Re: [PATCH v2 01/11] pwm: Make .get_state() callback return an error code

2022-12-01 Thread Neil Armstrong
On 30/11/2022 16:21, Uwe Kleine-König wrote: .get_state() might fail in some cases. To make it possible that a driver signals such a failure change the prototype of .get_state() to return an error code. This patch was created using coccinelle and the following semantic patch: @p1@ identifier ge

[PATCH] gpu: host1x: Remove redundant null checks before kfree

2022-12-01 Thread zys . zljxml
From: Yushan Zhou Fix the following coccicheck warning: ./drivers/gpu/host1x/fence.c:97:2-7: WARNING: NULL check before some freeing functions is not needed. Signed-off-by: Yushan Zhou --- drivers/gpu/host1x/fence.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/

Re: [PATCH] net: tun: Remove redundant null checks before kfree

2022-12-01 Thread Katrin Jo
On Wed, Nov 30, 2022 at 9:57 PM Simon Horman wrote: > > + Thierry Reding, linux-tegra, dri-devel > > On Tue, Nov 29, 2022 at 04:43:29PM +0800, zys.zlj...@gmail.com wrote: > > From: Yushan Zhou > > > > Fix the following coccicheck warning: > > ./drivers/gpu/host1x/fence.c:97:2-7: WARNING: > > NULL

Re: Screen corruption using radeon kernel driver

2022-12-01 Thread Mikhail Krylov
On Wed, Nov 30, 2022 at 11:07:32AM -0500, Alex Deucher wrote: > On Wed, Nov 30, 2022 at 10:42 AM Robin Murphy wrote: > > > > On 2022-11-30 14:28, Alex Deucher wrote: > > > On Wed, Nov 30, 2022 at 7:54 AM Robin Murphy wrote: > > >> > > >> On 2022-11-29 17:11, Mikhail Krylov wrote: > > >>> On Tue,

Re: [PATCH v5 1/2] drm/fourcc: Add Synaptics VideoSmart tiled modifiers

2022-12-01 Thread Randy Li
Sent from my iPad > On Nov 30, 2022, at 7:30 PM, Daniel Vetter wrote: > > CAUTION: Email originated externally, do not click links or open attachments > unless you recognize the sender and know the content is safe. > > >> On Wed, Nov 30, 2022 at 05:21:48PM +0800, Hsia-Jun Li wrote: >> Fro

Re: [PATCH v2 01/11] pwm: Make .get_state() callback return an error code

2022-12-01 Thread Baolin Wang
On 11/30/2022 11:21 PM, Uwe Kleine-König wrote: diff --git a/drivers/pwm/pwm-sprd.c b/drivers/pwm/pwm-sprd.c index 7004f55bbf11..bda8bc5af976 100644 --- a/drivers/pwm/pwm-sprd.c +++ b/drivers/pwm/pwm-sprd.c @@ -65,8 +65,8 @@ static void sprd_pwm_write(struct sprd_pwm_chip *spc, u32 hwid,

Re: [PATCH] drm: bridge: dw_hdmi: fix preference of RGB modes over YUV420

2022-12-01 Thread Neil Armstrong
Hi, On Wed, 16 Nov 2022 15:35:23 +0100, Guillaume BRUN wrote: > Cheap monitors sometimes advertise YUV modes they don't really have > (HDMI specification mandates YUV support so even monitors without actual > support will often wrongfully advertise it) which results in YUV matches > and user forum

Re: [PATCH v2 0/6] drm/gud: Use the shadow plane helper

2022-12-01 Thread Greg KH
On Wed, Nov 30, 2022 at 08:26:48PM +0100, Noralf Trønnes via B4 Submission Endpoint wrote: > Hi, > > I have started to look at igt for testing and want to use CRC tests. To > implement support for this I need to move away from the simple kms > helper. > > When looking around for examples I came

Re: [PATCH] gpu: host1x: Remove redundant null checks before kfree

2022-12-01 Thread Mikko Perttunen
On 12/1/22 03:55, zys.zlj...@gmail.com wrote: From: Yushan Zhou Fix the following coccicheck warning: ./drivers/gpu/host1x/fence.c:97:2-7: WARNING: NULL check before some freeing functions is not needed. Signed-off-by: Yushan Zhou --- drivers/gpu/host1x/fence.c | 3 +-- 1 file changed, 1 i

Re: [PATCH RESEND2 v4 2/2] drm/meson: dw-hdmi: Use devm_regulator_*get_enable*()

2022-12-01 Thread Neil Armstrong
On 30/11/2022 10:23, Matti Vaittinen wrote: Simplify using the devm_regulator_get_enable_optional(). Also drop the now unused struct member 'hdmi_supply'. Signed-off-by: Matti Vaittinen Martin Blumenstingl Missing Acked-by, I'll add it while applying. Neil --- v4 resend 2: Respinning unc

Re: [PATCH] drm/etnaviv: print MMU exception cause

2022-12-01 Thread Philipp Zabel
On Mi, 2022-11-30 at 19:53 +0100, Lucas Stach wrote: From: Christian Gmeiner The MMU tells us the fault status. While the raw register value is already printed, it's a bit more user friendly to translate the fault reasons into human readable format. Signed-off-by: Christian Gmeiner Signed-off-b

Re: [PATCH RESEND2 v4 0/2] Use devm helpers for regulator get and enable

2022-12-01 Thread Neil Armstrong
Hi, On Wed, 30 Nov 2022 11:21:51 +0200, Matti Vaittinen wrote: > Simplify couple of drivers by using the new devm_regulator_*get_enable*() > > These patches were previously part of the series: > https://lore.kernel.org/lkml/cover.1660934107.git.mazziesacco...@gmail.com/ > "Devm helpers for regula

Re: [PATCH RESEND2 v4 2/2] drm/meson: dw-hdmi: Use devm_regulator_*get_enable*()

2022-12-01 Thread Matti Vaittinen
On 12/1/22 10:38, Neil Armstrong wrote: On 30/11/2022 10:23, Matti Vaittinen wrote: Simplify using the devm_regulator_get_enable_optional(). Also drop the now unused struct member 'hdmi_supply'. Signed-off-by: Matti Vaittinen Martin Blumenstingl Missing Acked-by, I'll add it while applying.

[PATCH v3 0/7] drm/vc4: dpi: Various improvements

2022-12-01 Thread Maxime Ripard
Hi, Those patches have been in the downstream RaspberryPi tree for a while and help to support more DPI displays. Let me know what you think, Maxime To: Emma Anholt To: Maxime Ripard To: David Airlie To: Daniel Vetter To: Eric Anholt To: Rob Herring Cc: linux-ker...@vger.kernel.org Cc: dri

[PATCH v3 1/7] media: uapi: add MEDIA_BUS_FMT_RGB565_1X24_CPADHI

2022-12-01 Thread Maxime Ripard
From: Chris Morgan Add the MEDIA_BUS_FMT_RGB565_1X24_CPADHI format used by the Geekworm MZP280 panel for the Raspberry Pi. Signed-off-by: Chris Morgan Reviewed-by: Laurent Pinchart Signed-off-by: Maxime Ripard --- .../userspace-api/media/v4l/subdev-formats.rst | 37 ++

[PATCH v3 2/7] media: uapi: add MEDIA_BUS_FMT_BGR666_1X18

2022-12-01 Thread Maxime Ripard
From: Joerg Quinten Add the BGR666 format MEDIA_BUS_FMT_BGR666_1X18 supported by the RaspberryPi. Signed-off-by: Joerg Quinten Reviewed-by: Laurent Pinchart Signed-off-by: Maxime Ripard --- .../userspace-api/media/v4l/subdev-formats.rst | 37 ++ include/uapi/linux/med

[PATCH v3 3/7] media: uapi: add MEDIA_BUS_FMT_BGR666_1X24_CPADHI

2022-12-01 Thread Maxime Ripard
From: Joerg Quinten Add the BGR666 format MEDIA_BUS_FMT_BGR666_1X24_CPADHI supported by the RaspberryPi. Signed-off-by: Joerg Quinten Signed-off-by: Maxime Ripard --- .../userspace-api/media/v4l/subdev-formats.rst | 37 ++ include/uapi/linux/media-bus-format.h

[PATCH v3 4/7] drm/vc4: dpi: Support RGB565 format

2022-12-01 Thread Maxime Ripard
From: Chris Morgan The RGB565 format with padding over 24 bits (MEDIA_BUS_FMT_RGB565_1X24_CPADHI) is supported by the vc4 DPI controller. This is what the Geekworm MZP280 DPI display uses, so let's add support for it in the DPI controller driver. Reviewed-by: Dave Stevenson Signed-off-by: Chris

[PATCH v3 5/7] drm/vc4: dpi: Support BGR666 formats

2022-12-01 Thread Maxime Ripard
From: Joerg Quinten The VC4 DPI output can support multiple BGR666 variants, but they were never added to the driver. Let's add the the support for those formats. Signed-off-by: Joerg Quinten Reviewed-by: Laurent Pinchart Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_dpi.c | 6 +++

[PATCH v3 6/7] drm/vc4: dpi: Change the default DPI format to being 18bpp, not 24.

2022-12-01 Thread Maxime Ripard
From: Dave Stevenson DPI hasn't really been used up until now, so the default has been meaningless. In theory we should be able to pass the desired format for the adjacent bridge chip through, but framework seems to be missing for that. As the main device to use DPI is the VGA666 or Adafruit Kip

[PATCH v3 7/7] drm/vc4: dpi: Fix format mapping for RGB565

2022-12-01 Thread Maxime Ripard
From: Dave Stevenson The mapping is incorrect for RGB565_1X16 as it should be DPI_FORMAT_18BIT_666_RGB_1 instead of DPI_FORMAT_18BIT_666_RGB_3. Fixes: 08302c35b59d ("drm/vc4: Add DPI driver") Signed-off-by: Dave Stevenson Reviewed-by: Laurent Pinchart Signed-off-by: Maxime Ripard --- drivers

[PULL] drm-intel-fixes

2022-12-01 Thread Tvrtko Ursulin
Hi Dave, Daniel, A few more small fixes for the release candidate week. Fixes for confused return values when waiting on request retirement, which can explode in the GuC backend, fix for reading on DRAM info data and a fix to filter out impossible display pipes from the bigjoiner code. Regards,

Re: [PATCH v2 4/6] drm/gud: Prepare buffer for CPU access in gud_flush_work()

2022-12-01 Thread Thomas Zimmermann
Am 30.11.22 um 20:26 schrieb Noralf Trønnes via B4 Submission Endpoint: From: Noralf Trønnes In preparation for moving to the shadow plane helper prepare the framebuffer for CPU access as early as possible. v2: - Use src as variable name for iosys_map (Thomas) Reviewed-by: Javier Martinez C

Re: [PATCH v2 5/6] drm/gud: Use the shadow plane helper

2022-12-01 Thread Thomas Zimmermann
Am 30.11.22 um 20:26 schrieb Noralf Trønnes via B4 Submission Endpoint: From: Noralf Trønnes Use the shadow plane helper to take care of mapping the framebuffer for CPU access. The synchronous flushing is now done inline without the use of a worker. The async path now uses a shadow buffer to

Re: [PATCH v2 6/6] drm/gud: Enable synchronous flushing by default

2022-12-01 Thread Thomas Zimmermann
Am 30.11.22 um 20:26 schrieb Noralf Trønnes via B4 Submission Endpoint: From: Noralf Trønnes gud has a module parameter that controls whether framebuffer flushing happens synchronously during the commit or asynchronously in a worker. GNOME before version 3.38 handled all displays in the same

Re: [Intel-gfx] [PATCH v4 3/5] drm/i915: Introduce guard pages to i915_vma

2022-12-01 Thread Tvrtko Ursulin
On 30/11/2022 23:58, Andi Shyti wrote: From: Chris Wilson Introduce the concept of padding the i915_vma with guard pages before and after. The major consequence is that all ordinary uses of i915_vma must use i915_vma_offset/i915_vma_size and not i915_vma.node.start/size directly, as the drm_m

Re: [Intel-gfx] [PATCH v4 4/5] drm/i915: Refine VT-d scanout workaround

2022-12-01 Thread Tvrtko Ursulin
On 30/11/2022 23:58, Andi Shyti wrote: From: Chris Wilson VT-d may cause overfetch of the scanout PTE, both before and after the vma (depending on the scanout orientation). bspec recommends that we provide a tile-row in either directions, and suggests using 168 PTE, warning that the accesses

Re: [Intel-gfx] [PATCH v4 5/5] Revert "drm/i915: Improve on suspend / resume time with VT-d enabled"

2022-12-01 Thread Tvrtko Ursulin
On 30/11/2022 23:58, Andi Shyti wrote: This reverts commit 2ef6efa79fecd5e3457b324155d35524d95f2b6b. Checking the presence if the IRST (Intel Rapid Start Technology) through the ACPI to decide whether to rebuild or not the GGTT puts us at the mercy of the boot firmware and we need to unnecessa

[PATCH] drm/tests: probe_helper: Fix unitialized variable

2022-12-01 Thread Maxime Ripard
The len variable is used while uninitialized. Initialize it. Fixes: 1e4a91db109f ("drm/probe-helper: Provide a TV get_modes helper") Reported-by: kernel test robot Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_probe_helper_test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/

Re: [PATCH] drm/etnaviv: print MMU exception cause

2022-12-01 Thread Lucas Stach
Hi Philipp, Am Donnerstag, dem 01.12.2022 um 09:40 +0100 schrieb Philipp Zabel: > On Mi, 2022-11-30 at 19:53 +0100, Lucas Stach wrote: > From: Christian Gmeiner > > The MMU tells us the fault status. While the raw register value is > already printed, it's a bit more user friendly to translate th

Re: [PATCH v2 4/7] arm64: dts: renesas: r8a779g0: Add display related nodes

2022-12-01 Thread Geert Uytterhoeven
On Wed, Nov 23, 2022 at 8:00 AM Tomi Valkeinen wrote: > Add DT nodes for components needed to get the DSI output working: > - FCPv > - VSPd > - DU > - DSI > > Signed-off-by: Tomi Valkeinen > Reviewed-by: Kieran Bingham > Reviewed-by: Laurent Pinchart Reviewed-by: Geert Uytterhoeven i.e. will

[PATCH v4 0/7] Support for the NPU in Vim3

2022-12-01 Thread Tomeu Vizoso
Hi, This series adds support for the Verisilicon VIPNano-QI NPU in the A311D as in the VIM3 board. The IP is very closely based on previous Vivante GPUs, so the etnaviv kernel driver works basically unchanged. The userspace part of the driver is being reviewed at: https://gitlab.freedesktop.org

[PATCH v4 5/7] drm/etnaviv: add HWDB entry for VIPNano-QI.7120.0055

2022-12-01 Thread Tomeu Vizoso
This is a compute-only module marketed towards AI and vision acceleration. This particular version can be found on the Amlogic A311D SoC. The feature bits are taken from the Khadas downstream kernel driver 6.4.4.3.310723AAA. Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/etnaviv/etnaviv_hwdb.c

[PATCH v4 7/7] drm/etnaviv: Warn when probing on NPUs

2022-12-01 Thread Tomeu Vizoso
Userspace is still not making full use of the hardware, so we don't know yet if changes to the UAPI won't be needed. Warn about it. Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c

[PATCH v4 6/7] drm/etnaviv: Add nn_core_count to chip feature struct

2022-12-01 Thread Tomeu Vizoso
We will use these for differentiating between GPUs and NPUs, as the downstream driver does. Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/etnaviv/etnaviv_gpu.h | 3 +++ drivers/gpu/drm/etnaviv/etnaviv_hwdb.c | 5 + 2 files changed, 8 insertions(+) diff --git a/drivers/gpu/drm/etnaviv/etn

Re: [PATCH v3 5/5] drm/i915/mtl: Hold forcewake and MCR lock over PPAT setup

2022-12-01 Thread Balasubramani Vivekanandan
On 30.11.2022 07:58, Matt Roper wrote: > PPAT setup involves a series of multicast writes. This can be optimized > slightly be acquiring forcewake and the steering lock just once for the > entire sequence. > > v2: > - We should use FW_REG_WRITE instead of FW_REG_READ. (Bala) > > Suggested-by:

Re: [PATCH v2 3/7] clk: renesas: r8a779g0: Add display related clocks

2022-12-01 Thread Geert Uytterhoeven
Hi Tomi, On Thu, Dec 1, 2022 at 10:06 AM Tomi Valkeinen wrote: > On 30/11/2022 21:18, Geert Uytterhoeven wrote: > > On Wed, Nov 23, 2022 at 8:00 AM Tomi Valkeinen > > wrote: > >> Add clocks related to display which are needed to get the DSI output > >> working. > >> > >> Extracted from Renesas B

Re: [PATCH v5 1/2] drm/fourcc: Add Synaptics VideoSmart tiled modifiers

2022-12-01 Thread Daniel Vetter
On Thu, Dec 01, 2022 at 12:49:16AM +0800, Randy Li wrote: > > > Sent from my iPad > > > On Nov 30, 2022, at 7:30 PM, Daniel Vetter wrote: > > > > CAUTION: Email originated externally, do not click links or open > > attachments unless you recognize the sender and know the content is safe. > >

Re: [PATCH v2 3/7] clk: renesas: r8a779g0: Add display related clocks

2022-12-01 Thread Geert Uytterhoeven
Hi Tomi, On Thu, Dec 1, 2022 at 10:26 AM Tomi Valkeinen wrote: > On 30/11/2022 21:18, Geert Uytterhoeven wrote: > > On Wed, Nov 23, 2022 at 8:00 AM Tomi Valkeinen > > wrote: > >> Add clocks related to display which are needed to get the DSI output > >> working. > >> > >> Extracted from Renesas B

Re: [PATCH v4 5/7] drm/etnaviv: add HWDB entry for VIPNano-QI.7120.0055

2022-12-01 Thread Lucas Stach
Hi Tomeu, the changes itself look good to me now, I was just very confused about the ordering of the patches. I would have expected them to be in this order: 1. Add NN cores to chip identities struct (set to 0 for all existing entries in HWDB) 2. Add UAPI warning 3. Add HWDB entry for VIPNano-QI.

Re: [PATCH 1/3] drm/doc: Fix title underline length

2022-12-01 Thread Javier Martinez Canillas
On 11/28/22 09:19, Maxime Ripard wrote: > The underline length for the new Analog TV properties section doesn't > match the title length, resulting in a warning. > > Fixes: 7d63cd8526f1 ("drm/connector: Add TV standard property") > Reported-by: kernel test robot > Signed-off-by: Maxime Ripard >

Re: [PATCH 2/3] drm/modes: Use strscpy() to copy command-line mode name

2022-12-01 Thread Javier Martinez Canillas
On 11/28/22 09:19, Maxime Ripard wrote: > The mode name in struct drm_cmdline_mode can hold 32 characters at most, > which can easily get overrun. Switch to strscpy() to prevent such a > thing. > > Reported-by: coverity-bot > Addresses-Coverity-ID: 1527354 ("Security best practices violations") >

Re: [PATCH v3 3/7] media: uapi: add MEDIA_BUS_FMT_BGR666_1X24_CPADHI

2022-12-01 Thread Laurent Pinchart
Hi Maxime, Thank you for the patch. On Thu, Dec 01, 2022 at 09:42:48AM +0100, Maxime Ripard wrote: > From: Joerg Quinten > > Add the BGR666 format MEDIA_BUS_FMT_BGR666_1X24_CPADHI supported by the > RaspberryPi. > > Signed-off-by: Joerg Quinten > Signed-off-by: Maxime Ripard Reviewed-by: La

Re: [PATCH] drm/tests: probe_helper: Fix unitialized variable

2022-12-01 Thread Javier Martinez Canillas
On 12/1/22 10:07, Maxime Ripard wrote: > The len variable is used while uninitialized. Initialize it. > > Fixes: 1e4a91db109f ("drm/probe-helper: Provide a TV get_modes helper") > Reported-by: kernel test robot > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/tests/drm_probe_helper_test.c

Re: [PATCH v2 0/6] drm/gud: Use the shadow plane helper

2022-12-01 Thread Noralf Trønnes
Den 01.12.2022 06.55, skrev Greg KH: > On Wed, Nov 30, 2022 at 08:26:48PM +0100, Noralf Trønnes via B4 Submission > Endpoint wrote: >> Hi, >> >> I have started to look at igt for testing and want to use CRC tests. To >> implement support for this I need to move away from the simple kms >> helpe

Re: [PATCH v2 5/7] arm64: dts: renesas: white-hawk-cpu: Add DP output support

2022-12-01 Thread Geert Uytterhoeven
Hi Tomi, On Wed, Nov 23, 2022 at 8:00 AM Tomi Valkeinen wrote: > Add DT nodes needed for the mini DP connector. The DP is driven by > sn65dsi86, which in turn gets the pixel data from the SoC via DSI. > > Signed-off-by: Tomi Valkeinen > Reviewed-by: Kieran Bingham > Reviewed-by: Laurent Pinchar

Re: [PATCH] drm/fourcc: Document open source user waiver

2022-12-01 Thread Daniel Vetter
On Wed, Nov 23, 2022 at 08:24:37PM +0100, Daniel Vetter wrote: > It's a bit a FAQ, and we really can't claim to be the authoritative > source for allocating these numbers used in many standard extensions > if we tell closed source or vendor stacks in general to go away. > > Iirc this was already c

Re: [PATCH v7 20/20] drm/i915/vm_bind: Async vm_unbind support

2022-12-01 Thread Matthew Auld
On 29/11/2022 23:26, Niranjana Vishwanathapura wrote: On Wed, Nov 23, 2022 at 11:42:58AM +, Matthew Auld wrote: On 16/11/2022 00:37, Niranjana Vishwanathapura wrote: On Tue, Nov 15, 2022 at 03:15:03PM -0800, Niranjana Vishwanathapura wrote: On Tue, Nov 15, 2022 at 08:33:47AM -0800, Niranjan

Re: [PATCH 1/3] drm/doc: Fix title underline length

2022-12-01 Thread Maxime Ripard
On Mon, 28 Nov 2022 09:19:36 +0100, Maxime Ripard wrote: > The underline length for the new Analog TV properties section doesn't > match the title length, resulting in a warning. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: [PATCH] drm/tests: probe_helper: Fix unitialized variable

2022-12-01 Thread Maxime Ripard
On Thu, 1 Dec 2022 10:07:36 +0100, Maxime Ripard wrote: > The len variable is used while uninitialized. Initialize it. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: [PATCH v3 0/7] drm/vc4: dpi: Various improvements

2022-12-01 Thread Maxime Ripard
On Thu, 01 Dec 2022 09:42:45 +0100, Maxime Ripard wrote: > Those patches have been in the downstream RaspberryPi tree for a while and > help > to support more DPI displays. > > Let me know what you think, > Maxime > > > [...] Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Look for a guilty context when an engine reset fails

2022-12-01 Thread Tvrtko Ursulin
On 30/11/2022 21:04, John Harrison wrote: On 11/30/2022 00:30, Tvrtko Ursulin wrote: On 29/11/2022 21:12, john.c.harri...@intel.com wrote: From: John Harrison Engine resets are supposed to never happen. But in the case when one Engine resets or engine reset failures? Hopefully the latter.

Re: [PATCH] drm/fourcc: Document open source user waiver

2022-12-01 Thread Daniel Vetter
On Thu, 1 Dec 2022 at 11:07, Daniel Vetter wrote: > > On Wed, Nov 23, 2022 at 08:24:37PM +0100, Daniel Vetter wrote: > > It's a bit a FAQ, and we really can't claim to be the authoritative > > source for allocating these numbers used in many standard extensions > > if we tell closed source or vend

Re: [PATCH v2 01/11] pwm: Make .get_state() callback return an error code

2022-12-01 Thread Andre Przywara
On Wed, 30 Nov 2022 16:21:38 +0100 Uwe Kleine-König wrote: Hi, > .get_state() might fail in some cases. To make it possible that a driver > signals such a failure change the prototype of .get_state() to return an > error code. > > This patch was created using coccinelle and the following semant

Re: [PATCH v2 01/17] drm/tests: helpers: Move the helper header to include/drm

2022-12-01 Thread Maxime Ripard
Hi Javier, On Wed, Nov 30, 2022 at 09:00:03AM +0100, Javier Martinez Canillas wrote: > On 11/28/22 15:53, Maxime Ripard wrote: > > We'll need to use those helpers from drivers too, so let's move it to a > > more visible location. > > > > Signed-off-by: Maxime Ripard > > --- > > drivers/gpu/drm/

[PATCH v5 0/7] Support for the NPU in Vim3

2022-12-01 Thread Tomeu Vizoso
Hi, This series adds support for the Verisilicon VIPNano-QI NPU in the A311D as in the VIM3 board. The IP is very closely based on previous Vivante GPUs, so the etnaviv kernel driver works basically unchanged. The userspace part of the driver is being reviewed at: https://gitlab.freedesktop.org

[PATCH v5 5/7] drm/etnaviv: Add nn_core_count to chip feature struct

2022-12-01 Thread Tomeu Vizoso
We will use these for differentiating between GPUs and NPUs, as the downstream driver does. Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/etnaviv/etnaviv_gpu.h | 3 +++ drivers/gpu/drm/etnaviv/etnaviv_hwdb.c | 4 2 files changed, 7 insertions(+) diff --git a/drivers/gpu/drm/etnaviv/etna

[PATCH v5 6/7] drm/etnaviv: Warn when probing on NPUs

2022-12-01 Thread Tomeu Vizoso
Userspace is still not making full use of the hardware, so we don't know yet if changes to the UAPI won't be needed. Warn about it. Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c

[PATCH v5 7/7] drm/etnaviv: add HWDB entry for VIPNano-QI.7120.0055

2022-12-01 Thread Tomeu Vizoso
This is a compute-only module marketed towards AI and vision acceleration. This particular version can be found on the Amlogic A311D SoC. The feature bits are taken from the Khadas downstream kernel driver 6.4.4.3.310723AAA. Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/etnaviv/etnaviv_hwdb.c

Re: [PATCH v2 01/12] dt-bindings: display: msm: Rename mdss node name in example

2022-12-01 Thread Krzysztof Kozlowski
On 30/11/2022 21:09, Adam Skladowski wrote: > Follow other YAMLs and replace mdss name into display-subystem. > > Signed-off-by: Adam Skladowski Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 11/12] arm64: dts: qcom: sm6115: Add WCN node.

2022-12-01 Thread Krzysztof Kozlowski
On 30/11/2022 21:09, Adam Skladowski wrote: > Add WCN node to allow using wifi module. > A nit: Drop full stop from commit subject. Best regards, Krzysztof

Re: [PATCH v2 01/17] drm/tests: helpers: Move the helper header to include/drm

2022-12-01 Thread Javier Martinez Canillas
Hello Maxime, On 12/1/22 11:27, Maxime Ripard wrote: [...] >> >> I wonder if now that this header was moved outside of the tests directory, >> if we should add stub functions in the header file that are just defined >> but do nothing if CONFIG_DRM_KUNIT_TEST isn't enabled. So that including >> i

Re: [PATCH v2 01/11] pwm: Make .get_state() callback return an error code

2022-12-01 Thread Dave Stevenson
On Wed, 30 Nov 2022 at 15:23, Uwe Kleine-König wrote: > > .get_state() might fail in some cases. To make it possible that a driver > signals such a failure change the prototype of .get_state() to return an > error code. > > This patch was created using coccinelle and the following semantic patch:

Re: [Intel-gfx] [PATCH v4 3/5] drm/i915: Introduce guard pages to i915_vma

2022-12-01 Thread Andi Shyti
Hi Tvrtko, [...] > > @@ -768,8 +773,17 @@ i915_vma_insert(struct i915_vma *vma, struct > > i915_gem_ww_ctx *ww, > > GEM_BUG_ON(!IS_ALIGNED(alignment, I915_GTT_MIN_ALIGNMENT)); > > GEM_BUG_ON(!is_power_of_2(alignment)); > > + guard = vma->guard; /* retain guard across rebinds */ > > +

Re: [PATCH v8 22/22] drm/i915/vm_bind: Support capture of persistent mappings

2022-12-01 Thread Matthew Auld
On 29/11/2022 07:26, Niranjana Vishwanathapura wrote: Support dump capture of persistent mappings upon user request. Signed-off-by: Brian Welty Signed-off-by: Niranjana Vishwanathapura --- .../drm/i915/gem/i915_gem_vm_bind_object.c| 11 +++ drivers/gpu/drm/i915/gt/intel_gtt.c

Re: [Intel-gfx] [PATCH v4 3/5] drm/i915: Introduce guard pages to i915_vma

2022-12-01 Thread Tvrtko Ursulin
On 01/12/2022 10:45, Andi Shyti wrote: Hi Tvrtko, [...] @@ -768,8 +773,17 @@ i915_vma_insert(struct i915_vma *vma, struct i915_gem_ww_ctx *ww, GEM_BUG_ON(!IS_ALIGNED(alignment, I915_GTT_MIN_ALIGNMENT)); GEM_BUG_ON(!is_power_of_2(alignment)); + guard = vma->guard; /* re

Re: [RFC 3/3] drm: Update file owner during use

2022-12-01 Thread Tvrtko Ursulin
On 30/11/2022 14:18, Daniel Vetter wrote: On Wed, Nov 30, 2022 at 01:34:07PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin With the typical model where the display server opends the file descriptor and then hands it over to the client we were showing stale data in debugfs. Fix it by upd

Re: [PATCH v2 00/11] pwm: Allow .get_state to fail

2022-12-01 Thread Conor Dooley
Hey Uwe! On Wed, Nov 30, 2022 at 04:21:37PM +0100, Uwe Kleine-König wrote: > Hello, > > I forgot about this series and was remembered when I talked to Conor > Dooley about how .get_state() should behave in an error case. In the context of "my" driver, get_state() the proposal was to fail with -E

Re: [PATCH v28 05/11] soc: mediatek: refine code to use mtk_mmsys_update_bits API

2022-12-01 Thread Chen-Yu Tsai
On Mon, Nov 7, 2022 at 3:23 PM Nancy.Lin wrote: > > Simplify code for update mmsys reg. > > Signed-off-by: Nancy.Lin > Reviewed-by: AngeloGioacchino Del Regno > > Reviewed-by: CK Hu > Tested-by: AngeloGioacchino Del Regno > > Tested-by: Bo-Chen Chen > Reviewed-by: Nícolas F. R. A. Prado >

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915/guc: Add GuC CT specific debug print wrappers

2022-12-01 Thread Michal Wajdeczko
On 01.12.2022 01:41, John Harrison wrote: > On 11/23/2022 12:45, Michal Wajdeczko wrote: >> On 23.11.2022 02:25, John Harrison wrote: >>> On 11/22/2022 09:54, Michal Wajdeczko wrote: On 18.11.2022 02:58, john.c.harri...@intel.com wrote: > From: John Harrison > > Re-work the exi

Re: [PATCH v5 7/7] drm: rcar-du: dsi: Add r8A779g0 support

2022-12-01 Thread Kieran Bingham
Quoting Tomi Valkeinen (2022-12-01 09:56:31) > Add DSI support for r8a779g0. The main differences to r8a779a0 are in > the PLL and PHTW setups. > > Signed-off-by: Tomi Valkeinen > Reviewed-by: Laurent Pinchart Now that the differences I saw about the PHTW values are understood, I'm happy. I li

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915/guc: Add GuC CT specific debug print wrappers

2022-12-01 Thread Tvrtko Ursulin
On 01/12/2022 11:56, Michal Wajdeczko wrote: On 01.12.2022 01:41, John Harrison wrote: On 11/23/2022 12:45, Michal Wajdeczko wrote: On 23.11.2022 02:25, John Harrison wrote: On 11/22/2022 09:54, Michal Wajdeczko wrote: On 18.11.2022 02:58, john.c.harri...@intel.com wrote: From: John Harris

Re: [PATCH v2 0/6] drm/gud: Use the shadow plane helper

2022-12-01 Thread Greg KH
On Thu, Dec 01, 2022 at 11:00:44AM +0100, Noralf Trønnes wrote: > > > Den 01.12.2022 06.55, skrev Greg KH: > > On Wed, Nov 30, 2022 at 08:26:48PM +0100, Noralf Trønnes via B4 Submission > > Endpoint wrote: > >> Hi, > >> > >> I have started to look at igt for testing and want to use CRC tests. To

[PATCH 2/3] drm/i915: export all mock selftest functions

2022-12-01 Thread Mauro Carvalho Chehab
In order to prepare for a new KUnit module that will run selftests, export all mock selftest functions to I915_SELFTEST namespace. No functional changes. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PA

[PATCH 1/3] drm/i915: place selftest preparation on a separate function

2022-12-01 Thread Mauro Carvalho Chehab
The selftest preparation logic should also be used by KUnit. So, place it on a separate function and export it. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH 0/3] at: https://lore.kernel.org/all/c

[PATCH 3/3] drm/i915: allow running mock selftests via Kunit

2022-12-01 Thread Mauro Carvalho Chehab
The mock selftests don't require any hardware to run. They can easily run via kunit with qemu or bare metal. Add support for it. With this change, mock selftest can now run in qemu with: $ ./tools/testing/kunit/kunit.py run --arch=x86_64 \ --kunitconfig=drivers/gpu/drm/i9

[PATCH 0/3] Add KUnit support for i915 mock selftests

2022-12-01 Thread Mauro Carvalho Chehab
That's an updated version of my previous KUnit RFC series: https://patchwork.freedesktop.org/series/110481/ While the RFC series added support for live and perf, let's start with mock, as running tests in bare metal is not the current focus of KUnit. So, basically patch 1 was changed to ex

Re: [PATCH v2 15/17] drm/vc4: tests: Introduce a mocking infrastructure

2022-12-01 Thread Maxime Ripard
Hi Javier, On Wed, Nov 30, 2022 at 10:59:37AM +0100, Javier Martinez Canillas wrote: > On 11/28/22 15:53, Maxime Ripard wrote: > > In order to test the current atomic_check hooks we need to have a DRM > > device that has roughly the same capabilities and layout that the actual > > hardware. We'll

Re: [PATCH v2 0/6] drm/gud: Use the shadow plane helper

2022-12-01 Thread Noralf Trønnes
Den 01.12.2022 13.12, skrev Greg KH: > On Thu, Dec 01, 2022 at 11:00:44AM +0100, Noralf Trønnes wrote: >> >> >> Den 01.12.2022 06.55, skrev Greg KH: >>> On Wed, Nov 30, 2022 at 08:26:48PM +0100, Noralf Trønnes via B4 Submission >>> Endpoint wrote: Hi, I have started to look at ig

Re: [PATCH v2 01/11] pwm: Make .get_state() callback return an error code

2022-12-01 Thread Uwe Kleine-König
Hello Andre, On Thu, Dec 01, 2022 at 10:22:52AM +, Andre Przywara wrote: > Just one comment: I don't see a sunxi specific patch later in the series, > though it seems we have at least one error error exit (see prescaler == 0 > above). Plus potentially another exit if clk_get_rate() (at the ver

Re: [PATCH v2 00/11] pwm: Allow .get_state to fail

2022-12-01 Thread Uwe Kleine-König
Hello Conor, On Thu, Dec 01, 2022 at 11:11:51AM +, Conor Dooley wrote: > TL;DR, I quite like the ability to return an error and not mislead the > caller. Is this an Ack? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solution

Re: [PATCH v2 0/6] drm/gud: Use the shadow plane helper

2022-12-01 Thread Greg KH
On Thu, Dec 01, 2022 at 02:14:42PM +0100, Noralf Trønnes wrote: > > > Den 01.12.2022 13.12, skrev Greg KH: > > On Thu, Dec 01, 2022 at 11:00:44AM +0100, Noralf Trønnes wrote: > >> > >> > >> Den 01.12.2022 06.55, skrev Greg KH: > >>> On Wed, Nov 30, 2022 at 08:26:48PM +0100, Noralf Trønnes via B4

Re: [PATCH v2 0/6] drm/gud: Use the shadow plane helper

2022-12-01 Thread Javier Martinez Canillas
Hello Greg, On 12/1/22 14:21, Greg KH wrote: [...] This patchset was sent using the b4 tool and I can't control this aspect. Everyone mentioned in the patches gets the whole set. >>> >>> Fair enough, but watch out, bots will report this as being a problem as >>> they can't always read

Re: [PATCH v2 00/11] pwm: Allow .get_state to fail

2022-12-01 Thread Conor Dooley
On Thu, Dec 01, 2022 at 02:19:07PM +0100, Uwe Kleine-König wrote: > Hello Conor, > > On Thu, Dec 01, 2022 at 11:11:51AM +, Conor Dooley wrote: > > TL;DR, I quite like the ability to return an error and not mislead the > > caller. > > Is this an Ack? It is if you want it to be! I didn't reall

Re: Screen corruption using radeon kernel driver

2022-12-01 Thread Robin Murphy
On 2022-11-30 19:59, Mikhail Krylov wrote: On Wed, Nov 30, 2022 at 11:07:32AM -0500, Alex Deucher wrote: On Wed, Nov 30, 2022 at 10:42 AM Robin Murphy wrote: On 2022-11-30 14:28, Alex Deucher wrote: On Wed, Nov 30, 2022 at 7:54 AM Robin Murphy wrote: On 2022-11-29 17:11, Mikhail Krylov wr

Re: Screen corruption using radeon kernel driver

2022-12-01 Thread Alex Deucher
On Thu, Dec 1, 2022 at 9:01 AM Robin Murphy wrote: > > On 2022-11-30 19:59, Mikhail Krylov wrote: > > On Wed, Nov 30, 2022 at 11:07:32AM -0500, Alex Deucher wrote: > >> On Wed, Nov 30, 2022 at 10:42 AM Robin Murphy wrote: > >>> > >>> On 2022-11-30 14:28, Alex Deucher wrote: > On Wed, Nov 30,

Re: [PATCH v2 0/6] drm/gud: Use the shadow plane helper

2022-12-01 Thread Konstantin Ryabitsev
On Thu, Dec 01, 2022 at 02:34:41PM +0100, Javier Martinez Canillas wrote: > >> Konstantin, > >> > >> Can you add a rule in b4 to exclude sta...@vger.kernel.org > >> (sta...@kernel.org as well?) from getting the whole patchset? > > > > sta...@kernel.org is a pipe to /dev/null so that's not needed t

Re: [PATCH v2 01/11] pwm: Make .get_state() callback return an error code

2022-12-01 Thread Andre Przywara
On Thu, 1 Dec 2022 14:16:04 +0100 Uwe Kleine-König wrote: Hi Uwe, > Hello Andre, > > On Thu, Dec 01, 2022 at 10:22:52AM +, Andre Przywara wrote: > > Just one comment: I don't see a sunxi specific patch later in the series, > > though it seems we have at least one error error exit (see presc

Re: [PATCH v2 0/6] drm/gud: Use the shadow plane helper

2022-12-01 Thread Javier Martinez Canillas
On 12/1/22 15:16, Konstantin Ryabitsev wrote: > On Thu, Dec 01, 2022 at 02:34:41PM +0100, Javier Martinez Canillas wrote: Konstantin, Can you add a rule in b4 to exclude sta...@vger.kernel.org (sta...@kernel.org as well?) from getting the whole patchset? >>> >>> sta...@kernel.

Re: [PATCH v2 0/6] drm/gud: Use the shadow plane helper

2022-12-01 Thread Vlastimil Babka
On 12/1/22 15:16, Konstantin Ryabitsev wrote: On Thu, Dec 01, 2022 at 02:34:41PM +0100, Javier Martinez Canillas wrote: Konstantin, Can you add a rule in b4 to exclude sta...@vger.kernel.org (sta...@kernel.org as well?) from getting the whole patchset? sta...@kernel.org is a pipe to /dev/null

Re: [PATCH v2 0/6] drm/gud: Use the shadow plane helper

2022-12-01 Thread Mark Brown
On Thu, Dec 01, 2022 at 03:27:32PM +0100, Vlastimil Babka wrote: > I usually do that with git send-email and a custom --cc-cmd script, but > additionally it sends the cover letter also to everyone that's on any > individual patch's Cc, so everyone gets at least the cover letter + their > specific

[PATCH v5 3/5] drm/i915: Introduce guard pages to i915_vma

2022-12-01 Thread Andi Shyti
From: Chris Wilson Introduce the concept of padding the i915_vma with guard pages before and after. The major consequence is that all ordinary uses of i915_vma must use i915_vma_offset/i915_vma_size and not i915_vma.node.start/size directly, as the drm_mm_node will include the guard pages that su

Re: [Intel-gfx] [PATCH v5 3/5] drm/i915: Introduce guard pages to i915_vma

2022-12-01 Thread Tvrtko Ursulin
On 01/12/2022 14:44, Andi Shyti wrote: From: Chris Wilson Introduce the concept of padding the i915_vma with guard pages before and after. The major consequence is that all ordinary uses of i915_vma must use i915_vma_offset/i915_vma_size and not i915_vma.node.start/size directly, as the drm_m

Re: [PATCH v2 1/3] ASoC: hdmi-codec: Add event handler for hdmi TX

2022-12-01 Thread 俞家鑫

Re: [PATCH v7 20/20] drm/i915/vm_bind: Async vm_unbind support

2022-12-01 Thread Niranjana Vishwanathapura
On Thu, Dec 01, 2022 at 10:10:14AM +, Matthew Auld wrote: On 29/11/2022 23:26, Niranjana Vishwanathapura wrote: On Wed, Nov 23, 2022 at 11:42:58AM +, Matthew Auld wrote: On 16/11/2022 00:37, Niranjana Vishwanathapura wrote: On Tue, Nov 15, 2022 at 03:15:03PM -0800, Niranjana Vishwanath

[PATCH v3 01/20] drm/tests: helpers: Move the helper header to include/drm

2022-12-01 Thread Maxime Ripard
We'll need to use those helpers from drivers too, so let's move it to a more visible location. Reviewed-by: Javier Martinez Canillas Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_client_modeset_test.c| 3 +-- drivers/gpu/drm/tests/drm_kunit_helpers.c |

[PATCH v3 00/20] drm: Introduce Kunit Tests to VC4

2022-12-01 Thread Maxime Ripard
Hi, This series introduce Kunit tests to the vc4 KMS driver, but unlike what we have been doing so far in KMS, it actually tests the atomic modesetting code. In order to do so, I've had to improve a fair bit on the Kunit helpers already found in the tree in order to register a full blown and some

[PATCH v3 03/20] drm/tests: helpers: Document drm_kunit_device_init()

2022-12-01 Thread Maxime Ripard
Commit 44a3928324e9 ("drm/tests: Add Kunit Helpers") introduced the drm_kunit_device_init() function but didn't document it properly. Add that documentation. Reviewed-by: Maíra Canal Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_kunit_helpers.c | 17 + 1 file change

[PATCH v3 02/20] drm/tests: Introduce a config option for the KUnit helpers

2022-12-01 Thread Maxime Ripard
Driver-specific tests will need access to the helpers without pulling every DRM framework test. Let's create an intermediate Kconfig options for the helpers. Suggested-by: Maíra Canal Signed-off-by: Maxime Ripard --- drivers/gpu/drm/Kconfig| 7 +++ drivers/gpu/drm/Makefile | 2

[PATCH v3 04/20] drm/tests: helpers: Switch to EXPORT_SYMBOL_GPL

2022-12-01 Thread Maxime Ripard
drm_kunit_device_init() among other things will allocate a device and wrap around root_device_register. This function is exported with EXPORT_SYMBOL_GPL, so we can't really change the license. Fixes: 199557fab925 ("drm/tests: helpers: Add missing export") Suggested-by: Javier Martinez Canillas Si

  1   2   >