Re: [PATCH 2/2] drm/amdgpu: Fix PCI device refcount leak in amdgpu_atrm_get_bios()

2022-11-25 Thread Alex Deucher
Applied the series. Thanks! Alex On Tue, Nov 22, 2022 at 6:13 AM Xiongfeng Wang wrote: > > As comment of pci_get_class() says, it returns a pci_device with its > refcount increased and decreased the refcount for the input parameter > @from if it is not NULL. > > If we break the loop in amdgpu_a

Re: [Linaro-mm-sig] Re: [PATCH] dma-buf: A collection of typo and documentation fixes

2022-11-25 Thread T.J. Mercier
On Thu, Nov 24, 2022 at 1:43 AM Christian König wrote: > > Am 24.11.22 um 10:05 schrieb Daniel Vetter: > > On Thu, Nov 24, 2022 at 08:03:09AM +0100, Christian König wrote: > >> Am 23.11.22 um 20:35 schrieb T.J. Mercier: > >>> I've been collecting these typo fixes for a while and it feels like > >>

[PATCH v3 2/2] drm/modes: Add support for driver-specific named modes

2022-11-25 Thread Geert Uytterhoeven
The mode parsing code recognizes named modes only if they are explicitly listed in the internal named mode list, which is currently limited to "NTSC" and "PAL". Provide a mechanism for drivers to override this list to support custom modes. Ideally, this list should just come from the driver's act

[PATCH v3 0/2] drm/modes: Command line mode selection improvements

2022-11-25 Thread Geert Uytterhoeven
Hi all, This patch series contains improvements for specifying video modes on the kernel command line. I don't expect the second patch to be acceptable as-is, but it's a dependency for posting the RFC Atari DRM driver... Changes compared to v2[1]: - Drop applied and obsolete patches,

[PATCH/RFC 3/3] drm: atari: Add a DRM driver for Atari graphics hardware

2022-11-25 Thread Geert Uytterhoeven
Supported formats: - C[1248], - RG16 (both standard DRM (little-endian) and native (big-endian)), - XR24. RG16 and XR24 are only supported with the underlying RGB565 hardware mode on Falcon, and are subject to hardware restrictions (limited to e.g. "qvga" and "hvga" modes). All formats use

[PATCH/RFC 1/3] video: fbdev: c2p: Add transp2() and transp2x()

2022-11-25 Thread Geert Uytterhoeven
Add transpose operations on two 32-bit words, using normal or reverse order. To be used by the Atari DRM driver. Signed-off-by: Geert Uytterhoeven --- drivers/video/fbdev/c2p_core.h | 38 ++ 1 file changed, 38 insertions(+) diff --git a/drivers/video/fbdev/c2p_c

[PATCH v3 1/2] drm/modes: parse_cmdline: Make mode->*specified handling more uniform

2022-11-25 Thread Geert Uytterhoeven
The various mode->*specified flags are not handled in an uniform way: some flags are set by the corresponding drm_mode_parse_cmdline_*() function, some flags by the caller of the function, and some flags by both. Make this uniform by making this the responsibility of the various parsing helpers, i

[PATCH/RFC 2/3] drm/simple-kms-helper: Add mode_fixup() to simple display pipe

2022-11-25 Thread Geert Uytterhoeven
From: Thomas Zimmermann The mode fix-up function for simple display helpers is equivalent to the regular pipeline's CRTC mode fix-up function. It's called to adjust the CRTC's display mode for the encoder. Add this function for DRM fbconv helpers. Signed-off-by: Thomas Zimmermann Signed-off-by:

[PATCH/RFC 0/3] Atari DRM driver

2022-11-25 Thread Geert Uytterhoeven
Hi all, This RFC patch series adds a DRM driver for the good old Atari ST/TT/Falcon hardware. It was developed and tested (only) on the ARAnyM emulator. Supported formats: - C[1248], - RG16 (both standard DRM (little-endian) and native (big-endian)), - XR24. Patch overview: 1. T

[PATCH] drm/amd/display: fix PSR-SU/DSC interoperability support

2022-11-25 Thread Hamza Mahfooz
Currently, there are issues with enabling PSR-SU + DSC. This stems from the fact that DSC imposes a slice height on transmitted video data and we are not conforming to that slice height in PSR-SU regions. So, pass slice_height into su_y_granularity to feed the DSC slice height into PSR-SU code. Si

[PATCH -next] drm/amdgpu: update docum. filename following rename

2022-11-25 Thread Randy Dunlap
Fix documentation build errors for amdgpu: correct the filename. Error: Cannot open file ../drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c Error: Cannot open file ../drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c Error: Cannot open file ../drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c WARNING: kernel-doc '../scripts/ke

Re: [PATCH v8 06/14] drm: bridge: samsung-dsim: Handle proper DSI host initialization

2022-11-25 Thread Marek Vasut
On 11/23/22 21:09, Jagan Teki wrote: On Sat, Nov 19, 2022 at 7:45 PM Marek Vasut wrote: On 11/17/22 14:04, Marek Szyprowski wrote: On 17.11.2022 05:58, Marek Vasut wrote: On 11/10/22 19:38, Jagan Teki wrote: DSI host initialization handling in previous exynos dsi driver has some pitfalls. I

Re: [PATCH v28 6/7] drm/mediatek: add drm ovl_adaptor sub driver for MT8195

2022-11-25 Thread Nícolas F . R . A . Prado
On Mon, Nov 07, 2022 at 03:24:12PM +0800, Nancy.Lin wrote: > Add drm ovl_adaptor sub driver. Bring up ovl_adaptor sub driver if > the component exists in the path. > > Signed-off-by: Nancy.Lin > Reviewed-by: AngeloGioacchino Del Regno > > Reviewed-by: CK Hu > Tested-by: AngeloGioacchino Del Re

[PATCH v3 0/5] Add guard padding around i915_vma

2022-11-25 Thread Andi Shyti
Hi, This series adds guards around vma's but setting a pages at the beginning and at the end that work as padding. The first user of the vma guard are scanout objects which don't need anymore to add scratch to all the unused ggtt's and speeding up up considerably the boot and resume by several hu

[PATCH v3 4/5] Revert "drm/i915: Improve on suspend / resume time with VT-d enabled"

2022-11-25 Thread Andi Shyti
This reverts commit 2ef6efa79fecd5e3457b324155d35524d95f2b6b. Checking the presence if the IRST (Intel Rapid Start Technology) through the ACPI to decide whether to rebuild or not the GGTT puts us at the mercy of the boot firmware and we need to unnecessarily rely on third parties. Because now we

[PATCH v3 1/5] drm/i915: Wrap all access to i915_vma.node.start|size

2022-11-25 Thread Andi Shyti
From: Chris Wilson We already wrap i915_vma.node.start for use with the GGTT, as there we can perform additional sanity checks that the node belongs to the GGTT and fits within the 32b registers. In the next couple of patches, we will introduce guard pages around the objects _inside_ the drm_mm_n

[PATCH v3 2/5] drm/i915: Introduce guard pages to i915_vma

2022-11-25 Thread Andi Shyti
From: Chris Wilson Introduce the concept of padding the i915_vma with guard pages before and after. The major consequence is that all ordinary uses of i915_vma must use i915_vma_offset/i915_vma_size and not i915_vma.node.start/size directly, as the drm_mm_node will include the guard pages that su

[PATCH v3 5/5] drm/i915: Limit the display memory alignment to 32 bit instead of 64

2022-11-25 Thread Andi Shyti
Chris commit "drm/i915: Introduce guard pages to i915_vma" was "cunningly" changing display_alignment to u32 from u64. The reason is that the display GGTT is and will be limited o 4GB. Put it in a separate patch and use "max(...)" instead of "max_t(64, ...)" when asigning the value. We can safely

[PATCH v3 3/5] drm/i915: Refine VT-d scanout workaround

2022-11-25 Thread Andi Shyti
From: Chris Wilson VT-d may cause overfetch of the scanout PTE, both before and after the vma (depending on the scanout orientation). bspec recommends that we provide a tile-row in either directions, and suggests using 168 PTE, warning that the accesses will wrap around the ends of the GGTT. Curr

Re: [PATCH RESEND v4 2/2] gpu: drm: meson: Use devm_regulator_*get_enable*()

2022-11-25 Thread Martin Blumenstingl
On Wed, Nov 16, 2022 at 2:03 PM Matti Vaittinen wrote: > > Simplify using the devm_regulator_get_enable_optional(). Also drop the > seemingly unused struct member 'hdmi_supply'. Personally I'd replace "seemingly" with "now" because hdmi_supply was used before (although only in this one function, w

[PATCH] fbdev: make offb driver tristate

2022-11-25 Thread Randy Dunlap
Make the offb (Open Firmware frame buffer) driver tristate, i.e., so that it can be built as a loadable module. However, it still depends on the setting of DRM_OFDRM so that both of these drivers cannot be builtin at the same time nor can one be builtin and the other one a loadable module. Build-

Re: [PATCH v2 0/2] Fix a bunch of allmodconfig errors

2022-11-25 Thread Andrew Morton
On Fri, 25 Nov 2022 12:07:48 + Lee Jones wrote: > Since b339ec9c229aa ("kbuild: Only default to -Werror if COMPILE_TEST") > WERROR > now defaults to COMPILE_TEST meaning that it's enabled for allmodconfig > > builds. This leads to some interesting failures, each resolved in this s

Re: [PATCH v2 0/2] Fix a bunch of allmodconfig errors

2022-11-25 Thread Andrew Morton
On Fri, 25 Nov 2022 12:07:48 + Lee Jones wrote: > Since b339ec9c229aa ("kbuild: Only default to -Werror if COMPILE_TEST") > WERROR > now defaults to COMPILE_TEST meaning that it's enabled for allmodconfig > > builds. This leads to some interesting failures, each resolved in this s

<    1   2