Re: [PATCH v1] drm/ttm: Clean up page shift operation

2022-11-22 Thread Christian König
Am 22.11.22 um 08:51 schrieb Somalapuram Amaranath: Remove page shift operations as ttm_resource moved from num_pages to size_t size in bytes. v1 -> v2: fix missing page shift to fpfn and lpfn Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 +--- driv

Re: [Intel-gfx] [PATCH v2 0/5] Add module oriented dmesg output

2022-11-22 Thread Tvrtko Ursulin
On 21/11/2022 18:21, John Harrison wrote: On 11/18/2022 02:52, Jani Nikula wrote: On Thu, 17 Nov 2022, john.c.harri...@intel.com wrote: From: John Harrison When trying to analyse bug reports from CI, customers, etc. it can be difficult to work out exactly what is happening on which GT in a

Re: [PATCH v1 2/8] dt-bindings: display: bridge: renesas, dsi-csi2-tx: Add r8a779g0

2022-11-22 Thread Tomi Valkeinen
On 17/11/2022 17:14, Geert Uytterhoeven wrote: Hi Tomi, On Thu, Nov 17, 2022 at 1:26 PM Tomi Valkeinen wrote: From: Tomi Valkeinen Extend the Renesas DSI display bindings to support the r8a779g0 V4H. Signed-off-by: Tomi Valkeinen --- .../bindings/display/bridge/renesas,dsi-csi2-tx.yaml

Re: [PATCH] drm/msm/dpu: Print interrupt index in addition to the mask

2022-11-22 Thread Martin Botka
On November 21, 2022 11:24:55 PM GMT+01:00, Marijn Suijten wrote: >The mask only describes the `irq_idx % 32` part, making it generally >impossible to deduce what interrupt is being enabled/disabled. Since >`debug/core_irq` in debugfs (and other prints) also include the full >`DPU_IRQ_IDX()`

Re: ast: resolutions that require single-buffering (due to VRAM limitations) are unavailable

2022-11-22 Thread Jeremy Rand
Thomas Zimmermann: Hi Am 25.10.22 um 09:12 schrieb Jeremy Rand: Hi dri-devel, I have two machines with ASPEED GPU's (ast Linux driver).  One machine is x86_64, running an ASRock Rack Tommy 90-SC02P1-00UBNZ GPU (AST2510 chipset) with KDE Plasma Wayland; the other is ppc64le, running an integ

Re: [PATCH v4 02/10] dt-bindings: display: bridge: Add MHDP DP for i.MX8MQ

2022-11-22 Thread Krzysztof Kozlowski
On 21/11/2022 08:23, Sandor Yu wrote: > Add bindings for i.MX8MQ MHDP DisplayPort. > > Signed-off-by: Sandor Yu > --- > .../display/bridge/cdns,mhdp-imx8mq-dp.yaml | 93 +++ > 1 file changed, 93 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/display/br

Re: [PATCH v1 4/8] arm64: dts: renesas: r8a779g0: Add display related data

2022-11-22 Thread Tomi Valkeinen
On 17/11/2022 17:03, Kieran Bingham wrote: Quoting Tomi Valkeinen (2022-11-17 12:25:43) From: Tomi Valkeinen Add DT nodes for components needed to get the DSI output working: - FCPv - VSPd - DU - DSI Signed-off-by: Tomi Valkeinen --- arch/arm64/boot/dts/renesas/r8a779g0.dtsi | 129

Re: [PATCH v1 6/8] drm: rcar-du: Add r8a779g0 support

2022-11-22 Thread Tomi Valkeinen
On 22/11/2022 05:05, Laurent Pinchart wrote: On Thu, Nov 17, 2022 at 03:08:38PM +, Kieran Bingham wrote: Quoting Tomi Valkeinen (2022-11-17 12:25:45) From: Tomi Valkeinen Add support for DU on r8a779g0, which is identical to DU on r8a779a0. Signed-off-by: Tomi Valkeinen --- drivers/gp

Re: [PATCH v1 7/8] drm: rcar-du: dsi: Add r8A779g0 support

2022-11-22 Thread Tomi Valkeinen
On 17/11/2022 17:46, Kieran Bingham wrote: Quoting Tomi Valkeinen (2022-11-17 12:25:46) From: Tomi Valkeinen Add DSI support for r8a779g0. The main differences to r8a779a0 are in the PLL and PHTW setups. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c | 484 +

Re: [PATCH v1 2/8] dt-bindings: display: bridge: renesas, dsi-csi2-tx: Add r8a779g0

2022-11-22 Thread Geert Uytterhoeven
Hi Tomi, On Tue, Nov 22, 2022 at 9:20 AM Tomi Valkeinen wrote: > On 17/11/2022 17:14, Geert Uytterhoeven wrote: > > On Thu, Nov 17, 2022 at 1:26 PM Tomi Valkeinen > > wrote: > >> From: Tomi Valkeinen > >> > >> Extend the Renesas DSI display bindings to support the r8a779g0 V4H. > >> > >> Signed

Re: [Intel-gfx] [PATCH 1/6] drm/i915/uc: Introduce GSC FW

2022-11-22 Thread Jani Nikula
On Mon, 21 Nov 2022, Daniele Ceraolo Spurio wrote: > On MTL the GSC FW needs to be loaded on the media GT by the graphics > driver. We're going to treat it like a new uc_fw, so add the initial > defs and init/fini functions for it. > > Similarly to the other FWs, the GSC FW path can be overriden

Re: [PATCH] drm/mediatek: Clean dangling pointer on bind error path

2022-11-22 Thread AngeloGioacchino Del Regno
Il 21/11/22 23:37, Nícolas F. R. A. Prado ha scritto: mtk_drm_bind() can fail, in which case drm_dev_put() is called, destroying the drm_device object. However a pointer to it was still being held in the private object, and that pointer would be passed along to DRM in mtk_drm_sys_prepare() if a s

[PATCH] drm/bridge: ti-sn65dsi83: Fix delay after reset deassert to match spec

2022-11-22 Thread Frieder Schrempf
From: Frieder Schrempf The datasheet specifies a delay of 10 milliseconds, but the current driver only waits for 1 ms. Fix this to make sure the initialization sequence meets the spec. Fixes: ceb515ba29ba ("drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver") Signed-off-by: Frieder

[Bug 216727] New: Failure to wake up from suspend to RAM

2022-11-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216727 Bug ID: 216727 Summary: Failure to wake up from suspend to RAM Product: Drivers Version: 2.5 Kernel Version: 6.0.9 Hardware: AMD OS: Linux Tree: Mainline

Re: [PATCH v4 0/4] new subsystem for compute accelerator devices

2022-11-22 Thread Jacek Lawrynowicz
Hi, On 11/19/2022 9:44 PM, Oded Gabbay wrote: > This is the fourth (and hopefully last) version of the patch-set to add the > new subsystem for compute accelerators. I removed the RFC headline as > I believe it is now ready for merging. Looks good and works without issues. I will rebase next vers

Re: [PATCH v4] dma-buf: fix racing conflict of dma_heap_add()

2022-11-22 Thread Sumit Semwal
Hi Dawei Li, On Mon, 21 Nov 2022 at 23:53, Christian König wrote: > > Hi Dawei, > > from the technical description, coding style etc.. it looks clean to me, > but I'm the completely wrong person to ask for a background check. > > I have a high level understanding of how dma-heaps work, but not a

Re: [PATCH 6/6] drm/i915: Bpp/timeslot calculation fixes for DP MST DSC

2022-11-22 Thread Lisovskiy, Stanislav
On Thu, Nov 10, 2022 at 02:23:53PM -0800, Navare, Manasi wrote: > On Thu, Nov 03, 2022 at 03:23:00PM +0200, Stanislav Lisovskiy wrote: > > Fix intel_dp_dsc_compute_config, previously timeslots parameter > > was used in fact not as a timeslots, but more like a ratio > > timeslots/64, which of course

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: Fix negative value passed as remaining time

2022-11-22 Thread Tvrtko Ursulin
On 21/11/2022 23:19, Janusz Krzysztofik wrote: Hi Andrzej, Thanks for providing your R-b. On Monday, 21 November 2022 18:40:51 CET Andrzej Hajda wrote: On 21.11.2022 15:56, Janusz Krzysztofik wrote: Commit b97060a99b01 ("drm/i915/guc: Update intel_gt_wait_for_idle to work with GuC") extende

[git pull] new subsystem for compute accelerator devices

2022-11-22 Thread Oded Gabbay
Hi Dave, Here is the pull request for creating the compute acceleration (accel) subsystem. It includes the fixes to the few comments given in the latest patch-set review. Highlights of the patch-set contents are in the signed tag. Thanks, Oded The following changes since commit fc58764bbf602b65

Re: [PATCH v3 2/2] drm/i915: Never return 0 if not all requests retired

2022-11-22 Thread Tvrtko Ursulin
On 21/11/2022 14:56, Janusz Krzysztofik wrote: Users of intel_gt_retire_requests_timeout() expect 0 return value on success. However, we have no protection from passing back 0 potentially returned by a call to dma_fence_wait_timeout() when it succedes right after its timeout has expired. Is

Re: [PATCH v28 01/11] dt-bindings: arm: mediatek: mmsys: add vdosys1 compatible for MT8195

2022-11-22 Thread 林欣螢

Re: Build regressions/improvements in v6.1-rc6

2022-11-22 Thread Geert Uytterhoeven
On Tue, 22 Nov 2022, Geert Uytterhoeven wrote: JFYI, when comparing v6.1-rc6[1] to v6.1-rc5[3], the summaries are: - build errors: +6/-0 + /kisskb/src/arch/sh/include/asm/io.h: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]: => 239:34 sh4-gcc11/sh-allm

Re: [PATCH v4 3/4] drm: initialize accel framework

2022-11-22 Thread Melissa Wen
On 11/19, Oded Gabbay wrote: > Now that we have the accel framework code ready, let's call the > accel functions from all the appropriate places. These places are the > drm module init/exit functions, and all the drm_minor handling > functions. Hi Oded, The proposal overall LGTM, but I didn't man

Re: [PATCH v4 3/4] drm: initialize accel framework

2022-11-22 Thread Oded Gabbay
On Tue, Nov 22, 2022 at 12:56 PM Melissa Wen wrote: > > On 11/19, Oded Gabbay wrote: > > Now that we have the accel framework code ready, let's call the > > accel functions from all the appropriate places. These places are the > > drm module init/exit functions, and all the drm_minor handling > >

Re: [PATCH v4 3/4] drm: initialize accel framework

2022-11-22 Thread Oded Gabbay
On Tue, Nov 22, 2022 at 12:59 PM Oded Gabbay wrote: > > On Tue, Nov 22, 2022 at 12:56 PM Melissa Wen wrote: > > > > On 11/19, Oded Gabbay wrote: > > > Now that we have the accel framework code ready, let's call the > > > accel functions from all the appropriate places. These places are the > > >

Re: [PATCH v4 07/10] dt-bindings: phy: Add Cadence HDP-TX DP PHY

2022-11-22 Thread Krzysztof Kozlowski
On 21/11/2022 08:23, Sandor Yu wrote: > Add bindings for Cadence HDP-TX DisplayPort PHY. > > Signed-off-by: Sandor Yu > ---> .../bindings/phy/cdns,hdptx-dp-phy.yaml | 68 +++ > 1 file changed, 68 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/phy/c

Re: [PATCH v4 09/10] dt-bindings: phy: Add Cadence HDP-TX HDMI PHY

2022-11-22 Thread Krzysztof Kozlowski
On 21/11/2022 08:23, Sandor Yu wrote: > Add bindings for Cadence HDP-TX HDMI PHY. > > Signed-off-by: Sandor Yu > --- > .../bindings/phy/cdns,hdptx-hdmi-phy.yaml | 52 +++ > 1 file changed, 52 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/phy/cdns,hd

Re: [PATCH v4 3/4] drm: initialize accel framework

2022-11-22 Thread Melissa Wen
11/22, Oded Gabbay wrote: > On Tue, Nov 22, 2022 at 12:59 PM Oded Gabbay wrote: > > > > On Tue, Nov 22, 2022 at 12:56 PM Melissa Wen wrote: > > > > > > On 11/19, Oded Gabbay wrote: > > > > Now that we have the accel framework code ready, let's call the > > > > accel functions from all the appropr

[PATCH 1/2] drm/radeon: Fix PCI device refcount leak in radeon_atrm_get_bios()

2022-11-22 Thread Xiongfeng Wang
As comment of pci_get_class() says, it returns a pci_device with its refcount increased and decreased the refcount for the input parameter @from if it is not NULL. If we break the loop in radeon_atrm_get_bios() with 'pdev' not NULL, we need to call pci_dev_put() to decrease the refcount. Add the m

[PATCH 0/2] drm: Fix PCI device refcount leak

2022-11-22 Thread Xiongfeng Wang
As comment of pci_get_class() says, it returns a pci_device with its refcount increased and decreased the refcount for the input parameter @from if it is not NULL. If we use pci_get_class() to iterate all the PCI device of a certain class, when we find the expected device and break the iteration l

[PATCH 2/2] drm/amdgpu: Fix PCI device refcount leak in amdgpu_atrm_get_bios()

2022-11-22 Thread Xiongfeng Wang
As comment of pci_get_class() says, it returns a pci_device with its refcount increased and decreased the refcount for the input parameter @from if it is not NULL. If we break the loop in amdgpu_atrm_get_bios() with 'pdev' not NULL, we need to call pci_dev_put() to decrease the refcount. Add the m

[git pull v2] new subsystem for compute accelerator devices

2022-11-22 Thread Oded Gabbay
Hi Dave, Resending the pull-request with the fix of the build when CONFIG_DRM_ACCEL is set to N. Thanks, Oded The following changes since commit fc58764bbf602b65a6f63c53e5fd6feae76c510c: Merge tag 'amd-drm-next-6.2-2022-11-18' of https://gitlab.freedesktop.org/agd5f/linux into drm-next (2022

Re: [regression][6.0] After commit b261509952bc19d1012cf732f853659be6ebc61e I see WARNING message at drivers/gpu/drm/drm_modeset_lock.c:276 drm_modeset_drop_locks+0x63/0x70

2022-11-22 Thread Mikhail Gavrilov
On Thu, Oct 13, 2022 at 6:36 PM Mikhail Gavrilov wrote: > > Hi! > I bisected an issue of the 6.0 kernel which started happening after > 6.0-rc7 on all my machines. > > Backtrace of this issue looks like as: > > [ 2807.339439] [ cut here ] > [ 2807.339445] WARNING: CPU: 11 P

[PATCH] drm/amd/display: Fix set scaling doesn's work

2022-11-22 Thread hongao
[Why] Setting scaling does not correctly update CRTC state. As a result dc stream state's src (composition area) && dest (addressable area) was not calculated as expected. This causes set scaling doesn's work. [How] Correctly update CRTC state when setting scaling property. Signed-off-by: hongao

[PATCH linux-next] drm/i915/gvt: use sysfs_streq() instead of strncmp()

2022-11-22 Thread yang.yang29
From: Xu Panda Replace the open-code with sysfs_streq(). Signed-off-by: Xu Panda Signed-off-by: Yang Yang --- drivers/gpu/drm/i915/gvt/cmd_parser.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/gvt/cmd_parser.c b/drivers/gpu/drm/i915/

Re: [PATCH RFC 16/19] mm/frame-vector: remove FOLL_FORCE usage

2022-11-22 Thread Hans Verkuil
Hi Tomasz, David, On 11/8/22 05:45, Tomasz Figa wrote: > Hi David, > > On Tue, Nov 8, 2022 at 1:19 AM David Hildenbrand wrote: >> >> FOLL_FORCE is really only for debugger access. According to commit >> 707947247e95 ("media: videobuf2-vmalloc: get_userptr: buffers are always >> writable"), the p

Re: [PATCH RFC 16/19] mm/frame-vector: remove FOLL_FORCE usage

2022-11-22 Thread David Hildenbrand
On 22.11.22 13:25, Hans Verkuil wrote: Hi Tomasz, David, On 11/8/22 05:45, Tomasz Figa wrote: Hi David, On Tue, Nov 8, 2022 at 1:19 AM David Hildenbrand wrote: FOLL_FORCE is really only for debugger access. According to commit 707947247e95 ("media: videobuf2-vmalloc: get_userptr: buffers ar

Re: Coverity: intel_hti_uses_phy(): Integer handling issues

2022-11-22 Thread Jani Nikula
On Fri, 18 Nov 2022, coverity-bot wrote: > Hello! > > This is an experimental semi-automated report about issues detected by > Coverity from a scan of next-20221118 as part of the linux-next scan project: > https://scan.coverity.com/projects/linux-next-weekly-scan > > You're getting this email bec

[no subject]

2022-11-22 Thread Denis Arefev
Date: Tue, 22 Nov 2022 15:51:44 +0300 Subject: [PATCH] powerplay: hwmgr: added result check The return value of the 'div64_s64' function called in ppevvmath.h:371 was not checked. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Denis Arefev --- drivers/gpu/drm/

[MAINTAINER TOOLS] docs: updated rules for topic/core-for-CI commit management

2022-11-22 Thread Jani Nikula
Introduce stricter rules for topic/core-for-CI management. Way too many commits have been added over the years, with insufficient rationale recorded in the commit message, and insufficient follow-up with removing the commits from the topic branch. New rules: 1. Require maintainer ack for rebase.

Re: Build regressions/improvements in v6.1-rc6

2022-11-22 Thread Alex Deucher
On Tue, Nov 22, 2022 at 5:56 AM Geert Uytterhoeven wrote: > > On Tue, 22 Nov 2022, Geert Uytterhoeven wrote: > > JFYI, when comparing v6.1-rc6[1] to v6.1-rc5[3], the summaries are: > > - build errors: +6/-0 > >+ /kisskb/src/arch/sh/include/asm/io.h: error: cast to pointer from > integer of d

Re: [PATCH RFC 16/19] mm/frame-vector: remove FOLL_FORCE usage

2022-11-22 Thread Hans Verkuil
On 11/22/22 13:38, David Hildenbrand wrote: > On 22.11.22 13:25, Hans Verkuil wrote: >> Hi Tomasz, David, >> >> On 11/8/22 05:45, Tomasz Figa wrote: >>> Hi David, >>> >>> On Tue, Nov 8, 2022 at 1:19 AM David Hildenbrand wrote: FOLL_FORCE is really only for debugger access. According to c

Re: [PATCH mm-unstable v1 06/20] mm: rework handling in do_wp_page() based on private vs. shared mappings

2022-11-22 Thread Vlastimil Babka
On 11/16/22 11:26, David Hildenbrand wrote: > We want to extent FAULT_FLAG_UNSHARE support to anything mapped into a > COW mapping (pagecache page, zeropage, PFN, ...), not just anonymous pages. > Let's prepare for that by handling shared mappings first such that we can > handle private mappings la

Re: Try to address the DMA-buf coherency problem

2022-11-22 Thread Daniel Vetter
On Fri, Nov 18, 2022 at 11:32:19AM -0800, Rob Clark wrote: > On Thu, Nov 17, 2022 at 7:38 AM Nicolas Dufresne wrote: > > > > Le jeudi 17 novembre 2022 à 13:10 +0100, Christian König a écrit : > > > > > DMA-Buf let's the exporter setup the DMA addresses the importer uses > > > > > to > > > > > be

[PATCH v2] drm/mediatek: Clean dangling pointer on bind error path

2022-11-22 Thread Nícolas F . R . A . Prado
mtk_drm_bind() can fail, in which case drm_dev_put() is called, destroying the drm_device object. However a pointer to it was still being held in the private object, and that pointer would be passed along to DRM in mtk_drm_sys_prepare() if a suspend were triggered at that point, resulting in a pani

Re: [PATCH 7/7] drm/fb-helper: Don't use the preferred depth for the BPP default

2022-11-22 Thread Daniel Vetter
On Wed, Nov 16, 2022 at 05:09:17PM +0100, Thomas Zimmermann wrote: > If no preferred value for bits-per-pixel has been given, fall back > to 32. Never use the preferred depth. The color depth is the number > of color/alpha bits per pixel, while bpp is the overall number of > bits in most cases. >

Re: [PATCH] drm/doc: make drm-uapi igt-tests more readable

2022-11-22 Thread Daniel Vetter
On Fri, Nov 18, 2022 at 03:51:37PM -0800, Randy Dunlap wrote: > Correct grammar and make the use of the igt-tests more readable. > > Signed-off-by: Randy Dunlap > Cc: Gabriela Bittencourt > Cc: Rodrigo Siqueira > Cc: David Airlie > Cc: Daniel Vetter > Cc: Maarten Lankhorst > Cc: Maxime Ripar

Re: [PATCH 1/2] drm/radeon: Fix PCI device refcount leak in radeon_atrm_get_bios()

2022-11-22 Thread Alex Deucher
On Tue, Nov 22, 2022 at 6:12 AM Xiongfeng Wang wrote: > > As comment of pci_get_class() says, it returns a pci_device with its > refcount increased and decreased the refcount for the input parameter > @from if it is not NULL. > > If we break the loop in radeon_atrm_get_bios() with 'pdev' not NULL,

Re: [PATCH mm-unstable v1 07/20] mm: don't call vm_ops->huge_fault() in wp_huge_pmd()/wp_huge_pud() for private mappings

2022-11-22 Thread Vlastimil Babka
On 11/16/22 11:26, David Hildenbrand wrote: > If we already have a PMD/PUD mapped write-protected in a private mapping > and we want to break COW either due to FAULT_FLAG_WRITE or > FAULT_FLAG_UNSHARE, there is no need to inform the file system just like on > the PTE path. > > Let's just split (->

Re: [syzbot] inconsistent lock state in sync_info_debugfs_show

2022-11-22 Thread Daniel Vetter
On Fri, Nov 18, 2022 at 06:46:38PM -0800, syzbot wrote: > syzbot has found a reproducer for the following issue on: > > HEAD commit:84368d882b96 Merge tag 'soc-fixes-6.1-3' of git://git.kern.. > git tree: upstream > console+strace: https://syzkaller.appspot.com/x/log.txt?x=1670fb6588

[Bug 216727] Failure to wake up from suspend to RAM

2022-11-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216727 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC||alexdeuc...@gmail.c

Re: [PATCH v4 0/4] new subsystem for compute accelerator devices

2022-11-22 Thread Daniel Vetter
On Tue, Nov 22, 2022 at 03:46:25PM +1000, Dave Airlie wrote: > On Tue, 22 Nov 2022 at 09:06, Sonal Santan wrote: > > > > On 11/19/22 12:44, Oded Gabbay wrote: > > > This is the fourth (and hopefully last) version of the patch-set to add > > > the > > > new subsystem for compute accelerators. I re

[Bug 216727] Failure to wake up from suspend to RAM

2022-11-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216727 --- Comment #2 from Martin (martin...@gmx.com) --- (In reply to Alex Deucher from comment #1) > Does this patch help? > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/ > ?id=8d4de331f1b24a22d18e3c6116aa25228cf54854 Than

Re: [MAINTAINER TOOLS] docs: updated rules for topic/core-for-CI commit management

2022-11-22 Thread Daniel Vetter
On Tue, Nov 22, 2022 at 03:17:14PM +0200, Jani Nikula wrote: > Introduce stricter rules for topic/core-for-CI management. Way too many > commits have been added over the years, with insufficient rationale > recorded in the commit message, and insufficient follow-up with removing > the commits from

Re: [PATCH 1/2] drm/radeon: Fix PCI device refcount leak in radeon_atrm_get_bios()

2022-11-22 Thread Lazar, Lijo
On 11/22/2022 8:19 PM, Alex Deucher wrote: On Tue, Nov 22, 2022 at 6:12 AM Xiongfeng Wang wrote: As comment of pci_get_class() says, it returns a pci_device with its refcount increased and decreased the refcount for the input parameter @from if it is not NULL. If we break the loop in radeo

Re: [PATCH RFC 16/19] mm/frame-vector: remove FOLL_FORCE usage

2022-11-22 Thread David Hildenbrand
On 22.11.22 15:07, Hans Verkuil wrote: On 11/22/22 13:38, David Hildenbrand wrote: On 22.11.22 13:25, Hans Verkuil wrote: Hi Tomasz, David, On 11/8/22 05:45, Tomasz Figa wrote: Hi David, On Tue, Nov 8, 2022 at 1:19 AM David Hildenbrand wrote: FOLL_FORCE is really only for debugger access.

Re: [PATCH v2 2/4] usb: gadget: hid: Convert to use list_count()

2022-11-22 Thread Andy Shevchenko
On Mon, Nov 14, 2022 at 04:15:35PM -0300, Fabio Estevam wrote: > On Mon, Nov 14, 2022 at 1:22 PM Andy Shevchenko > wrote: > > > > The list API now provides the list_count() to help with counting > > existing nodes in the list. Uilise it. > > s/Uilise/Utilise Fixed for v3, thanks! -- With Best

Re: [PATCH v2 1/4] i915: Move list_count() to list.h for broader use

2022-11-22 Thread Andy Shevchenko
On Tue, Nov 15, 2022 at 05:46:28PM +0200, Jani Nikula wrote: > On Mon, 14 Nov 2022, Andy Shevchenko > wrote: > > Some of the existing users, and definitely will be new ones, want to > > count existing nodes in the list. Provide a generic API for that by > > moving code from i915 to list.h. > > I

RE: [EXT] Re: [PATCH v4 02/10] dt-bindings: display: bridge: Add MHDP DP for i.MX8MQ

2022-11-22 Thread Sandor Yu
Hi Krzysztof, Thanks your comments, > -Original Message- > From: Krzysztof Kozlowski > Sent: 2022年11月22日 16:28 > To: Sandor Yu ; andrzej.ha...@intel.com; > neil.armstr...@linaro.org; robert.f...@linaro.org; > laurent.pinch...@ideasonboard.com; jo...@kwiboo.se; > jernej.skra...@gmail.com;

[PATCH v3 1/4] i915: Move list_count() to list.h for broader use

2022-11-22 Thread Andy Shevchenko
Some of the existing users, and definitely will be new ones, want to count existing nodes in the list. Provide a generic API for that by moving code from i915 to list.h. Signed-off-by: Andy Shevchenko Acked-by: Jani Nikula --- v3: added tag (Jani), changed to be static inline (Mike) v2: dropped

[PATCH v3 3/4] usb: gadget: udc: bcm63xx: Convert to use list_count()

2022-11-22 Thread Andy Shevchenko
The list API now provides the list_count() to help with counting existing nodes in the list. Utilise it. Signed-off-by: Andy Shevchenko --- v3: no change v2: no change drivers/usb/gadget/udc/bcm63xx_udc.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/usb

[PATCH v3 2/4] usb: gadget: hid: Convert to use list_count()

2022-11-22 Thread Andy Shevchenko
The list API now provides the list_count() to help with counting existing nodes in the list. Utilise it. Signed-off-by: Andy Shevchenko --- v3: fixed typo in the commit message (Fabio) v2: no change drivers/usb/gadget/legacy/hid.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) dif

[PATCH v3 4/4] xhci: Convert to use list_count()

2022-11-22 Thread Andy Shevchenko
The list API now provides the list_count() to help with counting existing nodes in the list. Utilise it. Signed-off-by: Andy Shevchenko --- v3: no change v2: no change drivers/usb/host/xhci-ring.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/usb/host/xhci-ri

Re: [PATCH mm-unstable v1 08/20] mm: extend FAULT_FLAG_UNSHARE support to anything in a COW mapping

2022-11-22 Thread Vlastimil Babka
On 11/16/22 11:26, David Hildenbrand wrote: > Extend FAULT_FLAG_UNSHARE to break COW on anything mapped into a > COW (i.e., private writable) mapping and adjust the documentation > accordingly. > > FAULT_FLAG_UNSHARE will now also break COW when encountering the shared > zeropage, a pagecache page

[PATCH] drm/amd/pm: added result check

2022-11-22 Thread Denis Arefev
The return value of the 'div64_s64' function called in ppevvmath.h:371 was not checked. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Denis Arefev --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppevvmath.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-

Re: Build regressions/improvements in v6.1-rc6

2022-11-22 Thread Johannes Berg
On Tue, 2022-11-22 at 08:55 -0500, Alex Deucher wrote: > > > >+ /kisskb/src/arch/um/include/asm/processor-generic.h: error: called > > object is not a function or function pointer: => 94:18 > >+ /kisskb/src/drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c: > > error: control reaches

Re: [PATCH v3 1/4] i915: Move list_count() to list.h for broader use

2022-11-22 Thread Andy Shevchenko
On Tue, Nov 22, 2022 at 05:35:13PM +0200, Andy Shevchenko wrote: > Some of the existing users, and definitely will be new ones, want to > count existing nodes in the list. Provide a generic API for that by > moving code from i915 to list.h. Sorry for the noise, forgot to squash one part, so it get

Re: [PATCH v28 01/11] dt-bindings: arm: mediatek: mmsys: add vdosys1 compatible for MT8195

2022-11-22 Thread Matthias Brugger
On 22/11/2022 11:51, Nancy Lin (林欣螢) wrote: Dear Matthias, Thanks for the review. On Thu, 2022-11-10 at 14:10 +0100, Matthias Brugger wrote: On 09/11/2022 06:10, Jason-JH Lin (林睿祥) wrote: > On Tue, 2022-11-08 at 18:46 +0100, Matthias Brugger wrote: > > > > On 07/11/2022 08:22, Nancy.Lin w

Re: git send-email friendly smtp provider anyone?

2022-11-22 Thread Konstantin Ryabitsev
On Mon, Nov 21, 2022 at 07:13:28PM +0100, Noralf Trønnes wrote: > > Otherwise, you might consider using: > > https://b4.docs.kernel.org/en/latest/contributor/send.html#authenticating-with-the-web-submission-endpoint > > > > That's an interesting option. I did briefly look at b4 a few months back

Re: [PATCH v4 0/4] new subsystem for compute accelerator devices

2022-11-22 Thread Jeffrey Hugo
On 11/20/2022 3:04 PM, Jeffrey Hugo wrote: On 11/19/2022 1:44 PM, Oded Gabbay wrote: This is the fourth (and hopefully last) version of the patch-set to add the new subsystem for compute accelerators. I removed the RFC headline as I believe it is now ready for merging. Compare to v3, this patc

Re: [PATCH 1/2] drm/radeon: Fix PCI device refcount leak in radeon_atrm_get_bios()

2022-11-22 Thread Alex Deucher
On Tue, Nov 22, 2022 at 9:59 AM Lazar, Lijo wrote: > > > > On 11/22/2022 8:19 PM, Alex Deucher wrote: > > On Tue, Nov 22, 2022 at 6:12 AM Xiongfeng Wang > > wrote: > >> > >> As comment of pci_get_class() says, it returns a pci_device with its > >> refcount increased and decreased the refcount for

Re: [PATCH mm-unstable v1 09/20] mm/gup: reliable R/O long-term pinning in COW mappings

2022-11-22 Thread Vlastimil Babka
On 11/16/22 11:26, David Hildenbrand wrote: > We already support reliable R/O pinning of anonymous memory. However, > assume we end up pinning (R/O long-term) a pagecache page or the shared > zeropage inside a writable private ("COW") mapping. The next write access > will trigger a write-fault and

Re: [Intel-gfx] [PATCH v2 0/5] Add module oriented dmesg output

2022-11-22 Thread Michal Wajdeczko
On 18.11.2022 11:52, Jani Nikula wrote: > On Thu, 17 Nov 2022, john.c.harri...@intel.com wrote: >> From: John Harrison >> >> When trying to analyse bug reports from CI, customers, etc. it can be >> difficult to work out exactly what is happening on which GT in a >> multi-GT system. So add GT or

Re: [PATCH printk v5 00/40] reduce console_lock scope

2022-11-22 Thread Greg Kroah-Hartman
On Wed, Nov 16, 2022 at 05:27:12PM +0106, John Ogness wrote: > This is v5 of a series to prepare for threaded/atomic > printing. v4 is here [0]. This series focuses on reducing the > scope of the BKL console_lock. It achieves this by switching to > SRCU and a dedicated mutex for console list iterat

Re: [PATCH v2 1/5] drm/i915/gt: Start adding module oriented dmesg output

2022-11-22 Thread Michal Wajdeczko
On 18.11.2022 02:58, john.c.harri...@intel.com wrote: > From: John Harrison > > When trying to analyse bug reports from CI, customers, etc. it can be > difficult to work out exactly what is happening on which GT in a > multi-GT system. So add GT oriented debug/error message wrappers. If > used

Re: Build regressions/improvements in v6.1-rc6

2022-11-22 Thread Randy Dunlap
On 11/22/22 07:00, Johannes Berg wrote: > On Tue, 2022-11-22 at 08:55 -0500, Alex Deucher wrote: >>> >>>+ /kisskb/src/arch/um/include/asm/processor-generic.h: error: called >>> object is not a function or function pointer: => 94:18 >>>+ /kisskb/src/drivers/gpu/drm/amd/amdgpu/../amdkfd/

[PATCH] dma-buf: Require VM_PFNMAP vma for mmap

2022-11-22 Thread Daniel Vetter
tldr; DMA buffers aren't normal memory, expecting that you can use them like that (like calling get_user_pages works, or that they're accounting like any other normal memory) cannot be guaranteed. Since some userspace only runs on integrated devices, where all buffers are actually all resident sys

Re: [PATCH 1/2] drm/radeon: Fix PCI device refcount leak in radeon_atrm_get_bios()

2022-11-22 Thread Lazar, Lijo
[AMD Official Use Only - General] When only second GPU has valid ATRM handle - then it stays inside the loop and in the next call to pci_get_class(), it passes pdev reference to first GPU as the "from" param. That time it drops the reference count of "from" device. Thanks, Lijo

Re: [PATCH 1/2] drm/radeon: Fix PCI device refcount leak in radeon_atrm_get_bios()

2022-11-22 Thread Alex Deucher
On Tue, Nov 22, 2022 at 12:10 PM Lazar, Lijo wrote: > > [AMD Official Use Only - General] > > When only second GPU has valid ATRM handle - > then it stays inside the loop and in the next call to pci_get_class(), it > passes pdev reference to first GPU as the "from" param. That time it drops > th

Re: [PATCH v2 2/5] drm/i915/huc: Add HuC specific debug print wrappers

2022-11-22 Thread Michal Wajdeczko
On 18.11.2022 02:58, john.c.harri...@intel.com wrote: > From: John Harrison > > Create a set of HuC printers and start using them. > > Signed-off-by: John Harrison > --- > drivers/gpu/drm/i915/gt/uc/intel_huc.c | 31 ++ > drivers/gpu/drm/i915/gt/uc/intel_huc.h | 23 +

Re: [syzbot] inconsistent lock state in sync_info_debugfs_show

2022-11-22 Thread Christian König
Am 22.11.22 um 15:51 schrieb Daniel Vetter: On Fri, Nov 18, 2022 at 06:46:38PM -0800, syzbot wrote: syzbot has found a reproducer for the following issue on: HEAD commit:84368d882b96 Merge tag 'soc-fixes-6.1-3' of git://git.kern.. git tree: upstream console+strace: https://nam11.safe

Re: [PATCH RFC 16/19] mm/frame-vector: remove FOLL_FORCE usage

2022-11-22 Thread Linus Torvalds
On Tue, Nov 22, 2022 at 4:25 AM Hans Verkuil wrote: > > I tracked the use of 'force' all the way back to the first git commit > (2.6.12-rc1) in the very old video-buf.c. So it is very, very old and the > reason is lost in the mists of time. Well, not entirely. For archaeology reasons, I went bac

Re: Try to address the DMA-buf coherency problem

2022-11-22 Thread Christian König
Am 22.11.22 um 15:36 schrieb Daniel Vetter: On Fri, Nov 18, 2022 at 11:32:19AM -0800, Rob Clark wrote: On Thu, Nov 17, 2022 at 7:38 AM Nicolas Dufresne wrote: Le jeudi 17 novembre 2022 à 13:10 +0100, Christian König a écrit : DMA-Buf let's the exporter setup the DMA addresses the importer use

Re: git send-email friendly smtp provider anyone?

2022-11-22 Thread Noralf Trønnes
Den 22.11.2022 16.51, skrev Konstantin Ryabitsev: > On Mon, Nov 21, 2022 at 07:13:28PM +0100, Noralf Trønnes wrote: >>> Otherwise, you might consider using: >>> https://b4.docs.kernel.org/en/latest/contributor/send.html#authenticating-with-the-web-submission-endpoint >>> >> >> That's an interest

Re: [PATCH v2 3/5] drm/i915/guc: Add GuC specific debug print wrappers

2022-11-22 Thread Michal Wajdeczko
On 18.11.2022 02:58, john.c.harri...@intel.com wrote: > From: John Harrison > > Create a set of GuC printers and start using them. > > Signed-off-by: John Harrison > --- > drivers/gpu/drm/i915/gt/uc/intel_guc.c| 32 -- > drivers/gpu/drm/i915/gt/uc/intel_guc.h| 35 +++

Re: [Intel-gfx] [MAINTAINER TOOLS] docs: updated rules for topic/core-for-CI commit management

2022-11-22 Thread Rodrigo Vivi
On Tue, Nov 22, 2022 at 03:59:10PM +0100, Daniel Vetter wrote: > On Tue, Nov 22, 2022 at 03:17:14PM +0200, Jani Nikula wrote: > > Introduce stricter rules for topic/core-for-CI management. Way too many > > commits have been added over the years, with insufficient rationale > > recorded in the commi

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915/guc: Add GuC CT specific debug print wrappers

2022-11-22 Thread Michal Wajdeczko
On 18.11.2022 02:58, john.c.harri...@intel.com wrote: > From: John Harrison > > Re-work the existing GuC CT printers and extend as required to match > the new wrapping scheme. > > Signed-off-by: John Harrison > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 222 +++--- >

Re: [PATCH] dma-buf: Require VM_PFNMAP vma for mmap

2022-11-22 Thread Jason Gunthorpe
On Tue, Nov 22, 2022 at 06:08:00PM +0100, Daniel Vetter wrote: > tldr; DMA buffers aren't normal memory, expecting that you can use > them like that (like calling get_user_pages works, or that they're > accounting like any other normal memory) cannot be guaranteed. > > Since some userspace only ru

Re: [PATCH] dma-buf: Require VM_PFNMAP vma for mmap

2022-11-22 Thread Daniel Vetter
On Tue, 22 Nov 2022 at 19:04, Jason Gunthorpe wrote: > > On Tue, Nov 22, 2022 at 06:08:00PM +0100, Daniel Vetter wrote: > > tldr; DMA buffers aren't normal memory, expecting that you can use > > them like that (like calling get_user_pages works, or that they're > > accounting like any other normal

Re: [PATCH v4 01/10] drm: bridge: cadence: convert mailbox functions to macro functions

2022-11-22 Thread Fabio Estevam
Hi Sandor, On Mon, Nov 21, 2022 at 4:27 AM Sandor Yu wrote: > > Mailbox access functions could be share to other mhdp driver and > HDP-TX HDMI/DP PHY drivers, move those functions to head file > include/drm/bridge/cdns-mhdp-mailbox.h and convert them to > macro functions. What is the reason for

Re: [PATCH v3 1/4] i915: Move list_count() to list.h for broader use

2022-11-22 Thread kernel test robot
Hi Andy, I love your patch! Yet something to improve: [auto build test ERROR on usb/usb-testing] [also build test ERROR on usb/usb-next usb/usb-linus drm-intel/for-linux-next drm-intel/for-linux-next-fixes linus/master v6.1-rc6 next-20221122] [If your patch is applied to the wrong git tree

Re: [Intel-gfx] [PATCH v2 0/5] Add module oriented dmesg output

2022-11-22 Thread Jani Nikula
On Tue, 22 Nov 2022, Michal Wajdeczko wrote: > On 18.11.2022 11:52, Jani Nikula wrote: >> On Thu, 17 Nov 2022, john.c.harri...@intel.com wrote: >>> From: John Harrison >>> >>> When trying to analyse bug reports from CI, customers, etc. it can be >>> difficult to work out exactly what is happening

Re: Try to address the DMA-buf coherency problem

2022-11-22 Thread Daniel Vetter
On Tue, 22 Nov 2022 at 18:34, Christian König wrote: > Am 22.11.22 um 15:36 schrieb Daniel Vetter: > > On Fri, Nov 18, 2022 at 11:32:19AM -0800, Rob Clark wrote: > >> On Thu, Nov 17, 2022 at 7:38 AM Nicolas Dufresne > >> wrote: > >>> Le jeudi 17 novembre 2022 à 13:10 +0100, Christian König a écr

Running into problems with UDMABUF

2022-11-22 Thread Paul Cercueil
Hi Gerd, I'm running into a problem trying to use UDMABUF and I'm not sure if it's a bug in udmabuf, or I'm just using it wrong. I create a UDMABUF in userspace, enable CPU access to it, copy some data, disable CPU access, then register it with the IIO subsystem using an ioctl I'm working on

Re: [PATCH v3 1/4] i915: Move list_count() to list.h for broader use

2022-11-22 Thread kernel test robot
Hi Andy, I love your patch! Yet something to improve: [auto build test ERROR on usb/usb-testing] [also build test ERROR on usb/usb-next usb/usb-linus drm-intel/for-linux-next drm-intel/for-linux-next-fixes linus/master v6.1-rc6 next-20221122] [If your patch is applied to the wrong git tree

Re: git send-email friendly smtp provider anyone?

2022-11-22 Thread Konstantin Ryabitsev
On Tue, Nov 22, 2022 at 06:42:19PM +0100, Noralf Trønnes wrote: > The first thing that strikes me is that everyone mentioned in one of the > patches get the entire patchset, even sta...@vger.kernel.org (cc'ed in a > fixes patch). The first patch touches a core file and as a result a few > drivers,

Re: [PATCH] dma-buf: Require VM_PFNMAP vma for mmap

2022-11-22 Thread Jason Gunthorpe
On Tue, Nov 22, 2022 at 07:08:25PM +0100, Daniel Vetter wrote: > On Tue, 22 Nov 2022 at 19:04, Jason Gunthorpe wrote: > > > > On Tue, Nov 22, 2022 at 06:08:00PM +0100, Daniel Vetter wrote: > > > tldr; DMA buffers aren't normal memory, expecting that you can use > > > them like that (like calling g

Re: [Intel-gfx] [PATCH 2/6] drm/i915/gsc: Skip the version check when fetching the GSC FW

2022-11-22 Thread Rodrigo Vivi
On Mon, Nov 21, 2022 at 03:16:13PM -0800, Daniele Ceraolo Spurio wrote: > The current exectation from the FW side is that the driver will query > the GSC FW version after the FW is loaded, similarly to what the mei > driver does on DG2. However, we're discussing with the FW team if there > is a way

[PATCH v2 0/4] Add guard padding around i915_vma

2022-11-22 Thread Andi Shyti
Hi, This series adds guards around vma's but setting a pages at the beginning and at the end that work as padding. The first user of the vma guard are scanout objects which don't need anymore to add scratch to all the unused ggtt's and speeding up up considerably the boot and resume by several hu

[PATCH v2 1/4] drm/i915: Wrap all access to i915_vma.node.start|size

2022-11-22 Thread Andi Shyti
From: Chris Wilson We already wrap i915_vma.node.start for use with the GGTT, as there we can perform additional sanity checks that the node belongs to the GGTT and fits within the 32b registers. In the next couple of patches, we will introduce guard pages around the objects _inside_ the drm_mm_n

  1   2   3   >