Re: [PATCH] drm/amdgpu: add mb for si

2022-11-18 Thread Christian König
Am 18.11.22 um 08:48 schrieb Zhenneng Li: During reboot test on arm64 platform, it may failure on boot, so add this mb in smc. The error message are as follows: [6.996395][ 7] [ T295] [drm:amdgpu_device_ip_late_init [amdgpu]] *ERROR* late_init of IP block failed

Re: [PATCH] dma-buf: Fix possible UAF in dma_buf_export

2022-11-18 Thread Christian König
Am 18.11.22 um 03:36 schrieb T.J. Mercier: On Thu, Nov 17, 2022 at 2:16 AM Christian König wrote: Am 17.11.22 um 08:48 schrieb Charan Teja Kalla: Sometime back Dan also reported the same issue[1] where I do mentioned that fput()-->dma_buf_file_release() will remove it from the list. But it se

[PATCH 1/2] dt-bindings: display: simple: add support for InnoLux G070ACE-L01

2022-11-18 Thread richard . leitner
From: Richard Leitner Add Innolux G070ACE-L01 7" WVGA (800x480) TFT LCD panel compatible string. Signed-off-by: Richard Leitner --- Cc: Thierry Reding Cc: Sam Ravnborg Cc: David Airlie Cc: Daniel Vetter Cc: Rob Herring Cc: Krzysztof Kozlowski Cc: dri-devel@lists.freedesktop.org Cc: devic

[PATCH 2/2] drm/panel: simple: Add InnoLux G070ACE-L01

2022-11-18 Thread richard . leitner
From: Richard Leitner Add InnoLux G070ACE-L01 7" 800x480 TFT LCD with WLED backlight panel support. Timing data was extracted from datasheet and vendor provided EDID file. Signed-off-by: Richard Leitner --- Cc: Thierry Reding Cc: Sam Ravnborg Cc: David Airlie Cc: Daniel Vetter Cc: dri-deve

Re: The state of Quantization Range handling

2022-11-18 Thread Pekka Paalanen
On Thu, 17 Nov 2022 22:39:36 +0100 Sebastian Wick wrote: > On Wed, Nov 16, 2022 at 1:34 PM Pekka Paalanen wrote: > > > > Is it a good idea to put even more automation/magic into configuring > > the color pipeline and metadata for a sink, making them even more > > intertwined? > > > > I would pre

[PULL] drm-intel-gt-next

2022-11-18 Thread Joonas Lahtinen
Hi Dave & Daniel, Here goes the last drm-intel-gt-next feature pull req for v6.2. We have a couple of important fixes around memory management (TTM and userptr), then demoting GuC kernel contexts to normal priority and Meteorlake enabling. Beyond that it's smaller fixes to code structure and cor

[PATCH] video: fbdev: fix spelling mistake "paramaters"->"parameters"

2022-11-18 Thread Yu Zhe
There is a spelling mistake in comment. Fix it. Signed-off-by: Yu Zhe --- drivers/video/fbdev/controlfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/controlfb.c b/drivers/video/fbdev/controlfb.c index 6bbcd9fc864e..77dbf94aae5f 100644 --- a/drivers/vi

Re: [PATCH] video: fbdev: fix spelling mistake "paramaters"->"parameters"

2022-11-18 Thread Helge Deller
On 11/18/22 10:00, Yu Zhe wrote: There is a spelling mistake in comment. Fix it. Signed-off-by: Yu Zhe applied. Thanks! Helge --- drivers/video/fbdev/controlfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/controlfb.c b/drivers/video/fbdev/con

Re: [PATCH] drm/amdgpu: add mb for si

2022-11-18 Thread Michel Dänzer
On 11/18/22 09:01, Christian König wrote: > Am 18.11.22 um 08:48 schrieb Zhenneng Li: >> During reboot test on arm64 platform, it may failure on boot, >> so add this mb in smc. >> >> The error message are as follows: >> [    6.996395][ 7] [  T295] [drm:amdgpu_device_ip_late_init [amdgpu]] *ERROR* >

Re: linux-next: manual merge of the drm-misc tree with the origin tree

2022-11-18 Thread Maxime Ripard
On Thu, Nov 17, 2022 at 05:01:08PM -0700, Nathan Chancellor wrote: > On Fri, Nov 18, 2022 at 09:06:36AM +1100, Stephen Rothwell wrote: > > Hi Nathan, > > > > On Thu, 17 Nov 2022 10:29:33 -0700 Nathan Chancellor > > wrote: > > > > > > This resolution is not quite right, as pointed out by clang: >

Re: [PATCH 2/2] drm/tests: helpers: Add SPDX header

2022-11-18 Thread Maxime Ripard
Hi Maira, On Wed, Nov 16, 2022 at 01:48:13PM -0300, Maíra Canal wrote: > Hi Maxime, > > On 11/16/22 12:18, Maxime Ripard wrote: > > The SPDX header is missing, let's add it and fix the corresponding > > checkpatch warning. > > > > Suggested-by: Maíra Canal > > Fixes: 44a3928324e9 ("drm/tests: A

Re: [PATCH] drm/amdgpu: add mb for si

2022-11-18 Thread 李真能
在 2022/11/18 17:18, Michel Dänzer 写道: On 11/18/22 09:01, Christian König wrote: Am 18.11.22 um 08:48 schrieb Zhenneng Li: During reboot test on arm64 platform, it may failure on boot, so add this mb in smc. The error message are as follows: [    6.996395][ 7] [  T295] [drm:amdgpu_device_ip_l

Re: [PATCH v3 5/6] ARM: dts: renesas: Use new media bus type macros

2022-11-18 Thread Lad, Prabhakar
Hi Laurent, Thank you for the patch. On Wed, Jun 15, 2022 at 11:21 PM Laurent Pinchart wrote: > > Now that a header exists with macros for the media interface bus-type > values, replace hardcoding numerical constants with the corresponding > macros in the DT sources. > > Signed-off-by: Laurent P

Re: [PATCH v4] udmabuf: add vmap and vunmap methods to udmabuf_ops

2022-11-18 Thread Lukasz Wiecaszek
On Thu, Nov 17, 2022 at 07:01:05PM +0100, Christian König wrote: > Am 17.11.22 um 18:32 schrieb Dmitry Osipenko: > > On 11/17/22 20:08, Lukasz Wiecaszek wrote: > > > On Thu, Nov 17, 2022 at 12:04:35PM +0300, Dmitry Osipenko wrote: > > > > Hi, > > > > > > > > On 11/17/22 07:58, Lukasz Wiecaszek wro

Re: [PATCH v5] udmabuf: add vmap and vunmap methods to udmabuf_ops

2022-11-18 Thread Christian König
Pushed this one here to drm-misc-next. Thanks, Christian. Am 17.11.22 um 18:18 schrieb Lukasz Wiecaszek: The reason behind that patch is associated with videobuf2 subsystem (or more genrally with v4l2 framework) and user created dma buffers (udmabuf). In some circumstances when dealing with V4L

Re: The state of Quantization Range handling

2022-11-18 Thread Pekka Paalanen
On Thu, 17 Nov 2022 22:13:26 +0100 Sebastian Wick wrote: > Hi Dave, > > I noticed that I didn't get the Broadcast RGB property thanks to you > (more below) > > On Tue, Nov 15, 2022 at 2:16 PM Dave Stevenson > wrote: > > > > Hi Sebastian > > > > Thanks for starting the conversation - it's stall

Re: [PATCH v3 2/7] drm/ivpu: Add Intel VPU MMU support

2022-11-18 Thread Jacek Lawrynowicz
Hi, On 11/1/2022 10:00 AM, Thomas Zimmermann wrote: > Hi > > Am 24.09.22 um 17:11 schrieb Jacek Lawrynowicz: >> VPU Memory Management Unit is based on ARM MMU-600. >> It allows to create multiple virtual address spaces for the device and >> map noncontinuous host memory (there is no dedicated mem

Re: [PATCH v3 2/7] drm/ivpu: Add Intel VPU MMU support

2022-11-18 Thread Jacek Lawrynowicz
Hi, On 11/1/2022 9:56 AM, Thomas Zimmermann wrote: > Hi > > Am 24.09.22 um 17:11 schrieb Jacek Lawrynowicz: >> VPU Memory Management Unit is based on ARM MMU-600. >> It allows to create multiple virtual address spaces for the device and >> map noncontinuous host memory (there is no dedicated memo

Re: [PATCH v2] drm/gem-shmem: When drm_gem_object_init failed, should release object

2022-11-18 Thread Chunyou Tang
Hi Thomas, Can I discard the first two patchs, and pull the new code, then modify and git send-email this patch? ?? Thu, 17 Nov 2022 14:42:36 +0100 Thomas Zimmermann : > Hi > > Am 11.11.22 um 04:38 schrieb ChunyouTang: > > when goto err_free, the object had init, so it should be rele

[PATCH v2 0/2] drm/i915: Fix timeout handling when retiring requests

2022-11-18 Thread Janusz Krzysztofik
Fixes for issues discovered via code review while working on https://gitlab.freedesktop.org/drm/intel/issues/7349. v2: PATCH 1: fix the issue on the caller side, not the provider, reword commit message and description. PATCH 2: move the added lines down so flush_submission() is not affect

[PATCH v2 1/2] drm/i915: Fix negative value passed as remaining time

2022-11-18 Thread Janusz Krzysztofik
Commit b97060a99b01 ("drm/i915/guc: Update intel_gt_wait_for_idle to work with GuC") extended the API of intel_gt_retire_requests_timeout() with an extra argument 'remaining_timeout', intended for passing back unconsumed portion of requested timeout when 0 (success) is returned. However, when requ

[PATCH v2 2/2] drm/i915: Never return 0 if not all requests retired

2022-11-18 Thread Janusz Krzysztofik
Users of intel_gt_retire_requests_timeout() expect 0 return value on success. However, we have no protection from passing back 0 potentially returned by a call to dma_fence_wait_timeout() when it succedes right after its timeout has expired. Replace 0 with -ETIME before potentially using the time

Re: [Intel-gfx] [PATCH v2 0/5] Add module oriented dmesg output

2022-11-18 Thread Jani Nikula
On Thu, 17 Nov 2022, john.c.harri...@intel.com wrote: > From: John Harrison > > When trying to analyse bug reports from CI, customers, etc. it can be > difficult to work out exactly what is happening on which GT in a > multi-GT system. So add GT oriented debug/error message wrappers. If > used ins

Re: DRM-managed resources / devm_drm_dev_alloc leaking resources

2022-11-18 Thread Javier Martinez Canillas
Hello Maxime, On 11/17/22 17:53, Maxime Ripard wrote: > Hi, > > After trying to get more kunit tests for KMS, I found out that the > recent kunit helpers we merged to create a DRM device [1] are broken and > won't free their device-managed and DRM-managed resources. > > With some help from Thoma

Re: [PATCH v3 1/2] arm64: dts: qcom: add data-lanes and link-freuencies into dp_out endpoint

2022-11-18 Thread Dmitry Baryshkov
On Fri, 18 Nov 2022 at 00:50, Kuogee Hsieh wrote: > > Add both data-lanes and link-frequencies property to dp_out endpoint. Bindings update? Deprecate the old data-lanes property? > Also set link-frequencies to 81 khz at herobrine platform to have > max link rate limited at 81 khz (HBR3)

Re: [PATCH v3 2/2] drm/msm/dp: add support of max dp link rate

2022-11-18 Thread Dmitry Baryshkov
On 18/11/2022 01:49, Kuogee Hsieh wrote: dp_out endpoint contains both data-lanes and link-frequencies properties. This patch parser dp_out endpoint properties and acquire dp_max_lanes and dp_max_link_rate from respective property. Finally, comparing them against both data lane and link rate read

Re: [PATCH mm-unstable v1 20/20] mm: rename FOLL_FORCE to FOLL_PTRACE

2022-11-18 Thread Peter Zijlstra
On Wed, Nov 16, 2022 at 10:16:34AM -0800, Linus Torvalds wrote: > Following the history of it is a big of a mess, because there's a > number of renamings and re-organizations, but it seems to go back to > 2007 and commit b6a2fea39318 ("mm: variable length argument support"). I went back and read p

[bug report] Merge branch 'for-linux-next' of git://anongit.freedesktop.org/drm/drm-misc

2022-11-18 Thread Dan Carpenter
Hello Stephen Rothwell, The patch 23b727d76bda: "Merge branch 'for-linux-next' of git://anongit.freedesktop.org/drm/drm-misc" from Nov 17, 2022, leads to the following Smatch static checker warning: drivers/gpu/drm/vc4/vc4_hdmi.c:351 vc4_hdmi_reset_link() error: uninitialized symb

Re: [PATCH v2] drm/gem-shmem: When drm_gem_object_init failed, should release object

2022-11-18 Thread Thomas Zimmermann
Hi Am 18.11.22 um 11:32 schrieb Chunyou Tang: Hi Thomas, Can I discard the first two patchs, and pull the new code, then modify and git send-email this patch? Yes, of course. Just make sure that the next version is marked as v3, so it's obvious what it belongs to. Best regards Thoma

Re: [PATCH printk v5 00/40] reduce console_lock scope

2022-11-18 Thread Petr Mladek
On Wed 2022-11-16 17:27:12, John Ogness wrote: > This is v5 of a series to prepare for threaded/atomic > printing. v4 is here [0]. This series focuses on reducing the > scope of the BKL console_lock. It achieves this by switching to > SRCU and a dedicated mutex for console list iteration and > modi

[PATCH] drm/i915: Fix workarounds on Gen2-3

2022-11-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In 3653727560d0 ("drm/i915: Simplify internal helper function signature") I broke the old platforms by not noticing engine workaround init does not initialize the list on old platforms. Fix it by always initializing which already does the right thing by mostly not doing anyth

[GIT PULL v2] drm/tegra: Fixes for v6.1-rc6

2022-11-18 Thread Thierry Reding
Hi Dave, Daniel, The following changes since commit 9abf2313adc1ca1b6180c508c25f22f9395cc780: Linux 6.1-rc1 (2022-10-16 15:36:24 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/drm/tegra.git tags/drm/tegra/for-6.1-rc6 for you to fetch changes up to c2418f911a3

[PATCH v3 0/3] add color management support for the crtc

2022-11-18 Thread Kalyan Thota
Add color management support for the crtc provided there are enough dspps that can be allocated from the catalog Kalyan Thota (3): drm/msm/disp/dpu1: pin 1 crtc to 1 encoder drm/msm/disp/dpu1: add helper to know if display is builtin drm/msm/disp/dpu1: add color management support for the cr

[PATCH v3 1/3] drm/msm/disp/dpu1: pin 1 crtc to 1 encoder

2022-11-18 Thread Kalyan Thota
Pin each crtc with one encoder. This arrangement will disallow crtc switching between encoders and also will facilitate to advertise certain features on crtc based on encoder type. Changes in v1: - use drm_for_each_encoder macro while iterating through encoder list (Dmitry) Changes in v2: - mak

[PATCH v3 2/3] drm/msm/disp/dpu1: add helper to know if display is builtin

2022-11-18 Thread Kalyan Thota
Since DRM encoder type for few encoders can be similar (like eDP and DP) find out if the interface supports HPD from encoder bridge to differentiate between builtin and pluggable displays. Changes in v1: - add connector type in the disp_info (Dmitry) - add helper functions to know encoder type - u

[PATCH v3 3/3] drm/msm/disp/dpu1: add color management support for the crtc

2022-11-18 Thread Kalyan Thota
Add color management support for the crtc provided there are enough dspps that can be allocated from the catalog. Changes in v1: - cache color enabled state in the dpu crtc obj (Dmitry) - simplify dspp allocation while creating crtc (Dmitry) - register for color when crtc is created (Dmitry) Chan

Re: [RFC PATCH v6] media: mediatek: vcodec: support stateless AV1 decoder

2022-11-18 Thread Andrzej Pietrasiewicz
Hi again, W dniu 17.11.2022 o 13:42, Andrzej Pietrasiewicz pisze: Hi Xiaoyong Lu, Sorry about chiming in only at v6. Please see inline below. Andrzej W dniu 17.11.2022 o 07:17, Xiaoyong Lu pisze: Add mediatek av1 decoder linux driver which use the stateless API in MT8195. Signed-off-by: Xia

Re: [PATCH v3 1/3] drm/msm/disp/dpu1: pin 1 crtc to 1 encoder

2022-11-18 Thread Dmitry Baryshkov
On 18/11/2022 15:16, Kalyan Thota wrote: Pin each crtc with one encoder. This arrangement will disallow crtc switching between encoders and also will facilitate to advertise certain features on crtc based on encoder type. Changes in v1: - use drm_for_each_encoder macro while iterating through

Re: [PATCH v3 2/3] drm/msm/disp/dpu1: add helper to know if display is builtin

2022-11-18 Thread Dmitry Baryshkov
On 18/11/2022 15:16, Kalyan Thota wrote: Since DRM encoder type for few encoders can be similar (like eDP and DP) find out if the interface supports HPD from encoder bridge to differentiate between builtin and pluggable displays. Changes in v1: - add connector type in the disp_info (Dmitry) - ad

Re: [PATCH v3 3/3] drm/msm/disp/dpu1: add color management support for the crtc

2022-11-18 Thread Dmitry Baryshkov
On 18/11/2022 15:16, Kalyan Thota wrote: Add color management support for the crtc provided there are enough dspps that can be allocated from the catalog. Changes in v1: - cache color enabled state in the dpu crtc obj (Dmitry) - simplify dspp allocation while creating crtc (Dmitry) - register fo

Re: [PATCH 1/7] drm/hisilicon/hibmc: Fix preferred depth and bpp

2022-11-18 Thread Javier Martinez Canillas
Hello Thomas, On 11/16/22 17:09, Thomas Zimmermann wrote: > Set the preferred color depth to 24 bits and the fbdev bpp to 32 > bits. This will signal XRGB as default format to clients. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 4 ++-- > 1

[PATCH v2] drm/msm/hdmi: remove unnecessary NULL check

2022-11-18 Thread Dan Carpenter
This code was recently refactored in commit and now the "hdmi" pointer can't be NULL. Checking for NULL leads to a Smatch warning: drivers/gpu/drm/msm/hdmi/hdmi.c:141 msm_hdmi_init() warn: variable dereferenced before check 'hdmi' (see line 119) Fixes: 69a88d8633ec ("drm/msm/hdmi: move r

Re: [PATCH 2/7] drm/logicvc: Fix preferred fbdev cpp

2022-11-18 Thread Javier Martinez Canillas
On 11/16/22 17:09, Thomas Zimmermann wrote: > Logicvc can have different values for the preferred color depth. Set > the fbdev bpp value depending on the runtime value. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/logicvc/logicvc_drm.c | 14 +- > 1 file changed, 13 in

Re: [PATCH 01/23] dt-bindings: display: tegra: add bindings for Tegra20 VIP

2022-11-18 Thread Krzysztof Kozlowski
On 18/11/2022 10:08, Luca Ceresoli wrote: > description: parallel video capture interface for the VI > >>> +type: object >> >> Do you expect it to grow to more channels? > > Not on Tegra20, it has one input only, but for other SoCs it's likely. > Definitely some (including Tegra20 itself)

Re: [PATCH 1/7] drm/hisilicon/hibmc: Fix preferred depth and bpp

2022-11-18 Thread Thomas Zimmermann
Hi Javier Am 18.11.22 um 13:52 schrieb Javier Martinez Canillas: Hello Thomas, On 11/16/22 17:09, Thomas Zimmermann wrote: Set the preferred color depth to 24 bits and the fbdev bpp to 32 bits. This will signal XRGB as default format to clients. Signed-off-by: Thomas Zimmermann --- dri

Re: [PATCH 2/7] drm/logicvc: Fix preferred fbdev cpp

2022-11-18 Thread Thomas Zimmermann
Hi Am 18.11.22 um 14:08 schrieb Javier Martinez Canillas: On 11/16/22 17:09, Thomas Zimmermann wrote: Logicvc can have different values for the preferred color depth. Set the fbdev bpp value depending on the runtime value. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/logicvc/logicvc

Re: [PATCH v2 07/18] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC

2022-11-18 Thread Bryan O'Donoghue
On 08/11/2022 12:46, Dmitry Baryshkov wrote: On 08/11/2022 02:56, Bryan O'Donoghue wrote: Currently we do not differentiate between the various users of the qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one compatible string but, the hardware does have some significant diffe

Re: [PATCH v2 07/18] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC

2022-11-18 Thread Dmitry Baryshkov
On 18/11/2022 15:29, Bryan O'Donoghue wrote: On 08/11/2022 12:46, Dmitry Baryshkov wrote: On 08/11/2022 02:56, Bryan O'Donoghue wrote: Currently we do not differentiate between the various users of the qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one compatible string but,

Re: [PATCH 1/7] drm/hisilicon/hibmc: Fix preferred depth and bpp

2022-11-18 Thread Javier Martinez Canillas
On 11/18/22 14:18, Thomas Zimmermann wrote: [...] >> >> In the cover letter you said "color depth is the number of color and alpha >> bits >> that affect image composition" but it should be "only the number of color >> bits >> excluding the alpha bits" a better description right? > > I was loo

[PATCH 0/3] drm/fb-helper: Restore damage worker

2022-11-18 Thread Thomas Zimmermann
It turns out that the removal of the damage worker can lead to locking cycles. The display update now runs while holding the fbdefio lock, which conflicts with locks in the modesetting code that updates the display. There's no easy fix for this, so let's restore the damage worker. The display updat

[PATCH 1/3] Revert "drm/fb-helper: Remove damage worker"

2022-11-18 Thread Thomas Zimmermann
This reverts commit 27c3e9452d552ea86369a94f23287a9675f2d7a1. Needed to restore the fbdev damage worker. There have been bug reports about locking order [1] and incorrectly takens branches. [2] Restore the damage worker until these problems have been resovled. Signed-off-by: Thomas Zimmermann Li

[PATCH 2/3] Revert "drm/fb-helper: Schedule deferred-I/O worker after writing to framebuffer"

2022-11-18 Thread Thomas Zimmermann
This reverts commit 7f5cc4a3e5e4c5a38e5748defc952e45278f7a70. Needed to restore the fbdev damage worker. There have been bug reports about locking order [1] and incorrectly takens branches. [2] Restore the damage worker until these problems have been resovled. Signed-off-by: Thomas Zimmermann Li

[PATCH 3/3] Revert "drm/fb-helper: Perform damage handling in deferred-I/O helper"

2022-11-18 Thread Thomas Zimmermann
This reverts commit 5fc586a058babc71c82a038477581b7bfe1c6e2a. Needed to restore the fbdev damage worker. There have been bug reports about locking order [1] and incorrectly takens branches. [2] Restore the damage worker until these problems have been resovled. Signed-off-by: Thomas Zimmermann Li

Re: [PATCH 2/7] drm/logicvc: Fix preferred fbdev cpp

2022-11-18 Thread Javier Martinez Canillas
On 11/18/22 14:22, Thomas Zimmermann wrote: [...] >> >> I'm also not sure if this is needed. Since IIUC in logicvc_mode_init() the >> driver does: >> >> preferred_depth = layer_primary->formats->depth; >> >> /* DRM counts alpha in depth, our driver doesn't. */ >> if (layer_primary-

Re: [PATCH 3/7] drm/cirrus: Decouple fbdev bpp value from color depth

2022-11-18 Thread Javier Martinez Canillas
On 11/16/22 17:09, Thomas Zimmermann wrote: > Cirrus has a preferred color depth of 16 bit; also use it as fbdev > bpp value. Don't use the color depth directly. It has a different > meaning than bpp and both cannot be used interchangeably. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gp

Re: [PATCH 2/7] drm/logicvc: Fix preferred fbdev cpp

2022-11-18 Thread Thomas Zimmermann
Hi Am 18.11.22 um 14:41 schrieb Javier Martinez Canillas: On 11/18/22 14:22, Thomas Zimmermann wrote: [...] I'm also not sure if this is needed. Since IIUC in logicvc_mode_init() the driver does: preferred_depth = layer_primary->formats->depth; /* DRM counts alpha in depth,

Re: [PATCH v3 4/8] drm/simpledrm: Use struct iosys_map consistently

2022-11-18 Thread Thomas Zimmermann
Hi Am 17.11.22 um 19:40 schrieb Thierry Reding: From: Thierry Reding The majority of the driver already uses struct iosys_map to encapsulate accesses to I/O remapped vs. system memory. Accesses via the screen base pointer still use __iomem annotations, which can lead to inconsistencies and con

Re: [PATCH 2/7] drm/logicvc: Fix preferred fbdev cpp

2022-11-18 Thread Javier Martinez Canillas
On 11/18/22 14:48, Thomas Zimmermann wrote: [...] >>> >> >> Ah, I see. So is to set 32-bit bpp for both XRGB and ARGB. But then >> I think that you also need to fix logicvc_mode_init() to remove that += 8? >> >> Because right now the preferred_depth += 8 would set a preferred_depth of 32

Re: [PATCH 4/7] drm/ofdrm: Set preferred depth from format of scanout buffer

2022-11-18 Thread Javier Martinez Canillas
On 11/16/22 17:09, Thomas Zimmermann wrote: > Set the preferred depth from the format of the scanout buffer. The > value cannot be hardcoded, as the scanout buffer's is only known at > runtime. Keeping the existing switch statement just duplicates the > driver's existing logic for format detection.

Re: [PATCH 5/7] drm/simpledrm: Set preferred depth from format of scanout buffer

2022-11-18 Thread Javier Martinez Canillas
On 11/16/22 17:09, Thomas Zimmermann wrote: > Set the preferred depth from the format of the scanout buffer. The > value cannot be hardcoded, as the scanout buffer's is only known at > runtime. Also derive the fbdev emulations bpp value from the scanout > format. > > Signed-off-by: Thomas Zimmerma

Re: [PATCH 6/7] drm/solomon: Set preferred color depth and bpp to the correct values

2022-11-18 Thread Javier Martinez Canillas
On 11/16/22 17:09, Thomas Zimmermann wrote: > Set the preferred color depth to 24 bits and the fbdev bpp to 32 > bits. This will signal XRGB as default format to clients. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Cani

Re: [PATCH 1/2] dt-bindings: display: simple: add support for InnoLux G070ACE-L01

2022-11-18 Thread Krzysztof Kozlowski
On 18/11/2022 08:58, richard.leit...@linux.dev wrote: > From: Richard Leitner > > Add Innolux G070ACE-L01 7" WVGA (800x480) TFT LCD panel compatible > string. Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v3 5/8] drm/simpledrm: Add support for system memory framebuffers

2022-11-18 Thread Thomas Zimmermann
Hi Am 17.11.22 um 19:40 schrieb Thierry Reding: From: Thierry Reding Simple framebuffers can be set up in system memory, which cannot be requested and/or I/O remapped using the I/O resource helpers. Add a separate code path that obtains system memory framebuffers from the reserved memory regio

Re: [PATCH 7/7] drm/fb-helper: Don't use the preferred depth for the BPP default

2022-11-18 Thread Javier Martinez Canillas
On 11/16/22 17:09, Thomas Zimmermann wrote: > If no preferred value for bits-per-pixel has been given, fall back > to 32. Never use the preferred depth. The color depth is the number > of color/alpha bits per pixel, while bpp is the overall number of > bits in most cases. > > Most noteworthy, XRGB

Re: [PATCH v3 5/8] drm/simpledrm: Add support for system memory framebuffers

2022-11-18 Thread Thomas Zimmermann
Hi Am 17.11.22 um 19:40 schrieb Thierry Reding: From: Thierry Reding Simple framebuffers can be set up in system memory, which cannot be requested and/or I/O remapped using the I/O resource helpers. Add a separate code path that obtains system memory framebuffers from the reserved memory regio

Re: [PATCH v2] amdgpu: nbio_v7_4: Add pointer check

2022-11-18 Thread Alex Deucher
On Fri, Nov 18, 2022 at 9:11 AM Denis Arefev wrote: > > Return value of a function 'amdgpu_ras_find_obj' is dereferenced > at nbio_v7_4.c:325 without checking for null > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Signed-off-by: Denis Arefev > --- > drivers/gpu/drm/am

Re: [Intel-gfx] [PATCH 1/1] drm/i915/mtl: Enable Idle Messaging for GSC CS

2022-11-18 Thread Rodrigo Vivi
On Fri, Nov 18, 2022 at 09:35:41AM +0530, Nilawar, Badal wrote: > > > On 18-11-2022 03:44, Rodrigo Vivi wrote: > > On Tue, Nov 15, 2022 at 07:14:40PM +0530, Badal Nilawar wrote: > > > From: Vinay Belgaumkar > > > > > > By defaut idle mesaging is disabled for GSC CS so to unblock RC6 > > > entry

RE: [PATCH v3 2/3] drm/msm/disp/dpu1: add helper to know if display is builtin

2022-11-18 Thread Kalyan Thota
>-Original Message- >From: Dmitry Baryshkov >Sent: Friday, November 18, 2022 6:09 PM >To: Kalyan Thota (QUIC) ; dri- >de...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; >freedr...@lists.freedesktop.org; devicet...@vger.kernel.org >Cc: linux-ker...@vger.kernel.org; robdcl...@chro

Re: [Intel-gfx] [PATCH 1/1] drm/i915/mtl: Enable Idle Messaging for GSC CS

2022-11-18 Thread Rodrigo Vivi
On Fri, Nov 18, 2022 at 09:32:37AM -0500, Rodrigo Vivi wrote: > On Fri, Nov 18, 2022 at 09:35:41AM +0530, Nilawar, Badal wrote: > > > > > > On 18-11-2022 03:44, Rodrigo Vivi wrote: > > > On Tue, Nov 15, 2022 at 07:14:40PM +0530, Badal Nilawar wrote: > > > > From: Vinay Belgaumkar > > > > > > >

Re: [PATCH v2] drm/msm/hdmi: remove unnecessary NULL check

2022-11-18 Thread Abhinav Kumar
On 11/18/2022 5:03 AM, Dan Carpenter wrote: This code was recently refactored in commit and now the "hdmi" pointer can't be NULL. Checking for NULL leads to a Smatch warning: drivers/gpu/drm/msm/hdmi/hdmi.c:141 msm_hdmi_init() warn: variable dereferenced before check 'hdmi' (see li

[GIT PULL] etnaviv-next for 6.2

2022-11-18 Thread Lucas Stach
Hi Dave, hi Daniel, please pull the following etnaviv changes for the next merge window. Mostly some small workarounds to get new hardware support going. But also more fixes to the softpin MMU handling and a nice addition from Christian to make the kernel logs on hang detection more useful. Regar

Re: [PATCH printk v5 00/40] reduce console_lock scope

2022-11-18 Thread Petr Mladek
On Fri 2022-11-18 12:22:58, Petr Mladek wrote: > On Wed 2022-11-16 17:27:12, John Ogness wrote: > > This is v5 of a series to prepare for threaded/atomic > > printing. v4 is here [0]. This series focuses on reducing the > > scope of the BKL console_lock. It achieves this by switching to > > SRCU an

Re: [PATCH v3 2/3] drm/msm/disp/dpu1: add helper to know if display is builtin

2022-11-18 Thread Dmitry Baryshkov
On 18/11/2022 16:37, Kalyan Thota wrote: -Original Message- From: Dmitry Baryshkov Sent: Friday, November 18, 2022 6:09 PM To: Kalyan Thota (QUIC) ; dri- de...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; freedr...@lists.freedesktop.org; devicet...@vger.kernel.org Cc: linux-k

Re: [PATCH v3 6/8] drm/format-helper: Support the XB24 format

2022-11-18 Thread Thomas Zimmermann
Am 17.11.22 um 19:40 schrieb Thierry Reding: From: Thierry Reding Add a conversion helper for the XB24 format to use in drm_fb_blit(). Signed-off-by: Thierry Reding Reviewed-by: Thomas Zimmermann --- Changes in v3: - rebase onto latest drm-next Changes in v2: - support XB24 format ins

[bug report] drm: rcar-du: Add RZ/G2L DSI driver

2022-11-18 Thread Dan Carpenter
Hello Biju Das, The patch 7a043f978ed1: "drm: rcar-du: Add RZ/G2L DSI driver" from Sep 20, 2022, leads to the following Smatch static checker warning: drivers/gpu/drm/rcar-du/rzg2l_mipi_dsi.c:372 rzg2l_mipi_dsi_set_display_timing() warn: uninitialized special assign 'vich1ppsetr

Re: [PATCH] drm/amd/display: add FB_DAMAGE_CLIPS support

2022-11-18 Thread Hamza Mahfooz
Hey Leo, On 11/17/22 12:31, Leo Li wrote: On 11/15/22 15:24, Hamza Mahfooz wrote: Currently, userspace doesn't have a way to communicate selective updates to displays. So, enable support for FB_DAMAGE_CLIPS for DCN ASICs newer than DCN301, convert DRM damage clips to dc dirty rectangles and f

Re: [PATCH v3 7/8] drm/simpledrm: Support the XB24/AB24 format

2022-11-18 Thread Thomas Zimmermann
Hi Am 17.11.22 um 19:40 schrieb Thierry Reding: From: Thierry Reding Add XB24 and AB24 to the list of supported formats. The format helpers support conversion to these formats and they are documented in the simple-framebuffer device tree bindings. Signed-off-by: Thierry Reding --- Changes in

RE: [PATCH] drm/i915: rename intel_gsc to intel_heci_gsc

2022-11-18 Thread Winkler, Tomas
> > > On 11/3/2022 3:41 AM, Winkler, Tomas wrote: > >> Starting on MTL, the GSC FW is loaded at runtime and will be managed > >> directly by i915. This means we now have a naming clash around the > >> GSC, as we have 2 different aspects of it that we need to handle: the > >> HECI interfaces we e

call to __compiletime_assert_1441 declared with attribute error: FIELD_PREP: mask is not constant

2022-11-18 Thread Borislav Petkov
Hi, I'm getting this on latest Linus master with gcc (SUSE Linux) 7.5.0: DESCEND objtool CALLscripts/checksyscalls.sh CC [M] drivers/gpu/drm/i915/gt/uc/intel_guc_submission.o In file included from :0:0: In function ‘__guc_context_policy_add_priority.isra.45’, inlined from ‘__guc_co

RE: [bug report] drm: rcar-du: Add RZ/G2L DSI driver

2022-11-18 Thread Biju Das
Hi Dan Carpenter, Thanks for the feedback. > Subject: [bug report] drm: rcar-du: Add RZ/G2L DSI driver > > Hello Biju Das, > > The patch 7a043f978ed1: "drm: rcar-du: Add RZ/G2L DSI driver" from Sep > 20, 2022, leads to the following Smatch static checker warning: > > drivers/gpu/drm/rcar

Re: [PATCH v3 5/8] drm/simpledrm: Add support for system memory framebuffers

2022-11-18 Thread Thierry Reding
On Fri, Nov 18, 2022 at 03:21:14PM +0100, Thomas Zimmermann wrote: > Hi > > Am 17.11.22 um 19:40 schrieb Thierry Reding: > > From: Thierry Reding > > > > Simple framebuffers can be set up in system memory, which cannot be > > requested and/or I/O remapped using the I/O resource helpers. Add a >

Re: [PATCH 2/3] drm/tiny: ili9486: Do not assume 8-bit only SPI controllers

2022-11-18 Thread Mark Brown
On Fri, Nov 18, 2022 at 11:36:27AM +0100, Carlo Caione wrote: > On 17/11/2022 15:59, Mark Brown wrote: > > So this is an issue in the MIPI DBI code where the interpretation of the > > buffer passed in depends on both the a caller parameter and the > > capabilities of the underlying SPI controller,

Re: [PATCH v3 7/8] drm/simpledrm: Support the XB24/AB24 format

2022-11-18 Thread Thierry Reding
On Fri, Nov 18, 2022 at 04:08:23PM +0100, Thomas Zimmermann wrote: > Hi > > Am 17.11.22 um 19:40 schrieb Thierry Reding: > > From: Thierry Reding > > > > Add XB24 and AB24 to the list of supported formats. The format helpers > > support conversion to these formats and they are documented in the

Re: The state of Quantization Range handling

2022-11-18 Thread Dave Stevenson
Hi Pekka On Fri, 18 Nov 2022 at 10:15, Pekka Paalanen wrote: > > On Thu, 17 Nov 2022 22:13:26 +0100 > Sebastian Wick wrote: > > > Hi Dave, > > > > I noticed that I didn't get the Broadcast RGB property thanks to you > > (more below) > > > > On Tue, Nov 15, 2022 at 2:16 PM Dave Stevenson > > wro

Re: [PATCH v3 5/8] drm/simpledrm: Add support for system memory framebuffers

2022-11-18 Thread Thomas Zimmermann
Hi Am 18.11.22 um 16:38 schrieb Thierry Reding: On Fri, Nov 18, 2022 at 03:21:14PM +0100, Thomas Zimmermann wrote: Hi Am 17.11.22 um 19:40 schrieb Thierry Reding: From: Thierry Reding Simple framebuffers can be set up in system memory, which cannot be requested and/or I/O remapped using the

Re: [PATCH v3 7/8] drm/simpledrm: Support the XB24/AB24 format

2022-11-18 Thread Thomas Zimmermann
Hi Am 18.11.22 um 16:44 schrieb Thierry Reding: On Fri, Nov 18, 2022 at 04:08:23PM +0100, Thomas Zimmermann wrote: Hi Am 17.11.22 um 19:40 schrieb Thierry Reding: From: Thierry Reding Add XB24 and AB24 to the list of supported formats. The format helpers support conversion to these formats

Re: DRM-managed resources / devm_drm_dev_alloc leaking resources

2022-11-18 Thread Maxime Ripard
Hi, Javier and I looked into it some more today, and I think we have a better idea of what is going on. On Thu, Nov 17, 2022 at 05:53:11PM +0100, Maxime Ripard wrote: > After trying to get more kunit tests for KMS, I found out that the > recent kunit helpers we merged to create a DRM device [1] a

Re: [PATCH mm-unstable v1 01/20] selftests/vm: anon_cow: prepare for non-anonymous COW tests

2022-11-18 Thread Vlastimil Babka
On 11/16/22 11:26, David Hildenbrand wrote: > Originally, the plan was to have a separate tests for testing COW of > non-anonymous (e.g., shared zeropage) pages. > > Turns out, that we'd need a lot of similar functionality and that there > isn't a really good reason to separate it. So let's prepar

Re: [PATCH v3 5/8] drm/simpledrm: Add support for system memory framebuffers

2022-11-18 Thread Thierry Reding
On Fri, Nov 18, 2022 at 04:54:31PM +0100, Thomas Zimmermann wrote: > Hi > > Am 18.11.22 um 16:38 schrieb Thierry Reding: > > On Fri, Nov 18, 2022 at 03:21:14PM +0100, Thomas Zimmermann wrote: > > > Hi > > > > > > Am 17.11.22 um 19:40 schrieb Thierry Reding: > > > > From: Thierry Reding > > > >

Re: [PATCH v3 7/8] drm/simpledrm: Support the XB24/AB24 format

2022-11-18 Thread Thierry Reding
On Fri, Nov 18, 2022 at 05:10:38PM +0100, Thomas Zimmermann wrote: > Hi > > Am 18.11.22 um 16:44 schrieb Thierry Reding: > > On Fri, Nov 18, 2022 at 04:08:23PM +0100, Thomas Zimmermann wrote: > > > Hi > > > > > > Am 17.11.22 um 19:40 schrieb Thierry Reding: > > > > From: Thierry Reding > > > >

[PATCH v4 1/2] arm64: dts: qcom: add data-lanes and link-freuencies into dp_out endpoint

2022-11-18 Thread Kuogee Hsieh
Add both data-lanes and link-frequencies property to dp_out endpoint. Also set link-frequencies to 81 khz at herobrine platform to have max link rate limited at 81 khz (HBR3). Signed-off-by: Kuogee Hsieh --- arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 9 - arch/arm64/boot/d

[PATCH v4 0/2] Add data-lanes and link-frequencies to dp_out endpoint

2022-11-18 Thread Kuogee Hsieh
Add DP both data-lanes and link-frequencies property to dp_out endpoint and support functions to DP driver. Kuogee Hsieh (2): arm64: dts: qcom: add data-lanes and link-freuencies into dp_out endpoint drm/msm/dp: add support of max dp link rate arch/arm64/boot/dts/qcom/sc7180-trogdor.dts

[PATCH v4 2/2] drm/msm/dp: add support of max dp link rate

2022-11-18 Thread Kuogee Hsieh
dp_out endpoint contains both data-lanes and link-frequencies properties. This patch parser dp_out endpoint properties and acquire dp_max_lanes and dp_max_link_rate from respective property. Finally, comparing them against both data lane and link rate read back from sink to ensure both data lane an

Re: [PATCH v4 0/2] Add data-lanes and link-frequencies to dp_out endpoint

2022-11-18 Thread Dmitry Baryshkov
On 18/11/2022 18:36, Kuogee Hsieh wrote: Add DP both data-lanes and link-frequencies property to dp_out endpoint and support functions to DP driver. Kuogee Hsieh (2): arm64: dts: qcom: add data-lanes and link-freuencies into dp_out endpoint drm/msm/dp: add support of max dp link rate

Re: [PATCH] fbdev: da8xx-fb: add missing regulator_disable() in fb_probe

2022-11-18 Thread Helge Deller
On 11/18/22 15:14, Dongliang Mu wrote: The error handling code in fb_probe misses regulator_disable if regulator_enable is called successfully. The previous commit only adds regulator_disable in the .remove(), forgetting the error handling code in the .probe. Fix this by adding a new error label

Re: [PATCH mm-unstable v1 04/20] mm: add early FAULT_FLAG_UNSHARE consistency checks

2022-11-18 Thread Vlastimil Babka
On 11/16/22 11:26, David Hildenbrand wrote: > For now, FAULT_FLAG_UNSHARE only applies to anonymous pages, which > implies a COW mapping. Let's hide FAULT_FLAG_UNSHARE early if we're not > dealing with a COW mapping, such that we treat it like a read fault as > documented and don't have to worry ab

Coverity: intel_hti_uses_phy(): Integer handling issues

2022-11-18 Thread coverity-bot
Hello! This is an experimental semi-automated report about issues detected by Coverity from a scan of next-20221118 as part of the linux-next scan project: https://scan.coverity.com/projects/linux-next-weekly-scan You're getting this email because you were associated with the identified lin

Coverity: pre_compute_mst_dsc_configs_for_state(): Uninitialized variables

2022-11-18 Thread coverity-bot
Hello! This is an experimental semi-automated report about issues detected by Coverity from a scan of next-20221118 as part of the linux-next scan project: https://scan.coverity.com/projects/linux-next-weekly-scan You're getting this email because you were associated with the identified lin

[syzbot] inconsistent lock state in mark_held_locks

2022-11-18 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:e01d50cbd6ee Merge tag 'vfio-v6.1-rc6' of https://github.c.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=145f640188 kernel config: https://syzkaller.appspot.com/x/.config?x=e9039cbe1d7613aa das

Re: [PATCH mm-unstable v1 05/20] mm: add early FAULT_FLAG_WRITE consistency checks

2022-11-18 Thread Vlastimil Babka
On 11/16/22 11:26, David Hildenbrand wrote: > Let's catch abuse of FAULT_FLAG_WRITE early, such that we don't have to > care in all other handlers and might get "surprises" if we forget to do > so. > > Write faults without VM_MAYWRITE don't make any sense, and our > maybe_mkwrite() logic could hav

  1   2   3   >