[PATCH v3] drm/i915/mtl: Enable Idle Messaging for GSC CS

2022-11-17 Thread Badal Nilawar
From: Vinay Belgaumkar By defaut idle mesaging is disabled for GSC CS so to unblock RC6 entry on media tile idle messaging need to be enabled. v2: - Fix review comments (Vinay) - Set GSC idle hysteresis (Badal) v3: - Fix review comments (Rodrigo) Bspec: 71496 Cc: Daniele Ceraolo Spurio Sig

Re: [PATCH] drm/atomic: add quirks for blind save/restore

2022-11-17 Thread Pekka Paalanen
On Thu, 17 Nov 2022 07:54:40 + Simon Ser wrote: > Two quirks to make blind atomic save/restore [1] work correctly: > > - Mark the DPMS property as immutable for atomic clients, since > atomic clients cannot change it. > - Allow user-space to set content protection to "enabled", interpret >

[PULL] drm-misc-next

2022-11-17 Thread Maxime Ripard
Hi Dave, Daniel, Here's this week drm-misc-next PR. Given we're at rc5 already, it's probably going to be the last for 6.2. Thanks! Maxime drm-misc-next-2022-11-17: drm-misc-next for 6.2: UAPI Changes: Cross-subsystem Changes: - fbdev: Add support for the nomodeset kernel parameter Core Chang

[PULL] drm-intel-fixes

2022-11-17 Thread Tvrtko Ursulin
Hi Dave, Daniel, Just one fix for the release candidate window this week and that is for a possible use-after-free on discrete platforms with small BAR. Regards, Tvrtko drm-intel-fixes-2022-11-17: - Fix uaf with lmem_userfault_list handling (Matthew Auld) The following changes since commit 0942

Re: [PATCH 3/3] spi: meson-spicc: Lower CS between bursts

2022-11-17 Thread Neil Armstrong
Hi, On 17/11/2022 09:47, Carlo Caione wrote: On some hardware (reproduced on S905X) when a large payload is transmitted over SPI in bursts at the end of each burst, the clock line briefly fluctuates creating spurious clock transitions that are being recognised by the connected device as a genuin

Re: [PATCH v3 0/6] Add support for atomic async page-flips

2022-11-17 Thread Simon Ser
Ville, any news on this?

Re: [PATCH v4] udmabuf: add vmap and vunmap methods to udmabuf_ops

2022-11-17 Thread Dmitry Osipenko
Hi, On 11/17/22 07:58, Lukasz Wiecaszek wrote: > The reason behind that patch is associated with videobuf2 subsystem > (or more genrally with v4l2 framework) and user created > dma buffers (udmabuf). In some circumstances > when dealing with V4L2_MEMORY_DMABUF buffers videobuf2 subsystem > wants t

Re: [PATCH v5] drm/mediatek: Add AFBC support to Mediatek DRM driver

2022-11-17 Thread AngeloGioacchino Del Regno
Il 16/11/22 20:33, Justin Green ha scritto: From: Justin Green Tested on MT8195 and confirmed both correct video output and improved DRAM bandwidth performance. v5: * Removed some dead defines. * Refactored mtk_ovl_set_afbc(). v4: * Move modifier validation to format_mod_supported function. *

[PATCH v10 00/19] drm: Analog TV Improvements

2022-11-17 Thread Maxime Ripard
Hi, Here's a series aiming at improving the command line named modes support, and more importantly how we deal with all the analog TV variants. The named modes support were initially introduced to allow to specify the analog TV mode to be used. However, this was causing multiple issues: * The

[PATCH v10 01/19] drm/tests: client: Mention that we can't use MODULE_ macros

2022-11-17 Thread Maxime Ripard
That file is included directly, so we can't use any MODULE macro. Let's leave a comment to avoid any future mistake. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_client_modeset_test.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_client_modeset_

[PATCH v10 02/19] drm/connector: Rename legacy TV property

2022-11-17 Thread Maxime Ripard
The current tv_mode has driver-specific values that don't allow to easily share code using it, either at the userspace or kernel level. Since we're going to introduce a new, generic, property that fit the same purpose, let's rename this one to legacy_tv_mode to make it obvious we should move away

[PATCH v10 03/19] drm/connector: Only register TV mode property if present

2022-11-17 Thread Maxime Ripard
The drm_create_tv_properties() will create the TV mode property unconditionally. However, since we'll gradually phase it out, let's register it only if we have a list passed as an argument. This will make the transition easier. Acked-by: Noralf Trønnes Tested-by: Mateusz Kwiatkowski Signed-off-

[PATCH v10 04/19] drm/connector: Rename drm_mode_create_tv_properties

2022-11-17 Thread Maxime Ripard
drm_mode_create_tv_properties(), among other things, will create the "mode" property that stores the analog TV mode that connector is supposed to output. However, that property is getting deprecated, so let's rename that function to mention it's deprecated. We'll introduce a new variant of that fu

[PATCH v10 05/19] drm/connector: Add TV standard property

2022-11-17 Thread Maxime Ripard
The TV mode property has been around for a while now to select and get the current TV mode output on an analog TV connector. Despite that property name being generic, its content isn't and has been driver-specific which makes it hard to build any generic behaviour on top of it, both in kernel and

[PATCH v10 07/19] drm/connector: Add a function to lookup a TV mode by its name

2022-11-17 Thread Maxime Ripard
As part of the command line parsing rework coming in the next patches, we'll need to lookup drm_connector_tv_mode values by their name, already defined in drm_tv_mode_enum_list. In order to avoid any code duplication, let's do a function that will perform a lookup of a TV mode name and return its

[PATCH v10 06/19] drm/modes: Add a function to generate analog display modes

2022-11-17 Thread Maxime Ripard
Multiple drivers (meson, vc4, sun4i) define analog TV 525-lines and 625-lines modes in their drivers. Since those modes are fairly standard, and that we'll need to use them in more places in the future, it makes sense to move their definition into the core framework. However, analog display usual

[PATCH v10 08/19] drm/modes: Introduce the tv_mode property as a command-line option

2022-11-17 Thread Maxime Ripard
Our new tv mode option allows to specify the TV mode from a property. However, it can still be useful, for example to avoid any boot time artifact, to set that property directly from the kernel command line. Let's add some code to allow it, and some unit tests to exercise that code. Reviewed-by:

[PATCH v10 09/19] drm/modes: Properly generate a drm_display_mode from a named mode

2022-11-17 Thread Maxime Ripard
The framework will get the drm_display_mode from the drm_cmdline_mode it got by parsing the video command line argument by calling drm_connector_pick_cmdline_mode(). The heavy lifting will then be done by the drm_mode_create_from_cmdline_mode() function. In the case of the named modes though, the

[PATCH v10 10/19] drm/client: Remove match on mode name

2022-11-17 Thread Maxime Ripard
Commit 3aeeb13d8996 ("drm/modes: Support modes names on the command line") initially introduced the named modes support by essentially matching the name passed on the command-line to the mode names defined by the drivers. This proved to be difficult to work with, since all drivers had to provide p

[PATCH v10 11/19] drm/modes: Introduce more named modes

2022-11-17 Thread Maxime Ripard
Now that we can easily extend the named modes list, let's add a few more analog TV modes that were used in the wild, and some unit tests to make sure it works as intended. Reviewed-by: Noralf Trønnes Tested-by: Mateusz Kwiatkowski Signed-off-by: Maxime Ripard --- Changes in v9: - Document the

[PATCH v10 12/19] drm/probe-helper: Provide a TV get_modes helper

2022-11-17 Thread Maxime Ripard
From: Noralf Trønnes Most of the TV connectors will need a similar get_modes implementation that will, depending on the drivers' capabilities, register the 480i and 576i modes. That implementation will also need to set the preferred flag and order the modes based on the driver and users preferre

[PATCH v10 13/19] drm/atomic-helper: Add a TV properties reset helper

2022-11-17 Thread Maxime Ripard
The drm_tv_create_properties() function will create a bunch of properties, but it's up to each and every driver using that function to properly reset the state of these properties leading to inconsistent behaviours. Let's create a helper that will take care of it. Reviewed-by: Noralf Trønnes Tes

[PATCH v10 15/19] drm/vc4: vec: Use TV Reset implementation

2022-11-17 Thread Maxime Ripard
The analog TV properties created by the drm_mode_create_tv_properties() are not properly initialised at reset. Let's switch our implementation to call drm_atomic_helper_connector_tv_reset(). Reviewed-by: Noralf Trønnes Tested-by: Mateusz Kwiatkowski Signed-off-by: Maxime Ripard --- drivers/gpu

[PATCH v10 14/19] drm/atomic-helper: Add an analog TV atomic_check implementation

2022-11-17 Thread Maxime Ripard
The analog TV connector drivers share some atomic_check logic, and the new TV standard property have created some boilerplate that can be shared across drivers too. Let's create an atomic_check helper for those use cases. Reviewed-by: Noralf Trønnes Tested-by: Mateusz Kwiatkowski Signed-off-by:

[PATCH v10 17/19] drm/vc4: vec: Convert to the new TV mode property

2022-11-17 Thread Maxime Ripard
Now that the core can deal fine with analog TV modes, let's convert the vc4 VEC driver to leverage those new features. We've added some backward compatibility to support the old TV mode property and translate it into the new TV norm property. We're also making use of the new analog TV atomic_check

[PATCH v10 16/19] drm/vc4: vec: Check for VEC output constraints

2022-11-17 Thread Maxime Ripard
From: Mateusz Kwiatkowski The VEC can accept pretty much any relatively reasonable mode, but still has a bunch of constraints to meet. Let's create an atomic_check() implementation that will make sure we don't end up accepting a non-functional mode. Acked-by: Noralf Trønnes Signed-off-by: Mate

[PATCH v10 18/19] drm/vc4: vec: Add support for more analog TV standards

2022-11-17 Thread Maxime Ripard
From: Mateusz Kwiatkowski Add support for the following composite output modes (all of them are somewhat more obscure than the previously defined ones): - NTSC_443 - NTSC-style signal with the chroma subcarrier shifted to 4.43361875 MHz (the PAL subcarrier frequency). Never used for broadcas

[PATCH v10 19/19] drm/sun4i: tv: Convert to the new TV mode property

2022-11-17 Thread Maxime Ripard
Now that the core can deal fine with analog TV modes, let's convert the sun4i TV driver to leverage those new features. Acked-by: Noralf Trønnes Reviewed-by: Jernej Skrabec Signed-off-by: Maxime Ripard --- Changes in v6: - Convert to new get_modes helper Changes in v5: - Removed the count var

Re: Try to address the DMA-buf coherency problem

2022-11-17 Thread Tomasz Figa
Hi Christian and everyone, On Thu, Nov 3, 2022 at 4:14 AM Christian König wrote: > > Am 02.11.22 um 18:10 schrieb Lucas Stach: > > Am Mittwoch, dem 02.11.2022 um 13:21 +0100 schrieb Christian König: > > [SNIP] > >> It would just be doing this for the importer and exactly that > >> would be bad de

[RFC PATCH v7] media: mediatek: vcodec: support stateless AV1 decoder

2022-11-17 Thread Xiaoyong Lu
Add mediatek av1 decoder linux driver which use the stateless API in MT8195. Signed-off-by: Xiaoyong Lu --- Changes from v6: - change slot_id type from u8 to s8 - test by av1 fluster, result is 173/239 Changes from v5: - change av1 PROFILE and LEVEL cfg - test by av1 fluster, result is 173/239

Re: [PATCH 12/13] drm/scheduler: rework entity flush, kill and fini

2022-11-17 Thread Christian König
Am 17.11.22 um 03:36 schrieb Dmitry Osipenko: Hi, On 10/14/22 11:46, Christian König wrote: +/* Remove the entity from the scheduler and kill all pending jobs */ +static void drm_sched_entity_kill(struct drm_sched_entity *entity) +{ + struct drm_sched_job *job; + struct dma_fence *p

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Never return 0 on timeout when retiring requests

2022-11-17 Thread Das, Nirmoy
Looks very relevant to  our recent hangcheck failures. Acked-by: Nirmoy Das On 11/16/2022 12:25 PM, Janusz Krzysztofik wrote: Users of intel_gt_retire_requests_timeout() expect 0 return value on success. However, we have no protection from passing back 0 potentially returned by dma_fence_wai

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Fix negative remaining time after retire requests

2022-11-17 Thread Das, Nirmoy
On 11/16/2022 12:25 PM, Janusz Krzysztofik wrote: Commit b97060a99b01 ("drm/i915/guc: Update intel_gt_wait_for_idle to work with GuC") extended the API of intel_gt_retire_requests_timeout() with an extra argument 'remaining_timeout', intended for passing back unconsumed portion of requested time

Re: [PATCH] backlight: pwm_bl: Drop support for legacy PWM probing

2022-11-17 Thread Daniel Thompson
On Thu, Nov 17, 2022 at 08:21:51AM +0100, Uwe Kleine-König wrote: > There is no in-tree user left which relies on legacy probing. So drop > support for it which removes another user of the deprecated > pwm_request() function. > > Signed-off-by: Uwe Kleine-König I have to take the "no in-tree user

Re: [PATCH] dma-buf: Fix possible UAF in dma_buf_export

2022-11-17 Thread Christian König
Am 17.11.22 um 08:48 schrieb Charan Teja Kalla: Sometime back Dan also reported the same issue[1] where I do mentioned that fput()-->dma_buf_file_release() will remove it from the list. But it seems that I failed to notice fput() here calls the dma_buf_file_release() asynchronously i.e. dmabuf t

Re: [PATCH] backlight: pwm_bl: Drop support for legacy PWM probing

2022-11-17 Thread Uwe Kleine-König
On Thu, Nov 17, 2022 at 10:14:01AM +, Daniel Thompson wrote: > On Thu, Nov 17, 2022 at 08:21:51AM +0100, Uwe Kleine-König wrote: > > There is no in-tree user left which relies on legacy probing. So drop > > support for it which removes another user of the deprecated > > pwm_request() function.

Re: [PATCH v3] drm/msm/a6xx: Fix speed-bin detection vs probe-defer

2022-11-17 Thread Akhil P Oommen
On 11/15/2022 9:16 PM, Rob Clark wrote: From: Rob Clark If we get an error (other than -ENOENT) we need to propagate that up the stack. Otherwise if the nvmem driver hasn't probed yet, we'll end up end up claiming that we support all the OPPs which is not likely to be true (and on some generat

Re: [PATCH 3/3] spi: meson-spicc: Lower CS between bursts

2022-11-17 Thread Mark Brown
On Thu, Nov 17, 2022 at 09:47:41AM +0100, Carlo Caione wrote: > On some hardware (reproduced on S905X) when a large payload is > transmitted over SPI in bursts at the end of each burst, the clock line > briefly fluctuates creating spurious clock transitions that are being > recognised by the connec

Re: [PATCH] backlight: pwm_bl: Drop support for legacy PWM probing

2022-11-17 Thread Daniel Thompson
On Thu, Nov 17, 2022 at 11:28:14AM +0100, Uwe Kleine-König wrote: > On Thu, Nov 17, 2022 at 10:14:01AM +, Daniel Thompson wrote: > > On Thu, Nov 17, 2022 at 08:21:51AM +0100, Uwe Kleine-König wrote: > > > There is no in-tree user left which relies on legacy probing. So drop > > > support for it

[PATCH v6 1/3] drm_bridge: register content protect property

2022-11-17 Thread Hsin-Yi Wang
Some bridges are able to update HDCP status from userspace request if they support HDCP. HDCP property is the same as other connector properties that needs to be created after the connecter is initialized and before the connector is registered. If there exists a bridge that supports HDCP, add the

[PATCH v6 2/3] drm/bridge: anx7625: register content protect property

2022-11-17 Thread Hsin-Yi Wang
Set support_hdcp so the connector can register content protect proterty when it's initializing. Signed-off-by: Hsin-Yi Wang Reviewed-by: Sean Paul --- v5->v6: no change. --- drivers/gpu/drm/bridge/analogix/anx7625.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bridge/anal

[PATCH v6 3/3] drm/bridge: it6505: handle HDCP request

2022-11-17 Thread Hsin-Yi Wang
it6505 supports HDCP 1.3, but current implementation lacks the update of HDCP status through drm_hdcp_update_content_protection(). it6505 default enables the HDCP. If user set it to undesired then the driver will stop HDCP. Signed-off-by: Hsin-Yi Wang Reviewed-by: allen chen --- v5->v6: no chang

Re: [PATCH 2/3] drm/tiny: ili9486: Do not assume 8-bit only SPI controllers

2022-11-17 Thread Mark Brown
On Thu, Nov 17, 2022 at 09:47:40AM +0100, Carlo Caione wrote: > The ILI9486 driver is wrongly assuming that the SPI panel is interfaced > only with 8-bit SPI controllers and consequently that the pixel data > passed by the MIPI DBI subsystem are already swapped before being sent > over SPI using 8

Re: [PATCH 2/2] drm/i915: Ratelimit debug log in vm_fault_ttm

2022-11-17 Thread Matthew Auld
On 13/10/2022 09:40, Nirmoy Das wrote: Test like i915_gem_mman_live_selftests/igt_mmap_migrate can cause dmesg spamming. Use ratelimit api to reduce log rate. References: https://gitlab.freedesktop.org/drm/intel/-/issues/7038 Cc: Matthew Auld Signed-off-by: Nirmoy Das Reviewed-by: Matthew Aul

RE: [EXT] Re: [PATCH v3 05/10] dt-bindings: display: bridge: Add MHDP DP for i.MX8MQ

2022-11-17 Thread Sandor Yu
Hi Rob, Thanks your comments, > -Original Message- > From: Rob Herring > Sent: 2022年11月17日 0:27 > To: Sandor Yu > Cc: dri-devel@lists.freedesktop.org; devicet...@vger.kernel.org; > linux-arm-ker...@lists.infradead.org; linux-ker...@vger.kernel.org; > linux-...@lists.infradead.org; andrz

Re: [Intel-gfx] [PATCH 1/2] drm/print: Add drm_dbg_ratelimited

2022-11-17 Thread Matthew Auld
On Thu, 13 Oct 2022 at 09:40, Nirmoy Das wrote: > > Add a function for ratelimitted debug print. > > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Cc: David Airlie > Cc: Daniel Vetter > Signed-off-by: Nirmoy Das Reviewed-by: Matthew Auld > --- > include/drm/drm_print

[PATCH] fbdev: Make fb_modesetting_disabled() static inline

2022-11-17 Thread Thomas Zimmermann
Make fb_modesetting_disabled() a static-inline function when it is defined in the header file. Avoid the linker error shown below. ld: drivers/video/fbdev/core/fbmon.o: in function `fb_modesetting_disabled': fbmon.c:(.text+0x1e4): multiple definition of `fb_modesetting_disabled'; drivers/video/

Re: [PATCH] backlight: pwm_bl: Drop support for legacy PWM probing

2022-11-17 Thread Lee Jones
On Thu, 17 Nov 2022, Uwe Kleine-König wrote: > There is no in-tree user left which relies on legacy probing. So drop > support for it which removes another user of the deprecated > pwm_request() function. > > Signed-off-by: Uwe Kleine-König > --- > drivers/video/backlight/pwm_bl.c | 12

Re: [PATCH v10 01/19] drm/tests: client: Mention that we can't use MODULE_ macros

2022-11-17 Thread Noralf Trønnes
Den 17.11.2022 10.28, skrev Maxime Ripard: > That file is included directly, so we can't use any MODULE macro. Let's > leave a comment to avoid any future mistake. > > Signed-off-by: Maxime Ripard > --- Reviewed-by: Noralf Trønnes

Re: [PATCH] fbdev: Make fb_modesetting_disabled() static inline

2022-11-17 Thread Thomas Zimmermann
Am 17.11.22 um 12:47 schrieb Thomas Zimmermann: Make fb_modesetting_disabled() a static-inline function when it is defined in the header file. Avoid the linker error shown below. ld: drivers/video/fbdev/core/fbmon.o: in function `fb_modesetting_disabled': fbmon.c:(.text+0x1e4): multiple de

Re: Try to address the DMA-buf coherency problem

2022-11-17 Thread Christian König
Hi Tomasz, Am 17.11.22 um 10:35 schrieb Tomasz Figa: Hi Christian and everyone, On Thu, Nov 3, 2022 at 4:14 AM Christian König wrote: Am 02.11.22 um 18:10 schrieb Lucas Stach: Am Mittwoch, dem 02.11.2022 um 13:21 +0100 schrieb Christian König: [SNIP] It would just be doing this for the impo

[PATCH v1 0/8] Renesas V4H DSI & DP output support

2022-11-17 Thread Tomi Valkeinen
Hi, These add support for DSI on V4H SoC (r8a779g0) and DP for Whitehawk board. The last patch is a hack, but needed to get the DSI working. It is still unclear what the register write does, and as that patch is needed to get the DSI working, this series is not ready yet. But all the rest of the

[PATCH v1 1/8] dt-bindings: display: renesas, du: Provide bindings for r8a779g0

2022-11-17 Thread Tomi Valkeinen
From: Tomi Valkeinen Extend the Renesas DU display bindings to support the r8a779g0 V4H. Signed-off-by: Tomi Valkeinen --- Documentation/devicetree/bindings/display/renesas,du.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/renesas,du.yaml

[PATCH v1 8/8] HACK: drm: rcar-du: dsi: use-extal-clk hack

2022-11-17 Thread Tomi Valkeinen
From: Tomi Valkeinen Renesas BSP kernel does this for Whitehawk board. It is not clear what it does, as the bits are marked reserved in the SoC documentation. Do not merge. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c | 4 1 file changed, 4 insertions(+) dif

[PATCH v1 4/8] arm64: dts: renesas: r8a779g0: Add display related data

2022-11-17 Thread Tomi Valkeinen
From: Tomi Valkeinen Add DT nodes for components needed to get the DSI output working: - FCPv - VSPd - DU - DSI Signed-off-by: Tomi Valkeinen --- arch/arm64/boot/dts/renesas/r8a779g0.dtsi | 129 ++ 1 file changed, 129 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/

[PATCH v1 5/8] arm64: dts: renesas: white-hawk-cpu: Add DP output support

2022-11-17 Thread Tomi Valkeinen
From: Tomi Valkeinen Add DT nodes needed for the mini DP connector. The DP is driven by sn65dsi86, which in turn gets the pixel data from the SoC via DSI. Signed-off-by: Tomi Valkeinen --- .../dts/renesas/r8a779g0-white-hawk-cpu.dtsi | 94 +++ 1 file changed, 94 insertions(+)

[PATCH v1 6/8] drm: rcar-du: Add r8a779g0 support

2022-11-17 Thread Tomi Valkeinen
From: Tomi Valkeinen Add support for DU on r8a779g0, which is identical to DU on r8a779a0. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/dr

[PATCH v1 7/8] drm: rcar-du: dsi: Add r8A779g0 support

2022-11-17 Thread Tomi Valkeinen
From: Tomi Valkeinen Add DSI support for r8a779g0. The main differences to r8a779a0 are in the PLL and PHTW setups. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c | 484 +++ drivers/gpu/drm/rcar-du/rcar_mipi_dsi_regs.h | 6 +- 2 files changed,

[PATCH v1 3/8] clk: renesas: r8a779g0: Add display related clocks

2022-11-17 Thread Tomi Valkeinen
From: Tomi Valkeinen Add clocks related to display which are needed to get the DSI output working. Extracted from Renesas BSP tree. Signed-off-by: Tomi Valkeinen --- drivers/clk/renesas/r8a779g0-cpg-mssr.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/clk/renesas

[PATCH v1 2/8] dt-bindings: display: bridge: renesas, dsi-csi2-tx: Add r8a779g0

2022-11-17 Thread Tomi Valkeinen
From: Tomi Valkeinen Extend the Renesas DSI display bindings to support the r8a779g0 V4H. Signed-off-by: Tomi Valkeinen --- .../bindings/display/bridge/renesas,dsi-csi2-tx.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/di

Re: [PATCH v1 0/8] Renesas V4H DSI & DP output support

2022-11-17 Thread Tomi Valkeinen
On 17/11/2022 14:25, Tomi Valkeinen wrote: Hi, These add support for DSI on V4H SoC (r8a779g0) and DP for Whitehawk board. The last patch is a hack, but needed to get the DSI working. It is still unclear what the register write does, and as that patch is needed to get the DSI working, this seri

Re: [RFC PATCH v6] media: mediatek: vcodec: support stateless AV1 decoder

2022-11-17 Thread Andrzej Pietrasiewicz
Hi Xiaoyong Lu, Sorry about chiming in only at v6. Please see inline below. Andrzej W dniu 17.11.2022 o 07:17, Xiaoyong Lu pisze: Add mediatek av1 decoder linux driver which use the stateless API in MT8195. Signed-off-by: Xiaoyong Lu --- Changes from v5: - change av1 PROFILE and LEVEL cfg -

Re: [PATCH 12/13] drm/scheduler: rework entity flush, kill and fini

2022-11-17 Thread Dmitry Osipenko
On 11/17/22 12:53, Christian König wrote: > Am 17.11.22 um 03:36 schrieb Dmitry Osipenko: >> Hi, >> >> On 10/14/22 11:46, Christian König wrote: >>> +/* Remove the entity from the scheduler and kill all pending jobs */ >>> +static void drm_sched_entity_kill(struct drm_sched_entity *entity) >>> +{ >

Re: [PATCH 12/13] drm/scheduler: rework entity flush, kill and fini

2022-11-17 Thread Christian König
Am 17.11.22 um 13:47 schrieb Dmitry Osipenko: On 11/17/22 12:53, Christian König wrote: Am 17.11.22 um 03:36 schrieb Dmitry Osipenko: Hi, On 10/14/22 11:46, Christian König wrote: +/* Remove the entity from the scheduler and kill all pending jobs */ +static void drm_sched_entity_kill(struct d

Re: [v2,5/6] drm/fb-helper: Schedule deferred-I/O worker after writing to framebuffer

2022-11-17 Thread Marek Szyprowski
5_thermal ecdh_generic ecc libaes CPU: 0 PID: 220 Comm: systemd-udevd Not tainted 6.1.0-rc5-next-20221117-00041-g13334c897c2b #5953 Hardware name: BCM2835  unwind_backtrace from show_stack+0x10/0x14  show_stack from dump_stack_lvl+0x40/0x4c  dump_stack_lvl from __warn+0xc8/0x13c  __warn

Re: [PATCH 12/13] drm/scheduler: rework entity flush, kill and fini

2022-11-17 Thread Dmitry Osipenko
On 11/17/22 15:55, Christian König wrote: > Am 17.11.22 um 13:47 schrieb Dmitry Osipenko: >> On 11/17/22 12:53, Christian König wrote: >>> Am 17.11.22 um 03:36 schrieb Dmitry Osipenko: Hi, On 10/14/22 11:46, Christian König wrote: > +/* Remove the entity from the scheduler and ki

Re: [PATCH 12/13] drm/scheduler: rework entity flush, kill and fini

2022-11-17 Thread Dmitry Osipenko
On 11/17/22 15:59, Dmitry Osipenko wrote: > On 11/17/22 15:55, Christian König wrote: >> Am 17.11.22 um 13:47 schrieb Dmitry Osipenko: >>> On 11/17/22 12:53, Christian König wrote: Am 17.11.22 um 03:36 schrieb Dmitry Osipenko: > Hi, > > On 10/14/22 11:46, Christian König wrote: >>>

Re: [PATCH v8 06/14] drm: bridge: samsung-dsim: Handle proper DSI host initialization

2022-11-17 Thread Marek Szyprowski
On 17.11.2022 05:58, Marek Vasut wrote: > On 11/10/22 19:38, Jagan Teki wrote: >> DSI host initialization handling in previous exynos dsi driver has >> some pitfalls. It initializes the host during host transfer() hook >> that is indeed not the desired call flow for I2C and any other DSI >> configu

Re: [PATCH 12/13] drm/scheduler: rework entity flush, kill and fini

2022-11-17 Thread Christian König
Am 17.11.22 um 14:00 schrieb Dmitry Osipenko: On 11/17/22 15:59, Dmitry Osipenko wrote: On 11/17/22 15:55, Christian König wrote: Am 17.11.22 um 13:47 schrieb Dmitry Osipenko: On 11/17/22 12:53, Christian König wrote: Am 17.11.22 um 03:36 schrieb Dmitry Osipenko: Hi, On 10/14/22 11:46, Chri

Re: [PATCH V2 0/3] DSI host and peripheral initialisation ordering

2022-11-17 Thread Dmitry Baryshkov
On 15/11/2022 17:38, Dave Stevenson wrote: Hi Dmitry On Tue, 15 Nov 2022 at 14:21, Dmitry Baryshkov wrote: On 15/11/2022 17:14, Dave Stevenson wrote: Hi Dmitry On Sun, 13 Nov 2022 at 13:06, Dmitry Baryshkov wrote: Hi Dave, On 19/07/2022 16:45, Dave Stevenson wrote: Hi Sam On Mon, 18 J

Re: [Freedreno] [PATCH v2 03/12] drm/msm/dpu: Refactor sc7280_pp location

2022-11-17 Thread Abhinav Kumar
On 11/15/2022 5:30 AM, Robert Foss wrote: The sc7280_pp declaration is not located by the other _pp declarations, but rather hidden around the _merge_3d declarations. Let's fix this to avoid confusion. Signed-off-by: Robert Foss Reviewed-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar

Re: [PATCH v2] drm/gem-shmem: When drm_gem_object_init failed, should release object

2022-11-17 Thread Thomas Zimmermann
Hi Am 11.11.22 um 04:38 schrieb ChunyouTang: when goto err_free, the object had init, so it should be release when fail. Signed-off-by: ChunyouTang --- drivers/gpu/drm/drm_gem.c | 19 --- drivers/gpu/drm/drm_gem_shmem_helper.c | 4 +++- include/drm/drm_gem.h

Re: [PATCH v1 1/8] dt-bindings: display: renesas, du: Provide bindings for r8a779g0

2022-11-17 Thread Kieran Bingham
Quoting Tomi Valkeinen (2022-11-17 12:25:40) > From: Tomi Valkeinen > > Extend the Renesas DU display bindings to support the r8a779g0 V4H. > > Signed-off-by: Tomi Valkeinen Matches my expectations, and interpretations of the datasheets. Reviewed-by: Kieran Bingham > --- > Documentation/de

Re: [PATCH v1 2/8] dt-bindings: display: bridge: renesas, dsi-csi2-tx: Add r8a779g0

2022-11-17 Thread Kieran Bingham
Quoting Tomi Valkeinen (2022-11-17 12:25:41) > From: Tomi Valkeinen > > Extend the Renesas DSI display bindings to support the r8a779g0 V4H. > > Signed-off-by: Tomi Valkeinen > --- > .../bindings/display/bridge/renesas,dsi-csi2-tx.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 de

Re: [PATCH v3 2/7] drm/ivpu: Add Intel VPU MMU support

2022-11-17 Thread Jacek Lawrynowicz
Hi, On 10/27/2022 7:44 PM, Jeffrey Hugo wrote: > On 10/27/2022 3:14 AM, Jacek Lawrynowicz wrote: >> Hi, >> >> Thanks for an in-depth review. My responses are inline. >> >> On 10/26/2022 2:12 AM, Jeffrey Hugo wrote: >>> On 9/24/2022 9:11 AM, Jacek Lawrynowicz wrote: VPU Memory Management Unit

Re: [PATCH v1 3/8] clk: renesas: r8a779g0: Add display related clocks

2022-11-17 Thread Kieran Bingham
Quoting Tomi Valkeinen (2022-11-17 12:25:42) > From: Tomi Valkeinen > > Add clocks related to display which are needed to get the DSI output > working. > > Extracted from Renesas BSP tree. > > Signed-off-by: Tomi Valkeinen > --- > drivers/clk/renesas/r8a779g0-cpg-mssr.c | 14 ++ >

Re: [PATCH V2 0/3] DSI host and peripheral initialisation ordering

2022-11-17 Thread Maxime Ripard
On Thu, Nov 17, 2022 at 03:24:07PM +0200, Dmitry Baryshkov wrote: > On 15/11/2022 17:38, Dave Stevenson wrote: > > Hi Dmitry > > > > On Tue, 15 Nov 2022 at 14:21, Dmitry Baryshkov > > wrote: > > > > > > On 15/11/2022 17:14, Dave Stevenson wrote: > > > > Hi Dmitry > > > > > > > > On Sun, 13 Nov

Re: [PATCH V2 0/3] DSI host and peripheral initialisation ordering

2022-11-17 Thread Dmitry Baryshkov
On 17/11/2022 17:34, Maxime Ripard wrote: On Thu, Nov 17, 2022 at 03:24:07PM +0200, Dmitry Baryshkov wrote: On 15/11/2022 17:38, Dave Stevenson wrote: Hi Dmitry On Tue, 15 Nov 2022 at 14:21, Dmitry Baryshkov wrote: On 15/11/2022 17:14, Dave Stevenson wrote: Hi Dmitry On Sun, 13 Nov 2022 a

Re: [PATCH v10 05/19] drm/connector: Add TV standard property

2022-11-17 Thread Mauro Carvalho Chehab
On Thu, 17 Nov 2022 10:28:48 +0100 Maxime Ripard wrote: > The TV mode property has been around for a while now to select and get the > current TV mode output on an analog TV connector. > > Despite that property name being generic, its content isn't and has been > driver-specific which makes it h

Re: [PATCH 12/13] drm/scheduler: rework entity flush, kill and fini

2022-11-17 Thread Dmitry Osipenko
On 11/17/22 16:11, Christian König wrote: > Am 17.11.22 um 14:00 schrieb Dmitry Osipenko: >> On 11/17/22 15:59, Dmitry Osipenko wrote: >>> On 11/17/22 15:55, Christian König wrote: Am 17.11.22 um 13:47 schrieb Dmitry Osipenko: > On 11/17/22 12:53, Christian König wrote: >> Am 17.11.22

Re: [PATCH v10 05/19] drm/connector: Add TV standard property

2022-11-17 Thread Maxime Ripard
On Thu, Nov 17, 2022 at 03:35:57PM +0100, Mauro Carvalho Chehab wrote: > On Thu, 17 Nov 2022 10:28:48 +0100 > Maxime Ripard wrote: > > > The TV mode property has been around for a while now to select and get the > > current TV mode output on an analog TV connector. > > > > Despite that property

Re: [PATCH 2/3] drm/tiny: ili9486: Do not assume 8-bit only SPI controllers

2022-11-17 Thread Mark Brown
On Thu, Nov 17, 2022 at 02:40:05PM +0100, Carlo Caione wrote: > On 17/11/2022 12:09, Mark Brown wrote: > > I don't understand what the commit log is saying here. The meson-spicc > > driver advertises support for 8 bit words, if the driver is sending data > > formatted as a byte stream everything

Re: [PATCH v1 4/8] arm64: dts: renesas: r8a779g0: Add display related data

2022-11-17 Thread Kieran Bingham
Quoting Tomi Valkeinen (2022-11-17 12:25:43) > From: Tomi Valkeinen > > Add DT nodes for components needed to get the DSI output working: > - FCPv > - VSPd > - DU > - DSI > > Signed-off-by: Tomi Valkeinen > --- > arch/arm64/boot/dts/renesas/r8a779g0.dtsi | 129 ++ > 1 file

Re: [PATCH v1 5/8] arm64: dts: renesas: white-hawk-cpu: Add DP output support

2022-11-17 Thread Kieran Bingham
Quoting Tomi Valkeinen (2022-11-17 12:25:44) > From: Tomi Valkeinen > > Add DT nodes needed for the mini DP connector. The DP is driven by > sn65dsi86, which in turn gets the pixel data from the SoC via DSI. > > Signed-off-by: Tomi Valkeinen Reviewed-by: Kieran Bingham > --- > .../dts/rene

Re: [PATCH v1 6/8] drm: rcar-du: Add r8a779g0 support

2022-11-17 Thread Kieran Bingham
Quoting Tomi Valkeinen (2022-11-17 12:25:45) > From: Tomi Valkeinen > > Add support for DU on r8a779g0, which is identical to DU on r8a779a0. > > Signed-off-by: Tomi Valkeinen > --- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 22 ++ > 1 file changed, 22 insertions(+) > > dif

Re: [PATCH 12/13] drm/scheduler: rework entity flush, kill and fini

2022-11-17 Thread Christian König
Am 17.11.22 um 15:41 schrieb Dmitry Osipenko: [SNIP] drm_sched_entity_flush() should be called from the flush callback from the file_operations structure of panfrost. See amdgpu_flush() and amdgpu_ctx_mgr_entity_flush(). This makes sure that we wait for all entities of the process/file descripto

Re: [PATCH v1] dt-bindings: display: Convert fsl, imx-fb.txt to dt-schema

2022-11-17 Thread Rob Herring
On Wed, Nov 16, 2022 at 11:49 AM Philipp Zabel wrote: > > On Thu, Nov 10, 2022 at 10:49:45AM +0100, Uwe Kleine-König wrote: > [...] > > new file mode 100644 > > index ..c3cf6f92a766 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/imx/fsl,imx-lcdc.yaml > > @@ -0,0

Re: [PATCH 12/13] drm/scheduler: rework entity flush, kill and fini

2022-11-17 Thread Dmitry Osipenko
On 11/17/22 18:09, Christian König wrote: > Am 17.11.22 um 15:41 schrieb Dmitry Osipenko: >> [SNIP] >>> drm_sched_entity_flush() should be called from the flush callback from >>> the file_operations structure of panfrost. See amdgpu_flush() and >>> amdgpu_ctx_mgr_entity_flush(). This makes sure tha

Re: [PATCH v1 2/8] dt-bindings: display: bridge: renesas, dsi-csi2-tx: Add r8a779g0

2022-11-17 Thread Geert Uytterhoeven
Hi Tomi, On Thu, Nov 17, 2022 at 1:26 PM Tomi Valkeinen wrote: > From: Tomi Valkeinen > > Extend the Renesas DSI display bindings to support the r8a779g0 V4H. > > Signed-off-by: Tomi Valkeinen > --- > .../bindings/display/bridge/renesas,dsi-csi2-tx.yaml | 3 ++- > 1 file changed, 2 i

Re: [PATCH] drm/atomic: add quirks for blind save/restore

2022-11-17 Thread Daniel Vetter
On Thu, Nov 17, 2022 at 07:54:40AM +, Simon Ser wrote: > Two quirks to make blind atomic save/restore [1] work correctly: > > - Mark the DPMS property as immutable for atomic clients, since > atomic clients cannot change it. > - Allow user-space to set content protection to "enabled", interp

[PATCH] fbcon: Use kzalloc() in fbcon_prepare_logo()

2022-11-17 Thread Tetsuo Handa
A kernel built with syzbot's config file reported that scr_memcpyw(q, save, array3_size(logo_lines, new_cols, 2)) causes uninitialized "save" to be copied. -- [drm] Initialized vgem 1.0.0 20120112 for vgem on minor 0 [drm] Initialized vkms 1.0.0 20180514 for vkms on minor 1 Con

Re: [PATCH] fbcon: Use kzalloc() in fbcon_prepare_logo()

2022-11-17 Thread Daniel Vetter
On Fri, Nov 18, 2022 at 12:27:58AM +0900, Tetsuo Handa wrote: > A kernel built with syzbot's config file reported that > > scr_memcpyw(q, save, array3_size(logo_lines, new_cols, 2)) > > causes uninitialized "save" to be copied. > > -- > [drm] Initialized vgem 1.0.0 20120112 for vge

Re: Try to address the DMA-buf coherency problem

2022-11-17 Thread Nicolas Dufresne
Le jeudi 17 novembre 2022 à 13:10 +0100, Christian König a écrit : > > > DMA-Buf let's the exporter setup the DMA addresses the importer uses to > > > be able to directly decided where a certain operation should go. E.g. we > > > have cases where for example a P2P write doesn't even go to memory, b

Re: [PATCH v1 7/8] drm: rcar-du: dsi: Add r8A779g0 support

2022-11-17 Thread Kieran Bingham
Quoting Tomi Valkeinen (2022-11-17 12:25:46) > From: Tomi Valkeinen > > Add DSI support for r8a779g0. The main differences to r8a779a0 are in > the PLL and PHTW setups. > > Signed-off-by: Tomi Valkeinen > --- > drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c | 484 +++ > drivers/g

Re: [PATCH v1 7/8] drm: rcar-du: dsi: Add r8A779g0 support

2022-11-17 Thread Tomi Valkeinen
On 17/11/2022 17:46, Kieran Bingham wrote: + if (ret) + return ret; + + if (setup_info->hsfreq <= MHZ(1000)) + ret = WRITE_PHTW(0x01020100, 0x01910170, 0x01020171, +0x01110172); The <=1Gbps reads: <=1Gbps Set PHTW=H’010201

Re: [PATCH v10 18/19] drm/vc4: vec: Add support for more analog TV standards

2022-11-17 Thread Mauro Carvalho Chehab
On Thu, 17 Nov 2022 10:29:01 +0100 Maxime Ripard wrote: > From: Mateusz Kwiatkowski > > Add support for the following composite output modes (all of them are > somewhat more obscure than the previously defined ones): > > - NTSC_443 - NTSC-style signal with the chroma subcarrier shifted to >

Re: [PATCH v1 7/8] drm: rcar-du: dsi: Add r8A779g0 support

2022-11-17 Thread Kieran Bingham
Quoting Tomi Valkeinen (2022-11-17 15:49:36) > On 17/11/2022 17:46, Kieran Bingham wrote: > >> + if (ret) > >> + return ret; > >> + > >> + if (setup_info->hsfreq <= MHZ(1000)) > >> + ret = WRITE_PHTW(0x01020100, 0x01910170, 0x01020171, > >> +

Re: [PATCH] drm/i915/huc: fix leak of debug object in huc load fence on driver unload

2022-11-17 Thread Ceraolo Spurio, Daniele
On 11/16/2022 5:29 PM, Brian Norris wrote: Hi Daniele, On Thu, Nov 10, 2022 at 04:56:51PM -0800, Daniele Ceraolo Spurio wrote: The fence is always initialized in huc_init_early, but the cleanup in huc_fini is only being run if HuC is enabled. This causes a leaking of the debug object when Hu

Re: [PATCH v6 1/3] drm_bridge: register content protect property

2022-11-17 Thread Doug Anderson
Hi, On Thu, Nov 17, 2022 at 3:08 AM Hsin-Yi Wang wrote: > > Some bridges are able to update HDCP status from userspace request if > they support HDCP. > > HDCP property is the same as other connector properties that needs to be > created after the connecter is initialized and before the connector

Re: [v2,5/6] drm/fb-helper: Schedule deferred-I/O worker after writing to framebuffer

2022-11-17 Thread Thomas Zimmermann
sha256_arm cfg80211 snd_soc_core ac97_bus snd_pcm_dmaengine hci_uart btbcm snd_pcm snd_timer snd crc32_arm_ce soundcore raspberrypi_hwmon drm_dma_helper bluetooth bcm2835_thermal ecdh_generic ecc libaes CPU: 0 PID: 220 Comm: systemd-udevd Not tainted 6.1.0-rc5-next-20221117-00041-g13334c897c2b #5953 Har

  1   2   >