Re: [PATCH] drm/vc4: hdmi: Fix pointer dereference before check

2022-11-07 Thread Maxime Ripard
On Wed, Nov 02, 2022 at 12:10:03PM +0100, José Expósito wrote: > Hi Maxime, > > Thanks a lot for looking into the patch. > > On Wed, Nov 02, 2022 at 10:01:53AM +0100, Maxime Ripard wrote: > > Hi, > > > > On Sat, Oct 29, 2022 at 11:34:13AM +0200, José Expósito wrote: > > > Commit 6bed2ea3cb38 ("d

Re: [PATCH v2 43/65] ASoC: tlv320aic32x4: Add a determine_rate hook

2022-11-07 Thread Maxime Ripard
Hi Mark, On Fri, Nov 04, 2022 at 03:59:53PM +, Mark Brown wrote: > On Fri, Nov 04, 2022 at 04:51:23PM +0100, Maxime Ripard wrote: > > > Just filling determine_rate if it's missing with > > __clk_mux_determine_rate will possibly pick different parents, and I'm > > fairly certain that this have

[PATCH v6 00/20] drm/i915/vm_bind: Add VM_BIND functionality

2022-11-07 Thread Niranjana Vishwanathapura
DRM_I915_GEM_VM_BIND/UNBIND ioctls allows UMD to bind/unbind GEM buffer objects (BOs) or sections of a BOs at specified GPU virtual addresses on a specified address space (VM). Multiple mappings can map to the same physical pages of an object (aliasing). These mappings (also referred to as persiste

[PATCH v6 03/20] drm/i915/vm_bind: Expose i915_gem_object_max_page_size()

2022-11-07 Thread Niranjana Vishwanathapura
Expose i915_gem_object_max_page_size() function non-static which will be used by the vm_bind feature. Reviewed-by: Matthew Auld Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gem/i915_gem_create.c | 18 +- drivers/gpu/drm/i915/gem/i9

[PATCH v6 11/20] drm/i915/vm_bind: Use common execbuf functions in execbuf path

2022-11-07 Thread Niranjana Vishwanathapura
Update the execbuf path to use common execbuf functions to reduce code duplication with the newer execbuf3 path. Reviewed-by: Matthew Auld Signed-off-by: Niranjana Vishwanathapura --- .../gpu/drm/i915/gem/i915_gem_execbuffer.c| 507 ++ 1 file changed, 38 insertions(+), 469 d

[PATCH v6 05/20] drm/i915/vm_bind: Implement bind and unbind of object

2022-11-07 Thread Niranjana Vishwanathapura
Add uapi and implement support for bind and unbind of an object at the specified GPU virtual addresses. The vm_bind mode is not supported in legacy execbuf2 ioctl. It will be supported only in the newer execbuf3 ioctl. v2: On older platforms ctx->vm is not set, check for it. In vm_bind call,

[PATCH v6 01/20] drm/i915/vm_bind: Expose vm lookup function

2022-11-07 Thread Niranjana Vishwanathapura
Make i915_gem_vm_lookup() function non-static as it will be used by the vm_bind feature. Reviewed-by: Matthew Auld Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 11 ++- drivers/gpu/drm/i915/gem/i915_gem_context.h |

[PATCH v6 06/20] drm/i915/vm_bind: Support for VM private BOs

2022-11-07 Thread Niranjana Vishwanathapura
Each VM creates a root_obj and shares it with all of its private objects to use it as dma_resv object. This has a performance advantage as it requires a single dma_resv object update for all private BOs vs list of dma_resv objects update for shared BOs, in the execbuf path. VM private BOs can be o

[PATCH v6 13/20] drm/i915/vm_bind: Update i915_vma_verify_bind_complete()

2022-11-07 Thread Niranjana Vishwanathapura
Ensure i915_vma_verify_bind_complete() handles case where bind is not initiated. Also make it non static, add documentation and move it out of CONFIG_DRM_I915_DEBUG_GEM. v2: Fix fence leak Reviewed-by: Matthew Auld Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti --- drivers

[PATCH v6 12/20] drm/i915/vm_bind: Implement I915_GEM_EXECBUFFER3 ioctl

2022-11-07 Thread Niranjana Vishwanathapura
Implement new execbuf3 ioctl (I915_GEM_EXECBUFFER3) which only works in vm_bind mode. The vm_bind mode only works with this new execbuf3 ioctl. The new execbuf3 ioctl will not have any list of objects to validate bind as all required objects binding would have been requested by the userspace befor

[PATCH v6 20/20] drm/i915/vm_bind: Async vm_unbind support

2022-11-07 Thread Niranjana Vishwanathapura
Asynchronously unbind the vma upon vm_unbind call. Fall back to synchronous unbind if backend doesn't support async unbind or if async unbind fails. No need for vm_unbind out fence support as i915 will internally handle all sequencing and user need not try to sequence any operation with the unbind

[PATCH v6 07/20] drm/i915/vm_bind: Add support to handle object evictions

2022-11-07 Thread Niranjana Vishwanathapura
Support eviction by maintaining a list of evicted persistent vmas for rebinding during next submission. Ensure the list do not include persistent vmas that are being purged. v2: Remove unused I915_VMA_PURGED definition. v3: Properly handle __i915_vma_unbind_async() case. Reviewed-by: Matthew Auld

[PATCH v6 08/20] drm/i915/vm_bind: Support persistent vma activeness tracking

2022-11-07 Thread Niranjana Vishwanathapura
Do not use i915_vma activeness tracking for persistent vmas. As persistent vmas are part of working set for each execbuf submission on that address space (VM), a persistent vma is active if the VM active. As vm->root_obj->base.resv will be updated for each submission on that VM, it correctly repre

[PATCH v6 02/20] drm/i915/vm_bind: Add __i915_sw_fence_await_reservation()

2022-11-07 Thread Niranjana Vishwanathapura
Add function __i915_sw_fence_await_reservation() for asynchronous wait on a dma-resv object with specified dma_resv_usage. This is required for async vma unbind with vm_bind. Reviewed-by: Matthew Auld Signed-off-by: Niranjana Vishwanathapura --- drivers/gpu/drm/i915/i915_sw_fence.c | 28 +++

[PATCH v6 16/20] drm/i915/vm_bind: userptr dma-resv changes

2022-11-07 Thread Niranjana Vishwanathapura
For persistent (vm_bind) vmas of userptr BOs, handle the user page pinning by using the i915_gem_object_userptr_submit_init() /done() functions v2: Do not double add vma to vm->userptr_invalidated_list v3: Initialize vma->userptr_invalidated_link Reviewed-by: Matthew Auld Signed-off-by: Niranjan

[PATCH v6 09/20] drm/i915/vm_bind: Add out fence support

2022-11-07 Thread Niranjana Vishwanathapura
Add support for handling out fence for vm_bind call. v2: Reset vma->vm_bind_fence.syncobj to NULL at the end of vm_bind call. v3: Remove vm_unbind out fence uapi which is not supported yet. v4: Return error if I915_TIMELINE_FENCE_WAIT fence flag is set. Wait for bind to complete iff I915_T

[PATCH v6 15/20] drm/i915/vm_bind: Handle persistent vmas in execbuf3

2022-11-07 Thread Niranjana Vishwanathapura
Handle persistent (VM_BIND) mappings during the request submission in the execbuf3 path. v2: Ensure requests wait for bindings to complete. v3: Remove short term pinning with PIN_VALIDATE flag. Individualize fences before adding to dma_resv obj. v4: Fix bind completion check, use PIN_NOEVICT,

[PATCH v6 18/20] drm/i915/vm_bind: Add uapi for user to enable vm_bind_mode

2022-11-07 Thread Niranjana Vishwanathapura
Add getparam support for VM_BIND capability version. Add VM creation time flag to enable vm_bind_mode for the VM. v2: update kernel-doc v3: create vm->root_obj only upon I915_VM_CREATE_FLAGS_USE_VM_BIND v4: replace vm->vm_bind_mode check with i915_gem_vm_is_vm_bind_mode() Reviewed-by: Matthew Aul

[PATCH v6 10/20] drm/i915/vm_bind: Abstract out common execbuf functions

2022-11-07 Thread Niranjana Vishwanathapura
The new execbuf3 ioctl path and the legacy execbuf ioctl paths have many common functionalities. Abstract out the common execbuf functionalities into a separate file where possible, thus allowing code sharing. Reviewed-by: Andi Shyti Reviewed-by: Matthew Auld Signed-off-by: Niranjana Vishwanatha

[PATCH v6 17/20] drm/i915/vm_bind: Limit vm_bind mode to non-recoverable contexts

2022-11-07 Thread Niranjana Vishwanathapura
Only support vm_bind mode with non-recoverable contexts. With new vm_bind mode with eb3 submission path, we need not support older recoverable contexts. Reviewed-by: Matthew Auld Signed-off-by: Niranjana Vishwanathapura --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 6 ++ 1 file changed,

[PATCH v6 04/20] drm/i915/vm_bind: Add support to create persistent vma

2022-11-07 Thread Niranjana Vishwanathapura
Add i915_vma_instance_persistent() to create persistent vmas. Persistent vmas will use i915_gtt_view to support partial binding. vma_lookup is tied to segment of the object instead of section of VA space. Hence, it do not support aliasing. ie., multiple mappings (at different VA) point to the same

Re: [PATCH] video: fbdev: pxafb: Remove unnecessary print function dev_err()

2022-11-07 Thread Helge Deller
On 11/6/22 15:16, wangkail...@jari.cn wrote: Eliminate the follow coccicheck warning: ./drivers/video/fbdev/pxafb.c:2330:2-9: line 2330 is redundant because platform_get_irq() already prints an error Signed-off-by: KaiLong Wang applied. Thanks! Helge --- drivers/video/fbdev/pxafb.c | 1 -

[PATCH v6 14/20] drm/i915/vm_bind: Expose i915_request_await_bind()

2022-11-07 Thread Niranjana Vishwanathapura
Rename __i915_request_await_bind() as i915_request_await_bind() and make it non-static as it will be used in execbuf3 ioctl path. v2: add documentation Reviewed-by: Matthew Auld Reviewed-by: Andi Shyti Signed-off-by: Niranjana Vishwanathapura --- drivers/gpu/drm/i915/i915_vma.c | 8 +---

[PATCH v6 19/20] drm/i915/vm_bind: Render VM_BIND documentation

2022-11-07 Thread Niranjana Vishwanathapura
Update i915 documentation to include VM_BIND changes and render all VM_BIND related documentation. Reviewed-by: Matthew Auld Signed-off-by: Niranjana Vishwanathapura --- Documentation/gpu/i915.rst | 78 -- 1 file changed, 59 insertions(+), 19 deletions(-) di

Re: [PATCH v2 56/65] clk: ingenic: cgu: Switch to determine_rate

2022-11-07 Thread Maxime Ripard
Hi, On Fri, Nov 04, 2022 at 05:35:29PM +, Aidan MacDonald wrote: > > Maxime Ripard writes: > > > Hi Paul, > > > > On Fri, Nov 04, 2022 at 02:31:20PM +, Paul Cercueil wrote: > >> Le ven. 4 nov. 2022 à 14:18:13 +0100, Maxime Ripard a > >> écrit : > >> > The Ingenic CGU clocks implements

Re: [PATCH v3 1/2] dt-bindings: backlight: qcom-wled: Add PMI8950 compatible

2022-11-07 Thread Lee Jones
On Tue, 01 Nov 2022, Luca Weiss wrote: > Document the compatible for the wled block found in PMI8950. > > Signed-off-by: Luca Weiss > --- > Changes since v2: > * New patch > > Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml | 1 + > 1 file changed, 1 insertion(+) Applied, than

dcn321_fpu.c:626: Array index check in wrong place ?

2022-11-07 Thread David Binderman
Hello there, Static analyser cppcheck says: linux-6.1-rc4/drivers/gpu/drm/amd/display/dc/dml/dcn321/dcn321_fpu.c:626:27: style: Array index 'i' is used before limits check. [arrayIndexThenCheck] Source code is if (dcfclk_sta_targets[i] < optimal_dcfclk_for_uclk[j] && i < num_dc

Re: [PATCH 4/8] pwm: atmel-hlcdc: fix struct clk pointer comparing

2022-11-07 Thread Cc Carnaghi

[PATCH] driver: gpu: add failure check for ftell

2022-11-07 Thread SPeak Shen
From: shenyanfeng add return-value check of ftell to improve robustness(and avoid abnormal behavior) Signed-off-by: SPeak Signed-off-by: shenyanfeng --- Receive "Undelivered Mail Returned to Sender", so send again drivers/gpu/drm/radeon/mkregtable.c | 5 +++-- 1 file changed, 3 insertion

Re: Must-Pass Test Suite for KMS drivers

2022-11-07 Thread Maxime Ripard
On Thu, Oct 27, 2022 at 08:08:28AM -0700, Rob Clark wrote: > On Wed, Oct 26, 2022 at 1:17 AM wrote: > > > > Hi Rob, > > > > On Mon, Oct 24, 2022 at 08:48:15AM -0700, Rob Clark wrote: > > > On Mon, Oct 24, 2022 at 5:43 AM wrote: > > > > I've discussing the idea for the past year to add an IGT test

Re: Must-Pass Test Suite for KMS drivers

2022-11-07 Thread Maxime Ripard
Hi Thomas, On Fri, Oct 28, 2022 at 09:31:38AM +0200, Thomas Zimmermann wrote: > Am 24.10.22 um 14:43 schrieb max...@cerno.tech: > > I've discussing the idea for the past year to add an IGT test suite that > > all well-behaved KMS drivers must pass. > > > > The main idea behind it comes from v4l2-

[PATCH] [next] drm/amdgpu: Replace 1-element array with flexible-array member

2022-11-07 Thread Paulo Miguel Almeida
One-element arrays are deprecated, and we are replacing them with flexible array members instead. So, replace one-element array with flexible-array member in structs _ATOM_GPIO_PIN_ASSIGNMENT, _ATOM_DISPLAY_OBJECT_PATH, _ATOM_DISPLAY_OBJECT_PATH_TABLE, _ATOM_OBJECT_TABLE and refactor the rest of th

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Add GT oriented dmesg output

2022-11-07 Thread Tvrtko Ursulin
On 05/11/2022 01:03, Ceraolo Spurio, Daniele wrote: On 11/4/2022 10:25 AM, john.c.harri...@intel.com wrote: From: John Harrison When trying to analyse bug reports from CI, customers, etc. it can be difficult to work out exactly what is happening on which GT in a multi-GT system. So add GT

Re: Must-Pass Test Suite for KMS drivers

2022-11-07 Thread Thomas Zimmermann
Hi Am 07.11.22 um 10:30 schrieb Maxime Ripard: Hi Thomas, On Fri, Oct 28, 2022 at 09:31:38AM +0200, Thomas Zimmermann wrote: Am 24.10.22 um 14:43 schrieb max...@cerno.tech: I've discussing the idea for the past year to add an IGT test suite that all well-behaved KMS drivers must pass. The ma

Re: [PATCH v6 10/23] drm/modes: Fill drm_cmdline mode from named modes

2022-11-07 Thread Maxime Ripard
On Sun, Nov 06, 2022 at 02:04:56PM +0100, Noralf Trønnes wrote: > > > Den 26.10.2022 17.33, skrev max...@cerno.tech: > > The current code to deal with named modes will only set the mode name, and > > then it's up to drivers to try to match that name to whatever mode or > > configuration they see

Re: [PATCH v3 02/12] dt-bindings: display: mediatek: add MT8195 hdmi bindings

2022-11-07 Thread Krzysztof Kozlowski
On 04/11/2022 15:09, Guillaume Ranquet wrote: > Add mt8195 SoC bindings for hdmi and hdmi-ddc > > On mt8195 the ddc i2c controller is part of the hdmi IP block and thus has no > specific register range, power domain or interrupt, making it simpler > than its the legacy "mediatek,hdmi-ddc" binding.

Re: [PATCH v6 16/23] drm/probe-helper: Provide a TV get_modes helper

2022-11-07 Thread Maxime Ripard
Hi Noralf, On Sun, Nov 06, 2022 at 05:59:23PM +0100, Noralf Trønnes wrote: > > > Den 27.10.2022 00.02, skrev Mateusz Kwiatkowski: > > Hi Maxime, > > > > First of all, nice idea with the helper function that can be reused by > > different > > drivers. This is neat! > > > > But looking at this

Re: [PATCH v6 16/23] drm/probe-helper: Provide a TV get_modes helper

2022-11-07 Thread Maxime Ripard
Hi Noralf, I'll leave aside your comments on the code, since we'll use your implementation. On Sun, Nov 06, 2022 at 05:33:48PM +0100, Noralf Trønnes wrote: > Den 26.10.2022 17.33, skrev max...@cerno.tech: > > + > > + if (cmdline->tv_mode_specified) > > + default_mode = cmdline->tv_mod

Re: [igt-dev] Must-Pass Test Suite for KMS drivers

2022-11-07 Thread Daniel Vetter
On Mon, 7 Nov 2022 at 10:43, Thomas Zimmermann wrote: > > Hi > > Am 07.11.22 um 10:30 schrieb Maxime Ripard: > > Hi Thomas, > > > > On Fri, Oct 28, 2022 at 09:31:38AM +0200, Thomas Zimmermann wrote: > >> Am 24.10.22 um 14:43 schrieb max...@cerno.tech: > >>> I've discussing the idea for the past ye

Re: (subset) [PATCH] drm/vc4: Fix missing platform_unregister_drivers() call in vc4_drm_register()

2022-11-07 Thread Maxime Ripard
On Thu, 3 Nov 2022 01:47:05 +, Yuan Can wrote: > A problem about modprobe vc4 failed is triggered with the following log > given: > > [ 420.327987] Error: Driver 'vc4_hvs' is already registered, aborting... > [ 420.333904] failed to register platform driver vc4_hvs_driver [vc4]: -16 > mod

[PATCH] drm/msm/dpu1: Remove INTF4 IRQ from SDM845 IRQ mask

2022-11-07 Thread Konrad Dybcio
From: Konrad Dybcio SDM845 only has INTF0-3 and has no business caring about the INTF4 irq. Suggested-by: Dmitry Baryshkov Signed-off-by: Konrad Dybcio Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/g

Re: [PATCH v1 3/5] arm64: dts: qcom: sm8450-hdk: enable display hardware

2022-11-07 Thread Konrad Dybcio
On 06/11/2022 05:30, Bjorn Andersson wrote: On Fri, Nov 04, 2022 at 04:13:56PM +0300, Dmitry Baryshkov wrote: Enable MDSS/DPU/DSI0 on SM8450-HDK device. Note, there is no panel configuration (yet). Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 18 ++

[PATCH 2/2] fbdev: Add support for the nomodeset kernel parameter

2022-11-07 Thread Thomas Zimmermann
Support the kernel's nomodeset parameter for all PCI-based fbdev drivers that use aperture helpers to remove other, hardware-agnostic graphics drivers. The parameter is a simple way of using the firmware-provided scanout buffer if the hardware's native driver is broken. The same effect could be ac

[PATCH 0/2] video/fbdev: Support 'nomodeset' in PCI drivers

2022-11-07 Thread Thomas Zimmermann
Add support for the kernel's 'nomodeset' parameter to PCI-based fbdev drivers. The option prevents DRM drivers from loading if they could possibly displace a hardware-agnostic driver that runs on the firmware framebuffer. It is a fallback for systems on which the hardware's native driver does not w

[PATCH 1/2] drm: Move nomodeset kernel parameter to drivers/video

2022-11-07 Thread Thomas Zimmermann
Move the nomodeset kernel parameter to drivers/video to make it available to non-DRM drivers. Adapt the interface, but keep the DRM interface drm_firmware_drivers_only() to avoid churn within DRM. The function should later be inlined into callers. The parameter disables any DRM graphics driver tha

Re: [igt-dev] Must-Pass Test Suite for KMS drivers

2022-11-07 Thread Thomas Zimmermann
Hi Am 07.11.22 um 11:26 schrieb Daniel Vetter: On Mon, 7 Nov 2022 at 10:43, Thomas Zimmermann wrote: Hi Am 07.11.22 um 10:30 schrieb Maxime Ripard: Hi Thomas, On Fri, Oct 28, 2022 at 09:31:38AM +0200, Thomas Zimmermann wrote: Am 24.10.22 um 14:43 schrieb max...@cerno.tech: I've discussin

Re: [GIT PULL] treewide: timers: Use timer_shutdown*() before freeing timers

2022-11-07 Thread Thomas Gleixner
Linus, On Sun, Nov 06 2022 at 22:32, Steven Rostedt wrote: > As discussed here: > > https://lore.kernel.org/all/20221106212427.739928...@goodmis.org/ Please hold off. It's only nits, but tip has documented rules and random pull requests are not making them go away. Thanks, tglx

Re: [PATCH v2 20/65] clk: wm831x: clkout: Add a determine_rate hook

2022-11-07 Thread Charles Keepax
On Fri, Nov 04, 2022 at 02:17:37PM +0100, Maxime Ripard wrote: > The WM381x "clkout" clock implements a mux with a set_parent hook, > but doesn't provide a determine_rate implementation. > > This is a bit odd, since set_parent() is there to, as its name implies, > change the parent of a clock. How

Re: [PATCH v3 04/12] drm/mediatek: extract common functions from the mtk hdmi driver

2022-11-07 Thread AngeloGioacchino Del Regno
Il 04/11/22 15:09, Guillaume Ranquet ha scritto: Create a common "framework" that can be used to add support for different hdmi IPs within the mediatek range of products. Signed-off-by: Guillaume Ranquet --- drivers/gpu/drm/mediatek/Makefile | 3 +- drivers/gpu/drm/mediatek/mtk_hd

Re: [PATCH v3 06/12] drm/mediatek: hdmi: add frame_colorimetry flag

2022-11-07 Thread AngeloGioacchino Del Regno
Il 04/11/22 15:09, Guillaume Ranquet ha scritto: Add a flag to indicate support for frame colorimetry. Signed-off-by: Guillaume Ranquet --- drivers/gpu/drm/mediatek/mtk_hdmi_common.c | 11 +++ drivers/gpu/drm/mediatek/mtk_hdmi_common.h | 1 + 2 files changed, 12 insertions(+) diff

Re: [PATCH v3 08/12] drm/mediatek: hdmi: v2: add audio support

2022-11-07 Thread AngeloGioacchino Del Regno
Il 04/11/22 15:09, Guillaume Ranquet ha scritto: Add HDMI audio support for v2 Signed-off-by: Guillaume Ranquet --- drivers/gpu/drm/mediatek/mtk_hdmi_common.c | 1 + drivers/gpu/drm/mediatek/mtk_hdmi_ddc_v2.c | 2 +- drivers/gpu/drm/mediatek/mtk_hdmi_v2.c | 213 +

Re: [PATCH v2 65/65] clk: Warn if we register a mux without determine_rate

2022-11-07 Thread Charles Keepax
On Fri, Nov 04, 2022 at 02:18:22PM +0100, Maxime Ripard wrote: > The determine_rate hook allows to select the proper parent and its rate > for a given clock configuration. On another hand, set_parent is there to > change the parent of a mux. > > Some clocks provide a set_parent hook but don't impl

Re: [PATCH v6 16/23] drm/probe-helper: Provide a TV get_modes helper

2022-11-07 Thread Noralf Trønnes
Den 07.11.2022 11.07, skrev Maxime Ripard: > Hi Noralf, > > On Sun, Nov 06, 2022 at 05:59:23PM +0100, Noralf Trønnes wrote: >> >> >> Den 27.10.2022 00.02, skrev Mateusz Kwiatkowski: >>> Hi Maxime, >>> >>> First of all, nice idea with the helper function that can be reused by >>> different >>>

Re: [PATCH v3 12/12] drm/mediatek: dpi: Add mt8195 hdmi to DPI driver

2022-11-07 Thread AngeloGioacchino Del Regno
Il 04/11/22 15:09, Guillaume Ranquet ha scritto: Add the DPI1 hdmi path support in mtk dpi driver Signed-off-by: Guillaume Ranquet --- drivers/gpu/drm/mediatek/mtk_dpi.c | 143 ++-- drivers/gpu/drm/mediatek/mtk_dpi_regs.h | 5 ++ 2 files changed, 141 inser

Re: [PATCH v3 03/12] drm/mediatek: hdmi: use a regmap instead of iomem

2022-11-07 Thread AngeloGioacchino Del Regno
Il 04/11/22 15:09, Guillaume Ranquet ha scritto: To prepare support for newer chips that need to share their address range with a dedicated ddc driver, use a regmap. Signed-off-by: Guillaume Ranquet --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 43 +++-- 1 file ch

Re: [PATCH v3 01/12] dt-bindings: phy: mediatek: hdmi-phy: Add mt8195 compatible

2022-11-07 Thread AngeloGioacchino Del Regno
Il 04/11/22 15:09, Guillaume Ranquet ha scritto: Add a compatible for the HDMI PHY on MT8195 Acked-by: Krzysztof Kozlowski Signed-off-by: Guillaume Ranquet Ack and R-b tags go after your S-o-b. Apart from that: Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v6 16/23] drm/probe-helper: Provide a TV get_modes helper

2022-11-07 Thread Noralf Trønnes
Den 07.11.2022 11.21, skrev Maxime Ripard: > Hi Noralf, > > I'll leave aside your comments on the code, since we'll use your > implementation. > > On Sun, Nov 06, 2022 at 05:33:48PM +0100, Noralf Trønnes wrote: >> Den 26.10.2022 17.33, skrev max...@cerno.tech: >>> + >>> + if (cmdline->tv_mo

Re: [PATCH v1 3/5] arm64: dts: qcom: sm8450-hdk: enable display hardware

2022-11-07 Thread Krzysztof Kozlowski
On 07/11/2022 11:46, Konrad Dybcio wrote: > > > On 06/11/2022 05:30, Bjorn Andersson wrote: >> On Fri, Nov 04, 2022 at 04:13:56PM +0300, Dmitry Baryshkov wrote: >>> Enable MDSS/DPU/DSI0 on SM8450-HDK device. Note, there is no panel >>> configuration (yet). >>> >>> Signed-off-by: Dmitry Baryshkov

Re: [PATCH v1 3/5] arm64: dts: qcom: sm8450-hdk: enable display hardware

2022-11-07 Thread Konrad Dybcio
On 07/11/2022 12:36, Krzysztof Kozlowski wrote: On 07/11/2022 11:46, Konrad Dybcio wrote: On 06/11/2022 05:30, Bjorn Andersson wrote: On Fri, Nov 04, 2022 at 04:13:56PM +0300, Dmitry Baryshkov wrote: Enable MDSS/DPU/DSI0 on SM8450-HDK device. Note, there is no panel configuration (yet). Si

Re: [PATCH v5] media: mediatek: vcodec: Add to support VP9 inner racing mode

2022-11-07 Thread 董云飞
Hi Mingjia, Thanks for your patch. Some comments need to get your feedback. On Tue, 2022-10-25 at 09:46 +0800, Mingjia Zhang wrote: > Enable VP9 inner racing mode > We send lat trans buffer to the core when trigger lat to work, > instead of waiting for the lat decode done. > It can be reduce decod

Re: [PATCH] drm/vc4: hdmi: Fix pointer dereference before check

2022-11-07 Thread Ville Syrjälä
On Mon, Nov 07, 2022 at 09:26:30AM +0100, Maxime Ripard wrote: > On Wed, Nov 02, 2022 at 12:10:03PM +0100, José Expósito wrote: > > Hi Maxime, > > > > Thanks a lot for looking into the patch. > > > > On Wed, Nov 02, 2022 at 10:01:53AM +0100, Maxime Ripard wrote: > > > Hi, > > > > > > On Sat, Oct

Re: [PATCH v2 43/65] ASoC: tlv320aic32x4: Add a determine_rate hook

2022-11-07 Thread Mark Brown
On Mon, Nov 07, 2022 at 09:43:22AM +0100, Maxime Ripard wrote: > On Fri, Nov 04, 2022 at 03:59:53PM +, Mark Brown wrote: > > Well, hopefully everyone for whom it's an issue currently will be > > objecting to this version of the change anyway so we'll either know > > where to set the flag or we

Re: [PATCH v2 21/65] clk: davinci: da8xx-cfgchip: Add a determine_rate hook

2022-11-07 Thread Maxime Ripard
Hi David, On Fri, Nov 04, 2022 at 11:45:17AM -0500, David Lechner wrote: > On 11/4/22 8:17 AM, Maxime Ripard wrote: > > The Davinci DA8xxx cfgchip mux clock implements a mux with a set_parent > > hook, but doesn't provide a determine_rate implementation. > > > > This is a bit odd, since set_paren

Re: [PATCH] drm: do not call detect for connectors which are forced on

2022-11-07 Thread Maxime Ripard
On Fri, Sep 30, 2022 at 02:33:08AM +0300, Laurent Pinchart wrote: > Hello Michael, > > Thank you for the patch. Sorry for the late reply, I wasn't on the CC > list so I didn't notice it. > > On Fri, Aug 26, 2022 at 11:11:21AM +0200, Michael Rodin wrote: > > "detect" should not be called and its r

Re: [PATCH] drm: do not call detect for connectors which are forced on

2022-11-07 Thread Maxime Ripard
On Fri, Aug 26, 2022 at 11:11:21AM +0200, Michael Rodin wrote: > "detect" should not be called and its return value shall not be used when a > connector is forced as hinted in the commit d50ba256b5f1 ("drm/kms: start > adding command line interface using fb.") and the commit 6fe14acd496e > ("drm: D

Re: [PATCH v6 16/23] drm/probe-helper: Provide a TV get_modes helper

2022-11-07 Thread Maxime Ripard
On Mon, Nov 07, 2022 at 12:29:28PM +0100, Noralf Trønnes wrote: > > > Den 07.11.2022 11.21, skrev Maxime Ripard: > > Hi Noralf, > > > > I'll leave aside your comments on the code, since we'll use your > > implementation. > > > > On Sun, Nov 06, 2022 at 05:33:48PM +0100, Noralf Trønnes wrote: >

[PATCH 0/3] drm/fb-helper: Build fixes for cleanup

2022-11-07 Thread Thomas Zimmermann
Cleaning up the fbdev code produced a number of simple build errors. Fix them. Thomas Zimmermann (3): drm/fbdev: Include drm/hisilicon/hibmc: Include for readl() and writel() drm/fb-helper: Document struct drm_fb_helper.hint_leak_smem_start drivers/gpu/drm/drm_fbdev_generic.c

[PATCH 2/3] drm/hisilicon/hibmc: Include for readl() and writel()

2022-11-07 Thread Thomas Zimmermann
Include to get readl() and writel() on S390. The error message is shown below and a bug report is at [1]. drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c:75:15: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration] 75 | reg = readl(priv->mmio + H

[PATCH 3/3] drm/fb-helper: Document struct drm_fb_helper.hint_leak_smem_start

2022-11-07 Thread Thomas Zimmermann
Document the new field smem_start in struct drm_fb_helper and avoid a compile-time warning. An error message is shown below and the bug report is at [1]. include/drm/drm_fb_helper.h:204: warning: Function parameter or member 'hint_leak_smem_start' not described in 'drm_fb_helper' Reported-by:

[PATCH 1/3] drm/fbdev: Include

2022-11-07 Thread Thomas Zimmermann
Include in fbdev emulation to get vzalloc() and vfree() on MIPS. The error messages are shown below and bug reports are at [1] and [2]. drivers/gpu/drm/drm_fbdev_generic.c: In function 'drm_fbdev_cleanup': drivers/gpu/drm/drm_fbdev_generic.c:63:17: error: implicit declaration of function 'vf

Re: [RFC PATCH v2 1/3] drivers/accel: define kconfig and register a new major

2022-11-07 Thread Jason Gunthorpe
On Thu, Nov 03, 2022 at 10:39:36PM +0200, Oded Gabbay wrote: > On Thu, Nov 3, 2022 at 3:31 PM Oded Gabbay wrote: > > > > On Thu, Nov 3, 2022 at 2:31 AM Greg Kroah-Hartman > > wrote: > > > > > > On Wed, Nov 02, 2022 at 10:34:03PM +0200, Oded Gabbay wrote: > > > > --- /dev/null > > > > +++ b/driver

Re: [RFC PATCH v2 1/3] drivers/accel: define kconfig and register a new major

2022-11-07 Thread Oded Gabbay
On Mon, Nov 7, 2022 at 2:56 PM Jason Gunthorpe wrote: > > On Thu, Nov 03, 2022 at 10:39:36PM +0200, Oded Gabbay wrote: > > On Thu, Nov 3, 2022 at 3:31 PM Oded Gabbay wrote: > > > > > > On Thu, Nov 3, 2022 at 2:31 AM Greg Kroah-Hartman > > > wrote: > > > > > > > > On Wed, Nov 02, 2022 at 10:34:03

Re: [RFC PATCH v2 1/3] drivers/accel: define kconfig and register a new major

2022-11-07 Thread Jason Gunthorpe
On Mon, Nov 07, 2022 at 03:01:08PM +0200, Oded Gabbay wrote: > I don't agree with your statement that it should be "a layer over top of DRM". > Anything on top of DRM is a device driver. > Accel is not a device driver, it is a new type of drm minor / drm driver. Yeah, I still think this is not the

Re: [PATCH v2 0/4] drm/sun4i: dsi: Support the A100/D1 controller variant

2022-11-07 Thread Maxime Ripard
On Sun, 6 Nov 2022 23:35:48 -0600, Samuel Holland wrote: > This series adds support for the digital part of the DSI controller > found in the A100 and D1 SoCs (plus T7, which is not supported by > mainline Linux). There are two changes to the hardware integration: > 1) the module clock routes thr

Re: [PATCH v5] media: mediatek: vcodec: Add to support VP9 inner racing mode

2022-11-07 Thread AngeloGioacchino Del Regno
Il 07/11/22 12:46, Yunfei Dong (董云飞) ha scritto: Hi Mingjia, Thanks for your patch. Some comments need to get your feedback. On Tue, 2022-10-25 at 09:46 +0800, Mingjia Zhang wrote: Enable VP9 inner racing mode We send lat trans buffer to the core when trigger lat to work, instead of waiting for

Re: [PATCH 04/10] vfio: Move storage of allow_unsafe_interrupts to vfio_main.c

2022-11-07 Thread Jason Gunthorpe
On Mon, Oct 31, 2022 at 04:45:26PM -0600, Alex Williamson wrote: > > It is one idea, it depends how literal you want to be on "module > > parameters are ABI". IMHO it is a weak form of ABI and the need of > > this paramter in particular is not that common in modern times, AFAIK. > > > > So perhap

Re: [PATCH] drm/panfrost: Remove type name from internal struct again

2022-11-07 Thread Alyssa Rosenzweig
Reviewed-by: Alyssa Rosenzweig On Thu, Nov 03, 2022 at 11:40:36AM +, Steven Price wrote: > Commit 72655fb942c1 ("drm/panfrost: replace endian-specific types with > native ones") accidentally reverted part of the parent commit > 7228d9d79248 ("drm/panfrost: Remove type name from internal struc

Re: [RFC PATCH v2 1/3] drivers/accel: define kconfig and register a new major

2022-11-07 Thread Stanislaw Gruszka
Hi On Mon, Nov 07, 2022 at 09:10:36AM -0400, Jason Gunthorpe wrote: > On Mon, Nov 07, 2022 at 03:01:08PM +0200, Oded Gabbay wrote: > > I don't agree with your statement that it should be "a layer over top of > > DRM". > > Anything on top of DRM is a device driver. > > Accel is not a device driver

Re: [PATCH v6 14/23] drm/modes: Properly generate a drm_display_mode from a named mode

2022-11-07 Thread Maxime Ripard
On Sat, Nov 05, 2022 at 06:50:30PM +0100, Noralf Trønnes wrote: > Den 26.10.2022 17.33, skrev max...@cerno.tech: > > The framework will get the drm_display_mode from the drm_cmdline_mode it > > got by parsing the video command line argument by calling > > drm_connector_pick_cmdline_mode(). > > > >

Re: [PATCH 2/2] fbdev: Add support for the nomodeset kernel parameter

2022-11-07 Thread Helge Deller
On 11/7/22 11:49, Thomas Zimmermann wrote: Support the kernel's nomodeset parameter for all PCI-based fbdev drivers that use aperture helpers to remove other, hardware-agnostic graphics drivers. The parameter is a simple way of using the firmware-provided scanout buffer if the hardware's native

Re: [PATCH 10/10] iommufd: Allow iommufd to supply /dev/vfio/vfio

2022-11-07 Thread Jason Gunthorpe
On Mon, Oct 31, 2022 at 04:53:11PM -0600, Alex Williamson wrote: > On Fri, 28 Oct 2022 15:44:36 -0300 > Jason Gunthorpe wrote: > > > On Wed, Oct 26, 2022 at 03:31:33PM -0600, Alex Williamson wrote: > > > On Tue, 25 Oct 2022 15:50:45 -0300 > > > Jason Gunthorpe wrote: > > > > > > > If the VFIO

Re: [RFC PATCH v2 1/3] drivers/accel: define kconfig and register a new major

2022-11-07 Thread Oded Gabbay
On Mon, Nov 7, 2022 at 3:10 PM Jason Gunthorpe wrote: > > On Mon, Nov 07, 2022 at 03:01:08PM +0200, Oded Gabbay wrote: > > I don't agree with your statement that it should be "a layer over top of > > DRM". > > Anything on top of DRM is a device driver. > > Accel is not a device driver, it is a ne

Re: [Intel-gfx] [PATCH] drm/i915: Don't wait forever in drop_caches

2022-11-07 Thread Tvrtko Ursulin
On 04/11/2022 17:45, John Harrison wrote: On 11/4/2022 03:01, Tvrtko Ursulin wrote: On 03/11/2022 19:16, John Harrison wrote: On 11/3/2022 02:38, Tvrtko Ursulin wrote: On 03/11/2022 09:18, Tvrtko Ursulin wrote: On 03/11/2022 01:33, John Harrison wrote: On 11/2/2022 07:20, Tvrtko Ursulin wr

Re: [RFC PATCH v2 1/3] drivers/accel: define kconfig and register a new major

2022-11-07 Thread Jason Gunthorpe
On Mon, Nov 07, 2022 at 04:02:01PM +0200, Oded Gabbay wrote: > On Mon, Nov 7, 2022 at 3:10 PM Jason Gunthorpe wrote: > > > > On Mon, Nov 07, 2022 at 03:01:08PM +0200, Oded Gabbay wrote: > > > I don't agree with your statement that it should be "a layer over top of > > > DRM". > > > Anything on to

Re: [PATCH v4a 30/38] timers: dma-buf: Use timer_shutdown_sync() for on stack timers

2022-11-07 Thread Christian König
Am 05.11.22 um 07:00 schrieb Steven Rostedt: From: "Steven Rostedt (Google)" Before a timer is released, timer_shutdown_sync() must be called. Link: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fall%2F20221104054053.431922658%40goodmis.org%2F&data=05%7C01

Re: [PATCH] drm/i915/mtl: Media GT and Render GT share common GGTT

2022-11-07 Thread Iddamsetty, Aravind
On 31-10-2022 23:16, Matt Roper wrote: > On Mon, Oct 31, 2022 at 06:01:11PM +0530, Aravind Iddamsetty wrote: >> On XE_LPM+ platforms the media engines are carved out into a separate >> GT but have a common GGTMMADR address range which essentially makes >> the GGTT address space to be shared betw

[PATCH v7 00/23] drm: Analog TV Improvements

2022-11-07 Thread Maxime Ripard
Hi, Here's a series aiming at improving the command line named modes support, and more importantly how we deal with all the analog TV variants. The named modes support were initially introduced to allow to specify the analog TV mode to be used. However, this was causing multiple issues: * The

[PATCH v7 01/23] drm/tests: Add Kunit Helpers

2022-11-07 Thread Maxime Ripard
As the number of kunit tests in KMS grows further, we start to have multiple test suites that, for example, need to register a mock DRM driver to interact with the KMS function they are supposed to test. Let's add a file meant to provide those kind of helpers to avoid duplication. Reviewed-by: No

[PATCH printk v3 00/40] reduce console_lock scope

2022-11-07 Thread John Ogness
This is v3 of a series to prepare for threaded/atomic printing. v2 is here [0]. This series focuses on reducing the scope of the BKL console_lock. It achieves this by switching to SRCU and a dedicated mutex for console list iteration and modification, respectively. The console_lock will no longer o

[PATCH v7 02/23] drm/connector: Rename legacy TV property

2022-11-07 Thread Maxime Ripard
The current tv_mode has driver-specific values that don't allow to easily share code using it, either at the userspace or kernel level. Since we're going to introduce a new, generic, property that fit the same purpose, let's rename this one to legacy_tv_mode to make it obvious we should move away

[PATCH v7 03/23] drm/connector: Only register TV mode property if present

2022-11-07 Thread Maxime Ripard
The drm_create_tv_properties() will create the TV mode property unconditionally. However, since we'll gradually phase it out, let's register it only if we have a list passed as an argument. This will make the transition easier. Acked-by: Noralf Trønnes Signed-off-by: Maxime Ripard --- drivers/

[PATCH printk v3 33/40] printk, xen: fbfront: create/use safe function for forcing preferred

2022-11-07 Thread John Ogness
With commit 9e124fe16ff2("xen: Enable console tty by default in domU if it's not a dummy") a hack was implemented to make sure that the tty console remains the console behind the /dev/console device. The main problem with the hack is that, after getting the console pointer to the tty console, it is

[PATCH v7 04/23] drm/connector: Rename drm_mode_create_tv_properties

2022-11-07 Thread Maxime Ripard
drm_mode_create_tv_properties(), among other things, will create the "mode" property that stores the analog TV mode that connector is supposed to output. However, that property is getting deprecated, so let's rename that function to mention it's deprecated. We'll introduce a new variant of that fu

[PATCH v7 06/23] drm/modes: Add a function to generate analog display modes

2022-11-07 Thread Maxime Ripard
Multiple drivers (meson, vc4, sun4i) define analog TV 525-lines and 625-lines modes in their drivers. Since those modes are fairly standard, and that we'll need to use them in more places in the future, it makes sense to move their definition into the core framework. However, analog display usual

[PATCH v7 05/23] drm/connector: Add TV standard property

2022-11-07 Thread Maxime Ripard
The TV mode property has been around for a while now to select and get the current TV mode output on an analog TV connector. Despite that property name being generic, its content isn't and has been driver-specific which makes it hard to build any generic behaviour on top of it, both in kernel and

[PATCH v7 07/23] drm/client: Add some tests for drm_connector_pick_cmdline_mode()

2022-11-07 Thread Maxime Ripard
drm_connector_pick_cmdline_mode() is in charge of finding a proper drm_display_mode from the definition we got in the video= command line argument. Let's add some unit tests to make sure we're not getting any regressions there. Acked-by: Noralf Trønnes Signed-off-by: Maxime Ripard --- Changes

[PATCH v7 08/23] drm/modes: Move named modes parsing to a separate function

2022-11-07 Thread Maxime Ripard
The current construction of the named mode parsing doesn't allow to extend it easily. Let's move it to a separate function so we can add more parameters and modes. In order for the tests to still pass, some extra checks are needed, so it's not a 1:1 move. Reviewed-by: Noralf Trønnes Signed-off-b

[PATCH v7 09/23] drm/modes: Switch to named mode descriptors

2022-11-07 Thread Maxime Ripard
The current named mode parsing relies only on the mode name, and doesn't allow to specify any other parameter. Let's convert that string list to an array of a custom structure that will hold the name and some additional parameters in the future. Reviewed-by: Noralf Trønnes Signed-off-by: Maxime

[PATCH v7 11/23] drm/connector: Add pixel clock to cmdline mode

2022-11-07 Thread Maxime Ripard
We'll need to get the pixel clock to generate proper display modes for all the current named modes. Let's add it to struct drm_cmdline_mode and fill it when parsing the named mode. Reviewed-by: Noralf Trønnes Signed-off-by: Maxime Ripard --- Changes in v7: - Add Noralf Reviewed-by:w --- driver

[PATCH v7 10/23] drm/modes: Fill drm_cmdline mode from named modes

2022-11-07 Thread Maxime Ripard
The current code to deal with named modes will only set the mode name, and then it's up to drivers to try to match that name to whatever mode or configuration they see fit. The plan is to remove that need and move the named mode handling out of drivers and into the core, and only rely on modes and

  1   2   3   4   >