Re: [PATCH v7 07/10] drm: bridge: samsung-dsim: Add atomic_get_input_bus_fmts

2022-11-03 Thread Jagan Teki
On Mon, Oct 17, 2022 at 12:54 PM Marek Vasut wrote: > > On 10/17/22 05:58, Jagan Teki wrote: > > On Sun, Oct 16, 2022 at 3:31 AM Marek Vasut wrote: > >> > >> On 10/5/22 17:13, Jagan Teki wrote: > >> > >> [...] > >> > >>> @@ -1321,6 +1322,32 @@ static void > >>> samsung_dsim_atomic_post_disable(s

[PULL] drm-intel-gt-next

2022-11-03 Thread Joonas Lahtinen
Hi Dave & Daniel, This amends the previous PR that did cause a build error with clang: https://lists.freedesktop.org/archives/dri-devel/2022-October/377713.html Quite naturally, it includes a fix to the hwmon code tested with Clang version 14.0.5 and GCC 12.2.1. Additionally there is a screen f

RE: [PATCH v6 1/2] dt-bindings: it6505: add properties to restrict output bandwidth

2022-11-03 Thread allen.chen
hi -Original Message- From: Krzysztof Kozlowski Sent: Thursday, November 3, 2022 12:34 AM To: Allen Chen (陳柏宇) Cc: treapk...@chromium.org; Jau-Chih Tseng (曾昭智) ; Hermes Wu (吳佳宏) ; Kenneth Hung (洪家倫) ; andrzej.ha...@intel.com; narmstr...@baylibre.com; robert.f...@linaro.org; laurent.p

[PULL] drm-misc-next

2022-11-03 Thread Maxime Ripard
Hi Dave, Daniel, Here's this week drm-misc-next PR Maxime drm-misc-next-2022-11-03: drm-misc-next for 6.2: UAPI Changes: Cross-subsystem Changes: - dma-buf: locking improvements - firmware: New API in the RaspberryPi firmware driver used by vc4 Core Changes: - client: Null pointer dereference

[ANNOUNCE] libdrm 2.4.114

2022-11-03 Thread Simon Ser
Alex Deucher (5): amdgpu.ids: use consistent formatting for RID amdgpu.ids: sort the file amdgpu.ids: update to the latest marketing name amdgpu_ids: add MI marketing names amdgpu: Add a default marketing name if none is found Eli Schwartz (1): meson: fast-fail

Re: [PATCH] drm/meson: Fix return type of meson_encoder_cvbs_mode_valid()

2022-11-03 Thread Neil Armstrong
Hi, On Wed, 2 Nov 2022 08:52:42 -0700, Nathan Chancellor wrote: > With clang's kernel control flow integrity (kCFI, CONFIG_CFI_CLANG), > indirect call targets are validated against the expected function > pointer prototype to make sure the call target is valid to help mitigate > ROP attacks. If th

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-11-03 Thread Liu Ying
On Tue, 2022-11-01 at 15:04 +0100, Marco Felsch wrote: > Hi Marek, Liu, Hi, > > On 22-10-28, Liu Ying wrote: > > On Fri, 2022-10-28 at 02:03 +0200, Marek Vasut wrote: > > > On 10/27/22 19:47, Marco Felsch wrote: > > > > On 22-10-27, Liu Ying wrote: > > > > > On Thu, 2022-10-27 at 12:03 +0200, Ma

[PULL] drm-intel-fixes

2022-11-03 Thread Tvrtko Ursulin
Hi Dave, Daniel, A few fixes for 6.1. On the display side fixed a race condition in accessing DKL PHY registers (TGL+), fixed LVDS EDID fixed mode setup and fixed SDVO invalid mode filtering. On the GEM side fix running under Xen and use DMA API directly instead of special casing for SWIOTLB only

Re: [PATCH v2] drm: lcdif: Set and enable FIFO Panic threshold

2022-11-03 Thread Liu Ying
On Tue, 2022-11-01 at 16:26 +0100, Marek Vasut wrote: > In case the LCDIFv3 is used to drive a 4k panel via i.MX8MP HDMI > bridge, > the LCDIFv3 becomes susceptible to FIFO underflows, these lead to > nasty > flicker of the image on the panel, or image being shifted by half > frame > horizontally e

Re: [PATCH] drm/i915/guc: don't hardcode BCS0 in guc_hang selftest

2022-11-03 Thread Das, Nirmoy
LGTM Acked-by: Nirmoy Das On 11/2/2022 10:43 PM, Daniele Ceraolo Spurio wrote: On MTL there are no BCS engines on the media GT, so we can't always use BCS0 in the test. There is no actual reason to use a BCS engine over an engine of a different class, so switch to using any available engine. S

[PATCH v7 0/2] *** IT6505 driver read dt properties ***

2022-11-03 Thread allen
This series let driver can read properties from dt to restrict dp output bandwidth. Changes in v3: -Rename property name. Changes in v4: -Use data-lanes and link-frequencies instead of "ite,dp-output-data-lane-count" and "ite,dp-output-max-pixel-clock-mhz". Changes in v5: -Add a port and a endp

[PATCH v7 2/2] drm/bridge: add it6505 driver to read data-lanes and link-frequencies from dt

2022-11-03 Thread allen
From: allen chen Add driver to read data-lanes and link-frequencies from dt property to restrict output bandwidth. Signed-off-by: Allen chen Signed-off-by: Pin-yen Lin --- drivers/gpu/drm/bridge/ite-it6505.c | 80 +++-- 1 file changed, 77 insertions(+), 3 deletions(-)

[PATCH v7 1/2] dt-bindings: it6505: add properties to restrict output bandwidth

2022-11-03 Thread allen
From: allen chen Currently there are no "upstream" users. So, no existing users to break. Add properties to restrict dp output data-lanes and clock. Signed-off-by: Pin-Yen Lin Signed-off-by: Allen Chen --- .../bindings/display/bridge/ite,it6505.yaml | 68 +-- 1 file changed,

Re: [Intel-gfx] [PATCH] drm/i915: Don't wait forever in drop_caches

2022-11-03 Thread Tvrtko Ursulin
On 03/11/2022 01:33, John Harrison wrote: On 11/2/2022 07:20, Tvrtko Ursulin wrote: On 02/11/2022 12:12, Jani Nikula wrote: On Tue, 01 Nov 2022, john.c.harri...@intel.com wrote: From: John Harrison At the end of each test, IGT does a drop caches call via sysfs with sysfs? Sorry, that was

Re: [Intel-gfx] [PATCH] drm/i915: Don't wait forever in drop_caches

2022-11-03 Thread Tvrtko Ursulin
On 03/11/2022 09:18, Tvrtko Ursulin wrote: On 03/11/2022 01:33, John Harrison wrote: On 11/2/2022 07:20, Tvrtko Ursulin wrote: On 02/11/2022 12:12, Jani Nikula wrote: On Tue, 01 Nov 2022, john.c.harri...@intel.com wrote: From: John Harrison At the end of each test, IGT does a drop caches

Re: [PATCH v7 07/10] drm: bridge: samsung-dsim: Add atomic_get_input_bus_fmts

2022-11-03 Thread Jagan Teki
On Sun, Oct 16, 2022 at 3:31 AM Marek Vasut wrote: > > On 10/5/22 17:13, Jagan Teki wrote: > > [...] > > > @@ -1321,6 +1322,32 @@ static void samsung_dsim_atomic_post_disable(struct > > drm_bridge *bridge, > > pm_runtime_put_sync(dsi->dev); > > } > > > > +#define MAX_INPUT_SEL_FORMATS

Re: [igt-dev] [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2022-11-03 Thread Mauro Carvalho Chehab
On Sun, 28 Aug 2022 21:09:19 -0300 Isabella Basso wrote: > This adds functions for both executing the tests as well as parsing (K)TAP > kmsg output, as per the KTAP spec [1]. > > [1] https://www.kernel.org/doc/html/latest/dev-tools/ktap.html > > Signed-off-by: Isabella Basso Hi Isabella, I'm

[PATCH v3 1/2] drm/ofdrm: Convert PCI IDs to CPU endianness for comparing

2022-11-03 Thread Thomas Zimmermann
Properties of 32-bit integers are returned from the OF device tree as type __be32. Convert PCI vendor and device IDs from __be32 to host endianness before comparing them to constants. All relevant machines are old, big-endian Macintosh systems; hence the bug never happened in practice. Fixes spars

[PATCH v3 0/2] drm/ofdrm: Fix sparse warnings

2022-11-03 Thread Thomas Zimmermann
Fix two types of sparse warnings in ofdrm. Reported by the LKP bot. v3: * use IOMEM_ERR_PTR() (Javier) v2: * convert PCI ID endianness (Alex) Thomas Zimmermann (2): drm/ofdrm: Convert PCI IDs to CPU endianness for comparing drm/ofdrm: Cast error pointers to void __iomem * dr

[PATCH v3 2/2] drm/ofdrm: Cast error pointers to void __iomem *

2022-11-03 Thread Thomas Zimmermann
Cast error pointers when returning them as void __iomem *. Fixes a number of Sparse warnings, such as the ones shown below. ../drivers/gpu/drm/tiny/ofdrm.c:439:31: warning: incorrect type in return expression (different address spaces) ../drivers/gpu/drm/tiny/ofdrm.c:439:31:expected void [nod

RE: [PATCH] drm/i915: rename intel_gsc to intel_heci_gsc

2022-11-03 Thread Winkler, Tomas
> > Starting on MTL, the GSC FW is loaded at runtime and will be managed > directly by i915. This means we now have a naming clash around the GSC, as > we have 2 different aspects of it that we need to handle: the HECI interfaces > we export pre-mtl and the new full FW loading and support we have

Re: [Intel-gfx] [PATCH] drm/i915: Don't wait forever in drop_caches

2022-11-03 Thread Jani Nikula
On Wed, 02 Nov 2022, John Harrison wrote: > On 11/2/2022 07:20, Tvrtko Ursulin wrote: >> On 02/11/2022 12:12, Jani Nikula wrote: >>> On Tue, 01 Nov 2022, john.c.harri...@intel.com wrote: From: John Harrison At the end of each test, IGT does a drop caches call via sysfs with >>> >>>

Re: [PATCH] drm: rcar_du: DRM_RCAR_DU optionally depends on RCAR_MIPI_DSI

2022-11-03 Thread Kieran Bingham
Hi Randy, Quoting Randy Dunlap (2022-11-03 06:06:45) > ping. I have verified (on linux-next-20221103) that this is still needed. > Thanks. > > On 10/18/22 11:18, Randy Dunlap wrote: > > When CONFIG_DRM_RCAR_DU=y and CONFIG_DRM_RCAR_MIPI_DSI=m, calls > > from the builtin d

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/guc: Don't deadlock busyness stats vs reset

2022-11-03 Thread Tvrtko Ursulin
On 02/11/2022 19:21, john.c.harri...@intel.com wrote: From: John Harrison The engine busyness stats has a worker function to do things like 64bit extend the 32bit hardware counters. The GuC's reset prepare function flushes out this worker function to ensure no corruption happens during the re

[PATCH] drm/panfrost: Remove type name from internal struct again

2022-11-03 Thread Steven Price
Commit 72655fb942c1 ("drm/panfrost: replace endian-specific types with native ones") accidentally reverted part of the parent commit 7228d9d79248 ("drm/panfrost: Remove type name from internal structs") leading to the situation that the Panfrost UAPI header still doesn't compile correctly in C++.

Re: [igt-dev] [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2022-11-03 Thread Mauro Carvalho Chehab
On Thu, 3 Nov 2022 10:48:40 +0100 Mauro Carvalho Chehab wrote: > On Sun, 28 Aug 2022 21:09:19 -0300 > Isabella Basso wrote: > > > This adds functions for both executing the tests as well as parsing (K)TAP > > kmsg output, as per the KTAP spec [1]. > > > > [1] https://www.kernel.org/doc/html/la

Re: [PATCH] drm: rcar_du: DRM_RCAR_DU optionally depends on RCAR_MIPI_DSI

2022-11-03 Thread Javier Martinez Canillas
Hello Kieran, On 11/3/22 11:59, Kieran Bingham wrote: > Hi Randy, > > Quoting Randy Dunlap (2022-11-03 06:06:45) >> ping. I have verified (on linux-next-20221103) that this is still needed. >> Thanks. >> >> On 10/18/22 11:18, Randy Dunlap wrote:

Re: [PATCH] drm: rcar_du: DRM_RCAR_DU optionally depends on RCAR_MIPI_DSI

2022-11-03 Thread Javier Martinez Canillas
On 11/3/22 12:53, Javier Martinez Canillas wrote: [...] >> > > What this Kconfig expression is saying is that it depends on > DRM_RCAR_MIPI_DSI=y > if DRM_RCAR_DU=y and DRM_RCAR_MIPI_DSI=m if DRM_RCAR_DU=m. But that the it can It should had been s/and/or here but you get the idea. > also be s

Re: [PATCH] drm: rcar_du: DRM_RCAR_DU optionally depends on RCAR_MIPI_DSI

2022-11-03 Thread Kieran Bingham
Quoting Javier Martinez Canillas (2022-11-03 11:53:14) > Hello Kieran, > > On 11/3/22 11:59, Kieran Bingham wrote: > > Hi Randy, > > > > Quoting Randy Dunlap (2022-11-03 06:06:45) > >> ping. I have verified (on linux-next-20221103) that this is still needed. &

Re: [igt-dev] [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2022-11-03 Thread Petri Latvala
On Thu, Nov 03, 2022 at 12:40:59PM +0100, Mauro Carvalho Chehab wrote: > On Thu, 3 Nov 2022 10:48:40 +0100 > Mauro Carvalho Chehab wrote: > > > On Sun, 28 Aug 2022 21:09:19 -0300 > > Isabella Basso wrote: > > > > > This adds functions for both executing the tests as well as parsing (K)TAP > > >

Re: [PATCH v2 02/12] dt-bindings: display: mediatek: add MT8195 hdmi bindings

2022-11-03 Thread Krzysztof Kozlowski
On 02/11/2022 09:31, Guillaume Ranquet wrote: > On Fri, 14 Oct 2022 18:08, Krzysztof Kozlowski > wrote: >> On 14/10/2022 11:15, Guillaume Ranquet wrote: >>> Add mt8195 SoC bindings for hdmi and hdmi-ddc >>> >>> Signed-off-by: Guillaume Ranquet >>> --- >>> .../bindings/display/mediatek/mediatek,h

[PATCH 5/6] drm/i915: Extract VESA DSC bpp alignment to separate function

2022-11-03 Thread Stanislav Lisovskiy
We might to use that function separately from intel_dp_dsc_compute_config for DP DSC over MST case, because allocating bandwidth in that case can be a bit more tricky. So in order to avoid code copy-pasta lets extract this to separate function and reuse it for both SST and MST cases. v2: Removed m

[PATCH 6/6] drm/i915: Bpp/timeslot calculation fixes for DP MST DSC

2022-11-03 Thread Stanislav Lisovskiy
Fix intel_dp_dsc_compute_config, previously timeslots parameter was used in fact not as a timeslots, but more like a ratio timeslots/64, which of course didn't have any effect for SST DSC, but causes now issues for MST DSC. Secondly we need to calculate pipe_bpp using intel_dp_dsc_compute_bpp only

Re: [RFC PATCH v2 1/3] drivers/accel: define kconfig and register a new major

2022-11-03 Thread Oded Gabbay
On Wed, Nov 2, 2022 at 11:04 PM Jeffrey Hugo wrote: > > On 11/2/2022 2:34 PM, Oded Gabbay wrote: > > diff --git a/drivers/accel/accel_drv.c b/drivers/accel/accel_drv.c > > new file mode 100644 > > index ..6132765ea054 > > --- /dev/null > > +++ b/drivers/accel/accel_drv.c > > @@ -0,0 +1

Re: [RFC PATCH v2 1/3] drivers/accel: define kconfig and register a new major

2022-11-03 Thread Oded Gabbay
On Thu, Nov 3, 2022 at 12:58 AM Randy Dunlap wrote: > > > > On 11/2/22 13:34, Oded Gabbay wrote: > > diff --git a/drivers/accel/Kconfig b/drivers/accel/Kconfig > > new file mode 100644 > > index ..282ea24f90c5 > > --- /dev/null > > +++ b/drivers/accel/Kconfig > > @@ -0,0 +1,24 @@ > > +

Re: [RFC PATCH v2 1/3] drivers/accel: define kconfig and register a new major

2022-11-03 Thread Oded Gabbay
On Thu, Nov 3, 2022 at 2:31 AM Greg Kroah-Hartman wrote: > > On Wed, Nov 02, 2022 at 10:34:03PM +0200, Oded Gabbay wrote: > > --- /dev/null > > +++ b/drivers/accel/Kconfig > > @@ -0,0 +1,24 @@ > > +# SPDX-License-Identifier: GPL-2.0-only > > +# > > +# Compute Acceleration device configuration > >

[PATCH] drm/edid: make a couple of read-only arrays static const

2022-11-03 Thread Colin Ian King
Don't populate two read-only arrays on the stack but instead make them static const . Also makes the object code a little smaller. Signed-off-by: Colin Ian King --- drivers/gpu/drm/drm_edid.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/dri

Re: [RESEND PATCH v1] dt-bindings: display/msm: convert MDP5 schema to YAML format

2022-11-03 Thread Krzysztof Kozlowski
On 02/11/2022 18:08, Dmitry Baryshkov wrote: > Convert the mdp5.txt into the yaml format. Changes to the existing (txt) > schema: > - MSM8996 has additional "iommu" clock, define it separately > - Add new properties used on some of platforms: >- interconnects, interconnect-names >- iommu

Re: [PATCH] drm/edid: make a couple of read-only arrays static const

2022-11-03 Thread Jani Nikula
On Thu, 03 Nov 2022, Colin Ian King wrote: > Don't populate two read-only arrays on the stack but instead make > them static const . Also makes the object code a little smaller. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/drm_edid.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 de

Re: [PATCH 1/7] drm/atomic: log drm_atomic_replace_property_blob_from_id() errors

2022-11-03 Thread Simon Ser
Ping

Re: [PATCH v2 1/8] dt-bindings: display/msm/dsi-controller-main: allow defining opp-table

2022-11-03 Thread Krzysztof Kozlowski
On 02/11/2022 19:13, Dmitry Baryshkov wrote: > Allow defining DSI OPP table inside the DSI controller node. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 2/8] dt-bindings: display/msm: add sm8350 and sm8450 DSI PHYs

2022-11-03 Thread Krzysztof Kozlowski
On 02/11/2022 19:13, Dmitry Baryshkov wrote: > SM8350 and SM8450 platforms use the same driver and same bindings as the > existing 7nm DSI PHYs. Add corresponding compatibility strings. > > Signed-off-by: Dmitry Baryshkov > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 3/8] dt-bindings: display/msm: add support for the display on SM8450

2022-11-03 Thread Krzysztof Kozlowski
On 02/11/2022 19:13, Dmitry Baryshkov wrote: > Add DPU and MDSS schemas to describe MDSS and DPU blocks on the Qualcomm > SM8450 platform. > > Signed-off-by: Dmitry Baryshkov > --- > .../bindings/display/msm/qcom,sm8450-dpu.yaml | 132 +++ > .../display/msm/qcom,sm8450-mdss.yaml | 34

[PATCH] drm/ingenic: Fix missing platform_driver_unregister() call in ingenic_drm_init()

2022-11-03 Thread Yuan Can
A problem about modprobe ingenic-drm failed is triggered with the following log given: [ 303.561088] Error: Driver 'ingenic-ipu' is already registered, aborting... modprobe: ERROR: could not insert 'ingenic_drm': Device or resource busy The reason is that ingenic_drm_init() returns platform_dr

[PATCH v3 1/4] dt-bindings: vendor-prefixes: Document Chongzhou

2022-11-03 Thread Jagan Teki
Chongzhou is a professional is a manufacturer of LCD panels from Shenzhen. Add vendor prefix for it. Acked-by: Krzysztof Kozlowski Signed-off-by: Jagan Teki --- Changes for v3, v2: - none Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --gi

[PATCH v3 2/4] dt-bindings: vendor-prefixes: Document Jadard

2022-11-03 Thread Jagan Teki
Jadard Technology Inc. manufactures and distributes chips from Shenzhen. Add vendor prefix for it. Signed-off-by: Jagan Teki Acked-by: Krzysztof Kozlowski --- Changes for v3, v2: - none Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH v3 3/4] dt-bindings: display: Document Jadard JD9365DA-H3 DSI panel

2022-11-03 Thread Jagan Teki
Jadard JD9365DA-H3 is WXGA MIPI DSI panel and it support TFT dot matrix LCD with 800RGBx1280 dots at maximum. Document it. Cc: dri-devel@lists.freedesktop.org Signed-off-by: Jagan Teki Reviewed-by: Krzysztof Kozlowski --- Changes for v3: - updated title - collect Krzysztof r-b - rebased on drm-

[PATCH v3 4/4] drm: panel: Add Jadard JD9365DA-H3 DSI panel

2022-11-03 Thread Jagan Teki
Jadard JD9365DA-H3 is WXGA MIPI DSI panel and it support TFT dot matrix LCD with 800RGBx1280 dots at maximum. Add support for it. Cc: dri-devel@lists.freedesktop.org Signed-off-by: Jagan Teki --- Changes for v3: - updatd to WXGA - use JD9365DA_CMD_DCS and JD9365DA_CMD_DELAY Changes for v2: - non

Re: [PATCH v1 9/9] arm64: dts: qcom: sm8350-hdk: Enable lt9611uxc dsi-hdmi bridge

2022-11-03 Thread Dmitry Baryshkov
On 28/10/2022 16:56, Dmitry Baryshkov wrote: On 28/10/2022 15:08, Robert Foss wrote: The sm8350-hdk ships with the LT9611 UXC DSI/HDMI bridge chip. In order to toggle the board to enable the HDMI output, switch #7 & #8 on the rightmost multi-switch package have to be toggled to On. Since this

Re: [PATCH v2 2/2] drm/msm: Hangcheck progress detection

2022-11-03 Thread Rob Clark
On Wed, Nov 2, 2022 at 4:26 PM Dmitry Baryshkov wrote: > > On 02/11/2022 01:33, Rob Clark wrote: > > From: Rob Clark > > > > If the hangcheck timer expires, check if the fw's position in the > > cmdstream has advanced (changed) since last timer expiration, and > > allow it up to three additional

Re: [PATCH] drm/mediatek: Fix return type of mtk_hdmi_bridge_mode_valid()

2022-11-03 Thread AngeloGioacchino Del Regno
Il 02/11/22 16:47, Nathan Chancellor ha scritto: With clang's kernel control flow integrity (kCFI, CONFIG_CFI_CLANG), indirect call targets are validated against the expected function pointer prototype to make sure the call target is valid to help mitigate ROP attacks. If they are not identical,

[PATCH RFC v2 5/8] drm/i915: add live selftests to KUnit

2022-11-03 Thread Mauro Carvalho Chehab
Now that i915 KUnit has PCI support, add live tests as well. NOTE: currently, some tests are failing when excecuting via KUnit. I'll do a further investigation to check why, and if this patch can be safely merged or not. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large n

[PATCH RFC v2 6/8] drm/i915: add perf selftests to KUnit

2022-11-03 Thread Mauro Carvalho Chehab
Now that i915 KUnit has PCI support, add perf tests as well. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH RFC v2 0/8] at: https://lore.kernel.org/all/cover.1667486144.git.mche...@kernel.org/ dr

[PATCH RFC v2 8/8] drm/i915: check if current->mm is not NULL

2022-11-03 Thread Mauro Carvalho Chehab
The mmap tests require mm in order to work. Failing to do that will cause a crash: [ 316.820722] BUG: kernel NULL pointer dereference, address: 00e8 [ 316.822517] #PF: supervisor write access in kernel mode [ 316.823430] #PF: error_code(0x0002) - not-present page [ 316.824390] PGD

[PATCH RFC v2 4/8] drm/i915: add support to run KUnit tests on bare metal

2022-11-03 Thread Mauro Carvalho Chehab
Add a logic to seek for PCI devices and to run tests on them, if the tests are willing to run on physical hardware, instead of using Qemu. Later patches will add the KUnit tests. So, for now, mark such functions with __maybe_unused, to avoid build issues with WERROR. Signed-off-by: Mauro Carvalho

[PATCH RFC v2 1/8] drm/i915: export all selftest functions

2022-11-03 Thread Mauro Carvalho Chehab
In order to prepare for a new KUnit module that will run selftests, export all selftest functions to I915_SELFTEST namespace. No functional changes. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH R

[PATCH RFC v2 3/8] drm/i915: allow running mock selftests via Kunit

2022-11-03 Thread Mauro Carvalho Chehab
The mock selftests don't require any hardware to run. They can easily run via kunit with qemu or bare metal. Add support for it. With this change, mock selftest can now run in qemu with: $ ./tools/testing/kunit/kunit.py run --arch=x86_64 \ --kunitconfig=drivers/gpu/drm/i9

[PATCH RFC v2 7/8] drm/i915: now that all functions are used, remove __maybe_unused

2022-11-03 Thread Mauro Carvalho Chehab
The PCI-specific KUnit tests that run in bare metal got added, so we can remove the __maybe_unused from such functions. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH RFC v2 0/8] at: https://lore.k

[PATCH RFC v2 2/8] drm/i915: place selftest preparation on a separate function

2022-11-03 Thread Mauro Carvalho Chehab
The selftest preparation logic should also be used by KUnit. So, place it on a separate function and export it. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH RFC v2 0/8] at: https://lore.kernel.or

[PATCH RFC v2 0/8] Add KUnit support for i915 driver

2022-11-03 Thread Mauro Carvalho Chehab
This RFC patch series implement KUnit support for i915 driver, using the already-existing tests inside i915 selftests. On this version, mock selftest can now run in qemu with: $ ./tools/testing/kunit/kunit.py run --arch=x86_64 \ --kunitconfig=drivers/gpu/drm/i915/selftests

Re: [igt-dev] [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2022-11-03 Thread Mauro Carvalho Chehab
On Thu, 3 Nov 2022 10:48:40 +0100 Mauro Carvalho Chehab wrote: > On Sun, 28 Aug 2022 21:09:19 -0300 > Isabella Basso wrote: > > > This adds functions for both executing the tests as well as parsing (K)TAP > > kmsg output, as per the KTAP spec [1]. > > > > [1] https://www.kernel.org/doc/html/la

Re: [PATCH] drm/ingenic: Fix missing platform_driver_unregister() call in ingenic_drm_init()

2022-11-03 Thread Paul Cercueil
Hi Yuan, Le jeu. 3 nov. 2022 à 14:01:48 +, Yuan Can a écrit : A problem about modprobe ingenic-drm failed is triggered with the following log given: [ 303.561088] Error: Driver 'ingenic-ipu' is already registered, aborting... modprobe: ERROR: could not insert 'ingenic_drm': Device or

[PATCH v3 01/23] drm/komeda: Don't set struct drm_driver.lastclose

2022-11-03 Thread Thomas Zimmermann
Don't set struct drm_driver.lastclose. It's used to restore the fbdev console. But as komeda uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the call to drm_client_dev_restore() in drm_lastclose(). Signed-off-by: Thomas Zimmermann Reviewed-by: Ja

[PATCH v3 00/23] drm/fb-helper: Untangle fbdev emulation and helpers

2022-11-03 Thread Thomas Zimmermann
Separate generic fbdev emulation from the helper code that is shared among the various fbdev implementations within DRM. Affects many drivers. It has become apparent that our fully generic fbdev emulation will never produce optimal results for all drivers. In its current form, it is also hard to m

[PATCH v3 08/23] drm/rockchip: Don't set struct drm_driver.output_poll_changed

2022-11-03 Thread Thomas Zimmermann
Don't set struct drm_driver.output_poll_changed. It's used to restore the fbdev console. But as rockchip uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the functions drm_kms_helper_hotplug_event() and drm_kms_helper_connector_hotplug_event() in dr

[PATCH v3 02/23] drm/mcde: Don't set struct drm_driver.lastclose

2022-11-03 Thread Thomas Zimmermann
Don't set struct drm_driver.lastclose. It's used to restore the fbdev console. But as mcde uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the call to drm_client_dev_restore() in drm_lastclose(). Signed-off-by: Thomas Zimmermann Reviewed-by: Javi

[PATCH v3 06/23] drm/ingenic: Don't set struct drm_driver.output_poll_changed

2022-11-03 Thread Thomas Zimmermann
Don't set struct drm_driver.output_poll_changed. It's used to restore the fbdev console. But as ingenic uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the functions drm_kms_helper_hotplug_event() and drm_kms_helper_connector_hotplug_event() in drm

[PATCH v3 05/23] drm/imx/dcss: Don't set struct drm_driver.output_poll_changed

2022-11-03 Thread Thomas Zimmermann
Don't set struct drm_driver.output_poll_changed. It's used to restore the fbdev console. But as DCSS uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the functions drm_kms_helper_hotplug_event() and drm_kms_helper_connector_hotplug_event() in drm_pr

[PATCH v3 07/23] drm/logicvc: Don't set struct drm_driver.output_poll_changed

2022-11-03 Thread Thomas Zimmermann
Don't set struct drm_driver.output_poll_changed. It's used to restore the fbdev console. But as logicvc uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the functions drm_kms_helper_hotplug_event() and drm_kms_helper_connector_hotplug_event() in drm

[PATCH v3 03/23] drm/vboxvideo: Don't set struct drm_driver.lastclose

2022-11-03 Thread Thomas Zimmermann
Don't set struct drm_driver.lastclose. It's used to restore the fbdev console. But as vboxvideo uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the call to drm_client_dev_restore() in drm_lastclose(). Signed-off-by: Thomas Zimmermann Reviewed-by:

[PATCH v3 10/23] drm/tve200: Include

2022-11-03 Thread Thomas Zimmermann
Include for of_match_ptr(). Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/tve200/tve200_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/tve200/tve200_drv.c b/drivers/gpu/drm/tve200/tve200_drv.c index 04db72e3fa9c2..611785e

[PATCH v3 14/23] drm/fb-helper: Rename drm_fb_helper_unregister_fbi() to use _info postfix

2022-11-03 Thread Thomas Zimmermann
Rename drm_fb_helper_unregister_fbi() to drm_fb_helper_unregister_info() as part of unifying the naming within fbdev helpers. Adapt drivers. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/armada/armada_fbdev.c | 2 +- drive

[PATCH v3 18/23] drm/fb_helper: Minimize damage-helper overhead

2022-11-03 Thread Thomas Zimmermann
Pull the test for fb_dirty into the caller to avoid extra work if no callback has been set. In this case no damage handling is required and no damage area needs to be computed. Print a warning if the damage worker runs without getting an fb_dirty callback. Signed-off-by: Thomas Zimmermann Reviewe

[PATCH v3 21/23] drm/fb-helper: Move generic fbdev emulation into separate source file

2022-11-03 Thread Thomas Zimmermann
Move the generic fbdev implementation into its own source and header file. Adapt drivers. No functional changes, but some of the internal helpers have been renamed to fit into the drm_fbdev_ naming scheme. v3: * rename drm_fbdev.{c,h} to drm_fbdev_generic.{c,h} * rebase onto vmwgfx

[PATCH v3 22/23] drm/fb-helper: Remove unnecessary include statements

2022-11-03 Thread Thomas Zimmermann
Remove include statements for where it is not required (i.e., most of them). In a few places include other header files that are required by the source code. v3: * fix amdgpu include statements * fix rockchip include statements Signed-off-by: Thomas Zimmermann Reviewed-by: Javie

[PATCH v3 16/23] drm/fb-helper: Call fb_sync in I/O functions

2022-11-03 Thread Thomas Zimmermann
Call struct fb_ops.fb_sync in drm_fbdev_{read,write}() to mimic the behavior of fbdev. Fbdev implementations of fb_read and fb_write in struct fb_ops invoke fb_sync to synchronize with outstanding operations before I/O. Doing the same in DRM implementations will allow us to use them throughout DRM

[PATCH v3 19/23] drm/fb-helper: Always initialize generic fbdev emulation

2022-11-03 Thread Thomas Zimmermann
Initialize the generic fbdev emulation even if it has been disabled on the kernel command line. The hotplug and mode initialization will fail accordingly. The kernel parameter can still be changed at runtime and the emulation will initialize after hotplugging the connector. Signed-off-by: Thomas

[PATCH v3 13/23] drm/fb-helper: Rename drm_fb_helper_alloc_fbi() to use _info postfix

2022-11-03 Thread Thomas Zimmermann
Rename drm_fb_helper_alloc_fbi() to drm_fb_helper_alloc_info() as part of unifying the naming within fbdev helpers. Adapt drivers. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/armada/armada_fbdev.c | 2 +- drivers/gpu/drm

[PATCH v3 04/23] drm/amdgpu: Don't set struct drm_driver.output_poll_changed

2022-11-03 Thread Thomas Zimmermann
Don't set struct drm_driver.output_poll_changed. It's used to restore the fbdev console. But as amdgpu uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the functions drm_kms_helper_hotplug_event() and drm_kms_helper_connector_hotplug_event() in drm_

[PATCH v3 12/23] drm/fb_helper: Rename field fbdev to info in struct drm_fb_helper

2022-11-03 Thread Thomas Zimmermann
Rename struct drm_fb_helper.fbdev to info. The current name is misleading as it overlaps with generic fbdev naming conventions. Adapt to the usual naming in fbdev drivers by calling the field 'info'. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --

[PATCH v3 20/23] drm/fb-helper: Set flag in struct drm_fb_helper for leaking physical addresses

2022-11-03 Thread Thomas Zimmermann
Uncouple the parameter drm_leak_fbdev_smem from the implementation by setting a flag in struct drm_fb_helper. This will help to move the generic fbdev emulation into its own source file, while keeping the parameter in drm_fb_helper.c. No functional changes. Signed-off-by: Thomas Zimmermann --- d

[PATCH v3 09/23] drm/panel-ili9341: Include

2022-11-03 Thread Thomas Zimmermann
Include for devm_of_find_backlight(). Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-i

[PATCH v3 11/23] drm/fb-helper: Cleanup include statements in header file

2022-11-03 Thread Thomas Zimmermann
Only include what we have to. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- include/drm/drm_fb_helper.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h index fddd0d1af6891..e92308952

[PATCH v3 23/23] drm/fb-helper: Clarify use of last_close and output_poll_changed

2022-11-03 Thread Thomas Zimmermann
Clarify documentation in the use of struct drm_driver.last_close and struct drm_mode_config_funcs.output_poll_changed. Those callbacks should not be said for fbdev implementations on top of struct drm_client_funcs. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fb_helper.c | 6 --

[PATCH v3 17/23] drm/fb-helper: Perform all fbdev I/O with the same implementation

2022-11-03 Thread Thomas Zimmermann
Implement the fbdev's read/write helpers with the same functions. Use the generic fbdev's code as template. Convert all drivers. DRM's fb helpers must implement regular I/O functionality in struct fb_ops and possibly perform a damage update. Handle all this in the same functions and convert driver

Re: [PATCH v2 02/12] dt-bindings: display: mediatek: add MT8195 hdmi bindings

2022-11-03 Thread Guillaume Ranquet
On Thu, 03 Nov 2022 13:45, Krzysztof Kozlowski wrote: >On 02/11/2022 09:31, Guillaume Ranquet wrote: >> On Fri, 14 Oct 2022 18:08, Krzysztof Kozlowski >> wrote: >>> On 14/10/2022 11:15, Guillaume Ranquet wrote: Add mt8195 SoC bindings for hdmi and hdmi-ddc Signed-off-by: Guillaume

[PATCH v3 15/23] drm/fb-helper: Disconnect damage worker from update logic

2022-11-03 Thread Thomas Zimmermann
The fbdev helpers implement a damage worker that forwards fbdev updates to the DRM driver. The worker's update logic depends on the generic fbdev emulation. Separate the two via function pointer. The generic fbdev emulation sets struct drm_fb_helper_funcs.fb_dirty, a new callback that hides the up

KUnit issues - Was: [igt-dev] [PATCH RFC v2 8/8] drm/i915: check if current->mm is not NULL

2022-11-03 Thread Mauro Carvalho Chehab
Hi, I'm facing a couple of issues when testing KUnit with the i915 driver. The DRM subsystem and the i915 driver has, for a long time, his own way to do unit tests, which seems to be added before KUnit. I'm now checking if it is worth start using KUnit at i915. So, I wrote a RFC with some patche

Re: [PATCH v2 02/12] dt-bindings: display: mediatek: add MT8195 hdmi bindings

2022-11-03 Thread Krzysztof Kozlowski
On 03/11/2022 11:17, Guillaume Ranquet wrote: > On Thu, 03 Nov 2022 13:45, Krzysztof Kozlowski >>> This is an i2c adapter, not a device. >>> And as it lives inside the HDMI hw block, I've omitted using an address >>> here. >>> >>> Is this valid? or should this be expressed differently? >> >> What

[PATCH] drm: sti: Make array en_di static const

2022-11-03 Thread Colin Ian King
Don't populate the read-only array en_di on the stack but instead make it static. Also makes the object code a little smaller. Signed-off-by: Colin Ian King --- drivers/gpu/drm/sti/sti_hdmi.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_h

Re: [PATCH v7 1/2] dt-bindings: it6505: add properties to restrict output bandwidth

2022-11-03 Thread Krzysztof Kozlowski
On 03/11/2022 05:12, allen wrote: > From: allen chen > > Currently there are no "upstream" users. So, no existing users to break. > Add properties to restrict dp output data-lanes and clock. > > Signed-off-by: Pin-Yen Lin > Signed-off-by: Allen Chen Reviewed-by: Krzysztof Kozlowski Best re

Re: [PATCH v7 07/10] drm: bridge: samsung-dsim: Add atomic_get_input_bus_fmts

2022-11-03 Thread Marek Vasut
On 11/3/22 10:39, Jagan Teki wrote: On Sun, Oct 16, 2022 at 3:31 AM Marek Vasut wrote: On 10/5/22 17:13, Jagan Teki wrote: [...] @@ -1321,6 +1322,32 @@ static void samsung_dsim_atomic_post_disable(struct drm_bridge *bridge, pm_runtime_put_sync(dsi->dev); } +#define MAX_INPUT_SEL

Re: [PATCH v7 07/10] drm: bridge: samsung-dsim: Add atomic_get_input_bus_fmts

2022-11-03 Thread Marek Vasut
On 11/3/22 08:40, Jagan Teki wrote: On Mon, Oct 17, 2022 at 12:54 PM Marek Vasut wrote: On 10/17/22 05:58, Jagan Teki wrote: On Sun, Oct 16, 2022 at 3:31 AM Marek Vasut wrote: On 10/5/22 17:13, Jagan Teki wrote: [...] @@ -1321,6 +1322,32 @@ static void samsung_dsim_atomic_post_disable(s

Re: [PATCH] drm: rcar_du: DRM_RCAR_DU optionally depends on RCAR_MIPI_DSI

2022-11-03 Thread Randy Dunlap
Hi, On 11/3/22 04:53, Javier Martinez Canillas wrote: > Hello Kieran, > > On 11/3/22 11:59, Kieran Bingham wrote: >> Hi Randy, >> >> Quoting Randy Dunlap (2022-11-03 06:06:45) >>> ping. I have verified (on linux-next-20221103) that this is still needed. &

Re: [PATCH 3/9] drm/i915: Use kmap_local_page() in gem/i915_gem_shmem.c

2022-11-03 Thread Ira Weiny
On Mon, Oct 17, 2022 at 05:37:19PM +0800, Zhao Liu wrote: > From: Zhao Liu > > The use of kmap_atomic() is being deprecated in favor of > kmap_local_page()[1]. > > The main difference between atomic and local mappings is that local > mappings doesn't disable page faults or preemption. > > In dr

Re: [PATCH 1/9] drm/i915: Use kmap_local_page() in gem/i915_gem_object.c

2022-11-03 Thread Ira Weiny
On Sat, Oct 29, 2022 at 01:17:03PM +0200, Fabio M. De Francesco wrote: > On lunedì 17 ottobre 2022 11:37:17 CEST Zhao Liu wrote: > > From: Zhao Liu > > > > The use of kmap_atomic() is being deprecated in favor of > > kmap_local_page()[1]. > > > > The main difference between atomic and local mapp

Re: [PATCH v7 07/10] drm: bridge: samsung-dsim: Add atomic_get_input_bus_fmts

2022-11-03 Thread Jagan Teki
On Thu, Nov 3, 2022 at 9:56 PM Marek Vasut wrote: > > On 11/3/22 10:39, Jagan Teki wrote: > > On Sun, Oct 16, 2022 at 3:31 AM Marek Vasut wrote: > >> > >> On 10/5/22 17:13, Jagan Teki wrote: > >> > >> [...] > >> > >>> @@ -1321,6 +1322,32 @@ static void > >>> samsung_dsim_atomic_post_disable(stru

[PATCH 1/2] component: Add helper for device nodes

2022-11-03 Thread Sean Anderson
There is a common case where component_patch_add_release is called with component_release_of/component_compare_of and a device node. Add a helper and convert existing users. Signed-off-by: Sean Anderson --- drivers/iommu/mtk_iommu.c| 3 +-- drivers/iommu/mtk_iommu_v1.c | 3 +-- include/linu

[PATCH 0/2] drm: Add component_match_add_of and convert users of drm_of_component_match_add

2022-11-03 Thread Sean Anderson
This series adds a new function component_match_add_of to simplify the common case of calling component_match_add_release with component_release_of and component_compare_of. There is already drm_of_component_match_add, which allows for a custom compare function. However, all existing users just use

[PATCH 2/2] drm: Convert users of drm_of_component_match_add to component_match_add_of

2022-11-03 Thread Sean Anderson
Every user of this function either uses component_compare_of or something equivalent. Most of them immediately put the device node as well. Convert these users to component_match_add_of and remove drm_of_component_match_add. Signed-off-by: Sean Anderson --- .../gpu/drm/arm/display/komeda/komeda

  1   2   >