[PATCH v4] media: mediatek: vcodec: Add to support VP9 inner racing mode

2022-10-24 Thread Mingjia Zhang
In order to reduce decoder latency, enable VP9 inner racing mode. Send lat trans buffer information to core when trigger lat to work, need not to wait until lat decode done. Signed-off-by: Mingjia Zhang --- Changes from v3: - CTS/GTS test pass - Fluster result: Ran 275/303 tests successfully Ch

Re: Fixes for scheduler hang when killing a process

2022-10-24 Thread Luben Tuikov
On 2022-10-14 04:46, Christian König wrote: > Hi guys, > > rebased those patches on top of amd-staging-drm-next since the > amdgpu changes are quite substencial. > > Please review and comment, > Christian. Hi Christian, The changes are good and I think asynchronous is the way to go. I'm also r

[PATCH v2] drm/amd/display: Revert logic for plane modifiers

2022-10-24 Thread Joaquín Ignacio Aramendía
This file was split in commit 5d945cbcd4b16a29d6470a80dfb19738f9a4319f ("drm/amd/display: Create a file dedicated to planes") and the logic in dm_plane_format_mod_supported() function got changed by a switch logic. That change broke drm_plane modifiers setting on series 5000 APUs (tested on OXP min

Re: [RFC PATCH v5 4/6] drm/tidss: Add support to configure OLDI mode for am625-dss.

2022-10-24 Thread Tomi Valkeinen
On 18/10/2022 10:00, Aradhya Bhatia wrote: Hi Tomi Thank you for the comprehensive feedback across all the patches. I am working on them. I do have some concerns which I have talked about, below. On 12-Oct-22 17:53, Tomi Valkeinen wrote: On 28/09/2022 20:52, Aradhya Bhatia wrote: The newer v

Re: [PATCH 1/2] drm/sched: add DRM_SCHED_FENCE_DONT_PIPELINE flag

2022-10-24 Thread Luben Tuikov
On 2022-10-14 04:15, Christian König wrote: > Setting this flag on a scheduler fence prevents pipelining of jobs > depending on this fence. In other words we always insert a full CPU > round trip before dependen jobs are pushed to the pipeline. "dependent" > > Signed-off-by: Christian König > C

Re: [RFC PATCH 1/3] drivers/accel: add new kconfig and update MAINTAINERS

2022-10-24 Thread Oded Gabbay
On Sun, Oct 23, 2022 at 3:40 PM Greg Kroah-Hartman wrote: > > On Sun, Oct 23, 2022 at 12:46:20AM +0300, Oded Gabbay wrote: > > Add a new Kconfig for the accel subsystem. The Kconfig currently > > contains only the basic CONFIG_ACCEL option that will be used to > > decide whether to compile the acc

Re: [PATCH 2/2] drm/amdgpu: use DRM_SCHED_FENCE_DONT_PIPELINE for VM updates

2022-10-24 Thread Luben Tuikov
On 2022-10-17 02:27, Christian König wrote: > Am 17.10.22 um 07:29 schrieb Luben Tuikov: >> Hi Christian, >> >> On 2022-10-14 04:15, Christian König wrote: >>> Make sure that we always have a CPU round trip to let the submission >>> code correctly decide if a TLB flush is necessary or not. >>> >>>

Re: [RFC PATCH 2/3] drm: define new accel major and register it

2022-10-24 Thread Oded Gabbay
On Sun, Oct 23, 2022 at 3:40 PM Greg Kroah-Hartman wrote: > > On Sun, Oct 23, 2022 at 12:46:21AM +0300, Oded Gabbay wrote: > > The accelerator devices will be exposed to the user space with a new, > > dedicated major number - 261. > > > > The drm core registers the new major number as a char devic

Re: [RFC PATCH 3/3] drm: add dedicated minor for accelerator devices

2022-10-24 Thread Oded Gabbay
On Sun, Oct 23, 2022 at 3:41 PM Greg Kroah-Hartman wrote: > > On Sun, Oct 23, 2022 at 12:46:22AM +0300, Oded Gabbay wrote: > > +/** > > + * accel_open - open method for ACCEL file > > + * @inode: device inode > > + * @filp: file pointer. > > + * > > + * This function must be used by drivers as the

Re: (subset) [PATCH] drm/vc4: Fix spelling mistake "mmaping" -> "mmapping"

2022-10-24 Thread maxime
On Fri, 21 Oct 2022 09:40:35 +0100, Colin Ian King wrote: > There are a couple of spelling mistakes in DRM_DEBUG messages. Fix them. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: (subset) [PATCH] gpu/drm: fix repeated words in comments

2022-10-24 Thread maxime
On Sat, 22 Oct 2022 14:07:01 +0800, wangjianli wrote: > Delete the redundant word 'the'. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: [PATCH] drm/amdgpu: don't call drm_fb_helper_lastclose in lastclose()

2022-10-24 Thread Thomas Zimmermann
Hi Am 24.10.22 um 08:20 schrieb Quan, Evan: [AMD Official Use Only - General] Reviewed-by: Evan Quan -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Thursday, October 20, 2022 10:36 PM To: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org Cc: Deucher, A

Re: [RFC PATCH 2/3] drm: define new accel major and register it

2022-10-24 Thread Dave Airlie
On Mon, 24 Oct 2022 at 17:23, Oded Gabbay wrote: > > On Sun, Oct 23, 2022 at 3:40 PM Greg Kroah-Hartman > wrote: > > > > On Sun, Oct 23, 2022 at 12:46:21AM +0300, Oded Gabbay wrote: > > > The accelerator devices will be exposed to the user space with a new, > > > dedicated major number - 261. > >

Re: [PATCH v2 1/3] drm/bridge: it6505: Initialize AUX channel in it6505_i2c_probe

2022-10-24 Thread Robert Foss
On Thu, 13 Oct 2022 at 13:04, Pin-yen Lin wrote: > > During device boot, the HPD interrupt could be triggered before the DRM > subsystem registers it6505 as a DRM bridge. In such cases, the driver > tries to access AUX channel and causes NULL pointer dereference. > Initializing the AUX channel ear

Re: [PATCH v2 2/3] drm/bridge: it6505: Setup links in it6505_irq_hpd

2022-10-24 Thread Robert Foss
On Thu, 13 Oct 2022 at 13:04, Pin-yen Lin wrote: > > Move the DPCD read and link setup steps to HPD IRQ handler to remove > an unnecessary dependency between .detect callback and the HPD IRQ > handler before registering it6505 as a DRM bridge. This is safe because > there is always a .detect call

Re: [PATCH v2 3/3] drm/bridge: it6505: Improve synchronization between extcon subsystem

2022-10-24 Thread Robert Foss
On Thu, 13 Oct 2022 at 13:04, Pin-yen Lin wrote: > > Originally, the it6505 relies on a short sleep in the IRQ handler and a > long sleep to make sure it6505->lane_swap and it6505->lane_count is > configured in it6505_extcon_work and it6505_detect, respectively. > > Use completion and additional D

Re: [PATCH v2 0/3] Clean up it6505 driver and improve synchronization

2022-10-24 Thread Robert Foss
On Thu, 13 Oct 2022 at 13:04, Pin-yen Lin wrote: > > The main purpose of this series is to improve the synchronizations of > it6505 driver. The first two patches are required for the third one, but > they alone can be clean ups to the driver. > > Changes in v2: > - Remove redundant spaces in it650

Re: [PATCH v7 00/10] drm: bridge: Add Samsung MIPI DSIM bridge

2022-10-24 Thread Alexander Stein
Hi Jagan, Am Mittwoch, 5. Oktober 2022, 17:12:59 CEST schrieb Jagan Teki: > This series supports common bridge support for Samsung MIPI DSIM > which is used in Exynos and i.MX8MM SoC's. > > The final bridge supports both the Exynos and i.MX8MM DSI devices. > > Changes for v7: > * fix the drm bri

Re: [PATCH v7 14/21] media: tegra-vde: Prepare to dynamic dma-buf locking specification

2022-10-24 Thread Hans Verkuil
On 10/17/22 19:22, Dmitry Osipenko wrote: > Prepare Tegra video decoder driver to the common dynamic dma-buf > locking convention by starting to use the unlocked versions of dma-buf > API functions. > > Acked-by: Christian König Acked-by: Hans Verkuil Thanks! Hans > Signed-off-by:

Re: [PATCH v7 13/21] media: videobuf2: Prepare to dynamic dma-buf locking specification

2022-10-24 Thread Hans Verkuil
On 10/17/22 19:22, Dmitry Osipenko wrote: > Prepare V4L2 memory allocators to the common dynamic dma-buf locking > convention by starting to use the unlocked versions of dma-buf API > functions. > > Acked-by: Tomasz Figa Acked-by: Hans Verkuil Thanks! Hans > Acked-by: Christian Kö

[PATCH 1/2] drm/vc4: hdmi: Take our lock to reset the link

2022-10-24 Thread maxime
We access some fields protected by our internal mutex in vc4_hdmi_reset_link() (saved_adjusted_mode, output_bpc, output_format) and are calling functions that need to have that lock taken (vc4_hdmi_supports_scrambling()). However, the current code doesn't lock that mutex. Let's make sure it does.

[PATCH 2/2] drm/vc4: hdmi: Fix outdated function name in comment

2022-10-24 Thread maxime
A comment introduced by commit 6bed2ea3cb38 ("drm/vc4: hdmi: Reset link on hotplug") mentions a drm_atomic_helper_connector_hdmi_reset_link() function that was part of the earlier versions but got moved internally and is now named vc4_hdmi_reset_link(). Let's fix the function name. Fixes: 6bed2ea3

Re: [PATCH] drm/amd/display: don't print messages that contain %f in dml

2022-10-24 Thread Christian König
Am 21.10.22 um 18:34 schrieb Hamza Mahfooz: Unfortunately, printk() doesn't currently support the printing of %f entries. So, print statements that contain "%f" should be removed. However, since DC is used on other OSes that can still benefit from the additional debugging information, we should i

Re: [Regression] CPU stalls and eventually causes a complete system freeze with 6.0.3 due to "video/aperture: Disable and unregister sysfb devices via aperture helpers"

2022-10-24 Thread Thomas Zimmermann
Hi Am 23.10.22 um 10:04 schrieb Thorsten Leemhuis: Hi, this is your Linux kernel regression tracker speaking. I noticed a regression report in bugzilla.kernel.org. As many (most?) kernel developer don't keep an eye on it, I decided to forward it by mail. Quoting from https://bugzilla.kernel.org

Re: [Regression] CPU stalls and eventually causes a complete system freeze with 6.0.3 due to "video/aperture: Disable and unregister sysfb devices via aperture helpers"

2022-10-24 Thread Thorsten Leemhuis
Hi! Thx for the reply. On 24.10.22 12:26, Thomas Zimmermann wrote: > Am 23.10.22 um 10:04 schrieb Thorsten Leemhuis: >> >> I noticed a regression report in bugzilla.kernel.org. As many (most?) >> kernel developer don't keep an eye on it, I decided to forward it by >> mail. Quoting from https://bug

Re: [RFC PATCH] drm/scheduler: Set the FIFO schedulig policy as the default

2022-10-24 Thread Christian König
Am 22.10.22 um 03:09 schrieb Luben Tuikov: The currently default Round-Robin GPU scheduling can result in starvation of entities which have a large number of jobs, over entities which have a very small number of jobs (single digit). This can be illustrated in the following diagram, where jobs ar

Re: [PATCH 05/13] drm/amdgpu: drop amdgpu_sync from amdgpu_vmid_grab

2022-10-24 Thread Christian König
Am 23.10.22 um 03:25 schrieb Luben Tuikov: On 2022-10-14 04:46, Christian König wrote: [SNIP] @@ -254,12 +254,10 @@ static struct dma_fence *amdgpu_job_dependency(struct drm_sched_job *sched_job, DRM_ERROR("Error adding fence (%d)\n", r); } - while (fence == N

Re: [PATCH v1] drm: Switch drm_client_buffer_delete() to unlocked drm_gem_vunmap

2022-10-24 Thread Christian König
Am 20.10.22 um 23:33 schrieb Dmitry Osipenko: The drm_client_buffer_delete() wasn't switched to unlocked GEM vunmapping by accident when rest of drm_client code transitioned to the unlocked variants of the vmapping functions. Make drm_client_buffer_delete() use the unlocked variant. This fixes

[PATCH v2 00/21] drm/fb-helper: Untangle fbdev emulation and helpers

2022-10-24 Thread Thomas Zimmermann
Separate generic fbdev emulation from the helper code that is shared among the various fbdev implementations within DRM. Affects many drivers. It has become apparent that our fully generic fbdev emulation will never produce optimal results for all drivers. In its current form, it is also hard to m

[PATCH v2 01/21] drm/komeda: Don't set struct drm_driver.lastclose

2022-10-24 Thread Thomas Zimmermann
Don't set struct drm_driver.lastclose. It's used to restore the fbdev console. But as komeda uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the call to drm_client_dev_restore() in drm_lastclose(). Signed-off-by: Thomas Zimmermann --- drivers/gp

[PATCH v2 08/21] drm/rockchip: Don't set struct drm_driver.output_poll_changed

2022-10-24 Thread Thomas Zimmermann
Don't set struct drm_driver.output_poll_changed. It's used to restore the fbdev console. But as rockchip uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the functions drm_kms_helper_hotplug_event() and drm_kms_helper_connector_hotplug_event() in dr

[PATCH v2 05/21] drm/imx/dcss: Don't set struct drm_driver.output_poll_changed

2022-10-24 Thread Thomas Zimmermann
Don't set struct drm_driver.output_poll_changed. It's used to restore the fbdev console. But as DCSS uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the functions drm_kms_helper_hotplug_event() and drm_kms_helper_connector_hotplug_event() in drm_pr

[PATCH v2 03/21] drm/vboxvideo: Don't set struct drm_driver.lastclose

2022-10-24 Thread Thomas Zimmermann
Don't set struct drm_driver.lastclose. It's used to restore the fbdev console. But as vboxvideo uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the call to drm_client_dev_restore() in drm_lastclose(). Signed-off-by: Thomas Zimmermann --- drivers

[PATCH v2 11/21] drm/fb-helper: Cleanup include statements in header file

2022-10-24 Thread Thomas Zimmermann
Only include what we have to. Signed-off-by: Thomas Zimmermann --- include/drm/drm_fb_helper.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h index fddd0d1af6891..e923089522896 100644 --- a/include/drm/drm_fb_he

[PATCH v2 04/21] drm/amdgpu: Don't set struct drm_driver.output_poll_changed

2022-10-24 Thread Thomas Zimmermann
Don't set struct drm_driver.output_poll_changed. It's used to restore the fbdev console. But as amdgpu uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the functions drm_kms_helper_hotplug_event() and drm_kms_helper_connector_hotplug_event() in drm_

[PATCH v2 18/21] drm/fb_helper: Minimize damage-helper overhead

2022-10-24 Thread Thomas Zimmermann
Pull the test for fb_dirty into the caller to avoid extra work if no callback has been set. In this case no damage handling is required and no damage area needs to be computed. Print a warning if the damage worker runs without getting an fb_dirty callback. Signed-off-by: Thomas Zimmermann --- dr

[PATCH v2 17/21] drm/fb-helper: Perform all fbdev I/O with the same implementation

2022-10-24 Thread Thomas Zimmermann
Implement the fbdev's read/write helpers with the same functions. Use the generic fbdev's code as template. Convert all drivers. DRM's fb helpers must implement regular I/O functionality in struct fb_ops and possibly perform a damage update. Handle all this in the same functions and convert driver

[PATCH v2 02/21] drm/mcde: Don't set struct drm_driver.lastclose

2022-10-24 Thread Thomas Zimmermann
Don't set struct drm_driver.lastclose. It's used to restore the fbdev console. But as mcde uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the call to drm_client_dev_restore() in drm_lastclose(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/

[PATCH v2 16/21] drm/fb-helper: Call fb_sync in I/O functions

2022-10-24 Thread Thomas Zimmermann
Call struct fb_ops.fb_sync in drm_fbdev_{read,write}() to mimic the behavior of fbdev. Fbdev implementations of fb_read and fb_write in struct fb_ops invoke fb_sync to synchronize with outstanding operations before I/O. Doing the same in DRM implementations will allow us to use them throughout DRM

[PATCH v2 15/21] drm/fb-helper: Disconnect damage worker from update logic

2022-10-24 Thread Thomas Zimmermann
The fbdev helpers implement a damage worker that forwards fbdev updates to the DRM driver. The worker's update logic depends on the generic fbdev emulation. Separate the two via function pointer. The generic fbdev emulation sets struct drm_fb_helper_funcs.fb_dirty, a new callback that hides the up

[PATCH v2 13/21] drm/fb-helper: Rename drm_fb_helper_alloc_fbi() to use _info postfix

2022-10-24 Thread Thomas Zimmermann
Rename drm_fb_helper_alloc_fbi() to drm_fb_helper_alloc_info() as part of unifying the naming within fbdev helpers. Adapt drivers. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/armada/armada_fbdev.c | 2 +- drivers/gpu/drm/drm_fb_helper.c| 8 ---

[PATCH v2 10/21] drm/tve200: Include

2022-10-24 Thread Thomas Zimmermann
Include for of_match_ptr(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tve200/tve200_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/tve200/tve200_drv.c b/drivers/gpu/drm/tve200/tve200_drv.c index 04db72e3fa9c2..611785e097576 100644 --- a/drivers/gpu/drm/tve

[PATCH v2 06/21] drm/ingenic: Don't set struct drm_driver.output_poll_changed

2022-10-24 Thread Thomas Zimmermann
Don't set struct drm_driver.output_poll_changed. It's used to restore the fbdev console. But as ingenic uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the functions drm_kms_helper_hotplug_event() and drm_kms_helper_connector_hotplug_event() in drm

[PATCH v2 12/21] drm/fb_helper: Rename field fbdev to info in struct drm_fb_helper

2022-10-24 Thread Thomas Zimmermann
Rename struct drm_fb_helper.fbdev to info. The current name is misleading as it overlaps with generic fbdev naming conventions. Adapt to the usual naming in fbdev drivers by calling the field 'info'. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fb_helper.c

[PATCH v2 21/21] drm/fb-helper: Remove unnecessary include statements

2022-10-24 Thread Thomas Zimmermann
Remove include statements for where it is not required (i.e., most of them). In a few places include other header files that are required by the source code. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_display.c

[PATCH v2 09/21] drm/panel-ili9341: Include

2022-10-24 Thread Thomas Zimmermann
Include for devm_of_find_backlight(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c index 39dc40cf681f0..b59472c29

[PATCH v2 07/21] drm/logicvc: Don't set struct drm_driver.output_poll_changed

2022-10-24 Thread Thomas Zimmermann
Don't set struct drm_driver.output_poll_changed. It's used to restore the fbdev console. But as logicvc uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the functions drm_kms_helper_hotplug_event() and drm_kms_helper_connector_hotplug_event() in drm

[PATCH v2 14/21] drm/fb-helper: Rename drm_fb_helper_unregister_fbi() to use _info postfix

2022-10-24 Thread Thomas Zimmermann
Rename drm_fb_helper_unregister_fbi() to drm_fb_helper_unregister_info() as part of unifying the naming within fbdev helpers. Adapt drivers. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/armada/armada_fbdev.c | 2 +- drivers/gpu/drm/drm_fb_helper.c|

[PATCH v2 19/21] drm/fb-helper: Always initialize generic fbdev emulation

2022-10-24 Thread Thomas Zimmermann
Initialize the generic fbdev emulation even if it has been disabled on the kernel command line. The hotplug and mode initialization will fail accordingly. The kernel parameter can still be changed at runtime and the emulation will initialize after hotplugging the connector. Signed-off-by: Thomas

[PATCH v2 20/21] drm/fb-helper: Move generic fbdev emulation into separate source file

2022-10-24 Thread Thomas Zimmermann
Move the generic fbdev implementation into its own source and header file. Adapt drivers. No functonal changes, but some of the internal helpers have been renamed to fit into the drm_fbdev_ naming scheme. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/Makefile | 2 +-

Re: [Regression] CPU stalls and eventually causes a complete system freeze with 6.0.3 due to "video/aperture: Disable and unregister sysfb devices via aperture helpers"

2022-10-24 Thread Greg KH
On Mon, Oct 24, 2022 at 12:41:43PM +0200, Thorsten Leemhuis wrote: > Hi! Thx for the reply. > > On 24.10.22 12:26, Thomas Zimmermann wrote: > > Am 23.10.22 um 10:04 schrieb Thorsten Leemhuis: > >> > >> I noticed a regression report in bugzilla.kernel.org. As many (most?) > >> kernel developer don'

Re: [PATCH v5 00/10] Driver of Intel(R) Gaussian & Neural Accelerator

2022-10-24 Thread Thomas Zimmermann
Hi Am 20.10.22 um 19:53 schrieb Maciej Kwapulinski: Dear kernel maintainers, This submission is a kernel driver to support Intel(R) Gaussian & Neural Accelerator (Intel(R) GNA). Intel(R) GNA is a PCI-based neural co-processor available on multiple Intel platforms. AI developers and users can of

Re: [Regression] CPU stalls and eventually causes a complete system freeze with 6.0.3 due to "video/aperture: Disable and unregister sysfb devices via aperture helpers"

2022-10-24 Thread Thomas Zimmermann
Hi Am 24.10.22 um 13:27 schrieb Greg KH: On Mon, Oct 24, 2022 at 12:41:43PM +0200, Thorsten Leemhuis wrote: Hi! Thx for the reply. On 24.10.22 12:26, Thomas Zimmermann wrote: Am 23.10.22 um 10:04 schrieb Thorsten Leemhuis: I noticed a regression report in bugzilla.kernel.org. As many (most?

Re: [PATCH v2 00/10] drm/msm: probe deferral fixes

2022-10-24 Thread Johan Hovold
On Fri, Oct 21, 2022 at 09:05:52AM -0700, Abhinav Kumar wrote: > Hi Johan > > On 10/20/2022 11:27 PM, Johan Hovold wrote: > > On Tue, Sep 20, 2022 at 11:06:30AM +0200, Johan Hovold wrote: > >> On Tue, Sep 13, 2022 at 10:53:10AM +0200, Johan Hovold wrote: > >>> The MSM DRM driver is currently broke

Re: [PATCH 00/22] Fallback to native backlight

2022-10-24 Thread Jani Nikula
On Mon, 24 Oct 2022, Akihiko Odaki wrote: > Commit 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native() > helper") and following commits made native backlight unavailable if > CONFIG_ACPI_VIDEO is set and the backlight feature of ACPI video is > unavailable, which broke the backlight

Re: [PATCH 00/22] Fallback to native backlight

2022-10-24 Thread Hans de Goede
Hi Akihiko, On 10/24/22 13:34, Akihiko Odaki wrote: > Commit 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native() > helper") and following commits made native backlight unavailable if > CONFIG_ACPI_VIDEO is set and the backlight feature of ACPI video is > unavailable, which broke the

Re: [RFC PATCH 0/3] new subsystem for compute accelerator devices

2022-10-24 Thread Thomas Zimmermann
Hi Am 22.10.22 um 23:46 schrieb Oded Gabbay: In the last couple of months we had a discussion [1] about creating a new subsystem for compute accelerator devices in the kernel. After an analysis that was done by DRM maintainers and myself, and following a BOF session at the Linux Plumbers confer

Re: [PATCH 00/22] Fallback to native backlight

2022-10-24 Thread Hans de Goede
Hi, On 10/24/22 13:56, Akihiko Odaki wrote: > On 2022/10/24 20:48, Jani Nikula wrote: >> On Mon, 24 Oct 2022, Akihiko Odaki wrote: >>> Commit 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native() >>> helper") and following commits made native backlight unavailable if >>> CONFIG_ACPI_V

[PATCH 5.4 094/255] drm: fix drm_mipi_dbi build errors

2022-10-24 Thread Greg Kroah-Hartman
From: Randy Dunlap [ Upstream commit eb7de496451bd969e203f02f66585131228ba4ae ] drm_mipi_dbi needs lots of DRM_KMS_HELPER support, so select that Kconfig symbol like it is done is most other uses, and the way that it was before MIPS_DBI was moved from tinydrm to its core location. Fixes these b

[PATCH 5.10 154/390] drm: fix drm_mipi_dbi build errors

2022-10-24 Thread Greg Kroah-Hartman
From: Randy Dunlap [ Upstream commit eb7de496451bd969e203f02f66585131228ba4ae ] drm_mipi_dbi needs lots of DRM_KMS_HELPER support, so select that Kconfig symbol like it is done is most other uses, and the way that it was before MIPS_DBI was moved from tinydrm to its core location. Fixes these b

Re: [PATCH -next resend] backlight: ktd253: Switch to use dev_err_probe() helper

2022-10-24 Thread Lee Jones
On Mon, 26 Sep 2022, Yang Yingliang wrote: > In the probe path, dev_err() can be replaced with dev_err_probe() > which will check if error code is -EPROBE_DEFER and prints the > error name. It also sets the defer probe reason which can be > checked later through debugfs. It's more simple in error

[PATCH v2 00/16] drm/edid: EDID override refactoring and fixes

2022-10-24 Thread Jani Nikula
v2 of drm/edid: EDID override refactoring and fixes Address review comments, add patch 15. BR, Jani. Jani Nikula (16): drm/i915/hdmi: do dual mode detect only if connected drm/i915/hdmi: stop using connector->override_edid drm/amd/display: stop using connector->override_edid drm/edid: d

[PATCH v2 01/16] drm/i915/hdmi: do dual mode detect only if connected

2022-10-24 Thread Jani Nikula
For normal connector detect, there's really no point in trying dual mode detect if the connector is disconnected. We can simplify the detect sequence by skipping it. Since intel_hdmi_dp_dual_mode_detect() is only called when EDID is present, we can drop the has_edid parameter. The functional effec

[PATCH v2 02/16] drm/i915/hdmi: stop using connector->override_edid

2022-10-24 Thread Jani Nikula
The connector->override_edid flag is strictly for EDID override debugfs management, and drivers have no business using it. The check for override_edid was added in commit 301906290553 ("drm/i915: Ignore TMDS clock limit for DP++ when EDID override is set") to facilitate mode list cross-checking ag

[PATCH v2 03/16] drm/amd/display: stop using connector->override_edid

2022-10-24 Thread Jani Nikula
The connector->override_edid flag is strictly for EDID override debugfs management, and drivers have no business using it. Cc: Alex Deucher Cc: Christian König Cc: Xinhui Pan Cc: amd-...@lists.freedesktop.org Signed-off-by: Jani Nikula Reviewed-by: Harry Wentland Acked-by: Alex Deucher ---

[PATCH v2 04/16] drm/edid: debug log EDID override set/reset

2022-10-24 Thread Jani Nikula
It's useful debugging information to know if and when an override EDID was set or reset. Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 4

[PATCH v2 07/16] drm/edid: split drm_edid block count helper

2022-10-24 Thread Jani Nikula
Split the drm_edid block count helper to a base version that reports the block count indicated by EDID contents, and another on top that limits the block count based on size allocated for the EDID. Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 15 +++

[PATCH v2 06/16] drm/edid: rename drm_add_override_edid_modes() to drm_edid_override_connector_update()

2022-10-24 Thread Jani Nikula
Follow the naming of both EDID override functions as well as drm_edid_connector_update(). This also matches better what the function does; a combination of EDID property update and add modes. Indeed it should later be converted to call drm_edid_connector_update(). Signed-off-by: Jani Nikula Revie

[PATCH v2 08/16] drm/edid: add function for checking drm_edid validity

2022-10-24 Thread Jani Nikula
We've lacked a function for immutable validity check on drm_edid. Add one. Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 30 ++ include/drm/drm_edid.h | 1 + 2 files changed, 31 insertions(+) diff --git a/drivers/gpu/drm

[PATCH v2 05/16] drm/edid: abstract debugfs override EDID show better

2022-10-24 Thread Jani Nikula
Add a function to dump the override EDID in debugfs. This hides the override EDID management better in drm_edid.c. Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_crtc_internal.h | 4 +++- drivers/gpu/drm/drm_debugfs.c | 8 +--- drivers/gpu/drm/drm_edid

[PATCH v2 09/16] drm/edid: detach debugfs EDID override from EDID property update

2022-10-24 Thread Jani Nikula
Having the EDID override debugfs directly update the EDID property is problematic. The update is partial only. The driver has no way of knowing it's been updated. Mode list is not updated. It's an inconsistent state. Detach debugfs EDID override from the property update completely. Only set and re

[PATCH v2 11/16] drm/edid/firmware: rename drm_load_edid_firmware() to drm_edid_load_firmware()

2022-10-24 Thread Jani Nikula
Follow the usual naming convention by file name. Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 10 +- drivers/gpu/drm/drm_edid_load.c | 2 +- include/drm/drm_edid.h | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff

[PATCH v2 10/16] drm/edid/firmware: drop redundant connector_name variable/parameter

2022-10-24 Thread Jani Nikula
Stop passing around something that's readily available in connector->name. Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid_load.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/drm_edid_load.c b/drivers/gpu

[PATCH v2 12/16] drm/edid: use struct drm_edid for override/firmware EDID

2022-10-24 Thread Jani Nikula
There's a lot going on here, but the main thing is switching the firmware EDID loader to use struct drm_edid. Unfortunately, it's difficult to reasonably split to smaller pieces. Convert the EDID loader to struct drm_edid. There's a functional change in validation; it no longer tries to fix errors

[PATCH v2 13/16] drm/edid: move edid load declarations to internal header

2022-10-24 Thread Jani Nikula
The EDID loader is internal to drm, not for drivers. Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_crtc_internal.h | 11 +++ drivers/gpu/drm/drm_edid_load.c | 5 +++-- include/drm/drm_edid.h | 7 --- 3 files changed, 14 insertions(+

[PATCH v2 15/16] drm/edid: add [CONNECTOR:%d:%s] to debug logging

2022-10-24 Thread Jani Nikula
Reference the connector using [CONNECTOR:%d:%s] in existing device based debug logging. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 38 +- 1 file changed, 25 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/

[PATCH v2 16/16] drm/edid: convert to device specific logging

2022-10-24 Thread Jani Nikula
Convert to drm_kms_dbg/drm_err where possible, and reference the connector using [CONNECTOR:%d:%s]. Pass connectors around a bit more to enable this. Where this is not possible, unify the rest of the debugs to DRM_DEBUG_KMS. Rewrite tile debug logging to one line while at it. v2: - Use [CONNECTOR

[PATCH v2 14/16] drm/edid/firmware: convert to drm device specific logging

2022-10-24 Thread Jani Nikula
Conform to device specific logging. v2: Include [CONNECTOR:%d:%s] (Ville) Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid_load.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_edid_load.c b/drivers/gpu/drm/drm_edid_load.c index 882ca

Must-Pass Test Suite for KMS drivers

2022-10-24 Thread maxime
Hi, I've discussing the idea for the past year to add an IGT test suite that all well-behaved KMS drivers must pass. The main idea behind it comes from v4l2-compliance and cec-compliance, that are being used to validate that the drivers are sane. We should probably start building up the test lis

Re: [RFC PATCH 0/3] new subsystem for compute accelerator devices

2022-10-24 Thread Oded Gabbay
On Mon, Oct 24, 2022 at 2:56 PM Thomas Zimmermann wrote: > > Hi > > Am 22.10.22 um 23:46 schrieb Oded Gabbay: > > In the last couple of months we had a discussion [1] about creating a new > > subsystem for compute accelerator devices in the kernel. > > > > After an analysis that was done by DRM ma

Re: [PATCH 16/21] fbdev: remove s3c2410 framebuffer

2022-10-24 Thread Krzysztof Kozlowski
On 21/10/2022 16:27, Arnd Bergmann wrote: > From: Arnd Bergmann > > The s3c24xx platform was removed, so the framebuffer driver is no longer > needed. > > Signed-off-by: Arnd Bergmann > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 2/2] drm/tiny: add support for tft displays based on ilitek, ili9488

2022-10-24 Thread Thomas Zimmermann
Hi, thanks for your driver submission. Am 18.10.22 um 18:45 schrieb Tommaso Merciai: This adds support for ilitek,ili9488 based displays with shift register in front of controller. Waveshare,pico-restouch-lcd-3.5 are such displays Signed-off-by: Tommaso Merciai --- drivers/gpu/drm/tiny/Kcon

Re: [RFC PATCH 0/3] new subsystem for compute accelerator devices

2022-10-24 Thread Greg Kroah-Hartman
On Mon, Oct 24, 2022 at 01:55:56PM +0200, Thomas Zimmermann wrote: > Hi > > Am 22.10.22 um 23:46 schrieb Oded Gabbay: > > In the last couple of months we had a discussion [1] about creating a new > > subsystem for compute accelerator devices in the kernel. > > > > After an analysis that was done

Re: [PATCH 00/21] ARM: s3c: clean out obsolete platforms

2022-10-24 Thread Rob Herring
On Fri, Oct 21, 2022 at 10:22:28PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > The s3c24xx platform was marked as deprecated a while ago, > and for the s3c64xx platform, we marked all except one legacy > board file as unused. > > This series removes all of those, leaving only s3c64xx s

Re: [PATCH 00/22] Fallback to native backlight

2022-10-24 Thread Pali Rohár
On Monday 24 October 2022 21:58:57 Akihiko Odaki wrote: > Regarding the second limitation, I don't even understand the difference > between vendor and native. My guess is that a vendor backlight device uses > vendor-specific ACPI interface, and a native one directly uses hardware > registers. If my

Re: [PATCH v3 1/8] memory: tegra: Add API for retrieving carveout bounds

2022-10-24 Thread Thierry Reding
On Tue, Sep 20, 2022 at 11:11:56AM +0300, Mikko Perttunen wrote: > From: Mikko Perttunen > > On Tegra234 NVDEC firmware is loaded from a secure carveout, where it > has been loaded by a bootloader. When booting NVDEC, we need to tell it > the address of this firmware, which we can determine by ch

Re: [PATCH v3 0/8] Support for NVDEC on Tegra234

2022-10-24 Thread Thierry Reding
On Tue, Sep 20, 2022 at 11:11:55AM +0300, Mikko Perttunen wrote: > From: Mikko Perttunen > > v3: > * Updated patch 3 based on comments > > v2: > * Updated patches 1,3 based on comments > * Added Acked-by to patch 2 > > Original message: > > Hi all, > > this series adds support for the HW vide

Re: [PATCH 00/22] Fallback to native backlight

2022-10-24 Thread Hans de Goede
Hi, On 10/24/22 14:58, Akihiko Odaki wrote: > On 2022/10/24 20:53, Hans de Goede wrote: >> Hi Akihiko, >> >> On 10/24/22 13:34, Akihiko Odaki wrote: >>> Commit 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native() >>> helper") and following commits made native backlight unavailable if

Re: [PATCH v5 00/10] Driver of Intel(R) Gaussian & Neural Accelerator

2022-10-24 Thread Maciej Kwapulinski
On 10/21/2022 6:17 AM, Greg Kroah-Hartman wrote: > On Thu, Oct 20, 2022 at 07:53:24PM +0200, Maciej Kwapulinski wrote: >> Dear kernel maintainers, > > > This really is v6, not v5, right? Why send 2 v5 out? > > greg k-h what do you mean?

Re: [PATCH 00/22] Fallback to native backlight

2022-10-24 Thread Hans de Goede
Hi, On 10/24/22 15:14, Pali Rohár wrote: > On Monday 24 October 2022 21:58:57 Akihiko Odaki wrote: >> Regarding the second limitation, I don't even understand the difference >> between vendor and native. My guess is that a vendor backlight device uses >> vendor-specific ACPI interface, and a nativ

Re: [PATCH v2 15/16] drm/edid: add [CONNECTOR:%d:%s] to debug logging

2022-10-24 Thread Simon Ser
Reviewed-by: Simon Ser

Re: [PATCH 00/21] ARM: s3c: clean out obsolete platforms

2022-10-24 Thread Arnd Bergmann
On Mon, Oct 24, 2022, at 15:00, Rob Herring wrote: > On Fri, Oct 21, 2022 at 10:22:28PM +0200, Arnd Bergmann wrote: >> From: Arnd Bergmann >> >> The s3c24xx platform was marked as deprecated a while ago, >> and for the s3c64xx platform, we marked all except one legacy >> board file as unused. >>

[PATCH v1] ACPI: video: Fix missing native backlight on Chromebooks

2022-10-24 Thread Dmitry Osipenko
Chromebooks don't have backlight in ACPI table, they suppose to use native backlight in this case. Check presence of the CrOS embedded controller ACPI device and prefer the native backlight if EC found. Suggested-by: Hans de Goede Fixes: b1d36e73cc1c ("drm/i915: Don't register backlight when anot

Re: [PATCH v5 01/10] gna: add PCI driver module

2022-10-24 Thread Maciej Kwapulinski
On 10/21/2022 6:20 AM, Greg Kroah-Hartman wrote: > On Thu, Oct 20, 2022 at 07:53:25PM +0200, Maciej Kwapulinski wrote: >> Add a new PCI driver for Intel(R) Gaussian & Neural Accelerator > Please drop all of the (R) stuff in here, and in the Kconfig file and in > the .c files. If your lawyers ins

Re: [PATCH v1] ACPI: video: Fix missing native backlight on Chromebooks

2022-10-24 Thread Hans de Goede
Hi, On 10/24/22 15:32, Dmitry Osipenko wrote: > Chromebooks don't have backlight in ACPI table, they suppose to use > native backlight in this case. Check presence of the CrOS embedded > controller ACPI device and prefer the native backlight if EC found. Thank you for this patch! > Suggested-by:

Re: [RFC PATCH 0/3] new subsystem for compute accelerator devices

2022-10-24 Thread Alex Deucher
On Sat, Oct 22, 2022 at 5:46 PM Oded Gabbay wrote: > > In the last couple of months we had a discussion [1] about creating a new > subsystem for compute accelerator devices in the kernel. > > After an analysis that was done by DRM maintainers and myself, and following > a BOF session at the Linux

Re: [PATCH v1] ACPI: video: Fix missing native backlight on Chromebooks

2022-10-24 Thread Dmitry Osipenko
On 10/24/22 16:46, Hans de Goede wrote: > Hi, > > On 10/24/22 15:32, Dmitry Osipenko wrote: >> Chromebooks don't have backlight in ACPI table, they suppose to use >> native backlight in this case. Check presence of the CrOS embedded >> controller ACPI device and prefer the native backlight if EC f

[PATCH v2] ACPI: video: Fix missing native backlight on Chromebooks

2022-10-24 Thread Dmitry Osipenko
Chromebooks don't have backlight in ACPI table, they suppose to use native backlight in this case. Check presence of the CrOS embedded controller ACPI device and prefer the native backlight if EC found. Suggested-by: Hans de Goede Fixes: 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_na

Re: [PATCH v2] ACPI: video: Fix missing native backlight on Chromebooks

2022-10-24 Thread Hans de Goede
Hi, On 10/24/22 16:12, Dmitry Osipenko wrote: > Chromebooks don't have backlight in ACPI table, they suppose to use > native backlight in this case. Check presence of the CrOS embedded > controller ACPI device and prefer the native backlight if EC found. > > Suggested-by: Hans de Goede > Fixes:

[CI] mm/huge_memory: do not clobber swp_entry_t during THP split

2022-10-24 Thread Tvrtko Ursulin
From: Mel Gorman On Mon, Oct 24, 2022 at 02:04:50PM +0100, Tvrtko Ursulin wrote: > > Hi Mel, mm experts, > > With 6.1-rc2 we started hitting the WARN_ON added in 71e2d666ef85 > ("mm/huge_memory: do not clobber swp_entry_t during THP split") in i915 > automated CI: > Thanks for the report. As s

  1   2   3   >