Re: [RFC PATCH v5 4/6] drm/tidss: Add support to configure OLDI mode for am625-dss.

2022-10-18 Thread Aradhya Bhatia
Hi Tomi Thank you for the comprehensive feedback across all the patches. I am working on them. I do have some concerns which I have talked about, below. On 12-Oct-22 17:53, Tomi Valkeinen wrote: On 28/09/2022 20:52, Aradhya Bhatia wrote: The newer version of DSS (AM625-DSS) has 2 OLDI TXes at

[PATCH v4 02/17] drm/i915/vm_bind: Add __i915_sw_fence_await_reservation()

2022-10-18 Thread Niranjana Vishwanathapura
Add function __i915_sw_fence_await_reservation() for asynchronous wait on a dma-resv object with specified dma_resv_usage. This is required for async vma unbind with vm_bind. Reviewed-by: Matthew Auld Signed-off-by: Niranjana Vishwanathapura --- drivers/gpu/drm/i915/i915_sw_fence.c | 28 +++

[PATCH v4 00/17] drm/i915/vm_bind: Add VM_BIND functionality

2022-10-18 Thread Niranjana Vishwanathapura
DRM_I915_GEM_VM_BIND/UNBIND ioctls allows UMD to bind/unbind GEM buffer objects (BOs) or sections of a BOs at specified GPU virtual addresses on a specified address space (VM). Multiple mappings can map to the same physical pages of an object (aliasing). These mappings (also referred to as persiste

[PATCH v4 04/17] drm/i915/vm_bind: Add support to create persistent vma

2022-10-18 Thread Niranjana Vishwanathapura
Add i915_vma_instance_persistent() to create persistent vmas. Persistent vmas will use i915_gtt_view to support partial binding. vma_lookup is tied to segment of the object instead of section of VA space. Hence, it do not support aliasing. ie., multiple mappings (at different VA) point to the same

[PATCH v4 05/17] drm/i915/vm_bind: Implement bind and unbind of object

2022-10-18 Thread Niranjana Vishwanathapura
Add uapi and implement support for bind and unbind of an object at the specified GPU virtual addresses. The vm_bind mode is not supported in legacy execbuf2 ioctl. It will be supported only in the newer execbuf3 ioctl. v2: On older platforms ctx->vm is not set, check for it. In vm_bind call,

[PATCH v4 01/17] drm/i915/vm_bind: Expose vm lookup function

2022-10-18 Thread Niranjana Vishwanathapura
Make i915_gem_vm_lookup() function non-static as it will be used by the vm_bind feature. Reviewed-by: Matthew Auld Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 11 ++- drivers/gpu/drm/i915/gem/i915_gem_context.h |

[PATCH v4 11/17] drm/i915/vm_bind: Use common execbuf functions in execbuf path

2022-10-18 Thread Niranjana Vishwanathapura
Update the execbuf path to use common execbuf functions to reduce code duplication with the newer execbuf3 path. Reviewed-by: Matthew Auld Signed-off-by: Niranjana Vishwanathapura --- .../gpu/drm/i915/gem/i915_gem_execbuffer.c| 507 ++ 1 file changed, 38 insertions(+), 469 d

[PATCH v4 07/17] drm/i915/vm_bind: Add support to handle object evictions

2022-10-18 Thread Niranjana Vishwanathapura
Support eviction by maintaining a list of evicted persistent vmas for rebinding during next submission. Ensure the list do not include persistent vmas that are being purged. v2: Remove unused I915_VMA_PURGED definition. v3: Properly handle __i915_vma_unbind_async() case. Reviewed-by: Matthew Auld

[PATCH v4 16/17] drm/i915/vm_bind: userptr dma-resv changes

2022-10-18 Thread Niranjana Vishwanathapura
For persistent (vm_bind) vmas of userptr BOs, handle the user page pinning by using the i915_gem_object_userptr_submit_init() /done() functions v2: Do not double add vma to vm->userptr_invalidated_list Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti --- .../gpu/drm/i915/gem/

[PATCH v4 03/17] drm/i915/vm_bind: Expose i915_gem_object_max_page_size()

2022-10-18 Thread Niranjana Vishwanathapura
Expose i915_gem_object_max_page_size() function non-static which will be used by the vm_bind feature. Reviewed-by: Matthew Auld Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gem/i915_gem_create.c | 18 +- drivers/gpu/drm/i915/gem/i9

[PATCH v4 09/17] drm/i915/vm_bind: Add out fence support

2022-10-18 Thread Niranjana Vishwanathapura
Add support for handling out fence for vm_bind call. v2: Reset vma->vm_bind_fence.syncobj to NULL at the end of vm_bind call. v3: Remove vm_unbind out fence uapi which is not supported yet. Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gem/i915

[PATCH v4 12/17] drm/i915/vm_bind: Implement I915_GEM_EXECBUFFER3 ioctl

2022-10-18 Thread Niranjana Vishwanathapura
Implement new execbuf3 ioctl (I915_GEM_EXECBUFFER3) which only works in vm_bind mode. The vm_bind mode only works with this new execbuf3 ioctl. The new execbuf3 ioctl will not have any list of objects to validate bind as all required objects binding would have been requested by the userspace befor

[PATCH v4 15/17] drm/i915/vm_bind: Handle persistent vmas in execbuf3

2022-10-18 Thread Niranjana Vishwanathapura
Handle persistent (VM_BIND) mappings during the request submission in the execbuf3 path. v2: Ensure requests wait for bindings to complete. v3: Remove short term pinning with PIN_VALIDATE flag. Individualize fences before adding to dma_resv obj. Signed-off-by: Niranjana Vishwanathapura Signe

[PATCH v4 13/17] drm/i915/vm_bind: Update i915_vma_verify_bind_complete()

2022-10-18 Thread Niranjana Vishwanathapura
Ensure i915_vma_verify_bind_complete() handles case where bind is not initiated. Also make it non static, add documentation and move it out of CONFIG_DRM_I915_DEBUG_GEM. Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/i915_vma.c | 16 +++-

[PATCH v4 14/17] drm/i915/vm_bind: Expose i915_request_await_bind()

2022-10-18 Thread Niranjana Vishwanathapura
Rename __i915_request_await_bind() as i915_request_await_bind() and make it non-static as it will be used in execbuf3 ioctl path. Reviewed-by: Andi Shyti Signed-off-by: Niranjana Vishwanathapura --- drivers/gpu/drm/i915/i915_vma.c | 8 +--- drivers/gpu/drm/i915/i915_vma.h | 6 ++ 2 file

[PATCH v4 06/17] drm/i915/vm_bind: Support for VM private BOs

2022-10-18 Thread Niranjana Vishwanathapura
Each VM creates a root_obj and shares it with all of its private objects to use it as dma_resv object. This has a performance advantage as it requires a single dma_resv object update for all private BOs vs list of dma_resv objects update for shared BOs, in the execbuf path. VM private BOs can be o

[PATCH v4 17/17] drm/i915/vm_bind: Add uapi for user to enable vm_bind_mode

2022-10-18 Thread Niranjana Vishwanathapura
Add getparam support for VM_BIND capability version. Add VM creation time flag to enable vm_bind_mode for the VM. v2: update kernel-doc v3: create vm->root_obj only upon I915_VM_CREATE_FLAGS_USE_VM_BIND v4: replace vm->vm_bind_mode check with i915_gem_vm_is_vm_bind_mode() Reviewed-by: Matthew Aul

[PATCH v4 08/17] drm/i915/vm_bind: Support persistent vma activeness tracking

2022-10-18 Thread Niranjana Vishwanathapura
Do not use i915_vma activeness tracking for persistent vmas. As persistent vmas are part of working set for each execbuf submission on that address space (VM), a persistent vma is active if the VM active. As vm->root_obj->base.resv will be updated for each submission on that VM, it correctly repre

[PATCH v4 10/17] drm/i915/vm_bind: Abstract out common execbuf functions

2022-10-18 Thread Niranjana Vishwanathapura
The new execbuf3 ioctl path and the legacy execbuf ioctl paths have many common functionalities. Abstract out the common execbuf functionalities into a separate file where possible, thus allowing code sharing. Reviewed-by: Andi Shyti Acked-by: Matthew Auld Signed-off-by: Niranjana Vishwanathapur

logging:convert dev_info to drm_info

2022-10-18 Thread jianengchencool
Hi,I want to convert logging dev_info/warn/err to drm_info/warn/err  in drivers/gpu/drm/pl111, so I want to ask if this work will be merged?Thanks!TODO list below:Convert logging to drm_* functions with drm_device paramater¶For drivers which could have multiple instances, it is n

Re: [PATCH] fbdev: da8xx-fb: Fix error handling in .remove()

2022-10-18 Thread Uwe Kleine-König
On Tue, Oct 18, 2022 at 08:08:49AM +0200, Helge Deller wrote: > On 10/17/22 21:52, Uwe Kleine-König wrote: > > Even in the presence of problems (here: regulator_disable() might fail), > > it's important to unregister all resources acquired during .probe() and > > disable the device (i.e. DMA activi

Re: [PATCH v3 1/7] firmware: raspberrypi: Introduce rpi_firmware_find_node()

2022-10-18 Thread Maxime Ripard
Hi Florian On Fri, Oct 14, 2022 at 12:43:38PM -0700, Florian Fainelli wrote: > On 10/13/22 02:13, Maxime Ripard wrote: > > A significant number of RaspberryPi drivers using the firmware don't > > have a phandle to it, so end up scanning the device tree to find a node > > with the firmware compatib

Re: [PATCH v4 11/30] drm/modes: Add a function to generate analog display modes

2022-10-18 Thread Maxime Ripard
Hi, On Sat, Oct 15, 2022 at 05:04:50PM +0200, Noralf Trønnes wrote: > Den 13.10.2022 10.36, skrev Maxime Ripard: > > On Sat, Oct 01, 2022 at 02:52:06PM +0200, Noralf Trønnes wrote: > >> Den 29.09.2022 18.31, skrev Maxime Ripard: > >>> Multiple drivers (meson, vc4, sun4i) define analog TV 525-lines

[PATCH v2] video: fbdev: sm501fb: convert sysfs snprintf to sysfs_emit

2022-10-18 Thread Xuezhi Zhang
From: Xuezhi Zhang Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: Xuezhi Zhang --- v2:change onvert to convert in subject. --- drivers/video/fbdev/sm5

Paletted pixel formats could be supported in Wayland

2022-10-18 Thread Pekka Paalanen
Hi all, once again I read some comments about how important paletted pixel formats still are to some users. Here are some musings about how they could be supported in Wayland, because I want to underline that Wayland in no way denies paletted pixel formats; not for apps and not for compositors. N

[PATCH] fbdev: gbefb: convert sysfs snprintf to sysfs_emit

2022-10-18 Thread Xuezhi Zhang
From: Xuezhi Zhang Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: Xuezhi Zhang --- drivers/video/fbdev/gbefb.c | 4 ++-- 1 file changed, 2 insertions(

Re: not ok 1 - single_pixel_source_buffer: The buggy address belongs to the physical page

2022-10-18 Thread Javier Martinez Canillas
[adding a few folks to Cc list that might help with this issue] Hello Naresh, Thanks a lot for your report. On 10/18/22 08:40, Naresh Kamboju wrote: > Following kunit tests started failing on Linux mainline. > - drm_format_helper_test — FAIL > - drm_test_fb_xrgb_to_xrgb2101010 — FAIL > -

Re: [PATCH v5 08/22] drm/modes: Move named modes parsing to a separate function

2022-10-18 Thread Maxime Ripard
On Sun, Oct 16, 2022 at 06:11:21PM +0200, Noralf Trønnes wrote: > Den 13.10.2022 15.18, skrev Maxime Ripard: > > The current construction of the named mode parsing doesn't allow to extend > > it easily. Let's move it to a separate function so we can add more > > parameters and modes. > > > > In or

Re: logging:convert dev_info to drm_info

2022-10-18 Thread Jani Nikula
On Tue, 18 Oct 2022, jianengchencool wrote: > I want to convert logging dev_info/warn/err to drm_info/warn/err in > drivers/gpu/drm/pl111, so I want to ask if this work will be merged? Where are the patches? BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center

[PATCH] drm/kmb: Remove some unused functions

2022-10-18 Thread Jiapeng Chong
Functions set_test_mode_src_osc_freq_target_low_bits() and set_test_mode_src_osc_freq_target_hi_bits() are defined in the kmb_dsi.c file, but not called elsewhere, so remove these unused functions. drivers/gpu/drm/kmb/kmb_dsi.c:822:2: warning: unused function 'set_test_mode_src_osc_freq_target_lo

[PATCH] drm/amdgpu/discovery: fix possible memory leak

2022-10-18 Thread Yang Yingliang
If kset_register() fails, the refcount of device is not 0, the name allocated in dev_set_name() is leaked. Fix this by calling kset_put(), so that it will be freed in callback function kobject_cleanup(). Fixes: a6c40b178092 ("drm/amdgpu: Show IP discovery in sysfs") Signed-off-by: Yang Yingliang

Re: [PATCH v5 06/22] drm/modes: Add a function to generate analog display modes

2022-10-18 Thread Maxime Ripard
Hi, On Sun, Oct 16, 2022 at 07:34:12PM +0200, Mateusz Kwiatkowski wrote: > Hi Maxime & everyone, > > Sorry for being inactive in the discussions about this patchset for the last > couple of weeks. > > > +const static struct analog_parameters tv_modes_parameters[] = { > > + TV_MODE_PARAMETER(DR

Re: not ok 1 - single_pixel_source_buffer: The buggy address belongs to the physical page

2022-10-18 Thread David Gow
On Tue, Oct 18, 2022 at 3:54 PM Javier Martinez Canillas wrote: > > [adding a few folks to Cc list that might help with this issue] > > Hello Naresh, > > Thanks a lot for your report. > > On 10/18/22 08:40, Naresh Kamboju wrote: > > Following kunit tests started failing on Linux mainline. > > - d

[PATCH] gma500: Remove the unused function gma_pipe_event()

2022-10-18 Thread Jiapeng Chong
The function gma_pipe_event() is defined in the psb_irq.c file, but not called elsewhere, so remove this unused function. drivers/gpu/drm/gma500/psb_irq.c:35:19: warning: unused function 'gma_pipe_event'. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2428 Reported-by: Abaci Robot Signed-

[PATCH] drm/mipi-dsi: fix possible memory leak in mipi_dsi_device_register_full()

2022-10-18 Thread Yang Yingliang
If mipi_dsi_device_add() fails, the refcount of device is not 0, the name allocated in dev_set_name() is leaked. Fix this by calling put_device(), so that it will be freed in callback function kobject_cleanup(). Fixes: 068a00233969 ("drm: Add MIPI DSI bus support") Signed-off-by: Yang Yingliang -

Re: [PATCH v5 19/22] drm/vc4: vec: Check for VEC output constraints

2022-10-18 Thread Maxime Ripard
Hi, On Sun, Oct 16, 2022 at 08:16:32PM +0200, Mateusz Kwiatkowski wrote: > W dniu 13.10.2022 o 15:19, Maxime Ripard pisze: > > From: Mateusz Kwiatkowski > > > > The VEC can accept pretty much any relatively reasonable mode, but still > > has a bunch of constraints to meet. > > > > Let's create an

Re: [PATCH] fbdev: gbefb: convert sysfs snprintf to sysfs_emit

2022-10-18 Thread Helge Deller
On 10/18/22 09:51, Xuezhi Zhang wrote: From: Xuezhi Zhang Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: Xuezhi Zhang applied. Thanks! Helge ---

Re: [PATCH] drm/vc4: vec: Add support for PAL-60

2022-10-18 Thread Maxime Ripard
Hi, On Sun, Oct 16, 2022 at 09:46:49PM +0200, Mateusz Kwiatkowski wrote: > @@ -308,14 +324,15 @@ static const struct vc4_vec_tv_mode vc4_vec_tv_modes[] > = { > }; > > static inline const struct vc4_vec_tv_mode * > -vc4_vec_tv_mode_lookup(unsigned int mode) > +vc4_vec_tv_mode_lookup(unsigned i

Re: [PATCH v2] drm/panel/panel-sitronix-st7701: Fix RTNI calculation

2022-10-18 Thread Linus Walleij
On Thu, Oct 13, 2022 at 12:12 AM Marek Vasut wrote: > The RTNI field is multiplied by 16 and incremented by 512 before being > used as the minimum number of pixel clock per horizontal line, hence > it is necessary to subtract those 512 bytes from htotal and then divide > the result by 16 before w

Re: i915 "GPU HANG", bisected to a2daa27c0c61 "swiotlb: simplify swiotlb_max_segment"

2022-10-18 Thread Jan Beulich
On 18.10.2022 10:24, Christoph Hellwig wrote: > @@ -127,19 +128,22 @@ static inline unsigned int i915_sg_dma_sizes(struct > scatterlist *sg) > return page_sizes; > } > > -static inline unsigned int i915_sg_segment_size(void) > +static inline unsigned int i915_sg_segment_size(struct device

Re: [PATCH v2] drm/panel/panel-sitronix-st7701: Fix RTNI calculation

2022-10-18 Thread Marek Vasut
On 10/18/22 10:53, Linus Walleij wrote: On Thu, Oct 13, 2022 at 12:12 AM Marek Vasut wrote: The RTNI field is multiplied by 16 and incremented by 512 before being used as the minimum number of pixel clock per horizontal line, hence it is necessary to subtract those 512 bytes from htotal and th

[PATCH v3] dma-buf: Proactively round up to kmalloc bucket size

2022-10-18 Thread Kees Cook
Instead of discovering the kmalloc bucket size _after_ allocation, round up proactively so the allocation is explicitly made for the full size, allowing the compiler to correctly reason about the resulting size of the buffer through the existing __alloc_size() hint. Cc: Sumit Semwal Cc: linux-me.

Re: [PATCH v2] drm/panel/panel-sitronix-st7701: Fix RTNI calculation

2022-10-18 Thread Linus Walleij
On Tue, Oct 18, 2022 at 11:03 AM Marek Vasut wrote: > On 10/18/22 10:53, Linus Walleij wrote: > > On Thu, Oct 13, 2022 at 12:12 AM Marek Vasut wrote: > > > >> The RTNI field is multiplied by 16 and incremented by 512 before being > >> used as the minimum number of pixel clock per horizontal line,

Re: [PATCH 1/2] Revert "drm: hide unregistered connectors from GETCONNECTOR IOCTL"

2022-10-18 Thread Ville Syrjälä
On Mon, Oct 17, 2022 at 03:31:57PM +, Simon Ser wrote: > This reverts commit 981f09295687f856d5345e19c7084aca481c1395. > > It turns out this breaks Mutter. A bit more detail would be a good to help future archaeologists. > > Signed-off-by: Simon Ser > Cc: Daniel Vetter > Cc: Lyude Paul >

Re: [PATCH 2/2] drm/connector: send hotplug uevent on connector cleanup

2022-10-18 Thread Ville Syrjälä
On Mon, Oct 17, 2022 at 03:32:01PM +, Simon Ser wrote: > A typical DP-MST unplug removes a KMS connector. However care must > be taken to properly synchronize with user-space. The expected > sequence of events is the following: > > 1. The kernel notices that the DP-MST port is gone. > 2. The k

Re: [PATCH 2/2] drm/connector: send hotplug uevent on connector cleanup

2022-10-18 Thread Simon Ser
On Tuesday, October 18th, 2022 at 11:24, Ville Syrjälä wrote: > On Mon, Oct 17, 2022 at 03:32:01PM +, Simon Ser wrote: > > > A typical DP-MST unplug removes a KMS connector. However care must > > be taken to properly synchronize with user-space. The expected > > sequence of events is the fo

Re: [PATCH 1/2] Revert "drm: hide unregistered connectors from GETCONNECTOR IOCTL"

2022-10-18 Thread Jonas Ådahl
On Tue, Oct 18, 2022 at 12:14:09PM +0300, Ville Syrjälä wrote: > On Mon, Oct 17, 2022 at 03:31:57PM +, Simon Ser wrote: > > This reverts commit 981f09295687f856d5345e19c7084aca481c1395. > > > > It turns out this breaks Mutter. > > A bit more detail would be a good to help future archaeologist

Re: [PATCH v5 12/22] drm/connector: Add a function to lookup a TV mode by its name

2022-10-18 Thread Maxime Ripard
On Mon, Oct 17, 2022 at 12:44:45PM +0200, Noralf Trønnes wrote: > Den 13.10.2022 15.18, skrev Maxime Ripard: > > As part of the command line parsing rework coming in the next patches, > > we'll need to lookup drm_connector_tv_mode values by their name, already > > defined in drm_tv_mode_enum_list.

Re: [PATCH 1/2] Revert "drm: hide unregistered connectors from GETCONNECTOR IOCTL"

2022-10-18 Thread Ville Syrjälä
On Tue, Oct 18, 2022 at 11:27:19AM +0200, Jonas Ådahl wrote: > On Tue, Oct 18, 2022 at 12:14:09PM +0300, Ville Syrjälä wrote: > > On Mon, Oct 17, 2022 at 03:31:57PM +, Simon Ser wrote: > > > This reverts commit 981f09295687f856d5345e19c7084aca481c1395. > > > > > > It turns out this breaks Mutt

Re: [PATCH v5 20/22] drm/vc4: vec: Convert to the new TV mode property

2022-10-18 Thread Maxime Ripard
On Mon, Oct 17, 2022 at 12:31:31PM +0200, Noralf Trønnes wrote: > Den 16.10.2022 20.52, skrev Mateusz Kwiatkowski: > >> static int vc4_vec_connector_get_modes(struct drm_connector *connector) > >> { > >> - struct drm_connector_state *state = connector->state; > >>struct drm_display_mode *mod

Re: [PATCH v2] drm/panel/panel-sitronix-st7701: Fix RTNI calculation

2022-10-18 Thread Marek Vasut
On 10/18/22 11:13, Linus Walleij wrote: On Tue, Oct 18, 2022 at 11:03 AM Marek Vasut wrote: On 10/18/22 10:53, Linus Walleij wrote: On Thu, Oct 13, 2022 at 12:12 AM Marek Vasut wrote: The RTNI field is multiplied by 16 and incremented by 512 before being used as the minimum number of pixel

Re: [PATCH 1/2] Revert "drm: hide unregistered connectors from GETCONNECTOR IOCTL"

2022-10-18 Thread Jonas Ådahl
On Tue, Oct 18, 2022 at 12:58:53PM +0300, Ville Syrjälä wrote: > On Tue, Oct 18, 2022 at 11:27:19AM +0200, Jonas Ådahl wrote: > > On Tue, Oct 18, 2022 at 12:14:09PM +0300, Ville Syrjälä wrote: > > > On Mon, Oct 17, 2022 at 03:31:57PM +, Simon Ser wrote: > > > > This reverts commit 981f09295687f

Re: [PATCH] drm/mipi-dsi: fix possible memory leak in mipi_dsi_device_register_full()

2022-10-18 Thread Thierry Reding
On Tue, Oct 18, 2022 at 04:25:45PM +0800, Yang Yingliang wrote: > If mipi_dsi_device_add() fails, the refcount of device is not 0, the name > allocated in dev_set_name() is leaked. Fix this by calling put_device(), > so that it will be freed in callback function kobject_cleanup(). > > Fixes: 068a0

Re: [PATCH v2 4/7] drm/simpledrm: Add support for system memory framebuffers

2022-10-18 Thread Thierry Reding
On Mon, Oct 17, 2022 at 01:15:59PM -0500, Rob Herring wrote: > On Mon, Oct 17, 2022 at 9:54 AM Thierry Reding > wrote: > > > > On Mon, Oct 10, 2022 at 10:12:34AM +0200, Thomas Zimmermann wrote: > > > Hi > > > > > > Am 07.10.22 um 14:49 schrieb Thierry Reding: > > > > From: Thierry Reding > > > >

Re: Build regressions/improvements in v6.1-rc1

2022-10-18 Thread Maciej W. Rozycki
On Mon, 17 Oct 2022, Geert Uytterhoeven wrote: > > + {standard input}: Error: branch to a symbol in another ISA mode: 1339 => > > 2616, 2621 > > mips-gcc11/micro32r2_defconfig > mips-gcc11/micro32r2el_defconfig Where can these configs be obtained from? Maciej

Re: [PATCH 1/2] Revert "drm: hide unregistered connectors from GETCONNECTOR IOCTL"

2022-10-18 Thread Ville Syrjälä
On Tue, Oct 18, 2022 at 12:07:43PM +0200, Jonas Ådahl wrote: > On Tue, Oct 18, 2022 at 12:58:53PM +0300, Ville Syrjälä wrote: > > On Tue, Oct 18, 2022 at 11:27:19AM +0200, Jonas Ådahl wrote: > > > On Tue, Oct 18, 2022 at 12:14:09PM +0300, Ville Syrjälä wrote: > > > > On Mon, Oct 17, 2022 at 03:31:5

Re: [PATCH v7 00/21] Move all drivers to a common dma-buf locking convention

2022-10-18 Thread Christian König
Am 18.10.22 um 01:07 schrieb Dmitry Osipenko: On 10/17/22 20:22, Dmitry Osipenko wrote: Hello, This series moves all drivers to a dynamic dma-buf locking specification. From now on all dma-buf importers are made responsible for holding dma-buf's reservation lock around all operations performed

Re: [PATCH v2] drm/panel/panel-sitronix-st7701: Fix RTNI calculation

2022-10-18 Thread Linus Walleij
On Tue, Oct 18, 2022 at 12:01 PM Marek Vasut wrote: > On 10/18/22 11:13, Linus Walleij wrote: > > I've been told to go and poke the DRM git people at IRC to rebase > > the fixes branch. > > That would be #dri-devel on OFTC I think ? Yups, I pinged and mlankhorst says he will fix it. Yours, Linu

Re: [PATCH v2 4/7] drm/simpledrm: Add support for system memory framebuffers

2022-10-18 Thread Thomas Zimmermann
Hi Thierry Am 17.10.22 um 16:54 schrieb Thierry Reding: On Mon, Oct 10, 2022 at 10:12:34AM +0200, Thomas Zimmermann wrote: [...] That whole 'Memory Manangement' block is will be unmaintainable. Before I go into a detailed review, please see my questions about the reservedmem code at the end o

Re: [PATCH v3] drm/sched: Fix kernel NULL pointer dereference error

2022-10-18 Thread Yadav, Arvind
On 10/17/2022 8:20 PM, Christian König wrote: Am 17.10.22 um 16:30 schrieb Arvind Yadav: -This is purely a timing issue. Here, sometimes Job free is happening before the job is done. To fix this issue moving 'dma_fence_cb' callback from job(struct drm_sched_job) to scheduler fence (struct drm_

Re: [PATCH v5 12/22] drm/connector: Add a function to lookup a TV mode by its name

2022-10-18 Thread Noralf Trønnes
Den 18.10.2022 11.33, skrev Maxime Ripard: > On Mon, Oct 17, 2022 at 12:44:45PM +0200, Noralf Trønnes wrote: >> Den 13.10.2022 15.18, skrev Maxime Ripard: >>> As part of the command line parsing rework coming in the next patches, >>> we'll need to lookup drm_connector_tv_mode values by their nam

Re: Build regressions/improvements in v6.1-rc1

2022-10-18 Thread Geert Uytterhoeven
Hi Maciej, On Tue, Oct 18, 2022 at 12:39 PM Maciej W. Rozycki wrote: > On Mon, 17 Oct 2022, Geert Uytterhoeven wrote: > > .> [1] > > http://kisskb.ellerman.id.au/kisskb/branch/linus/head/9abf2313adc1ca1b6180c508c25f22f9395cc780/ > > (all 149 configs) > > > + {standard input}: Error: branch to

Re: [PATCH v3] drm/sched: Fix kernel NULL pointer dereference error

2022-10-18 Thread Christian König
Am 18.10.22 um 14:20 schrieb Yadav, Arvind: [SNIP] +    drm_sched_fence_finished(s_fence); +    dma_fence_put(&s_fence->finished); +    wake_up_interruptible(&sched->wake_up_worker); +} + +int drm_sched_fence_add_parent_cb(struct dma_fence *fence, +  struct drm_sched_fence *s

Re: [PATCH v7 00/21] Move all drivers to a common dma-buf locking convention

2022-10-18 Thread Dmitry Osipenko
On 10/18/22 14:34, Christian König wrote: > Am 18.10.22 um 01:07 schrieb Dmitry Osipenko: >> On 10/17/22 20:22, Dmitry Osipenko wrote: >>> Hello, >>> >>> This series moves all drivers to a dynamic dma-buf locking >>> specification. >>>  From now on all dma-buf importers are made responsible for hol

[PATCH] drm: Remove drm_mode_config::fb_base

2022-10-18 Thread Zack Rusin
From: Zack Rusin The fb_base in struct drm_mode_config has been unused for a long time. Some drivers set it and some don't leading to a very confusing state where the variable can't be relied upon, because there's no indication as to which driver sets it and which doesn't. The only usage of fb_b

Re: Build regressions/improvements in v6.1-rc1

2022-10-18 Thread Maciej W. Rozycki
Hi Geert, > > > .> [1] > > > http://kisskb.ellerman.id.au/kisskb/branch/linus/head/9abf2313adc1ca1b6180c508c25f22f9395cc780/ > > > (all 149 configs) > > > > > + {standard input}: Error: branch to a symbol in another ISA mode: > > > > 1339 => > > > > 2616, 2621 > > > > > > mips-gcc11/micro32r2

Re: [PATCH] drm: Remove drm_mode_config::fb_base

2022-10-18 Thread Thomas Zimmermann
Hi Am 18.10.22 um 15:17 schrieb Zack Rusin: From: Zack Rusin The fb_base in struct drm_mode_config has been unused for a long time. Some drivers set it and some don't leading to a very confusing state where the variable can't be relied upon, because there's no indication as to which driver set

Re: i915 "GPU HANG", bisected to a2daa27c0c61 "swiotlb: simplify swiotlb_max_segment"

2022-10-18 Thread Jan Beulich
On 18.10.2022 13:02, Christoph Hellwig wrote: > On Tue, Oct 18, 2022 at 10:57:37AM +0200, Jan Beulich wrote: >> Shouldn't this then be xen_pv_domain() that you use here, and - if you >> really want IS_ENABLED() in addition - CONFIG_XEN_PV? > > I'll need help from people that understand Xen better

Re: i915 "GPU HANG", bisected to a2daa27c0c61 "swiotlb: simplify swiotlb_max_segment"

2022-10-18 Thread Juergen Gross
On 18.10.22 16:33, Christoph Hellwig wrote: On Tue, Oct 18, 2022 at 04:21:43PM +0200, Jan Beulich wrote: Leaving the "i915 abuses" part aside (because I can't tell what exactly the abuse is), but assuming that "can't cope with bounce buffering" means they don't actually use the allocated buffers

Re: [Intel-gfx] [PATCH v3 09/17] drm/i915/vm_bind: Add out fence support

2022-10-18 Thread Matthew Auld
On 14/10/2022 07:48, Niranjana Vishwanathapura wrote: On Sun, Oct 09, 2022 at 11:58:18PM -0700, Niranjana Vishwanathapura wrote: Add support for handling out fence for vm_bind call. v2: Reset vma->vm_bind_fence.syncobj to NULL at the end    of vm_bind call. Signed-off-by: Niranjana Vishwanatha

Re: [PATCH v2] drm/mgag200: Fix PLL setup for G200_SE_A rev >=4

2022-10-18 Thread Jocelyn Falempe
I just pushed it to drm-misc-next. I also fixed the commit message a bit, the commit moving this line of code is in fact: commit 877507bb954e ("drm/mgag200: Provide per-device callbacks for PIXPLLC") Best Regards -- Jocelyn On 13/10/2022 15:55, Thomas Zimmermann wrote: Am 13.10.22 um

Re: [PATCH] drm: Remove drm_mode_config::fb_base

2022-10-18 Thread Christian König
Am 18.10.22 um 15:17 schrieb Zack Rusin: From: Zack Rusin The fb_base in struct drm_mode_config has been unused for a long time. Some drivers set it and some don't leading to a very confusing state where the variable can't be relied upon, because there's no indication as to which driver sets it

Re: logging:convert dev_info to drm_info

2022-10-18 Thread Thomas Zimmermann
Hi Am 18.10.22 um 09:20 schrieb jianengchencool: Hi, I want to convert logging dev_info/warn/err to drm_info/warn/err  in drivers/gpu/drm/pl111, so I want to ask if this work will be merged? Thanks! Well, just send the patches for review. Best regards Thomas TODO list below: Conv

Re: [PATCH v2 0/2] drm/rockchip: dw_hdmi: Add 4k@30 support

2022-10-18 Thread Dan Johansen
Den 05.10.2022 kl. 13.10 skrev Sascha Hauer: On Wed, Oct 05, 2022 at 12:51:57PM +0200, Dan Johansen wrote: Den 05.10.2022 kl. 12.06 skrev Sascha Hauer: On Wed, Sep 28, 2022 at 10:39:27AM +0200, Dan Johansen wrote: Den 28.09.2022 kl. 10.37 skrev Sascha Hauer: On Tue, Sep 27, 2022 at 07:53:54

Re: [PATCH 1/2] drm/sched: add DRM_SCHED_FENCE_DONT_PIPELINE flag

2022-10-18 Thread Christian König
Gentle ping to others to get this reviewed. Alex, this is fixing the TLB flush errors and I think we need to get it into -fixes ASAP. Christian. Am 14.10.22 um 10:15 schrieb Christian König: Setting this flag on a scheduler fence prevents pipelining of jobs depending on this fence. In other

Re: [PATCH v2 4/7] drm/simpledrm: Add support for system memory framebuffers

2022-10-18 Thread Thierry Reding
On Tue, Oct 18, 2022 at 01:58:53PM +0200, Thomas Zimmermann wrote: > Hi Thierry > > Am 17.10.22 um 16:54 schrieb Thierry Reding: > > On Mon, Oct 10, 2022 at 10:12:34AM +0200, Thomas Zimmermann wrote: > [...] > > > > > > That whole 'Memory Manangement' block is will be unmaintainable. Before I >

Re: [PATCH] drm: Remove drm_mode_config::fb_base

2022-10-18 Thread Laurent Pinchart
Hi Zack, Thank you for the patch. On Tue, Oct 18, 2022 at 09:17:45AM -0400, Zack Rusin wrote: > From: Zack Rusin > > The fb_base in struct drm_mode_config has been unused for a long time. > Some drivers set it and some don't leading to a very confusing state > where the variable can't be relied

Re: [PATCH v4 09/17] drm/i915/vm_bind: Add out fence support

2022-10-18 Thread Matthew Auld
On 18/10/2022 08:16, Niranjana Vishwanathapura wrote: Add support for handling out fence for vm_bind call. v2: Reset vma->vm_bind_fence.syncobj to NULL at the end of vm_bind call. v3: Remove vm_unbind out fence uapi which is not supported yet. Signed-off-by: Niranjana Vishwanathapura Sign

Re: [PATCH v2 4/7] drm/simpledrm: Add support for system memory framebuffers

2022-10-18 Thread Rob Herring
On Tue, Oct 18, 2022 at 5:47 AM Thierry Reding wrote: > > On Mon, Oct 17, 2022 at 01:15:59PM -0500, Rob Herring wrote: > > On Mon, Oct 17, 2022 at 9:54 AM Thierry Reding > > wrote: > > > > > > On Mon, Oct 10, 2022 at 10:12:34AM +0200, Thomas Zimmermann wrote: > > > > Hi > > > > > > > > Am 07.10.

Re: [PATCH 1/2] drm/sched: add DRM_SCHED_FENCE_DONT_PIPELINE flag

2022-10-18 Thread Alex Deucher
On Tue, Oct 18, 2022 at 11:11 AM Christian König wrote: > > Gentle ping to others to get this reviewed. > > Alex, this is fixing the TLB flush errors and I think we need to get it > into -fixes ASAP. > > Christian. > > Am 14.10.22 um 10:15 schrieb Christian König: > > Setting this flag on a schedu

Re: [PATCH] drm: Remove drm_mode_config::fb_base

2022-10-18 Thread Zack Rusin
On Tue, 2022-10-18 at 16:05 +0200, Thomas Zimmermann wrote: > Hi > > Am 18.10.22 um 15:17 schrieb Zack Rusin: > > From: Zack Rusin > > > > The fb_base in struct drm_mode_config has been unused for a long time. > > Some drivers set it and some don't leading to a very confusing state > > where the

Re: [PATCH] drm/amdgpu/powerplay/psm: Fix memory leak in power state init

2022-10-18 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Oct 17, 2022 at 9:07 PM Quan, Evan wrote: > > [AMD Official Use Only - General] > > Reviewed-by: Evan Quan > > > -Original Message- > > From: Rafael Mendonca > > Sent: Tuesday, October 18, 2022 8:54 AM > > To: Quan, Evan ; Deucher, Alexander > > ; Koenig,

Re: [PATCH v4 17/17] drm/i915/vm_bind: Add uapi for user to enable vm_bind_mode

2022-10-18 Thread Matthew Auld
On 18/10/2022 08:16, Niranjana Vishwanathapura wrote: Add getparam support for VM_BIND capability version. Add VM creation time flag to enable vm_bind_mode for the VM. v2: update kernel-doc v3: create vm->root_obj only upon I915_VM_CREATE_FLAGS_USE_VM_BIND v4: replace vm->vm_bind_mode check with

[PATCH v2] drm: Remove drm_mode_config::fb_base

2022-10-18 Thread Zack Rusin
From: Zack Rusin v2: Thomas and Laurent noticed that in radeon_fb.c I forgot to set the info->apertures->ranges[0].base and Laurent noticed a neat little cleanup in the hisilicon driver as a result of the drm_mode_config::fb_base removal. The fb_base in struct drm_mode_config has been unused for

Re: [PATCH v2] drm: Remove drm_mode_config::fb_base

2022-10-18 Thread Laurent Pinchart
Hi Zack, Thank you for the patch. On Tue, Oct 18, 2022 at 12:11:51PM -0400, Zack Rusin wrote: > From: Zack Rusin > > v2: Thomas and Laurent noticed that in radeon_fb.c I forgot to set the > info->apertures->ranges[0].base and Laurent noticed a neat little cleanup > in the hisilicon driver as a

Re: [PATCH v2] drm: Remove drm_mode_config::fb_base

2022-10-18 Thread Zack Rusin
On Tue, 2022-10-18 at 19:28 +0300, Laurent Pinchart wrote: > > @@ -271,7 +260,8 @@ static int hibmc_load(struct drm_device *dev) > >    if (ret) > >    goto err; > > > > - ret = drmm_vram_helper_init(dev, pci_resource_start(pdev, 0), priv- > > >fb_size); > > + ret = drmm_vr

[PATCH 0/2] drm/tiny: add support tft display based on ilitek, ili9488

2022-10-18 Thread Tommaso Merciai
Hi All, This series support for ilitek,ili9488 based displays like Waveshare-ResTouch-LCD-3.5 display. Tested on Waveshare-ResTouch-LCD-3.5 connected to px30-evb via SPI. This series is based on work done by Kamlesh Gurudasani in 2020: - "drm/tiny: add support for tft displays based on ilitek, i

[PATCH 1/2] dt-bindings: add binding for tft displays based on ilitek, ili9488

2022-10-18 Thread Tommaso Merciai
This binding is for the tft displays based on ilitek,ili9488. waveshare,waveshare,pico-rt-lcd-35 (waveshare pico-restouch-lcd-3.5) Signed-off-by: Tommaso Merciai --- .../bindings/display/ilitek,ili9488.yaml | 72 +++ 1 file changed, 72 insertions(+) create mode 100644 Docu

[PATCH 2/2] drm/tiny: add support for tft displays based on ilitek, ili9488

2022-10-18 Thread Tommaso Merciai
This adds support for ilitek,ili9488 based displays with shift register in front of controller. Waveshare,pico-restouch-lcd-3.5 are such displays Signed-off-by: Tommaso Merciai --- drivers/gpu/drm/tiny/Kconfig | 13 + drivers/gpu/drm/tiny/Makefile | 1 + drivers/gpu/drm/tiny/ili9488.c | 44

Re: [PATCH v4 17/17] drm/i915/vm_bind: Add uapi for user to enable vm_bind_mode

2022-10-18 Thread Niranjana Vishwanathapura
On Tue, Oct 18, 2022 at 05:03:16PM +0100, Matthew Auld wrote: On 18/10/2022 08:16, Niranjana Vishwanathapura wrote: Add getparam support for VM_BIND capability version. Add VM creation time flag to enable vm_bind_mode for the VM. v2: update kernel-doc v3: create vm->root_obj only upon I915_VM_C

Re: [PATCH V2 3/4] drm/panel: Add prepare_upstream_first flag to drm_panel

2022-10-18 Thread Dave Stevenson
Hi Jagan On Mon, 17 Oct 2022 at 03:44, Jagan Teki wrote: > > Hi Dave, > > On Fri, Oct 7, 2022 at 6:26 PM Dave Stevenson > wrote: > > > > Hi Jagan > > > > On Thu, 6 Oct 2022 at 15:25, Jagan Teki wrote: > > > > > > On Fri, Mar 4, 2022 at 8:48 PM Dave Stevenson > > > wrote: > > > > > > > > Mappin

[PATCH v4] drm/sched: Fix kernel NULL pointer dereference error

2022-10-18 Thread Arvind Yadav
-This is purely a timing issue. Here, sometimes Job free is happening before the job is done. To fix this issue moving 'dma_fence_cb' callback from job(struct drm_sched_job) to scheduler fence (struct drm_sched_fence). -Added drm_sched_fence_set_parent() and drm_sched_fence_clear_parent() function

Re: [PATCH v4 12/17] drm/i915/vm_bind: Implement I915_GEM_EXECBUFFER3 ioctl

2022-10-18 Thread Matthew Auld
On 18/10/2022 08:16, Niranjana Vishwanathapura wrote: Implement new execbuf3 ioctl (I915_GEM_EXECBUFFER3) which only works in vm_bind mode. The vm_bind mode only works with this new execbuf3 ioctl. The new execbuf3 ioctl will not have any list of objects to validate bind as all required objects

Re: [PATCH v4 15/17] drm/i915/vm_bind: Handle persistent vmas in execbuf3

2022-10-18 Thread Matthew Auld
On 18/10/2022 08:16, Niranjana Vishwanathapura wrote: Handle persistent (VM_BIND) mappings during the request submission in the execbuf3 path. v2: Ensure requests wait for bindings to complete. v3: Remove short term pinning with PIN_VALIDATE flag. Individualize fences before adding to dma_r

[PATCH] drm: rcar_du: DRM_RCAR_DU optionally depends on RCAR_MIPI_DSI

2022-10-18 Thread Randy Dunlap
When CONFIG_DRM_RCAR_DU=y and CONFIG_DRM_RCAR_MIPI_DSI=m, calls from the builtin driver to the mipi driver fail due to linker errors. Since the RCAR_MIPI_DSI driver is not always required, fix the build error by making DRM_RCAR_DU optionally depend on the RCAR_MIPI_DSI Kconfig symbol. This prevents

Re: [PATCH v2] drm_bridge: register content protect property

2022-10-18 Thread Sean Paul
On Mon, Oct 17, 2022 at 9:49 AM Hsin-Yi Wang wrote: > > On Wed, Oct 12, 2022 at 12:20 PM Hsin-Yi Wang wrote: > > > > Some bridges are able to update HDCP status from userspace request if > > they support HDCP. > > > > HDCP property is the same as other connector properties that need to be > > cre

Re: [PATCH 1/2] dt-bindings: add binding for tft displays based on ilitek,ili9488

2022-10-18 Thread Krzysztof Kozlowski
On 18/10/2022 12:45, Tommaso Merciai wrote: > This binding is for the tft displays based on ilitek,ili9488. > waveshare,waveshare,pico-rt-lcd-35 (waveshare pico-restouch-lcd-3.5) > > Signed-off-by: Tommaso Merciai > --- > .../bindings/display/ilitek,ili9488.yaml | 72 +++ >

Re: [PATCH 2/2] drm/tiny: add support for tft displays based on ilitek, ili9488

2022-10-18 Thread Michael Nazzareno Trimarchi
Hi On Tue, Oct 18, 2022 at 6:46 PM Tommaso Merciai wrote: > > This adds support for ilitek,ili9488 based displays with shift register > in front of controller. Waveshare,pico-restouch-lcd-3.5 are such displays > > Signed-off-by: Tommaso Merciai > --- Because I start to make it working this driv

[PATCH v3] drm: Remove drm_mode_config::fb_base

2022-10-18 Thread Zack Rusin
From: Zack Rusin v3: Fix a silly pci_resource_len mistake spotted by Laurent The fb_base in struct drm_mode_config has been unused for a long time. Some drivers set it and some don't leading to a very confusing state where the variable can't be relied upon, because there's no indication as to wh

[PATCH v3] drm/i915/slpc: Use platform limits for min/max frequency

2022-10-18 Thread Vinay Belgaumkar
GuC will set the min/max frequencies to theoretical max on ATS-M. This will break kernel ABI, so limit min/max frequency to RP0(platform max) instead. Also modify the SLPC selftest to update the min frequency when we have a server part so that we can iterate between platform min and max. v2: Chec

  1   2   >