Re: [git pull] drm fixes for 6.1-rc1

2022-10-16 Thread Arthur Marsh
From: Arthur Marsh Hi, the "drm fixes for 6.1-rc1" commit caused the amdgpu module to fail with my Cape Verde radeonsi card. I haven't been able to bisect the problem to an individual commit, but attach a dmesg extract below. I'm happy to supply any other configuration information and test patc

Re: [PATCH AUTOSEL 6.0 16/44] drm: hide unregistered connectors from GETCONNECTOR IOCTL

2022-10-16 Thread Sasha Levin
On Thu, Oct 13, 2022 at 07:31:19PM +, Simon Ser wrote: Jonas has reported that this breaks Mutter. Sasha, can we remove this from the stable queue? Yup, I'll drop it for now. Thanks! -- Thanks, Sasha

Re: [PATCH v5 08/22] drm/modes: Move named modes parsing to a separate function

2022-10-16 Thread Noralf Trønnes
Den 13.10.2022 15.18, skrev Maxime Ripard: > The current construction of the named mode parsing doesn't allow to extend > it easily. Let's move it to a separate function so we can add more > parameters and modes. > > In order for the tests to still pass, some extra checks are needed, so > it's

Re: [PATCH v5 06/22] drm/modes: Add a function to generate analog display modes

2022-10-16 Thread Mateusz Kwiatkowski
Hi Maxime & everyone, Sorry for being inactive in the discussions about this patchset for the last couple of weeks. > +const static struct analog_parameters tv_modes_parameters[] = { > + TV_MODE_PARAMETER(DRM_MODE_ANALOG_NTSC, > + NTSC_LINES_NUMBER, > +

[RESEND PATCH] drm/amd/amdgpu: Replace kmap() with kmap_local_page()

2022-10-16 Thread Fabio M. De Francesco
kmap() is being deprecated in favor of kmap_local_page(). There are two main problems with kmap(): (1) It comes with an overhead as mapping space is restricted and protected by a global lock for synchronization and (2) it also requires global TLB invalidation when the kmap’s pool wraps and it migh

Re: [PATCH v5 13/22] drm/modes: Introduce the tv_mode property as a command-line option

2022-10-16 Thread Mateusz Kwiatkowski
Hi Maxime, Noralf & everyone, I'd like to address Noralf here in particular, and refer to these discussions from the past: - https://lore.kernel.org/linux-arm-kernel/2f607c7d-6da1-c8df-1c02-8dd344a92...@gmail.com/ - https://lore.kernel.org/linux-arm-kernel/9e76a508-f469-a54d-ecd7-b5868ca99...@t

[RESEND PATCH 0/3] drm/i915: Replace kmap() with kmap_local_page()

2022-10-16 Thread Fabio M. De Francesco
kmap() is being deprecated in favor of kmap_local_page(). There are two main problems with kmap(): (1) It comes with an overhead as mapping space is restricted and protected by a global lock for synchronization and (2) it also requires global TLB invalidation when the kmap’s pool wraps and it migh

[RESEND PATCH 1/3] drm/i915: Replace kmap() with kmap_local_page()

2022-10-16 Thread Fabio M. De Francesco
kmap() is being deprecated in favor of kmap_local_page(). There are two main problems with kmap(): (1) It comes with an overhead as mapping space is restricted and protected by a global lock for synchronization and (2) it also requires global TLB invalidation when the kmap’s pool wraps and it migh

[RESEND PATCH 2/3] drm/i915/gt: Replace kmap() with kmap_local_page()

2022-10-16 Thread Fabio M. De Francesco
kmap() is being deprecated in favor of kmap_local_page(). There are two main problems with kmap(): (1) It comes with an overhead as mapping space is restricted and protected by a global lock for synchronization and (2) it also requires global TLB invalidation when the kmap’s pool wraps and it migh

[RESEND PATCH 3/3] drm/i915/gem: Replace kmap() with kmap_local_page()

2022-10-16 Thread Fabio M. De Francesco
kmap() is being deprecated in favor of kmap_local_page(). There are two main problems with kmap(): (1) It comes with an overhead as mapping space is restricted and protected by a global lock for synchronization and (2) it also requires global TLB invalidation when the kmap’s pool wraps and it migh

Re: [PATCH v5 19/22] drm/vc4: vec: Check for VEC output constraints

2022-10-16 Thread Mateusz Kwiatkowski
Hi Maxime, W dniu 13.10.2022 o 15:19, Maxime Ripard pisze: > From: Mateusz Kwiatkowski > > The VEC can accept pretty much any relatively > reasonable mode, but still > has a bunch of constraints to meet. > > Let's > create an atomic_check() implementation that will make sure we > don't end up >

Re: [PATCH v5 19/22] drm/vc4: vec: Check for VEC output constraints

2022-10-16 Thread Mateusz Kwiatkowski
Hi Maxime, Sorry about the mess that happened to the previous message. I hope this one will be delivered more cleanly. W dniu 13.10.2022 o 15:19, Maxime Ripard pisze: > From: Mateusz Kwiatkowski > > The VEC can accept pretty much any relatively reasonable mode, but still > has a bunch of constra

Re: [PATCH v5 20/22] drm/vc4: vec: Convert to the new TV mode property

2022-10-16 Thread Mateusz Kwiatkowski
Hi Maxime, > static int vc4_vec_connector_get_modes(struct drm_connector *connector) > { > - struct drm_connector_state *state = connector->state; > struct drm_display_mode *mode; > > - mode = drm_mode_duplicate(connector->dev, > - vc4_vec_tv_modes[s

Re: [PATCH v5 20/22] drm/vc4: vec: Convert to the new TV mode property

2022-10-16 Thread Mateusz Kwiatkowski
Hi Maxime, Urgh. I cannot send e-mails apparently today, as I removed the second half of the previous message. Here goes: > @@ -454,13 +563,6 @@ static int vc4_vec_encoder_atomic_check(struct > drm_encoder *encoder, > struct drm_connector_state *conn_state)

Re: [PATCH v5 21/22] drm/vc4: vec: Add support for more analog TV standards

2022-10-16 Thread Mateusz Kwiatkowski
Hi Maxime, W dniu 13.10.2022 o 15:19, Maxime Ripard pisze: > From: Mateusz Kwiatkowski > > Add support for the following composite output modes (all of them are > somewhat more obscure than the previously defined ones): > > - NTSC_443 - NTSC-style signal with the chroma subcarrier shifted to >  

[PATCH] drm/vc4: vec: Add support for PAL-60

2022-10-16 Thread Mateusz Kwiatkowski
Add support for the PAL-60 mode. Because there is no separate TV mode property value for PAL-60, this requires matching the settings based on the modeline in addition to just that property alone. Signed-off-by: Mateusz Kwiatkowski --- This patch depends on patch '[PATCH v5 21/22] drm/vc4: vec: Ad

[PATCH] drm/framebuffer: break out of loop, if the requested element is found

2022-10-16 Thread Hamza Mahfooz
We can stop searching through the linked-list after we have found the element we are looking for. So, break out of list_for_each_entry() after we have found the element we are looking for in drm_mode_rmfb(). Signed-off-by: Hamza Mahfooz --- drivers/gpu/drm/drm_framebuffer.c | 5 - 1 file cha

Re: [git pull] drm fixes for 6.1-rc1

2022-10-16 Thread Dave Airlie
On Sun, 16 Oct 2022 at 18:09, Arthur Marsh wrote: > > From: Arthur Marsh > > Hi, the "drm fixes for 6.1-rc1" commit caused the amdgpu module to fail > with my Cape Verde radeonsi card. > > I haven't been able to bisect the problem to an individual commit, but > attach a dmesg extract below. > > I

[PATCH -next] nouveau/dmem: Remove duplicated include in nouveau_dmem.c

2022-10-16 Thread Yang Li
./drivers/gpu/drm/nouveau/nouveau_dmem.c: nvif/if000c.h is included more than once. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2404 Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/nouveau/nouveau_dmem.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu

Re: [git pull] drm fixes for 6.1-rc1

2022-10-16 Thread Arthur Marsh
Thanks Dave, I reverted patch 312b4dc11d4f74bfe03ea25ffe04c1f2fdd13cb9 against 6.1-rc1 and the resulting kernel loaded amdgpu fine on my pc with Cape Verde GPU. Regards, Arthur. On 17 October 2022 8:14:18 am ACDT, Dave Airlie wrote: >On Sun, 16 Oct 2022 at 18:09, Arthur Marsh > wrote: >> >>

Re: [PATCH V2 3/4] drm/panel: Add prepare_upstream_first flag to drm_panel

2022-10-16 Thread Jagan Teki
Hi Dave, On Fri, Oct 7, 2022 at 6:26 PM Dave Stevenson wrote: > > Hi Jagan > > On Thu, 6 Oct 2022 at 15:25, Jagan Teki wrote: > > > > On Fri, Mar 4, 2022 at 8:48 PM Dave Stevenson > > wrote: > > > > > > Mapping to the drm_bridge flag pre_enable_upstream_first, > > > add a new flag prepare_upstr

Re: [PATCH v7 01/10] drm: bridge: Add Samsung DSIM bridge driver

2022-10-16 Thread Jagan Teki
On Sun, Oct 16, 2022 at 3:16 AM Marek Vasut wrote: > > On 10/5/22 17:13, Jagan Teki wrote: > > Samsung MIPI DSIM controller is common DSI IP that can be used in various > > SoCs like Exynos, i.MX8M Mini/Nano. > > > > In order to access this DSI controller between various platform SoCs, > > the ide

Re: [PATCH v7 02/10] drm: bridge: samsung-dsim: Lookup OF-graph or Child node devices

2022-10-16 Thread Jagan Teki
On Sun, Oct 16, 2022 at 3:18 AM Marek Vasut wrote: > > On 10/5/22 17:13, Jagan Teki wrote: > > The child devices in MIPI DSI can be binding with OF-graph > > and also via child nodes. > > > > The OF-graph interface represents the child devices via > > remote and associated endpoint numbers like >

RE: [PATCH] drm/amdgpu/dm/mst: Fix incorrect usage of drm_dp_add_payload_part2()

2022-10-16 Thread Lin, Wayne
[Public] > -Original Message- > From: Lyude Paul > Sent: Thursday, October 6, 2022 3:37 AM > To: Siqueira, Rodrigo ; dri- > de...@lists.freedesktop.org; amd-...@lists.freedesktop.org > Cc: Wentland, Harry ; Li, Sun peng (Leo) > ; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui

Re: [PATCH v7 05/10] drm: bridge: samsung-dsim: Add atomic_check

2022-10-16 Thread Jagan Teki
On Sun, Oct 16, 2022 at 2:53 AM Marek Vasut wrote: > > On 10/5/22 17:13, Jagan Teki wrote: > > Look like an explicit fixing up of mode_flags is required for DSIM IP > > present in i.MX8M Mini/Nano SoCs. > > > > At least the LCDIF + DSIM needs active low sync polarities in order > > to correlate th

Re: [PATCH v7 07/10] drm: bridge: samsung-dsim: Add atomic_get_input_bus_fmts

2022-10-16 Thread Jagan Teki
On Sun, Oct 16, 2022 at 3:31 AM Marek Vasut wrote: > > On 10/5/22 17:13, Jagan Teki wrote: > > [...] > > > @@ -1321,6 +1322,32 @@ static void samsung_dsim_atomic_post_disable(struct > > drm_bridge *bridge, > > pm_runtime_put_sync(dsi->dev); > > } > > > > +#define MAX_INPUT_SEL_FORMATS

Re: [PATCH] dt-bindings: Remove "status" from schema examples, again

2022-10-16 Thread Vinod Koul
On 14-10-22, 15:51, Rob Herring wrote: > There's no reason to have "status" properties in examples. "okay" is the > default, and "disabled" turns off some schema checks ('required' > specifically). > > A meta-schema check for this is pending, so hopefully the last time to > fix these. > > Fix the

Re: [PATCH 2/2] drm/amdgpu: use DRM_SCHED_FENCE_DONT_PIPELINE for VM updates

2022-10-16 Thread Luben Tuikov
Hi Christian, On 2022-10-14 04:15, Christian König wrote: > Make sure that we always have a CPU round trip to let the submission > code correctly decide if a TLB flush is necessary or not. > > Signed-off-by: Christian König > CC: sta...@vger.kernel.org # 5.19+ > --- > drivers/gpu/drm/amd/amdgpu

Re: [git pull] drm fixes for 6.1-rc1

2022-10-16 Thread Christian König
Arun please take a look into this ASAP. Thanks, Christian. Am 17.10.22 um 03:13 schrieb Arthur Marsh: Thanks Dave, I reverted patch 312b4dc11d4f74bfe03ea25ffe04c1f2fdd13cb9 against 6.1-rc1 and the resulting kernel loaded amdgpu fine on my pc with Cape Verde GPU. Regards, Arthur. On 17 Octo

Re: [PATCH 2/2] drm/amdgpu: use DRM_SCHED_FENCE_DONT_PIPELINE for VM updates

2022-10-16 Thread Christian König
Am 17.10.22 um 07:29 schrieb Luben Tuikov: Hi Christian, On 2022-10-14 04:15, Christian König wrote: Make sure that we always have a CPU round trip to let the submission code correctly decide if a TLB flush is necessary or not. Signed-off-by: Christian König CC: sta...@vger.kernel.org # 5.19+

Re: [PATCH] drm/bridge: tc358767: Set default CLRSIPO count

2022-10-16 Thread Maxime Ripard
On Sun, Oct 16, 2022 at 02:35:56AM +0200, Marek Vasut wrote: > The current CLRSIPO count is still marginal and does not work with high > DSI clock rates in burst mode. Increase it further to allow the DSI link > to work at up to 1Gbps lane speed. This returns the counts to defaults > as provided by

Re: [PATCH] drm/bridge: tc358767: Enable DSI burst mode, LPM, non-continuous clock

2022-10-16 Thread Maxime Ripard
On Sun, Oct 16, 2022 at 02:36:32AM +0200, Marek Vasut wrote: > The TC358767/TC358867/TC9595 are capable of DSI burst mode, which > is more energy efficient than the non-burst modes. Make use of it. > > The TC358767/TC358867/TC9595 are capable of DSI non-continuous clock, > since it sources the int

Re: [git pull] drm fixes for 6.1-rc1

2022-10-16 Thread Arunpravin Paneer Selvam
Hi Arthur, Is this old radeon card? Thanks, Arun On 10/17/2022 11:50 AM, Christian König wrote: Arun please take a look into this ASAP. Thanks, Christian. Am 17.10.22 um 03:13 schrieb Arthur Marsh: Thanks Dave, I reverted patch 312b4dc11d4f74bfe03ea25ffe04c1f2fdd13cb9 against 6.1-rc1 and th