[PATCH 0/7] drm/i915: Add HWMON support

2022-10-13 Thread Ashutosh Dixit
This series adds the HWMON support for DGFX Test-with: 20221013151400.2086268-1-ashutosh.di...@intel.com v2: - Reorganized series. Created first patch as infrastructure patch followed by feature patches. (Ashutosh) - Fixed review comments (Jani) - Fixed review comments (Ashutosh) v3:

Re: [Intel-gfx] [PATCH 2/7] drm/i915/hwmon: Add HWMON current voltage support

2022-10-13 Thread Dixit, Ashutosh
On Mon, 03 Oct 2022 13:56:05 -0700, Andi Shyti wrote: Hi Andi, Badal is out for a bit so I am posting this version of the patches. > > Hi Badal, > > [...] > > > static void > > hwm_get_preregistration_info(struct drm_i915_private *i915) > > { > > + struct i915_hwmon *hwmon = i915->hwmon; >

Re: [PATCH 4/7] drm/i915/hwmon: Show device level energy usage

2022-10-13 Thread Dixit, Ashutosh
On Wed, 21 Sep 2022 05:02:48 -0700, Gupta, Anshuman wrote: > > > diff --git a/drivers/gpu/drm/i915/intel_mchbar_regs.h > > b/drivers/gpu/drm/i915/intel_mchbar_regs.h > > index b74df11977c6..1014d0b7cc16 100644 > > --- a/drivers/gpu/drm/i915/intel_mchbar_regs.h > > +++ b/drivers/gpu/drm/i915/intel_

Re: [Intel-gfx] [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting

2022-10-13 Thread Dixit, Ashutosh
On Mon, 03 Oct 2022 14:05:14 -0700, Andi Shyti wrote: > > Hi Badal, > > [...] > > > hwm_get_preregistration_info(struct drm_i915_private *i915) > > { > > struct i915_hwmon *hwmon = i915->hwmon; > > + struct intel_uncore *uncore = &i915->uncore; > > + intel_wakeref_t wakeref; > > + u32 v

Re: [PATCH 4/7] drm/i915/hwmon: Show device level energy usage

2022-10-13 Thread Dixit, Ashutosh
On Fri, 30 Sep 2022 09:52:28 -0700, Rodrigo Vivi wrote: > Hi Rodrigo, > On Tue, Sep 27, 2022 at 11:20:17AM +0530, Badal Nilawar wrote: > > From: Dale B Stimson > > > > Use i915 HWMON to display device level energy input. > > > > v2: Updated the date and kernel version in feature description > >

Re: [Intel-gfx] [PATCH 4/7] drm/i915/hwmon: Show device level energy usage

2022-10-13 Thread Dixit, Ashutosh
On Mon, 03 Oct 2022 14:13:10 -0700, Andi Shyti wrote: > Hi Andi, > [...] > > > > diff --git a/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon > > > b/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon > > > index 16e697b1db3d..7525db243d74 100644 > > > --- a/Documentation/ABI/testin

Re: [Intel-gfx] [PATCH 6/7] drm/i915/hwmon: Expose power1_max_interval

2022-10-13 Thread Dixit, Ashutosh
On Mon, 03 Oct 2022 14:32:36 -0700, Andi Shyti wrote: > Hi Andi, > > diff --git a/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon > > b/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon > > index f9d6d3b08bba..19b9fe3ef237 100644 > > --- a/Documentation/ABI/testing/sysfs-driver-int

Re: [PATCH v4 1/2] dt-bindings: it6505: add properties to restrict output bandwidth

2022-10-13 Thread Rob Herring
On Thu, 13 Oct 2022 18:51:13 +0800, allen wrote: > From: allen chen > > Add properties to restrict dp output data-lanes and clock. > > Signed-off-by: Pin-Yen Lin > Signed-off-by: Allen Chen > --- > .../bindings/display/bridge/ite,it6505.yaml | 43 +++ > 1 file changed, 43 in

[PATCH v2] drm/i915/slpc: Use platform limits for min/max frequency

2022-10-13 Thread Vinay Belgaumkar
GuC will set the min/max frequencies to theoretical max on ATS-M. This will break kernel ABI, so limit min/max frequency to RP0(platform max) instead. Also modify the SLPC selftest to update the min frequency when we have a server part so that we can iterate between platform min and max. v2: Chec

Re: [PATCH] drm/i915/slpc: Use platform limits for min/max frequency

2022-10-13 Thread Belgaumkar, Vinay
On 10/13/2022 8:14 AM, Das, Nirmoy wrote: On 10/12/2022 8:26 PM, Vinay Belgaumkar wrote: GuC will set the min/max frequencies to theoretical max on ATS-M. This will break kernel ABI, so limit min/max frequency to RP0(platform max) instead. Also modify the SLPC selftest to update the min freq

Re: [Freedreno] [PATCH v3 06/10] drm/msm/dsi: Migrate to drm_dsc_compute_rc_parameters()

2022-10-13 Thread Abhinav Kumar
On 10/13/2022 2:36 AM, Marijn Suijten wrote: On 2022-10-12 16:03:06, Abhinav Kumar wrote: On 10/9/2022 11:50 AM, Marijn Suijten wrote: As per the FIXME this code is entirely duplicate with what is already provided inside drm_dsc_compute_rc_parameters(), and it is yet unknown why this comme

Re: [PATCH v3 0/6] Add support for atomic async page-flips

2022-10-13 Thread Simon Ser
> > > So no tests that actually verify that the kernel properly rejects > > > stuff stuff like modesets, gamma LUT updates, plane movement, > > > etc.? > > > > Pondering this a bit more, it just occurred to me the current driver > > level checks might easily lead to confusing behaviour. Eg. is > >

Re: [PATCH v2] drm/sched: Fix kernel NULL pointer dereference error

2022-10-13 Thread Yadav, Arvind
On 10/12/2022 7:05 PM, Christian König wrote: That essentially looks like the right approach, but I would go a few steps further. I think we should add a drm_sched_fence_set_parent() function to sched_fence.c and move a good part of the handling into that C file. Just a simple signal functi

Re: [Intel-gfx] [PATCH v2] drm/i915/slpc: Use platform limits for min/max frequency

2022-10-13 Thread Tauro, Riana
On 10/13/2022 9:25 PM, Vinay Belgaumkar wrote: GuC will set the min/max frequencies to theoretical max on ATS-M. This will break kernel ABI, so limit min/max frequency to RP0(platform max) instead. Also modify the SLPC selftest to update the min frequency when we have a server part so that we

Re: [PATCH v5 22/22] drm/sun4i: tv: Convert to the new TV mode property

2022-10-13 Thread Jernej Škrabec
Hi Maxime, Dne četrtek, 13. oktober 2022 ob 15:19:06 CEST je Maxime Ripard napisal(a): > Now that the core can deal fine with analog TV modes, let's convert the > sun4i TV driver to leverage those new features. > > Acked-by: Noralf Trønnes > Signed-off-by: Maxime Ripard > > --- > Changes in v5

[PATCH] drm/amd/display: Increase frame size limit for display_mode_vba_util_32.o

2022-10-13 Thread Guenter Roeck
Building 32-bit images may fail with the following error. drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_util_32.c: In function ‘dml32_UseMinimumDCFCLK’: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_util_32.c:3142:1: error: the frame size

Re: [PATCH 01/15] drm/i915/hdmi: do dual mode detect only if connected

2022-10-13 Thread Ville Syrjälä
On Tue, Oct 11, 2022 at 04:49:35PM +0300, Jani Nikula wrote: > For normal connector detect, there's really no point in trying dual mode > detect if the connector is disconnected. We can simplify the detect > sequence by skipping it. Since intel_hdmi_dp_dual_mode_detect() is only > called when EDID

Re: [PATCH v4 1/2] dt-bindings: it6505: add properties to restrict output bandwidth

2022-10-13 Thread Rob Herring
On Thu, Oct 13, 2022 at 02:05:45PM +0300, Laurent Pinchart wrote: > Hi Allen, > > Thank you for the patch. > > On Thu, Oct 13, 2022 at 06:51:13PM +0800, allen wrote: > > From: allen chen > > > > Add properties to restrict dp output data-lanes and clock. > > > > Signed-off-by: Pin-Yen Lin > >

Re: [PATCH 01/15] drm/i915/hdmi: do dual mode detect only if connected

2022-10-13 Thread Ville Syrjälä
On Thu, Oct 13, 2022 at 09:41:21PM +0300, Ville Syrjälä wrote: > On Tue, Oct 11, 2022 at 04:49:35PM +0300, Jani Nikula wrote: > > For normal connector detect, there's really no point in trying dual mode > > detect if the connector is disconnected. We can simplify the detect > > sequence by skipping

[Bug 216119] 087451f372bf76d breaks hibernation on amdgpu Radeon R9 390

2022-10-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216119 --- Comment #40 from Harald Judt (h.j...@gmx.at) --- Any updates on this? Hibernate/resume is still borked after a few cycles (rather sooner than later) and it gets harder and harder to revert these fb patches on newer kernels. The prefer_shadow p

[PATCH v4] drm/mediatek: Add AFBC support to Mediatek DRM driver

2022-10-13 Thread Justin Green
Tested on MT8195 and confirmed both correct video output and improved DRAM bandwidth performance. v4: * Move modifier validation to format_mod_supported function. * Add modifiers to drm_universal_plane_init() call. * Make comparisons to DRM_FORMAT_MOD_LINEAR explicit rather than relying on DRM_F

Re: [PATCH AUTOSEL 6.0 16/44] drm: hide unregistered connectors from GETCONNECTOR IOCTL

2022-10-13 Thread Simon Ser
Jonas has reported that this breaks Mutter. Sasha, can we remove this from the stable queue?

[PATCH v3] drm/i915/huc: bump timeout for delayed load and reduce print verbosity

2022-10-13 Thread Daniele Ceraolo Spurio
We're observing sporadic HuC delayed load timeouts in CI, due to mei_pxp binding completing later than we expected. HuC is still loaded when the bind occurs, but in the meantime i915 has started allowing submission to the VCS engines even if HuC is not there. In most of the cases I've observed, the

[Bug 216119] 087451f372bf76d breaks hibernation on amdgpu Radeon R9 390

2022-10-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216119 --- Comment #41 from Alex Deucher (alexdeuc...@gmail.com) --- Does setting amdgpu.dc=0 make any difference? -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.

[PATCH v2] drm/i915: Fix CFI violations in gt_sysfs

2022-10-13 Thread Nathan Chancellor
When booting with CONFIG_CFI_CLANG, there are numerous violations when accessing the files under /sys/devices/pci:00/:00:02.0/drm/card0/gt/gt0: $ cd /sys/devices/pci:00/:00:02.0/drm/card0/gt/gt0 $ grep . * id:0 punit_req_freq_mhz:350 rc6_enable:1 rc6_residency_ms:21493

[PATCH] drm/radeon: Replace kmap() with kmap_local_page()

2022-10-13 Thread Fabio M. De Francesco
The use of kmap() is being deprecated in favor of kmap_local_page(). There are two main problems with kmap(): (1) It comes with an overhead as the mapping space is restricted and protected by a global lock for synchronization and (2) it also requires global TLB invalidation when the kmap’s pool wr

[PATCH] MAINTAINERS: git://github -> https://github.com for patjak

2022-10-13 Thread Palmer Dabbelt
Github deprecated the git:// links about a year ago, so let's move to the https:// URLs instead. Reported-by: Conor Dooley Link: https://github.blog/2021-09-01-improving-git-protocol-security-github/ Signed-off-by: Palmer Dabbelt --- I've split these up by github username so folks can take them

[PATCH] drm/gma500: Fix spelling mistake "patter" -> "pattern"

2022-10-13 Thread Colin Ian King
There is a spelling mistake in a DRM_DEBUG_KMS message. Fix it. Also clean checkpatch warning on the overly long line and remove braces as the if statement is just one statement. Signed-off-by: Colin Ian King --- drivers/gpu/drm/gma500/cdv_intel_dp.c | 6 +++--- 1 file changed, 3 insertions(+),

Re: [PATCH v2] drm/i915/slpc: Use platform limits for min/max frequency

2022-10-13 Thread Dixit, Ashutosh
On Thu, 13 Oct 2022 08:55:24 -0700, Vinay Belgaumkar wrote: > Hi Vinay, > GuC will set the min/max frequencies to theoretical max on > ATS-M. This will break kernel ABI, so limit min/max frequency > to RP0(platform max) instead. Isn't what we are calling "theoretical max" or "RPmax" really just

[PATCH 0/3] drm/msm/a6xx: devcore dump fixes

2022-10-13 Thread Rob Clark
From: Rob Clark First patch fixes a recently introduced memory corruption, the remaining two are cleanups. Rob Clark (3): drm/msm/a6xx: Fix kvzalloc vs state_kcalloc usage drm/msm/a6xx: Skip snapshotting unused GMU buffers drm/msm/a6xx: Remove state objects from list before freeing drive

[PATCH 2/3] drm/msm/a6xx: Skip snapshotting unused GMU buffers

2022-10-13 Thread Rob Clark
From: Rob Clark Some buffers are unused on certain sub-generations of a6xx. So just skip them. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c b/drivers/gpu/drm/msm/adr

[PATCH 3/3] drm/msm/a6xx: Remove state objects from list before freeing

2022-10-13 Thread Rob Clark
From: Rob Clark Technically it worked as it was before, only because it was using the _safe version of the iterator. But it is sloppy practice to leave dangling pointers. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 4 +++- 1 file changed, 3 insertions(+), 1 dele

[PATCH 1/3] drm/msm/a6xx: Fix kvzalloc vs state_kcalloc usage

2022-10-13 Thread Rob Clark
From: Rob Clark adreno_show_object() is a trap! It will re-allocate the pointer it is passed on first call, when the data is ascii85 encoded, using kvmalloc/ kvfree(). Which means the data *passed* to it must be kvmalloc'd, ie. we cannot use the state_kcalloc() helper. This partially reverts e

Re: [PATCH drm-misc-next v3 4/7] drm/arm/hdlcd: use drm_dev_unplug()

2022-10-13 Thread Danilo Krummrich
Hi Liviu, On 10/12/22 17:07, Liviu Dudau wrote: Hi Danilo, Appologies again for the delay in reviewing this as I was at XDC last week. No worries, thanks for following up. Looking at the documentation for drm_dev_unplug, you can get a hint about what is going on: /* * [] There is

Re: [Freedreno] [PATCH 0/3] drm/msm/a6xx: devcore dump fixes

2022-10-13 Thread Chia-I Wu
On Thu, Oct 13, 2022 at 3:55 PM Rob Clark wrote: > > From: Rob Clark > > First patch fixes a recently introduced memory corruption, the remaining > two are cleanups. Series is Reviewed-by: Chia-I Wu > Rob Clark (3): > drm/msm/a6xx: Fix kvzalloc vs state_kcalloc usage > drm/msm/a6xx: Skip s

Re: [PATCH v2] drm/i915/slpc: Use platform limits for min/max frequency

2022-10-13 Thread Belgaumkar, Vinay
On 10/13/2022 3:28 PM, Dixit, Ashutosh wrote: On Thu, 13 Oct 2022 08:55:24 -0700, Vinay Belgaumkar wrote: Hi Vinay, GuC will set the min/max frequencies to theoretical max on ATS-M. This will break kernel ABI, so limit min/max frequency to RP0(platform max) instead. Isn't what we are calling

[git pull] drm fixes for 6.1-rc1

2022-10-13 Thread Dave Airlie
Hi Linus, Round of fixes for the merge window stuff, bunch of amdgpu and i915 changes, this should have the gcc11 warning fix, amongst other changes. Dave. drm-next-2022-10-14: drm fixes for 6.1-rc1 amdgpu: - DC mutex fix - DC SubVP fixes - DCN 3.2.x fixes - DCN 3.1.x fixes - SDMA 6.x fixes - E

[Bug 216583] New: [AMDGPU] Black screen after resume + Failed to pin framebuffer -19

2022-10-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216583 Bug ID: 216583 Summary: [AMDGPU] Black screen after resume + Failed to pin framebuffer -19 Product: Drivers Version: 2.5 Kernel Version: 6.0.1 Hardware: All

[Bug 216583] [AMDGPU] Black screen after resume + Failed to pin framebuffer -19

2022-10-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216583 Paulo Marcos de Souza Arruda do Nascimento (contato-mygh...@protonmail.com) changed: What|Removed |Added Hardware|All

Re: [PATCH] drm/radeon: Replace kmap() with kmap_local_page()

2022-10-13 Thread Kees Cook
On Thu, Oct 13, 2022 at 11:07:14PM +0200, Fabio M. De Francesco wrote: > The use of kmap() is being deprecated in favor of kmap_local_page(). > > There are two main problems with kmap(): (1) It comes with an overhead as > the mapping space is restricted and protected by a global lock for > synchro

[PATCH v2] drm/omapdrm: Remove unused struct csc_coef_rgb2yuv

2022-10-13 Thread Yuan Can
After commit 64ff18911878, struct csc_coef_rgb2yuv is not used any more and can be removed as well. Fixes: 64ff18911878 ("drm/omap: Enable COLOR_ENCODING and COLOR_RANGE properties for planes") Signed-off-by: Yuan Can --- changes in v2: - adjust commit msg --- drivers/gpu/drm/omapdrm/dss/dispc.

RE: [PATCH v4 1/2] dt-bindings: it6505: add properties to restrict output bandwidth

2022-10-13 Thread allen.chen
Hi -Original Message- From: Rob Herring Sent: Friday, October 14, 2022 3:20 AM To: Laurent Pinchart ; Allen Chen (陳柏宇) Cc: Pin-yen Lin ; Jau-Chih Tseng (曾昭智) ; Kenneth Hung (洪家倫) ; Hermes Wu (吳佳宏) ; Andrzej Hajda ; Neil Armstrong ; Robert Foss ; Jonas Karlman ; Jernej Skrabec ; Da

Re: [git pull] drm fixes for 6.1-rc1

2022-10-13 Thread Linus Torvalds
On Thu, Oct 13, 2022 at 5:29 PM Dave Airlie wrote: > > Round of fixes for the merge window stuff, bunch of amdgpu and i915 > changes, this should have the gcc11 warning fix, amongst other > changes. Some of those amd changes aren't "fixes". They are some major code changes. We're still in the me

Re: [git pull] drm fixes for 6.1-rc1

2022-10-13 Thread pr-tracker-bot
The pull request you sent on Fri, 14 Oct 2022 10:29:19 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-next-2022-10-14 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/9c9155a3509a2ebdb06d77c7a621e9685c802eac Thank you! -- Deet-doot-dot, I am a bot. https://ko

Re: [PATCH v3 06/17] drm/i915/vm_bind: Support for VM private BOs

2022-10-13 Thread Niranjana Vishwanathapura
On Tue, Oct 11, 2022 at 06:41:23PM +0100, Matthew Auld wrote: On 11/10/2022 17:27, Matthew Auld wrote: On 10/10/2022 07:58, Niranjana Vishwanathapura wrote: Each VM creates a root_obj and shares it with all of its private objects to use it as dma_resv object. This has a performance advantage as

Re: [Intel-gfx] [PATCH v3 09/17] drm/i915/vm_bind: Add out fence support

2022-10-13 Thread Niranjana Vishwanathapura
On Sun, Oct 09, 2022 at 11:58:18PM -0700, Niranjana Vishwanathapura wrote: Add support for handling out fence for vm_bind call. v2: Reset vma->vm_bind_fence.syncobj to NULL at the end of vm_bind call. Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti --- drivers/gpu/drm/i9

Re: [PATCH 0/3] drm/msm/a6xx: devcore dump fixes

2022-10-13 Thread Akhil P Oommen
On 10/14/2022 4:25 AM, Rob Clark wrote: From: Rob Clark First patch fixes a recently introduced memory corruption, the remaining two are cleanups. Rob Clark (3): drm/msm/a6xx: Fix kvzalloc vs state_kcalloc usage drm/msm/a6xx: Skip snapshotting unused GMU buffers drm/msm/a6xx: Remove s

<    1   2