[PATCH v3 06/17] drm/i915/vm_bind: Support for VM private BOs

2022-10-10 Thread Niranjana Vishwanathapura
Each VM creates a root_obj and shares it with all of its private objects to use it as dma_resv object. This has a performance advantage as it requires a single dma_resv object update for all private BOs vs list of dma_resv objects update for shared BOs, in the execbuf path. VM private BOs can be o

[PATCH v3 05/17] drm/i915/vm_bind: Implement bind and unbind of object

2022-10-10 Thread Niranjana Vishwanathapura
Add uapi and implement support for bind and unbind of an object at the specified GPU virtual addresses. The vm_bind mode is not supported in legacy execbuf2 ioctl. It will be supported only in the newer execbuf3 ioctl. v2: On older platforms ctx->vm is not set, check for it. In vm_bind call,

[PATCH v3 04/17] drm/i915/vm_bind: Add support to create persistent vma

2022-10-10 Thread Niranjana Vishwanathapura
Add i915_vma_instance_persistent() to create persistent vmas. Persistent vmas will use i915_gtt_view to support partial binding. vma_lookup is tied to segment of the object instead of section of VA space. Hence, it do not support aliasing. ie., multiple mappings (at different VA) point to the same

[PATCH v3 16/17] drm/i915/vm_bind: userptr dma-resv changes

2022-10-10 Thread Niranjana Vishwanathapura
For persistent (vm_bind) vmas of userptr BOs, handle the user page pinning by using the i915_gem_object_userptr_submit_init() /done() functions v2: Do not double add vma to vm->userptr_invalidated_list Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti --- .../gpu/drm/i915/gem/

[PATCH v3 14/17] drm/i915/vm_bind: Expose i915_request_await_bind()

2022-10-10 Thread Niranjana Vishwanathapura
Rename __i915_request_await_bind() as i915_request_await_bind() and make it non-static as it will be used in execbuf3 ioctl path. Reviewed-by: Andi Shyti Signed-off-by: Niranjana Vishwanathapura --- drivers/gpu/drm/i915/i915_vma.c | 8 +--- drivers/gpu/drm/i915/i915_vma.h | 6 ++ 2 file

[PATCH v3 08/17] drm/i915/vm_bind: Support persistent vma activeness tracking

2022-10-10 Thread Niranjana Vishwanathapura
Do not use i915_vma activeness tracking for persistent vmas. As persistent vmas are part of working set for each execbuf submission on that address space (VM), a persistent vma is active if the VM active. As vm->root_obj->base.resv will be updated for each submission on that VM, it correctly repre

[PATCH v3 17/17] drm/i915/vm_bind: Add uapi for user to enable vm_bind_mode

2022-10-10 Thread Niranjana Vishwanathapura
Add getparam support for VM_BIND capability version. Add VM creation time flag to enable vm_bind_mode for the VM. v2: update kernel-doc v3: create vm->root_obj only upon I915_VM_CREATE_FLAGS_USE_VM_BIND Acked-by: Matthew Auld Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti -

[PATCH v3 07/17] drm/i915/vm_bind: Add support to handle object evictions

2022-10-10 Thread Niranjana Vishwanathapura
Support eviction by maintaining a list of evicted persistent vmas for rebinding during next submission. Ensure the list do not include persistent vmas that are being purged. v2: Remove unused I915_VMA_PURGED definition. v3: Properly handle __i915_vma_unbind_async() case. Acked-by: Matthew Auld S

[PATCH v3 15/17] drm/i915/vm_bind: Handle persistent vmas in execbuf3

2022-10-10 Thread Niranjana Vishwanathapura
Handle persistent (VM_BIND) mappings during the request submission in the execbuf3 path. v2: Ensure requests wait for bindings to complete. v3: Remove short term pinning with PIN_VALIDATE flag. Individualize fences before adding to dma_resv obj. Signed-off-by: Niranjana Vishwanathapura Signe

[PATCH v3 11/17] drm/i915/vm_bind: Use common execbuf functions in execbuf path

2022-10-10 Thread Niranjana Vishwanathapura
Update the execbuf path to use common execbuf functions to reduce code duplication with the newer execbuf3 path. Acked-by: Matthew Auld Signed-off-by: Niranjana Vishwanathapura --- .../gpu/drm/i915/gem/i915_gem_execbuffer.c| 507 ++ 1 file changed, 38 insertions(+), 469 dele

[PATCH v3 13/17] drm/i915/vm_bind: Update i915_vma_verify_bind_complete()

2022-10-10 Thread Niranjana Vishwanathapura
Ensure i915_vma_verify_bind_complete() handles case where bind is not initiated. Also make it non static, add documentation and move it out of CONFIG_DRM_I915_DEBUG_GEM. Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/i915_vma.c | 16 +++-

[PATCH v3 10/17] drm/i915/vm_bind: Abstract out common execbuf functions

2022-10-10 Thread Niranjana Vishwanathapura
The new execbuf3 ioctl path and the legacy execbuf ioctl paths have many common functionalities. Abstract out the common execbuf functionalities into a separate file where possible, thus allowing code sharing. Reviewed-by: Andi Shyti Acked-by: Matthew Auld Signed-off-by: Niranjana Vishwanathapur

[PATCH v3 03/17] drm/i915/vm_bind: Expose i915_gem_object_max_page_size()

2022-10-10 Thread Niranjana Vishwanathapura
Expose i915_gem_object_max_page_size() function non-static which will be used by the vm_bind feature. Acked-by: Matthew Auld Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gem/i915_gem_create.c | 18 +- drivers/gpu/drm/i915/gem/i915_

[PATCH v3 12/17] drm/i915/vm_bind: Implement I915_GEM_EXECBUFFER3 ioctl

2022-10-10 Thread Niranjana Vishwanathapura
Implement new execbuf3 ioctl (I915_GEM_EXECBUFFER3) which only works in vm_bind mode. The vm_bind mode only works with this new execbuf3 ioctl. The new execbuf3 ioctl will not have any list of objects to validate bind as all required objects binding would have been requested by the userspace befor

[PATCH v3 09/17] drm/i915/vm_bind: Add out fence support

2022-10-10 Thread Niranjana Vishwanathapura
Add support for handling out fence for vm_bind call. v2: Reset vma->vm_bind_fence.syncobj to NULL at the end of vm_bind call. Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gem/i915_gem_vm_bind.h | 4 + .../drm/i915/gem/i915_gem_vm_bind_objec

[PATCH -next] drm/amd/display: Simplify bool conversion

2022-10-10 Thread Yang Li
The result of 'pwr_status == 0' is Boolean, and the question mark expression is redundant. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2354 Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c | 2 +- 1 file changed, 1 insertion(+), 1 d

Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix display problems after resume

2022-10-10 Thread Andrzej Hajda
On 05.10.2022 14:11, Thomas Hellström wrote: Commit 39a2bd34c933 ("drm/i915: Use the vma resource as argument for gtt binding / unbinding") introduced a regression that due to the vma resource tracking of the binding state, dpt ptes were not correctly repopulated. Fix this by clearing the vma res

Re: [PATCH] drm/i915/gem: remove redundant assignments to variable ret

2022-10-10 Thread Tvrtko Ursulin
On 07/10/2022 20:47, Colin Ian King wrote: The variable ret is being assigned with a value that is never read both before and after a while-loop. The variable is being re-assigned inside the while-loop and afterwards on the call to the function i915_gem_object_lock_interruptible. Remove the red

Re: [PATCH v2 4/7] drm/simpledrm: Add support for system memory framebuffers

2022-10-10 Thread Thomas Zimmermann
Hi Am 07.10.22 um 14:49 schrieb Thierry Reding: From: Thierry Reding Simple framebuffers can be set up in system memory, which cannot be requested and/or I/O remapped using the I/O resource helpers. Add a separate code path that obtains system memory framebuffers from the reserved memory regio

Re: [PATCH] drm/i915/perf: remove redundant variable 'taken'

2022-10-10 Thread Tvrtko Ursulin
On 08/10/2022 12:55, Christophe JAILLET wrote: Le 07/10/2022 à 21:53, Colin Ian King a écrit : The assignment to variable taken is redundant and so it can be removed as well as the variable too. Cleans up clang-scan build warnings: warning: Although the value stored to 'taken' is used in the

Re: [RFC PATCH] drm/syncobj: add IOCTL to register an eventfd for a timeline

2022-10-10 Thread Pekka Paalanen
On Sun, 09 Oct 2022 14:40:14 + Simon Ser wrote: > Introduce a new DRM_IOCTL_SYNCOBJ_TIMELINE_REGISTER_EVENTFD IOCTL > which signals an eventfd when a timeline point completes. > > This is useful for Wayland compositors to handle wait-before-submit. > Wayland clients can send a timeline point

Re: [PATCH 0/2] drm/vc4: hdmi: Fixes for the RaspberryPi 0-3 stalls

2022-10-10 Thread Maxime Ripard
Hi Mark, Stefan, On Thu, Sep 29, 2022 at 11:21:16AM +0200, Maxime Ripard wrote: > Here's a series addressing the current bug that has been reported for the > RaspberryPi3, where booting without an HDMI monitor attached and with vc4 > compiled as a module will lead to a stuck system when the module

Re: [RFC PATCH] drm/syncobj: add IOCTL to register an eventfd for a timeline

2022-10-10 Thread Simon Ser
On Sunday, October 9th, 2022 at 20:00, Christian König wrote: > Am 09.10.22 um 16:40 schrieb Simon Ser: > > > Introduce a new DRM_IOCTL_SYNCOBJ_TIMELINE_REGISTER_EVENTFD IOCTL > > which signals an eventfd when a timeline point completes. > > I was entertaining the same though for quite a while

Re: [RFC PATCH] drm/syncobj: add IOCTL to register an eventfd for a timeline

2022-10-10 Thread Simon Ser
On Monday, October 10th, 2022 at 10:19, Pekka Paalanen wrote: > I'm completely clueless about this API. No worries! > > +/** > > + * struct drm_syncobj_timeline_register_eventfd > > + * > > + * Register an eventfd to be signalled when a timeline point completes. The > > + * eventfd counter wil

Re: [PATCH v2 1/7] dt-bindings: display: simple-framebuffer: Support system memory framebuffers

2022-10-10 Thread Thomas Zimmermann
Hi Am 07.10.22 um 14:49 schrieb Thierry Reding: From: Thierry Reding In order to support framebuffers residing in system memory, allow the memory-region property to override the framebuffer memory specification in the "reg" property. What happens if both properties are present and they disag

[PATCH 1/8] drm/ast: Acquire I/O-register lock in atomic_commit_tail function

2022-10-10 Thread Thomas Zimmermann
Hold I/O-register lock in atomic_commit_tail to protect all pipeline updates at once. Protects modesetting against concurrent EDID reads. Complex modesetting operations involve mode changes and plane updates. These steps used to be protected individually against concurrent I/O. Make all this atomi

[PATCH 2/8] drm/ast: Call drm_atomic_helper_check_plane_state() unconditionally

2022-10-10 Thread Thomas Zimmermann
Always call drm_atomic_helper_check_plane_state() in each plane's atomic_check function. At the minimum, it needs to set or clear the plane state's 'visible' field. Otherwise the plane-state handling is bogus and would keep updating planes that have been disabled. While at it, also warn if the pri

[PATCH 0/8] drm/ast: Convert ast driver to SHMEM

2022-10-10 Thread Thomas Zimmermann
This patchset converts ast to GEM SHMEM helpers. Fixes problems with memory allocation and BMC scanout updates. Patches 1 to 3 are fixes for various minor problems in the ast driver. We should merge them even without SHMEM support. Patches 4 to 6 prepare the driver for the conversion. The cursor

[PATCH 4/8] drm/ast: Remove cursor double buffering

2022-10-10 Thread Thomas Zimmermann
Update the cursor image via damage handling in-place. The cursor's double buffering has no visible effect on the output, so remove it. Done in preparation of switching ast to GEM SHMEM helpers. Removing double buffering will allow us to use the same data structure for primary and cursor plane. Si

[PATCH 3/8] drm/ast: Do not call drm_atomic_add_affected_planes()

2022-10-10 Thread Thomas Zimmermann
There's no need to add planes to the atomic state. Remove the call to drm_atomic_add_affected_planes() from ast. On full modesets, the DRM helpers already add a CRTC's planes to the atomic state; see drm_atomic_helper_check_modeset(). There's no reason to call drm_atomic_add_affected_planes() unco

[PATCH 8/8] drm/ast: Avoid reprogramming primary-plane scanout address

2022-10-10 Thread Thomas Zimmermann
Some AST-based BMCs stop display output for up to 5 seconds after reprogramming the scanout address. As the address is fixed, avoid re-setting the address' value. Reported-by: Jocelyn Falempe Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_mode.c | 12 ++-- 1 file changed,

[PATCH 5/8] drm/ast: Rename struct ast_cursor_plane to struct ast_plane

2022-10-10 Thread Thomas Zimmermann
Rename the plane structure struct ast_cursor_plane to struct ast_plane as it will be used for the primary plane as well. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_drv.h | 15 +-- drivers/gpu/drm/ast/ast_mode.c | 22 +++--- 2

[PATCH 6/8] drm/ast: Style cleanups in plane code

2022-10-10 Thread Thomas Zimmermann
Rename some of the variables in the plane code to better reflect the old and new state during checks and updates. Change some indention as well. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_mode.c | 104 ++--- 1 file changed, 45

Re: [PATCH v2 0/7] drm/vc4: Fix the core clock behaviour

2022-10-10 Thread Maxime Ripard
Hi Florian, On Tue, Sep 20, 2022 at 02:50:19PM +0200, Maxime Ripard wrote: > Those patches used to be part of a larger clock fixes series: > https://lore.kernel.org/linux-clk/20220715160014.2623107-1-max...@cerno.tech/ > > However, that series doesn't seem to be getting anywhere, so I've split ou

Re: (subset) [PATCH v4 02/30] drm/tests: Order Kunit tests in Makefile

2022-10-10 Thread Maxime Ripard
On Thu, 29 Sep 2022 18:30:56 +0200, Maxime Ripard wrote: > Since we've recently added a ton of tests, the list starts to be a bit > of a mess and creates unneeded conflicts. > > Let's order it alphabetically. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: (subset) [PATCH v4 04/30] drm/atomic-helper: Rename drm_atomic_helper_connector_tv_reset to avoid ambiguity

2022-10-10 Thread Maxime Ripard
On Thu, 29 Sep 2022 18:30:58 +0200, Maxime Ripard wrote: > We currently have two sets of TV properties. > > The first one is there to deal with analog TV properties, creating > properties such as the TV mode, subconnectors, saturation, hue and so on. > It's created by calling the drm_mode_create_t

Re: (subset) [PATCH v4 06/30] drm/atomic: Add TV subconnector property to get/set_property

2022-10-10 Thread Maxime Ripard
On Thu, 29 Sep 2022 18:31:00 +0200, Maxime Ripard wrote: > The subconnector property was created by drm_mode_create_tv_properties(), > but wasn't exposed to the userspace through the generic > atomic_get/set_property implementation, and wasn't stored in any generic > state structure. > > Let's sol

Re: (subset) [PATCH v4 12/30] drm/modes: Only consider bpp and refresh before options

2022-10-10 Thread Maxime Ripard
On Thu, 29 Sep 2022 18:31:06 +0200, Maxime Ripard wrote: > Some video= options might have a value that contains a dash. However, the > command line parsing mode considers all dashes as the separator between the > mode and the bpp count. > > Let's rework the parsing code a bit to only consider a da

Re: (subset) [PATCH v4 05/30] drm/connector: Rename subconnector state variable

2022-10-10 Thread Maxime Ripard
On Thu, 29 Sep 2022 18:30:59 +0200, Maxime Ripard wrote: > There is two TV subconnector related properties registered by > drm_mode_create_tv_properties(): subconnector and select subconnector. > > While the select subconnector property is stored in the kernel by the > drm_tv_connector_state struc

Re: (subset) [PATCH v4 13/30] drm/modes: parse_cmdline: Add support for named modes containing dashes

2022-10-10 Thread Maxime Ripard
On Thu, 29 Sep 2022 18:31:07 +0200, Maxime Ripard wrote: > From: Geert Uytterhoeven > > It is fairly common for named video modes to contain dashes (e.g. > "tt-mid" on Atari, "dblntsc-ff" on Amiga). Currently such mode names > are not recognized, as the dash is considered to be a separator betwe

Re: (subset) [PATCH v4 25/30] drm/vc4: vec: Fix definition of PAL-M mode

2022-10-10 Thread Maxime Ripard
On Thu, 29 Sep 2022 18:31:19 +0200, Maxime Ripard wrote: > From: Mateusz Kwiatkowski > > PAL-M is a Brazilian analog TV standard that uses a PAL-style chroma > subcarrier at 3.575611[888111] MHz on top of 525-line (480i60) timings. > This commit makes the driver actually use the proper VEC preset

Re: [PATCH v4 00/30] drm: Analog TV Improvements

2022-10-10 Thread Maxime Ripard
On Sat, Oct 01, 2022 at 03:12:06PM +0200, Noralf Trønnes wrote: > > > Den 29.09.2022 18.30, skrev Maxime Ripard: > > Hi, > > > > Here's a series aiming at improving the command line named modes support, > > and more importantly how we deal with all the analog TV variants. > > > > The named mode

Re: [PATCH] drm/bridge: tc358775: Do not soft reset i2c-slave controller

2022-10-10 Thread Robert Foss
Applied to drm-misc-next.

Re: [PATCH v3 07/17] drm/i915/vm_bind: Add support to handle object evictions

2022-10-10 Thread Matthew Auld
On 10/10/2022 07:58, Niranjana Vishwanathapura wrote: Support eviction by maintaining a list of evicted persistent vmas for rebinding during next submission. Ensure the list do not include persistent vmas that are being purged. v2: Remove unused I915_VMA_PURGED definition. v3: Properly handle __

Re: Difference GART/GTT and related questions

2022-10-10 Thread Alex Deucher
On Sat, Oct 8, 2022 at 7:14 AM Peter Maucher wrote: > > Hi dri-devel, > > what is the difference between GTT and GART for AMD GPUs? > From what I gathered when looking through the mailing list archives and > the freedesktop docs [1] as well as wikipedia [2], > these terms seem to be synonymous, b

[RESEND PATCH v2] drm/mediatek: Add AFBC support to Mediatek DRM driver

2022-10-10 Thread Justin Green
From: Justin Green Add AFBC support to Mediatek DRM driver and enable on MT8195. Tested on MT8195 and confirmed both correct video output and improved DRAM bandwidth performance. v2: Marked mtk_ovl_set_afbc as static, reflowed some lines to fit column limit. Signed-off-by: Justin Green --- d

Re: [PATCH v3 07/17] drm/i915/vm_bind: Add support to handle object evictions

2022-10-10 Thread Niranjana Vishwanathapura
On Mon, Oct 10, 2022 at 02:30:49PM +0100, Matthew Auld wrote: On 10/10/2022 07:58, Niranjana Vishwanathapura wrote: Support eviction by maintaining a list of evicted persistent vmas for rebinding during next submission. Ensure the list do not include persistent vmas that are being purged. v2: R

Re: [PATCH 0/2] drm/vc4: hdmi: Fixes for the RaspberryPi 0-3 stalls

2022-10-10 Thread Stefan Wahren
Am 10.10.22 um 10:50 schrieb Maxime Ripard: Hi Mark, Stefan, On Thu, Sep 29, 2022 at 11:21:16AM +0200, Maxime Ripard wrote: Here's a series addressing the current bug that has been reported for the RaspberryPi3, where booting without an HDMI monitor attached and with vc4 compiled as a module wi

Re: [PATCH v2 3/7] firmware: raspberrypi: Provide a helper to query a clock max rate

2022-10-10 Thread Stefan Wahren
Hi Maxime, Am 20.09.22 um 14:50 schrieb Maxime Ripard: The firmware allows to query for its clocks the operating range of a given clock. We'll need this for some drivers (KMS, in particular) to infer the state of some configuration options, so let's create a function to do so. Signed-off-by: Ma

[PATCH 0/3] Add a drm_crtc_helper_atomic_check() helper

2022-10-10 Thread Javier Martinez Canillas
Add a helper function and make drivers that have the same logic in their struct drm_crtc_helper_funcs .atomic_check handler to use this instead. Patch #1 and #2 are just cleanups for the simpledrm and ssd130x drivers respectively, so that these can be converted to use the helper added by patch #3.

[PATCH 2/3] drm/ssd130x: Do not call drm_atomic_add_affected_planes()

2022-10-10 Thread Javier Martinez Canillas
There's no need to add planes to the atomic state. Remove the call to drm_atomic_add_affected_planes() from ssd130x. On full modesets, the DRM helpers already add a CRTC's planes to the atomic state; see drm_atomic_helper_check_modeset(). There's no reason to call drm_atomic_add_affected_planes()

[PATCH 1/3] drm/simpledrm: Do not call drm_atomic_add_affected_planes()

2022-10-10 Thread Javier Martinez Canillas
There's no need to add planes to the atomic state. Remove the call to drm_atomic_add_affected_planes() from simpledrm. On full modesets, the DRM helpers already add a CRTC's planes to the atomic state; see drm_atomic_helper_check_modeset(). There's no reason to call drm_atomic_add_affected_planes(

[PATCH 3/3] drm/crtc-helper: Add a drm_crtc_helper_atomic_check() helper

2022-10-10 Thread Javier Martinez Canillas
Provides a default CRTC state check handler for CRTCs that only have one primary plane attached. There are some drivers that duplicate this logic in their helpers, such as simpledrm and ssd130x. Factor out this common code into a CRTC helper and make drivers use it. Signed-off-by: Javier Martinez

Re: [PATCH 3/8] drm/ast: Do not call drm_atomic_add_affected_planes()

2022-10-10 Thread Javier Martinez Canillas
Hello Thomas, On 10/10/22 12:36, Thomas Zimmermann wrote: > There's no need to add planes to the atomic state. Remove the call > to drm_atomic_add_affected_planes() from ast. > > On full modesets, the DRM helpers already add a CRTC's planes to the > atomic state; see drm_atomic_helper_check_modes

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915/slpc: Update the frequency debugfs

2022-10-10 Thread Rodrigo Vivi
On Thu, Oct 06, 2022 at 05:24:34PM -0400, Rodrigo Vivi wrote: > On Wed, Oct 05, 2022 at 08:59:43AM -0700, Vinay Belgaumkar wrote: > > Read the values stored in the SLPC structures. Remove the > > fields that are no longer valid (like RPS interrupts) as > > well. > > > > v2: Move all functionality

Re: [PATCH v3 07/17] drm/i915/vm_bind: Add support to handle object evictions

2022-10-10 Thread Matthew Auld
On 10/10/2022 17:11, Niranjana Vishwanathapura wrote: On Mon, Oct 10, 2022 at 02:30:49PM +0100, Matthew Auld wrote: On 10/10/2022 07:58, Niranjana Vishwanathapura wrote: Support eviction by maintaining a list of evicted persistent vmas for rebinding during next submission. Ensure the list do no

[linux-next:master] BUILD REGRESSION cd9fd78f5c11b5e165d9317ef11e613f4aef4dd1

2022-10-10 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: cd9fd78f5c11b5e165d9317ef11e613f4aef4dd1 Add linux-next specific files for 20221010 Error/Warning reports: https://lore.kernel.org/linux-doc/202209201326.sy9kholm-...@intel.com https

[Bug 213145] AMDGPU resets, timesout and crashes after "*ERROR* Waiting for fences timed out!"

2022-10-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213145 --- Comment #24 from rv1sr (vyoepdeygrbbs...@stefan.wf) --- Do you guys by any chance use KWin? Had experienced this exact issue on a daily basis (kernel 5.19 + amdgpu), especially while running Firefox or Vivaldi. After setting the following en

[PATCH v2] drm/i915/huc: bump timeout for delayed load and reduce print verbosity

2022-10-10 Thread Daniele Ceraolo Spurio
We're observing sporadic HuC delayed load timeouts in CI, due to mei_pxp binding completing later than we expected. HuC is still loaded when the bind occurs, but in the meantime i915 has started allowing submission to the VCS engines even if HuC is not there. In most of the cases I've observed, the

Re: [PATCH v6 10/21] RDMA/umem: Prepare to dynamic dma-buf locking specification

2022-10-10 Thread Jason Gunthorpe
On Sun, Oct 09, 2022 at 03:08:56AM +0300, Dmitry Osipenko wrote: > On 9/28/22 22:15, Dmitry Osipenko wrote: > > Prepare InfiniBand drivers to the common dynamic dma-buf locking > > convention by starting to use the unlocked versions of dma-buf API > > functions. > > > > Acked-by: Christian König

Re: [PATCH v2 0/7] drm/vc4: Fix the core clock behaviour

2022-10-10 Thread Florian Fainelli
On 10/10/22 04:44, Maxime Ripard wrote: Hi Florian, On Tue, Sep 20, 2022 at 02:50:19PM +0200, Maxime Ripard wrote: Those patches used to be part of a larger clock fixes series: https://lore.kernel.org/linux-clk/20220715160014.2623107-1-max...@cerno.tech/ However, that series doesn't seem to be

Re: [PATCH 3/7] drm/i915/uc: use different ggtt pin offsets for uc loads

2022-10-10 Thread John Harrison
On 9/30/2022 16:42, Ceraolo Spurio, Daniele wrote: On 9/30/2022 4:24 PM, John Harrison wrote: On 9/22/2022 15:11, Daniele Ceraolo Spurio wrote: Our current FW loading process is the same for all FWs: - Pin FW to GGTT at the start of the ggtt->uc_fw node - Load the FW - Unpin This worked becau

Re: [PATCH] drm/amd/display: fix array-bounds error in dc_stream_remove_writeback() [take 2]

2022-10-10 Thread Alex Deucher
Applied. Thanks. Alex On Mon, Oct 10, 2022 at 2:05 AM Guenter Roeck wrote: > > Commit 5d8c3e836fc2 ("drm/amd/display: fix array-bounds error in > dc_stream_remove_writeback()") tried to fix an array bounds error seen > with gcc 12.0. Unfortunately, that results in another array bounds error, >

Re: [RFC/PATCH] backlight: hx8357: prepare to conversion to gpiod API

2022-10-10 Thread Linus Walleij
On Thu, Oct 6, 2022 at 12:05 PM Daniel Thompson wrote: > On Thu, Oct 06, 2022 at 11:03:15AM +0200, Linus Walleij wrote: > > On Tue, Oct 4, 2022 at 10:35 PM Dmitry Torokhov > > wrote: > > > > > > Dmitry, could you fix this? Just patch away in gpiolib-of.c. > > > > > > Sure, I'll add a few quirks.

Re: [PATCH v2] drm/i915/huc: bump timeout for delayed load and reduce print verbosity

2022-10-10 Thread John Harrison
On 10/10/2022 11:48, Daniele Ceraolo Spurio wrote: We're observing sporadic HuC delayed load timeouts in CI, due to mei_pxp binding completing later than we expected. HuC is still loaded when the bind occurs, but in the meantime i915 has started allowing submission to the VCS engines even if HuC

Re: [PATCH v2] drm/i915/huc: bump timeout for delayed load and reduce print verbosity

2022-10-10 Thread Ceraolo Spurio, Daniele
On 10/10/2022 3:50 PM, John Harrison wrote: On 10/10/2022 11:48, Daniele Ceraolo Spurio wrote: We're observing sporadic HuC delayed load timeouts in CI, due to mei_pxp binding completing later than we expected. HuC is still loaded when the bind occurs, but in the meantime i915 has started all

[PATCH v6 0/7] treewide cleanup of random integer usage

2022-10-10 Thread Jason A. Donenfeld
Changes v5->v6: - Added a few missing conversions that weren't in my older tree, so now this should be ready to go, as well as a couple nits people had from v5. Barring something large and unforeseen, this is the "final version", as this is ready to ship. Thanks to everyone who reviewed thi

[PATCH v6 1/7] treewide: use prandom_u32_max() when possible, part 1

2022-10-10 Thread Jason A. Donenfeld
Rather than incurring a division or requesting too many random bytes for the given range, use the prandom_u32_max() function, which only takes the minimum required bytes from the RNG and avoids divisions. This was done mechanically with this coccinelle script: @basic@ expression E; type T; identif

[PATCH v6 2/7] treewide: use prandom_u32_max() when possible, part 2

2022-10-10 Thread Jason A. Donenfeld
Rather than incurring a division or requesting too many random bytes for the given range, use the prandom_u32_max() function, which only takes the minimum required bytes from the RNG and avoids divisions. This was done by hand, covering things that coccinelle could not do on its own. Reviewed-by:

[PATCH v6 3/7] treewide: use get_random_{u8, u16}() when possible, part 1

2022-10-10 Thread Jason A. Donenfeld
Rather than truncate a 32-bit value to a 16-bit value or an 8-bit value, simply use the get_random_{u8,u16}() functions, which are faster than wasting the additional bytes from a 32-bit value. This was done mechanically with this coccinelle script: @@ expression E; identifier get_random_u32 =~ "ge

[PATCH v6 4/7] treewide: use get_random_{u8, u16}() when possible, part 2

2022-10-10 Thread Jason A. Donenfeld
Rather than truncate a 32-bit value to a 16-bit value or an 8-bit value, simply use the get_random_{u8,u16}() functions, which are faster than wasting the additional bytes from a 32-bit value. This was done by hand, identifying all of the places where one of the random integer functions was used in

[PATCH v6 5/7] treewide: use get_random_u32() when possible

2022-10-10 Thread Jason A. Donenfeld
The prandom_u32() function has been a deprecated inline wrapper around get_random_u32() for several releases now, and compiles down to the exact same code. Replace the deprecated wrapper with a direct call to the real function. The same also applies to get_random_int(), which is just a wrapper arou

[PATCH v6 6/7] treewide: use get_random_bytes() when possible

2022-10-10 Thread Jason A. Donenfeld
The prandom_bytes() function has been a deprecated inline wrapper around get_random_bytes() for several releases now, and compiles down to the exact same code. Replace the deprecated wrapper with a direct call to the real function. This was done as a basic find and replace. Reviewed-by: Greg Kroah

[PATCH v6 7/7] prandom: remove unused functions

2022-10-10 Thread Jason A. Donenfeld
With no callers left of prandom_u32() and prandom_bytes(), as well as get_random_int(), remove these deprecated wrappers, in favor of get_random_u32() and get_random_bytes(). Reviewed-by: Greg Kroah-Hartman Reviewed-by: Kees Cook Reviewed-by: Yury Norov Signed-off-by: Jason A. Donenfeld --- d

RE: [PATCH] drm/i915/gvt: Add missing vfio_unregister_group_dev() call

2022-10-10 Thread Tian, Kevin
> From: Alex Williamson > Sent: Friday, October 7, 2022 2:31 AM > > On Thu, 6 Oct 2022 08:37:09 -0300 > Jason Gunthorpe wrote: > > > On Wed, Oct 05, 2022 at 04:03:56PM -0600, Alex Williamson wrote: > > > We can't have a .remove callback that does nothing, this breaks > > > removing the device w

[PATCH] drm/i915: Use graphics ver, rel info for media on old platforms

2022-10-10 Thread Radhakrishna Sripada
Platforms prior to MTL do not have a separate media and graphics version. On platforms where GMD id is not supported, reuse the graphics ip version, release info for media. The rest of the IP graphics, display versions would be copied during driver creation. While at it warn if GMD is not used fo

Re: [PATCH v3 07/17] drm/i915/vm_bind: Add support to handle object evictions

2022-10-10 Thread Niranjana Vishwanathapura
On Mon, Oct 10, 2022 at 06:15:02PM +0100, Matthew Auld wrote: On 10/10/2022 17:11, Niranjana Vishwanathapura wrote: On Mon, Oct 10, 2022 at 02:30:49PM +0100, Matthew Auld wrote: On 10/10/2022 07:58, Niranjana Vishwanathapura wrote: Support eviction by maintaining a list of evicted persistent v

Re: [PATCH v3 07/17] drm/i915/vm_bind: Add support to handle object evictions

2022-10-10 Thread Niranjana Vishwanathapura
On Mon, Oct 10, 2022 at 05:43:47PM -0700, Niranjana Vishwanathapura wrote: On Mon, Oct 10, 2022 at 06:15:02PM +0100, Matthew Auld wrote: On 10/10/2022 17:11, Niranjana Vishwanathapura wrote: On Mon, Oct 10, 2022 at 02:30:49PM +0100, Matthew Auld wrote: On 10/10/2022 07:58, Niranjana Vishwanath

Re: [PATCH v6 3/7] treewide: use get_random_{u8,u16}() when possible, part 1

2022-10-10 Thread Jason A. Donenfeld
On Tue, Oct 11, 2022 at 01:18:40AM +, Elliott, Robert (Servers) wrote: > > > diff --git a/crypto/testmgr.c b/crypto/testmgr.c > ... > > @@ -944,7 +944,7 @@ static void generate_random_bytes(u8 *buf, size_t count) > > default: > > /* Fully random bytes */ > > for (i

Re: [PATCH] drm/edid/firmware: stop using throwaway platform device

2022-10-10 Thread Matthieu CHARETTE
It should fix the issue. Meanwhile, the system will still crash if a new monitor is plugged while the machine is suspended. We might need to precache the EDID to prevent that. Matthieu On Fri, Oct 7 2022 at 01:21:46 AM +0300, Jani Nikula wrote: We've used a temporary platform device for fir

RE: [PATCH v6 3/7] treewide: use get_random_{u8, u16}() when possible, part 1

2022-10-10 Thread Elliott, Robert (Servers)
> diff --git a/crypto/testmgr.c b/crypto/testmgr.c ... > @@ -944,7 +944,7 @@ static void generate_random_bytes(u8 *buf, size_t count) > default: > /* Fully random bytes */ > for (i = 0; i < count; i++) > - buf[i] = (u8)prandom_u32(); > +