Re: [PATCH] drm: rcar-du: Fix Kconfig dependency between RCAR_DU and RCAR_MIPI_DSI

2022-10-03 Thread Geert Uytterhoeven
Hi Tomi, On Mon, Oct 3, 2022 at 8:56 AM Tomi Valkeinen wrote: > On 02/10/2022 01:03, Laurent Pinchart wrote: > > When the R-Car MIPI DSI driver was added, it was a standalone encoder > > driver without any dependency to or from the R-Car DU driver. Commit > > 957fe62d7d15 ("drm: rcar-du: Fix DSI

Re: Nested AVIC design (was:Re: [RFC PATCH v3 04/19] KVM: x86: mmu: allow to enable write tracking externally)

2022-10-03 Thread Maxim Levitsky
On Thu, 2022-09-29 at 22:38 +, Sean Christopherson wrote: > On Mon, Aug 08, 2022, Maxim Levitsky wrote: > > Hi Sean, Paolo, and everyone else who wants to review my nested AVIC work. > > Before we dive deep into design details, I think we should first decide > whether > or not nested AVIC is

Re: [PATCH] drm: rcar-du: Fix Kconfig dependency between RCAR_DU and RCAR_MIPI_DSI

2022-10-03 Thread Tomi Valkeinen
On 03/10/2022 10:01, Geert Uytterhoeven wrote: Hi Tomi, On Mon, Oct 3, 2022 at 8:56 AM Tomi Valkeinen wrote: On 02/10/2022 01:03, Laurent Pinchart wrote: When the R-Car MIPI DSI driver was added, it was a standalone encoder driver without any dependency to or from the R-Car DU driver. Commit

Re: [PATCH v6 01/10] drm: bridge: Add Samsung DSIM bridge driver

2022-10-03 Thread Marek Szyprowski
Hi Jagan, On 01.10.2022 10:06, Jagan Teki wrote: > Samsung MIPI DSIM controller is common DSI IP that can be used in various > SoCs like Exynos, i.MX8M Mini/Nano. > > In order to access this DSI controller between various platform SoCs, > the ideal way to incorporate this in the drm stack is via t

Re: [PATCH v5 06/11] drm: bridge: samsung-dsim: Add atomic_check

2022-10-03 Thread Marek Szyprowski
Hi Jagan, On 16.09.2022 20:17, Jagan Teki wrote: > Look like an explicit fixing up of mode_flags is required for DSIM IP > present in i.MX8M Mini/Nano SoCs. > > At least the LCDIF + DSIM needs active low sync polarities in order > to correlate the correct sync flags of the surrounding components i

Re: [Intel-gfx] [PATCH v4 3/4] drm/i915: Make the heartbeat play nice with long pre-emption timeouts

2022-10-03 Thread Tvrtko Ursulin
On 30/09/2022 18:44, John Harrison wrote: On 9/30/2022 02:22, Tvrtko Ursulin wrote: On 29/09/2022 17:21, John Harrison wrote: On 9/29/2022 00:42, Tvrtko Ursulin wrote: On 29/09/2022 03:18, john.c.harri...@intel.com wrote: From: John Harrison Compute workloads are inherently not pre-emptib

Re: [PATCH v7 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml

2022-10-03 Thread Krzysztof Kozlowski
On 23/09/2022 22:32, Dmitry Baryshkov wrote: > On 22/09/2022 15:28, Krzysztof Kozlowski wrote: >> On 22/09/2022 13:46, Dmitry Baryshkov wrote: > - ranges: true > +maxItems: 2 > > interconnects: > -items: > - - description: Interconnect path from mdp0 p

Re: [Intel-gfx] [PATCH] drm/i915/guc: Fix revocation of non-persistent contexts

2022-10-03 Thread Tvrtko Ursulin
On 30/09/2022 15:52, Andrzej Hajda wrote: On 30.09.2022 11:47, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Patch which added graceful exit for non-persistent contexts missed the fact it is not enough to set the exiting flag on a context and let the backend handle it from there. GuC backend c

[PATCH] drm/ttm: fix bo->resource check in vm_access

2022-10-03 Thread Matthew Auld
Touching bo->resource looks like it should require first locking the object, since this state is dynamic and could potentially change from under us. It looks we can just use obj->base.size here, which avoids any issues with locking, since this is immutable state. Signed-off-by: Matthew Auld Cc: C

Re: [PATCH v3 2/2] drm/tests: Split drm_test_dp_mst_sideband_msg_req_decode into parameterized tests

2022-10-03 Thread Michał Winiarski
On Sat, Oct 01, 2022 at 07:34:22PM -0300, Maíra Canal wrote: > The drm_test_dp_mst_sideband_msg_req_decode repeats the same test > structure with different parameters. This could be better represented > by parameterized tests, provided by KUnit. > > In addition to the parameterization of the tests

Re: [PATCH 14/16] drm/i915/vm_bind: Handle persistent vmas in execbuf3

2022-10-03 Thread Matthew Auld
On 02/10/2022 07:28, Niranjana Vishwanathapura wrote: On Fri, Sep 30, 2022 at 10:47:48AM +0100, Matthew Auld wrote: On 28/09/2022 07:19, Niranjana Vishwanathapura wrote: Handle persistent (VM_BIND) mappings during the request submission in the execbuf3 path. Signed-off-by: Niranjana Vishwanath

Re: [RFC v2] drm/kms: control display brightness through drm_connector properties

2022-10-03 Thread Pekka Paalanen
On Fri, 30 Sep 2022 18:17:39 +0200 Sebastian Wick wrote: > On Fri, Sep 30, 2022 at 5:27 PM Pekka Paalanen wrote: > > > > On Fri, 30 Sep 2022 17:44:17 +0300 > > Ville Syrjälä wrote: > > > > > On Fri, Sep 30, 2022 at 04:20:29PM +0200, Sebastian Wick wrote: > > > > On Fri, Sep 30, 2022 at 9:40

Re: KMS atomic state sets, full vs. minimal (Re: [PATCH v3 0/6] Add support for atomic async page-flips)

2022-10-03 Thread Pekka Paalanen
On Fri, 30 Sep 2022 18:45:09 +0300 Ville Syrjälä wrote: > On Fri, Sep 30, 2022 at 06:37:00PM +0300, Pekka Paalanen wrote: > > On Fri, 30 Sep 2022 18:09:55 +0300 > > Ville Syrjälä wrote: > > > > > That would actively discourage people from even attempting the > > > "just dump all the state int

Re: [RFC v2] drm/kms: control display brightness through drm_connector properties

2022-10-03 Thread Hans de Goede
Hi, On 9/28/22 12:04, Jani Nikula wrote: > On Fri, 09 Sep 2022, Hans de Goede wrote: >> Hi all, >> >> Here is v2 of my "drm/kms: control display brightness through drm_connector >> properties" RFC: >> >> Changes from version 1: >> - Drop bl_brightness_0_is_min_brightness from list of new connect

Re: [Intel-gfx] [PATCH v2 14/14] drm/i915/mtl: Add multicast steering for media GT

2022-10-03 Thread Tvrtko Ursulin
Hi Matt, On 01/10/2022 01:45, Matt Roper wrote: MTL's media GT only has a single type of steering ("OAADDRM") which selects between media slice 0 and media slice 1. We'll always steer to media slice 0 unless it is fused off (which is the case when VD0, VE0, and SFC0 are all reported as unavai

Re: [RFC v2] drm/kms: control display brightness through drm_connector properties

2022-10-03 Thread Hans de Goede
Hi, On 9/28/22 12:57, Ville Syrjälä wrote: > On Wed, Sep 28, 2022 at 01:04:01PM +0300, Jani Nikula wrote: >> On Fri, 09 Sep 2022, Hans de Goede wrote: >>> Hi all, >>> >>> Here is v2 of my "drm/kms: control display brightness through drm_connector >>> properties" RFC: >>> >>> Changes from version

Re: KMS atomic state sets, full vs. minimal (Re: [PATCH v3 0/6] Add support for atomic async page-flips)

2022-10-03 Thread Ville Syrjälä
On Mon, Oct 03, 2022 at 11:48:49AM +0300, Pekka Paalanen wrote: > On Fri, 30 Sep 2022 18:45:09 +0300 > Ville Syrjälä wrote: > > > On Fri, Sep 30, 2022 at 06:37:00PM +0300, Pekka Paalanen wrote: > > > On Fri, 30 Sep 2022 18:09:55 +0300 > > > Ville Syrjälä wrote: > > > > > > > That would active

Re: [RFC v2] drm/kms: control display brightness through drm_connector properties

2022-10-03 Thread Ville Syrjälä
On Mon, Oct 03, 2022 at 11:37:50AM +0300, Pekka Paalanen wrote: > On Fri, 30 Sep 2022 18:17:39 +0200 > Sebastian Wick wrote: > > > On Fri, Sep 30, 2022 at 5:27 PM Pekka Paalanen wrote: > > > > > > On Fri, 30 Sep 2022 17:44:17 +0300 > > > Ville Syrjälä wrote: > > > > > > > On Fri, Sep 30, 2022

Re: [Intel-gfx] [PATCH] drm/i915/guc: Fix revocation of non-persistent contexts

2022-10-03 Thread Andrzej Hajda
On 03.10.2022 09:59, Tvrtko Ursulin wrote: On 30/09/2022 15:52, Andrzej Hajda wrote: On 30.09.2022 11:47, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Patch which added graceful exit for non-persistent contexts missed the fact it is not enough to set the exiting flag on a context and let the b

Re: [RFC v2] drm/kms: control display brightness through drm_connector properties

2022-10-03 Thread Hans de Goede
Hi, On 9/30/22 18:17, Sebastian Wick wrote: > On Fri, Sep 30, 2022 at 5:27 PM Pekka Paalanen wrote: >> >> On Fri, 30 Sep 2022 17:44:17 +0300 >> Ville Syrjälä wrote: >> >>> On Fri, Sep 30, 2022 at 04:20:29PM +0200, Sebastian Wick wrote: On Fri, Sep 30, 2022 at 9:40 AM Pekka Paalanen wrote:

Re: [RFC v2] drm/kms: control display brightness through drm_connector properties

2022-10-03 Thread Pekka Paalanen
On Mon, 3 Oct 2022 12:29:01 +0300 Ville Syrjälä wrote: > On Mon, Oct 03, 2022 at 11:37:50AM +0300, Pekka Paalanen wrote: > > On Fri, 30 Sep 2022 18:17:39 +0200 > > Sebastian Wick wrote: > > > > > On Fri, Sep 30, 2022 at 5:27 PM Pekka Paalanen > > > wrote: > > > > > > > > On Fri, 30 Sep 20

Re: [RFC v2] drm/kms: control display brightness through drm_connector properties

2022-10-03 Thread Pekka Paalanen
On Mon, 3 Oct 2022 11:44:56 +0200 Hans de Goede wrote: > One example mentioned here is that laptops with Intel integrated > graphics may have some "perceived brightness" mapping table > in their Video BIOS Tables (VBT) it would be interesting to use > this and to export the curve coming from that

Re: [RFC v2] drm/kms: control display brightness through drm_connector properties

2022-10-03 Thread Hans de Goede
Hi, On 10/3/22 12:32, Pekka Paalanen wrote: > On Mon, 3 Oct 2022 11:44:56 +0200 > Hans de Goede wrote: > >> One example mentioned here is that laptops with Intel integrated >> graphics may have some "perceived brightness" mapping table >> in their Video BIOS Tables (VBT) it would be interesting

Re: [PATCH] drm/i915/slpc: Update frequency debugfs for SLPC

2022-10-03 Thread Jani Nikula
On Fri, 30 Sep 2022, Vinay Belgaumkar wrote: > Create a wrapper to print out the frequency debugfs for > SLPC and non-SLPC cases. Most of the RPS related information > is no longer valid when SLPC is enabled. Please split code movement and functional changes to separate patches. BR, Jani. > > S

Re: [PATCH v2 2/2] drm/bridge: it6505: Add pre_enable/post_disable callback

2022-10-03 Thread AngeloGioacchino Del Regno
Il 03/10/22 07:03, Pin-yen Lin ha scritto: Add atomic_pre_enable and atomic_post_disable callback to make sure the bridge is not powered off until atomic_post_disable is called. This prevents a power leakage when it6505 is powered off, but the upstream DRM bridge is still sending display signals.

Re: [PATCH v2 1/2] drm/bridge: it6505: Adapt runtime power management framework

2022-10-03 Thread AngeloGioacchino Del Regno
Il 03/10/22 07:03, Pin-yen Lin ha scritto: Use pm_runtime_(get|put)_sync to control the bridge power, and add SET_SYSTEM_SLEEP_PM_OPS with pm_runtime_force_(suspend|resume) to it6505 driver. Without SET_SYSTEM_SLEEP_PM_OPS, the bridge will be powered on unnecessarily when no external display is c

Re: [Intel-gfx] [PATCH v4 3/4] drm/i915: Make the heartbeat play nice with long pre-emption timeouts

2022-10-03 Thread Tvrtko Ursulin
On 03/10/2022 08:53, Tvrtko Ursulin wrote: On 30/09/2022 18:44, John Harrison wrote: On 9/30/2022 02:22, Tvrtko Ursulin wrote: On 29/09/2022 17:21, John Harrison wrote: On 9/29/2022 00:42, Tvrtko Ursulin wrote: On 29/09/2022 03:18, john.c.harri...@intel.com wrote: From: John Harrison Co

[PATCH v2] drm/i915/guc: Fix revocation of non-persistent contexts

2022-10-03 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Patch which added graceful exit for non-persistent contexts missed the fact it is not enough to set the exiting flag on a context and let the backend handle it from there. GuC backend cannot handle it because it runs independently in the firmware and driver might not see the

Re: [PATCH v2 15/17] drm/i915/vm_bind: Handle persistent vmas in execbuf3

2022-10-03 Thread Matthew Auld
On 03/10/2022 07:12, Niranjana Vishwanathapura wrote: Handle persistent (VM_BIND) mappings during the request submission in the execbuf3 path. v2: Ensure requests wait for bindings to complete. Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti --- .../gpu/drm/i915/gem/i915_

Re: [PATCH] drm: rcar-du: Fix Kconfig dependency between RCAR_DU and RCAR_MIPI_DSI

2022-10-03 Thread Laurent Pinchart
Hi Tomi, On Mon, Oct 03, 2022 at 10:31:24AM +0300, Tomi Valkeinen wrote: > On 03/10/2022 10:01, Geert Uytterhoeven wrote: > > On Mon, Oct 3, 2022 at 8:56 AM Tomi Valkeinen wrote: > >> On 02/10/2022 01:03, Laurent Pinchart wrote: > >>> When the R-Car MIPI DSI driver was added, it was a standalone e

Re: [RFC/PATCH] backlight: hx8357: prepare to conversion to gpiod API

2022-10-03 Thread Daniel Thompson
On Wed, Sep 28, 2022 at 11:33:52AM -0700, Dmitry Torokhov wrote: > On Wed, Sep 28, 2022 at 12:00:51PM +0100, Daniel Thompson wrote: > > On Tue, Sep 27, 2022 at 03:32:35PM -0700, Dmitry Torokhov wrote: > > > Properties describing GPIOs should be named as "-gpios" or > > > "-gpio", and that is what g

Re: [PATCH -next resend] backlight: ktd253: Switch to use dev_err_probe() helper

2022-10-03 Thread Linus Walleij
On Mon, Sep 26, 2022 at 4:14 PM Yang Yingliang wrote: > In the probe path, dev_err() can be replaced with dev_err_probe() > which will check if error code is -EPROBE_DEFER and prints the > error name. It also sets the defer probe reason which can be > checked later through debugfs. It's more simp

Re: [PATCH v1 17/17] drm/mediatek: Add mt8195-dpi support to drm_drv

2022-10-03 Thread Guillaume Ranquet
On Tue, 27 Sep 2022 16:28, Krzysztof Kozlowski wrote: >On 27/09/2022 15:04, Guillaume Ranquet wrote: >> On Thu, 22 Sep 2022 09:20, Krzysztof Kozlowski >> wrote: >>> On 19/09/2022 18:56, Guillaume Ranquet wrote: Add dpi support to enable the HDMI path. Signed-off-by: Guillaume Ranqu

RE: [PATCH v4.1] drm/i915/mtl: Define engine context layouts

2022-10-03 Thread Sripada, Radhakrishna
> -Original Message- > From: De Marchi, Lucas > Sent: Thursday, September 29, 2022 5:11 PM > To: Sripada, Radhakrishna > Cc: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Subject: Re: [PATCH v4.1] drm/i915/mtl: Define engine context layouts > > On Wed, Sep 28, 202

Re: [PATCH v1 09/17] drm/mediatek: hdmi: add connector flag

2022-10-03 Thread Guillaume Ranquet
On Tue, 20 Sep 2022 12:38, AngeloGioacchino Del Regno wrote: >Il 19/09/22 18:56, Guillaume Ranquet ha scritto: >> Add a flag to indicate support for an external connector >> >> Signed-off-by: Guillaume Ranquet >> >> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_common.c >> b/drivers/gpu/drm/med

Re: [PATCH v2 10/17] drm/i915/vm_bind: Abstract out common execbuf functions

2022-10-03 Thread Andi Shyti
Hi Niranjana, [...] > + for_each_child(ce, child) { > + err = intel_context_pin_ww(child, ww); > + GEM_BUG_ON(err);/* perma-pinned should incr a counter */ > + } > + > + for_each_child(ce, child) { > + err = eb_pin_timeline(child, throttle,

Re: [PATCH v2 14/17] drm/i915/vm_bind: Expose i915_request_await_bind()

2022-10-03 Thread Andi Shyti
Hi Niranjana, On Sun, Oct 02, 2022 at 11:12:42PM -0700, Niranjana Vishwanathapura wrote: > Rename __i915_request_await_bind() as i915_request_await_bind() > and make it non-static as it will be used in execbuf3 ioctl path. > > Signed-off-by: Niranjana Vishwanathapura Reviewed-by: Andi Shyti A

Re: [PATCH v3 3/8] dt-bindings: Add bindings for Tegra234 NVDEC

2022-10-03 Thread Rob Herring
On Tue, 20 Sep 2022 11:11:58 +0300, Mikko Perttunen wrote: > From: Mikko Perttunen > > Update NVDEC bindings for Tegra234. This new engine version only has > two memory clients, but now requires three clocks, and as a bigger > change the engine loads firmware from a secure carveout configured by

Re: [PATCH 1/4] dt-bindings: display: Add bindings for JDI LPM102A188A

2022-10-03 Thread Diogo Ivo
On Fri, Sep 30, 2022 at 12:49:31PM +0200, Krzysztof Kozlowski wrote: > > + ts-reset-gpios: > > +maxItems: 1 > > +description: | > > + Specifier for a GPIO connected to the touchscreen reset control > > signal. > > + The reset signal is active low. > > Isn't touchscreen a separa

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Use GEN12 RPSTAT register

2022-10-03 Thread Andi Shyti
On Tue, Sep 27, 2022 at 06:47:28PM -0700, Dixit, Ashutosh wrote: > On Tue, 27 Sep 2022 04:35:29 -0700, Badal Nilawar wrote: > > > > From: Don Hiatt > > > > On GEN12 and above use GEN12_RPSTAT register to get Current > > Actual Graphics Frequency of GT > > I think even for the purposes of reviewin

Re: [PATCH v2 1/8] mm/memory.c: Fix race when faulting a device private page

2022-10-03 Thread Felix Kuehling
Am 2022-10-02 um 20:53 schrieb Alistair Popple: Felix Kuehling writes: On 2022-09-28 08:01, Alistair Popple wrote: When the CPU tries to access a device private page the migrate_to_ram() callback associated with the pgmap for the page is called. However no reference is taken on the faulting p

Re: [Intel-gfx] [PATCH] drm/i915: Fix CFI violations in gt_sysfs

2022-10-03 Thread Nathan Chancellor
Hi Andrzej, On Thu, Sep 29, 2022 at 03:44:40PM -0700, Nathan Chancellor wrote: > On Fri, Sep 30, 2022 at 12:34:41AM +0200, Andrzej Hajda wrote: > > On 22.09.2022 21:51, Nathan Chancellor wrote: > > > When booting with clang's kernel control flow integrity series [1], > > > there are numerous viola

Re: [PATCH 2/4] drm/tegra: dsi: Clear enable register if powered by bootloader

2022-10-03 Thread Diogo Ivo
On Fri, Sep 30, 2022 at 01:11:10PM +0200, Thierry Reding wrote: > On Thu, Sep 29, 2022 at 06:05:00PM +0100, Diogo Ivo wrote: > > + > > err = tegra_dsi_prepare(dsi); > > if (err < 0) { > > dev_err(dsi->dev, "failed to prepare: %d\n", err); > > @@ -1573,6 +1600,8 @@ static int teg

Re: [PATCH] drm/tve200: Use drm_* variants for logging

2022-10-03 Thread Linus Walleij
On Wed, Sep 28, 2022 at 11:31 AM Khalid Masum wrote: > We have routines like drm_info/warn/err for logging. Use them instead > of dev_* variants to get drm-formatted log messages. > > Signed-off-by: Khalid Masum So is this the new thing? We've been through: - DRM_INFO_ETC BIG CAPITAL LETTER MAC

[PATCH] drm/i915/pmu: Match frequencies reported by PMU and sysfs

2022-10-03 Thread Ashutosh Dixit
PMU and sysfs use different wakeref's to "interpret" zero freq. Sysfs uses runtime PM wakeref (see intel_rps_read_punit_req and intel_rps_read_actual_frequency). PMU uses the GT parked/unparked wakeref. In general the GT wakeref is held for less time that the runtime PM wakeref which causes PMU to

Re: [PATCH] drm: amd: clean up dcn32_fpu.c kernel-doc

2022-10-03 Thread Rodrigo Siqueira Jordao
On 2022-10-01 00:33, Randy Dunlap wrote: Rectify multiple kernel-doc warnings in dcn32_fpu.c. E.g.: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/dcn32_fpu.c:247: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst

Re: [Intel-gfx] [PATCH v2 14/14] drm/i915/mtl: Add multicast steering for media GT

2022-10-03 Thread Matt Roper
On Mon, Oct 03, 2022 at 09:56:18AM +0100, Tvrtko Ursulin wrote: > > Hi Matt, > > On 01/10/2022 01:45, Matt Roper wrote: > > MTL's media GT only has a single type of steering ("OAADDRM") which > > selects between media slice 0 and media slice 1. We'll always steer to > > media slice 0 unless it i

Re: [PATCH] drm/panel: db7430: Silent no spi_device_id warning

2022-10-03 Thread Linus Walleij
On Thu, Sep 15, 2022 at 6:14 PM Wei Yongjun wrote: > From: Wei Yongjun > > Add spi_device_id entries to silent following SPI warning: > > SPI driver db7430-panel has no spi_device_id for samsung,lms397kf04 > > Signed-off-by: Wei Yongjun Patch applied. Yours, Linus Walleij

Re: [PATCH] drm/panel: tpg110: Silent no spi_device_id warning

2022-10-03 Thread Linus Walleij
On Thu, Sep 15, 2022 at 6:17 PM Wei Yongjun wrote: > From: Wei Yongjun > > Add spi_device_id entries to silent following SPI warning: > > SPI driver tpo-tpg110-panel has no spi_device_id for tpo,tpg110 > > Signed-off-by: Wei Yongjun Patch applied. Yours, Linus Walleij

Re: [PATCH] drm/panel: ws2401: Silent no spi_device_id warning

2022-10-03 Thread Linus Walleij
On Thu, Sep 15, 2022 at 6:17 PM Wei Yongjun wrote: > From: Wei Yongjun > > Add spi_device_id entries to silent following SPI warning: > > SPI driver ws2401-panel has no spi_device_id for samsung,lms380kf01 > > Signed-off-by: Wei Yongjun Patch applied. Yours, Linus Walleij

Re: [Intel-gfx] [PATCH 1/7] drm/i915/hwmon: Add HWMON infrastructure

2022-10-03 Thread Andi Shyti
Hi Badal, On Tue, Sep 27, 2022 at 11:20:14AM +0530, Badal Nilawar wrote: > From: Dale B Stimson > > The i915 HWMON module will be used to expose voltage, power and energy > values for dGfx. Here we set up i915 hwmon infrastructure including i915 > hwmon registration, basic data structures and fu

Re: [Intel-gfx] [PATCH 2/7] drm/i915/hwmon: Add HWMON current voltage support

2022-10-03 Thread Andi Shyti
Hi Badal, [...] > static void > hwm_get_preregistration_info(struct drm_i915_private *i915) > { > + struct i915_hwmon *hwmon = i915->hwmon; > + > + if (IS_DG1(i915) || IS_DG2(i915)) why not GRAPHICS_VER(i915) >= 12 here? Andi > + hwmon->rg.gt_perf_status = GEN12_RPSTAT1;

Re: [Intel-gfx] [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting

2022-10-03 Thread Andi Shyti
Hi Badal, [...] > hwm_get_preregistration_info(struct drm_i915_private *i915) > { > struct i915_hwmon *hwmon = i915->hwmon; > + struct intel_uncore *uncore = &i915->uncore; > + intel_wakeref_t wakeref; > + u32 val_sku_unit; > > - if (IS_DG1(i915) || IS_DG2(i915)) > +

Re: [PATCH v2 10/17] drm/i915/vm_bind: Abstract out common execbuf functions

2022-10-03 Thread Niranjana Vishwanathapura
On Mon, Oct 03, 2022 at 05:53:37PM +0200, Andi Shyti wrote: Hi Niranjana, [...] + for_each_child(ce, child) { + err = intel_context_pin_ww(child, ww); + GEM_BUG_ON(err);/* perma-pinned should incr a counter */ + } + + for_each_child(ce, chi

Re: [Intel-gfx] [PATCH 12/16] drm/i915/vm_bind: Implement I915_GEM_EXECBUFFER3 ioctl

2022-10-03 Thread Niranjana Vishwanathapura
On Thu, Sep 29, 2022 at 09:02:01AM -0700, Niranjana Vishwanathapura wrote: On Thu, Sep 29, 2022 at 04:00:47PM +0100, Matthew Auld wrote: On 28/09/2022 07:19, Niranjana Vishwanathapura wrote: Implement new execbuf3 ioctl (I915_GEM_EXECBUFFER3) which only works in vm_bind mode. The vm_bind mode o

Re: [Intel-gfx] [PATCH 4/7] drm/i915/hwmon: Show device level energy usage

2022-10-03 Thread Andi Shyti
Hi Badal, [...] > > diff --git a/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon > > b/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon > > index 16e697b1db3d..7525db243d74 100644 > > --- a/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon > > +++ b/Documentation/ABI/testing

Re: [Intel-gfx] [PATCH 5/7] drm/i915/hwmon: Expose card reactive critical power

2022-10-03 Thread Andi Shyti
Hi Badal, [...] > diff --git a/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon > b/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon > index 7525db243d74..f9d6d3b08bba 100644 > --- a/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon > +++ b/Documentation/ABI/testing/sysfs-dri

Re: [Intel-gfx] [PATCH 6/7] drm/i915/hwmon: Expose power1_max_interval

2022-10-03 Thread Andi Shyti
Hi Badal, > diff --git a/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon > b/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon > index f9d6d3b08bba..19b9fe3ef237 100644 > --- a/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon > +++ b/Documentation/ABI/testing/sysfs-driver-int

Re: [Intel-gfx] [PATCH 7/7] drm/i915/hwmon: Extend power/energy for XEHPSDV

2022-10-03 Thread Andi Shyti
On Tue, Sep 27, 2022 at 11:20:20AM +0530, Badal Nilawar wrote: > From: Dale B Stimson > > Extend hwmon power/energy for XEHPSDV especially per gt level energy > usage. > > v2: Update to latest HWMON spec (Ashutosh) > v3: Fix review comments (Ashutosh) > v4: Fix review comments (Anshuman) > v5: s

[PATCH 0/2] drm/i915/slpc: Update frequency debugfs for SLPC

2022-10-03 Thread Vinay Belgaumkar
Remove the RPS related information that is not valid when SLPC is enabled. Signed-off-by: Vinay Belgaumkar Vinay Belgaumkar (2): drm/i915: Add a wrapper for frequency debugfs drm/i915/slpc: Update the frequency debugfs drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 157 + driv

[PATCH 1/2] drm/i915: Add a wrapper for frequency debugfs

2022-10-03 Thread Vinay Belgaumkar
Move it to the RPS source file. Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 157 +--- drivers/gpu/drm/i915/gt/intel_rps.c | 169 ++ drivers/gpu/drm/i915/gt/intel_rps.h | 3 + 3 files changed, 173 insertions

[PATCH 2/2] drm/i915/slpc: Update the frequency debugfs

2022-10-03 Thread Vinay Belgaumkar
Read the values stored in the SLPC structures. Remove the fields that are no longer valid (like RPS interrupts) as well. Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/intel_rps.c | 37 + 1 file changed, 37 insertions(+) diff --git a/drivers/gpu/drm/i915

Re: [PATCH v2 10/17] drm/i915/vm_bind: Abstract out common execbuf functions

2022-10-03 Thread Andi Shyti
Hi Niranjana, On Mon, Oct 03, 2022 at 02:06:18PM -0700, Niranjana Vishwanathapura wrote: > On Mon, Oct 03, 2022 at 05:53:37PM +0200, Andi Shyti wrote: > > Hi Niranjana, > > > > [...] > > > > > + for_each_child(ce, child) { > > > + err = intel_context_pin_ww(child, ww); > > > + GE

Re: [PATCH 1/5] drm/msm/dsi: Remove useless math in DSC calculation

2022-10-03 Thread Bjorn Andersson
On Sat, Oct 01, 2022 at 09:08:03PM +0200, Marijn Suijten wrote: > Multiplying a value by 2 and adding 1 to it always results in a value > that is uneven, and that 1 gets truncated immediately when performing > integer division by 2 again. There is no "rounding" possible here. > > Fixes: b9080324d

Re: [PATCH 2/5] drm/msm/dsi: Remove repeated calculation of slice_per_intf

2022-10-03 Thread Bjorn Andersson
On Sat, Oct 01, 2022 at 09:08:04PM +0200, Marijn Suijten wrote: > slice_per_intf is already computed for intf_width, which holds the same > value as hdisplay. > > Fixes: 08802f515c3c ("drm/msm/dsi: Add support for DSC configuration") > Signed-off-by: Marijn Suijten Reviewed-by: Bjorn Andersson

Re: [PATCH] Updated the orientation quirks to support the many variations of ONEXPLAYER and AokZoe devices.

2022-10-03 Thread Matthew Anderson
Has anyone been able to review this? If possible I'd like to see this pulled into 6.1 On Fri, Sep 16, 2022, 8:50 AM Matthew wrote: > Signed-off-by: Matthew Anderson > --- > .../gpu/drm/drm_panel_orientation_quirks.c| 86 ++- > 1 file changed, 85 insertions(+), 1 deletion(-)

Re: linux-next: build failure after merge of the drm tree

2022-10-03 Thread Stephen Rothwell
Hi broo...@kernel.org, On Fri, 30 Sep 2022 11:54:34 +0100 broo...@kernel.org wrote: > > After merging the drm tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > /tmp/next/build/drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_stream.c: In > function 'dc_stream_remove_wr

Re: linux-next: build failure after merge of the drm tree

2022-10-03 Thread David Airlie
On Tue, Oct 4, 2022 at 12:21 PM Stephen Rothwell wrote: > > Hi broo...@kernel.org, > > On Fri, 30 Sep 2022 11:54:34 +0100 broo...@kernel.org wrote: > > > > After merging the drm tree, today's linux-next build (x86_64 > > allmodconfig) failed like this: > > > > /tmp/next/build/drivers/gpu/drm/amd/a

linux-next: manual merge of the fbdev tree with the drm tree

2022-10-03 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the fbdev tree got a conflict in: drivers/video/fbdev/tridentfb.c between commit: 145eed48de27 ("fbdev: Remove conflicting devices on PCI bus") from the drm tree and commit: d738bf0123d6 ("fbdev: tridentfb: Fix missing pci_disable_device() in probe a

Re: linux-next: build failure after merge of the drm tree

2022-10-03 Thread Stephen Rothwell
Hi Dave, On Tue, 4 Oct 2022 12:24:37 +1000 David Airlie wrote: > > On Tue, Oct 4, 2022 at 12:21 PM Stephen Rothwell > wrote: > > > > On Fri, 30 Sep 2022 11:54:34 +0100 broo...@kernel.org wrote: > > > > > > After merging the drm tree, today's linux-next build (x86_64 > > > allmodconfig) failed

Re: [PATCH 0/5] drm: Fix math issues in MSM DSC implementation

2022-10-03 Thread Vinod Koul
On 01-10-22, 21:08, Marijn Suijten wrote: > Various removals of complex yet unnecessary math, fixing all uses of > drm_dsc_config::bits_per_pixel to deal with the fact that this field > includes four fractional bits, and finally an approach for dealing with > dsi_host setting negative values in ran

[PATCH v3 0/2] drm/bridge: it6505: Power management fixes for it6505 bridge

2022-10-03 Thread Pin-yen Lin
This series contains 2 fixes related to it6505 power management. Changes in v3: - Handle the error from extcon_get_state - Collect review tag Changes in v2: - Handle the error from pm_runtime_get_sync in it6505_extcon_work Pin-yen Lin (2): drm/bridge: it6505: Adapt runtime power management fra

[PATCH v3 1/2] drm/bridge: it6505: Adapt runtime power management framework

2022-10-03 Thread Pin-yen Lin
Use pm_runtime_(get|put)_sync to control the bridge power, and add SET_SYSTEM_SLEEP_PM_OPS with pm_runtime_force_(suspend|resume) to it6505 driver. Without SET_SYSTEM_SLEEP_PM_OPS, the bridge will be powered on unnecessarily when no external display is connected. Fixes: b5c84a9edcd4 ("drm/bridge:

[PATCH v3 2/2] drm/bridge: it6505: Add pre_enable/post_disable callback

2022-10-03 Thread Pin-yen Lin
Add atomic_pre_enable and atomic_post_disable callback to make sure the bridge is not powered off until atomic_post_disable is called. This prevents a power leakage when it6505 is powered off, but the upstream DRM bridge is still sending display signals. Fixes: b5c84a9edcd4 ("drm/bridge: add it650

[PATCH] drm/display: Drop obsolete dependency on COMPILE_TEST

2022-10-03 Thread Jean Delvare
Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it is possible to test-build any driver which depends on OF on any architecture by explicitly selecting OF. Therefore depending on COMPILE_TEST as an alternative is no longer needed. It is actually better to always build such driver