Re: [PATCH v7 03/12] dt-bindings: display/msm: add interconnects property to qcom,mdss-smd845

2022-09-22 Thread Krzysztof Kozlowski
On 15/09/2022 15:37, Dmitry Baryshkov wrote: > Add interconnects required for the SDM845 MDSS device tree node. This > change was made in the commit c8c61c09e38b ("arm64: dts: qcom: sdm845: > Add interconnects property for display"), but was not reflected in the > schema. Reviewed-by: Krzysztof K

Re: [PATCH v7 04/12] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml

2022-09-22 Thread Krzysztof Kozlowski
On 15/09/2022 15:37, Dmitry Baryshkov wrote: > Move properties common to all DPU DT nodes to the dpu-common.yaml. > > Note, this removes description of individual DPU port@ nodes. However > such definitions add no additional value. The reg values do not > correspond to hardware INTF indices. The d

Re: [PATCH v7 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml

2022-09-22 Thread Krzysztof Kozlowski
On 15/09/2022 15:37, Dmitry Baryshkov wrote: > Move properties common to all MDSS DT nodes to the mdss-common.yaml. > > This extends qcom,msm8998-mdss schema to allow interconnect nodes, which > will be added later, once msm8998 gains interconnect support. > > Signed-off-by: Dmitry Baryshkov > -

Re: [PATCH v7 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml

2022-09-22 Thread Krzysztof Kozlowski
On 15/09/2022 15:37, Dmitry Baryshkov wrote: > Move properties common to all MDSS DT nodes to the mdss-common.yaml. > > This extends qcom,msm8998-mdss schema to allow interconnect nodes, which > will be added later, once msm8998 gains interconnect support. > > Signed-off-by: Dmitry Baryshkov > -

Re: [PATCH v7 06/12] dt-bindings: display/msm: split dpu-sc7180 into DPU and MDSS parts

2022-09-22 Thread Krzysztof Kozlowski
On 15/09/2022 15:37, Dmitry Baryshkov wrote: > In order to make the schema more readable, split dpu-sc7180 into the DPU > and MDSS parts, each one describing just a single device binding. > > Signed-off-by: Dmitry Baryshkov Thank you for your patch. There is something to discuss/improve. > +--

Re: [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting

2022-09-22 Thread Gupta, Anshuman
On 9/21/2022 8:23 PM, Nilawar, Badal wrote: On 21-09-2022 17:15, Gupta, Anshuman wrote: On 9/16/2022 8:30 PM, Badal Nilawar wrote: From: Dale B Stimson Use i915 HWMON to display/modify dGfx power PL1 limit and TDP setting. v2:    - Fix review comments (Ashutosh)    - Do not restore po

Re: [PATCH v7 11/12] dt-bindings: display/msm: add missing device nodes to mdss-* schemas

2022-09-22 Thread Krzysztof Kozlowski
On 15/09/2022 15:37, Dmitry Baryshkov wrote: > Add missing device nodes (DSI, PHYs, DP/eDP) to the existing MDSS > schemas. > > Reviewed-by: Rob Herring > Signed-off-by: Dmitry Baryshkov > --- > .../display/msm/qcom,msm8998-mdss.yaml| 12 + > .../display/msm/qcom,qcm2290-mdss.ya

Re: [PATCH v7 12/12] dt-bindings: display/msm: add support for the display on SM8250

2022-09-22 Thread Krzysztof Kozlowski
On 15/09/2022 15:37, Dmitry Baryshkov wrote: > Add DPU and MDSS schemas to describe MDSS and DPU blocks on the Qualcomm > SM8250 platform. > > Signed-off-by: Dmitry Baryshkov > --- > .../bindings/display/msm/mdss-common.yaml | 4 +- > .../bindings/display/msm/qcom,sm8250-dpu.yaml | 92 +++

Re: [PATCH v1 01/17] dt-bindings: clk: mediatek: Add MT8195 DPI clocks

2022-09-22 Thread Krzysztof Kozlowski
On 19/09/2022 18:55, Guillaume Ranquet wrote: > From: Pablo Sun > > Expand dt-bindings slot for VDOSYS1 of MT8195. > This clock is required by the DPI1 hardware > and is a downstream of the HDMI pixel clock. > > Signed-off-by: Pablo Sun > Signed-off-by: Guillaume Ranquet > Reviewed-by: Mattijs

Re: [PATCH 00/12] slab: Introduce kmalloc_size_roundup()

2022-09-22 Thread Christian König
Am 22.09.22 um 05:10 schrieb Kees Cook: Hi, This series fixes up the cases where callers of ksize() use it to opportunistically grow their buffer sizes, which can run afoul of the __alloc_size hinting that CONFIG_UBSAN_BOUNDS and CONFIG_FORTIFY_SOURCE use to perform dynamic buffer bounds checkin

Re: [PATCH v1 03/17] dt-bindings: phy: mediatek: hdmi-phy: Add mt8195 compatible

2022-09-22 Thread Krzysztof Kozlowski
On 19/09/2022 18:56, Guillaume Ranquet wrote: > Add a compatible for the HDMI PHY on MT8195 > > Signed-off-by: Guillaume Ranquet The same... maybe it works, maybe not, I don't know. Any reason not using standard tools and producing standard patches? Best regards, Krzysztof

Re: [PATCH 6/7] drm/i915/hwmon: Expose power1_max_interval

2022-09-22 Thread Gupta, Anshuman
On 9/16/2022 8:30 PM, Badal Nilawar wrote: From: Ashutosh Dixit Expose power1_max_interval, that is the tau corresponding to PL1. Some bit manipulation is needed because of the format of PKG_PWR_LIM_1_TIME in GT0_PACKAGE_RAPL_LIMIT register (1.x * power(2,y)). v2: Update date and kernel ver

Re: [PATCH 01/18] phy: mediatek: add a new helper to update bitfield

2022-09-22 Thread AngeloGioacchino Del Regno
Il 22/09/22 04:36, Chunfeng Yun ha scritto: On Wed, 2022-09-21 at 10:15 +0200, AngeloGioacchino Del Regno wrote: Il 20/09/22 11:00, Chunfeng Yun ha scritto: Due to FIELD_PREP() macro can be used to prepare a bitfield value, local ones can be remove; add the new helper to make bitfield update ea

Re: [PATCH v1 04/17] dt-bindings: display: mediatek: add MT8195 hdmi bindings

2022-09-22 Thread Krzysztof Kozlowski
On 19/09/2022 18:56, Guillaume Ranquet wrote: > Add mt8195 SoC bindings for hdmi and hdmi-ddc > > Make port1 optional for mt8195 as it only supports HDMI tx for now. > Requires a ddc-i2c-bus phandle. > Requires a power-domains phandle. > > Signed-off-by: Guillaume Ranquet > > diff --git > a/Do

Re: [PATCH v1 06/17] dt-bindings: mediatek: set the hdmi to be compatible with syscon

2022-09-22 Thread Krzysztof Kozlowski
On 19/09/2022 18:56, Guillaume Ranquet wrote: > In order to share register with a dedicated ddc driver, set the hdmi > compatible to syscon. > > Signed-off-by: Guillaume Ranquet > > diff --git > a/Documentation/devicetree/bindings/display/mediatek/mediatek,hdmi.yaml > b/Documentation/devicetre

Re: [PATCH v1 15/17] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8195

2022-09-22 Thread Krzysztof Kozlowski
On 19/09/2022 18:56, Guillaume Ranquet wrote: > Add dt-binding documentation of dpi for MediaTek MT8195 SoC. > > Signed-off-by: Guillaume Ranquet > > diff --git > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > b/Documentation/devicetree/bindings/display/mediatek/media

Re: [PATCH v1 17/17] drm/mediatek: Add mt8195-dpi support to drm_drv

2022-09-22 Thread Krzysztof Kozlowski
On 19/09/2022 18:56, Guillaume Ranquet wrote: > Add dpi support to enable the HDMI path. > > Signed-off-by: Guillaume Ranquet > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > index 72049a530ae1..27f029ca760b 100644 > --- a/drivers/gpu/drm/medi

Re: [PATCH v1 16/17] drm/mediatek: dpi: Add mt8195 hdmi to DPI driver

2022-09-22 Thread Krzysztof Kozlowski
On 19/09/2022 18:56, Guillaume Ranquet wrote: > Add the DPI1 hdmi path support in mtk dpi driver > > Signed-off-by: Guillaume Ranquet > > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c > b/drivers/gpu/drm/mediatek/mtk_dpi.c > index 630a4e301ef6..91212b7610e8 100644 > --- a/drivers/gpu/drm/medi

[PATCH v1] drivers:adp8870_bl: check the return value of adp8870_write

2022-09-22 Thread Li Zhong
Check and propagate the return value of adp8870_write() when it fails, which is possible when SMBus writing byte fails. Signed-off-by: Li Zhong --- drivers/video/backlight/adp8870_bl.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/video/backlight/adp8870_bl.c

[PATCH v2] drivers/amd/pm: check the return value of amdgpu_bo_kmap

2022-09-22 Thread Li Zhong
amdgpu_bo_kmap() returns error when fails to map buffer object. Add the error check and propagate the error. Signed-off-by: Li Zhong --- drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/amd_p

[PATCH -next] video: fbdev: tridentfb: Fix missing pci_disable_device() in probe and remove

2022-09-22 Thread ruanjinjie
Replace pci_enable_device() with pcim_enable_device(), pci_disable_device() and pci_release_regions() will be called in release automatically. Signed-off-by: ruanjinjie --- drivers/video/fbdev/tridentfb.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/video/fbde

Re: [PATCH v1] drivers:amdgpu: check the return value of amdgpu_bo_kmap

2022-09-22 Thread Li Zhong
On Wed, Sep 21, 2022 at 7:11 PM Chen, Guchun wrote: > > Perhaps you need to update the prefix of patch subject to 'drm/amd/pm: check > return value ...'. > > With above addressed, it's: Acked-by: Guchun Chen > > Regards, > Guchun > > -Original Message- > From: Li Zhong > Sent: Thursday,

Re: [PATCH v1 11/17] drm/mediatek: hdmi: add mt8195 support

2022-09-22 Thread Krzysztof Kozlowski
On 19/09/2022 18:56, Guillaume Ranquet wrote: > Adds hdmi and hdmi-ddc support for mt8195. > > Signed-off-by: Guillaume Ranquet > +static int mtk_hdmi_ddc_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct mtk_hdmi_ddc *ddc; > + int ret; > + > +

[PATCH v1] drivers:amdgpu: check the return value of amdgpu_bo_kmap

2022-09-22 Thread Li Zhong
amdgpu_bo_kmap() returns error when fails to map buffer object. Add the error check and propagate the error. Signed-off-by: Li Zhong --- drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/amd_p

Re: [PATCH v2 10/10] drm/ofdrm: Support color management

2022-09-22 Thread Maxime Ripard
On Thu, Sep 22, 2022 at 08:42:23AM +0200, Thomas Zimmermann wrote: > Hi > > Am 21.09.22 um 18:48 schrieb Geert Uytterhoeven: > > Hi Thomas, > > > > On Wed, Sep 21, 2022 at 2:55 PM Thomas Zimmermann > > wrote: > > > Am 05.08.22 um 02:19 schrieb Benjamin Herrenschmidt: > > > > On Wed, 2022-07-20

[PATCH v7,0/3] Add dpi output format control for MT8186

2022-09-22 Thread xinlei.lee
From: Xinlei Lee Base on the branch of ck-linux-next/mediatek-drm-fixes. Changes since v6: 1. Different from other ICs, when mt8186 DPI changes the output format, the mmsys_base+400 register needs to be set to be valid at the same time. In this series, all the situations that mmsys need to be

[PATCH v7,3/3] drm: mediatek: Add mt8186 dpi compatible to

2022-09-22 Thread xinlei.lee
From: Xinlei Lee Add the compatible because use edge_cfg_in_mmsys in mt8186. Signed-off-by: Xinlei Lee --- drivers/gpu/drm/mediatek/mtk_dpi.c | 21 + drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++ 2 files changed, 23 insertions(+) diff --git a/drivers/gpu/drm/mediatek

[PATCH v7,2/3] drm: mediatek: Adjust the dpi output format to MT8186

2022-09-22 Thread xinlei.lee
From: Xinlei Lee Due to the mt8186 hardware changes, we need to modify the dpi output format corresponding to the mmsys register(mmsys_base+0x400). Because different sink ICs may support other output formats. The current DRM architecture supports retrieving the output format of all bridges (eg

[PATCH v7, 1/3] soc: mediatek: Add mmsys func to adapt to dpi output for MT8186

2022-09-22 Thread xinlei.lee
From: Xinlei Lee The difference between MT8186 and other ICs is that when modifying the output format, we need to modify the mmsys_base+0x400 register to take effect. So when setting the dpi output format, we need to call mmsys_func to set it to MT8186 synchronously. Co-developed-by: Jitao Shi

Re: [PATCH 7/7] drm/i915/hwmon: Extend power/energy for XEHPSDV

2022-09-22 Thread Gupta, Anshuman
On 9/16/2022 8:30 PM, Badal Nilawar wrote: From: Dale B Stimson Extend hwmon power/energy for XEHPSDV especially per gt level energy usage. v2: Update to latest HWMON spec (Ashutosh) v3: Fixed review comments (Ashutosh) Signed-off-by: Ashutosh Dixit Signed-off-by: Dale B Stimson Signed-o

Re: [PATCH v7 04/12] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml

2022-09-22 Thread Dmitry Baryshkov
On Thu, 22 Sept 2022 at 10:02, Krzysztof Kozlowski wrote: > > On 15/09/2022 15:37, Dmitry Baryshkov wrote: > > Move properties common to all DPU DT nodes to the dpu-common.yaml. > > > > Note, this removes description of individual DPU port@ nodes. However > > such definitions add no additional val

Re: [PATCH v7 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml

2022-09-22 Thread Dmitry Baryshkov
On Thu, 22 Sept 2022 at 10:05, Krzysztof Kozlowski wrote: > > On 15/09/2022 15:37, Dmitry Baryshkov wrote: > > Move properties common to all MDSS DT nodes to the mdss-common.yaml. > > > > This extends qcom,msm8998-mdss schema to allow interconnect nodes, which > > will be added later, once msm8998

Re: [PATCH v7,3/3] drm: mediatek: Add mt8186 dpi compatible to

2022-09-22 Thread AngeloGioacchino Del Regno
Il 22/09/22 09:29, xinlei@mediatek.com ha scritto: From: Xinlei Lee Add the compatible because use edge_cfg_in_mmsys in mt8186. Signed-off-by: Xinlei Lee Please fix the commit title. drm: mediatek: Add mt8186 dpi compatibles and platform data

Re: [PATCH v7,1/3] soc: mediatek: Add mmsys func to adapt to dpi output for MT8186

2022-09-22 Thread xinlei . lee
On Thu, 2022-09-22 at 15:29 +0800, xinlei@mediatek.com wrote: > From: Xinlei Lee > > The difference between MT8186 and other ICs is that when modifying > the > output format, we need to modify the mmsys_base+0x400 register to > take > effect. > So when setting the dpi output format, we need t

Re: [PATCH v2 10/10] drm/ofdrm: Support color management

2022-09-22 Thread Thomas Zimmermann
Hi Am 22.09.22 um 09:28 schrieb Maxime Ripard: On Thu, Sep 22, 2022 at 08:42:23AM +0200, Thomas Zimmermann wrote: Hi Am 21.09.22 um 18:48 schrieb Geert Uytterhoeven: Hi Thomas, On Wed, Sep 21, 2022 at 2:55 PM Thomas Zimmermann wrote: Am 05.08.22 um 02:19 schrieb Benjamin Herrenschmidt: On

Re: [Intel-gfx] [RFC v4 03/14] drm/i915/vm_bind: Expose i915_gem_object_max_page_size()

2022-09-22 Thread Tvrtko Ursulin
On 21/09/2022 19:00, Niranjana Vishwanathapura wrote: On Wed, Sep 21, 2022 at 10:13:12AM +0100, Tvrtko Ursulin wrote: On 21/09/2022 08:09, Niranjana Vishwanathapura wrote: Expose i915_gem_object_max_page_size() function non-static which will be used by the vm_bind feature. Signed-off-by: Ni

Re: [Intel-gfx] [PATCH] drm/i915: Noop lrc_init_wa_ctx() on recent/future platforms

2022-09-22 Thread Balasubramani Vivekanandan
On 07.09.2022 16:08, Lucas De Marchi wrote: > Except for graphics version 8 and 9, nothing is done in > lrc_init_wa_ctx(). Assume this won't be needed on future platforms as > well and remove the warning. > > Note that this function is not called for anything below version 8 since > those don't us

Re: [PATCH v7,1/3] soc: mediatek: Add mmsys func to adapt to dpi output for MT8186

2022-09-22 Thread AngeloGioacchino Del Regno
Il 22/09/22 09:29, xinlei@mediatek.com ha scritto: From: Xinlei Lee The difference between MT8186 and other ICs is that when modifying the output format, we need to modify the mmsys_base+0x400 register to take effect. So when setting the dpi output format, we need to call mmsys_func to set

[PATCH] drm/i915: Fix double word in comments

2022-09-22 Thread Bo Liu
Remove the repeated word "not" in comments. Signed-off-by: Bo Liu --- drivers/gpu/drm/i915/display/intel_bw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c index 4ace026b29bd..a5cb253f6dc

Re: [Intel-gfx] [RFC v4 08/14] drm/i915/vm_bind: Abstract out common execbuf functions

2022-09-22 Thread Tvrtko Ursulin
On 21/09/2022 19:17, Niranjana Vishwanathapura wrote: On Wed, Sep 21, 2022 at 11:18:53AM +0100, Tvrtko Ursulin wrote: On 21/09/2022 08:09, Niranjana Vishwanathapura wrote: The new execbuf3 ioctl path and the legacy execbuf ioctl paths have many common functionalities. Share code between thes

[PATCH resend v2] drm/amdgpu: fix enum conversion in display_mode_vba

2022-09-22 Thread Zeng Heng
Fix below compile warning when open enum-conversion option check (compiled with -Wenum-conversion): drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/display_mode_vba_20.c: In function ‘dml20_ModeSupportAndSystemConfigurationFull’: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/display_mode_v

Re: [PATCH 11/12] slab: Remove __malloc attribute from realloc functions

2022-09-22 Thread Miguel Ojeda
On Thu, Sep 22, 2022 at 5:10 AM Kees Cook wrote: > > -#ifdef __alloc_size__ > -# define __alloc_size(x, ...) __alloc_size__(x, ## __VA_ARGS__) __malloc > -#else > -# define __alloc_size(x, ...) __malloc > -#endif > +#define __alloc_size(x, ...) __alloc_size__(x, ## __VA_ARGS__) __malloc > +#de

Re: [RFC v4 02/14] drm/i915/vm_bind: Add __i915_sw_fence_await_reservation()

2022-09-22 Thread Jani Nikula
On Wed, 21 Sep 2022, Niranjana Vishwanathapura wrote: > Add function __i915_sw_fence_await_reservation() for > asynchronous wait on a dma-resv object with specified > dma_resv_usage. This is required for async vma unbind > with vm_bind. > > Signed-off-by: Niranjana Vishwanathapura > --- > drive

Re: [Intel-gfx] [PATCH] drm/i915: Remove unused function parameter

2022-09-22 Thread Tvrtko Ursulin
On 22/09/2022 05:43, Niranjana Vishwanathapura wrote: The function parameter 'exclude' in funciton i915_sw_fence_await_reservation() is not used. Remove it. Signed-off-by: Niranjana Vishwanathapura --- drivers/gpu/drm/i915/display/intel_atomic_plane.c | 5 ++--- drivers/gpu/drm/i915/gem/i9

Re: [Intel-gfx] [RFC v4 04/14] drm/i915/vm_bind: Implement bind and unbind of object

2022-09-22 Thread Jani Nikula
On Wed, 21 Sep 2022, Niranjana Vishwanathapura wrote: > Add uapi and implement support for bind and unbind of an > object at the specified GPU virtual addresses. > > The vm_bind mode is not supported in legacy execbuf2 ioctl. > It will be supported only in the newer execbuf3 ioctl. > > Signed-off

Re: [Intel-gfx] [RFC v4 07/14] drm/i915/vm_bind: Add out fence support

2022-09-22 Thread Jani Nikula
On Wed, 21 Sep 2022, Niranjana Vishwanathapura wrote: > Add support for handling out fence for vm_bind call. > > Signed-off-by: Niranjana Vishwanathapura > Signed-off-by: Andi Shyti > --- > drivers/gpu/drm/i915/gem/i915_gem_vm_bind.h | 4 + > .../drm/i915/gem/i915_gem_vm_bind_object.c|

Re: [PATCH v1] drivers:adp8870_bl: check the return value of adp8870_write

2022-09-22 Thread Daniel Thompson
On Wed, Sep 21, 2022 at 02:50:49PM -0700, Li Zhong wrote: > Subject: [PATCH v1] drivers:adp8870_bl: check the return value of > adp8870_write Should be backlight: adp8870_bl. > Check and propagate the return value of adp8870_write() when it fails, > which

Re: [PATCH] gpu: dc: fix enum conversion in display_mode_vba

2022-09-22 Thread Zeng Heng
I just correct the subject line and resend the patch mail. Please refer to: [PATCH resend v2] drm/amdgpu: fix enum conversion in display_mode_vba On 2022/9/19 15:44, Christian König wrote: Am 19.09.22 um 03:41 schrieb Zeng Heng: Fix below compile warning when open enum-conversion option chec

Re: [RFC v4 08/14] drm/i915/vm_bind: Abstract out common execbuf functions

2022-09-22 Thread Jani Nikula
On Wed, 21 Sep 2022, Niranjana Vishwanathapura wrote: > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer_common.h > b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer_common.h > new file mode 100644 > index ..725febfd6a53 > --- /dev/null > +++ b/drivers/gpu/drm/i915/gem/i915_gem

[PATCH v3 0/7] New DRM driver for Intel VPU

2022-09-22 Thread Jacek Lawrynowicz
Hi, This patchset contains a new Linux* Kernel Driver for Intel® VPUs. VPU stands for Versatile Processing Unit and it is an AI inference accelerator integrated with Intel non-server CPUs starting from 14th generation. VPU enables efficient execution of Deep Learning applications like object dete

[PATCH v3 1/7] drm/ivpu: Introduce a new DRM driver for Intel VPU

2022-09-22 Thread Jacek Lawrynowicz
VPU stands for Versatile Processing Unit and it's a CPU-integrated inference accelerator for Computer Vision and Deep Learning applications. The VPU device consist of following componensts: - Buttress - provides CPU to VPU integration, interrupt, frequency and power management. - Memory Ma

[PATCH v3 2/7] drm/ivpu: Add Intel VPU MMU support

2022-09-22 Thread Jacek Lawrynowicz
VPU Memory Management Unit is based on ARM MMU-600. It allows to create multiple virtual address spaces for the device and map noncontinuous host memory (there is no dedicated memory on the VPU). Address space is implemented as a struct ivpu_mmu_context, it has an ID, drm_mm allocator for VPU addr

[PATCH v3 3/7] drm/ivpu: Add GEM buffer object management

2022-09-22 Thread Jacek Lawrynowicz
Adds four types of GEM-based BOs for the VPU: - shmem - userptr - internal - prime All types are implemented as struct ivpu_bo, based on struct drm_gem_object. VPU address is allocated when buffer is created except for imported prime buffers that allocate it in BO_INFO IOCTL due to missing

[PATCH v3 5/7] drm/ivpu: Implement firmware parsing and booting

2022-09-22 Thread Jacek Lawrynowicz
Read, parse and boot VPU firmware image. Signed-off-by: Andrzej Kacprowski Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz --- drivers/gpu/drm/ivpu/Makefile | 1 + drivers/gpu/drm/ivpu/ivpu_drv.c | 122 +++- drivers/gpu/drm/ivpu/ivpu_drv.h | 10 + drive

[PATCH v3 7/7] drm/ivpu: Add PM support

2022-09-22 Thread Jacek Lawrynowicz
- Implement cold and warm firmware boot flows - Add hang recovery support - Add runtime power management support Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz --- drivers/gpu/drm/ivpu/Makefile | 3 +- drivers/gpu/drm/ivpu/ivpu_drv.c| 34 ++- drivers/gpu/d

[PATCH v3 4/7] drm/ivpu: Add IPC driver and JSM messages

2022-09-22 Thread Jacek Lawrynowicz
The IPC driver is used to send and receive messages to/from firmware running on the VPU. The only supported IPC message format is Job Submission Model (JSM) defined in vpu_jsm_api.h header. Signed-off-by: Andrzej Kacprowski Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz --

[PATCH v3 6/7] drm/ivpu: Add command buffer submission logic

2022-09-22 Thread Jacek Lawrynowicz
Each of the user contexts has two command queues, one for compute engine and one for the copy engine. Command queues are allocated and registered in the device when the first job (command buffer) is submitted from the user space to the VPU device. The userspace provides a list of GEM buffer object

Re: [PATCH v7 06/12] dt-bindings: display/msm: split dpu-sc7180 into DPU and MDSS parts

2022-09-22 Thread Dmitry Baryshkov
On Thu, 22 Sept 2022 at 10:08, Krzysztof Kozlowski wrote: > > On 15/09/2022 15:37, Dmitry Baryshkov wrote: > > In order to make the schema more readable, split dpu-sc7180 into the DPU > > and MDSS parts, each one describing just a single device binding. > > > > Signed-off-by: Dmitry Baryshkov > >

Re: [PATCH AUTOSEL 5.4 3/5] drm/amdgpu: use dirty framebuffer helper

2022-09-22 Thread Michel Dänzer
On 2022-09-21 17:54, Sasha Levin wrote: > From: Hamza Mahfooz > > [ Upstream commit 66f99628eb24409cb8feb5061f78283c8b65f820 ] > > Currently, we aren't handling DRM_IOCTL_MODE_DIRTYFB. So, use > drm_atomic_helper_dirtyfb() as the dirty callback in the amdgpu_fb_funcs > struct. > > Signed-off-by

Re: [PATCH 01/12] slab: Introduce kmalloc_size_roundup()

2022-09-22 Thread Hyeonggon Yoo
On Wed, Sep 21, 2022 at 08:10:02PM -0700, Kees Cook wrote: > In the effort to help the compiler reason about buffer sizes, the > __alloc_size attribute was added to allocators. This improves the scope > of the compiler's ability to apply CONFIG_UBSAN_BOUNDS and (in the near > future) CONFIG_FORTIFY

[PATCH 2/5] drm/msm/dsi: add support for DSI 2.6.0

2022-09-22 Thread Dmitry Baryshkov
Add support for DSI 2.6.0 (block used on sm8450). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 2 ++ drivers/gpu/drm/msm/dsi/dsi_cfg.h | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_cfg.c index 7e9

[PATCH 3/5] drm/msm/dpu: add support for MDP_TOP blackhole

2022-09-22 Thread Dmitry Baryshkov
On sm8450 a register block was removed from MDP TOP. Accessing it during snapshotting results in NoC errors / immediate reboot. Skip accessing these registers during snapshot. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 1 + drivers/gpu/drm/msm/disp/dpu1

[PATCH 0/5] drm/msm: add support for SM8450

2022-09-22 Thread Dmitry Baryshkov
This adds support for the MDSS/DPU/DSI on the Qualcomm SM8450 platform. Dmitry Baryshkov (5): drm/msm/dsi: add support for DSI-PHY on SM8350 and SM8450 drm/msm/dsi: add support for DSI 2.6.0 drm/msm/dpu: add support for MDP_TOP blackhole drm/msm/dpu: add support for SM8450 drm/msm: mdss

[PATCH 5/5] drm/msm: mdss add support for SM8450

2022-09-22 Thread Dmitry Baryshkov
Add support for the MDSS block on SM8450 platform. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index e13c5c12b775..9e011762396b 100644 --- a/drivers/

[PATCH 1/5] drm/msm/dsi: add support for DSI-PHY on SM8350 and SM8450

2022-09-22 Thread Dmitry Baryshkov
SM8350 and SM8450 use 5nm DSI PHYs, which share register definitions with 7nm DSI PHYs. Rather than duplicating the driver, handle 5nm variants inside the common 5+7nm driver. Co-developed-by: Robert Foss Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/Kconfig | 6 +- dr

[PATCH 4/5] drm/msm/dpu: add support for SM8450

2022-09-22 Thread Dmitry Baryshkov
Add definitions for the display hardware used on Qualcomm SM8450 platform. Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 224 ++ .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h| 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h | 3 + dri

[PATCH v3 2/4] drm/ofdrm: Add CRTC state

2022-09-22 Thread Thomas Zimmermann
Add a dedicated CRTC state to ofdrm to later store information for palette updates. v3: * rework CRTC state helpers (Javier) Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/tiny/ofdrm.c | 59 ++-- 1 file changed

[PATCH v3 0/4] drm: Add driver for PowerPC OF displays

2022-09-22 Thread Thomas Zimmermann
PowerPC's Open Firmware offers a simple display buffer for graphics output. Add ofdrm, a DRM driver for the device. As with the existing simpledrm driver, the graphics hardware is pre-initialized by the firmware. The driver only provides blitting, no actual DRM modesetting is possible. For version

[PATCH v3 3/4] drm/ofdrm: Add per-model device function

2022-09-22 Thread Thomas Zimmermann
Add a per-model device-function structure in preparation of adding color-management support. Detection of the individual models has been taken from fbdev's offb. v3: * define constants for PCI ids (Javier) Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drive

[PATCH v3 1/4] drm/ofdrm: Add ofdrm for Open Firmware framebuffers

2022-09-22 Thread Thomas Zimmermann
Open Firmware provides basic display output via the 'display' node. DT platform code already provides a device that represents the node's framebuffer. Add a DRM driver for the device. The display mode and color format is pre-initialized by the system's firmware. Runtime modesetting via DRM is not p

[PATCH v3 4/4] drm/ofdrm: Support color management

2022-09-22 Thread Thomas Zimmermann
Support the CRTC's color-management property and implement each model's palette support. The OF hardware has different methods of setting the palette. The respective code has been taken from fbdev's offb and refactored into per-model device functions. The device functions integrate this functional

Re: [PATCH v7 04/12] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml

2022-09-22 Thread Krzysztof Kozlowski
On 22/09/2022 09:50, Dmitry Baryshkov wrote: > On Thu, 22 Sept 2022 at 10:02, Krzysztof Kozlowski > wrote: >> >> On 15/09/2022 15:37, Dmitry Baryshkov wrote: >>> Move properties common to all DPU DT nodes to the dpu-common.yaml. >>> >>> Note, this removes description of individual DPU port@ nodes.

Re: [PATCH v7 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml

2022-09-22 Thread Krzysztof Kozlowski
On 22/09/2022 09:53, Dmitry Baryshkov wrote: > On Thu, 22 Sept 2022 at 10:05, Krzysztof Kozlowski > wrote: >> >> On 15/09/2022 15:37, Dmitry Baryshkov wrote: >>> Move properties common to all MDSS DT nodes to the mdss-common.yaml. >>> >>> This extends qcom,msm8998-mdss schema to allow interconnect

Re: [Freedreno] [PATCH 0/5] drm/msm: add support for SM8450

2022-09-22 Thread Vinod Koul
On 22-09-22, 14:30, Dmitry Baryshkov wrote: > This adds support for the MDSS/DPU/DSI on the Qualcomm SM8450 platform. Tested this on DM8450-HDK with HDMI and it works for me. For whole series: Tested-by: Vinod Koul Reviewed-by: Vinod Koul > > Dmitry Baryshkov (5): > drm/msm/dsi: add suppor

Re: [PATCH v7 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml

2022-09-22 Thread Dmitry Baryshkov
On 22/09/2022 14:43, Krzysztof Kozlowski wrote: On 22/09/2022 09:53, Dmitry Baryshkov wrote: On Thu, 22 Sept 2022 at 10:05, Krzysztof Kozlowski wrote: On 15/09/2022 15:37, Dmitry Baryshkov wrote: Move properties common to all MDSS DT nodes to the mdss-common.yaml. This extends qcom,msm8998-

Re: [PATCH v7 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml

2022-09-22 Thread Dmitry Baryshkov
On 22/09/2022 10:04, Krzysztof Kozlowski wrote: On 15/09/2022 15:37, Dmitry Baryshkov wrote: Move properties common to all MDSS DT nodes to the mdss-common.yaml. This extends qcom,msm8998-mdss schema to allow interconnect nodes, which will be added later, once msm8998 gains interconnect support

Re: [PATCH v7,1/3] soc: mediatek: Add mmsys func to adapt to dpi output for MT8186

2022-09-22 Thread xinlei . lee
On Thu, 2022-09-22 at 10:16 +0200, AngeloGioacchino Del Regno wrote: > Il 22/09/22 09:29, xinlei@mediatek.com ha scritto: > > From: Xinlei Lee > > > > The difference between MT8186 and other ICs is that when modifying > > the > > output format, we need to modify the mmsys_base+0x400 register

[PATCH] drm/i915: Improve debug print in vm_fault_ttm

2022-09-22 Thread Nirmoy Das
Print the error code returned by __i915_ttm_migrate() for better debuggability. References: https://gitlab.freedesktop.org/drm/intel/-/issues/6889 Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu

Re: [PATCH v7 06/12] dt-bindings: display/msm: split dpu-sc7180 into DPU and MDSS parts

2022-09-22 Thread Krzysztof Kozlowski
On 22/09/2022 12:30, Dmitry Baryshkov wrote: >>> +display-subsystem@ae0 { >>> +#address-cells = <1>; >>> +#size-cells = <1>; >>> +compatible = "qcom,sc7180-mdss"; >>> +reg = <0xae0 0x1000>; >>> +reg-names = "mdss"; >>> +power-domains = <&d

Re: [PATCH v7 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml

2022-09-22 Thread Krzysztof Kozlowski
On 22/09/2022 13:47, Dmitry Baryshkov wrote: missing allOf >>> >>> Rob asked to remove this while reviewing v6 ([1]). And indeed the >>> allOf's around a single $ref do not seem to be necessary >> >> He commented on one of properties, not top-level, maybe it is different >> case for dtsc

Re: [PATCH v7 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml

2022-09-22 Thread Krzysztof Kozlowski
On 22/09/2022 13:46, Dmitry Baryshkov wrote: >>> - ranges: true >>> +maxItems: 2 >>> >>> interconnects: >>> -items: >>> - - description: Interconnect path from mdp0 port to the data bus >>> - - description: Interconnect path from mdp1 port to the data bus >>> +maxItems

[PATCH v8,0/3] Add dpi output format control for MT8186

2022-09-22 Thread xinlei.lee
From: Xinlei Lee Base on the branch of ck-linux-next/mediatek-drm-fixes. Changes since v7: 1. This series is based on the following patch: [1] soc: mediatek: Add mmsys func to adapt to dpi output for MT8186 https://patchwork.kernel.org/project/linux-mediatek/patch/1663161662-1598-2-git-se

[PATCH v8, 1/3] soc: mediatek: Add all settings to mtk_mmsys_ddp_dpi_fmt_config func

2022-09-22 Thread xinlei.lee
From: Xinlei Lee The difference between MT8186 and other ICs is that when modifying the output format, we need to modify the mmsys_base+0x400 register to take effect. So when setting the dpi output format, we need to call mmsys_func to set it to MT8186 synchronously. Adding mmsys all the settings

[PATCH v8, 3/3] drm: mediatek: Add mt8186 dpi compatibles and platform data

2022-09-22 Thread xinlei.lee
From: Xinlei Lee Add the compatible because use edge_cfg_in_mmsys in mt8186. Signed-off-by: Xinlei Lee --- drivers/gpu/drm/mediatek/mtk_dpi.c | 21 + drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++ 2 files changed, 23 insertions(+) diff --git a/drivers/gpu/drm/mediatek

[PATCH v8,2/3]drm: mediatek: Adjust the dpi output format to MT8186

2022-09-22 Thread xinlei.lee
From: Xinlei Lee Due to the mt8186 hardware changes, we need to modify the dpi output format corresponding to the mmsys register(mmsys_base+0x400). Because different sink ICs may support other output formats. The current DRM architecture supports retrieving the output format of all bridges (eg

Re: [PATCH v1 01/17] dt-bindings: clk: mediatek: Add MT8195 DPI clocks

2022-09-22 Thread Guillaume Ranquet
On Thu, 22 Sep 2022 09:11, Krzysztof Kozlowski wrote: >On 19/09/2022 18:55, Guillaume Ranquet wrote: >> From: Pablo Sun >> >> Expand dt-bindings slot for VDOSYS1 of MT8195. >> This clock is required by the DPI1 hardware >> and is a downstream of the HDMI pixel clock. >> >> Signed-off-by: Pablo Su

Re: [PATCH v1 01/17] dt-bindings: clk: mediatek: Add MT8195 DPI clocks

2022-09-22 Thread Krzysztof Kozlowski
On 22/09/2022 14:45, Guillaume Ranquet wrote: > On Thu, 22 Sep 2022 09:11, Krzysztof Kozlowski > wrote: >> On 19/09/2022 18:55, Guillaume Ranquet wrote: >>> From: Pablo Sun >>> >>> Expand dt-bindings slot for VDOSYS1 of MT8195. >>> This clock is required by the DPI1 hardware >>> and is a downstre

Re: [PATCH v1 01/17] dt-bindings: clk: mediatek: Add MT8195 DPI clocks

2022-09-22 Thread Krzysztof Kozlowski
On 19/09/2022 18:55, Guillaume Ranquet wrote: > From: Pablo Sun > > Expand dt-bindings slot for VDOSYS1 of MT8195. > This clock is required by the DPI1 hardware > and is a downstream of the HDMI pixel clock. > > Signed-off-by: Pablo Sun > Signed-off-by: Guillaume Ranquet > Reviewed-by: Mattijs

Re: [PATCH v1 03/17] dt-bindings: phy: mediatek: hdmi-phy: Add mt8195 compatible

2022-09-22 Thread Krzysztof Kozlowski
On 19/09/2022 18:56, Guillaume Ranquet wrote: > Add a compatible for the HDMI PHY on MT8195 > > Signed-off-by: Guillaume Ranquet > Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

[PATCH 1/5] drm/simpledrm: Compute linestride with drm_format_info_min_pitch()

2022-09-22 Thread Thomas Zimmermann
If not given, compute the stride with drm_format_info_min_pitch(). It's the standard helper for this purpose. Suggested-by: Daniel Vetter Signed-off-by: Thomas Zimmermann Fixes: fd9e3169e42b ("drm/simpledrm: Compute framebuffer stride if not set") Cc: Javier Martinez Canillas Cc: dri-devel@list

[PATCH 2/5] drm/simpledrm: Use drm_atomic_get_new_plane_state()

2022-09-22 Thread Thomas Zimmermann
Lookup the plane's state in atomic_update with the helper drm_atomic_get_new_plane_state(). Also rename the helpers' state arguments. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tiny/simpledrm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff -

[PATCH 0/5] drm/simpledrm: Various improvements

2022-09-22 Thread Thomas Zimmermann
This patchset contains various improvements to simpledrm that have piled up over time. Thomas Zimmermann (5): drm/simpledrm: Compute linestride with drm_format_info_min_pitch() drm/simpledrm: Use drm_atomic_get_new_plane_state() drm/simpledrm: Remove !fb check from atomic_update drm/simple

[PATCH 5/5] drm/simpledrm: Synchronize access to GEM BOs

2022-09-22 Thread Thomas Zimmermann
Synchronize CPU access to GEM BOs with other drivers when updating the screen buffer. Imported buffers might otherwise contain stale data. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tiny/simpledrm.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/

[PATCH 3/5] drm/simpledrm: Remove !fb check from atomic_update

2022-09-22 Thread Thomas Zimmermann
The primary plane implements atomic_disable, so atomic_update will not be called without a framebuffer set. Remove the test for !fb. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tiny/simpledrm.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/tiny/simpledrm.c b/driv

[PATCH 4/5] drm/simpledrm: Iterate over damage clips

2022-09-22 Thread Thomas Zimmermann
Iterate over all damage clips and updated them one by one. Replaces the merging of damage areas, which can result in significant overhead if damage areas are not close to each other. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tiny/simpledrm.c | 24 +--- 1 file chang

Re: [PATCH 1/2] drm/rockchip: dw_hdmi: relax mode_valid hook

2022-09-22 Thread Robin Murphy
On 25/08/2022 12:40 pm, Sascha Hauer wrote: On Wed, Aug 24, 2022 at 05:07:50PM +0100, Robin Murphy wrote: On 2022-08-22 16:20, Sascha Hauer wrote: The driver checks if the pixel clock of the given mode matches an entry in the mpll config table. The frequencies in the mpll table are meant as a f

Re: [PATCH 04/12] btrfs: send: Proactively round up to kmalloc bucket size

2022-09-22 Thread David Sterba
On Wed, Sep 21, 2022 at 08:10:05PM -0700, Kees Cook wrote: > Instead of discovering the kmalloc bucket size _after_ allocation, round > up proactively so the allocation is explicitly made for the full size, > allowing the compiler to correctly reason about the resulting size of > the buffer through

Re: [PATCH 03/12] net: ipa: Proactively round up to kmalloc bucket size

2022-09-22 Thread Alex Elder
On 9/21/22 10:10 PM, Kees Cook wrote: Instead of discovering the kmalloc bucket size _after_ allocation, round up proactively so the allocation is explicitly made for the full size, allowing the compiler to correctly reason about the resulting size of the buffer through the existing __alloc_size(

[PATCH v2 01/10] drm/panel: db7430: Silence no spi_device_id warning

2022-09-22 Thread Wei Yongjun
From: Wei Yongjun SPI devices use the spi_device_id for module autoloading even on systems using device tree, after commit 5fa6863ba692 ("spi: Check we have a spi_device_id for each DT compatible"), kernel warns as follows since the spi_device_id is missing: SPI driver db7430-panel has no spi_de

[PATCH v2 03/10] drm/panel: innolux-ej030na: Silence no spi_device_id warning

2022-09-22 Thread Wei Yongjun
From: Wei Yongjun SPI devices use the spi_device_id for module autoloading even on systems using device tree, after commit 5fa6863ba692 ("spi: Check we have a spi_device_id for each DT compatible"), kernel warns as follows since the spi_device_id is missing: SPI driver panel-innolux-ej030na has

  1   2   3   >