Re: [PATCH v2 1/6] dt-bindings: arm: mediatek: mmsys: change compatible for MT8195

2022-09-18 Thread Krzysztof Kozlowski
On 16/09/2022 04:34, Jason-JH Lin wrote: > Hi Matthias, > > Thanks for the review. > > On Fri, 2022-09-16 at 00:05 +0200, Matthias Brugger wrote: >> >> On 15/09/2022 18:18, Jason-JH.Lin wrote: >>> For previous MediaTek SoCs, such as MT8173, there are 2 display HW >>> pipelines binding to 1 mmsys

Re: [PATCH RESEND v3 1/9] dt-bindings: mediatek: modify item formatting for gamma

2022-09-18 Thread Krzysztof Kozlowski
On 12/09/2022 02:29, Jason-JH.Lin wrote: > From: "zheng-yan.chen" > > Since the items with only one const should be dedicated as enum, > merge all such items into one enum item. > > Fixes: 4ed545e7d100 ("dt-bindings: display: mediatek: disp: split each block > to individual yaml") > Signed-off-

Re: [PATCH RESEND v3 2/9] dt-bindings: mediatek: Add gamma compatible for mt8195

2022-09-18 Thread Krzysztof Kozlowski
On 12/09/2022 02:29, Jason-JH.Lin wrote: > From: "zheng-yan.chen" > > mt8195 uses 10bit-to-12bit gamma-LUT, which is not compatible with > current 9bit-to-10bit gamma-LUT. > > This patch thus add constant compatible for mt8195, which means that > mt8195 should only use specified mt8195 gamma dri

Re: [PATCH] drm/bridge: ti-sn65dsi83: Add and use hs_rate and lp_rate

2022-09-18 Thread Marek Vasut
On 8/1/22 15:11, Marek Vasut wrote: Fill in hs_rate and lp_rate to struct mipi_dsi_device for this bridge and adjust DSI input frequency calculations such that they expect the DSI host to configure HS clock according to hs_rate. This is an optimization for the DSI burst mode case. In case the DS

Re: [PATCH v3 0/3] KUnit tests for RGB888, XRGB2101010 and grayscale

2022-09-18 Thread José Expósito
Hi! On Sun, Aug 28, 2022 at 06:45:14PM +0200, José Expósito wrote: > Hello everyone, > > This series is a follow up on my work adding KUnit test to the XRGB > conversion functions. This time RGB888, XRGB2101010 and gray8 are added. > > Best wishes, > Jose > > v1 -> v2: > > Tested-by: M

Re: [PATCH v3 0/3] KUnit tests for RGB888, XRGB2101010 and grayscale

2022-09-18 Thread Maíra Canal
Hi Jose, On 9/18/22 10:22, José Expósito wrote: > Hi! > > On Sun, Aug 28, 2022 at 06:45:14PM +0200, José Expósito wrote: >> Hello everyone, >> >> This series is a follow up on my work adding KUnit test to the XRGB >> conversion functions. This time RGB888, XRGB2101010 and gray8 are added. >>

Re: [PATCH] drm/amdgpu: use dirty framebuffer helper

2022-09-18 Thread root
Hi, I recently experienced lock-ups that only responded to magic sysreq reboots when the amdgpu module was loading on my pc (Athlon II X4 640 CPU, with Radeon R7 250 - Cape Verde). .config has: CONFIG_DRM_AMDGPU=m CONFIG_DRM_AMDGPU_SI=y # CONFIG_DRM_AMDGPU_CIK is not set # CONFIG_DRM_AMDGPU_USER

[PATCH 2/2] video: fbdev: uvesafb: convert snprintf to scnprintf

2022-09-18 Thread Jules Irenge
Coccinelle reports a warning WARNING: use scnprintf or sprintf Adding to that, there has also been some slow migration from snprintf to scnprintf This article explains the rationale for this change https: //lwn.net/Articles/69419/ Signed-off-by: Jules Irenge --- drivers/video/fbdev/uvesafb.c |

Re: [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry.

2022-09-18 Thread Zheng Hacker
I'll try using another mail client like Mutt later. :) Regards, Zheng Wang Greg KH 于2022年9月17日周六 17:07写道: > > On Fri, Sep 16, 2022 at 11:54:42PM +0800, Zheng Hacker wrote: > > >From afe79848cb74cc8e45ab426d13fa2394c87e0422 Mon Sep 17 00:00:00 2001 > > From: xmzyshypnc <1002992...@qq.com> > > Dat

Re: [PATCH v3 0/5] drm/gma500: Backlight handling changes

2022-09-18 Thread Patrik Jakobsson
On Sat, Sep 17, 2022 at 10:59 PM Hans de Goede wrote: > > Hi All, > > Here is a patch-series changing gma500's backlight handling to match > the changes done to the other major x86 GPU drivers in the just landed > backlight detection refactor patch series: > https://lore.kernel.org/dri-devel/261af

Re: [PATCH 0/6] drm/gma500: 1 fix + further cleanups

2022-09-18 Thread Patrik Jakobsson
On Sat, Sep 17, 2022 at 2:31 PM Hans de Goede wrote: > > Hi Patrik, > > On 9/14/22 09:50, Patrik Jakobsson wrote: > > On Fri, Sep 9, 2022 at 1:56 PM Hans de Goede wrote: > >> > >> Hi Patrik, > >> > >> Here is another gma500 patch-series with one more bugfix and a bunch > >> of other cleanups of s

Re: [PATCH v3 0/5] drm/gma500: Backlight handling changes

2022-09-18 Thread Sam Ravnborg
Hi Hans, > > Changes in v3: > > - Fix unused variable warnings when CONFIG_BACKLIGHT is not selected by > > marking the 2 variables as __maybe_unused. > > This looks good to me. I don't have access to my DIM setup in a couple > of days so please push these yourself if possible. > > For the en

Re: [PATCH v3 0/5] drm/gma500: Backlight handling changes

2022-09-18 Thread Hans de Goede
Hi Patrik, On 9/18/22 20:22, Patrik Jakobsson wrote: > On Sat, Sep 17, 2022 at 10:59 PM Hans de Goede wrote: >> >> Hi All, >> >> Here is a patch-series changing gma500's backlight handling to match >> the changes done to the other major x86 GPU drivers in the just landed >> backlight detection re

Re: [PATCH v3 0/5] drm/gma500: Backlight handling changes

2022-09-18 Thread Hans de Goede
Hi Sam, On 9/18/22 20:51, Sam Ravnborg wrote: > Hi Hans, > >>> Changes in v3: >>> - Fix unused variable warnings when CONFIG_BACKLIGHT is not selected by >>> marking the 2 variables as __maybe_unused. >> >> This looks good to me. I don't have access to my DIM setup in a couple >> of days so pl

Re: [PATCH 0/6] drm/gma500: 1 fix + further cleanups

2022-09-18 Thread Hans de Goede
Hi Patrik, On 9/18/22 20:45, Patrik Jakobsson wrote: > On Sat, Sep 17, 2022 at 2:31 PM Hans de Goede wrote: >> >> Hi Patrik, >> >> On 9/14/22 09:50, Patrik Jakobsson wrote: >>> On Fri, Sep 9, 2022 at 1:56 PM Hans de Goede wrote: Hi Patrik, Here is another gma500 patch-series

linux-next: manual merge of the drm tree with Linus' tree

2022-09-18 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c between commit: 41012d715d5d ("drm/amd/display: Mark dml30's UseMinimumDCFCLK() as noinline for stack usage") from Linus' tree and commit: a0f7e7f759cf ("d

[PATCH 0/3] drm/meson: fix use-after-free driver unload issues

2022-09-18 Thread Adrián Larumbe
This patch series tries to fix some use-after-free bugs I've observed with the help of KASAN in Amlogic's KMS DRM driver. The first patch in the series reorders the driver deinitialisation sequence so that devres won't deallocate things that are still expected to be around by a later call to drm_d

[PATCH 1/3] drm/meson: reorder driver deinit sequence to fix use-after-free bug

2022-09-18 Thread Adrián Larumbe
Unloading the driver triggers the following KASAN warning: [ +0.006275] = [ +0.29] BUG: KASAN: use-after-free in __list_del_entry_valid+0xe0/0x1a0 [ +0.26] Read of size 8 at addr 20c395e0 by task rmmod/2695 [ +0.1

[PATCH 3/3] drm/meson: remove drm bridges at aggregate driver unbind time

2022-09-18 Thread Adrián Larumbe
drm bridges added by meson_encoder_hdmi_init and meson_encoder_cvbs_init were not manually removed at module unload time, which caused dangling references to freed memory to remain linked in the global bridge_list. When loading the driver modules back in, the same functions would again call drm_br

[PATCH 2/3] drm/meson: explicitly remove aggregate driver at module unload time

2022-09-18 Thread Adrián Larumbe
Because component_master_del wasn't being called when unloading the meson_drm module, the aggregate device would linger forever in the global aggregate_devices list. That means when unloading and reloading the meson_dw_hdmi module, component_add would call into try_to_bring_up_aggregate_device and

Re: [PATCH v2 1/6] dt-bindings: arm: mediatek: mmsys: change compatible for MT8195

2022-09-18 Thread Jason-JH Lin
Hi Krzysztof, Thanks for the reviews. On Sun, 2022-09-18 at 10:31 +0100, Krzysztof Kozlowski wrote: > On 16/09/2022 04:34, Jason-JH Lin wrote: > > Hi Matthias, > > > > Thanks for the review. > > > > On Fri, 2022-09-16 at 00:05 +0200, Matthias Brugger wrote: > > > > > > On 15/09/2022 18:18, Jas

Re: [PATCH] gpu: color: eliminate implicit conversion about enum type

2022-09-18 Thread Wei Yongjun
gpu: color: fix enum-conversion compile warning 标题我记得不跟你所过让你改的 On 2022/9/19 9:44, Zeng Heng wrote: > Fix below compile warning when open enum-conversion > option check: > > drivers/gpu/drm/amd/amdgpu/../display/modules/color/color_gamma.c: > In function ‘apply_degamma_for_user_regamma’: > drive

[PATCH] drm/amd/display: remove redundant CalculateTWait's

2022-09-18 Thread Tom Rix
There are several copies of CalculateTwait. Reduce to one instance and change local variable name to match common usage. Signed-off-by: Tom Rix --- .../dc/dml/dcn20/display_mode_vba_20.c| 16 +++--- .../dc/dml/dcn20/display_mode_vba_20v2.c | 21 ++- .../dc/dm

Re: [PATCH] gpu: dc: fix enum conversion in display_mode_vba

2022-09-18 Thread Wei Yongjun
On 2022/9/19 9:41, Zeng Heng wrote: > Fix below compile warning when open enum-conversion > option check (compiled with -Wenum-conversion): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/display_mode_vba_20.c: > In function ‘dml20_ModeSupportAndSystemConfigurationFull’: > drivers/gpu/dr

Re: drm/amdgpu: use dirty framebuffer helper

2022-09-18 Thread Arthur Marsh
I have done a delayed load of amdgpu with the 6.0-rc6 kernel using: modprobe amdgpu si_support=1 and saved the dmesg output: [ 455.424263] udevd[414]: specified group 'sgx' unknown [ 455.514818] ACPI: bus type drm_connector registered [ 457.759316] [drm] amdgpu kernel modesetting enabled. [

Re: [PATCH v2] drm: mediatek: Fix display vblank timeout when disable dsi

2022-09-18 Thread Allen-KH Cheng
Hi CK, We will test this fix on the mt8186/mt8183. Maybe our fix is not necessary. I appreciate your suggestion. BRs, Allen On 9/18/22 12:32, Chun-Kuang Hu wrote: > Hi, Allen: > > Allen-KH Cheng 於 2022年9月14日 週三 晚上10:00寫道: >> >> From: Xinlei Lee >> >> Dsi is turned off at bridge.disable, caus

[PATCH] drm: bridge/dw-hdmi-ahb-audio: use strscpy() is more robust and safer

2022-09-18 Thread cgel . zte
From: Minghao Chi The implementation of strscpy() is more robust and safer. That's now the recommended way to copy NUL terminated strings. Reported-by: Zeal Robot Signed-off-by: Minghao Chi --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [PATCH v4 02/12] drm: bridge: Add Samsung DSIM bridge driver

2022-09-18 Thread Marek Szyprowski
Hi Jagan, On 16.09.2022 12:21, Jagan Teki wrote: > On Fri, Sep 16, 2022 at 1:58 PM Marek Szyprowski > wrote: >> On 14.09.2022 11:39, Jagan Teki wrote: >>> On Wed, Sep 14, 2022 at 2:51 PM Marek Szyprowski >>> wrote: On 13.09.2022 19:29, Jagan Teki wrote: > On Wed, Sep 7, 2022 at 3:34 PM

Re: [PATCH v3 0/3] KUnit tests for RGB888, XRGB2101010 and grayscale

2022-09-18 Thread José Expósito
On Sun, Sep 18, 2022 at 01:26:06PM -0300, Maíra Canal wrote: > Hi Jose, > > On 9/18/22 10:22, José Expósito wrote: > > Hi! > > > > On Sun, Aug 28, 2022 at 06:45:14PM +0200, José Expósito wrote: > >> Hello everyone, > >> > >> This series is a follow up on my work adding KUnit test to the XRGB

[PATCH v2] virtio-gpu: fix shift wrapping bug in virtio_gpu_fence_event_create()

2022-09-18 Thread Dan Carpenter
The ->ring_idx_mask variable is a u64 so static checkers, Smatch in this case, complain if the BIT() is not also a u64. drivers/gpu/drm/virtio/virtgpu_ioctl.c:50 virtio_gpu_fence_event_create() warn: should '(1 << ring_idx)' be a 64 bit type? Fixes: cd7f5ca33585 ("drm/virtio: implement context in

RE: [Intel-gfx] [PATCH] drm/i915/mtl: Add MTL forcewake support

2022-09-18 Thread Chegondi, Harish
Reviewed-by: Harish Chegondi -Original Message- From: Intel-gfx On Behalf Of Matt Roper Sent: Friday, September 9, 2022 5:17 PM To: intel-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Subject: [Intel-gfx] [PATCH] drm/i915/mtl: Add MTL forcewake support MTL has separate

Re: [PATCH] drm/panfrost: Give name to anonymous coredump object union

2022-09-18 Thread Adrián Larumbe
Hi Steven, On 13.09.2022 09:45, Steven Price wrote: >On 12/09/2022 17:44, Adrián Larumbe wrote: >> Building Mesa's Perfetto requires including the panfrost drm uAPI header in >> C++ code, but the C++ compiler requires anonymous unions to have only >> public non-static data members. >> >> Commit 7

Re: [PATCH] drm/amdgpu: use dirty framebuffer helper

2022-09-18 Thread Thomas Zimmermann
Hi Am 06.09.22 um 21:57 schrieb Hamza Mahfooz: Currently, we aren't handling DRM_IOCTL_MODE_DIRTYFB. So, use drm_atomic_helper_dirtyfb() as the dirty callback in the amdgpu_fb_funcs struct. drm_atomic_helper_dirtyfb() creates a new atomic commit for the frambuffer's planes. Drivers can then u