Re: [PATCH] drm/i915: Fix return type of mode_valid function hook

2022-09-15 Thread Jani Nikula
On Tue, 13 Sep 2022, Nathan Chancellor wrote: > On Tue, Sep 13, 2022 at 01:55:27PM -0700, Nathan Huckleberry wrote: >> All of the functions used for intel_dvo_dev_ops.mode_valid have a return >> type of enum drm_mode_status, but the mode_valid field in the struct >> definition has a return type of

Re: [PATCH v1 2/7] clk: bcm: rpi: Add a function to retrieve the maximum

2022-09-15 Thread Maxime Ripard
On Wed, Sep 14, 2022 at 08:26:55PM +0200, Stefan Wahren wrote: > Am 14.09.22 um 20:14 schrieb Stephen Boyd: > > Quoting Stefan Wahren (2022-09-14 11:09:04) > > > Am 14.09.22 um 20:05 schrieb Stephen Boyd: > > > > Quoting Stefan Wahren (2022-09-14 10:45:48) > > > > > Am 14.09.22 um 17:50 schrieb Ste

Re: [PATCH v1 2/7] clk: bcm: rpi: Add a function to retrieve the maximum

2022-09-15 Thread Maxime Ripard
Hi, On Wed, Sep 14, 2022 at 11:20:59AM -0700, Stephen Boyd wrote: > Quoting Stefan Wahren (2022-09-14 11:09:04) > > Am 14.09.22 um 20:05 schrieb Stephen Boyd: > > > Quoting Stefan Wahren (2022-09-14 10:45:48) > > >> Am 14.09.22 um 17:50 schrieb Stephen Boyd: > > >>> Furthermore, I wonder if even t

Re: [Intel-gfx] [PATCH 1/1] drm/i915/uc: Update to latest GuC and use new-format GuC/HuC names

2022-09-15 Thread Tvrtko Ursulin
Hi, On 15/09/2022 00:46, john.c.harri...@intel.com wrote: From: John Harrison Going forwards, the intention is for GuC firmware files to be named for their major version only and HuC firmware files to have no version number in the name at all. This patch adds those entries for all platforms

Re: [PATCH -next] drm/mediatek: dp: change mtk_dp_driver to static

2022-09-15 Thread Dmitry Osipenko
On 9/13/22 16:49, Yang Yingliang wrote: > mtk_dp_driver is only used in mtk_dp.c now, change it > to static. > > Fixes: f70ac097a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort driver") > Signed-off-by: Yang Yingliang > --- > drivers/gpu/drm/mediatek/mtk_dp.c | 2 +- > 1 file changed, 1 inse

[PATCH] A simple doc fix

2022-09-15 Thread Anup K Parikh
Fix two warnings during doc build which also results in corresponding additions in generated docs Warnings Fixed: 1. include/drm/gpu_scheduler.h:462: warning: Function parameter or member 'dev' not described in 'drm_gpu_scheduler' 2. drivers/gpu/drm/scheduler/sched_main.c:1005: warning: Functio

Re: [PATCH] A simple doc fix

2022-09-15 Thread Anup K Parikh
On Wed, Sep 14, 2022 at 10:24:36AM -0400, Andrey Grodzovsky wrote: > > On 2022-09-14 06:36, Anup K Parikh wrote: > > Fix two warnings during doc build which also results in corresponding > > additions in generated docs > > > > Warnings Fixed: > > 1. include/drm/gpu_scheduler.h:462: warning: Funct

[PATCH v1 0/2] Fix chrontel-ch7033 reversion

2022-09-15 Thread Robert Foss
When the chrontel-ch7033 series from Chris Morgan was reverted[1], I made mistake. Patch 2/2 in this[1] series reverts [2] when it should have reverted [3]. This series fixes this mistake. [1] https://lore.kernel.org/all/20220912113856.817188-1-robert.f...@linaro.org/ [2] c312b0df3b13 - drm/br

[PATCH v1 2/2] Revert "drm/bridge: chrontel-ch7033: Add byteswap order setting"

2022-09-15 Thread Robert Foss
Revert this patch since it depends on devicetree functionality that previously has been reverted in the below commit. commit e798ba3374a1 ("Revert "dt-bindings: Add byteswap order to chrontel ch7033"") This reverts commit ce9564cfc9aea65e68eb343c599317633bc2321a. Signed-off-by: Robert Foss ---

[PATCH v1 1/2] Revert "Revert "drm/bridge: ti-sn65dsi86: Implement bridge connector operations for DP""

2022-09-15 Thread Robert Foss
This commit was accidentally reverted instead of another commit, and therefore needs to be reinstated. This reverts commit 8c9c40ec83445b188fb6b59e119bf5c2de81b02d. Signed-off-by: Robert Foss --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 28 +++ 1 file changed, 28 insertio

Re: [PATCH 3/3] drm/mediatek: dp: Fix warning in mtk_dp_video_mute()

2022-09-15 Thread AngeloGioacchino Del Regno
Il 15/09/22 09:50, Bo-Chen Chen ha scritto: Warning: ../drivers/gpu/drm/mediatek/mtk_dp.c: In function ‘mtk_dp_video_mute’: ../drivers/gpu/drm/mediatek/mtk_dp.c:947:23: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type ‘long unsigned int’ [-Wformat=] 947 |

Re: [PATCH 2/3] drm/mediatek: dp: Remove unused register definitions

2022-09-15 Thread AngeloGioacchino Del Regno
Il 15/09/22 09:50, Bo-Chen Chen ha scritto: Some definitions in mtk_dp_reg.h are not used, so remove these redundant codes. Signed-off-by: Bo-Chen Chen Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v1 2/2] Revert "drm/bridge: ti-sn65dsi86: Implement bridge connector operations for DP"

2022-09-15 Thread Robert Foss
On Mon, 12 Sept 2022 at 16:43, Laurent Pinchart wrote: > > On Mon, Sep 12, 2022 at 03:29:52PM +0100, Doug Anderson wrote: > > On Mon, Sep 12, 2022 at 12:43 PM Robert Foss wrote: > > > > > > As reported by Laurent in response to this commit[1], this functionality > > > should > > > not be impleme

Re: [PATCH 1/3] drm/mediatek: dp: Refactor drivers in mtk_dp_bdg_detect()

2022-09-15 Thread AngeloGioacchino Del Regno
Il 15/09/22 09:50, Bo-Chen Chen ha scritto: It is more clear to modify this in mtk_dp_bdg_detect(). I agree with this commit. Since you anyway have to send a v2 of this series, please clarify the commit description and title, something like: drm/mediatek: dp: Reduce indentation in mtk_dp_bdg_d

Re: [PATCH 1/4] drm/i915/gt: Cleanup partial engine discovery failures

2022-09-15 Thread Janusz Krzysztofik
Hi Matt, On Thursday, 15 September 2022 00:04:24 CEST Matt Roper wrote: > From: Chris Wilson > > If we abort driver initialisation in the middle of gt/engine discovery, > some engines will be fully setup and some not. Those incompletely setup > engines only have 'engine->release == NULL' and so

[PATCH] virtio-gpu: fix shift wrapping bug in virtio_gpu_fence_event_create()

2022-09-15 Thread Dan Carpenter
The ->ring_idx_mask variable is a u64 so static checkers, Smatch in this case, complain if the BIT() is not also a u64. drivers/gpu/drm/virtio/virtgpu_ioctl.c:50 virtio_gpu_fence_event_create() warn: should '(1 << ring_idx)' be a 64 bit type? Fixes: cd7f5ca33585 ("drm/virtio: implement context in

Re: [PATCH v2 3/3] dt-bindings: display: bridge: nxp, tda998x: Convert to json-schema

2022-09-15 Thread Geert Uytterhoeven
Hi Krzysztof, On Thu, Sep 15, 2022 at 10:26 AM Krzysztof Kozlowski wrote: > On Wed, 14 Sep 2022 16:33:22 +0200, Geert Uytterhoeven wrote: > > Convert the NXP TDA998x HDMI transmitter Device Tree binding > > documentation to json-schema. > > > > Add missing "#sound-dai-cells" property. > > Add por

RE: [PATCH v6 2/2] drm: rcar-du: Add RZ/G2L DSI driver

2022-09-15 Thread Biju Das
Hi Laurent, > Subject: RE: [PATCH v6 2/2] drm: rcar-du: Add RZ/G2L DSI driver > > Hi Laurent and all, > > Thanks for the feedback. > > > Subject: Re: [PATCH v6 2/2] drm: rcar-du: Add RZ/G2L DSI driver > > > > Hi Biju, > > > > On Tue, Aug 30, 2022 at 08:22:08AM +, Biju Das wrote: > > > Subj

Re: [PATCH v1 2/7] clk: bcm: rpi: Add a function to retrieve the maximum

2022-09-15 Thread Stefan Wahren
Hi Maxime, Am 15.09.22 um 09:54 schrieb Maxime Ripard: On Wed, Sep 14, 2022 at 08:26:55PM +0200, Stefan Wahren wrote: Am 14.09.22 um 20:14 schrieb Stephen Boyd: Quoting Stefan Wahren (2022-09-14 11:09:04) Am 14.09.22 um 20:05 schrieb Stephen Boyd: Quoting Stefan Wahren (2022-09-14 10:45:48)

Re: [PATCH v1 2/7] clk: bcm: rpi: Add a function to retrieve the maximum

2022-09-15 Thread Maxime Ripard
Hi Stefan, On Thu, Sep 15, 2022 at 01:30:02PM +0200, Stefan Wahren wrote: > Am 15.09.22 um 09:54 schrieb Maxime Ripard: > > On Wed, Sep 14, 2022 at 08:26:55PM +0200, Stefan Wahren wrote: > > > Am 14.09.22 um 20:14 schrieb Stephen Boyd: > > > > Quoting Stefan Wahren (2022-09-14 11:09:04) > > > > >

Re: [PATCH v6 01/12] dt-bindings: display/msm: split qcom,mdss bindings

2022-09-15 Thread Dmitry Baryshkov
On 11/09/2022 22:19, Krzysztof Kozlowski wrote: On 11/09/2022 20:36, Krzysztof Kozlowski wrote: If your child schema fails, the referencing schema fails as well... Although now with DSI-PHY I cannot reproduce it and I am pretty sure I reproduced it with DPU controllers after modifying the DT

Re: [PULL] drm-intel-next

2022-09-15 Thread Jani Nikula
On Mon, 29 Aug 2022, Jani Nikula wrote: > Hi Dave & Daniel - > > drm-intel-next-2022-08-29: > drm/i915 feature pull for v6.1: Hey, I started making another pull request, but realized you haven't pulled this one yet. Anything the matter, or just fell between the cracks? BR, Jani. > > Features a

[PULL] drm-misc-fixes

2022-09-15 Thread Thomas Zimmermann
Hi Dave and Daniel, this is the drm-misc-fixes PR for this week. Best regards Thomas drm-misc-fixes-2022-09-15: Short summary of fixes pull: * gma500: Locking and IRQ fixes * meson: OSD1 display fixes * panel-edp: Fix Innolux timings * rockchip: DP/HDMI fixes The following changes since com

Re: [PATCH v4 4/6] dma-buf: dma_fence_wait must enable signaling

2022-09-15 Thread Christian König
Am 14.09.22 um 18:43 schrieb Arvind Yadav: dma_fence_wait() should always enable signaling even when the fence is already signaled. Signed-off-by: Arvind Yadav Reviewed-by: Christian König --- Changes in v1..v3: This new patch was not part of previous series. --- drivers/dma-buf/dma-f

Re: [PATCH v4 6/6] dma-buf: Check status of enable-signaling bit on debug

2022-09-15 Thread Christian König
Am 14.09.22 um 18:43 schrieb Arvind Yadav: Fence signaling must be enabled to make sure that the dma_fence_is_signaled() function ever returns true. Since drivers and implementations sometimes mess this up, this ensures correct behaviour when DMABUF_DEBUG_ENABLE_SIGNALING is used during debugging

Re: [PATCH v4 0/6] dma-buf: Check status of enable-signaling bit on debug

2022-09-15 Thread Christian König
Is that sufficient to allow running a desktop on amdgpu with the extra check enabled? If yes that would be quite a milestone. What's left is checking the userspace IGT tests. Especially the sync_file and drm_syncobj tests I would expect to have problems with this extra check. Thanks, Christi

Re: [PATCH 0/3] Host1x context isolation on Tegra234

2022-09-15 Thread Thierry Reding
On Wed, Sep 07, 2022 at 11:38:41AM +0300, Mikko Perttunen wrote: > From: Mikko Perttunen > > Hi all, > > this series adds support for Host1x context isolation > on Tegra234 (Orin). The difference from previous generations > is that there are two IOMMUs to which engines can be attached > to, resu

Re: [Intel-gfx] [PATCH 0/4] Further multi-gt handling

2022-09-15 Thread Jani Nikula
On Wed, 14 Sep 2022, Matt Roper wrote: > Now that MTL is going to start providing two GTs, there are a few more > places in the driver that need to iterate over each GT instead of > operating directly on gt0. Also some more deliberate cleanup is needed, > in cases where we fail GT/engine initiali

Re: [PATCH 4/9] drm/tegra: convert to using is_hdmi from display info

2022-09-15 Thread Thierry Reding
On Thu, Sep 01, 2022 at 03:47:06PM +0300, Jani Nikula wrote: > Prefer the parsed results for is_hdmi in display info over calling > drm_detect_hdmi_monitor(). > > Cc: Thierry Reding > Cc: linux-te...@vger.kernel.org > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/tegra/hdmi.c | 9 +

Re: [PATCH v6 04/12] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml

2022-09-15 Thread Dmitry Baryshkov
On 08/09/2022 00:13, Dmitry Baryshkov wrote: On Wed, 7 Sept 2022 at 22:59, Rob Herring wrote: On Thu, Sep 01, 2022 at 01:23:04PM +0300, Dmitry Baryshkov wrote: Move properties common to all DPU DT nodes to the dpu-common.yaml. Note, this removes description of individual DPU port@ nodes. How

Re: mgag200 broken on kernel-6.0-rc3 on DELL/T620

2022-09-15 Thread Thomas Zimmermann
Hi Am 14.09.22 um 16:58 schrieb Wang Yugui: [...] 24-bit works on my G200HE and G200 test machines. Maybe the G200ER has a bug. When I try 16-bit depth, the display works, but is way too dark. No fiddling with the LUT tables fixes this. It's 90s hardware, so it should support 16-bit framebuff

Re: [PATCH v4 0/6] dma-buf: Check status of enable-signaling bit on debug

2022-09-15 Thread Yadav, Arvind
On 9/15/2022 5:37 PM, Christian König wrote: Is that sufficient to allow running a desktop on amdgpu with the extra check enabled? If yes that would be quite a milestone. Yes, It is running on amdgpu with extra config enabled. What's left is checking the userspace IGT tests. Especially the

RE: [PATCH v5 06/21] drm/i915: Prepare to dynamic dma-buf locking specification

2022-09-15 Thread Ruhl, Michael J
>-Original Message- >From: Dmitry Osipenko >Sent: Tuesday, September 13, 2022 3:28 PM >To: David Airlie ; Gerd Hoffmann ; >Gurchetan Singh ; Chia-I Wu >; Daniel Vetter ; Daniel Almeida >; Gert Wollny ; >Gustavo Padovan ; Daniel Stone >; Tomeu Vizoso ; >Maarten Lankhorst ; Maxime Ripard >;

[PATCH v7 00/12] dt-bindings: display/msm: rework MDSS and DPU bindings

2022-09-15 Thread Dmitry Baryshkov
Create separate YAML schema for MDSS devicesd$ (both for MDP5 and DPU devices). Cleanup DPU schema files, so that they do not contain schema for both MDSS and DPU nodes. Apply misc small fixes to the DPU schema afterwards. Add schema for the MDSS and DPU on sm8250 platform. Changes since v6: - Re

[PATCH v7 03/12] dt-bindings: display/msm: add interconnects property to qcom, mdss-smd845

2022-09-15 Thread Dmitry Baryshkov
Add interconnects required for the SDM845 MDSS device tree node. This change was made in the commit c8c61c09e38b ("arm64: dts: qcom: sdm845: Add interconnects property for display"), but was not reflected in the schema. Signed-off-by: Dmitry Baryshkov --- .../devicetree/bindings/display/msm/dpu-

[PATCH v7 01/12] dt-bindings: display/msm: split qcom,mdss bindings

2022-09-15 Thread Dmitry Baryshkov
Split Mobile Display SubSystem (MDSS) root node bindings to the separate yaml file. Changes to the existing (txt) schema: - Added optional "vbif_nrt_phys" region used by msm8996 - Made "bus" and "vsync" clocks optional (they are not used by some platforms) - Added (optional) "core" clock adde

[PATCH v7 02/12] dt-bindings: display/msm: add gcc-bus clock to dpu-smd845

2022-09-15 Thread Dmitry Baryshkov
Add gcc-bus clock required for the SDM845 DPU device tree node. This change was made in the commit 111c52854102 ("arm64: dts: qcom: sdm845: move bus clock to mdp node for sdm845 target"), but was not reflected in the schema. Reviewed-by: Rob Herring Signed-off-by: Dmitry Baryshkov --- .../devic

[PATCH v7 08/12] dt-bindings: display/msm: split dpu-sdm845 into DPU and MDSS parts

2022-09-15 Thread Dmitry Baryshkov
In order to make the schema more readable, split dpu-sdm845 into the DPU and MDSS parts, each one describing just a single device binding. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dpu-sdm845.yaml | 148 -- .../bindings/display/msm/qcom,sdm845-dpu.yaml |

[PATCH v7 06/12] dt-bindings: display/msm: split dpu-sc7180 into DPU and MDSS parts

2022-09-15 Thread Dmitry Baryshkov
In order to make the schema more readable, split dpu-sc7180 into the DPU and MDSS parts, each one describing just a single device binding. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dpu-sc7180.yaml | 158 -- .../bindings/display/msm/qcom,sc7180-dpu.yaml |

[PATCH v7 09/12] dt-bindings: display/msm: split dpu-msm8998 into DPU and MDSS parts

2022-09-15 Thread Dmitry Baryshkov
In order to make the schema more readable, split dpu-msm8998 into the DPU and MDSS parts, each one describing just a single device binding. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dpu-msm8998.yaml | 150 -- .../display/msm/qcom,msm8998-dpu.yaml |

[PATCH v7 10/12] dt-bindings: display/msm: split dpu-qcm2290 into DPU and MDSS parts

2022-09-15 Thread Dmitry Baryshkov
In order to make the schema more readable, split dpu-qcm2290 into the DPU and MDSS parts, each one describing just a single device binding. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dpu-qcm2290.yaml | 148 -- .../display/msm/qcom,qcm2290-dpu.yaml |

[PATCH v7 07/12] dt-bindings: display/msm: split dpu-sc7280 into DPU and MDSS parts

2022-09-15 Thread Dmitry Baryshkov
In order to make the schema more readable, split dpu-sc7280 into the DPU and MDSS parts, each one describing just a single device binding. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dpu-sc7280.yaml | 162 -- .../bindings/display/msm/qcom,sc7280-dpu.yaml |

[PATCH v7 12/12] dt-bindings: display/msm: add support for the display on SM8250

2022-09-15 Thread Dmitry Baryshkov
Add DPU and MDSS schemas to describe MDSS and DPU blocks on the Qualcomm SM8250 platform. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/mdss-common.yaml | 4 +- .../bindings/display/msm/qcom,sm8250-dpu.yaml | 92 .../display/msm/qcom,sm8250-mdss.yaml

[PATCH v7 04/12] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml

2022-09-15 Thread Dmitry Baryshkov
Move properties common to all DPU DT nodes to the dpu-common.yaml. Note, this removes description of individual DPU port@ nodes. However such definitions add no additional value. The reg values do not correspond to hardware INTF indices. The driver discovers and binds these ports not paying any ca

[PATCH v7 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml

2022-09-15 Thread Dmitry Baryshkov
Move properties common to all MDSS DT nodes to the mdss-common.yaml. This extends qcom,msm8998-mdss schema to allow interconnect nodes, which will be added later, once msm8998 gains interconnect support. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dpu-msm8998.yaml | 41 +---

[PATCH v7 11/12] dt-bindings: display/msm: add missing device nodes to mdss-* schemas

2022-09-15 Thread Dmitry Baryshkov
Add missing device nodes (DSI, PHYs, DP/eDP) to the existing MDSS schemas. Reviewed-by: Rob Herring Signed-off-by: Dmitry Baryshkov --- .../display/msm/qcom,msm8998-mdss.yaml| 12 + .../display/msm/qcom,qcm2290-mdss.yaml| 6 + .../display/msm/qcom,sc7180-mdss.yaml

Re: (subset) [PATCH v2 0/3] drm/rockchip: support gamma control on RK3399

2022-09-15 Thread Heiko Stuebner
On Tue, 19 Oct 2021 22:58:40 +0100, Hugh Cole-Baker wrote: > This extends the Rockchip VOP driver to support setting the gamma LUT on the > RK3399 SoC. Previously, the driver supported gamma control for the RK3288 > only. On the RK3399 the method for updating the LUT is slightly different. > This i

Re: [PATCH] drm/rockchip: remove vop_writel

2022-09-15 Thread Heiko Stuebner
On Sat, 21 May 2022 15:07:16 -0400, Tom Rix wrote: > cppcheck reports > [drivers/gpu/drm/rockchip/rockchip_drm_vop.c:186]: (style) The function > 'vop_writel' is never used. > > vop_writel is static function that is not used, so remove it. Applied, thanks! [1/1] drm/rockchip: remove vop_writel

Re: (subset) [PATCH v2 0/3] drm/rockchip: support gamma control on RK3399

2022-09-15 Thread Heiko Stuebner
On Tue, 19 Oct 2021 22:58:40 +0100, Hugh Cole-Baker wrote: > This extends the Rockchip VOP driver to support setting the gamma LUT on the > RK3399 SoC. Previously, the driver supported gamma control for the RK3288 > only. On the RK3399 the method for updating the LUT is slightly different. > This i

[PULL] drm-intel-fixes

2022-09-15 Thread Rodrigo Vivi
Hi Dave and Daniel, Nothing that big for this round, but a couple targeting stable. Here goes drm-intel-fixes-2022-09-15: - Revert a display patch around max DP source rate now that the proper WaEdpLinkRateDataReload is in place. (Ville) - Fix perf limit reasons bit position. (Ashutosh) - Fix

Re: [PATCH v2 3/3] dt-bindings: display: bridge: nxp,tda998x: Convert to json-schema

2022-09-15 Thread Rob Herring
On Thu, Sep 15, 2022 at 12:15:28PM +0100, Geert Uytterhoeven wrote: > Hi Krzysztof, > > On Thu, Sep 15, 2022 at 10:26 AM Krzysztof Kozlowski > wrote: > > On Wed, 14 Sep 2022 16:33:22 +0200, Geert Uytterhoeven wrote: > > > Convert the NXP TDA998x HDMI transmitter Device Tree binding > > > document

pr-tracker-bot for drm subsystem?

2022-09-15 Thread Jani Nikula
Hey all, I'd be interested in having the pr-tracker-bot [1] set up for the drm subsystem, following the dri-devel mailing list [2] and notifying when the pull requests have been merged to either the drm-next or drm-fixes branches of the main drm repository [3]. What would this require in terms o

[PATCH] drm/etnaviv: don't truncate physical page address

2022-09-15 Thread Lucas Stach
While the interface for the MMU mapping takes phys_addr_t to hold a full 64bit address when necessary and MMUv2 is able to map physical addresses with up to 40bit, etnaviv_iommu_map() truncates the address to 32bits. Fix this by using the correct type. Fixes: 931e97f3afd8 ("drm/etnaviv: mmuv2: sup

Re: [PATCH v6 01/12] dt-bindings: display/msm: split qcom,mdss bindings

2022-09-15 Thread Krzysztof Kozlowski
On 15/09/2022 12:50, Dmitry Baryshkov wrote: > On 11/09/2022 22:19, Krzysztof Kozlowski wrote: >> On 11/09/2022 20:36, Krzysztof Kozlowski wrote: >> If your child schema fails, the referencing schema fails as well... >>> >>> >>> Although now with DSI-PHY I cannot reproduce it and I am pretty s

Re: [PATCH] drm/etnaviv: don't truncate physical page address

2022-09-15 Thread Philipp Zabel
Hi Lucas, On Do, 2022-09-15 at 16:19 +0200, Lucas Stach wrote: > While the interface for the MMU mapping takes phys_addr_t to hold a > full 64bit address when necessary and MMUv2 is able to map physical > addresses with up to 40bit, etnaviv_iommu_map() truncates the address > to 32bits. Fix this b

Re: [PATCH v2 3/3] arm64: dts: rockchip: enable gamma control on RK3399

2022-09-15 Thread Robin Murphy
On 2021-10-19 22:58, Hugh Cole-Baker wrote: Define the memory region on RK3399 VOPs containing the gamma LUT at base+0x2000. Signed-off-by: Hugh Cole-Baker --- Changes from v1: no changes in this patch arch/arm64/boot/dts/rockchip/rk3399.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 de

Re: mgag200 broken on kernel-6.0-rc3 on DELL/T620

2022-09-15 Thread Wang Yugui
Hi, > Hi > > Am 14.09.22 um 16:58 schrieb Wang Yugui: > [...] > >> 24-bit works on my G200HE and G200 test machines. Maybe the G200ER has a > >> bug. > >> > >> When I try 16-bit depth, the display works, but is way too dark. No > >> fiddling with the LUT tables fixes this. It's 90s hardware, so

[PATCH] drm/mgag200: Force 32 bpp on the console

2022-09-15 Thread Thomas Zimmermann
G200ER does not seem to support 24 bpp, so force the console to use 32 bpp. The problem was introduced, when commit 73f54d5d9682 ("drm/mgag200: Remove special case for G200SE with <2 MiB") changed the preferred color depth from 32 bit to 24 bit. A setting of 24 is the correct color depth, but G200

Re: [PATCH] drm/rockchip: vop2: Fix Null Pointer Dereference on Multiple VPs

2022-09-15 Thread Chris Morgan
On Wed, Sep 14, 2022 at 03:35:30PM +0200, Sascha Hauer wrote: > On Wed, Sep 14, 2022 at 08:04:18AM -0500, Chris Morgan wrote: > > On Wed, Sep 14, 2022 at 08:49:27AM +0200, Sascha Hauer wrote: > > > On Tue, Sep 13, 2022 at 08:55:22AM +0200, Michael Riesch wrote: > > > > Hi, > > > > > > > > On 9/12/

Re: [PATCH 2/3] drm/mediatek: dp: Remove unused register definitions

2022-09-15 Thread Matthias Brugger
On 15/09/2022 09:50, Bo-Chen Chen wrote: Some definitions in mtk_dp_reg.h are not used, so remove these redundant codes. Signed-off-by: Bo-Chen Chen Reviewed-by: Matthias Brugger --- drivers/gpu/drm/mediatek/mtk_dp_reg.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/driver

Re: [PATCH 3/3] drm/mediatek: dp: Fix warning in mtk_dp_video_mute()

2022-09-15 Thread Matthias Brugger
On 15/09/2022 09:50, Bo-Chen Chen wrote: Warning: ../drivers/gpu/drm/mediatek/mtk_dp.c: In function ‘mtk_dp_video_mute’: ../drivers/gpu/drm/mediatek/mtk_dp.c:947:23: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type ‘long unsigned int’ [-Wformat=] 947 |

Re: [PATCH v4 0/6] dma-buf: Check status of enable-signaling bit on debug

2022-09-15 Thread Christian König
Am 15.09.22 um 15:02 schrieb Yadav, Arvind: On 9/15/2022 5:37 PM, Christian König wrote: Is that sufficient to allow running a desktop on amdgpu with the extra check enabled? If yes that would be quite a milestone. Yes, It is running on amdgpu with extra config enabled. In this case I will

Re: [PATCH 4/5] arm64: dts: change compatible of vdosys0 and vdosys1 for mt8195

2022-09-15 Thread Matthias Brugger
On 14/09/2022 20:23, Jason-JH.Lin wrote: For previous MediaTek SoCs, such as MT8173, there are 2 display HW pipelines binding to 1 mmsys with the same power domain, the same clock driver and the same mediatek-drm driver. For MT8195, VDOSYS0 and VDOSYS1 are 2 display HW pipelines binding to 2

Re: [PATCH v6,1/3] soc: mediatek: Add mmsys func to adapt to dpi output for MT8186

2022-09-15 Thread Matthias Brugger
On 14/09/2022 15:21, xinlei@mediatek.com wrote: From: Xinlei Lee Add mmsys func to manipulate dpi output format config for MT8186. Co-developed-by: Jitao Shi Signed-off-by: Jitao Shi Signed-off-by: Xinlei Lee Reviewed-by: Nís F. R. A. Prado Applied, thanks! --- drivers/soc/me

Re: [PATCH 1/5] dt-bindings: arm: mediatek: mmsys: change compatible for MT8195

2022-09-15 Thread Matthias Brugger
Hi Jason, On 15/09/2022 03:24, Jason-JH Lin wrote: Hi Matthias, Thanks for the reviews. On Wed, 2022-09-14 at 23:24 +0200, Matthias Brugger wrote: On 14/09/2022 20:23, Jason-JH.Lin wrote: For previous MediaTek SoCs, such as MT8173, there are 2 display HW pipelines binding to 1 mmsys with th

[PATCH] drm/panel: db7430: Silent no spi_device_id warning

2022-09-15 Thread Wei Yongjun
From: Wei Yongjun Add spi_device_id entries to silent following SPI warning: SPI driver db7430-panel has no spi_device_id for samsung,lms397kf04 Signed-off-by: Wei Yongjun --- drivers/gpu/drm/panel/panel-samsung-db7430.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/d

[PATCH] drm/panel: tpg110: Silent no spi_device_id warning

2022-09-15 Thread Wei Yongjun
From: Wei Yongjun Add spi_device_id entries to silent following SPI warning: SPI driver tpo-tpg110-panel has no spi_device_id for tpo,tpg110 Signed-off-by: Wei Yongjun --- drivers/gpu/drm/panel/panel-tpo-tpg110.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/panel

[PATCH] drm/panel: s6d27a1: Silent no spi_device_id warning

2022-09-15 Thread Wei Yongjun
From: Wei Yongjun Add spi_device_id entries to silent following SPI warning: SPI driver s6d27a1-panel has no spi_device_id for samsung,s6d27a1 Signed-off-by: Wei Yongjun --- drivers/gpu/drm/panel/panel-samsung-s6d27a1.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/dr

[PATCH] drm/panel: s6e63m0: Silent no spi_device_id warning

2022-09-15 Thread Wei Yongjun
From: Wei Yongjun Add spi_device_id entries to silent following SPI warning: SPI driver panel-samsung-s6e63m0 has no spi_device_id for samsung,s6e63m0 Signed-off-by: Wei Yongjun --- drivers/gpu/drm/panel/panel-samsung-s6e63m0-spi.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/dr

[PATCH] drm/panel: ws2401: Silent no spi_device_id warning

2022-09-15 Thread Wei Yongjun
From: Wei Yongjun Add spi_device_id entries to silent following SPI warning: SPI driver ws2401-panel has no spi_device_id for samsung,lms380kf01 Signed-off-by: Wei Yongjun --- drivers/gpu/drm/panel/panel-widechips-ws2401.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu

[PATCH] drm/panel: innolux-ej030na: Silent no spi_device_id warning

2022-09-15 Thread Wei Yongjun
From: Wei Yongjun Add spi_device_id entries to silent following SPI warning: SPI driver panel-innolux-ej030na has no spi_device_id for innolux,ej030na Signed-off-by: Wei Yongjun --- drivers/gpu/drm/panel/panel-innolux-ej030na.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/driver

[PATCH] drm/panel: nv3052c: Silent no spi_device_id warning

2022-09-15 Thread Wei Yongjun
From: Wei Yongjun Add spi_device_id entries to silent following SPI warning: SPI driver nv3052c has no spi_device_id for leadtek,ltk035c5444t Signed-off-by: Wei Yongjun --- drivers/gpu/drm/panel/panel-newvision-nv3052c.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/d

[PATCH] drm/panel: novatek,nt39016: Silent no spi_device_id warning

2022-09-15 Thread Wei Yongjun
From: Wei Yongjun Add spi_device_id entries to silent following SPI warning: SPI driver nt39016 has no spi_device_id for kingdisplay,kd035g6-54nt Signed-off-by: Wei Yongjun --- drivers/gpu/drm/panel/panel-novatek-nt39016.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu

[PATCH] drm/panel: panel-ilitek-ili9322: Silent no spi_device_id warnings

2022-09-15 Thread Wei Yongjun
From: Wei Yongjun Add spi_device_id entries to silent following SPI warnings: SPI driver panel-ilitek-ili9322 has no spi_device_id for dlink,dir-685-panel SPI driver panel-ilitek-ili9322 has no spi_device_id for ilitek,ili9322 Signed-off-by: Wei Yongjun --- drivers/gpu/drm/panel/panel-ilitek-

[PATCH] drm/panel: y030xx067a: Silent no spi_device_id warning

2022-09-15 Thread Wei Yongjun
From: Wei Yongjun Add spi_device_id entries to silent following SPI warning: SPI driver abt-y030xx067a has no spi_device_id for abt,y030xx067a Signed-off-by: Wei Yongjun --- drivers/gpu/drm/panel/panel-abt-y030xx067a.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm

[PATCH v2 0/2] drm/i915/gem: Really move i915_gem_context.link under ref protection

2022-09-15 Thread Janusz Krzysztofik
i915_perf assumes that it can use the i915_gem_context reference to protect its i915->gem.contexts.list iteration. However, this requires that we do not remove the context from the list until after we drop the final reference and release the struct. If, as currently, we remove the context from the

[PATCH v2 2/2] drm/i915/gem: Really move i915_gem_context.link under ref protection

2022-09-15 Thread Janusz Krzysztofik
From: Chris Wilson i915_perf assumes that it can use the i915_gem_context reference to protect its i915->gem.contexts.list iteration. However, this requires that we do not remove the context from the list until after we drop the final reference and release the struct. If, as currently, we remove

[PATCH v2 1/2] drm/i915/gem: Flush contexts on driver release

2022-09-15 Thread Janusz Krzysztofik
Due to i915_perf assuming that it can use the i915_gem_context reference to protect its i915->gem.contexts.list iteration, we need to defer removal of the context from the list until last reference to the context is put. However, there is a risk of triggering kernel warning on contexts list not emp

Re: [PATCH v2 3/3] arm64: dts: rockchip: enable gamma control on RK3399

2022-09-15 Thread Hugh Cole-Baker
> On 15 Sep 2022, at 15:40, Robin Murphy wrote: > > On 2021-10-19 22:58, Hugh Cole-Baker wrote: >> Define the memory region on RK3399 VOPs containing the gamma LUT at >> base+0x2000. >> Signed-off-by: Hugh Cole-Baker >> --- >> Changes from v1: no changes in this patch >> arch/arm64/boot/dts/r

Re: [PATCH v2 3/3] arm64: dts: rockchip: enable gamma control on RK3399

2022-09-15 Thread Robin Murphy
On 2022-09-15 17:53, Hugh Cole-Baker wrote: On 15 Sep 2022, at 15:40, Robin Murphy wrote: On 2021-10-19 22:58, Hugh Cole-Baker wrote: Define the memory region on RK3399 VOPs containing the gamma LUT at base+0x2000. Signed-off-by: Hugh Cole-Baker --- Changes from v1: no changes in this patch

Re: [PATCH v2 3/3] dt-bindings: display: bridge: nxp,tda998x: Convert to json-schema

2022-09-15 Thread Krzysztof Kozlowski
On Wed, 14 Sep 2022 16:33:22 +0200, Geert Uytterhoeven wrote: > Convert the NXP TDA998x HDMI transmitter Device Tree binding > documentation to json-schema. > > Add missing "#sound-dai-cells" property. > Add ports hierarchy, as an alternative to port. > Drop pinctrl properties, as they do not belo

Re: drivers/gpu/drm/omapdrm/dss/dsi.c:1126:1: warning: the frame size of 1060 bytes is larger than 1024 bytes

2022-09-15 Thread Arnd Bergmann
On Thu, Sep 15, 2022, at 8:17 PM, kernel test robot wrote: > Hi Arnd, > tree: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 3245cb65fd91cd514801bf91f5a3066d562f0ac4 > commit: 3d427228f7370894680580fcd0381c0349624fa1 ARM: ixp4xx: enable > multiplatform

Re: [PATCH] drm/etnaviv: don't truncate physical page address

2022-09-15 Thread kernel test robot
Hi Lucas, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on linus/master v6.0-rc5 next-20220915] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [Intel-gfx] [PATCH 1/1] drm/i915/uc: Update to latest GuC and use new-format GuC/HuC names

2022-09-15 Thread John Harrison
On 9/15/2022 01:59, Tvrtko Ursulin wrote: Hi, On 15/09/2022 00:46, john.c.harri...@intel.com wrote: From: John Harrison Going forwards, the intention is for GuC firmware files to be named for their major version only and HuC firmware files to have no version number in the name at all. This p

[PATCH v1 0/4] drm/i915: Improvements to stolen memory setup

2022-09-15 Thread Lucas De Marchi
: bb4f6b2281b11b009210f62eecd291f7b75c1e85 change-id: 20220915-stolen-7aa0e407368f Best regards, -- Lucas De Marchi

[PATCH v1 3/4] drm/i915: Split i915_gem_init_stolen()

2022-09-15 Thread Lucas De Marchi
Add some helpers: adjust_stolen(), request_smem_stolen_() and init_reserved_stolen() that are now called by i915_gem_init_stolen() to initialize each part of the Data Stolen Memory region. Main goal is to split the reserved part, also known as WOPCM, as its calculation changes often per platform.

[PATCH v1 4/4] drm/i915/dgfx: Make failure to setup stolen non-fatal

2022-09-15 Thread Lucas De Marchi
There is no reason to consider the setup of Data Stolen Memory fatal on dgfx and non-fatal on integrated. Move the debug and error propagation around so both have the same behavior: non-fatal. Before this change, loading i915 on a system with TGL + DG2 would result in just TGL succeeding the initia

[PATCH v1 1/4] drm/i915: Move dsm assignment to be after adjustment

2022-09-15 Thread Lucas De Marchi
Reduce possible side effects of assigning the region and bailing out due to errors. Signed-off-by: Lucas De Marchi diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c index acc561c0f0aa..42f4769bb4ac 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem

[PATCH v1 2/4] drm/i915: Add missing mask when reading GEN12_DSMBASE

2022-09-15 Thread Lucas De Marchi
DSMBASE register is defined so BDSM bitfield contains the bits 63 to 20 of the base address of stolen. For the supported platforms bits 0-19 are zero but that may not be true in future. Add the missing mask. Signed-off-by: Lucas De Marchi diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c

Re: [PATCH V3 46/47] drm/amd/display: Fix failures of disabling primary plans

2022-09-15 Thread Rodrigo Siqueira Jordao
Hi Michel, First of all, thanks a lot for your review. I want to take this opportunity to discuss this topic in more depth and learn more from you and others. +(Nick, Leo, Daniel, Mark, Dave, Sean, Simon) On 2022-09-15 04:55, Michel Dänzer wrote: On 2022-09-14 22:08, Alex Hung wrote: On 20

RE: [PATCH v5 00/15] drm/i915: HuC loading for DG2

2022-09-15 Thread Winkler, Tomas
> On Wed, Sep 14, 2022 at 04:51:03PM +, Winkler, Tomas wrote: > > > > > > On DG2, HuC loading is performed by the GSC, via a PXP command. The > > > load operation itself is relatively simple (just send a message to > > > the GSC with the physical address of the HuC in LMEM), but there are >

Re: [Intel-gfx] [PATCH v1 2/4] drm/i915: Add missing mask when reading GEN12_DSMBASE

2022-09-15 Thread Caz Yokoyama
Reviewed-by: Caz Yokoyama Better to be safe. On Thu, Sep 15, 2022 at 1:40 PM Lucas De Marchi wrote: > DSMBASE register is defined so BDSM bitfield contains the bits 63 to 20 > of the base address of stolen. For the supported platforms bits 0-19 are > zero but that may not be true in future. A

[linux-next:master] BUILD REGRESSION 6ce5d01e7011b32600656bf90a626b1e51fb192a

2022-09-15 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 6ce5d01e7011b32600656bf90a626b1e51fb192a Add linux-next specific files for 20220915 Error/Warning reports: https://lore.kernel.org/linux-mm/202209150141.wgbakqmx-...@intel.com https

Re: [PATCH 2/2] power: supply: Add Lenovo Yoga C630 EC driver

2022-09-15 Thread Bjorn Andersson
On Tue, Sep 13, 2022 at 12:45:45PM +0200, Sebastian Reichel wrote: > Hi, > > [+Cc Lee Jones, DRI devel] > > On Tue, Aug 09, 2022 at 10:05:00PM -0500, Bjorn Andersson wrote: > > The Qualcomm Snapdragon-based Lenovo Yoga C630 has some sort of EC > > providing AC-adapter and battery status, as well

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Make GEM resume all engines

2022-09-15 Thread Andi Shyti
Hi Matt, On Wed, Sep 14, 2022 at 03:04:25PM -0700, Matt Roper wrote: > From: Tvrtko Ursulin > > Walk all GTs from i915_gem_resume when resuming engines. > > Cc: Andi Shyti > Signed-off-by: Tvrtko Ursulin > Signed-off-by: Matt Roper I had this (and others) in my multi-gt branch from a long t

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Make GEM suspend all GTs

2022-09-15 Thread Andi Shyti
Hi Matt, On Wed, Sep 14, 2022 at 03:04:26PM -0700, Matt Roper wrote: > From: Tvrtko Ursulin > > Walk all GTs when suspending. > > Signed-off-by: Tvrtko Ursulin > Signed-off-by: Matt Roper I had this as well... thanks again! Reviewed-by: Andi Shyti Andi

Re: [Intel-gfx] [PATCH 0/4] Further multi-gt handling

2022-09-15 Thread Andi Shyti
Hi Jani, On Thu, Sep 15, 2022 at 03:25:15PM +0300, Jani Nikula wrote: > On Wed, 14 Sep 2022, Matt Roper wrote: > > Now that MTL is going to start providing two GTs, there are a few more > > places in the driver that need to iterate over each GT instead of > > operating directly on gt0. Also some

Re: [PATCH 2/2] power: supply: Add Lenovo Yoga C630 EC driver

2022-09-15 Thread Dmitry Baryshkov
On Fri, 16 Sept 2022 at 00:25, Bjorn Andersson wrote: > > On Tue, Sep 13, 2022 at 12:45:45PM +0200, Sebastian Reichel wrote: > > Hi, > > > > [+Cc Lee Jones, DRI devel] > > > > On Tue, Aug 09, 2022 at 10:05:00PM -0500, Bjorn Andersson wrote: > > > The Qualcomm Snapdragon-based Lenovo Yoga C630 has

Re: [PATCH v2 1/6] dt-bindings: arm: mediatek: mmsys: change compatible for MT8195

2022-09-15 Thread Matthias Brugger
On 15/09/2022 18:18, Jason-JH.Lin wrote: For previous MediaTek SoCs, such as MT8173, there are 2 display HW pipelines binding to 1 mmsys with the same power domain, the same clock driver and the same mediatek-drm driver. For MT8195, VDOSYS0 and VDOSYS1 are 2 display HW pipelines binding to 2

[PATCH v1.1] drm/i915: Split i915_gem_init_stolen()

2022-09-15 Thread Lucas De Marchi
Add some helpers: adjust_stolen(), request_smem_stolen_() and init_reserved_stolen() that are now called by i915_gem_init_stolen() to initialize each part of the Data Stolen Memory region. Main goal is to split the reserved part, also known as WOPCM, as its calculation changes often per platform.

  1   2   >