Re: [PATCH v6 39/57] dyndbg/drm: POC add tracebits sysfs-knob

2022-09-07 Thread Daniel Vetter
On Sun, Sep 04, 2022 at 03:41:16PM -0600, Jim Cromie wrote: > clone DRM.debug interface to DRM.tracebits: ie map bits to > drm-debug-categories, except this interface enables messages to > tracefs, not to syslog. > > 1- we reuse the class-map added previously. >this reflects the single source

Re: [PATCH 5/7] drm/plane-helper: Export individual helpers

2022-09-07 Thread Thomas Zimmermann
Hi Am 06.09.22 um 21:15 schrieb Daniel Vetter: On Thu, Aug 11, 2022 at 08:32:19PM +0200, Thomas Zimmermann wrote: Hi Am 11.08.22 um 18:41 schrieb Daniel Vetter: On Wed, Jul 20, 2022 at 10:30:56AM +0200, Thomas Zimmermann wrote: Export the individual plane helpers that make up the plane funct

Re: [PATCH 5/6] drm/simpledrm: Support the AB24 format

2022-09-07 Thread Thomas Zimmermann
Hi Am 05.09.22 um 18:32 schrieb Thierry Reding: From: Thierry Reding Add AB24 to the list of supported formats. The format helpers support conversion to that format and it is documented in the simple-framebuffer device tree bindings. Signed-off-by: Thierry Reding Reviewed-by: Thomas Zimmer

Re: [PATCH 4/6] drm/format-helper: Support the AB24 format

2022-09-07 Thread Thomas Zimmermann
Hi Am 05.09.22 um 18:32 schrieb Thierry Reding: From: Thierry Reding Add a conversion helper for the AB24 format to use in drm_fb_blit(). Signed-off-by: Thierry Reding --- drivers/gpu/drm/drm_format_helper.c | 35 + 1 file changed, 35 insertions(+) diff --git

Re: [PATCH v2 07/11] drm/udl: Drop unneeded alignment

2022-09-07 Thread Thomas Zimmermann
Hi Am 06.09.22 um 09:39 schrieb Takashi Iwai: The alignment of damaged area was needed for the original udlfb driver that tried to trim the superfluous copies between front and backend buffers and handle data in long int. It's not the case for udl DRM driver, hence we can omit the whole unneede

Re: [PATCH v2 09/11] drm/udl: Fix inconsistent urbs.count value during udl_free_urb_list()

2022-09-07 Thread Thomas Zimmermann
Hi Am 06.09.22 um 09:39 schrieb Takashi Iwai: In the current design, udl_get_urb() may be called asynchronously during the driver freeing its URL list via udl_free_urb_list(). The problem is that the sync is determined by comparing the urbs.count and urbs.available fields, while we clear urbs.co

Re: [PATCH v2 11/11] drm/udl: Sync pending URBs at the end of suspend

2022-09-07 Thread Thomas Zimmermann
Hi Am 06.09.22 um 09:39 schrieb Takashi Iwai: It's better to perform the sync at the very last of the suspend instead of the pipe-disable function, so that we can catch all pending URBs (if any). While we're at it, drop the error code from udl_sync_pending_urb() since we basically ignore it; in

Re: [PATCH] drm/bochs: fix blanking

2022-09-07 Thread Thomas Zimmermann
Am 06.09.22 um 16:29 schrieb Gerd Hoffmann: VGA_IS1_RC is the color mode register (VGA_IS1_RM the one for monochrome mode, note C vs. M at the end). So when using VGA_IS1_RC make sure the vga device is actually in color mode and set the corresponding bit in the misc register. Reproducible whe

Re: mgag200 broken on kernel-6.0-rc3 on DELL/T620

2022-09-07 Thread Wang Yugui
Hi, > Hi > > Am 07.09.22 um 06:16 schrieb Wang Yugui: > > Hi, > > > >> Am 02.09.22 um 07:52 schrieb Wang Yugui: > >>> Hi, > >>> > >>> mgag200 broken on kernel-6.0-rc3 on DELL/T620. > >>> > >>> See the attachementment file for the graph output. > >> > >> Thanks for reporting the bug. We recently

Re: [PATCH v2 36/41] drm/sun4i: tv: Merge mode_set into atomic_enable

2022-09-07 Thread Maxime Ripard
On Tue, Sep 06, 2022 at 10:04:32PM +0200, Jernej Škrabec wrote: > Dne ponedeljek, 29. avgust 2022 ob 15:11:50 CEST je Maxime Ripard napisal(a): > > Our mode_set implementation can be merged into our atomic_enable > > implementation to simplify things, so let's do this. > > Are you sure this is a g

Re: [PATCH] drm/ttm: Remove unnecessary '0' values from ret

2022-09-07 Thread Christian König
Am 07.09.22 um 05:29 schrieb Li zeming: The variable ret is assigned in the judgment branch statement, he does not need to initialize the assignment. Signed-off-by: Li zeming Reviewed and pushed to drm-misc-next. Thanks, Christian. --- include/drm/ttm/ttm_bo_driver.h | 2 +- 1 file chan

Re: [PATCH v3] drm/ast: add dmabuf/prime buffer sharing support

2022-09-07 Thread Thomas Zimmermann
Hi, on a more general note, let me say that your patch doesn't seem to fit the ideas of how buffer sharing is supposed to work. Your patch does the BMC screen update 'behind the scenes.' Shouldn't userspace set up the DRM state for mirroring the output of the discrete card to the BMC? Best

Re: mgag200 broken on kernel-6.0-rc3 on DELL/T620

2022-09-07 Thread Thomas Zimmermann
Hi Am 07.09.22 um 09:38 schrieb Wang Yugui: Hi, Hi Am 07.09.22 um 06:16 schrieb Wang Yugui: Hi, Am 02.09.22 um 07:52 schrieb Wang Yugui: Hi, mgag200 broken on kernel-6.0-rc3 on DELL/T620. See the attachementment file for the graph output. Thanks for reporting the bug. We recently ref

Re: [PATCH] drm/aperture: Fix some kerneldoc comments

2022-09-07 Thread Thomas Zimmermann
Hi Am 05.09.22 um 18:22 schrieb Thierry Reding: From: Thierry Reding Reword some kerneldoc comments for the DRM aperture handling code. Signed-off-by: Thierry Reding Acked-by: Thomas Zimmermann Thanks! --- drivers/gpu/drm/drm_aperture.c | 10 +- 1 file changed, 5 insertions(

Re: [Linaro-mm-sig] [PATCH v2 1/3] dma-buf: Add ioctl to query mmap info

2022-09-07 Thread Rob Clark
On Tue, Sep 6, 2022 at 12:46 PM Daniel Vetter wrote: > > On Mon, Aug 01, 2022 at 10:04:55AM -0700, Rob Clark wrote: > > From: Rob Clark > > > > This is a fairly narrowly focused interface, providing a way for a VMM > > in userspace to tell the guest kernel what pgprot settings to use when > > map

Re: [PATCH v3] drm/ast: add dmabuf/prime buffer sharing support

2022-09-07 Thread Christian König
Hi Thomas, I was wondering pretty much the same thing, but then thought that this might be the first step to direct scanout from DMA-bufs. If this isn't the case then I to see this rather critically since that functionality belongs into userspace. Regards, Christian. Am 07.09.22 um 09:50 s

Re: [PATCH v2 3/3] efi: earlycon: Add support for generic framebuffers and move to console subsystem

2022-09-07 Thread Arnd Bergmann
On Tue, Sep 6, 2022, at 11:52 PM, Daniel Vetter wrote: > On Sat, Aug 06, 2022 at 07:32:24PM +0300, Markuss Broks wrote: > > Ok I have a more fundamental issue with this than the lack of proper patch > splitting I mentioned in the other thread. > > This is the wrong place. > > drivers/video/console

Re: (subset) [PATCH v2 24/41] drm/vc4: vec: Remove empty mode_fixup

2022-09-07 Thread Maxime Ripard
On Mon, 29 Aug 2022 15:11:38 +0200, Maxime Ripard wrote: > The mode_fixup hooks are deprecated, and the behaviour we implement is the > default one anyway. Let's remove it. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: (subset) [PATCH v2 25/41] drm/vc4: vec: Convert to atomic helpers

2022-09-07 Thread Maxime Ripard
On Mon, 29 Aug 2022 15:11:39 +0200, Maxime Ripard wrote: > The VC4 VEC driver still uses legacy enable and disable hook > implementation. Let's convert to the atomic variants. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: (subset) [PATCH v2 26/41] drm/vc4: vec: Refactor VEC TV mode setting

2022-09-07 Thread Maxime Ripard
On Mon, 29 Aug 2022 15:11:40 +0200, Maxime Ripard wrote: > From: Mateusz Kwiatkowski > > Change the mode_set function pointer logic to declarative config0, > config1 and custom_freq fields, to make TV mode setting logic more > concise and uniform. > > > [...] Applied to drm/drm-misc (drm-misc-

Re: (subset) [PATCH v2 27/41] drm/vc4: vec: Remove redundant atomic_mode_set

2022-09-07 Thread Maxime Ripard
On Mon, 29 Aug 2022 15:11:41 +0200, Maxime Ripard wrote: > From: Mateusz Kwiatkowski > > Let's remove the superfluous tv_mode field, which was redundant with the > mode field in struct drm_tv_connector_state. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: (subset) [PATCH v2 28/41] drm/vc4: vec: Fix timings for VEC modes

2022-09-07 Thread Maxime Ripard
On Mon, 29 Aug 2022 15:11:42 +0200, Maxime Ripard wrote: > From: Mateusz Kwiatkowski > > This commit fixes vertical timings of the VEC (composite output) modes > to accurately represent the 525-line ("NTSC") and 625-line ("PAL") ITU-R > standards. > > Previous timings were actually defined as 50

Re: (subset) [PATCH v2 34/41] drm/sun4i: tv: Remove unused mode_valid

2022-09-07 Thread Maxime Ripard
On Mon, 29 Aug 2022 15:11:48 +0200, Maxime Ripard wrote: > The mode_valid implementation is pretty much a nop, let's remove it. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: (subset) [PATCH v2 37/41] drm/sun4i: tv: Remove useless function

2022-09-07 Thread Maxime Ripard
On Mon, 29 Aug 2022 15:11:51 +0200, Maxime Ripard wrote: > The drm_connector_to_sun4i_tv() function isn't used anywhere in the driver, > so let's remove it. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: (subset) [PATCH v2 35/41] drm/sun4i: tv: Convert to atomic hooks

2022-09-07 Thread Maxime Ripard
On Mon, 29 Aug 2022 15:11:49 +0200, Maxime Ripard wrote: > The sun4i TV driver still uses legacy enable and disable hook > implementation. Let's convert to the atomic variants. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: (subset) [PATCH v2 38/41] drm/sun4i: tv: Remove useless destroy function

2022-09-07 Thread Maxime Ripard
On Mon, 29 Aug 2022 15:11:52 +0200, Maxime Ripard wrote: > Our destroy implementation is just calling the generic helper, so let's > just remove our function and directly use the helper. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: (subset) [PATCH v2 39/41] drm/sun4i: tv: Rename error label

2022-09-07 Thread Maxime Ripard
On Mon, 29 Aug 2022 15:11:53 +0200, Maxime Ripard wrote: > The other error labels in sun4i_tv_bind() are named after the task they > perform (err_disable_clk to call clk_disable_unprepare for example). > > However, the err_cleanup_connector is named after the calling site > (drm_connector_init fai

Re: (subset) [PATCH v2 40/41] drm/sun4i: tv: Add missing reset assertion

2022-09-07 Thread Maxime Ripard
On Mon, 29 Aug 2022 15:11:54 +0200, Maxime Ripard wrote: > The reset line is deasserted at bind, and asserted if we ever encounter an > error there. However, it's never asserted in unbind which will lead to a > resource unbalance. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

[PATCH 0/3] Host1x context isolation on Tegra234

2022-09-07 Thread Mikko Perttunen
From: Mikko Perttunen Hi all, this series adds support for Host1x context isolation on Tegra234 (Orin). The difference from previous generations is that there are two IOMMUs to which engines can be attached to, resulting in having to have a set of contexts for each one. Patches should be applie

[PATCH 2/3] dt-bindings: Add Host1x context stream IDs on Tegra234

2022-09-07 Thread Mikko Perttunen
From: Mikko Perttunen Add defines for stream IDs used for Host1x context isolation on Tegra234. The same stream IDs are used for both NISO0 and NISO1 SMMUs since Host1x's stream ID protection tables don't make a distinction between the two. Signed-off-by: Mikko Perttunen --- include/dt-binding

[PATCH 1/3] gpu: host1x: Select context device based on attached IOMMU

2022-09-07 Thread Mikko Perttunen
From: Mikko Perttunen On Tegra234, engines that are programmed through Host1x channels can be attached to either the NISO0 or NISO1 SMMU. Because of that, when selecting a context device to use with an engine, we need to select one that is also attached to the same SMMU. Add a parameter to host1

[PATCH 3/3] arm64: tegra: Add context isolation domains on Tegra234

2022-09-07 Thread Mikko Perttunen
From: Mikko Perttunen Add Host1x context isolation domains on Tegra234. On Tegra234 we have two IOMMUs that are connected to Host1x-channel programmed engines, so we have to include domains for each of them. Signed-off-by: Mikko Perttunen --- arch/arm64/boot/dts/nvidia/tegra234.dtsi | 19 +

Re: [PATCH v2 14/41] drm/modes: Move named modes parsing to a separate function

2022-09-07 Thread Maxime Ripard
Hi, On Tue, Aug 30, 2022 at 04:36:23PM +0300, Jani Nikula wrote: > On Tue, 30 Aug 2022, Maxime Ripard wrote: > > Hi, > > > > On Tue, Aug 30, 2022 at 01:43:07PM +0300, Jani Nikula wrote: > >> On Tue, 30 Aug 2022, Geert Uytterhoeven wrote: > >> > On Mon, Aug 29, 2022 at 3:13 PM Maxime Ripard wrot

Re: mgag200 broken on kernel-6.0-rc3 on DELL/T620

2022-09-07 Thread Wang Yugui
Hi, > Am 07.09.22 um 09:38 schrieb Wang Yugui: > > Hi, > > > > > >> Hi > >> > >> Am 07.09.22 um 06:16 schrieb Wang Yugui: > >>> Hi, > >>> > Am 02.09.22 um 07:52 schrieb Wang Yugui: > > Hi, > > > > mgag200 broken on kernel-6.0-rc3 on DELL/T620. > > > > See the attachementme

Re: [PATCH v5,2/2] drm: mediatek: Adjust the dpi output format to MT8186

2022-09-07 Thread CK Hu
Hi, Xinlei: On Mon, 2022-09-05 at 21:34 +0800, xinlei@mediatek.com wrote: > From: Xinlei Lee > > Dpi output needs to adjust the output format to dual edge for MT8186. Separate this patch into two patches. One is adding edge_cfg_in_mmsys, and another one is adding mt8186 dpi support. I thin

Re: mgag200 broken on kernel-6.0-rc3 on DELL/T620

2022-09-07 Thread Thomas Zimmermann
Hi Am 07.09.22 um 10:47 schrieb Wang Yugui: Hi, Am 07.09.22 um 09:38 schrieb Wang Yugui: Hi, Hi Am 07.09.22 um 06:16 schrieb Wang Yugui: Hi, Am 02.09.22 um 07:52 schrieb Wang Yugui: Hi, mgag200 broken on kernel-6.0-rc3 on DELL/T620. See the attachementment file for the graph output.

Re: [PATCH v2] drm/ttm: update bulk move object of ghost BO

2022-09-07 Thread Matthew Auld
On Tue, 6 Sept 2022 at 09:54, Christian König wrote: > > Am 06.09.22 um 10:46 schrieb ZhenGuo Yin: > > [Why] > > Ghost BO is released with non-empty bulk move object. There is a > > warning trace: > > WARNING: CPU: 19 PID: 1582 at ttm/ttm_bo.c:366 ttm_bo_release+0x2e1/0x2f0 > > [amdttm] > > Call

Re: [PATCH v2] drm/ttm: update bulk move object of ghost BO

2022-09-07 Thread Christian König
Am 07.09.22 um 11:21 schrieb Matthew Auld: On Tue, 6 Sept 2022 at 09:54, Christian König wrote: Am 06.09.22 um 10:46 schrieb ZhenGuo Yin: [Why] Ghost BO is released with non-empty bulk move object. There is a warning trace: WARNING: CPU: 19 PID: 1582 at ttm/ttm_bo.c:366 ttm_bo_release+0x2e1/0x

Re: [PATCH v3] drm/ast: add dmabuf/prime buffer sharing support

2022-09-07 Thread Thomas Zimmermann
Hi Am 07.09.22 um 10:10 schrieb Christian König: Hi Thomas, I was wondering pretty much the same thing, but then thought that this might be the first step to direct scanout from DMA-bufs. If this isn't the case then I to see this rather critically since that functionality belongs into users

Re: [PATCH v2 00/41] drm: Analog TV Improvements

2022-09-07 Thread Maxime Ripard
On Mon, Sep 05, 2022 at 05:17:18PM +0200, Noralf Trønnes wrote: > Den 05.09.2022 16.57, skrev Maxime Ripard: > > On Fri, Sep 02, 2022 at 01:28:16PM +0200, Noralf Trønnes wrote: > >> > >> > >> Den 01.09.2022 21.35, skrev Noralf Trønnes: > >>> > >>> > >>> I have finally found a workaround for my kern

[PATCH] drm/ttm: cleanup the resource of ghost objects after locking them

2022-09-07 Thread Christian König
Otherwise lockdep will complain about cleaning up the bulk_move. Not even compile tested. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo_util.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c b/drivers/gpu/drm/ttm/

Re: [PATCH v4 02/12] drm: bridge: Add Samsung DSIM bridge driver

2022-09-07 Thread Marek Szyprowski
Hi Jagan, On 06.09.2022 21:07, Jagan Teki wrote: > On Mon, Sep 5, 2022 at 4:54 PM Marek Szyprowski > wrote: >> On 02.09.2022 12:47, Marek Szyprowski wrote: >>> On 29.08.2022 20:40, Jagan Teki wrote: Samsung MIPI DSIM controller is common DSI IP that can be used in various SoCs like

Re: [PATCH] drm/ttm: cleanup the resource of ghost objects after locking them

2022-09-07 Thread Matthew Auld
On Wed, 7 Sept 2022 at 11:00, Christian König wrote: > > Otherwise lockdep will complain about cleaning up the bulk_move. > > Not even compile tested. > > Signed-off-by: Christian König Can we quickly resend with --cc=intel-...@lists.freedesktop.org to trigger a CI run? It will even compile test

Re: [PATCH v3] drm/ast: add dmabuf/prime buffer sharing support

2022-09-07 Thread oushixiong
Hi, Firstly, the dirty() call back function is called by drm_mode_dirtyfb_ioctl.     drm_mode_dirtyfb_ioctl         |__   fb->funcs->dirty(fb, file_priv, flags, r->color,clips, num_clips);                         |__ ast_user_framebuffer_dirty                                     |__ ast_hand

Re: [PATCH] drm/virtio: set fb_modifiers_not_supported

2022-09-07 Thread Gerd Hoffmann
On Wed, Aug 31, 2022 at 12:06:01PM -0700, Chia-I Wu wrote: > Without this, the drm core advertises LINEAR modifier which is > incorrect. > > Also userspace virgl does not support modifiers. For example, it causes > chrome on ozone/drm to fail with "Failed to create scanout buffer". > > Fixes: 2a

Re: [PATCH] drm/qxl: fix the suspend/resume issue on qxl device

2022-09-07 Thread Gerd Hoffmann
On Wed, Sep 07, 2022 at 05:44:23PM +0800, Zongmin Zhou wrote: > > From: Zongmin Zhou > > Details: > Currently, when trying to suspend and resume with qxl device, > there are some error messages after resuming, > eventually caused to black screen and can't be recovered. [ analysis snipped ] > L

Re: [PATCH v8 2/2] drm/gem: Don't map imported GEMs

2022-09-07 Thread Dmitry Osipenko
On 8/23/22 19:47, Rob Clark wrote: > On Tue, Aug 23, 2022 at 3:01 AM Christian König > wrote: >> >> Am 22.08.22 um 19:26 schrieb Dmitry Osipenko: >>> On 8/16/22 22:55, Dmitry Osipenko wrote: On 8/16/22 15:03, Christian König wrote: > Am 16.08.22 um 13:44 schrieb Dmitry Osipenko: >> [S

Re: [PATCH] drm/ttm: cleanup the resource of ghost objects after locking them

2022-09-07 Thread Matthew Auld
On Wed, 7 Sept 2022 at 11:00, Christian König wrote: > > Otherwise lockdep will complain about cleaning up the bulk_move. > > Not even compile tested. > > Signed-off-by: Christian König Looks reasonable to me, Reviewed-by: Matthew Auld > --- > drivers/gpu/drm/ttm/ttm_bo_util.c | 10 +-

Re: [PATCH v2 00/41] drm: Analog TV Improvements

2022-09-07 Thread Stefan Wahren
Hi Maxime, Am 05.09.22 um 16:57 schrieb Maxime Ripard: On Fri, Sep 02, 2022 at 01:28:16PM +0200, Noralf Trønnes wrote: Den 01.09.2022 21.35, skrev Noralf Trønnes: I have finally found a workaround for my kernel hangs. Dom had a look at my kernel and found that the VideoCore was fine, and he

Re: [PATCH v2 00/41] drm: Analog TV Improvements

2022-09-07 Thread Noralf Trønnes
Den 07.09.2022 11.58, skrev Maxime Ripard: > On Mon, Sep 05, 2022 at 05:17:18PM +0200, Noralf Trønnes wrote: >> Den 05.09.2022 16.57, skrev Maxime Ripard: >>> On Fri, Sep 02, 2022 at 01:28:16PM +0200, Noralf Trønnes wrote: Den 01.09.2022 21.35, skrev Noralf Trønnes: > > >>

Re: [PATCH 0/8] Support for NVDEC on Tegra234

2022-09-07 Thread Krzysztof Kozlowski
On 07/09/2022 07:27, Mikko Perttunen wrote: > On 9/6/22 20:50, Krzysztof Kozlowski wrote: >> On 06/09/2022 15:28, Mikko Perttunen wrote: >>> From: Mikko Perttunen >>> >>> Hi all, >>> >>> this series adds support for the HW video decoder, NVDEC, >>> on Tegra234 (Orin). The main change is a switch f

Re: [PATCH 2/8] dt-bindings: Add headers for NVDEC on Tegra234

2022-09-07 Thread Krzysztof Kozlowski
On 06/09/2022 15:28, Mikko Perttunen wrote: > From: Mikko Perttunen > > Add clock, memory controller, powergate and reset dt-binding headers > necessary for NVDEC. > > Signed-off-by: Mikko Perttunen Acked-by: Krzysztof Kozlowski (which is ack also for memory-controllers part, feel free to t

Re: [PATCH 3/8] dt-bindings: Add bindings for Tegra234 NVDEC

2022-09-07 Thread Krzysztof Kozlowski
On 06/09/2022 15:28, Mikko Perttunen wrote: > From: Mikko Perttunen > > Update NVDEC bindings for Tegra234. This new engine version only has > two memory clients, but now requires three clocks, and as a bigger > change the engine loads firmware from a secure carveout configured by > the bootloade

Re: [PATCH 0/8] Support for NVDEC on Tegra234

2022-09-07 Thread Mikko Perttunen
On 7.9.2022 13.58, Krzysztof Kozlowski wrote: On 07/09/2022 07:27, Mikko Perttunen wrote: On 9/6/22 20:50, Krzysztof Kozlowski wrote: On 06/09/2022 15:28, Mikko Perttunen wrote: From: Mikko Perttunen Hi all, this series adds support for the HW video decoder, NVDEC, on Tegra234 (Orin). The m

[PATCH] drm/amdkfd: fix repeated words in comments

2022-09-07 Thread Jilin Yuan
Delete the redundant word 'to'. Signed-off-by: Jilin Yuan --- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c index 24b414cff3ec..cd5f8b219bf9 100644 --- a/dri

[PATCH] drm/amdgpu: fix repeated words in comments

2022-09-07 Thread Jilin Yuan
Delete the redundant word 'we'. Signed-off-by: Jilin Yuan --- drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c index 02cb3a12dd76..6d6cc4637d41 100644 ---

[PATCH] drm/amdgpu: fix repeated words in comments

2022-09-07 Thread Jilin Yuan
Delete the redundant word 'and'. Delete the redundant word 'in'. Delete the redundant word 'the'. Delete the redundant word 'are'. Signed-off-by: Jilin Yuan --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/am

[v1] arm64: dts: qcom: sc7280: assign DSI clock source parents

2022-09-07 Thread Rajeev Nandan
Assign DSI clock source parents to DSI PHY clocks. Signed-off-by: Rajeev Nandan Cc: Dmitry Baryshkov --- This change is needed after the refactor done by the patch [2] (drm/msm/dsi: stop setting clock parents manually) of series [1], to fix the DSI pixel clock set rate error: dsi_link_clk_se

[PATCH] drm/edid: fix repeated words in comments

2022-09-07 Thread Jilin Yuan
Delete the redundant word 'on'. Signed-off-by: Jilin Yuan --- drivers/gpu/drm/drm_edid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 4005dab6147d..25866b568d6b 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/driv

[PATCH] drm/gma500: fix repeated words in comments

2022-09-07 Thread Jilin Yuan
Delete the redundant word 'for'. Signed-off-by: Jilin Yuan --- drivers/gpu/drm/gma500/oaktrail_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/gma500/oaktrail_crtc.c b/drivers/gpu/drm/gma500/oaktrail_crtc.c index 6004390d647a..64761f46b434 100644 --- a

回复: Re: [PATCH] drm/qxl: fix the suspend/resume issue on qxl device

2022-09-07 Thread 周宗敏
Dear Gerd:Thanks for your reply.If there are anything else, please feel free to contact me.            主 题:Re: [PATCH] drm/qxl: fix the suspend/resume issue on qxl device            日 期:2022-09-07 18:17            发件人:Gerd Hoffmann            收件人:Zongmin Zhou                          

Re: (subset) [PATCH 2/3] MAINTAINERS: pwm-fan: Drop Bartlomiej Zolnierkiewicz

2022-09-07 Thread Krzysztof Kozlowski
On Mon, 8 Aug 2022 13:15:25 +0300, Krzysztof Kozlowski wrote: > Bartlomiej's Samsung email address is not working since around last > year and there was no follow up patch take over of the drivers, so drop > the email from maintainers. > > Applied, thanks! [2/3] MAINTAINERS: pwm-fan: Drop Bartl

Re: [PATCH v2 09/41] drm/connector: Add TV standard property

2022-09-07 Thread Maxime Ripard
Hi, On Fri, Sep 02, 2022 at 12:00:33AM +0200, Mateusz Kwiatkowski wrote: > W dniu 29.08.2022 o 15:11, Maxime Ripard pisze: > > The TV mode property has been around for a while now to select and get the > > current TV mode output on an analog TV connector. > > > > Despite that property name being g

Re: [PATCH v2 09/41] drm/connector: Add TV standard property

2022-09-07 Thread Maxime Ripard
On Fri, Sep 02, 2022 at 09:35:20AM +0200, Geert Uytterhoeven wrote: > On Fri, Sep 2, 2022 at 12:00 AM Mateusz Kwiatkowski wrote: > > W dniu 29.08.2022 o 15:11, Maxime Ripard pisze: > > > The TV mode property has been around for a while now to select and get the > > > current TV mode output on an a

Re: [PATCH v2 01/15] vfio: Add helpers for unifying vfio_device life cycle

2022-09-07 Thread Jason Gunthorpe
On Wed, Sep 07, 2022 at 04:55:18AM -0700, Christoph Hellwig wrote: > On Wed, Sep 07, 2022 at 12:43:30AM +, Tian, Kevin wrote: > > > From: Christoph Hellwig > > > Sent: Tuesday, September 6, 2022 5:42 PM > > > > > > What is the point? This adds indirect calls, and actually creates > > > more b

Re: [PATCH] drm/gma500: fix repeated words in comments

2022-09-07 Thread Patrik Jakobsson
On Wed, Sep 7, 2022 at 1:39 PM Jilin Yuan wrote: > > Delete the redundant word 'for'. > > Signed-off-by: Jilin Yuan Patch applied to drm-misc-next -Patrik > --- > drivers/gpu/drm/gma500/oaktrail_crtc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/gm

Re: [PATCH v2 4/4] vfio/pci: Allow MMIO regions to be exported through dma-buf

2022-09-07 Thread Jason Gunthorpe
On Wed, Sep 07, 2022 at 05:05:57AM -0700, Christoph Hellwig wrote: > On Tue, Sep 06, 2022 at 08:48:28AM -0300, Jason Gunthorpe wrote: > > Right, this whole thing is the "standard" that dmabuf has adopted > > instead of the struct pages. Once the AMD GPU driver started doing > > this some time ago o

[Bug 216455] PCI AER error caused by LTR enablement on amdgpu with LTR disabled on video card PCIe bridge

2022-09-07 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216455 --- Comment #3 from Lijo Lazar (lijo.la...@gmail.com) --- Created attachment 301760 --> https://bugzilla.kernel.org/attachment.cgi?id=301760&action=edit LTR Fix Does the attached patch help? -- You may reply to this email to add a comment. Y

Re: [PATCH 1/2] dt-bindings: display: panel: Add NewVision NV3051D panel bindings

2022-09-07 Thread Krzysztof Kozlowski
On 06/09/2022 20:52, Chris Morgan wrote: > From: Chris Morgan > > Add documentation for the NewVision NV3051D panel bindings. > Note that for the two expected consumers of this panel binding > the underlying LCD model is unknown. > > Signed-off-by: Chris Morgan > --- > .../display/panel/newvis

Re: [PATCH 0/3] iommu/dma: Some housekeeping

2022-09-07 Thread Joerg Roedel
On Tue, Aug 16, 2022 at 06:28:02PM +0100, Robin Murphy wrote: > Robin Murphy (3): > iommu/dma: Clean up Kconfig > iommu/dma: Move public interfaces to linux/iommu.h > iommu/dma: Make header private Applied, thanks. > include/linux/dma-iommu.h | 93 - S

Re: [PATCH V2 1/2] dt-bindings: Add byteswap order to chrontel ch7033

2022-09-07 Thread Chris Morgan
On Mon, Sep 05, 2022 at 05:20:57PM +0200, Robert Foss wrote: > Thanks Laurent, > > On Sat, 3 Sept 2022 at 02:17, Laurent Pinchart > wrote: > > > > Hi Chris, > > > > Thank you for the patch. > > > > On Fri, Sep 02, 2022 at 10:39:05AM -0500, Chris Morgan wrote: > > > From: Chris Morgan > > > > > >

Re: [PATCH 1/2] dt-bindings: display: panel: Add NewVision NV3051D panel bindings

2022-09-07 Thread Chris Morgan
On Wed, Sep 07, 2022 at 02:53:56PM +0200, Krzysztof Kozlowski wrote: > On 06/09/2022 20:52, Chris Morgan wrote: > > From: Chris Morgan > > > > Add documentation for the NewVision NV3051D panel bindings. > > Note that for the two expected consumers of this panel binding > > the underlying LCD mode

Re: [PATCH 1/2] dt-bindings: display: panel: Add Samsung AMS495QA01 panel bindings

2022-09-07 Thread Chris Morgan
On Tue, Sep 06, 2022 at 04:41:00PM -0500, Rob Herring wrote: > On Tue, 06 Sep 2022 13:36:41 -0500, Chris Morgan wrote: > > From: Chris Morgan > > > > Add documentation for the Samsung AMS495QA01 panel. > > > > Signed-off-by: Chris Morgan > > --- > > .../display/panel/samsung,ams495qa01.yaml

Re: [Intel-gfx] [PATCH] drm/i915: Rename ggtt_view as gtt_view

2022-09-07 Thread Tvrtko Ursulin
On 06/09/2022 17:14, Tvrtko Ursulin wrote: On 05/09/2022 10:34, Tvrtko Ursulin wrote: On 01/09/2022 19:38, Niranjana Vishwanathapura wrote: So far, different views (normal, partial, rotated and remapped) into the same object are only supported for GGTT mappings. But with the upcoming VM_BIN

[PATCH] fbdev: remove redundant initialization to variable identical

2022-09-07 Thread Colin Ian King
The variable identical is being initialized with a value that is never read. The variable is being re-assigned later on. The initialization is redundant and can be removed. Cleans up clang scan-build warning: drivers/video/fbdev/udlfb.c:373:6: warning: Value stored to 'identical' during its initia

[PATCH] drm/qxl: fix the suspend/resume issue on qxl device

2022-09-07 Thread Zongmin Zhou
From: Zongmin Zhou Details: Currently, when trying to suspend and resume with qxl device, there are some error messages after resuming, eventually caused to black screen and can't be recovered. The first error message: [ 64.668577][C3] [drm] driver is in bug mode This error is

Re: [PATCH v6 10/57] dyndbg: cleanup auto vars in dynamic_debug_init

2022-09-07 Thread Jason Baron
On 9/4/22 17:40, Jim Cromie wrote: > rework var-names for clarity, regularity > rename variables > - n to mod_sites - it counts sites-per-module > - entries to i - display only > - iter_start to iter_mod_start - marks start of each module's subrange > - modct to mod_ct - stylistic > > n

[PATCH] drm/dp_mst: Avoid deleting payloads for connectors staying enabled

2022-09-07 Thread Imre Deak
When an MST connector stays enabled during a commit the connector's MST state needs to be added to the atomic state, but the corresponding MST payload allocation shouldn't be set for deletion; fix such modesets by ensuring the above even if the connector was already enabled before the modeset. The

Re: [PATCH v2 10/41] drm/modes: Add a function to generate analog display modes

2022-09-07 Thread Maxime Ripard
On Mon, Sep 05, 2022 at 06:44:42PM +0200, Mateusz Kwiatkowski wrote: > Hi Maxime, > > W dniu 5.09.2022 o 15:37, Maxime Ripard pisze: > >>> +    vfp = vfp_min + (porches_rem / 2); > >>> +    vbp = porches - vfp; > >> > >> Relative position of the vertical sync within the VBI effectively moves the >

Re: [PATCH v2 10/41] drm/modes: Add a function to generate analog display modes

2022-09-07 Thread Maxime Ripard
On Mon, Sep 05, 2022 at 06:32:14PM +0200, Mateusz Kwiatkowski wrote: > Hi Maxime, > > W dniu 5.09.2022 o 15:32, Maxime Ripard pisze: > > Hi, > > > > On Wed, Aug 31, 2022 at 10:14:28AM +0200, Geert Uytterhoeven wrote: > +enum drm_mode_analog { > +    DRM_MODE_ANALOG_NTSC, > +    DRM_

Re: [PATCH v2 4/4] vfio/pci: Allow MMIO regions to be exported through dma-buf

2022-09-07 Thread Oded Gabbay
On Wed, Sep 7, 2022 at 5:30 PM Christoph Hellwig wrote: > > On Wed, Sep 07, 2022 at 09:33:11AM -0300, Jason Gunthorpe wrote: > > Yes, you said that, and I said that when the AMD driver first merged > > it - but it went in anyhow and now people are using it in a bunch of > > places. > > drm folks m

Re: [PATCH] drm/amdgpu: fix repeated words in comments

2022-09-07 Thread Robin Murphy
On 2022-09-07 12:26, Jilin Yuan wrote: Delete the redundant word 'we'. FWIW, to me it's not redundant because while indeed it is not correct, it looks exactly like the kind of typo I might make of "if we", and parsing it as *that* does make sense. The sentence you end up with here can hardly

Re: [PATCH v6 21/57] dyndbg: test DECLARE_DYNDBG_CLASSMAP, sysfs nodes

2022-09-07 Thread Greg KH
On Sun, Sep 04, 2022 at 03:40:58PM -0600, Jim Cromie wrote: > Demonstrate use of DECLARE_DYNDBG_CLASSMAP macro, and expose them as > sysfs-nodes for testing. Wait, why sysfs? sysfs isn't for testing, why not use debugfs? > > For each of the 4 class-map-types: > > - declare a class-map of th

Re: [PATCH] drm/amdgpu: fix repeated words in comments

2022-09-07 Thread Robin Murphy
On 2022-09-07 12:34, Jilin Yuan wrote: Delete the redundant word 'and'. Delete the redundant word 'in'. Delete the redundant word 'the'. Delete the redundant word 'are'. Signed-off-by: Jilin Yuan --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 +++--- 1 file changed, 3 insertions(+), 3 de

Re: [PATCH] drm/amdgpu: fix repeated words in comments

2022-09-07 Thread Alex Deucher
On Wed, Sep 7, 2022 at 10:50 AM Robin Murphy wrote: > > On 2022-09-07 12:26, Jilin Yuan wrote: > > Delete the redundant word 'we'. > > FWIW, to me it's not redundant because while indeed it is not correct, > it looks exactly like the kind of typo I might make of "if we", and > parsing it as *that*

Re: [PATCH v6 21/57] dyndbg: test DECLARE_DYNDBG_CLASSMAP, sysfs nodes

2022-09-07 Thread Greg KH
On Wed, Sep 07, 2022 at 04:54:00PM +0200, Greg KH wrote: > On Sun, Sep 04, 2022 at 03:40:58PM -0600, Jim Cromie wrote: > > Demonstrate use of DECLARE_DYNDBG_CLASSMAP macro, and expose them as > > sysfs-nodes for testing. > > Wait, why sysfs? > > sysfs isn't for testing, why not use debugfs? > >

Re: [PATCH v2 4/4] vfio/pci: Allow MMIO regions to be exported through dma-buf

2022-09-07 Thread Robin Murphy
On 2022-09-07 13:33, Jason Gunthorpe wrote: On Wed, Sep 07, 2022 at 05:05:57AM -0700, Christoph Hellwig wrote: On Tue, Sep 06, 2022 at 08:48:28AM -0300, Jason Gunthorpe wrote: Right, this whole thing is the "standard" that dmabuf has adopted instead of the struct pages. Once the AMD GPU driver

Re: [PATCH v6 00/57] DYNDBG: opt-in class'd debug for modules, use in drm.

2022-09-07 Thread Greg KH
On Sun, Sep 04, 2022 at 03:40:37PM -0600, Jim Cromie wrote: > hi Greg, Jason, DRM-folk, Steven, > > If Im not too late for linux-next in this cycle, heres V6. Diffs are minor: > > - rebased onto e47eb90a0a9a (tag: next-20220901, linux-next/master) >gets past Kconfig conflict, same for drm-t

Re: [PATCH v2 4/4] vfio/pci: Allow MMIO regions to be exported through dma-buf

2022-09-07 Thread Christian König
Am 07.09.22 um 14:03 schrieb Christoph Hellwig: On Tue, Sep 06, 2022 at 12:38:44PM +0200, Christian König wrote: The problem is once more that this is MMIO space, in other words register BARs which needs to be exported/imported. Everything used for P2P is bar space. Adding struct pages for it

Re: Re: [PATCH v2 36/41] drm/sun4i: tv: Merge mode_set into atomic_enable

2022-09-07 Thread Jernej Škrabec
Dne sreda, 07. september 2022 ob 09:41:34 CEST je Maxime Ripard napisal(a): > On Tue, Sep 06, 2022 at 10:04:32PM +0200, Jernej Škrabec wrote: > > Dne ponedeljek, 29. avgust 2022 ob 15:11:50 CEST je Maxime Ripard napisal(a): > > > Our mode_set implementation can be merged into our atomic_enable > >

Re: [PATCH v2 4/4] vfio/pci: Allow MMIO regions to be exported through dma-buf

2022-09-07 Thread Jason Gunthorpe
On Wed, Sep 07, 2022 at 07:29:58AM -0700, Christoph Hellwig wrote: > On Wed, Sep 07, 2022 at 09:33:11AM -0300, Jason Gunthorpe wrote: > > Yes, you said that, and I said that when the AMD driver first merged > > it - but it went in anyhow and now people are using it in a bunch of > > places. > > dr

Re: [PATCH v2] drm/sced: Add FIFO sched policy to rq

2022-09-07 Thread Andrey Grodzovsky
Luben, just a ping, whenever you have time. Andrey On 2022-09-05 01:57, Christian König wrote: Am 03.09.22 um 04:48 schrieb Andrey Grodzovsky: Poblem: Given many entities competing for same rq on same scheduler an uncceptabliy long wait time for some jobs waiting stuck in rq before being pic

[Bug 216455] PCI AER error caused by LTR enablement on amdgpu with LTR disabled on video card PCIe bridge

2022-09-07 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216455 --- Comment #4 from Gustaw Smolarczyk (wielkie...@gmail.com) --- Yes, it does. LTR+ is no longer being enabled with this patch. -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee

Re: [PATCH v2 4/4] vfio/pci: Allow MMIO regions to be exported through dma-buf

2022-09-07 Thread Jason Gunthorpe
On Wed, Sep 07, 2022 at 08:32:23AM -0700, Christoph Hellwig wrote: > On Wed, Sep 07, 2022 at 12:23:28PM -0300, Jason Gunthorpe wrote: > > 2) DMABUF abuses dma_map_resource() for P2P and thus doesn't work in > > certain special cases. > > Not just certain special cases, but one of the main use

[Bug 216455] PCI AER error caused by LTR enablement on amdgpu with LTR disabled on video card PCIe bridge

2022-09-07 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216455 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC||alexdeuc...@gmail.c

Re: [PATCH v3 11/14] drm/i915/mtl: Add gsi_offset when emitting aux table invalidation

2022-09-07 Thread Iddamsetty, Aravind
On 07-09-2022 05:19, Matt Roper wrote: > The aux table invalidation registers are a bit unique --- they're > engine-centric registers that reside in the GSI register space rather > than within the engines' regular MMIO ranges. That means that when > issuing invalidation on engines in the standa

Re: [PATCH v2 1/4] drm/sched: Enable signaling for finished fence

2022-09-07 Thread Andrey Grodzovsky
On 2022-09-07 02:37, Christian König wrote: Am 06.09.22 um 21:55 schrieb Andrey Grodzovsky: On 2022-09-06 02:34, Christian König wrote: Am 05.09.22 um 18:34 schrieb Arvind Yadav: Here's enabling software signaling for finished fence. Signed-off-by: Arvind Yadav --- Changes in v1 : 1- Add

Re: [PATCH v2 4/4] vfio/pci: Allow MMIO regions to be exported through dma-buf

2022-09-07 Thread Robin Murphy
On 2022-09-07 16:23, Jason Gunthorpe wrote: On Wed, Sep 07, 2022 at 07:29:58AM -0700, Christoph Hellwig wrote: On Wed, Sep 07, 2022 at 09:33:11AM -0300, Jason Gunthorpe wrote: Yes, you said that, and I said that when the AMD driver first merged it - but it went in anyhow and now people are usin

Re: [PATCH] drm/udl: Enable damage clipping

2022-09-07 Thread Daniel Vetter
On Wed, Sep 07, 2022 at 08:59:17AM +0200, Thomas Zimmermann wrote: > Hi > > Am 06.09.22 um 21:35 schrieb Daniel Vetter: > > On Thu, Jul 28, 2022 at 09:47:56AM +0200, Thomas Zimmermann wrote: > > > Call drm_plane_enable_fb_damage_clips() and give userspace a chance > > > of minimizing the updated d

Re: [PATCH v2 1/3] dma-buf: Add ioctl to query mmap coherency/cache info

2022-09-07 Thread Daniel Vetter
On Tue, Aug 16, 2022 at 06:50:54PM +0200, Christian König wrote: > Am 16.08.22 um 16:26 schrieb Rob Clark: > > On Tue, Aug 16, 2022 at 1:27 AM Christian König > > wrote: > > > Am 15.08.22 um 23:15 schrieb Rob Clark: > > > > From: Rob Clark > > > > > > > > This is a fairly narrowly focused interf

  1   2   >