Re: [PATCH v4 12/21] xen/gntdev: Prepare to dynamic dma-buf locking specification

2022-09-01 Thread Christian König
Am 31.08.22 um 17:37 schrieb Dmitry Osipenko: Prepare gntdev driver to the common dynamic dma-buf locking convention by starting to use the unlocked versions of dma-buf API functions. Signed-off-by: Dmitry Osipenko Acked-by: Christian König --- drivers/xen/gntdev-dmabuf.c | 8

Re: [PATCH v4 13/21] media: videobuf2: Prepare to dynamic dma-buf locking specification

2022-09-01 Thread Christian König
Am 31.08.22 um 17:37 schrieb Dmitry Osipenko: Prepare V4L2 memory allocators to the common dynamic dma-buf locking convention by starting to use the unlocked versions of dma-buf API functions. Acked-by: Tomasz Figa Signed-off-by: Dmitry Osipenko Acked-by: Christian König --- drivers/med

Re: [PATCH v4 14/21] media: tegra-vde: Prepare to dynamic dma-buf locking specification

2022-09-01 Thread Christian König
Am 31.08.22 um 17:37 schrieb Dmitry Osipenko: Prepare Tegra video decoder driver to the common dynamic dma-buf locking convention by starting to use the unlocked versions of dma-buf API functions. Signed-off-by: Dmitry Osipenko Acked-by: Christian König --- drivers/media/platform/nvidia/

Re: [PATCH v4 16/21] dma-buf: Move dma_buf_attach() to dynamic locking specification

2022-09-01 Thread Christian König
Am 31.08.22 um 17:37 schrieb Dmitry Osipenko: Move dma-buf attachment API functions to the dynamic locking specification by taking the reservation lock around the mapping operations. The strict locking convention prevents deadlock situations for dma-buf importers and exporters. Signed-off-by: Dm

Re: [PATCH v4 17/21] dma-buf: Move dma_buf_map_attachment() to dynamic locking specification

2022-09-01 Thread Christian König
Am 31.08.22 um 17:37 schrieb Dmitry Osipenko: Move dma-buf attachment mapping functions to the dynamic locking specification by asserting that the reservation lock is held. Signed-off-by: Dmitry Osipenko Reviewed-by: Christian König --- drivers/dma-buf/dma-buf.c | 10 ++ 1 file

Re: [PATCH v4 19/21] dma-buf: Document dynamic locking convention

2022-09-01 Thread Christian König
Am 31.08.22 um 17:37 schrieb Dmitry Osipenko: Add documentation for the dynamic locking convention. The documentation tells dma-buf API users when they should take the reservation lock and when not. Signed-off-by: Dmitry Osipenko Reviewed-by: Christian König --- Documentation/driver-api/

[PATCH v2 00/15] Tidy up vfio_device life cycle

2022-09-01 Thread Kevin Tian
The idea is to let vfio core manage the vfio_device life cycle instead of duplicating the logic cross drivers. Besides cleaner code in driver side this also allows adding struct device to vfio_device as the first step toward adding cdev uAPI in the future. Another benefit is that user can now look

[PATCH v2 01/15] vfio: Add helpers for unifying vfio_device life cycle

2022-09-01 Thread Kevin Tian
The idea is to let vfio core manage the vfio_device life cycle instead of duplicating the logic cross drivers. This is also a preparatory step for adding struct device into vfio_device. New pair of helpers together with a kref in vfio_device: - vfio_alloc_device() - vfio_put_device() Drivers c

[PATCH v2 02/15] vfio/pci: Use the new device life cycle helpers

2022-09-01 Thread Kevin Tian
From: Yi Liu Also introduce two pci core helpers as @init/@release for pci drivers: - vfio_pci_core_init_dev() - vfio_pci_core_release_dev() Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe --- drivers/vfio/pci/vfio_pci.c | 20 +- drivers/v

[PATCH v2 03/15] vfio/mlx5: Use the new device life cycle helpers

2022-09-01 Thread Kevin Tian
From: Yi Liu mlx5 has its own @init/@release for handling migration cap. Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe --- drivers/vfio/pci/mlx5/main.c | 49 ++-- 1 file changed, 36 insertions(+), 13 deletions(-) diff --git a/dr

[PATCH v2 04/15] vfio/hisi_acc: Use the new device life cycle helpers

2022-09-01 Thread Kevin Tian
From: Yi Liu Tidy up @probe so all migration specific initialization logic is moved to migration specific @init callback. Remove vfio_pci_core_{un}init_device() given no user now. Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe Reviewed-by: Shameer Kolothum ---

[PATCH v2 05/15] vfio/mdpy: Use the new device life cycle helpers

2022-09-01 Thread Kevin Tian
From: Yi Liu and manage mdpy_count inside @init/@release. Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe --- samples/vfio-mdev/mdpy.c | 81 +++- 1 file changed, 47 insertions(+), 34 deletions(-) diff --git a/samples/vfio-mdev

[PATCH v2 06/15] vfio/mtty: Use the new device life cycle helpers

2022-09-01 Thread Kevin Tian
From: Yi Liu and manage available ports inside @init/@release. Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe --- samples/vfio-mdev/mtty.c | 67 +++- 1 file changed, 39 insertions(+), 28 deletions(-) diff --git a/samples/vfio

[PATCH v2 07/15] vfio/mbochs: Use the new device life cycle helpers

2022-09-01 Thread Kevin Tian
From: Yi Liu and manage avail_mbytes inside @init/@release. Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe --- samples/vfio-mdev/mbochs.c | 73 -- 1 file changed, 46 insertions(+), 27 deletions(-) diff --git a/samples/vfio-md

[PATCH v2 08/15] drm/i915/gvt: Use the new device life cycle helpers

2022-09-01 Thread Kevin Tian
Move vfio_device to the start of intel_vgpu as required by the new helpers. Change intel_gvt_create_vgpu() to use intel_vgpu as the first param as other vgpu helpers do. Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe --- drivers/gpu/drm/i915/gvt/gvt.h | 5 ++- drivers/gpu/drm/i915/g

[PATCH v2 09/15] vfio/ap: Use the new device life cycle helpers

2022-09-01 Thread Kevin Tian
From: Yi Liu and manage available_instances inside @init/@release. Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Tony Krowiak Reviewed-by: Jason Gunthorpe --- drivers/s390/crypto/vfio_ap_ops.c | 50 ++- 1 file changed, 29 insertions(+), 21 deletion

[PATCH v2 10/15] vfio/fsl-mc: Use the new device life cycle helpers

2022-09-01 Thread Kevin Tian
From: Yi Liu Also add a comment to mark that vfio core releases device_set if @init fails. Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe --- drivers/vfio/fsl-mc/vfio_fsl_mc.c | 85 ++- 1 file changed, 49 insertions(+), 36 deletions(-

[PATCH v2 12/15] vfio/amba: Use the new device life cycle helpers

2022-09-01 Thread Kevin Tian
Implement amba's own vfio_device_ops. Remove vfio_platform_probe/remove_common() given no user now. Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe --- drivers/vfio/platform/vfio_amba.c | 72 ++- drivers/vfio/platform/vfio_platform_common.c | 60

[PATCH v2 11/15] vfio/platform: Use the new device life cycle helpers

2022-09-01 Thread Kevin Tian
Move vfio_device_ops from platform core to platform drivers so device specific init/cleanup can be added. Introduce two new helpers vfio_platform_init/release_common() for the use in driver @init/@release. vfio_platform_probe/remove_common() will be deprecated. Signed-off-by: Kevin Tian Reviewe

[PATCH v2 13/15] vfio/ccw: Use the new device life cycle helpers

2022-09-01 Thread Kevin Tian
ccw is the only exception which cannot use vfio_alloc_device() because its private device structure is designed to serve both mdev and parent. Life cycle of the parent is managed by css_driver so vfio_ccw_private must be allocated/freed in css_driver probe/remove path instead of conforming to vfio

[PATCH v2 14/15] vfio: Rename vfio_device_put() and vfio_device_try_get()

2022-09-01 Thread Kevin Tian
With the addition of vfio_put_device() now the names become confusing. vfio_put_device() is clear from object life cycle p.o.v given kref. vfio_device_put()/vfio_device_try_get() are helpers for tracking users on a registered device. Now rename them: - vfio_device_put() -> vfio_device_put_regi

[PATCH v2 15/15] vfio: Add struct device to vfio_device

2022-09-01 Thread Kevin Tian
From: Yi Liu and replace kref. With it a 'vfio-dev/vfioX' node is created under the sysfs path of the parent, indicating the device is bound to a vfio driver, e.g.: /sys/devices/pci\:6f/\:6f\:01.0/vfio-dev/vfio0 It is also a preparatory step toward adding cdev for supporting future devi

RE: [PATCH v2 12/15] vfio/amba: Use the new device life cycle helpers

2022-09-01 Thread Tian, Kevin
> From: Tian, Kevin > Sent: Thursday, September 1, 2022 10:38 PM > > +static const struct vfio_device_ops vfio_amba_ops= { Above missed a space after vfio_amba_ops.

RE: [PATCH v2 15/15] vfio: Add struct device to vfio_device

2022-09-01 Thread Tian, Kevin
> From: Tian, Kevin > Sent: Thursday, September 1, 2022 10:38 PM > > diff --git a/Documentation/ABI/testing/sysfs-devices-vfio-dev > b/Documentation/ABI/testing/sysfs-devices-vfio-dev > new file mode 100644 > index ..e21424fd9666 > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs

Re: [PATCH v3 01/11] drm/i915: Move display and media IP version to runtime info

2022-09-01 Thread Jani Nikula
On Wed, 31 Aug 2022, Radhakrishna Sripada wrote: > Future platforms can read the IP version from a register and the > IP version numbers need not be hard coded in device info. Move the > ip version for media and display to runtime info. > > On platforms where hard coding of IP version is required

Re: [PATCH v4 20/21] media: videobuf2: Stop using internal dma-buf lock

2022-09-01 Thread Christian König
Am 31.08.22 um 17:37 schrieb Dmitry Osipenko: All drivers that use dma-bufs have been moved to the updated locking specification and now dma-buf reservation is guaranteed to be locked by importers during the mapping operations. There is no need to take the internal dma-buf lock anymore. Remove lo

Re: [PATCH v4 21/21] dma-buf: Remove obsoleted internal lock

2022-09-01 Thread Christian König
Am 31.08.22 um 17:37 schrieb Dmitry Osipenko: The internal dma-buf lock isn't needed anymore because the updated locking specification claims that dma-buf reservation must be locked by importers, and thus, the internal data is already protected by the reservation lock. Remove the obsoleted intern

Re: [PATCH v4 00/21] Move all drivers to a common dma-buf locking convention

2022-09-01 Thread Christian König
Hi Dmitry, I've gone over this multiple times now and while it is still possible that we missed something I think that this should land now. The whole topic is just to complicated that we can 100% sure guarantee that there isn't anything wrong with the locking, but lockdep and driver testing

Re: [PATCH v2 1/4] dma-buf: Add dma_buf_try_get()

2022-09-01 Thread Christian König
Am 01.09.22 um 01:12 schrieb Jason Gunthorpe: Used to increment the refcount of the dma buf's struct file, only if the refcount is not zero. Useful to allow the struct file's lifetime to control the lifetime of the dmabuf while still letting the driver to keep track of created dmabufs. Signed-of

[PATCH -next] drm/amd/display: clean up some inconsistent indentings

2022-09-01 Thread Yang Li
This if statement is the content of the for statement above it. It should be indented. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2026 Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [Intel-gfx] [PATCH v3 02/11] drm/i915: Read graphics/media/display arch version from hw

2022-09-01 Thread Jani Nikula
On Wed, 31 Aug 2022, Radhakrishna Sripada wrote: > From: Matt Roper > > Going forward, the hardware teams no longer consider new platforms to > have a "generation" in the way we've defined it for past platforms. > Instead, each IP block (graphics, media, display) will have their own > architectu

Re: [Intel-gfx] [RFC PATCH v3 10/17] drm/i915/vm_bind: Implement I915_GEM_EXECBUFFER3 ioctl

2022-09-01 Thread Tvrtko Ursulin
On 01/09/2022 06:09, Niranjana Vishwanathapura wrote: On Wed, Aug 31, 2022 at 08:38:48AM +0100, Tvrtko Ursulin wrote: On 27/08/2022 20:43, Andi Shyti wrote: From: Niranjana Vishwanathapura Implement new execbuf3 ioctl (I915_GEM_EXECBUFFER3) which only works in vm_bind mode. The vm_bind mo

Re: [PATCH 1/3] drm/i915: audit bo->resource usage

2022-09-01 Thread Christian König
Am 31.08.22 um 18:32 schrieb Matthew Auld: On 31/08/2022 15:53, Matthew Auld wrote: On 31/08/2022 14:34, Christian König wrote: Am 31.08.22 um 14:50 schrieb Matthew Auld: On 31/08/2022 13:35, Christian König wrote: Am 31.08.22 um 14:06 schrieb Matthew Auld: On 31/08/2022 12:03, Christian Kön

Re: [PATCH v2] dt-bindings: display: bridge: renesas,dw-hdmi: Add resets property

2022-09-01 Thread Krzysztof Kozlowski
On 01/09/2022 00:35, Lad Prabhakar wrote: > The DWC HDMI blocks on R-Car and RZ/G2 SoC's use resets, so to complete > the bindings include resets property. > > This also fixes the below warning when running dtbs_check: > arch/arm64/boot/dts/renesas/r8a774b1-hihope-rzg2n-rev2-ex-idk-1110wr.dtb: >

[PATCH -next] drm/amd/display: Simplify bool conversion

2022-09-01 Thread Yang Li
The result of relational operation is Boolean, and the question mark expression is redundant. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2027 Reported-by: Abaci Robot Signed-off-by: Yang Li --- .../gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c | 2 +- 1 file changed, 1 i

[PATCH -next] drm/amd/display: remove possible condition with no effect (if == else)

2022-09-01 Thread Yang Li
Conditional statements have no effect to next process.So remove it. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2028 Reported-by: Abaci Robot Signed-off-by: Yang Li --- .../drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c | 4 1 file changed, 4 deletions(-) diff --git a

Re: [PATCH] drm/msm/dsi: Set panel orientation when directly connected

2022-09-01 Thread Dmitry Baryshkov
On 06/07/2022 22:14, Stephen Boyd wrote: Set the panel orientation in drm when the panel is directly connected, i.e. we're not using an external bridge. The external bridge case is already handled by the panel bridge code, so we only update the path we take when the panel is directly connected/in

Re: [PATCH v3 01/11] drm/i915: Move display and media IP version to runtime info

2022-09-01 Thread Michal Wajdeczko
On 01.09.2022 09:45, Jani Nikula wrote: > On Wed, 31 Aug 2022, Radhakrishna Sripada > wrote: ... >> struct ip_version graphics; >> +struct ip_version media; >> +struct ip_version display; > > The runtime display info is now in an unnamed struct under struct > intel_runtime_info

[RFC PATCH 0/3] drm/msm/dp: several fixes for the IRQ handling

2022-09-01 Thread Dmitry Baryshkov
Johan Hovold has reported that returning a probe deferral from the msm_dp_modeset_init() can cause issues because the IRQ is not freed properly. This (compile-tested only) series tries to fix the issue by moving devm_request_irq() to the probe callback. Dmitry Baryshkov (3): drm/msm/dp: fold dis

[RFC PATCH 1/3] drm/msm/dp: fold disable_irq into devm_request_irq

2022-09-01 Thread Dmitry Baryshkov
Calling disable_irq() right after devm_request_irq() is a bad practice. it leaves a small window when the driver doesn't expect the IRQ, but the hardware still can trigger it. Use the IRQF_NO_AUTOEN flag to prevent the request_irq from enabling the IRQ line. Signed-off-by: Dmitry Baryshkov --- d

[RFC PATCH 2/3] drm/msm/dp: switch to using platform_get_irq()

2022-09-01 Thread Dmitry Baryshkov
There is little point in using irq_of_parse_and_map(). Switch to plain and usual platform_get_irq() for parsing the DP IRQ line. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_display.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/

[RFC PATCH 3/3] drm/msm/dp: move dp_request_irq() call to dp_display_probe()

2022-09-01 Thread Dmitry Baryshkov
As the MDSS registers the IRQ domain before populating child devices, there is little point in deferring the IRQ request up to the msm_dp_modeset_init(). Following the 'get resources as early as possible' paradigm, move dp_request_irq() call to dp_display_probe(). Signed-off-by: Dmitry Baryshkov

Re: [RFC PATCH 0/3] drm/msm/dp: several fixes for the IRQ handling

2022-09-01 Thread Johan Hovold
On Thu, Sep 01, 2022 at 12:15:24PM +0300, Dmitry Baryshkov wrote: > Johan Hovold has reported that returning a probe deferral from the > msm_dp_modeset_init() can cause issues because the IRQ is not freed > properly. This (compile-tested only) series tries to fix the issue by > moving devm_request_

Re: [RFC PATCH 0/3] drm/msm/dp: several fixes for the IRQ handling

2022-09-01 Thread Dmitry Baryshkov
On 01/09/2022 12:20, Johan Hovold wrote: On Thu, Sep 01, 2022 at 12:15:24PM +0300, Dmitry Baryshkov wrote: Johan Hovold has reported that returning a probe deferral from the msm_dp_modeset_init() can cause issues because the IRQ is not freed properly. This (compile-tested only) series tries to f

Re: [RFC PATCH 0/3] drm/msm/dp: several fixes for the IRQ handling

2022-09-01 Thread Johan Hovold
On Thu, Sep 01, 2022 at 12:21:36PM +0300, Dmitry Baryshkov wrote: > On 01/09/2022 12:20, Johan Hovold wrote: > > On Thu, Sep 01, 2022 at 12:15:24PM +0300, Dmitry Baryshkov wrote: > >> Johan Hovold has reported that returning a probe deferral from the > >> msm_dp_modeset_init() can cause issues beca

[PATCH] drm/ttm: update bulk move object of ghost BO

2022-09-01 Thread ZhenGuo Yin
[Why] Ghost BO is released with non-empty bulk move object. There is a warning trace: WARNING: CPU: 19 PID: 1582 at ttm/ttm_bo.c:366 ttm_bo_release+0x2e1/0x2f0 [amdttm] Call Trace: amddma_resv_reserve_fences+0x10d/0x1f0 [amdkcl] amdttm_bo_put+0x28/0x30 [amdttm] amdttm_bo_move_accel_cleanup+0

Re: [PATCH] drm/ttm: update bulk move object of ghost BO

2022-09-01 Thread JingWen Chen
Acked-by: Jingwen Chen still need confirmation from Christian On 9/1/22 5:29 PM, ZhenGuo Yin wrote: > [Why] > Ghost BO is released with non-empty bulk move object. There is a > warning trace: > WARNING: CPU: 19 PID: 1582 at ttm/ttm_bo.c:366 ttm_bo_release+0x2e1/0x2f0 > [amdttm] > Call Trace: >

Re: [PATCH v3 01/11] drm/i915: Move display and media IP version to runtime info

2022-09-01 Thread Jani Nikula
On Thu, 01 Sep 2022, Michal Wajdeczko wrote: > On 01.09.2022 09:45, Jani Nikula wrote: >> On Wed, 31 Aug 2022, Radhakrishna Sripada >> wrote: > > ... > >>> struct ip_version graphics; >>> + struct ip_version media; >>> + struct ip_version display; >> >> The runtime display info is now i

[PATCH 0/4] Add DP MST DSC support to i915

2022-09-01 Thread Stanislav Lisovskiy
Currently we have only DSC support for DP SST. Stanislav Lisovskiy (4): drm: Add missing DP DSC extended capability definitions. drm/i915: Fix intel_dp_mst_compute_link_config drm/i915: Extract drm_dp_atomic_find_vcpi_slots cycle to separate function drm/i915: Add DSC support to MST pa

[PATCH 1/4] drm: Add missing DP DSC extended capability definitions.

2022-09-01 Thread Stanislav Lisovskiy
Adding DP DSC register definitions, we might need for further DSC implementation, supporting MST and DP branch pass-through mode. v2: - Fixed checkpatch comment warning v3: - Removed function which is not yet used(Jani Nikula) Reviewed-by: Vinod Govindapillai Signed-off-by: Stanislav Lisovskiy

[PATCH 2/4] drm/i915: Fix intel_dp_mst_compute_link_config

2022-09-01 Thread Stanislav Lisovskiy
We currently always exit that bpp loop because drm_dp_atomic_find_vcpi_slots doesn't care if we actually can fit those or not. I think that wasn't the initial intention here, especially when we keep trying with lower bpps, we are supposed to keep trying until we actually find some _working_ configu

[PATCH 4/4] drm/i915: Add DSC support to MST path

2022-09-01 Thread Stanislav Lisovskiy
Whenever we are not able to get enough timeslots for required PBN, let's try to allocate those using DSC, just same way as we do for SST. v2: Removed intel_dp_mst_dsc_compute_config and refactored intel_dp_dsc_compute_config to support timeslots as a parameter(Ville Syrjälä) v3: - Rebased

[PATCH 3/4] drm/i915: Extract drm_dp_atomic_find_vcpi_slots cycle to separate function

2022-09-01 Thread Stanislav Lisovskiy
We would be using almost same code to loop through bpps while calling drm_dp_atomic_find_vcpi_slots - lets remove this duplication by introducing a new function intel_dp_mst_find_vcpi_slots_for_bpp v2: Fix pbn_div calculation - shouldn't matter if its DSC or not. Signed-off-by: Stanislav Lisovski

Re: [PATCH] drm/panfrost: Update io-pgtable API

2022-09-01 Thread Steven Price
On 22/08/2022 23:01, Robin Murphy wrote: > Convert to io-pgtable's bulk {map,unmap}_pages() APIs, to help the old > single-page interfaces eventually go away. Unmapping heap BOs still > wants to be done a page at a time, but everything else can get the full > benefit of the more efficient interface

Re: [PATCH v6 2/6] clk: qcom: Allow custom reset ops

2022-09-01 Thread Philipp Zabel
Hi Akhil, On Wed, Aug 31, 2022 at 10:48:23AM +0530, Akhil P Oommen wrote: > Allow soc specific clk drivers to specify a custom reset operation. We > will use this in an upcoming patch to allow gpucc driver to specify a > differet reset operation for cx_gdsc. > > Signed-off-by: Akhil P Oommen > R

[PATCH v6 00/12] dt-bindings: display/msm: rework MDSS and DPU bindings

2022-09-01 Thread Dmitry Baryshkov
Create separate YAML schema for MDSS devicesd$ (both for MDP5 and DPU devices). Cleanup DPU schema files, so that they do not contain schema for both MDSS and DPU nodes. Apply misc small fixes to the DPU schema afterwards. Add schema for the MDSS and DPU on sm8250 platform. Changes since v5: - Dr

[PATCH v6 02/12] dt-bindings: display/msm: add gcc-bus clock to dpu-smd845

2022-09-01 Thread Dmitry Baryshkov
Add gcc-bus clock required for the SDM845 DPU device tree node. This change was made in the commit 111c52854102 ("arm64: dts: qcom: sdm845: move bus clock to mdp node for sdm845 target"), but was not reflected in the schema. Reviewed-by: Rob Herring Signed-off-by: Dmitry Baryshkov --- .../devic

[PATCH v6 01/12] dt-bindings: display/msm: split qcom,mdss bindings

2022-09-01 Thread Dmitry Baryshkov
Split Mobile Display SubSystem (MDSS) root node bindings to the separate yaml file. Changes to the existing (txt) schema: - Added optional "vbif_nrt_phys" region used by msm8996 - Made "bus" and "vsync" clocks optional (they are not used by some platforms) - Added (optional) "core" clock adde

[PATCH v6 03/12] dt-bindings: display/msm: add interconnects property to qcom, mdss-smd845

2022-09-01 Thread Dmitry Baryshkov
Add interconnects required for the SDM845 MDSS device tree node. This change was made in the commit c8c61c09e38b ("arm64: dts: qcom: sdm845: Add interconnects property for display"), but was not reflected in the schema. Signed-off-by: Dmitry Baryshkov --- .../devicetree/bindings/display/msm/dpu-

[PATCH v6 08/12] dt-bindings: display/msm: split dpu-sdm845 into DPU and MDSS parts

2022-09-01 Thread Dmitry Baryshkov
In order to make the schema more readable, split dpu-sdm845 into the DPU and MDSS parts, each one describing just a single device binding. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dpu-sdm845.yaml | 170 ++ .../bindings/display/msm/mdss-sdm845.yaml |

[PATCH v6 04/12] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml

2022-09-01 Thread Dmitry Baryshkov
Move properties common to all DPU DT nodes to the dpu-common.yaml. Note, this removes description of individual DPU port@ nodes. However such definitions add no additional value. The reg values do not correspond to hardware INTF indices. The driver discovers and binds these ports not paying any ca

[PATCH v6 10/12] dt-bindings: display/msm: split dpu-qcm2290 into DPU and MDSS parts

2022-09-01 Thread Dmitry Baryshkov
In order to make the schema more readable, split dpu-qcm2290 into the DPU and MDSS parts, each one describing just a single device binding. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dpu-qcm2290.yaml | 166 ++ .../bindings/display/msm/mdss-qcm2290.yaml|

[PATCH v6 07/12] dt-bindings: display/msm: split dpu-sc7280 into DPU and MDSS parts

2022-09-01 Thread Dmitry Baryshkov
In order to make the schema more readable, split dpu-sc7280 into the DPU and MDSS parts, each one describing just a single device binding. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dpu-sc7280.yaml | 194 ++ .../bindings/display/msm/mdss-sc7280.yaml |

[PATCH v6 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml

2022-09-01 Thread Dmitry Baryshkov
Move properties common to all MDSS DT nodes to the mdss-common.yaml. This extends qcom,msm8998-mdss schema to allow interconnect nodes, which will be added later, once msm8998 gains interconnect support. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dpu-msm8998.yaml | 42 ++--

[PATCH v6 06/12] dt-bindings: display/msm: split dpu-sc7180 into DPU and MDSS parts

2022-09-01 Thread Dmitry Baryshkov
In order to make the schema more readable, split dpu-sc7180 into the DPU and MDSS parts, each one describing just a single device binding. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dpu-sc7180.yaml | 185 ++ .../bindings/display/msm/mdss-sc7180.yaml |

[PATCH v6 11/12] dt-bindings: display/msm: add missing device nodes to mdss-* schemas

2022-09-01 Thread Dmitry Baryshkov
Add missing device nodes (DSI, PHYs, DP/eDP) to the existing MDSS schemas. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/mdss-msm8998.yaml| 12 + .../bindings/display/msm/mdss-qcm2290.yaml| 6 + .../bindings/display/msm/mdss-sc7180.yaml | 18 +

[PATCH v6 12/12] dt-bindings: display/msm: add support for the display on SM8250

2022-09-01 Thread Dmitry Baryshkov
Add DPU and MDSS schemas to describe MDSS and DPU blocks on the Qualcomm SM8250 platform. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dpu-sm8250.yaml | 96 .../bindings/display/msm/mdss-common.yaml | 4 +- .../bindings/display/msm/mdss-sm8250.yaml

[PATCH v6 09/12] dt-bindings: display/msm: split dpu-msm8998 into DPU and MDSS parts

2022-09-01 Thread Dmitry Baryshkov
In order to make the schema more readable, split dpu-msm8998 into the DPU and MDSS parts, each one describing just a single device binding. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dpu-msm8998.yaml | 161 ++ .../bindings/display/msm/mdss-msm8998.yaml|

Re: [PATCH v6 3/6] clk: qcom: gdsc: Add a reset op to poll gdsc collapse

2022-09-01 Thread Philipp Zabel
On Wed, Aug 31, 2022 at 10:48:24AM +0530, Akhil P Oommen wrote: > Add a reset op compatible function to poll for gdsc collapse. > > Signed-off-by: Akhil P Oommen > Reviewed-by: Dmitry Baryshkov > --- > > (no changes since v2) > > Changes in v2: > - Minor update to function prototype > > driv

Re: [PATCH v6 4/6] clk: qcom: gpucc-sc7280: Add cx collapse reset support

2022-09-01 Thread Philipp Zabel
On Wed, Aug 31, 2022 at 10:48:25AM +0530, Akhil P Oommen wrote: > Allow a consumer driver to poll for cx gdsc collapse through Reset > framework. > > Signed-off-by: Akhil P Oommen > Reviewed-by: Dmitry Baryshkov > --- > > (no changes since v3) > > Changes in v3: > - Convert 'struct qcom_reset_

Re: [PATCH v4 09/21] drm/etnaviv: Prepare to dynamic dma-buf locking specification

2022-09-01 Thread Dmitry Osipenko
On 9/1/22 09:50, Christian König wrote: > Am 31.08.22 um 17:37 schrieb Dmitry Osipenko: >> Prepare Etnaviv driver to the common dynamic dma-buf locking convention >> by starting to use the unlocked versions of dma-buf API functions. >> >> Signed-off-by: Dmitry Osipenko > > Interesting, where is t

Re: [PATCH v4 06/21] drm/i915: Prepare to dynamic dma-buf locking specification

2022-09-01 Thread Dmitry Osipenko
On 9/1/22 09:45, Christian König wrote: > Am 31.08.22 um 17:37 schrieb Dmitry Osipenko: >> Prepare i915 driver to the common dynamic dma-buf locking convention >> by starting to use the unlocked versions of dma-buf API functions >> and handling cases where importer now holds the reservation lock. >

Re: [PATCH v6 4/6] clk: qcom: gpucc-sc7280: Add cx collapse reset support

2022-09-01 Thread Dmitry Baryshkov
On 01/09/2022 13:34, Philipp Zabel wrote: On Wed, Aug 31, 2022 at 10:48:25AM +0530, Akhil P Oommen wrote: Allow a consumer driver to poll for cx gdsc collapse through Reset framework. Signed-off-by: Akhil P Oommen Reviewed-by: Dmitry Baryshkov --- (no changes since v3) Changes in v3: - Conv

Re: [PATCH v4 00/21] Move all drivers to a common dma-buf locking convention

2022-09-01 Thread Dmitry Osipenko
Hello Christian, On 9/1/22 10:49, Christian König wrote: > Hi Dmitry, > > I've gone over this multiple times now and while it is still possible > that we missed something I think that this should land now. Thank you very much for the review! > The whole topic is just to complicated that we can

Re: [PATCH v17 00/10] Add MT8195 DisplayPort driver

2022-09-01 Thread AngeloGioacchino Del Regno
Il 01/09/22 06:41, Bo-Chen Chen ha scritto: This patch is separated from v10 which is including dp driver, phy driver and dpintf driver. This series is only contained the DisplayPort driver. For the entire series: Tested-by: AngeloGioacchino Del Regno Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH] drm/ttm: update bulk move object of ghost BO

2022-09-01 Thread Christian König
Am 01.09.22 um 11:29 schrieb ZhenGuo Yin: [Why] Ghost BO is released with non-empty bulk move object. There is a warning trace: WARNING: CPU: 19 PID: 1582 at ttm/ttm_bo.c:366 ttm_bo_release+0x2e1/0x2f0 [amdttm] Call Trace: amddma_resv_reserve_fences+0x10d/0x1f0 [amdkcl] amdttm_bo_put+0x28/

Re: [PATCH] drm/ttm: update bulk move object of ghost BO

2022-09-01 Thread Christian König
Am 01.09.22 um 13:11 schrieb Christian König: Am 01.09.22 um 11:29 schrieb ZhenGuo Yin: [Why] Ghost BO is released with non-empty bulk move object. There is a warning trace: WARNING: CPU: 19 PID: 1582 at ttm/ttm_bo.c:366 ttm_bo_release+0x2e1/0x2f0 [amdttm] Call Trace:    amddma_resv_reserve_fe

Re: [PATCH v6 1/3] drm/bridge: ti-sn65dsi86: Reject modes with too large blanking

2022-09-01 Thread Robert Foss
On Wed, 31 Aug 2022 at 10:27, Tomi Valkeinen wrote: > > From: Tomi Valkeinen > > The front and back porch registers are 8 bits, and pulse width registers > are 15 bits, so reject any modes with larger periods. > > Signed-off-by: Tomi Valkeinen > --- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 23

Re: [PATCH v2 1/2] drm/cmdline-parser: Merge negative tests

2022-09-01 Thread Maíra Canal
Hi Michał Applied both patches to drm-misc-next. Best Regards, - Maíra Canal On 8/17/22 18:12, Michał Winiarski wrote: > Negative tests can be expressed as a single parameterized test case, > which highlights that we're following the same test logic (passing > invalid cmdline and expecting drm_m

Re: [PATCH v6 0/3] drm/bridge: ti-sn65dsi86: Basic DP support

2022-09-01 Thread Robert Foss
On Wed, 31 Aug 2022 at 10:27, Tomi Valkeinen wrote: > > Hi, > > v5 of the series can be found from: > > https://lore.kernel.org/all/20220824130034.196041-1-tomi.valkei...@ideasonboard.com/ > > Changes to v5: > - Drop the broken "check AUX errors better" patch > - Fix sync pulse widths in "Reject m

Re: [PATCH v2 2/2] drm/plane_helper: Split into parameterized test cases

2022-09-01 Thread Maíra Canal
Hi Michał On 8/31/22 17:45, Michał Winiarski wrote: > The test was constructed as a single function (test case) which checks > multiple conditions, calling the function that is tested multiple times > with different arguments. > This usually means that it can be easily converted into multiple test

[PATCH 0/9] drm: convert to using is_hdmi and has_audio from display info

2022-09-01 Thread Jani Nikula
The low-hanging fruit of the drm todo item "Replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi", with has_audio changes on top. I'm afraid not all of these have been even build tested, let alone actually tested. BR, Jani. Cc: Laurent Pinchart Cc: Sandy Huang Cc: Heiko Stübner

[PATCH 1/9] drm/edid: parse display info has_audio similar to is_hdmi

2022-09-01 Thread Jani Nikula
Since we already iterate everything that's needed for determining audio, reduce the need to call drm_detect_monitor_audio() by storing has_audio to connector info. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 6 ++ include/drm/drm_connector.h | 8 2 files changed, 14

[PATCH 2/9] drm/nouveau: convert to using is_hdmi and has_audio from display info

2022-09-01 Thread Jani Nikula
Prefer the parsed results for is_hdmi and has_audio in display info over calling drm_detect_hdmi_monitor() and drm_detect_monitor_audio(), respectively. Cc: Ben Skeggs Cc: Karol Herbst Cc: Lyude Paul Cc: nouv...@lists.freedesktop.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/nouveau/disp

[PATCH 3/9] drm/radeon: convert to using is_hdmi and has_audio from display info

2022-09-01 Thread Jani Nikula
Prefer the parsed results for is_hdmi and has_audio in display info over calling drm_detect_hdmi_monitor() and drm_detect_monitor_audio(), respectively. Cc: Alex Deucher Cc: Christian König Cc: "Pan, Xinhui" Cc: amd-...@lists.freedesktop.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/rade

[PATCH 4/9] drm/tegra: convert to using is_hdmi from display info

2022-09-01 Thread Jani Nikula
Prefer the parsed results for is_hdmi in display info over calling drm_detect_hdmi_monitor(). Cc: Thierry Reding Cc: linux-te...@vger.kernel.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/tegra/hdmi.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/gpu/dr

[PATCH 5/9] drm/exynos: convert to using is_hdmi from display info

2022-09-01 Thread Jani Nikula
Prefer the parsed results for is_hdmi in display info over calling drm_detect_hdmi_monitor(). Cc: Inki Dae Cc: Seung-Woo Kim Cc: Kyungmin Park Signed-off-by: Jani Nikula --- drivers/gpu/drm/exynos/exynos_hdmi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/g

[PATCH 6/9] drm/i2c/tda998x: convert to using has_audio from display_info

2022-09-01 Thread Jani Nikula
Prefer the parsed results for has_audio in display info over calling drm_detect_monitor_audio(). Cc: Russell King Signed-off-by: Jani Nikula --- drivers/gpu/drm/i2c/tda998x_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu

[PATCH 7/9] drm/sti/sti_hdmi: convert to using is_hdmi from display info

2022-09-01 Thread Jani Nikula
Prefer the parsed results for is_hdmi in display info over calling drm_detect_hdmi_monitor(). Remove the now redundant hdmi_monitor member from struct sti_hdmi. Cc: Alain Volmat Signed-off-by: Jani Nikula --- drivers/gpu/drm/sti/sti_hdmi.c | 11 ++- drivers/gpu/drm/sti/sti_hdmi.h | 2 -

[PATCH 8/9] drm/rockchip: cdn-dp: call drm_connector_update_edid_property() unconditionally

2022-09-01 Thread Jani Nikula
Calling drm_connector_update_edid_property() should be done unconditionally instead of depending on the number of modes added. Also match the call order in inno_hdmi and rk3066_hdmi. Cc: Sandy Huang Cc: Heiko Stübner Signed-off-by: Jani Nikula --- drivers/gpu/drm/rockchip/cdn-dp-core.c | 5 ++-

[PATCH 9/9] drm/rockchip: convert to using has_audio from display_info

2022-09-01 Thread Jani Nikula
Prefer the parsed results for has_audio in display info over calling drm_detect_monitor_audio(). Cc: Sandy Huang Cc: Heiko Stübner Signed-off-by: Jani Nikula --- drivers/gpu/drm/rockchip/cdn-dp-core.c | 4 ++-- drivers/gpu/drm/rockchip/inno_hdmi.c | 3 ++- 2 files changed, 4 insertions(+), 3

[PATCH v2 1/2] drm/tests: Split drm_framebuffer_create_test into parameterized tests

2022-09-01 Thread Maíra Canal
The igt_check_drm_framebuffer_create is based on a loop that executes tests for all createbuffer_tests test cases. This could be better represented by parameterized tests, provided by KUnit. So, convert the igt_check_drm_framebuffer_create into parameterized tests. Signed-off-by: Maíra Canal Rev

[PATCH v2 2/2] drm/tests: Change "igt_" prefix to "test_drm_"

2022-09-01 Thread Maíra Canal
With the introduction of KUnit, IGT is no longer the only option to run the DRM unit tests, as the tests can be run through kunit-tool or on real hardware with CONFIG_KUNIT. Therefore, remove the "igt_" prefix from the tests and replace it with the "test_drm_" prefix, making the tests' names indep

Re: [PATCH 1/3] drm/i915: audit bo->resource usage

2022-09-01 Thread Matthew Auld
On 01/09/2022 09:00, Christian König wrote: Am 31.08.22 um 18:32 schrieb Matthew Auld: On 31/08/2022 15:53, Matthew Auld wrote: On 31/08/2022 14:34, Christian König wrote: Am 31.08.22 um 14:50 schrieb Matthew Auld: On 31/08/2022 13:35, Christian König wrote: Am 31.08.22 um 14:06 schrieb Matt

Re: [PATCH v2 2/2] drm/tests: Change "igt_" prefix to "test_drm_"

2022-09-01 Thread Maxime Ripard
Hi, On Thu, Sep 01, 2022 at 09:42:10AM -0300, Maíra Canal wrote: > With the introduction of KUnit, IGT is no longer the only option to run > the DRM unit tests, as the tests can be run through kunit-tool or on > real hardware with CONFIG_KUNIT. > > Therefore, remove the "igt_" prefix from the tes

Re: [PATCH v2 2/2] drm/tests: Change "igt_" prefix to "test_drm_"

2022-09-01 Thread Javier Martinez Canillas
On 9/1/22 14:55, Maxime Ripard wrote: > Hi, > > On Thu, Sep 01, 2022 at 09:42:10AM -0300, Maíra Canal wrote: >> With the introduction of KUnit, IGT is no longer the only option to run >> the DRM unit tests, as the tests can be run through kunit-tool or on >> real hardware with CONFIG_KUNIT. >> >>

[PATCH] drm/bridge: tc358775: Do not soft reset i2c-slave controller

2022-09-01 Thread Teresa Remmet
Soft reset during tc_bridge_enable() is triggered by setting all available reset control bits in the SYSRST register. But as noted in the data sheet resetting the i2c-slave controller should be only done over DSI and is only useful for chip debugging. So do not set RSTI2CS (bit0). Signed-off-by: T

[PATCH] drm: Simplify testing on UML with kunit.py

2022-09-01 Thread Michał Winiarski
DRM depends on IOMEM and DMA, introduce an additional Kconfig to pull in IOMEM and DMA emulation on UML. Since --kconfig_add usage is no longer needed, remove it from documentation. Signed-off-by: Michał Winiarski --- Documentation/gpu/drm-internals.rst | 7 +-- drivers/video/Kconfig

[PULL] drm-intel-fixes

2022-09-01 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-fixes-2022-09-01: - GVT fixes including fix for a CommetLake regression in mmio table and misc doc and typo fixes (Julia, Jiapeng, Colin, Alex) - Fix CCS handling (Matt) - Fix for guc requests after reset (Daniele) - Display DSI related fixes (Jani) - Dis

Re: [PATCH] drm: Simplify testing on UML with kunit.py

2022-09-01 Thread Maxime Ripard
Hi, On Thu, Sep 01, 2022 at 03:36:21PM +0200, Michał Winiarski wrote: > DRM depends on IOMEM and DMA, introduce an additional Kconfig to pull in > IOMEM and DMA emulation on UML. > Since --kconfig_add usage is no longer needed, remove it from > documentation. > > Signed-off-by: Michał Winiarski

  1   2   >