Re: [PATCH v3 03/14] gpu: drm: simplify drivers using devm_regulator_*get_enable*()

2022-08-30 Thread Matti Vaittinen
On 8/29/22 17:25, Robert Foss wrote: Thanks for the review Robert. Hi Matti, On Fri, 19 Aug 2022 at 21:18, Matti Vaittinen wrote: Simplify drivers using managed "regulator get and enable". meson: Use the devm_regulator_get_enable_optional(). Also drop the seemingly unused struct member 'hd

Re: [PATCH 4/4] amd/display: indicate support for atomic async page-flips on DCN

2022-08-30 Thread Simon Ser
On Friday, August 26th, 2022 at 16:39, Alex Deucher wrote: > On Fri, Aug 26, 2022 at 3:38 AM Simon Ser wrote: > > > > On Thursday, August 25th, 2022 at 20:22, Alex Deucher > > wrote: > > > > > On Wed, Aug 24, 2022 at 11:09 AM Simon Ser cont...@emersion.fr wrote: > > > > > > > amdgpu_dm_commit

Re: [PATCH v3 1/3] PCI: Move PCI_VENDOR_ID_MICROSOFT/PCI_DEVICE_ID_HYPERV_VIDEO definitions to pci_ids.h

2022-08-30 Thread Vitaly Kuznetsov
Bjorn Helgaas writes: > On Sat, Aug 27, 2022 at 03:03:43PM +0200, Vitaly Kuznetsov wrote: >> There are already three places in kernel which define PCI_VENDOR_ID_MICROSOFT >> and two for PCI_DEVICE_ID_HYPERV_VIDEO and there's a need to use these >> from core Vmbus code. Move the defines where they

Re: [PATCH 1/3] drm/i915: audit bo->resource usage

2022-08-30 Thread Christian König
Hi guys, can we get an rb/acked-by for this i915 change? Basically we are just making sure that the driver doesn't crash when bo->resource is NULL and a bo doesn't have any backing store assigned to it. The Intel CI seems to be happy with this change, so I'm pretty sure it is correct. Than

RE: [PATCH v6 2/2] drm: rcar-du: Add RZ/G2L DSI driver

2022-08-30 Thread Biju Das
Hi Laurent, Thanks for the feedback. > Subject: Re: [PATCH v6 2/2] drm: rcar-du: Add RZ/G2L DSI driver > > Hi Biju, > > On Mon, Aug 29, 2022 at 04:26:02PM +, Biju Das wrote: > > Hi Robert, > > > > Thanks for the feedback. > > > > > Subject: Re: [PATCH v6 2/2] drm: rcar-du: Add RZ/G2L DSI dr

[PATCH v2] drm/bridge: megachips: Fix a null pointer dereference bug

2022-08-30 Thread Zheyu Ma
When removing the module we will get the following warning: [ 31.911505] i2c-core: driver [stdp2690-ge-b850v3-fw] unregistered [ 31.912484] general protection fault, probably for non-canonical address 0xdc01: [#1] PREEMPT SMP KASAN PTI [ 31.913338] KASAN: null-ptr-deref in

Re: [PATCH] drm/bridge: megachips: Fix a null pointer dereference bug

2022-08-30 Thread Zheyu Ma
Hi Robert, On Mon, Aug 29, 2022 at 11:03 PM Robert Foss wrote: > > On Sat, 16 Jul 2022 at 10:13, Zheyu Ma wrote: > > > > When removing the module we will get the following warning: > > > > [ 31.911505] i2c-core: driver [stdp2690-ge-b850v3-fw] unregistered > > [ 31.912484] general protection

Re: [PATCH v2 2/3] drm/mediatek: Add gamma lut support for mt8195

2022-08-30 Thread AngeloGioacchino Del Regno
Il 30/08/22 08:39, zheng-yan.chen ha scritto: Since the previous gamma_set_common() function is designed for 9bit-to-10bit conversion, which is not feasible for the 10bit-to-12bit conversion in mt8195. Update the function to fit the need of mt8195. Fixes: 7266e90a51a3 ("drm/mediatek: Add mediat

Re: [PATCH v2 1/3] dt-bindings: mediatek: Add gamma compatible for mt8195

2022-08-30 Thread AngeloGioacchino Del Regno
Il 30/08/22 08:39, zheng-yan.chen ha scritto: mt8195 uses 10bit-to-12bit gamma-LUT, which is not compatible with current 9bit-to-10bit gamma-LUT. This patch thus add constant compatible for mt8195, which means that mt8195 should only use specified mt8195 gamma driver data. Also, delete related

Re: [PATCH v2 3/3] arm64: dts: Modify gamma compatible for mt8195

2022-08-30 Thread AngeloGioacchino Del Regno
Il 30/08/22 08:39, zheng-yan.chen ha scritto: Modify gamma compatible for mt8195. Fixes: 16590e634f1d ("arm64: dts: mt8195: Add display node for vdosys0") Signed-off-by: zheng-yan.chen Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH 0/2] drm: bridge: adv7511: CEC support for ADV7535

2022-08-30 Thread Alvin Šipraga
Hi Robert, On Mon, Aug 29, 2022 at 06:02:17PM +0200, Robert Foss wrote: > Hi Alvin, > > Sorry about being slow to get to this series. Nothing to be sorry about - in fact it was already applied! ;-) ab0af093bf90 drm: bridge: adv7511: use non-legacy mode for CEC RX 0aae7623b495 drm: bridge: adv75

Re: [PATCH 3/4] drm: introduce DRM_CAP_ATOMIC_ASYNC_PAGE_FLIP

2022-08-30 Thread Ville Syrjälä
On Mon, Aug 29, 2022 at 04:01:44PM +, Simon Ser wrote: > On Friday, August 26th, 2022 at 10:19, Ville Syrjälä > wrote: > > > On Wed, Aug 24, 2022 at 03:08:55PM +, Simon Ser wrote: > > > This new kernel capability indicates whether async page-flips are > > > supported via the atomic uAPI.

Re: [PATCH v2] drm/bridge: megachips: Fix a null pointer dereference bug

2022-08-30 Thread Robert Foss
On Tue, 30 Aug 2022 at 09:35, Zheyu Ma wrote: > > When removing the module we will get the following warning: > > [ 31.911505] i2c-core: driver [stdp2690-ge-b850v3-fw] unregistered > [ 31.912484] general protection fault, probably for non-canonical address > 0xdc01: [#1] PREE

Re: [PATCH v2] drm/bridge: it6505: Fix the order of DP_SET_POWER commands

2022-08-30 Thread Robert Foss
On Tue, 30 Aug 2022 at 06:58, Pin-yen Lin wrote: > > Send DP_SET_POWER_D3 command to the downstream before stopping DP, so the > suspend process will not be interrupted by the HPD interrupt. Also modify > the order in .atomic_enable callback to make the callbacks symmetric. > > Fixes: 46ca7da7f1e8

Re: [PATCH v5 2/4] drm/bridge: ti-sn65dsi86: Reject modes with too large blanking

2022-08-30 Thread Tomi Valkeinen
Hi Doug, On 29/08/2022 20:23, Doug Anderson wrote: Hi, On Wed, Aug 24, 2022 at 6:00 AM Tomi Valkeinen wrote: From: Tomi Valkeinen The blanking related registers are 8 bits, so reject any modes with larger blanking periods. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/ti-sn6

Re: drm: document uAPI page-flip flags

2022-08-30 Thread Pekka Paalanen
On Mon, 29 Aug 2022 15:37:52 + Simon Ser wrote: > CC Ville for the ASYNC bits, see below. > > On Friday, August 26th, 2022 at 10:53, Pekka Paalanen > wrote: > > > > +/** > > > + * DRM_MODE_PAGE_FLIP_EVENT > > > + * > > > + * Request that the kernel sends back a vblank event (see > > > + *

RE: [PATCH v6 2/2] drm: rcar-du: Add RZ/G2L DSI driver

2022-08-30 Thread Biju Das
Hi Laurent, Thanks for the feedback. > Subject: Re: [PATCH v6 2/2] drm: rcar-du: Add RZ/G2L DSI driver > > Hi Biju, > > Thank you for the patch. > > On Mon, Aug 29, 2022 at 10:19:01AM +0100, Biju Das wrote: > > This driver supports the MIPI DSI encoder found in the RZ/G2L SoC. It > > currently

Re: [PATCH v2 01/41] drm/tests: Order Kunit tests in Makefile

2022-08-30 Thread Maxime Ripard
Hi Konstantin, On Mon, Aug 29, 2022 at 03:02:42PM -0400, Konstantin Ryabitsev wrote: > On Mon, Aug 29, 2022 at 08:46:42PM +0200, Noralf Trønnes wrote: > > Something has gone wrong with this patchset, there are double line endings. > > I noticed this, too, and I think the reason is because these p

Re: drm: document uAPI page-flip flags

2022-08-30 Thread Michel Dänzer
On 2022-08-30 10:16, Pekka Paalanen wrote: > On Mon, 29 Aug 2022 15:37:52 + > Simon Ser wrote: >> On Friday, August 26th, 2022 at 10:53, Pekka Paalanen >> wrote: >> +/** + * DRM_MODE_PAGE_FLIP_ASYNC + * + * Request that the page-flip is performed as soon as possible, ie.

[PATCH linux-next] drm/amdgpu: Remove the unneeded result variable 'r'

2022-08-30 Thread cgel . zte
From: ye xingchen Return the value sdma_v4_0_start() directly instead of storing it in another redundant variable. Reported-by: Zeal Robot Signed-off-by: ye xingchen --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/

Re: [PATCH v6 2/2] drm: rcar-du: Add RZ/G2L DSI driver

2022-08-30 Thread Laurent Pinchart
Hi Biju, On Tue, Aug 30, 2022 at 08:22:08AM +, Biju Das wrote: > Subject: Re: [PATCH v6 2/2] drm: rcar-du: Add RZ/G2L DSI driver > > On Mon, Aug 29, 2022 at 10:19:01AM +0100, Biju Das wrote: > > > This driver supports the MIPI DSI encoder found in the RZ/G2L SoC. It > > > currently supports DS

Re: [PATCH 3/4] drm: introduce DRM_CAP_ATOMIC_ASYNC_PAGE_FLIP

2022-08-30 Thread Pekka Paalanen
On Tue, 30 Aug 2022 11:08:22 +0300 Ville Syrjälä wrote: > On Mon, Aug 29, 2022 at 04:01:44PM +, Simon Ser wrote: > > On Friday, August 26th, 2022 at 10:19, Ville Syrjälä > > wrote: > > > > > On Wed, Aug 24, 2022 at 03:08:55PM +, Simon Ser wrote: > > > > This new kernel capability i

Re: drm: document uAPI page-flip flags

2022-08-30 Thread Ville Syrjälä
On Tue, Aug 30, 2022 at 11:16:26AM +0300, Pekka Paalanen wrote: > On Mon, 29 Aug 2022 15:37:52 + > Simon Ser wrote: > > > CC Ville for the ASYNC bits, see below. > > > > On Friday, August 26th, 2022 at 10:53, Pekka Paalanen > > wrote: > > > > > > +/** > > > > + * DRM_MODE_PAGE_FLIP_EVENT

Re: [PATCH v2] drm: document uAPI page-flip flags

2022-08-30 Thread Pekka Paalanen
On Mon, 29 Aug 2022 15:40:01 + Simon Ser wrote: > Document flags accepted by the page-flip and atomic IOCTLs. > > v2 (Pekka): > - Mention DRM_EVENT_FLIP_COMPLETE in DRM_MODE_PAGE_FLIP_EVENT docs. > - Expand DRM_MODE_ATOMIC_NONBLOCK and DRM_MODE_ATOMIC_ALLOW_MODESET > description. > > Sign

Re: [PATCH v9 09/10] leds: flash: mt6370: Add MediaTek MT6370 flashlight support

2022-08-30 Thread AngeloGioacchino Del Regno
Il 30/08/22 05:40, ChiaEn Wu ha scritto: From: Alice Chen The MediaTek MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED driv

Re: [PATCH v5 4/4] drm/bridge: ti-sn65dsi86: Implement bridge connector operations

2022-08-30 Thread Tomi Valkeinen
Hi, On 29/08/2022 20:38, Doug Anderson wrote: Hi, On Wed, Aug 24, 2022 at 6:00 AM Tomi Valkeinen wrote: From: Laurent Pinchart Implement the bridge connector-related .get_edid() and .detect() operations, and report the related bridge capabilities and type. These ops are only added for DP

Re: drm: document uAPI page-flip flags

2022-08-30 Thread Pekka Paalanen
On Tue, 30 Aug 2022 11:41:39 +0300 Ville Syrjälä wrote: > On Tue, Aug 30, 2022 at 11:16:26AM +0300, Pekka Paalanen wrote: > > Hence, "has been displayed" is not it because the flip-done event is > > emitted before the new FB contents have been scanned out. That scanout > > cycle is only starting

RE: [PATCH v6 2/2] drm: rcar-du: Add RZ/G2L DSI driver

2022-08-30 Thread Biju Das
Hi Laurent, > Subject: Re: [PATCH v6 2/2] drm: rcar-du: Add RZ/G2L DSI driver > > Hi Biju, > > On Tue, Aug 30, 2022 at 08:22:08AM +, Biju Das wrote: > > Subject: Re: [PATCH v6 2/2] drm: rcar-du: Add RZ/G2L DSI driver > > > On Mon, Aug 29, 2022 at 10:19:01AM +0100, Biju Das wrote: > > > > Thi

Re: [PATCH v2 1/3] dt-bindings: mediatek: Add gamma compatible for mt8195

2022-08-30 Thread Krzysztof Kozlowski
On 30/08/2022 09:39, zheng-yan.chen wrote: > mt8195 uses 10bit-to-12bit gamma-LUT, which is not compatible with > current 9bit-to-10bit gamma-LUT. > > This patch thus add constant compatible for mt8195, which means that > mt8195 should only use specified mt8195 gamma driver data. > > Also, delete

Re: [PATCH v2 3/3] arm64: dts: Modify gamma compatible for mt8195

2022-08-30 Thread Krzysztof Kozlowski
On 30/08/2022 09:39, zheng-yan.chen wrote: > Modify gamma compatible for mt8195. Commit should explain why. "What" we all can easily see. > > Fixes: 16590e634f1d ("arm64: dts: mt8195: Add display node for vdosys0") Your patchset is not bisectable and might cause ABI break. I doubt that it matche

Re: [PATCH v2 3/3] arm64: dts: Modify gamma compatible for mt8195

2022-08-30 Thread Krzysztof Kozlowski
On 30/08/2022 10:49, AngeloGioacchino Del Regno wrote: > Il 30/08/22 08:39, zheng-yan.chen ha scritto: >> Modify gamma compatible for mt8195. >> >> Fixes: 16590e634f1d ("arm64: dts: mt8195: Add display node for vdosys0") >> Signed-off-by: zheng-yan.chen > > Reviewed-by: AngeloGioacchino Del Regno

build failure of next-20220830 due to 5f8cdece42ff ("drm/msm/dsi: switch to DRM_PANEL_BRIDGE")

2022-08-30 Thread Sudip Mukherjee (Codethink)
Hi All, The builds of arm64 allmodconfig with clang have failed to build next-20220830 with the error: drivers/gpu/drm/msm/dsi/dsi_host.c:1903:14: error: variable 'device_node' is uninitialized when used here [-Werror,-Wuninitialized] of_node_put(d

Re: drm: document uAPI page-flip flags

2022-08-30 Thread Ville Syrjälä
On Tue, Aug 30, 2022 at 12:00:50PM +0300, Pekka Paalanen wrote: > On Tue, 30 Aug 2022 11:41:39 +0300 > Ville Syrjälä wrote: > > > On Tue, Aug 30, 2022 at 11:16:26AM +0300, Pekka Paalanen wrote: > > > > Hence, "has been displayed" is not it because the flip-done event is > > > emitted before the

Re: [PATCH] dt-bindings: display: bridge: renesas,dw-hdmi: Fix 'unevaluatedProperties' warnings

2022-08-30 Thread Krzysztof Kozlowski
On 30/08/2022 00:58, Lad Prabhakar wrote: > With 'unevaluatedProperties' support implemented, there's a number of > warnings when running dtbs_check: > > arch/arm64/boot/dts/renesas/r8a774b1-hihope-rzg2n-rev2-ex-idk-1110wr.dtb: > hdmi@fead: Unevaluated properties are not allowed ('resets' was

Re: [PATCH v5 1/4] drm/bridge: ti-sn65dsi86: check AUX errors better

2022-08-30 Thread Tomi Valkeinen
Hi, On 29/08/2022 20:15, Doug Anderson wrote: Hi, On Wed, Aug 24, 2022 at 6:01 AM Tomi Valkeinen wrote: From: Tomi Valkeinen The driver does not check AUX_IRQ_STATUS_NAT_I2C_FAIL bit at all when sending AUX transfers, It doesn't? What about a few lines down from where your patch modifies

Re: [PATCH v5 5/6] dt-bindings: drm/msm/gpu: Add optional resets

2022-08-30 Thread Krzysztof Kozlowski
On 28/08/2022 22:21, Akhil P Oommen wrote: > Add an optional reference to GPUCC reset which can be used to ensure cx > gdsc collapse during gpu recovery. > > Signed-off-by: Akhil P Oommen > Acked-by: Rob Herring > --- > > Changes in v5: > - Nit: Remove a duplicate blank line (Krzysztof) FWIW:

Re: [PATCH v2 14/41] drm/modes: Move named modes parsing to a separate function

2022-08-30 Thread Geert Uytterhoeven
Hi Maxime, On Mon, Aug 29, 2022 at 3:13 PM Maxime Ripard wrote: > The current construction of the named mode parsing doesn't allow to extend > it easily. Let's move it to a separate function so we can add more > parameters and modes. > > Signed-off-by: Maxime Ripard Thanks for your patch! > --

Re: [PATCH v9 05/10] lib: add linear range index macro

2022-08-30 Thread Matti Vaittinen
On 8/30/22 06:40, ChiaEn Wu wrote: From: ChiaEn Wu Add linear_range_idx macro for declaring the linear_range struct simply. Signed-off-by: ChiaEn Wu Reviewed-by: Matti Vaittinen --- v9 - Revise LINEAR_RANGE() and LINEAR_RANGE_IDX() --- include/linux/linear_range.h | 11 +++ 1

Re: [PATCH 3/4] drm: introduce DRM_CAP_ATOMIC_ASYNC_PAGE_FLIP

2022-08-30 Thread Ville Syrjälä
On Tue, Aug 30, 2022 at 11:40:10AM +0300, Pekka Paalanen wrote: > On Tue, 30 Aug 2022 11:08:22 +0300 > Ville Syrjälä wrote: > > > On Mon, Aug 29, 2022 at 04:01:44PM +, Simon Ser wrote: > > > On Friday, August 26th, 2022 at 10:19, Ville Syrjälä > > > wrote: > > > > > > > On Wed, Aug 24, 2

Re: [PATCH v9 07/10] power: supply: mt6370: Add MediaTek MT6370 charger driver

2022-08-30 Thread Matti Vaittinen
On 8/30/22 06:40, ChiaEn Wu wrote: From: ChiaEn Wu MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight driver, display bias voltage supply, one general purpose LDO, and the USB Type-C & PD controller com

Re: [PATCH v2 14/41] drm/modes: Move named modes parsing to a separate function

2022-08-30 Thread Jani Nikula
On Tue, 30 Aug 2022, Geert Uytterhoeven wrote: > On Mon, Aug 29, 2022 at 3:13 PM Maxime Ripard wrote: >> +#define STR_STRICT_EQ(str, len, cmp) \ >> + ((strlen(cmp) == len) && !strncmp(str, cmp, len)) > > This is not part of the move, but newly added. The same construct is also duplicated e

Re: [PATCH 1/3] drm/i915: audit bo->resource usage

2022-08-30 Thread Matthew Auld
Hi, On 30/08/2022 08:33, Christian König wrote: Hi guys, can we get an rb/acked-by for this i915 change? Basically we are just making sure that the driver doesn't crash when bo->resource is NULL and a bo doesn't have any backing store assigned to it. The Intel CI seems to be happy with thi

Re: [PATCH v2 14/41] drm/modes: Move named modes parsing to a separate function

2022-08-30 Thread Maxime Ripard
Hi, On Tue, Aug 30, 2022 at 01:43:07PM +0300, Jani Nikula wrote: > On Tue, 30 Aug 2022, Geert Uytterhoeven wrote: > > On Mon, Aug 29, 2022 at 3:13 PM Maxime Ripard wrote: > >> +#define STR_STRICT_EQ(str, len, cmp) \ > >> + ((strlen(cmp) == len) && !strncmp(str, cmp, len)) > > > > This is n

Re: [PATCH 4/4] drm/i915: Extract drm_dp_atomic_find_vcpi_slots cycle to separate function

2022-08-30 Thread Lisovskiy, Stanislav
On Mon, Aug 29, 2022 at 05:43:19PM +0300, Govindapillai, Vinod wrote: > Hi Stan, > > I wonder if it is better if you reorder the 3 and 4 patches in this - move > this 4/4 before the 3rd > one and modify the 3rd one accordingly. Was thiking about that, but decided to first introduce a new functio

Re: [PATCH 3/4] drm: introduce DRM_CAP_ATOMIC_ASYNC_PAGE_FLIP

2022-08-30 Thread Simon Ser
On Tuesday, August 30th, 2022 at 10:08, Ville Syrjälä wrote: > > In the documentation patch discussion [1], it appears it's not clear what > > drivers should do when async flip isn't possible with the legacy uAPI. > > > > For the atomic uAPI, we need to pick on of these two approaches: > > > > 1

Re: [PATCH v2 19/41] drm/modes: Introduce the tv_mode property as a command-line option

2022-08-30 Thread Maíra Canal
Hi Maxime, On 8/29/22 10:11, Maxime Ripard wrote: > Our new tv mode option allows to specify the TV mode from a property. > However, it can still be useful, for example to avoid any boot time > artifact, to set that property directly from the kernel command line. > > Let's add some code to allow

Re: [PATCH RESEND - dt 1/2] dt-bindings: nvmem: qfprom: add IPQ8064 and SDM630 compatibles

2022-08-30 Thread Srinivas Kandagatla
Hi Krzysztof, I seems to have missed this one, On 25/08/2022 13:54, Krzysztof Kozlowski wrote: Document compatibles for QFPROM used on IPQ8064 and SDM630. They are compatible with generic QFPROM fallback. Signed-off-by: Krzysztof Kozlowski Applied thanks, Srini --- Documentation/devic

Re: build failure of next-20220830 due to 5f8cdece42ff ("drm/msm/dsi: switch to DRM_PANEL_BRIDGE")

2022-08-30 Thread Nathan Chancellor
Hi Sudip, On Tue, Aug 30, 2022 at 10:18:43AM +0100, Sudip Mukherjee (Codethink) wrote: > Hi All, > > The builds of arm64 allmodconfig with clang have failed to build > next-20220830 with the error: > > drivers/gpu/drm/msm/dsi/dsi_host.c:1903:14: error: variable 'device_no

Re: [PATCH 3/4] drm: introduce DRM_CAP_ATOMIC_ASYNC_PAGE_FLIP

2022-08-30 Thread Simon Ser
On Tuesday, August 30th, 2022 at 12:24, Ville Syrjälä wrote: > > > The current behaviour is to fall back to a blit if the async > > > flip fails. So you still get the same effective behaviour, just > > > not as efficient. I think that's a reasonable way to handle it. > > > > That's purely an Xor

Re: [PATCH v2 19/41] drm/modes: Introduce the tv_mode property as a command-line option

2022-08-30 Thread Maíra Canal
On 8/29/22 10:11, Maxime Ripard wrote: > Our new tv mode option allows to specify the TV mode from a property. > However, it can still be useful, for example to avoid any boot time > artifact, to set that property directly from the kernel command line. > > Let's add some code to allow it, and some

Re: drm: document uAPI page-flip flags

2022-08-30 Thread Simon Ser
On Tuesday, August 30th, 2022 at 10:31, Michel Dänzer wrote: > > For the atomic uAPI, we need to pick on of these two approaches: > > > > 1. Let the kernel fall back to a sync flip if async isn't possible. This > >simplifies user-space, but then user-space has no reliable way to figure > >

[PATCH] drm/display: Don't assume dual mode adaptors support i2c sub-addressing

2022-08-30 Thread Simon Rettberg
Current dual mode adaptor ("DP++") detection code assumes that all adaptors support i2c sub-addressing for read operations from the DP-HDMI adaptor ID buffer. It has been observed that multiple adaptors do not in fact support this, and always return data starting at register 0. On affected adapto

Re: [PATCH 3/4] drm: introduce DRM_CAP_ATOMIC_ASYNC_PAGE_FLIP

2022-08-30 Thread Simon Ser
(Oops, I replied to the wrong thread. Re-sending to the correct one.) On Tuesday, August 30th, 2022 at 10:41, Michel Dänzer wrote: > > For the atomic uAPI, we need to pick on of these two approaches: > > > > 1. Let the kernel fall back to a sync flip if async isn't possible. This > >simplif

Re: [PATCH v2 10/41] drm/modes: Add a function to generate analog display modes

2022-08-30 Thread Maíra Canal
Hi Maxime, On 8/29/22 10:11, Maxime Ripard wrote: > Multiple drivers (meson, vc4, sun4i) define analog TV 525-lines and > 625-lines modes in their drivers. > > Since those modes are fairly standard, and that we'll need to use them > in more places in the future, it makes sense to move their defin

[PATCH] tty/vt: Add console_lock check to vt_console_print()

2022-08-30 Thread Daniel Vetter
I'm scratching my head why we have this printing_lock. Digging through historical git trees shows that: - Added in 1.1.73, and I found absolutely no reason why. - Converted to atomic bitops in 2.1.125pre2, I guess as part of SMP enabling/bugfixes. - Converted to a proper spinlock in b0940003f25d

Re: [PATCH v2 14/41] drm/modes: Move named modes parsing to a separate function

2022-08-30 Thread Jani Nikula
On Tue, 30 Aug 2022, Maxime Ripard wrote: > Hi, > > On Tue, Aug 30, 2022 at 01:43:07PM +0300, Jani Nikula wrote: >> On Tue, 30 Aug 2022, Geert Uytterhoeven wrote: >> > On Mon, Aug 29, 2022 at 3:13 PM Maxime Ripard wrote: >> >> +#define STR_STRICT_EQ(str, len, cmp) \ >> >> + ((strlen(cmp) =

[PATCH] tty/vt: Remove printable variable

2022-08-30 Thread Daniel Vetter
Every since the 0.99.7A release when console_register() was introduced it's become impossible to call vt_console_print (called console_print() back then still) directly. Which means the initialization issue this variable protected against is no more. Give it a send off with style and let it rest i

Re: [PATCH 01/15] vfio: Add helpers for unifying vfio_device life cycle

2022-08-30 Thread Anthony Krowiak
Reviewed-by: Tony Krowiak I have a couple of review comments, but nothing critical that would prevent my r-b. On 8/27/22 1:10 PM, Kevin Tian wrote: The idea is to let vfio core manage the vfio_device life cycle instead of duplicating the logic cross drivers. This is also a preparatory step f

Re: [PATCH 09/15] vfio/ap: Use the new device life cycle helpers

2022-08-30 Thread Anthony Krowiak
Reviewed-by: Tony Krowiak On 8/27/22 1:10 PM, Kevin Tian wrote: From: Yi Liu and manage available_instances inside @init/@release. Signed-off-by: Yi Liu Signed-off-by: Kevin Tian --- drivers/s390/crypto/vfio_ap_ops.c | 50 ++- 1 file changed, 29 insertions(+)

Re: [PATCH] dt-bindings: display: bridge: renesas,dw-hdmi: Fix 'unevaluatedProperties' warnings

2022-08-30 Thread Lad, Prabhakar
Hi Laurent, On Tue, Aug 30, 2022 at 12:08 AM Laurent Pinchart wrote: > > Hi Prabhakar, > > Thank you for the patch. > > On Mon, Aug 29, 2022 at 10:58:16PM +0100, Lad Prabhakar wrote: > > With 'unevaluatedProperties' support implemented, there's a number of > > warnings when running dtbs_check: >

Re: [PATCH] dt-bindings: display: bridge: renesas,dw-hdmi: Fix 'unevaluatedProperties' warnings

2022-08-30 Thread Lad, Prabhakar
Hi Krzysztof, Thank you for the review. On Tue, Aug 30, 2022 at 10:23 AM Krzysztof Kozlowski wrote: > > On 30/08/2022 00:58, Lad Prabhakar wrote: > > With 'unevaluatedProperties' support implemented, there's a number of > > warnings when running dtbs_check: > > > > arch/arm64/boot/dts/renesas/r8

Re: [PATCH 4/4] amd/display: indicate support for atomic async page-flips on DCN

2022-08-30 Thread Alex Deucher
On Tue, Aug 30, 2022 at 3:08 AM Simon Ser wrote: > > On Friday, August 26th, 2022 at 16:39, Alex Deucher > wrote: > > > On Fri, Aug 26, 2022 at 3:38 AM Simon Ser wrote: > > > > > > On Thursday, August 25th, 2022 at 20:22, Alex Deucher > > > wrote: > > > > > > > On Wed, Aug 24, 2022 at 11:09 A

Re: [Intel-gfx] [PATCH] drm/i915/guc: clear stalled request after a reset

2022-08-30 Thread Tvrtko Ursulin
On 12/08/2022 16:31, Ceraolo Spurio, Daniele wrote: On 8/12/2022 12:29 AM, Tvrtko Ursulin wrote: On 11/08/2022 22:08, Daniele Ceraolo Spurio wrote: If the GuC CTs are full and we need to stall the request submission while waiting for space, we save the stalled request and where the stall occ

dri-devel@lists.freedesktop.org

2022-08-30 Thread Dan Carpenter
-ci/archive/20220830/202208301957.ulaot2oy-...@intel.com/config) compiler: gcc-11 (Debian 11.3.0-5) 11.3.0 If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot Reported-by: Dan Carpenter New smatch warnings: drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c:497

Re: [PATCH] drm/i915: Fix random -ENOSPC eviction errors due to locked vma objects

2022-08-30 Thread Tvrtko Ursulin
On 17/08/2022 08:34, Thomas Hellström wrote: On Wed, 2022-08-17 at 09:55 +0300, Sviatoslav Peleshko wrote: The i915_gem_object_trylock we had in the grab_vma() makes it return false when the vma->obj is already locked. In this case we'll skip this vma during eviction, and eventually might be f

Re: [PATCH 4/4] amd/display: indicate support for atomic async page-flips on DCN

2022-08-30 Thread Simon Ser
On Tuesday, August 30th, 2022 at 16:06, Alex Deucher wrote: > On Tue, Aug 30, 2022 at 3:08 AM Simon Ser cont...@emersion.fr wrote: > > > On Friday, August 26th, 2022 at 16:39, Alex Deucher alexdeuc...@gmail.com > > wrote: > > > > > On Fri, Aug 26, 2022 at 3:38 AM Simon Ser cont...@emersion.fr

Re: [PATCH v3 06/13] drm: bridge: samsung-dsim: Add DSI init in bridge pre_enable()

2022-08-30 Thread Dave Stevenson
Hi Jagan On Mon, 29 Aug 2022 at 19:31, Jagan Teki wrote: > > Hi Dave, > > On Fri, Jul 22, 2022 at 9:35 PM Dave Stevenson > wrote: > > > > Hi Jagan and Marek. > > > > On Fri, 22 Jul 2022 at 16:35, Marek Szyprowski > > wrote: > > > > > > On 20.07.2022 17:52, Jagan Teki wrote: > > > > Host transf

Re: [PATCH 4/4] amd/display: indicate support for atomic async page-flips on DCN

2022-08-30 Thread Alex Deucher
On Tue, Aug 30, 2022 at 10:24 AM Simon Ser wrote: > > On Tuesday, August 30th, 2022 at 16:06, Alex Deucher > wrote: > > > On Tue, Aug 30, 2022 at 3:08 AM Simon Ser cont...@emersion.fr wrote: > > > > > On Friday, August 26th, 2022 at 16:39, Alex Deucher alexdeuc...@gmail.com > > > wrote: > > > >

[PATCH] tty/vt: Add console_lock check to vt_console_print()

2022-08-30 Thread Daniel Vetter
I'm scratching my head why we have this printing_lock. Digging through historical git trees shows that: - Added in 1.1.73, and I found absolutely no reason why. - Converted to atomic bitops in 2.1.125pre2, I guess as part of SMP enabling/bugfixes. - Converted to a proper spinlock in b0940003f25d

[PATCH] kernel/panic: Drop unblank_screen call

2022-08-30 Thread Daniel Vetter
console_unblank() does this too (called in both places right after), and with a lot more confidence inspiring approach to locking. Reconstructing this story is very strange: In b61312d353da ("oops handling: ensure that any oops is flushed to the mtdoops console") it is claimed that a printk(" ");

Re: [PATCH] tty/vt: Remove printable variable

2022-08-30 Thread Daniel Vetter
On Tue, Aug 30, 2022 at 03:41:17PM +0200, Daniel Vetter wrote: > Every since the 0.99.7A release when console_register() was introduced > it's become impossible to call vt_console_print (called > console_print() back then still) directly. Which means the > initialization issue this variable protect

Re: [PATCH v5 4/4] drm/bridge: ti-sn65dsi86: Implement bridge connector operations

2022-08-30 Thread Doug Anderson
Hi, On Tue, Aug 30, 2022 at 2:00 AM Tomi Valkeinen wrote: > > Hi, > > On 29/08/2022 20:38, Doug Anderson wrote: > > Hi, > > > > On Wed, Aug 24, 2022 at 6:00 AM Tomi Valkeinen > > wrote: > >> > >> From: Laurent Pinchart > >> > >> Implement the bridge connector-related .get_edid() and .detect() >

Re: [PATCH 4/4] amd/display: indicate support for atomic async page-flips on DCN

2022-08-30 Thread Simon Ser
On Tuesday, August 30th, 2022 at 16:42, Alex Deucher wrote: > > Hm, can you elaborate on the difference between "immediate flip" (as in > > UNP_FLIP_CONTROL) and GRPH_SURFACE_UPDATE_H_RETRACE_EN? What are their > > relationship with KMS's concept of "async flips"? > > The display surface regist

Re: [PATCH 3/3] drm: omapdrm: Do no allocate non-scanout GEMs through DMM/TILER

2022-08-30 Thread Yongqin Liu
HI, Andrew Thanks a lot for the information! And great to have you here! Hi, Ivaylo With the code provided by Andrew, could you please help give suggestions on how to modify it in the gralloc lib side? to add the OMAP_BO_SCANOUT flag unconditionally as OMAP_BO_MEM_CONTIG? Thanks, Yongqin Liu

Re: [PATCH 01/15] vfio: Add helpers for unifying vfio_device life cycle

2022-08-30 Thread Jason Gunthorpe
On Tue, Aug 30, 2022 at 09:42:42AM -0400, Anthony Krowiak wrote: > > +/* > > + * Alloc and initialize vfio_device so it can be registered to vfio > > + * core. > > + * > > + * Drivers should use the wrapper vfio_alloc_device() for allocation. > > + * @size is the size of the structure to be alloca

Re: [PATCH v9 00/10] Add MediaTek MT6370 PMIC support

2022-08-30 Thread Andy Shevchenko
On Tue, Aug 30, 2022 at 11:37:20AM +0800, ChiaEn Wu wrote: > From: ChiaEn Wu > > This patch series add MediaTek MT6370 PMIC support and add a index macro > to . The MT6370 is a highly-integrated smart power > management IC, which includes a single cell Li-Ion/Li-Polymer switching > battery charge

Re: [PATCH v2 24/41] drm/vc4: vec: Remove empty mode_fixup

2022-08-30 Thread Noralf Trønnes
Den 29.08.2022 15.11, skrev Maxime Ripard: > The mode_fixup hooks are deprecated, and the behaviour we implement is the > > default one anyway. Let's remove it. > > > > Signed-off-by: Maxime Ripard > Reviewed-by: Noralf Trønnes

Re: [PATCH v2 25/41] drm/vc4: vec: Convert to atomic helpers

2022-08-30 Thread Noralf Trønnes
Den 29.08.2022 15.11, skrev Maxime Ripard: > The VC4 VEC driver still uses legacy enable and disable hook > > implementation. Let's convert to the atomic variants. > > > > Signed-off-by: Maxime Ripard > Reviewed-by: Noralf Trønnes

Re: [PATCH v2 26/41] drm/vc4: vec: Refactor VEC TV mode setting

2022-08-30 Thread Noralf Trønnes
Den 29.08.2022 15.11, skrev Maxime Ripard: > From: Mateusz Kwiatkowski > > > > Change the mode_set function pointer logic to declarative config0, > > config1 and custom_freq fields, to make TV mode setting logic more > > concise and uniform. > > > > Signed-off-by: Mateusz Kwiatkowski >

Re: [PATCH v2 27/41] drm/vc4: vec: Remove redundant atomic_mode_set

2022-08-30 Thread Noralf Trønnes
Den 29.08.2022 15.11, skrev Maxime Ripard: > From: Mateusz Kwiatkowski > > > > Let's remove the superfluous tv_mode field, which was redundant with the > > mode field in struct drm_tv_connector_state. > > > > Signed-off-by: Mateusz Kwiatkowski > > Signed-off-by: Maxime Ripard > > >

Re: [PATCH] MAINTAINERS: Add myself as a reviewer for panel-edp.c

2022-08-30 Thread Doug Anderson
Hi, On Fri, Aug 26, 2022 at 8:07 AM Sam Ravnborg wrote: > > On Mon, Aug 22, 2022 at 10:53:59AM -0700, Douglas Anderson wrote: > > panel-edp changes go through the drm-misc tree (as per the "DRM PANEL > > DRIVERS" entry in MAINTAINERS), but ever since splitting panel-edp out > > of panel-simple I'

Re: [PATCH v3] gpu/drm/bridge/cadence: avoid flush_scheduled_work() usage

2022-08-30 Thread Robert Foss
Applied to drm-misc-next.

Re: [PATCH v5 4/4] drm/bridge: ti-sn65dsi86: Implement bridge connector operations

2022-08-30 Thread Tomi Valkeinen
Hi, On 30/08/2022 17:55, Doug Anderson wrote: Hi, On Tue, Aug 30, 2022 at 2:00 AM Tomi Valkeinen wrote: Hi, On 29/08/2022 20:38, Doug Anderson wrote: Hi, On Wed, Aug 24, 2022 at 6:00 AM Tomi Valkeinen wrote: From: Laurent Pinchart Implement the bridge connector-related .get_edid() an

Re: [PATCH v5 4/4] drm/bridge: ti-sn65dsi86: Implement bridge connector operations

2022-08-30 Thread Doug Anderson
Hi, On Tue, Aug 30, 2022 at 9:11 AM Tomi Valkeinen wrote: > > >>> eDP the _correct_ implementation for detect is to always return true. > >>> Yes, there is a line called HPD for eDP and yes that line is used for > >>> full DisplayPort for detecting a display. For eDP, though, HPD does > >>> not d

Re: [PATCH] drm/msm/dsi: Remove use of device_node in dsi_host_parse_dt()

2022-08-30 Thread Abhinav Kumar
On 8/29/2022 9:54 AM, Nathan Chancellor wrote: Clang warns: drivers/gpu/drm/msm/dsi/dsi_host.c:1903:14: error: variable 'device_node' is uninitialized when used here [-Werror,-Wuninitialized] of_node_put(device_node); ^~~ drivers/gpu/drm/msm/ds

Re: [PATCH] tty/vt: Add console_lock check to vt_console_print()

2022-08-30 Thread Sam Ravnborg
Hi Daniel, On Tue, Aug 30, 2022 at 04:49:45PM +0200, Daniel Vetter wrote: > I'm scratching my head why we have this printing_lock. Digging through > historical git trees shows that: > - Added in 1.1.73, and I found absolutely no reason why. > - Converted to atomic bitops in 2.1.125pre2, I guess as

Re: [PATCH] tty/vt: Remove printable variable

2022-08-30 Thread Sam Ravnborg
Hi Daniel, On Tue, Aug 30, 2022 at 03:41:17PM +0200, Daniel Vetter wrote: > Every since the 0.99.7A release when console_register() was introduced > it's become impossible to call vt_console_print (called > console_print() back then still) directly. Which means the > initialization issue this vari

[PATCH AUTOSEL 5.19 05/33] drm/vc4: hdmi: Depends on CONFIG_PM

2022-08-30 Thread Sasha Levin
From: Maxime Ripard [ Upstream commit 72e2329e7c9bbe15e7a813670497ec9c6f919af3 ] We already depend on runtime PM to get the power domains and clocks for most of the devices supported by the vc4 driver, so let's just select it to make sure it's there. Link: https://lore.kernel.org/r/202206291235

[PATCH AUTOSEL 5.19 07/33] drm/gem: Fix GEM handle release errors

2022-08-30 Thread Sasha Levin
From: Jeffy Chen [ Upstream commit ea2aa97ca37a9044ade001aef71dbc06318e8d44 ] Currently we are assuming a one to one mapping between dmabuf and GEM handle when releasing GEM handles. But that is not always true, since we would create extra handles for the GEM obj in cases like gem_open() and ge

[PATCH AUTOSEL 5.19 06/33] drm/vc4: hdmi: Rework power up

2022-08-30 Thread Sasha Levin
From: Maxime Ripard [ Upstream commit 258e483a4d5e97a6a8caa74381ddc1f395ac1c71 ] The current code tries to handle the case where CONFIG_PM isn't selected by first calling our runtime_resume implementation and then properly report the power state to the runtime_pm core. This allows to have a fun

[PATCH AUTOSEL 5.19 09/33] drm/amdgpu: Move psp_xgmi_terminate call from amdgpu_xgmi_remove_device to psp_hw_fini

2022-08-30 Thread Sasha Levin
From: YiPeng Chai [ Upstream commit 9d705d7741ae70764f3d6d87e67fad3b5c30ffd0 ] V1: The amdgpu_xgmi_remove_device function will send unload command to psp through psp ring to terminate xgmi, but psp ring has been destroyed in psp_hw_fini. V2: 1. Change the commit title. 2. Restore amdgpu_xgmi_re

[PATCH AUTOSEL 5.19 10/33] drm/amdgpu: fix hive reference leak when adding xgmi device

2022-08-30 Thread Sasha Levin
From: YiPeng Chai [ Upstream commit f5994da72ba124a3d0463672fdfbec073e3bb72f ] Only amdgpu_get_xgmi_hive but no amdgpu_put_xgmi_hive which will leak the hive reference. Signed-off-by: YiPeng Chai Reviewed-by: Hawking Zhang Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/

[PATCH AUTOSEL 5.19 12/33] drm/amdgpu: Remove the additional kfd pre reset call for sriov

2022-08-30 Thread Sasha Levin
From: shaoyunl [ Upstream commit 06671734881af2bcf7f453661b5f8616e32bb3fc ] The additional call is caused by merge conflict Reviewed-by: Felix Kuehling Signed-off-by: shaoyunl Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 -- 1 fi

[PATCH AUTOSEL 5.19 11/33] drm/amdgpu: Check num_gfx_rings for gfx v9_0 rb setup.

2022-08-30 Thread Sasha Levin
From: Candice Li [ Upstream commit c351938350ab9b5e978dede2c321da43de7eb70c ] No need to set up rb when no gfx rings. Signed-off-by: Candice Li Reviewed-by: Hawking Zhang Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 3 ++- 1 file change

[PATCH AUTOSEL 5.19 13/33] drm/radeon: add a force flush to delay work when radeon

2022-08-30 Thread Sasha Levin
From: Zhenneng Li [ Upstream commit f461950fdc374a3ada5a63c669d997de4600dffe ] Although radeon card fence and wait for gpu to finish processing current batch rings, there is still a corner case that radeon lockup work queue may not be fully flushed, and meanwhile the radeon_suspend_kms() funct

[PATCH AUTOSEL 5.19 27/33] fbdev: omapfb: Fix tests for platform_get_irq() failure

2022-08-30 Thread Sasha Levin
From: Yu Zhe [ Upstream commit acf4c6205e862304681234a6a4375b478af12552 ] The platform_get_irq() returns negative error codes. It can't actually return zero. Signed-off-by: Yu Zhe Signed-off-by: Helge Deller Signed-off-by: Sasha Levin --- drivers/video/fbdev/omap/omapfb_main.c | 4 ++-- 1

[PATCH AUTOSEL 5.19 28/33] fbdev: fb_pm2fb: Avoid potential divide by zero error

2022-08-30 Thread Sasha Levin
From: Letu Ren [ Upstream commit 19f953e7435644b81332dd632ba1b2d80b1e37af ] In `do_fb_ioctl()` of fbmem.c, if cmd is FBIOPUT_VSCREENINFO, var will be copied from user, then go through `fb_set_var()` and `info->fbops->fb_check_var()` which could may be `pm2fb_check_var()`. Along the path, `var->p

[PATCH AUTOSEL 5.19 30/33] fbdev: chipsfb: Add missing pci_disable_device() in chipsfb_pci_init()

2022-08-30 Thread Sasha Levin
From: Yang Yingliang [ Upstream commit 07c55c9803dea748d17a054000cbf1913ce06399 ] Add missing pci_disable_device() in error path in chipsfb_pci_init(). Signed-off-by: Yang Yingliang Signed-off-by: Helge Deller Signed-off-by: Sasha Levin --- drivers/video/fbdev/chipsfb.c | 1 + 1 file change

[PATCH AUTOSEL 5.19 29/33] fbdev: fbcon: Destroy mutex on freeing struct fb_info

2022-08-30 Thread Sasha Levin
From: Shigeru Yoshida [ Upstream commit 58559dfc1ebba2ae0c7627dc8f8991ae1984c6e3 ] It's needed to destroy bl_curve_mutex on freeing struct fb_info since the mutex is embedded in the structure and initialized when it's allocated. Signed-off-by: Shigeru Yoshida Signed-off-by: Helge Deller Signe

[PATCH AUTOSEL 5.19 32/33] drm/amdgpu: add sdma instance check for gfx11 CGCG

2022-08-30 Thread Sasha Levin
From: Tim Huang [ Upstream commit 00047c3d967d7ef8adf8bac3c3579294a3bc0bb1 ] For some ASICs, like GFX IP v11.0.1, only have one SDMA instance, so not need to configure SDMA1_RLC_CGCG_CTRL for this case. Signed-off-by: Tim Huang Reviewed-by: Yifan Zhang Signed-off-by: Alex Deucher Signed-off-

  1   2   3   >