Re: [RFC] drm/kms: control display brightness through drm_connector properties

2022-08-28 Thread Hans de Goede
Hi, On 8/25/22 23:40, Yusuf Khan wrote: > Perhaps the Kconfig modifications could be postponed to stage 2 > since for people running distros that suddenly decide to disable > /sys/class/backlight/ it may be impractical for them to recompile > their kernels and such. In step 1, the Kconfig option

Re: [PATCH 0/3] KUnit tests for RGB888, XRGB2101010 and grayscale

2022-08-28 Thread José Expósito
On Tue, Aug 16, 2022 at 10:37:49AM -0300, Maíra Canal wrote: > Hi José, > > Tested the whole series on UML, x86, i386 and PPC. All looks fine! > > Tested-by: Maíra Canal > > Best Regards, > - Maíra Canal > > On 8/16/22 07:29, José Expósito wrote: > > Hello everyone, > > > > This series is a f

[PATCH v2 0/3] KUnit tests for RGB888, XRGB2101010 and grayscale

2022-08-28 Thread José Expósito
Hello everyone, This series is a follow up on my work adding KUnit test to the XRGB conversion functions. This time RGB888, XRGB2101010 and gray8 are added. Best wishes, Jose v1 -> v2: Tested-by: Maíra Canal Reviewed-by: David Gow José Expósito (3): drm/format-helper: Add KUnit

[PATCH v2 1/3] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb888()

2022-08-28 Thread José Expósito
Extend the existing test cases to test the conversion from XRGB to RGB888. Tested-by: Maíra Canal Reviewed-by: David Gow Signed-off-by: José Expósito --- .../gpu/drm/tests/drm_format_helper_test.c| 65 +++ 1 file changed, 65 insertions(+) diff --git a/drivers/gpu/drm/t

[PATCH v2 2/3] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_xrgb2101010()

2022-08-28 Thread José Expósito
Extend the existing test cases to test the conversion from XRGB to XRGB2101010. Tested-by: Maíra Canal Reviewed-by: David Gow Signed-off-by: José Expósito --- .../gpu/drm/tests/drm_format_helper_test.c| 63 +++ 1 file changed, 63 insertions(+) diff --git a/drivers/gpu/

[PATCH v2 3/3] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_gray8()

2022-08-28 Thread José Expósito
Extend the existing test cases to test the conversion from XRGB to grayscale. Tested-by: Maíra Canal Reviewed-by: David Gow Signed-off-by: José Expósito --- .../gpu/drm/tests/drm_format_helper_test.c| 62 +++ 1 file changed, 62 insertions(+) diff --git a/drivers/gpu/dr

Re: [PATCH v2 2/3] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_xrgb2101010()

2022-08-28 Thread kernel test robot
Hi "José, Thank you for the patch! Yet something to improve: [auto build test ERROR on 61a9fa154d217c13eea90aa5bc635bc4b1fcb66e] url: https://github.com/intel-lab-lkp/linux/commits/Jos-Exp-sito/KUnit-tests-for-RGB888-XRGB2101010-and-grayscale/20220828-170347

Re: [PATCH v3] gpu/drm/bridge/cadence: avoid flush_scheduled_work() usage

2022-08-28 Thread Tetsuo Handa
No response since 2022-06-10. Can somebody take this patch? On 2022/07/28 10:40, Tetsuo Handa wrote: > Like commit c4f135d643823a86 ("workqueue: Wrap flush_workqueue() using a > macro") says, flush_scheduled_work() is dangerous and will be forbidden. > We are on the way for removing all flush_sche

[PATCH] drm/ssd130x: Replace simple display helpers with the atomic helpers

2022-08-28 Thread Javier Martinez Canillas
The simple display pipeline is a set of helpers that can be used by DRM drivers to avoid dealing with all the needed components and just define a few functions to operate a simple display device with one full-screen scanout buffer feeding a single output. But it is arguable that this provides the

[PATCH v3 0/3] KUnit tests for RGB888, XRGB2101010 and grayscale

2022-08-28 Thread José Expósito
Hello everyone, This series is a follow up on my work adding KUnit test to the XRGB conversion functions. This time RGB888, XRGB2101010 and gray8 are added. Best wishes, Jose v1 -> v2: Tested-by: Maíra Canal Reviewed-by: David Gow v2 -> v3: Export symbol drm_fb_xrgb_to_x

[PATCH v3 1/3] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb888()

2022-08-28 Thread José Expósito
Extend the existing test cases to test the conversion from XRGB to RGB888. Tested-by: Maíra Canal Reviewed-by: David Gow Signed-off-by: José Expósito --- .../gpu/drm/tests/drm_format_helper_test.c| 65 +++ 1 file changed, 65 insertions(+) diff --git a/drivers/gpu/drm/t

[PATCH v3 3/3] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_gray8()

2022-08-28 Thread José Expósito
Extend the existing test cases to test the conversion from XRGB to grayscale. Tested-by: Maíra Canal Reviewed-by: David Gow Signed-off-by: José Expósito --- .../gpu/drm/tests/drm_format_helper_test.c| 62 +++ 1 file changed, 62 insertions(+) diff --git a/drivers/gpu/dr

[PATCH v3 2/3] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_xrgb2101010()

2022-08-28 Thread José Expósito
Extend the existing test cases to test the conversion from XRGB to XRGB2101010. In order to be able to call drm_fb_xrgb_to_xrgb2101010() when compiling CONFIG_DRM_KMS_HELPER as a module export the symbol. Tested-by: Maíra Canal Reviewed-by: David Gow Signed-off-by: José Expósito --- d

Re: [PATCH v1 34/35] drm/modes: Introduce the tv_mode property as a command-line option

2022-08-28 Thread Noralf Trønnes
Den 26.08.2022 08.46, skrev Maxime Ripard: > On Thu, Aug 25, 2022 at 02:41:27PM +0200, Noralf Trønnes wrote: >> Den 24.08.2022 17.45, skrev Maxime Ripard: >>> Hi Noralf, >>> >>> On Sat, Aug 20, 2022 at 10:18:47PM +0200, Noralf Trønnes wrote: Den 29.07.2022 18.35, skrev Maxime Ripard: >

Re: [PATCH v1 32/35] drm/sun4i: tv: Convert to the new TV mode property

2022-08-28 Thread Noralf Trønnes
Den 29.07.2022 18.35, skrev Maxime Ripard: > Now that the core can deal fine with analog TV modes, let's convert the > sun4i TV driver to leverage those new features. > > Signed-off-by: Maxime Ripard > > diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c > b/drivers/gpu/drm/sun4i/sun4i_tv.c > ind

[PATCH] drm/mm: Reduce stack frame usage in __igt_reserve

2022-08-28 Thread Maíra Canal
The struct drm_mm is being allocated on the stack, which is causing the following -Wframe-larger-than warning on ARM: ../drivers/gpu/drm/tests/drm_mm_test.c:344:12: error: stack frame size (1064) exceeds limit (1024) in '__igt_reserve' [-Werror,-Wframe-larger-than] static int __igt_reserve(struct

[PATCH v5 0/6] clk/qcom: Support gdsc collapse polling using 'reset' interface

2022-08-28 Thread Akhil P Oommen
Some clients like adreno gpu driver would like to ensure that its gdsc is collapsed at hardware during a gpu reset sequence. This is because it has a votable gdsc which could be ON due to a vote from another subsystem like tz, hyp etc or due to an internal hardware signal. To allow this, gpucc dr

[PATCH v5 2/6] clk: qcom: Allow custom reset ops

2022-08-28 Thread Akhil P Oommen
Allow soc specific clk drivers to specify a custom reset operation. We will use this in an upcoming patch to allow gpucc driver to specify a differet reset operation for cx_gdsc. Signed-off-by: Akhil P Oommen Reviewed-by: Dmitry Baryshkov --- (no changes since v3) Changes in v3: - Use pointer

[PATCH v5 3/6] clk: qcom: gdsc: Add a reset op to poll gdsc collapse

2022-08-28 Thread Akhil P Oommen
Add a reset op compatible function to poll for gdsc collapse. Signed-off-by: Akhil P Oommen Reviewed-by: Dmitry Baryshkov --- (no changes since v2) Changes in v2: - Minor update to function prototype drivers/clk/qcom/gdsc.c | 23 +++ drivers/clk/qcom/gdsc.h | 7 +++

[PATCH v5 1/6] dt-bindings: clk: qcom: Support gpu cx gdsc reset

2022-08-28 Thread Akhil P Oommen
Add necessary definitions in gpucc bindings to ensure gpu cx gdsc collapse through 'reset' framework for SC7280. Signed-off-by: Akhil P Oommen Acked-by: Krzysztof Kozlowski --- (no changes since v1) include/dt-bindings/clock/qcom,gpucc-sc7280.h | 3 +++ 1 file changed, 3 insertions(+) diff -

[PATCH v5 5/6] dt-bindings: drm/msm/gpu: Add optional resets

2022-08-28 Thread Akhil P Oommen
Add an optional reference to GPUCC reset which can be used to ensure cx gdsc collapse during gpu recovery. Signed-off-by: Akhil P Oommen Acked-by: Rob Herring --- Changes in v5: - Nit: Remove a duplicate blank line (Krzysztof) Changes in v4: - New patch in v4 Documentation/devicetree/binding

[PATCH v5 4/6] clk: qcom: gpucc-sc7280: Add cx collapse reset support

2022-08-28 Thread Akhil P Oommen
Allow a consumer driver to poll for cx gdsc collapse through Reset framework. Signed-off-by: Akhil P Oommen Reviewed-by: Dmitry Baryshkov --- (no changes since v3) Changes in v3: - Convert 'struct qcom_reset_ops cx_gdsc_reset' to 'static const' (Krzysztof) Changes in v2: - Minor update to use

[PATCH v5 6/6] arm64: dts: qcom: sc7280: Add Reset support for gpu

2022-08-28 Thread Akhil P Oommen
Add support for Reset using GPUCC driver for GPU. This helps to ensure that GPU state is reset by making sure that CX head switch is collapsed. Signed-off-by: Akhil P Oommen --- (no changes since v1) arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ar

[PATCH v2] Documentation: fb: udlfb: clean up text and formatting

2022-08-28 Thread Randy Dunlap
Clean up punctuation, spelling, and formatting for command line usage and modprobe config file usage in udlfb.rst. Signed-off-by: Randy Dunlap Cc: Bernie Thompson Cc: linux-fb...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: Helge Deller Cc: Jonathan Corbet Cc: linux-...@vger.kernel.

[PATCH i-g-t v2 0/4] Add support for KUnit tests

2022-08-28 Thread Isabella Basso
This patch series was first developed as part of the LKCamp hackathon that happened last year[1], mainly focusing on refactoring DRM tests to use KUnit. KUnit[2][3] is a unified test framework that provides helper tools, simplifying their development and execution. Using an x86-64 machine it's pos

[PATCH i-g-t v2 2/4] lib/igt_kmod.c: check if module is builtin before attempting to unload it

2022-08-28 Thread Isabella Basso
This change makes `igt_module_unload_r` safer as it checks whether the module can be unloaded before attempting it. Signed-off-by: Isabella Basso --- lib/igt_kmod.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c index bb6cb7bb..97cac7f5 100644 --- a/lib/ig

[PATCH i-g-t v2 1/4] lib/igt_kmod: rename kselftest functions to ktest

2022-08-28 Thread Isabella Basso
This aims at making IGT's structure more general to different kernel testing frameworks such as KUnit, as they use a lot of the same functionality. Signed-off-by: Isabella Basso --- lib/igt_kmod.c | 22 +++--- lib/igt_kmod.h | 12 ++-- 2 files changed, 17 insertions(+), 1

[PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2022-08-28 Thread Isabella Basso
This adds functions for both executing the tests as well as parsing (K)TAP kmsg output, as per the KTAP spec [1]. [1] https://www.kernel.org/doc/html/latest/dev-tools/ktap.html Signed-off-by: Isabella Basso --- lib/igt_kmod.c | 290 + lib/igt_kmod

[PATCH i-g-t v2 4/4] tests: DRM selftests: switch to KUnit

2022-08-28 Thread Isabella Basso
As the DRM selftests are now using KUnit [1], update IGT tests as well. [1] - https://lore.kernel.org/all/20220708203052.236290-1-maira.ca...@usp.br/ Signed-off-by: Isabella Basso --- tests/drm_buddy.c| 7 --- tests/drm_mm.c | 7 --- tests/kms_selftest.c | 12 +--- 3

[PTACH v3] drm/ast: add dmabuf/prime buffer sharing support

2022-08-28 Thread oushixiong
This patch adds ast specific codes for DRM prime feature, this is to allow for offloading of rending in one direction and outputs in other. This patch is designed to solve the problem that the AST is not displayed when the server plug in a discrete graphics graphics card at the same time. We call

Re: [PATCH 1/4] dt-bindings: display: imx: add binding for i.MX8MP HDMI TX

2022-08-28 Thread Rob Herring
On Fri, 26 Aug 2022 21:24:21 +0200, Lucas Stach wrote: > The HDMI TX controller on the i.MX8MP SoC is a Synopsys designware IP > core with a little bit of SoC integration around it. > > Signed-off-by: Lucas Stach > Tested-by: Marek Vasut > --- > .../bindings/display/imx/fsl,imx8mp-hdmi.yaml | 7

Re: [PATCH 3/3] drm: omapdrm: Do no allocate non-scanout GEMs through DMM/TILER

2022-08-28 Thread Yongqin Liu
Hi, Ivaylo Sorry for the late response, and Thanks very much for the detailed explanations! On Thu, 18 Aug 2022 at 18:23, Ivaylo Dimitrov wrote: > > Hi, > > On 17.08.22 г. 7:52 ч., Yongqin Liu wrote: > > Hi, Ivaylo > > > > On Mon, 15 Aug 2022 at 14:23, Ivaylo Dimitrov > > wrote: > >> > >> Hi Li

Re: [PTACH v3] drm/ast: add dmabuf/prime buffer sharing support

2022-08-28 Thread kernel test robot
Hi oushixiong, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm/drm-next drm-intel/for-linux-next drm-tip/drm-tip linus/master v6.0-rc3 next-20220826] [If your patch is applied to the wrong git tree, kindly

Re: [PATCH 4/4] vfio/pci: Allow MMIO regions to be exported through dma-buf

2022-08-28 Thread Yan Zhao
On Wed, Aug 17, 2022 at 01:11:42PM -0300, Jason Gunthorpe wrote: > dma-buf has become a way to safely acquire a handle to non-struct page > memory that can still have lifetime controlled by the exporter. Notably > RDMA can now import dma-buf FDs and build them into MRs which allows for > PCI P2P op

Re: [PTACH v3] drm/ast: add dmabuf/prime buffer sharing support

2022-08-28 Thread Christian König
Am 27.08.22 um 11:10 schrieb oushixiong: This patch adds ast specific codes for DRM prime feature, this is to allow for offloading of rending in one direction and outputs in other. This patch is designed to solve the problem that the AST is not displayed when the server plug in a discrete graphi

Re: [PATCH] drm: rcar-du: Drop leftovers variables from Makefile

2022-08-28 Thread Geert Uytterhoeven
On Sat, Aug 27, 2022 at 2:50 AM Laurent Pinchart wrote: > Commit 841281fe52a7 ("drm: rcar-du: Drop LVDS device tree backward > compatibility") has removed device tree overlay sources used for > backward compatibility with old bindings, but forgot to remove related > variables from the Makefile. Fi