Re: [RFC] drm/kms: control display brightness through drm_connector properties

2022-08-26 Thread Yusuf Khan
Perhaps the Kconfig modifications could be postponed to stage 2 since for people running distros that suddenly decide to disable /sys/class/backlight/ it may be impractical for them to recompile their kernels and such. Also stage 2 should probably take ~2 decades until it comes into being, for refe

[PATCH linux-next] drm/amdgpu: Remove the unneeded result variable

2022-08-26 Thread cgel . zte
From: ye xingchen Return the value sdma_v5_2_start() directly instead of storing it in another redundant variable. Reported-by: Zeal Robot Signed-off-by: ye xingchen --- drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/

[PATCH] drm/i915/guc: Remove log size module parameters

2022-08-26 Thread Joonas Lahtinen
Remove the module parameters for configuring GuC log size. We should instead rely on tuning the defaults to be usable for reporting bugs. Fixes: 8ad0152afb1b ("drm/i915/guc: Make GuC log sizes runtime configurable") Signed-off-by: Joonas Lahtinen Cc: Jani Nikula Cc: Rodrigo Vivi Cc: Tvrtko Urs

[PATCH linux-next] drm/msm/dsi: Remove the unneeded result variable

2022-08-26 Thread cgel . zte
From: ye xingchen Return the value msm_dsi_phy_enable() directly instead of storing it in another redundant variable. Reported-by: Zeal Robot Signed-off-by: ye xingchen --- drivers/gpu/drm/msm/dsi/dsi_manager.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gp

Re: [PATCH] drm/ast: add dmabuf/prime buffer sharing support

2022-08-26 Thread Christian König
Am 26.08.22 um 03:31 schrieb oushixiong: This patch adds ast specific codes for DRM prime feature, this is to allow for offloading of rending in one direction and outputs in other. This patch is designed to solve the problem that the AST is not displayed when the server plug in a discrete graphi

Re: [PATCH 4/4] amd/display: indicate support for atomic async page-flips on DCN

2022-08-26 Thread Simon Ser
On Thursday, August 25th, 2022 at 20:22, Alex Deucher wrote: > On Wed, Aug 24, 2022 at 11:09 AM Simon Ser cont...@emersion.fr wrote: > > > amdgpu_dm_commit_planes already sets the flip_immediate flag for > > async page-flips. This flag is used to set the UNP_FLIP_CONTROL > > register. Thus, no

Re: [PATCH] drm/i915/guc: Remove log size module parameters

2022-08-26 Thread Jani Nikula
On Fri, 26 Aug 2022, Joonas Lahtinen wrote: > Remove the module parameters for configuring GuC log size. > > We should instead rely on tuning the defaults to be usable for > reporting bugs. Reviewed-by: Jani Nikula > > Fixes: 8ad0152afb1b ("drm/i915/guc: Make GuC log sizes runtime configurable"

Re: linux-next: build failure after merge of the drm-intel tree

2022-08-26 Thread Jani Nikula
On Fri, 26 Aug 2022, Stephen Rothwell wrote: > Hi all, > > After merging the drm-intel tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/gpu/drm/i915/gt/uc/intel_guc.c: In function > 'intel_guc_dump_time_info': > drivers/gpu/drm/i915/gt/uc/intel_guc.c:399:9: err

Re: vm binding interfaces and parallel with mmap

2022-08-26 Thread Christian König
After reading up on some internal discussion with Marek and some other people I stumbled over another very important think to keep in mind: We have tons of hardware specific stuff in the VM subsystem! This ranges from specific permission flags (valid, executable, read, write are probably commo

[PATCH][next] drm/i915/guc: Fix spelling mistake "heatbeat" -> "heartbeat"

2022-08-26 Thread Colin Ian King
There is a spelling mistake in a drm_err message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/gt/uc/selftest_guc_hangcheck.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/uc/selftest_guc_hangcheck.c b/drivers/gpu/drm/i915/gt/uc/se

Re: [PATCH 3/4] drm: introduce DRM_CAP_ATOMIC_ASYNC_PAGE_FLIP

2022-08-26 Thread Ville Syrjälä
On Wed, Aug 24, 2022 at 03:08:55PM +, Simon Ser wrote: > This new kernel capability indicates whether async page-flips are > supported via the atomic uAPI. DRM clients can use it to check > for support before feeding DRM_MODE_PAGE_FLIP_ASYNC to the kernel. I think we'd need to clarify the sema

Re: [PATCH] drm/msm/dp: add atomic_check to bridge ops

2022-08-26 Thread Dmitry Baryshkov
On 24/08/2022 22:16, Abhinav Kumar wrote: On 8/24/2022 1:25 AM, Dmitry Baryshkov wrote: On Wed, 24 Aug 2022 at 01:59, Abhinav Kumar wrote: On 8/23/2022 3:41 PM, Dmitry Baryshkov wrote: On Wed, 24 Aug 2022 at 01:07, Abhinav Kumar wrote: On 8/22/2022 11:33 AM, Dmitry Baryshkov wrote: On

Re: [PATCH linux-next] drm/msm/dsi: Remove the unneeded result variable

2022-08-26 Thread Dmitry Baryshkov
On 26/08/2022 10:28, cgel@gmail.com wrote: From: ye xingchen Return the value msm_dsi_phy_enable() directly instead of storing it in another redundant variable. Reported-by: Zeal Robot Signed-off-by: ye xingchen Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v1 05/35] drm/connector: Add TV standard property

2022-08-26 Thread Maxime Ripard
On Sun, Aug 21, 2022 at 01:43:40PM +0200, Noralf Trønnes wrote: > > > Den 18.08.2022 17.31, skrev Maxime Ripard: > > On Thu, Aug 18, 2022 at 05:01:38PM +0200, Noralf Trønnes wrote: > >> > >> > >> Den 18.08.2022 01.23, skrev Noralf Trønnes: > >>> > >>> > >>> Den 17.08.2022 15.11, skrev Noralf Trøn

Re: [PATCH v1 00/35] drm: Analog TV Improvements

2022-08-26 Thread Maxime Ripard
On Fri, Aug 26, 2022 at 06:07:47AM +0200, Mateusz Kwiatkowski wrote: > Hi Maxime, Noralf and everyone, > > Just as a quick update. I isolated the issue to the power management > subsystem. > Unfortunately I know very little about the power management subsystem so > I don't think I can help. > >

Re: [v2] drm/msm: add null checks for drm device to avoid crash during probe defer

2022-08-26 Thread Dmitry Baryshkov
On 15/06/2022 15:23, Dmitry Baryshkov wrote: On 03/06/2022 12:42, Vinod Polimera wrote: During probe defer, drm device is not initialized and an external trigger to shutdown is trying to clean up drm device leading to crash. Add checks to avoid drm device cleanup in such cases. BUG: unable to h

[PATCH] drm/amd/display: Fix variable dereferenced before check

2022-08-26 Thread sunliming
Fixes the following smatch warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dc_dmub_srv.c:311 dc_dmub_srv_p_state_delegate() warn: variable dereferenced before check 'dc' (see line 309) Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: sunliming --- drivers/gpu/drm/am

Re: drm: document uAPI page-flip flags

2022-08-26 Thread Pekka Paalanen
On Wed, 24 Aug 2022 17:45:06 + Simon Ser wrote: > Document flags accepted by the page-flip and atomic IOCTLs. > > Signed-off-by: Simon Ser > Cc: Daniel Vetter > --- > include/uapi/drm/drm_mode.h | 44 - > 1 file changed, 43 insertions(+), 1 deletion(-)

Re: [PATCH 3/3] drm/msm/hdmi: move resource allocation to probe function

2022-08-26 Thread Dmitry Baryshkov
On 24/08/2022 02:58, Abhinav Kumar wrote: On 6/16/2022 12:59 AM, Dmitry Baryshkov wrote: Rather than having all resource allocation happen in the _bind function (resulting in possible EPROBE_DEFER returns and component bind/unbind cycles) allocate and check all resources in _probe function. Wh

Re: [PATCH v2 2/3] drm/msm/dp: Remove pixel_rate from struct dp_ctrl

2022-08-26 Thread Dmitry Baryshkov
On 23/06/2022 03:25, Stephen Boyd wrote: This struct member is stored to in the function that calls the function which uses it. That's possible with a function argument instead of storing to a struct member. Pass the pixel_rate as an argument instead to simplify the code. Note that dp_ctrl_link_m

Re: [PATCH v2 3/3] drm/msm/dp: Get rid of dp_ctrl_on_stream_phy_test_report()

2022-08-26 Thread Dmitry Baryshkov
On 23/06/2022 03:25, Stephen Boyd wrote: This API isn't really more than a couple lines now that we don't store the pixel_rate to the struct member. Inline it into the caller. Cc: Kuogee Hsieh Signed-off-by: Stephen Boyd Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_ctrl.c

Re: [PATCH] drm/msm/dpu: populate wb or intf before reset_intf_cfg

2022-08-26 Thread Dmitry Baryshkov
On 15/07/2022 22:14, Abhinav Kumar wrote: dpu_encoder_helper_phys_cleanup() was not populating neither wb or intf to the intf_cfg before calling the reset_intf_cfg(). This causes the reset of the active bits of wb/intf to be skipped which is incorrect. Fix this by populating the relevant wb or

Re: [RFC PATCH] drm/msm: lookup the ICC paths in both mdp5/dpu and mdss devices

2022-08-26 Thread Dmitry Baryshkov
On 05/08/2022 15:24, Marijn Suijten wrote: On 2022-08-05 14:56:30, Dmitry Baryshkov wrote: The commit 6874f48bb8b0 ("drm/msm: make mdp5/dpu devices master components") changed the MDP5 driver to look for the interconnect paths in the MDSS device rather than in the MDP5 device itself. This was le

Re: [RFC PATCH] drm/msm: lookup the ICC paths in both mdp5/dpu and mdss devices

2022-08-26 Thread Dmitry Baryshkov
On 24/08/2022 00:31, Stephen Boyd wrote: Quoting Dmitry Baryshkov (2022-08-05 04:56:30) diff --git a/drivers/gpu/drm/msm/msm_io_utils.c b/drivers/gpu/drm/msm/msm_io_utils.c index 7b504617833a..d02cd29ce829 100644 --- a/drivers/gpu/drm/msm/msm_io_utils.c +++ b/drivers/gpu/drm/msm/msm_io_utils.c

[PATCH 0/4] Add DP MST DSC support to i915

2022-08-26 Thread Stanislav Lisovskiy
Currently we have only DSC support for DP SST. Stanislav Lisovskiy (4): drm: Add missing DP DSC extended capability definitions. drm/i915: Fix intel_dp_mst_compute_link_config drm/i915: Add DSC support to MST path drm/i915: Extract drm_dp_atomic_find_vcpi_slots cycle to separate functi

[PATCH 1/4] drm: Add missing DP DSC extended capability definitions.

2022-08-26 Thread Stanislav Lisovskiy
Adding DP DSC register definitions, we might need for further DSC implementation, supporting MST and DP branch pass-through mode. v2: - Fixed checkpatch comment warning v3: - Removed function which is not yet used(Jani Nikula) Reviewed-by: Vinod Govindapillai Signed-off-by: Stanislav Lisovskiy

[PATCH 2/4] drm/i915: Fix intel_dp_mst_compute_link_config

2022-08-26 Thread Stanislav Lisovskiy
We currently always exit that bpp loop because drm_dp_atomic_find_vcpi_slots doesn't care if we actually can fit those or not. I think that wasn't the initial intention here, especially when we keep trying with lower bpps, we are supposed to keep trying until we actually find some _working_ configu

[PATCH 3/4] drm/i915: Add DSC support to MST path

2022-08-26 Thread Stanislav Lisovskiy
Whenever we are not able to get enough timeslots for required PBN, let's try to allocate those using DSC, just same way as we do for SST. v2: Removed intel_dp_mst_dsc_compute_config and refactored intel_dp_dsc_compute_config to support timeslots as a parameter(Ville Syrjälä) v3: - Rebased

[PATCH 4/4] drm/i915: Extract drm_dp_atomic_find_vcpi_slots cycle to separate function

2022-08-26 Thread Stanislav Lisovskiy
We are using almost same code to loop through bpps while calling drm_dp_atomic_find_vcpi_slots - lets remove this duplication by introducing a new function intel_dp_mst_find_vcpi_slots_for_bpp Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 85 +++

[PATCH] drm: do not call detect for connectors which are forced on

2022-08-26 Thread Michael Rodin
"detect" should not be called and its return value shall not be used when a connector is forced as hinted in the commit d50ba256b5f1 ("drm/kms: start adding command line interface using fb.") and the commit 6fe14acd496e ("drm: Document drm_connector_funcs"). One negative side effect of doing this i

[PATCH v2] drm/i915/guc: Remove log size module parameters

2022-08-26 Thread Joonas Lahtinen
Remove the module parameters for configuring GuC log size. We should instead rely on tuning the defaults to be usable for reporting bugs. v2: - Use correct 1M unit Fixes: 8ad0152afb1b ("drm/i915/guc: Make GuC log sizes runtime configurable") Signed-off-by: Joonas Lahtinen Cc: Jani Nikula Cc: R

[PATCH v2 0/5] drm/msm/hdmi: move resource allocation to probe function

2022-08-26 Thread Dmitry Baryshkov
As pointed several times in the discussions, start moving resource allocation from component bind to the probe function. This simplifies boot process, as the component will not be registered until all resources (clocks, regulators, IRQ, etc.) are not registered. Changes since v1: - Moved a call t

[PATCH v2 1/5] drm/msm/hdmi: use devres helper for runtime PM management

2022-08-26 Thread Dmitry Baryshkov
Use devm_pm_runtime_enable() to enable runtime PM. This way its effect will be reverted on device unbind/destruction. Fixes: 6ed9ed484d04 ("drm/msm/hdmi: Set up runtime PM for HDMI") Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/hdmi/hdmi.c | 2 +- 1 file ch

[PATCH v2 3/5] drm/msm/hdmi: move resource allocation to probe function

2022-08-26 Thread Dmitry Baryshkov
Rather than having all resource allocation happen in the _bind function (resulting in possible EPROBE_DEFER returns and component bind/unbind cycles) allocate and check all resources in _probe function. While we are at it, use platform_get_irq() to get the IRQ rather than going through the irq_of_p

[PATCH v2 2/5] drm/msm/hdmi: drop constant resource names from platform config

2022-08-26 Thread Dmitry Baryshkov
All MSM HDMI devices use "core_physical" and "qfprom_physical" names for register areas. Drop them from the platform config. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/hdmi/hdmi.c | 9 +++-- drivers/gpu/drm/msm/hdmi/hdmi.h | 3 --- 2 files changed, 3

[PATCH v2 5/5] drm/msm/hdmi: move msm_hdmi_get_phy() to msm_hdmi_dev_probe()

2022-08-26 Thread Dmitry Baryshkov
To continue the idea of failing the probe() rather than failing the bind(), move the call to msm_hdmi_get_phy() function to msm_hdmi_dev_probe(), so that the driver fails the probe if PHY is not yet available rather than succeeding the probe and then failing the bind() with -EPROBE_DEFER. Signed-o

[PATCH v2 4/5] drm/msm/hdmi: don't take extra reference on PHY device

2022-08-26 Thread Dmitry Baryshkov
The of_find_device_by_node() already increments the device's usage count, so there is no need to increment it again using get_device(). Drop this extra get_device(). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

Re: [PATCH] drm/msm: fix repeated words in comments

2022-08-26 Thread Dmitry Baryshkov
On 23/08/2022 14:54, Jilin Yuan wrote: Delete the redundant word 'one'. The whitespace is unnecessary. Signed-off-by: Jilin Yuan Reviewed-by: Dmitry Baryshkov Fixes: 7198e6b03155 ("drm/msm: add a3xx gpu support") --- drivers/gpu/drm/msm/msm_gem.h | 2 +- 1 file changed, 1 inserti

Re: [PATCH] msm/adreno: fix repeated words in comments

2022-08-26 Thread Dmitry Baryshkov
On 24/07/2022 10:36, wangjianli wrote: Delete the redundant word 'in'. Could you please: - adjust the commit subject to follow the rest of commit messages, - drop the extra whitespace at the beginning of the commit message, - add a correct Fixes tag. Thank you Signed-off-by: wangjianli -

Re: [PATCH] msm/adreno: fix repeated words in comments

2022-08-26 Thread Dmitry Baryshkov
On 23/08/2022 14:56, Jilin Yuan wrote: Delete the redundant word 'power'. Delete the redundant word 'in'. Delete the redundant word 'for'. Signed-off-by: Jilin Yuan Could you please: - adjust the commit subject to follow the rest of commit messages, - drop the extra whitespace at the be

Re: [PATCH 5/5] dt-bindings: display: drop minItems equal to maxItems

2022-08-26 Thread Dmitry Baryshkov
On 25/08/2022 14:33, Krzysztof Kozlowski wrote: minItems, if missing, are implicitly equal to maxItems, so drop redundant piece to reduce size of code. Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml | 1 - .../devicetree/bindings/displa

Re: [PATCH v2 1/5] dt-bindings: display/msm: dpu-msm8998: add missing DPU opp-table

2022-08-26 Thread Dmitry Baryshkov
On 17/08/2022 09:20, Krzysztof Kozlowski wrote: The 'display-controller' child (DPU) of Display SubSystem (MDSS) uses opp-table, so reference it which allows restricting DPU schema to fixed list of properties. Fixes: 6e986a8f1cf1 ("dt-bindings: display: msm: Add binding for msm8998 dpu") Signed-

Re: [PATCH v2 2/5] dt-bindings: display/msm: dpu-qcm2290: add missing DPU opp-table

2022-08-26 Thread Dmitry Baryshkov
On 17/08/2022 09:20, Krzysztof Kozlowski wrote: The 'display-controller' child (DPU) of Display SubSystem (MDSS) uses opp-table, so reference it which allows restricting DPU schema to fixed list of properties. Fixes: 164f69d9d45a ("dt-bindings: msm: disp: add yaml schemas for QCM2290 DPU bindin

Re: [PATCH v2 3/5] dt-bindings: display/msm: dpu-sc7180: add missing DPU opp-table

2022-08-26 Thread Dmitry Baryshkov
On 17/08/2022 09:20, Krzysztof Kozlowski wrote: The 'display-controller' child (DPU) of Display SubSystem (MDSS) uses opp-table, so reference it which allows restricting DPU schema to fixed list of properties. Fixes: 3d7a0dd8f39b ("dt-bindings: msm: disp: add yaml schemas for DPU bindings") Sig

Re: [PATCH v2 4/5] dt-bindings: display/msm: dpu-sc7280: add missing DPU opp-table

2022-08-26 Thread Dmitry Baryshkov
On 17/08/2022 09:20, Krzysztof Kozlowski wrote: The 'display-controller' child (DPU) of Display SubSystem (MDSS) uses opp-table, so reference it which allows restricting DPU schema to fixed list of properties. Fixes: 57fd4f34ddac ("dt-bindings: msm: add DT bindings for sc7280") Signed-off-by: Kr

Re: [PATCH v2 5/5] dt-bindings: display/msm: dpu-sdm845: add missing DPU opp-table

2022-08-26 Thread Dmitry Baryshkov
On 17/08/2022 09:20, Krzysztof Kozlowski wrote: The 'display-controller' child (DPU) of Display SubSystem (MDSS) uses opp-table, so reference it which allows restricting DPU schema to fixed list of properties. Fixes: 3d7a0dd8f39b ("dt-bindings: msm: disp: add yaml schemas for DPU bindings") Sig

Re: drm: document uAPI page-flip flags

2022-08-26 Thread Sebastian Wick
On Fri, Aug 26, 2022 at 10:58 AM Pekka Paalanen wrote: > > On Wed, 24 Aug 2022 17:45:06 + > Simon Ser wrote: > > > Document flags accepted by the page-flip and atomic IOCTLs. > > > > Signed-off-by: Simon Ser > > Cc: Daniel Vetter > > --- > > include/uapi/drm/drm_mode.h | 44 +++

Re: [PATCH] msm/adreno: fix repeated words in comments

2022-08-26 Thread Dan Carpenter
On Fri, Aug 26, 2022 at 12:45:09PM +0300, Dmitry Baryshkov wrote: > On 24/07/2022 10:36, wangjianli wrote: > > Delete the redundant word 'in'. > > Could you please: > - adjust the commit subject to follow the rest of commit messages, > - drop the extra whitespace at the beginning of the commit m

Re: [PATCH] msm/adreno: fix repeated words in comments

2022-08-26 Thread Dmitry Baryshkov
On 26/08/2022 12:53, Dan Carpenter wrote: On Fri, Aug 26, 2022 at 12:45:09PM +0300, Dmitry Baryshkov wrote: On 24/07/2022 10:36, wangjianli wrote: Delete the redundant word 'in'. Could you please: - adjust the commit subject to follow the rest of commit messages, - drop the extra whitespac

Re: [PATCH] dt-bindings: display: Add missing (unevaluated|additional)Properties on child nodes

2022-08-26 Thread Dmitry Baryshkov
On 23/08/2022 17:56, Rob Herring wrote: In order to ensure only documented properties are present, node schemas must have unevaluatedProperties or additionalProperties set to false (typically). Signed-off-by: Rob Herring --- Documentation/devicetree/bindings/display/arm,komeda.yaml| 1

Re: [PATCH -next] drm/msm/adreno: Switch to memdup_user_nul() helper

2022-08-26 Thread Dmitry Baryshkov
On 26/08/2022 11:45, Yang Yingliang wrote: Use memdup_user_nul() helper instead of open-coding to simplify the code. Signed-off-by: Yang Yingliang Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions

Re: [PATCH v3] drm/msm/dp: correct 1.62G link rate at dp_catalog_ctrl_config_msa()

2022-08-26 Thread Dmitry Baryshkov
On 24/08/2022 23:15, Kuogee Hsieh wrote: At current implementation there is an extra 0 at 1.62G link rate which cause no correct pixel_div selected for 1.62G link rate to calculate mvid and nvid. This patch delete the extra 0 to have mvid and nvid be calculated correctly. Changes in v2: -- fix F

Re: [RFC] drm/bridge: adv7533: remove dynamic lane switching from adv7533 bridge

2022-08-26 Thread Dmitry Baryshkov
On 22/08/2022 19:31, Dmitry Baryshkov wrote: On 09/08/2022 22:40, Laurent Pinchart wrote: Hi Abhinav, Thank you for the patch. On Mon, Aug 08, 2022 at 05:35:30PM -0700, Abhinav Kumar wrote: adv7533 bridge tries to dynamically switch lanes based on the mode by detaching and attaching the mipi

[PATCH] drm/bridge: it6505: Fix the order of DP_SET_POWER commands

2022-08-26 Thread Pin-yen Lin
Send DP_SET_POWER_D3 command to the downstream before stopping DP, so the suspend process will not be interrupted by the HPD interrupt. Also modify the order in .atomic_enable callback to make the callbacks symmetric. Fixes: 77c18864c5fc ("drm/bridge: it6505: Send DP_SET_POWER_D3 before stopping

Re: [v1] drm/msm/disp/dpu1: add support for hierarchical flush for dspp in sc7280

2022-08-26 Thread Dmitry Baryshkov
On 08/08/2022 13:44, Kalyan Thota wrote: -Original Message- From: Dmitry Baryshkov Sent: Thursday, August 4, 2022 9:29 PM To: Kalyan Thota (QUIC) Cc: dri-devel@lists.freedesktop.org; linux-arm-...@vger.kernel.org; freedr...@lists.freedesktop.org; devicet...@vger.kernel.org; linux- ke

Re: [PATCH] drm/tve200: Fix smatch warning

2022-08-26 Thread Linus Walleij
On Thu, May 5, 2022 at 11:52 PM Linus Walleij wrote: > The "ret" variable is ambiguously returning something that > could be zero in the tve200_modeset_init() function, assign > it an explicit error return code to make this unambiguous. > > Reported-by: Dan Carpenter > Signed-off-by: Linus Walle

Re: [PATCH 2/2] drm: fix drm_mipi_dbi build errors

2022-08-26 Thread Linus Walleij
On Tue, Aug 23, 2022 at 2:42 AM Randy Dunlap wrote: > drm_mipi_dbi needs lots of DRM_KMS_HELPER support, so select > that Kconfig symbol like it is done is most other uses, and > the way that it was before MIPS_DBI was moved from tinydrm > to its core location. > > Fixes these build errors: > > l

Re: [PATCH 1/2] drm/panel: use 'select' for Ili9341 panel driver helpers

2022-08-26 Thread Linus Walleij
On Tue, Aug 23, 2022 at 2:42 AM Randy Dunlap wrote: > Use 'select' instead of 'depends on' for DRM helpers for the > Ilitek ILI9341 panel driver. > This is what is done in the vast majority of other cases and > this makes it possible to fix a build error with drm_mipi_dbi. > > Fixes: 5a04227326b0

Re: [PATCH] drm/panel: nt35510: Fix comment typo

2022-08-26 Thread Linus Walleij
On Thu, Aug 4, 2022 at 1:41 PM Jason Wang wrote: > The double `the' is duplicated in the comment, remove one. > > Signed-off-by: Jason Wang Patch applied to drm-misc-next Yours, Linus Walleij

Re: [PATCH] drm: bridge: icn6211: Add and use hs_rate and lp_rate

2022-08-26 Thread Linus Walleij
On Mon, Aug 1, 2022 at 3:16 PM Marek Vasut wrote: > Fill in hs_rate and lp_rate to struct mipi_dsi_device for this bridge and > adjust DSI input frequency calculations such that they expect the DSI host > to configure HS clock according to hs_rate. > > This is an optimization for the DSI burst mo

Re: [PATCH 1/2] dt-bindings: display: bridge: icn6211: Add support for RGB/BGR swap

2022-08-26 Thread Linus Walleij
On Mon, Aug 8, 2022 at 3:57 AM Marek Vasut wrote: > On 8/4/22 00:41, Rob Herring wrote: > > On Tue, Aug 2, 2022 at 5:33 AM Marek Vasut wrote: > >> > >> On 8/1/22 18:32, Rob Herring wrote: > >>> On Mon, Aug 01, 2022 at 03:19:00PM +0200, Marek Vasut wrote: > The ICN6211 is capable of swapping

Re: [PATCH 1/2] dt-bindings: display: bridge: icn6211: Add support for RGB/BGR swap

2022-08-26 Thread Marek Vasut
On 8/26/22 13:52, Linus Walleij wrote: On Mon, Aug 8, 2022 at 3:57 AM Marek Vasut wrote: On 8/4/22 00:41, Rob Herring wrote: On Tue, Aug 2, 2022 at 5:33 AM Marek Vasut wrote: On 8/1/22 18:32, Rob Herring wrote: On Mon, Aug 01, 2022 at 03:19:00PM +0200, Marek Vasut wrote: The ICN6211 is ca

Re: [PATCH 1/2] dt-bindings: display: bridge: icn6211: Add support for external REFCLK

2022-08-26 Thread Linus Walleij
On Mon, Aug 1, 2022 at 3:18 PM Marek Vasut wrote: > The ICN6211 is capable of deriving its internal PLL clock from either > MIPI DSI HS clock, external REFCLK clock, or even internal oscillator. > Currently supported is only the first option. Document support for > external REFCLK clock input in

Re: [RFC] drm/bridge: adv7533: remove dynamic lane switching from adv7533 bridge

2022-08-26 Thread Laurent Pinchart
Hello, On Fri, Aug 26, 2022 at 01:17:43PM +0300, Dmitry Baryshkov wrote: > On 22/08/2022 19:31, Dmitry Baryshkov wrote: > > On 09/08/2022 22:40, Laurent Pinchart wrote: > >> On Mon, Aug 08, 2022 at 05:35:30PM -0700, Abhinav Kumar wrote: > >>> adv7533 bridge tries to dynamically switch lanes based

Re: [RFC] drm/bridge: adv7533: remove dynamic lane switching from adv7533 bridge

2022-08-26 Thread Laurent Pinchart
Hi Abhinav, On Tue, Aug 09, 2022 at 02:47:32PM -0700, Abhinav Kumar wrote: > On 8/9/2022 12:40 PM, Laurent Pinchart wrote: > > On Mon, Aug 08, 2022 at 05:35:30PM -0700, Abhinav Kumar wrote: > >> adv7533 bridge tries to dynamically switch lanes based on the > >> mode by detaching and attaching the

Re: [PATCH] drm/tve200: Fix smatch warning

2022-08-26 Thread Dan Carpenter
On Fri, Aug 26, 2022 at 01:35:56PM +0200, Linus Walleij wrote: > On Thu, May 5, 2022 at 11:52 PM Linus Walleij > wrote: > > > The "ret" variable is ambiguously returning something that > > could be zero in the tve200_modeset_init() function, assign > > it an explicit error return code to make th

Re: drm: document uAPI page-flip flags

2022-08-26 Thread Simon Ser
On Friday, August 26th, 2022 at 11:49, Sebastian Wick wrote: > > > +/* > > > + * DRM_MODE_ATOMIC_ALLOW_MODESET > > > + * > > > + * Allow the update to result in visible artifacts such as a black > > > screen. > > > > Maybe add: > > > > ...temporary or transient visible artifacts while the upd

Re: [PATCH] drm/tve200: Fix smatch warning

2022-08-26 Thread Linus Walleij
On Fri, Aug 26, 2022 at 2:05 PM Dan Carpenter wrote: > On Fri, Aug 26, 2022 at 01:35:56PM +0200, Linus Walleij wrote: > > On Thu, May 5, 2022 at 11:52 PM Linus Walleij > > wrote: > > > > > The "ret" variable is ambiguously returning something that > > > could be zero in the tve200_modeset_init()

[PULL] drm-intel-fixes

2022-08-26 Thread Rodrigo Vivi
Hi Dave and Daniel, Sorry for the delay here. I hope we still have time for these. But no big deal if this needs to wait until next week. Here goes drm-intel-fixes-2022-08-26: - GVT fixes including fix for a CommetLake regression in mmio table and misc doc and typo fixes - Fix CCS handling (Mat

Re: drm: document uAPI page-flip flags

2022-08-26 Thread Sebastian Wick
On Fri, Aug 26, 2022 at 2:17 PM Simon Ser wrote: > > On Friday, August 26th, 2022 at 11:49, Sebastian Wick > wrote: > > > > > +/* > > > > + * DRM_MODE_ATOMIC_ALLOW_MODESET > > > > + * > > > > + * Allow the update to result in visible artifacts such as a black > > > > screen. > > > > > > Maybe a

Re: drm: document uAPI page-flip flags

2022-08-26 Thread Simon Ser
On Friday, August 26th, 2022 at 15:10, Sebastian Wick wrote: > On Fri, Aug 26, 2022 at 2:17 PM Simon Ser cont...@emersion.fr wrote: > > > On Friday, August 26th, 2022 at 11:49, Sebastian Wick > > sebastian.w...@redhat.com wrote: > > > > > > > +/* > > > > > + * DRM_MODE_ATOMIC_ALLOW_MODESET >

Re: [PATCH v3,1/2] soc: mediatek: Add mmsys func to adapt to dpi output for MT8186

2022-08-26 Thread Nícolas F . R . A . Prado
On Fri, Aug 26, 2022 at 02:12:00PM +0800, xinlei.lee wrote: > On Thu, 2022-08-25 at 17:04 +0200, Matthias Brugger wrote: > > > > On 23/08/2022 22:17, Nícolas F. R. A. Prado wrote: > > > On Tue, Aug 23, 2022 at 02:38:22PM +0800, xinlei@mediatek.com > > > wrote: > > > > From: Xinlei Lee > > > >

Re: [Intel-gfx] [PATCH v9 1/8] overflow: Move and add few utility macros into overflow

2022-08-26 Thread Andrzej Hajda
On 25.08.2022 18:47, Kees Cook wrote: On Wed, Aug 24, 2022 at 05:45:07PM +0900, Gwan-gyeong Mun wrote: It moves overflows_type utility macro into overflow header from i915_utils header. The overflows_type can be used to catch the truncaion (overflow) between different data types. And it adds che

Re: [RFC] drm/bridge: adv7533: remove dynamic lane switching from adv7533 bridge

2022-08-26 Thread Dmitry Baryshkov
On 26/08/2022 14:55, Laurent Pinchart wrote: Hello, On Fri, Aug 26, 2022 at 01:17:43PM +0300, Dmitry Baryshkov wrote: On 22/08/2022 19:31, Dmitry Baryshkov wrote: On 09/08/2022 22:40, Laurent Pinchart wrote: On Mon, Aug 08, 2022 at 05:35:30PM -0700, Abhinav Kumar wrote: adv7533 bridge tries

[PATCH] drm: Fix repeated word in comments

2022-08-26 Thread Jules Maselbas
Remove redundant words `the` and `this`. CC: David Airlie CC: Maxime Ripard CC: Thomas Zimmermann CC: amd-...@lists.freedesktop.org CC: dri-devel@lists.freedesktop.org Signed-off-by: Jules Maselbas --- .../gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu11_driver_if_arcturus.h | 2 +- .../gpu/drm/amd/pm/

Re: [v1 2/2] drm/msm/disp/dpu1: enable crtc color management based on encoder topology

2022-08-26 Thread Dmitry Baryshkov
On 27/06/2022 14:56, Kalyan Thota wrote: Thanks for the comments, Dmitry. I haven't noticed mode->hdisplay being used. My idea was to run thru the topology and tie up the encoders with dspp to the CRTCs. Since mode is available only in the commit, we cannot use the dpu_encoder_get_topology dur

Re: [PATCH v3,2/2] drm: mediatek: Adjust the dpi output format to MT8186

2022-08-26 Thread Nícolas F . R . A . Prado
On Fri, Aug 26, 2022 at 11:58:29AM +0800, xinlei.lee wrote: > On Wed, 2022-08-24 at 11:44 -0400, Nícolas F. R. A. Prado wrote: > > On Wed, Aug 24, 2022 at 09:59:21AM +0800, xinlei.lee wrote: > > > On Tue, 2022-08-23 at 16:16 -0400, Nícolas F. R. A. Prado wrote: > > > > On Tue, Aug 23, 2022 at 02:18

[PATCH v7 0/3] drm/i915/display: stop HPD workers before display driver unregister

2022-08-26 Thread Andrzej Hajda
Hi Imre, Jani, Ville, Arun, This patchset is replacement of patch "drm/i915/display: disable HPD workers before display driver unregister" [1]. Ive decided to split patch into two parts - fbdev and MST, there are different issues. Ive also dropped shutdown path, as it has slightly different requir

[PATCH v7 3/3] drm/i915/fbdev: do not create fbdev if HPD is suspended

2022-08-26 Thread Andrzej Hajda
In case of deferred FB setup core can try to create new framebuffer. Disallow it if hpd_suspended flag is set. Signed-off-by: Andrzej Hajda Reviewed-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_fbdev.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/displa

[PATCH v7 1/3] drm/i915/hpd: suspend MST at the end of intel_modeset_driver_remove

2022-08-26 Thread Andrzej Hajda
i915->hotplug.dig_port_work can be queued from intel_hpd_irq_handler called by IRQ handler or by intel_hpd_trigger_irq called from dp_mst. Since dp_mst is suspended after irq handler uninstall, a cleaner approach is to cancel hpd work after intel_dp_mst_suspend, otherwise we risk use-after-free. I

[PATCH v7 2/3] drm/i915/fbdev: suspend HPD before fbdev unregistration

2022-08-26 Thread Andrzej Hajda
HPD event after fbdev unregistration can cause registration of deferred fbdev which will not be unregistered later, causing use-after-free. To avoid it HPD handling should be suspended before fbdev unregistration. It should fix following GPF: [272.634530] general protection fault, probably for non

Re: [PATCH v1 1/4] drm/msm/mdp5: stop overriding drvdata

2022-08-26 Thread Dmitry Baryshkov
On 24/08/2022 20:20, Abhinav Kumar wrote: On 8/24/2022 1:29 AM, Dmitry Baryshkov wrote: On Wed, 24 Aug 2022 at 04:25, Abhinav Kumar wrote: On 6/20/2022 2:30 PM, Dmitry Baryshkov wrote: The rest of the code expects that master's device drvdata is the struct msm_drm_private instance. Do no

Re: [PATCH v3 3/3] arm64: dts: qcom: msm8996: add #clock-cells and XO clock to the HDMI PHY node

2022-08-26 Thread Dmitry Baryshkov
On 04/07/2022 19:11, Dmitry Baryshkov wrote: Add #clock-cells property to the HDMI PHY device node to let other nodes resolve the hdmipll clock. While we are at it, also add the XO clock to the device node. Acked-by: Krzysztof Kozlowski Signed-off-by: Dmitry Baryshkov Bjorn, I'm picking the

Re: mainline build failure for x86_64 allmodconfig with clang

2022-08-26 Thread Alex Deucher
On Thu, Aug 25, 2022 at 6:34 PM Nathan Chancellor wrote: > > Hi AMD folks, > > Top posting because it might not have been obvious but I was looking for > your feedback on this message (which can be viewed on lore.kernel.org if > you do not have the original [1]) so that we can try to get this fixe

[Bug 215443] [radeon] BUG: Unable to handle kernel data access on read at 0xc007ffffffff9130, Oops: Kernel access of bad area, sig: 11 [#1]

2022-08-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215443 Erhard F. (erhar...@mailbox.org) changed: What|Removed |Added Status|NEW |RESOLVED Resol

Re: [PATCH 4/4] amd/display: indicate support for atomic async page-flips on DCN

2022-08-26 Thread Alex Deucher
On Fri, Aug 26, 2022 at 3:38 AM Simon Ser wrote: > > On Thursday, August 25th, 2022 at 20:22, Alex Deucher > wrote: > > > On Wed, Aug 24, 2022 at 11:09 AM Simon Ser cont...@emersion.fr wrote: > > > > > amdgpu_dm_commit_planes already sets the flip_immediate flag for > > > async page-flips. This

Re: [Intel-gfx] [PATCH] drm/i915/dg2: Incorporate Wa_16014892111 into DRAW_WATERMARK tuning

2022-08-26 Thread Balasubramani Vivekanandan
On 23.08.2022 13:24, Matt Roper wrote: > Although register tuning settings are generally implemented via the > workaround infrastructure, it turns out that the DRAW_WATERMARK register > is not properly saved/restored by hardware around power events (i.e., > RC6 entry) so updates to the value cannot

Re: [PATCH v1 00/35] drm: Analog TV Improvements

2022-08-26 Thread Dom Cobley
On Fri, 26 Aug 2022 at 05:08, Mateusz Kwiatkowski wrote: > - Commenting out the pm_runtime_put() / pm_runtime_get_sync() calls in > vc4_vec.c > - Reverting this PR by Dom Cobley a.k.a. popcornmix: >https://github.com/raspberrypi/linux/pull/4639 > > Either of these approaches makes VEC mode sw

[PATCH v2] drm/fourcc: Add missing big-endian XRGB1555 and RGB565 formats

2022-08-26 Thread Geert Uytterhoeven
As of commit eae06120f1974e1a ("drm: refuse ADDFB2 ioctl for broken bigendian drivers"), drivers must set the quirk_addfb_prefer_host_byte_order quirk to make the drm_mode_addfb() compat code work correctly on big-endian machines. While that works fine for big-endian XRGB and ARGB, which a

Re: [PATCH] MAINTAINERS: Add myself as a reviewer for panel-edp.c

2022-08-26 Thread Sam Ravnborg
On Mon, Aug 22, 2022 at 10:53:59AM -0700, Douglas Anderson wrote: > panel-edp changes go through the drm-misc tree (as per the "DRM PANEL > DRIVERS" entry in MAINTAINERS), but ever since splitting panel-edp out > of panel-simple I've been trying to keep a close eye on it. Make that > official by li

Re: drm: document uAPI page-flip flags

2022-08-26 Thread Pekka Paalanen
On Fri, 26 Aug 2022 13:17:09 + Simon Ser wrote: > On Friday, August 26th, 2022 at 15:10, Sebastian Wick > wrote: > > > On Fri, Aug 26, 2022 at 2:17 PM Simon Ser cont...@emersion.fr wrote: > > > > > On Friday, August 26th, 2022 at 11:49, Sebastian Wick > > > sebastian.w...@redhat.com wr

Re: [Intel-gfx] [PATCH v2] drm/i915/guc: Remove log size module parameters

2022-08-26 Thread Rodrigo Vivi
On Fri, Aug 26, 2022 at 12:23:43PM +0300, Joonas Lahtinen wrote: > Remove the module parameters for configuring GuC log size. > > We should instead rely on tuning the defaults to be usable for > reporting bugs. > > v2: > - Use correct 1M unit > > Fixes: 8ad0152afb1b ("drm/i915/guc: Make GuC log

Re: [PATCH v2 1/3] drm/i915/uc: Support for version reduced and multiple firmware files

2022-08-26 Thread Ceraolo Spurio, Daniele
On 8/25/2022 8:05 PM, john.c.harri...@intel.com wrote: From: John Harrison There was a misunderstanding in how firmware file compatibility should be managed within i915. This has been clarified as: i915 must support all existing firmware releases forever new minor firmware releases sho

Re: [PATCH v2 1/3] drm/i915/uc: Support for version reduced and multiple firmware files

2022-08-26 Thread John Harrison
On 8/26/2022 09:35, Ceraolo Spurio, Daniele wrote: On 8/25/2022 8:05 PM, john.c.harri...@intel.com wrote: From: John Harrison There was a misunderstanding in how firmware file compatibility should be managed within i915. This has been clarified as:    i915 must support all existing firmware re

Re: [PATCH] drm/msm/dp: add atomic_check to bridge ops

2022-08-26 Thread Abhinav Kumar
On 8/26/2022 1:19 AM, Dmitry Baryshkov wrote: On 24/08/2022 22:16, Abhinav Kumar wrote: On 8/24/2022 1:25 AM, Dmitry Baryshkov wrote: On Wed, 24 Aug 2022 at 01:59, Abhinav Kumar wrote: On 8/23/2022 3:41 PM, Dmitry Baryshkov wrote: On Wed, 24 Aug 2022 at 01:07, Abhinav Kumar wrote:

Re: [RFC] drm/bridge: adv7533: remove dynamic lane switching from adv7533 bridge

2022-08-26 Thread Laurent Pinchart
Hi Dmitry, On Fri, Aug 26, 2022 at 04:52:12PM +0300, Dmitry Baryshkov wrote: > On 26/08/2022 14:55, Laurent Pinchart wrote: > > On Fri, Aug 26, 2022 at 01:17:43PM +0300, Dmitry Baryshkov wrote: > >> On 22/08/2022 19:31, Dmitry Baryshkov wrote: > >>> On 09/08/2022 22:40, Laurent Pinchart wrote: > >

Re: Fwd: [PATCH 4/4] vfio/pci: Allow MMIO regions to be exported through dma-buf

2022-08-26 Thread Jason Gunthorpe
On Sun, Aug 21, 2022 at 04:51:34PM +0300, Oded Gabbay wrote: > > +static void vfio_pci_dma_buf_unmap(struct dma_buf_attachment *attachment, > > + struct sg_table *sgt, > > + enum dma_data_direction dir) > > +{ > > + struct vfi

[GIT PULL] fbdev updates & fixes for v6.0-rc3

2022-08-26 Thread Helge Deller
Hi Linus, please pull the second round of fbdev fixes & updates for v6.0-rc3. Mostly just small patches, with the exception of the bigger indenting cleanups in the sisfb and radeonfb drivers. Two patches should be mentioned though: A fix-up for fbdev if the screen resize fails (by Shigeru Yoshid

[PATCH v2] drm: bridge: dw_hdmi: only trigger hotplug event on link change

2022-08-26 Thread Lucas Stach
There are two events that signal a real change of the link state: HPD going high means the sink is newly connected or wants the source to re-read the EDID, RX sense going low is a indication that the link has been disconnected. Ignore the other two events that also trigger interrupts, but don't ne

[PATCH 1/2] drm/etnaviv: add HWDB entry for GC7000 r6203

2022-08-26 Thread Lucas Stach
From: Marco Felsch The GPU is found on the NXP i.MX8MN SoC. The feature bits are taken from the NXP downstream kernel driver 6.4.3.p2. Signed-off-by: Marco Felsch Signed-off-by: Lucas Stach --- drivers/gpu/drm/etnaviv/etnaviv_hwdb.c | 31 ++ 1 file changed, 31 insertio

  1   2   >