Re: [PATCH] drm/i915:Move the code position to reduce the number of judgments

2022-08-25 Thread Jani Nikula
On Thu, 25 Aug 2022, Lv qian wrote: > If the kmalloc allocation is successful, the if is judged twice, > so I move the second judgment in to the first judgment. The code is fine as it is. BR, Jani. > > Signed-off-by: Lv qian > --- > drivers/gpu/drm/i915/i915_gpu_error.c | 8 -

[PATCH] drm/msm/dp: correct 1.62G link rate at dp_catalog_ctrl_config_msa()

2022-08-25 Thread Kuogee Hsieh
At current implementation there is an extra 0 at 1.62G link rate which cause no correct pixel_div selected for 1.62G link rate to calculate mvid and nvid. This patch delete the extra 0 to have mvid and nvid be calculated correctly. Fixes: 937f941ca06f "drm/msm/dp: Use qmp phy for DP PLL and PHY"

[PATCH v2] drm/msm/dp: correct 1.62G link rate at dp_catalog_ctrl_config_msa()

2022-08-25 Thread Kuogee Hsieh
At current implementation there is an extra 0 at 1.62G link rate which cause no correct pixel_div selected for 1.62G link rate to calculate mvid and nvid. This patch delete the extra 0 to have mvid and nvid be calculated correctly. Changes in v2: -- fix Fixes tag's text Fixes: 937f941ca06f ("drm

[PATCH] udmabuf: Set ubuf->sg = NULL if the creation of sg table fails

2022-08-25 Thread Vivek Kasireddy
When userspace tries to map the dmabuf and if for some reason (e.g. OOM) the creation of the sg table fails, ubuf->sg needs to be set to NULL. Otherwise, when the userspace subsequently closes the dmabuf fd, we'd try to erroneously free the invalid sg table from release_udmabuf resulting in the fol

Re: [PATCH] drm/sced: Add FIFO policy for scheduler rq

2022-08-25 Thread Luben Tuikov
Inlined: On 2022-08-24 12:21, Andrey Grodzovsky wrote: > > On 2022-08-23 17:37, Luben Tuikov wrote: >> >> On 2022-08-23 14:57, Andrey Grodzovsky wrote: >>> On 2022-08-23 14:30, Luben Tuikov wrote: >>> On 2022-08-23 14:13, Andrey Grodzovsky wrote: > On 2022-08-23 12:58, Luben Tuikov wrote

[PATCH v3] drm/msm/dp: correct 1.62G link rate at dp_catalog_ctrl_config_msa()

2022-08-25 Thread Kuogee Hsieh
At current implementation there is an extra 0 at 1.62G link rate which cause no correct pixel_div selected for 1.62G link rate to calculate mvid and nvid. This patch delete the extra 0 to have mvid and nvid be calculated correctly. Changes in v2: -- fix Fixes tag's text Changes in v3: -- fix miss

Re: [PATCH] drm/sced: Add FIFO policy for scheduler rq

2022-08-25 Thread Andrey Grodzovsky
On 2022-08-23 17:37, Luben Tuikov wrote: On 2022-08-23 14:57, Andrey Grodzovsky wrote: On 2022-08-23 14:30, Luben Tuikov wrote: On 2022-08-23 14:13, Andrey Grodzovsky wrote: On 2022-08-23 12:58, Luben Tuikov wrote: Inlined: On 2022-08-22 16:09, Andrey Grodzovsky wrote: Poblem: Given many

Re: [Intel-gfx] [PATCH 6/7] drm/i915/guc: Make GuC log sizes runtime configurable

2022-08-25 Thread Joonas Lahtinen
Quoting John Harrison (2022-08-24 21:45:09) > On 8/24/2022 02:01, Joonas Lahtinen wrote: > > NACK on this one. Let's get this reverted or fixed to eliminate > > new module parameters. > > > > What prevents us just from using the maximum sizes? Or alternatively > > we could check the already existin

[PATCH] drm/i915:Move the code position to reduce the number of judgments

2022-08-25 Thread Lv qian
If the kmalloc allocation is successful, the if is judged twice, so I move the second judgment in to the first judgment. Signed-off-by: Lv qian --- drivers/gpu/drm/i915/i915_gpu_error.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i

Re: [PATCH] drm/msm/dp: correct 1.62G link rate at dp_catalog_ctrl_config_msa()

2022-08-25 Thread Abhinav Kumar
On 8/24/2022 9:59 AM, Kuogee Hsieh wrote: At current implementation there is an extra 0 at 1.62G link rate which cause no correct pixel_div selected for 1.62G link rate to calculate mvid and nvid. This patch delete the extra 0 to have mvid and nvid be calculated correctly. Fixes: 937f941ca06f

Re: [Linaro-mm-sig] [PATCH v3 6/9] dma-buf: Move dma-buf attachment to dynamic locking specification

2022-08-25 Thread Christian König
Am 24.08.22 um 17:49 schrieb Dmitry Osipenko: On 8/24/22 18:24, Christian König wrote: Am 24.08.22 um 12:22 schrieb Dmitry Osipenko: Move dma-buf attachment API functions to the dynamic locking specification. The strict locking convention prevents deadlock situations for dma-buf importers and e

[PATCH linux-next v2] drm/mediatek: Remove the unneeded result

2022-08-25 Thread cgel . zte
From: ye xingchen Return the value drm_mode_config_helper_suspend() directly instead of storing it in another redundant variable. Reported-by: Zeal Robot Signed-off-by: ye xingchen --- v1 -> v2 Add all the mailinglists that get_maintainers.pl give. drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5

[PATCH linux-next] drm/bridge: parade-ps8622: Remove the unneeded result variable

2022-08-25 Thread cgel . zte
From: ye xingchen Return the value ps8622_set() directly instead of storing it in another redundant variable. Reported-by: Zeal Robot Signed-off-by: ye xingchen --- drivers/gpu/drm/bridge/parade-ps8622.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm

Re: [PATCH] drm/msm/dp: add atomic_check to bridge ops

2022-08-25 Thread Abhinav Kumar
On 8/24/2022 1:25 AM, Dmitry Baryshkov wrote: On Wed, 24 Aug 2022 at 01:59, Abhinav Kumar wrote: On 8/23/2022 3:41 PM, Dmitry Baryshkov wrote: On Wed, 24 Aug 2022 at 01:07, Abhinav Kumar wrote: On 8/22/2022 11:33 AM, Dmitry Baryshkov wrote: On 22/08/2022 20:32, Abhinav Kumar wrote:

Re: [Intel-gfx] [PATCH v1] drm/i915: fix null pointer dereference

2022-08-25 Thread Jani Nikula
On Tue, 23 Aug 2022, Łukasz Bartosik wrote: >> >> Hi all, >> >> Apologies in advance if you see this twice. I did not see the original >> make it to either lore.kernel.org or the freedesktop.org archives so I >> figured it might have been sent into the void. >> >> On Tue, Feb 01, 2022 at 04:33:54P

Re: [PATCH 5/5] drm/msm: Skip tlbinv on unmap from non-current pgtables

2022-08-25 Thread Akhil P Oommen
On 8/21/2022 11:49 PM, Rob Clark wrote: From: Rob Clark We can rely on the tlbinv done by CP_SMMU_TABLE_UPDATE in this case. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 6 ++ drivers/gpu/drm/msm/msm_iommu.c | 29 +++ 2 files chan

Re: [PATCH v1 1/4] drm/msm/mdp5: stop overriding drvdata

2022-08-25 Thread Abhinav Kumar
On 8/24/2022 1:29 AM, Dmitry Baryshkov wrote: On Wed, 24 Aug 2022 at 04:25, Abhinav Kumar wrote: On 6/20/2022 2:30 PM, Dmitry Baryshkov wrote: The rest of the code expects that master's device drvdata is the struct msm_drm_private instance. Do not override the mdp5's drvdata. Fixes: 687

Re: [PATCH drm-misc-next v3 0/4] Fixes for vc4 hotplug rework

2022-08-25 Thread Maxime Ripard
On Wed, 24 Aug 2022 18:13:23 +0200, Danilo Krummrich wrote: > I've found a few potential issues left after the hotplug rework. > > In vc4_hdmi.c we're missing two mutex_unlock() calls when the device is > unplugged. > > vc4_crtc and vc4_plane seem to miss some drm_dev_enter()/drm_dev_exit() calls

Re: [Intel-gfx] [PATCH 1/2] drm/i915/uc: Support for version reduced and multiple firmware files

2022-08-25 Thread Ceraolo Spurio, Daniele
On 8/16/2022 1:28 PM, john.c.harri...@intel.com wrote: From: John Harrison There was a misunderstanding in how firmware file compatibility should be managed within i915. This has been clarified as: i915 must support all existing firmware releases forever new minor firmware releases sho

[PATCH] drm: document uAPI page-flip flags

2022-08-25 Thread Simon Ser
Document flags accepted by the page-flip and atomic IOCTLs. Signed-off-by: Simon Ser Cc: Daniel Vetter --- include/uapi/drm/drm_mode.h | 44 - 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mod

Re: [PATCH] drm: amd: amdgpu: ACPI: Add comment about ACPI_FADT_LOW_POWER_S0

2022-08-25 Thread Limonciello, Mario
On 8/24/2022 12:32, Rafael J. Wysocki wrote: From: Rafael J. Wysocki According to the ACPI specification [1], the ACPI_FADT_LOW_POWER_S0 flag merely means that it is better to use low-power S0 idle on the given platform than S3 (provided that the latter is supported) and it doesn't preclude usi

Re: [Intel-gfx] [PATCH v9 2/8] util_macros: Add exact_type macro to catch type mis-match while compiling

2022-08-25 Thread Gwan-gyeong Mun
Hi Bartosz Golaszewski, would you mind taking a look at this patch? Thanks, G.G. On 8/24/22 5:45 PM, Gwan-gyeong Mun wrote: It adds exact_type and exactly_pgoff_t macro to catch type mis-match while compiling. The existing typecheck() macro outputs build warnings, but the newly added exact_typ

Re: [PATCH] dt-bindings: display: adi,adv75xx: Add missing graph schema references

2022-08-25 Thread Krzysztof Kozlowski
On 23/08/2022 17:56, Rob Herring wrote: > DT bindings using the graph binding must have references to the graph > binding schema. These are missing from the adi,adv7511 and adi,adv7533 > bindings, so add them. > > Signed-off-by: Rob Herring Reviewed-by: Krzysztof Kozlowski Best regards, Krzy

Re: [PATCH] dt-bindings: display: adi,adv75xx: Add missing graph schema references

2022-08-25 Thread Laurent Pinchart
Hi Rob, Thank you for the patch. On Tue, Aug 23, 2022 at 09:56:43AM -0500, Rob Herring wrote: > DT bindings using the graph binding must have references to the graph > binding schema. These are missing from the adi,adv7511 and adi,adv7533 > bindings, so add them. > > Signed-off-by: Rob Herring

Re: [RFC] drm/kms: control display brightness through drm_connector properties

2022-08-25 Thread Hans de Goede
Hi Yusuf, On 8/24/22 04:18, Yusuf Khan wrote: > Sorry for the necro-bump, I hadnt seen this go by No problem. > My main concern with this proposal is the phasing out of > /sys/class/backlight/. > Currently on the user(user, not userland) level its easier for me to just > modify > the file and

[Bug 216119] 087451f372bf76d breaks hibernation on amdgpu Radeon R9 390

2022-08-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216119 --- Comment #39 from Harald Judt (h.j...@gmx.at) --- Switching back to the original amdgpu_fb implementation (I've reverted this and all relevant patches on stable-5.18.19), all remaining issues vanish. After two hibernate/resume cycles, I can sti

Re: [PATCH v4 05/31] drm/nouveau: Don't register backlight when another backlight should be used (v2)

2022-08-25 Thread Hans de Goede
Hi Lyude, Thank you for the review. On 8/24/22 19:41, Lyude Paul wrote: > Just one tiny nitpick below: > > On Wed, 2022-08-24 at 14:14 +0200, Hans de Goede wrote: >> Before this commit when we want userspace to use the acpi_video backlight >> device we register both the GPU's native backlight de

Re: [PATCH] dt-bindings: display: Add missing (unevaluated|additional)Properties on child nodes

2022-08-25 Thread Laurent Pinchart
Hi Rob, Thank you for the patch. On Tue, Aug 23, 2022 at 09:56:42AM -0500, Rob Herring wrote: > In order to ensure only documented properties are present, node schemas > must have unevaluatedProperties or additionalProperties set to false > (typically). > > Signed-off-by: Rob Herring Reviewed-

Re: [PATCH v4 02/31] drm/i915: Don't register backlight when another backlight should be used

2022-08-25 Thread Hans de Goede
Hi All, On 8/24/22 14:50, Jani Nikula wrote: > On Wed, 24 Aug 2022, Hans de Goede wrote: >> Before this commit when we want userspace to use the acpi_video backlight >> device we register both the GPU's native backlight device and acpi_video's >> firmware acpi_video# backlight device. This relies

[PATCH v2 0/3] Drivers: hv: Avoid allocating MMIO from framebuffer region for other passed through PCI devices

2022-08-25 Thread Vitaly Kuznetsov
Changes since v1: - Dropped PATCH2 as it is no longer needed. - Move PCI ids to linux/pci_ids.h [Michael] - Correctly handle "!(pdev->resource[0].flags & IORESOURCE_MEM)" case [Michael]. Passed through PCI device sometimes misbehave on Gen1 VMs when Hyper-V DRM driver is also loaded. Looking at

[PATCH v2 3/3] Drivers: hv: Never allocate anything besides framebuffer from framebuffer memory region

2022-08-25 Thread Vitaly Kuznetsov
Passed through PCI device sometimes misbehave on Gen1 VMs when Hyper-V DRM driver is also loaded. Looking at IOMEM assignment, we can see e.g. $ cat /proc/iomem ... f800-fffb : PCI Bus :00 f800-fbff : :00:08.0 f800-f8001fff : bb8c4f33-2ba2-4808-9f7f-02f3b4da22fe .

[PATCH v2 2/3] Drivers: hv: Always reserve framebuffer region for Gen1 VMs

2022-08-25 Thread Vitaly Kuznetsov
vmbus_reserve_fb() tries reserving framebuffer region iff 'screen_info.lfb_base' is set. Gen2 VMs seem to have it set by EFI fb (or, in some edge cases like kexec, the address where the buffer was moved, see https://lore.kernel.org/all/20201014092429.1415040-1-kas...@redhat.com/) but on Gen1 VM it

[PATCH v2 1/3] PCI: Move PCI_VENDOR_ID_MICROSOFT/PCI_DEVICE_ID_HYPERV_VIDEO definitions to pci_ids.h

2022-08-25 Thread Vitaly Kuznetsov
There are already three places in kernel which define PCI_VENDOR_ID_MICROSOFT and two for PCI_DEVICE_ID_HYPERV_VIDEO and there's a need to use these from core Vmbus code. Move the defines where they belong. No functional change. Signed-off-by: Vitaly Kuznetsov --- drivers/gpu/drm/hyperv/hyperv_

[PATCH] drm: amd: amdgpu: ACPI: Add comment about ACPI_FADT_LOW_POWER_S0

2022-08-25 Thread Rafael J. Wysocki
From: Rafael J. Wysocki According to the ACPI specification [1], the ACPI_FADT_LOW_POWER_S0 flag merely means that it is better to use low-power S0 idle on the given platform than S3 (provided that the latter is supported) and it doesn't preclude using either of them (which of them will be used d

Re: [PATCH] video: fbdev: omap: Remove unnecessary print function dev_err()

2022-08-25 Thread Helge Deller
On 8/24/22 13:44, Jiapeng Chong wrote: > The print function dev_err() is redundant because platform_get_irq() > already prints an error. > > ./drivers/video/fbdev/omap/omapfb_main.c:1653:2-9: line 1653 is redundant > because platform_get_irq() already prints an error. > ./drivers/video/fbdev/omap/

Re: [PATCH] fbcon: Properly revert changes when vc_resize() failed

2022-08-25 Thread Helge Deller
Hi Shigeru, On 8/18/22 20:13, Shigeru Yoshida wrote: > fbcon_do_set_font() calls vc_resize() when font size is changed. > However, if if vc_resize() failed, current implementation doesn't > revert changes for font size, and this causes inconsistent state. > > syzbot reported unable to handle page

Re: [PATCH v4 05/31] drm/nouveau: Don't register backlight when another backlight should be used (v2)

2022-08-25 Thread Lyude Paul
Just one tiny nitpick below: On Wed, 2022-08-24 at 14:14 +0200, Hans de Goede wrote: > Before this commit when we want userspace to use the acpi_video backlight > device we register both the GPU's native backlight device and acpi_video's > firmware acpi_video# backlight device. This relies on user

[PATCH v4 03/10] dt-bindings: display/msm: move qcom, sc7180-mdss schema to mdss.yaml

2022-08-25 Thread Dmitry Baryshkov
Move schema for qcom,sc7180-mdss from dpu-sc7180.yaml to mdss.yaml so that the dpu file describes only the DPU schema. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dpu-sc7180.yaml | 149 +- .../devicetree/bindings/display/msm/mdss.yaml | 66 +++- 2 files

[PATCH v4 00/10] dt-bindings: display/msm: rework MDSS and DPU bindings

2022-08-25 Thread Dmitry Baryshkov
Create separate YAML schema for MDSS devicesd$ (both for MDP5 and DPU devices). Cleanup DPU schema files, so that they do not contain schema for both MDSS and DPU nodes. Apply misc small fixes to the DPU schema afterwards. Changes since v3: - Changed mdss->(dpu, dsi, etc.) relationship into the t

[PATCH v4 02/10] dt-bindings: display/msm: move qcom, sdm845-mdss schema to mdss.yaml

2022-08-25 Thread Dmitry Baryshkov
Move schema for qcom,sdm845-mdss from dpu-sdm845.yaml to mdss.yaml so that the dpu file describes only the DPU schema. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dpu-sdm845.yaml | 135 +++-- .../devicetree/bindings/display/msm/mdss.yaml | 265 ++ 2 file

[PATCH v4 04/10] dt-bindings: display/msm: move qcom, sc7280-mdss schema to mdss.yaml

2022-08-25 Thread Dmitry Baryshkov
Move schema for qcom,sc7280-mdss from dpu-sc7280.yaml to mdss.yaml so that the dpu file describes only the DPU schema. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dpu-sc7280.yaml | 148 +- .../devicetree/bindings/display/msm/mdss.yaml | 54 +++ 2 files

[PATCH v4 05/10] dt-bindings: display/msm: move qcom, qcm2290-mdss schema to mdss.yaml

2022-08-25 Thread Dmitry Baryshkov
Move schema for qcom,qcm2290-mdss from dpu-qcm2290.yaml to mdss.yaml so that the dpu file describes only the DPU schema. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dpu-qcm2290.yaml | 140 +- .../devicetree/bindings/display/msm/mdss.yaml | 49 ++ 2 files

[PATCH v4 07/10] dt-bindings: display/mdm: add gcc-bus clock to dpu-smd845

2022-08-25 Thread Dmitry Baryshkov
Add gcc-bus clock required for the SDM845 DPU device tree node. This change was made in the commit 111c52854102 ("arm64: dts: qcom: sdm845: move bus clock to mdp node for sdm845 target"), but was not reflected in the schema. Reviewed-by: Rob Herring Signed-off-by: Dmitry Baryshkov --- .../devic

[PATCH v4 10/10] dt-bindings: display/msm: add support for the display on SM8250

2022-08-25 Thread Dmitry Baryshkov
Add DPU schema and extend MDSS schema to describe MDSS and DPU blocks on Qualcomm SM8250 platform. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dpu-sm8250.yaml | 123 ++ .../devicetree/bindings/display/msm/mdss.yaml | 51 2 files changed, 174 insert

[PATCH v4 06/10] dt-bindings: display/msm: move qcom, msm8998-mdss schema to mdss.yaml

2022-08-25 Thread Dmitry Baryshkov
Move schema for qcom,msm8998-mdss from dpu-msm8998.yaml to mdss.yaml so that the dpu file describes only the DPU schema. Reviewed-by: Rob Herring Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dpu-msm8998.yaml | 142 +- .../devicetree/bindings/display/msm/mdss.

[PATCH v4 01/10] dt-bindings: display/msm: split qcom,mdss bindings

2022-08-25 Thread Dmitry Baryshkov
Split Mobile Display SubSystem (MDSS) root node bindings to the separate yaml file. Changes to the existing (txt) schema: - Added optional "vbif_nrt_phys" region used by msm8996 - Made "bus" and "vsync" clocks optional (they are not used by some platforms) - Added (optional) "core" clock adde

[PATCH v4 08/10] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml

2022-08-25 Thread Dmitry Baryshkov
Move properties common to all DPU DT nodes to the dpu-common.yaml. Note, this removes description of individual DPU port@ nodes. However such definitions add no additional value. The reg values do not correspond to hardware INTF indices. The driver discovers and binds these ports not paying any ca

[PATCH v4 09/10] dt-bindings: display/msm/dpu-common: add opp-table property

2022-08-25 Thread Dmitry Baryshkov
The display controller node can contain the opp-table describing its frequencies and OPP levels. Allow specifying the opp-table in the DPU devices. Signed-off-by: Dmitry Baryshkov --- Documentation/devicetree/bindings/display/msm/dpu-common.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --g

Re: [PATCH] drm/virtio: Fix same-context optimization

2022-08-25 Thread Gerd Hoffmann
On Fri, Aug 12, 2022 at 03:40:00PM -0700, Rob Clark wrote: > From: Rob Clark > > When VIRTGPU_EXECBUF_RING_IDX is used, we should be considering the > timeline that the EB if running on rather than the global driver fence > context. > > Fixes: 85c83ea915ed ("drm/virtio: implement context init: a

Re: [PATCH] udmabuf: Set ubuf->sg = NULL if the creation of sg table fails

2022-08-25 Thread Gerd Hoffmann
On Wed, Aug 24, 2022 at 11:35:22PM -0700, Vivek Kasireddy wrote: > When userspace tries to map the dmabuf and if for some reason > (e.g. OOM) the creation of the sg table fails, ubuf->sg needs to be > set to NULL. Otherwise, when the userspace subsequently closes the > dmabuf fd, we'd try to errone

Re: [PATCH v4 12/31] drm/nouveau: Register ACPI video backlight when nv_backlight registration fails (v2)

2022-08-25 Thread Lyude Paul
Reviewed-by: Lyude Paul On Wed, 2022-08-24 at 14:15 +0200, Hans de Goede wrote: > Typically the acpi_video driver will initialize before nouveau, which > used to cause /sys/class/backlight/acpi_video0 to get registered and then > nouveau would register its own nv_backlight device later. After whi

Re: [PATCH v4 31/31] drm/todo: Add entry about dealing with brightness control on devices with > 1 panel

2022-08-25 Thread Lyude Paul
Reviewed-by: Lyude Paul On Wed, 2022-08-24 at 14:15 +0200, Hans de Goede wrote: > Add an entry summarizing the discussion about dealing with brightness > control on devices with more then 1 internal panel. > > The original discussion can be found here: > https://lore.kernel.org/dri-devel/2022051

Re: [PATCH v2 05/21] drm/i915/mtl: Define engine context layouts

2022-08-25 Thread Balasubramani Vivekanandan
On 18.08.2022 16:41, Radhakrishna Sripada wrote: > From: Matt Roper > > The part of the media and blitter engine contexts that we care about for > setting up an initial state are the same on MTL as they were on DG2 > (and PVC), so we need to update the driver conditions to re-use the DG2 > contex

Re: [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-25 Thread Karol Herbst
On Wed, Aug 24, 2022 at 7:50 PM Kai-Heng Feng wrote: > > On Tue, Aug 16, 2022 at 4:06 PM Jani Nikula > wrote: > > > > On Tue, 16 Aug 2022, Kai-Heng Feng wrote: > > > On mobile workstations like HP ZBook Fury G8, iGFX's DP-IN can switch to > > > dGFX so external monitors are routed to dGFX, and

[PATCH 1/2] drm: rcar-du: Drop unused encoder header files

2022-08-25 Thread Biju Das
Drop unused header files from rcar_du_encoder.c Signed-off-by: Biju Das --- drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/rcar-du/rcar_du_encoder.c b/drivers/gpu/drm/rcar-du/rcar_du_encoder.c index 60d6be78323b..bfd5c087eb0a 10

[PATCH 2/2] drm: rcar-du: Use %p4cc to print 4CC format

2022-08-25 Thread Biju Das
Replace use of struct rcar_du_format_info with %p4cc for printing 4CC formats. Reported-by: Geert Uytterhoeven Signed-off-by: Biju Das --- drivers/gpu/drm/rcar-du/rcar_du_kms.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drive

Re: [Intel-gfx] [PATCH v6 3/4] drm/i915/display: add hotplug.suspended flag

2022-08-25 Thread Andrzej Hajda
On 24.08.2022 13:22, Imre Deak wrote: On Tue, Aug 23, 2022 at 11:48:01PM +0200, Andrzej Hajda wrote: On 22.08.2022 19:27, Imre Deak wrote: On Fri, Jul 22, 2022 at 02:51:42PM +0200, Andrzej Hajda wrote: HPD events during driver removal can be generated by hardware and software frameworks - dr

[PATCH 1/5] dt-bindings: socionext, uniphier-system-cache: drop minItems equal to maxItems

2022-08-25 Thread Krzysztof Kozlowski
minItems, if missing, are implicitly equal to maxItems, so drop redundant piece to reduce size of code. Signed-off-by: Krzysztof Kozlowski --- .../bindings/arm/socionext/socionext,uniphier-system-cache.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/devicetree/bindings/ar

[PATCH 2/5] dt-bindings: ata: drop minItems equal to maxItems

2022-08-25 Thread Krzysztof Kozlowski
minItems, if missing, are implicitly equal to maxItems, so drop redundant piece to reduce size of code. Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/ata/brcm,sata-brcm.yaml | 1 - .../devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml | 2 -- Documentat

[PATCH 5/5] dt-bindings: display: drop minItems equal to maxItems

2022-08-25 Thread Krzysztof Kozlowski
minItems, if missing, are implicitly equal to maxItems, so drop redundant piece to reduce size of code. Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml | 1 - .../devicetree/bindings/display/msm/dsi-controller-main.yaml| 2 -- Documentat

[PATCH 3/5] dt-bindings: clock: drop minItems equal to maxItems

2022-08-25 Thread Krzysztof Kozlowski
minItems, if missing, are implicitly equal to maxItems, so drop redundant piece to reduce size of code. Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/clock/cirrus,cs2000-cp.yaml | 1 - .../devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.yaml | 2 -- Documentat

[PATCH 4/5] dt-bindings: crypto: drop minItems equal to maxItems

2022-08-25 Thread Krzysztof Kozlowski
minItems, if missing, are implicitly equal to maxItems, so drop redundant piece to reduce size of code. Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/devicetree/bindings/crypto

Re: [PATCH 1/2] drm/rockchip: dw_hdmi: relax mode_valid hook

2022-08-25 Thread Sascha Hauer
On Wed, Aug 24, 2022 at 05:07:50PM +0100, Robin Murphy wrote: > On 2022-08-22 16:20, Sascha Hauer wrote: > > The driver checks if the pixel clock of the given mode matches an entry > > in the mpll config table. The frequencies in the mpll table are meant as > > a frequency range up to which the ent

Re: [PATCH v4 01/10] dt-bindings: display/msm: split qcom,mdss bindings

2022-08-25 Thread Krzysztof Kozlowski
On 25/08/2022 12:50, Dmitry Baryshkov wrote: > Split Mobile Display SubSystem (MDSS) root node bindings to the separate > yaml file. Changes to the existing (txt) schema: > - Added optional "vbif_nrt_phys" region used by msm8996 > - Made "bus" and "vsync" clocks optional (they are not used by som

Re: [PATCH] drm: Remove the unused param "struct drm_buddy *mm"

2022-08-25 Thread Maíra Canal
Hi Cai, On 6/27/22 05:54, Cai Huoqing wrote: > Remove the param "struct drm_buddy *mm" which is unused in > the function drm_block_alloc()/drm_block_free(). > > Signed-off-by: Cai Huoqing Reviewed-by: Maíra Canal Best Regards, - Maíra Canal > --- > drivers/gpu/drm/drm_buddy.c | 25 +

Re: [PATCH v4 01/10] dt-bindings: display/msm: split qcom,mdss bindings

2022-08-25 Thread Krzysztof Kozlowski
On 25/08/2022 12:50, Dmitry Baryshkov wrote: (...) > +minItems: 1 > +maxItems: 4 > + > + clock-names: > +minItems: 1 > +maxItems: 4 > + > + "#address-cells": > +const: 1 > + > + "#size-cells": > +const: 1 > + > + ranges: > +true > + > + resets: > +items: > +

Re: [PATCH v4 02/10] dt-bindings: display/msm: move qcom, sdm845-mdss schema to mdss.yaml

2022-08-25 Thread Krzysztof Kozlowski
On 25/08/2022 12:50, Dmitry Baryshkov wrote: > Move schema for qcom,sdm845-mdss from dpu-sdm845.yaml to mdss.yaml so > that the dpu file describes only the DPU schema. > > Signed-off-by: Dmitry Baryshkov > --- > .../bindings/display/msm/dpu-sdm845.yaml | 135 +++-- > .../devicetree/bind

Re: [PATCH v4 03/10] dt-bindings: display/msm: move qcom, sc7180-mdss schema to mdss.yaml

2022-08-25 Thread Krzysztof Kozlowski
On 25/08/2022 12:50, Dmitry Baryshkov wrote: > Move schema for qcom,sc7180-mdss from dpu-sc7180.yaml to mdss.yaml so > that the dpu file describes only the DPU schema. MDSS grows to unmanagable file. I don't think we will be able to keep it maintained. You will have many if-else defining subnodes

Re: vm binding interfaces and parallel with mmap

2022-08-25 Thread Christian König
Am 24.08.22 um 18:14 schrieb Jason Ekstrand: On Mon, Aug 22, 2022 at 8:27 AM Christian König wrote: [SNIP] >> I suppose it also asks the question around paralleling >> >> fd = open() >> ptr = mmap(fd,) >> close(fd) >> the mapping is still valid. >> >> I suppose

Re: [PATCH v4 03/10] dt-bindings: display/msm: move qcom, sc7180-mdss schema to mdss.yaml

2022-08-25 Thread Dmitry Baryshkov
On 25/08/2022 15:01, Krzysztof Kozlowski wrote: On 25/08/2022 12:50, Dmitry Baryshkov wrote: Move schema for qcom,sc7180-mdss from dpu-sc7180.yaml to mdss.yaml so that the dpu file describes only the DPU schema. MDSS grows to unmanagable file. I don't think we will be able to keep it maintaine

Re: [PATCH v1 34/35] drm/modes: Introduce the tv_mode property as a command-line option

2022-08-25 Thread Noralf Trønnes
Den 24.08.2022 17.45, skrev Maxime Ripard: > Hi Noralf, > > On Sat, Aug 20, 2022 at 10:18:47PM +0200, Noralf Trønnes wrote: >> Den 29.07.2022 18.35, skrev Maxime Ripard: >>> Our new tv mode option allows to specify the TV mode from a property. >>> However, it can still be useful, for example to

Re: [PATCH] drm/bridge: sii902x: add support for DRM_BRIDGE_ATTACH_NO_CONNECTOR

2022-08-25 Thread Linus Walleij
On Wed, Aug 17, 2022 at 3:31 PM Neil Armstrong wrote: > On 15/08/2022 02:15, Dmitry Osipenko wrote: > > 08.08.2022 12:51, Neil Armstrong пишет: > >> On 08/08/2022 11:15, Neil Armstrong wrote: > This patch broke ARM/QEMU vexpress display because of_drm_find_bridge() > always fail with -E

Re: [PATCH RESEND] dt-bindings: leds: qcom-wled: fix number of addresses

2022-08-25 Thread Krzysztof Kozlowski
On 20/07/2022 19:37, Krzysztof Kozlowski wrote: > On PM660L, PMI8994 and PMI8998, the WLED has two address spaces. This > also fixes dtbs_check warnings like: > > arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dtb: leds@d800: reg: > [[55296], [2]] is too long > > Signed-off-by: Krzysztof K

[PATCH 1/2] drm/plane_helper: Print actual/expected values on failure

2022-08-25 Thread Michał Winiarski
Currently the values are printed with debug log level. Adjust the log level and link the output with the test by using kunit_err. Example output: foo: dst: 20x20+10+10, expected: 10x10+0+0 foo: EXPECTATION FAILED at drivers/gpu/drm/tests/drm_plane_helper_test.c:85 Signed-off-by: Michał Winiarski

[PATCH 2/2] drm/plane_helper: Split into parameterized test cases

2022-08-25 Thread Michał Winiarski
The test was constructed as a single function (test case) which checks multiple conditions, calling the function that is tested multiple times with different arguments. This usually means that it can be easily converted into multiple test cases. Split igt_check_plane_state into two parameterized te

[PATCH RESEND - dt 1/2] dt-bindings: nvmem: qfprom: add IPQ8064 and SDM630 compatibles

2022-08-25 Thread Krzysztof Kozlowski
Document compatibles for QFPROM used on IPQ8064 and SDM630. They are compatible with generic QFPROM fallback. Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/n

[PATCH RESEND - dt 0/2] dt-bindings: left-overs for DT tree

2022-08-25 Thread Krzysztof Kozlowski
Hi Rob, These were sent some months ago, then resent and still were not applied. You already reviewed them (I removed your tag here). Can you apply them to your tree? https://lore.kernel.org/all/20220720163720.7099-1-krzysztof.kozlow...@linaro.org/ https://lore.kernel.org/all/daaf6ad7-6204-2a13

[PATCH RESEND - dt 2/2] dt-bindings: leds: qcom-wled: fix number of addresses

2022-08-25 Thread Krzysztof Kozlowski
On PM660L, PMI8994 and PMI8998, the WLED has two address spaces. This also fixes dtbs_check warnings like: arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dtb: leds@d800: reg: [[55296], [2]] is too long Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/leds/backlight/qcom-wle

Re: [Linaro-mm-sig] [PATCH v3 6/9] dma-buf: Move dma-buf attachment to dynamic locking specification

2022-08-25 Thread Dmitry Osipenko
On 8/24/22 20:45, Christian König wrote: > Am 24.08.22 um 17:49 schrieb Dmitry Osipenko: >> On 8/24/22 18:24, Christian König wrote: >>> Am 24.08.22 um 12:22 schrieb Dmitry Osipenko: Move dma-buf attachment API functions to the dynamic locking specification. The strict locking conven

Re: [PATCH linux-next v2] drm/mediatek: Remove the unneeded result

2022-08-25 Thread Matthias Brugger
On 25/08/2022 09:23, cgel@gmail.com wrote: From: ye xingchen Return the value drm_mode_config_helper_suspend() directly instead of storing it in another redundant variable. Reported-by: Zeal Robot Signed-off-by: ye xingchen I thought I already did this in v1, anyway here we go aga

Re: [PATCH 0/4] Add support for atomic async page-flips

2022-08-25 Thread Melissa Wen
On 08/24, Simon Ser wrote: > This series adds support for DRM_MODE_PAGE_FLIP_ASYNC for atomic > commits, aka. "immediate flip" (which might result in tearing). > The feature was only available via the legacy uAPI, however for > gaming use-cases it may be desirable to enable it via the atomic > uAPI

Re: [PATCH v1 23/35] drm/vc4: vec: Convert to the new TV mode property

2022-08-25 Thread Noralf Trønnes
Den 24.08.2022 17.26, skrev Maxime Ripard: > Hi, > > On Sat, Aug 20, 2022 at 07:22:48PM +0200, Noralf Trønnes wrote: >> Den 29.07.2022 18.35, skrev Maxime Ripard: >>> Now that the core can deal fine with analog TV modes, let's convert the vc4 >>> VEC driver to leverage those new features. >>> >

Re: [PATCH v1 05/35] drm/connector: Add TV standard property

2022-08-25 Thread Maxime Ripard
Hi, On Fri, Aug 19, 2022 at 11:35:42AM +0200, Geert Uytterhoeven wrote: > On Thu, Aug 18, 2022 at 5:34 PM Maxime Ripard wrote: > > On Thu, Aug 18, 2022 at 05:20:42PM +0200, Geert Uytterhoeven wrote: > > > On Thu, Aug 18, 2022 at 4:54 PM Maxime Ripard wrote: > > > > On Wed, Aug 17, 2022 at 04:04:

[PATCH v5 0/2] Add RZ/G2L DSI driver

2022-08-25 Thread Biju Das
This patch series aims to support the MIPI DSI encoder found in the RZ/G2L SoC. It currently supports DSI mode only. This unit supports MIPI Alliance Specification for Display Serial Interface (DSI) Specification. This unit provides a solution for transmitting MIPI DSI compliant digital video and

[PATCH v5 1/2] dt-bindings: display: bridge: Document RZ/G2L MIPI DSI TX bindings

2022-08-25 Thread Biju Das
The RZ/G2L MIPI DSI TX is embedded in the Renesas RZ/G2L family SoC's. It can operate in DSI mode, with up to four data lanes. Signed-off-by: Biju Das Reviewed-by: Rob Herring Reviewed-by: Laurent Pinchart Reviewed-by: Geert Uytterhoeven --- v4->v5: * No change. v3->v4: * No change. v2->v3:

[PATCH v5 2/2] drm: rcar-du: Add RZ/G2L DSI driver

2022-08-25 Thread Biju Das
This driver supports the MIPI DSI encoder found in the RZ/G2L SoC. It currently supports DSI mode only. Signed-off-by: Biju Das Acked-by: Sam Ravnborg --- v4->v5: * Added Ack from Sam. * Added a trivial change, replaced rzg2l_mipi_dsi_parse_dt() with drm_of_get_data_lanes_count_ep() in prob

Re: [PATCH v1 05/35] drm/connector: Add TV standard property

2022-08-25 Thread Maxime Ripard
Hi, On Sat, Aug 20, 2022 at 10:12:46PM +0200, Noralf Trønnes wrote: > > diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h > > index 1e9996b33cc8..78275e68ff66 100644 > > --- a/include/drm/drm_connector.h > > +++ b/include/drm/drm_connector.h > > @@ -143,6 +143,32 @@ enum subpi

Re: [PATCH] drm/sced: Add FIFO policy for scheduler rq

2022-08-25 Thread Andrey Grodzovsky
On 2022-08-24 22:29, Luben Tuikov wrote: Inlined: On 2022-08-24 12:21, Andrey Grodzovsky wrote: On 2022-08-23 17:37, Luben Tuikov wrote: On 2022-08-23 14:57, Andrey Grodzovsky wrote: On 2022-08-23 14:30, Luben Tuikov wrote: On 2022-08-23 14:13, Andrey Grodzovsky wrote: On 2022-08-23 12:5

Re: [PATCH] drm/sced: Add FIFO policy for scheduler rq

2022-08-25 Thread Andrey Grodzovsky
On 2022-08-24 22:29, Luben Tuikov wrote: Inlined: On 2022-08-24 12:21, Andrey Grodzovsky wrote: On 2022-08-23 17:37, Luben Tuikov wrote: On 2022-08-23 14:57, Andrey Grodzovsky wrote: On 2022-08-23 14:30, Luben Tuikov wrote: On 2022-08-23 14:13, Andrey Grodzovsky wrote: On 2022-08-23 12:5

Re: [PATCH] drm: omapdrm: Improve check for contiguous buffers

2022-08-25 Thread Andrew Davis
On 8/22/22 7:03 PM, Andrew Davis wrote: While a scatter-gather table having only 1 entry does imply it is contiguous, it is a logic error to assume the inverse. Tables can have more than 1 entry and still be contiguous. Use a proper check here. Signed-off-by: Andrew Davis --- Looks like an o

Re: [PATCH v1 35/35] drm/modes: Introduce more named modes

2022-08-25 Thread Maxime Ripard
On Sun, Aug 21, 2022 at 06:16:15PM +0200, Noralf Trønnes wrote: > > > Den 29.07.2022 18.35, skrev Maxime Ripard: > > Now that we can easily extend the named modes list, let's add a few more > > analog TV modes that were used in the wild, and some unit tests to make > > sure it works as intended.

RE: [PATCH v2 1/3] PCI: Move PCI_VENDOR_ID_MICROSOFT/PCI_DEVICE_ID_HYPERV_VIDEO definitions to pci_ids.h

2022-08-25 Thread Michael Kelley (LINUX)
From: Vitaly Kuznetsov Sent: Thursday, August 25, 2022 2:00 AM > > There are already three places in kernel which define PCI_VENDOR_ID_MICROSOFT > and two for PCI_DEVICE_ID_HYPERV_VIDEO and there's a need to use these > from core Vmbus code. Move the defines where they belong. > > No functional

[PATCH v5 00/31] drm/kms: Stop registering multiple /sys/class/backlight devs for a single display

2022-08-25 Thread Hans de Goede
Hi All, As mentioned in my RFC titled "drm/kms: control display brightness through drm_connector properties": https://lore.kernel.org/dri-devel/0d188965-d809-81b5-74ce-7d30c49fe...@redhat.com/ The first step towards this is to deal with some existing technical debt in backlight handling on x86/AC

[PATCH v5 04/31] drm/radeon: Don't register backlight when another backlight should be used (v3)

2022-08-25 Thread Hans de Goede
Before this commit when we want userspace to use the acpi_video backlight device we register both the GPU's native backlight device and acpi_video's firmware acpi_video# backlight device. This relies on userspace preferring firmware type backlight devices over native ones. Registering 2 backlight

Re: [PATCH v4 03/10] dt-bindings: display/msm: move qcom, sc7180-mdss schema to mdss.yaml

2022-08-25 Thread Krzysztof Kozlowski
On 25/08/2022 15:40, Dmitry Baryshkov wrote: >>> clock-names: >>> items: >>> + - const: bus >>> - const: iface >>> - - const: ahb >>> + - const: rot >>> + - const: lut >>> - const: core >>> + - const: vsync >> >> All these changes point that device

[PATCH v5 02/31] drm/i915: Don't register backlight when another backlight should be used (v2)

2022-08-25 Thread Hans de Goede
Before this commit when we want userspace to use the acpi_video backlight device we register both the GPU's native backlight device and acpi_video's firmware acpi_video# backlight device. This relies on userspace preferring firmware type backlight devices over native ones. Registering 2 backlight

[PATCH v5 03/31] drm/amdgpu: Don't register backlight when another backlight should be used (v3)

2022-08-25 Thread Hans de Goede
Before this commit when we want userspace to use the acpi_video backlight device we register both the GPU's native backlight device and acpi_video's firmware acpi_video# backlight device. This relies on userspace preferring firmware type backlight devices over native ones. Registering 2 backlight

[PATCH v5 05/31] drm/nouveau: Don't register backlight when another backlight should be used (v2)

2022-08-25 Thread Hans de Goede
Before this commit when we want userspace to use the acpi_video backlight device we register both the GPU's native backlight device and acpi_video's firmware acpi_video# backlight device. This relies on userspace preferring firmware type backlight devices over native ones. Registering 2 backlight

[PATCH v5 01/31] ACPI: video: Add acpi_video_backlight_use_native() helper

2022-08-25 Thread Hans de Goede
ATM on x86 laptops where we want userspace to use the acpi_video backlight device we often register both the GPU's native backlight device and acpi_video's firmware acpi_video# backlight device. This relies on userspace preferring firmware type backlight devices over native ones, but registering 2

[PATCH v5 06/31] ACPI: video: Drop backlight_device_get_by_type() call from acpi_video_get_backlight_type()

2022-08-25 Thread Hans de Goede
All x86/ACPI kms drivers which register native/BACKLIGHT_RAW type backlight devices call acpi_video_backlight_use_native() now. This sets __acpi_video_get_backlight_type()'s internal static native_available flag. This makes the backlight_device_get_by_type(BACKLIGHT_RAW) check unnecessary. Relyin

  1   2   >