vm binding interfaces and parallel with mmap

2022-08-22 Thread Dave Airlie
Hey, I've just been looking at the vm bind type interfaces and wanted to at least document how we think the unmapping API should work. I know I've talked on irc before about this, but wanted to solidify things a bit more around what is required vs what is a nice to have. My main concerns/thoughts

[PATCH] subdev/clk: fix repeated words in comments

2022-08-22 Thread wangjianli
Delete the redundant word 'at'. Signed-off-by: wangjianli --- drivers/gpu/drm/nouveau/nvkm/subdev/clk/gm20b.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/clk/gm20b.c b/drivers/gpu/drm/nouveau/nvkm/subdev/clk/gm20b.c index a139dafffe06

[RFC 08/10] cpuhp: Replace cpumask_any_but(cpu_online_mask, cpu)

2022-08-22 Thread Pingfan Liu
In a kexec quick reboot path, the dying cpus are still on cpu_online_mask. During the teardown of cpu, a subsystem needs to migrate its broker to a real online cpu. This patch replaces cpumask_any_but(cpu_online_mask, cpu) in a teardown procedure with cpumask_not_dying_but(cpu_online_mask, cpu).

Re: vm binding interfaces and parallel with mmap

2022-08-22 Thread Dave Airlie
On Mon, 22 Aug 2022 at 17:05, Dave Airlie wrote: > > Hey, > > I've just been looking at the vm bind type interfaces and wanted to at > least document how we think the unmapping API should work. I know I've > talked on irc before about this, but wanted to solidify things a bit > more around what is

Re: [PATCH v1 00/35] drm: Analog TV Improvements

2022-08-22 Thread Maxime Ripard
Hi, On Sun, Aug 21, 2022 at 06:33:12PM +0200, Noralf Trønnes wrote: > Den 29.07.2022 18.34, skrev Maxime Ripard: > > Hi, > > > > Here's a series aiming at improving the command line named modes support, > > and more importantly how we deal with all the analog TV variants. > > > > The named modes

[PATCH v11 0/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2022-08-22 Thread Liu Ying
Hi, This is the v11 series to introduce i.MX8qm/qxp Display Processing Unit(DPU) DRM support. DPU is comprised of a blit engine for 2D graphics, a display controller and a command sequencer. Outside of DPU, optional prefetch engines can fetch data from memory prior to some DPU fetchunits of bli

[PATCH v11 1/6] dt-bindings: display: imx: Add i.MX8qxp/qm DPU binding

2022-08-22 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Processing Unit. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v10->v11: * No change. v9->v10: * No change. v8->v9: * No change. v7->v8: * No change. v6->v7: * Add Rob's R-b tag back. v5->v6: * Use graph schema. So, drop Rob's R-b tag

[PATCH v11 2/6] dt-bindings: display: imx: Add i.MX8qxp/qm PRG binding

2022-08-22 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Gasket. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v10->v11: * No change. v9->v10: * No change. v8->v9: * No change. v7->v8: * No change. v6->v7: * No change. v5->v6: * No change. v4->v5: * No change. v3->v4: * Im

[PATCH v11 3/6] dt-bindings: display: imx: Add i.MX8qxp/qm DPR channel binding

2022-08-22 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Channel. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v10->v11: * No change. v9->v10: * Add Rob's R-b tag. v8->v9: * Reference 'interrupts-extended' schema instead of 'interrupts' to require an additional interrupt(r_r

[PATCH v11 4/6] drm/atomic: Avoid unused-but-set-variable warning on for_each_old_plane_in_state

2022-08-22 Thread Liu Ying
Artificially use 'plane' and 'old_plane_state' to avoid 'not used' warning. The precedent has already been set by other macros in the same file. Acked-by: Daniel Vetter Signed-off-by: Liu Ying --- v10->v11: * No change. v9->v10: * No change. v8->v9: * No change. v7->v8: * No change. v6->v7:

[PATCH v11 6/6] MAINTAINERS: add maintainer for i.MX8qxp DPU DRM driver

2022-08-22 Thread Liu Ying
Add myself as the maintainer of the i.MX8qxp DPU DRM driver. Acked-by: Laurentiu Palcu Signed-off-by: Liu Ying --- v10->v11: * Rebase upon v6.0-rc1. v9->v10: * Add Laurentiu's A-b tag. v8->v9: * No change. v7->v8: * No change. v6->v7: * No change. v5->v6: * No change. v4->v5: * No change.

Re: vm binding interfaces and parallel with mmap

2022-08-22 Thread Bas Nieuwenhuizen
On Mon, Aug 22, 2022 at 9:28 AM Dave Airlie wrote: > > On Mon, 22 Aug 2022 at 17:05, Dave Airlie wrote: > > > > Hey, > > > > I've just been looking at the vm bind type interfaces and wanted to at > > least document how we think the unmapping API should work. I know I've > > talked on irc before a

Re: [PATCH v1 00/35] drm: Analog TV Improvements

2022-08-22 Thread Mateusz Kwiatkowski
Hi Maxime, I tried testing and reviewing your changes properly over the last weekend, but ultimately ran into this ("flip_done timed out" etc.) issue and was unable to mitigate it, at least so far. This seems to pop up every time I try to change modes in any way (either change the TV norm, or just

Re: [PATCH 3/3] drm: rcar-du: fix DSI enable & disable sequence

2022-08-22 Thread Tomi Valkeinen
Hi, On 19/08/2022 04:34, Laurent Pinchart wrote: Hi Tomi, Thank you for the patch. On Wed, Aug 17, 2022 at 04:28:03PM +0300, Tomi Valkeinen wrote: From: Tomi Valkeinen The rcar crtc depends on the clock provided from the rcar DSI bridge. When the DSI bridge is disabled, the clock is stopped

[syzbot] KASAN: use-after-free Read in udl_get_urb_timeout

2022-08-22 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:5b6a4bf680d6 Add linux-next specific files for 20220818 git tree: linux-next console+strace: https://syzkaller.appspot.com/x/log.txt?x=12341a3d08 kernel config: https://syzkaller.appspot.com/x/.config?x=ead6107a3bbe3c62 dashbo

Re: [PATCH 3/3] drm: rcar-du: fix DSI enable & disable sequence

2022-08-22 Thread Laurent Pinchart
Hi Tomi, On Mon, Aug 22, 2022 at 12:02:06PM +0300, Tomi Valkeinen wrote: > On 19/08/2022 04:34, Laurent Pinchart wrote: > > On Wed, Aug 17, 2022 at 04:28:03PM +0300, Tomi Valkeinen wrote: > >> From: Tomi Valkeinen > >> > >> The rcar crtc depends on the clock provided from the rcar DSI bridge. > >

[PATCH 2/2] drm/i915: Add DSC support to MST path

2022-08-22 Thread Stanislav Lisovskiy
Whenever we are not able to get enough timeslots for required PBN, let's try to allocate those using DSC, just same way as we do for SST. v2: Removed intel_dp_mst_dsc_compute_config and refactored intel_dp_dsc_compute_config to support timeslots as a parameter(Ville Syrjälä) v3: - Rebased

[PATCH 0/2] Add DP MST DSC support to i915

2022-08-22 Thread Stanislav Lisovskiy
Currently we have only DSC support for DP SST. Stanislav Lisovskiy (2): drm: Add missing DP DSC extended capability definitions. drm/i915: Add DSC support to MST path drivers/gpu/drm/i915/display/intel_dp.c | 73 - drivers/gpu/drm/i915/display/intel_dp.h | 17 +++ drivers/g

[PATCH 1/2] drm: Add missing DP DSC extended capability definitions.

2022-08-22 Thread Stanislav Lisovskiy
Adding DP DSC register definitions, we might need for further DSC implementation, supporting MST and DP branch pass-through mode. v2: - Fixed checkpatch comment warning v3: - Removed function which is not yet used(Jani Nikula) Signed-off-by: Stanislav Lisovskiy --- include/drm/display/drm_dp.h

Re: [PATCH v5 3/4] drm/lcdif: Clean up debug prints and comments

2022-08-22 Thread Marek Vasut
On 8/22/22 08:24, Alexander Stein wrote: Hi, [...] --- a/drivers/gpu/drm/mxsfb/lcdif_kms.c +++ b/drivers/gpu/drm/mxsfb/lcdif_kms.c @@ -203,7 +203,7 @@ static void lcdif_crtc_mode_set_nofb(struct lcdif_drm_private *lcdif, DRM_DEV_DEBUG_DRIVER(drm->dev, "Pixel clock: %dkHz (actual: %dkHz)\n", m-

Re: [PATCH v7 1/8] overflow: Move and add few utility macros into overflow

2022-08-22 Thread Jani Nikula
On Wed, 17 Aug 2022, Kees Cook wrote: > On Thu, Aug 18, 2022 at 01:07:29AM +0200, Andi Shyti wrote: >> Hi Kees, >> >> would you mind taking a look at this patch? > > Hi! Thanks for the heads-up! Thanks for your review. This actually reaffirms my belief that we need to get these macros out of i91

Re: [PATCH 0/2] Convert arm,versatile-sysreg to DT schema

2022-08-22 Thread Linus Walleij
On Wed, Aug 10, 2022 at 6:03 PM Rob Herring wrote: > This short series converts the arm,versatile-sysreg binding to DT schema. > The binding is already in use in examples which unsurprisingly needs a > fix with the schema added. Excellent, thanks! Reviewed-by: Linus Walleij I assume you will a

Re: [syzbot] KASAN: use-after-free Read in udl_get_urb_timeout

2022-08-22 Thread Takashi Iwai
On Mon, 22 Aug 2022 11:09:31 +0200, syzbot wrote: > > Hello, > > syzbot found the following issue on: > > HEAD commit:5b6a4bf680d6 Add linux-next specific files for 20220818 > git tree: linux-next > console+strace: https://syzkaller.appspot.com/x/log.txt?x=12341a3d08 > kernel confi

Re: [PATCH 2/3] iommu/dma: Move public interfaces to linux/iommu.h

2022-08-22 Thread Robin Murphy
On 2022-08-22 12:21, Christoph Hellwig wrote: diff --git a/include/linux/iommu.h b/include/linux/iommu.h index 70393fbb57ed..79cb6eb560a8 100644 --- a/include/linux/iommu.h +++ b/include/linux/iommu.h @@ -1059,4 +1059,40 @@ void iommu_debugfs_setup(void); static inline void iommu_debugfs_setup(

[PATCH v2 1/4] drm: rcar-du: dsi: Properly stop video mode TX

2022-08-22 Thread Tomi Valkeinen
From: Tomi Valkeinen The driver does not explicitly stop the video mode transmission when disabling the output. While this doesn't seem to be causing any issues, lets follow the steps described in the documentation and add a rcar_mipi_dsi_stop_video() which stop the video mode transmission. This

[PATCH v2 3/4] drm: rcar-du: fix DSI enable & disable sequence

2022-08-22 Thread Tomi Valkeinen
From: Tomi Valkeinen The rcar crtc depends on the clock provided from the rcar DSI bridge. When the DSI bridge is disabled, the clock is stopped, which causes the crtc disable to timeout. Also, while I have no issue with the enable, the documentation suggests to enable the DSI before the crtc so

[PATCH v2 0/4] drm: rcar-du: DSI fixes

2022-08-22 Thread Tomi Valkeinen
Hi, This is v2 of the third patch in an earlier series ("drm: rcar-du: fix DSI enable & disable sequence"). The first two patches have already been accepted. Changes in v2: - Split the patch into smaller pieces - Modify the pclk enable function names so that they match between LVDS and DSI. - C

[PATCH v2 2/4] drm: rcar-du: dsi: Improve DSI shutdown

2022-08-22 Thread Tomi Valkeinen
From: Tomi Valkeinen Improve the DSI shutdown procedure by clearing various bits that were set while enabling the DSI output. There has been no clear issues caused by these, but it's safer to ensure that the features are disabled at the start of the next DSI enable. Signed-off-by: Tomi Valkeinen

[PATCH v2 4/4] drm: rcar-du: lvds: Rename pclk enable/disable functions

2022-08-22 Thread Tomi Valkeinen
From: Tomi Valkeinen Rename LVDS pclk enable/disable functions to match what we use for DSI. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 4 ++-- drivers/gpu/drm/rcar-du/rcar_lvds.c| 4 ++-- drivers/gpu/drm/rcar-du/rcar_lvds.h| 10 +- 3 files cha

Re: [PATCH v2 1/4] drm: rcar-du: dsi: Properly stop video mode TX

2022-08-22 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Mon, Aug 22, 2022 at 04:05:09PM +0300, Tomi Valkeinen wrote: > From: Tomi Valkeinen > > The driver does not explicitly stop the video mode transmission when > disabling the output. While this doesn't seem to be causing any issues, > lets follow the steps des

Re: [PATCH v2 2/4] drm: rcar-du: dsi: Improve DSI shutdown

2022-08-22 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Mon, Aug 22, 2022 at 04:05:10PM +0300, Tomi Valkeinen wrote: > From: Tomi Valkeinen > > Improve the DSI shutdown procedure by clearing various bits that were > set while enabling the DSI output. There has been no clear issues caused > by these, but it's safe

Re: [PATCH v1 00/35] drm: Analog TV Improvements

2022-08-22 Thread Noralf Trønnes
Den 22.08.2022 09.48, skrev Maxime Ripard: > Hi, > > On Sun, Aug 21, 2022 at 06:33:12PM +0200, Noralf Trønnes wrote: >> Den 29.07.2022 18.34, skrev Maxime Ripard: >>> Hi, >>> >>> Here's a series aiming at improving the command line named modes support, >>> and more importantly how we deal with

Re: [PATCH v2,1/2] soc: mediatek: Add mmsys func to adapt to dpi output for MT8186

2022-08-22 Thread Nícolas F . R . A . Prado
On Mon, Aug 22, 2022 at 08:50:45PM +0800, xinlei.lee wrote: [..] > Hi Nícolas: > > Thanks for your careful review. > I will correct it in the next version: > 1. Modify key nouns in the description; > 2. Modify the label of jitao to Co-developed-by; To be clear, you shouldn't change jitao's signed

RE: [PATCH v2 1/4] drm: rcar-du: dsi: Properly stop video mode TX

2022-08-22 Thread Biju Das
Hi Tomi, Thanks for the patch. > Subject: [PATCH v2 1/4] drm: rcar-du: dsi: Properly stop video mode TX > > From: Tomi Valkeinen > > The driver does not explicitly stop the video mode transmission when > disabling the output. While this doesn't seem to be causing any issues, > lets follow the

Re: [PATCH] drm/panel-edp: add AUO B133UAN02.1 panel entry

2022-08-22 Thread Johan Hovold
On Fri, Jul 22, 2022 at 11:48:40AM +0200, Johan Hovold wrote: > On Mon, Jul 11, 2022 at 09:52:02AM +0200, Johan Hovold wrote: > > Add an eDP panel entry for AUO B133UAN02.1. > > > > Due to lack of documentation, use the delay_200_500_e50 timings like > > some other AUO entries for now. > > > > Si

Re: [PATCH v6 1/6] drm/ttm: Add new callbacks to ttm res mgr

2022-08-22 Thread Christian König
Am 20.08.22 um 09:32 schrieb Arunpravin Paneer Selvam: We are adding two new callbacks to ttm resource manager function to handle intersection and compatibility of placement and resources. v2: move the amdgpu and ttm_range_manager changes to separate patches (Christian) v3: rename "intersec

Re: [PATCH v2 3/4] drm: rcar-du: fix DSI enable & disable sequence

2022-08-22 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Mon, Aug 22, 2022 at 04:05:11PM +0300, Tomi Valkeinen wrote: > From: Tomi Valkeinen > > The rcar crtc depends on the clock provided from the rcar DSI bridge. > When the DSI bridge is disabled, the clock is stopped, which causes the > crtc disable to timeout.

Re: [PATCH v2 2/4] drm: rcar-du: dsi: Improve DSI shutdown

2022-08-22 Thread Tomi Valkeinen
On 22/08/2022 16:20, Laurent Pinchart wrote: Hi Tomi, Thank you for the patch. On Mon, Aug 22, 2022 at 04:05:10PM +0300, Tomi Valkeinen wrote: From: Tomi Valkeinen Improve the DSI shutdown procedure by clearing various bits that were set while enabling the DSI output. There has been no clear

Re: [PATCH v2 4/4] drm: rcar-du: lvds: Rename pclk enable/disable functions

2022-08-22 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Mon, Aug 22, 2022 at 04:05:12PM +0300, Tomi Valkeinen wrote: > From: Tomi Valkeinen > > Rename LVDS pclk enable/disable functions to match what we use for DSI. I'd explain here the rationale for the new names: The DU driver uses the rcar_lvds_clk_enable()

Re: [PATCH 4/5] drm/msm: Use separate ASID for each set of pgtables

2022-08-22 Thread Robin Murphy
On 2022-08-21 19:19, Rob Clark wrote: From: Rob Clark Optimize TLB invalidation by using different ASID for each set of pgtables. There can be scenarios where multiple processes end up with the same ASID (such as >256 processes using the GPU), but this is harmless, it will only result in some

Re: [PATCH v2 4/4] drm: rcar-du: lvds: Rename pclk enable/disable functions

2022-08-22 Thread Tomi Valkeinen
On 22/08/2022 16:52, Laurent Pinchart wrote: Hi Tomi, Thank you for the patch. On Mon, Aug 22, 2022 at 04:05:12PM +0300, Tomi Valkeinen wrote: From: Tomi Valkeinen Rename LVDS pclk enable/disable functions to match what we use for DSI. I'd explain here the rationale for the new names: The

Re: [PATCH v2 1/4] drm: rcar-du: dsi: Properly stop video mode TX

2022-08-22 Thread Tomi Valkeinen
Hi, On 22/08/2022 16:25, Biju Das wrote: Hi Tomi, Thanks for the patch. Subject: [PATCH v2 1/4] drm: rcar-du: dsi: Properly stop video mode TX From: Tomi Valkeinen The driver does not explicitly stop the video mode transmission when disabling the output. While this doesn't seem to be causi

Re: [PATCH v2 2/4] drm: rcar-du: dsi: Improve DSI shutdown

2022-08-22 Thread Laurent Pinchart
On Mon, Aug 22, 2022 at 04:49:02PM +0300, Tomi Valkeinen wrote: > On 22/08/2022 16:20, Laurent Pinchart wrote: > > Hi Tomi, > > > > Thank you for the patch. > > > > On Mon, Aug 22, 2022 at 04:05:10PM +0300, Tomi Valkeinen wrote: > >> From: Tomi Valkeinen > >> > >> Improve the DSI shutdown proced

Re: [PATCH v7 1/8] overflow: Move and add few utility macros into overflow

2022-08-22 Thread Andrzej Hajda
On 18.08.2022 02:12, Kees Cook wrote: On Thu, Aug 18, 2022 at 01:07:29AM +0200, Andi Shyti wrote: Hi Kees, would you mind taking a look at this patch? Hi! Thanks for the heads-up! Thanks, Andi On Tue, Aug 16, 2022 at 06:35:18PM +0900, Gwan-gyeong Mun wrote: It moves overflows_type utilit

Re: [PATCH 2/2] [WIP]: media: Add Synaptics compressed tiled format

2022-08-22 Thread Nicolas Dufresne
Le samedi 20 août 2022 à 08:10 +0800, Hsia-Jun Li a écrit : > > On 8/20/22 03:17, Nicolas Dufresne wrote: > > CAUTION: Email originated externally, do not click links or open > > attachments unless you recognize the sender and know the content is safe. > > > > > > Le vendredi 19 août 2022 à 23:

RE: [PATCH v2 1/4] drm: rcar-du: dsi: Properly stop video mode TX

2022-08-22 Thread Biju Das
Hi, > Subject: Re: [PATCH v2 1/4] drm: rcar-du: dsi: Properly stop video mode > TX > > Hi, > > On 22/08/2022 16:25, Biju Das wrote: > > Hi Tomi, > > > > Thanks for the patch. > > > >> Subject: [PATCH v2 1/4] drm: rcar-du: dsi: Properly stop video mode > >> TX > >> > >> From: Tomi Valkeinen > >>

Re: [PATCH v2 2/4] drm: rcar-du: dsi: Improve DSI shutdown

2022-08-22 Thread Tomi Valkeinen
On 22/08/2022 17:05, Laurent Pinchart wrote: On Mon, Aug 22, 2022 at 04:49:02PM +0300, Tomi Valkeinen wrote: On 22/08/2022 16:20, Laurent Pinchart wrote: Hi Tomi, Thank you for the patch. On Mon, Aug 22, 2022 at 04:05:10PM +0300, Tomi Valkeinen wrote: From: Tomi Valkeinen Improve the DSI s

Re: [Intel-gfx] [PATCH v7 1/8] overflow: Move and add few utility macros into overflow

2022-08-22 Thread Andrzej Hajda
On 22.08.2022 16:05, Andrzej Hajda wrote: On 18.08.2022 02:12, Kees Cook wrote: On Thu, Aug 18, 2022 at 01:07:29AM +0200, Andi Shyti wrote: Hi Kees, would you mind taking a look at this patch? Hi! Thanks for the heads-up! Thanks, Andi On Tue, Aug 16, 2022 at 06:35:18PM +0900, Gwan-gye

Re: [PATCH v2 2/4] drm: rcar-du: dsi: Improve DSI shutdown

2022-08-22 Thread Laurent Pinchart
On Mon, Aug 22, 2022 at 05:19:56PM +0300, Tomi Valkeinen wrote: > On 22/08/2022 17:05, Laurent Pinchart wrote: > > On Mon, Aug 22, 2022 at 04:49:02PM +0300, Tomi Valkeinen wrote: > >> On 22/08/2022 16:20, Laurent Pinchart wrote: > >>> Hi Tomi, > >>> > >>> Thank you for the patch. > >>> > >>> On Mon

[PATCH v3 0/5] drm: rcar-du: DSI fixes

2022-08-22 Thread Tomi Valkeinen
Changes to v2: - Move the LVDS patch to the beginning and improve the patch desc. - Write 0 to registers in rcar_mipi_dsi_shutdown instead of just clearing a bit. - Fix function names in "fix DSI enable & disable sequence" patch desc. - Add "drm: rcar-du: dsi: Fix VCLKSET write" Tomi Tomi Val

[PATCH v3 2/5] drm: rcar-du: dsi: Properly stop video mode TX

2022-08-22 Thread Tomi Valkeinen
From: Tomi Valkeinen The driver does not explicitly stop the video mode transmission when disabling the output. While this doesn't seem to be causing any issues, lets follow the steps described in the documentation and add a rcar_mipi_dsi_stop_video() which stop the video mode transmission. This

[PATCH v3 3/5] drm: rcar-du: dsi: Improve DSI shutdown

2022-08-22 Thread Tomi Valkeinen
From: Tomi Valkeinen Improve the DSI shutdown procedure by clearing various bits that were set while enabling the DSI output. There has been no clear issues caused by these, but it's safer to ensure that the features are disabled at the start of the next DSI enable. Signed-off-by: Tomi Valkeinen

[PATCH v3 5/5] drm: rcar-du: dsi: Fix VCLKSET write

2022-08-22 Thread Tomi Valkeinen
From: Tomi Valkeinen rcar_mipi_dsi_startup() writes correct values to VCLKSET, but as it uses or-operation to add the new values to the current value in the register, it should first make sure the fields are cleared. Do this by using rcar_mipi_dsi_write() to write the VCLKSET_CKEN bit to VCLKSET

[PATCH v3 1/5] drm: rcar-du: lvds: Rename pclk enable/disable functions

2022-08-22 Thread Tomi Valkeinen
From: Tomi Valkeinen The DU driver uses the rcar_lvds_clk_enable() and rcar_lvds_clk_disable() functions enable or disable the pixel clock generated by the LVDS encoder, as it requires that clock for proper DU operation. Rename the functions by replacing "clk" with "pclk" to make it clearer that

Re: [PATCH 4/5] drm/msm: Use separate ASID for each set of pgtables

2022-08-22 Thread Robin Murphy
On 2022-08-22 14:52, Robin Murphy wrote: On 2022-08-21 19:19, Rob Clark wrote: From: Rob Clark Optimize TLB invalidation by using different ASID for each set of pgtables.  There can be scenarios where multiple processes end up with the same ASID (such as >256 processes using the GPU), but this

Re: [PATCH v3 5/5] drm: rcar-du: dsi: Fix VCLKSET write

2022-08-22 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Mon, Aug 22, 2022 at 05:34:01PM +0300, Tomi Valkeinen wrote: > From: Tomi Valkeinen > > rcar_mipi_dsi_startup() writes correct values to VCLKSET, but as it uses > or-operation to add the new values to the current value in the register, > it should first make

[PATCH 2/2] drm/rockchip: dw_hdmi: Add support for 4k@30 resolution

2022-08-22 Thread Sascha Hauer
This adds the PLL/phy settings to support higher resolutions like 4k@30. The values were taken from the Rockchip downstream Kernel. Signed-off-by: Sascha Hauer --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/rockchip/dw_

[PATCH 1/2] drm/rockchip: dw_hdmi: relax mode_valid hook

2022-08-22 Thread Sascha Hauer
The driver checks if the pixel clock of the given mode matches an entry in the mpll config table. The frequencies in the mpll table are meant as a frequency range up to which the entry works, not as a frequency that must match the pixel clock. Return MODE_OK when the pixelclock is smaller than one

[PATCH 0/2] drm/rockchip: dw_hdmi: Add 4k@30 support

2022-08-22 Thread Sascha Hauer
This series adds support for 4k@30 to the rockchip HDMI controller. This has been tested on a rk3568 rock3a board. It should be possible to add 4k@60 support the same way, but it doesn't work for me, so let's add 4k@30 as a first step. Sascha Sascha Hauer (2): drm/rockchip: dw_hdmi: relax mode_

Re: [PATCH] drm/msm/dp: add atomic_check to bridge ops

2022-08-22 Thread Dmitry Baryshkov
On 17/08/2022 21:01, Kuogee Hsieh wrote: DRM commit_tails() will disable downstream crtc/encoder/bridge if both disable crtc is required and crtc->active is set before pushing a new frame downstream. There is a rare case that user space display manager issue an extra screen update immediately fo

Re: [RFC] drm/bridge: adv7533: remove dynamic lane switching from adv7533 bridge

2022-08-22 Thread Dmitry Baryshkov
On 09/08/2022 22:40, Laurent Pinchart wrote: Hi Abhinav, Thank you for the patch. On Mon, Aug 08, 2022 at 05:35:30PM -0700, Abhinav Kumar wrote: adv7533 bridge tries to dynamically switch lanes based on the mode by detaching and attaching the mipi dsi device. This approach is incorrect becaus

Re: [PATCH] drm/msm/dp: add atomic_check to bridge ops

2022-08-22 Thread Abhinav Kumar
Hi Dmitry On 8/22/2022 9:18 AM, Dmitry Baryshkov wrote: On 17/08/2022 21:01, Kuogee Hsieh wrote: DRM commit_tails() will disable downstream crtc/encoder/bridge if both disable crtc is required and crtc->active is set before pushing a new frame downstream. There is a rare case that user space d

Re: [PATCH] drm/msm/dp: add atomic_check to bridge ops

2022-08-22 Thread Dmitry Baryshkov
On 22/08/2022 19:38, Abhinav Kumar wrote: Hi Dmitry On 8/22/2022 9:18 AM, Dmitry Baryshkov wrote: On 17/08/2022 21:01, Kuogee Hsieh wrote: DRM commit_tails() will disable downstream crtc/encoder/bridge if both disable crtc is required and crtc->active is set before pushing a new frame downstre

Re: [PATCH v6 1/4] drm/i915/hpd: postpone HPD cancel work after last user suspension

2022-08-22 Thread Imre Deak
On Fri, Jul 22, 2022 at 02:51:40PM +0200, Andrzej Hajda wrote: > i915->hotplug.dig_port_work can be queued from intel_hpd_irq_handler > called by IRQ handler or by intel_hpd_trigger_irq called from dp_mst. > Since dp_mst is suspended after irq handler uninstall, a cleaner approach > is to cancel hp

Re: [Intel-gfx] [PATCH v6 2/4] drm/i915/fbdev: suspend HPD before fbdev unregistration

2022-08-22 Thread Imre Deak
On Fri, Jul 22, 2022 at 02:51:41PM +0200, Andrzej Hajda wrote: > HPD event after fbdev unregistration can cause registration of deferred > fbdev which will not be unregistered later, causing use-after-free. > To avoid it HPD handling should be suspended before fbdev unregistration. > > It should f

Re: [PATCH v4 2/6] clk: qcom: Allow custom reset ops

2022-08-22 Thread Dmitry Baryshkov
On 19/08/2022 19:40, Akhil P Oommen wrote: Allow soc specific clk drivers to specify a custom reset operation. We will use this in an upcoming patch to allow gpucc driver to specify a differet reset operation for cx_gdsc. Signed-off-by: Akhil P Oommen Reviewed-by: Dmitry Baryshkov -- With

Re: [PATCH v4 3/6] clk: qcom: gdsc: Add a reset op to poll gdsc collapse

2022-08-22 Thread Dmitry Baryshkov
On 19/08/2022 19:40, Akhil P Oommen wrote: Add a reset op compatible function to poll for gdsc collapse. Signed-off-by: Akhil P Oommen Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v4 4/6] clk: qcom: gpucc-sc7280: Add cx collapse reset support

2022-08-22 Thread Dmitry Baryshkov
On 19/08/2022 19:40, Akhil P Oommen wrote: Allow a consumer driver to poll for cx gdsc collapse through Reset framework. Signed-off-by: Akhil P Oommen --- (no changes since v3) Changes in v3: - Convert 'struct qcom_reset_ops cx_gdsc_reset' to 'static const' (Krzysztof) Changes in v2: - Minor

Re: [PATCH] drm/msm: De-open-code some CP_EVENT_WRITE

2022-08-22 Thread Dmitry Baryshkov
On 21/08/2022 18:54, Rob Clark wrote: From: Rob Clark Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

[PATCH] drm/msm/dpu: drop unused variable from dpu_kms_mdp_snapshot()

2022-08-22 Thread Dmitry Baryshkov
Follow up the merge of address fields and drop the variable that became unused after the commit 9403f9a42c88 ("drm/msm/dpu: merge base_off with blk_off in struct dpu_hw_blk_reg_map"). Fixes: 9403f9a42c88 ("drm/msm/dpu: merge base_off with blk_off in struct dpu_hw_blk_reg_map") Signed-off-by: Dmit

[PATCH] drm/msm/dpu: drop unused memory allocation

2022-08-22 Thread Dmitry Baryshkov
Drop the dpu_cfg variable and corresponding kzalloc, which became unused after changing hw catalog to static configuration. Fixes: de7d480f5e8c ("drm/msm/dpu: make dpu hardware catalog static const") Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Dmitry Baryshkov ---

Re: [PATCH v8 2/2] drm/gem: Don't map imported GEMs

2022-08-22 Thread Dmitry Osipenko
On 8/16/22 22:55, Dmitry Osipenko wrote: > On 8/16/22 15:03, Christian König wrote: >> Am 16.08.22 um 13:44 schrieb Dmitry Osipenko: >>> [SNIP] The other complication I noticed is that we don't seem to keep around the fd after importing to a GEM handle.  And I could imagine that doin

Re: [Intel-gfx] [PATCH v6 3/4] drm/i915/display: add hotplug.suspended flag

2022-08-22 Thread Imre Deak
On Fri, Jul 22, 2022 at 02:51:42PM +0200, Andrzej Hajda wrote: > HPD events during driver removal can be generated by hardware and > software frameworks - drm_dp_mst, the former we can avoid by disabling > interrupts, the latter can be triggered by any drm_dp_mst transaction, > and this is too late

Re: [PATCH v6 4/4] drm/i915/fbdev: do not create fbdev if HPD is suspended

2022-08-22 Thread Imre Deak
On Fri, Jul 22, 2022 at 02:51:43PM +0200, Andrzej Hajda wrote: > In case of deferred FB setup core can try to create new > framebuffer. Disallow it if hpd_suspended flag is set. > > Signed-off-by: Andrzej Hajda Reviewed-by: Imre Deak > --- > drivers/gpu/drm/i915/display/intel_fbdev.c | 6

Re: [PATCH] drm/panel-edp: add AUO B133UAN02.1 panel entry

2022-08-22 Thread Doug Anderson
Hi, On Mon, Aug 22, 2022 at 6:35 AM Johan Hovold wrote: > > On Fri, Jul 22, 2022 at 11:48:40AM +0200, Johan Hovold wrote: > > On Mon, Jul 11, 2022 at 09:52:02AM +0200, Johan Hovold wrote: > > > Add an eDP panel entry for AUO B133UAN02.1. > > > > > > Due to lack of documentation, use the delay_200

Re: [PATCH] drm/msm/dp: add atomic_check to bridge ops

2022-08-22 Thread Abhinav Kumar
On 8/22/2022 9:49 AM, Dmitry Baryshkov wrote: On 22/08/2022 19:38, Abhinav Kumar wrote: Hi Dmitry On 8/22/2022 9:18 AM, Dmitry Baryshkov wrote: On 17/08/2022 21:01, Kuogee Hsieh wrote: DRM commit_tails() will disable downstream crtc/encoder/bridge if both disable crtc is required and crtc-

[PATCH] drm/msm/dsi: drop the hpd worker

2022-08-22 Thread Dmitry Baryshkov
It makes no sense to have the HPD worker in the MSM DSI driver anymore. It is only queued from the dsi_host_attach/detach() callbacks, where it plays no useful role. Either way the panel or next bridge will be present and will report it's status directly. Signed-off-by: Dmitry Baryshkov --- driv

Re: [Freedreno] [PATCH v2.5] drm/msm/dsi: switch to DRM_PANEL_BRIDGE

2022-08-22 Thread Dmitry Baryshkov
On 15/07/2022 00:54, Abhinav Kumar wrote: On 7/12/2022 6:22 AM, Dmitry Baryshkov wrote: Currently the DSI driver has two separate paths: one if the next device in a chain is a bridge and another one if the panel is connected directly to the DSI host. Simplify the code path by using panel-bridg

Re: [PATCH] drm/msm/dpu: drop unused memory allocation

2022-08-22 Thread Abhinav Kumar
On 8/22/2022 10:24 AM, Dmitry Baryshkov wrote: Drop the dpu_cfg variable and corresponding kzalloc, which became unused after changing hw catalog to static configuration. Fixes: de7d480f5e8c ("drm/msm/dpu: make dpu hardware catalog static const") Reported-by: kernel test robot Reported-by: D

[PATCH] MAINTAINERS: Add myself as a reviewer for panel-edp.c

2022-08-22 Thread Douglas Anderson
panel-edp changes go through the drm-misc tree (as per the "DRM PANEL DRIVERS" entry in MAINTAINERS), but ever since splitting panel-edp out of panel-simple I've been trying to keep a close eye on it. Make that official by listing me as a reviewer. Signed-off-by: Douglas Anderson --- MAINTAINER

Re: [PATCH] drm/panel-edp: add AUO B133UAN02.1 panel entry

2022-08-22 Thread Doug Anderson
Hi, On Mon, Aug 22, 2022 at 10:33 AM Doug Anderson wrote: > > Hi, > > On Mon, Aug 22, 2022 at 6:35 AM Johan Hovold wrote: > > > > On Fri, Jul 22, 2022 at 11:48:40AM +0200, Johan Hovold wrote: > > > On Mon, Jul 11, 2022 at 09:52:02AM +0200, Johan Hovold wrote: > > > > Add an eDP panel entry for A

Re: [PATCH 3/4] dt-bindings: display/msm/gmu: account for different GMU variants

2022-08-22 Thread Dmitry Baryshkov
On 06/07/2022 18:52, Krzysztof Kozlowski wrote: On 06/07/2022 16:52, Dmitry Baryshkov wrote: Make display/msm/gmu.yaml describe all existing GMU variants rather than just the 630.2 (SDM845) version of it. Signed-off-by: Dmitry Baryshkov --- .../devicetree/bindings/display/msm/gmu.yaml | 166

Re: [PATCH v2] dt-bindings: gpu: arm,mali: restrict opp-table to objects

2022-08-22 Thread Rob Herring
On Thu, 18 Aug 2022 09:17:13 +0300, Krzysztof Kozlowski wrote: > Simple 'opp-table:true' accepts a boolean property as opp-table, so > restrict it to object to properly enforce real OPP table nodes. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v1: > 1. Correct typo in msg. >

Re: [RESEND v6 6/9] drm: vkms: Refactor the plane composer to accept new formats

2022-08-22 Thread Igor Matheus Andrade Torrente
Hi Melissa, On 8/20/22 07:51, Melissa Wen wrote: On 08/19, Igor Torrente wrote: Currently the blend function only accepts XRGB_ and ARGB_ as a color input. This patch refactors all the functions related to the plane composition to overcome this limitation. The pixels blend is done usi

Re: [RESEND v6 2/9] drm: vkms: Rename `vkms_composer` to `vkms_frame_info`

2022-08-22 Thread Igor Matheus Andrade Torrente
Hi Mellisa, On 8/20/22 08:00, Melissa Wen wrote: On 08/19, Igor Torrente wrote: Changes the name of this struct to a more meaningful name. A name that represents better what this struct is about. Composer is the code that do the compositing of the planes. This struct contains information on th

Re: [PATCH] drm/msm/dp: add atomic_check to bridge ops

2022-08-22 Thread Dmitry Baryshkov
On 22/08/2022 20:32, Abhinav Kumar wrote: On 8/22/2022 9:49 AM, Dmitry Baryshkov wrote: On 22/08/2022 19:38, Abhinav Kumar wrote: Hi Dmitry On 8/22/2022 9:18 AM, Dmitry Baryshkov wrote: On 17/08/2022 21:01, Kuogee Hsieh wrote: DRM commit_tails() will disable downstream crtc/encoder/bridge

Re: [RESEND v6 2/9] drm: vkms: Rename `vkms_composer` to `vkms_frame_info`

2022-08-22 Thread Melissa Wen
On 08/22, Igor Matheus Andrade Torrente wrote: > Hi Mellisa, > > On 8/20/22 08:00, Melissa Wen wrote: > > On 08/19, Igor Torrente wrote: > > > Changes the name of this struct to a more meaningful name. > > > A name that represents better what this struct is about. > > > > > > Composer is the code

Re: [PATCH v2 8/9] dt-bindings: msm/dp: add missing properties

2022-08-22 Thread Dmitry Baryshkov
On 12/07/2022 02:16, Rob Herring wrote: On Sun, Jul 10, 2022 at 11:41:32AM +0300, Dmitry Baryshkov wrote: Document missing definitions for opp-table (DP controller OPPs), aux-bus (DP AUX BUS) and data-lanes (DP/eDP lanes mapping) properties. Reviewed-by: Stephen Boyd Signed-off-by: Dmitry Bary

[PATCH] drm/msm/iommu: optimize map/unmap

2022-08-22 Thread Rob Clark
From: Rob Clark Using map_pages/unmap_pages cuts down on the # of pgtable walks needed in the process of finding where to insert/remove an entry. The end result is ~5-10x faster than mapping a single page at a time. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_iommu.c | 91 +++

[PATCH v3 2/3] dt-bindings: msm/dp: add missing properties

2022-08-22 Thread Dmitry Baryshkov
Document missing definitions for opp-table (DP controller OPPs), aux-bus (DP AUX BUS) and data-lanes (DP/eDP lanes mapping) properties. Reviewed-by: Stephen Boyd Acked-by: Krzysztof Kozlowski Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dp-controller.yaml | 12

[PATCH v3 0/3] dt-bindings: msm/dp: cleanup Qualcomm DP and eDP bidndings

2022-08-22 Thread Dmitry Baryshkov
Fix several issues with the DP and eDP bindings on the Qualcomm platforms. While we are at it, fix several small issues with platform files declaring these controllers. Changes since v2: - Fixed commit message for the patch 1 to mention proper commit IDs. - Dropped dts patches which were picked

[PATCH v3 1/3] dt-bindings: msm/dp: mark vdda supplies as deprecated

2022-08-22 Thread Dmitry Baryshkov
The commit 85936d4f3815 ("phy: qcom-qmp: add regulator_set_load to dp phy") moved setting regulator load to the DP PHY driver (QMP). Then, the commit 7516351bebc1 ("drm/msm/dp: delete vdda regulator related functions from eDP/DP controller") removed support for VDDA supplies from the DP controller

[PATCH v3 3/3] dt-bindings: msm/dp: handle DP vs eDP difference

2022-08-22 Thread Dmitry Baryshkov
The #sound-dai-cells property should be used only for DP controllers. It doesn't make sense for eDP, there is no support for audio output. The aux-bus should not be used for DP controllers. Also p1 MMIO region should be used only for DP controllers. Take care of these differences. Reviewed-by: Ro

Re: [PATCH v2 04/11] dt-bindings: display/msm: split qcom, mdss bindings

2022-08-22 Thread Dmitry Baryshkov
On 11/07/2022 14:37, Krzysztof Kozlowski wrote: On 10/07/2022 11:00, Dmitry Baryshkov wrote: Thank you for your patch. There is something to discuss/improve. +required: + - compatible + - reg + - reg-names + - interrupts + - interrupt-controller + - "#interrupt-cells" + - power-domains

Re: [RESEND v6 6/9] drm: vkms: Refactor the plane composer to accept new formats

2022-08-22 Thread Melissa Wen
On 08/22, Igor Matheus Andrade Torrente wrote: > Hi Melissa, > > On 8/20/22 07:51, Melissa Wen wrote: > > On 08/19, Igor Torrente wrote: > > > Currently the blend function only accepts XRGB_ and ARGB_ > > > as a color input. > > > > > > This patch refactors all the functions related to th

Re: [PATCH v2 06/11] dt-bindings: display/msm: move qcom, sc7180-mdss schema to mdss.yaml

2022-08-22 Thread Dmitry Baryshkov
On 11/08/2022 11:25, Krzysztof Kozlowski wrote: On 10/07/2022 12:00, Dmitry Baryshkov wrote: Move schema for qcom,sc7180-mdss from dpu-sc7180.yaml to mdss.yaml so that the dpu file describes only the DPU schema. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dpu-sc7180.yaml

Re: [PATCH v4 5/6] dt-bindings: drm/msm/gpu: Add optional resets

2022-08-22 Thread Rob Herring
On Fri, 19 Aug 2022 22:10:44 +0530, Akhil P Oommen wrote: > Add an optional reference to GPUCC reset which can be used to ensure cx > gdsc collapse during gpu recovery. > > Signed-off-by: Akhil P Oommen > --- > > Changes in v4: > - New patch in v4 > > Documentation/devicetree/bindings/display/

RE: [PATCH v1 1/4] Drivers: hv: Move legacy Hyper-V PCI video device's ids to linux/hyperv.h

2022-08-22 Thread Michael Kelley (LINUX)
From: Vitaly Kuznetsov Sent: Thursday, August 18, 2022 7:25 AM > > There are already two places in kernel with PCI_VENDOR_ID_MICROSOFT/ > PCI_DEVICE_ID_HYPERV_VIDEO and there's a need to use these from core > Vmbus code. Move the defines to a common header. > > No functional change. > > Signed

RE: [PATCH v1 2/4] drm/hyperv: Don't forget to put PCI device when removing conflicting FB fails

2022-08-22 Thread Michael Kelley (LINUX)
From: Vitaly Kuznetsov Sent: Thursday, August 18, 2022 7:25 AM > > When drm_aperture_remove_conflicting_pci_framebuffers() fails, 'pdev' > needs to be released with pci_dev_put(). > > Fixes: 76c56a5affeb ("drm/hyperv: Add DRM driver for hyperv synthetic video > device") > Signed-off-by: Vitaly

Re: [PATCH v7 1/8] overflow: Move and add few utility macros into overflow

2022-08-22 Thread Gwan-gyeong Mun
On 8/22/22 11:05 PM, Andrzej Hajda wrote: On 18.08.2022 02:12, Kees Cook wrote: On Thu, Aug 18, 2022 at 01:07:29AM +0200, Andi Shyti wrote: Hi Kees, would you mind taking a look at this patch? Hi! Thanks for the heads-up! Thanks, Andi On Tue, Aug 16, 2022 at 06:35:18PM +0900, Gwan-gye

  1   2   >