[PATCH AUTOSEL 5.15 16/69] drm/radeon: integer overflow in radeon_mode_dumb_create()

2022-08-11 Thread Sasha Levin
From: Xiaohui Zhang [ Upstream commit feb54650bae25f2a2adfc493e3e254e7c27a3fba ] Similar to the handling of amdgpu_mode_dumb_create in commit 54ef0b5461c0 ("drm/amdgpu: integer overflow in amdgpu_mode_dumb_create()"), we thought a patch might be needed here as well. args->size is a u64. arg->p

[PATCH AUTOSEL 5.15 15/69] drm/amd/display: Fix dpp dto for disabled pipes

2022-08-11 Thread Sasha Levin
From: Duncan Ma [ Upstream commit d4965c53b95d7533dfc2309d2fc25838bd33220e ] [Why] When switching from 1 pipe to 4to1 mpc combine, DppDtoClk aren't enabled for the disabled pipes pior to programming the pipes. Upon optimizing bandwidth, DppDto are enabled causing intermittent underflow. [How] U

[PATCH AUTOSEL 5.15 17/69] drm/radeon: Initialize fences array entries in radeon_sa_bo_next_hole

2022-08-11 Thread Sasha Levin
From: Xiaohui Zhang [ Upstream commit 0381ac3ca2e727d4dfb7264d9416a8ba6bb6c18b ] Similar to the handling of amdgpu_sa_bo_next_hole in commit 6a15f3ff19a8 ("drm/amdgpu: Initialize fences array entries in amdgpu_sa_bo_next_hole"), we thought a patch might be needed here as well. The entries were

[PATCH AUTOSEL 5.15 18/69] udmabuf: Set the DMA mask for the udmabuf device (v2)

2022-08-11 Thread Sasha Levin
From: Vivek Kasireddy [ Upstream commit 9e9fa6a9198b767b00f48160800128e83a038f9f ] If the DMA mask is not set explicitly, the following warning occurs when the userspace tries to access the dma-buf via the CPU as reported by syzbot here: WARNING: CPU: 1 PID: 3595 at kernel/dma/mapping.c:188 __d

[PATCH AUTOSEL 5.15 20/69] drm/amd/display: Fix monitor flash issue

2022-08-11 Thread Sasha Levin
From: Shah Dharati [ Upstream commit b840b64bc8ed3fc46f6d6aa7f97c43862a33bea5 ] [Why & How] For a some specific monitors, when connected on boot or hot plug, monitor flash for 1/2 seconds can happen during first HDCP query operation. Ading some delay in the init sequence for these monitors fixes

[PATCH AUTOSEL 5.15 30/69] drm/bridge/tc358775: Fix DSI clock division for vsync delay calculation

2022-08-11 Thread Sasha Levin
From: Jiri Vanek [ Upstream commit 993a87917c2af59efb0ee1ce43c878ca8790ba1c ] Use the same PCLK divide option (divide DSI clock to generate pixel clock) which is set to LVDS Configuration Register (LVCFG) also for a VSync delay calculation. Without this change an auxiliary variable could underfl

[PATCH AUTOSEL 5.15 36/69] amdgpu/pm: Fix possible array out-of-bounds if SCLK levels != 2

2022-08-11 Thread Sasha Levin
From: Darren Powell [ Upstream commit ceb180361e3851007547c55035cd1de03f108f75 ] [v2] simplified fix after Lijo's feedback removed clocks.num_levels from calculation of loop count removed unsafe accesses to shim table freq_values retained corner case output only min,now if clocks.num_le

[PATCH AUTOSEL 5.15 41/69] drm/amdgpu/display/dc: Fix null pointer exception

2022-08-11 Thread Sasha Levin
From: Rahul Kumar [ Upstream commit 1c4dae3e4639540fb567e570cc56a3c292afb6fe ] We observed hard hang due to NULL derefrence This issue is seen after running system all the time after two or three days struct dc *dc = plane_state->ctx->dc; Randomly in long run we found plane_state or plane_state

[PATCH AUTOSEL 5.15 43/69] drm/amdgpu: skip whole ras bad page framework on sriov

2022-08-11 Thread Sasha Levin
From: "Stanley.Yang" [ Upstream commit e0e146d5567317d6ba7d0169bed55d1d9ea05a61 ] It should not init whole ras bad page framework on sriov guest side due to it is handled on host side. Signed-off-by: Stanley.Yang Reviewed-by: Hawking Zhang Reviewed-by: Tao Zhou Signed-off-by: Alex Deucher S

[PATCH AUTOSEL 5.15 44/69] drm/amd/display: Guard against ddc_pin being NULL for AUX

2022-08-11 Thread Sasha Levin
From: Nicholas Kazlauskas [ Upstream commit bc19909f19fdc8253d720d11c948935786fbfa08 ] [Why] In the case where we don't support DMUB aux but we have DPIA links in the configuration we might try to message AUX using the legacy path - where DDC pin is NULL. This causes a NULL pointer dereference.

[PATCH AUTOSEL 5.15 46/69] drm/msm/gem: Drop obj lock in msm_gem_free_object()

2022-08-11 Thread Sasha Levin
From: Rob Clark [ Upstream commit a414fe3a2129b490e1e9b8ad66f0364f4f961887 ] The only reason we grabbed the lock was to satisfy a bunch of places that WARN_ON() if called without the lock held. But this angers lockdep which doesn't realize no one else can be holding the lock by the time we end

[PATCH AUTOSEL 5.15 50/69] drm/nouveau/nvkm: use list_add_tail() when building object tree

2022-08-11 Thread Sasha Levin
From: Ben Skeggs [ Upstream commit 61c1f340bc809a1ca1e3c8794207a91cde1a7c78 ] Fixes resume from hibernate failing on (at least) TU102, where cursor channel init failed due to being performed before the core channel. Not solid idea why suspend-to-ram worked, but, presumably HW being in an entire

[PATCH AUTOSEL 5.15 60/69] drm/amdkfd: Correct mmu_notifier_get failure handling

2022-08-11 Thread Sasha Levin
From: Philip Yang [ Upstream commit 0593ad215359d51514c1e6c81ce28ea598efed6b ] If process has signal pending, mmu_notifier_get_locked fails and calls ops->free_notifier, kfd_process_free_notifier will schedule kfd_process_wq_release as process refcount is 1, but process structure is already free

[PATCH AUTOSEL 5.10 01/46] drm/r128: Fix undefined behavior due to shift overflowing the constant

2022-08-11 Thread Sasha Levin
From: Borislav Petkov [ Upstream commit 6556551f8848f98eff356c8aacae42c8dd65b2df ] Fix: drivers/gpu/drm/r128/r128_cce.c: In function ‘r128_do_init_cce’: drivers/gpu/drm/r128/r128_cce.c:417:2: error: case label does not reduce to an integer constant case R128_PM4_64BM_64VCBM_64INDBM:

[PATCH AUTOSEL 5.10 05/46] drm/panfrost: Handle HW_ISSUE_TTRX_2968_TTRX_3162

2022-08-11 Thread Sasha Levin
From: Alyssa Rosenzweig [ Upstream commit 382435709516c1a7dc3843872792abf95e786c83 ] Add handling for the HW_ISSUE_TTRX_2968_TTRX_3162 quirk. Logic ported from kbase. kbase lists this workaround as used on Mali-G57. Reviewed-by: Steven Price Signed-off-by: Alyssa Rosenzweig Link: https://pat

[PATCH AUTOSEL 5.10 06/46] drm/panfrost: Don't set L2_MMU_CONFIG quirks

2022-08-11 Thread Sasha Levin
From: Alyssa Rosenzweig [ Upstream commit d8e53d8a4e0ae842ef5e83e0dfb0796980f710cf ] L2_MMU_CONFIG is an implementation-defined register. Different Mali GPUs define slightly different MAX_READS and MAX_WRITES fields, which throttle outstanding reads and writes when set to non-zero values. When l

[PATCH AUTOSEL 5.10 04/46] drm/nouveau: clear output poll workers before nouveau_fbcon_destroy()

2022-08-11 Thread Sasha Levin
From: Mark Menzynski [ Upstream commit 6b03816f869529393b37d03e5d75b68f7365a7a4 ] Resources needed for output poll workers are destroyed in nouveau_fbcon_fini() before output poll workers are cleared in nouveau_display_fini(). This means there is a time between fbcon_fini() and display_fini(), w

[PATCH AUTOSEL 5.10 11/46] drm/radeon: Initialize fences array entries in radeon_sa_bo_next_hole

2022-08-11 Thread Sasha Levin
From: Xiaohui Zhang [ Upstream commit 0381ac3ca2e727d4dfb7264d9416a8ba6bb6c18b ] Similar to the handling of amdgpu_sa_bo_next_hole in commit 6a15f3ff19a8 ("drm/amdgpu: Initialize fences array entries in amdgpu_sa_bo_next_hole"), we thought a patch might be needed here as well. The entries were

[PATCH AUTOSEL 5.10 10/46] drm/radeon: integer overflow in radeon_mode_dumb_create()

2022-08-11 Thread Sasha Levin
From: Xiaohui Zhang [ Upstream commit feb54650bae25f2a2adfc493e3e254e7c27a3fba ] Similar to the handling of amdgpu_mode_dumb_create in commit 54ef0b5461c0 ("drm/amdgpu: integer overflow in amdgpu_mode_dumb_create()"), we thought a patch might be needed here as well. args->size is a u64. arg->p

[PATCH AUTOSEL 5.10 08/46] drm/amd/display: Detect dpcd_rev when hotplug mst monitor

2022-08-11 Thread Sasha Levin
From: Wayne Lin [ Upstream commit 453b0016a054df0f442fda8a145b97a33816cab9 ] [Why] Once mst topology is constructed, later on new connected monitors are reported to source by CSN message. Within CSN, there is no carried info of DPCD_REV comparing to LINK_ADDRESS reply. As the result, we might le

[PATCH AUTOSEL 5.10 09/46] drm/amd/display: Fix dpp dto for disabled pipes

2022-08-11 Thread Sasha Levin
From: Duncan Ma [ Upstream commit d4965c53b95d7533dfc2309d2fc25838bd33220e ] [Why] When switching from 1 pipe to 4to1 mpc combine, DppDtoClk aren't enabled for the disabled pipes pior to programming the pipes. Upon optimizing bandwidth, DppDto are enabled causing intermittent underflow. [How] U

[PATCH AUTOSEL 5.10 12/46] udmabuf: Set the DMA mask for the udmabuf device (v2)

2022-08-11 Thread Sasha Levin
From: Vivek Kasireddy [ Upstream commit 9e9fa6a9198b767b00f48160800128e83a038f9f ] If the DMA mask is not set explicitly, the following warning occurs when the userspace tries to access the dma-buf via the CPU as reported by syzbot here: WARNING: CPU: 1 PID: 3595 at kernel/dma/mapping.c:188 __d

[PATCH AUTOSEL 5.10 14/46] drm/amd/display: Fix monitor flash issue

2022-08-11 Thread Sasha Levin
From: Shah Dharati [ Upstream commit b840b64bc8ed3fc46f6d6aa7f97c43862a33bea5 ] [Why & How] For a some specific monitors, when connected on boot or hot plug, monitor flash for 1/2 seconds can happen during first HDCP query operation. Ading some delay in the init sequence for these monitors fixes

[PATCH AUTOSEL 5.10 22/46] drm/bridge/tc358775: Fix DSI clock division for vsync delay calculation

2022-08-11 Thread Sasha Levin
From: Jiri Vanek [ Upstream commit 993a87917c2af59efb0ee1ce43c878ca8790ba1c ] Use the same PCLK divide option (divide DSI clock to generate pixel clock) which is set to LVDS Configuration Register (LVCFG) also for a VSync delay calculation. Without this change an auxiliary variable could underfl

[PATCH AUTOSEL 5.10 31/46] drm/nouveau/nvkm: use list_add_tail() when building object tree

2022-08-11 Thread Sasha Levin
From: Ben Skeggs [ Upstream commit 61c1f340bc809a1ca1e3c8794207a91cde1a7c78 ] Fixes resume from hibernate failing on (at least) TU102, where cursor channel init failed due to being performed before the core channel. Not solid idea why suspend-to-ram worked, but, presumably HW being in an entire

[PATCH AUTOSEL 5.10 29/46] drm/amdgpu/display/dc: Fix null pointer exception

2022-08-11 Thread Sasha Levin
From: Rahul Kumar [ Upstream commit 1c4dae3e4639540fb567e570cc56a3c292afb6fe ] We observed hard hang due to NULL derefrence This issue is seen after running system all the time after two or three days struct dc *dc = plane_state->ctx->dc; Randomly in long run we found plane_state or plane_state

[PATCH AUTOSEL 5.4 04/25] drm/nouveau: clear output poll workers before nouveau_fbcon_destroy()

2022-08-11 Thread Sasha Levin
From: Mark Menzynski [ Upstream commit 6b03816f869529393b37d03e5d75b68f7365a7a4 ] Resources needed for output poll workers are destroyed in nouveau_fbcon_fini() before output poll workers are cleared in nouveau_display_fini(). This means there is a time between fbcon_fini() and display_fini(), w

[PATCH AUTOSEL 5.4 05/25] drm/panfrost: Don't set L2_MMU_CONFIG quirks

2022-08-11 Thread Sasha Levin
From: Alyssa Rosenzweig [ Upstream commit d8e53d8a4e0ae842ef5e83e0dfb0796980f710cf ] L2_MMU_CONFIG is an implementation-defined register. Different Mali GPUs define slightly different MAX_READS and MAX_WRITES fields, which throttle outstanding reads and writes when set to non-zero values. When l

[PATCH AUTOSEL 5.4 01/25] drm/r128: Fix undefined behavior due to shift overflowing the constant

2022-08-11 Thread Sasha Levin
From: Borislav Petkov [ Upstream commit 6556551f8848f98eff356c8aacae42c8dd65b2df ] Fix: drivers/gpu/drm/r128/r128_cce.c: In function ‘r128_do_init_cce’: drivers/gpu/drm/r128/r128_cce.c:417:2: error: case label does not reduce to an integer constant case R128_PM4_64BM_64VCBM_64INDBM:

[PATCH AUTOSEL 5.4 07/25] drm/radeon: integer overflow in radeon_mode_dumb_create()

2022-08-11 Thread Sasha Levin
From: Xiaohui Zhang [ Upstream commit feb54650bae25f2a2adfc493e3e254e7c27a3fba ] Similar to the handling of amdgpu_mode_dumb_create in commit 54ef0b5461c0 ("drm/amdgpu: integer overflow in amdgpu_mode_dumb_create()"), we thought a patch might be needed here as well. args->size is a u64. arg->p

[PATCH AUTOSEL 5.4 08/25] drm/radeon: Initialize fences array entries in radeon_sa_bo_next_hole

2022-08-11 Thread Sasha Levin
From: Xiaohui Zhang [ Upstream commit 0381ac3ca2e727d4dfb7264d9416a8ba6bb6c18b ] Similar to the handling of amdgpu_sa_bo_next_hole in commit 6a15f3ff19a8 ("drm/amdgpu: Initialize fences array entries in amdgpu_sa_bo_next_hole"), we thought a patch might be needed here as well. The entries were

[PATCH AUTOSEL 5.4 09/25] udmabuf: Set the DMA mask for the udmabuf device (v2)

2022-08-11 Thread Sasha Levin
From: Vivek Kasireddy [ Upstream commit 9e9fa6a9198b767b00f48160800128e83a038f9f ] If the DMA mask is not set explicitly, the following warning occurs when the userspace tries to access the dma-buf via the CPU as reported by syzbot here: WARNING: CPU: 1 PID: 3595 at kernel/dma/mapping.c:188 __d

[PATCH AUTOSEL 5.4 16/25] drm/nouveau/nvkm: use list_add_tail() when building object tree

2022-08-11 Thread Sasha Levin
From: Ben Skeggs [ Upstream commit 61c1f340bc809a1ca1e3c8794207a91cde1a7c78 ] Fixes resume from hibernate failing on (at least) TU102, where cursor channel init failed due to being performed before the core channel. Not solid idea why suspend-to-ram worked, but, presumably HW being in an entire

[PATCH AUTOSEL 4.19 01/14] drm/r128: Fix undefined behavior due to shift overflowing the constant

2022-08-11 Thread Sasha Levin
From: Borislav Petkov [ Upstream commit 6556551f8848f98eff356c8aacae42c8dd65b2df ] Fix: drivers/gpu/drm/r128/r128_cce.c: In function ‘r128_do_init_cce’: drivers/gpu/drm/r128/r128_cce.c:417:2: error: case label does not reduce to an integer constant case R128_PM4_64BM_64VCBM_64INDBM:

[PATCH AUTOSEL 4.19 02/14] drm/radeon: integer overflow in radeon_mode_dumb_create()

2022-08-11 Thread Sasha Levin
From: Xiaohui Zhang [ Upstream commit feb54650bae25f2a2adfc493e3e254e7c27a3fba ] Similar to the handling of amdgpu_mode_dumb_create in commit 54ef0b5461c0 ("drm/amdgpu: integer overflow in amdgpu_mode_dumb_create()"), we thought a patch might be needed here as well. args->size is a u64. arg->p

[PATCH AUTOSEL 4.19 03/14] drm/radeon: Initialize fences array entries in radeon_sa_bo_next_hole

2022-08-11 Thread Sasha Levin
From: Xiaohui Zhang [ Upstream commit 0381ac3ca2e727d4dfb7264d9416a8ba6bb6c18b ] Similar to the handling of amdgpu_sa_bo_next_hole in commit 6a15f3ff19a8 ("drm/amdgpu: Initialize fences array entries in amdgpu_sa_bo_next_hole"), we thought a patch might be needed here as well. The entries were

[PATCH AUTOSEL 4.19 09/14] drm/nouveau/nvkm: use list_add_tail() when building object tree

2022-08-11 Thread Sasha Levin
From: Ben Skeggs [ Upstream commit 61c1f340bc809a1ca1e3c8794207a91cde1a7c78 ] Fixes resume from hibernate failing on (at least) TU102, where cursor channel init failed due to being performed before the core channel. Not solid idea why suspend-to-ram worked, but, presumably HW being in an entire

[PATCH AUTOSEL 4.14 01/14] drm/r128: Fix undefined behavior due to shift overflowing the constant

2022-08-11 Thread Sasha Levin
From: Borislav Petkov [ Upstream commit 6556551f8848f98eff356c8aacae42c8dd65b2df ] Fix: drivers/gpu/drm/r128/r128_cce.c: In function ‘r128_do_init_cce’: drivers/gpu/drm/r128/r128_cce.c:417:2: error: case label does not reduce to an integer constant case R128_PM4_64BM_64VCBM_64INDBM:

[PATCH AUTOSEL 4.14 03/14] drm/radeon: Initialize fences array entries in radeon_sa_bo_next_hole

2022-08-11 Thread Sasha Levin
From: Xiaohui Zhang [ Upstream commit 0381ac3ca2e727d4dfb7264d9416a8ba6bb6c18b ] Similar to the handling of amdgpu_sa_bo_next_hole in commit 6a15f3ff19a8 ("drm/amdgpu: Initialize fences array entries in amdgpu_sa_bo_next_hole"), we thought a patch might be needed here as well. The entries were

[PATCH AUTOSEL 4.14 02/14] drm/radeon: integer overflow in radeon_mode_dumb_create()

2022-08-11 Thread Sasha Levin
From: Xiaohui Zhang [ Upstream commit feb54650bae25f2a2adfc493e3e254e7c27a3fba ] Similar to the handling of amdgpu_mode_dumb_create in commit 54ef0b5461c0 ("drm/amdgpu: integer overflow in amdgpu_mode_dumb_create()"), we thought a patch might be needed here as well. args->size is a u64. arg->p

[PATCH AUTOSEL 4.14 09/14] drm/nouveau/nvkm: use list_add_tail() when building object tree

2022-08-11 Thread Sasha Levin
From: Ben Skeggs [ Upstream commit 61c1f340bc809a1ca1e3c8794207a91cde1a7c78 ] Fixes resume from hibernate failing on (at least) TU102, where cursor channel init failed due to being performed before the core channel. Not solid idea why suspend-to-ram worked, but, presumably HW being in an entire

Re: [PATCH v3 01/10] drm/fourcc: Add drm_format_info_bpp() helper

2022-08-11 Thread Daniel Vetter
On Thu, Aug 11, 2022 at 09:59:39AM +0200, Geert Uytterhoeven wrote: > Hi Daniel, > > On Wed, Aug 10, 2022 at 5:59 PM Daniel Vetter wrote: > > On Fri, Jul 08, 2022 at 08:20:46PM +0200, Geert Uytterhoeven wrote: > > > Add a helper to retrieve the actual number of bits per pixel for a > > > plane, t

[PATCH AUTOSEL 4.9 01/12] drm/r128: Fix undefined behavior due to shift overflowing the constant

2022-08-11 Thread Sasha Levin
From: Borislav Petkov [ Upstream commit 6556551f8848f98eff356c8aacae42c8dd65b2df ] Fix: drivers/gpu/drm/r128/r128_cce.c: In function ‘r128_do_init_cce’: drivers/gpu/drm/r128/r128_cce.c:417:2: error: case label does not reduce to an integer constant case R128_PM4_64BM_64VCBM_64INDBM:

[PATCH AUTOSEL 4.9 02/12] drm/radeon: Initialize fences array entries in radeon_sa_bo_next_hole

2022-08-11 Thread Sasha Levin
From: Xiaohui Zhang [ Upstream commit 0381ac3ca2e727d4dfb7264d9416a8ba6bb6c18b ] Similar to the handling of amdgpu_sa_bo_next_hole in commit 6a15f3ff19a8 ("drm/amdgpu: Initialize fences array entries in amdgpu_sa_bo_next_hole"), we thought a patch might be needed here as well. The entries were

Re: [PATCH] drm:pl111: Add of_node_put() when breaking out of for_each_available_child_of_node()

2022-08-11 Thread Daniel Vetter
On Wed, Aug 10, 2022 at 01:35:36PM -0600, Rob Herring wrote: > On Wed, Aug 10, 2022 at 10:37 AM Daniel Vetter wrote: > > > > On Mon, Jul 11, 2022 at 09:15:50PM +0800, Liang He wrote: > > > The reference 'child' in the iteration of > > > for_each_available_child_of_node() > > > is only escaped out

Re: [PATCH 2/2] drm/virtio: kms: use drm managed resources

2022-08-11 Thread Daniel Vetter
On Thu, Jul 14, 2022 at 03:00:28PM +0200, Danilo Krummrich wrote: > Allocate driver structures with drm managed resource allocators in order > to cleanup/simplify the drm driver .release callback. > > Signed-off-by: Danilo Krummrich On both patches: Reviewed-by: Daniel Vetter I'm assuming you

Re: [Intel-gfx] [PATCH 1/3] drm: Use original src rect while initializing damage iterator

2022-08-11 Thread Daniel Vetter
On Fri, Jul 15, 2022 at 04:49:56PM +0300, Jouni Högander wrote: > drm_plane_state->src might be modified by the driver. This is done > e.g. in i915 driver when there is bigger framebuffer than the plane > and there is some offset within framebuffer. I915 driver calculates > separate offset and adju

[PATCH] drm/amd/display: fix DSC related non-x86/PPC64 compilation issue

2022-08-11 Thread Hamza Mahfooz
Need to protect DSC code with CONFIG_DRM_AMD_DC_DCN. Fixes the following build errors on arm64: ERROR: modpost: "dc_dsc_get_policy_for_timing" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! ERROR: modpost: "dc_dsc_compute_bandwidth_range" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! Fixe

Re: [PATCH] drm/amd/display: fix DSC related non-x86/PPC64 compilation issue

2022-08-11 Thread Alex Deucher
On Thu, Aug 11, 2022 at 12:24 PM Hamza Mahfooz wrote: > > Need to protect DSC code with CONFIG_DRM_AMD_DC_DCN. > Fixes the following build errors on arm64: > ERROR: modpost: "dc_dsc_get_policy_for_timing" > [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! > ERROR: modpost: "dc_dsc_compute_bandwi

Re: [PATCH v4 1/7] drm: Move and add a few utility macros into drm util header

2022-08-11 Thread Daniel Vetter
On Tue, Jul 19, 2022 at 05:04:18PM +0300, Gwan-gyeong Mun wrote: > It moves overflows_type utility macro into drm util header from i915_utils > header. The overflows_type can be used to catch the truncation between data > types. And it adds safe_conversion() macro which performs a type conversion >

Re: [PATCH v3 09/21] drm/scheduler: fix a kernel-doc warning

2022-08-11 Thread Alex Deucher
On Sat, Jul 9, 2022 at 6:08 AM Mauro Carvalho Chehab wrote: > > The dev field was not documented: > > include/drm/gpu_scheduler.h:463: warning: Function parameter or > member 'dev' not described in 'drm_gpu_scheduler' > > Document it. > > Reviewed-by: Alex Deucher > Signed-off-by: Mauro

Re: [PATCH 5/7] drm/plane-helper: Export individual helpers

2022-08-11 Thread Daniel Vetter
On Wed, Jul 20, 2022 at 10:30:56AM +0200, Thomas Zimmermann wrote: > Export the individual plane helpers that make up the plane functions and > align the naming with other helpers. The plane helpers are for non-atomic > modesetting and exporting them will simplify a later conversion of drivers > to

Re: [PATCH 7/7] drm/fsl-dcu: Use drm_plane_helper_destroy()

2022-08-11 Thread Daniel Vetter
On Wed, Jul 20, 2022 at 10:30:58AM +0200, Thomas Zimmermann wrote: > Replace the driver's own function with drm_plane_helper_destroy(). No > functional changes. > > Signed-off-by: Thomas Zimmermann Somewhat aside, but the real fix here is switching over to the drmm versions of this. As long as a

Re: [PATCH v4 00/41] DYNDBG: opt-in class'd debug for modules, use in drm.

2022-08-11 Thread Daniel Vetter
On Wed, Aug 03, 2022 at 04:13:05PM -0400, Jason Baron wrote: > > > On 8/3/22 15:56, jim.cro...@gmail.com wrote: > > On Wed, Jul 20, 2022 at 9:32 AM Jim Cromie wrote: > >> > > > >> Hi Jason, Greg, DRM-folk, > >> > >> This adds 'typed' "class FOO" support to dynamic-debug, where 'typed' > >> mean

build failure of next-20220811 due to b1a63a0b48ad ("drm/amd/display: consider DSC pass-through during mode validation")

2022-08-11 Thread Sudip Mukherjee (Codethink)
Hi All, Not sure if it has been reported, builds of riscv, alpha, s390, arm, arm64, xtensa, mips, csky allmodconfig have failed to build next-20220811 with the error: ERROR: modpost: "dc_dsc_compute_bandwidth_range" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! ERRO

Re: build failure of next-20220811 due to b1a63a0b48ad ("drm/amd/display: consider DSC pass-through during mode validation")

2022-08-11 Thread Alex Deucher
On Thu, Aug 11, 2022 at 1:11 PM Sudip Mukherjee (Codethink) wrote: > > Hi All, > > Not sure if it has been reported, builds of riscv, alpha, s390, arm, > arm64, xtensa, mips, csky allmodconfig have failed to build next-20220811 > with the error: > > ERROR: modpost: "d

Re: [PATCH v2 04/10] drm/simpledrm: Compute framebuffer stride if not set

2022-08-11 Thread Daniel Vetter
On Wed, 27 Jul 2022 at 09:53, Thomas Zimmermann wrote: > > Hi > > Am 25.07.22 um 17:13 schrieb Javier Martinez Canillas: > > Hello Geert, > > > > On 7/21/22 16:46, Geert Uytterhoeven wrote: > >> Hi Thomas, > >> > >> On Wed, Jul 20, 2022 at 4:27 PM Thomas Zimmermann > >> wrote: > >>> Compute the

Re: [PATCH] drm/ast: radeon amdgpu for ast add prime

2022-08-11 Thread kernel test robot
Hi oushixiong, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on drm-intel/for-linux-next linus/master v5.19 next-20220811] [cannot apply to drm-misc/drm-misc-next drm-tip/drm-tip] [If your patch is applied to the wrong

Re: build failure of next-20220811 due to b1a63a0b48ad ("drm/amd/display: consider DSC pass-through during mode validation")

2022-08-11 Thread Sudip Mukherjee
On Thu, Aug 11, 2022 at 6:16 PM Alex Deucher wrote: > > On Thu, Aug 11, 2022 at 1:11 PM Sudip Mukherjee (Codethink) > wrote: > > > > Hi All, > > > > Not sure if it has been reported, builds of riscv, alpha, s390, arm, > > arm64, xtensa, mips, csky allmodco

RE: [PATCH v3 2/3] drm/amdgpu_dm: Rely on split out luminance calculation function

2022-08-11 Thread Deucher, Alexander
[Public] > -Original Message- > From: amd-gfx On Behalf Of Jani > Nikula > Sent: Thursday, August 4, 2022 5:55 AM > To: Jouni Högander ; dri- > de...@lists.freedesktop.org; intel-...@lists.freedesktop.org; amd- > g...@lists.freedesktop.org > Cc: Siqueira, Rodrigo ; Li, Roman > ; Manasi Na

[PATCH v2] drm/amd/display: fix DSC related non-x86/PPC64 compilation issue

2022-08-11 Thread Hamza Mahfooz
Need to protect DSC code with CONFIG_DRM_AMD_DC_DCN. Fixes the following build errors on arm64: ERROR: modpost: "dc_dsc_get_policy_for_timing" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! ERROR: modpost: "dc_dsc_compute_bandwidth_range" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! Fixe

Re: [PATCH 0/2] Add DP MST DSC support to i915

2022-08-11 Thread Navare, Manasi
On Thu, Aug 11, 2022 at 10:33:51AM +0300, Lisovskiy, Stanislav wrote: > On Wed, Aug 10, 2022 at 04:02:08PM -0400, Lyude Paul wrote: > > Btw, what's the plan for this? Figured I'd ask since I noticed this on the > > ML, > > nd I'm now finishing up getting the atomic only MST patches I've been > >

Re: [PATCH v2] drm/amd/display: fix DSC related non-x86/PPC64 compilation issue

2022-08-11 Thread Sudip Mukherjee
On Thu, Aug 11, 2022 at 7:00 PM Hamza Mahfooz wrote: > > Need to protect DSC code with CONFIG_DRM_AMD_DC_DCN. > Fixes the following build errors on arm64: > ERROR: modpost: "dc_dsc_get_policy_for_timing" > [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! > ERROR: modpost: "dc_dsc_compute_bandwid

Re: [PATCH 1/4] drm/probe-helper: Add drm_connector_helper_get_modes_static()

2022-08-11 Thread Thomas Zimmermann
Hi Sam, thanks for the reviews. Am 10.08.22 um 21:21 schrieb Sam Ravnborg: Hi Thomas, On Wed, Aug 10, 2022 at 01:20:50PM +0200, Thomas Zimmermann wrote: Add drm_connector_helper_get_modes_static(), which duplicates a single display mode for a connector. Convert drivers. I like this helper!

Re: [PATCH v2 04/10] drm/simpledrm: Compute framebuffer stride if not set

2022-08-11 Thread Thomas Zimmermann
Hi Daniel Am 11.08.22 um 19:23 schrieb Daniel Vetter: On Wed, 27 Jul 2022 at 09:53, Thomas Zimmermann wrote: Hi Am 25.07.22 um 17:13 schrieb Javier Martinez Canillas: Hello Geert, On 7/21/22 16:46, Geert Uytterhoeven wrote: Hi Thomas, On Wed, Jul 20, 2022 at 4:27 PM Thomas Zimmermann wr

Re: [PATCH v2] drm/amd/display: fix DSC related non-x86/PPC64 compilation issue

2022-08-11 Thread Anders Roxell
On Thu, 11 Aug 2022 at 20:00, Hamza Mahfooz wrote: > > Need to protect DSC code with CONFIG_DRM_AMD_DC_DCN. > Fixes the following build errors on arm64: > ERROR: modpost: "dc_dsc_get_policy_for_timing" > [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! > ERROR: modpost: "dc_dsc_compute_bandwidth

Re: [PATCH v2 04/10] drm/simpledrm: Compute framebuffer stride if not set

2022-08-11 Thread Thomas Zimmermann
Am 11.08.22 um 20:26 schrieb Thomas Zimmermann: Hi Daniel Am 11.08.22 um 19:23 schrieb Daniel Vetter: On Wed, 27 Jul 2022 at 09:53, Thomas Zimmermann wrote: Hi Am 25.07.22 um 17:13 schrieb Javier Martinez Canillas: Hello Geert, On 7/21/22 16:46, Geert Uytterhoeven wrote: Hi Thomas, On

Re: [PATCH v3 01/10] drm/fourcc: Add drm_format_info_bpp() helper

2022-08-11 Thread Sam Ravnborg
Hi Geert, Daniel. On Thu, Aug 11, 2022 at 06:11:40PM +0200, Daniel Vetter wrote: > On Thu, Aug 11, 2022 at 09:59:39AM +0200, Geert Uytterhoeven wrote: > > Hi Daniel, > > > > On Wed, Aug 10, 2022 at 5:59 PM Daniel Vetter wrote: > > > On Fri, Jul 08, 2022 at 08:20:46PM +0200, Geert Uytterhoeven wr

Re: [PATCH 5/7] drm/plane-helper: Export individual helpers

2022-08-11 Thread Thomas Zimmermann
Hi Am 11.08.22 um 18:41 schrieb Daniel Vetter: On Wed, Jul 20, 2022 at 10:30:56AM +0200, Thomas Zimmermann wrote: Export the individual plane helpers that make up the plane functions and align the naming with other helpers. The plane helpers are for non-atomic modesetting and exporting them wil

Re: [PATCH v2] drm/amd/display: fix DSC related non-x86/PPC64 compilation issue

2022-08-11 Thread Alex Deucher
On Thu, Aug 11, 2022 at 2:00 PM Hamza Mahfooz wrote: > > Need to protect DSC code with CONFIG_DRM_AMD_DC_DCN. > Fixes the following build errors on arm64: > ERROR: modpost: "dc_dsc_get_policy_for_timing" > [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! > ERROR: modpost: "dc_dsc_compute_bandwid

Re: [PATCH v3 01/10] drm/fourcc: Add drm_format_info_bpp() helper

2022-08-11 Thread Geert Uytterhoeven
Hi Sam, On Thu, Aug 11, 2022 at 8:29 PM Sam Ravnborg wrote: > On Thu, Aug 11, 2022 at 06:11:40PM +0200, Daniel Vetter wrote: > > On Thu, Aug 11, 2022 at 09:59:39AM +0200, Geert Uytterhoeven wrote: > > > On Wed, Aug 10, 2022 at 5:59 PM Daniel Vetter wrote: > > > > On Fri, Jul 08, 2022 at 08:20:46

Re: [PATCH v4 1/7] drm: Move and add a few utility macros into drm util header

2022-08-11 Thread Jani Nikula
On Thu, 11 Aug 2022, Daniel Vetter wrote: > On Tue, Jul 19, 2022 at 05:04:18PM +0300, Gwan-gyeong Mun wrote: >> It moves overflows_type utility macro into drm util header from i915_utils >> header. The overflows_type can be used to catch the truncation between data >> types. And it adds safe_conve

Re: [PATCH v3 01/10] drm/fourcc: Add drm_format_info_bpp() helper

2022-08-11 Thread Sam Ravnborg
Hi Geert. > > > > > > Yeah I don't think we should describe these with bpp or cpp or anything > > > like that. bpp < 8 makes sense since that's how this has been done since > > > decades, but trying to extend these to funny new formats is a bad idea. > > > This is also why cpp and depth refuse to

Re: [PATCH v3 00/32] OpenChrome DRM for Linux 5.20

2022-08-11 Thread Sam Ravnborg
Hi Kevin, On Mon, Jul 25, 2022 at 04:50:55PM -0700, Kevin Brace wrote: > From: Kevin Brace > > Hi, > > This is my first attempt (this is not a RFC posting) in trying to get > OpenChrome DRM pulled in for Linux 5.20. > I started to work on this seriously around the summer of 2017, so it has > be

Re: [PATCH] drm/ast: radeon amdgpu for ast add prime

2022-08-11 Thread kernel test robot
Hi oushixiong, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on drm-intel/for-linux-next linus/master v5.19 next-20220811] [cannot apply to drm-misc/drm-misc-next drm-tip/drm-tip] [If your patch is applied to the wrong

Re: [PATCH 0/2] Add DP MST DSC support to i915

2022-08-11 Thread Lyude Paul
On Thu, 2022-08-11 at 10:33 +0300, Lisovskiy, Stanislav wrote: > On Wed, Aug 10, 2022 at 04:02:08PM -0400, Lyude Paul wrote: > > Btw, what's the plan for this? Figured I'd ask since I noticed this on the > > ML, > > nd I'm now finishing up getting the atomic only MST patches I've been > > working

[git pull] drm fixes for 6.0-rc1

2022-08-11 Thread Dave Airlie
Hey Linus, not much to squeeze into rc1, just two small fixes, one for core gem and one for shmem-helpers. Dave. drm-next-2022-08-12-1: drm fixes for 6.0-rc1 gem: - Annotate WW context in error paths shmem-helper: - Add missing vunmap in error paths The following changes since commit 5493ee191

[PULL] drm-intel-next-fixes

2022-08-11 Thread Rodrigo Vivi
Hi Dave and Daniel, And here is the right one. And now including all the fixes. Here goes drm-intel-next-fixes-2022-08-11: - disable pci resize on 32-bit systems (Nirmoy) - don't leak the ccs state (Matt) - TLB invalidation fixes (Chris) [now with all fixes of fixes] Thanks, Rodrigo. The follo

[PATCH] drm/i915/guc: clear stalled request after a reset

2022-08-11 Thread Daniele Ceraolo Spurio
If the GuC CTs are full and we need to stall the request submission while waiting for space, we save the stalled request and where the stall occurred; when the CTs have space again we pick up the request submission from where we left off. If a full GT reset occurs, the state of all contexts is cle

[PATCH v3] drm/msm/dp: delete DP_RECOVERED_CLOCK_OUT_EN to fix tps4

2022-08-11 Thread Kuogee Hsieh
Data Symbols scrambled is required for tps4 at link training 2. Therefore SCRAMBLING_DISABLE bit should not be set for tps4 to work. RECOVERED_CLOCK_OUT_EN is for enable simple EYE test for jitter measurement with minimal equipment for embedded applications purpose and is not required to be set du

[PATCH v4] drm/msm/dp: delete DP_RECOVERED_CLOCK_OUT_EN to fix tps4

2022-08-11 Thread Kuogee Hsieh
Data Symbols scrambled is required for tps4 at link training 2. Therefore SCRAMBLING_DISABLE bit should not be set for tps4 to work. RECOVERED_CLOCK_OUT_EN is for enable simple EYE test for jitter measurement with minimal equipment for embedded applications purpose and is not required to be set du

[PATCH v5] drm/msm/dp: delete DP_RECOVERED_CLOCK_OUT_EN to fix tps4

2022-08-11 Thread Kuogee Hsieh
Data Symbols scrambled is required for tps4 at link training 2. Therefore SCRAMBLING_DISABLE bit should not be set for tps4 to work. RECOVERED_CLOCK_OUT_EN is for enable simple EYE test for jitter measurement with minimal equipment for embedded applications purpose and is not required to be set du

Re: build failure of next-20220811 due to b1a63a0b48ad ("drm/amd/display: consider DSC pass-through during mode validation")

2022-08-11 Thread Stephen Rothwell
Hi all, On Thu, 11 Aug 2022 18:10:48 +0100 "Sudip Mukherjee (Codethink)" wrote: > > Not sure if it has been reported, builds of riscv, alpha, s390, arm, > arm64, xtensa, mips, csky allmodconfig have failed to build next-20220811 > with the erro

Re: [PATCH] drm/amdgpu: use native mode for dp aux transfer

2022-08-11 Thread kernel test robot
Hi Zhenneng, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on linus/master v5.19 next-20220811] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to

[PATCH -next 1/4] drm/amd/display: clean up one inconsistent indenting

2022-08-11 Thread Yang Li
The indentation of statements in the same curly bracket should be consistent. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1886 Reported-by: Abaci Robot Signed-off-by: Yang Li --- .../gpu/drm/amd/display/dc/dml/dcn321/dcn321_fpu.c | 13 - 1 file changed, 8 insertions(+), 5

[PATCH -next 3/4] drm/amd/display: clean up one inconsistent indenting

2022-08-11 Thread Yang Li
The indentation of statements in the same curly bracket should be consistent. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1890 Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1891 Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_seq

[PATCH -next 2/4] drm/amd/display: clean up one inconsistent indenting

2022-08-11 Thread Yang Li
1. The indentation of statements in the same curly bracket should be consistent. 2. Variable declarations in the same function should be aligned. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1887 Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1888 Link: https://bugzilla.openanolis.cn

[PATCH -next 4/4] drm/amd/display: clean up one inconsistent indenting

2022-08-11 Thread Yang Li
The indentation of statements in the same curly bracket should be consistent. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1892 Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions

[PATCH] drm/sun4i: dsi: Prevent underflow when computing packet sizes

2022-08-11 Thread Samuel Holland
Currently, the packet overhead is subtracted using unsigned arithmetic. With a short sync pulse, this could underflow and wrap around to near the maximal u16 value. Fix this by using signed subtraction. The call to max() will correctly handle any negative numbers that are produced. Apply the same

[PATCH] drm/amd/display: remove unreachable code

2022-08-11 Thread Jiapeng Chong
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_util_32.c:1658 dml32_TruncToValidBPP() warn: ignoring unreachable code. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1894 Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- .../drm/amd/display/dc/dml/dcn32/displ

Re: [PATCH 1/1] tee: new ioctl to a register tee_shm from a dmabuf file descriptor

2022-08-11 Thread kernel test robot
Hi Olivier, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on drm-tip/drm-tip linus/master v5.19 next-20220811] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [PATCH v4 00/41] DYNDBG: opt-in class'd debug for modules, use in drm.

2022-08-11 Thread Greg KH
On Thu, Aug 11, 2022 at 06:52:40PM +0200, Daniel Vetter wrote: > On Wed, Aug 03, 2022 at 04:13:05PM -0400, Jason Baron wrote: > > > > > > On 8/3/22 15:56, jim.cro...@gmail.com wrote: > > > On Wed, Jul 20, 2022 at 9:32 AM Jim Cromie wrote: > > >> > > > > > >> Hi Jason, Greg, DRM-folk, > > >> > >

<    1   2