Re: [PATCH v2] drm/ttm: Fix dummy res NULL ptr deref bug

2022-07-28 Thread Arunpravin Paneer Selvam
Hi Andre, On 7/27/2022 8:56 PM, André Almeida wrote: Hi Arunpravin, Às 02:30 de 27/07/22, Arunpravin Paneer Selvam escreveu: Check the bo->resource value before accessing the resource mem_type. v2: Fix commit description unwrapped warning [ 40.191227][ T184] general protection fault, pro

Re: [PATCH 04/12] drm/format-helper: Rework XRGB8888-to-RGBG332 conversion

2022-07-28 Thread José Expósito
Hi Thomas, On Wed, Jul 27, 2022 at 01:33:04PM +0200, Thomas Zimmermann wrote: > Update XRGB-to-RGB332 conversion to support struct iosys_map > and convert all users. Although these are single-plane color formats, > the new interface supports multi-plane formats for consistency with > drm_fb_bl

Re: [Intel-gfx] [PATCH v2 06/21] drm/i915/gt: Batch TLB invalidations

2022-07-28 Thread Mauro Carvalho Chehab
On Thu, 28 Jul 2022 08:32:32 +0200 Mauro Carvalho Chehab wrote: > On Wed, 27 Jul 2022 13:56:50 +0100 > Tvrtko Ursulin wrote: > > > > Because vma_invalidate_tlb() basically stores a TLB seqno, but the > > > actual invalidation is deferred to when the pages are unset, at > > > __i915_gem_object_u

Re: [PATCH 12/12] drm/format-helper: Move destination-buffer handling into internal helper

2022-07-28 Thread José Expósito
Hi! On Wed, Jul 27, 2022 at 01:33:12PM +0200, Thomas Zimmermann wrote: > The format-convertion helpers handle several cases for different > values of destination buffer and pitch. Move that code into the > internal helper drm_fb_xfrm() and avoid quite a bit of duplucation. > > Signed-off-by: Thom

Re: [PATCH 04/12] drm/format-helper: Rework XRGB8888-to-RGBG332 conversion

2022-07-28 Thread Thomas Zimmermann
Hi Am 28.07.22 um 09:13 schrieb José Expósito: Hi Thomas, On Wed, Jul 27, 2022 at 01:33:04PM +0200, Thomas Zimmermann wrote: Update XRGB-to-RGB332 conversion to support struct iosys_map and convert all users. Although these are single-plane color formats, the new interface supports multi-p

[PATCH] drm/udl: Restore display mode on resume

2022-07-28 Thread Thomas Zimmermann
Restore the display mode whne resuming from suspend. Currently, the display remains dark. On resume, the CRTC's mode does not change, but the 'active' flag changes to 'true'. Taking this into account when considering a mode switch restores the display mode. The bug is reproducable by using Gnome

Re: [PATCH 12/12] drm/format-helper: Move destination-buffer handling into internal helper

2022-07-28 Thread Thomas Zimmermann
Hi Am 28.07.22 um 09:26 schrieb José Expósito: Hi! On Wed, Jul 27, 2022 at 01:33:12PM +0200, Thomas Zimmermann wrote: The format-convertion helpers handle several cases for different values of destination buffer and pitch. Move that code into the internal helper drm_fb_xfrm() and avoid quite a

Re: [RFC PATCH v3 04/19] KVM: x86: mmu: allow to enable write tracking externally

2022-07-28 Thread Maxim Levitsky
On Mon, 2022-07-25 at 16:08 +, Sean Christopherson wrote: > On Wed, Jul 20, 2022, Maxim Levitsky wrote: > > On Sun, 2022-05-22 at 13:22 +0300, Maxim Levitsky wrote: > > > On Thu, 2022-05-19 at 16:37 +, Sean Christopherson wrote: > > > > On Wed, Apr 27, 2022, Maxim Levitsky wrote: > > > > >

[PATCH] drm/udl: Enable damage clipping

2022-07-28 Thread Thomas Zimmermann
Call drm_plane_enable_fb_damage_clips() and give userspace a chance of minimizing the updated display area. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/udl/udl_modeset.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/udl/udl_modeset.c b/drivers/gpu/drm/udl/udl_mode

[PATCH v3] staging: fbtft: core: set smem_len before fb_deferred_io_init call

2022-07-28 Thread Peter Suti
The fbtft_framebuffer_alloc() calls fb_deferred_io_init() before initializing info->fix.smem_len. It is set to zero by the framebuffer_alloc() function. It will trigger a WARN_ON() at the start of fb_deferred_io_init() and the function will not do anything. Fixes: 856082f021a2 ("fbdev: defio: fi

BUG: unable to handle kernel paging request in imageblit

2022-07-28 Thread Dipanjan Das
Hi, We would like to report the following bug which has been found by our modified version of syzkaller. == description: BUG: unable to handle kernel paging request in imageblit affected file: drivers/gpu/drm/drm_fb_helper.c kernel version: 5.4.

[PATCH] gpu: lontium-lt9611: Fix NULL pointer dereference in lt9611_connector_init()

2022-07-28 Thread Zeng Jingxiang
From: Zeng Jingxiang A NULL check for bridge->encoder shows that it may be NULL, but it already been dereferenced on all paths leading to the check. 812 if (!bridge->encoder) { Dereference the pointer bridge->encoder. 810 drm_connector_attach_encoder(<9611->connector, bridge->encoder);

Re: [PATCH] drm/i915/ttm: don't leak the ccs state

2022-07-28 Thread Matthew Auld
On 28/07/2022 00:16, C, Ramalingam wrote: -Original Message- From: Auld, Matthew Sent: Wednesday, July 27, 2022 10:14 PM To: intel-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org; Thomas Hellström ; C, Ramalingam Subject: [PATCH] drm/i915/ttm: don't leak the ccs state Th

[PULL] drm-intel-fixes

2022-07-28 Thread Tvrtko Ursulin
Hi Dave, Daniel, Just one fix this time round to further improve reliability of resets on execlists platforms in some edge cases. Not sure if there is scope to do one more fixes pull before 5.19 is out so just in case. If it doesn't get pulled we'll send it to stable after release. Regards, Tv

Re: [PATCH v2 4/5] MAINTAINERS: Add entries for Toshiba Visconti DNN image processing accelerator

2022-07-28 Thread Greg KH
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I includ

Re: [PATCH v2 0/5] Add Toshiba Visconti DNN image processing accelerator driver

2022-07-28 Thread Greg KH
On Tue, Jul 26, 2022 at 06:09:50AM +, yuji2.ishik...@toshiba.co.jp wrote: > Hi Greg > > Thank you for your comments. > > > -Original Message- > > From: Greg KH > > Sent: Monday, July 25, 2022 9:47 PM > > To: ishikawa yuji(石川 悠司 ○RDC□AITC○EA開) > > > > Cc: Rob Herring ; Hans Verkuil ;

Re: [PATCH] drm: lcdif: change burst size to 256B

2022-07-28 Thread Marco Felsch
On 22-07-28, Liu Ying wrote: > On Wed, 2022-07-27 at 05:56 +0200, Marco Felsch wrote: > > Hi Marek, Liu, > > > > On 22-07-26, Liu Ying wrote: > > > On Tue, 2022-07-26 at 16:19 +0200, Marek Vasut wrote: > > > > On 7/26/22 11:43, Marco Felsch wrote: > > > > > FIFO underruns are seen if a AXI bus mas

Re: [PATCH] drm: lcdif: change burst size to 256B

2022-07-28 Thread Marco Felsch
On 22-07-28, Marco Felsch wrote: > On 22-07-28, Liu Ying wrote: > > On Wed, 2022-07-27 at 05:56 +0200, Marco Felsch wrote: > > > Hi Marek, Liu, > > > > > > On 22-07-26, Liu Ying wrote: > > > > On Tue, 2022-07-26 at 16:19 +0200, Marek Vasut wrote: > > > > > On 7/26/22 11:43, Marco Felsch wrote: > >

RE: [PATCH] drm/i915/ttm: don't leak the ccs state

2022-07-28 Thread C, Ramalingam
> -Original Message- > From: Auld, Matthew > Sent: Thursday, July 28, 2022 1:38 PM > To: C, Ramalingam ; intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Thomas Hellström > > Subject: Re: [PATCH] drm/i915/ttm: don't leak the ccs state > > On 28/07/2022 00:16, C, Ra

Re: [PATCH 7/8] drm/tidss: Fix clock request value for OLDI videoports

2022-07-28 Thread Tomi Valkeinen
On 19/07/2022 11:08, Aradhya Bhatia wrote: The OLDI TX(es) require a serial clock which is 7 times the pixel clock of the display panel. When the OLDI is enabled in DSS, the pixel clock input of the corresponding videoport gets a divided-by 7 value of the requested clock. For the am625-dss, the

Re: [Intel-gfx] [PATCH v2 06/21] drm/i915/gt: Batch TLB invalidations

2022-07-28 Thread Tvrtko Ursulin
On 28/07/2022 07:32, Mauro Carvalho Chehab wrote: On Wed, 27 Jul 2022 13:56:50 +0100 Tvrtko Ursulin wrote: Because vma_invalidate_tlb() basically stores a TLB seqno, but the actual invalidation is deferred to when the pages are unset, at __i915_gem_object_unset_pages(). So, what happens is:

Re: [PATCH v3 02/13] drm: bridge: Add Samsung DSIM bridge driver

2022-07-28 Thread Adam Ford
On Wed, Jul 20, 2022 at 10:52 AM Jagan Teki wrote: > > Samsung MIPI DSIM controller is common DSI IP that can be used in various > SoCs like Exynos, i.MX8M Mini/Nano. > > In order to access this DSI controller between various platform SoCs, > the ideal way to incorporate this in the drm stack is v

Re: [PATCH 4/8] drm/tidss: Add support for Dual Link LVDS Bus Format

2022-07-28 Thread Tomi Valkeinen
On 19/07/2022 11:08, Aradhya Bhatia wrote: The 2 OLDI TXes in the AM625 SoC can be synced together to output a 2K resolution video. Add support in the driver for the discovery of such a dual mode connection on the OLDI video port, using the values of "ti,oldi-mode" property. Signed-off-by: Arad

Re: [PATCH 1/8] dt-bindings: display: ti,am65x-dss: Add port properties for DSS

2022-07-28 Thread Tomi Valkeinen
On 19/07/2022 11:08, Aradhya Bhatia wrote: Add "ti,oldi-mode" property to indicate the tidss driver the OLDI output mode. The 2 OLDI TXes on am625-dss allow a 3 different types of panel connections with the board. 1. Single Link / Single Mode on OLDI TX 0 OR 1. 2. Single Link / Duplicate Mode

Re: [PATCH v2 00/10] drm: Add driver for PowerPC OF displays

2022-07-28 Thread Michael Ellerman
Thomas Zimmermann writes: > (was: drm: Add driverof PowerPC OF displays) > > PowerPC's Open Firmware offers a simple display buffer for graphics > output. Add ofdrm, a DRM driver for the device. As with the existing > simpledrm driver, the graphics hardware is pre-initialized by the > firmware. Th

Re: [PATCH 8/8] drm/tidss: Enable Dual and Duplicate Modes for OLDI

2022-07-28 Thread Tomi Valkeinen
On 28/07/2022 11:49, Aradhya Bhatia wrote: Hi Tomi, On 28-Jul-22 12:16, Tomi Valkeinen wrote: On 27/07/2022 16:22, Tomi Valkeinen wrote: Hi, On 19/07/2022 11:08, Aradhya Bhatia wrote: The AM625 DSS peripheral supports 2 OLDI TXes which can work to enable 2 duplicated displays of smaller res

Re: [PATCH v6 13/13] video: backlight: mt6370: Add MediaTek MT6370 support

2022-07-28 Thread Daniel Thompson
On Wed, Jul 27, 2022 at 02:24:46PM +0800, ChiaEn Wu wrote: > On Tue, Jul 26, 2022 at 7:59 PM Daniel Thompson > wrote: > > > > > So should we make all 16384 steps of MT6372 available to users? > > > > > > > > Yes. > > > > > > > > > > > > > Does that mean the DTS needs to be modified as well? > > >

Re: [PATCH v2 00/10] drm: Add driver for PowerPC OF displays

2022-07-28 Thread Michal Suchánek
Hello, On Thu, Jul 28, 2022 at 09:13:59PM +1000, Michael Ellerman wrote: > Thomas Zimmermann writes: > > (was: drm: Add driverof PowerPC OF displays) > > > > PowerPC's Open Firmware offers a simple display buffer for graphics > > output. Add ofdrm, a DRM driver for the device. As with the existin

Re: [PATCH 4/8] drm/tidss: Add support for Dual Link LVDS Bus Format

2022-07-28 Thread Tomi Valkeinen
On 28/07/2022 14:03, Tomi Valkeinen wrote: On 19/07/2022 11:08, Aradhya Bhatia wrote: The 2 OLDI TXes in the AM625 SoC can be synced together to output a 2K resolution video. Add support in the driver for the discovery of such a dual mode connection on the OLDI video port, using the values of "

Re: [PATCH] component: try_module_get() to prevent unloading while in use

2022-07-28 Thread Greg KH
On Thu, Jul 28, 2022 at 11:49:57AM +0100, Richard Fitzgerald wrote: > On 26/07/2022 18:28, Greg KH wrote: > > On Tue, Jul 26, 2022 at 11:32:28AM +0100, Richard Fitzgerald wrote: > > > On 25/07/2022 19:09, Greg KH wrote: > > > > On Mon, Jul 25, 2022 at 05:08:59PM +0100, Richard Fitzgerald wrote: > >

Re: [PATCH v3 2/2] drm/tidss: Add support for AM625 DSS

2022-07-28 Thread Tomi Valkeinen
On 27/06/2022 18:12, Aradhya Bhatia wrote: Add support for the DSS IP on TI's new AM625 SoC in the tidss driver. Signed-off-by: Aradhya Bhatia Reviewed-by: Rahul T R --- drivers/gpu/drm/tidss/tidss_dispc.c | 56 - drivers/gpu/drm/tidss/tidss_dispc.h | 2 ++ dri

Re: [PATCH 3/8] drm/tidss: Add support for DSS port properties

2022-07-28 Thread Tomi Valkeinen
On 19/07/2022 11:08, Aradhya Bhatia wrote: Add support to enable and read the dss port properties. The "ti,oldi-mode" property indicates the tidss driver how many OLDI TXes are enabled as well as which mode do they need to be connected in. The "ti,rgb565_to_888" is a special property that force

Re: [Intel-gfx] [PATCH v3 0/6] drm/i915: reduce TLB performance regressions

2022-07-28 Thread Andi Shyti
Hi Mauro, Pushed in drm-intel-gt-next. Thanks, Andi On Wed, Jul 27, 2022 at 02:29:50PM +0200, Mauro Carvalho Chehab wrote: > Doing TLB invalidation cause performance regressions, like: > [424.370996] i915 :00:02.0: [drm] *ERROR* rcs0 TLB invalidation did > not complete in 4ms! > > As

Re: [PATCH v4 1/2] dt-bindings: display: panel: Add Novatek NT35596S panel bindings

2022-07-28 Thread Krzysztof Kozlowski
On 28/07/2022 04:35, Molly Sophia wrote: > Add documentation for "novatek,nt35596s" panel. > > Changes in v4: > - Correct numeric order of the items. > > Changes in v3: > - Embed the documentation into existing one (novatek,nt36672a). This does not go to commit msg, but to changelog after --- W

Re: [PATCH v4 2/2] drm: panel: Add novatek nt35596s panel driver

2022-07-28 Thread Krzysztof Kozlowski
On 28/07/2022 04:35, Molly Sophia wrote: > Novatek NT35596s is a generic DSI IC that drives command and video mode > panels. Add the driver for it. Currently add support for the LCD panel > from JDI connected with this IC, as found on Xiaomi Mi Mix2s phones. > > Changes in v4: > - No change. > >

[PATCH 2/2] drm/i915/gt: document TLB cache invalidation functions

2022-07-28 Thread Mauro Carvalho Chehab
Add a description for the TLB cache invalidation algorithm and for the related kAPI functions. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH 0/2] at: https://lore.kernel.org/all/cover.1659011328.g

[PATCH 1/2] drm/i915/gt: Move TLB invalidation to its own file

2022-07-28 Thread Mauro Carvalho Chehab
From: Chris Wilson Prepare for supporting more TLB invalidation scenarios by moving the current MMIO invalidation to its own file. Signed-off-by: Chris Wilson Cc: Fei Yang Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C

[PATCH 0/2] Move TLB invalidation code for its own file and document it

2022-07-28 Thread Mauro Carvalho Chehab
There are more things to be added to TLB invalidation. Before doing that, move the code to its own file, and add the relevant documentation. Chris Wilson (1): drm/i915/gt: Move TLB invalidation to its own file Mauro Carvalho Chehab (1): drm/i915/gt: document TLB cache invalidation functions

Re: [Intel-gfx] [PATCH v3 0/6] drm/i915: reduce TLB performance regressions

2022-07-28 Thread Mauro Carvalho Chehab
Hi Andi, On Thu, 28 Jul 2022 14:08:11 +0200 Andi Shyti wrote: > Hi Mauro, > > Pushed in drm-intel-gt-next. Thank you! I submitted two additional patches moving the TLB code into its own file, and adding the documentation for it, as agreed during patch 5/6 review: https://patchwork.fr

[PATCH v3 00/14] drm/mgag200: Move model-specific code into separate functions

2022-07-28 Thread Thomas Zimmermann
Mgag200 still mixes model-specific code and generic code in the same functions. Separate it into distinct helpers. As part of this effort, convert the driver from simple-KMS helpers to regular atomic helpers. The latter are way more flexible and can be adapted easily for each hardware model. Test

[PATCH v3 10/14] drm/mgag200: Provide per-device callbacks for BMC synchronization

2022-07-28 Thread Thomas Zimmermann
Move the BMC-related code into its own file and wire it up with device callbacks. While programming a new display mode, G200EW3 and G200WB have to de- synchronize with the BMC. Synchronization is done via VIDRST pins and controlled via VRSTEN and HRSTEN bits. Move the BMC code behind a serviceable

[PATCH v3 09/14] drm/mgag200: Add per-device callbacks

2022-07-28 Thread Thomas Zimmermann
While currently empty, the device callbacks will allow mgag200's modesetting code to interact with the BMC and PIXPLLC. Signed-off-by: Thomas Zimmermann Reviewed-by: Jocelyn Falempe Tested-by: Jocelyn Falempe Acked-by: Sam Ravnborg --- drivers/gpu/drm/mgag200/mgag200_drv.c | 4 +++- drive

[PATCH v3 02/14] drm/mgag200: Move DAC-register setup into model-specific code

2022-07-28 Thread Thomas Zimmermann
Provide an init function for each model's DAC registers. Remove the shared helper. The code for initializing the DAC registers consisted of a large table of default value, plus many exceptions for the various G200 models. Providing a per-model implementation makes if more readable. At some point,

[PATCH v3 13/14] drm/mgag200: Move CRTC atomic_enable to model-specific code

2022-07-28 Thread Thomas Zimmermann
The CRTC atomic_enable helper contains per-model branches for G200ER, G200EV and G200SE devices. Implement a dedicated helper for each of them and remove the branches from the shared helper. Signed-off-by: Thomas Zimmermann Reviewed-by: Jocelyn Falempe Tested-by: Jocelyn Falempe Acked-by: Sam R

[PATCH v3 08/14] drm/mgag200: Set SCROFF in primary-plane code

2022-07-28 Thread Thomas Zimmermann
The SCROFF bit controls reading the primary plane's scanout buffer from video memory. Set it from primary-plane code, instead of CRTC code. v3: * only flip SCROFF when enabling/disabling the plane (Jocelyn) Signed-off-by: Thomas Zimmermann Reviewed-by: Jocelyn Falempe Tested-by: Jocelyn

[PATCH v3 01/14] drm/mgag200: Split mgag200_modeset_init()

2022-07-28 Thread Thomas Zimmermann
Split mgag200_modeset_init() into smaller helpers to initialize the mode_config structure and the pipeline. This will be helpful for transforming this code into per-model functions. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Jocelyn Falempe Tested-by: Jocelyn Falempe A

[PATCH v3 05/14] drm/mgag200: Store primary plane's color format in CRTC state

2022-07-28 Thread Thomas Zimmermann
Store the primary plane's color format in the CRTC state and use it for programming the CRTC's gamma LUTs. Gamma tables (i.e., color management) are provided by the CRTC, but depend in the primary plane's color format. Store the format in the CRTC state and use it. This has not been an issue with

[PATCH v3 03/14] dmr/mgag200: Move ER/EW3 register initialization to per-model code

2022-07-28 Thread Thomas Zimmermann
The register initialization code contains special cases for G200ER and G200EW3 hardware. Move this to per-model code. Signed-off-by: Thomas Zimmermann Reviewed-by: Jocelyn Falempe Tested-by: Jocelyn Falempe Acked-by: Sam Ravnborg --- drivers/gpu/drm/mgag200/mgag200_g200er.c | 2 ++ drivers/g

[PATCH v3 06/14] drm/mgag200: Reorganize before dropping simple-KMS helpers

2022-07-28 Thread Thomas Zimmermann
Move around some modesetting code before dropping simple-KMS helpers. Makes the next patch more readable. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Jocelyn Falempe Tested-by: Jocelyn Falempe Acked-by: Sam Ravnborg --- drivers/gpu/drm/mgag200/mgag200_mode.c | 95

[PATCH v3 07/14] drm/mgag200: Replace simple-KMS with regular atomic helpers

2022-07-28 Thread Thomas Zimmermann
Drop simple-KMS in favor of regular atomic helpers. Makes the code more modular and hence better to adapt to per-model requirements. The simple-KMS helpers provide few extra features, so the patch is mostly about open-coding what simple-KMS does. The simple-KMS helpers do mix up plane and CRTC sta

[PATCH v3 12/14] drm/mgag200: Move mode-config to model-specific code

2022-07-28 Thread Thomas Zimmermann
Move the mode-config code into model-specific code and call the plane/CRTC helpers as needed. This will help with providing per- model implementations of individual helpers. Duplication of the pipeline init function is accepted. Some macros simplify this for shared helpers. v3: * clean up

[PATCH v3 11/14] drm/mgag200: Provide per-device callbacks for PIXPLLC

2022-07-28 Thread Thomas Zimmermann
Move the PIXPLLC code into per-model source files and wire it up with per-model callbacks. No functional changes. The PIXPLLC pixel-clock is part of the CRTC, but really separate hardware that varies with each model of the G200. Move the PIXPLLC code for each model into the per-model source file a

[PATCH v3 14/14] drm/mgag200: Remove type field from struct mga_device

2022-07-28 Thread Thomas Zimmermann
Each model's specific code is located in a separate file. The type field in struct mga_device is no unused. Remove it. Signed-off-by: Thomas Zimmermann Reviewed-by: Jocelyn Falempe Tested-by: Jocelyn Falempe Acked-by: Sam Ravnborg --- drivers/gpu/drm/mgag200/mgag200_drv.c | 17 +++

[PATCH v3 04/14] drm/mgag200: Acquire I/O-register lock in atomic_commit_tail function

2022-07-28 Thread Thomas Zimmermann
Hold I/O-register lock in atomic_commit_tail to protect all pipeline updates at once. Protects against concurrent I/O access in get-modes helper. Complex modesetting operations involve mode changes, plane updates and possibly BMC updates. Make all this atomic wrt to reading display modes via EDID.

RE: [PATCH v3] staging: fbtft: core: set smem_len before fb_deferred_io_init call

2022-07-28 Thread Liu, Chuansheng
Hi Peter, > -Original Message- > From: Peter Suti > Sent: Wednesday, July 27, 2022 3:36 PM > To: Liu, Chuansheng ; dan.carpen...@oracle.com; > Greg Kroah-Hartman ; Thomas Zimmermann > ; Javier Martinez Canillas > Cc: Peter Suti ; dri- > de...@lists.freedesktop.org; linux-fb...@vger.kerne

[PATCH v1 0/7] New DRM driver for Intel VPU

2022-07-28 Thread Jacek Lawrynowicz
Hi, This patchset contains a new Linux* Kernel Driver for Intel® VPUs. VPU stands for Versatile Processing Unit and it is an AI inference accelerator integrated with Intel non-server CPUs starting from 14th generation. VPU enables efficient execution of Deep Learning applications like object dete

[PATCH v1 1/7] drm/vpu: Introduce a new DRM driver for Intel VPU

2022-07-28 Thread Jacek Lawrynowicz
VPU stands for Versatile Processing Unit and it's a CPU-integrated inference accelerator for Computer Vision and Deep Learning applications. The VPU device consist of following componensts: - Buttress - provides CPU to VPU integration, interrupt, frequency and power management. - Memory Ma

[PATCH v1 4/7] drm/vpu: Add IPC driver and JSM messages

2022-07-28 Thread Jacek Lawrynowicz
The IPC driver is used to send and receive messages to/from firmware running on the VPU. The only supported IPC message format is Job Submission Model (JSM) defined in vpu_jsm_api.h header. Signed-off-by: Andrzej Kacprowski Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz --

[PATCH v1 7/7] drm/vpu: Add PM support

2022-07-28 Thread Jacek Lawrynowicz
- Implement cold and warm firmware boot flows - Add hang recovery support - Add runtime power management support Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz --- drivers/gpu/drm/vpu/Makefile | 3 +- drivers/gpu/drm/vpu/vpu_drv.c| 32 ++- drivers/gpu/drm/v

[PATCH v1 5/7] drm/vpu: Implement firmware parsing and booting

2022-07-28 Thread Jacek Lawrynowicz
Read, parse and boot VPU firmware image. Signed-off-by: Andrzej Kacprowski Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz --- drivers/gpu/drm/vpu/Makefile | 1 + drivers/gpu/drm/vpu/vpu_boot_api.h | 222 drivers/gpu/drm/vpu/vpu_drv.c | 123 +++

[PATCH v1 6/7] drm/vpu: Add command buffer submission logic

2022-07-28 Thread Jacek Lawrynowicz
Each of the user contexts has two command queues, one for compute engine and one for the copy engine. Command queues are allocated and registered in the device when the first job (command buffer) is submitted from the user space to the VPU device. The userspace provides a list of GEM buffer object

[PATCH v1 2/7] drm/vpu: Add Intel VPU MMU support

2022-07-28 Thread Jacek Lawrynowicz
VPU Memory Management Unit is based on ARM MMU-600. It allows to create multiple virtual address spaces for the device and map noncontinuous host memory (there is no dedicated memory on the VPU). Address space is implemented as a struct vpu_mmu_context, it has an ID, drm_mm allocator for VPU addre

[PATCH v1 3/7] drm/vpu: Add GEM buffer object management

2022-07-28 Thread Jacek Lawrynowicz
Adds four types of GEM-based BOs for the VPU: - shmem - userptr - internal - prime All types are implemented as struct vpu_bo, based on struct drm_gem_object. VPU address is allocated when buffer is created except for imported prime buffers that allocate it in BO_INFO IOCTL due to missing

Re: [PATCH v3] staging: fbtft: core: set smem_len before fb_deferred_io_init call

2022-07-28 Thread Dan Carpenter
On Thu, Jul 28, 2022 at 12:49:15PM +, Liu, Chuansheng wrote: > Hi Peter, > > > > > The fbtft_framebuffer_alloc() calls fb_deferred_io_init() before > > initializing info->fix.smem_len. It is set to zero by the > > framebuffer_alloc() function. It will trigger a WARN_ON() at the > > start of

Re: [PATCH v4 2/2] drm: panel: Add novatek nt35596s panel driver

2022-07-28 Thread Sam Ravnborg
Hi Krzysztof On Thu, Jul 28, 2022 at 02:17:29PM +0200, Krzysztof Kozlowski wrote: > On 28/07/2022 04:35, Molly Sophia wrote: > > Novatek NT35596s is a generic DSI IC that drives command and video mode > > panels. Add the driver for it. Currently add support for the LCD panel > > from JDI connected

Re: [PATCH] drm/amdgpu: Fix stub fence refcount underflow

2022-07-28 Thread Felix Kuehling
Am 2022-07-27 um 23:52 schrieb Alex Deucher: On Wed, Jul 27, 2022 at 7:08 PM Felix Kuehling wrote: Don't drop the stub fence reference after installing it as a replacement for the eviction fence. dma_resv_replace_fences doesn't take another reference to the fence, so it takes ownership of the r

Re: [PATCH v4 2/2] drm: panel: Add novatek nt35596s panel driver

2022-07-28 Thread Krzysztof Kozlowski
On 28/07/2022 15:50, Sam Ravnborg wrote: > Hi Krzysztof > On Thu, Jul 28, 2022 at 02:17:29PM +0200, Krzysztof Kozlowski wrote: >> On 28/07/2022 04:35, Molly Sophia wrote: >>> Novatek NT35596s is a generic DSI IC that drives command and video mode >>> panels. Add the driver for it. Currently add sup

[PATCH 0/2] Add generic framebuffer support to EFI earlycon driver

2022-07-28 Thread Markuss Broks
Make the EFI earlycon driver be suitable for any linear framebuffers. This should be helpful for early porting of boards with no other means of output, like smartphones/tablets. There seems to be an issue with early_ioremap function on ARM32, but I am unable to find the exact cause. It appears the

[PATCH 1/2] drivers: serial: earlycon: Pass device-tree node

2022-07-28 Thread Markuss Broks
Pass a pointer to device-tree node in case the driver probed from OF. This makes early console drivers able to fetch options from device-tree node properties. Signed-off-by: Markuss Broks --- drivers/tty/serial/earlycon.c | 3 +++ include/linux/serial_core.h | 1 + 2 files changed, 4 insertion

[PATCH 2/2] efi: earlycon: Add support for generic framebuffers and move to fbdev subsystem

2022-07-28 Thread Markuss Broks
Add early console support for generic linear framebuffer devices. This driver supports probing from cmdline early parameters or from the device-tree using information in simple-framebuffer node. The EFI functionality should be retained in whole. The driver was disabled on ARM because of a bug in ea

[PATCH v3 2/6] drm/ttm: Implement intersect/compatible functions

2022-07-28 Thread Arunpravin Paneer Selvam
Implemented a new intersect and compatible callback functions to ttm range manager fetching start offset from drm mm range allocator. Signed-off-by: Christian König Signed-off-by: Arunpravin Paneer Selvam --- drivers/gpu/drm/ttm/ttm_range_manager.c | 33 + 1 file changed

[PATCH v3 3/6] drm/amdgpu: Implement intersect/compatible functions

2022-07-28 Thread Arunpravin Paneer Selvam
Implemented a new intersect and compatible callback function fetching start offset from backend drm buddy allocator. Signed-off-by: Christian König Signed-off-by: Arunpravin Paneer Selvam --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 38 drivers/gpu/drm/amd/amdgpu/amdgpu_vram_

[PATCH v3 1/6] drm/ttm: Add new callbacks to ttm res mgr

2022-07-28 Thread Arunpravin Paneer Selvam
We are adding two new callbacks to ttm resource manager function to handle intersection and compatibility of placement and resources. v2: move the amdgpu and ttm_range_manager changes to separate patches (Christian) v3: rename "intersect" to "intersects" (Matthew) Signed-off-by: Christian Kön

[PATCH v3 4/6] drm/i915: Implement intersect/compatible functions

2022-07-28 Thread Arunpravin Paneer Selvam
Implemented a new intersect and compatible callback function fetching start offset from drm buddy allocator. v2: move the bits that are specific to buddy_man (Matthew) Signed-off-by: Christian König Signed-off-by: Arunpravin Paneer Selvam --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 39

[PATCH v3 6/6] drm/ttm: Switch to using the new res callback

2022-07-28 Thread Arunpravin Paneer Selvam
Apply new intersect and compatible callback instead of having a generic placement range verfications. v2: Added a separate callback for compatiblilty checks (Christian) Signed-off-by: Christian König Signed-off-by: Arunpravin Paneer Selvam --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 45 +

[PATCH v3 5/6] drm/nouveau: Implement intersect/compatible functions

2022-07-28 Thread Arunpravin Paneer Selvam
Implemented a new intersect and compatible callback function fetching the start offset from struct ttm_resource. Signed-off-by: Christian König Signed-off-by: Arunpravin Paneer Selvam --- drivers/gpu/drm/nouveau/nouveau_mem.c | 29 +++ drivers/gpu/drm/nouveau/nouveau_mem

Re: [PATCH v2 4/6] drm/i915: Implement intersect/compatible functions

2022-07-28 Thread Arunpravin Paneer Selvam
Hi Matthew, On 7/26/2022 4:11 PM, Matthew Auld wrote: On 25/07/2022 12:42, Arunpravin Paneer Selvam wrote: Implemented a new intersect and compatible callback function fetching start offset from drm buddy allocator. Signed-off-by: Christian König Signed-off-by: Arunpravin Paneer Selvam ---

Re: [PATCH 1/2] drivers: serial: earlycon: Pass device-tree node

2022-07-28 Thread Greg Kroah-Hartman
On Thu, Jul 28, 2022 at 05:28:18PM +0300, Markuss Broks wrote: > Pass a pointer to device-tree node in case the driver probed from > OF. This makes early console drivers able to fetch options from > device-tree node properties. > > Signed-off-by: Markuss Broks > --- > drivers/tty/serial/earlycon

Re: [PATCH 2/2] efi: earlycon: Add support for generic framebuffers and move to fbdev subsystem

2022-07-28 Thread Greg Kroah-Hartman
On Thu, Jul 28, 2022 at 05:28:19PM +0300, Markuss Broks wrote: > Add early console support for generic linear framebuffer devices. > This driver supports probing from cmdline early parameters > or from the device-tree using information in simple-framebuffer node. > The EFI functionality should be r

Re: [PATCH 00/10] drm: use idr_init_base() over idr_init() if applicable

2022-07-28 Thread Maxime Ripard
On Fri, 1 Jul 2022 20:52:53 +0200, d...@redhat.com wrote: > From: Danilo Krummrich > > This patch series initializes IDRs with idr_init_base(&idr, 1) rather than > idr_init(&idr) in case for the particular IDR no IDs < 1 are ever requested - > this avoids unnecessary tree walks. > > Danilo Krumm

Re: [PATCH 00/10] drm: use idr_init_base() over idr_init() if applicable

2022-07-28 Thread Maxime Ripard
On Thu, Jul 28, 2022 at 04:41:41PM +0200, Maxime Ripard wrote: > On Fri, 1 Jul 2022 20:52:53 +0200, d...@redhat.com wrote: > > From: Danilo Krummrich > > > > This patch series initializes IDRs with idr_init_base(&idr, 1) rather than > > idr_init(&idr) in case for the particular IDR no IDs < 1 are

Re: [PATCH 2/2] efi: earlycon: Add support for generic framebuffers and move to fbdev subsystem

2022-07-28 Thread Markuss Broks
Hi Greg, On 7/28/22 17:39, Greg Kroah-Hartman wrote: On Thu, Jul 28, 2022 at 05:28:19PM +0300, Markuss Broks wrote: Add early console support for generic linear framebuffer devices. This driver supports probing from cmdline early parameters or from the device-tree using information in simple-fr

Re: [PATCH 2/2] efi: earlycon: Add support for generic framebuffers and move to fbdev subsystem

2022-07-28 Thread Arnd Bergmann
On Thu, Jul 28, 2022 at 4:28 PM Markuss Broks wrote: > > Add early console support for generic linear framebuffer devices. > This driver supports probing from cmdline early parameters > or from the device-tree using information in simple-framebuffer node. > The EFI functionality should be retained

Re: [PATCH 00/10] drm: use idr_init_base() over idr_init() if applicable

2022-07-28 Thread Danilo Krummrich
On 7/28/22 16:44, Maxime Ripard wrote: On Thu, Jul 28, 2022 at 04:41:41PM +0200, Maxime Ripard wrote: On Fri, 1 Jul 2022 20:52:53 +0200, d...@redhat.com wrote: From: Danilo Krummrich This patch series initializes IDRs with idr_init_base(&idr, 1) rather than idr_init(&idr) in case for the part

Re: [PATCH 2/2] efi: earlycon: Add support for generic framebuffers and move to fbdev subsystem

2022-07-28 Thread Markuss Broks
Hi Arnd, On 7/28/22 17:48, Arnd Bergmann wrote: On Thu, Jul 28, 2022 at 4:28 PM Markuss Broks wrote: Add early console support for generic linear framebuffer devices. This driver supports probing from cmdline early parameters or from the device-tree using information in simple-framebuffer nod

Re: [PATCH 2/2] efi: earlycon: Add support for generic framebuffers and move to fbdev subsystem

2022-07-28 Thread Greg Kroah-Hartman
On Thu, Jul 28, 2022 at 05:52:04PM +0300, Markuss Broks wrote: > Hi Greg, > > On 7/28/22 17:39, Greg Kroah-Hartman wrote: > > On Thu, Jul 28, 2022 at 05:28:19PM +0300, Markuss Broks wrote: > > > Add early console support for generic linear framebuffer devices. > > > This driver supports probing fr

Re: [PATCH v3 07/14] drm/mgag200: Replace simple-KMS with regular atomic helpers

2022-07-28 Thread Jocelyn Falempe
On 28/07/2022 14:40, Thomas Zimmermann wrote: Drop simple-KMS in favor of regular atomic helpers. Makes the code more modular and hence better to adapt to per-model requirements. The simple-KMS helpers provide few extra features, so the patch is mostly about open-coding what simple-KMS does. The

Re: [PATCH v3 4/6] drm/i915: Implement intersect/compatible functions

2022-07-28 Thread Matthew Auld
On 28/07/2022 15:33, Arunpravin Paneer Selvam wrote: Implemented a new intersect and compatible callback function fetching start offset from drm buddy allocator. v2: move the bits that are specific to buddy_man (Matthew) Signed-off-by: Christian König Signed-off-by: Arunpravin Paneer Selvam -

[Bug 201273] Fatal error during GPU init amdgpu RX560

2022-07-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201273 quirin.blae...@freenet.de changed: What|Removed |Added Status|NEW |RESOLVED Resolution|-

Re: [PATCH v3 6/6] drm/ttm: Switch to using the new res callback

2022-07-28 Thread Matthew Auld
On 28/07/2022 15:33, Arunpravin Paneer Selvam wrote: Apply new intersect and compatible callback instead of having a generic placement range verfications. v2: Added a separate callback for compatiblilty checks (Christian) Signed-off-by: Christian König Signed-off-by: Arunpravin Paneer Sel

Re: [PATCH] drm/tests: Split up test cases in igt_check_drm_format_min_pitch

2022-07-28 Thread Melissa Wen
On 07/17, Maíra Canal wrote: > The igt_check_drm_format_min_pitch() function had a lot of > KUNIT_EXPECT_* calls, all of which ended up allocating and initializing > various test assertion structures on the stack. > > This behavior was producing -Wframe-larger-than warnings on PowerPC, i386, > and

Re: [PATCH 2/2] efi: earlycon: Add support for generic framebuffers and move to fbdev subsystem

2022-07-28 Thread Arnd Bergmann
On Thu, Jul 28, 2022 at 4:57 PM Markuss Broks wrote: > On 7/28/22 17:48, Arnd Bergmann wrote: > > On Thu, Jul 28, 2022 at 4:28 PM Markuss Broks > > wrote: > >> > >> Add early console support for generic linear framebuffer devices. > >> This driver supports probing from cmdline early parameters >

Re: [PATCH] drm/tests: Split up test cases in igt_check_drm_format_min_pitch

2022-07-28 Thread André Almeida
Às 15:43 de 17/07/22, Maíra Canal escreveu: > The igt_check_drm_format_min_pitch() function had a lot of > KUNIT_EXPECT_* calls, all of which ended up allocating and initializing > various test assertion structures on the stack. > > This behavior was producing -Wframe-larger-than warnings on Power

Re: [RFC PATCH] drm/edid: Make 144 Hz not preferred on Sharp LQ140M1JW46

2022-07-28 Thread Abhinav Kumar
Hi Rob and Doug On 7/22/2022 10:36 AM, Rob Clark wrote: On Fri, Jul 22, 2022 at 9:48 AM Doug Anderson wrote: Hi, On Fri, Jul 22, 2022 at 9:37 AM Abhinav Kumar wrote: + sankeerth Hi Doug On 7/21/2022 3:23 PM, Douglas Anderson wrote: The Sharp LQ140M1JW46 panel is on the Qualcomm sc7280

Re: [PATCH 04/12] drm/format-helper: Rework XRGB8888-to-RGBG332 conversion

2022-07-28 Thread José Expósito
On Thu, Jul 28, 2022 at 09:27:52AM +0200, Thomas Zimmermann wrote: > Hi > > Am 28.07.22 um 09:13 schrieb José Expósito: > > Hi Thomas, > > > > On Wed, Jul 27, 2022 at 01:33:04PM +0200, Thomas Zimmermann wrote: > > > Update XRGB-to-RGB332 conversion to support struct iosys_map > > > and conver

Re: [PATCH v3 0/4] KUnit tests for RGB565 conversion

2022-07-28 Thread José Expósito
On Wed, Jul 27, 2022 at 01:09:12AM +0200, José Expósito wrote: > Hello everyone, > > This series is a follow up of the XRGB to RGB332 conversion KUnit > tests. > > As I mentioned in v2 [1] I suspected that the inconsistency handling > the endian might need to be fixed. > Fortunately, Geert Uy

Re: [PATCH 2/2] efi: earlycon: Add support for generic framebuffers and move to fbdev subsystem

2022-07-28 Thread Thomas Zimmermann
Hi Am 28.07.22 um 17:16 schrieb Arnd Bergmann: On Thu, Jul 28, 2022 at 4:57 PM Markuss Broks wrote: On 7/28/22 17:48, Arnd Bergmann wrote: On Thu, Jul 28, 2022 at 4:28 PM Markuss Broks wrote: Add early console support for generic linear framebuffer devices. This driver supports probing fro

Re: [PATCH 3/6] drm/i915/guc: Add selftest for a hung GuC

2022-07-28 Thread John Harrison
On 7/27/2022 19:42, john.c.harri...@intel.com wrote: From: Rahul Kumar Singh Add a test to check that the hangcheck will recover from a submission hang in the GuC. Signed-off-by: Rahul Kumar Singh Signed-off-by: John Harrison --- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 1 + .../

Re: [PATCH 12/12] drm/format-helper: Move destination-buffer handling into internal helper

2022-07-28 Thread José Expósito
On Thu, Jul 28, 2022 at 09:45:27AM +0200, Thomas Zimmermann wrote: > Hi > > Am 28.07.22 um 09:26 schrieb José Expósito: > > Hi! > > > > On Wed, Jul 27, 2022 at 01:33:12PM +0200, Thomas Zimmermann wrote: > > > The format-convertion helpers handle several cases for different > > > values of destina

[PATCH 3/6] drm/i915/guc: Add selftest for a hung GuC

2022-07-28 Thread John . C . Harrison
From: Rahul Kumar Singh Add a test to check that the hangcheck will recover from a submission hang in the GuC. Signed-off-by: Rahul Kumar Singh Signed-off-by: John Harrison --- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 1 + .../drm/i915/gt/uc/selftest_guc_hangcheck.c | 159 +

  1   2   >