Re: [PATCH v2] staging: fbtft: core: set smem_len before fb_deferred_io_init call

2022-07-27 Thread Greg Kroah-Hartman
On Wed, Jul 27, 2022 at 09:07:23AM +0200, Peter Suti wrote: > The fbtft_framebuffer_alloc() calls fb_deferred_io_init() before > initializing info->fix.smem_len. It is set to zero by the > framebuffer_alloc() function. It will trigger a WARN_ON() at the > start of fb_deferred_io_init() and the fu

Re: [PATCH] drm: Fix typo 'the the' in comment

2022-07-27 Thread Linus Walleij
On Thu, Jul 21, 2022 at 8:24 AM Slark Xiao wrote: > Replace 'the the' with 'the' in the comment. > > Signed-off-by: Slark Xiao Patch applied! Yours, Linus Walleij

Re: [PATCH 1/2] dt-bindings: display: panel: sitronix,st7701: Add Densitron DMT028VGHMCMI-1A TFT

2022-07-27 Thread Linus Walleij
On Mon, Jul 25, 2022 at 5:17 PM Marek Vasut wrote: > Add compatible string for Densitron DMT028VGHMCMI-1A TFT matrix. > This is a DSI-attached 480x640 2.83 inch panel. > > Signed-off-by: Marek Vasut > Cc: Guido Günther > Cc: Jagan Teki > Cc: Laurent Pinchart > Cc: Linus Walleij > Cc: Rob Her

Re: [PATCH 2/2] drm/panel/panel-sitronix-st7701: Add Densitron DMT028VGHMCMI-1A TFT

2022-07-27 Thread Linus Walleij
On Mon, Jul 25, 2022 at 5:17 PM Marek Vasut wrote: > Add support for Densitron DMT028VGHMCMI-1A TFT matrix into this driver. > This is a DSI-attached 480x640 2.83 inch panel. > > Signed-off-by: Marek Vasut > Cc: Guido Günther > Cc: Jagan Teki > Cc: Laurent Pinchart > Cc: Linus Walleij > Cc:

Re: [PATCH v15 01/11] dt-bindings: mediatek,dp: Add Display Port binding

2022-07-27 Thread Krzysztof Kozlowski
On 27/07/2022 06:50, Bo-Chen Chen wrote: > From: Markus Schneider-Pargmann > > This controller is present on several mediatek hardware. Currently > mt8195 and mt8395 have this controller without a functional difference, > so only one compatible field is added. > > The controller can have two for

Re: [PATCH v3 26/32] drm/via: Add via_drm.h

2022-07-27 Thread Thomas Zimmermann
Hi Am 26.07.22 um 22:20 schrieb Dave Airlie: On Wed, 27 Jul 2022 at 04:18, Thomas Zimmermann wrote: Hi Am 26.07.22 um 19:41 schrieb Sam Ravnborg: Hi Kevin. On Mon, Jul 25, 2022 at 04:53:53PM -0700, Kevin Brace wrote: From: Kevin Brace Changed the uAPI. Signed-off-by: Kevin Brace It

[PATCH v2] staging: fbtft: core: set smem_len before fb_deferred_io_init call

2022-07-27 Thread Peter Suti
The fbtft_framebuffer_alloc() calls fb_deferred_io_init() before initializing info->fix.smem_len. It is set to zero by the framebuffer_alloc() function. It will trigger a WARN_ON() at the start of fb_deferred_io_init() and the function will not do anything. Fixes: 856082f021a2 ("fbdev: defio: fi

Re: [PATCH v6 11/13] leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support

2022-07-27 Thread ChiaEn Wu
On Tue, Jul 26, 2022 at 8:18 PM Andy Shevchenko wrote: ... > > Just for saving memory space. > > Because these led_classdevs do not be used at the same time. > > Or do you think it would be better to rewrite it as follows? > > -

[PATCH] drm: Fix EDID firmware load on resume

2022-07-27 Thread Matthieu CHARETTE
Loading an EDID using drm.edid_firmware parameter makes resume to fail after firmware cache is being cleaned. This is because edid_load() use a temporary device to request the firmware. This cause the EDID firmware not to be cached from suspend. And, requesting the EDID firmware return an error dur

Re: [PATCH v2 02/10] drm/simpledrm: Inline device-init helpers

2022-07-27 Thread Thomas Zimmermann
Hi Am 25.07.22 um 17:01 schrieb Javier Martinez Canillas: Hello Thomas, On 7/20/22 16:27, Thomas Zimmermann wrote: Inline the helpers for initializing the hardware FB, the memory management and the modesetting into the device-creation function. No functional changes. Could you please elabor

Re: [PATCH v2 04/10] drm/simpledrm: Compute framebuffer stride if not set

2022-07-27 Thread Thomas Zimmermann
Hi Am 25.07.22 um 17:13 schrieb Javier Martinez Canillas: Hello Geert, On 7/21/22 16:46, Geert Uytterhoeven wrote: Hi Thomas, On Wed, Jul 20, 2022 at 4:27 PM Thomas Zimmermann wrote: Compute the framebuffer's scanline stride length if not given by the simplefb data. Signed-off-by: Thomas Z

[PATCH] dma-buf: use struct_size helper instead of kzalloc

2022-07-27 Thread Arvind Yadav
Replace zero-length array allocation with flexible-array member because Dynamic calculations should not be performed for memory allocator due to the risk of them overflowing. So using struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes. Signed-off-by

Re: [PATCH v2 05/10] drm/simpledrm: Convert to atomic helpers

2022-07-27 Thread Thomas Zimmermann
Hi Am 25.07.22 um 17:46 schrieb Javier Martinez Canillas: On 7/20/22 16:27, Thomas Zimmermann wrote: Replace the simple-KMS helpers with the regular atomic helpers. The regular helpers are better architectured and therefore allow for easier code sharing among drivers. No functional changes.

RE: [PATCH 02/10] drm: rcar-du: Add encoder lib support

2022-07-27 Thread Biju Das
Hi, > Subject: Re: [PATCH 02/10] drm: rcar-du: Add encoder lib support > > Hi Biju, > > Thank you for the patch! Perhaps something to improve: > > wget > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross > W=

Re: [PATCH, v2] media: mediatek: vcodec: Add to support VP9 inner racing mode

2022-07-27 Thread AngeloGioacchino Del Regno
Il 27/07/22 08:13, Mingjia Zhang ha scritto: In order to reduce decoder latency, enable VP9 inner racing mode. Send lat trans buffer information to core when trigger lat to work, need not to wait until lat decode done. Signed-off-by: mingjia zhang For MT8195: Tested-by: AngeloGioacchino Del

Re: [PATCH] drm: Fix EDID firmware load on resume

2022-07-27 Thread Takashi Iwai
On Wed, 27 Jul 2022 09:41:52 +0200, Matthieu CHARETTE wrote: > > Loading an EDID using drm.edid_firmware parameter makes resume to fail > after firmware cache is being cleaned. This is because edid_load() use a > temporary device to request the firmware. This cause the EDID firmware > not to be ca

Re: [PATCH v2 06/10] drm/simpledrm: Move some functionality into fwfb helper library

2022-07-27 Thread Thomas Zimmermann
Hi Am 25.07.22 um 18:23 schrieb Javier Martinez Canillas: On 7/20/22 16:27, Thomas Zimmermann wrote: Move some of simpledrm's functionality into a helper library. Other drivers for firmware-provided framebuffers will also need functions to handle fixed modes and color formats, or update the bac

Re: [PATCH v2 09/10] drm/ofdrm: Add per-model device function

2022-07-27 Thread Thomas Zimmermann
Hi Am 26.07.22 um 21:22 schrieb Javier Martinez Canillas: Hello Michal, On 7/26/22 16:40, Michal Suchánek wrote: Hello, On Tue, Jul 26, 2022 at 03:38:37PM +0200, Javier Martinez Canillas wrote: On 7/20/22 16:27, Thomas Zimmermann wrote: Add a per-model device-function structure in preparati

Re: [PATCH v2 10/10] drm/ofdrm: Support color management

2022-07-27 Thread Thomas Zimmermann
Hi Am 26.07.22 um 15:49 schrieb Javier Martinez Canillas: On 7/20/22 16:27, Thomas Zimmermann wrote: Support the CRTC's color-management property and implement each model's palette support. The OF hardware has different methods of setting the palette. The respective code has been taken from fb

Re: [PATCH 2/4] arm64: dts: qcom: add sdm845-google-blueline (Pixel 3)

2022-07-27 Thread Kalle Valo
+ ath10k list Dmitry Baryshkov writes: > On 19/07/2022 00:30, Caleb Connolly wrote: > >> From: Amit Pundir >> >> This adds an initial dts for the Blueline (Pixel 3). Supported >> functionality includes display, Debug UART, UFS, USB-C (peripheral), WiFi, >> Bluetooth and modem. >> >> Bootloader

Re: [PATCH] fbdev: Make registered_fb[] private to fbmem.c

2022-07-27 Thread Thomas Zimmermann
Hi Am 27.07.22 um 06:08 schrieb Helge Deller: On 7/26/22 09:22, Helge Deller wrote: On 7/25/22 09:54, Javier Martinez Canillas wrote: From: Daniel Vetter No driver access this anymore, except for the olpc dcon fbdev driver but that has been marked as broken anyways by commit de0952f267ff ("s

[BUG] video: fbdev: arkfb: Found a divide-by-zero bug which may cause DoS

2022-07-27 Thread Zheyu Ma
Hello, I found a bug in the arkfb driver in the latest kernel, which may cause DoS. The reason for this bug is that the user controls some input to ioctl, making 'mode' 0x7 on line 704, which causes hdiv = 1, hmul = 2, and if the pixclock is controlled to be 1, it will cause a division error in t

Re: [PATCH v2 02/10] drm/simpledrm: Inline device-init helpers

2022-07-27 Thread Javier Martinez Canillas
Hello Thomas, On 7/27/22 09:50, Thomas Zimmermann wrote: > Hi > > Am 25.07.22 um 17:01 schrieb Javier Martinez Canillas: >> Hello Thomas, >> >> On 7/20/22 16:27, Thomas Zimmermann wrote: >>> Inline the helpers for initializing the hardware FB, the memory >>> management and the modesetting into th

Re: [PATCH v15 03/11] drm/edid: Add cea_sad helpers for freq/length

2022-07-27 Thread AngeloGioacchino Del Regno
Il 27/07/22 06:50, Bo-Chen Chen ha scritto: From: Guillaume Ranquet This patch adds two helper functions that extract the frequency and word length from a struct cea_sad. For these helper functions new defines are added that help translate the 'freq' and 'byte2' fields into real numbers. Sign

Re: [PATCH v15 04/11] video/hdmi: Add audio_infoframe packing for DP

2022-07-27 Thread AngeloGioacchino Del Regno
Il 27/07/22 06:50, Bo-Chen Chen ha scritto: From: Markus Schneider-Pargmann Similar to HDMI, DP uses audio infoframes as well which are structured very similar to the HDMI ones. This patch adds a helper function to pack the HDMI audio infoframe for DP, called hdmi_audio_infoframe_pack_for_dp()

Re: [PATCH v15 05/11] drm/mediatek: Add MT8195 Embedded DisplayPort driver

2022-07-27 Thread AngeloGioacchino Del Regno
Il 27/07/22 06:50, Bo-Chen Chen ha scritto: From: Markus Schneider-Pargmann This patch adds a embedded displayport driver for the MediaTek mt8195 SoC. It supports the MT8195, the embedded DisplayPort units. It offers DisplayPort 1.4 with up to 4 lanes. The driver creates a child device for th

Re: [PATCH v15 06/11] drm/mediatek: Add MT8195 External DisplayPort support

2022-07-27 Thread AngeloGioacchino Del Regno
Il 27/07/22 06:50, Bo-Chen Chen ha scritto: From: Guillaume Ranquet This patch adds External DisplayPort support to the mt8195 eDP driver. Signed-off-by: Guillaume Ranquet Signed-off-by: Bo-Chen Chen Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v2 06/10] drm/simpledrm: Move some functionality into fwfb helper library

2022-07-27 Thread Javier Martinez Canillas
On 7/27/22 10:24, Thomas Zimmermann wrote: > Hi > > Am 25.07.22 um 18:23 schrieb Javier Martinez Canillas: >> On 7/20/22 16:27, Thomas Zimmermann wrote: >>> Move some of simpledrm's functionality into a helper library. Other >>> drivers for firmware-provided framebuffers will also need functions >

Re: [PATCH v15 07/11] drm/mediatek: Add retry to prevent misjudgment for sink devices

2022-07-27 Thread AngeloGioacchino Del Regno
Il 27/07/22 06:50, Bo-Chen Chen ha scritto: For some DP dungles, we need to train more than onece to confirm that we don't misjudge the status of sink device. Please fix the typos in your commit title and description. title: misjudgment -> misjudgement desc: dungles->dongles; onece->once Sig

Re: [PATCH v2 10/10] drm/ofdrm: Support color management

2022-07-27 Thread Javier Martinez Canillas
On 7/27/22 10:41, Thomas Zimmermann wrote: [...] >> >>> +static void __iomem *ofdrm_mach64_cmap_ioremap(struct ofdrm_device *odev, >>> + struct device_node *of_node, >>> + u64 fb_base) >>> +{ >>> + struct drm_devi

Re: [PATCH v6 11/13] leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support

2022-07-27 Thread Andy Shevchenko
On Wed, Jul 27, 2022 at 9:37 AM ChiaEn Wu wrote: > On Tue, Jul 26, 2022 at 8:18 PM Andy Shevchenko > wrote: > > ... > > > > Just for saving memory space. > > > Because these led_classdevs do not be used at the same time. > > > Or do you think it would be better to rewrite it as follows? > > > ---

Re: [PATCH v3 1/2] dt-bindings: display: panel: Add Novatek NT35596S panel bindings

2022-07-27 Thread Krzysztof Kozlowski
On 26/07/2022 12:15, Molly Sophia wrote: > Add documentation for "novatek,nt35596s" panel. > > Changes in v3: > - Embed the documentation into existing one (novatek,nt36672a). > > Signed-off-by: Molly Sophia > --- > .../display/panel/novatek,nt36672a.yaml | 20 --- > 1 fil

Re: [Intel-gfx] [PATCH v5 1/7] drm: Move and add a few utility macros into drm util header

2022-07-27 Thread Andi Shyti
Hi, On Mon, Jul 25, 2022 at 12:25:22PM +0300, Gwan-gyeong Mun wrote: > It moves overflows_type utility macro into drm util header from i915_utils > header. The overflows_type can be used to catch the truncation between data > types. And it adds safe_conversion() macro which performs a type convers

Re: [PATCH] drm: lcdif: change burst size to 256B

2022-07-27 Thread Marek Vasut
On 7/27/22 05:56, Marco Felsch wrote: Hi Marek, Liu, Hi, On 22-07-26, Liu Ying wrote: On Tue, 2022-07-26 at 16:19 +0200, Marek Vasut wrote: On 7/26/22 11:43, Marco Felsch wrote: FIFO underruns are seen if a AXI bus master with a higher priority do a lot of memory access. Increase the burst

Re: [PATCH 2/4] arm64: dts: qcom: add sdm845-google-blueline (Pixel 3)

2022-07-27 Thread Amit Pundir
n Tue, 19 Jul 2022 at 03:43, Dmitry Baryshkov wrote: > > On 19/07/2022 00:30, Caleb Connolly wrote: > > From: Amit Pundir > > > > This adds an initial dts for the Blueline (Pixel 3). Supported > > functionality includes display, Debug UART, UFS, USB-C (peripheral), WiFi, > > Bluetooth and modem.

[PATCH 01/12] drm/format-helper: Provide drm_fb_blit()

2022-07-27 Thread Thomas Zimmermann
Provide drm_fb_blit() that works with struct iosys_map. Update all users of drm_fb_blit_toio(), which required a destination buffer in I/O memory. The new function's interface works with multi-plane color formats, although the implementation only supports a single plane for now. Signed-off-by: Tho

[PATCH 00/12] drm/format-helper: Move to struct iosys_map

2022-07-27 Thread Thomas Zimmermann
Change format-conversion helpers to use struct iosys_map for source and destination buffers. Update all users. Also prepare interface for multi-plane color formats. The format-conversion helpers mostly used to convert to I/O memory or system memory. To actual memory type depended on the usecase. W

[PATCH 02/12] drm/format-helper: Merge drm_fb_memcpy() and drm_fb_memcpy_toio()

2022-07-27 Thread Thomas Zimmermann
Merge drm_fb_memcpy() and drm_fb_memcpy() into drm_fb_memcpy() that uses struct iosys_map for buffers. The new function also supports multi-plane color formats. Convert all users of the original helpers. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_format_helper.c | 77 ++

[PATCH 04/12] drm/format-helper: Rework XRGB8888-to-RGBG332 conversion

2022-07-27 Thread Thomas Zimmermann
Update XRGB-to-RGB332 conversion to support struct iosys_map and convert all users. Although these are single-plane color formats, the new interface supports multi-plane formats for consistency with drm_fb_blit(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_format_helper.c

[PATCH 05/12] drm/format-helper: Rework XRGB8888-to-RGBG565 conversion

2022-07-27 Thread Thomas Zimmermann
Update XRGB-to-RGB565 conversion to support struct iosys_map and convert all users. Although these are single-plane color formats, the new interface supports multi-plane formats for consistency with drm_fb_blit(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_format_helper.c | 59

[PATCH 03/12] drm/format-helper: Convert drm_fb_swab() to struct iosys_map

2022-07-27 Thread Thomas Zimmermann
Convert drm_fb_swab() to use struct iosys_map() and convert users. The new interface supports multi-plane color formats. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_format_helper.c | 38 + drivers/gpu/drm/drm_mipi_dbi.c | 2 +- drivers/gpu/drm/gud/g

[PATCH 07/12] drm/format-helper: Rework RGB565-to-XRGB8888 conversion

2022-07-27 Thread Thomas Zimmermann
Update RGB565-to-XRGB conversion to support struct iosys_map and convert all users. Although these are single-plane color formats, the new interface supports multi-plane formats for consistency with drm_fb_blit(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_format_helper.c | 25

[PATCH 06/12] drm/format-helper: Rework XRGB8888-to-RGB888 conversion

2022-07-27 Thread Thomas Zimmermann
Update XRGB-to-RGB888 conversion to support struct iosys_map and convert all users. Although these are single-plane color formats, the new interface supports multi-plane formats for consistency with drm_fb_blit(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_format_helper.c | 48

[PATCH 11/12] drm/format-helper: Rework XRGB8888-to-MONO conversion

2022-07-27 Thread Thomas Zimmermann
Update XRGB-to-MONO conversion to support struct iosys_map and convert all users. Although these are single-plane color formats, the new interface supports multi-plane formats for consistency with drm_fb_blit(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_format_helper.c | 28 ++

[PATCH 08/12] drm/format-helper: Rework RGB888-to-XRGB8888 conversion

2022-07-27 Thread Thomas Zimmermann
Update RGB888-to-XRGB conversion to support struct iosys_map and convert all users. Although these are single-plane color formats, the new interface supports multi-plane formats for consistency with drm_fb_blit(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_format_helper.c | 25

[PATCH 12/12] drm/format-helper: Move destination-buffer handling into internal helper

2022-07-27 Thread Thomas Zimmermann
The format-convertion helpers handle several cases for different values of destination buffer and pitch. Move that code into the internal helper drm_fb_xfrm() and avoid quite a bit of duplucation. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_format_helper.c | 169 +++-

[PATCH 10/12] drm/format-helper: Rework XRGB8888-to-GRAY8 conversion

2022-07-27 Thread Thomas Zimmermann
Update XRGB-to-GRAY8 conversion to support struct iosys_map and convert all users. Although these are single-plane color formats, the new interface supports multi-plane formats for consistency with drm_fb_blit(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_format_helper.c | 25 +

[PATCH 09/12] drm/format-helper: Rework XRGB8888-to-XRGB2101010 conversion

2022-07-27 Thread Thomas Zimmermann
Update XRGB-to-XRGB2101010 conversion to support struct iosys_map and convert all users. Although these are single-plane color formats, the new interface supports multi-plane formats for consistency with drm_fb_blit(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_format_helper.c

Re: [Intel-gfx] [PATCH v2 06/21] drm/i915/gt: Batch TLB invalidations

2022-07-27 Thread Mauro Carvalho Chehab
On Wed, 20 Jul 2022 11:49:59 +0100 Tvrtko Ursulin wrote: > On 20/07/2022 08:13, Mauro Carvalho Chehab wrote: > > On Mon, 18 Jul 2022 14:52:05 +0100 > > Tvrtko Ursulin wrote: > > > >> > >> On 14/07/2022 13:06, Mauro Carvalho Chehab wrote: > >>> From: Chris Wilson > >>> > >>> Invalidate TLB

Re: [PATCH] drm/tests: Split up test cases in igt_check_drm_format_min_pitch

2022-07-27 Thread Maíra Canal
Hi all, Friendly ping: is someone available to take this, please? Best Regards, - Maíra Canal On 7/17/22 15:43, Maíra Canal wrote: > The igt_check_drm_format_min_pitch() function had a lot of > KUNIT_EXPECT_* calls, all of which ended up allocating and initializing > various test assertion struc

[PATCH v3 4/6] drm/i915/gt: Skip TLB invalidations once wedged

2022-07-27 Thread Mauro Carvalho Chehab
From: Chris Wilson Skip all further TLB invalidations once the device is wedged and had been reset, as, on such cases, it can no longer process instructions on the GPU and the user no longer has access to the TLB's in each engine. So, an attempt to do a TLB cache invalidation will produce a time

[PATCH v3 1/6] drm/i915/gt: Ignore TLB invalidations on idle engines

2022-07-27 Thread Mauro Carvalho Chehab
From: Chris Wilson Check if the device is powered down prior to any engine activity, as, on such cases, all the TLBs were already invalidated, so an explicit TLB invalidation is not needed, thus reducing the performance regression impact due to it. This becomes more significant with GuC, as it c

[PATCH v3 2/6] drm/i915/gt: document with_intel_gt_pm_if_awake()

2022-07-27 Thread Mauro Carvalho Chehab
Add a kernel-doc markup to document this new macro. Reviewed-by: Tvrtko Ursulin Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 0/6] at: https://lore.kernel.org/all/cover.1658924372.git.mche...@

[PATCH v3 3/6] drm/i915/gt: Invalidate TLB of the OA unit at TLB invalidations

2022-07-27 Thread Mauro Carvalho Chehab
From: Chris Wilson Ensure that the TLB of the OA unit is also invalidated on gen12 HW, as just invalidating the TLB of an engine is not enough. Cc: sta...@vger.kernel.org Fixes: 7938d61591d3 ("drm/i915: Flush TLBs before releasing backing store") Signed-off-by: Chris Wilson Cc: Fei Yang Review

[PATCH v3 5/6] drm/i915/gt: Batch TLB invalidations

2022-07-27 Thread Mauro Carvalho Chehab
From: Chris Wilson Invalidate TLB in batches, in order to reduce performance regressions. Currently, every caller performs a full barrier around a TLB invalidation, ignoring all other invalidations that may have already removed their PTEs from the cache. As this is a synchronous operation and ca

[PATCH v3 6/6] drm/i915/gt: describe the new tlb parameter at i915_vma_resource

2022-07-27 Thread Mauro Carvalho Chehab
TLB cache invalidation can happen on two different situations: 1. synchronously, at __vma_put_pages(); 2. asynchronously. On the first case, TLB cache invalidation happens inside __vma_put_pages(). So, no need to do it later on. However, on the second case, the pages will keep in memory until __

[PATCH v3 0/6] drm/i915: reduce TLB performance regressions

2022-07-27 Thread Mauro Carvalho Chehab
Doing TLB invalidation cause performance regressions, like: [424.370996] i915 :00:02.0: [drm] *ERROR* rcs0 TLB invalidation did not complete in 4ms! As reported at: https://gitlab.freedesktop.org/drm/intel/-/issues/6424 as this is an expensive operation. So, reduce the need o

Re: [Intel-gfx] [PATCH v2 06/21] drm/i915/gt: Batch TLB invalidations

2022-07-27 Thread Tvrtko Ursulin
On 27/07/2022 12:48, Mauro Carvalho Chehab wrote: On Wed, 20 Jul 2022 11:49:59 +0100 Tvrtko Ursulin wrote: On 20/07/2022 08:13, Mauro Carvalho Chehab wrote: On Mon, 18 Jul 2022 14:52:05 +0100 Tvrtko Ursulin wrote: On 14/07/2022 13:06, Mauro Carvalho Chehab wrote: From: Chris Wilson

Re: [PATCH 8/8] drm/tidss: Enable Dual and Duplicate Modes for OLDI

2022-07-27 Thread Tomi Valkeinen
Hi, On 19/07/2022 11:08, Aradhya Bhatia wrote: The AM625 DSS peripheral supports 2 OLDI TXes which can work to enable 2 duplicated displays of smaller resolutions or enable a single Dual-Link display with a higher resolution (1920x1200). Configure the necessary register to enable the different

[drm:drm-next 6/19] drivers/gpu/drm/nouveau/nvkm/engine/disp/gv100.c:676:1: sparse: sparse: symbol 'gv100_disp_core_mthd_base' was not declared. Should it be static?

2022-07-27 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm drm-next head: 2bc7ea71a73747a77e7f83bc085b0d2393235410 commit: acbe9ecfb7fb14db868ddbeda8f43e623026316b [6/19] drm/nouveau/disp: merge head/outp/ior code into chipset files config: alpha-randconfig-s032-20220725 compiler: alpha-linux-gcc (GCC) 12.1.

Re: [PATCH] drm: Fix EDID firmware load on resume

2022-07-27 Thread Matthieu CHARETTE
Hi, Caching the EDID via the firmware API makes the kernel able to reclaim the memory in case it's needed. And eventually, the kernel will load it again before suspending. But for 128 bytes, even if we have many monitors it will not make any difference. I don't know if storing a platform devic

Re: [Freedreno] [PATCH] drm/msm/dsi: Don't set a load before disabling a regulator

2022-07-27 Thread Dmitry Baryshkov
On Wed, 27 Jul 2022 at 16:57, Doug Anderson wrote: > > Hi, > > On Tue, Jul 26, 2022 at 4:53 PM Abhinav Kumar > wrote: > > > > On 7/25/2022 5:49 PM, Douglas Anderson wrote: > > > As of commit 5451781dadf8 ("regulator: core: Only count load for > > > enabled consumers"), a load isn't counted for a

Re: [Freedreno] [PATCH] drm/msm/dsi: Don't set a load before disabling a regulator

2022-07-27 Thread Doug Anderson
Hi, On Tue, Jul 26, 2022 at 4:53 PM Abhinav Kumar wrote: > > On 7/25/2022 5:49 PM, Douglas Anderson wrote: > > As of commit 5451781dadf8 ("regulator: core: Only count load for > > enabled consumers"), a load isn't counted for a disabled > > regulator. That means all the code in the DSI driver to

Re: [Freedreno] [PATCH] drm/msm/dsi: Don't set a load before disabling a regulator

2022-07-27 Thread Doug Anderson
Hi, On Wed, Jul 27, 2022 at 6:59 AM Dmitry Baryshkov wrote: > > On Wed, 27 Jul 2022 at 16:57, Doug Anderson wrote: > > > > Hi, > > > > On Tue, Jul 26, 2022 at 4:53 PM Abhinav Kumar > > wrote: > > > > > > On 7/25/2022 5:49 PM, Douglas Anderson wrote: > > > > As of commit 5451781dadf8 ("regulato

Re: [Intel-gfx] [PATCH v3 2/6] drm/i915/gt: document with_intel_gt_pm_if_awake()

2022-07-27 Thread Andi Shyti
Hi Mauro, > Add a kernel-doc markup to document this new macro. > > Reviewed-by: Tvrtko Ursulin > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Andi Shyti Andi

Re: [Intel-gfx] [PATCH v3 6/6] drm/i915/gt: describe the new tlb parameter at i915_vma_resource

2022-07-27 Thread Andi Shyti
Hi Mauro, > TLB cache invalidation can happen on two different situations: > > 1. synchronously, at __vma_put_pages(); > 2. asynchronously. > > On the first case, TLB cache invalidation happens inside > __vma_put_pages(). So, no need to do it later on. > > However, on the second case, the pages

Re: [PATCH v3 5/6] drm/i915/gt: Batch TLB invalidations

2022-07-27 Thread Andi Shyti
Hi Mauro, I think there are still some unanswered questions from Tvrtko on this patch, am I right? Andi On Wed, Jul 27, 2022 at 02:29:55PM +0200, Mauro Carvalho Chehab wrote: > From: Chris Wilson > > Invalidate TLB in batches, in order to reduce performance regressions. > > Currently, every c

[PATCH] drm/amdgpu: fix i2s_pdata out of bound array access

2022-07-27 Thread Vijendar Mukunda
Fixed following Smatch static checker warning: drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:393 acp_hw_init() error: buffer overflow 'i2s_pdata' 3 <= 3 drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:396 acp_hw_init() error: buffer overflow 'i2s_pdata' 3 <= 3 Reported-by: Dan Carpenter Signed

Re: [PATCH] drm/amdgpu: fix i2s_pdata out of bound array access

2022-07-27 Thread Alex Deucher
On Wed, Jul 27, 2022 at 10:42 AM Vijendar Mukunda wrote: > > Fixed following Smatch static checker warning: > > drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:393 acp_hw_init() > error: buffer overflow 'i2s_pdata' 3 <= 3 > drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:396 acp_hw_init() > error:

Re: [PATCH] drm/amdgpu: fix i2s_pdata out of bound array access

2022-07-27 Thread Mukunda,Vijendar
On 7/27/22 8:25 PM, Alex Deucher wrote: > On Wed, Jul 27, 2022 at 10:42 AM Vijendar Mukunda > wrote: >> >> Fixed following Smatch static checker warning: >> >> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:393 acp_hw_init() >> error: buffer overflow 'i2s_pdata' 3 <= 3 >> drivers/gpu/drm/amd/

Re: [PATCH] drm/amdgpu: fix i2s_pdata out of bound array access

2022-07-27 Thread Alex Deucher
On Wed, Jul 27, 2022 at 11:16 AM Mukunda,Vijendar wrote: > > On 7/27/22 8:25 PM, Alex Deucher wrote: > > On Wed, Jul 27, 2022 at 10:42 AM Vijendar Mukunda > > wrote: > >> > >> Fixed following Smatch static checker warning: > >> > >> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:393 acp_hw_init() >

Re: [PATCH v2] drm/ttm: Fix dummy res NULL ptr deref bug

2022-07-27 Thread André Almeida
Hi Arunpravin, Às 02:30 de 27/07/22, Arunpravin Paneer Selvam escreveu: > Check the bo->resource value before accessing the resource > mem_type. > > v2: Fix commit description unwrapped warning > > > [ 40.191227][ T184] general protection fault, probably for non-canonical > address 0xdc

Re: [PATCH -next] drm/amd/display: remove unneeded semicolon

2022-07-27 Thread Rodrigo Siqueira Jordao
On 2022-07-26 18:28, Yang Li wrote: Eliminate the following coccicheck warning: ./drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c:2344:67-68: Unneeded semicolon Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c | 2 +- 1 file c

Re: [PATCH] drm/amdkfd: use time_is_before_jiffies(a + b) to replace "jiffies - a > b"

2022-07-27 Thread Felix Kuehling
This patch introduces a build warning for me: CC [M] drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_interrupt.o In file included from /home/fkuehlin/compute/kernel/include/linux/spinlock.h:54, from /home/fkuehlin/compute/kernel/include/linux/mmzone.h:8, from /home/f

[PATCH v5 00/10] Add RZ/G2L Display support

2022-07-27 Thread Biju Das
RZ/G2L LCD controller composed of Frame compression Processor(FCPVD), Video signal processor (VSPD) and Display unit(DU). The output of LCDC is connected to Display parallel interface and MIPI link video interface. This patch series aims to add basic display support on RZ/G2L SMARC EVK platform. T

[PATCH v5 02/10] drm: rcar-du: Move rcar_du_vsp_plane_cleanup_fb()

2022-07-27 Thread Biju Das
Move rcar_du_vsp_plane_cleanup_fb() to RCar DU vsp lib so that it can be shared by both RCar and RZ/G2L DU vsp drivers. Signed-off-by: Biju Das --- v5: * New patch --- drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 12 drivers/gpu/drm/rcar-du/rcar_du_vsp_lib.c | 12 drive

[PATCH v5 03/10] drm: rcar-du: Move rcar_du_vsp_plane_atomic_update()

2022-07-27 Thread Biju Das
Move rcar_du_vsp_plane_atomic_update() to RCar DU vsp lib so that both RCar and RZ/G2L DU vsp drivers can share this function. Signed-off-by: Biju Das --- v5: * New patch --- drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 51 --- drivers/gpu/drm/rcar-du/rcar_du_vsp_lib.c | 51 +

[PATCH v5 04/10] drm: rcar-du: Add rcar_du_lib_fb_create()

2022-07-27 Thread Biju Das
Move the common code from rcar_du_fb_create->rcar_du_lib_fb_create, so that rzg2l_du_fb_create() can reuse the common code. Signed-off-by: Biju Das --- v5: * New patch --- drivers/gpu/drm/rcar-du/rcar_du_kms.c | 64 + drivers/gpu/drm/rcar-du/rcar_du_kms_lib.c | 69 ++

[PATCH v5 08/10] drm: rcar-du: Add rcar_du_lib_vsps_init()

2022-07-27 Thread Biju Das
Add rcar_du_lib_vsps_init() to RCar DU kms lib to handle both rcar_du_vsp_init() and rzg2l_du_vsp_init(). Signed-off-by: Biju Das --- v5: * New patch --- drivers/gpu/drm/rcar-du/rcar_du_kms.c | 88 +- drivers/gpu/drm/rcar-du/rcar_du_kms_lib.c | 89 +++

[PATCH v5 01/10] drm: rcar-du: Move rcar_du_vsp_plane_prepare_fb()

2022-07-27 Thread Biju Das
Move rcar_du_vsp_plane_prepare_fb() to RCar DU vsp lib so that both RCar and RZ/G2L DU vsp drivers can share this function. Signed-off-by: Biju Das --- v5: * New patch --- drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 21 - drivers/gpu/drm/rcar-du/rcar_du_vsp_lib.c | 21 ++

[PATCH v5 09/10] dt-bindings: display: Document Renesas RZ/G2L DU bindings

2022-07-27 Thread Biju Das
The RZ/G2L LCD controller is composed of Frame Compression Processor (FCPVD), Video Signal Processor (VSPD), and Display Unit (DU). The DU module supports the following hardware features − Display Parallel Interface (DPI) and MIPI LINK Video Interface − Display timing master − Generates video timi

[PATCH v5 07/10] drm: rcar-du: Move rcar_du_properties_init()

2022-07-27 Thread Biju Das
Move rcar_du_properties_init() to RCar DU kms lib, so that it can be shared by both RCar and RZ/G2L kms drivers. Signed-off-by: Biju Das --- v5: * New patch --- drivers/gpu/drm/rcar-du/rcar_du_kms.c | 16 drivers/gpu/drm/rcar-du/rcar_du_kms_lib.c | 16 driv

[PATCH v5 06/10] drm: rcar-du: Move rcar_du_encoders_init()

2022-07-27 Thread Biju Das
RZ/G2L supports only DSI and DPI. Add rcar_du_encoders_init() to handle the pointer to du_output_name(), so that we can share du_encoders_init() between RCar and RZ/G2L kms drivers. Signed-off-by: Biju Das --- v5: * New patch --- drivers/gpu/drm/rcar-du/rcar_du_kms.c | 92 +

[PATCH v5 05/10] drm: rcar-du: Add rcar_du_lib_mode_cfg_helper_fns()

2022-07-27 Thread Biju Das
Add rcar_du_lib_mode_cfg_helper_fns() in RCar DU kms lib to get the pointer to rcar_du_mode_config_helper, so that both rcar_du_atomic_ commit_tail() and rcar_du_mode_config_helper can be reused by rcar_du_modeset_init() and rzg2l_du_modeset_init(). Signed-off-by: Biju Das --- v5: * New patch --

[PATCH v5 10/10] drm: rcar-du: Add RZ/G2L DU Support

2022-07-27 Thread Biju Das
The LCD controller is composed of Frame Compression Processor (FCPVD), Video Signal Processor (VSPD), and Display Unit (DU). It has DPI/DSI interfaces and supports a maximum resolution of 1080p along with 2 RPFs to support blending of two picture layers and raster operations (ROPs). The DU part i

[PATCH] dt-bindings: display: use spi-peripheral-props.yaml

2022-07-27 Thread Krzysztof Kozlowski
Instead of listing directly properties typical for SPI peripherals, reference the spi-peripheral-props.yaml schema. This allows using all properties typical for SPI-connected devices, even these which device bindings author did not tried yet. Remove the spi-* properties which now come via spi-per

[PATCH] drm/i915/ttm: don't leak the ccs state

2022-07-27 Thread Matthew Auld
The kernel only manages the ccs state with lmem-only objects, however the kernel should still take care not to leak the CCS state from the previous user. Fixes: 48760ffe923a ("drm/i915/gt: Clear compress metadata for Flat-ccs objects") Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Ramali

Re: [PATCH] dt-bindings: display: use spi-peripheral-props.yaml

2022-07-27 Thread Sam Ravnborg
Hi Krzysztof, On Wed, Jul 27, 2022 at 06:43:12PM +0200, Krzysztof Kozlowski wrote: > Instead of listing directly properties typical for SPI peripherals, > reference the spi-peripheral-props.yaml schema. This allows using all > properties typical for SPI-connected devices, even these which device

[PATCH] mm: Fix a null ptr deref with CONFIG_DEBUG_VM enabled in wp_page_reuse

2022-07-27 Thread Zack Rusin
From: Zack Rusin Write page faults on last references might not have a valid page anymore. wp_page_reuse has always dealt with that scenario by making sure the page isn't null (or the reference was shared) before doing anything with it. Recently added checks in VM_BUG_ON (enabled by the CONFIG_DE

Re: [PATCH] mm: Fix a null ptr deref with CONFIG_DEBUG_VM enabled in wp_page_reuse

2022-07-27 Thread Matthew Wilcox
On Wed, Jul 27, 2022 at 03:14:07PM -0400, Zack Rusin wrote: > From: Zack Rusin > > Write page faults on last references might not have a valid page anymore. > wp_page_reuse has always dealt with that scenario by making > sure the page isn't null (or the reference was shared) before doing > anythi

Re: [PATCH] mm: Fix a null ptr deref with CONFIG_DEBUG_VM enabled in wp_page_reuse

2022-07-27 Thread Zack Rusin
On Wed, 2022-07-27 at 20:24 +0100, Matthew Wilcox wrote: > On Wed, Jul 27, 2022 at 03:14:07PM -0400, Zack Rusin wrote: > > From: Zack Rusin > > > > Write page faults on last references might not have a valid page anymore. > > wp_page_reuse has always dealt with that scenario by making > > sure th

Re: (subset) [PATCH v2 0/7] drm/msm/dsi regulator improvements

2022-07-27 Thread Mark Brown
On Tue, 26 Jul 2022 10:38:17 -0700, Douglas Anderson wrote: > The main goal of this series is to make a small dent in cleaning up > the way we deal with regulator loads. The idea is to add some extra > functionality to the regulator "bulk" API so that consumers can > specify the load using that. Th

[PATCH] drm/amdgpu: Fix stub fence refcount underflow

2022-07-27 Thread Felix Kuehling
Don't drop the stub fence reference after installing it as a replacement for the eviction fence. dma_resv_replace_fences doesn't take another reference to the fence, so it takes ownership of the reference passed in by us. Fixes: 548e7432dc2d ("dma-buf: add dma_resv_replace_fences v2") CC: Christia

RE: [PATCH] drm/i915/ttm: don't leak the ccs state

2022-07-27 Thread C, Ramalingam
> -Original Message- > From: Auld, Matthew > Sent: Wednesday, July 27, 2022 10:14 PM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Thomas Hellström > ; C, > Ramalingam > Subject: [PATCH] drm/i915/ttm: don't leak the ccs state > > The kernel only manages th

Re: [PATCH v2 0/7] drm/msm/dsi regulator improvements

2022-07-27 Thread Mark Brown
On Tue, Jul 26, 2022 at 10:38:17AM -0700, Douglas Anderson wrote: > * After that I have patches that add to the regulator API and then > show a usage of those in the DSI driver. I'd expect that the two > regulator patches could land in the regulator tree. The DSI patches > would need to wait

[PATCH] drm/i915/guc: Don't send policy update for child contexts.

2022-07-27 Thread Daniele Ceraolo Spurio
The GuC FW applies the parent context policy to all the children, so individual updates to the children are not supported and we should not send them. Note that sending the message did not have any functional consequences, because the GuC just drops it and logs an error; since we were trying to se

[PATCH v3] gpu/drm/bridge/cadence: avoid flush_scheduled_work() usage

2022-07-27 Thread Tetsuo Handa
Like commit c4f135d643823a86 ("workqueue: Wrap flush_workqueue() using a macro") says, flush_scheduled_work() is dangerous and will be forbidden. We are on the way for removing all flush_scheduled_work() callers from the kernel, and this patch is for removing flush_scheduled_work() call from caden

Re: [PATCH] drm/i915/guc: Don't send policy update for child contexts.

2022-07-27 Thread John Harrison
On 7/27/2022 17:33, Daniele Ceraolo Spurio wrote: The GuC FW applies the parent context policy to all the children, so individual updates to the children are not supported and we should not send them. Note that sending the message did not have any functional consequences, because the GuC just dr

Re: [PATCH] drm/i915/guc: Don't send policy update for child contexts.

2022-07-27 Thread Ceraolo Spurio, Daniele
On 7/27/2022 6:44 PM, John Harrison wrote: On 7/27/2022 17:33, Daniele Ceraolo Spurio wrote: The GuC FW applies the parent context policy to all the children, so individual updates to the children are not supported and we should not send them. Note that sending the message did not have any f

Re: [PATCH] drm/i915/guc: Don't send policy update for child contexts.

2022-07-27 Thread John Harrison
On 7/27/2022 18:50, Ceraolo Spurio, Daniele wrote: On 7/27/2022 6:44 PM, John Harrison wrote: On 7/27/2022 17:33, Daniele Ceraolo Spurio wrote: The GuC FW applies the parent context policy to all the children, so individual updates to the children are not supported and we should not send them.

  1   2   >