[PATCH v3 14/15] drm/msm/gem: Add msm_gem_assert_locked()

2022-07-26 Thread Rob Clark
From: Rob Clark All use of msm_gem_is_locked() is just for WARN_ON()s, so extract out into an msm_gem_assert_locked() patch. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 36 +-- drivers/gpu/drm/msm/msm_gem.h | 8 +++- 2 files changed, 25 ins

[PATCH v3 12/15] drm/msm/gem: Consolidate shrinker trace

2022-07-26 Thread Rob Clark
From: Rob Clark Combine separate trace events for purge vs evict into one. When we add support for purging/evicting active buffers we'll just add more info into this one trace event, rather than adding a bunch more events. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem_shrinker.c |

[PATCH v3 11/15] drm/msm/gem: Unpin buffers earlier

2022-07-26 Thread Rob Clark
From: Rob Clark We've already attached the fences, so obj->resv (which shrinker checks) tells us whether they are still active. So we can unpin sooner, before we drop the queue lock. This also avoids the need to grab the obj lock in the retire path, avoiding potential for lock contention betwee

[PATCH v3 06/15] drm/msm/gem: Rename to pin/unpin_pages

2022-07-26 Thread Rob Clark
From: Rob Clark Since that is what these fxns actually do.. they are getting *pinned* pages (as opposed to cases where we need pages, but don't need them pinned, like CPU mappings). Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 18 +- drivers/gpu/drm/msm/ms

Re: [PATCH 1/2] drm/i915/gem: Avoid taking runtime-pm under the shrinker

2022-07-26 Thread Matthew Auld
On 20/07/2022 11:16, Janusz Krzysztofik wrote: From: Chris Wilson Inside the shrinker, we cannot wake the device as that may cause recursion into fs-reclaim, so instead we only unbind vma if the device is currently awake. (In order to provide reclaim while asleep, we do wake the device up durin

[pull] amdgpu, amdkfd drm-next-5.20

2022-07-26 Thread Alex Deucher
Hi Dave, Daniel, Bug fixes for 5.20 and a few new things. I know it's a bit late for new stuff, but this is mainly fixes for new IPs that were just added in 5.20 and more DC cleanup which is just code shuffling to group FP code into separate code objects and spliting up the DC DM code into more f

[PATCH v5] drm: Add initial ci/ subdirectory

2022-07-26 Thread Tomeu Vizoso
And use it to store expectations about what the DRM drivers are supposed to pass in the IGT test suite. Also include a configuration file that points to the out-of-tree CI scripts. By storing the test expectations along the code we can make sure both stay in sync with each other, and so we can kn

Re: [PATCH v3 26/32] drm/via: Add via_drm.h

2022-07-26 Thread Thomas Zimmermann
Hi Am 26.07.22 um 19:41 schrieb Sam Ravnborg: Hi Kevin. On Mon, Jul 25, 2022 at 04:53:53PM -0700, Kevin Brace wrote: From: Kevin Brace Changed the uAPI. Signed-off-by: Kevin Brace It would be great to have the new extensions to the UAPI documented using kernel-doc. As an example see: vc4

[PATCH v2 1/4] drm/amd: Add detailed GFXOFF stats to debugfs

2022-07-26 Thread André Almeida
Add debugfs interface to log GFXOFF statistics: - Read amdgpu_gfxoff_count to get the total GFXOFF entry count at the time of query since system power-up - Write 1 to amdgpu_gfxoff_residency to start logging, and 0 to stop. Read it to get average GFXOFF residency % multiplied by 100 during

[PATCH v2 2/4] drm/amd/pm: Implement GFXOFF's entry count and residency for vangogh

2022-07-26 Thread André Almeida
Implement functions to get and set GFXOFF's entry count and residency for vangogh. Signed-off-by: André Almeida --- .../pm/swsmu/inc/pmfw_if/smu_v11_5_ppsmc.h| 5 +- drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h | 5 +- .../gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 92 +++

[PATCH v2 0/4] drm/amd: Add more GFXOFF stats for vangogh

2022-07-26 Thread André Almeida
This series adds new logging features for GFXOFF available for vangogh and documentation for it. I've created a small userspace program to interact with this new debugfs interface and it can be found at: https://gitlab.freedesktop.org/andrealmeid/gfxoff_tool Changelog: v2: - Make entrycount u

[PATCH v2 3/4] Documentation/gpu: Document GFXOFF's count and residency

2022-07-26 Thread André Almeida
Add documentation explaining those two new files. While here, add a note about the value type. Signed-off-by: André Almeida --- Documentation/gpu/amdgpu/thermal.rst | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/Documentation/gpu/amdgpu/thermal.rst b/Doc

[PATCH v2 4/4] drm/amdgpu: Document gfx_off members of struct amdgpu_gfx

2022-07-26 Thread André Almeida
Add comments to document gfx_off related members of struct amdgpu_gfx. Signed-off-by: André Almeida --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h b/drivers/gpu/drm/amd/amdgpu/a

Re: [PATCH v3 26/32] drm/via: Add via_drm.h

2022-07-26 Thread Thomas Zimmermann
Hi Am 26.07.22 um 01:53 schrieb Kevin Brace: From: Kevin Brace Changed the uAPI. Signed-off-by: Kevin Brace --- include/uapi/drm/via_drm.h | 35 +++ 1 file changed, 31 insertions(+), 4 deletions(-) diff --git a/include/uapi/drm/via_drm.h b/include/uapi/drm

Re: [PATCH v9 06/14] mm/gup: migrate device coherent pages when pinning instead of failing

2022-07-26 Thread Andrew Morton
On Mon, 25 Jul 2022 21:22:06 -0500 "Sierra Guiza, Alejandro (Alex)" wrote: > >> a) add the || to the end of the previous line > >> b) indent such the we have a nice-to-read alignment > >> > >> if (!list_empty(&movable_page_list) || isolation_error_count || > >> coherent_pages) > >> > > I mi

Re: [PATCH v2 09/10] drm/ofdrm: Add per-model device function

2022-07-26 Thread Javier Martinez Canillas
Hello Michal, On 7/26/22 16:40, Michal Suchánek wrote: > Hello, > > On Tue, Jul 26, 2022 at 03:38:37PM +0200, Javier Martinez Canillas wrote: >> On 7/20/22 16:27, Thomas Zimmermann wrote: >>> Add a per-model device-function structure in preparation of adding >>> color-management support. Detectio

Re: [PATCH 1/2] drm/amd/display: change variables type

2022-07-26 Thread André Almeida
Às 17:47 de 25/07/22, Magali Lemes escreveu: > > On 7/25/22 16:42, André Almeida wrote: >> Hi Magali, >> >> Às 15:15 de 25/07/22, Magali Lemes escreveu: >>> As "dcn3_15_soc" and "dcn3_16_soc" are of type "struct >>> _vcs_dpi_soc_bounding_box_st", change their types accordingly. >>> >> I can see th

Re: [PATCH v3 26/32] drm/via: Add via_drm.h

2022-07-26 Thread Dave Airlie
On Wed, 27 Jul 2022 at 04:18, Thomas Zimmermann wrote: > > Hi > > Am 26.07.22 um 19:41 schrieb Sam Ravnborg: > > Hi Kevin. > > > > On Mon, Jul 25, 2022 at 04:53:53PM -0700, Kevin Brace wrote: > >> From: Kevin Brace > >> > >> Changed the uAPI. > >> > >> Signed-off-by: Kevin Brace > > > > It would

[Bug 213145] AMDGPU resets, timesout and crashes after "*ERROR* Waiting for fences timed out!"

2022-07-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213145 Michal Przybylowicz (michal.przybylow...@gmail.com) changed: What|Removed |Added CC||mich

[Bug 216290] New: [amdgpu] drm/ttm: fbdev race condition into fork()

2022-07-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216290 Bug ID: 216290 Summary: [amdgpu] drm/ttm: fbdev race condition into fork() Product: Drivers Version: 2.5 Kernel Version: 5.19.0-rc7+ 353afba44cdabdab9fdfaa6990a088718abd5d85 Hardware: AMD

[PATCH -next] drm/amd/display: remove unneeded semicolon

2022-07-26 Thread Yang Li
Eliminate the following coccicheck warning: ./drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c:2344:67-68: Unneeded semicolon Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v3 0/4] KUnit tests for RGB565 conversion

2022-07-26 Thread José Expósito
Hello everyone, This series is a follow up of the XRGB to RGB332 conversion KUnit tests. As I mentioned in v2 [1] I suspected that the inconsistency handling the endian might need to be fixed. Fortunately, Geert Uytterhoeven fixed it in commit 4d9db10576ff ("drm/format-helper: Fix endianness

[PATCH v3 2/4] drm/format-helper: Rename test cases to make them more generic

2022-07-26 Thread José Expósito
The tests available at the moment only check the conversion from XRGB to RGB332. However, more conversions will be tested in the future. In order to make the struct and functions present in the tests more generic, rename xrgb_to_rgb332_* to convert_xrgb_*. Tested-by: Tales L. Aparecid

[PATCH v3 1/4] drm/format-helper: Fix test on big endian architectures

2022-07-26 Thread José Expósito
The tests fail on big endian architectures, like PowerPC: $ ./tools/testing/kunit/kunit.py run \ --kunitconfig=drivers/gpu/drm/tests \ --arch=powerpc --cross_compile=powerpc64-linux-gnu- Transform the XRGB buffer from little endian to the CPU endian before calling the conversion functi

[PATCH v3 3/4] drm/format-helper: Support multiple target formats results

2022-07-26 Thread José Expósito
In order to support multiple destination format conversions, store the destination pitch and the expected result in its own structure. Tested-by: Tales L. Aparecida Acked-by: Thomas Zimmermann Reviewed-by: David Gow Signed-off-by: José Expósito --- .../gpu/drm/tests/drm_format_helper_test.c

[PATCH v3 4/4] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb565()

2022-07-26 Thread José Expósito
Extend the existing test cases to test the conversion from XRGB to RGB565. The documentation and the color picker available on [1] are useful resources to understand this patch and validate the values returned by the conversion function. Tested-by: Tales L. Aparecida Acked-by: Thomas Zimmerm

[git pull] nouveau display patches

2022-07-26 Thread Dave Airlie
Just to work in the process, I've pulled a bunch of patches Lyude tested, that rework some of the nouveau display code. Dave. topic/nouveau-misc-2022-07-27: drm/nouveau-misc: display patches. These are just some precursor and cleanup display patches from Ben, tested by Lyude. The following chang

Re: [Freedreno] [PATCH] drm/msm/dsi: Don't set a load before disabling a regulator

2022-07-26 Thread Abhinav Kumar
On 7/25/2022 5:49 PM, Douglas Anderson wrote: As of commit 5451781dadf8 ("regulator: core: Only count load for enabled consumers"), a load isn't counted for a disabled regulator. That means all the code in the DSI driver to specify and set loads before disabling a regulator is not actually doi

Re: [PATCH 1/2] drm/amd/display: change variables type

2022-07-26 Thread Melissa Wen
On 07/26, Magali Lemes wrote: > On 7/25/22 20:38, Melissa Wen wrote: > > > On 07/25, Magali Lemes wrote: > > > On 7/25/22 16:42, André Almeida wrote: > > > > Hi Magali, > > > > > > > > Às 15:15 de 25/07/22, Magali Lemes escreveu: > > > > > As "dcn3_15_soc" and "dcn3_16_soc" are of type "struct >

Re: [PATCH 02/10] drm: rcar-du: Add encoder lib support

2022-07-26 Thread kernel test robot
Hi Biju, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on next-20220726] [cannot apply to drm-intel/for-linux-next pinchartl-media/drm/du/next linus/master v5.19-rc8] [If your patch is applied to the wrong git tree

Re: linux-next: manual merge of the drm tree with the drm-misc-fixes tree

2022-07-26 Thread Stephen Rothwell
Hi all, On Mon, 18 Jul 2022 09:44:53 +1000 Stephen Rothwell wrote: > > On Mon, 11 Jul 2022 10:05:45 +0200 Christian König > wrote: > > > > Am 11.07.22 um 04:47 schrieb Stephen Rothwell: > > > > > > Today's linux-next merge of the drm tree got a conflict in: > > > > > >drivers/gpu/drm/amd

Re: linux-next: manual merge of the drm tree with the drm-misc-fixes tree

2022-07-26 Thread Dave Airlie
On Wed, 27 Jul 2022 at 12:55, Stephen Rothwell wrote: > > Hi all, > > On Mon, 18 Jul 2022 09:44:53 +1000 Stephen Rothwell > wrote: > > > > On Mon, 11 Jul 2022 10:05:45 +0200 Christian König > > wrote: > > > > > > Am 11.07.22 um 04:47 schrieb Stephen Rothwell: > > > > > > > > Today's linux-next

Re: [PATCH] drm: lcdif: change burst size to 256B

2022-07-26 Thread Marco Felsch
Hi Marek, Liu, On 22-07-26, Liu Ying wrote: > On Tue, 2022-07-26 at 16:19 +0200, Marek Vasut wrote: > > On 7/26/22 11:43, Marco Felsch wrote: > > > FIFO underruns are seen if a AXI bus master with a higher priority > > > do a > > > lot of memory access. Increase the burst size to 256B to avoid suc

Re: [PATCH] fbdev: Make registered_fb[] private to fbmem.c

2022-07-26 Thread Helge Deller
On 7/26/22 09:22, Helge Deller wrote: > On 7/25/22 09:54, Javier Martinez Canillas wrote: >> From: Daniel Vetter >> >> No driver access this anymore, except for the olpc dcon fbdev driver but >> that has been marked as broken anyways by commit de0952f267ff ("staging: >> olpc_dcon: mark driver as b

[PATCH v2] drm/ttm: Fix dummy res NULL ptr deref bug

2022-07-26 Thread Arunpravin Paneer Selvam
Check the bo->resource value before accessing the resource mem_type. v2: Fix commit description unwrapped warning [ 40.191227][ T184] general protection fault, probably for non-canonical address 0xdc02: [#1] SMP KASAN PTI [ 40.192995][ T184] KASAN: null-ptr-deref in range

Re: linux-next: manual merge of the drm tree with the drm-misc-fixes tree

2022-07-26 Thread Stephen Rothwell
Hi Dave, On Wed, 27 Jul 2022 13:24:45 +1000 Dave Airlie wrote: > > My assumption is I fix this on sending my -next tree to Linus with a > resolution I create at that time? > > Is there another option, we have this fixed in out drm-tip tree already. Sounds good, no problem. -- Cheers, Stephen

[PATCH] drm/amdkfd: use time_is_before_jiffies(a + b) to replace "jiffies - a > b"

2022-07-26 Thread Yu Zhe
time_is_before_jiffies deals with timer wrapping correctly. Signed-off-by: Yu Zhe --- drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c b/drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c index a946

Re: [PATCH v6 13/13] video: backlight: mt6370: Add MediaTek MT6370 support

2022-07-26 Thread ChiaEn Wu
On Tue, Jul 26, 2022 at 7:59 PM Daniel Thompson wrote: ... > > > > > Does the MT6372 support more steps than this? In other words does it > > > > > use > > > > > a fourteen bit scale or does it use an 11-bit scale at a different > > > > > register location? > > > > > > > > Hi Daniel, > > > > >

<    1   2