Re: [PATCH v8 2/2] drm/gem: Don't map imported GEMs

2022-07-06 Thread Dmitry Osipenko
On 7/6/22 00:48, Rob Clark wrote: > On Tue, Jul 5, 2022 at 4:51 AM Christian König > wrote: >> >> Am 01.07.22 um 11:02 schrieb Dmitry Osipenko: >>> Drivers that use drm_gem_mmap() and drm_gem_mmap_obj() helpers don't >>> handle imported dma-bufs properly, which results in mapping of something >>>

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-07-06 Thread Dmitry Osipenko
Hello Andrey, On 5/17/22 17:48, Dmitry Osipenko wrote: > On 5/17/22 17:13, Andrey Grodzovsky wrote: >> Done. >> >> Andrey > > Awesome, thank you! > Given that this drm-scheduler issue needs to be fixed in the 5.19-RC and earlier, shouldn't it be in the drm-fixes and not in drm-next? -- Best r

Re: [PATCH V2 0/3] DSI host and peripheral initialisation ordering

2022-07-06 Thread Frieder Schrempf
Am 10.06.22 um 09:52 schrieb Lucas Stach: > Hi, > > Am Mittwoch, dem 11.05.2022 um 16:58 +0200 schrieb Marek Szyprowski: >> Hi Dave, >> >> On 05.04.2022 13:43, Dave Stevenson wrote: >>> On Fri, 18 Mar 2022 at 12:25, Dave Stevenson >>> wrote: On Fri, 4 Mar 2022 at 15:18, Dave Stevenson

Re: [PATCH v7 7/9] drm/virtio: Improve DMA API usage for shmem BOs

2022-07-06 Thread Gerd Hoffmann
Hi, > Gerd, thank you very much! It's was indeed unclear to me how to test the > MMIO GPU, but yours variant with microvm works! I was looking for trying > aarch64 in the past, but it also was unclear how to do it since there is > no DT support for the VirtIO-GPU, AFAICS. aarch64 uses acpi by d

Re: [PATCH V2 0/3] DSI host and peripheral initialisation ordering

2022-07-06 Thread Jagan Teki
Hi Frieder, On Wed, Jul 6, 2022 at 12:39 PM Frieder Schrempf wrote: > > Am 10.06.22 um 09:52 schrieb Lucas Stach: > > Hi, > > > > Am Mittwoch, dem 11.05.2022 um 16:58 +0200 schrieb Marek Szyprowski: > >> Hi Dave, > >> > >> On 05.04.2022 13:43, Dave Stevenson wrote: > >>> On Fri, 18 Mar 2022 at 12

Re: [PATCH v7 7/9] drm/virtio: Improve DMA API usage for shmem BOs

2022-07-06 Thread Dmitry Osipenko
On 7/6/22 10:13, Gerd Hoffmann wrote: > Hi, > >> Gerd, thank you very much! It's was indeed unclear to me how to test the >> MMIO GPU, but yours variant with microvm works! I was looking for trying >> aarch64 in the past, but it also was unclear how to do it since there is >> no DT support for t

Re: [PATCH v7 7/9] drm/virtio: Improve DMA API usage for shmem BOs

2022-07-06 Thread Emil Velikov
On 2022/07/05, Dmitry Osipenko wrote: > On 7/5/22 18:45, Gerd Hoffmann wrote: > > Hi, > > > >>> Also note that pci is not the only virtio transport we have. > >> > >> The VirtIO indeed has other transports, but only PCI is really supported > >> in case of the VirtIO-GPU in kernel and in Qemu/cro

Re: [PATCH v7 7/9] drm/virtio: Improve DMA API usage for shmem BOs

2022-07-06 Thread Emil Velikov
On 2022/07/05, Gerd Hoffmann wrote: > Hi, > > > > Also note that pci is not the only virtio transport we have. > > > > The VirtIO indeed has other transports, but only PCI is really supported > > in case of the VirtIO-GPU in kernel and in Qemu/crosvm, AFAICT. Hence > > only the PCI transport wa

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-07-06 Thread Jean Delvare
On Tue, 28 Jun 2022 16:03:12 +0200, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The value returned by an i2c driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) > > So change the prototype of the remove f

[POSSIBLE BUG] Unreachable code or possible dereferencing of NULL pointer

2022-07-06 Thread Subkhankulov Rustam
Version: 5.19-rc5 In function 'via_do_init_map' (drivers/gpu/drm/via/via_map.c: 54) 'drm_legacy_findmap' can return NULL pointer. If that happens,it calls 'via_do_cleanup_map' (drivers/gpu/drm/via/via_map.c: 58). - 54dev_pr

[PATCH] drm/amdgpu/display: Remove duplicated argument to ||

2022-07-06 Thread Zhongjun Tan
From: Zhongjun Tan Remove duplicated argument to || Signed-off-by: Zhongjun Tan --- .../gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c b/driver

[PATCH] drm/amd/display: Fix unsigned expression compared with zero

2022-07-06 Thread Zhongjun Tan
From: Zhongjun Tan Fix unsigned expression compared with zero Signed-off-by: Zhongjun Tan --- .../gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20.c

Re: [PATCH v5 00/13] Canaan devicetree fixes

2022-07-06 Thread Geert Uytterhoeven
Hi Conor, On Tue, Jul 5, 2022 at 11:52 PM Conor Dooley wrote: > I *DO NOT* have any Canaan hardware so I have not tested any of this in > action. Since I sent v1, I tried to buy some since it's cheap - but could > out of the limited stockists none seemed to want to deliver to Ireland :( > I based

Re: [PATCH V3 02/20] OPP: Make dev_pm_opp_set_regulators() accept NULL terminated list

2022-07-06 Thread Steven Price
On 05/07/2022 05:34, Viresh Kumar wrote: > On 04-07-22, 15:35, Steven Price wrote: >> I have to say the 'new improved' list ending with NULL approach doesn't >> work out so well for Panfrost. We already have to have a separate >> 'num_supplies' variable for devm_regulator_bulk_get() / >> regulator_

Re: [PATCH v5 00/13] Canaan devicetree fixes

2022-07-06 Thread Geert Uytterhoeven
Hi Conor, On Tue, Jul 5, 2022 at 11:52 PM Conor Dooley wrote: > This series should rid us of dtbs_check errors for the RISC-V Canaan k210 > based boards. To make keeping it that way a little easier, I changed the > Canaan devicetree Makefile so that it would build all of the devicetrees > in the

Re: [PATCH v4 1/5] dt-bindings: display: bridge: Convert cdns, dsi.txt to yaml

2022-07-06 Thread Krzysztof Kozlowski
On 05/07/2022 14:11, Rahul T R wrote: > Convert cdns,dsi.txt binding to yaml format > > Signed-off-by: Rahul T R > --- > .../bindings/display/bridge/cdns,dsi.txt | 112 -- > .../bindings/display/bridge/cdns,dsi.yaml | 198 ++ > 2 files changed, 198 insertions(+),

[PATCH V3.1 02/20] OPP: Make dev_pm_opp_set_regulators() accept NULL terminated list

2022-07-06 Thread Viresh Kumar
Make dev_pm_opp_set_regulators() accept a NULL terminated list of names instead of making the callers keep the two parameters in sync, which creates an opportunity for bugs to get in. Suggested-by: Greg Kroah-Hartman Signed-off-by: Viresh Kumar --- V3->V3.1: - Update panfrost_drv.c to include th

Re: [PATCH v4 2/5] dt-bindings: display: bridge: cdns,dsi: Add compatible for dsi on j721e

2022-07-06 Thread Krzysztof Kozlowski
On 05/07/2022 14:11, Rahul T R wrote: > Add compatible to support dsi bridge on j721e > > Signed-off-by: Rahul T R > --- > .../bindings/display/bridge/cdns,dsi.yaml | 24 +-- > 1 file changed, 22 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/binding

Re: [PATCH v4 3/5] drm/bridge: cdns-dsi: Move to drm/bridge/cadence

2022-07-06 Thread Krzysztof Kozlowski
On 05/07/2022 14:11, Rahul T R wrote: > Move the cadence dsi bridge under drm/bridge/cadence > directory, to prepare for adding j721e wrapper > support > > Signed-off-by: Rahul T R > --- > drivers/gpu/drm/bridge/Kconfig | 11 --- > drivers/gpu/drm/bridge/Makefile

Re: [PATCH 0/3] drm: rename CMA helpers to DMA helpers

2022-07-06 Thread Thomas Zimmermann
Am 05.07.22 um 23:26 schrieb Danilo Krummrich: This patch series renames all CMA helpers to DMA helpers - considering the hierarchy of APIs (mm/cma -> dma -> gem/fb dma helpers) calling them DMA helpers seems to be more applicable. Ok, why not. Acked-by: Thomas Zimmermann for the series.

Re: [PATCH] Revert "drivers/video/backlight/platform_lcd.c: add support for device tree based probe"

2022-07-06 Thread Daniel Thompson
On Wed, Jun 29, 2022 at 03:00:23PM -0600, Rob Herring wrote: > This reverts commit 52e842432f36d5b15227d0ee0d2aa3d2bc3cc0b2. > > The DT support never would have worked because there's no platform_data > providing ops. There's not any documented binding for it either. > > Cc: Jingoo Han > Signed-

[ANNOUNCE] libdrm 2.4.112

2022-07-06 Thread Simon Ser
Saleemkhan Jamadar (1): tests/amdgpu/vcn:vcn encoder unit test Sathishkumar S (1): tests/amdgpu: fix decode test failure on VCN2.5 Simon Ser (6): gen_table_fourcc: strip _MODIFIER suffix for INVALID xf86drmMode: constify drmModeAtomicReq functions xf86drmMode: introd

Re: [PATCH 0/3] drm: rename CMA helpers to DMA helpers

2022-07-06 Thread Laurent Pinchart
Hi Thomas, On Wed, Jul 06, 2022 at 10:34:13AM +0200, Thomas Zimmermann wrote: > Am 05.07.22 um 23:26 schrieb Danilo Krummrich: > > This patch series renames all CMA helpers to DMA helpers - considering the > > hierarchy of APIs (mm/cma -> dma -> gem/fb dma helpers) calling them DMA > > helpers see

[PATCH] drm/amd/display: remove repeated includes

2022-07-06 Thread Guo Zhengkui
Remove a repeated "#include " Signed-off-by: Guo Zhengkui --- drivers/gpu/drm/amd/display/dc/os_types.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/os_types.h b/drivers/gpu/drm/amd/display/dc/os_types.h index 795dd486b6d6..6b88ae14f1f9 100644 --- a/driver

Re: [PATCH 0/3] drm: rename CMA helpers to DMA helpers

2022-07-06 Thread Thomas Zimmermann
Hi Am 06.07.22 um 11:06 schrieb Laurent Pinchart: Hi Thomas, On Wed, Jul 06, 2022 at 10:34:13AM +0200, Thomas Zimmermann wrote: Am 05.07.22 um 23:26 schrieb Danilo Krummrich: This patch series renames all CMA helpers to DMA helpers - considering the hierarchy of APIs (mm/cma -> dma -> gem/fb

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-07-06 Thread Uwe Kleine-König
On Wed, Jul 06, 2022 at 12:13:15PM +0300, Vladimir Oltean wrote: > On Tue, Jun 28, 2022 at 04:03:12PM +0200, Uwe Kleine-König wrote: > > From: Uwe Kleine-König > > > > The value returned by an i2c driver's remove function is mostly ignored. > > (Only an error message is printed if the value is no

Re: [PATCH 1/3] drm/fb: rename FB CMA helpers to FB DMA helpers

2022-07-06 Thread Laurent Pinchart
Hi Danilo, Thank you for the patch. I've been bothered by the CMA name in this helper for quite some time but never found time to fix it, so I'm happy to see these patches. On Tue, Jul 05, 2022 at 11:26:11PM +0200, Danilo Krummrich wrote: > Rename "FB CMA" helpers to "FB DMA" helpers - considerin

Re: [PATCH V3.1 02/20] OPP: Make dev_pm_opp_set_regulators() accept NULL terminated list

2022-07-06 Thread Steven Price
On 06/07/2022 09:18, Viresh Kumar wrote: > Make dev_pm_opp_set_regulators() accept a NULL terminated list of names > instead of making the callers keep the two parameters in sync, which > creates an opportunity for bugs to get in. > > Suggested-by: Greg Kroah-Hartman > Signed-off-by: Viresh Kumar

Re: [PATCH V2 0/3] DSI host and peripheral initialisation ordering

2022-07-06 Thread Dave Stevenson
Hi Frieder. Apologies Lucas - I missed your response. On Wed, 6 Jul 2022 at 08:09, Frieder Schrempf wrote: > > Am 10.06.22 um 09:52 schrieb Lucas Stach: > > Hi, > > > > Am Mittwoch, dem 11.05.2022 um 16:58 +0200 schrieb Marek Szyprowski: > >> Hi Dave, > >> > >> On 05.04.2022 13:43, Dave Stevenso

[PATCH v3 1/3] drm/amdgpu: fix for coding style issues

2022-07-06 Thread Vijendar Mukunda
Fixed below checkpatch warnings and errors drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:131: CHECK: Comparison to NULL could be written "apd" drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:150: CHECK: Comparison to NULL could be written "apd" drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:196: CHECK: Prefer kernel

[PATCH v2 2/3] drm/amdgpu: add dmi check for jadeite platform

2022-07-06 Thread Vijendar Mukunda
DMI check is required to distinguish Jadeite platform from Stoney base variant. Add DMI check logic for Jadeite platform. Signed-off-by: Vijendar Mukunda Acked-by: Alex Deucher --- changes since v1: - Modified commit label as drm/amdgpu drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 36 +++

[PATCH v2 3/3] drm/amdgpu: create I2S platform devices for Jadeite platform

2022-07-06 Thread Vijendar Mukunda
Jadeite platform uses I2S MICSP instance. Create platform devices for DMA controller and I2S controller for Jadeite platform. Signed-off-by: Vijendar Mukunda Acked-by: Alex Deucher --- changes since v1: - Modified commit lable as drm/amdgpu drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 293 ++

Re: [PATCH v7 7/9] drm/virtio: Improve DMA API usage for shmem BOs

2022-07-06 Thread Laszlo Ersek
Hi Emil, On 07/05/22 22:56, Emil Velikov wrote: > On 2022/07/05, Dmitry Osipenko wrote: >> On 7/5/22 18:45, Gerd Hoffmann wrote: >>> Hi, >>> > Also note that pci is not the only virtio transport we have. The VirtIO indeed has other transports, but only PCI is really supported

Re: [PATCH v3 1/3] drm/amdgpu: fix for coding style issues

2022-07-06 Thread Christian König
Am 06.07.22 um 12:28 schrieb Vijendar Mukunda: Fixed below checkpatch warnings and errors drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:131: CHECK: Comparison to NULL could be written "apd" drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:150: CHECK: Comparison to NULL could be written "apd" drivers/gpu/drm/

drm/syncobj: flatten dma_fence_chains on transfer

2022-07-06 Thread Zhang, Jesse(Jie)
[AMD Official Use Only - General] Fix sync syncobj issue by enable the signaling of the base fence. diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c index d5db818f1c76..971ad97a2f54 100644 --- a/drivers/gpu/drm/drm_syncobj.c +++ b/drivers/gpu/drm/drm_syncobj.c @@ -887,6

Re: [PATCH V2 0/3] DSI host and peripheral initialisation ordering

2022-07-06 Thread Frieder Schrempf
Hi Dave, Am 06.07.22 um 12:27 schrieb Dave Stevenson: > Hi Frieder. > > Apologies Lucas - I missed your response. > > On Wed, 6 Jul 2022 at 08:09, Frieder Schrempf > wrote: >> >> Am 10.06.22 um 09:52 schrieb Lucas Stach: >>> Hi, >>> >>> Am Mittwoch, dem 11.05.2022 um 16:58 +0200 schrieb Marek S

Re: [PATCH 2/3] drm/gem: rename GEM CMA helpers to GEM DMA helpers

2022-07-06 Thread Laurent Pinchart
Hi Danilo, Thank you for the patch. On Tue, Jul 05, 2022 at 11:26:12PM +0200, Danilo Krummrich wrote: > Rename "GEM CMA" helpers to "GEM DMA" helpers - considering the > hierarchy of APIs (mm/cma -> dma -> gem dma) calling them "GEM > DMA" seems to be more applicable. > > Besides that, commit e5

RE: drm/syncobj: flatten dma_fence_chains on transfer

2022-07-06 Thread Zhang, Jesse(Jie)
[AMD Official Use Only - General] + Lionel From: Zhang, Jesse(Jie) Sent: Wednesday, 6 July 2022 6:41 pm To: dri-devel-boun...@lists.freedesktop.org; open list:DRM DRIVERS Cc: Koenig, Christian ; lucas.demar...@intel.com; Nirmoy Das Subject: drm/syncobj: flatten dma_fence_chains on transfer

Re: [PATCH 3/3] drm/todo: remove task to rename CMA helpers

2022-07-06 Thread Laurent Pinchart
Hi Danilo, Thank you for the patch. On Tue, Jul 05, 2022 at 11:26:13PM +0200, Danilo Krummrich wrote: > Both, GEM and FB, CMA helpers were renamed to "GEM DMA" and "FB DMA", > hence the task can be removed. > > Signed-off-by: Danilo Krummrich Reviewed-by: Laurent Pinchart > --- > Documentat

Re: drm/syncobj: flatten dma_fence_chains on transfer

2022-07-06 Thread Christian König
Hi Jesse, not sure how you created this, but usually we use "git send-email" to send out patches. That one here looks kind of mangled. Additional to that this is most likely not the right place for the call. Regards, Christian. Am 06.07.22 um 12:41 schrieb Zhang, Jesse(Jie): [AMD Official

Re: [PATCH v3 2/2] drm/i915/gt: Serialize TLB invalidates with GT resets

2022-07-06 Thread Andi Shyti
Hi Mauro and Chris, On Mon, Jul 04, 2022 at 09:09:29AM +0100, Mauro Carvalho Chehab wrote: > From: Chris Wilson > > Avoid trying to invalidate the TLB in the middle of performing an > engine reset, as this may result in the reset timing out. Currently, > the TLB invalidate is only serialised by

Re: [PATCH v3 1/2] drm/i915/gt: Serialize GRDOM access between multiple engine resets

2022-07-06 Thread Andi Shyti
Hi Mauro and Chris, On Mon, Jul 04, 2022 at 09:09:28AM +0100, Mauro Carvalho Chehab wrote: > From: Chris Wilson > > Don't allow two engines to be reset in parallel, as they would both > try to select a reset bit (and send requests to common registers) > and wait on that register, at the same tim

Re: (subset) [PATCH V2 0/5] I2S driver changes for Jadeite platform

2022-07-06 Thread Mark Brown
On Fri, 1 Jul 2022 17:11:02 +0530, Vijendar Mukunda wrote: > Jadeite(JD) platform is Stoney APU varaint which uses I2S MICSP > instance and ES8336 Codec. > This patch series creates I2S platform devices for JD platform, > adds I2S MICSP instance support and Machine driver support > > This patch se

Re: [PATCH 1/4] drm/bridge: anx7625: Convert to devm_i2c_new_dummy_device()

2022-07-06 Thread Robert Foss
Hey Hsin-Yi, On Wed, 6 Jul 2022 at 04:29, Xin Ji wrote: > > Hi Hsin-Yi, thanks for your patch, looks good to me. > > Reviewed-by: Xin Ji > > On Thu, Jun 30, 2022 at 12:05:47AM +0800, Hsin-Yi Wang wrote: > > Simplify the resource management. > > > > Signed-off-by: Hsin-Yi Wang > > --- > > drive

[PATCH v2 0/4] drm: rename CMA helpers to DMA helpers

2022-07-06 Thread Danilo Krummrich
This patch series renames all CMA helpers to DMA helpers - considering the hierarchy of APIs (mm/cma -> dma -> gem/fb dma helpers) calling them DMA helpers seems to be more applicable. Additionally, commit e57924d4ae80 ("drm/doc: Task to rename CMA helpers") requests to rename the CMA helpers and

[PATCH v2 3/4] drm/gem: rename struct drm_gem_dma_object.{paddr => dma_addr}

2022-07-06 Thread Danilo Krummrich
The field paddr of struct drm_gem_dma_object holds a DMA address, which might actually be a physical address. However, depending on the platform, it can also be a bus address or a virtual address managed by an IOMMU. Hence, rename the field to dma_addr, which is more applicable. Since 'paddr' is

[PATCH v2 4/4] drm/todo: remove task to rename CMA helpers

2022-07-06 Thread Danilo Krummrich
Both, GEM and FB, CMA helpers were renamed to "GEM DMA" and "FB DMA", hence the task can be removed. Acked-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart Signed-off-by: Danilo Krummrich --- Documentation/gpu/todo.rst | 13 - 1 file changed, 13 deletions(-) diff --git a/Docume

[PATCH v2 1/4] drm/fb: rename FB CMA helpers to FB DMA helpers

2022-07-06 Thread Danilo Krummrich
Rename "FB CMA" helpers to "FB DMA" helpers - considering the hierarchy of APIs (mm/cma -> dma -> fb dma) calling them "FB DMA" seems to be more applicable. Besides that, commit e57924d4ae80 ("drm/doc: Task to rename CMA helpers") requests to rename the CMA helpers and implies that people seem to

[PATCH v2 0/4] anx7625: Cleanup, fixes, and implement wait_hpd_asserted

2022-07-06 Thread Hsin-Yi Wang
This series contains: Cleanup: - Convert to use devm_i2c_new_dummy_device() - Use pm_runtime_force_suspend(resume) Fixes: - Fix NULL pointer crash when using edp-panel and Impelment wait_hpd_asserted() callback. The patches are not related to each other, but they are all anx7625 patches so they ar

[PATCH v2 1/4] drm/bridge: anx7625: Convert to devm_i2c_new_dummy_device()

2022-07-06 Thread Hsin-Yi Wang
Simplify the resource management. Signed-off-by: Hsin-Yi Wang Reviewed-by: Xin Ji --- v1->v2: Fix indent. --- drivers/gpu/drm/bridge/analogix/anx7625.c | 96 +++ 1 file changed, 27 insertions(+), 69 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/driv

[PATCH v2 2/4] drm/bridge: anx7625: use pm_runtime_force_suspend(resume)

2022-07-06 Thread Hsin-Yi Wang
There's no need to check for IRQ or disable it in suspend. Use pm_runtime_force_suspend(resume) to make sure anx7625 is powered off correctly. Make the system suspend/resume and pm runtime suspend/resume more consistent. Signed-off-by: Hsin-Yi Wang Reviewed-by: Xin Ji --- v1->v2: Fix typo. ---

[PATCH v2 3/4] drm/bridge: anx7625: Fix NULL pointer crash when using edp-panel

2022-07-06 Thread Hsin-Yi Wang
Move devm_of_dp_aux_populate_ep_devices() after pm runtime and i2c setup to avoid NULL pointer crash. edp-panel probe (generic_edp_panel_probe) calls pm_runtime_get_sync() to read EDID. At this time, bridge should have pm runtime enabled and i2c clients ready. Fixes: adca62ec370c ("drm/bridge: an

[PATCH v2 4/4] drm/bridge: anx7625: Add wait_hpd_asserted() callback

2022-07-06 Thread Hsin-Yi Wang
Move hpd polling check into wait_hpd_asserted() callback. For the cases that aux transfer function wasn't used, do hpd polling check after pm runtime resume, which will power on the bridge. Signed-off-by: Hsin-Yi Wang Reviewed-by: Xin Ji --- v1->v2: fix indent. --- drivers/gpu/drm/bridge/analog

Re: [PATCH 1/4] drm/bridge: anx7625: Convert to devm_i2c_new_dummy_device()

2022-07-06 Thread Hsin-Yi Wang
On Wed, Jul 6, 2022 at 8:31 PM Robert Foss wrote: > > Hey Hsin-Yi, > > On Wed, 6 Jul 2022 at 04:29, Xin Ji wrote: > > > > Hi Hsin-Yi, thanks for your patch, looks good to me. > > > > Reviewed-by: Xin Ji > > > > On Thu, Jun 30, 2022 at 12:05:47AM +0800, Hsin-Yi Wang wrote: > > > Simplify the reso

Re: [PATCH 6/7] dt-bindings: msm: dsi: Add missing clocks to 28nm DSI PHY YAML

2022-07-06 Thread Dmitry Baryshkov
On 30/06/2022 15:08, Bryan O'Donoghue wrote: Add in missing clock and clock-names declarations to the 28nm DSI PHY. When converting from .txt to .yaml we missed these. Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings") Signed-off-by: Bryan O'Donoghue I checked th

[PATCH v2] drm/fb: Improve drm_framebuffer.offsets documentation

2022-07-06 Thread Geert Uytterhoeven
Fix various spelling and grammar mistakes in the kerneldoc comments documenting the offsets member in the drm_framebuffer structure: - s/laytou/layout/, - Add missing "is", - s/it/its/. Signed-off-by: Geert Uytterhoeven Acked-by: Sam Ravnborg Reviewed-by: Simon Ser --- v2: - Add Acked-b

[PATCH v2] drm/msm/adreno: Do not propagate void return values

2022-07-06 Thread Geert Uytterhoeven
With sparse ("make C=2"), lots of error: return expression in void function messages are seen. Fix this by removing the return statements to propagate void return values. Signed-off-by: Geert Uytterhoeven Reviewed-by: Guenter Roeck --- v2: - Add Reviewed-by. --- drivers/gpu/drm/msm/adren

[PATCH v3] drm/mode: Improve drm_mode_fb_cmd2 documentation

2022-07-06 Thread Geert Uytterhoeven
Fix various grammar mistakes in the kerneldoc comments documenting the drm_mode_fb_cmd2 structure: - s/is/are/, - s/8 bit/8-bit/. Signed-off-by: Geert Uytterhoeven Acked-by: Sam Ravnborg Reviewed-by: Simon Ser --- v3: - Add Reviewed-by. v2: - Add Acked-by, - Rebase on top of commit a

Re: [PATCH v2 0/4] anx7625: Cleanup, fixes, and implement wait_hpd_asserted

2022-07-06 Thread Robert Foss
On Wed, 6 Jul 2022 at 14:53, Hsin-Yi Wang wrote: > > This series contains: > Cleanup: > - Convert to use devm_i2c_new_dummy_device() > - Use pm_runtime_force_suspend(resume) > Fixes: > - Fix NULL pointer crash when using edp-panel > and Impelment wait_hpd_asserted() callback. > > The patches are n

[PATCH 2/3] drm/bridge: tc358767: increase CLRSIPO count

2022-07-06 Thread Lucas Stach
The current CLRSIPO count is marginal and does not work with high DSI clock rates. Increase it a bit to allow the DSI link to work at up to 1Gbps lane speed. Signed-off-by: Lucas Stach --- drivers/gpu/drm/bridge/tc358767.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 3/3] drm/bridge: tc358767: disable main link PHYs on main link disable

2022-07-06 Thread Lucas Stach
Disable the main link PHYs and put them into reset when the main link is disabled. When the PHYs stay enabled while the rest of the DP link circuits are disabled there is some noise on the data lanes, which some displays try to lock onto, waking them up from their low power state. Signed-off-by: L

[PATCH 1/3] drm/bridge: tc358767: don't fixup mode sync polarity

2022-07-06 Thread Lucas Stach
There is no need to enforce a specific sync signal polarity on the DPI interface, as we can simply tell the TC358767 which polarities it should expect on the input interface. Signed-off-by: Lucas Stach --- drivers/gpu/drm/bridge/tc358767.c | 54 +++ 1 file changed, 18

Re: [PATCH] drm: bridge: ldb: Drop DE flip from Freescale i.MX8MP LDB bridge

2022-07-06 Thread Robert Foss
On Thu, 30 Jun 2022 at 19:40, Marek Vasut wrote: > > The DE inversion is implemented in LCDIFv3 driver and is no longer > needed in the LDB bridge which does not invert the DE signal. Drop > the inversion. > > Fixes: 463db5c2ed4ae ("drm: bridge: ldb: Implement simple Freescale i.MX8MP > LDB bridg

Re: [PATCH 1/3] drm/bridge: fsl-ldb: Fix mode clock rate validation

2022-07-06 Thread Robert Foss
On Fri, 1 Jul 2022 at 13:00, Marek Vasut wrote: > > On 7/1/22 08:56, Liu Ying wrote: > > With LVDS dual link, up to 160MHz mode clock rate is supported. > > With LVDS single link, up to 80MHz mode clock rate is supported. > > Fix mode clock rate validation by swapping the maximum mode clock > > ra

Re: [PATCH 3/3] drm/bridge: tc358767: disable main link PHYs on main link disable

2022-07-06 Thread Robert Foss
On Wed, 6 Jul 2022 at 15:28, Lucas Stach wrote: > > Disable the main link PHYs and put them into reset when the main link > is disabled. When the PHYs stay enabled while the rest of the DP link > circuits are disabled there is some noise on the data lanes, which some > displays try to lock onto, w

Re: [PATCH 1/3] drm/bridge: tc358767: don't fixup mode sync polarity

2022-07-06 Thread Marco Felsch
On 22-07-06, Lucas Stach wrote: > There is no need to enforce a specific sync signal polarity on the > DPI interface, as we can simply tell the TC358767 which polarities > it should expect on the input interface. > > Signed-off-by: Lucas Stach Reviewed-by: Marco Felsch

Re: [PATCH] drm/amd/display: remove repeated includes

2022-07-06 Thread Harry Wentland
On 2022-07-06 05:13, Guo Zhengkui wrote: > Remove a repeated "#include " > > Signed-off-by: Guo Zhengkui Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/dc/os_types.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/os_types.h >

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-07-06 Thread Andrey Grodzovsky
On 2022-07-06 03:07, Dmitry Osipenko wrote: Hello Andrey, On 5/17/22 17:48, Dmitry Osipenko wrote: On 5/17/22 17:13, Andrey Grodzovsky wrote: Done. Andrey Awesome, thank you! Given that this drm-scheduler issue needs to be fixed in the 5.19-RC and earlier, shouldn't it be in the drm-fixes

Re: [PATCH 1/2] soc: mediatek: Add mmsys func to adapt to dpi output for MT8186

2022-07-06 Thread Matthias Brugger
On 01/07/2022 05:15, xinlei@mediatek.com wrote: From: Xinlei Lee Add mmsys func to manipulate dpi output format config for MT8186. Signed-off-by: Jitao Shi Signed-off-by: Xinlei Lee --- drivers/soc/mediatek/mt8186-mmsys.h| 1 + drivers/soc/mediatek/mtk-mmsys.c | 8 +++

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-07-06 Thread Vladimir Oltean
On Tue, Jun 28, 2022 at 04:03:12PM +0200, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The value returned by an i2c driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) > > So change the prototype of the re

Re: [PATCH v5 00/13] Canaan devicetree fixes

2022-07-06 Thread Damien Le Moal
On 7/6/22 17:03, Geert Uytterhoeven wrote: > Hi Conor, > > On Tue, Jul 5, 2022 at 11:52 PM Conor Dooley wrote: >> I *DO NOT* have any Canaan hardware so I have not tested any of this in >> action. Since I sent v1, I tried to buy some since it's cheap - but could >> out of the limited stockists no

Re: [PATCH v5 04/13] dt-bindings: memory-controllers: add canaan k210 sram controller

2022-07-06 Thread Rob Herring
On Tue, 05 Jul 2022 22:52:05 +0100, Conor Dooley wrote: > From: Conor Dooley > > The k210 U-Boot port has been using the clocks defined in the > devicetree to bring up the board's SRAM, but this violates the > dt-schema. As such, move the clocks to a dedicated node with > the same compatible stri

[PATCH 1/4] dt-bindings: display/msm/gpu: allow specifying several IOMMU nodes

2022-07-06 Thread Dmitry Baryshkov
Different platforms require different amounts of IOMMUs. The APQ8064 uses 64 IOMMU instances for GPU, adjust the schema accordingly. Signed-off-by: Dmitry Baryshkov --- Documentation/devicetree/bindings/display/msm/gpu.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Do

[PATCH 0/4] dt-bindings: display/msm: schema fixes for gpu, gmu and mdp4

2022-07-06 Thread Dmitry Baryshkov
Fix several issues in MSM display schema. Dmitry Baryshkov (4): dt-bindings: display/msm/gpu: allow specifying several IOMMU nodes dt-bindings: display/msm/gpu: document using the amd,imageon adreno too dt-bindings: display/msm/gmu: account for different GMU variants dt-bindings: displ

[PATCH 2/4] dt-bindings: display/msm/gpu: document using the amd, imageon adreno too

2022-07-06 Thread Dmitry Baryshkov
The DT binding desribes using amd,imageon only for Imageon 2xx GPUs. We have been using amd,imageon with newer (Adreno) GPUs to describe the headless setup, when the platform does not (yet) have the display DT nodes (and no display support). Document this trick in the schema. Signed-off-by: Dmitry

[PATCH 3/4] dt-bindings: display/msm/gmu: account for different GMU variants

2022-07-06 Thread Dmitry Baryshkov
Make display/msm/gmu.yaml describe all existing GMU variants rather than just the 630.2 (SDM845) version of it. Signed-off-by: Dmitry Baryshkov --- .../devicetree/bindings/display/msm/gmu.yaml | 166 +++--- 1 file changed, 146 insertions(+), 20 deletions(-) diff --git a/Documentati

[PATCH 4/4] dt-bindings: display/msm/mdp4: require 4 IOMMUs

2022-07-06 Thread Dmitry Baryshkov
APQ8064, the only supported mdp4 platform, uses 4 IOMMUs for the MDP4 device. Update schema accordingly. When we have other MDP4 platforms, this spec can be updated accordingly. Signed-off-by: Dmitry Baryshkov --- Documentation/devicetree/bindings/display/msm/mdp4.yaml | 2 +- 1 file changed, 1

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-07-06 Thread Dmitry Osipenko
On 7/6/22 16:49, Andrey Grodzovsky wrote: > On 2022-07-06 03:07, Dmitry Osipenko wrote: > >> Hello Andrey, >> >> On 5/17/22 17:48, Dmitry Osipenko wrote: >>> On 5/17/22 17:13, Andrey Grodzovsky wrote: Done. Andrey >>> Awesome, thank you! >>> >> Given that this drm-scheduler issue ne

Re: [PATCH v5 1/5] dt-bindings: display: bridge: Convert cdns,dsi.txt to yaml

2022-07-06 Thread Rob Herring
On Wed, Jul 06, 2022 at 05:10:49PM +0530, Rahul T R wrote: > Convert cdns,dsi.txt binding to yaml format > > Signed-off-by: Rahul T R > --- > .../bindings/display/bridge/cdns,dsi.txt | 112 -- > .../bindings/display/bridge/cdns,dsi.yaml | 195 ++ > 2 files change

Re: [PATCH v5 2/5] dt-bindings: display: bridge: cdns,dsi: Add compatible for dsi on j721e

2022-07-06 Thread Rob Herring
On Wed, 06 Jul 2022 17:10:50 +0530, Rahul T R wrote: > Add compatible to support dsi bridge on j721e > > Signed-off-by: Rahul T R > --- > .../bindings/display/bridge/cdns,dsi.yaml | 21 +++ > 1 file changed, 21 insertions(+) > Reviewed-by: Rob Herring

[PATCH v3 2/4] fbcon: Prevent that screen size is smaller than font size

2022-07-06 Thread Helge Deller
We need to prevent that users configure a screen size which is smaller than the currently selected font size. Otherwise rendering chars on the screen will access memory outside the graphics memory region. This patch adds a new function fbcon_modechange_possible() which implements this check and wh

[PATCH v3 0/4] fbcon: Fixes for screen resolution changes

2022-07-06 Thread Helge Deller
This series fixes possible out-of-bound memory accesses when users trigger screen resolutions changes with invalid input parameters, e.g. reconfigures screen which is smaller than the current font size, or if the virtual screen size is smaller than the physical screen size. Changes in v3 (all feed

[PATCH v3 3/4] fbmem: Check virtual screen sizes in fb_set_var()

2022-07-06 Thread Helge Deller
Verify that the fbdev or drm driver correctly adjusted the virtual screen sizes. On failure report the failing driver and reject the screen size change. Signed-off-by: Helge Deller Cc: sta...@vger.kernel.org # v5.4+ --- drivers/video/fbdev/core/fbmem.c | 11 +++ 1 file changed, 11 insert

[PATCH v3 4/4] fbcon: Use fbcon_info_from_console() in fbcon_modechange_possible()

2022-07-06 Thread Helge Deller
Use the fbcon_info_from_console() wrapper which was added to kernel v5.19 with commit 409d6c95f9c6 ("fbcon: Introduce wrapper for console->fb_info lookup"). Signed-off-by: Helge Deller Reviewed-by: Geert Uytterhoeven --- drivers/video/fbdev/core/fbcon.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH v3 1/4] fbcon: Disallow setting font bigger than screen size

2022-07-06 Thread Helge Deller
Prevent that users set a font size which is bigger than the physical screen. It's unlikely this may happen (because screens are usually much larger than the fonts and each font char is limited to 32x32 pixels), but it may happen on smaller screens/LCD displays. Signed-off-by: Helge Deller Reviewe

Re: [PATCH v2 1/7] drm: Move and add a few utility macros into drm util header

2022-07-06 Thread Gwan-gyeong Mun
On 7/5/22 5:23 PM, Mauro Carvalho Chehab wrote: On Tue, 5 Jul 2022 15:24:49 +0300 Gwan-gyeong Mun wrote: It moves overflows_type utility macro into drm util header from i915_utils header. The overflows_type can be used to catch the truncation between data types. And it adds safe_conversion

Re: [PATCH v2 1/1] drm/bridge: ti-sn65dsi86: Use atomic variants of drm_bridge_funcs

2022-07-06 Thread Robert Foss
On Sun, 3 Jul 2022 at 20:40, Sam Ravnborg wrote: > > Move away from the deprecated enable/disable operations in > drm_bridge_funcs and enable atomic use. > > v3: > - Drop use of DRM_BRIDGE_STATE_OPS > > v2: > - fix build (kernel test robot ) > > Signed-off-by: Sam Ravnborg > Cc: Kieran Bingham

Re: [PATCH] video: of_display_timing.h: include errno.h

2022-07-06 Thread Helge Deller
On 7/1/22 01:27, Stephen Boyd wrote: > Quoting Hsin-Yi Wang (2022-06-30 10:33:29) >> If CONFIG_OF is not enabled, default of_get_display_timing() returns an >> errno, so include the header. >> >> Fixes: 422b67e0b31a ("videomode: provide dummy inline functions for >> !CONFIG_OF") >> Suggested-by: S

Re: [PATCH v2 1/1] drm/bridge: ti-sn65dsi86: Use atomic variants of drm_bridge_funcs

2022-07-06 Thread Dave Stevenson
Hi Sam On Mon, 4 Jul 2022 at 17:18, Sam Ravnborg wrote: > > Move away from the deprecated enable/disable operations in > drm_bridge_funcs and enable atomic use. If you're moving to the atomic API, shouldn't you also be getting the mode from the provided state, rather than ti_sn_bridge_set_video_

[PATCH] drm/i915/gem: Really move i915_gem_context.link under ref protection

2022-07-06 Thread Andi Shyti
From: Chris Wilson i915_perf assumes that it can use the i915_gem_context reference to protect its i915->gem.contexts.list iteration. However, this requires that we do not remove the context from the list until after we drop the final reference and release the struct. If, as currently, we remove

[PATCH AUTOSEL 5.18 17/22] fbdev: Disable sysfb device registration when removing conflicting FBs

2022-07-06 Thread Sasha Levin
From: Javier Martinez Canillas [ Upstream commit ee7a69aa38d87a3bbced7b8245c732c05ed0c6ec ] The platform devices registered by sysfb match with firmware-based DRM or fbdev drivers, that are used to have early graphics using a framebuffer provided by the system firmware. DRM or fbdev drivers lat

[PATCH AUTOSEL 5.15 13/18] fbdev: Disable sysfb device registration when removing conflicting FBs

2022-07-06 Thread Sasha Levin
From: Javier Martinez Canillas [ Upstream commit ee7a69aa38d87a3bbced7b8245c732c05ed0c6ec ] The platform devices registered by sysfb match with firmware-based DRM or fbdev drivers, that are used to have early graphics using a framebuffer provided by the system firmware. DRM or fbdev drivers lat

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-07-06 Thread Alex Deucher
On Wed, Jul 6, 2022 at 9:49 AM Andrey Grodzovsky wrote: > > On 2022-07-06 03:07, Dmitry Osipenko wrote: > > > Hello Andrey, > > > > On 5/17/22 17:48, Dmitry Osipenko wrote: > >> On 5/17/22 17:13, Andrey Grodzovsky wrote: > >>> Done. > >>> > >>> Andrey > >> Awesome, thank you! > >> > > Given that t

Re: [PATCH 1/4] dt-bindings: display/msm/gpu: allow specifying several IOMMU nodes

2022-07-06 Thread Krzysztof Kozlowski
On 06/07/2022 16:52, Dmitry Baryshkov wrote: > Different platforms require different amounts of IOMMUs. The APQ8064 > uses 64 IOMMU instances for GPU, adjust the schema accordingly. > > Signed-off-by: Dmitry Baryshkov > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH] drm/amdgpu/display: Remove duplicated argument to ||

2022-07-06 Thread Alex Deucher
Applied. Thanks! On Wed, Jul 6, 2022 at 3:41 AM Zhongjun Tan wrote: > > From: Zhongjun Tan > > Remove duplicated argument to || > > Signed-off-by: Zhongjun Tan > --- > .../gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > d

[PATCH] drm/i915/selftests: Grab the runtime pm in shrink_thp

2022-07-06 Thread Matthew Auld
From: Chris Wilson Since we are not holding a wakeref, shrinking a bound object is not guaranteed. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6370 Signed-off-by: Chris Wilson Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/gem/selftests/huge_pages.c | 7 ++- 1 file cha

Re: [PATCH 2/4] dt-bindings: display/msm/gpu: document using the amd,imageon adreno too

2022-07-06 Thread Krzysztof Kozlowski
On 06/07/2022 16:52, Dmitry Baryshkov wrote: > The DT binding desribes using amd,imageon only for Imageon 2xx GPUs. We > have been using amd,imageon with newer (Adreno) GPUs to describe the > headless setup, when the platform does not (yet) have the display DT Does not have "yet"? So later it will

Re: [PATCH] drm/i915/selftests: Grab the runtime pm in shrink_thp

2022-07-06 Thread Matthew Auld
On Wed, 6 Jul 2022 at 16:48, Matthew Auld wrote: > > From: Chris Wilson > > Since we are not holding a wakeref, shrinking a bound object is not > guaranteed. > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6370 > Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld

Re: [RFT][PATCH v2 1/9] vfio: Make vfio_unpin_pages() return void

2022-07-06 Thread Nicolin Chen
On Tue, Jul 05, 2022 at 11:54:50PM -0700, Christoph Hellwig wrote: > > +void vfio_unpin_pages(struct vfio_device *device, unsigned long *user_pfn, > > + int npage) > > { > > struct vfio_container *container; > > struct vfio_iommu_driver *driver; > > - int ret; > > > > -

Re: [PATCH 3/4] dt-bindings: display/msm/gmu: account for different GMU variants

2022-07-06 Thread Krzysztof Kozlowski
On 06/07/2022 16:52, Dmitry Baryshkov wrote: > Make display/msm/gmu.yaml describe all existing GMU variants rather than > just the 630.2 (SDM845) version of it. > > Signed-off-by: Dmitry Baryshkov > --- > .../devicetree/bindings/display/msm/gmu.yaml | 166 +++--- > 1 file changed, 1

  1   2   >