Re: [PATCH v6 3/5] fbdev: Disable sysfb device registration when removing conflicting FBs

2022-07-05 Thread Xi Ruoyao
On Mon, 2022-07-04 at 17:36 +0800, Xi Ruoyao wrote: > > Yes, please do. Either with CONFIG_SYSFB_SIMPLEFB disabled and CONFIG_FB_EFI > > enabled (so that "efi-framebuffer" is registered and efifb probed) or with > > CONFIG_SYSFB_SIMPLEFB but CONFIG_FB_SIMPLE enabled (so "simple-framebuffer > > is

[PATCH 2/3] media: vsp1: add blend mode support

2022-07-05 Thread Takanari Hayama
To support DRM blend mode in R-Car DU driver, we must add blend mode support in VSP1. Although VSP1 hardware is capable to support all blend mode defined in DRM, the current R-Car DU driver implicitly supports DRM_MODE_BLEND_COVERAGE only. We add a new property to vsp1_du_atomic_config, so that R-

[PATCH v3 1/2] vfio: Replace the DMA unmapping notifier with a callback

2022-07-05 Thread Jason Gunthorpe
Instead of having drivers register the notifier with explicit code just have them provide a dma_unmap callback op in their driver ops and rely on the core code to wire it up. Suggested-by: Christoph Hellwig Reviewed-by: Christoph Hellwig Reviewed-by: Kevin Tian Reviewed-by: Tony Krowiak Review

[PATCH 3/3] drm: rcar-du: Add DRM blend mode support

2022-07-05 Thread Takanari Hayama
R-Car DU supports different blend modes via VSP1. Add DRM blend mode supports to make it configurable. As drm_plane_create_blend_mode_property() creates the blend mode property with the default value of DRM_MODE_BLEND_PREMULTI, it changes the default blending behavior on R-Car DU. The rcar-du's bl

Re: [PATCH v15 2/3] phy: qcom-qmp: add regulator_set_load to dp phy

2022-07-05 Thread Vinod Koul
On 21-06-22, 10:01, Kuogee Hsieh wrote: > This patch add regulator_set_load() before enable regulator at > DP phy driver. > > Signed-off-by: Kuogee Hsieh > Reviewed-by: Stephen Boyd > Reviewed-by: Douglas Anderson > --- > drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 43 > ++

Re: [PATCH v6 14/22] dma-buf: Introduce new locking convention

2022-07-05 Thread Dmitry Osipenko
On 7/1/22 13:43, Dmitry Osipenko wrote: > On 6/29/22 00:26, Thomas Hellström (Intel) wrote: >> On 5/30/22 15:57, Dmitry Osipenko wrote: >>> On 5/30/22 16:41, Christian König wrote: Hi Dmitry, Am 30.05.22 um 15:26 schrieb Dmitry Osipenko: > Hello Christian, > > On 5/30/22

Re: [PATCH] drm/rockchip: Detach from ARM DMA domain in attach_device

2022-07-05 Thread Tomeu Vizoso
Thanks, this fixes the DRM driver on 5.19-rc2 on the rk3288-veyron-jaq. Tested-by: Tomeu Vizoso Cheers, Tomeu On Wed, Jun 15, 2022 at 5:52 PM Steven Price wrote: > Since commit 1ea2a07a532b ("iommu: Add DMA ownership management > interfaces") the Rockchip display driver on the Firefly RK3288

Re: [PATCH v12 1/1] phy: phy-mtk-dp: Add driver for DP phy

2022-07-05 Thread Vinod Koul
On 24-06-22, 14:27, Bo-Chen Chen wrote: > From: Markus Schneider-Pargmann > > This is a new driver that supports the integrated DisplayPort phy for > mediatek SoCs, especially the mt8195. The phy is integrated into the > DisplayPort controller and will be created by the mtk-dp driver. This > driv

Re: [PATCH v6 04/10] gpu: host1x: Add context device management code

2022-07-05 Thread kernel test robot
ext config: arm-randconfig-r005-20220703 (https://download.01.org/0day-ci/archive/20220705/202207051045.jwevr4tw-...@intel.com/config) compiler: arm-linux-gnueabi-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross

Re: [Intel-gfx] [RFC 05/10] drm/i915/vm_bind: Handle persistent vmas

2022-07-05 Thread Ramalingam C
On 2022-07-04 at 17:05:38 +, Zeng, Oak wrote: > > > Thanks, > Oak > > > -Original Message- > > From: Intel-gfx On Behalf Of > > Niranjana Vishwanathapura > > Sent: July 1, 2022 6:51 PM > > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > > Cc: Zanoni, Paulo R ;

[Bug 216200] AMDGPU hung after enabling HIP for gpu acceleration in Blender Cycles 3.2

2022-07-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216200 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED Reso

Re: [PATCH v6 3/5] fbdev: Disable sysfb device registration when removing conflicting FBs

2022-07-05 Thread Xi Ruoyao
On Fri, 2022-06-17 at 08:46 +0200, Javier Martinez Canillas wrote: > Hello Zack, > > On 6/17/22 03:35, Zack Rusin wrote: > > On Fri, 2022-06-17 at 01:21 +0200, Javier Martinez Canillas wrote: > > > On 6/17/22 00:18, Javier Martinez Canillas wrote: > > > > On 6/16/22 23:03, Zack Rusin wrote: > > >

Re: [PATCH 1/3] dt-bindings: phy: qcom,hdmi-phy-qmp: add clock-cells

2022-07-05 Thread Vinod Koul
On 17-06-22, 13:36, Dmitry Baryshkov wrote: > As the QMP HDMI PHY is a clock provider, add constant #clock-cells > property. For the compatibility with older DTs the property is not > marked as required. Acked-By: Vinod Koul -- ~Vinod

[PATCH v3 2/2] vfio: Replace the iommu notifier with a device list

2022-07-05 Thread Jason Gunthorpe
Instead of bouncing the function call to the driver op through a blocking notifier just have the iommu layer call it directly. Register each device that is being attached to the iommu with the lower driver which then threads them on a linked list and calls the appropriate driver op at the right ti

[PATCH 0/3] Add DRM pixel blend mode support to R-Car DU

2022-07-05 Thread Takanari Hayama
The series of patches adds support for DRM pixel blend mode to R-Car DU. The current R-Car DU implicitly supports "Coverage" only. Unfortunately, this changes the default blending mode of R-Car DU to "Pre-multiplied" which is the default when pixel blend mode is supported. Takanari Hayama (3):

RE: [RESEND RFC 15/18] drm/display/dp_mst: Skip releasing payloads if last connected port isn't connected

2022-07-05 Thread Lin, Wayne
[Public] > -Original Message- > From: Lyude Paul > Sent: Wednesday, June 8, 2022 3:30 AM > To: dri-devel@lists.freedesktop.org; nouv...@lists.freedesktop.org; amd- > g...@lists.freedesktop.org > Cc: Lin, Wayne ; Ville Syrjälä > ; Zuo, Jerry ; Jani Nikula > ; Imre Deak ; Daniel Vetter >

Re: [PATCH RESEND V2 1/3] drm/amdgpu: fix checkpatch warnings

2022-07-05 Thread Christian König
Am 04.07.22 um 15:54 schrieb Vijendar Mukunda: From: vijendar Fixed below checkpatch warnings and errors drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:131: CHECK: Comparison to NULL could be written "apd" drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:150: CHECK: Comparison to NULL could be written "a

[PATCH 1/3] media: vsp1: save pixel alpha info in vsp1_rwpf

2022-07-05 Thread Takanari Hayama
In order to support DRM blend mode, we need to able to override pixel alpha flag. When DRM_MODE_BLEND_PIXEL_NONE is desired, we'd like to let VSP1 to ignore the pixel alpha by overriding the flag. Signed-off-by: Takanari Hayama --- drivers/media/platform/renesas/vsp1/vsp1_drm.c | 1 + drivers/m

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-07-05 Thread Uwe Kleine-König
On Tue, Jul 05, 2022 at 12:08:52PM +0200, Jean Delvare wrote: > On Tue, 28 Jun 2022 16:03:12 +0200, Uwe Kleine-König wrote: > > From: Uwe Kleine-König > > > > The value returned by an i2c driver's remove function is mostly ignored. > > (Only an error message is printed if the value is non-zero th

Re: [PATCH V3 02/20] OPP: Make dev_pm_opp_set_regulators() accept NULL terminated list

2022-07-05 Thread Viresh Kumar
On 04-07-22, 15:35, Steven Price wrote: > I have to say the 'new improved' list ending with NULL approach doesn't > work out so well for Panfrost. We already have to have a separate > 'num_supplies' variable for devm_regulator_bulk_get() / > regulator_bulk_{en,dis}able(), so the keeping everything

[PATCH v2 1/2] drm: Use size_t type for len variable in drm_copy_field()

2022-07-05 Thread Javier Martinez Canillas
The strlen() function returns a size_t which is an unsigned int on 32-bit arches and an unsigned long on 64-bit arches. But in the drm_copy_field() function, the strlen() return value is assigned to an 'int len' variable. Later, the len variable is passed as copy_from_user() third argument that is

Re: [RFC 09/10] drm/i915/vm_bind: Skip vma_lookup for persistent vmas

2022-07-05 Thread Thomas Hellström
On Fri, 2022-07-01 at 15:50 -0700, Niranjana Vishwanathapura wrote: > vma_lookup is tied to segment of the object instead of section > of VA space. Hence, it do not support aliasing (ie., multiple > bindings to the same section of the object). > Skip vma_lookup for persistent vmas as it supports al

Re: [RFC 10/10] drm/i915/vm_bind: Fix vm->vm_bind_mutex and vm->mutex nesting

2022-07-05 Thread Thomas Hellström
On Fri, 2022-07-01 at 15:50 -0700, Niranjana Vishwanathapura wrote: > VM_BIND functionality maintain that vm->vm_bind_mutex will never be > taken > while holding vm->mutex. > However, while closing 'vm', vma is destroyed while holding vm- > >mutex. > But vma releasing needs to take vm->vm_bind_mute

Re: [PATCH v3 1/2] vfio: Replace the DMA unmapping notifier with a callback

2022-07-05 Thread Zhenyu Wang
On 2022.07.04 21:59:03 -0300, Jason Gunthorpe wrote: > Instead of having drivers register the notifier with explicit code just > have them provide a dma_unmap callback op in their driver ops and rely on > the core code to wire it up. > > Suggested-by: Christoph Hellwig > Reviewed-by: Christoph He

[PATCH v2 2/2] drm: Prevent drm_copy_field() to attempt copying a NULL pointer

2022-07-05 Thread Javier Martinez Canillas
There are some struct drm_driver fields that are required by drivers since drm_copy_field() attempts to copy them to user-space via DRM_IOCTL_VERSION. But it can be possible that a driver has a bug and did not set some of the fields, which leads to drm_copy_field() attempting to copy a NULL pointe

[PATCH v3 0/2] Remove the VFIO_IOMMU_NOTIFY_DMA_UNMAP notifier

2022-07-05 Thread Jason Gunthorpe
This is the last notifier toward the drivers, replace it with a simple op callback in the vfio_device_ops. v3: - Remove 'nb' doc string from ccw - Rebase on extern removal patch - Check that register_device/unregister_device are either both defined or not - Remove check of dma_unmap during

RE: [RESEND RFC 18/18] drm/display/dp_mst: Move all payload info into the atomic state

2022-07-05 Thread Lin, Wayne
[Public] > -Original Message- > From: Lyude Paul > Sent: Wednesday, June 8, 2022 3:30 AM > To: dri-devel@lists.freedesktop.org; nouv...@lists.freedesktop.org; amd- > g...@lists.freedesktop.org > Cc: Lin, Wayne ; Ville Syrjälä > ; Zuo, Jerry ; Jani Nikula > ; Imre Deak ; Daniel Vetter >

[PATCH v2 0/2] drm: A couple of fixes for drm_copy_field() helper function

2022-07-05 Thread Javier Martinez Canillas
Hello, Peter Robinson reported me a kernel bug in one of his aarch64 test boards and even though I was not able to reproduce it, I think that figured out what the problem was. It seems the cause is that a DRM driver doesn't set some of the struct drm fields copied to userspace via DRM_IOCTL_VERSIO

Re: [RFC 01/10] drm/i915/vm_bind: Introduce VM_BIND ioctl

2022-07-05 Thread Hellstrom, Thomas
Hi, On Fri, 2022-07-01 at 15:50 -0700, Niranjana Vishwanathapura wrote: > Add VM_BIND and VM_UNBIND ioctls to bind/unbind a section of an > object at the specified GPU virtual addresses. > > Add I915_PARAM_VM_BIND_VERSION to indicate version of VM_BIND feature > supported and I915_VM_CREATE_FLAG

Re: [Linaro-mm-sig] Re: [PATCH v6 02/22] drm/gem: Move mapping of imported dma-bufs to drm_gem_mmap_obj()

2022-07-05 Thread Dmitry Osipenko
On 7/4/22 15:33, Christian König wrote: > Am 30.06.22 um 01:06 schrieb Dmitry Osipenko: >> On 6/29/22 11:43, Thomas Hellström (Intel) wrote: >>> On 6/29/22 10:22, Dmitry Osipenko wrote: On 6/29/22 09:40, Thomas Hellström (Intel) wrote: > On 5/27/22 01:50, Dmitry Osipenko wrote: >> Driv

RE: [PATCH 0/4] Add Toshiba Visconti DNN image processing accelerator driver

2022-07-05 Thread yuji2.ishikawa
Hi Hans, Thank you for your advice. I understand that V4L2 M2M driver is recommended for a group including Affine and Pyramid. As for DSPIF, our application SW engineer said that there is another version of firmware to handle neural network. Therefore, DSP can handle not only images, but also s

Re: [PATCH v6 3/5] fbdev: Disable sysfb device registration when removing conflicting FBs

2022-07-05 Thread Xi Ruoyao
On Mon, 2022-07-04 at 13:04 +0200, Javier Martinez Canillas wrote: > Hello Xi, > > > > With CONFIG_SYSFB_SIMPLEFB and CONFIG_FB_SIMPLE enabled, there is no > > issue. > > > > I guess it's something going wrong on a "drm -> drm" pass over.  For now > > I'll continue to use simpledrm with this comm

Re: [Freedreno] [PATCH] drm/msm/dp: make eDP panel as the first connected connector

2022-07-05 Thread Abhinav Kumar
On 7/4/2022 11:14 AM, Dmitry Baryshkov wrote: On 30/06/2022 09:14, Dmitry Baryshkov wrote: On 30 June 2022 04:57:35 GMT+03:00, Rob Clark wrote: On Wed, Jun 29, 2022 at 5:36 PM Doug Anderson wrote: Hi, On Tue, Jun 28, 2022 at 1:14 PM Dmitry Baryshkov wrote: On 28 June 2022 18:20:06

Re: [PATCH v6 14/22] dma-buf: Introduce new locking convention

2022-07-05 Thread Dmitry Osipenko
On 7/5/22 01:38, Dmitry Osipenko wrote: ... >>> Also i915 will run into trouble with attach. In particular since i915 >>> starts a full ww transaction in its attach callback to be able to lock >>> other objects if migration is needed. I think i915 CI would catch this >>> in a selftest. >> Seems it

Re: [PATCH v3 1/3] dt-bindings: phy: qcom,hdmi-phy-qmp: add clock-cells and XO clock

2022-07-05 Thread Vinod Koul
On 04-07-22, 19:11, Dmitry Baryshkov wrote: > As the QMP HDMI PHY is a clock provider, add constant #clock-cells > property. For the compatibility with older DTs the property is not > marked as required. Also add the XO clock to the list of the clocks used > by the driver. Acked-By: Vinod Koul >

Re: [PATCH v8 1/2] drm/gem: Properly annotate WW context on drm_gem_lock_reservations() error

2022-07-05 Thread Christian König
Am 01.07.22 um 11:02 schrieb Dmitry Osipenko: Use ww_acquire_fini() in the error code paths. Otherwise lockdep thinks that lock is held when lock's memory is freed after the drm_gem_lock_reservations() error. The ww_acquire_context needs to be annotated as "released", which fixes the noisy "WARNI

Re: [PATCH v8 2/2] drm/gem: Don't map imported GEMs

2022-07-05 Thread Christian König
Am 01.07.22 um 11:02 schrieb Dmitry Osipenko: Drivers that use drm_gem_mmap() and drm_gem_mmap_obj() helpers don't handle imported dma-bufs properly, which results in mapping of something else than the imported dma-buf. On NVIDIA Tegra we get a hard lockup when userspace writes to the memory mapp

[PATCH v2 0/7] Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

2022-07-05 Thread Gwan-gyeong Mun
This patch series fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation, etc. We need to check that we avoid integer overflows when looking up a page, and so fix all the instances where we have mistakenly used a plain integer instead o

[PATCH v2 1/7] drm: Move and add a few utility macros into drm util header

2022-07-05 Thread Gwan-gyeong Mun
It moves overflows_type utility macro into drm util header from i915_utils header. The overflows_type can be used to catch the truncation between data types. And it adds safe_conversion() macro which performs a type conversion (cast) of an source value into a new variable, checking that the destina

[PATCH v2 2/7] drm/i915/gem: Typecheck page lookups

2022-07-05 Thread Gwan-gyeong Mun
From: Chris Wilson We need to check that we avoid integer overflows when looking up a page, and so fix all the instances where we have mistakenly used a plain integer instead of a more suitable long. Be pedantic and add integer typechecking to the lookup so that we can be sure that we are safe. A

[PATCH v2 3/7] drm/i915: Check for integer truncation on scatterlist creation

2022-07-05 Thread Gwan-gyeong Mun
From: Chris Wilson There is an impedance mismatch between the scatterlist API using unsigned int and our memory/page accounting in unsigned long. That is we may try to create a scatterlist for a large object that overflows returning a small table into which we try to fit very many pages. As the o

[PATCH v2 4/7] drm/i915: Check for integer truncation on the configuration of ttm place

2022-07-05 Thread Gwan-gyeong Mun
There is an impedance mismatch between the first/last valid page frame number of ttm place in unsigned and our memory/page accounting in unsigned long. As the object size is under the control of userspace, we have to be prudent and catch the conversion errors. To catch the implicit truncation as we

[PATCH v2 6/7] drm/i915: Use error code as -E2BIG when the size of gem ttm object is too large

2022-07-05 Thread Gwan-gyeong Mun
The ttm_bo_init_reserved() functions returns -ENOSPC if the size is too big to add vma. The direct function that returns -ENOSPC is drm_mm_insert_node_in_range(). To handle the same error as other code returning -E2BIG when the size is too large, it converts return value to -E2BIG. Signed-off-by:

[PATCH v2 5/7] drm/i915: Check if the size is too big while creating shmem file

2022-07-05 Thread Gwan-gyeong Mun
The __shmem_file_setup() function returns -EINVAL if size is greater than MAX_LFS_FILESIZE. To handle the same error as other code that returns -E2BIG when the size is too large, it add a code that returns -E2BIG when the size is larger than the size that can be handled. Signed-off-by: Gwan-gyeong

[PATCH v2 7/7] drm/i915: Remove truncation warning for large objects

2022-07-05 Thread Gwan-gyeong Mun
From: Chris Wilson Having addressed the issues surrounding incorrect types for local variables and potential integer truncation in using the scatterlist API, we have closed all the loop holes we had previously identified with dangerously large object creation. As such, we can eliminate the warnin

Re: [PATCH v4 04/14] dt-bindings: dma: dw-axi-dmac: extend the number of interrupts

2022-07-05 Thread Vinod Koul
On 01-07-22, 20:22, Conor Dooley wrote: > From: Conor Dooley > > The Canaan k210 apparently has a Sysnopsys Designware AXI DMA > controller, but according to the documentation & devicetree it has 6 > interrupts rather than the standard one. Support the 6 interrupt > configuration by unconditional

[PATCH] drm/nouveau: fix a use-after-free in nouveau_gem_prime_import_sg_table()

2022-07-05 Thread Jianglei Nie
nouveau_bo_init() is backed by ttm_bo_init() and ferries its return code back to the caller. On failures, ttm will call nouveau_bo_del_ttm() and free the memory.Thus, when nouveau_bo_init() returns an error, the gem object has already been released. Then the call to nouveau_bo_ref() will use the fr

[PATCH] drm/amdgpu/mes: Fix an error handling path in amdgpu_mes_self_test()

2022-07-05 Thread Jianglei Nie
if amdgpu_mes_ctx_alloc_meta_data() fails, we should call amdgpu_vm_fini() to handle amdgpu_vm_init(). Add a new lable before amdgpu_vm_init() and goto this lable when amdgpu_mes_ctx_alloc_meta_data() fails. Signed-off-by: Jianglei Nie --- drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 4 +++- 1 fil

RE: [Intel-gfx] [RFC 05/10] drm/i915/vm_bind: Handle persistent vmas

2022-07-05 Thread Zeng, Oak
Thanks, Oak > -Original Message- > From: C, Ramalingam > Sent: July 5, 2022 5:20 AM > To: Zeng, Oak > Cc: Vishwanathapura, Niranjana ; > intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Vetter, > Daniel ; christian.koe...@amd.com; Hellstrom, > Thomas ; Zanoni, Paulo R

Re: [PATCH v7 7/9] drm/virtio: Improve DMA API usage for shmem BOs

2022-07-05 Thread Gerd Hoffmann
Hi, > - * So for the moment keep things as-is, with a bulky comment > - * for the next person who feels like removing this > - * drm_dev_set_unique() quirk. Dragons lurking here. It's not the first attempt to ditch this, and so far all have been rolled back due to regressions.

Re: [PATCH v2 1/7] drm: Move and add a few utility macros into drm util header

2022-07-05 Thread Mauro Carvalho Chehab
On Tue, 5 Jul 2022 15:24:49 +0300 Gwan-gyeong Mun wrote: > It moves overflows_type utility macro into drm util header from i915_utils > header. The overflows_type can be used to catch the truncation between data > types. And it adds safe_conversion() macro which performs a type conversion > (cas

Re: [PATCH v7 7/9] drm/virtio: Improve DMA API usage for shmem BOs

2022-07-05 Thread Dmitry Osipenko
Hello Gerd, On 7/5/22 16:53, Gerd Hoffmann wrote: > Hi, > >> - * So for the moment keep things as-is, with a bulky comment >> - * for the next person who feels like removing this >> - * drm_dev_set_unique() quirk. > > Dragons lurking here. It's not the first attempt to ditch this,

RE: [PATCH] drm/amdgpu: Fix GTT size reporting in amdgpu_ioctl

2022-07-05 Thread Chen, Guchun
Hi Alex, I think we need to revert this patch on amd-staging-drm-next branch, as its base commit like " drm/amdgpu: remove GTT accounting v2" does not present on 5.16. Instead, the series is part of upcoming 5.18 based amd-staging-drm-next branch. Otherwise, incorrect GTT size reporting switche

Re: [PATCH v2 2/7] drm/i915/gem: Typecheck page lookups

2022-07-05 Thread Mauro Carvalho Chehab
On Tue, 5 Jul 2022 15:24:50 +0300 Gwan-gyeong Mun wrote: > From: Chris Wilson > > We need to check that we avoid integer overflows when looking up a page, > and so fix all the instances where we have mistakenly used a plain > integer instead of a more suitable long. Be pedantic and add integer

Re: [PATCH v2 4/7] drm/i915: Check for integer truncation on the configuration of ttm place

2022-07-05 Thread Mauro Carvalho Chehab
On Tue, 5 Jul 2022 15:24:52 +0300 Gwan-gyeong Mun wrote: > There is an impedance mismatch between the first/last valid page > frame number of ttm place in unsigned and our memory/page accounting in > unsigned long. > As the object size is under the control of userspace, we have to be prudent > a

Re: [PATCH v2 3/7] drm/i915: Check for integer truncation on scatterlist creation

2022-07-05 Thread Mauro Carvalho Chehab
On Tue, 5 Jul 2022 15:24:51 +0300 Gwan-gyeong Mun wrote: > From: Chris Wilson > > There is an impedance mismatch between the scatterlist API using unsigned > int and our memory/page accounting in unsigned long. That is we may try > to create a scatterlist for a large object that overflows retu

Re: [PATCH v2 5/7] drm/i915: Check if the size is too big while creating shmem file

2022-07-05 Thread Mauro Carvalho Chehab
On Tue, 5 Jul 2022 15:24:53 +0300 Gwan-gyeong Mun wrote: > The __shmem_file_setup() function returns -EINVAL if size is greater than > MAX_LFS_FILESIZE. To handle the same error as other code that returns > -E2BIG when the size is too large, it add a code that returns -E2BIG when > the size is l

Re: [PATCH v2 6/7] drm/i915: Use error code as -E2BIG when the size of gem ttm object is too large

2022-07-05 Thread Mauro Carvalho Chehab
On Tue, 5 Jul 2022 15:24:54 +0300 Gwan-gyeong Mun wrote: > The ttm_bo_init_reserved() functions returns -ENOSPC if the size is too big > to add vma. The direct function that returns -ENOSPC is > drm_mm_insert_node_in_range(). > To handle the same error as other code returning -E2BIG when the si

Re: [PATCH v2 7/7] drm/i915: Remove truncation warning for large objects

2022-07-05 Thread Mauro Carvalho Chehab
On Tue, 5 Jul 2022 15:24:55 +0300 Gwan-gyeong Mun wrote: > From: Chris Wilson > > Having addressed the issues surrounding incorrect types for local > variables and potential integer truncation in using the scatterlist API, > we have closed all the loop holes we had previously identified with >

Re: [PATCH] drm/amdgpu/mes: Fix an error handling path in amdgpu_mes_self_test()

2022-07-05 Thread Alex Deucher
Applied. Thanks! On Tue, Jul 5, 2022 at 9:46 AM Jianglei Nie wrote: > > if amdgpu_mes_ctx_alloc_meta_data() fails, we should call amdgpu_vm_fini() > to handle amdgpu_vm_init(). > > Add a new lable before amdgpu_vm_init() and goto this lable when > amdgpu_mes_ctx_alloc_meta_data() fails. > > Sign

Re: [PATCH] drm/amdpgu/debugfs: Simplify some exit paths

2022-07-05 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 4, 2022 at 12:23 PM Christian König wrote: > > Am 04.07.22 um 15:45 schrieb André Almeida: > > To avoid code repetition, unify the function exit path when possible. No > > functional changes. > > > > Signed-off-by: André Almeida > > Acked-by: Christian König > > >

Re: connecting a sn65dsi86 to displayport connector

2022-07-05 Thread Kieran Bingham
Hi Rasmus, Quoting Rasmus Villemoes (2022-07-05 10:08:37) > Hi > > I have an imx8mp board with a sn65dsi86 and a (full-size) DisplayPort > connector, which I'm trying to get up and running. > > The display connector registers itself as a bridge; I do get > successfully to the end of display_conn

Re: [PATCH] drm/amd/display: Remove return value of Calculate256BBlockSizes

2022-07-05 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Jun 30, 2022 at 2:50 PM Maíra Canal wrote: > > The function Calculate256BBlockSizes always returns true, regardless of > the parameters. As any file checks the return of the function, this > commit changes the return value to void. > > Signed-off-by: Maíra Canal >

Re: [PATCH -next] drm/amd/display: clean up some inconsistent indenting

2022-07-05 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Jul 1, 2022 at 5:24 AM Yang Li wrote: > > Eliminate the follow smatch warning: > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3151 > commit_planes_for_stream() warn: inconsistent indenting > > Signed-off-by: Yang Li > --- > drivers/gpu/drm/amd/display/dc/c

Re: [PATCH] drm/amd/display: Remove duplicate code across dcn30 and dcn31

2022-07-05 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Jun 30, 2022 at 4:18 PM Maíra Canal wrote: > > The function CalculateBytePerPixelAnd256BBlockSizes was defined four > times: on display_mode_vba_30.c, display_rq_dlg_calc_30.c, > display_mode_vba_31.c and display_rq_dlg_calc_31.c. In order to avoid > code duplicati

Re: [PATCH] drm/amd/display: Remove unused variables from vba_vars_st

2022-07-05 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Jun 30, 2022 at 5:53 PM Maíra Canal wrote: > > Some variables from the struct vba_vars_st are not referenced in any > other place on the codebase. As they are not used, this commit removes > those variables. > > Signed-off-by: Maíra Canal > --- > > Unused variable

Re: [PATCH RESEND V2 1/3] drm/amdgpu: fix checkpatch warnings

2022-07-05 Thread Mukunda,Vijendar
On 7/5/22 4:51 PM, Christian König wrote: > > > Am 04.07.22 um 15:54 schrieb Vijendar Mukunda: >> From: vijendar >> >> Fixed below checkpatch warnings and errors >> >> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:131: CHECK: Comparison to NULL >> could be written "apd" >> drivers/gpu/drm/amd/amdgpu/a

Re: [PATCH v7 7/9] drm/virtio: Improve DMA API usage for shmem BOs

2022-07-05 Thread Gerd Hoffmann
Hi, > > Also note that pci is not the only virtio transport we have. > > The VirtIO indeed has other transports, but only PCI is really supported > in case of the VirtIO-GPU in kernel and in Qemu/crosvm, AFAICT. Hence > only the PCI transport was tested. qemu -M microvm \ -global virtio-mmio

Re: [PATCH v2 1/4] drm/vmwgfx: Stop using 'TRUE'

2022-07-05 Thread Zack Rusin
On Jun 30, 2022, at 3:51 PM, Ville Syrjala mailto:ville.syrj...@linux.intel.com>> wrote: From: Ville Syrjälä mailto:ville.syrj...@linux.intel.com>> Stop using the 'TRUE' define. This ultimately gets defined by acpi/actypes.h that gets included here via a convoluted chain of other headers. drm_

[PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-07-05 Thread Kuogee Hsieh
0) rebase on https://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git tree 1) add regulator_set_load() to eDP phy 2) add regulator_set_load() to DP phy 3) remove vdda related function out of eDP/DP controller Kuogee Hsieh (3): phy: qcom-edp: add regulator_set_load to edp phy phy: qco

[PATCH v16 1/3] phy: qcom-edp: add regulator_set_load to edp phy

2022-07-05 Thread Kuogee Hsieh
This patch add regulator_set_load() before enable regulator at eDP phy driver. Signed-off-by: Kuogee Hsieh Reviewed-by: Douglas Anderson Reviewed-by: Dmitry Baryshkov --- drivers/phy/qualcomm/phy-qcom-edp.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/phy/qualcomm/

[PATCH v16 2/3] phy: qcom-qmp: add regulator_set_load to dp phy

2022-07-05 Thread Kuogee Hsieh
This patch add regulator_set_load() before enable regulator at DP phy driver. Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd Reviewed-by: Douglas Anderson --- drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 41 --- 1 file changed, 32 insertions(+), 9 deletions(-)

[PATCH v16 3/3] drm/msm/dp: delete vdda regulator related functions from eDP/DP controller

2022-07-05 Thread Kuogee Hsieh
Vdda regulators are related to both eDP and DP phy so that it should be managed at eDP and DP phy driver instead of controller. This patch removes vdda regulators related functions out of eDP/DP controller. Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd Reviewed-by: Dmitry Baryshkov Revi

[PATCH v4 3/7] drm/msm/dp: Add basic PSR support for eDP

2022-07-05 Thread Vinod Polimera
Add support for basic panel self refresh (PSR) feature for eDP. Add a new interface to set PSR state in the sink from DPU. Program the eDP controller to issue PSR enter and exit SDP to the sink. Signed-off-by: Sankeerth Billakanti Signed-off-by: Vinod Polimera --- drivers/gpu/drm/msm/dp/dp_cata

[PATCH v4 6/7] drm/msm/disp/dpu1: use atomic enable/disable callbacks for encoder functions

2022-07-05 Thread Vinod Polimera
Use atomic variants for encoder callback functions such that certain states like self-refresh can be accessed as part of enable/disable sequence. Signed-off-by: Kalyan Thota Signed-off-by: Vinod Polimera Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 10 ++

[PATCH v4 0/7] Add PSR support for eDP

2022-07-05 Thread Vinod Polimera
Changes in v2: - Use dp bridge to set psr entry/exit instead of dpu_enocder. - Don't modify whitespaces. - Set self refresh aware from atomic_check. - Set self refresh aware only if psr is supported. - Provide a stub for msm_dp_display_set_psr. - Move dp functions to bridge code. Chang

[PATCH v4 2/7] drm: add helper functions to retrieve old and new crtc

2022-07-05 Thread Vinod Polimera
Add new helper functions, drm_atomic_get_old_crtc_for_encoder and drm_atomic_get_new_crtc_for_encoder to retrieve the corresponding crtc for the encoder. Signed-off-by: Sankeerth Billakanti Signed-off-by: Vinod Polimera --- drivers/gpu/drm/drm_atomic.c | 60 +

[PATCH v4 5/7] drm/bridge: Add psr support for panel bridge callbacks

2022-07-05 Thread Vinod Polimera
This change will handle the psr entry exit cases in the panel bridge atomic callback functions. For example, the panel power should not turn off if the panel is entering psr. Signed-off-by: Sankeerth Billakanti Signed-off-by: Vinod Polimera --- drivers/gpu/drm/bridge/panel.c | 48 ++

[PATCH v4 1/7] drm/msm/disp/dpu1: clear dpu_assign_crtc and get crtc from drm_enc instead of dpu_enc

2022-07-05 Thread Vinod Polimera
Update crtc retrieval from dpu_enc to drm_enc, since new links get set as part of the update legacy mode set. The dpu_enc->crtc cache is no more needed, hence cleaning it as part of this change. Signed-off-by: Vinod Polimera --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 4 drivers/gpu/

[PATCH v4 7/7] drm/msm/disp/dpu1: add PSR support for eDP interface in dpu driver

2022-07-05 Thread Vinod Polimera
Enable PSR on eDP interface using drm self-refresh librabry. This patch uses a trigger from self-refresh library to enter/exit into PSR, when there are no updates from framework. Signed-off-by: Kalyan Thota Signed-off-by: Vinod Polimera --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 13 +

[PATCH v4 4/7] drm/bridge: use atomic enable/disable callbacks for panel bridge

2022-07-05 Thread Vinod Polimera
Use atomic variants for panel bridge callback functions such that certain states like self-refresh can be accessed as part of enable/disable sequence. Signed-off-by: Sankeerth Billakanti Signed-off-by: Vinod Polimera --- drivers/gpu/drm/bridge/panel.c | 20 1 file changed,

Re: [PATCH v7 7/9] drm/virtio: Improve DMA API usage for shmem BOs

2022-07-05 Thread Dmitry Osipenko
On 7/5/22 18:45, Gerd Hoffmann wrote: > Hi, > >>> Also note that pci is not the only virtio transport we have. >> >> The VirtIO indeed has other transports, but only PCI is really supported >> in case of the VirtIO-GPU in kernel and in Qemu/crosvm, AFAICT. Hence >> only the PCI transport was tes

Re: [PATCH v4 1/7] drm/msm/disp/dpu1: clear dpu_assign_crtc and get crtc from drm_enc instead of dpu_enc

2022-07-05 Thread Dmitry Baryshkov
On 05/07/2022 20:00, Vinod Polimera wrote: Update crtc retrieval from dpu_enc to drm_enc, since new links get set as part of the update legacy mode set. The dpu_enc->crtc cache is no more needed, hence cleaning it as part of this change. NAK. Quoting the documentation: only really meaningful f

Re: [PATCH v4 02/14] dt-bindings: display: ili9341: document canaan kd233's lcd

2022-07-05 Thread Rob Herring
On Fri, 01 Jul 2022 20:22:48 +0100, Conor Dooley wrote: > From: Conor Dooley > > The Canaan KD233 development board has a built in LCD. > Add a specific compatible for it. > > Signed-off-by: Conor Dooley > --- > .../devicetree/bindings/display/panel/ilitek,ili9341.yaml| 1 + > 1 file c

Re: [PATCH v4 4/7] drm/bridge: use atomic enable/disable callbacks for panel bridge

2022-07-05 Thread Dmitry Baryshkov
On 05/07/2022 20:00, Vinod Polimera wrote: Use atomic variants for panel bridge callback functions such that certain states like self-refresh can be accessed as part of enable/disable sequence. Signed-off-by: Sankeerth Billakanti Signed-off-by: Vinod Polimera Reviewed-by: Dmitry Baryshkov

Re: [PATCH v4 6/7] drm/msm/disp/dpu1: use atomic enable/disable callbacks for encoder functions

2022-07-05 Thread Dmitry Baryshkov
On 05/07/2022 20:00, Vinod Polimera wrote: Use atomic variants for encoder callback functions such that certain states like self-refresh can be accessed as part of enable/disable sequence. Signed-off-by: Kalyan Thota Signed-off-by: Vinod Polimera Reviewed-by: Dmitry Baryshkov No. Your sign

Re: [PATCH v4 7/7] drm/msm/disp/dpu1: add PSR support for eDP interface in dpu driver

2022-07-05 Thread Dmitry Baryshkov
On 05/07/2022 20:00, Vinod Polimera wrote: Enable PSR on eDP interface using drm self-refresh librabry. This patch uses a trigger from self-refresh library to enter/exit into PSR, when there are no updates from framework. Signed-off-by: Kalyan Thota Signed-off-by: Vinod Polimera --- drivers/

Re: [PATCH v4 05/14] dt-bindings: memory-controllers: add canaan k210 sram controller

2022-07-05 Thread Rob Herring
On Fri, Jul 01, 2022 at 08:22:51PM +0100, Conor Dooley wrote: > From: Conor Dooley > > The k210 U-Boot port has been using the clocks defined in the > devicetree to bring up the board's SRAM, but this violates the > dt-schema. As such, move the clocks to a dedicated node with > the same compatibl

Re: [PATCH v4 3/7] drm/msm/dp: Add basic PSR support for eDP

2022-07-05 Thread Dmitry Baryshkov
On 05/07/2022 20:00, Vinod Polimera wrote: Add support for basic panel self refresh (PSR) feature for eDP. Add a new interface to set PSR state in the sink from DPU. Program the eDP controller to issue PSR enter and exit SDP to the sink. Signed-off-by: Sankeerth Billakanti Signed-off-by: Vinod

Re: flush_icache_range in the sticore driver

2022-07-05 Thread James Bottomley
On Tue, 2022-07-05 at 18:46 +0200, Christoph Hellwig wrote: > Hi all, > > flush_icache_range is supposed to flush the instruction cache, which > is something no driver should be doing. It was added in commit > 03b18f1b2afe ("[PARISC] Clean up sti_flush") but the explanation in > there looks odd.

[pull] amdgpu, amdkfd, radeon drm-next-5.20

2022-07-05 Thread Alex Deucher
Hi Dave, Daniel, New stuff for 5.20. The following changes since commit bf23729c7a5f44f0e863666b9364a64741fd3241: Merge tag 'amd-drm-next-5.19-2022-05-26-2' of https://gitlab.freedesktop.org/agd5f/linux into drm-next (2022-06-01 10:56:11 +1000) are available in the Git repository at: htt

[PATCH 0/3] drm: rename CMA helpers to DMA helpers

2022-07-05 Thread Danilo Krummrich
This patch series renames all CMA helpers to DMA helpers - considering the hierarchy of APIs (mm/cma -> dma -> gem/fb dma helpers) calling them DMA helpers seems to be more applicable. Additionally, commit e57924d4ae80 ("drm/doc: Task to rename CMA helpers") requests to rename the CMA helpers and

[PATCH 3/3] drm/todo: remove task to rename CMA helpers

2022-07-05 Thread Danilo Krummrich
Both, GEM and FB, CMA helpers were renamed to "GEM DMA" and "FB DMA", hence the task can be removed. Signed-off-by: Danilo Krummrich --- Documentation/gpu/todo.rst | 13 - 1 file changed, 13 deletions(-) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index 10bf

[PATCH 1/3] drm/fb: rename FB CMA helpers to FB DMA helpers

2022-07-05 Thread Danilo Krummrich
Rename "FB CMA" helpers to "FB DMA" helpers - considering the hierarchy of APIs (mm/cma -> dma -> fb dma) calling them "FB DMA" seems to be more applicable. Besides that, commit e57924d4ae80 ("drm/doc: Task to rename CMA helpers") requests to rename the CMA helpers and implies that people seem to

Re: [PATCH v7 7/9] drm/virtio: Improve DMA API usage for shmem BOs

2022-07-05 Thread Rob Clark
On Tue, Jul 5, 2022 at 10:02 AM Dmitry Osipenko wrote: > > On 7/5/22 18:45, Gerd Hoffmann wrote: > > Hi, > > > >>> Also note that pci is not the only virtio transport we have. > >> > >> The VirtIO indeed has other transports, but only PCI is really supported > >> in case of the VirtIO-GPU in ker

Re: [PATCH v8 2/2] drm/gem: Don't map imported GEMs

2022-07-05 Thread Rob Clark
On Tue, Jul 5, 2022 at 4:51 AM Christian König wrote: > > Am 01.07.22 um 11:02 schrieb Dmitry Osipenko: > > Drivers that use drm_gem_mmap() and drm_gem_mmap_obj() helpers don't > > handle imported dma-bufs properly, which results in mapping of something > > else than the imported dma-buf. On NVIDI

Re: [PATCH v7 7/9] drm/virtio: Improve DMA API usage for shmem BOs

2022-07-05 Thread Dmitry Osipenko
On 7/6/22 00:39, Rob Clark wrote: > On Tue, Jul 5, 2022 at 10:02 AM Dmitry Osipenko > wrote: >> >> On 7/5/22 18:45, Gerd Hoffmann wrote: >>> Hi, >>> > Also note that pci is not the only virtio transport we have. The VirtIO indeed has other transports, but only PCI is really support

[linux-next:master] BUILD REGRESSION 2a2aa3f05338270aecbe2492fda910d6c17e0102

2022-07-05 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 2a2aa3f05338270aecbe2492fda910d6c17e0102 Add linux-next specific files for 20220705 Error/Warning reports: https://lore.kernel.org/linux-doc/202207051821.3f0erisl-...@intel.com Error/Warning

Re: [PATCH 1/4] drm/bridge: anx7625: Convert to devm_i2c_new_dummy_device()

2022-07-05 Thread Xin Ji
Hi Hsin-Yi, thanks for your patch, looks good to me. Reviewed-by: Xin Ji On Thu, Jun 30, 2022 at 12:05:47AM +0800, Hsin-Yi Wang wrote: > Simplify the resource management. > > Signed-off-by: Hsin-Yi Wang > --- > drivers/gpu/drm/bridge/analogix/anx7625.c | 96 +++ > 1 file c

Re: [PATCH 2/4] drm/bridge: anx7625: Use pm_runtime_force_suspend(resume)

2022-07-05 Thread Xin Ji
Hi Hsin-Yi, thanks for your patch, looks good to me. Reviewed-by: Xin Ji Thanks, Xin On Thu, Jun 30, 2022 at 12:05:48AM +0800, Hsin-Yi Wang wrote: > There's no need to check for IRQ or disable it in suspend. > > Use pm_runtime_force_suspend(resume) to make sure anx7625 is powered off > correctl

  1   2   >