Re: [PATCH v3 12/14] leds: mt6370: Add Mediatek MT6370 current sink type LED Indicator support

2022-06-24 Thread szuni chen
Hi Linus, Thank you for the comment. Linus Walleij 於 2022年6月24日 週五 下午2:25寫道: > > On Fri, Jun 24, 2022 at 8:23 AM Linus Walleij > wrote: > > Thanks for your patch! > > > > On Thu, Jun 23, 2022 at 1:58 PM ChiaEn Wu wrote: > > > > > From: ChiYuan Huang > > > > > > Add Mediatek MT6370 current si

Re: [PATCH] drm/ast: Fix black screen when getting out of suspend

2022-06-24 Thread Thomas Zimmermann
Hi Am 22.06.22 um 14:48 schrieb Jocelyn Falempe: With an AST2600, the screen is garbage when going out of suspend. This is because color settings are lost, and not restored on resume. Force the color settings on DPMS_ON, to make sure the settings are correct. I didn't write this code, it comes

Re: [PATCH] drm/rockchip: vop: Don't crash for invalid duplicate_state()

2022-06-24 Thread Heiko Stuebner
Am Freitag, 24. Juni 2022, 01:44:52 CEST schrieb Doug Anderson: > Hi, > > On Fri, Jun 17, 2022 at 5:27 PM Brian Norris wrote: > > > > It's possible for users to try to duplicate the CRTC state even when the > > state doesn't exist. drm_atomic_helper_crtc_duplicate_state() (and other > > users of

[RFC] Per file OOM-badness / RSS once more

2022-06-24 Thread Christian König
Hello everyone, To summarize the issue I'm trying to address here: Processes can allocate resources through a file descriptor without being held responsible for it. I'm not explaining all the details again. See here for a more deeply description of the problem: https://lwn.net/ml/linux-kernel/20

[PATCH 01/14] fs: add per file RSS

2022-06-24 Thread Christian König
From: Andrey Grodzovsky Some files allocate large amounts of memory on behalf of userspace without any on disk backing store. This memory isn't necessarily mapped into the address space, but should still accounts towards the RSS of a process just like mapped shared pages do. That information can

[PATCH 02/14] oom: take per file RSS into account

2022-06-24 Thread Christian König
From: Andrey Grodzovsky Try to make better decisions which process to kill based on per file RSS. Signed-off-by: Andrey Grodzovsky --- mm/oom_kill.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/mm/oom_kill.c b/mm/oom_kill.c index 3c6cf9e3cd66..76a5ea73eb6a

[PATCH 03/14] proc: expose per file RSS

2022-06-24 Thread Christian König
Add the per file RSS to the memory management accounting. This allows to see the per file RSS in tools like top as well. Signed-off-by: Christian König --- fs/proc/array.c | 7 +-- fs/proc/internal.h | 3 ++- fs/proc/task_mmu.c | 6 -- fs/proc/task_nommu.c | 3 ++- 4 files chan

[PATCH 06/14] drm/gem: adjust per file RSS on handling buffers

2022-06-24 Thread Christian König
From: Andrey Grodzovsky Large amounts of VRAM are usually not CPU accessible, so they are not mapped into the processes address space. But since the device drivers usually support swapping buffers from VRAM to system memory we can still run into an out of memory situation when userspace starts to

[PATCH 04/14] mm: shmem: provide RSS for shmem files

2022-06-24 Thread Christian König
This gives the OOM killer an additional hint which processes are referencing shmem files with potentially no other accounting for them. Signed-off-by: Christian König --- mm/shmem.c | 16 1 file changed, 16 insertions(+) diff --git a/mm/shmem.c b/mm/shmem.c index a6f565308133..

[PATCH 07/14] drm/gma500: use drm_file_rss

2022-06-24 Thread Christian König
This allows the OOM killer to make a better decision which process to reap. Signed-off-by: Christian König --- drivers/gpu/drm/gma500/psb_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm/gma500/psb_drv.c index 1d8744f3e702..92c005aa6e9e

[PATCH 05/14] dma-buf: provide file RSS for DMA-buf files

2022-06-24 Thread Christian König
Just return the size of the DMA-buf in pages since pages allocated or mapped through DMA-bufs are usually not accounted elsewhere. Signed-off-by: Christian König --- drivers/dma-buf/dma-buf.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dm

[PATCH 08/14] drm/amdgpu: use drm_file_rss

2022-06-24 Thread Christian König
From: Andrey Grodzovsky This allows the OOM killer to make a better decision which process to reap. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/driv

[PATCH 09/14] drm/radeon: use drm_oom_badness

2022-06-24 Thread Christian König
This allows the OOM killer to make a better decision which process to reap. Signed-off-by: Christian König --- drivers/gpu/drm/radeon/radeon_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c index 956c72b5aa33..11

[PATCH 10/14] drm/i915: use drm_file_rss

2022-06-24 Thread Christian König
This allows the OOM killer to make a better decision which process to reap. Signed-off-by: Christian König --- drivers/gpu/drm/i915/i915_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c index 90b0ce5051af..fc269

[PATCH 11/14] drm/nouveau: use drm_file_rss

2022-06-24 Thread Christian König
This allows the OOM killer to make a better decision which process to reap. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_drm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c index 561309d447

[PATCH 12/14] drm/omap: use drm_file_rss

2022-06-24 Thread Christian König
This allows the OOM killer to make a better decision which process to reap. Signed-off-by: Christian König --- drivers/gpu/drm/omapdrm/omap_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c index eaf67b9e5f12..dff63

[PATCH 13/14] drm/vmwgfx: use drm_file_rss

2022-06-24 Thread Christian König
This allows the OOM killer to make a better decision which process to reap. Signed-off-by: Christian König --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c index 01a5b47e95f9..99

[PATCH 14/14] drm/tegra: use drm_file_rss

2022-06-24 Thread Christian König
This allows the OOM killer to make a better decision which process to reap. Signed-off-by: Christian König --- drivers/gpu/drm/tegra/drm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c index 4cdc8faf798f..cc0c2fc57250 100644 --- a/d

Re: [PATCH 0/3] drm: Test for primary plane in new drm_atomic_helper_check_crtc_state()

2022-06-24 Thread Jocelyn Falempe
On 17/06/2022 12:32, Thomas Zimmermann wrote: Provide drm_atomic_helper_check_crtc_state() for validating a CRTC state against common constraints. As many CRTC need a primary plane to work correctly, add this as the first test. The simple-KMS helpers already contain related code. Convert it to t

Re: DMA-buf and uncached system memory

2022-06-24 Thread Lucas Stach
Am Freitag, dem 24.06.2022 um 08:54 +0200 schrieb Christian König: > Am 23.06.22 um 17:26 schrieb Lucas Stach: > > Am Donnerstag, dem 23.06.2022 um 14:52 +0200 schrieb Christian König: > > > Am 23.06.22 um 14:14 schrieb Lucas Stach: > > > > Am Donnerstag, dem 23.06.2022 um 13:54 +0200 schrieb Chris

Re: [Intel-gfx] [PATCH v5 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-24 Thread Tvrtko Ursulin
On 24/06/2022 06:32, Niranjana Vishwanathapura wrote: VM_BIND and related uapi definitions v2: Reduce the scope to simple Mesa use case. v3: Expand VM_UNBIND documentation and add I915_GEM_VM_BIND/UNBIND_FENCE_VALID and I915_GEM_VM_BIND_TLB_FLUSH flags. v4: Remove I915_GEM_VM_BIND_TL

Re: [PATCH] drm/exynos: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2022-06-24 Thread Inki Dae
22. 6. 16. 16:22에 hongao 이(가) 쓴 글: > Once EDID is parsed, the monitor HDMI support information is available > through drm_display_info.is_hdmi. > > This driver calls drm_detect_hdmi_monitor() to receive the same > information, which is less efficient. > > Avoid calling drm_detect_hdmi_monitor(

Re: [PATCH v11 20/24] arm64: dts: rockchip: enable vop2 and hdmi tx on rock-3a

2022-06-24 Thread Piotr Oniszczuk
> Wiadomość napisana przez Piotr Oniszczuk w dniu > 14.05.2022, o godz. 15:58: > > > >> Wiadomość napisana przez Peter Geis w dniu 09.05.2022, >> o godz. 18:00: >> >> If you want to confirm the hardware is configured correctly you can >> remove the cec pin from the hdmi node and set up a

Re: [Intel-gfx] [PATCH v3 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-24 Thread Tvrtko Ursulin
On 23/06/2022 22:05, Zeng, Oak wrote: -Original Message- From: Intel-gfx On Behalf Of Tvrtko Ursulin Sent: June 23, 2022 7:06 AM To: Landwerlin, Lionel G ; Vishwanathapura, Niranjana Cc: Zanoni, Paulo R ; intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Hellstrom, Tho

Re: [PATCH 5/6] drm/i915/gt: Serialize GRDOM access between multiple engine resets

2022-06-24 Thread Tvrtko Ursulin
On 23/06/2022 12:17, Andi Shyti wrote: Hi Mauro, On Wed, Jun 15, 2022 at 04:27:39PM +0100, Mauro Carvalho Chehab wrote: From: Chris Wilson Don't allow two engines to be reset in parallel, as they would both try to select a reset bit (and send requests to common registers) and wait on that r

Re: [PATCH v2 1/4] drm/etnaviv: add simple moving average (SMA)

2022-06-24 Thread Lucas Stach
Hi Christian, Am Dienstag, dem 21.06.2022 um 09:20 +0200 schrieb Christian Gmeiner: > This adds a SMA algorithm inspired by Exponentially weighted moving > average (EWMA) algorithm found in the kernel. > Still not sure about this one. I _feel_ that a simple moving average over a period of one sec

Re: [PATCH v3 05/14] dt-bindings: backlight: Add Mediatek MT6370 backlight

2022-06-24 Thread ChiaEn Wu
Hi Joe, Joe Simmons-Talbott 於 2022年6月23日 週四 晚上9:17寫道: > > On Thu, Jun 23, 2022 at 07:56:22PM +0800, ChiaEn Wu wrote: > > From: ChiYuan Huang > > > > Add mt6370 backlight binding documentation. > > > > Signed-off-by: ChiYuan Huang > > --- > > > > v3 > > - Rename "mediatek,bled-pwm-hys-input-thre

Re: [PATCH v2 2/4] drm/etnaviv: add loadavg accounting

2022-06-24 Thread Lucas Stach
Am Dienstag, dem 21.06.2022 um 09:20 +0200 schrieb Christian Gmeiner: > The GPU has an idle state register where each bit represents the idle > state of a sub-GPU component like FE or TX. Sample this register > every 10ms and calculate a simple moving average over the sub-GPU > component idle state

Re: [PATCH v2 4/4] drm/etnaviv: export loadavg via perfmon

2022-06-24 Thread Lucas Stach
Am Dienstag, dem 21.06.2022 um 09:20 +0200 schrieb Christian Gmeiner: > Make it possible to access the sub-GPU component load value from > user space with the perfmon infrastructure. > You need to explain a bit more how you intend to use those. Contrary to all other perfmon values, where we go to

Re: [PATCH v3 14/14] video: backlight: mt6370: Add Mediatek MT6370 support

2022-06-24 Thread ChiaEn Wu
Hi Daniel, Thanks for your comments! Daniel Thompson 於 2022年6月23日 週四 晚上9:43寫道: > > On Thu, Jun 23, 2022 at 07:56:31PM +0800, ChiaEn Wu wrote: > > From: ChiaEn Wu > > > > Add Mediatek MT6370 Backlight support. > > > > Signed-off-by: ChiaEn Wu > > > diff --git a/drivers/video/backlight/Kconfig

Re: [PATCH v3 07/14] mfd: mt6370: Add Mediatek MT6370 support

2022-06-24 Thread ChiaEn Wu
Hi Andy, Thanks for your helpful comments! We have some questions below. Andy Shevchenko 於 2022年6月24日 週五 凌晨2:01寫道: > > On Thu, Jun 23, 2022 at 1:59 PM ChiaEn Wu wrote: > > > > From: ChiYuan Huang > > > > Add Mediatek MT6370 MFD support. > > ... > > > +config MFD_MT6370 > > + tristate "Me

Re: [PATCH v3 02/14] dt-bindings: power: supply: Add Mediatek MT6370 Charger

2022-06-24 Thread Krzysztof Kozlowski
On 23/06/2022 13:56, ChiaEn Wu wrote: > From: ChiaEn Wu > > Add Mediatek MT6370 Charger binding documentation. > > Signed-off-by: ChiaEn Wu > --- > > v3 > - Add items and remove maxItems of io-channels > - Add io-channel-names and describe each item > - Add "unevaluatedProperties: false" in "u

Re: [PATCH v3 09/14] regulator: mt6370: Add mt6370 DisplayBias and VibLDO support

2022-06-24 Thread ChiaEn Wu
Hi Andy, Thanks for your helpful comments! Andy Shevchenko 於 2022年6月24日 週五 凌晨2:19寫道: > > On Thu, Jun 23, 2022 at 2:00 PM ChiaEn Wu wrote: > > > > From: ChiYuan Huang > > > > Add mt6370 DisplayBias and VibLDO support. > > ... > > > +#include > > +#include > > +#include > > +#include > > +#i

Re: [PATCH v3 03/14] dt-bindings: leds: mt6370: Add Mediatek mt6370 current sink type LED indicator

2022-06-24 Thread Krzysztof Kozlowski
On 23/06/2022 13:56, ChiaEn Wu wrote: > From: ChiYuan Huang > > Add Mediatek mt6370 current sink type LED indicator binding documentation. > > Signed-off-by: ChiYuan Huang > --- > > v3 > - Use leds-class-multicolor.yaml instead of common.yaml. > - Split multi-led and led node. > - Add subdevic

Re: [PATCH v3 03/14] dt-bindings: leds: mt6370: Add Mediatek mt6370 current sink type LED indicator

2022-06-24 Thread Krzysztof Kozlowski
On 24/06/2022 12:35, Krzysztof Kozlowski wrote: > On 23/06/2022 13:56, ChiaEn Wu wrote: >> From: ChiYuan Huang >> >> Add Mediatek mt6370 current sink type LED indicator binding documentation. >> >> Signed-off-by: ChiYuan Huang >> --- >> >> v3 >> - Use leds-class-multicolor.yaml instead of common.

Re: [PATCH v3 04/14] dt-bindings: leds: Add Mediatek MT6370 flashlight

2022-06-24 Thread Krzysztof Kozlowski
On 23/06/2022 13:56, ChiaEn Wu wrote: > From: Alice Chen > > Add Mediatek MT6370 flashlight binding documentation. > > Signed-off-by: Alice Chen > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v3 06/14] dt-bindings: mfd: Add Mediatek MT6370

2022-06-24 Thread Krzysztof Kozlowski
On 23/06/2022 13:56, ChiaEn Wu wrote: > From: ChiYuan Huang > > Add Mediatek MT6370 binding documentation. > > Signed-off-by: ChiYuan Huang > --- > > v3 > - Use " in entire patchset > - Refine ADC description > - Rename "enable-gpio" to "enable-gpios" in "regualtor" > - Change "/schemas/" to "

Re: [PATCH v3 08/14] usb: typec: tcpci_mt6370: Add Mediatek MT6370 tcpci driver

2022-06-24 Thread Greg KH
On Thu, Jun 23, 2022 at 07:56:25PM +0800, ChiaEn Wu wrote: > --- /dev/null > +++ b/drivers/usb/typec/tcpm/tcpci_mt6370.c > @@ -0,0 +1,212 @@ > +// SPDX-License-Identifier: GPL-2.0+ Are you sure you mean "+" here? I have to ask, sorry. And no copyright line? Your company is ok with that, nice!

Re: [PATCH] usb: gadget: Fix unsigned comparison with less than zero

2022-06-24 Thread Greg KH
On Thu, Jun 23, 2022 at 04:43:47PM +0800, Jiapeng Chong wrote: > This was found by coccicheck: > > ./drivers/usb/gadget/udc/aspeed_udc.c:496:8-13: WARNING: Unsigned expression > compared with zero: chunk >= 0. What does this mean? Where is the error? Please explain the reason for changes, not

[PATCH v2] drm/bridge: imx: i.MX8 bridge drivers should depend on ARCH_MXC

2022-06-24 Thread Geert Uytterhoeven
The various Freescale i.MX8 display bridges are only present on Freescale i.MX8 SoCs. Hence add a dependency on ARCH_MXC, to prevent asking the user about these drivers when configuring a kernel without i.MX SoC support. Fixes: e60c4354840b2fe8 ("drm/bridge: imx: Add LDB support for i.MX8qm") Fix

Re: [PATCH v11 20/24] arm64: dts: rockchip: enable vop2 and hdmi tx on rock-3a

2022-06-24 Thread Peter Geis
On Fri, Jun 24, 2022 at 4:30 AM Piotr Oniszczuk wrote: > > > > > Wiadomość napisana przez Piotr Oniszczuk w dniu > > 14.05.2022, o godz. 15:58: > > > > > > > >> Wiadomość napisana przez Peter Geis w dniu > >> 09.05.2022, o godz. 18:00: > >> > >> If you want to confirm the hardware is configure

Re: [PATCH v5 2/2] drm: lcdif: Add support for i.MX8MP LCDIF variant

2022-06-24 Thread Lucas Stach
Am Montag, dem 13.06.2022 um 23:31 +0200 schrieb Marek Vasut: > Add support for i.MX8MP LCDIF variant. This is called LCDIFv3 and is > completely different from the LCDIFv3 found in i.MX23 in that it has > a completely scrambled register layout compared to all previous LCDIF > variants. The new LCD

Re: [RFT][PATCH v1 5/6] vfio/ccw: Add kmap_local_page() for memcpy

2022-06-24 Thread Jason Gunthorpe
On Tue, Jun 21, 2022 at 02:21:22PM -0700, Nicolin Chen wrote: > On Sun, Jun 19, 2022 at 11:32:07PM -0700, Christoph Hellwig wrote: > > On Sun, Jun 19, 2022 at 11:57:26PM -0300, Jason Gunthorpe wrote: > > > The remark about io memory is because on s390 memcpy() will crash even > > > on ioremapped me

Re: [PATCH] drm: logicvc: Fix uninitialized variable in probe

2022-06-24 Thread Maxime Ripard
Hi, On Fri, Jun 24, 2022 at 04:35:25PM +0200, Paul Kocialkowski wrote: > On Tue 14 Jun 22, 15:08, Dan Carpenter wrote: > > The "regmap" is supposed to be initialized to NULL but it's used > > without being initialized. > > > > Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display control

Re: [bug report] drm: Add support for the LogiCVC display controller

2022-06-24 Thread Paul Kocialkowski
Hello Dan, On Tue 14 Jun 22, 15:07, Dan Carpenter wrote: > Hello Paul Kocialkowski, > > The patch efeeaefe9be5: "drm: Add support for the LogiCVC display > controller" from May 20, 2022, leads to the following Smatch static > checker warning: > > drivers/gpu/drm/logicvc/logicvc_layer.c:320

Re: [Intel-gfx] [PATCH v5 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-24 Thread Niranjana Vishwanathapura
On Fri, Jun 24, 2022 at 09:11:35AM +0100, Tvrtko Ursulin wrote: On 24/06/2022 06:32, Niranjana Vishwanathapura wrote: VM_BIND and related uapi definitions v2: Reduce the scope to simple Mesa use case. v3: Expand VM_UNBIND documentation and add I915_GEM_VM_BIND/UNBIND_FENCE_VALID and I9

Re: [PATCH] drm/msm/dp: no dp_hpd_unplug_handle() required for eDP

2022-06-24 Thread Kuogee Hsieh
On 6/23/2022 5:09 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-06-23 16:34:16) eDP implementation does not reuried to support hpd signal. Therefore s/reuried/require/ it only has either ST_DISPLAY_OFF or ST_CONNECTED state during normal operation. This patch remove unnecessary dp_hpd_

Re: [PATCH] drm: logicvc: Fix uninitialized variable in probe

2022-06-24 Thread Maxime Ripard
On Fri, Jun 24, 2022 at 04:46:36PM +0200, Paul Kocialkowski wrote: > Hi, > > On Fri 24 Jun 22, 16:37, Maxime Ripard wrote: > > Hi, > > > > On Fri, Jun 24, 2022 at 04:35:25PM +0200, Paul Kocialkowski wrote: > > > On Tue 14 Jun 22, 15:08, Dan Carpenter wrote: > > > > The "regmap" is supposed to be

Re: [PATCH v5 2/2] drm: lcdif: Add support for i.MX8MP LCDIF variant

2022-06-24 Thread Sam Ravnborg
> > + > > +static int lcdif_rpm_resume(struct device *dev) > > +{ > > + struct drm_device *drm = dev_get_drvdata(dev); > > + struct lcdif_drm_private *lcdif = drm->dev_private; > > + > > + /* These clock supply the Control Bus, APB, APBH Ctrl Registers */ > > + clk_prepare_enable(lcdif->clk

Re: [PATCH v3 1/4] dt-bindings: display: bridge: Convert cdns, dsi.txt to yaml

2022-06-24 Thread Krzysztof Kozlowski
On 20/06/2022 22:54, Rahul T R wrote: > Convert cdns,dsi.txt binding to yaml format > > Signed-off-by: Rahul T R > --- > .../bindings/display/bridge/cdns,dsi.txt | 112 -- > .../bindings/display/bridge/cdns,dsi.yaml | 193 ++ > 2 files changed, 193 insertions(+),

Re: [PATCH v5 01/13] mm: add zone device coherent type memory support

2022-06-24 Thread Sierra Guiza, Alejandro (Alex)
On 6/23/2022 1:21 PM, David Hildenbrand wrote: On 23.06.22 20:20, Sierra Guiza, Alejandro (Alex) wrote: On 6/23/2022 2:57 AM, David Hildenbrand wrote: On 23.06.22 01:16, Sierra Guiza, Alejandro (Alex) wrote: On 6/21/2022 11:16 AM, David Hildenbrand wrote: On 21.06.22 18:08, Sierra Guiza, Al

Re: [PATCH] MAINTAINERS: rectify entry for NVIDIA TEGRA DRM and VIDEO DRIVER

2022-06-24 Thread Thierry Reding
On Thu, Jun 23, 2022 at 11:54:52AM +0200, Lukas Bulwahn wrote: > Commit fd27de58b0ad ("dt-bindings: display: tegra: Convert to json-schema") > converts nvidia,tegra20-host1x.txt to yaml, but missed to adjust its > references in MAINTAINERS. > > Hence, ./scripts/get_maintainer.pl --self-test=patter

[PATCH 5/6] dma-buf: remove useless FMODE_LSEEK flag

2022-06-24 Thread Jason A. Donenfeld
This is already on by default. Suggested-by: Al Viro Cc: Sumit Semwal Cc: Christian König Cc: dri-devel@lists.freedesktop.org Signed-off-by: Jason A. Donenfeld --- drivers/dma-buf/dma-buf.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.

[PATCH v1 0/3] fix primary corruption issue

2022-06-24 Thread Kuogee Hsieh
fix primary corruption : 1) move struc of msm_display_info to msm_drv.h 2) decoupling dp->id out of dp controller_id at sc_dp_cfg table 3) place edp at head of drm bridge chain to fix screen corruption Kuogee Hsieh (3): drm/msm/dp: move struc of msm_display_info to msm_drv.h drm/msm/dp: d

[PATCH v1 3/3] drm/msm/dp: place edp at head of drm bridge chain to fix screen corruption

2022-06-24 Thread Kuogee Hsieh
The msm_dp_modeset_init() is used to attach DP driver to drm bridge chain. msm_dp_modeset_init() is executed in the order of index (dp->id) of DP descriptor table. Currently, DP is placed at first entry (dp->id = 0) of descriptor table and eDP is placed at secondary entry (dp->id = 1 ) of descript

[PATCH v1 1/3] drm/msm/dp: move struc of msm_display_info to msm_drv.h

2022-06-24 Thread Kuogee Hsieh
With current implementation, communication between interface driver and upper mdss encoder layer are implemented through function calls. This increase code complexity. Since struct msm_display_info contains msm generic display information, it can be expended to contains more useful information, suc

[PATCH v1 2/3] drm/msm/dp: decoupling dp->id out of dp controller_id at scxxxx_dp_cfg table

2022-06-24 Thread Kuogee Hsieh
Current the index (dp->id) of DP descriptor table (sc_dp_cfg[]) are tightly coupled with DP controller_id. This means DP use controller id 0 must be placed at first entry of DP descriptor table (sc_dp_cfg[]). Otherwise the internal INTF will mismatch controller_id. This will cause controlle

Re: [PATCH] drm/ingenic: Use resource_size function on resource object

2022-06-24 Thread Sam Ravnborg
Hi Jiapeng, On Fri, Jun 24, 2022 at 09:31:59AM +0800, Jiapeng Chong wrote: > This was found by coccicheck: > > ./drivers/gpu/drm/ingenic/ingenic-drm-drv.c:1149:35-38: WARNING: Suspicious > code. resource_size is maybe missing with res. > Nice one, now I have to go back and fix my code as well.

Re: [RESEND v5 1/2] dt-bindings: display: simple: Add DataImage FG1001L0DSSWMG01 compatible string

2022-06-24 Thread Sam Ravnborg
Hi Philip, On Thu, Jun 23, 2022 at 01:22:56PM +0200, Philip Oberfichtner wrote: > Add DataImage FG1001L0DSSWMG01 10.1" 1280x800 TFT LCD panel compatible > string. > > Signed-off-by: Philip Oberfichtner > Acked-by: Krzysztof Kozlowski Both patches applied to drm-misc (drm-misc-next) Sa

Re: [PATCH v6 02/10] dt-bindings: display: tegra: Convert to json-schema

2022-06-24 Thread Rob Herring
On Tue, 21 Jun 2022 18:10:14 +0300, Mikko Perttunen wrote: > From: Thierry Reding > > Convert the Tegra host1x controller bindings from the free-form text > format to json-schema. > > This also adds the missing display-hub DT bindings that were not > previously documented. > > Reviewed-by: Rob

[PATCH v6 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-24 Thread Niranjana Vishwanathapura
VM_BIND design document with description of intended use cases. v2: Reduce the scope to simple Mesa use case. v3: Expand documentation on dma-resv usage, TLB flushing and execbuf3. v4: Remove vm_bind tlb flush request support. v5: Update TLB flushing documentation. Signed-off-by: Niranjana Vi

[PATCH v6 2/3] drm/i915: Update i915 uapi documentation

2022-06-24 Thread Niranjana Vishwanathapura
Add some missing i915 upai documentation which the new i915 VM_BIND feature documentation will be refer to. Signed-off-by: Niranjana Vishwanathapura Reviewed-by: Matthew Auld --- include/uapi/drm/i915_drm.h | 205 1 file changed, 160 insertions(+), 45 deleti

[PATCH v6 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-24 Thread Niranjana Vishwanathapura
VM_BIND and related uapi definitions v2: Reduce the scope to simple Mesa use case. v3: Expand VM_UNBIND documentation and add I915_GEM_VM_BIND/UNBIND_FENCE_VALID and I915_GEM_VM_BIND_TLB_FLUSH flags. v4: Remove I915_GEM_VM_BIND_TLB_FLUSH flag and add additional documentation for vm_bin

[PATCH v6 0/3] drm/doc/rfc: i915 VM_BIND feature design + uapi

2022-06-24 Thread Niranjana Vishwanathapura
This is the i915 driver VM_BIND feature design RFC patch series along with the required uapi definition and description of intended use cases. v2: Reduce the scope to simple Mesa use case. Remove all compute related uapi, vm_bind/unbind queue support and only support a timeline out fence i

Re: [PATCH] drm/rockchip: vop: Don't crash for invalid duplicate_state()

2022-06-24 Thread Brian Norris
On Fri, Jun 24, 2022 at 12:23 AM Heiko Stuebner wrote: > The interesting question would be, do we want some fixes tag for it? I'm not aware of any currently-upstream code that will hit this [1]. I've hit it in out-of-tree code (or, code that I submitted to dri-devel, but wasn't accepted as-is), a

[PATCH v6 1/2] dt-bindings: lcdif: Add compatible for i.MX8MP

2022-06-24 Thread Marek Vasut
Add compatible string for i.MX8MP LCDIF variant. This is called LCDIFv3 and is completely different from the LCDIFv3 found in i.MX23 in that it has a completely scrambled register layout compared to all previous LCDIF variants. The new LCDIFv3 also supports 36bit address space. However, except for

[PATCH v6 2/2] drm: lcdif: Add support for i.MX8MP LCDIF variant

2022-06-24 Thread Marek Vasut
Add support for i.MX8MP LCDIF variant. This is called LCDIFv3 and is completely different from the LCDIFv3 found in i.MX23 in that it has a completely scrambled register layout compared to all previous LCDIF variants. The new LCDIFv3 also supports 36bit address space. Add a separate driver which i

[PATCH v2 0/4] Rework amdgpu HW fence refocunt and update scheduler parent fence refcount.

2022-06-24 Thread Andrey Grodzovsky
Yiqing raised a problem of negative fence refcount for resubmitted jobs in amdgpu and suggested a workaround in [1]. I took a look myself and discovered some deeper problems both in amdgpu and scheduler code. Yiqing helped with testing the new code and also drew a detailed refcount and flow tra

[PATCH v2 1/4] drm/amdgpu: Add put fence in amdgpu_fence_driver_clear_job_fences

2022-06-24 Thread Andrey Grodzovsky
This function should drop the fence refcount when it extracts the fence from the fence array, just as it's done in amdgpu_fence_process. Signed-off-by: Andrey Grodzovsky Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 4 +++- 1 file changed, 3 insertions(+), 1 delet

[PATCH v2 3/4] drm/sched: Partial revert of 'drm/sched: Keep s_fence->parent pointer'

2022-06-24 Thread Andrey Grodzovsky
Problem: This patch caused negative refcount as described in [1] because for that case parent fence did not signal by the time of drm_sched_stop and hence kept in pending list the assumption was they will not signal and so fence was put to account for the s_fence->parent refcount but for amdgpu wh

[PATCH v2 2/4] drm/amdgpu: Prevent race between late signaled fences and GPU reset.

2022-06-24 Thread Andrey Grodzovsky
Problem: After we start handling timed out jobs we assume there fences won't be signaled but we cannot be sure and sometimes they fire late. We need to prevent concurrent accesses to fence array from amdgpu_fence_driver_clear_job_fences during GPU reset and amdgpu_fence_process from a late EOP inte

[PATCH v2 4/4] drm/amdgpu: Follow up change to previous drm scheduler change.

2022-06-24 Thread Andrey Grodzovsky
Align refcount behaviour for amdgpu_job embedded HW fence with classic pointer style HW fences by increasing refcount each time emit is called so amdgpu code doesn't need to make workarounds using amdgpu_job.job_run_counter to keep the HW fence refcount balanced. Also since in the previous patch w

Re: [PATCH] drm/bridge: add it6505 driver read config from dt property

2022-06-24 Thread Sam Ravnborg
Hi allen. On Thu, Jun 23, 2022 at 05:31:54PM +0800, allen wrote: > From: allen chen > > add read max-lane and max-pixel-clock from dt property > > Signed-off-by: Allen-kh Cheng > Can you fix so your s-o-b mail and author mail matches? As it is now an error is flagged as they do not match.

[PATCH] drm/bridge: tc358767: Do not cache dsi_lanes twice

2022-06-24 Thread Marek Vasut
The DSI lane count can be accessed via the dsi device pointer, make use of that. No functional change. Signed-off-by: Marek Vasut Cc: Andrzej Hajda Cc: Laurent Pinchart Cc: Lucas Stach Cc: Maxime Ripard Cc: Robert Foss Cc: Sam Ravnborg --- drivers/gpu/drm/bridge/tc358767.c | 6 ++ 1 fi

[PATCH] drm/msm/gem: Fix error return on fence id alloc fail

2022-06-24 Thread Rob Clark
From: Rob Clark This was a typo, we didn't actually want to return zero. Fixes: a61acbbe9cf8 ("drm/msm: Track "seqno" fences by idr") Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem_submit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_ge

Re: [git pull] drm fixes for 5.19-rc4

2022-06-24 Thread pr-tracker-bot
The pull request you sent on Fri, 24 Jun 2022 15:55:38 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2022-06-24 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/38bc4ac431684498126f9baa3a530e5a132f0173 Thank you! -- Deet-doot-dot, I am a bot. https://k

Re: [PATCH v11 20/24] arm64: dts: rockchip: enable vop2 and hdmi tx on rock-3a

2022-06-24 Thread Piotr Oniszczuk
> Wiadomość napisana przez Peter Geis w dniu 24.06.2022, > o godz. 14:40: > >> >> Sascha, Peter >> >> I returned to trying to find why hdmi-cec is not working on rock3-a v1.31 hw. >> >> I'm on vop2 v11 on 5.18 mainline. >> >> Current findings: >> >> (1) the same sw. stack/binaries works

Re: [PATCH] drm/ingenic: Use resource_size function on resource object

2022-06-24 Thread Paul Cercueil
Hi, Le ven., juin 24 2022 at 09:31:59 +0800, Jiapeng Chong a écrit : This was found by coccicheck: ./drivers/gpu/drm/ingenic/ingenic-drm-drv.c:1149:35-38: WARNING: Suspicious code. resource_size is maybe missing with res. Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/ingenic/ingenic-d

Re: [PATCH v2 04/68] drm/connector: Reorder headers

2022-06-24 Thread Sam Ravnborg
On Wed, Jun 22, 2022 at 04:31:05PM +0200, Maxime Ripard wrote: > Unlike most of the other files in DRM, and Linux in general, the headers in > drm_connector.c aren't sorted alphabetically. Let's fix that. > > Signed-off-by: Maxime Ripard Acked-by: Sam Ravnborg > --- > drivers/gpu/drm/drm_connec

Re: [RFT][PATCH v1 5/6] vfio/ccw: Add kmap_local_page() for memcpy

2022-06-24 Thread Nicolin Chen
On Fri, Jun 24, 2022 at 10:56:15AM -0300, Jason Gunthorpe wrote: > > How about the updated commit log below? Thanks. > > > > The pinned PFN list returned from vfio_pin_pages() is converted using > > page_to_pfn(), so direct access via memcpy() will crash on S390 if the > > PFN is an IO PFN, as we

Re: [PATCH v2 05/68] drm/connector: Mention the cleanup after drm_connector_init

2022-06-24 Thread Sam Ravnborg
On Wed, Jun 22, 2022 at 04:31:06PM +0200, Maxime Ripard wrote: > Unlike encoders and CRTCs, the drm_connector_init() and > drm_connector_init_with_ddc() don't mention how the cleanup is supposed to > be done. Let's add it. > > Signed-off-by: Maxime Ripard Looks sensible, Acked-by: Sam Ravnborg >

Re: [PATCH v2 06/68] drm/connector: Clarify when drm_connector_unregister is needed

2022-06-24 Thread Sam Ravnborg
On Wed, Jun 22, 2022 at 04:31:07PM +0200, Maxime Ripard wrote: > The current documentation for drm_connector_unregister() mentions that > it's needed for connectors that have been registered through > drm_dev_register(). > > However, this was a typo and was meant to be drm_connector_register(), >

Re: [PATCH v2 07/68] drm/connector: Introduce drmm_connector_init

2022-06-24 Thread Sam Ravnborg
On Wed, Jun 22, 2022 at 04:31:08PM +0200, Maxime Ripard wrote: > Unlike other DRM entities, there's no helper to create a DRM-managed > initialisation of a connector. > > Let's create an helper to initialise a connector that would be passed as an > argument, and handle the cleanup through a DRM-ma

Re: [PATCH v2 08/68] drm/connector: Introduce drmm_connector_init_with_ddc

2022-06-24 Thread Sam Ravnborg
On Wed, Jun 22, 2022 at 04:31:09PM +0200, Maxime Ripard wrote: > Let's create a DRM-managed variant of drm_connector_init_with_ddc that will > take care of an action of the connector cleanup. > > Signed-off-by: Maxime Ripard Acked-by: Sam Ravnborg

Re: [PATCH v2 09/68] drm/bridge: panel: Introduce drmm_panel_bridge_add

2022-06-24 Thread Sam Ravnborg
On Wed, Jun 22, 2022 at 04:31:10PM +0200, Maxime Ripard wrote: > Unlike what can be found for other entities, there's no DRM-managed > function to create a panel_bridge instance from a panel. > > Let's introduce one. > > Signed-off-by: Maxime Ripard Acked-by: Sam Ravnborg

Re: [RFT][PATCH v1 5/6] vfio/ccw: Add kmap_local_page() for memcpy

2022-06-24 Thread Jason Gunthorpe
On Fri, Jun 24, 2022 at 12:22:36PM -0700, Nicolin Chen wrote: > On Fri, Jun 24, 2022 at 10:56:15AM -0300, Jason Gunthorpe wrote: > > > > How about the updated commit log below? Thanks. > > > > > > The pinned PFN list returned from vfio_pin_pages() is converted using > > > page_to_pfn(), so direct

Re: [PATCH v2 10/68] drm/bridge: panel: Introduce drmm_of_get_bridge

2022-06-24 Thread Sam Ravnborg
On Wed, Jun 22, 2022 at 04:31:11PM +0200, Maxime Ripard wrote: > Unlike what can be found for other DRM entities, we don't have a > DRM-managed function equivalent to devm_drm_of_get_bridge(). > > Let's create it. > > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/bridge/panel.c | 35

Re: [PATCH v6 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-24 Thread Daniel Vetter
On Fri, Jun 24, 2022 at 10:49:34AM -0700, Niranjana Vishwanathapura wrote: > VM_BIND design document with description of intended use cases. > > v2: Reduce the scope to simple Mesa use case. > v3: Expand documentation on dma-resv usage, TLB flushing and > execbuf3. > v4: Remove vm_bind tlb flu

Re: [PATCH] drm/pl111: drop unexpected word "the" in the comments

2022-06-24 Thread Sam Ravnborg
On Tue, Jun 21, 2022 at 09:31:07PM +0800, Jiang Jian wrote: > there is an unexpected word "the" in the comments that need to be dropped > > file: drivers/gpu/drm/pl111/pl111_display.c > line: 251 > * Note that the the ARM hardware's format reader takes 'r' from > changed to > * Note that the the A

Re: [PATCH] drm/panel: nt35510: Remove duplicate 'the' in two places.

2022-06-24 Thread Sam Ravnborg
On Tue, Jun 21, 2022 at 10:01:51PM +0800, Jiang Jian wrote: > file: ./drivers/gpu/drm/panel/panel-novatek-nt35510.c > line: 193,214,253 > * amplification for the the step-up circuit: > changed to > * amplification for the step-up circuit: > > Signed-off-by: Jiang Jian Thanks, applied to drm-misc

Re: [PATCH 1/1] drm/panel: panel-simple: Add dev_err_probe if backlight could not be found

2022-06-24 Thread Sam Ravnborg
On Tue, Jun 21, 2022 at 09:21:18AM +0200, Alexander Stein wrote: > If the backlight node is not enabled, this (silently) returns with > -EPROBE_DEFER. /sys/kernel/debug/devices_deferred also shows nothing > helpful: > $ cat /sys/kernel/debug/devices_deferred > display > > With this patch, there is

Re: [PATCH] drm/ssd130x: Use new regmap bulk write support to drop custom bus

2022-06-24 Thread Sam Ravnborg
Hi Javier, On Sat, Jun 18, 2022 at 07:43:38PM +0200, Javier Martinez Canillas wrote: > Data writes for the ssd130x 4-wire SPI protocol need special handling, due > the Data/Command control (D/C) pin having to be toggled prior to the write. > > The regmap API only allowed drivers to provide .reg_{

Re: [PATCH v6 2/3] drm/i915: Update i915 uapi documentation

2022-06-24 Thread Daniel Vetter
On Fri, Jun 24, 2022 at 10:49:35AM -0700, Niranjana Vishwanathapura wrote: > Add some missing i915 upai documentation which the new > i915 VM_BIND feature documentation will be refer to. > > Signed-off-by: Niranjana Vishwanathapura > Reviewed-by: Matthew Auld > --- > include/uapi/drm/i915_drm.h

Re: [PATCH v2 3/3] drm/panel: sony-acx565akm: Use backlight helpers

2022-06-24 Thread Sam Ravnborg
On Thu, Jun 16, 2022 at 07:23:15PM +0200, Stephen Kitt wrote: > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from futur

Re: [PATCH v2 2/3] drm/panel: panel-dsi-cm: Use backlight helpers

2022-06-24 Thread Sam Ravnborg
On Thu, Jun 16, 2022 at 07:23:14PM +0200, Stephen Kitt wrote: > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from futur

Re: [PATCH v2 1/3] drm/panel: Use backlight helper

2022-06-24 Thread Sam Ravnborg
On Thu, Jun 16, 2022 at 07:23:13PM +0200, Stephen Kitt wrote: > backlight_properties.fb_blank is deprecated. The states it represents > are handled by other properties; but instead of accessing those > properties directly, drivers should use the helpers provided by > backlight.h. > > Instead of re

Re: [PATCH v2] drm: shmobile: Use backlight helper

2022-06-24 Thread Sam Ravnborg
On Thu, Jun 16, 2022 at 07:08:21PM +0200, Stephen Kitt wrote: > This started with work on the removal of backlight_properties' > deprecated fb_blank field, much of which can be taken care of by using > helper functions provided by backlight.h instead of directly accessing > fields in backlight_prop

Re: [PATCH v5 1/9] dt-bindings: usb: Add Type-C switch binding

2022-06-24 Thread Stephen Boyd
Quoting Prashant Malani (2022-06-23 19:48:04) > On Thu, Jun 23, 2022 at 7:13 PM Stephen Boyd wrote: > > > > Quoting Prashant Malani (2022-06-23 17:35:38) > > > On Thu, Jun 23, 2022 at 4:14 PM Stephen Boyd wrote: > > > > > > > > I'm not aware of any documentation for the dos and don'ts here. Are >

[Bug 216119] 087451f372bf76d breaks hibernation on amdgpu Radeon R9 390

2022-06-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216119 --- Comment #20 from Harald Judt (h.j...@gmx.at) --- One thing that I have noticed: Since these changes, the kernel seems to switch to text mode when hibernating. Before that I think it remained (frozen) on the X screen. Here are the results: - 1

Re: [PATCH 2/2] drm/panel: simple: add AM-800600P5TMQW-TB8H

2022-06-24 Thread Sam Ravnborg
Hi Bastian, On Fri, Jun 10, 2022 at 01:15:11PM +0200, Bastian Krause wrote: > Add support for the Ampire AM-800600P5TMQW-TB8H 800x600 panel. Data > sheet is currently not publicly available, unfortunately. > > Signed-off-by: Bastian Krause Applied to drm-misc (drm-misc-next). When applying I fi

  1   2   3   >