Re: [PATCH] drm/fourcc: fix integer type usage in uapi header

2022-06-22 Thread Simon Ser
On Tuesday, June 21st, 2022 at 22:39, Carlos Llamas wrote: > Kernel uapi headers are supposed to use __[us]{8,16,32,64} types defined > by as opposed to 'uint32_t' and similar. See [1] for the > relevant discussion about this topic. In this particular case, the usage > of 'uint64_t' escaped head

Re: [PATCH 5/5] drm/amdgpu: Follow up change to previous drm scheduler change.

2022-06-22 Thread Christian König
Am 21.06.22 um 22:00 schrieb Andrey Grodzovsky: On 2022-06-21 03:28, Christian König wrote: Am 21.06.22 um 00:03 schrieb Andrey Grodzovsky: Align refcount behaviour for amdgpu_job embedded HW fence with classic pointer style HW fences by increasing refcount each time emit is called so amdgpu c

Re: [PATCH v6 04/10] gpu: host1x: Add context device management code

2022-06-22 Thread kernel test robot
ext config: arm64-randconfig-r021-20220622 (https://download.01.org/0day-ci/archive/20220622/202206221557.laes8ynq-...@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 8b8d126598ce7bd5243da7f94f69fa1104288bee) reproduce (this is a W=1 build): w

Re: [PATCH 2/3] drm/msm/dp: Remove pixel_rate from struct dp_ctrl

2022-06-22 Thread Dmitry Baryshkov
On 22/06/2022 05:59, Stephen Boyd wrote: Quoting Dmitry Baryshkov (2022-06-17 16:07:58) On 17/06/2022 23:47, Stephen Boyd wrote: This struct member is stored to in the function that calls the function which uses it. That's possible with a function argument instead of storing to a struct member.

Re: [PATCH v8 1/2] drm/msm/dp: force link training for display resolution change

2022-06-22 Thread Dmitry Baryshkov
On 16/06/2022 20:09, Kuogee Hsieh wrote: Display resolution change is implemented through drm modeset. Older modeset (resolution) has to be disabled first before newer modeset (resolution) can be enabled. Display disable will turn off both pixel clock and main link clock so that main link have to

Re: (subset) [PATCH] drm: panel-orientation-quirks: drop unexpected word "the" in the comments

2022-06-22 Thread Maxime Ripard
On Tue, 21 Jun 2022 21:44:01 +0800, Jiang Jian wrote: > there is an unexpected word "the" in the comments that need to be dropped > > file: drivers/gpu/drm/drm_panel_orientation_quirks.c > line: 196 > * GPD Pocket, note that the the DMI data is less generic then > changed to > * GPD Pocket, note t

Re: (subset) [PATCH] drm/prime: drop unexpected word "the" in the comments

2022-06-22 Thread Maxime Ripard
On Tue, 21 Jun 2022 21:02:10 +0800, Jiang Jian wrote: > there is an unexpected word "the" in the comments that need to be dropped > > file: drivers/gpu/drm/drm_prime.c > line: 842 > * of the the buffer described by the provided sg_table. > changed to > * of the buffer described by the provided sg_

Re: (subset) [PATCH] GPU: drm: drop unexpected word "the" in the comments

2022-06-22 Thread Maxime Ripard
On Tue, 21 Jun 2022 21:51:40 +0800, Jiang Jian wrote: > there is an unexpected word "the" in the comments that need to be dropped > > file: drivers/gpu/drm/drm_ioctl.c > line: 86 > *means the the unique name for the master node just opening is _not_ > filled > changed to > *means the uniq

Re: (subset) [PATCH] drm/vc4: drop unexpected word "the" in the comments

2022-06-22 Thread Maxime Ripard
On Tue, 21 Jun 2022 21:05:50 +0800, Jiang Jian wrote: > there is an unexpected word "the" in the comments that need to be dropped > > file: drivers/gpu/drm/vc4/vc4_regs.h > line: 267 > /* Set when the the downstream tries to read from the display FIFO > changed to > /* Set when the downstream trie

Re: (subset) [PATCH] drm/vc4: hdmi: Fixed possible integer overflow

2022-06-22 Thread Maxime Ripard
On Thu, 9 Jun 2022 23:50:31 +0500, Saud Farooqui wrote: > Multiplying ints and saving it in unsigned long long > could lead to integer overflow before being type casted to > unsigned long long. > > Addresses-Coverity: 1505113: Unintentional integer overflow. > > > [...] Applied to drm/drm-misc

Re: (subset) [PATCH v2] drm/sun4i: Add DMA mask and segment size

2022-06-22 Thread Maxime Ripard
On Mon, 20 Jun 2022 20:13:33 +0200, Jernej Skrabec wrote: > Kernel occasionally complains that there is mismatch in segment size > when trying to render HW decoded videos and rendering them directly with > sun4i DRM driver. Following message can be observed on H6 SoC: > > [ 184.298308] --

Re: [PATCH v2] drm/sun4i: Add DMA mask and segment size

2022-06-22 Thread Maxime Ripard
Hi Robin, On Tue, Jun 21, 2022 at 01:44:44PM +0100, Robin Murphy wrote: > On 2022-06-20 19:13, Jernej Skrabec wrote: > > Kernel occasionally complains that there is mismatch in segment size > > when trying to render HW decoded videos and rendering them directly with > > sun4i DRM driver. Following

[PATCH] drm/vc4: perfmon: Fix variable dereferenced before check

2022-06-22 Thread Maxime Ripard
Commit 30f8c74ca9b7 ("drm/vc4: Warn if some v3d code is run on BCM2711") introduced a check in vc4_perfmon_get() that dereferences a pointer before we checked whether that pointer is valid or not. Let's rework that function a bit to do things in the proper order. Reported-by: kernel test robot R

Re: [Intel-gfx] [PATCH v3 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-22 Thread Tvrtko Ursulin
On 22/06/2022 04:56, Niranjana Vishwanathapura wrote: VM_BIND and related uapi definitions v2: Reduce the scope to simple Mesa use case. v3: Expand VM_UNBIND documentation and add I915_GEM_VM_BIND/UNBIND_FENCE_VALID and I915_GEM_VM_BIND_TLB_FLUSH flags. Signed-off-by: Niranjana Vish

Re: [Intel-gfx] [PATCH v2 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-22 Thread Tvrtko Ursulin
On 21/06/2022 15:43, Niranjana Vishwanathapura wrote: On Tue, Jun 21, 2022 at 09:35:16AM +0100, Tvrtko Ursulin wrote: On 20/06/2022 17:29, Niranjana Vishwanathapura wrote: On Mon, Jun 20, 2022 at 11:43:10AM +0100, Tvrtko Ursulin wrote: Hi, On 17/06/2022 06:14, Niranjana Vishwanathapura wr

[PATCH] drm/hyperv-drm: Include framebuffer and EDID headers

2022-06-22 Thread Thomas Zimmermann
Fix a number of compile errors by including the correct header files. Examples are shown below. ../drivers/gpu/drm/hyperv/hyperv_drm_modeset.c: In function 'hyperv_blit_to_vram_rect': ../drivers/gpu/drm/hyperv/hyperv_drm_modeset.c:25:48: error: invalid use of undefined type 'struct drm_frame

Re: (subset) [PATCH 2/2] arm64: dts: qcom: correct SPMI WLED register range encoding

2022-06-22 Thread Krzysztof Kozlowski
On Thu, 5 May 2022 17:47:02 +0200, Krzysztof Kozlowski wrote: > On PM660L, PMI8994 and PMI8998, the WLED has two address spaces and with > size-cells=0, they should be encoded as two separate items. > > Applied, thanks! [2/2] arm64: dts: qcom: correct SPMI WLED register range encoding ht

Re: [PATCH] drm/etnaviv: print offender task information on hangcheck recovery

2022-06-22 Thread Lucas Stach
Hi Christian, Am Freitag, dem 03.06.2022 um 14:37 +0200 schrieb Christian Gmeiner: > Track the pid per submit, so we can print the name and cmdline of > the task which submitted the batch that caused the gpu to hang. > I really like the idea. I think the pid handling could be integrated into the

Re: [PATCH 1/5] drm/amdgpu: Fix possible refcount leak for release of external_hw_fence

2022-06-22 Thread Christian König
Am 21.06.22 um 21:34 schrieb Andrey Grodzovsky: On 2022-06-21 03:19, Christian König wrote: Am 21.06.22 um 00:02 schrieb Andrey Grodzovsky: Problem: In amdgpu_job_submit_direct - The refcount should drop by 2 but it drops only by 1. amdgpu_ib_sched->emit -> refcount 1 from first fence init dm

Re: [Linaro-mm-sig] Re: DMA-buf and uncached system memory

2022-06-22 Thread Christian König
Am 21.06.22 um 17:42 schrieb Nicolas Dufresne: Hi Christian and Andy, Le mardi 21 juin 2022 à 12:34 +0200, Christian König a écrit :  Hi Andy,  Am 21.06.22 um 12:17 schrieb Andy.Hsieh: On 2/16/21 4:39 AM, Nicolas Dufresne wrote: Le lundi 15 février 2021 à 09:58 +0100, Christian König

Re: [PATCH] drm/bridge: imx: i.MX8 bridge drivers should depend on ARCH_MXC

2022-06-22 Thread Geert Uytterhoeven
Hi Liu, On Tue, Jun 21, 2022 at 5:47 PM Liu Ying wrote: > On Tue, 2022-06-21 at 15:30 +0200, Geert Uytterhoeven wrote: > > The various Freescale i.MX8MP display bridges are only present on > > Freescale i.MX8 SoCs. Hence add a dependency on ARCH_MXC, to prevent > > asking the user about these dr

Re: [PATCH v1 0/9] drm/bridge: ps8640 and ti-sn65dsi86 updates

2022-06-22 Thread Kieran Bingham
Hi Sam, Quoting Sam Ravnborg (2022-02-06 19:09:11) > > > > The code builds - but needs testing. > > Hrmff, no it does not build. The fixes was by accident not included. > Will wait a bit for feedback before posting a v2. > > Sam Do you have any plan to send a v2 on this series? I have

Re: [PATCH v8 01/16] clk: generalize devm_clk_get() a bit

2022-06-22 Thread Andy Shevchenko
On Tue, Jun 21, 2022 at 11:01 PM Uwe Kleine-König wrote: > On Tue, Jun 21, 2022 at 08:57:00PM +0100, Jon Hunter wrote: ... > (Pro tipp: The commit in next has a Link: footer. If you follow the > link, you find the thread that was actually applied (i.e. v9) and where > the fix is also contained.)

Re: [PATCH v8 01/10] drm/i915/ttm: dont trample cache_level overrides during ttm move

2022-06-22 Thread Thomas Hellström
On 6/21/22 22:00, Robert Beckett wrote: Various places within the driver override the default chosen cache_level. Before ttm, these overrides were permanent until explicitly changed again or for the lifetime of the buffer. TTM movement code came along and decided that it could make that decisi

Re: [PATCH v8 02/10] drm/i915: limit ttm to dma32 for i965G[M]

2022-06-22 Thread Thomas Hellström
On 6/21/22 22:00, Robert Beckett wrote: i965G[M] cannot relocate objects above 4GiB. Ensure ttm uses dma32 on these systems. Signed-off-by: Robert Beckett LGTM. Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i915/intel_region_ttm.c | 7 ++- 1 file changed, 6 insertions(+), 1

Re: [PATCH v8 03/10] drm/i915/ttm: only trust snooping for dgfx when deciding default cache_level

2022-06-22 Thread Thomas Hellström
On 6/21/22 22:00, Robert Beckett wrote: By default i915_ttm_cache_level() decides I915_CACHE_LLC if HAS_SNOOP. This is divergent from existing backends code which only considers HAS_LLC. Testing shows that trusting snooping on gen5- is unreliable and bsw via ggtt mappings, so limit DGFX for now

[PATCH v3 00/13] drm/edid: expand on struct drm_edid usage

2022-06-22 Thread Jani Nikula
v3 of [1], addressing review comments. I'm adding some code movement and refactoring in the beginning to reuse code between drm_connector_update_edid_property() and drm_edid_connector_update() which was a concern Ville raised [2]. BR, Jani. [1] https://patchwork.freedesktop.org/series/104309/ [2

[PATCH v3 02/13] drm/edid: convert drm_connector_update_edid_property() to struct drm_edid

2022-06-22 Thread Jani Nikula
Make drm_connector_update_edid_property() a thin wrapper around a struct drm_edid based version of the same. This lets us remove the legacy drm_update_tile_info() and drm_add_display_info() functions altogether. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 81

[PATCH v3 01/13] drm/edid: move drm_connector_update_edid_property() to drm_edid.c

2022-06-22 Thread Jani Nikula
The function needs access to drm_edid.c internals more than drm_connector.c. We can make drm_reset_display_info(), drm_add_display_info() and drm_update_tile_info() static. There will be more benefits with follow-up struct drm_edid refactoring. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_

[PATCH v3 03/13] drm/edid: clean up connector update error handling and debug logging

2022-06-22 Thread Jani Nikula
Bail out on all errors, debug log all errors, and convert to drm device based debug logging. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 41 ++ 1 file changed, 28 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers

[PATCH v3 04/13] drm/edid: abstract debugfs override EDID set/reset

2022-06-22 Thread Jani Nikula
Add functions drm_edid_override_set() and drm_edid_override_reset() to support "edid_override" connector debugfs, and to hide the details about it in drm_edid.c. No functional changes at this time. Also note in the connector.override_edid flag kernel-doc that this is only supposed to be modified b

[PATCH v3 05/13] drm/edid: add drm_edid_connector_update()

2022-06-22 Thread Jani Nikula
Add a new function drm_edid_connector_update() to replace the combination of calls drm_connector_update_edid_property() and drm_add_edid_modes(). Usually they are called in the drivers in this order, however the former needs information from the latter. Since the new drm_edid_read*() functions no

[PATCH v3 06/13] drm/probe-helper: add drm_connector_helper_get_modes()

2022-06-22 Thread Jani Nikula
Add a helper function to be used as the "default" .get_modes() hook. This also works as an example of what the driver .get_modes() hooks are supposed to do regarding the new drm_edid_read*() and drm_edid_connector_update() calls. Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers

[PATCH v3 07/13] drm/edid: add drm_edid_raw() to access the raw EDID data

2022-06-22 Thread Jani Nikula
Unfortunately, there are still plenty of interfaces around that require a struct edid pointer, and it's impossible to change them all at once. Add an accessor to the raw EDID data to help the transition. While there are no such cases now, be defensive against raw EDID extension count indicating bi

[PATCH v3 08/13] drm/i915/edid: convert DP, HDMI and LVDS to drm_edid

2022-06-22 Thread Jani Nikula
Convert all the connectors that use cached connector edid and detect_edid to drm_edid. v2: Don't leak opregion fallback EDID (Ville) Signed-off-by: Jani Nikula --- .../gpu/drm/i915/display/intel_connector.c| 4 +- .../drm/i915/display/intel_display_types.h| 4 +- drivers/gpu/drm/i915/

[PATCH v3 09/13] drm/i915/bios: convert intel_bios_init_panel() to drm_edid

2022-06-22 Thread Jani Nikula
Try to use struct drm_edid where possible, even if having to fall back to looking into struct edid down low via drm_edid_raw(). v2: Rebase Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_bios.c | 19 ++- drivers/gpu/drm/i915/display/

[PATCH v3 10/13] drm/edid: do invalid block filtering in-place

2022-06-22 Thread Jani Nikula
Rewrite edid_filter_invalid_blocks() to filter invalid blocks in-place. The main motivation is to not rely on passed in information on invalid block count or the allocation size, which will be helpful in follow-up work on HF-EEODB. Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drive

[PATCH v3 11/13] drm/edid: add HF-EEODB support to EDID read and allocation

2022-06-22 Thread Jani Nikula
HDMI 2.1 section 10.3.6 defines an HDMI Forum EDID Extension Override Data Block, which may contain a different extension count than the base block claims. Add support for reading more EDID data if available. The extra blocks aren't parsed yet, though. Hard-coding the EEODB parsing instead of usin

[PATCH v3 12/13] drm/edid: take HF-EEODB extension count into account

2022-06-22 Thread Jani Nikula
Take the HF-EEODB extension count override into account. Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index fa3a3e294560..bbc25e3b72

[PATCH v3 13/13] drm/todo: add entry for converting the subsystem to struct drm_edid

2022-06-22 Thread Jani Nikula
We need to stop duplicating EDID validation and parsing all over the subsystem in various broken ways. v2: Update to reflect drm_connector_helper_get_modes() Cc: David Airlie Cc: Daniel Vetter Signed-off-by: Jani Nikula --- Documentation/gpu/todo.rst | 25 + 1 file cha

Re: [PATCH v2 4/9] drm: selftest: convert drm_format selftest to KUnit

2022-06-22 Thread kernel test robot
Hi "Maíra, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on linus/master v5.19-rc3 next-20220622] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest t

Re: [PATCH v8 01/16] clk: generalize devm_clk_get() a bit

2022-06-22 Thread Neil Armstrong
On 22/06/2022 12:36, Andy Shevchenko wrote: On Tue, Jun 21, 2022 at 11:01 PM Uwe Kleine-König wrote: On Tue, Jun 21, 2022 at 08:57:00PM +0100, Jon Hunter wrote: ... (Pro tipp: The commit in next has a Link: footer. If you follow the link, you find the thread that was actually applied (i.e.

Re: [PATCH v8 04/10] drm/i915/gem: selftest should not attempt mmap of private regions

2022-06-22 Thread Thomas Hellström
On Tue, 2022-06-21 at 20:00 +, Robert Beckett wrote: > During testing make can_mmap consider whether the region is private. > > Signed-off-by: Robert Beckett LGTM. Reviewed-by: Thomas Hellström > --- >  drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 3 +++ >  1 file changed, 3 insert

[PATCH v2 05/13] gpu: host1x: Simplify register mapping and add common aperture

2022-06-22 Thread Mikko Perttunen
From: Mikko Perttunen Refactor 'regs' property loading using devm_platform_ioremap_* and add loading of the 'common' region found on Tegra234. Signed-off-by: Mikko Perttunen --- drivers/gpu/host1x/dev.c | 46 +--- drivers/gpu/host1x/dev.h | 3 +++ 2 files c

[PATCH v2 10/13] gpu: host1x: Rewrite job opcode sequence

2022-06-22 Thread Mikko Perttunen
From: Mikko Perttunen For new (Tegra186+) SoCs, use a new ('full-featured') job opcode sequence that is compatible with virtualization. In particular, the Host1x hardware in Tegra234 is more strict regarding the sequence, requiring ACQUIRE_MLOCK-SETCLASS-SETSTREAMID opcodes to occur in that seque

[PATCH v2 06/13] gpu: host1x: Program virtualization tables

2022-06-22 Thread Mikko Perttunen
From: Mikko Perttunen Program virtualization tables specifying which VMs have access to which Host1x hardware resources. Programming these has become mandatory in Tegra234. For now, since the driver does not operate as a Host1x hypervisor, we basically allow access to everything to everyone. Si

[PATCH v2 03/13] arm64: tegra: Add Host1x and VIC on Tegra234

2022-06-22 Thread Mikko Perttunen
From: Mikko Perttunen Add device tree nodes for Host1x and VIC on Tegra234. Signed-off-by: Mikko Perttunen --- arch/arm64/boot/dts/nvidia/tegra234.dtsi | 46 1 file changed, 46 insertions(+) diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot/dts/

[PATCH v2 09/13] gpu: host1x: Tegra234 device data and headers

2022-06-22 Thread Mikko Perttunen
From: Mikko Perttunen Add device data and chip headers for Tegra234. Signed-off-by: Mikko Perttunen --- drivers/gpu/host1x/Makefile | 3 +- drivers/gpu/host1x/dev.c | 42 drivers/gpu/host1x/hw/host1x08.c | 33 drivers/gpu/host1x

[PATCH v2 00/13] Host1x support on Tegra234

2022-06-22 Thread Mikko Perttunen
From: Mikko Perttunen - Merging notes - This series should be applied on top of the Host1x context isolation series. - Changes in v2 - Rebased on top of v5.19-rc3. Updated Host1x device tree schema based on Rob's comments. No changes to node na

[PATCH v2 08/13] gpu: host1x: Program interrupt destinations on Tegra234

2022-06-22 Thread Mikko Perttunen
From: Mikko Perttunen On Tegra234, each Host1x VM has 8 interrupt lines. Each syncpoint can be configured with which interrupt line should be used for threshold interrupt, allowing for load balancing. For now, to keep backwards compatibility, just set all syncpoints to the first interrupt. Sign

[PATCH v2 02/13] dt-bindings: Add headers for Host1x and VIC on Tegra234

2022-06-22 Thread Mikko Perttunen
From: Mikko Perttunen Add clock, memory controller, powergate and reset dt-binding headers for Host1x and VIC on Tegra234. Signed-off-by: Mikko Perttunen --- include/dt-bindings/clock/tegra234-clock.h | 4 include/dt-bindings/memory/tegra234-mc.h | 5 + include/dt-bindings/p

[PATCH v2 11/13] gpu: host1x: Add MLOCK release code on Tegra234

2022-06-22 Thread Mikko Perttunen
From: Mikko Perttunen With the full-featured opcode sequence using MLOCKs, we need to also unlock those MLOCKs in the event of a timeout. However, it turns out that on Tegra186/Tegra194, by default, we don't need to do this; furthermore, on Tegra234 it is much simpler to do; so only implement thi

[PATCH v2 13/13] drm/tegra: vic: Add Tegra234 support

2022-06-22 Thread Mikko Perttunen
From: Mikko Perttunen Add Tegra234 support for VIC. It is backwards compatible with Tegra194. Signed-off-by: Mikko Perttunen --- drivers/gpu/drm/tegra/drm.c | 1 + drivers/gpu/drm/tegra/vic.c | 12 2 files changed, 13 insertions(+) diff --git a/drivers/gpu/drm/tegra/drm.c b/driv

[PATCH v2 12/13] gpu: host1x: Use RESTART_W to skip timed out jobs on Tegra186+

2022-06-22 Thread Mikko Perttunen
From: Mikko Perttunen When MLOCK enforcement is enabled, the 0-word write currently done is rejected by the hardware outside of an MLOCK region. As such, on these chips, which also have the newer, more convenient RESTART_W opcode, use that instead to skip over the timed out job. Signed-off-by: M

[PATCH v2 04/13] gpu: host1x: Deduplicate hardware headers

2022-06-22 Thread Mikko Perttunen
From: Mikko Perttunen Host1x class information and opcodes are unchanged or backwards compatible across SoCs so let's not duplicate them for each one but have them in a shared header file. At the same time, add opcode functions for acquire/release_mlock. Signed-off-by: Mikko Perttunen --- dri

[PATCH v2 01/13] dt-bindings: Add bindings for Tegra234 Host1x and VIC

2022-06-22 Thread Mikko Perttunen
From: Mikko Perttunen Update VIC and Host1x bindings for changes in Tegra234. Namely, - New compatible strings - Sharded syncpoint interrupts - Optional reset. Also, fix the order of descriptions for VM/hypervisor register apertures -- while the reg-names specification was correct, the descript

[PATCH v2 07/13] gpu: host1x: Allow reset to be missing

2022-06-22 Thread Mikko Perttunen
From: Mikko Perttunen Host1x on Tegra234 does not have a software-controllable reset line. As such, don't bail out if we don't find one in the device tree. Signed-off-by: Mikko Perttunen --- drivers/gpu/host1x/dev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/host1x/dev.c

[PULL] drm-intel-fixes

2022-06-22 Thread Jani Nikula
Hi Dave & Daniel - drm-intel-fixes-2022-06-22: drm/i915 fixes for v5.19-rc4: - Revert low voltage SKU check removal to fix display issues - Apply PLL DCO fraction workaround for ADL-S - Don't show engine classes not present in client fdinfo BR, Jani. The following changes since commit a111daf0

Re: [PATCH v8 08/10] drm/i915: allow memory region creators to alloc and free the region

2022-06-22 Thread Thomas Hellström
Hi, Bob, On Tue, 2022-06-21 at 20:00 +, Robert Beckett wrote: > add callbacks for alloc and free. > this allows region creators to allocate any extra storage they may > require. > > Signed-off-by: Robert Beckett I think the correct solution here would be to, similar to ttm, export an alloc_

Re: [PATCH] drm/hyperv-drm: Include framebuffer and EDID headers

2022-06-22 Thread Maxime Ripard
On Wed, Jun 22, 2022 at 10:34:13AM +0200, Thomas Zimmermann wrote: > Fix a number of compile errors by including the correct header > files. Examples are shown below. > > ../drivers/gpu/drm/hyperv/hyperv_drm_modeset.c: In function > 'hyperv_blit_to_vram_rect': > ../drivers/gpu/drm/hyperv/hype

Re: [kbuild-all] Re: [PATCH v2 1/1] drm/panfrost: Add support for devcoredump

2022-06-22 Thread Alyssa Rosenzweig
Hi Rong Chen, Sorry for the noise -- I think that was meant for Adrian! Apologies, Alyssa On Wed, Jun 22, 2022 at 10:30:00AM +0800, Chen, Rong A wrote: > > > On 6/21/2022 10:32 PM, Alyssa Rosenzweig wrote: > > > drivers/gpu/drm/panfrost/panfrost_dump.c: In function > > > 'panfrost_core_d

Re: [PATCH v2 1/1] drm/panfrost: Add support for devcoredump

2022-06-22 Thread Alyssa Rosenzweig
> > > + iter.start = __vmalloc(file_size, GFP_KERNEL | __GFP_NOWARN | > > > + __GFP_NORETRY); > > > + if (!iter.start) { > > > + dev_warn(pfdev->dev, "failed to allocate devcoredump file\n"); > > > + return; > > > + } > > > ... > > > + memset(iter.hdr, 0, iter.data -

Re: [PATCH v3 1/1] drm/panfrost: Add support for devcoredump

2022-06-22 Thread Alyssa Rosenzweig
> + js_as_offset = slot * 0x80; JS_SLOT_STRIDE > + slot = panfrost_job_get_slot(job); > + slot = slot ? slot : 0; `slot = slot ? slot : 0` is a no-op. Delete the line. > + if (!IS_ERR(page)) > + *bomap++ = cpu_to_le64(p

[PATCH] drm/vc4: fix error code in vc4_check_tex_size()

2022-06-22 Thread Dan Carpenter
The vc4_check_tex_size() function is supposed to return false on error but this error path accidentally returns -ENODEV (which means true). Fixes: 30f8c74ca9b7 ("drm/vc4: Warn if some v3d code is run on BCM2711") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/vc4/vc4_validate.c | 2 +- 1 file

Re: [PATCH v3 1/1] drm/panfrost: Add support for devcoredump

2022-06-22 Thread kernel test robot
Hi "Adrián, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on linus/master v5.19-rc3 next-20220622] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest t

Re: [PATCH 09/64] drm/simple: Introduce drmm_simple_encoder_init

2022-06-22 Thread Maxime Ripard
On Mon, Jun 20, 2022 at 09:04:11PM +0200, Thomas Zimmermann wrote: > Hi > > Am 20.06.22 um 16:45 schrieb Thomas Zimmermann: > > Hi > > > > Am 20.06.22 um 16:39 schrieb Maxime Ripard: > > > On Mon, Jun 20, 2022 at 04:25:38PM +0200, Thomas Zimmermann wrote: > > > > Hi > > > > > > > > Am 20.06.22 u

[PATCH] drm/ast: Fix black screen when getting out of suspend

2022-06-22 Thread Jocelyn Falempe
With an AST2600, the screen is garbage when going out of suspend. This is because color settings are lost, and not restored on resume. Force the color settings on DPMS_ON, to make sure the settings are correct. I didn't write this code, it comes from the out-of-tree aspeed driver v1.13 https://www

[Bug 201957] amdgpu: ring gfx timeout

2022-06-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201957 --- Comment #74 from Martin von Wittich (martin.von.witt...@iserv.eu) --- > Did you try with the latest Linux Kernel? I had a lot of gpu lockups like > this. Also try these kernel parameters : "amdgpu.ppfeaturemask=0xbffb > amdgpu.noretry=0

[Bug 216119] 087451f372bf76d breaks hibernation on amdgpu Radeon R9 390

2022-06-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216119 --- Comment #18 from Alex Deucher (alexdeuc...@gmail.com) --- Just to verify, you removed the patch from comment 11 before testing the new patches? Also, can you try the just patch 1/4 and then again with just patches 2/4 and 3/4? Do either of t

Re: [PATCH v2 1/1] drm/panfrost: Add support for devcoredump

2022-06-22 Thread Lucas Stach
Am Mittwoch, dem 22.06.2022 um 02:54 +0100 schrieb Adri??n Larumbe: > Hi Alyssa, thanks for the feedback. > > If I don't answer directly to any of your concerns in this message, it's > because > I applied your suggestions in v3 of the patch straight away. > > On 21.06.2022 09:03, Alyssa Rosenzwe

Re: [PATCH] soc: mediatek: mutex: add suffix 0 to DDP_COMPONENT_DITHER for mt8395

2022-06-22 Thread AngeloGioacchino Del Regno
Il 22/06/22 15:19, Jason-JH.Lin ha scritto: Add suffix 0 to DDP_COMPONENT_DITHER for mt8395. Fixes: 141311b856d8 ("soc: mediatek: mutex: add MT8365 support") Signed-off-by: Jason-JH.Lin Hello Jason-JH, you must've missed my commit, sent two days ago, which is doing the same: https://lore.k

Re: [PATCH] drm/hyperv-drm: Include framebuffer and EDID headers

2022-06-22 Thread Ville Syrjälä
On Wed, Jun 22, 2022 at 10:34:13AM +0200, Thomas Zimmermann wrote: > Fix a number of compile errors by including the correct header > files. Examples are shown below. > > ../drivers/gpu/drm/hyperv/hyperv_drm_modeset.c: In function > 'hyperv_blit_to_vram_rect': > ../drivers/gpu/drm/hyperv/hype

Re: linux-next: build failure after merge of the drm-misc tree

2022-06-22 Thread Ville Syrjälä
On Wed, Jun 22, 2022 at 11:04:51AM +1000, Stephen Rothwell wrote: > Hi all, > > On Tue, 21 Jun 2022 10:48:17 +0300 Ville Syrjälä > wrote: > > > > On Tue, Jun 21, 2022 at 12:36:56PM +1000, Stephen Rothwell wrote: > > > > > > After merging the drm-misc tree, today's linux-next build (x86_64 > > >

Re: [PATCH v3 1/1] drm/panfrost: Add support for devcoredump

2022-06-22 Thread Adri??n Larumbe
On 22.06.2022 08:17, Alyssa Rosenzweig wrote: >> +js_as_offset = slot * 0x80; > >JS_SLOT_STRIDE Sorry about this blunder. >> +slot = panfrost_job_get_slot(job); >> +slot = slot ? slot : 0; > >`slot = slot ? slot : 0` is a no-op. Delete the line. I think what I meant h

[PATCH v3 1/3] MAINTAINERS: Broaden scope of simpledrm entry

2022-06-22 Thread Thomas Zimmermann
There will be more DRM drivers for firmware-provided framebuffers. Use the existing entry for simpledrm instead of adding a new one for each driver. Also add DRM's aperture helpers, which are part of the driver's infrastructure. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canill

[PATCH v3 0/3] Improve vfio-pci primary GPU assignment behavior

2022-06-22 Thread Thomas Zimmermann
(I'm taking over this patchset from Alex, [1] as we agreed that it should go through the drm-misc tree.) When assigning a primary graphics device to VM through vfio-pci device assignment, users often prevent binding of the native PCI graphics driver to avoid device initialization conflicts, howeve

[PATCH v3 3/3] vfio/pci: Remove console drivers

2022-06-22 Thread Thomas Zimmermann
From: Alex Williamson Console drivers can create conflicts with PCI resources resulting in userspace getting mmap failures to memory BARs. This is especially evident when trying to re-use the system primary console for userspace drivers. Use the aperture helpers to remove these conflicts. v3:

[PATCH v3 2/3] drm: Implement DRM aperture helpers under video/

2022-06-22 Thread Thomas Zimmermann
Implement DRM's aperture helpers under video/ for sharing with other sub-systems. Remove DRM-isms from the interface. The helpers track the ownership of framebuffer apertures and provide hand-over from firmware, such as EFI and VESA, to native graphics drivers. Other subsystems, such as fbdev and

[PATCH] drm/i915/selftests: Increase timeout for live_parallel_switch

2022-06-22 Thread Matthew Auld
From: Akeem G Abodunrin With GuC submission, it takes a little bit longer switching contexts among all available engines simultaneously, when running live_parallel_switch subtest. Increase the timeout. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5885 Signed-off-by: Akeem G Abodunri

Re: [PATCH] drm/i915/selftests: Increase timeout for live_parallel_switch

2022-06-22 Thread Matthew Auld
On Wed, 22 Jun 2022 at 15:11, Matthew Auld wrote: > > From: Akeem G Abodunrin > > With GuC submission, it takes a little bit longer switching contexts > among all available engines simultaneously, when running > live_parallel_switch subtest. Increase the timeout. > > Closes: https://gitlab.freede

Re: [PATCH v3 1/1] drm/panfrost: Add support for devcoredump

2022-06-22 Thread Alyssa Rosenzweig
> Sorry about this blunder. > > >> + slot = panfrost_job_get_slot(job); > >> + slot = slot ? slot : 0; > > > >`slot = slot ? slot : 0` is a no-op. Delete the line. > > I think what I meant here was 'slot = (slot >= 0) ? slot : 0;' but for some > reason I blundered again. The point of this was e

Re: [PATCH v2 03/12] drm/i915/uapi: expose the avail tracking

2022-06-22 Thread Thomas Hellström
On Tue, 2022-06-21 at 11:44 +0100, Matthew Auld wrote: > Vulkan would like to have a rough measure of how much device memory > can > in theory be allocated. Also add unallocated_cpu_visible_size to > track > the visible portion, in case the device is using small BAR. Also > tweak > the locking so w

Re: [PATCH v2 09/12] drm/i915/selftests: ensure we reserve a fence slot

2022-06-22 Thread Thomas Hellström
On Tue, 2022-06-21 at 11:44 +0100, Matthew Auld wrote: > We should always be explicit and allocate a fence slot before adding > a > new fence. > > Signed-off-by: Matthew Auld > Cc: Thomas Hellström > Cc: Lionel Landwerlin > Cc: Tvrtko Ursulin > Cc: Jon Bloomfield > Cc: Daniel Vetter > Cc: Jo

Re: [PATCH v2 02/13] dt-bindings: Add headers for Host1x and VIC on Tegra234

2022-06-22 Thread Krzysztof Kozlowski
On 22/06/2022 13:37, Mikko Perttunen wrote: > From: Mikko Perttunen > > Add clock, memory controller, powergate and reset dt-binding headers > for Host1x and VIC on Tegra234. > > Signed-off-by: Mikko Perttunen > --- > include/dt-bindings/clock/tegra234-clock.h | 4 > include/dt-bindin

[PATCH] gpu/drm/radeon: Fix typo in comments

2022-06-22 Thread Jiang Jian
Remove the repeated word 'and' from comments Signed-off-by: Jiang Jian --- drivers/gpu/drm/radeon/r300_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/r300_reg.h b/drivers/gpu/drm/radeon/r300_reg.h index 60d5413bafa1..9d341cff63ee 100644 --- a/dr

Re: [PATCH v2 00/13] Host1x support on Tegra234

2022-06-22 Thread Krzysztof Kozlowski
On 22/06/2022 13:37, Mikko Perttunen wrote: > From: Mikko Perttunen > > - > Merging notes > - > > This series should be applied on top of the Host1x context isolation > series. > The dependency should be first merged into next, so automated tools can process it. Best r

Re: [PATCH v2 01/13] dt-bindings: Add bindings for Tegra234 Host1x and VIC

2022-06-22 Thread Krzysztof Kozlowski
On 22/06/2022 13:37, Mikko Perttunen wrote: > From: Mikko Perttunen > > Update VIC and Host1x bindings for changes in Tegra234. > > Namely, > - New compatible strings > - Sharded syncpoint interrupts > - Optional reset. > > Also, fix the order of descriptions for VM/hypervisor > register apertu

[PATCH v2 00/68] drm/vc4: Fix hotplug for vc4

2022-06-22 Thread Maxime Ripard
on top on next-20220622 - Consolidated the new drmm init helpers with their alloc counterparts - Dropped the drmm writeback and simple encoder helpers - Clarified the documentation of drm_connector_unregister - Removed the drm_connector_unregister usage - Fixed a vblank timeout when unbinding

[PATCH v2 01/68] drm/mipi-dsi: Detach devices when removing the host

2022-06-22 Thread Maxime Ripard
Whenever the MIPI-DSI host is unregistered, the code of mipi_dsi_host_unregister() loops over every device currently found on that bus and will unregister it. However, it doesn't detach it from the bus first, which leads to all kind of resource leaks if the host wants to perform some clean up when

[PATCH v2 02/68] drm/crtc: Introduce drmm_crtc_init_with_planes

2022-06-22 Thread Maxime Ripard
The DRM-managed function to register a CRTC is drmm_crtc_alloc_with_planes(), which will allocate the underlying structure and initialisation the CRTC. However, we might want to separate the structure creation and the CRTC initialisation, for example if the structure is shared across multiple DRM

[PATCH v2 03/68] drm/encoder: Introduce drmm_encoder_init

2022-06-22 Thread Maxime Ripard
The DRM-managed function to register an encoder is drmm_encoder_alloc() and its variants, which will allocate the underlying structure and initialisation the encoder. However, we might want to separate the structure creation and the encoder initialisation, for example if the structure is shared ac

[PATCH v2 04/68] drm/connector: Reorder headers

2022-06-22 Thread Maxime Ripard
Unlike most of the other files in DRM, and Linux in general, the headers in drm_connector.c aren't sorted alphabetically. Let's fix that. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_connector.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm

[PATCH v2 05/68] drm/connector: Mention the cleanup after drm_connector_init

2022-06-22 Thread Maxime Ripard
Unlike encoders and CRTCs, the drm_connector_init() and drm_connector_init_with_ddc() don't mention how the cleanup is supposed to be done. Let's add it. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_connector.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/d

[PATCH v2 06/68] drm/connector: Clarify when drm_connector_unregister is needed

2022-06-22 Thread Maxime Ripard
The current documentation for drm_connector_unregister() mentions that it's needed for connectors that have been registered through drm_dev_register(). However, this was a typo and was meant to be drm_connector_register(), which only applies to connectors registered after drm_dev_register() has be

[PATCH v2 07/68] drm/connector: Introduce drmm_connector_init

2022-06-22 Thread Maxime Ripard
Unlike other DRM entities, there's no helper to create a DRM-managed initialisation of a connector. Let's create an helper to initialise a connector that would be passed as an argument, and handle the cleanup through a DRM-managed action. Acked-by: Thomas Zimmermann Signed-off-by: Maxime Ripard

[PATCH v2 08/68] drm/connector: Introduce drmm_connector_init_with_ddc

2022-06-22 Thread Maxime Ripard
Let's create a DRM-managed variant of drm_connector_init_with_ddc that will take care of an action of the connector cleanup. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_connector.c | 74 - include/drm/drm_connector.h | 5 +++ 2 files changed, 69 inse

[PATCH v2 09/68] drm/bridge: panel: Introduce drmm_panel_bridge_add

2022-06-22 Thread Maxime Ripard
Unlike what can be found for other entities, there's no DRM-managed function to create a panel_bridge instance from a panel. Let's introduce one. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/panel.c | 39 ++ include/drm/drm_bridge.h | 2 ++ 2 fi

[PATCH v2 10/68] drm/bridge: panel: Introduce drmm_of_get_bridge

2022-06-22 Thread Maxime Ripard
Unlike what can be found for other DRM entities, we don't have a DRM-managed function equivalent to devm_drm_of_get_bridge(). Let's create it. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/panel.c | 35 ++ include/drm/drm_bridge.h | 2 ++ 2 files

[PATCH v2 11/68] drm/vc4: drv: Call component_unbind_all()

2022-06-22 Thread Maxime Ripard
While we were using the component framework to deal with all the DRM subdevices, we were not calling component_unbind_all(). This leads to none of the subdevices freeing up their resources as part of their unbind() or device managed hooks. Fixes: c8b75bca92cb ("drm/vc4: Add KMS support for Raspbe

[PATCH v2 12/68] drm/vc4: drv: Use drm_dev_unplug

2022-06-22 Thread Maxime Ripard
When our KMS driver is unbound, the device is no longer there but we might still have users with an opened fd to the KMS device. To avoid any issue in such a situation, every device access needs to be protected by calls to drm_dev_enter() and drm_dev_exit(), and the driver needs to call drm_dev_un

  1   2   3   >