Re: [PATCH 07/14] riscv: dts: canaan: fix the k210's memory node

2022-06-20 Thread Damien Le Moal
On 6/20/22 08:54, conor.doo...@microchip.com wrote: > On 20/06/2022 00:38, Damien Le Moal wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the >> content is safe >> >> On 6/18/22 21:30, Conor Dooley wrote: >>> From: Conor Dooley >>> >>> The k210 memory node has a c

Re: [PATCH 07/14] riscv: dts: canaan: fix the k210's memory node

2022-06-20 Thread Damien Le Moal
On 6/18/22 21:30, Conor Dooley wrote: > From: Conor Dooley > > The k210 memory node has a compatible string that does not match with > any driver or dt-binding & has several non standard properties. > Replace the reg names with a comment and delete the rest. > > Signed-off-by: Conor Dooley > --

Re: [PATCH, v2] media: mediatek: vcodec: Fix non subdev architecture open power fail

2022-06-20 Thread Chen-Yu Tsai
On Fri, Jun 17, 2022 at 3:25 PM Yunfei Dong wrote: > > According to subdev_bitmap bit value to open hardware power, need to > set subdev_bitmap value for non subdev architecture. > > Fixes: c05bada35f01 ("media: mtk-vcodec: Add to support multi hardware > decode") > Signed-off-by: Yunfei Dong R

Re: [Intel-gfx] [PATCH v2 1/1] i915/gem: drop wbinvd_on_all_cpus usage

2022-06-20 Thread Thomas Hellström
Hi, On Fri, 2022-06-17 at 16:30 -0700, Lucas De Marchi wrote: > On Thu, Apr 14, 2022 at 11:19:23AM -0700, Michael Cheng wrote: > > Previous concern with using drm_clflush_sg was that we don't know > > what the > > sg_table is pointing to, thus the usage of wbinvd_on_all_cpus to > > flush > > every

[PATCH v2 0/4] HDR aux backlight range calculation

2022-06-20 Thread Jouni Högander
This patch set splits out static hdr metadata backlight range parsing from gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c into gpu/drm/drm-edid.c as a new function. This new function is then used during edid parsing when HDR static metadata block parsing. Calculated values are stored in a new struct dr

[PATCH v2 1/4] drm/display: Add drm_luminance_range_info

2022-06-20 Thread Jouni Högander
Add new data structure to store luminance range calculated using data from EDID's static hdr metadata block. Add this new struct as a part of drm_display_info struct. Cc: Roman Li Cc: Rodrigo Siqueira Cc: Harry Wentland Cc: Lyude Paul Cc: Mika Kahola Cc: Jani Nikula Cc: Manasi Navare Signed

[PATCH v2 2/4] drm: New function to get luminance range based on static hdr metadata

2022-06-20 Thread Jouni Högander
Split luminance min/max calculation using static hdr metadata from drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:update_connector_ext_caps into drm/drm_edid.c and use it during edid parsing. Calculated range is stored into connector->display_info->luminance_range. v2: Calculate range during ed

[PATCH v2 3/4] drm/amdgpu_dm: Rely on split out luminance calculation function

2022-06-20 Thread Jouni Högander
Luminance range calculation was split out into drm_edid.c and is now part of edid parsing. Rely on values calculated during edid parsing and use these for caps->aux_max_input_signal and caps->aux_min_input_signal. v2: Use values calculated during edid parsing Cc: Roman Li Cc: Rodrigo Siqueira C

[PATCH v2 4/4] drm/i915: Use luminance range calculated during edid parsing

2022-06-20 Thread Jouni Högander
Instead of using fixed 0 - 512 range use luminance range calculated as a part of edid parsing. As a backup fall back to static 0 - 512. v2: Use values calculated during edid parsing Cc: Lyude Paul Cc: Mika Kahola Cc: Jani Nikula Cc: Manasi Navare Signed-off-by: Jouni Högander --- .../drm/i9

Re: [PATCH 06/14] spi: dt-bindings: dw-apb-ssi: update spi-{r,t}x-bus-width for dwc-ssi

2022-06-20 Thread Geert Uytterhoeven
Hi Conor, On Sat, Jun 18, 2022 at 2:32 PM Conor Dooley wrote: > From: Conor Dooley > > snps,dwc-ssi-1.01a has a single user - the Canaan k210, which uses a > width of 4 for spi-{r,t}x-bus-width. Update the binding to reflect > this. > > Signed-off-by: Conor Dooley Thanks for your patch! > ---

Re: [PATCH, v2] media: mediatek: vcodec: Initialize decoder parameters after getting dec_capability

2022-06-20 Thread AngeloGioacchino Del Regno
Il 20/06/22 08:32, Yunfei Dong ha scritto: Need to get dec_capability from scp first, then initialize decoder supported format and other parameters according to dec_capability value. Fixes: fd00d90330d1 ("media: mtk-vcodec: vdec: move stateful ops into their own file") Signed-off-by: Yunfei Don

Re: [PATCH, v2] media: mediatek: vcodec: Initialize decoder parameters after getting dec_capability

2022-06-20 Thread Chen-Yu Tsai
On Mon, Jun 20, 2022 at 2:32 PM Yunfei Dong wrote: > > Need to get dec_capability from scp first, then initialize decoder > supported format and other parameters according to dec_capability value. > > Fixes: fd00d90330d1 ("media: mtk-vcodec: vdec: move stateful ops into their > own file") > Signe

Re: [PATCH v2 1/3] dt-bindings: phy: qcom,hdmi-phy-qmp: add clock-cells and XO clock

2022-06-20 Thread Krzysztof Kozlowski
On 20/06/2022 03:02, Dmitry Baryshkov wrote: > As the QMP HDMI PHY is a clock provider, add constant #clock-cells > property. For the compatibility with older DTs the property is not > marked as required. Also add the XO clock to the list of the clocks used > by the driver. > > Signed-off-by: Dmit

Re: [PATCH v2 3/3] arm64: dts: qcom: msm8996: add #clock-cells and XO clock to the HDMI PHY node

2022-06-20 Thread Krzysztof Kozlowski
On 20/06/2022 03:03, Dmitry Baryshkov wrote: > Add #clock-cells property to the HDMI PHY device node to let other nodes > resolve the hdmipll clock. While we are at it, also add the XO clock to > the device node. > > Signed-off-by: Dmitry Baryshkov Acked-by: Krzysztof Kozlowski Best regards,

Re: [PATCH v5 01/13] mm: add zone device coherent type memory support

2022-06-20 Thread Alistair Popple
Oded Gabbay writes: > On Mon, Jun 20, 2022 at 3:33 AM Alistair Popple wrote: >> >> >> Oded Gabbay writes: >> >> > On Fri, Jun 17, 2022 at 8:20 PM Sierra Guiza, Alejandro (Alex) >> > wrote: >> >> >> >> >> >> On 6/17/2022 4:40 AM, David Hildenbrand wrote: >> >> > On 31.05.22 22:00, Alex Sierra

Re: radeon driver warning

2022-06-20 Thread Christian König
Am 17.06.22 um 16:22 schrieb John Garry: Hi Christian, Am 17.06.22 um 14:01 schrieb John Garry: On 17/06/2022 12:57, Christian König wrote: And/Or compile out the warning when "warnings = errors"? That should be doable I think. ok, if something can be done then I would appreciate it. I d

[PATCH 1/2] drm/amdgpu: Drop CONFIG_BACKLIGHT_CLASS_DEVICE ifdefs

2022-06-20 Thread Hans de Goede
The DRM_AMDGPU Kconfig code contains: select BACKLIGHT_CLASS_DEVICE So the condition these ifdefs test for is always true, drop them. Signed-off-by: Hans de Goede --- drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 6 -- drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 4 -

[PATCH 2/2] drm/radeon: Drop CONFIG_BACKLIGHT_CLASS_DEVICE ifdefs

2022-06-20 Thread Hans de Goede
The DRM_RADEON Kconfig code contains: select BACKLIGHT_CLASS_DEVICE So the condition these ifdefs test for is always true, drop them. Signed-off-by: Hans de Goede --- drivers/gpu/drm/radeon/atombios_encoders.c | 14 -- drivers/gpu/drm/radeon/radeon_acpi.c|

[PATCH] drm/nouveau/Kconfig: Drop duplicate "select ACPI_VIDEO"

2022-06-20 Thread Hans de Goede
Before this change nouveau's Kconfig section had 2 "select ACPI_VIDEO" statements: select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && INPUT select ACPI_VIDEO if ACPI && X86 Drop the one with the extra conditions, if the conditions for that one are true then the second statement will al

Re: [PATCH v3 00/14] Driver of Intel(R) Gaussian & Neural Accelerator

2022-06-20 Thread Greg KH
On Mon, Jun 20, 2022 at 11:49:07AM +0200, maciej.kwapulin...@linux.intel.com wrote: > Please share your thoughts. No code here to share thoughts about :(

Re: DRM FB interface does not sanitize len when mmap'ed

2022-06-20 Thread Thomas Zimmermann
Hi Am 20.06.22 um 01:01 schrieb Nuno Gonçalves: On Fri, Jun 17, 2022 at 10:27 AM Thomas Zimmermann wrote: Could you please try the attached patch? It's similar to your solution, but closer to the original intention of the code. Works fine. Tested-by: Nuno Gonçalves Thanks, I'll post the

Re: [PATCH v2] drm/bridge: cdns-dsi: Add support for J721E wrapper

2022-06-20 Thread Tomi Valkeinen
Hi, On 19/06/2022 17:01, Rahul T R wrote: Add support for wrapper settings for DSI bridge on j721e. Also set the DPI input to DPI0 Signed-off-by: Rahul T R --- Nack... This wouldn't work with some other SoC using CDNS DSI. See cdns-mhdp8546 for an example of a bit more generic wrapper suppo

Re: [PATCH] drm/i915/gem: remove unused assignments

2022-06-20 Thread Jani Nikula
On Mon, 20 Jun 2022, zys.zlj...@gmail.com wrote: > From: katrinzhou > > The variable ret is reassigned and the value EINVAL is never used. > Thus, remove the unused assignments. It's obviously a bug, but it's not obvious just throwing the code away is the fix. Maybe there's a missing "else" inste

Re: [PATCH] drm/i915/gem: remove unused assignments

2022-06-20 Thread Tvrtko Ursulin
On 20/06/2022 11:02, zys.zlj...@gmail.com wrote: From: katrinzhou The variable ret is reassigned and the value EINVAL is never used. Thus, remove the unused assignments. Addresses-Coverity: ("Unused value") Fixes: d4433c7600f7 ("drm/i915/gem: Use the proto-context to handle create parameter

Re: [PATCH 05/64] drm/connector: Mention the cleanup after drm_connector_init

2022-06-20 Thread Thomas Zimmermann
Hi Am 10.06.22 um 11:28 schrieb Maxime Ripard: Unlike encoders and CRTCs, the drm_connector_init() and drm_connector_init_with_ddc() don't mention how the cleanup is supposed to be done. Let's add it. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_connector.c | 10 ++ 1 file c

Re: [PATCH 06/64] drm/connector: Introduce drmm_connector_init

2022-06-20 Thread Thomas Zimmermann
Am 10.06.22 um 11:28 schrieb Maxime Ripard: Unlike other DRM entities, there's no helper to create a DRM-managed initialisation of a connector. Let's create an helper to initialise a connector that would be passed as an argument, and handle the cleanup through a DRM-managed action. Signed-off

Re: [PATCH v3 00/14] Driver of Intel(R) Gaussian & Neural Accelerator

2022-06-20 Thread Greg KH
On Mon, Jun 20, 2022 at 12:08:34PM +0200, Maciej Kwapulinski wrote: > > Greg KH writes: > > > On Mon, Jun 20, 2022 at 11:49:07AM +0200, > > maciej.kwapulin...@linux.intel.com wrote: > >> Please share your thoughts. > > > > No code here to share thoughts about :( > > code will be published in c

Re: [PATCH 08/64] drm/writeback: Introduce drmm_writeback_connector_init

2022-06-20 Thread Thomas Zimmermann
Hi Am 10.06.22 um 11:28 schrieb Maxime Ripard: Let's create a DRM-managed variant of drmm_writeback_connector_init that will take care of an action of the encoder and connector cleanup. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_writeback.c | 136

Re: [Intel-gfx] [PATCH v2 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-20 Thread Tvrtko Ursulin
Hi, On 17/06/2022 06:14, Niranjana Vishwanathapura wrote: VM_BIND design document with description of intended use cases. v2: Reduce the scope to simple Mesa use case. since I expressed interest please add me to cc when sending out. How come the direction changed to simplify all of a sudde

Re: [PATCH 09/64] drm/simple: Introduce drmm_simple_encoder_init

2022-06-20 Thread Thomas Zimmermann
Hi Am 10.06.22 um 11:28 schrieb Maxime Ripard: The DRM-managed function to register an encoder is drmm_simple_encoder_alloc() and its variants, which will allocate the underlying structure and initialisation the encoder. However, we might want to separate the structure creation and the encoder

Re: [PATCH 13/64] drm/vc4: hvs: Protect device resources after removal

2022-06-20 Thread Thomas Zimmermann
Am 10.06.22 um 11:28 schrieb Maxime Ripard: Whenever the device and driver are unbound, the main device and all the subdevices will be removed by calling their unbind() method. However, the DRM device itself will only be freed when the last user will have closed it. It means that there is a t

Re: [PATCH 32/64] drm/vc4: dsi: Fix the driver structure lifetime

2022-06-20 Thread Thomas Zimmermann
Am 10.06.22 um 11:28 schrieb Maxime Ripard: The vc4_dsi structure is currently allocated through a device-managed allocation. This can lead to use-after-free issues however in the unbinding path since the DRM entities will stick around, but the underlying structure has been freed. However, we

Re: [PATCH 32/64] drm/vc4: dsi: Fix the driver structure lifetime

2022-06-20 Thread Thomas Zimmermann
Am 20.06.22 um 12:55 schrieb Thomas Zimmermann: Am 10.06.22 um 11:28 schrieb Maxime Ripard: The vc4_dsi structure is currently allocated through a device-managed allocation. This can lead to use-after-free issues however in the unbinding path since the DRM entities will stick around, but th

Re: [PATCH 34/64] drm/vc4: hdmi: Switch to drmm_kzalloc

2022-06-20 Thread Thomas Zimmermann
Am 10.06.22 um 11:28 schrieb Maxime Ripard: Our internal structure that stores the DRM entities structure is allocated through a device-managed kzalloc. This means that this will eventually be freed whenever the device is removed. In our case, the most like source of removal is that the main

Re: [PATCH 43/64] drm/vc4: hdmi: Protect device resources after removal

2022-06-20 Thread Thomas Zimmermann
Am 10.06.22 um 11:29 schrieb Maxime Ripard: Whenever the device and driver are unbound, the main device and all the subdevices will be removed by calling their unbind() method. However, the DRM device itself will only be freed when the last user will have closed it. It means that there is a t

Re: [PATCH 45/64] drm/vc4: txp: Remove vc4_dev txp pointer

2022-06-20 Thread Thomas Zimmermann
Am 10.06.22 um 11:29 schrieb Maxime Ripard: There's no user for that pointer so let's just get rid of it. Signed-off-by: Maxime Ripard Acked-by: Thomas Zimmermann --- drivers/gpu/drm/vc4/vc4_drv.h | 1 - drivers/gpu/drm/vc4/vc4_txp.c | 6 -- 2 files changed, 7 deletions(-) diff

Re: [PATCH 46/64] drm/vc4: txp: Remove duplicate regset

2022-06-20 Thread Thomas Zimmermann
Am 10.06.22 um 11:29 schrieb Maxime Ripard: There's already a regset in the vc4_crtc structure so there's no need to duplicate it in vc4_txp. Signed-off-by: Maxime Ripard Acked-by: Thomas Zimmermann --- drivers/gpu/drm/vc4/vc4_txp.c | 9 - 1 file changed, 4 insertions(+), 5 de

Re: [PATCH 47/64] drm/vc4: txp: Switch to drmm_kzalloc

2022-06-20 Thread Thomas Zimmermann
Am 10.06.22 um 11:29 schrieb Maxime Ripard: Our internal structure that stores the DRM entities structure is allocated through a device-managed kzalloc. This means that this will eventually be freed whenever the device is removed. In our case, the most like source of removal is that the main d

Re: [PATCH] drm/i915/display: Re-add check for low voltage sku for max dp source rate

2022-06-20 Thread Jason A. Donenfeld
Hi Jani, Do you plan to merge this revert? Thanks, Jason

Re: [PATCH v2 0/2] Improve vfio-pci primary GPU assignment behavior

2022-06-20 Thread Laszlo Ersek
On 06/16/22 22:38, Alex Williamson wrote: > When assigning a primary graphics device to VM through vfio-pci device > assignment, users often prevent binding of the native PCI graphics > driver to avoid device initialization conflicts, however firmware > console drivers may still be attached to the

[Bug 201957] amdgpu: ring gfx timeout

2022-06-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201957 --- Comment #72 from Martin von Wittich (martin.von.witt...@iserv.eu) --- I can confirm that adding "amdgpu.dpm=0" to the kernel command line seems to resolve this issue - I enabled that option on 2022-06-12 13:24, and my system didn't crash at al

[Bug 201957] amdgpu: ring gfx timeout

2022-06-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201957 --- Comment #73 from Martin von Wittich (martin.von.witt...@iserv.eu) --- Sorry, forgot to mention in my last post and now can't edit: interestingly enough, the attached video "5 second video clip that triggers a crash" still successfully triggers

Re: [PATCH 05/64] drm/connector: Mention the cleanup after drm_connector_init

2022-06-20 Thread Maxime Ripard
Hi Thomas, Thanks for your review On Mon, Jun 20, 2022 at 12:21:33PM +0200, Thomas Zimmermann wrote: > Am 10.06.22 um 11:28 schrieb Maxime Ripard: > > Unlike encoders and CRTCs, the drm_connector_init() and > > drm_connector_init_with_ddc() don't mention how the cleanup is supposed to > > be done

Re: [PATCH 25/64] drm/vc4: dpi: Add action to disable the clock

2022-06-20 Thread Maxime Ripard
On Thu, Jun 16, 2022 at 10:47:56AM +0100, Dave Stevenson wrote: > On Thu, 16 Jun 2022 at 09:38, Maxime Ripard wrote: > > > > Hi Dave, > > > > On Tue, Jun 14, 2022 at 05:47:28PM +0100, Dave Stevenson wrote: > > > Hi Maxime. > > > > > > On Fri, 10 Jun 2022 at 10:30, Maxime Ripard wrote: > > > > > >

Re: [PATCH v5 01/13] mm: add zone device coherent type memory support

2022-06-20 Thread Oded Gabbay
On Mon, Jun 20, 2022 at 11:50 AM Alistair Popple wrote: > > > Oded Gabbay writes: > > > On Mon, Jun 20, 2022 at 3:33 AM Alistair Popple wrote: > >> > >> > >> Oded Gabbay writes: > >> > >> > On Fri, Jun 17, 2022 at 8:20 PM Sierra Guiza, Alejandro (Alex) > >> > wrote: > >> >> > >> >> > >> >> On

Re: [PATCH v12 01/14] dt-bindings: mediatek,dpi: Add DP_INTF compatible

2022-06-20 Thread Maxime Ripard
On Mon, Jun 20, 2022 at 08:10:15PM +0800, Bo-Chen Chen wrote: > From: Markus Schneider-Pargmann > > DP_INTF is similar to DPI but does not have the exact same feature set > or register layouts. > > DP_INTF is the sink of the display pipeline that is connected to the > DisplayPort controller and

Re: [Intel-gfx] [PATCH] drm/i915: Fix vm use-after-free in vma destruction

2022-06-20 Thread Thomas Hellström
Hi, Andi On 5/19/22 23:46, Andi Shyti wrote: Hi Thomas, On Thu, May 12, 2022 at 11:40:45AM +0200, Thomas Hellström wrote: In vma destruction, the following race may occur: Thread 1: Thread 2: i915_vma_destroy(); ... list_del_init(vma->vm_link); ... mutex_u

Re: [PATCH] fbdev: Fix syntax errors in comments

2022-06-20 Thread Helge Deller
On 6/5/22 10:59, Xiang wangx wrote: > Delete the redundant word 'its'. > > Signed-off-by: Xiang wangx applied to fbdev tree. Thanks! Helge > --- > drivers/video/fbdev/skeletonfb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/skeletonfb.c > b/dri

[PATCH v2] drm/i915: Fix vm use-after-free in vma destruction

2022-06-20 Thread Thomas Hellström
In vma destruction, the following race may occur: Thread 1: Thread 2: i915_vma_destroy(); ... list_del_init(vma->vm_link); ... mutex_unlock(vma->vm->mutex); __i915_vm_release(); release_references(); And in release_reference() we

Re: [PATCH 0/2] video: fbdev: Convert from PCI to generic power management

2022-06-20 Thread Helge Deller
On 6/8/22 20:09, Bjorn Helgaas wrote: > On Wed, Jun 08, 2022 at 06:26:34PM +0200, Daniel Vetter wrote: >> On Tue, Jun 07, 2022 at 06:11:10PM -0500, Bjorn Helgaas wrote: >>> From: Bjorn Helgaas >>> >>> PCI-specific power management (pci_driver.suspend and pci_driver.resume) is >>> deprecated. If d

Re: [PATCH 13/64] drm/vc4: hvs: Protect device resources after removal

2022-06-20 Thread Maxime Ripard
Hi Dave, On Tue, Jun 14, 2022 at 04:11:20PM +0100, Dave Stevenson wrote: > On Fri, 10 Jun 2022 at 10:30, Maxime Ripard wrote: > > > > Whenever the device and driver are unbound, the main device and all the > > subdevices will be removed by calling their unbind() method. > > > > However, the DRM d

Re: [PATCH 13/64] drm/vc4: hvs: Protect device resources after removal

2022-06-20 Thread Maxime Ripard
Hi, On Tue, Jun 14, 2022 at 05:59:15PM +0100, Dave Stevenson wrote: > > > @@ -132,14 +139,18 @@ static int vc4_hvs_upload_linear_kernel(struct > > > vc4_hvs *hvs, > > > struct drm_mm_node *space, > > > const u32 *kern

Re: [PATCH v2] drm/i915: Fix vm use-after-free in vma destruction

2022-06-20 Thread Das, Nirmoy
Acked-by: Nirmoy Das On 6/20/2022 2:36 PM, Thomas Hellström wrote: In vma destruction, the following race may occur: Thread 1: Thread 2: i915_vma_destroy(); ... list_del_init(vma->vm_link); ... mutex_unlock(vma->vm->mutex);

Re: [PATCH 09/64] drm/simple: Introduce drmm_simple_encoder_init

2022-06-20 Thread Maxime Ripard
Hi, On Mon, Jun 20, 2022 at 12:44:24PM +0200, Thomas Zimmermann wrote: > Am 10.06.22 um 11:28 schrieb Maxime Ripard: > > The DRM-managed function to register an encoder is > > drmm_simple_encoder_alloc() and its variants, which will allocate the > > underlying structure and initialisation the enco

Re: [PATCH v6 17/22] drm/shmem-helper: Add generic memory shrinker

2022-06-20 Thread Dmitry Osipenko
On 6/19/22 20:53, Rob Clark wrote: ... >> +static unsigned long >> +drm_gem_shmem_shrinker_count_objects(struct shrinker *shrinker, >> +struct shrink_control *sc) >> +{ >> + struct drm_gem_shmem_shrinker *gem_shrinker = >> to_drm_shrinker(shrinker); >> +

Re: [PATCH 05/64] drm/connector: Mention the cleanup after drm_connector_init

2022-06-20 Thread Thomas Zimmermann
Hi Am 20.06.22 um 14:18 schrieb Maxime Ripard: + * At driver unload time the driver's &drm_connector_funcs.destroy hook + * should call drm_connector_unregister(), drm_connector_cleanup() and + * kfree() the connector structure. This sentence sounds odd. -- Thomas Zimmermann Graphics Driver D

Re: [PATCH 09/64] drm/simple: Introduce drmm_simple_encoder_init

2022-06-20 Thread Thomas Zimmermann
Hi Am 20.06.22 um 15:48 schrieb Maxime Ripard: Hi, On Mon, Jun 20, 2022 at 12:44:24PM +0200, Thomas Zimmermann wrote: Am 10.06.22 um 11:28 schrieb Maxime Ripard: The DRM-managed function to register an encoder is drmm_simple_encoder_alloc() and its variants, which will allocate the underlying

Re: [PATCH 09/64] drm/simple: Introduce drmm_simple_encoder_init

2022-06-20 Thread Maxime Ripard
On Mon, Jun 20, 2022 at 04:25:38PM +0200, Thomas Zimmermann wrote: > Hi > > Am 20.06.22 um 15:48 schrieb Maxime Ripard: > > Hi, > > > > On Mon, Jun 20, 2022 at 12:44:24PM +0200, Thomas Zimmermann wrote: > > > Am 10.06.22 um 11:28 schrieb Maxime Ripard: > > > > The DRM-managed function to register

Re: [PATCH 05/64] drm/connector: Mention the cleanup after drm_connector_init

2022-06-20 Thread Maxime Ripard
On Mon, Jun 20, 2022 at 04:19:43PM +0200, Thomas Zimmermann wrote: > Hi > > Am 20.06.22 um 14:18 schrieb Maxime Ripard: > > + * At driver unload time the driver's &drm_connector_funcs.destroy hook > > + * should call drm_connector_unregister(), drm_connector_cleanup() and > > + * kfree() the conne

RE: [PATCH v2 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-20 Thread Zeng, Oak
Thanks, Oak > -Original Message- > From: Vishwanathapura, Niranjana > Sent: June 17, 2022 1:15 AM > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Vetter, > Daniel > Cc: Hellstrom, Thomas ; Wilson, Chris P > ; ja...@jlekstrand.net; > christian.koe...@amd.com; Bro

Re: [PATCH 05/64] drm/connector: Mention the cleanup after drm_connector_init

2022-06-20 Thread Thomas Zimmermann
Hi Am 20.06.22 um 16:40 schrieb Maxime Ripard: On Mon, Jun 20, 2022 at 04:19:43PM +0200, Thomas Zimmermann wrote: Hi Am 20.06.22 um 14:18 schrieb Maxime Ripard: + * At driver unload time the driver's &drm_connector_funcs.destroy hook + * should call drm_connector_unregister(), drm_connector_c

Re: [PATCH 09/64] drm/simple: Introduce drmm_simple_encoder_init

2022-06-20 Thread Thomas Zimmermann
Hi Am 20.06.22 um 16:39 schrieb Maxime Ripard: On Mon, Jun 20, 2022 at 04:25:38PM +0200, Thomas Zimmermann wrote: Hi Am 20.06.22 um 15:48 schrieb Maxime Ripard: Hi, On Mon, Jun 20, 2022 at 12:44:24PM +0200, Thomas Zimmermann wrote: Am 10.06.22 um 11:28 schrieb Maxime Ripard: The DRM-manage

Re: [PATCH v6 17/22] drm/shmem-helper: Add generic memory shrinker

2022-06-20 Thread Rob Clark
On Mon, Jun 20, 2022 at 7:09 AM Dmitry Osipenko wrote: > > On 6/19/22 20:53, Rob Clark wrote: > ... > >> +static unsigned long > >> +drm_gem_shmem_shrinker_count_objects(struct shrinker *shrinker, > >> +struct shrink_control *sc) > >> +{ > >> + struct drm_

Re: [PATCH 3/3] drm/msm/dp: Get rid of dp_ctrl_on_stream_phy_test_report()

2022-06-20 Thread Kuogee Hsieh
On 6/17/2022 1:47 PM, Stephen Boyd wrote: This API isn't really more than a couple lines now that we don't store the pixel_rate to the struct member. Inline it into the caller. Cc: Kuogee Hsieh Signed-off-by: Stephen Boyd Reviewed-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_ctrl.c |

Re: [PATCH 1/3] drm/msm/dp: Reorganize code to avoid forward declaration

2022-06-20 Thread Kuogee Hsieh
On 6/17/2022 3:50 PM, Dmitry Baryshkov wrote: On 17/06/2022 23:47, Stephen Boyd wrote: Let's move these functions around to avoid having to forward declare dp_ctrl_on_stream_phy_test_report(). Also remove dp_ctrl_reinitialize_mainlink() forward declaration because we're doing that sort of task

Re: [RFT][PATCH v1 6/6] vfio: Replace phys_pfn with phys_page for vfio_pin_pages()

2022-06-20 Thread Jason Gunthorpe
On Sun, Jun 19, 2022 at 11:37:47PM -0700, Christoph Hellwig wrote: > On Sun, Jun 19, 2022 at 10:51:47PM -0700, Christoph Hellwig wrote: > > On Mon, Jun 20, 2022 at 12:00:46AM -0300, Jason Gunthorpe wrote: > > > On Fri, Jun 17, 2022 at 01:54:05AM -0700, Christoph Hellwig wrote: > > > > There is a bu

Re: [PATCH v6 17/22] drm/shmem-helper: Add generic memory shrinker

2022-06-20 Thread Rob Clark
() On Thu, May 26, 2022 at 4:55 PM Dmitry Osipenko wrote: > > Introduce a common DRM SHMEM shrinker framework that allows to reduce > code duplication among DRM drivers by replacing theirs custom shrinker > implementations with the generic shrinker. > > In order to start using DRM SHMEM shrinker

Re: [RFT][PATCH v1 5/6] vfio/ccw: Add kmap_local_page() for memcpy

2022-06-20 Thread Jason Gunthorpe
On Sun, Jun 19, 2022 at 11:32:07PM -0700, Christoph Hellwig wrote: > > This helps because we now block io memory from ever getting into these > > call paths. I'm pretty sure this is a serious security bug, but would > > let the IBM folks remark as I don't know it all that well.. > > Prevent as in

Re: [PATCH v2 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-20 Thread Niranjana Vishwanathapura
On Mon, Jun 20, 2022 at 07:42:25AM -0700, Zeng, Oak wrote: Thanks, Oak -Original Message- From: Vishwanathapura, Niranjana Sent: June 17, 2022 1:15 AM To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Vetter, Daniel Cc: Hellstrom, Thomas ; Wilson, Chris P ; ja...

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix vm use-after-free in vma destruction

2022-06-20 Thread Andrzej Hajda
On 20.06.2022 14:36, Thomas Hellström wrote: In vma destruction, the following race may occur: Thread 1: Thread 2: i915_vma_destroy(); ... list_del_init(vma->vm_link); ... mutex_unlock(vma->vm->mutex); __i915_vm_release(); re

[PATCH v4 0/3] KUnit tests for drm_format_helper

2022-06-20 Thread José Expósito
Hello everyone, Following the style used in the selftest to KUnit series [1] and the AMD series [2], the tests were moved to the "tests" folder. In addition, to be consistent naming functions, I renamed the kunit_suite and the test cases to use underscores as suggested in [3]. It is not clear yet

[PATCH v4 1/3] drm/rect: Add DRM_RECT_INIT() macro

2022-06-20 Thread José Expósito
Add a helper macro to initialize a rectangle from x, y, width and height information. Reviewed-by: Jani Nikula Acked-by: Thomas Zimmermann Signed-off-by: José Expósito --- include/drm/drm_rect.h | 16 1 file changed, 16 insertions(+) diff --git a/include/drm/drm_rect.h b/incl

[PATCH v4 2/3] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

2022-06-20 Thread José Expósito
Test the conversion from XRGB to RGB332. What is tested? - Different values for the X in XRGB to make sure it is ignored - Different clip values: Single pixel and full and partial buffer - Well known colors: White, black, red, green, blue, magenta, yellow and cyan - Other colors: R

[PATCH v4 3/3] drm/doc: Add KUnit documentation

2022-06-20 Thread José Expósito
Explain how to run the KUnit tests present in the DRM subsystem and clarify why the UML-only options were not added to the configuration file present in drivers/gpu/drm/.kunitconfig [1] [2]. [1] https://lore.kernel.org/dri-devel/CABVgOSn8i=lo5p7830h2xu1jgg0krn0qtnxkomhf1otgxja...@mail.gmail.com/

Re: [Intel-gfx] [PATCH] drm/i915/display: Re-add check for low voltage sku for max dp source rate

2022-06-20 Thread Jani Nikula
On Mon, 20 Jun 2022, "Jason A. Donenfeld" wrote: > Hi Jani, > > Do you plan to merge this revert? Yes, I've done that now, thanks for the bisection and the patch. Ankit, Imre, we need to figure out what to do with [1] now. BR, Jani. [1] https://gitlab.freedesktop.org/drm/intel/-/issues/5272

Re: [Intel-gfx] [PATCH] drm/i915/display: Re-add check for low voltage sku for max dp source rate

2022-06-20 Thread Jason A. Donenfeld
Hi Jani, On Mon, Jun 20, 2022 at 07:10:30PM +0300, Jani Nikula wrote: > On Mon, 20 Jun 2022, "Jason A. Donenfeld" wrote: > > Hi Jani, > > > > Do you plan to merge this revert? > > Yes, I've done that now, thanks for the bisection and the patch. Thanks! I see that this went into `drm-intel-next

Re: [Intel-gfx] [PATCH] drm/i915/display: Re-add check for low voltage sku for max dp source rate

2022-06-20 Thread Jani Nikula
On Mon, 20 Jun 2022, "Jason A. Donenfeld" wrote: > Hi Jani, > > On Mon, Jun 20, 2022 at 07:10:30PM +0300, Jani Nikula wrote: >> On Mon, 20 Jun 2022, "Jason A. Donenfeld" wrote: >> > Hi Jani, >> > >> > Do you plan to merge this revert? >> >> Yes, I've done that now, thanks for the bisection and t

Re: [Intel-gfx] [PATCH v2 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-20 Thread Niranjana Vishwanathapura
On Mon, Jun 20, 2022 at 11:43:10AM +0100, Tvrtko Ursulin wrote: Hi, On 17/06/2022 06:14, Niranjana Vishwanathapura wrote: VM_BIND design document with description of intended use cases. v2: Reduce the scope to simple Mesa use case. since I expressed interest please add me to cc when sending

[pull] drm/msm: drm-msm-fixes-2022-06-20 for v5.19-rc4

2022-06-20 Thread Rob Clark
Hi Dave, Here are fixes for v5.19, summary below (and in tag msg) The following changes since commit 24df12013853ac59c52cc726e9cbe51e38d09eda: MAINTAINERS: Add Dmitry as MSM DRM driver co-maintainer (2022-05-07 12:02:29 -0700) are available in the Git repository at: https://gitlab.freedesk

[PATCH v2] drm/sun4i: Add DMA mask and segment size

2022-06-20 Thread Jernej Skrabec
Kernel occasionally complains that there is mismatch in segment size when trying to render HW decoded videos and rendering them directly with sun4i DRM driver. Following message can be observed on H6 SoC: [ 184.298308] [ cut here ] [ 184.298326] DMA-API: sun4i-drm display

Re: [PATCH 1/4] video: fbdev: offb: Include missing linux/platform_device.h

2022-06-20 Thread Helge Deller
On 6/11/22 18:50, Christophe Leroy wrote: > A lot of drivers were getting platform and of headers > indirectly via headers like asm/pci.h or asm/prom.h > > Most of them were fixed during 5.19 cycle but a newissue was > introduced by commit 52b1b46c39ae ("of: Create platform devices > for OF framebu

Re: [PATCH] video: fbdev: au1100fb: Check before some function not needed

2022-06-20 Thread Helge Deller
On 6/8/22 13:43, Yihao Han wrote: > clk_disable() already checks the clk ptr using IS_ERR_OR_NULL(clk) > and clk_enable() checks the clk ptr using !clk, so there is no > need to check clk ptr again before calling them. > > Signed-off-by: Yihao Han applied to fbdev tree. Thanks! Helge > --- > d

Re: [PATCH] fbdev: simplefb: Check before clk_put() not needed

2022-06-20 Thread Helge Deller
On 6/2/22 12:50, Hans de Goede wrote: > Hi, > > On 6/2/22 11:42, Yihao Han wrote: >> clk_put() already checks the clk ptr using !clk and IS_ERR() >> so there is no need to check it again before calling it. >> >> Signed-off-by: Yihao Han >> --- >> drivers/video/fbdev/simplefb.c | 3 +-- >> 1 file

Re: [PATCH v2 07/15] Documentation: ABI: testing: mt6370: Add ADC sysfs guideline

2022-06-20 Thread Jonathan Cameron
On Mon, 20 Jun 2022 14:00:43 +0800 ChiaEn Wu wrote: > Hi Jonathan, > > Thanks for your helpful comments, and I have some questions want to > ask you below. > > Jonathan Cameron 於 2022年6月18日 週六 晚上11:39寫道: > > > > On Mon, 13 Jun 2022 19:11:38 +0800 > > ChiaEn Wu wrote: > > > > > From: ChiaEn

[PATCH v2 0/2] per-process page tables for qcom 8250

2022-06-20 Thread Emma Anholt
This enable per-process page tables on the Qualcomm RB5 boards I'm setting up for Mesa CI. Has survived a full deqp-vk run. v2: moved qcom,adreno-smmu compatible earlier Emma Anholt (2): iommu: arm-smmu-impl: Add 8250 display compatible to the client list. arm64: dts: qcom: sm8250: Enable pe

[PATCH v2 1/2] iommu: arm-smmu-impl: Add 8250 display compatible to the client list.

2022-06-20 Thread Emma Anholt
Required for turning on per-process page tables for the GPU. Signed-off-by: Emma Anholt Reviewed-by: Konrad Dybcio Reviewed-by: Dmitry Baryshkov --- drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/driv

[PATCH v2 2/2] arm64: dts: qcom: sm8250: Enable per-process page tables.

2022-06-20 Thread Emma Anholt
This is an SMMU for the adreno gpu, and adding this compatible lets the driver use per-fd page tables, which are required for security between GPU clients. Signed-off-by: Emma Anholt Reviewed-by: Dmitry Baryshkov --- v2: moved qcom,adreno-smmu earlier arch/arm64/boot/dts/qcom/sm8250.dtsi | 2

Re: [PATCH 09/64] drm/simple: Introduce drmm_simple_encoder_init

2022-06-20 Thread Thomas Zimmermann
Hi Am 20.06.22 um 16:45 schrieb Thomas Zimmermann: Hi Am 20.06.22 um 16:39 schrieb Maxime Ripard: On Mon, Jun 20, 2022 at 04:25:38PM +0200, Thomas Zimmermann wrote: Hi Am 20.06.22 um 15:48 schrieb Maxime Ripard: Hi, On Mon, Jun 20, 2022 at 12:44:24PM +0200, Thomas Zimmermann wrote: Am 10.

Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type

2022-06-20 Thread Robert Foss
On Fri, 17 Jun 2022 at 12:32, Chen-Yu Tsai wrote: > > Hi, > > On Mon, May 23, 2022 at 4:37 PM Robert Foss wrote: > > > > On Mon, 23 May 2022 at 09:18, Chen-Yu Tsai wrote: > > > > > > On Mon, May 23, 2022 at 11:13 AM Xin Ji wrote: > > > > > > > > On Sat, May 21, 2022 at 06:28:42PM +0200, Daniel

Re: [PATCH v9 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs

2022-06-20 Thread Robert Foss
On Thu, 16 Jun 2022 at 13:18, Sakari Ailus wrote: > > On Sat, Jun 11, 2022 at 10:14:07PM +0800, Liu Ying wrote: > > Patch 1/14 and 2/14 add bus formats used by pixel combiner. > > Thanks! > > For these: > > Acked-by: Sakari Ailus Applied to drm-misc-next.

Re: (subset) [PATCH 1/2] dt-bindings: leds: qcom-wled: fix number of addresses

2022-06-20 Thread Krzysztof Kozlowski
On Thu, 5 May 2022 17:47:01 +0200, Krzysztof Kozlowski wrote: > On PM660L, PMI8994 and PMI8998, the WLED has two address spaces. This > also fixes dtbs_check warnings like: > > arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dtb: leds@d800: reg: > [[55296], [2]] is too long > > Applied, t

Re: [PATCH 0/2] Fixes for TC358775 DSI to LVDS bridge

2022-06-20 Thread Robert Foss
On Thu, 16 Jun 2022 at 00:25, Jiri Vanek wrote: > > This patchset fixes two bugs in the driver for TC358775 DSI to LVDS bridge. > > Jiri Vanek (2): > drm/bridge/tc358775: Return before displaying inappropriate error > message > drm/bridge/tc358775: Fix DSI clock division for vsync delay >

Re: [PATCH v13 0/3] eDP/DP Phy vdda realted function

2022-06-20 Thread Kuogee Hsieh
On 6/16/2022 5:02 PM, Vinod Koul wrote: On 25-05-22, 14:02, Kuogee Hsieh wrote: 1) add regulator_set_load() to eDP phy 2) add regulator_set_load() to DP phy 3) remove vdda related function out of eDP/DP controller Kuogee Hsieh (3): phy: qcom-edp: add regulator_set_load to edp phy phy: q

Re: [PATCH v2 1/2] drm/bridge: ti-sn65dsi83: add more dev_err_probe

2022-06-20 Thread Robert Foss
On Tue, 14 Jun 2022 at 11:58, Alexander Stein wrote: > > Add more warning/debug messages during probe. E.g. a single -EPROBE_DEFER > might have several causes, these messages help finding the origin. > > Signed-off-by: Alexander Stein > --- > * New in v2 > > drivers/gpu/drm/bridge/ti-sn65dsi83.c

[PATCH v14 0/3] eDP/DP Phy vdda realted function

2022-06-20 Thread Kuogee Hsieh
0) rebase on https://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git tree 1) add regulator_set_load() to eDP phy 2) add regulator_set_load() to DP phy 3) remove vdda related function out of eDP/DP controller Kuogee Hsieh (3): phy: qcom-edp: add regulator_set_load to edp phy phy: qco

[PATCH v14 1/3] phy: qcom-edp: add regulator_set_load to edp phy

2022-06-20 Thread Kuogee Hsieh
This patch add regulator_set_load() before enable regulator at eDP phy driver. Signed-off-by: Kuogee Hsieh Reviewed-by: Douglas Anderson --- drivers/phy/qualcomm/phy-qcom-edp.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/q

[PATCH v14 2/3] phy: qcom-qmp: add regulator_set_load to dp phy

2022-06-20 Thread Kuogee Hsieh
This patch add regulator_set_load() before enable regulator at DP phy driver. Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd Reviewed-by: Douglas Anderson --- drivers/phy/qualcomm/phy-qcom-qmp.c | 40 - 1 file changed, 31 insertions(+), 9 deletions(-)

[PATCH v14 3/3] drm/msm/dp: delete vdda regulator related functions from eDP/DP controller

2022-06-20 Thread Kuogee Hsieh
Vdda regulators are related to both eDP and DP phy so that it should be managed at eDP and DP phy driver instead of controller. This patch removes vdda regulators related functions out of eDP/DP controller. Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd Reviewed-by: Dmitry Baryshkov Revi

Re: [PATCH v14 1/3] phy: qcom-edp: add regulator_set_load to edp phy

2022-06-20 Thread Dmitry Baryshkov
On 20/06/2022 23:12, Kuogee Hsieh wrote: This patch add regulator_set_load() before enable regulator at eDP phy driver. Signed-off-by: Kuogee Hsieh Reviewed-by: Douglas Anderson Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v14 2/3] phy: qcom-qmp: add regulator_set_load to dp phy

2022-06-20 Thread Dmitry Baryshkov
On 20/06/2022 23:12, Kuogee Hsieh wrote: This patch add regulator_set_load() before enable regulator at DP phy driver. Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd Reviewed-by: Douglas Anderson --- drivers/phy/qualcomm/phy-qcom-qmp.c | 40 - Thi

  1   2   >