[PATCH] drm/nouveau: Fix spelling typo in comments

2022-06-16 Thread 1064094935
From: pengfuyuan Fix spelling typo in comments. Reported-by: k2ci Signed-off-by: pengfuyuan --- drivers/gpu/drm/nouveau/include/nvhw/drf.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/include/nvhw/drf.h b/drivers/gpu/drm/nouveau/include/nvhw

Re: [PATCH 1/6] drm/i915/gt: Ignore TLB invalidations on idle engines

2022-06-16 Thread Tvrtko Ursulin
On 15/06/2022 16:27, Mauro Carvalho Chehab wrote: From: Chris Wilson As an extension of the current skip TLB invalidations, check if the device is powered down prior to any engine activity, as, on such cases, all the TLBs were already invalidated, so an explicit TLB invalidation is not neede

[PATCH] drm/connector: Remove usage of the deprecated ida_simple_xxx API

2022-06-16 Thread Bo Liu
Use ida_alloc_xxx()/ida_free() instead of ida_simple_get()/ida_simple_remove(). The latter is deprecated and more verbose. Signed-off-by: Bo Liu --- drivers/gpu/drm/drm_connector.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_connector.c b/

[PATCH] drm/exynos: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2022-06-16 Thread hongao
Once EDID is parsed, the monitor HDMI support information is available through drm_display_info.is_hdmi. This driver calls drm_detect_hdmi_monitor() to receive the same information, which is less efficient. Avoid calling drm_detect_hdmi_monitor() and use drm_display_info.is_hdmi instead. Signed-

[PULL] drm-misc-fixes

2022-06-16 Thread Maxime Ripard
Hi Dave, Daniel, Here's this week drm-misc-fixes PR Maxime drm-misc-fixes-2022-06-16: Two fixes for TTM, one for a NULL pointer dereference and one to make sure the buffer is pinned prior to a bulk move, and a fix for a spurious compiler warning. The following changes since commit 477277c7fd43d4

Re: [PATCH 3/6] drm/i915/gt: Skip TLB invalidations once wedged

2022-06-16 Thread Tvrtko Ursulin
On 15/06/2022 16:27, Mauro Carvalho Chehab wrote: From: Chris Wilson Skip all further TLB invalidations once the device is wedged and had been reset, as, on such cases, it can no longer process instructions on the GPU and the user no longer has access to the TLB's in each engine. Fixes: 7938

Re: [PATCH 4/6] drm/i915/gt: Only invalidate TLBs exposed to user manipulation

2022-06-16 Thread Tvrtko Ursulin
On 15/06/2022 16:27, Mauro Carvalho Chehab wrote: From: Chris Wilson Don't flush TLBs when the buffer is only used in the GGTT under full control of the kernel, as there's no risk of of concurrent access and stale access from prefetch. We only need to invalidate the TLB if they are accessibl

Re: [PATCH 5/6] drm/i915/gt: Serialize GRDOM access between multiple engine resets

2022-06-16 Thread Tvrtko Ursulin
On 15/06/2022 16:27, Mauro Carvalho Chehab wrote: From: Chris Wilson Don't allow two engines to be reset in parallel, as they would both try to select a reset bit (and send requests to common registers) and wait on that register, at the same time. Serialize control of the reset requests/acks

Re: [PATCH v4 4/7] dt-bindings: drm/bridge: anx7625: Add mode-switch support

2022-06-16 Thread Stephen Boyd
Quoting Prashant Malani (2022-06-15 10:20:20) > > .../display/bridge/analogix,anx7625.yaml | 64 +++ > 1 file changed, 64 insertions(+) Can this file get a link to the product brief[1]? It helps to quickly find the block diagram. > > diff --git > a/Documentation/devicetree/

Re: [PATCH v3 07/14] drm/msm/hdmi: enable core-vcc/core-vdda-supply for 8996 platform

2022-06-16 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-09 05:23:43) > DB820c makes use of core-vcc-supply and core-vdda-supply, however the > driver code doesn't support these regulators. Enable them for HDMI on > 8996 platform. > > Fixes: 0afbe59edd3f ("drm/msm/hdmi: Add basic HDMI support for msm8996") > Signed-off-b

Re: [PATCH v2 0/6] drm/sun4i: HDMI PHY cleanup/refactoring

2022-06-16 Thread Maxime Ripard
On Tue, 14 Jun 2022 23:55:37 -0500, Samuel Holland wrote: > This series prepares the sun8i HDMI PHY driver for supporting the new > custom PHY in the Allwinner D1 SoC. No functional change intended here. > > This series was tested on D1, H3, and H6. > > Changes in v2: > - Move error handling ins

[PULL] drm-intel-fixes

2022-06-16 Thread Jani Nikula
Hi Dave & Daniel - drm-intel-fixes-2022-06-16: drm/i915 fixes for v5.19-rc3: - Fix page fault on error state read - Fix memory leaks in per-gt sysfs - Fix multiple fence handling - Remove accidental static from a local variable BR, Jani. The following changes since commit b13baccc3850ca8b8cccb

Re: [PATCH] drm/sun4i: Fix crash during suspend after component bind failure

2022-06-16 Thread Maxime Ripard
Hi, On Wed, Jun 15, 2022 at 12:42:53AM -0500, Samuel Holland wrote: > If the component driver fails to bind, or is unbound, the driver data > for the top-level platform device points to a freed drm_device. If the > system is then suspended, the driver passes this dangling pointer to > drm_mode_con

Re: [PATCH] drm/sun4i: dw-hdmi: Fix ddc-en GPIO consumer conflict

2022-06-16 Thread Maxime Ripard
On Tue, 14 Jun 2022 02:31:00 -0500, Samuel Holland wrote: > commit 6de79dd3a920 ("drm/bridge: display-connector: add ddc-en gpio > support") added a consumer for this GPIO in the HDMI connector device. > This new consumer conflicts with the pre-existing GPIO consumer in the > sun8i HDMI controller

Re: [PATCH] drm/sun4i: Fix crash during suspend after component bind failure

2022-06-16 Thread Maxime Ripard
On Wed, 15 Jun 2022 00:42:53 -0500, Samuel Holland wrote: > If the component driver fails to bind, or is unbound, the driver data > for the top-level platform device points to a freed drm_device. If the > system is then suspended, the driver passes this dangling pointer to > drm_mode_config_helper_

[PATCH 0/3] drm/msm/hdmi: move resource allocation to probe function

2022-06-16 Thread Dmitry Baryshkov
As pointed several times in the discussions, start moving resource allocation from component bind to the probe function. This simplifies boot process, as the component will not be registered until all resources (clocks, regulators, IRQ, etc.) are not registered. Dmitry Baryshkov (3): drm/msm/hdm

[PATCH 2/3] drm/msm/hdmi: drop constant resource names from platform config

2022-06-16 Thread Dmitry Baryshkov
All MSM HDMI devices use "core_physical" and "qfprom_physical" names for register areas. Drop them from the platform config. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi.c | 9 +++-- drivers/gpu/drm/msm/hdmi/hdmi.h | 3 --- 2 files changed, 3 insertions(+), 9 deletions(-

[PATCH 1/3] drm/msm/hdmi: use devres helper for runtime PM management

2022-06-16 Thread Dmitry Baryshkov
Use devm_pm_runtime_enable() to enable runtime PM. This way its effect will be reverted on device unbind/destruction. Fixes: 6ed9ed484d04 ("drm/msm/hdmi: Set up runtime PM for HDMI") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH 3/3] drm/msm/hdmi: move resource allocation to probe function

2022-06-16 Thread Dmitry Baryshkov
Rather than having all resource allocation happen in the _bind function (resulting in possible EPROBE_DEFER returns and component bind/unbind cycles) allocate and check all resources in _probe function. While we are at it, use platform_get_irq() to get the IRQ rather than going through the irq_of_p

Re: [PATCH v2 4/5] drm/msm: move KMS aspace init to the separate helper

2022-06-16 Thread Dmitry Baryshkov
On 16/06/2022 05:34, Stephen Boyd wrote: Quoting Dmitry Baryshkov (2022-05-04 17:16:04) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index a37a3bbc04d9..98ae0036ab57 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm/msm_drv.c @@ -262,6 +263,46 @@

[PATCH v3 0/5] drm/msm: fixes for KMS iommu handling

2022-06-16 Thread Dmitry Baryshkov
This series started from the applied and then reverted [2] patch by Robin Murphy [1]. After the MDSS rework [3] has landed it is now possible to reapply the extended version of the original patch. While we are at it, also rework the IOMMU init code for DPU and MDP5 drivers. For MDP5 this moves iom

[PATCH v3 2/5] drm/msm/mdp5: move iommu_domain_alloc() call close to its usage

2022-06-16 Thread Dmitry Baryshkov
Move iommu_domain_alloc() in front of adress space/IOMMU initialization. This allows us to drop final bits of struct mdp5_cfg_platform which remained from the pre-DT days. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 16 --

[PATCH v3 4/5] drm/msm: move KMS aspace init to the separate helper

2022-06-16 Thread Dmitry Baryshkov
MDP5 and DPU drivers have the same piece of code now to initialize IOMMU and GEM address space. Move it to the msm_drv.c Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 32 ++- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 33 driv

[PATCH v3 1/5] drm/msm/dpu: check both DPU and MDSS devices for the IOMMU

2022-06-16 Thread Dmitry Baryshkov
Follow the lead of MDP5 driver and check both DPU and MDSS devices for the IOMMU specifiers. Historically DPU devices had IOMMU specified in the MDSS device tree node, but as some of MDP5 devices are being converted to the supported by the DPU driver, the driver should adapt and check both devices

[PATCH v3 5/5] drm/msm: switch msm_kms_init_aspace() to use device_iommu_mapped()

2022-06-16 Thread Dmitry Baryshkov
Change msm_kms_init_aspace() to use generic function device_iommu_mapped() instead of the fwnode-specific interface dev_iommu_fwspec_get(). While we are at it, stop referencing platform_bus_type directly and use the bus of the IOMMU device. Suggested-by: Robin Murphy Reviewed-by: Robin Murphy Si

[PATCH v3 3/5] drm/msm: Stop using iommu_present()

2022-06-16 Thread Dmitry Baryshkov
Even if some IOMMU has registered itself on the platform "bus", that doesn't necessarily mean it provides translation for the device we care about. Replace iommu_present() with a more appropriate check. On Qualcomm platforms the IOMMU can be specified either for the MDP/DPU device or for its paren

Re: [PATCH] drm/msm: Fix fence rollover issue

2022-06-16 Thread Dmitry Baryshkov
On 15/06/2022 19:24, Rob Clark wrote: From: Rob Clark And while we are at it, let's start the fence counter close to the rollover point so that if issues slip in, they are more obvious. Signed-off-by: Rob Clark Should it also have Fixes: fde5de6cb461 ("drm/msm: move fence code to it's own

Re: [PATCH] drm/msm/gem: Drop obj lock in msm_gem_free_object()

2022-06-16 Thread Stephen Boyd
Quoting Rob Clark (2022-06-13 13:50:32) > diff --git a/drivers/gpu/drm/msm/msm_gem.h b/drivers/gpu/drm/msm/msm_gem.h > index d608339c1643..432032ad4aed 100644 > --- a/drivers/gpu/drm/msm/msm_gem.h > +++ b/drivers/gpu/drm/msm/msm_gem.h > @@ -229,7 +229,19 @@ msm_gem_unlock(struct drm_gem_object *obj

Re: [PATCH] drm/msm/dpu: set preferred mode for writeback connector

2022-06-16 Thread Dmitry Baryshkov
On 16/06/2022 02:23, Abhinav Kumar wrote: After [1] was merged to IGT, we use either the first supported mode in the list OR the preferred mode to determine the primary plane to use for the sub-test due to the IGT API [2]. Since writeback does not set any preferred mode, this was selecting 4k as

Re: [PATCH v2 1/3] drm/msm/dpu: move intf and wb assignment to dpu_encoder_setup_display()

2022-06-16 Thread Dmitry Baryshkov
On 16/06/2022 00:22, Abhinav Kumar wrote: intf and wb resources are not dependent on the rm global state so need not be allocated during dpu_encoder_virt_atomic_mode_set(). Move the allocation of intf and wb resources to dpu_encoder_setup_display() so that we can utilize the hw caps even during

Re: [PATCH 25/64] drm/vc4: dpi: Add action to disable the clock

2022-06-16 Thread Maxime Ripard
Hi Dave, On Tue, Jun 14, 2022 at 05:47:28PM +0100, Dave Stevenson wrote: > Hi Maxime. > > On Fri, 10 Jun 2022 at 10:30, Maxime Ripard wrote: > > > > Adding a device-managed action will make the error path easier, so let's > > create one to disable our clock. > > The DPI block has two clocks (co

Re: [Linaro-mm-sig] Re: [PATCH] drivers: tty: serial: Add missing of_node_put() in serial-tegra.c

2022-06-16 Thread Greg KH
On Thu, Jun 16, 2022 at 06:23:26AM +1000, Dave Airlie wrote: > On Wed, 15 Jun 2022 at 20:53, Greg KH wrote: > > > > On Wed, Jun 15, 2022 at 06:48:33PM +0800, heliang wrote: > > > In tegra_uart_init(), of_find_matching_node() will return a node > > > pointer with refcount incremented. We should use

Re: [Linaro-mm-sig] Re: [PATCH] drivers: tty: serial: Add missing of_node_put() in serial-tegra.c

2022-06-16 Thread Greg KH
On Wed, Jun 15, 2022 at 10:30:47PM +0200, Daniel Vetter wrote: > On Wed, 15 Jun 2022 at 22:23, Dave Airlie wrote: > > > > On Wed, 15 Jun 2022 at 20:53, Greg KH wrote: > > > > > > On Wed, Jun 15, 2022 at 06:48:33PM +0800, heliang wrote: > > > > In tegra_uart_init(), of_find_matching_node() will re

Re: [PATCH v2 13/14] drm/vc4: crtc: Fix out of order frames during asynchronous page flips

2022-06-16 Thread Melissa Wen
On 06/10, Maxime Ripard wrote: > When doing an asynchronous page flip (PAGE_FLIP ioctl with the > DRM_MODE_PAGE_FLIP_ASYNC flag set), the current code waits for the > possible GPU buffer being rendered through a call to > vc4_queue_seqno_cb(). > > On the BCM2835-37, the GPU driver is part of the v

[PATCH] drm/msm/hdmi: drop empty bridge callbacks

2022-06-16 Thread Dmitry Baryshkov
Drop empty callbacks msm_hdmi_bridge_enable() and msm_hdmi_bridge_disable(). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c b/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c

[PATCH] drm/msm/hdmi: support attaching the "next" bridge

2022-06-16 Thread Dmitry Baryshkov
There might be a chain of bridges attached to the HDMI node (including but not limited to the display-connector bridge). Add support for attaching them right to the HDMI bridge chain. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi.c | 14 ++ drivers/gpu/drm/msm/hdm

Re:Re: [Linaro-mm-sig] Re: [PATCH] drivers: tty: serial: Add missing of_node_put() in serial-tegra.c

2022-06-16 Thread Liang He
At 2022-06-16 16:43:43, "Greg KH" wrote: >On Wed, Jun 15, 2022 at 10:30:47PM +0200, Daniel Vetter wrote: >> On Wed, 15 Jun 2022 at 22:23, Dave Airlie wrote: >> > >> > On Wed, 15 Jun 2022 at 20:53, Greg KH wrote: >> > > >> > > On Wed, Jun 15, 2022 at 06:48:33PM +0800, heliang wrote: >> > > > In

Re: [Intel-gfx] [PATCH 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-16 Thread Tvrtko Ursulin
On 15/06/2022 16:20, Niranjana Vishwanathapura wrote: On Wed, Jun 15, 2022 at 08:22:23AM +0100, Tvrtko Ursulin wrote: On 14/06/2022 17:42, Niranjana Vishwanathapura wrote: On Tue, Jun 14, 2022 at 05:07:37PM +0100, Tvrtko Ursulin wrote: On 14/06/2022 17:02, Tvrtko Ursulin wrote: On 14/06/

Re: [PATCH v4 4/7] dt-bindings: drm/bridge: anx7625: Add mode-switch support

2022-06-16 Thread Prashant Malani
On Thu, Jun 16, 2022 at 12:42 AM Stephen Boyd wrote: > > Quoting Prashant Malani (2022-06-15 10:20:20) > > > > .../display/bridge/analogix,anx7625.yaml | 64 +++ > > 1 file changed, 64 insertions(+) > > Can this file get a link to the product brief[1]? It helps to quickly > f

Re: [PATCH v4 0/7] usb: typec: Introduce typec-switch binding

2022-06-16 Thread AngeloGioacchino Del Regno
Il 15/06/22 19:20, Prashant Malani ha scritto: This series introduces a binding for Type-C data lane switches. These control the routing and operating modes of USB Type-C data lanes based on the PD messaging from the Type-C port driver regarding connected peripherals. The first patch introduces

[RFC PATCH 0/2] drm/msm/mdp4: rework LVDS/LCDC panel support

2022-06-16 Thread Dmitry Baryshkov
MDP4 uses custom code to handle LVDS panel. It predates handling EPROBE_DEFER, it tries to work when the panel device is not available, etc. Switch MDP4 LCDC code to use drm_panel_bridge/drm_bridge_connector to follow contemporary DRM practices. Note, this code has been compile-tested only. Testin

[RFC PATCH 1/2] drm/msm/mdp4: move move_valid callback to lcdc_encoder

2022-06-16 Thread Dmitry Baryshkov
We can check the LCDC clock directly from the LCDC encoder driver, so remove it from the LVDS connector. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.h | 1 - .../gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c | 26 ++- .../drm/msm/disp/mdp4/mdp4_lv

[RFC PATCH 2/2] drm/msm/mdp4: switch LVDS to use drm_bridge/_connector

2022-06-16 Thread Dmitry Baryshkov
LVDS support in MDP4 driver makes use of drm_connector directly. However LCDC encoder and LVDS connector are wrappers around drm_panel. Switch them to use drm_panel_bridge/drm_bridge_connector. This allows using standard interface for the drm_panel and also inserting additional bridges between enco

[PATCH] usb: gadget: Remove unnecessary print function dev_err()

2022-06-16 Thread Jiapeng Chong
The print function dev_err() is redundant because platform_get_irq() already prints an error. This was found by coccicheck: ./drivers/usb/gadget/udc/aspeed_udc.c:1546:2-9: line 1546 is redundant because platform_get_irq() already prints an error. Signed-off-by: Jiapeng Chong --- drivers/usb/g

Re: [PATCH v2 00/14] drm/vc4: Properly separate v3d on BCM2711, and fix frame ordering

2022-06-16 Thread Maxime Ripard
On Fri, 10 Jun 2022 13:51:35 +0200, Maxime Ripard wrote: > Here's a series that fixes a significant issue we missed when adding support > for the BCM2711 / RaspberryPi4 in the vc4 driver. > > Indeed, before the introduction of the BCM2711 support, the GPU was fairly > intertwined with the display

Re: [PATCH 02/64] drm/crtc: Introduce drmm_crtc_init_with_planes

2022-06-16 Thread Maxime Ripard
On Wed, Jun 15, 2022 at 12:34:46PM +0200, Thomas Zimmermann wrote: > Hi > > Am 15.06.22 um 10:32 schrieb Maxime Ripard: > [...] > > > See, helpers should be useful to many drivers. If we add them, we also > > > add a > > > resources and maintenance overhead to our libraries. And right now, these

Re:Re: [Linaro-mm-sig] Re: [PATCH] drivers: tty: serial: Add missing of_node_put() in serial-tegra.c

2022-06-16 Thread Liang He
At 2022-06-16 17:20:24, conor.doo...@microchip.com wrote: >On 16/06/2022 09:52, Liang He wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the >> content is safe >> >> At 2022-06-16 16:43:43, "Greg KH" wrote: >>> On Wed, Jun 15, 2022 at 10:30:47PM +0200, Daniel V

Re: [PATCH 17/64] drm/vc4: crtc: Move debugfs_name to crtc_data

2022-06-16 Thread Maxime Ripard
Hi Dave, On Tue, Jun 14, 2022 at 04:57:45PM +0100, Dave Stevenson wrote: > On Fri, 10 Jun 2022 at 10:30, Maxime Ripard wrote: > > > > All the CRTCs, including the TXP, have a debugfs file and name so we can > > consolidate it into vc4_crtc_data. > > > > Signed-off-by: Maxime Ripard > > Reviewed

Re: [PATCH v2] drm/arm/hdlcd: Take over EFI framebuffer properly

2022-06-16 Thread Liviu Dudau
On Wed, Jun 15, 2022 at 05:09:15PM +0100, Robin Murphy wrote: > The Arm Juno board EDK2 port has provided an EFI GOP display via HDLCD0 > for some time now, which works nicely as an early framebuffer. However, > once the HDLCD driver probes and takes over the hardware, it should > take over the log

Re: [PATCH 17/64] drm/vc4: crtc: Move debugfs_name to crtc_data

2022-06-16 Thread Dave Stevenson
On Thu, 16 Jun 2022 at 10:41, Maxime Ripard wrote: > > Hi Dave, > > On Tue, Jun 14, 2022 at 04:57:45PM +0100, Dave Stevenson wrote: > > On Fri, 10 Jun 2022 at 10:30, Maxime Ripard wrote: > > > > > > All the CRTCs, including the TXP, have a debugfs file and name so we can > > > consolidate it into

Re: [PATCH 25/64] drm/vc4: dpi: Add action to disable the clock

2022-06-16 Thread Dave Stevenson
On Thu, 16 Jun 2022 at 09:38, Maxime Ripard wrote: > > Hi Dave, > > On Tue, Jun 14, 2022 at 05:47:28PM +0100, Dave Stevenson wrote: > > Hi Maxime. > > > > On Fri, 10 Jun 2022 at 10:30, Maxime Ripard wrote: > > > > > > Adding a device-managed action will make the error path easier, so let's > > >

RE: [PATCH] usb: gadget: Remove unnecessary print function dev_err()

2022-06-16 Thread Neal Liu
> The print function dev_err() is redundant because platform_get_irq() already > prints an error. > > This was found by coccicheck: > > ./drivers/usb/gadget/udc/aspeed_udc.c:1546:2-9: line 1546 is redundant > because platform_get_irq() already prints an error. > > Signed-off-by: Jiapeng Chong

Re: [PATCH v2] drm/arm/hdlcd: Take over EFI framebuffer properly

2022-06-16 Thread Javier Martinez Canillas
Hello Robin, On 6/15/22 18:09, Robin Murphy wrote: > The Arm Juno board EDK2 port has provided an EFI GOP display via HDLCD0 > for some time now, which works nicely as an early framebuffer. However, > once the HDLCD driver probes and takes over the hardware, it should > take over the logical frame

Re: [PATCH] drm/arm/hdlcd: Simplify IRQ install/uninstall

2022-06-16 Thread Liviu Dudau
On Wed, Jun 15, 2022 at 05:11:09PM +0100, Robin Murphy wrote: > Since we no longer need to conform to the structure of the various DRM > IRQ callbacks, we can streamline the code by consolidating the piecemeal > functions and passing around our private data structure directly. We're > also a platfo

Re: [Intel-gfx] [PATCH 01/10] drm/doc: add rfc section for small BAR uapi

2022-06-16 Thread Intel
On 5/25/22 20:43, Matthew Auld wrote: Add an entry for the new uapi needed for small BAR on DG2+. v2: - Some spelling fixes and other small tweaks. (Akeem & Thomas) - Rework error capture interactions, including no longer needing NEEDS_CPU_ACCESS for objects marked for capture. (Tho

Re: [PATCH v9 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs

2022-06-16 Thread Sakari Ailus
On Sat, Jun 11, 2022 at 10:14:07PM +0800, Liu Ying wrote: > Patch 1/14 and 2/14 add bus formats used by pixel combiner. Thanks! For these: Acked-by: Sakari Ailus -- Sakari Ailus

[PATCH v2 0/9] DG2 VRAM_SR Support

2022-06-16 Thread Anshuman Gupta
This series add DG2 D3Cold VRAM_SR support. TODO: GuC Interface state save/restore on VRAM_SR entry/exit. Anshuman Gupta (8): drm/i915/dgfx: OpRegion VRAM Self Refresh Support drm/i915/dg1: OpRegion PCON DG1 MBD config support drm/i915/dg2: Add DG2_NB_MBD subplatform drm/i915/dg2: DG2 MBD

[PATCH v2 1/9] drm/i915/dgfx: OpRegion VRAM Self Refresh Support

2022-06-16 Thread Anshuman Gupta
Intel DGFX cards provides a feature Video Ram Self Refrsh(VRSR). DGFX VRSR can be enabled with runtime suspend D3Cold flow and with opportunistic S0ix system wide suspend flow as well. Without VRSR enablement i915 has to evict the lmem objects to system memory. Depending on some heuristics driver

[PATCH v2 2/9] drm/i915/dg1: OpRegion PCON DG1 MBD config support

2022-06-16 Thread Anshuman Gupta
DGFX cards support both Add in Card(AIC) and Mother Board Down(MBD) configs. MBD config requires HOST BIOS GPIO toggling support in order to enable/disable VRAM SR using ACPI OpRegion. i915 requires to check OpRegion PCON MBD Config bits to discover whether Gfx Card is MBD config before enabling V

[PATCH v2 3/9] drm/i915/dg2: Add DG2_NB_MBD subplatform

2022-06-16 Thread Anshuman Gupta
DG2 NB SKU need to distinguish between MBD and AIC to probe the VRAM Self Refresh feature support. Adding those sub platform accordingly. Cc: Matt Roper Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/i915_drv.h | 3 +++ drivers/gpu/drm/i915/intel_device_info.c | 21 +++

[PATCH v2 5/9] drm/i915/dgfx: Add has_lmem_sr

2022-06-16 Thread Anshuman Gupta
Add has_lmem_sr platform specific flag to know, whether platform has VRAM self refresh support. As of now both DG1 and DG2 client platforms supports VRAM self refresh with D3Cold but let it enable first on DG2 as primary lead platform for D3Cold support. Let it get enable on DG1 once this feature i

[PATCH v2 4/9] drm/i915/dg2: DG2 MBD config

2022-06-16 Thread Anshuman Gupta
Add DG2 Motherboard Down Config check support. v2: - Don't use pciid to check DG2 MBD. [Jani] BSpec: 44477 Cc: Rodrigo Vivi Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_opregion.c | 2 ++ drivers/gpu/drm/i915/i915_drv.h | 9 + 2 files changed, 11 i

[PATCH v2 6/9] drm/i915/dgfx: Setup VRAM SR with D3COLD

2022-06-16 Thread Anshuman Gupta
Setup VRAM Self Refresh with D3COLD state. VRAM Self Refresh will retain the context of VRAM, driver need to save any corresponding hardware state that needs to be restore on D3COLD exit, example PCI state. Cc: Jani Nikula Cc: Rodrigo Vivi Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915

[PATCH v2 7/9] drm/i915/rpm: Enable D3Cold VRAM SR Support

2022-06-16 Thread Anshuman Gupta
Intel Client DGFX card supports D3Cold with two option. D3Cold-off zero watt, D3Cold-VRAM Self Refresh. i915 requires to evict the lmem objects to smem in order to support D3Cold-Off, which increases i915 the suspend/resume latency. Enabling VRAM Self Refresh feature optimize the latency with addi

[PATCH v2 9/9] drm/i915/rpm: d3cold Policy

2022-06-16 Thread Anshuman Gupta
Add d3cold_sr_lmem_threshold modparam to choose between d3cold-off zero watt and d3cold-VRAM Self Refresh. i915 requires to evict the lmem objects to smem in order to support d3cold-Off. If gfx root port is not capable of sending PME from d3cold then i915 don't need to program d3cold-off/d3cold-vr

[PATCH v2 8/9] drm/i915/xehpsdv: Store lmem region in gt

2022-06-16 Thread Anshuman Gupta
From: Tvrtko Ursulin Store a pointer to respective local memory region in intel_gt so it can be used when memory local to a GT needs to be allocated. Cc: Andi Shyti Signed-off-by: Tvrtko Ursulin Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/gt/intel_gt.c | 1 + drivers/gpu/drm

Re: [Intel-gfx] [PATCH v2 3/9] drm/i915/dg2: Add DG2_NB_MBD subplatform

2022-06-16 Thread Tvrtko Ursulin
On 16/06/2022 13:01, Anshuman Gupta wrote: DG2 NB SKU need to distinguish between MBD and AIC to probe the VRAM Self Refresh feature support. Adding those sub platform accordingly. Cc: Matt Roper Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/i915_drv.h | 3 +++ drivers/

Re: [PATCH v2 6/9] drm/i915/dgfx: Setup VRAM SR with D3COLD

2022-06-16 Thread Jani Nikula
On Thu, 16 Jun 2022, Anshuman Gupta wrote: > Setup VRAM Self Refresh with D3COLD state. > VRAM Self Refresh will retain the context of VRAM, driver > need to save any corresponding hardware state that needs > to be restore on D3COLD exit, example PCI state. > > Cc: Jani Nikula > Cc: Rodrigo Vivi

Re: [PATCH v2 1/9] drm/i915/dgfx: OpRegion VRAM Self Refresh Support

2022-06-16 Thread Jani Nikula
On Thu, 16 Jun 2022, Anshuman Gupta wrote: > Intel DGFX cards provides a feature Video Ram Self Refrsh(VRSR). > DGFX VRSR can be enabled with runtime suspend D3Cold flow and with > opportunistic S0ix system wide suspend flow as well. > > Without VRSR enablement i915 has to evict the lmem objects t

Re: [PATCH v2 2/9] drm/i915/dg1: OpRegion PCON DG1 MBD config support

2022-06-16 Thread Jani Nikula
On Thu, 16 Jun 2022, Anshuman Gupta wrote: > DGFX cards support both Add in Card(AIC) and Mother Board Down(MBD) > configs. MBD config requires HOST BIOS GPIO toggling support > in order to enable/disable VRAM SR using ACPI OpRegion. > > i915 requires to check OpRegion PCON MBD Config bits to > di

Re: [PATCH v2] dt-bindings: display: Add Arm virtual platforms display

2022-06-16 Thread Linus Walleij
On Mon, Jun 13, 2022 at 4:57 PM Rob Herring wrote: > 'arm,rtsm-display' is a panel for Arm, Ltd. virtual platforms (e.g. FVP). > The binding has been in use for a long time, but was never documented. > > Some users and an example have a 'panel-dpi' compatible, but that's not > needed without a 'p

Re: [PATCH] drm/msm/gem: Drop obj lock in msm_gem_free_object()

2022-06-16 Thread Rob Clark
On Thu, Jun 16, 2022 at 1:28 AM Stephen Boyd wrote: > > Quoting Rob Clark (2022-06-13 13:50:32) > > diff --git a/drivers/gpu/drm/msm/msm_gem.h b/drivers/gpu/drm/msm/msm_gem.h > > index d608339c1643..432032ad4aed 100644 > > --- a/drivers/gpu/drm/msm/msm_gem.h > > +++ b/drivers/gpu/drm/msm/msm_gem.h

Re: [PATCH] drm/msm: Fix fence rollover issue

2022-06-16 Thread Rob Clark
On Thu, Jun 16, 2022 at 1:27 AM Dmitry Baryshkov wrote: > > On 15/06/2022 19:24, Rob Clark wrote: > > From: Rob Clark > > > > And while we are at it, let's start the fence counter close to the > > rollover point so that if issues slip in, they are more obvious. > > > > Signed-off-by: Rob Clark >

Re: [Intel-gfx] [PATCH v2 3/9] drm/i915/dg2: Add DG2_NB_MBD subplatform

2022-06-16 Thread Jani Nikula
On Thu, 16 Jun 2022, Tvrtko Ursulin wrote: > On 16/06/2022 13:01, Anshuman Gupta wrote: >> DG2 NB SKU need to distinguish between MBD and AIC to probe >> the VRAM Self Refresh feature support. Adding those sub platform >> accordingly. >> >> Cc: Matt Roper >> Signed-off-by: Anshuman Gupta >> ---

[PATCH V2 0/2] Add Xilinx DSI-Tx subsystem DRM driver

2022-06-16 Thread Venkateshwar Rao Gannavarapu
MIPI DSI TX subsystem allows you to quickly create systems based on the MIPI protocol. It interfaces between the video processing subsystems and MIPI-based displays. An internal high-speed physical layer design, D-PHY, is provided to allow direct connection to display peripherals. The subsystem co

[PATCH V2 1/2] dt-bindings: display: xlnx: Add DSI 2.0 Tx subsystem documentation

2022-06-16 Thread Venkateshwar Rao Gannavarapu
This patch adds dt binding for Xilinx DSI-TX subsystem. The Xilinx MIPI DSI (Display serial interface) Transmitter Subsystem implements the Mobile Industry Processor Interface (MIPI) based display interface. It supports the interface with the programmable logic (FPGA). Signed-off-by: Venkateshwar

[PATCH V2 2/2] drm: xlnx: dsi: Add Xilinx MIPI DSI-Tx subsystem driver

2022-06-16 Thread Venkateshwar Rao Gannavarapu
The Xilinx MIPI DSI Tx Subsystem soft IP is used to display video data from AXI-4 stream interface. It supports upto 4 lanes, optional register interface for the DPHY and multiple RGB color formats. This is a MIPI-DSI host driver and provides DSI bus for panels. This driver also helps to communica

Re: [Intel-gfx] [PATCH v2 9/9] drm/i915/rpm: d3cold Policy

2022-06-16 Thread Jani Nikula
On Thu, 16 Jun 2022, Anshuman Gupta wrote: > Add d3cold_sr_lmem_threshold modparam to choose between > d3cold-off zero watt and d3cold-VRAM Self Refresh. > i915 requires to evict the lmem objects to smem in order to > support d3cold-Off. > > If gfx root port is not capable of sending PME from d3co

Re: [Intel-gfx] [PATCH v2 8/9] drm/i915/xehpsdv: Store lmem region in gt

2022-06-16 Thread Jani Nikula
On Thu, 16 Jun 2022, Anshuman Gupta wrote: > From: Tvrtko Ursulin > > Store a pointer to respective local memory region in intel_gt so it can be > used when memory local to a GT needs to be allocated. > > Cc: Andi Shyti > Signed-off-by: Tvrtko Ursulin > Signed-off-by: Anshuman Gupta > --- > d

Re: [Intel-gfx] [PATCH v2 7/9] drm/i915/rpm: Enable D3Cold VRAM SR Support

2022-06-16 Thread Jani Nikula
On Thu, 16 Jun 2022, Anshuman Gupta wrote: > Intel Client DGFX card supports D3Cold with two option. > D3Cold-off zero watt, D3Cold-VRAM Self Refresh. > > i915 requires to evict the lmem objects to smem in order to > support D3Cold-Off, which increases i915 the suspend/resume > latency. Enabling V

Re: [Intel-gfx] [PATCH v2 3/9] drm/i915/dg2: Add DG2_NB_MBD subplatform

2022-06-16 Thread Tvrtko Ursulin
On 16/06/2022 15:15, Jani Nikula wrote: On Thu, 16 Jun 2022, Tvrtko Ursulin wrote: On 16/06/2022 13:01, Anshuman Gupta wrote: DG2 NB SKU need to distinguish between MBD and AIC to probe the VRAM Self Refresh feature support. Adding those sub platform accordingly. Cc: Matt Roper Signed-off-

Re: [Intel-gfx] [PATCH v2 3/9] drm/i915/dg2: Add DG2_NB_MBD subplatform

2022-06-16 Thread Jani Nikula
On Thu, 16 Jun 2022, Tvrtko Ursulin wrote: > On 16/06/2022 15:15, Jani Nikula wrote: >> On Thu, 16 Jun 2022, Tvrtko Ursulin wrote: >>> On 16/06/2022 13:01, Anshuman Gupta wrote: DG2 NB SKU need to distinguish between MBD and AIC to probe the VRAM Self Refresh feature support. Adding tho

Re: [PATCH 2/2] dt-bindings: phy: List supplies for qcom,edp-phy

2022-06-16 Thread Doug Anderson
Hi, On Mon, Apr 25, 2022 at 2:07 PM Douglas Anderson wrote: > > We're supposed to list the supplies in the dt bindings but there are > none in the eDP PHY bindings. > > Looking at the driver in Linux, I can see that there seem to be two > relevant supplies: "vdda-phy" and "vdda-pll". Let's add th

Re: [PATCH V2 2/2] drm: xlnx: dsi: Add Xilinx MIPI DSI-Tx subsystem driver

2022-06-16 Thread Randy Dunlap
On 6/16/22 07:17, Venkateshwar Rao Gannavarapu wrote: > diff --git a/drivers/gpu/drm/xlnx/Kconfig b/drivers/gpu/drm/xlnx/Kconfig > index f9cf93c..a75bd76 100644 > --- a/drivers/gpu/drm/xlnx/Kconfig > +++ b/drivers/gpu/drm/xlnx/Kconfig > @@ -1,3 +1,15 @@ > +config DRM_XLNX_DSI > + tristate "X

Re: [Freedreno] [PATCH] drm/msm/dpu: set preferred mode for writeback connector

2022-06-16 Thread Abhinav Kumar
On 6/16/2022 1:36 AM, Dmitry Baryshkov wrote: On 16/06/2022 02:23, Abhinav Kumar wrote: After [1] was merged to IGT, we use either the first supported mode in the list OR the preferred mode to determine the primary plane to use for the sub-test due to the IGT API [2]. Since writeback does no

Re: [PATCH 04/11] drm/r128: Fix undefined behavior due to shift overflowing the constant

2022-06-16 Thread Randy Dunlap
On 5/19/22 06:05, Daniel Vetter wrote: > On Mon, Apr 25, 2022 at 11:46:53AM -0700, Randy Dunlap wrote: >> >> >> On 4/5/22 08:15, Borislav Petkov wrote: >>> From: Borislav Petkov >>> >>> Fix: >>> >>> drivers/gpu/drm/r128/r128_cce.c: In function ‘r128_do_init_cce’: >>> drivers/gpu/drm/r128/r1

Re: [PATCH 00/10] drm: selftest: Convert to KUnit

2022-06-16 Thread Javier Martinez Canillas
On 6/16/22 16:55, David Gow wrote: > On Wed, Jun 15, 2022 at 9:59 PM Maíra Canal wrote: >> >> KUnit unifies the test structure and provides helper tools that simplify >> the development of tests. The basic use case allows running tests as regular >> processes, which makes it easier to run unit tes

[PATCH v2] drm: shmobile: Use backlight helper

2022-06-16 Thread Stephen Kitt
This started with work on the removal of backlight_properties' deprecated fb_blank field, much of which can be taken care of by using helper functions provided by backlight.h instead of directly accessing fields in backlight_properties. This patch series doesn't involve fb_blank, but it still seems

[PATCH v8 0/2] force link training for display resolution change

2022-06-16 Thread Kuogee Hsieh
1) force link training for display resolution change 2) remove pixel_rate from struct dp_ctrl Kuogee Hsieh (2): drm/msm/dp: force link training for display resolution change drm/msm/dp: clean up pixel_rate from dp_ctrl.c drivers/gpu/drm/msm/dp/dp_ctrl.c| 147 -

[PATCH v8 1/2] drm/msm/dp: force link training for display resolution change

2022-06-16 Thread Kuogee Hsieh
Display resolution change is implemented through drm modeset. Older modeset (resolution) has to be disabled first before newer modeset (resolution) can be enabled. Display disable will turn off both pixel clock and main link clock so that main link have to be re-trained during display enable to hav

[PATCH v8 2/2] drm/msm/dp: clean up pixel_rate from dp_ctrl.c

2022-06-16 Thread Kuogee Hsieh
dp_ctrl keep an local cache of pixel_rate which increase confusing in regrading how pixel_rate being used. This patch refer pixel_rate directly from dp_panel to eliminate unnecessary pixel_rate variable from struct dp_ctrl. Changes in v8: -- add this patch to remove pixel_rate from dp_ctrl Signed

Re: [PATCH 1/2] dt-bindings: display: simple: add Ampire AM-800600P5TMQW-TB8H panel

2022-06-16 Thread Rob Herring
On Fri, 10 Jun 2022 13:15:10 +0200, Bastian Krause wrote: > Add Ampire AM-800600P5TMQW-TB8H 8" TFT LCD panel compatible string. > > Signed-off-by: Bastian Krause > --- > .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Acked-by: Rob He

[PATCH v2 0/3] drm/panel: Use backlight helpers

2022-06-16 Thread Stephen Kitt
backlight_properties.fb_blank is deprecated. The states it represents are handled by other properties; but instead of accessing those properties directly, drivers should use the helpers provided by backlight.h. This will ultimately allow fb_blank to be removed. Changes since v1: - remove the last

[PATCH v2 2/3] drm/panel: panel-dsi-cm: Use backlight helpers

2022-06-16 Thread Stephen Kitt
Instead of retrieving the backlight brightness in struct backlight_properties manually, and then checking whether the backlight should be on at all, use backlight_get_brightness() which does all this and insulates this from future changes. Instead of setting the power state by manually updating fi

[PATCH v2 3/3] drm/panel: sony-acx565akm: Use backlight helpers

2022-06-16 Thread Stephen Kitt
Instead of retrieving the backlight brightness in struct backlight_properties manually, and then checking whether the backlight should be on at all, use backlight_get_brightness() which does all this and insulates this from future changes. Instead of manually checking the power state in struct bac

[PATCH v2 1/3] drm/panel: Use backlight helper

2022-06-16 Thread Stephen Kitt
backlight_properties.fb_blank is deprecated. The states it represents are handled by other properties; but instead of accessing those properties directly, drivers should use the helpers provided by backlight.h. Instead of retrieving the backlight brightness in struct backlight_properties manually,

Re: [PATCH v3 0/3] KUnit tests for drm_format_helper

2022-06-16 Thread José Expósito
Hi! Javier Martinez Canillas wrote: > Before merging this, could you please reach the folks working on [0] ? > I think that would be good to have some consistency with regard to KUnit > tests from the start to avoid future refactorings. For instance, you are > adding the tests under a `kunit` sub-

[Bug 216119] 087451f372bf76d breaks hibernation on amdgpu Radeon R9 390

2022-06-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216119 Harald Judt (h.j...@gmx.at) changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution

[PATCH] drm/fourcc: Add formats for packed YUV 4:4:4 AVUY and XVUY permutations

2022-06-16 Thread Laurent Pinchart
Add FourCCs for two missing permutations of the packed YUV 4:4:4 color components, namely AVUY and XVUY. These formats are needed by the NXP i.MX8 ISI. While the ISI is supported by a V4L2 device (corresponding formats have been submitted to V4L2), it is handled in userspace by libcamera, which us

Re: ✗ Fi.CI.IGT: failure for drm/dp/mst: Read the extended DPCD capabilities during system resume

2022-06-16 Thread Imre Deak
On Wed, Jun 15, 2022 at 04:25:34AM +, Patchwork wrote: > == Series Details == > > Series: drm/dp/mst: Read the extended DPCD capabilities during system resume > URL : https://patchwork.freedesktop.org/series/105102/ > State : failure Thanks for the reviews, pushed the patch to drm-misc-next

  1   2   >