On 13/06/2022 21:02, Niranjana Vishwanathapura wrote:
On Mon, Jun 13, 2022 at 06:33:07AM -0700, Zeng, Oak wrote:
Regards,
Oak
-Original Message-
From: Intel-gfx On Behalf
Of Niranjana
Vishwanathapura
Sent: June 10, 2022 1:43 PM
To: Landwerlin, Lionel G
Cc: Intel GFX ; Maling list
Hi Jose,
for the whole patchset:
Acked-by: Thomas Zimmermann
One small detail on licensing: drm_format_helper.c is licensed under
GPL2 or MIT. Maybe consider adding 'or MIT' to drm_format_helper_test.c
as well.
Best regards
Thomas
Am 13.06.22 um 19:17 schrieb José Expósito:
Hello everyon
On 14/06/2022 00:39, Matthew Brost wrote:
On Mon, Jun 13, 2022 at 07:09:06PM +0100, Tvrtko Ursulin wrote:
On 13/06/2022 18:49, Niranjana Vishwanathapura wrote:
On Mon, Jun 13, 2022 at 05:22:02PM +0100, Tvrtko Ursulin wrote:
On 13/06/2022 16:05, Niranjana Vishwanathapura wrote:
On Mon, Jun
Hi
Am 13.06.22 um 14:34 schrieb Patrik Jakobsson:
These functions mostly do the same thing so unify them. Change a check
of !IS_MRST() to IS_PSB() to not change the behaviour for CDV.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/cdv_intel_lvds.c | 51 +--
drive
Hi
Am 13.06.22 um 14:34 schrieb Patrik Jakobsson:
These now only contains generic gma functions so create
gma_lvds_helper_funcs that both PSB and CDV can use. Oaktrail still
needs the modeset callback refactored to align with PSB and CDV.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/g
The R16-Vista-E board from RenewWorldOutreach based on allwinner
R16(A33).
General features:
- 1GB RAM
- microSD slot
- Realtek Wifi
- 1 x USB 2.0
- HDMI IN
- HDMI OUT
- Audio out
- MIPI DSI
- TI DLPC3433
It has also connectors to connect an external mini keypad.
Signed-off-by: Suniel Mahesh
--
Add a binding for the RenewWorldOutReach R16-Vista-E board based on
allwinner R16.
Signed-off-by: Suniel Mahesh
---
Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml
b/Documentation/devicetr
commit 6de79dd3a920 ("drm/bridge: display-connector: add ddc-en gpio
support") added a consumer for this GPIO in the HDMI connector device.
This new consumer conflicts with the pre-existing GPIO consumer in the
sun8i HDMI controller driver, which prevents the driver from probing:
[4.983358]
Hi Patrik
Am 13.06.22 um 14:34 schrieb Patrik Jakobsson:
These now only contains generic gma functions so create
gma_lvds_connector_helper_funcs that all chips can use.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/cdv_intel_lvds.c | 10 +-
drivers/gpu/drm/gma500/gma_lv
Hi
Am 13.06.22 um 14:34 schrieb Patrik Jakobsson:
These now only contains generic drm/gma functions so create
gma_lvds_connector_funcs that all chips can use.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/cdv_intel_lvds.c | 9 +
drivers/gpu/drm/gma500/gma_lvds.c
Hi Patrik,
I've send comments on a few patches. For the other patches, you can add
Acked-by: Thomas Zimmermann
Best regards
Thomas
Am 13.06.22 um 14:34 schrieb Patrik Jakobsson:
Much of the lvds code for Poulsbo, Oaktrail and Cedarview are almost
identical so there is no need to keep three c
On Mon, 13 Jun 2022 14:54:57 +
Zack Rusin wrote:
> On Mon, 2022-06-13 at 17:25 +0300, Pekka Paalanen wrote:
> > On Mon, 13 Jun 2022 13:14:48 +
> > Zack Rusin wrote:
> >
> > > On Mon, 2022-06-13 at 10:33 +0300, Pekka Paalanen wrote:
> > > > On Fri, 10 Jun 2022 14:24:01 +
> > > >
Hi Thomas,
On Mon, Jun 13, 2022 at 01:23:54PM +0200, Thomas Zimmermann wrote:
> Am 10.06.22 um 11:28 schrieb Maxime Ripard:
> > The DRM-managed function to register a CRTC is
> > drmm_crtc_alloc_with_planes(), which will allocate the underlying
> > structure and initialisation the CRTC.
> >
> > H
On Thu, Jun 09, 2022 at 06:09:40PM +, Prashant Malani wrote:
> Loosen the typec_mux_match() requirements so that searches where an
> alt mode is not specified, but the target mux device lists the
> "mode-switch" property, return a success.
>
> This is helpful in Type C port drivers which would
Il 13/06/22 18:37, Nícolas F. R. A. Prado ha scritto:
While parsing the DT, the anx7625 driver checks for the presence of a
panel bridge on endpoint 1. If it is missing, pdata->panel_bridge stores
the error pointer and the function returns successfully without first
cleaning that variable. This i
Final call to raise objections.
Regards,
Tvrtko
On 07/06/2022 09:36, Tvrtko Ursulin wrote:
On 27/05/2022 13:07, Andrzej Hajda wrote:
On 27.05.2022 09:24, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
We have long standing customer complaints that pressing Ctrl-C (or to
the
effect of) cau
On Mon, 13 Jun 2022, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Eliminate unnecessary includes from drm_crtc.h to avoid
> pointless rebuilds of the entire universe when touching
> some random header.
>
> I didn't really feel like splitting this up per-driver since
> that would have ended up b
Hi,
On Thu, Jun 09, 2022 at 06:09:41PM +, Prashant Malani wrote:
> There are some drivers that can use the Type C mux API, but don't have
> to. Introduce CONFIG guards for the mux functions so that drivers can
> include the header file and not run into compilation errors on systems
> which don
Il 09/06/22 20:09, Prashant Malani ha scritto:
From: Pin-Yen Lin
Add the callback function when the driver receives state
changes of the Type-C port. The callback function configures the
crosspoint switch of the anx7625 bridge chip, which can change the
output pins of the signals according to t
On Mon, 13 Jun 2022 at 10:11, Michel Dänzer wrote:
>
> On 2022-06-11 09:19, Christian König wrote:
> > Am 10.06.22 um 15:54 schrieb Michel Dänzer:
> >> From: Michel Dänzer
> >>
> >> The commit below changed the TTM manager size unit from pages to
> >> bytes, but failed to adjust the corresponding
Il 09/06/22 20:09, Prashant Malani ha scritto:
When the DT node has "switches" available, register a Type-C mode-switch
for each listed "switch". This allows the driver to receive state
information about what operating mode a Type-C port and its connected
peripherals are in, as well as status inf
Il 09/06/22 20:09, Prashant Malani ha scritto:
Parse the "switches" node, if available, and count and store the number
of Type-C switches within it. Since we currently don't do anything with
this info, no functional changes are expected from this change.
This patch sets a foundation for the actu
Il 09/06/22 20:09, Prashant Malani ha scritto:
There are some drivers that can use the Type C mux API, but don't have
to. Introduce CONFIG guards for the mux functions so that drivers can
include the header file and not run into compilation errors on systems
which don't have CONFIG_TYPEC enabled.
Il 09/06/22 20:09, Prashant Malani ha scritto:
Loosen the typec_mux_match() requirements so that searches where an
alt mode is not specified, but the target mux device lists the
"mode-switch" property, return a success.
This is helpful in Type C port drivers which would like to get a pointer
to
Hi
Am 14.06.22 um 09:37 schrieb Maxime Ripard:
Hi Thomas,
On Mon, Jun 13, 2022 at 01:23:54PM +0200, Thomas Zimmermann wrote:
Am 10.06.22 um 11:28 schrieb Maxime Ripard:
The DRM-managed function to register a CRTC is
drmm_crtc_alloc_with_planes(), which will allocate the underlying
structure a
Quoting Kuogee Hsieh (2022-06-13 14:48:37)
> During display resolution changes display have to be disabled first
> followed by display enabling with new resolution. Display disable
> will turn off both pixel clock and main link clock so that main link
> have to be re-trained during display enable t
From: Ville Syrjälä
drm_crtc.h has no need for drm_edid.h, so don't include it.
Avoids useless rebuilds of the entire universe when
touching drm_edid.h.
Quite a few placs do currently depend on drm_edid.h without
actually including it directly. All of those need to be fixed
up.
v2: Fix up i915
From: Ville Syrjälä
drm_crtc.h has no need for drm_frambuffer.h, so don't include it.
Avoids useless rebuilds of the entire universe when
touching drm_framebuffer.h.
Quite a few placs do currently depend on drm_framebuffer.h without
actually including it directly. All of those need to be fixed
u
On Tue, Jun 14, 2022 at 10:29:20AM +0200, Thomas Zimmermann wrote:
> Hi
>
> Am 14.06.22 um 09:37 schrieb Maxime Ripard:
> > Hi Thomas,
> >
> > On Mon, Jun 13, 2022 at 01:23:54PM +0200, Thomas Zimmermann wrote:
> > > Am 10.06.22 um 11:28 schrieb Maxime Ripard:
> > > > The DRM-managed function to r
Hi AngeloGioacchino,
On Tue, Jun 14, 2022 at 4:15 PM AngeloGioacchino Del Regno
wrote:
>
> Il 09/06/22 20:09, Prashant Malani ha scritto:
> > From: Pin-Yen Lin
> >
> > Add the callback function when the driver receives state
> > changes of the Type-C port. The callback function configures the
>
The WD22TB4 Thunderbolt dock at least will revert its DP_MAX_LINK_RATE
from HBR3 to HBR2 after system suspend/resume if the DP_DP13_DPCD_REV
registers are not read subsequently also as required.
Fix this by reading DP_DP13_DPCD_REV registers as well, matching what is
done during connector detectio
From: Ville Syrjälä
drm_crtc.h has no need for drm_frambuffer.h, so don't include it.
Avoids useless rebuilds of the entire universe when
touching drm_framebuffer.h.
Quite a few placs do currently depend on drm_framebuffer.h without
actually including it directly. All of those need to be fixed
u
From: Ville Syrjälä
drm_crtc.h has no need for linux/media-bus-format.h, so don't
include it. Avoids useless rebuilds of the entire universe when
touching linux/media-bus-format.h.
Quite a few placs do currently depend on linux/media-bus-format.h
without actually including it directly. All of th
Add more warning/debug messages during probe. E.g. a single -EPROBE_DEFER
might have several causes, these messages help finding the origin.
Signed-off-by: Alexander Stein
---
* New in v2
drivers/gpu/drm/bridge/ti-sn65dsi83.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
There is no need to require non-sleeping GPIO access. Silence the
WARN_ON() if GPIO is using e.g. I2C expanders.
Signed-off-by: Alexander Stein
---
Change in v2:
* None
drivers/gpu/drm/bridge/ti-sn65dsi83.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/
Hi, Abhinav
On 2022/6/11 7:20, Abhinav Kumar wrote:
>
>
> On 6/7/2022 4:08 AM, Miaoqian Lin wrote:
>> of_graph_get_remote_node() returns remote device node pointer with
>> refcount incremented, we should use of_node_put() on it
>> when not need anymore.
>> Add missing of_node_put() to avoid refcou
On 14/06/2022 13:07, Miaoqian Lin wrote:
Hi, Abhinav
On 2022/6/11 7:20, Abhinav Kumar wrote:
On 6/7/2022 4:08 AM, Miaoqian Lin wrote:
of_graph_get_remote_node() returns remote device node pointer with
refcount incremented, we should use of_node_put() on it
when not need anymore.
Add missing
Hi Maxime
Am 14.06.22 um 11:04 schrieb Maxime Ripard:
On Tue, Jun 14, 2022 at 10:29:20AM +0200, Thomas Zimmermann wrote:
Hi
Am 14.06.22 um 09:37 schrieb Maxime Ripard:
Hi Thomas,
On Mon, Jun 13, 2022 at 01:23:54PM +0200, Thomas Zimmermann wrote:
Am 10.06.22 um 11:28 schrieb Maxime Ripard:
Hello Paul Kocialkowski,
The patch efeeaefe9be5: "drm: Add support for the LogiCVC display
controller" from May 20, 2022, leads to the following Smatch static
checker warning:
drivers/gpu/drm/logicvc/logicvc_layer.c:320
logicvc_layer_buffer_find_setup()
warn: impossible condition
The "regmap" is supposed to be initialized to NULL but it's used
without being initialized.
Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display controller")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/logicvc/logicvc_drm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
Return -EINVAL if logicvc_layer_formats_lookup() fails. Don't return
success.
Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display controller")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/logicvc/logicvc_layer.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/
On Tue, Jun 14, 2022 at 01:47:28PM +0200, Thomas Zimmermann wrote:
> Am 14.06.22 um 11:04 schrieb Maxime Ripard:
> > On Tue, Jun 14, 2022 at 10:29:20AM +0200, Thomas Zimmermann wrote:
> > > Am 14.06.22 um 09:37 schrieb Maxime Ripard:
> > > > Hi Thomas,
> > > >
> > > > On Mon, Jun 13, 2022 at 01:23
Return -ENOMEM instead of success if dma_fence_unwrap_merge() fails.
Fixes: ec8d985ff26f ("drm: use dma_fence_unwrap_merge() in drm_syncobj")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/drm_syncobj.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_
Am 14.06.22 um 14:10 schrieb Dan Carpenter:
Return -ENOMEM instead of success if dma_fence_unwrap_merge() fails.
You are to late Dan, that one was already reported and fixed
https://lore.kernel.org/lkml/4845ad23-476c-97b9-9b3f-d8aaa9027...@amd.com/T/
Interesting that now the automated checke
On Tue, 14 Jun 2022, Imre Deak wrote:
> The WD22TB4 Thunderbolt dock at least will revert its DP_MAX_LINK_RATE
> from HBR3 to HBR2 after system suspend/resume if the DP_DP13_DPCD_REV
> registers are not read subsequently also as required.
Does it actually change the behaviour depending on whether
On Tue, 14 Jun 2022, Jani Nikula wrote:
> On Tue, 14 Jun 2022, Imre Deak wrote:
>> The WD22TB4 Thunderbolt dock at least will revert its DP_MAX_LINK_RATE
>> from HBR3 to HBR2 after system suspend/resume if the DP_DP13_DPCD_REV
>> registers are not read subsequently also as required.
>
> Does it a
On Tue, Jun 14, 2022 at 9:23 AM Thomas Zimmermann wrote:
>
> Hi
>
> Am 13.06.22 um 14:34 schrieb Patrik Jakobsson:
> > These functions mostly do the same thing so unify them. Change a check
> > of !IS_MRST() to IS_PSB() to not change the behaviour for CDV.
> >
> > Signed-off-by: Patrik Jakobsson
Hi
Am 14.06.22 um 14:42 schrieb Patrik Jakobsson:
On Tue, Jun 14, 2022 at 9:23 AM Thomas Zimmermann wrote:
Hi
Am 13.06.22 um 14:34 schrieb Patrik Jakobsson:
These functions mostly do the same thing so unify them. Change a check
of !IS_MRST() to IS_PSB() to not change the behaviour for CDV.
On Tue, Jun 14, 2022 at 03:32:59PM +0300, Jani Nikula wrote:
> On Tue, 14 Jun 2022, Imre Deak wrote:
> > The WD22TB4 Thunderbolt dock at least will revert its DP_MAX_LINK_RATE
> > from HBR3 to HBR2 after system suspend/resume if the DP_DP13_DPCD_REV
> > registers are not read subsequently also as
Hello José,
On 6/13/22 19:17, José Expósito wrote:
[snip]
> +KUnit (Kernel unit testing framework) provides a common framework for unit
> tests
> +within the Linux kernel.
> +
I think that it will be useful to have a reference to the KUnit kernel doc here,
something like the following:
`KUnit
On 6/13/22 19:17, José Expósito wrote:
> Hello everyone,
>
> Here is the v3 of the series, including the documentation, previously
> sent as a standalone patch [1], and changes suggested during review.
>
> Thanks a lot,
> José Expósito
>
Before merging this, could you please reach the folks wor
The Arm Juno board EDK2 port has provided an EFI GOP display via HDLCD0
for some time now, which works nicely as an early framebuffer. However,
once the HDLCD driver probes and takes over the hardware, it should
take over the logical framebuffer as well, otherwise the now-defunct GOP
device hangs a
On 6/5/22 17:25, Daniel Vetter wrote:
> It only does a might_sleep_if(GFP_RECLAIM) check, which is already
> covered by the might_alloc() in slab_pre_alloc_hook(). And all callers
> of cache_alloc_debugcheck_before() call that beforehand already.
>
> Signed-off-by: Daniel Vetter
> Cc: Christoph L
On 6/5/22 17:25, Daniel Vetter wrote:
> ... instead of open codding it. Completely equivalent code, just
> a notch more meaningful when reading.
>
> Signed-off-by: Daniel Vetter
> Cc: Andrew Morton
> Cc: linux...@kvack.org
Reviewed-by: Vlastimil Babka
> ---
> mm/page_alloc.c | 5 +
> 1 f
On 6/5/22 17:25, Daniel Vetter wrote:
> mempool are generally used for GFP_NOIO, so this wont benefit all that
> much because might_alloc currently only checks GFP_NOFS. But it does
> validate against mmu notifier pte zapping, some might catch some
> drivers doing really silly things, plus it's a b
Hello Robin,
On 6/14/22 15:04, Robin Murphy wrote:
> The Arm Juno board EDK2 port has provided an EFI GOP display via HDLCD0
> for some time now, which works nicely as an early framebuffer. However,
> once the HDLCD driver probes and takes over the hardware, it should
> take over the logical frame
On 2022-06-14 14:26, Javier Martinez Canillas wrote:
Hello Robin,
On 6/14/22 15:04, Robin Murphy wrote:
The Arm Juno board EDK2 port has provided an EFI GOP display via HDLCD0
for some time now, which works nicely as an early framebuffer. However,
once the HDLCD driver probes and takes over the
Hi
Am 14.06.22 um 15:04 schrieb Robin Murphy:
The Arm Juno board EDK2 port has provided an EFI GOP display via HDLCD0
for some time now, which works nicely as an early framebuffer. However,
once the HDLCD driver probes and takes over the hardware, it should
take over the logical framebuffer as w
On Tue, 14 Jun 2022, Imre Deak wrote:
> On Tue, Jun 14, 2022 at 03:32:59PM +0300, Jani Nikula wrote:
>> On Tue, 14 Jun 2022, Imre Deak wrote:
>> > The WD22TB4 Thunderbolt dock at least will revert its DP_MAX_LINK_RATE
>> > from HBR3 to HBR2 after system suspend/resume if the DP_DP13_DPCD_REV
>> >
Hi Dave and Daniel,
Just two regression fixups.
Please kindly let me know if there is any problem.
Thanks,
Inki Dae
The following changes since commit b13baccc3850ca8b8cccbf8ed9912dbaa0fdf7f3:
Linux 5.19-rc2 (2022-06-12 16:11:37 -0700)
are available in the Git repository at:
git://
On Tue, 2022-06-14 at 10:36 +0300, Pekka Paalanen wrote:
> On Mon, 13 Jun 2022 14:54:57 +
> Zack Rusin wrote:
>
> > On Mon, 2022-06-13 at 17:25 +0300, Pekka Paalanen wrote:
> > > On Mon, 13 Jun 2022 13:14:48 +
> > > Zack Rusin wrote:
> > >
> > > > On Mon, 2022-06-13 at 10:33 +0300, Pe
On 6/10/2022 5:39 AM, Douglas Anderson wrote:
>From testing on sc7180-trogdor devices, reading the GMU registers
needs the GMU clocks to be enabled. Those clocks get turned on in
a6xx_gmu_resume(). Confusingly enough, that function is called as a
result of the runtime_pm of the GPU "struct device
>From testing on sc7180-trogdor devices, reading the GMU registers
needs the GMU clocks to be enabled. Those clocks get turned on in
a6xx_gmu_resume(). Confusingly enough, that function is called as a
result of the runtime_pm of the GPU "struct device", not the GMU
"struct device". Unfortunately th
On Fri, 10 Jun 2022 at 10:30, Maxime Ripard wrote:
>
> When the HVS driver is unbound, a lot of memory allocations in the LBM and
> DLIST RAM are still assigned to planes that are still allocated.
>
> Thus, we hit a warning when calling drm_mm_takedown() since the memory pool
> is not completely f
Hi,
On Tue, Jun 14, 2022 at 7:42 AM Akhil P Oommen wrote:
>
> On 6/10/2022 5:39 AM, Douglas Anderson wrote:
> > >From testing on sc7180-trogdor devices, reading the GMU registers
> > needs the GMU clocks to be enabled. Those clocks get turned on in
> > a6xx_gmu_resume(). Confusingly enough, that
Hi,
On Tue, 14 Jun 2022 at 15:40, Zack Rusin wrote:
> On Tue, 2022-06-14 at 10:36 +0300, Pekka Paalanen wrote:
> > The reason I am saying that you need to fix other issues with
> > virtualized drivers at the same time is because those other issues are
> > the sole and only reason why the driver w
On Fri, 10 Jun 2022 at 10:30, Maxime Ripard wrote:
>
> While we were using the component framework to deal with all the DRM
> subdevices, we were not calling component_unbind_all().
>
> This leads to none of the subdevices freeing up their resources as part of
> their unbind() or device managed ho
On 10.06.2022 20:37, Ville Syrjälä wrote:
On Fri, Jun 10, 2022 at 06:00:24PM +0200, Andrzej Hajda wrote:
Handling HPD during driver removal is pointless, and can cause different
use-after-free/concurrency issues:
1. Setup of deferred fbdev after fbdev unregistration.
2. Access to DP-AUX after DP
Hi Maxime
On Fri, 10 Jun 2022 at 10:30, Maxime Ripard wrote:
>
> Whenever the device and driver are unbound, the main device and all the
> subdevices will be removed by calling their unbind() method.
>
> However, the DRM device itself will only be freed when the last user will
> have closed it.
>
On Fri, 10 Jun 2022 at 10:30, Maxime Ripard wrote:
>
> vc4_plane_init() currently initialises the plane with no possible CRTCs,
> and will expect the caller to set it up by itself.
>
> Let's change that logic a bit to follow the syntax of
> drm_universal_plane_init() and pass the possible CRTCs bi
On 6/14/2022 1:38 AM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-06-13 14:48:37)
During display resolution changes display have to be disabled first
followed by display enabling with new resolution. Display disable
will turn off both pixel clock and main link clock so that main link
have t
Can't see anything wrong with this.
I consider this only a NIT, so feel : not sure if -ECANCELLED is reflective of
the "ct service being temporarily down"
as opposed to the "requester cancelling". Perhaps a -EPIPE or -EAGAIN (if we
got this far, we know we are probably mid-
reset) ?? (if not alre
On Mon, 13 Jun 2022 at 23:49, Rob Clark wrote:
>
> From: Rob Clark
>
> Misc small cleanup I noticed. Not called from another object file since
> 3c9edd9c85f5 ("drm/msm: Introduce GEM object funcs")
>
> Signed-off-by: Rob Clark
Reviewed-by: Dmitry Baryshkov
> ---
> drivers/gpu/drm/msm/msm_ge
On Fri, 10 Jun 2022 at 10:30, Maxime Ripard wrote:
>
> Let's switch to drmm_universal_plane_alloc() for our plane allocation and
> initialisation to make the driver a bit simpler.
>
> Signed-off-by: Maxime Ripard
Reviewed-by: Dave Stevenson
> ---
> drivers/gpu/drm/vc4/vc4_crtc.c | 12 +--
On Fri, 10 Jun 2022 at 10:30, Maxime Ripard wrote:
>
> Our internal structure that stores the DRM entities structure is allocated
> through a device-managed kzalloc.
>
> This means that this will eventually be freed whenever the device is
> removed. In our case, the most like source of removal is
On Tue, Jun 14, 2022 at 08:16:41AM +0100, Tvrtko Ursulin wrote:
On 14/06/2022 00:39, Matthew Brost wrote:
On Mon, Jun 13, 2022 at 07:09:06PM +0100, Tvrtko Ursulin wrote:
On 13/06/2022 18:49, Niranjana Vishwanathapura wrote:
On Mon, Jun 13, 2022 at 05:22:02PM +0100, Tvrtko Ursulin wrote:
On
Dne torek, 14. junij 2022 ob 09:31:00 CEST je Samuel Holland napisal(a):
> commit 6de79dd3a920 ("drm/bridge: display-connector: add ddc-en gpio
> support") added a consumer for this GPIO in the HDMI connector device.
> This new consumer conflicts with the pre-existing GPIO consumer in the
> sun8i H
Fix build error when CONFIG_DEBUG_FS is not enabled by adding a
stub function for crtc_debugfs_init().
Eliminates this build error:
../drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function
‘amdgpu_dm_crtc_late_register’:
../drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgp
On Fri, 10 Jun 2022 at 10:30, Maxime Ripard wrote:
>
> All the CRTCs, including the TXP, have a debugfs file and name so we can
> consolidate it into vc4_crtc_data.
>
> Signed-off-by: Maxime Ripard
Reviewed-by: Dave Stevenson
I was sort of expecting the vc4_debugfs_add_regset32 call to move to
On Fri, 10 Jun 2022 at 10:30, Maxime Ripard wrote:
>
> There's no user for that pointer so let's just get rid of it.
>
> Signed-off-by: Maxime Ripard
Reviewed-by: Dave Stevenson
> ---
> drivers/gpu/drm/vc4/vc4_dpi.c | 7 ---
> drivers/gpu/drm/vc4/vc4_drv.h | 1 -
> 2 files changed, 8 dele
On 14/06/2022 16:43, Niranjana Vishwanathapura wrote:
On Tue, Jun 14, 2022 at 08:16:41AM +0100, Tvrtko Ursulin wrote:
On 14/06/2022 00:39, Matthew Brost wrote:
On Mon, Jun 13, 2022 at 07:09:06PM +0100, Tvrtko Ursulin wrote:
On 13/06/2022 18:49, Niranjana Vishwanathapura wrote:
On Mon, Jun
On Fri, 10 Jun 2022 at 10:30, Maxime Ripard wrote:
>
> The VC4 DPI driver private structure contains only a pointer to the
> encoder it implements. This makes the overall structure somewhat
> inconsistent with the rest of the driver, and complicates its
> initialisation without any apparent gain.
On 14/06/2022 17:02, Tvrtko Ursulin wrote:
On 14/06/2022 16:43, Niranjana Vishwanathapura wrote:
On Tue, Jun 14, 2022 at 08:16:41AM +0100, Tvrtko Ursulin wrote:
On 14/06/2022 00:39, Matthew Brost wrote:
On Mon, Jun 13, 2022 at 07:09:06PM +0100, Tvrtko Ursulin wrote:
On 13/06/2022 18:49,
On 02.06.2022 19:21, Zhanjun Dong wrote:
> We are seeing error message of "No response for request". Some cases happened
> while waiting for response and reset/suspend action was triggered. In this
> case, no response is not an error, active requests will be cancelled.
>
> This patch will handl
On Fri, 10 Jun 2022 at 10:30, Maxime Ripard wrote:
>
> Our internal structure that stores the DRM entities structure is allocated
> through a device-managed kzalloc.
>
> This means that this will eventually be freed whenever the device is
> removed. In our case, the most like source of removal is
On Fri, 10 Jun 2022 at 10:30, Maxime Ripard wrote:
>
> The current code will call drm_crtc_cleanup() when the device is
> unbound. However, by then, there might still be some references held to
> that CRTC, including by the userspace that might still have the DRM
> device open.
>
> Let's switch to
On Tue, Jun 14, 2022 at 09:27:05AM +0300, Lionel Landwerlin wrote:
On 10/06/2022 11:53, Matthew Brost wrote:
On Fri, Jun 10, 2022 at 12:07:11AM -0700, Niranjana Vishwanathapura wrote:
VM_BIND and related uapi definitions
Signed-off-by: Niranjana Vishwanathapura
---
Documentation/gpu/rfc/i915
On Fri, 10 Jun 2022 at 10:30, Maxime Ripard wrote:
>
> If we fail to enable the DPI clock, we just ignore the error and moves
> forward. Let's return an error instead.
>
> Signed-off-by: Maxime Ripard
Reviewed-by: Dave Stevenson
> ---
> drivers/gpu/drm/vc4/vc4_dpi.c | 5 -
> 1 file change
On Thu, 02 Jun 2022, Zhanjun Dong wrote:
> We are seeing error message of "No response for request". Some cases happened
> while waiting for response and reset/suspend action was triggered. In this
> case, no response is not an error, active requests will be cancelled.
>
> This patch will handle t
On Thu, 02 Jun 2022 10:21:19 -0700, Zhanjun Dong wrote:
>
Hi Zhanjun,
> We are seeing error message of "No response for request". Some cases happened
> while waiting for response and reset/suspend action was triggered. In this
> case, no response is not an error, active requests will be cancelled
On 6/14/2022 3:09 AM, Dmitry Baryshkov wrote:
On 14/06/2022 13:07, Miaoqian Lin wrote:
Hi, Abhinav
On 2022/6/11 7:20, Abhinav Kumar wrote:
On 6/7/2022 4:08 AM, Miaoqian Lin wrote:
of_graph_get_remote_node() returns remote device node pointer with
refcount incremented, we should use of_no
On Fri, 10 Jun 2022 at 10:30, Maxime Ripard wrote:
>
> Since we have a managed call to create our panel_bridge instance, the call
> to drm_of_panel_bridge_remove() at unbind is both redundant and dangerous
> since it might lead to a use-after-free.
>
> Signed-off-by: Maxime Ripard
Reviewed-by: D
On Tue, Jun 14, 2022 at 05:07:37PM +0100, Tvrtko Ursulin wrote:
On 14/06/2022 17:02, Tvrtko Ursulin wrote:
On 14/06/2022 16:43, Niranjana Vishwanathapura wrote:
On Tue, Jun 14, 2022 at 08:16:41AM +0100, Tvrtko Ursulin wrote:
On 14/06/2022 00:39, Matthew Brost wrote:
On Mon, Jun 13, 2022 at
Hi Maxime.
On Fri, 10 Jun 2022 at 10:30, Maxime Ripard wrote:
>
> Adding a device-managed action will make the error path easier, so let's
> create one to disable our clock.
The DPI block has two clocks (core and pixel), and this is only
affecting one of them (the core clock).
(I'm actually puzz
On Fri, 10 Jun 2022 at 10:30, Maxime Ripard wrote:
>
> The current code will call drm_encoder_cleanup() when the device is
> unbound. However, by then, there might still be some references held to
> that encoder, including by the userspace that might still have the DRM
> device open.
>
> Let's swi
On Fri, 10 Jun 2022 at 10:30, Maxime Ripard wrote:
>
> The current code uses a device-managed function to retrieve the next bridge
> downstream.
>
> However, that means that it will be removed at unbind time, where the DRM
> device is still very much live and might still have some applications tha
On Fri, 10 Jun 2022 at 10:30, Maxime Ripard wrote:
>
> Our current code now mixes some resources whose lifetime are tied to the
> device (clocks, IO mappings, etc.) and some that are tied to the DRM device
> (encoder, bridge).
>
> The device one will be freed at unbind time, but the DRM one will o
On Tue, Jun 14, 2022 at 1:18 AM AngeloGioacchino Del Regno
wrote:
>
> Il 09/06/22 20:09, Prashant Malani ha scritto:
> > When the DT node has "switches" available, register a Type-C mode-switch
> > for each listed "switch". This allows the driver to receive state
> > information about what operati
On Tue, Jun 14, 2022 at 2:08 AM Pin-yen Lin wrote:
>
> Hi AngeloGioacchino,
>
>
> On Tue, Jun 14, 2022 at 4:15 PM AngeloGioacchino Del Regno
> wrote:
> >
> > Il 09/06/22 20:09, Prashant Malani ha scritto:
> > > From: Pin-Yen Lin
> > >
> > > Add the callback function when the driver receives stat
On Tue, 14 Jun 2022 at 16:11, Dave Stevenson
wrote:
>
> Hi Maxime
>
> On Fri, 10 Jun 2022 at 10:30, Maxime Ripard wrote:
> >
> > Whenever the device and driver are unbound, the main device and all the
> > subdevices will be removed by calling their unbind() method.
> >
> > However, the DRM device
1 - 100 of 168 matches
Mail list logo
