Re: [RESEND PATCH] drm/mipi-dsi: Fix error handling in mipi_dsi_device_register_full

2022-06-02 Thread Andrzej Hajda
On 01.06.2022 14:40, Miaoqian Lin wrote: In mipi_dsi_device_alloc(), it calls device_initialize(&dsi->dev); We need to use put_device() instead freeing directly. Fixes: 068a002 ("drm: Add MIPI DSI bus support") Signed-off-by: Miaoqian Lin Looks correct. Reviewed-by: Andrzej Hajda Regards

[PATCH] drm/tegra: Remove redundant NULL check before kfree

2022-06-02 Thread cgel . zte
From: Minghao Chi kfree on NULL pointer is a no-op. Reported-by: Zeal Robot Signed-off-by: Minghao Chi --- drivers/gpu/drm/tegra/submit.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tegra/submit.c b/drivers/gpu/drm/tegra/submit.c index 6d6dd8c35475..5

Re: [PATCH v2 1/5] drm/ast: Support multiple outputs

2022-06-02 Thread Patrik Jakobsson
On Tue, May 31, 2022 at 1:15 PM Thomas Zimmermann wrote: > > Systems with AST graphics can have multiple output; typically VGA > plus some other port. Record detected output chips in a bitmask and > initialize each output on its own. > > Assume a VGA output by default and use SIL164 and DP501 if a

Re: [PATCH v2 2/5] drm/ast: Fix updating the connector's EDID property

2022-06-02 Thread Patrik Jakobsson
On Tue, May 31, 2022 at 1:15 PM Thomas Zimmermann wrote: > > Read the display modes from the connectors DDC helper, which also > updates the connector's EDID property. The code for the connector's > .get_modes helper is now shared between VGA and SIL164. > > Signed-off-by: Thomas Zimmermann > ---

Re: [PATCH v2 3/5] drm/ast: Support output polling

2022-06-02 Thread Patrik Jakobsson
On Tue, May 31, 2022 at 1:15 PM Thomas Zimmermann wrote: > > Enable output polling for all connectors. VGA always uses EDID for this. As > there's currently no interrupt handling for the ast devices, we have to use > that trick for the various DP and DVI ports as well. > > Signed-off-by: Thomas Zi

Re: [PATCH v2 4/5] drm/ast: Fail probing if DCC channel could not be initialized

2022-06-02 Thread Patrik Jakobsson
On Tue, May 31, 2022 at 1:15 PM Thomas Zimmermann wrote: > > Expect the hardware to provide a DDC channel. Fail probing if its > initialization fails. > > Signed-off-by: Thomas Zimmermann It's funny how I just did the same thing to gma500. Great minds think alike ;) Reviewed-by: Patrik Jakobsso

Re: [PATCH v2 5/5] drm/ast: Remove struct ast_{vga,sil164}_connector

2022-06-02 Thread Patrik Jakobsson
On Tue, May 31, 2022 at 1:15 PM Thomas Zimmermann wrote: > > Both, struct ast_vga_connector and struct ast_sil164_connector, are > now wrappers around struct drm_connector. Remove them. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Patrik Jakobsson > --- > drivers/gpu/drm/ast/ast_drv.h

Re: [PATCH 0/8] Cleanup use of ddc i2c buses

2022-06-02 Thread Patrik Jakobsson
On Wed, Jun 1, 2022 at 9:56 PM Thomas Zimmermann wrote: > > Hi Patrik > > Am 01.06.22 um 11:23 schrieb Patrik Jakobsson: > > The various chips have slight differences in how they handle and store > > ddc i2c buses. This series tries to put the main i2c adapter for ddc > > into the drm_connector->d

[PATCH] drm/i915/gt: Fix kernel-doc

2022-06-02 Thread Jiapeng Chong
Fix the following W=1 kernel warnings: drivers/gpu/drm/i915/gt/intel_engine_cs.c:1117: warning: expecting prototype for intel_engines_init_common(). Prototype was for engine_init_common() instead. drivers/gpu/drm/i915/gt/intel_engine_cs.c:1194: warning: expecting prototype for intel_engines_clean

[PATCH] drm/i915/gvt: Fix kernel-doc

2022-06-02 Thread Jiapeng Chong
Fix the following W=1 kernel warnings: drivers/gpu/drm/i915/gvt/aperture_gm.c:308: warning: expecting prototype for inte_gvt_free_vgpu_resource(). Prototype was for intel_vgpu_free_resource() instead. drivers/gpu/drm/i915/gvt/aperture_gm.c:344: warning: expecting prototype for intel_alloc_vgpu_re

Re: mainline build failure due to f1e4c916f97f ("drm/edid: add EDID block count and size helpers")

2022-06-02 Thread Arnd Bergmann
On Thu, Jun 2, 2022 at 3:08 AM Linus Torvalds wrote: > > On Wed, Jun 1, 2022 at 3:28 PM Keisuke Nishimura > wrote: > > > > > > I found 13 definitions of packed structure that contains: > > > - spinlock_t > > > - atomic_t > > > - dma_addr_t > > > - phys_addr_t > > > - size_t > > > - struct m

Re: [PATCH v2 4/5] drm/ast: Fail probing if DCC channel could not be initialized

2022-06-02 Thread Patrik Jakobsson
On Thu, Jun 2, 2022 at 9:25 AM Patrik Jakobsson wrote: > > On Tue, May 31, 2022 at 1:15 PM Thomas Zimmermann wrote: > > > > Expect the hardware to provide a DDC channel. Fail probing if its > > initialization fails. > > > > Signed-off-by: Thomas Zimmermann > > It's funny how I just did the same

Re: How should "max bpc" and "Colorspace" KMS property work?

2022-06-02 Thread Pekka Paalanen
On Wed, 1 Jun 2022 17:06:25 +0300 Ville Syrjälä wrote: > On Wed, Jun 01, 2022 at 10:21:26AM +0300, Pekka Paalanen wrote: > > On Tue, 31 May 2022 20:37:31 +0300 > > Ville Syrjälä wrote: > > > > > On Wed, May 25, 2022 at 01:36:47PM +0300, Pekka Paalanen wrote: > > > > On Wed, 25 May 2022 09:2

Re: [PATCH v4] dma-buf: Add a capabilities directory

2022-06-02 Thread Jason Ekstrand
v4 looks good to me as well. --Jason On Wed, 2022-06-01 at 16:13 +, Simon Ser wrote: > To discover support for new DMA-BUF IOCTLs, user-space has no > choice but to try to perform the IOCTL on an existing DMA-BUF. > However, user-space may want to figure out whether or not the > IOCTL is ava

Re: [PATCH 2/3] dt-bindings: display: Add bindings for ClockworkPi CWD686

2022-06-02 Thread Max Fierke
On Wed, Jun 1, 2022, at 1:47 PM, Rob Herring wrote: > > You probably can simply add this to panel-simple-dsi.yaml. It mainly > depends on how many power supplies this panel has. > Unfortunately, it does have two, a 1.8v and a 3.3v, so panel-simple-dsi.yml won't work here. On the devices on which

Re: mainline build failure due to f1e4c916f97f ("drm/edid: add EDID block count and size helpers")

2022-06-02 Thread Keisuke Nishimura
On 2022/06/01 1:41, Linus Torvalds wrote: On Tue, May 31, 2022 at 1:04 AM Arnd Bergmann wrote: As an experiment: what kind of results would we get when looking for packed structures and unions that contain any of these: I don't think we have that. Not only because it would already caus

Re: [PATCH v2 0/8] Add a panel API to return panel orientation

2022-06-02 Thread Hsin-Yi Wang
On Thu, Jun 2, 2022 at 4:03 PM CK Hu wrote: > > Hi, Hsin-Yi: > > I'm curious that panel driver setting orientation in get_modes() would > work or not. It it works, why not just set orientation in get_modes()? > I find that exynos dsi driver has implement the get_modes() [1] but > Mediatek dsi does

Re: [PATCH] drm/gma500: Clean up some inconsistent indenting

2022-06-02 Thread Patrik Jakobsson
On Thu, May 5, 2022 at 10:10 AM Jiapeng Chong wrote: > > Eliminate the follow smatch warning: > > drivers/gpu/drm/gma500/cdv_device.c:250 cdv_errata() warn: > inconsistent indenting. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Hi Jiapeng, One entire patch to remove a single whit

Re: [PATCH 2/5] drm/gma500: Fix spelling typo in comment

2022-06-02 Thread Patrik Jakobsson
On Fri, May 27, 2022 at 5:42 AM <1064094...@qq.com> wrote: > > From: pengfuyuan > > Fix spelling typo in comment. > > Reported-by: k2ci > Signed-off-by: pengfuyuan > --- > drivers/gpu/drm/gma500/psb_intel_sdvo_regs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drive

Re: [PATCH] drm: bridge: adv7511: Add check for mipi_dsi_driver_register

2022-06-02 Thread Maxime Ripard
On Wed, Jun 01, 2022 at 07:12:55PM +0800, Jiasheng Jiang wrote: > On Wed, Jun 01, 2022 at 05:15:37PM +0800, Laurent Pinchart wrote: > >> Well, as far as I am concerned, the adv7511_exit() in the same file has > >> already dealt with the issue. > >> Therefore, it might not be necessary to add anoth

Re: [PATCH v4] drm/probe-helper: Default to 640x480 if no EDID on DP

2022-06-02 Thread Jani Nikula
On Wed, 01 Jun 2022, Douglas Anderson wrote: > If we're unable to read the EDID for a display because it's corrupt / > bogus / invalid then we'll add a set of standard modes for the > display. Since we have no true information about the connected > display, these modes are essentially guesses but

Re: [PATCH 06/14] leds: mt6370: Add Mediatek MT6370 Indicator support

2022-06-02 Thread Andy Shevchenko
On Thu, Jun 2, 2022 at 8:27 AM ChiYuan Huang wrote: > On Wed, Jun 01, 2022 at 11:48:58AM +0200, Andy Shevchenko wrote: > > On Tue, May 31, 2022 at 1:16 PM ChiaEn Wu wrote: ... > > What indicator? > It's RGB curent sink type LED driver (maximum supported current is only 24mA). Make your commit

Re: [PATCH v2 4/5] drm/ast: Fail probing if DCC channel could not be initialized

2022-06-02 Thread Thomas Zimmermann
Hi Patrik Am 02.06.22 um 09:42 schrieb Patrik Jakobsson: On Thu, Jun 2, 2022 at 9:25 AM Patrik Jakobsson wrote: On Tue, May 31, 2022 at 1:15 PM Thomas Zimmermann wrote: Expect the hardware to provide a DDC channel. Fail probing if its initialization fails. Signed-off-by: Thomas Zimmermann

Re: [PATCH 06/14] leds: mt6370: Add Mediatek MT6370 Indicator support

2022-06-02 Thread ChiYuan Huang
Andy Shevchenko 於 2022年6月2日 週四 下午5:18寫道: > > On Thu, Jun 2, 2022 at 8:27 AM ChiYuan Huang wrote: > > On Wed, Jun 01, 2022 at 11:48:58AM +0200, Andy Shevchenko wrote: > > > On Tue, May 31, 2022 at 1:16 PM ChiaEn Wu wrote: > > ... > > > > What indicator? > > It's RGB curent sink type LED driver (m

Re: [PATCH v2 08/11] drm/msm/dsi_phy_28nm: Replace parent names with clk_hw pointers

2022-06-02 Thread Dmitry Baryshkov
On Thu, 2 Jun 2022 at 01:08, Marijn Suijten wrote: > > parent_hw pointers are easier to manage and cheaper to use than > repeatedly formatting the parent name and subsequently leaving the clk > framework to perform lookups based on that name. > > Signed-off-by: Marijn Suijten Reviewed-by: Dmitry

Re: [PATCH v2 06/11] drm/msm/dsi/phy: Replace hardcoded char-array length with sizeof()

2022-06-02 Thread Dmitry Baryshkov
On Thu, 2 Jun 2022 at 01:08, Marijn Suijten wrote: > > Now that the last DSI PHY PLL driver (dsi_phy_28nm_8960) has been > converted to use a simple stack-local char-array instead of a > devm_kzalloc heap allocation we can safely call sizeof() on every string > variable (that's now a sized array i

Re: [PATCH 00/10] drm/mgag200: Convert device init to use device-info structure

2022-06-02 Thread Jocelyn Falempe
On 01/06/2022 13:25, Thomas Zimmermann wrote: Convert the device-init code to use a device-info structure for each model. The device info contains constants and flags that were previously located in different places of the code. Also refactor the PCI and VRAM initialization handling. A later pat

Re: [RESEND 13/14] leds: flashlight: mt6370: Add Mediatek MT6370 flashlight support

2022-06-02 Thread kernel test robot
Hi ChiaEn, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on pavel-leds/for-next] [also build test WARNING on lee-mfd/for-mfd-next lee-backlight/for-backlight-next v5.18 next-20220602] [If your patch is applied to the wrong git tree, kindly drop us a note. And

[PATCH] drm/sun4i: Enable output signal premultiplication for DE2/DE3

2022-06-02 Thread Roman Stratiienko
Otherwise alpha value is discarded, resulting incorrect pixel apperance on the display. This also fixes missing transparency for the most bottom layer. Test applications and videos w/ w/o this patch are available at [1]. [1]: https://github.com/GloDroid/glodroid_tests/issues/1 Signed-off-by: Rom

[Bug 205089] amdgpu : drm:amdgpu_cs_ioctl : Failed to initialize parser -125

2022-06-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205089 --- Comment #47 from Ryzen Buntu (birbwatc...@protonmail.com) --- I updated mesa using the kisak-mesa PPA, didn't notice any changes. But after disabling AMP/DOCP (using my 3600 ram at 3600mhz), and the auto setting on my BIOS set it to 2133mhz, I

Re: [PATCH v2 04/11] drm/msm/dsi/phy: Reindent and reflow multiline function calls

2022-06-02 Thread Dmitry Baryshkov
On Thu, 2 Jun 2022 at 01:07, Marijn Suijten wrote: > > Patch 613cbd1da3c9 ("drm/msm/dsi: use devm_clk_*register to registe DSI > PHY clocks") introduced the devm_ prefix to clk_hw registration calls, > without updating the indentation of the arguments on the following > lines. > > Similarly e55b3f

Re: [PATCH v2 01/11] clk: divider: Introduce devm_clk_hw_register_divider_parent_hw()

2022-06-02 Thread Dmitry Baryshkov
On Thu, 2 Jun 2022 at 01:07, Marijn Suijten wrote: > > Add the devres variant of clk_hw_register_divider_parent_hw() for > registering a divider clock with clk_hw parent pointer instead of parent > name. > > Signed-off-by: Marijn Suijten Reviewed-by: Dmitry Baryshkov > --- > include/linux/clk

Re: [PATCH v2 02/11] clk: mux: Introduce devm_clk_hw_register_mux_parent_hws()

2022-06-02 Thread Dmitry Baryshkov
On Thu, 2 Jun 2022 at 01:07, Marijn Suijten wrote: > > Add the devres variant of clk_hw_register_mux_hws() for registering a > mux clock with clk_hw parent pointers instead of parent names. > > Signed-off-by: Marijn Suijten Reviewed-by: Dmitry Baryshkov > --- > include/linux/clk-provider.h |

Re: [PATCH v2 03/11] clk: fixed-factor: Introduce *clk_hw_register_fixed_factor_parent_hw()

2022-06-02 Thread Dmitry Baryshkov
On Thu, 2 Jun 2022 at 01:07, Marijn Suijten wrote: > > Add the devres and non-devres variant of > clk_hw_register_fixed_factor_parent_hw() for registering a fixed factor > clock with clk_hw parent pointer instead of parent name. > > Signed-off-by: Marijn Suijten Two minor comments below. It's up

Re: [PATCH v3 1/4] drm/dp: Add wait_hpd_asserted() callback to struct drm_dp_aux

2022-06-02 Thread Dmitry Baryshkov
On 18/04/2022 20:17, Douglas Anderson wrote: Sometimes it's useful for users of the DP AUX bus (like panels) to be able to poll HPD. Let's add a callback that allows DP AUX busses drivers to provide this. Suggested-by: Dmitry Baryshkov Signed-off-by: Douglas Anderson Reviewed-by: Dmitry Bary

[PATCH V13 06/24] LoongArch: Add writecombine support for drm

2022-06-02 Thread Huacai Chen
LoongArch maintains cache coherency in hardware, but its WUC attribute (Weak-ordered UnCached, which is similar to WC) is out of the scope of cache coherency machanism. This means WUC can only used for write-only memory regions. Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Reviewed-by: W

[PATCH] ASoC: hdmi-codec: Update to modern DAI terminology

2022-06-02 Thread Mark Brown
As part of retiring the old defines used to specify DAI formats update the hdmi_codec driver to use the modern names, including the variables in the struct hdmi_codec_daifmt exported to the DRM drivers. In updating this I did note that the only use of this information in DRM drivers is to reject c

[PATCH v2] drm: bridge: adv7511: Add check for mipi_dsi_driver_register

2022-06-02 Thread Jiasheng Jiang
As mipi_dsi_driver_register could return error if fails, it should be better to check the return value and return error if fails. Moreover, if i2c_add_driver fails, mipi_dsi_driver_register should be reverted. Fixes: 1e4d58cd7f88 ("drm/bridge: adv7533: Create a MIPI DSI device") Signed-off-by: Ji

Re: [PATCH v2 4/5] drm/ast: Fail probing if DCC channel could not be initialized

2022-06-02 Thread Patrik Jakobsson
On Thu, Jun 2, 2022 at 11:32 AM Thomas Zimmermann wrote: > > Hi Patrik > > Am 02.06.22 um 09:42 schrieb Patrik Jakobsson: > > On Thu, Jun 2, 2022 at 9:25 AM Patrik Jakobsson > > wrote: > >> > >> On Tue, May 31, 2022 at 1:15 PM Thomas Zimmermann > >> wrote: > >>> > >>> Expect the hardware to pro

[PATCH v2] drm/virtio: Fix NULL vs IS_ERR checking in virtio_gpu_object_shmem_init

2022-06-02 Thread Miaoqian Lin
Since drm_prime_pages_to_sg() function return error pointers. The drm_gem_shmem_get_sg_table() function returns error pointers too. Using IS_ERR() to check the return value to fix this. Fixes: 2f2aa13724d5 ("drm/virtio: move virtio_gpu_mem_entry initialization to new function") Signed-off-by: Mia

[PATCH v1] dt-bindings: msm: update maintainers list with proper id

2022-06-02 Thread Krishna
From: Krishna Manikandan Use quic id instead of codeaurora id in maintainers list for display devicetree bindings. Signed-off-by: Krishna Manikandan --- Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml | 2 +- Documentation/devicetree/bindings/display/msm/dpu-sc7280.yaml

Re: [PATCH] fbdev: simplefb: Check before clk_put() not needed

2022-06-02 Thread Hans de Goede
Hi, On 6/2/22 11:42, Yihao Han wrote: > clk_put() already checks the clk ptr using !clk and IS_ERR() > so there is no need to check it again before calling it. > > Signed-off-by: Yihao Han > --- > drivers/video/fbdev/simplefb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff

Re: [PATCH v2 3/5] drm/ast: Support output polling

2022-06-02 Thread Thomas Zimmermann
Hi Am 02.06.22 um 09:25 schrieb Patrik Jakobsson: On Tue, May 31, 2022 at 1:15 PM Thomas Zimmermann wrote: Enable output polling for all connectors. VGA always uses EDID for this. As there's currently no interrupt handling for the ast devices, we have to use that trick for the various DP and

Re: [PATCH v2 1/5] drm/ast: Support multiple outputs

2022-06-02 Thread Thomas Zimmermann
Hi Am 02.06.22 um 09:24 schrieb Patrik Jakobsson: On Tue, May 31, 2022 at 1:15 PM Thomas Zimmermann wrote: Systems with AST graphics can have multiple output; typically VGA plus some other port. Record detected output chips in a bitmask and initialize each output on its own. Assume a VGA out

Re: [PATCH 00/10] drm/mgag200: Convert device init to use device-info structure

2022-06-02 Thread Thomas Zimmermann
Hi Am 02.06.22 um 11:52 schrieb Jocelyn Falempe: On 01/06/2022 13:25, Thomas Zimmermann wrote: Convert the device-init code to use a device-info structure for each model. The device info contains constants and flags that were previously located in different places of the code. Also refactor th

[PATCH V14 06/24] LoongArch: Add writecombine support for drm

2022-06-02 Thread Huacai Chen
LoongArch maintains cache coherency in hardware, but its WUC attribute (Weak-ordered UnCached, which is similar to WC) is out of the scope of cache coherency machanism. This means WUC can only used for write-only memory regions. Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Reviewed-by: W

Re: [PATCH v5 5/6] ARM: configs: Enable DRM_V3D

2022-06-02 Thread Stefan Wahren
Am 01.06.22 um 13:02 schrieb Peter Robinson: BCM2711, the SoC used on the Raspberry Pi 4 has a different 3D render GPU IP than its predecessors. Enable it it on multi v7 and bcm2835 configs. Signed-off-by: Nicolas Saenz Julienne Signed-off-by: Peter Robinson Reviewed-by: Stefan Wahren

Re: [PATCH v5 1/6] dt-bindings: gpu: v3d: Add BCM2711's compatible

2022-06-02 Thread Stefan Wahren
Am 01.06.22 um 13:02 schrieb Peter Robinson: BCM2711, Raspberry Pi 4's SoC, contains a V3D core. So add its specific compatible to the bindings. Signed-off-by: Nicolas Saenz Julienne Signed-off-by: Peter Robinson Reviewed-by: Stefan Wahren

Re: [PATCH v5 3/6] drm/v3d: Add support for bcm2711

2022-06-02 Thread Stefan Wahren
[add Melissa] Am 01.06.22 um 13:02 schrieb Peter Robinson: Add compatible string and Kconfig options for bcm2711. Signed-off-by: Nicolas Saenz Julienne Signed-off-by: Peter Robinson Reviewed-by: Stefan Wahren --- Changes since v5: - Change compatible to align downstream and othee HW, reord

Re: [PATCH v5 4/6] ARM: dts: bcm2711: Enable V3D

2022-06-02 Thread Stefan Wahren
Hi Peter, Am 01.06.22 um 13:02 schrieb Peter Robinson: This adds the entry for V3D for bcm2711 (used in the Raspberry Pi 4) and the associated firmware clock entry. Signed-off-by: Nicolas Saenz Julienne Signed-off-by: Peter Robinson --- Changes since v5: - Move the firmware clock to bcm2711-r

Re: [PATCH v5 6/6] arm64: config: Enable DRM_V3D

2022-06-02 Thread Stefan Wahren
Am 01.06.22 um 13:02 schrieb Peter Robinson: From: Nicolas Saenz Julienne BCM2711, the SoC used on the Raspberry Pi 4 has a different GPU than its predecessors. Enable it. Signed-off-by: Nicolas Saenz Julienne Signed-off-by: Peter Robinson Reviewed-by: Stefan Wahren

Re: mainline build failure due to f1e4c916f97f ("drm/edid: add EDID block count and size helpers")

2022-06-02 Thread Arnd Bergmann
On Thu, Jun 2, 2022 at 1:21 PM Tetsuo Handa wrote: > On 2022/06/02 16:38, Arnd Bergmann wrote: > >> But let's cc the tomoyo and chelsio people. > > > > I think both of them work because the structures are always > > embedded inside of larger structures that have at least word > > alignment. This i

Re: mainline build failure due to f1e4c916f97f ("drm/edid: add EDID block count and size helpers")

2022-06-02 Thread Tetsuo Handa
On 2022/06/02 16:38, Arnd Bergmann wrote: >> But let's cc the tomoyo and chelsio people. > > I think both of them work because the structures are always > embedded inside of larger structures that have at least word > alignment. This is the thing I was looking for, and the > __packed attribute was

Re: [PATCH v5 0/6] i915: SSEU handling updates

2022-06-02 Thread Balasubramani Vivekanandan
On 01.06.2022 08:07, Matt Roper wrote: > This series reworks i915's internal handling of slice/subslice/EU (SSEU) > > data to represent platforms like Xe_HP in a more natural manner and to >

Re: mainline build failure due to f1e4c916f97f ("drm/edid: add EDID block count and size helpers")

2022-06-02 Thread Ard Biesheuvel
On Thu, 2 Jun 2022 at 14:12, Arnd Bergmann wrote: > > On Thu, Jun 2, 2022 at 1:21 PM Tetsuo Handa > wrote: > > On 2022/06/02 16:38, Arnd Bergmann wrote: > > >> But let's cc the tomoyo and chelsio people. > > > > > > I think both of them work because the structures are always > > > embedded inside

Re: [PATCH v10 02/21] dt-bindings: mediatek,dp: Add Display Port binding

2022-06-02 Thread Rob Herring
On Mon, May 23, 2022 at 12:47:35PM +0200, Guillaume Ranquet wrote: > From: Markus Schneider-Pargmann > > This controller is present on several mediatek hardware. Currently > mt8195 and mt8395 have this controller without a functional difference, > so only one compatible field is added. > > The c

[PATCH v2 0/7] drm/msm: clean up the hw catalog init

2022-06-02 Thread Dmitry Baryshkov
Replace superfluous cfg_init functions, which just assign a static config to the struct dpu_mdss_cfg, with static instances of struct dpu_mdss_cfg. Changes since v1: - Turn catalog->perf and catalog->dma_cfg to be pointers, otherwise clang complains that they are not constant. Dmitry Baryshko

[PATCH v2 2/7] drm/msm/dpu: move VBIF_XINL_QOS_LVL_REMAP size to hw_catalog

2022-06-02 Thread Dmitry Baryshkov
Rather than detecting VBIF_XINL_QOS_LVL_REMAP_000 based on the hwversion, push the offset to the hw_catalog. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 2 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 2 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif

[PATCH v2 3/7] drm/msm/dpu: remove hwversion field from data structures

2022-06-02 Thread Dmitry Baryshkov
The driver should not depend on hw revision for detecting features. Instead it should use features from the hw catalog. Drop the hwversion field from struct dpu_mdss_cfg and struct dpu_hw_blk_reg_map. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 1 - dr

[PATCH v2 4/7] drm/msm/dpu: change catalog->perf to be a const pointer

2022-06-02 Thread Dmitry Baryshkov
Change dpu_mdss_cfg::perf to be a const pointer rather than embedding the dpu_perf_cfg struct into the struct dpu_mdss_cfg. Reported-by: kernel test robot Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 20 +-- .../drm/msm/disp/dpu1/dpu_encode

[PATCH v2 1/7] drm/msm/dpu: use feature bit for LM combined alpha check

2022-06-02 Thread Dmitry Baryshkov
Rather than checking hwversion, follow the usual patter and add special bit to the lm->features to check whether the LM has combined or separate alpha registers. While we are at it, rename dpu_hw_lm_setup_blend_config_sdm845() to dpu_hw_lm_setup_blend_config_combined_alpha(). Signed-off-by: Dmitry

[PATCH v2 7/7] drm/msm/dpu: make dpu hardware catalog static const

2022-06-02 Thread Dmitry Baryshkov
Replace superfluous cfg_init functions, which just assign a static config to the struct dpu_mdss_cfg, with static instances of struct dpu_mdss_cfg. Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 475 -- .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog

[PATCH v2 6/7] drm/msm/dpu: constify struct dpu_mdss_cfg

2022-06-02 Thread Dmitry Baryshkov
Mark struct dpu_mdss_cfg instance as a const pointer. This is mostly a preparation for the next patch. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 4 ++-- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 4 ++-- drivers/gpu/drm/msm/disp/dpu1/d

[PATCH v2 5/7] drm/msm/dpu: change catalog->dma_cfg to be a const pointer

2022-06-02 Thread Dmitry Baryshkov
Change dpu_mdss_cfg::dma_cfg to be a const pointer rather than embedding the dpu_reg_dma_cfg struct into the struct dpu_mdss_cfg. Reported-by: kernel test robot Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 12 ++-- drivers/gpu/drm/msm/disp/dpu1/dp

Re: [PATCH v5 4/6] ARM: dts: bcm2711: Enable V3D

2022-06-02 Thread Peter Robinson
Hi Stefan, > Am 01.06.22 um 13:02 schrieb Peter Robinson: > > This adds the entry for V3D for bcm2711 (used in the Raspberry Pi 4) > > and the associated firmware clock entry. > > > > Signed-off-by: Nicolas Saenz Julienne > > Signed-off-by: Peter Robinson > > --- > > Changes since v5: > > - Move

Re: [PATCH 1/2] dt-bindings: backlight: rt4831: Add the new property for ocp level selection

2022-06-02 Thread Rob Herring
On Thu, May 26, 2022 at 12:32:12PM +0200, Krzysztof Kozlowski wrote: > On 26/05/2022 10:13, ChiYuan Huang wrote: > > Krzysztof Kozlowski 於 2022年5月26日 週四 > > 下午4:06寫道: > >> > >> On 26/05/2022 05:16, cy_huang wrote: > >>> From: ChiYuan Huang > >>> > >>> Add the new property for ocp level selection

Re: [PATCH 07/14] leds: flashlight: mt6370: Add Mediatek MT6370 flashlight support

2022-06-02 Thread Andy Shevchenko
On Thu, Jun 2, 2022 at 2:07 PM szuni chen wrote: > Andy Shevchenko 於 2022年6月1日 週三 下午5:57寫道: > > On Tue, May 31, 2022 at 1:32 PM ChiaEn Wu wrote: ... > > > + const char * const states[] = { "off", "keep", "on" }; > > > + const char *str; > > > + int ret; > > > + > > > +

Re: [PATCH 1/2] dt-bindings: backlight: rt4831: Add the new property for ocp level selection

2022-06-02 Thread Krzysztof Kozlowski
On 02/06/2022 15:56, Rob Herring wrote: > On Thu, May 26, 2022 at 12:32:12PM +0200, Krzysztof Kozlowski wrote: >> On 26/05/2022 10:13, ChiYuan Huang wrote: >>> Krzysztof Kozlowski 於 2022年5月26日 週四 >>> 下午4:06寫道: On 26/05/2022 05:16, cy_huang wrote: > From: ChiYuan Huang > > A

Re: [PATCH 07/14] leds: flashlight: mt6370: Add Mediatek MT6370 flashlight support

2022-06-02 Thread Andy Shevchenko
On Thu, Jun 2, 2022 at 3:57 PM Andy Shevchenko wrote: > On Thu, Jun 2, 2022 at 2:07 PM szuni chen wrote: > > Andy Shevchenko 於 2022年6月1日 週三 下午5:57寫道: > > > On Tue, May 31, 2022 at 1:32 PM ChiaEn Wu wrote: ... > > > > + const char * const states[] = { "off", "keep", "on" }; > > > > +

Re: [PATCH v2] drm: bridge: adv7511: Add check for mipi_dsi_driver_register

2022-06-02 Thread Laurent Pinchart
Hi Jiasheng, Thank you for the patch. On Thu, Jun 02, 2022 at 06:34:01PM +0800, Jiasheng Jiang wrote: > As mipi_dsi_driver_register could return error if fails, > it should be better to check the return value and return error > if fails. > Moreover, if i2c_add_driver fails, mipi_dsi_driver_regis

Re: [PATCH] drm/i915: Add extra registers to GPU error dump

2022-06-02 Thread Souza, Jose
On Wed, 2022-06-01 at 14:06 -0700, Matt Roper wrote: > From: Stuart Summers > > Our internal teams have identified a few additional engine registers > that are worth inspecting in error state dumps during development & > debug. Let's capture and print them as part of our error dump. > > For sim

Re: [PATCH v3 3/4] drm/panel: atna33xc20: Take advantage of wait_hpd_asserted() in struct drm_dp_aux

2022-06-02 Thread Dmitry Baryshkov
On 18/04/2022 20:17, Douglas Anderson wrote: Let's add support for being able to read the HPD pin even if it's hooked directly to the controller. This will let us take away the waiting in the AUX transfer functions of the eDP controller drivers. Signed-off-by: Douglas Anderson --- Changes in v

Re: [PATCH v5 1/6] dt-bindings: gpu: v3d: Add BCM2711's compatible

2022-06-02 Thread Rob Herring
On Wed, 01 Jun 2022 12:02:44 +0100, Peter Robinson wrote: > BCM2711, Raspberry Pi 4's SoC, contains a V3D core. So add its specific > compatible to the bindings. > > Signed-off-by: Nicolas Saenz Julienne > Signed-off-by: Peter Robinson > --- > Changes since v5: > - Change compatible to align dow

Re: [PATCH v3 4/4] drm/bridge: parade-ps8640: Provide wait_hpd_asserted() in struct drm_dp_aux

2022-06-02 Thread Dmitry Baryshkov
On 18/04/2022 20:17, Douglas Anderson wrote: This implements the callback added by the patch ("drm/dp: Add wait_hpd_asserted() callback to struct drm_dp_aux"). With this change and all the two "DP AUX Endpoint" drivers changed to use wait_hpd_asserted(), we no longer need to have an long delay i

Re: [PATCH v3 2/4] drm/panel-edp: Take advantage of wait_hpd_asserted() in struct drm_dp_aux

2022-06-02 Thread Dmitry Baryshkov
On 18/04/2022 20:17, Douglas Anderson wrote: Let's add support for being able to read the HPD pin even if it's hooked directly to the controller. This will allow us to get more accurate delays also lets us take away the waiting in the AUX transfer functions of the eDP controller drivers. Signed-

Re: [PATCH 1/2] dt-bindings: backlight: rt4831: Add the new property for ocp level selection

2022-06-02 Thread ChiYuan Huang
Krzysztof Kozlowski 於 2022年6月2日 週四 下午9:58寫道: > > On 02/06/2022 15:56, Rob Herring wrote: > > On Thu, May 26, 2022 at 12:32:12PM +0200, Krzysztof Kozlowski wrote: > >> On 26/05/2022 10:13, ChiYuan Huang wrote: > >>> Krzysztof Kozlowski 於 2022年5月26日 週四 > >>> 下午4:06寫道: > > On 26/05/2022 0

[PATCH 0/6] drm: Add mouse cursor hotspot support to atomic KMS

2022-06-02 Thread Zack Rusin
From: Zack Rusin Support for setting mouse cursor hotspot never made the transition from the legacy kms to atomic. This left virtualized drivers, all which are atomic, in a weird spot because all userspace compositors put those drivers on deny-lists for atomic kms due to the fact that mouse click

[PATCH 2/6] drm/vmwgfx: Create mouse hotspot properties on cursor planes

2022-06-02 Thread Zack Rusin
From: Zack Rusin Atomic modesetting got support for mouse hotspots via the hotspot properties. Drivers need to create those properties on cursor planes which require the mouse hotspot coordinates. Add the code creating hotspot properties and port away from old legacy hotspot API. The legacy hots

[PATCH 1/6] drm/atomic: Add support for mouse hotspots

2022-06-02 Thread Zack Rusin
From: Zack Rusin Atomic modesetting code lacked support for specifying mouse cursor hotspots. The legacy kms DRM_IOCTL_MODE_CURSOR2 had support for setting the hotspot but the functionality was not implemented in the new atomic paths. Due to the lack of hotspots in the atomic paths userspace com

[PATCH 3/6] drm/qxl: Create mouse hotspot properties on cursor planes

2022-06-02 Thread Zack Rusin
From: Zack Rusin Atomic modesetting got support for mouse hotspots via the hotspot properties. Drivers need to create those properties on cursor planes which require the mouse hotspot coordinates. Add the code creating hotspot properties and port away from old legacy hotspot API. The legacy hots

[PATCH 5/6] drm/virtio: Create mouse hotspot properties on cursor planes

2022-06-02 Thread Zack Rusin
From: Zack Rusin Atomic modesetting got support for mouse hotspots via the hotspot properties. Drivers need to create those properties on cursor planes which require the mouse hotspot coordinates. Add the code creating hotspot properties and port away from old legacy hotspot API. The legacy hots

[PATCH 4/6] drm/vboxvideo: Create mouse hotspot properties on cursor planes

2022-06-02 Thread Zack Rusin
From: Zack Rusin Atomic modesetting got support for mouse hotspots via the hotspot properties. Drivers need to create those properties on cursor planes which require the mouse hotspot coordinates. Add the code creating hotspot properties and port away from old legacy hotspot API. The legacy hots

[PATCH 6/6] drm: Remove legacy cursor hotspot code

2022-06-02 Thread Zack Rusin
From: Zack Rusin Atomic modesetting support mouse cursor offsets via the hotspot properties that are creates on cursor planes. All drivers which support hotspot are atomic and the legacy code has been implemented in terms of the atomic properties as well. Due to the above the lagacy cursor hotsp

Re: DRM Master ignoring hotplug event during display switching (QT)

2022-06-02 Thread Jagan Teki
Hi Daniel, On Wed, Mar 30, 2022 at 3:27 PM Daniel Vetter wrote: > > On Wed, Mar 30, 2022 at 10:52:54AM +0200, Maxime Ripard wrote: > > On Tue, Mar 29, 2022 at 11:38:32PM +0530, Jagan Teki wrote: > > > Hi all, > > > > > > I have implemented runtime display switching in the MIPI switch design > > >

[PATCH] drm/tegra: dc: rgb: Fix refcount leak in tegra_dc_rgb_probe

2022-06-02 Thread Miaoqian Lin
of_get_child_by_name() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. So add of_node_put() in error paths. Fixes: format:d8f4a9eda006 ("drm: Add NVIDIA Tegra20 support") Signed-off-by: Miaoqian Lin --- drivers/gpu/drm/tegra/rgb.c | 31 +

Re: [RFC PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

2022-06-02 Thread Javier Martinez Canillas
Hello José, On 5/30/22 12:20, José Expósito wrote: > Test the conversion from XRGB to RGB332. > > What is tested? > > - Different values for the X in XRGB to make sure it is ignored > - Different clip values: Single pixel and full and partial buffer > - Well know colors: White, black,

Re: [Intel-gfx] [RFC v3 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-02 Thread Matthew Brost
On Thu, Jun 02, 2022 at 08:42:13AM +0300, Lionel Landwerlin wrote: > On 02/06/2022 00:18, Matthew Brost wrote: > > On Wed, Jun 01, 2022 at 05:25:49PM +0300, Lionel Landwerlin wrote: > > > On 17/05/2022 21:32, Niranjana Vishwanathapura wrote: > > > > +VM_BIND/UNBIND ioctl will immediately start bind

Re: How should "max bpc" and "Colorspace" KMS property work?

2022-06-02 Thread Ville Syrjälä
On Thu, Jun 02, 2022 at 10:47:59AM +0300, Pekka Paalanen wrote: > On Wed, 1 Jun 2022 17:06:25 +0300 > Ville Syrjälä wrote: > > > On Wed, Jun 01, 2022 at 10:21:26AM +0300, Pekka Paalanen wrote: > > > On Tue, 31 May 2022 20:37:31 +0300 > > > Ville Syrjälä wrote: > > > > > > > On Wed, May 25, 20

Re: [PATCH v1 01/13] drm/edid: add block count and data helper functions for drm_edid

2022-06-02 Thread Ville Syrjälä
On Tue, May 24, 2022 at 01:39:23PM +0300, Jani Nikula wrote: > Add drm_edid based block count and data access helper functions that > take the EDID allocated size into account. > > At the moment, the allocated size should always match the EDID size > indicated by the extension count, but this will

[PATCH] fbdev: simplefb: Check before clk_put() not needed

2022-06-02 Thread Yihao Han
clk_put() already checks the clk ptr using !clk and IS_ERR() so there is no need to check it again before calling it. Signed-off-by: Yihao Han --- drivers/video/fbdev/simplefb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/f

Re: [PATCH 07/14] leds: flashlight: mt6370: Add Mediatek MT6370 flashlight support

2022-06-02 Thread szuni chen
Thank you for the valuable suggestion. Andy Shevchenko 於 2022年6月1日 週三 下午5:57寫道: > > On Tue, May 31, 2022 at 1:32 PM ChiaEn Wu wrote: > > > > From: Alice Chen > > > > Add Mediatek MT6370 flashlight support > > Same comments about the commit message. > > ... > > > +#include > > +#include > > +#

Re: [PATCH v1 01/13] drm/edid: add block count and data helper functions for drm_edid

2022-06-02 Thread Jani Nikula
On Thu, 02 Jun 2022, Ville Syrjälä wrote: > On Tue, May 24, 2022 at 01:39:23PM +0300, Jani Nikula wrote: >> Add drm_edid based block count and data access helper functions that >> take the EDID allocated size into account. >> >> At the moment, the allocated size should always match the EDID size

Re: How should "max bpc" and "Colorspace" KMS property work?

2022-06-02 Thread Sebastian Wick
On Thu, Jun 2, 2022 at 6:40 PM Ville Syrjälä wrote: > > On Thu, Jun 02, 2022 at 10:47:59AM +0300, Pekka Paalanen wrote: > > On Wed, 1 Jun 2022 17:06:25 +0300 > > Ville Syrjälä wrote: > > > > > On Wed, Jun 01, 2022 at 10:21:26AM +0300, Pekka Paalanen wrote: > > > > On Tue, 31 May 2022 20:37:31 +03

Re: [PATCH v1 04/13] drm/edid: add drm_edid_connector_update()

2022-06-02 Thread Ville Syrjälä
On Tue, May 24, 2022 at 01:39:26PM +0300, Jani Nikula wrote: > Add a new function drm_edid_connector_update() to replace the > combination of calls drm_connector_update_edid_property() and > drm_add_edid_modes(). Usually they are called in the drivers in this > order, however the former needs infor

Re: [PATCH v1 06/13] drm/probe-helper: make .get_modes() optional, add default action

2022-06-02 Thread Ville Syrjälä
On Tue, May 24, 2022 at 01:39:28PM +0300, Jani Nikula wrote: > Add default action when .get_modes() not set. This also defines what a > .get_modes() hook should do. > > Cc: David Airlie > Cc: Daniel Vetter > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_probe_helper.c | 14 +

Re: How should "max bpc" and "Colorspace" KMS property work?

2022-06-02 Thread Ville Syrjälä
On Thu, Jun 02, 2022 at 07:08:33PM +0200, Sebastian Wick wrote: > On Thu, Jun 2, 2022 at 6:40 PM Ville Syrjälä > wrote: > > > > On Thu, Jun 02, 2022 at 10:47:59AM +0300, Pekka Paalanen wrote: > > > On Wed, 1 Jun 2022 17:06:25 +0300 > > > Ville Syrjälä wrote: > > > > > > > On Wed, Jun 01, 2022 at

Re: [RFC PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

2022-06-02 Thread Javier Martinez Canillas
Hello David, On 6/2/22 19:07, David Gow wrote: > On Thu, Jun 2, 2022 at 9:27 AM Javier Martinez Canillas [snip] >> >> And doing that will also allow you to get rid of this, since just selecting >> CONFIG_DRM_KUNIT_TEST=y would be enough for the tests built and run by KUnit. >> > > This is defin

[PATCH] drm/i915/guc: Check ctx while waiting for response

2022-06-02 Thread Zhanjun Dong
We are seeing error message of "No response for request". Some cases happened while waiting for response and reset/suspend action was triggered. In this case, no response is not an error, active requests will be cancelled. This patch will handle this condition and change the error message into deb

Re: [RFC PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

2022-06-02 Thread Javier Martinez Canillas
On 6/2/22 19:12, David Gow wrote: > On Mon, May 30, 2022 at 9:29 AM José Expósito > wrote: [snip] >> >> A .kuniconfig example is present in the cover letter. (...) > > FYI: it's also possible to run these tests under UML with the extra options: > CONFIG_VIRTIO_UML=y > CONFIG_UML_PCI_OVER_VIRTIO

[PATCH] drm/sun4i: sun8i: Add the ability to keep scaler enabled for VI layer

2022-06-02 Thread Roman Stratiienko
According to DE2.0/DE3.0 manual VI scaler enable register is double buffered, but de facto it doesn't, or the hardware has the shadow register latching issues which causes single-frame picture corruption after changing the state of scaler enable register. Allow the user to keep the scaler always e

  1   2   >