Re: [bug report] dma-buf: call dma_buf_stats_setup after dmabuf is in valid list

2022-05-16 Thread Charan Teja Kalla
++ Adding Christian On 5/16/2022 12:19 PM, Dan Carpenter wrote: > Hello Charan Teja Reddy, > > The patch ef3a6b70507a: "dma-buf: call dma_buf_stats_setup after > dmabuf is in valid list" from May 10, 2022, leads to the following > Smatch static checker warning: > > drivers/dma-buf/dma-buf.

Re: [PATCH] drm/meson: fix HDMI2 420 display mode selection logic

2022-05-16 Thread Neil Armstrong
Hi, On 15/05/2022 22:44, Adrián Larumbe wrote: Commit e67f6037ae1be34b2b68 ("drm/meson: split out encoder from meson_dw_hdmi") introduced a new way of calculating the display's pixel clock. However, it leads to the wrong value being reckoned for Odroid N2+ boards, where clock frequency is never

Re: [bug report] dma-buf: call dma_buf_stats_setup after dmabuf is in valid list

2022-05-16 Thread Christian König
Am 16.05.22 um 09:13 schrieb Charan Teja Kalla: ++ Adding Christian On 5/16/2022 12:19 PM, Dan Carpenter wrote: Hello Charan Teja Reddy, The patch ef3a6b70507a: "dma-buf: call dma_buf_stats_setup after dmabuf is in valid list" from May 10, 2022, leads to the following Smatch static checker war

[PATCH] drm: i915: fix a possible refcount leak in intel_dp_add_mst_connector()

2022-05-16 Thread Hangyu Hua
If drm_connector_init fails, intel_connector_free will be called to take care of proper free. So it is necessary to drop the refcount of port before intel_connector_free. Fixes: 091a4f91942a ("drm/i915: Handle drm-layer errors in intel_dp_add_mst_connector") Signed-off-by: Hangyu Hua --- driv

Re: [PATCH v3] uapi/drm/i915: Document memory residency and Flat-CCS capability of obj

2022-05-16 Thread Lionel Landwerlin
On 14/05/2022 00:06, Jordan Justen wrote: On 2022-05-13 05:31:00, Lionel Landwerlin wrote: On 02/05/2022 17:15, Ramalingam C wrote: Capture the impact of memory region preference list of the objects, on their memory residency and Flat-CCS capability. v2: Fix the Flat-CCS capability of an o

Re: [PATCH] drm/i915/guc/slpc: Use non-blocking H2G for waitboost

2022-05-16 Thread Jani Nikula
On Sat, 14 May 2022, Vinay Belgaumkar wrote: > SLPC min/max frequency updates require H2G calls. We are seeing > timeouts when GuC channel is backed up and it is unable to respond > in a timely fashion causing warnings and affecting CI. > > This is seen when waitboosting happens during a stress te

Re: [PATCH] drm/i915/guc/slpc: Use non-blocking H2G for waitboost

2022-05-16 Thread Jani Nikula
On Mon, 16 May 2022, Jani Nikula wrote: > On Sat, 14 May 2022, Vinay Belgaumkar wrote: >> SLPC min/max frequency updates require H2G calls. We are seeing >> timeouts when GuC channel is backed up and it is unable to respond >> in a timely fashion causing warnings and affecting CI. >> >> This is s

Re: [PATCH v1 14/15] tools: add hmm gup tests for device coherent type

2022-05-16 Thread Alistair Popple
Alex Sierra writes: > The intention is to test hmm device coherent type under different get > user pages paths. Also, test gup with FOLL_LONGTERM flag set in > device coherent pages. These pages should get migrated back to system > memory. > > Signed-off-by: Alex Sierra > --- > tools/testing/

Re: [PATCH v3] uapi/drm/i915: Document memory residency and Flat-CCS capability of obj

2022-05-16 Thread Jordan Justen
On 2022-05-16 00:47:43, Lionel Landwerlin wrote: > On 14/05/2022 00:06, Jordan Justen wrote: >> >> Acked-by: Jordan Justen >> >> I think Nanley has accounted for this on iris with: >> >> >> https://gitlab.freedesktop.org/mesa/mesa/-/commit/42a865730ef72574e179b56a314f30fdccc6cba8 >

Re: [Intel-gfx] [PATCH] drm/i915/guc/rc: Use i915_probe_error instead of drm_error

2022-05-16 Thread Jani Nikula
On Fri, 13 May 2022, "Teres Alexis, Alan Previn" wrote: > Nit: not sure why we use ERR_PTR for int when calling func was also returning > an int. > Anyway, that was how the original code was, so: %pe on an error pointer prints the symbolic error name if CONFIG_SYMBOLIC_ERRNAME=y and the errno i

Re: [Intel-gfx] [PATCH v2 03/25] drm/edid: add struct drm_edid container

2022-05-16 Thread Jani Nikula
On Tue, 10 May 2022, "Nautiyal, Ankit K" wrote: > LGTM. > > Reviewed-by: Ankit Nautiyal Thanks for the review, pushed the lot already on Friday. BR, Jani. > > Regards, > > Ankit > > On 5/9/2022 5:33 PM, Jani Nikula wrote: >> Introduce new opaque type struct drm_edid to encapsulate the EDID dat

Re: [Intel-gfx] [V2 3/3] drm/amd/display: Move connector debugfs to drm

2022-05-16 Thread Jani Nikula
On Mon, 02 May 2022, Harry Wentland wrote: > Both the kernel and IGT series look good to me. > > I recommend you merge the entire kernel set as one into drm-next. We > can pull it into amd-staging-drm-next so as not to break our CI once > the IGT patches land. Can we read that as an ack to merge

RE: [Intel-gfx] [V2 2/3] drm/i915/display/debug: Expose crtc current bpc via debugfs

2022-05-16 Thread Jani Nikula
On Tue, 12 Apr 2022, "Murthy, Arun R" wrote: >> -Original Message- >> From: Intel-gfx On Behalf Of >> Bhanuprakash Modem >> Sent: Monday, April 11, 2022 3:21 PM >> To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; amd- >> g...@lists.freedesktop.org; jani.nik...@linux.i

Re: [bug report] dma-buf: call dma_buf_stats_setup after dmabuf is in valid list

2022-05-16 Thread Dan Carpenter
On Mon, May 16, 2022 at 09:18:55AM +0200, Christian König wrote: > > > 557 > > > 558 return dmabuf; > > > 559 > > > 560 err_sysfs: > > > 561 /* > > > 562 * Set file->f_path.dentry->d_fsdata to NULL so that when > > > 563 * dma_buf_r

[PATCH v5 7/9] drm/tegra: falcon: Set DMACTX field on DMA transactions

2022-05-16 Thread cyndis
From: Mikko Perttunen The DMACTX field determines which context, as specified in the TRANSCFG register, is used. While during boot it doesn't matter which is used, later on it matters and this value is reused by the firmware. Signed-off-by: Mikko Perttunen --- drivers/gpu/drm/tegra/falcon.c |

[PATCH v5 0/9] Host1x context isolation support

2022-05-16 Thread cyndis
From: Mikko Perttunen *** New in v5: Rebased Renamed host1x_context to host1x_memory_context Small change in DRM side client driver ops to reduce churn with some upcoming changes Add NVDEC support *** *** New in v4: Addressed review comments. See individual patches. *** *** New in v3: Add

[PATCH v5 2/9] gpu: host1x: Add context bus

2022-05-16 Thread cyndis
From: Mikko Perttunen The context bus is a "dummy" bus that contains struct devices that correspond to IOMMU contexts assigned through Host1x to processes. Even when host1x itself is built as a module, the bus is registered in built-in code so that the built-in ARM SMMU driver is able to referen

[PATCH v5 6/9] arm64: tegra: Add Host1x context stream IDs on Tegra186+

2022-05-16 Thread cyndis
From: Mikko Perttunen Add Host1x context stream IDs on systems that support Host1x context isolation. Host1x and attached engines can use these stream IDs to allow isolation between memory used by different processes. The specified stream IDs must match those configured by the hypervisor, if one

[PATCH v5 8/9] drm/tegra: Support context isolation

2022-05-16 Thread cyndis
From: Mikko Perttunen For engines that support context isolation, allocate a context when opening a channel, and set up stream ID offset and context fields when submitting a job. As of this commit, the stream ID offset and fallback stream ID are not used when context isolation is disabled. Howev

[PATCH v5 1/9] dt-bindings: host1x: Add iommu-map property

2022-05-16 Thread cyndis
From: Mikko Perttunen Add schema information for specifying context stream IDs. This uses the standard iommu-map property. Signed-off-by: Mikko Perttunen Reviewed-by: Robin Murphy --- v3: * New patch v4: * Remove memory-contexts subnode. --- .../bindings/display/tegra/nvidia,tegra20-host1x.ya

[PATCH v5 4/9] gpu: host1x: Program context stream ID on submission

2022-05-16 Thread cyndis
From: Mikko Perttunen Add code to do stream ID switching at the beginning of a job. The stream ID is switched to the stream ID specified by the context passed in the job structure. Before switching the stream ID, an OP_DONE wait is done on the channel's engine to ensure that there is no residual

[PATCH v5 5/9] iommu/arm-smmu: Attach to host1x context device bus

2022-05-16 Thread cyndis
From: Mikko Perttunen Set itself as the IOMMU for the host1x context device bus, containing "dummy" devices used for Host1x context isolation. Signed-off-by: Mikko Perttunen --- drivers/iommu/arm/arm-smmu/arm-smmu.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/iom

[PATCH v5 9/9] drm/tegra: Implement stream ID related callbacks on engines

2022-05-16 Thread cyndis
From: Mikko Perttunen Implement the get_streamid_offset and can_use_memory_ctx callbacks required for supporting context isolation. Since old firmware on VIC cannot support context isolation without hacks that we don't want to implement, check the firmware binary to see if context isolation shoul

[PATCH v5 3/9] gpu: host1x: Add context device management code

2022-05-16 Thread cyndis
From: Mikko Perttunen Add code to register context devices from device tree, allocate them out and manage their refcounts. Signed-off-by: Mikko Perttunen --- v2: * Directly set DMA mask instead of inheriting from Host1x. * Use iommu-map instead of custom DT property. v4: * Use u64 instead of dm

[PATCH v1 02/13] dt-bindings: Add headers for Host1x and VIC on Tegra234

2022-05-16 Thread cyndis
From: Mikko Perttunen Add clock, memory controller, powergate and reset dt-binding headers for Host1x and VIC on Tegra234. Signed-off-by: Mikko Perttunen --- include/dt-bindings/clock/tegra234-clock.h | 4 include/dt-bindings/memory/tegra234-mc.h | 5 + include/dt-bindings/p

[PATCH v1 12/13] gpu: host1x: Use RESTART_W to skip timed out jobs on Tegra186+

2022-05-16 Thread cyndis
From: Mikko Perttunen When MLOCK enforcement is enabled, the 0-word write currently done is rejected by the hardware outside of an MLOCK region. As such, on these chips, which also have the newer, more convenient RESTART_W opcode, use that instead to skip over the timed out job. Signed-off-by: M

[PATCH v1 08/13] gpu: host1x: Program interrupt destinations on Tegra234

2022-05-16 Thread cyndis
From: Mikko Perttunen On Tegra234, each Host1x VM has 8 interrupt lines. Each syncpoint can be configured with which interrupt line should be used for threshold interrupt, allowing for load balancing. For now, to keep backwards compatibility, just set all syncpoints to the first interrupt. Sign

[PATCH v1 06/13] gpu: host1x: Program virtualization tables

2022-05-16 Thread cyndis
From: Mikko Perttunen Program virtualization tables specifying which VMs have access to which Host1x hardware resources. Programming these has become mandatory in Tegra234. For now, since the driver does not operate as a Host1x hypervisor, we basically allow access to everything to everyone. Si

[PATCH v1 01/13] dt-bindings: Add bindings for Tegra234 Host1x and VIC

2022-05-16 Thread cyndis
From: Mikko Perttunen Update VIC and Host1x bindings for changes in Tegra234. Namely, - New compatible strings - Sharded syncpoint interrupts - Optional reset. Signed-off-by: Mikko Perttunen --- .../display/tegra/nvidia,tegra124-vic.yaml| 1 + .../display/tegra/nvidia,tegra20-host1x.yam

[PATCH v1 09/13] gpu: host1x: Tegra234 device data and headers

2022-05-16 Thread cyndis
From: Mikko Perttunen Add device data and chip headers for Tegra234. Signed-off-by: Mikko Perttunen --- drivers/gpu/host1x/Makefile | 3 +- drivers/gpu/host1x/dev.c | 42 drivers/gpu/host1x/hw/host1x08.c | 33 drivers/gpu/host1x

[PATCH v1 07/13] gpu: host1x: Allow reset to be missing

2022-05-16 Thread cyndis
From: Mikko Perttunen Host1x on Tegra234 does not have a software-controllable reset line. As such, don't bail out if we don't find one in the device tree. Signed-off-by: Mikko Perttunen --- drivers/gpu/host1x/dev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/host1x/dev.c

[PATCH v1 11/13] gpu: host1x: Add MLOCK release code on Tegra234

2022-05-16 Thread cyndis
From: Mikko Perttunen With the full-featured opcode sequence using MLOCKs, we need to also unlock those MLOCKs in the event of a timeout. However, it turns out that on Tegra186/Tegra194, by default, we don't need to do this; furthermore, on Tegra234 it is much simpler to do; so only implement thi

[PATCH v1 13/13] drm/tegra: vic: Add Tegra234 support

2022-05-16 Thread cyndis
From: Mikko Perttunen Add Tegra234 support for VIC. It is backwards compatible with Tegra194. Signed-off-by: Mikko Perttunen --- drivers/gpu/drm/tegra/drm.c | 1 + drivers/gpu/drm/tegra/vic.c | 12 2 files changed, 13 insertions(+) diff --git a/drivers/gpu/drm/tegra/drm.c b/driv

[PATCH v1 03/13] arm64: tegra: Add Host1x and VIC on Tegra234

2022-05-16 Thread cyndis
From: Mikko Perttunen Add device tree nodes for Host1x and VIC on Tegra234. Signed-off-by: Mikko Perttunen --- arch/arm64/boot/dts/nvidia/tegra234.dtsi | 46 1 file changed, 46 insertions(+) diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot/dts/

[PATCH v1 10/13] gpu: host1x: Rewrite job opcode sequence

2022-05-16 Thread cyndis
From: Mikko Perttunen For new (Tegra186+) SoCs, use a new ('full-featured') job opcode sequence that is compatible with virtualization. In particular, the Host1x hardware in Tegra234 is more strict regarding the sequence, requiring ACQUIRE_MLOCK-SETCLASS-SETSTREAMID opcodes to occur in that seque

[PATCH v1 05/13] gpu: host1x: Simplify register mapping and add common aperture

2022-05-16 Thread cyndis
From: Mikko Perttunen Refactor 'regs' property loading using devm_platform_ioremap_* and add loading of the 'common' region found on Tegra234. Signed-off-by: Mikko Perttunen --- drivers/gpu/host1x/dev.c | 46 +--- drivers/gpu/host1x/dev.h | 3 +++ 2 files c

[PATCH v1 00/13] Host1x support on Tegra234

2022-05-16 Thread cyndis
From: Mikko Perttunen Hi all, This series adds support for Host1x and VIC on the recently released Tegra234 (Orin) SoC. It's split into the following parts: * Device tree binding updates * Cleanup in host1x driver * Add programming of new registers and old registers that now need to be progra

[PATCH v1 04/13] gpu: host1x: Deduplicate hardware headers

2022-05-16 Thread cyndis
From: Mikko Perttunen Host1x class information and opcodes are unchanged or backwards compatible across SoCs so let's not duplicate them for each one but have them in a shared header file. At the same time, add opcode functions for acquire/release_mlock. Signed-off-by: Mikko Perttunen --- dri

Re: [PATCH v5 5/9] iommu/arm-smmu: Attach to host1x context device bus

2022-05-16 Thread Will Deacon
On Mon, May 16, 2022 at 11:52:54AM +0300, cyn...@kapsi.fi wrote: > From: Mikko Perttunen > > Set itself as the IOMMU for the host1x context device bus, containing > "dummy" devices used for Host1x context isolation. > > Signed-off-by: Mikko Perttunen > --- > drivers/iommu/arm/arm-smmu/arm-smmu

Re: [PATCH v5 5/9] iommu/arm-smmu: Attach to host1x context device bus

2022-05-16 Thread Mikko Perttunen
On 5/16/22 13:07, Will Deacon wrote: On Mon, May 16, 2022 at 11:52:54AM +0300, cyn...@kapsi.fi wrote: From: Mikko Perttunen Set itself as the IOMMU for the host1x context device bus, containing "dummy" devices used for Host1x context isolation. Signed-off-by: Mikko Perttunen --- drivers/io

Re: [PATCH 1/3] usb: gadget: add Aspeed ast2600 udc driver

2022-05-16 Thread kernel test robot
onfig-s031-20220516 (https://download.01.org/0day-ci/archive/20220516/202205161801.ob6kctea-...@intel.com/config) compiler: or1k-linux-gcc (GCC) 11.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/

Re: [PATCH 1/3] usb: gadget: add Aspeed ast2600 udc driver

2022-05-16 Thread kernel test robot
fig: sparc-randconfig-s031-20220516 (https://download.01.org/0day-ci/archive/20220516/202205161842.gsojewvm-...@intel.com/config) compiler: sparc-linux-gcc (GCC) 11.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmo

Re: [PATCH v3] drm/probe-helper: Make 640x480 first if no EDID

2022-05-16 Thread Thomas Zimmermann
Hi Douglas, I understand that you're trying to tell userspace that the modelist has been made up, but it's not something that should be done via fragile heuristics IMHO. I looked at the Chromium source code that you linked, but I cannot say whether it's doing the correct thing. It all depend

Re: [PATCH v5 5/9] iommu/arm-smmu: Attach to host1x context device bus

2022-05-16 Thread Robin Murphy
On 2022-05-16 11:13, Mikko Perttunen wrote: On 5/16/22 13:07, Will Deacon wrote: On Mon, May 16, 2022 at 11:52:54AM +0300, cyn...@kapsi.fi wrote: From: Mikko Perttunen Set itself as the IOMMU for the host1x context device bus, containing "dummy" devices used for Host1x context isolation. Sig

Re: [PATCH v5 5/9] iommu/arm-smmu: Attach to host1x context device bus

2022-05-16 Thread Mikko Perttunen
On 5/16/22 13:44, Robin Murphy wrote: On 2022-05-16 11:13, Mikko Perttunen wrote: On 5/16/22 13:07, Will Deacon wrote: On Mon, May 16, 2022 at 11:52:54AM +0300, cyn...@kapsi.fi wrote: From: Mikko Perttunen Set itself as the IOMMU for the host1x context device bus, containing "dummy" devices

Re: [PATCH v4 2/5] drm: Add HPD state to drm_connector_oob_hotplug_event()

2022-05-16 Thread Heikki Krogerus
+Hans Hans, do you have any comments? On Mon, May 02, 2022 at 09:53:13AM -0700, Bjorn Andersson wrote: > In some implementations, such as the Qualcomm platforms, the display > driver has no way to query the current HPD state and as such it's > impossible to distinguish between disconnect and atte

Re: [PATCH 0/4] drm: Ignore non-existing color planes in helpers

2022-05-16 Thread Thomas Zimmermann
pinging for review Am 09.05.22 um 10:15 schrieb Thomas Zimmermann: Some DRM helpers assume that all potential color planes of a framebuffer are available; even if the color format didn't specify them. Non-existing planes are silently ignored. This behavior is inconsistent with other helpers and

Re: [PATCH v4 2/5] drm: Add HPD state to drm_connector_oob_hotplug_event()

2022-05-16 Thread Hans de Goede
Hi, On 5/16/22 13:25, Heikki Krogerus wrote: > +Hans > > Hans, do you have any comments? Thanks for the ping, this looks good to me: Reviewed-by: Hans de Goede Regards, Hans > > On Mon, May 02, 2022 at 09:53:13AM -0700, Bjorn Andersson wrote: >> In some implementations, such as the Qualco

Re: [PATCH v12] drm/amdgpu: add drm buddy support to amdgpu

2022-05-16 Thread Mike Lothian
Hi The merge window for 5.19 will probably be opening next week, has there been any progress with this bug? Thanks Mike On Mon, 2 May 2022 at 17:31, Mike Lothian wrote: > > On Mon, 2 May 2022 at 16:54, Arunpravin Paneer Selvam > wrote: > > > > > > > > On 5/2/2022 8:41 PM, Mike Lothian wrote:

Re: [PATCH 3/3] drm/panel: introduce ebbg,ft8719 panel

2022-05-16 Thread Joel Selvaraj
Hi Linus Walleij, On 13/05/22 03:21, Linus Walleij wrote: On Fri, May 6, 2022 at 2:18 PM Joel Selvaraj wrote: +#define dsi_dcs_write_seq(dsi, seq...) do {\ + static const u8 d[] = { seq }; \ + int ret;

Re: [PATCH 1/4] drm/gem: Share code between drm_gem_fb_{begin, end}_cpu_access()

2022-05-16 Thread Javier Martinez Canillas
Hello Thomas, On 5/9/22 10:15, Thomas Zimmermann wrote: > The error-recovery code in drm_gem_fb_begin() is the same pattern > as drm_gem_fb_end(). Implement both this an internal helper. No Maybe "both of these using using an" or something like that ? > functional changes. > > Signed-off-by: Th

Re: [PATCH v3] drm/mgag200: Enable atomic gamma lut update

2022-05-16 Thread Jocelyn Falempe
I pushed it to drm-misc-next. Thanks, -- Jocelyn

Re: [PATCH] [v2] Kbuild: move to -std=gnu11

2022-05-16 Thread Guenter Roeck
On Mon, Feb 28, 2022 at 11:27:43AM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > During a patch discussion, Linus brought up the option of changing > the C standard version from gnu89 to gnu99, which allows using variable > declaration inside of a for() loop. While the C99, C11 and later

Re: [PATCH v2 0/3] mgag200: Improve damage handling

2022-05-16 Thread Jocelyn Falempe
On 04/05/2022 16:59, Thomas Zimmermann wrote: Hi Jocelyn, with my comment on 3/3 considered, you can add Reviewed-by: Thomas Zimemrmann to this patchset. You should get commit access for drm-misc, so that you can land the patchset on your own. Please see   https://drm.pages.freedesktop.o

Re: [PATCH 2/4] drm/gem: Ignore color planes that are unused by framebuffer format

2022-05-16 Thread Javier Martinez Canillas
On 5/9/22 10:16, Thomas Zimmermann wrote: > Only handle color planes that exist in a framebuffer's color format. > Ignore non-existing planes. > > So far, several helpers assumed that all 4 planes are available and > silently ignored non-existing planes. This lead to subtil bugs with > uninitializ

Re: [PATCH 0/4] drm: Ignore non-existing color planes in helpers

2022-05-16 Thread Noralf Trønnes
Den 09.05.2022 10.15, skrev Thomas Zimmermann: > Some DRM helpers assume that all potential color planes of a framebuffer > are available; even if the color format didn't specify them. Non-existing > planes are silently ignored. This behavior is inconsistent with other > helpers and apparently l

Re: [greybus-dev] Re: [PATCH] [v2] Kbuild: move to -std=gnu11

2022-05-16 Thread Greg KH
On Mon, May 16, 2022 at 06:10:23AM -0700, Guenter Roeck wrote: > On Mon, Feb 28, 2022 at 11:27:43AM +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > During a patch discussion, Linus brought up the option of changing > > the C standard version from gnu89 to gnu99, which allows using var

[PATCH v2] drm/nouveau: reorder nouveau_drm_device_fini

2022-05-16 Thread Mark Menzynski
Resources needed for output poll workers are destroyed in nouveau_fbcon_fini() before output poll workers are cleared in nouveau_display_fini(). This means there is a time between fbcon_fini() and display_fini(), where if output poll happens, it crashes. This makes output poll workers cleared righ

Re: [PATCH 3/4] drm/gem-vram: Ignore planes that are unused by framebuffer format

2022-05-16 Thread Javier Martinez Canillas
On 5/9/22 10:16, Thomas Zimmermann wrote: > Only handle color planes that exist in a framebuffer's color format. > Ignore non-existing planes. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas > @@ -673,7 +679,10 @@ drm_gem_vram_plane_helper_prepare_fb(struct drm

Re: [PATCH 7/7] drm/mgag200: Split up connector's mode_valid helper

2022-05-16 Thread Thomas Zimmermann
Hi Am 12.05.22 um 12:38 schrieb Jocelyn Falempe: ... One suggestion to avoid too much repetition: static int mgag200_get_bandwidth_kbps(mdev) { if (IS_G200_SE(mdev)) {     u32 unique_rev_id = mdev->model.g200se.unique_rev_id;     if (unique_rev_id == 0x01) {     retur

Re: [PATCH 4/4] drm/gem: Warn on trying to use a non-existing framebuffer plane

2022-05-16 Thread Javier Martinez Canillas
On 5/9/22 10:16, Thomas Zimmermann wrote: > Warn if callers of drm_gem_fb_get_obj() try to use a GEM buffer for > a non-existing or unset plane. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Linux Engineering Red Ha

[PATCH v2 1/7] drm:/mgag200: Acquire I/O lock while reading EDID

2022-05-16 Thread Thomas Zimmermann
DDC operation conflicts with concurrent mode setting. Acquire the driver's I/O lock in get_modes to prevent this. This change should have been part of commit 931e3f3a0e99 ("drm/mgag200: Protect concurrent access to I/O registers with lock"), but apparently got lost somewhere. Signed-off-by: Thomas

[PATCH v2 6/7] drm/mgag200: Test memory requirements in drm_mode_config_funcs.mode_valid

2022-05-16 Thread Thomas Zimmermann
Test for a mode's memory requirements in the device-wide mode_valid helper. For simplicify, always assume a 32-bit color format. While some rejected modes would work with less colors, implementing this is probably not worth the effort. Also remove the memory-related test from the connector's mode_

[PATCH v2 4/7] drm/mgag200: Switch I2C code to managed cleanup

2022-05-16 Thread Thomas Zimmermann
Store the I2C state within struct mga_device and switch I2C to managed release. Simplifies the related code and lets us remove mga_connector_destroy(). Signed-off-by: Thomas Zimmermann Reviewed-by: Jocelyn Falempe Tested-by: Jocelyn Falempe --- drivers/gpu/drm/mgag200/mgag200_drv.h | 5 ++--

[PATCH v2 0/7] drm/mgag200: Various cleanups

2022-05-16 Thread Thomas Zimmermann
Various small fixes and clean-up patches for mgag200. Tested on Matrix G200EH hardware. v2: * comment on memory constraints on early G200SE-A * fix connector DDC helper Thomas Zimmermann (7): drm:/mgag200: Acquire I/O lock while reading EDID drm/mgag200: Fail on I2C initializa

[PATCH v2 3/7] drm/mgag200: Implement connector's get_modes with helper

2022-05-16 Thread Thomas Zimmermann
Provide drm_connector_helper_get_modes_from_ddc() to implement the connector's get_modes callback. The new helper updates the connector from DDC-provided EDID data. v2: * clear property if EDID is NULL in helper Signed-off-by: Thomas Zimmermann Reviewed-by: Jocelyn Falempe Tested-by: Jo

[PATCH v2 7/7] drm/mgag200: Split up connector's mode_valid helper

2022-05-16 Thread Thomas Zimmermann
Split up the connector's mode_valid helper into a simple-pipe and a mode-config helper. The simple-pipe helper tests for display-size limits while the mode-config helper tests for memory-bandwidth limits. Also add the mgag200_ prefix to mga_vga_calculate_mode_bandwidth() and comment on the functio

[PATCH v2 5/7] drm/mgag200: Remove struct mga_connector

2022-05-16 Thread Thomas Zimmermann
struct mga_connector has outlived its purpose. Inline the rsp init helper into the mode-config code and remove the data structure. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Jocelyn Falempe Tested-by: Jocelyn Falempe --- drivers/gpu/drm/mgag200/mgag200_drv.h | 8 +--

[PATCH v2 2/7] drm/mgag200: Fail on I2C initialization errors

2022-05-16 Thread Thomas Zimmermann
Initialization of the I2C adapter was allowed to fail. The mgag200 driver would have continued without DDC support. Had this happened in practice, it would have led to segmentation faults in the connector code. Resolve this problem by failing driver initialization on I2C- related errors. v2:

[PATCH v3 0/7] drm/mgag200: Various cleanups

2022-05-16 Thread Thomas Zimmermann
Various small fixes and clean-up patches for mgag200. Tested on Matrix G200EH hardware. v3: * fix commit message in 1/7 to say 'drm/mgag200' (Jocelyn) v2: * comment on memory constraints on early G200SE-A * fix connector DDC helper Thomas Zimmermann (7): drm/mgag200: Acq

[PATCH v3 4/7] drm/mgag200: Switch I2C code to managed cleanup

2022-05-16 Thread Thomas Zimmermann
Store the I2C state within struct mga_device and switch I2C to managed release. Simplifies the related code and lets us remove mga_connector_destroy(). Signed-off-by: Thomas Zimmermann Reviewed-by: Jocelyn Falempe Tested-by: Jocelyn Falempe --- drivers/gpu/drm/mgag200/mgag200_drv.h | 5 ++--

[PATCH v3 2/7] drm/mgag200: Fail on I2C initialization errors

2022-05-16 Thread Thomas Zimmermann
Initialization of the I2C adapter was allowed to fail. The mgag200 driver would have continued without DDC support. Had this happened in practice, it would have led to segmentation faults in the connector code. Resolve this problem by failing driver initialization on I2C- related errors. v2:

[PATCH v3 1/7] drm/mgag200: Acquire I/O lock while reading EDID

2022-05-16 Thread Thomas Zimmermann
DDC operation conflicts with concurrent mode setting. Acquire the driver's I/O lock in get_modes to prevent this. This change should have been part of commit 931e3f3a0e99 ("drm/mgag200: Protect concurrent access to I/O registers with lock"), but apparently got lost somewhere. v3: * fix com

[PATCH v3 5/7] drm/mgag200: Remove struct mga_connector

2022-05-16 Thread Thomas Zimmermann
struct mga_connector has outlived its purpose. Inline the rsp init helper into the mode-config code and remove the data structure. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Jocelyn Falempe Tested-by: Jocelyn Falempe --- drivers/gpu/drm/mgag200/mgag200_drv.h | 8 +--

[PATCH v3 3/7] drm/mgag200: Implement connector's get_modes with helper

2022-05-16 Thread Thomas Zimmermann
Provide drm_connector_helper_get_modes_from_ddc() to implement the connector's get_modes callback. The new helper updates the connector from DDC-provided EDID data. v2: * clear property if EDID is NULL in helper Signed-off-by: Thomas Zimmermann Reviewed-by: Jocelyn Falempe Tested-by: Jo

[PATCH v3 7/7] drm/mgag200: Split up connector's mode_valid helper

2022-05-16 Thread Thomas Zimmermann
Split up the connector's mode_valid helper into a simple-pipe and a mode-config helper. The simple-pipe helper tests for display-size limits while the mode-config helper tests for memory-bandwidth limits. Also add the mgag200_ prefix to mga_vga_calculate_mode_bandwidth() and comment on the functio

[PATCH v3 6/7] drm/mgag200: Test memory requirements in drm_mode_config_funcs.mode_valid

2022-05-16 Thread Thomas Zimmermann
Test for a mode's memory requirements in the device-wide mode_valid helper. For simplicify, always assume a 32-bit color format. While some rejected modes would work with less colors, implementing this is probably not worth the effort. Also remove the memory-related test from the connector's mode_

Re: [PATCH v5 5/9] iommu/arm-smmu: Attach to host1x context device bus

2022-05-16 Thread Thierry Reding
On Mon, May 16, 2022 at 02:20:18PM +0300, Mikko Perttunen wrote: > On 5/16/22 13:44, Robin Murphy wrote: > > On 2022-05-16 11:13, Mikko Perttunen wrote: > > > On 5/16/22 13:07, Will Deacon wrote: > > > > On Mon, May 16, 2022 at 11:52:54AM +0300, cyn...@kapsi.fi wrote: > > > > > From: Mikko Perttune

Re: [greybus-dev] Re: [PATCH] [v2] Kbuild: move to -std=gnu11

2022-05-16 Thread Guenter Roeck
On 5/16/22 06:31, Greg KH wrote: On Mon, May 16, 2022 at 06:10:23AM -0700, Guenter Roeck wrote: On Mon, Feb 28, 2022 at 11:27:43AM +0100, Arnd Bergmann wrote: From: Arnd Bergmann During a patch discussion, Linus brought up the option of changing the C standard version from gnu89 to gnu99, whi

Re: [PATCH] drm: bridge: icn6211: Register macro clean up

2022-05-16 Thread Robert Foss
On Sat, 30 Apr 2022 at 04:50, Marek Vasut wrote: > > Drop two unused register macros, ICN6211_MAX_REGISTER and MIPI_ATE_STATUS_1, > neither of which is used and where the later should be specified using macro > MIPI_ATE_STATUS(1) instead. Drop the _(n) underscore and keep only the (n) > part of re

Re: [PATCH v12] drm/amdgpu: add drm buddy support to amdgpu

2022-05-16 Thread Alex Deucher
On Mon, May 16, 2022 at 8:40 AM Mike Lothian wrote: > > Hi > > The merge window for 5.19 will probably be opening next week, has > there been any progress with this bug? It took a while to find a combination of GPUs that would repro the issue, but now that we can, it is still being investigated.

Re: [PATCH] drm: Create support for Write-Only property blob

2022-05-16 Thread Mark Yacoub
friendly ping :)) On Tue, May 10, 2022 at 3:08 PM Mark Yacoub wrote: > > [Why] > User space might need to inject data into the kernel without allowing it > to be read again by any user space. > An example of where this is particularly useful is secret keys fetched > by user space and injected int

Re: linux-next: Tree for May 16 (drm/msm: kconfig warning)

2022-05-16 Thread Randy Dunlap
On 5/16/22 03:57, Stephen Rothwell wrote: > Hi all, > > Changes since 20220513: > on i386 or x86_64: WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && OF [=n] Selected by [y]: - DRM_MSM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH

Re: [PATCH] drm: Add a debug message when getting a prop is missing

2022-05-16 Thread Mark Yacoub
friendly ping :)) On Tue, May 10, 2022 at 2:28 PM Mark Yacoub wrote: > > [Why] > If a connector property is attached but > drm_atomic_connector_get_property doesn't handle a case for it, > modeteset will crash with a segfault without. > > [How] > Add a debug message indicating that a connector pr

Re: [PATCH v2 1/3] dt-bindings: display: rockchip: make reg-names mandatory for VOP2

2022-05-16 Thread Rob Herring
On Wed, 11 May 2022 10:21:07 +0200, Sascha Hauer wrote: > The VOP2 driver relies on reg-names properties, but these are not > documented. Add the missing documentation, make reg-names mandatory > and increase minItems to 2 as always both register spaces are needed. > > Signed-off-by: Sascha Hauer

Re: [PATCH v5 1/9] dt-bindings: host1x: Add iommu-map property

2022-05-16 Thread Rob Herring
On Mon, 16 May 2022 11:52:50 +0300, cyn...@kapsi.fi wrote: > From: Mikko Perttunen > > Add schema information for specifying context stream IDs. This uses > the standard iommu-map property. > > Signed-off-by: Mikko Perttunen > Reviewed-by: Robin Murphy > --- > v3: > * New patch > v4: > * Remov

[PATCH v1 0/2] drm/panel: simple: add bus-format support for panel-dpi

2022-05-16 Thread Max Krummenacher
From: Max Krummenacher Commit 4a1d0dbc8332 ("drm/panel: simple: add panel-dpi support") added support for defining a panel from device tree provided data. However support for setting the bus format is missing, so that with the current implementation a 'panel-dpi' panel can only be used if the d

[PATCH v1 1/2] dt-bindings: display: add new bus-format property for panel-dpi

2022-05-16 Thread Max Krummenacher
From: Max Krummenacher The property is used to set the enum bus_format and infer the bpc for a panel defined by 'panel-dpi'. This specifies how the panel is connected to the display interface. Signed-off-by: Max Krummenacher --- .../bindings/display/panel/panel-dpi.yaml | 11 + ..

[PATCH v1 2/2] drm/panel: simple: add bus-format support for panel-dpi

2022-05-16 Thread Max Krummenacher
From: Max Krummenacher Evaluate the device tree bus-format property to set bus_format for a 'panel-dpi' panel. Additionally infer the bpc value from the given bus-format. Valid values for bus-format are found in: This completes the addition of panel-dpi to completely specify a panel-simple pan

Re: [PATCH v1 01/13] dt-bindings: Add bindings for Tegra234 Host1x and VIC

2022-05-16 Thread Rob Herring
On Mon, May 16, 2022 at 01:02:01PM +0300, cyn...@kapsi.fi wrote: > From: Mikko Perttunen > > Update VIC and Host1x bindings for changes in Tegra234. > > Namely, > - New compatible strings > - Sharded syncpoint interrupts > - Optional reset. > > Signed-off-by: Mikko Perttunen > --- > .../displ

Re: [PATCH v2 1/3] dt-bindings: display: rockchip: make reg-names mandatory for VOP2

2022-05-16 Thread Sascha Hauer
Heiko, On Mon, May 16, 2022 at 10:12:26AM -0500, Rob Herring wrote: > On Wed, 11 May 2022 10:21:07 +0200, Sascha Hauer wrote: > > The VOP2 driver relies on reg-names properties, but these are not > > documented. Add the missing documentation, make reg-names mandatory > > and increase minItems to 2

Re: [PATCH v2] dma-buf: Move sysfs work out of DMA-BUF export path

2022-05-16 Thread Christian König
Am 16.05.22 um 19:13 schrieb T.J. Mercier: Recently, we noticed an issue where a process went into direct reclaim while holding the kernfs rw semaphore for sysfs in write (exclusive) mode. This caused processes who were doing DMA-BUF exports and releases to go into uninterruptible sleep since the

[PATCH v3] drm/doc: add rfc section for small BAR uapi

2022-05-16 Thread Matthew Auld
Add an entry for the new uapi needed for small BAR on DG2+. v2: - Some spelling fixes and other small tweaks. (Akeem & Thomas) - Rework error capture interactions, including no longer needing NEEDS_CPU_ACCESS for objects marked for capture. (Thomas) - Add probed_cpu_visible_size. (Lionel

Re: [PATCH 1/3] usb: gadget: add Aspeed ast2600 udc driver

2022-05-16 Thread kernel test robot
documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Neal-Liu/add-Aspeed-udc-driver-for-ast2600/20220513-150314 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing config: mips-randconfig-s032-202205

Re: [linux-next:master] BUILD REGRESSION 1e1b28b936aed946122b4e0991e7144fdbbfd77e

2022-05-16 Thread Jakub Kicinski
On Sun, 15 May 2022 21:00:21 +0800 kernel test robot wrote: > tree/branch: > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > branch HEAD: 1e1b28b936aed946122b4e0991e7144fdbbfd77e Add linux-next > specific files for 20220513 > > Error/Warning reports: > > https://lo

Re: [PATCH v2] dma-buf: Move sysfs work out of DMA-BUF export path

2022-05-16 Thread Christian König
Am 16.05.22 um 20:08 schrieb T.J. Mercier: On Mon, May 16, 2022 at 10:20 AM Christian König wrote: Am 16.05.22 um 19:13 schrieb T.J. Mercier: Recently, we noticed an issue where a process went into direct reclaim while holding the kernfs rw semaphore for sysfs in write (exclusive) mode. This c

Re: linux-next: Tree for May 16 (drm/i915/gt/intel_gt_sysfs_pm.c)

2022-05-16 Thread Randy Dunlap
On 5/16/22 03:57, Stephen Rothwell wrote: > Hi all, > > Changes since 20220513: > on i386: CC drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.o ../drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c: In function ‘act_freq_mhz_show’: ../drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c:276:20: error: impli

Re: [PATCH 1/1] drm/i915/guc: Remove unnecessary GuC err capture noise

2022-05-16 Thread John Harrison
On 5/6/2022 21:58, Alan Previn wrote: GuC error capture blurts some debug messages about empty register lists for certain register types on engines during firmware initialization. These are not errors or warnings, so get rid of them. Signed-off-by: Alan Previn Reviewed-by: John Harrison --

Re: (subset) [PATCH v2 0/3] RK356x VOP2: Change register space names

2022-05-16 Thread Heiko Stuebner
On Wed, 11 May 2022 10:21:06 +0200, Sascha Hauer wrote: > The VOP2 driver sitting in next uses named register spaces, but the > binding lacks documentation for that. Add the missing documentation > and while at it take the opportunity to rename the register spaces > from too generic "regs" to "vop"

Re: [PATCH v2 11/12] dt-bindings: display: exynos: dsim: Add NXP i.MX8MM support

2022-05-16 Thread Rob Herring
On Wed, 04 May 2022 17:10:20 +0530, Jagan Teki wrote: > Samsung MIPI DSIM bridge can also be found in i.MX8MM SoC. > > Add dt-bingings for it. > > v2: > * updated comments > > v1: > * new patch > > Cc: devicet...@vger.kernel.org, > Cc: Rob Herring > Signed-off-by: Jagan Teki > --- > Note: > I

  1   2   >