Re: [5.18 regression] drm/i915 BYT rendering broken due to "Remove short-term pins from execbuf, v6"

2022-05-09 Thread Thorsten Leemhuis
[TLDR: I'm adding this regression report to the list of tracked regressions; all text from me you find below is based on a few templates paragraphs you might have encountered already already in similar form.] Hi, this is your Linux kernel regression tracker. Top-posting for once, to make this easi

Re: [PATCH v2 1/3] dt-bindings: mediatek: add vdosys1 RDMA definition for mt8195

2022-05-09 Thread Krzysztof Kozlowski
On 09/05/2022 06:43, Rex-BC Chen wrote: > From: "Nancy.Lin" > > Add vdosys1 RDMA definition. > > Signed-off-by: Nancy.Lin > Reviewed-by: AngeloGioacchino Del Regno > > --- > .../display/mediatek/mediatek,mdp-rdma.yaml | 94 +++ > 1 file changed, 94 insertions(+) > create m

Re: [PATCH v2 3/3] dt-bindings: mediatek: add ethdr definition for mt8195

2022-05-09 Thread Krzysztof Kozlowski
On 09/05/2022 06:43, Rex-BC Chen wrote: > From: "Nancy.Lin" > > Add vdosys1 ETHDR definition. > > Signed-off-by: Nancy.Lin > Reviewed-by: Chun-Kuang Hu > Reviewed-by: AngeloGioacchino Del Regno > > --- > .../display/mediatek/mediatek,ethdr.yaml | 191 ++ > 1 file change

Re: [PATCH v5 9/9] drm: vkms: Add support to the RGB565 format

2022-05-09 Thread Pekka Paalanen
On Fri, 6 May 2022 20:05:39 -0300 Igor Torrente wrote: > Hi Pekka, > > On 4/27/22 04:55, Pekka Paalanen wrote: > > On Tue, 26 Apr 2022 21:53:19 -0300 > > Igor Torrente wrote: > > > >> Hi Pekka, > >> > >> On 4/21/22 07:58, Pekka Paalanen wrote: > >>> On Mon, 4 Apr 2022 17:45:15 -0300 > >>>

[PATCH 3/4] drm/gem-vram: Ignore planes that are unused by framebuffer format

2022-05-09 Thread Thomas Zimmermann
Only handle color planes that exist in a framebuffer's color format. Ignore non-existing planes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_vram_helper.c | 36 ++- 1 file changed, 24 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_vr

[PATCH 0/4] drm: Ignore non-existing color planes in helpers

2022-05-09 Thread Thomas Zimmermann
Some DRM helpers assume that all potential color planes of a framebuffer are available; even if the color format didn't specify them. Non-existing planes are silently ignored. This behavior is inconsistent with other helpers and apparently leads to subtle bugs with uninitialized GEM buffer mappings

[PATCH 1/4] drm/gem: Share code between drm_gem_fb_{begin, end}_cpu_access()

2022-05-09 Thread Thomas Zimmermann
The error-recovery code in drm_gem_fb_begin() is the same pattern as drm_gem_fb_end(). Implement both this an internal helper. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_framebuffer_helper.c | 62 1 file changed, 26 insertions(+), 36

[PATCH 2/4] drm/gem: Ignore color planes that are unused by framebuffer format

2022-05-09 Thread Thomas Zimmermann
Only handle color planes that exist in a framebuffer's color format. Ignore non-existing planes. So far, several helpers assumed that all 4 planes are available and silently ignored non-existing planes. This lead to subtil bugs with uninitialized data in instances of struct iosys_map. [1] Signed-

[PATCH 4/4] drm/gem: Warn on trying to use a non-existing framebuffer plane

2022-05-09 Thread Thomas Zimmermann
Warn if callers of drm_gem_fb_get_obj() try to use a GEM buffer for a non-existing or unset plane. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_framebuffer_helper.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_gem_framebuffer_helper

Re: [PATCH v3 4/5] drm/gud: Map framebuffer BOs with drm_gem_fb_vmap()

2022-05-09 Thread Thomas Zimmermann
Hi Noralf Am 06.05.22 um 16:11 schrieb Thomas Zimmermann: Hi Am 06.05.22 um 16:01 schrieb Noralf Trønnes: Hi Thomas, I'm getting this on Ubuntu 22.04: [    0.00] Linux version 5.15.0-27-generic (buildd@ubuntu) (gcc (Ubuntu 11.2.0-19ubuntu1) 11.2.0, GNU ld (GNU Binutils for Ubuntu) 2.38)

Re: [PATCH v11, 13/17] media: mediatek: vcodec: Extract H264 common code

2022-05-09 Thread Hans Verkuil
Hi Yunfei, On 5/6/22 11:28, Yunfei Dong wrote: > Mt8192 can use some of common code with mt8183. Moves them to > a new file in order to reuse. > > Signed-off-by: Yunfei Dong > Reviewed-by: Nicolas Dufresne > --- > .../media/platform/mediatek/vcodec/Makefile | 1 + > .../vcodec/vdec/vdec_h2

[PATCH v12 0/3] drm/rockchip: RK356x VOP2 support last fixups

2022-05-09 Thread Sascha Hauer
This is not the full series, if you want that, look for v11. This series merely has a last-minute change: The VOP2 driver used platform_get_resource_byname() to get its registers, but the reg-names property hasn't been documented in the binding. This series adds the missing documentation and along

[PATCH v12 1/3] arm64: dts: rockchip: rk356x: Add VOP2 nodes

2022-05-09 Thread Sascha Hauer
The VOP2 is the display output controller on the RK3568. Add the node for it to the dtsi file along with the required display-subsystem node and the iommu node. Signed-off-by: Sascha Hauer --- Notes: Changes since v11: - Rename "regs" to "vop" - Rename "gamma_lut" to "gamma-lut"

[PATCH v12 2/3] dt-bindings: display: rockchip: Add binding for VOP2

2022-05-09 Thread Sascha Hauer
The VOP2 is found on newer Rockchip SoCs like the rk3568 or the rk3566. The binding differs slightly from the existing VOP binding, so add a new binding file for it. Signed-off-by: Sascha Hauer --- Notes: Changes since v11: - Document "vop" and "gamma-lut" reg-names property - make r

[PATCH v12 3/3] drm: rockchip: Add VOP2 driver

2022-05-09 Thread Sascha Hauer
From: Andy Yan The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568. It replaces the VOP unit found in the older Rockchip SoCs. This driver has been derived from the downstream Rockchip Kernel and heavily modified: - All nonstandard DRM properties have been removed - dropped str

Re: [PATCH v12 0/3] drm/rockchip: RK356x VOP2 support last fixups

2022-05-09 Thread Heiko Stübner
Hi Sascha, Am Montag, 9. Mai 2022, 10:37:35 CEST schrieb Sascha Hauer: > This is not the full series, if you want that, look for v11. > > This series merely has a last-minute change: The VOP2 driver used > platform_get_resource_byname() to get its registers, but the reg-names > property hasn't be

Re: [PATCH v5 2/2] ALSA: hda - identify when audio is provided by a video driver

2022-05-09 Thread Takashi Iwai
On Sat, 30 Apr 2022 22:04:55 +0200, Mauro Carvalho Chehab wrote: > > On some devices, the hda driver needs to hook into a video driver, > in order to be able to properly access the audio hardware and/or > the power management function. > > That's the case of several snd_hda_intel devices that dep

Re: (EXT) Re: (EXT) [PATCH v2 00/12] drm: bridge: Add Samsung MIPI DSIM bridge

2022-05-09 Thread Marek Szyprowski
Hi Dave, On 06.05.2022 12:50, Dave Stevenson wrote: > On Fri, 6 May 2022 at 09:57, Marek Szyprowski > wrote: >> On 05.05.2022 13:55, Alexander Stein wrote: >>> Am Donnerstag, 5. Mai 2022, 09:38:48 CEST schrieb Jagan Teki: On Thu, May 5, 2022 at 12:57 PM Alexander Stein wrote: >>>

[bug report] drm/msm/dpu: introduce the dpu_encoder_phys_* for writeback

2022-05-09 Thread Dan Carpenter
[ Oops. I never sent this after all. - dan ] Hello Abhinav Kumar, The patch d7d0e73f7de3: "drm/msm/dpu: introduce the dpu_encoder_phys_* for writeback" from Apr 26, 2022, leads to the following Smatch static checker warning: drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c:252 dpu_

[PATCH] drm/rockchip: vop2: unlock on error path in vop2_crtc_atomic_enable()

2022-05-09 Thread Dan Carpenter
This error path needs an unlock before returning. Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/dr

Re: [5.18 regression] drm/i915 BYT rendering broken due to "Remove short-term pins from execbuf, v6"

2022-05-09 Thread Tvrtko Ursulin
On 08/05/2022 15:38, Hans de Goede wrote: Hi All, When running a 5.18-rc4 (and -rc5) kernel on a Chuwi Hi 8, which is a Bay Trail based tablet with 2G RAM and a 1200x1920 DSI panel. I noticed that gnome-shell was misrendering. Many UI elements were missing (they were all black) and at the gdm

[PATCH 1/2] drm/edid: Fix minimum bpc supported with DSC1.2 for HDMI sink

2022-05-09 Thread Ankit Nautiyal
HF-VSDB/SCDB has bits to advertise support for 16, 12 and 10 bpc. If none of the bits are set, the minimum bpc supported with DSC is 8. This patch corrects the min bpc supported to be 8, instead of 0. Fixes: 76ee7b905678 ("drm/edid: Parse DSC1.2 cap fields from HFVSDB block") Cc: Ankit Nautiyal

[PATCH 0/2] Prune unsupported modes as per HDMI2.1 spec

2022-05-09 Thread Ankit Nautiyal
Modes like 4K100, 4K120, 8K50, 8K60 need FRL and/or DSC from source. Since FRL and DSC are not currently supported natively by intel platforms (are supported only via DP-HDMI2.1 PCONs), these modes must be pruned as per spec. Currently these modes are not getting pruned as we check the TMDS clock,

[PATCH 2/2] drm/i915/hdmi: Prune unsupported modes as per HDMI2.1 spec

2022-05-09 Thread Ankit Nautiyal
As per Sec 7.8.1 of HDMI2.1 spec, sources that support modes: 4K100, 4K120, 8K50, 8K60 must support these modes in at least one of the below formats: i) uncompressed FRL, 420 format and min of 10 bpc, or ii) compressed FRL, 444 format and min of 10 bpc. Since FRL and DSC are not supported natively

Re: (EXT) [PATCH v0.5 0/9] i.MX8MP HDMI support

2022-05-09 Thread Alexander Stein
Hi Lucas, Am Freitag, 6. Mai 2022, 20:10:25 CEST schrieb Lucas Stach: > second round of the i.MX8MP HDMI work. Still not split up into proper > parts for merging through the various trees this needs to go into, but > should make it easy for people to test. > > I've worked in the feedback I got fr

[PATCH] mgag200: Enable atomic gamma lut update

2022-05-09 Thread Jocelyn Falempe
Add support for atomic update of gamma lut. With this patch the "Night light" feature of gnome3 is working properly on mgag200. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/mgag200/mgag200_mode.c | 46 ++ 1 file changed, 46 insertions(+) diff --git a/drivers/gpu/dr

Re: [PATCH] drm/rockchip: vop2: unlock on error path in vop2_crtc_atomic_enable()

2022-05-09 Thread Sascha Hauer
On Mon, May 09, 2022 at 12:05:05PM +0300, Dan Carpenter wrote: > This error path needs an unlock before returning. Indeed. > > Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver") > Signed-off-by: Dan Carpenter Acked-by: Sascha Hauer Sascha > --- > drivers/gpu/drm/rockchip/rockchip_drm_vo

[PATCH 3/3] fixup! arm64: dts: rockchip: rk356x: Add VOP2 nodes

2022-05-09 Thread Sascha Hauer
Signed-off-by: Sascha Hauer --- arch/arm64/boot/dts/rockchip/rk356x.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi index 49eb45e23f8c9..646e60ee48c99 100644 --- a/arch/arm64/boot/dts/roc

[PATCH 2/3] fixup! drm: rockchip: Add VOP2 driver

2022-05-09 Thread Sascha Hauer
Signed-off-by: Sascha Hauer --- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c index 8d1323a47f822..d463ea80b6569 100644 --- a/drivers

[PATCH 1/3] fixup! dt-bindings: display: rockchip: Add binding for VOP2

2022-05-09 Thread Sascha Hauer
Signed-off-by: Sascha Hauer --- .../bindings/display/rockchip/rockchip-vop2.yaml | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchi

Re: [PATCH v12 0/3] drm/rockchip: RK356x VOP2 support last fixups

2022-05-09 Thread Sascha Hauer
On Mon, May 09, 2022 at 10:44:17AM +0200, Heiko Stübner wrote: > Hi Sascha, > > Am Montag, 9. Mai 2022, 10:37:35 CEST schrieb Sascha Hauer: > > This is not the full series, if you want that, look for v11. > > > > This series merely has a last-minute change: The VOP2 driver used > > platform_get_r

Re: [PATCH v12 0/3] drm/rockchip: RK356x VOP2 support last fixups

2022-05-09 Thread Heiko Stübner
Am Montag, 9. Mai 2022, 11:55:59 CEST schrieb Sascha Hauer: > On Mon, May 09, 2022 at 10:44:17AM +0200, Heiko Stübner wrote: > > Hi Sascha, > > > > Am Montag, 9. Mai 2022, 10:37:35 CEST schrieb Sascha Hauer: > > > This is not the full series, if you want that, look for v11. > > > > > > This serie

[PATCH 1/7] drm:/mgag200: Acquire I/O lock while reading EDID

2022-05-09 Thread Thomas Zimmermann
DDC operation conflicts with concurrent mode setting. Acquire the driver's I/O lock in get_modes to prevent this. This change should have been part of commit 931e3f3a0e99 ("drm/mgag200: Protect concurrent access to I/O registers with lock"), but apparently got lost somewhere. Signed-off-by: Thomas

[PATCH 3/7] drm/mgag200: Implement connector's get_modes with helper

2022-05-09 Thread Thomas Zimmermann
Provide drm_connector_helper_get_modes_from_ddc() to implement the connector's get_modes callback. The new helper updates the connector from DDC-provided EDID data. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_probe_helper.c | 33 ++ drivers/gpu/drm/mgag20

[PATCH 5/7] drm/mgag200: Remove struct mga_connector

2022-05-09 Thread Thomas Zimmermann
struct mga_connector has outlived its purpose. Inline the rsp init helper into the mode-config code and remove the data structure. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_drv.h | 8 + drivers/gpu/drm/mgag200/mgag200_mode.c | 44 --

[PATCH 0/7] drm/mgag200: Various cleanups

2022-05-09 Thread Thomas Zimmermann
Various small fixes and clean-up patches for mgag200. Tested on Matrix G200EH hardware. Thomas Zimmermann (7): drm:/mgag200: Acquire I/O lock while reading EDID drm/mgag200: Fail on I2C initialization errors drm/mgag200: Implement connector's get_modes with helper drm/mgag200: Switch I2C c

[PATCH 6/7] drm/mgag200: Test memory requirements in drm_mode_config_funcs.mode_valid

2022-05-09 Thread Thomas Zimmermann
Test for a mode's memory requirements in the device-wide mode_valid helper. For simplicify, always assume a 32-bit color format. While some rejected modes would work with less colors, implementing this is probably not worth the effort. Also remove the memory-related test from the connector's mode_

[PATCH 4/7] drm/mgag200: Switch I2C code to managed cleanup

2022-05-09 Thread Thomas Zimmermann
Store the I2C state within struct mga_device and switch I2C to managed release. Simplifies the related code and lets us remove mga_connector_destroy(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_drv.h | 5 ++-- drivers/gpu/drm/mgag200/mgag200_i2c.c | 33 +

[PATCH 7/7] drm/mgag200: Split up connector's mode_valid helper

2022-05-09 Thread Thomas Zimmermann
Split up the connector's mode_valid helper into a simple-pipe and a mode-config helper. The simple-pipe helper tests for display-size limits while the mode-config helper tests for memory-bandwidth limits. Also add the mgag200_ prefix to mga_vga_calculate_mode_bandwidth() and comment on the functio

[PATCH 2/7] drm/mgag200: Fail on I2C initialization errors

2022-05-09 Thread Thomas Zimmermann
Initialization of the I2C adapter was allowed to fail. The mgag200 driver would have continued without DDC support. Had this happened in practice, it would have led to segmentation faults in the connector code. Resolve this problem by failing driver initialization on I2C- related errors. v2:

Re: [PATCH v2 3/3] dt-bindings: mediatek: add ethdr definition for mt8195

2022-05-09 Thread Krzysztof Kozlowski
On 09/05/2022 10:54, Rex-BC Chen wrote: >>> +soc { >>> +#address-cells = <2>; >>> +#size-cells = <2>; >>> + >>> +disp_ethdr@1c114000 { >> >> No underscores in node name. Generic node names, so display- >> controller? >> > > OK, we will change the node name to ethdr like

Re: [PATCH 0/4] Remove support for Hyper-V 2008 and 2008R2/Win7

2022-05-09 Thread Wei Liu
On Sun, May 08, 2022 at 03:43:26PM +, Michael Kelley (LINUX) wrote: > From: Pavel Machek Sent: Wednesday, May 4, 2022 10:23 AM > > > > Hi! > > > > > Linux code for running as a Hyper-V guest includes special cases for the > > > first released versions of Hyper-V: 2008 and 2008R2/Windows 7. T

Re: [PATCH 1/2] drm/i915: Enable THP on Icelake and beyond

2022-05-09 Thread Matthew Auld
On 29/04/2022 11:04, Tvrtko Ursulin wrote: From: Tvrtko Ursulin We have a statement from HW designers that the GPU read regression when using 2M pages was fixed from Icelake onwards, which was also confirmed by bencharking Eero did last year: """ When IOMMU is disabled, enabling THP causes fol

Re: [PATCH v2 3/3] dt-bindings: mediatek: add ethdr definition for mt8195

2022-05-09 Thread AngeloGioacchino Del Regno
Il 09/05/22 12:44, Krzysztof Kozlowski ha scritto: On 09/05/2022 10:54, Rex-BC Chen wrote: +soc { +#address-cells = <2>; +#size-cells = <2>; + +disp_ethdr@1c114000 { No underscores in node name. Generic node names, so display- controller? OK, we will change the n

Re: 5.18 vmwgfx seems to break booting VirtualBox VMs

2022-05-09 Thread Hans de Goede
Hi Zack, On 4/11/22 16:24, Zack Rusin wrote: > On Mon, 2022-04-11 at 10:52 +0200, Hans de Goede wrote: >> Hi All, >> >> Fedora has received a bug report here: >> >> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.redhat.com%2Fshow_bug.cgi%3Fid%3D2072556&data=04%7C01%7Cza

[PATCH] drm/vmwgfx: Fix passing partly uninitialized drm_mode_fb_cmd2 struct

2022-05-09 Thread Hans de Goede
vmw_fb_kms_framebuffer() declares a drm_mode_fb_cmd2 struct on the stack without zero-ing it and then continues with initializing only some fields. This leads to drm_mode_fb_cmd2.modifiers[0] containing garbage, which eventually gets used by drm_helper_mode_fill_fb_struct() to set fb->modifier whe

[Bug 214853] [amdgpu] UBSAN shows several null-ptr-deref in ../dc/bios/command_table2.c some array-index-out-of-bounds in ../dc/bios/bios_parser2.c and an invalid-load in ../amdgpu_dm/amdgpu_dm.c

2022-05-09 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214853 --- Comment #2 from Erhard F. (erhar...@mailbox.org) --- Created attachment 300911 --> https://bugzilla.kernel.org/attachment.cgi?id=300911&action=edit kernel dmesg (kernel 5.18-rc6, AMD Ryzen 9 5950X) Same card in another machine, still tha sa

[Bug 214853] [amdgpu] UBSAN shows several null-ptr-deref in ../dc/bios/command_table2.c some array-index-out-of-bounds in ../dc/bios/bios_parser2.c and an invalid-load in ../amdgpu_dm/amdgpu_dm.c

2022-05-09 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214853 --- Comment #3 from Erhard F. (erhar...@mailbox.org) --- Created attachment 300912 --> https://bugzilla.kernel.org/attachment.cgi?id=300912&action=edit kernel .config (kernel 5.18-rc6, AMD Ryzen 9 5950X) -- You may reply to this email to add a

Re: [PATCH] drm/vmwgfx: Fix passing partly uninitialized drm_mode_fb_cmd2 struct

2022-05-09 Thread Javier Martinez Canillas
Hello Hans, On 5/9/22 13:04, Hans de Goede wrote: > vmw_fb_kms_framebuffer() declares a drm_mode_fb_cmd2 struct on the stack > without zero-ing it and then continues with initializing only some fields. > > This leads to drm_mode_fb_cmd2.modifiers[0] containing garbage, > which eventually gets use

Re: [PATCH] drm/vmwgfx: Fix passing partly uninitialized drm_mode_fb_cmd2 struct

2022-05-09 Thread Hans de Goede
Hi, On 5/9/22 13:52, Javier Martinez Canillas wrote: > Hello Hans, > > On 5/9/22 13:04, Hans de Goede wrote: >> vmw_fb_kms_framebuffer() declares a drm_mode_fb_cmd2 struct on the stack >> without zero-ing it and then continues with initializing only some fields. >> >> This leads to drm_mode_fb_cm

Re: [PATCH] drm/vmwgfx: Fix passing partly uninitialized drm_mode_fb_cmd2 struct

2022-05-09 Thread Javier Martinez Canillas
On 5/9/22 13:55, Hans de Goede wrote: [snip] >>> >>> Fixes: dabdcdc9822a ("drm/vmwgfx: Switch to mode_cmd2") >>> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=2072556 >>> Signed-off-by: Hans de Goede >>> --- >> >> Zack fixed this already: >> >> https://cgit.freedesktop.org/drm/drm-misc/co

[PATCH v2 00/25] drm/edid: introduce struct drm_edid

2022-05-09 Thread Jani Nikula
v2 of [1] with some NULL deref bugs and checkpatch/sparse warnings fixed. BR, Jani. [1] https://patchwork.freedesktop.org/series/103665/ Jani Nikula (25): drm/edid: use else-if in CTA extension parsing drm/edid: convert drm_for_each_detailed_block() to edid iter drm/edid: add struct drm_ed

[PATCH v2 01/25] drm/edid: use else-if in CTA extension parsing

2022-05-09 Thread Jani Nikula
Only one of the conditions can be true. Suggested-by: Ville Syrjälä Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c inde

[PATCH v2 02/25] drm/edid: convert drm_for_each_detailed_block() to edid iter

2022-05-09 Thread Jani Nikula
We have an iterator for this, use it. It does include the base block, but its tag is 0 and will be skipped. Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c

[PATCH v2 03/25] drm/edid: add struct drm_edid container

2022-05-09 Thread Jani Nikula
Introduce new opaque type struct drm_edid to encapsulate the EDID data and the size allocated for it. The contents will be private to drm_edid.c. There are a number of reasons for adding a container around struct edid: * struct edid is a raw blob pointer to data that usually originates outside

[PATCH v2 04/25] drm/edid: start propagating drm_edid to lower levels

2022-05-09 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. This is a clunky start, but a start nonetheless. We'll eventually convert all of the EDID parsing to struct drm_edid. Initially, we'll just create the struct drm_edid in stack. This will be the compat layer for legacy struct edid code. In the future, we

[PATCH v2 05/25] drm/edid: keep propagating drm_edid to display info

2022-05-09 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. v2: Use drm_edid_legacy_init() Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 48 +++--- 1 file changed, 29 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edi

[PATCH v2 06/25] drm/edid: propagate drm_edid to drm_edid_to_eld()

2022-05-09 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 96e3f9327044..e4fdf742645b 100644 --- a/

[PATCH v2 07/25] drm/edid: convert drm_edid_connector_update() to drm_edid fully

2022-05-09 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 95 ++ 1 file changed, 46 insertions(+), 49 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index e4fdf742645b..f5469942

[PATCH v2 09/25] drm/edid: convert drm_mode_detailed() to drm_edid

2022-05-09 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index c2887012add0..8acdb08a8571 100644 --- a/drivers/gpu/drm

[PATCH v2 10/25] drm/edid: convert drm_dmt_modes_for_range() to drm_edid

2022-05-09 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 8acdb08a8571..5d8744a7b62e 100644 --- a/drivers/gpu/

[PATCH v2 08/25] drm/edid: convert struct detailed_mode_closure to drm_edid

2022-05-09 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index f54699422bca..c2887012add0 100644

[PATCH v2 11/25] drm/edid: convert drm_gtf_modes_for_range() to drm_edid

2022-05-09 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 5d8744a7b62e..037102a4d0b5 100644 --- a/drivers/gpu/

[PATCH v2 12/25] drm/edid: convert drm_cvt_modes_for_range() to drm_edid

2022-05-09 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 037102a4d0b5..51d918c66a26 100644 --- a/drivers/gp

[PATCH v2 13/25] drm/edid: convert drm_mode_std() and children to drm_edid

2022-05-09 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 52 -- 1 file changed, 27 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 51d918c66a26..bea8f33c

[PATCH v2 14/25] drm/edid: convert mode_in_range() and drm_monitor_supports_rb() to drm_edid

2022-05-09 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index bea8f33c58ad..364949e146a9 100644

[PATCH v2 17/25] drm/edid: add drm_edid helper for drm_edid_to_sad()

2022-05-09 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. v2: Handle NULL EDID pointer (Ville, CI) Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 34 +- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/d

[PATCH v2 15/25] drm/edid: convert get_monitor_name() to drm_edid

2022-05-09 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. v2: Drop incorrect NULL name check (Dan Carpenter) Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/dr

[PATCH v2 16/25] drm/edid: convert drm_for_each_detailed_block() to drm_edid

2022-05-09 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. v2: Fix checkpatch warning on superfluous parens Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers

[PATCH v2 18/25] drm/edid: add drm_edid helper for drm_edid_to_speaker_allocation()

2022-05-09 Thread Jani Nikula
We'll need to propagate drm_edid everywhere.' v2: Handle NULL EDID pointer (Ville, CI) Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 37 +++-- 1 file changed, 23 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/d

Re: [PATCH v2 07/12] drm: bridge: samsung-dsim: Add module init, exit

2022-05-09 Thread Marek Szyprowski
On 04.05.2022 13:40, Jagan Teki wrote: > Add module init and exit functions for the bridge to register > and unregister dsi_driver. > > Exynos drm driver stack will register the platform_driver separately > in the common of it's exynos_drm_drv.c including dsi_driver. > > Register again would return

[PATCH v2 19/25] drm/edid: add drm_edid helper for drm_detect_hdmi_monitor()

2022-05-09 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. v2: Handle NULL EDID pointer (Ville, CI) Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 33 - 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/dr

[PATCH v2 20/25] drm/edid: add drm_edid helper for drm_detect_monitor_audio()

2022-05-09 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. v2: Handle NULL EDID pointer (Ville, CI) Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 37 ++--- 1 file changed, 22 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/dr

[PATCH v2 21/25] drm/edid: convert cea_db_iter_edid_begin() to drm_edid

2022-05-09 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. v2: Handle NULL drm_edid Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index f072cfba9dd9.

[PATCH v2 22/25] drm/edid: convert drm_edid_iter_begin() to drm_edid

2022-05-09 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. v2: Rebase Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index bd14010ed1c5..d857d1d74c82

[PATCH v2 23/25] drm/edid: add drm_edid helper for drm_update_tile_info()

2022-05-09 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. v2: Handle NULL EDID pointer (Ville, CI) Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index d857d

[PATCH v2 24/25] drm/displayid: convert to drm_edid

2022-05-09 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. v2: Rebase Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_displayid.c | 16 drivers/gpu/drm/drm_edid.c | 17 ++--- include/drm/drm_displayid.h | 6 +++--- include/drm/drm_edid.h | 6 -- 4 files

[PATCH v2 25/25] drm/edid: convert version_greater() to drm_edid

2022-05-09 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Also make version_greater() a function for type safety. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/

Re: [PATCH v2 3/3] dt-bindings: mediatek: add ethdr definition for mt8195

2022-05-09 Thread Rob Herring
On Mon, 09 May 2022 12:43:02 +0800, Rex-BC Chen wrote: > From: "Nancy.Lin" > > Add vdosys1 ETHDR definition. > > Signed-off-by: Nancy.Lin > Reviewed-by: Chun-Kuang Hu > Reviewed-by: AngeloGioacchino Del Regno > > --- > .../display/mediatek/mediatek,ethdr.yaml | 191 ++ >

Re: [PATCH v2 1/3] dt-bindings: mediatek: add vdosys1 RDMA definition for mt8195

2022-05-09 Thread Rob Herring
On Mon, 09 May 2022 12:43:00 +0800, Rex-BC Chen wrote: > From: "Nancy.Lin" > > Add vdosys1 RDMA definition. > > Signed-off-by: Nancy.Lin > Reviewed-by: AngeloGioacchino Del Regno > > --- > .../display/mediatek/mediatek,mdp-rdma.yaml | 94 +++ > 1 file changed, 94 insertions

Re: [PATCH v2 01/12] drm: bridge: Add Samsung DSIM bridge driver

2022-05-09 Thread Marek Szyprowski
On 04.05.2022 13:40, Jagan Teki wrote: > Samsung MIPI DSIM controller is common DSI IP that can be used in various > SoCs like Exynos, i.MX8M Mini/Nano. > > In order to access this DSI controller between various platform SoCs, > the ideal way to incorporate this in the drm stack is via the drm brid

Re: [PATCH 1/2] drm/i915: Enable THP on Icelake and beyond

2022-05-09 Thread Tvrtko Ursulin
On 09/05/2022 11:49, Matthew Auld wrote: On 29/04/2022 11:04, Tvrtko Ursulin wrote: From: Tvrtko Ursulin We have a statement from HW designers that the GPU read regression when using 2M pages was fixed from Icelake onwards, which was also confirmed by bencharking Eero did last year: """ Whe

[PATCH] drm/todo: Add entry for converting kselftests to kunit

2022-05-09 Thread Javier Martinez Canillas
Many of the kselftests in DRM can be converted to kunit tests instead, since that framework is more suitable for unit testing. Suggested-by: Maxime Ripard Signed-off-by: Javier Martinez Canillas --- Documentation/gpu/todo.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/Doc

Improve TTMs empty object handling

2022-05-09 Thread Christian König
Hi everyone, re-sending this because Daniel was requesting a background why this is useful. When TTM creates a buffer this object initially should not have any backing store and there no resource object associated with it. The same can happen when a driver requests that the backing store of an ob

[PATCH 01/11] drm/radeon: switch over to ttm_bo_init_reserved

2022-05-09 Thread Christian König
Use the new interface instead. Signed-off-by: Christian König --- drivers/gpu/drm/radeon/radeon_object.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c index 6c4a6802ca96..1d4

[PATCH 03/11] drm/vram-helper: switch over to ttm_bo_init_reserved

2022-05-09 Thread Christian König
Use the new interface instead. Signed-off-by: Christian König --- drivers/gpu/drm/drm_gem_vram_helper.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_helper.c index 123045b58fec..7449cbc2f925 1

[PATCH 02/11] drm/nouveau: switch over to ttm_bo_init_reserved

2022-05-09 Thread Christian König
Use the new interface instead. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_bo.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c index 05076e530e7d..858b9382036c 1006

[PATCH 04/11] drm/ttm: move default BO destructor into VMWGFX

2022-05-09 Thread Christian König
It's the only driver using this. Signed-off-by: Christian König --- drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c b/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c index 85a66014c2b6..c4f376d5e1d0 100644 --- a/drivers/gpu/drm/vmw

[PATCH 05/11] drm/ttm: drop ttm_bo_init

2022-05-09 Thread Christian König
Not used any more. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 26 - include/drm/ttm/ttm_bo_api.h | 44 2 files changed, 70 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index

[PATCH 07/11] drm/amdgpu: audit bo->resource usage

2022-05-09 Thread Christian König
Make sure we can at least move and release BOs without backing store. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgp

[PATCH 06/11] drm/ttm: rename and cleanup ttm_bo_init_reserved

2022-05-09 Thread Christian König
Rename ttm_bo_init_reserved to ttm_bo_init_validate since that better matches what the function is actually doing. Remove the unused size parameter, move the function's kerneldoc to the implementation and cleanup the whole error handling. Signed-off-by: Christian König --- drivers/gpu/drm/amd/a

[PATCH 10/11] drm/ttm: stop allocating dummy resources during BO creation

2022-05-09 Thread Christian König
That should not be necessary any more when drivers should at least be able to handle the move without a resource. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c

[PATCH 08/11] drm/nouveau: audit bo->resource usage

2022-05-09 Thread Christian König
Make sure we can at least move and release BOs without backing store. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_bo.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c index 6

[PATCH 09/11] drm/ttm: audit bo->resource usage

2022-05-09 Thread Christian König
Allow BOs to exist without backing store. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 2b01cb30694a..a55564c8b57c 100644 --- a

[PATCH 11/11] drm/ttm: stop allocating a dummy resource for pipelined gutting

2022-05-09 Thread Christian König
That should not be necessary any more when drivers should at least be able to handle a move without a resource. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo_util.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo_uti

Re: [PATCH] drm/nouveau: reorder nouveau_drm_device_fini

2022-05-09 Thread Mark Menzynski
I think there are no direct issues with initialization in the state how it is now. I suspect it's because "drm_kms_helper_poll_enable()" starts the first worker thread with a delay, which gives enough time to initialize required resources. I changed the initialization part to keep it consistent wit

Re: [PATCH v4 10/15] drm/shmem-helper: Take reservation lock instead of drm_gem_shmem locks

2022-05-09 Thread Daniel Vetter
On Fri, May 06, 2022 at 01:49:12AM +0300, Dmitry Osipenko wrote: > On 5/5/22 11:12, Daniel Vetter wrote: > > On Wed, May 04, 2022 at 06:56:09PM +0300, Dmitry Osipenko wrote: > >> On 5/4/22 11:21, Daniel Vetter wrote: > >> ... > > - Maybe also do what you suggest and keep a separate lock for thi

Re: [PATCH] drm/todo: Add entry for converting kselftests to kunit

2022-05-09 Thread Maxime Ripard
On Mon, May 09, 2022 at 03:08:46PM +0200, Javier Martinez Canillas wrote: > Many of the kselftests in DRM can be converted to kunit tests instead, > since that framework is more suitable for unit testing. > > Suggested-by: Maxime Ripard > Signed-off-by: Javier Martinez Canillas Acked-by: Maxime

Re: [PATCH v2 10/11] dt-bindings: display: convert Arm Mali-DP to DT schema

2022-05-09 Thread Andre Przywara
On Fri, 06 May 2022 17:39:53 -0500 Rob Herring wrote: > On Fri, 06 May 2022 15:05:32 +0100, Andre Przywara wrote: > > The Arm Mali Display Processor (DP) 5xx/6xx is a series of IP that scans > > out a framebuffer and hands the pixels over to a digital signal encoder. > > It supports multiple laye

Re: [PATCH v4 11/15] drm/shmem-helper: Add generic memory shrinker

2022-05-09 Thread Daniel Vetter
On Fri, May 06, 2022 at 03:10:43AM +0300, Dmitry Osipenko wrote: > On 5/5/22 11:34, Thomas Zimmermann wrote: > > Hi > > > > Am 18.04.22 um 00:37 schrieb Dmitry Osipenko: > >> Introduce a common DRM SHMEM shrinker. It allows to reduce code > >> duplication among DRM drivers that implement theirs ow

  1   2   >