Re: [PATCH v11 16/24] arm64: dts: rockchip: rk356x: Add VOP2 nodes

2022-05-06 Thread Sascha Hauer
On Thu, May 05, 2022 at 09:23:03AM +0200, Heiko Stübner wrote: > Am Donnerstag, 5. Mai 2022, 08:41:31 CEST schrieb Sascha Hauer: > > On Thu, May 05, 2022 at 02:28:24AM +0200, Heiko Stübner wrote: > > > Am Freitag, 22. April 2022, 09:28:33 CEST schrieb Sascha Hauer: > > > > The VOP2 is the display o

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Use non-blocking H2G for waitboost

2022-05-06 Thread Tvrtko Ursulin
On 05/05/2022 19:36, John Harrison wrote: On 5/5/2022 10:21, Belgaumkar, Vinay wrote: On 5/5/2022 5:13 AM, Tvrtko Ursulin wrote: On 05/05/2022 06:40, Vinay Belgaumkar wrote: SLPC min/max frequency updates require H2G calls. We are seeing timeouts when GuC channel is backed up and it is unabl

Re: [Intel-gfx] [PATCH 07/11] drm/i915/pvc: Engines definitions for new copy engines

2022-05-06 Thread Tvrtko Ursulin
On 05/05/2022 21:59, Matt Roper wrote: On Tue, May 03, 2022 at 09:05:43AM +0100, Tvrtko Ursulin wrote: On 02/05/2022 17:34, Matt Roper wrote: This patch adds the basic definitions needed to support new copy engines. Also updating the cmd_info to accommodate new engines, as the engine id's of

Re: [PATCH] drm/mgag200: Fail on I2C initialization errors

2022-05-06 Thread Dan Carpenter
Hi Thomas, url: https://github.com/intel-lab-lkp/linux/commits/Thomas-Zimmermann/drm-mgag200-Fail-on-I2C-initialization-errors/20220505-234643 base: git://anongit.freedesktop.org/drm/drm drm-next config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20220506/202205061008

Re: [PATCH v2] Revert "fbdev: Make fb_release() return -ENODEV if fbdev was unregistered"

2022-05-06 Thread Javier Martinez Canillas
On 5/4/22 13:59, Javier Martinez Canillas wrote: > This reverts commit aafa025c76dcc7d1a8c8f0bdefcbe4eb480b2f6a. That commit > attempted to fix a NULL pointer dereference, caused by the struct fb_info > associated with a framebuffer device to not longer be valid when the file > descriptor was close

Re: [PATCH v3 0/4] fbdev: Fix use-after-free caused by wrong fb_info cleanup in drivers

2022-05-06 Thread Javier Martinez Canillas
On 5/5/22 23:59, Javier Martinez Canillas wrote: > Hello, > > This series contains patches suggested by Daniel Vetter to fix a > use-after-free > error in the fb_release() function, due a fb_info associated with a fbdev > being > freed too early while a user-space process still has the fbdev dev

Re: [Intel-gfx] [PATCH v2] drm/i915/guc: Support programming the EU priority in the GuC descriptor

2022-05-06 Thread Tvrtko Ursulin
On 05/05/2022 19:56, John Harrison wrote: On 5/4/2022 16:46, Daniele Ceraolo Spurio wrote: From: Matthew Brost In GuC submission mode the EU priority must be updated by the GuC rather than the driver as the GuC owns the programming of the context descriptor. Given that the GuC code uses t

Re: [PATCH -next] drm/i915/gt: Fix build error without CONFIG_PM

2022-05-06 Thread Tvrtko Ursulin
On 06/05/2022 04:26, YueHaibing wrote: drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c: In function ‘act_freq_mhz_show’: drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c:276:20: error: implicit declaration of function ‘sysfs_gt_attribute_r_max_func’ [-Werror=implicit-function-declaration] 276 | u3

Re: [PATCH -next] drm/i915/gt: Fix build error without CONFIG_PM

2022-05-06 Thread Andi Shyti
Hi YueHaibing, On Fri, May 06, 2022 at 11:26:52AM +0800, YueHaibing wrote: > drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c: In function ‘act_freq_mhz_show’: > drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c:276:20: error: implicit > declaration of function ‘sysfs_gt_attribute_r_max_func’ > [-Werror=im

Re: [PATCH resend v8 1/5] drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_mode_set()

2022-05-06 Thread Guido Günther
Hi Liu, On Fri, Apr 29, 2022 at 08:30:43PM +0800, Liu Ying wrote: > Hi, > > On Fri, 2022-04-22 at 19:24 +0200, Guido Günther wrote: > > Hi, > > On Tue, Apr 19, 2022 at 09:08:48AM +0800, Liu Ying wrote: > > > The Northwest Logic MIPI DSI host controller embedded in i.MX8qxp > > > works with a Mixel

Re: [PATCH v11 16/24] arm64: dts: rockchip: rk356x: Add VOP2 nodes

2022-05-06 Thread Heiko Stuebner
Am Freitag, 6. Mai 2022, 09:10:28 CEST schrieb Sascha Hauer: > On Thu, May 05, 2022 at 09:23:03AM +0200, Heiko Stübner wrote: > > Am Donnerstag, 5. Mai 2022, 08:41:31 CEST schrieb Sascha Hauer: > > > On Thu, May 05, 2022 at 02:28:24AM +0200, Heiko Stübner wrote: > > > > Am Freitag, 22. April 2022,

Re: (EXT) Re: (EXT) [PATCH v2 00/12] drm: bridge: Add Samsung MIPI DSIM bridge

2022-05-06 Thread Marek Szyprowski
Hi Alexander, On 05.05.2022 13:55, Alexander Stein wrote: > Am Donnerstag, 5. Mai 2022, 09:38:48 CEST schrieb Jagan Teki: >> On Thu, May 5, 2022 at 12:57 PM Alexander Stein >> >> wrote: >>> Hello Jagan, >>> >>> thanks for the second version of this patchset. >>> >>> Am Mittwoch, 4. Mai 2022, 13:4

[PATCH 00/25] drm/edid: introduce struct drm_edid

2022-05-06 Thread Jani Nikula
Introduce struct drm_edid and start converting struct edid * to struct drm_edid * in the EDID parsing. The rationale for drm_edid is explained in depth in commit message for patch 3. Initially, there's little functional benefit in the series, it's mostly just prep work. It's also intended to be re

[PATCH 02/25] drm/edid: convert drm_for_each_detailed_block() to edid iter

2022-05-06 Thread Jani Nikula
We have an iterator for this, use it. It does include the base block, but its tag is 0 and will be skipped. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.

[PATCH 01/25] drm/edid: use else-if in CTA extension parsing

2022-05-06 Thread Jani Nikula
Only one of the conditions can be true. Suggested-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 47d121e99201..efc1999b9573

[PATCH 03/25] drm/edid: add struct drm_edid container

2022-05-06 Thread Jani Nikula
Introduce new opaque type struct drm_edid to encapsulate the EDID data and the size allocated for it. The contents will be private to drm_edid.c. There are a number of reasons for adding a container around struct edid: * struct edid is a raw blob pointer to data that usually originates outside

[PATCH 04/25] drm/edid: start propagating drm_edid to lower levels

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. This is a clunky start, but a start nonetheless. We'll eventually convert all of the EDID parsing to struct drm_edid. Initially, we'll just create the struct drm_edid in stack. This will be the compat layer for legacy struct edid code. In the future, we

[PATCH 05/25] drm/edid: keep propagating drm_edid to display info

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 50 +++--- 1 file changed, 31 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 946296632b2e..c9d48fbd

[PATCH 06/25] drm/edid: propagate drm_edid to drm_edid_to_eld()

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index c9d48fbd0a76..74038be72ad3 100644 --- a/

[PATCH 07/25] drm/edid: convert drm_edid_connector_update() to drm_edid fully

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 95 ++ 1 file changed, 46 insertions(+), 49 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 74038be72ad3..fdc6ad65

[PATCH 09/25] drm/edid: convert drm_mode_detailed() to drm_edid

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 1abdd88ff64b..b5d7347f32d9 100644 --- a/drivers/gpu/drm

[PATCH 08/25] drm/edid: convert struct detailed_mode_closure to drm_edid

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index fdc6ad651d3f..1abdd88ff64b 100644

[PATCH 10/25] drm/edid: convert drm_dmt_modes_for_range() to drm_edid

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index b5d7347f32d9..88bb6c7ac97c 100644 --- a/drivers/gpu/

[PATCH 11/25] drm/edid: convert drm_gtf_modes_for_range() to drm_edid

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 88bb6c7ac97c..3931c3318cf7 100644 --- a/drivers/gpu/

[PATCH 12/25] drm/edid: convert drm_cvt_modes_for_range() to drm_edid

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 3931c3318cf7..27655da6ef9c 100644 --- a/drivers/gp

[PATCH 13/25] drm/edid: convert drm_mode_std() and children to drm_edid

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 52 -- 1 file changed, 27 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 27655da6ef9c..4b2d3453

[PATCH 14/25] drm/edid: convert mode_in_range() and drm_monitor_supports_rb() to drm_edid

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 4b2d3453fc5c..b8deced8de01 100644

[PATCH 15/25] drm/edid: convert get_monitor_name() to drm_edid

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. v2: Drop incorrect NULL name check (Dan Carpenter) Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/dr

[PATCH 16/25] drm/edid: convert drm_for_each_detailed_block() to drm_edid

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 4fd2ee976d39..2017feecbe

[PATCH 17/25] drm/edid: add drm_edid helper for drm_edid_to_sad()

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 37 - 1 file changed, 24 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 2017feecbe1c..52ea18739

[PATCH 18/25] drm/edid: add drm_edid helper for drm_edid_to_speaker_allocation()

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 39 -- 1 file changed, 25 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 52ea187394dd..51aee048

[PATCH 19/25] drm/edid: add drm_edid helper for drm_detect_hdmi_monitor()

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 36 +++- 1 file changed, 23 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 51aee048bcff..3277b4fd33

[PATCH 20/25] drm/edid: add drm_edid helper for drm_detect_monitor_audio()

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 40 -- 1 file changed, 25 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 3277b4fd33ce..706552ae

[PATCH 21/25] drm/edid: convert cea_db_iter_edid_begin() to drm_edid

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 706552ae00ea..82a242a71ecf 100644 --- a

[PATCH 22/25] drm/edid: convert drm_edid_iter_begin() to drm_edid

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 82a242a71ecf..b453bbf2f642 100644 ---

[PATCH 23/25] drm/edid: add drm_edid helper for drm_update_tile_info()

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index b453bbf2f642..82db7afb4f8e 100644 --- a/driv

[PATCH 24/25] drm/displayid: convert to drm_edid

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_displayid.c | 16 drivers/gpu/drm/drm_edid.c | 17 ++--- include/drm/drm_displayid.h | 6 +++--- include/drm/drm_edid.h | 6 -- 4 files changed, 25

[PATCH 25/25] drm/edid: convert version_greater() to drm_edid

2022-05-06 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Also make version_greater() a function for type safety. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/

Re: [PATCH 05/25] drm/edid: keep propagating drm_edid to display info

2022-05-06 Thread Jani Nikula
On Fri, 06 May 2022, Jani Nikula wrote: > We'll need to propagate drm_edid everywhere. I seem to have copy-pasted a TAB in some of the commit messages, in a way that does not show up in git log. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_edid.c | 50 ++

[RFC PATCH 1/1] drm/vkms: Add basic support for ConfigFS to VKMS

2022-05-06 Thread Jim Shargo
This change adds boilerplate setup for ConfigFS, resulting in a config directory that looks like this (assuming it's mounted under /config/): /config `-- vkms |-- connectors | `-- 52 |-- crtcs | `-- 51 |-- encoders

Re: [PATCH 1/2] dma-buf: Add an API for exporting sync files (v13)

2022-05-06 Thread Jason Ekstrand
On Wed, May 4, 2022 at 5:49 PM Daniel Vetter wrote: > On Wed, May 04, 2022 at 03:34:03PM -0500, Jason Ekstrand wrote: > > Modern userspace APIs like Vulkan are built on an explicit > > synchronization model. This doesn't always play nicely with the > > implicit synchronization used in the kernel

[PATCH v5 2/4] drm/panel: simple: Add DataImage FG1001L0DSSWMG01 panel support

2022-05-06 Thread Philip Oberfichtner
Add DataImage FG1001L0DSSWMG01 10.1" 1280x800 TFT LCD panel support. Signed-off-by: Philip Oberfichtner --- Cc: Thierry Reding Cc: Sam Ravnborg Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: linux-ker...@vger.kernel.org Cc: matthias.win...@de.bosch.com --- Chan

Re: [PATCH 1/2] dma-buf: Add an API for exporting sync files (v13)

2022-05-06 Thread Jason Ekstrand
On Thu, May 5, 2022 at 1:25 AM Christian König wrote: > Am 04.05.22 um 22:34 schrieb Jason Ekstrand: > > Modern userspace APIs like Vulkan are built on an explicit > > synchronization model. This doesn't always play nicely with the > > implicit synchronization used in the kernel and assumed by X

[RFC PATCH 0/1] drm/vkms: ConfigFS support

2022-05-06 Thread Jim Shargo
Hi! I wanted to send this patch out early to get some feedback on the layout of the code and new ConfigFS directory. I intend to follow this up with a more complete patch set that uses this to, for instance, add more connectors and toggle feature support. A few questions I had as someone new to k

[PATCH v4 1/4] dt-bindings: display: simple: Add DataImage FG1001L0DSSWMG01 compatible string

2022-05-06 Thread Philip Oberfichtner
Add DataImage FG1001L0DSSWMG01 10.1" 1280x800 TFT LCD panel compatible string. Signed-off-by: Philip Oberfichtner Acked-by: Krzysztof Kozlowski --- Cc: Thierry Reding Cc: Sam Ravnborg Cc: David Airlie Cc: Daniel Vetter Cc: Rob Herring Cc: Krzysztof Kozlowski Cc: dri-devel@lists.freedeskt

[PATCH v4 2/4] drm/panel: simple: Add DataImage FG1001L0DSSWMG01 panel support

2022-05-06 Thread Philip Oberfichtner
Add DataImage FG1001L0DSSWMG01 10.1" 1280x800 TFT LCD panel support. Signed-off-by: Philip Oberfichtner --- Cc: Thierry Reding Cc: Sam Ravnborg Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: linux-ker...@vger.kernel.org Cc: matthias.win...@de.bosch.com --- Chan

Re: [PATCH 2/2] dma-buf: Add an API for importing sync files (v8)

2022-05-06 Thread Jason Ekstrand
On Wed, May 4, 2022 at 5:53 PM Daniel Vetter wrote: > On Wed, May 04, 2022 at 03:34:04PM -0500, Jason Ekstrand wrote: > > This patch is analogous to the previous sync file export patch in that > > it allows you to import a sync_file into a dma-buf. Unlike the previous > > patch, however, this do

Re: [PATCH 1/2] dma-buf: Add an API for exporting sync files (v13)

2022-05-06 Thread Jason Ekstrand
On Thu, May 5, 2022 at 3:23 AM Daniel Vetter wrote: > On Thu, May 05, 2022 at 03:05:44AM -0500, Jason Ekstrand wrote: > > On Wed, May 4, 2022 at 5:49 PM Daniel Vetter wrote: > > > > > On Wed, May 04, 2022 at 03:34:03PM -0500, Jason Ekstrand wrote: > > > > Modern userspace APIs like Vulkan are bu

[PATCH v5 1/4] dt-bindings: display: simple: Add DataImage FG1001L0DSSWMG01 compatible string

2022-05-06 Thread Philip Oberfichtner
Add DataImage FG1001L0DSSWMG01 10.1" 1280x800 TFT LCD panel compatible string. Signed-off-by: Philip Oberfichtner Acked-by: Krzysztof Kozlowski --- Cc: Thierry Reding Cc: Sam Ravnborg Cc: David Airlie Cc: Daniel Vetter Cc: Rob Herring Cc: Krzysztof Kozlowski Cc: dri-devel@lists.freedeskt

[BUG] Warning and NULL-ptr dereference in amdgpu driver with 5.18

2022-05-06 Thread Jörg Rödel
Hi, since recently I started to experience warnings and NULL-ptr dereferences in the amdgpu driver with kernel 5.18-rc5+. Earlier 5.18-based kernels might be affected as well, but I havn't seen this with 5.17. The kernel was built from the iommu-next branch, based on 5.18-rc5. The messages start

Re: (EXT) Re: (EXT) [PATCH v2 00/12] drm: bridge: Add Samsung MIPI DSIM bridge

2022-05-06 Thread Alexander Stein
Hi Marek, Am Freitag, 6. Mai 2022, 10:57:05 CEST schrieb Marek Szyprowski: > Hi Alexander, > > On 05.05.2022 13:55, Alexander Stein wrote: > > Am Donnerstag, 5. Mai 2022, 09:38:48 CEST schrieb Jagan Teki: > >> On Thu, May 5, 2022 at 12:57 PM Alexander Stein > >> > >> wrote: > >>> Hello Jagan, >

[PULL] drm-intel-next

2022-05-06 Thread Jani Nikula
Hi Dave & Daniel - drm-intel-next-2022-05-06: drm/i915 feature pull #2 for v5.19: Features and functionality: - Add first set of DG2 PCI IDs for "motherboard down" designs (Matt Roper) - Add initial RPL-P PCI IDs as ADL-P subplatform (Matt Atwood) Refactoring and cleanups: - Power well refacto

Re: (EXT) Re: (EXT) [PATCH v2 00/12] drm: bridge: Add Samsung MIPI DSIM bridge

2022-05-06 Thread Dave Stevenson
Hi Marek On Fri, 6 May 2022 at 09:57, Marek Szyprowski wrote: > > Hi Alexander, > > On 05.05.2022 13:55, Alexander Stein wrote: > > Am Donnerstag, 5. Mai 2022, 09:38:48 CEST schrieb Jagan Teki: > >> On Thu, May 5, 2022 at 12:57 PM Alexander Stein > >> > >> wrote: > >>> Hello Jagan, > >>> > >>> t

Re: [PATCH] drm/mgag200: Fail on I2C initialization errors

2022-05-06 Thread Thomas Zimmermann
Hi Am 05.05.22 um 17:49 schrieb Jocelyn Falempe: On 05/05/2022 17:22, Thomas Zimmermann wrote: Initialization of the I2C adapter was allowed to fail. The mgag200 driver would have continued without DDC support. Had this happened in practice, it would have led to segmentation faults in the conne

Re: (subset) [PATCH 1/2] [RFC] regmap: Add bulk read/write callbacks into regmap_config

2022-05-06 Thread Jani Nikula
On Thu, 05 May 2022, Mark Brown wrote: > On Sat, 30 Apr 2022 04:51:44 +0200, Marek Vasut wrote: >> Currently the regmap_config structure only allows the user to implement >> single element register read/write using .reg_read/.reg_write callbacks. >> The regmap_bus already implements bulk counterpa

Re: [RFC PATCH] drm/edid: drm_add_modes_noedid() should set lowest resolution as preferred

2022-05-06 Thread Jani Nikula
On Thu, 05 May 2022, Doug Anderson wrote: > Ville, > > On Tue, Apr 26, 2022 at 1:21 PM Douglas Anderson > wrote: >> >> If we're unable to read the EDID for a display because it's corrupt / >> bogus / invalid then we'll add a set of standard modes for the >> display. When userspace looks at these

Re: [PATCH v4 1/2] dt-bindings: display: bridge: ldb: Implement simple Freescale i.MX8MP LDB bridge

2022-05-06 Thread Robert Foss
> >> +description: | > >> + The i.MX8MP mediamix contains two registers which are responsible > >> + for configuring the on-SoC DPI-to-LVDS serializer. This describes > >> + those registers as bridge within the DT. > > > > This is a subblock of the mediamix? Please add 'reg' for the 2 registers

Re: [PATCH -next] drm/msm: Add missing OF dependency for DRM_MSM

2022-05-06 Thread Dmitry Baryshkov
On 06/05/2022 05:03, YueHaibing wrote: WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && OF [=n] Selected by [y]: - DRM_MSM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_QCOM || SOC_IMX5 || COMPILE_TEST [=y]) && COMMON_CLK [=y] &&

amdgpu sparse warnings (was: Re: ✗ Fi.CI.SPARSE: warning for drm/edid: introduce struct drm_edid)

2022-05-06 Thread Jani Nikula
Hey, do you ever run sparse on your driver? Whenever our CI ends up recompiling amdgpu, there's quite the spew. See below. You're not alone, but, sorry to say, the _Static_assert() from amdgv_sriovmsg.h has been pretty obnoxious for quite some time now. First, I don't think you should be using

Re: [Intel-gfx] [PATCH v7 6/7] drm/i915/gt: Create per-tile RPS sysfs interfaces

2022-05-06 Thread Jani Nikula
On Sat, 19 Mar 2022, Andi Shyti wrote: > +#define INTEL_GT_RPS_SYSFS_ATTR(_name, _mode, _show, _store) \ > + struct device_attribute dev_attr_gt_##_name = __ATTR(gt_##_name, _mode, > _show, _store); \ > + struct device_attribute dev_attr_rps_##_name = __ATTR(rps_##_name, > _mode, _show,

[PATCH 0/3] Introduce EBBG FT8719 DRM panel driver

2022-05-06 Thread Joel Selvaraj
Add bindings and DRM panel driver for EBBG FT8719 6.18" 2246x1080 DSI video mode panel, which can be found on some Xiaomi Poco F1 phones. The panel's backlight is managed through QCOM WLED driver. The driver is built using linux-mdss-dsi-panel-driver-generator[1], and additionally support for hand

[PATCH 1/3] dt-bindings: vendor-prefixes: Add prefix for EBBG

2022-05-06 Thread Joel Selvaraj
Add a prefix for EBBG. They manufacture displays which are used in some Xiaomi phones, but I could not find much details about the company. Signed-off-by: Joel Selvaraj --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/

[PATCH 2/3] dt-bindings: display: Add bindings for EBBG FT8719

2022-05-06 Thread Joel Selvaraj
Add bindings for the EBBG FT8719 6.18" 2246x1080 DSI video mode panel, which can be found on some Xiaomi Poco F1 phones. The backlight is managed through the QCOM WLED driver. Signed-off-by: Joel Selvaraj --- .../bindings/display/panel/ebbg,ft8719.yaml | 78 +++ 1 file changed,

[PATCH 3/3] drm/panel: introduce ebbg,ft8719 panel

2022-05-06 Thread Joel Selvaraj
Add DRM panel driver for EBBG FT8719 6.18" 2246x1080 DSI video mode panel, which can be found on some Xiaomi Poco F1 phones. The panel's backlight is managed through QCOM WLED driver. Signed-off-by: Joel Selvaraj --- MAINTAINERS | 7 + drivers/gpu/drm/panel/Kconfi

Re: [PATCH] dt-bindings: display: bridge: ldb: Fill in reg property

2022-05-06 Thread Robert Foss
On Wed, 4 May 2022 at 17:06, Rob Herring wrote: > > On Wed, 04 May 2022 03:26:01 +0200, Marek Vasut wrote: > > Add missing reg and reg-names properties for both 'LDB_CTRL' > > and 'LVDS_CTRL' registers. > > > > Fixes: 463db5c2ed4ae ("drm: bridge: ldb: Implement simple Freescale i.MX8MP > > LDB br

Re: (subset) [PATCH 1/2] [RFC] regmap: Add bulk read/write callbacks into regmap_config

2022-05-06 Thread Mark Brown
On Fri, May 06, 2022 at 01:58:18PM +0300, Jani Nikula wrote: > Hey Mark, sorry for hijacking the thread a bit. regmap.h seems to have > comprehensive API documentation, but there's very little in terms of > higher level documentation that I could find. Is there any? Not outside of the source. I

Re: (subset) [PATCH 1/2] [RFC] regmap: Add bulk read/write callbacks into regmap_config

2022-05-06 Thread Mark Brown
On Fri, May 06, 2022 at 01:55:57AM +0200, Marek Vasut wrote: > On 5/5/22 23:08, Mark Brown wrote: > > I did go through it and didn't spot > > any issues so it seemed like the testing coverage would be useful here. > > Are there specific things you're worried about that you'd like feedback > > on?

Re: [PATCH v2 -next] drm/display: Fix build error without CONFIG_OF

2022-05-06 Thread Dmitry Baryshkov
On 06/05/2022 15:32, YueHaibing wrote: While CONFIG_OF is n but COMPILE_TEST is y, we got this: WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && OF [=n] Selected by [y]: - DRM_MSM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_QCO

Re: [PATCH v3 3/4] fbdev: efifb: Cleanup fb_info in .fb_destroy rather than .remove

2022-05-06 Thread Andrzej Hajda
On 06.05.2022 00:05, Javier Martinez Canillas wrote: The driver is calling framebuffer_release() in its .remove callback, but this will cause the struct fb_info to be freed too early. Since it could be that a reference is still hold to it if user-space opened the fbdev. This would lead to a use-

Re: [BUG] Warning and NULL-ptr dereference in amdgpu driver with 5.18

2022-05-06 Thread Alex Deucher
+ some display folks On Fri, May 6, 2022 at 6:19 AM Jörg Rödel wrote: > > Hi, > > since recently I started to experience warnings and NULL-ptr > dereferences in the amdgpu driver with kernel 5.18-rc5+. Earlier > 5.18-based kernels might be affected as well, but I havn't seen this > with 5.17. > >

Re: [PATCH v3 3/4] fbdev: efifb: Cleanup fb_info in .fb_destroy rather than .remove

2022-05-06 Thread Javier Martinez Canillas
Hello Andrzej, On 5/6/22 15:07, Andrzej Hajda wrote: > On 06.05.2022 00:05, Javier Martinez Canillas wrote: [snip] >> + >> +framebuffer_release(info); >> + >> if (request_mem_succeeded) >> release_mem_region(info->apertures->ranges[0].base, >>

[PATCH] fbdev: efifb: Fix a use-after-free due early fb_info cleanup

2022-05-06 Thread Javier Martinez Canillas
Commit d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather than .remove") attempted to fix a use-after-free error due driver freeing the fb_info in the .remove handler instead of doing it in .fb_destroy. But ironically that change introduced yet another use-after-free since the fb_i

RE: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings

2022-05-06 Thread Sankeerth Billakanti (QUIC)
>> >> Our internal power grid documents list the regulators as >> >> VDD_A_*_1P2 and VDD_A_*_0P9 for all the platforms. >> > >> >Do your internal power grid documents indicate what these supplies >> >are powering? The question is if these supplies power any of the >> >logic inside the eDP controlle

Re: [PATCH] fbdev: efifb: Fix a use-after-free due early fb_info cleanup

2022-05-06 Thread Thomas Zimmermann
Am 06.05.22 um 15:22 schrieb Javier Martinez Canillas: Commit d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather than .remove") attempted to fix a use-after-free error due driver freeing the fb_info in the .remove handler instead of doing it in .fb_destroy. But ironically that c

[PATCH] drm/tegra: gem: Do not try to dereference ERR_PTR()

2022-05-06 Thread Thierry Reding
From: Thierry Reding When mapping the DMA-BUF attachment fails, map->sgt will be an ERR_PTR- encoded error code and the cleanup code would try to free that memory, which obviously would fail. Zero out that pointer after extracting the error code when this happens so that kfree() can do the right

Re: [PATCH v3 4/5] drm/gud: Map framebuffer BOs with drm_gem_fb_vmap()

2022-05-06 Thread Noralf Trønnes
Hi Thomas, I'm getting this on Ubuntu 22.04: [0.00] Linux version 5.15.0-27-generic (buildd@ubuntu) (gcc (Ubuntu 11.2.0-19ubuntu1) 11.2.0, GNU ld (GNU Binutils for Ubuntu) 2.38) #28-Ubuntu SMP Thu Apr 14 04:55:28 UTC 2022 (Ubuntu 5.15.0-27.28-generic 5.15.30) [4.830866] usb 2-3.1: ne

[PATCH v2 08/11] dt-bindings: display: convert PL110/PL111 to DT schema

2022-05-06 Thread Andre Przywara
The Arm PL110 and PL111 are IP blocks that provide a display engine with an LCD interface, being able to drive a variety of LC panels. Convert the binding over to DT schema, to the DTs can be automatically checked. This still contains the deprecated "arm,pl11x,tft-r0g0b0-pads" property, because th

[PATCH v2 09/11] dt-bindings: display: convert Arm HDLCD to DT schema

2022-05-06 Thread Andre Przywara
The Arm HDLCD is a display controller that scans out a framebuffer and hands a signal to a digital encoder to generate a DVI or HDMI signal. Convert the existing DT binding to DT schema. Signed-off-by: Andre Przywara --- .../devicetree/bindings/display/arm,hdlcd.txt | 79 .../b

[PATCH v2 11/11] dt-bindings: display: convert Arm Komeda to DT schema

2022-05-06 Thread Andre Przywara
The Arm Komeda (aka Mali-D71) is a display controller that scans out a framebuffer and hands a signal to a digital encoder to generate a DVI or HDMI signal. It supports up to two pipelines, each frame can be composed of up to four layers. Convert the existing DT binding to DT schema. Signed-off-b

[PATCH v2 10/11] dt-bindings: display: convert Arm Mali-DP to DT schema

2022-05-06 Thread Andre Przywara
The Arm Mali Display Processor (DP) 5xx/6xx is a series of IP that scans out a framebuffer and hands the pixels over to a digital signal encoder. It supports multiple layers, scaling and rotation. Convert the existing DT binding to DT schema. Signed-off-by: Andre Przywara --- .../bindings/displ

[PATCH 1/5] dma-buf: cleanup dma_fence_unwrap selftest v2

2022-05-06 Thread Christian König
The selftests, fix the error handling, remove unused functions and stop leaking memory in failed tests. v2: fix the memory leak correctly. Signed-off-by: Christian König --- drivers/dma-buf/st-dma-fence-unwrap.c | 48 +++ 1 file changed, 19 insertions(+), 29 deletions(-)

[PATCH 2/5] dma-buf: cleanup dma_fence_unwrap implementation

2022-05-06 Thread Christian König
Move the code from the inline functions into exported functions. Signed-off-by: Christian König Acked-by: Daniel Vetter --- drivers/dma-buf/Makefile | 2 +- drivers/dma-buf/dma-fence-unwrap.c | 59 ++ include/linux/dma-fence-unwrap.h | 52 ++-

[PATCH 4/5] dma-buf: generalize dma_fence unwrap & merging v2

2022-05-06 Thread Christian König
Introduce a dma_fence_unwrap_merge() macro which allows to unwrap fences which potentially can be containers as well and then merge them back together into a flat dma_fence_array. v2: rename the function, add some more comments about how the wrapper is used, move filtering of signaled fences i

[PATCH 3/5] dma-buf: return only unsignaled fences in dma_fence_unwrap_for_each v3

2022-05-06 Thread Christian König
dma_fence_chain containers cleanup signaled fences automatically, so filter those out from arrays as well. v2: fix missing walk over the array v3: massively simplify the patch and actually update the description. Signed-off-by: Christian König --- include/linux/dma-fence-unwrap.h | 6 +- 1

[PATCH 5/5] drm: use dma_fence_unwrap_merge() in drm_syncobj

2022-05-06 Thread Christian König
The unwrap merge function is now intended for this use case. Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/gpu/drm/drm_syncobj.c | 57 +-- 1 file changed, 7 insertions(+), 50 deletions(-) diff --git a/drivers/gpu/drm/drm_syncobj.c b/drive

Re: [PATCH 1/5] dma-buf: cleanup dma_fence_unwrap selftest v2

2022-05-06 Thread Christian König
I had to send this out once more. This time with the right mail addresses and a much simplified patch #3. Christian. Am 06.05.22 um 16:10 schrieb Christian König: The selftests, fix the error handling, remove unused functions and stop leaking memory in failed tests. v2: fix the memory leak co

Re: [PATCH v3 4/5] drm/gud: Map framebuffer BOs with drm_gem_fb_vmap()

2022-05-06 Thread Thomas Zimmermann
Hi Am 06.05.22 um 16:01 schrieb Noralf Trønnes: Hi Thomas, I'm getting this on Ubuntu 22.04: [0.00] Linux version 5.15.0-27-generic (buildd@ubuntu) (gcc (Ubuntu 11.2.0-19ubuntu1) 11.2.0, GNU ld (GNU Binutils for Ubuntu) 2.38) #28-Ubuntu SMP Thu Apr 14 04:55:28 UTC 2022 (Ubuntu 5.15.0-2

Re: [Intel-gfx] [PATCH 07/11] drm/i915/pvc: Engines definitions for new copy engines

2022-05-06 Thread Matt Roper
On Fri, May 06, 2022 at 08:21:46AM +0100, Tvrtko Ursulin wrote: > > On 05/05/2022 21:59, Matt Roper wrote: > > On Tue, May 03, 2022 at 09:05:43AM +0100, Tvrtko Ursulin wrote: > > > > > > On 02/05/2022 17:34, Matt Roper wrote: > > > > This patch adds the basic definitions needed to support > > > >

Re: [Intel-gfx] [PATCH v7 6/7] drm/i915/gt: Create per-tile RPS sysfs interfaces

2022-05-06 Thread Andi Shyti
Hi Jani, On Fri, May 06, 2022 at 02:53:50PM +0300, Jani Nikula wrote: > On Sat, 19 Mar 2022, Andi Shyti wrote: > > +#define INTEL_GT_RPS_SYSFS_ATTR(_name, _mode, _show, _store) \ > > + struct device_attribute dev_attr_gt_##_name = __ATTR(gt_##_name, _mode, > > _show, _store); \ > > + struct

Re: [Intel-gfx] [PATCH v2] drm/i915/guc: Support programming the EU priority in the GuC descriptor

2022-05-06 Thread Ceraolo Spurio, Daniele
On 5/6/2022 12:51 AM, Tvrtko Ursulin wrote: On 05/05/2022 19:56, John Harrison wrote: On 5/4/2022 16:46, Daniele Ceraolo Spurio wrote: From: Matthew Brost In GuC submission mode the EU priority must be updated by the GuC rather than the driver as the GuC owns the programming of the conte

Re: [Intel-gfx] [PATCH] fbdev: efifb: Fix a use-after-free due early fb_info cleanup

2022-05-06 Thread Andi Shyti
Hi Javier, On Fri, May 06, 2022 at 03:22:25PM +0200, Javier Martinez Canillas wrote: > Commit d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather > than .remove") attempted to fix a use-after-free error due driver freeing > the fb_info in the .remove handler instead of doing it in .

Re: [PATCH v2 -next] drm/display: Fix build error without CONFIG_OF

2022-05-06 Thread Abhinav Kumar
On 5/6/2022 5:32 AM, YueHaibing wrote: While CONFIG_OF is n but COMPILE_TEST is y, we got this: WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && OF [=n] Selected by [y]: - DRM_MSM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_

Re: [PATCH -next 2/2] drm/amdkfd: Return true/false (not 1/0) from bool functions

2022-05-06 Thread Alex Deucher
Series is: Reviewed-by: Alex Deucher On Thu, May 5, 2022 at 7:28 PM Yang Li wrote: > > Return boolean values ("true" or "false") instead of 1 or 0 from bool > functions. This fixes the following warnings from coccicheck: > > ./drivers/gpu/drm/amd/amdkfd/kfd_int_process_v11.c:244:9-10: WARNING: >

Re: [PATCH -next 2/2] drm/amdkfd: Return true/false (not 1/0) from bool functions

2022-05-06 Thread Alex Deucher
Applied. Thanks! On Fri, May 6, 2022 at 12:04 PM Alex Deucher wrote: > > Series is: > Reviewed-by: Alex Deucher > > On Thu, May 5, 2022 at 7:28 PM Yang Li wrote: > > > > Return boolean values ("true" or "false") instead of 1 or 0 from bool > > functions. This fixes the following warnings from

Re: [PATCH] drm/amdkfd: Return true/false (not 1/0) from bool functions

2022-05-06 Thread Alex Deucher
On Thu, May 5, 2022 at 10:05 PM Haowen Bai wrote: > > Return boolean values ("true" or "false") instead of 1 or 0 from bool > functions. > > Signed-off-by: Haowen Bai Thanks, I just applied the same fix from someone else. Alex > --- > drivers/gpu/drm/amd/amdkfd/kfd_int_process_v11.c | 6 +++--

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Use non-blocking H2G for waitboost

2022-05-06 Thread Belgaumkar, Vinay
On 5/6/2022 12:18 AM, Tvrtko Ursulin wrote: On 05/05/2022 19:36, John Harrison wrote: On 5/5/2022 10:21, Belgaumkar, Vinay wrote: On 5/5/2022 5:13 AM, Tvrtko Ursulin wrote: On 05/05/2022 06:40, Vinay Belgaumkar wrote: SLPC min/max frequency updates require H2G calls. We are seeing timeouts

Re: [RFC PATCH] drm/edid: drm_add_modes_noedid() should set lowest resolution as preferred

2022-05-06 Thread Abhinav Kumar
Hi Jani On 5/6/2022 4:16 AM, Jani Nikula wrote: On Thu, 05 May 2022, Doug Anderson wrote: Ville, On Tue, Apr 26, 2022 at 1:21 PM Douglas Anderson wrote: If we're unable to read the EDID for a display because it's corrupt / bogus / invalid then we'll add a set of standard modes for the disp

[GIT PULL] drm/tegra: Changes for v5.19-rc1

2022-05-06 Thread Thierry Reding
Hi Dave, Daniel, The following changes since commit 3123109284176b1532874591f7c81f3837bbdc17: Linux 5.18-rc1 (2022-04-03 14:08:21 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/drm/tegra.git tags/drm/tegra/for-5.19-rc1 for you to fetch changes up to cb7e1abc2

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Use non-blocking H2G for waitboost

2022-05-06 Thread John Harrison
On 5/6/2022 00:18, Tvrtko Ursulin wrote: On 05/05/2022 19:36, John Harrison wrote: On 5/5/2022 10:21, Belgaumkar, Vinay wrote: On 5/5/2022 5:13 AM, Tvrtko Ursulin wrote: On 05/05/2022 06:40, Vinay Belgaumkar wrote: SLPC min/max frequency updates require H2G calls. We are seeing timeouts when

drm pull request (was Re: )

2022-05-06 Thread Linus Torvalds
On Thu, May 5, 2022 at 9:07 PM Dave Airlie wrote: > > pretty quiet week, one fbdev, msm, kconfig, and 2 amdgpu fixes, about > what I'd expect for rc6. You're not getting the automated pr-tracker-bot response, because your subject line was missing... Just a "how did that happen" together with a "

  1   2   >