Re: [PATCH 3/4] mgag200: remove unused flag

2022-05-04 Thread Thomas Zimmermann
Hi Am 26.04.22 um 18:41 schrieb Jocelyn Falempe: The flag MGAG200_FLAG_HW_BUG_NO_STARTADD is no more used, because the framebuffer is now always at offset 0. Oh, well. I remember that thing. It took us a long time to find and fix this problem. Back then, mgag200 still used VRAM helpers, which

Re: [PATCH 2/2] fbdev: Make fb_release() return -ENODEV if fbdev was unregistered

2022-05-04 Thread Daniel Vetter
On Wed, May 04, 2022 at 12:09:57PM +0200, Javier Martinez Canillas wrote: > Hello Daniel, > > On 5/4/22 11:47, Daniel Vetter wrote: > > On Mon, May 02, 2022 at 03:09:44PM +0200, Javier Martinez Canillas wrote: > >> A reference to the framebuffer device struct fb_info is stored in the file > >> pri

Re: [PATCH] dt-bindings: Drop redundant 'maxItems/minItems' in if/then schemas

2022-05-04 Thread Ulf Hansson
On Tue, 3 May 2022 at 18:27, Rob Herring wrote: > > Another round of removing redundant minItems/maxItems when 'items' list is > specified. This time it is in if/then schemas as the meta-schema was > failing to check this case. > > If a property has an 'items' list, then a 'minItems' or 'maxItems'

Re: [PATCH 4/4] mgag200: remove mgag200_probe_vram()

2022-05-04 Thread Thomas Zimmermann
Hi Am 26.04.22 um 18:41 schrieb Jocelyn Falempe: This function writes some pattern to video memory, to check for conflict. In case of conflicts, it returns a random memory capacity (offset of the conflict). Using devm_arch_io_reserve_memtype_wc() should garantee that no other driver is using thi

Re: [PATCH v2 1/2] drm/dp: Add callbacks to make using DP AUX bus properly easier

2022-05-04 Thread Dmitry Baryshkov
On 04/05/2022 01:40, Douglas Anderson wrote: As talked about in this patch in the kerneldoc of of_dp_aux_populate_ep_device() and also in the past in commit a1e3667a9835 ("drm/bridge: ti-sn65dsi86: Promote the AUX channel to its own sub-dev"), it can be difficult for eDP controller drivers to kno

[PATCH] Revert "fbdev: Make fb_release() return -ENODEV if fbdev was unregistered"

2022-05-04 Thread Javier Martinez Canillas
This reverts commit aafa025c76dcc7d1a8c8f0bdefcbe4eb480b2f6a. That commit attempted to fix a NULL pointer dereference, caused by the struct fb_info associated with a framebuffer device to not longer be valid when the file descriptor was closed. But the solution was wrong since it was just papering

Re: [PATCH v2] fbdev: Use helper to get fb_info in all file operations

2022-05-04 Thread Daniel Vetter
On Wed, May 04, 2022 at 11:28:07AM +0200, Javier Martinez Canillas wrote: > Hello Daniel, > > On 5/4/22 11:02, Daniel Vetter wrote: > > On Tue, May 03, 2022 at 10:19:34PM +0200, Javier Martinez Canillas wrote: > >> A reference to the framebuffer device struct fb_info is stored in the file > >> pri

Re: [PATCH v3 3/3] drm: Allow simpledrm to setup its emulated FB as firmware provided

2022-05-04 Thread Daniel Vetter
On Tue, May 03, 2022 at 09:15:40AM +0200, Javier Martinez Canillas wrote: > Indicate to fbdev subsystem that the registered framebuffer is provided by > the system firmware, so that it can handle accordingly. For example, would > unregister the FB devices if asked to remove the conflicting framebuf

Re: [PATCH v2] drm/etnaviv: avoid cleaning up sched_job when submit succeeded

2022-05-04 Thread Daniel Vetter
On Wed, May 04, 2022 at 11:02:29AM +0200, Lucas Stach wrote: > While the labels may mislead the casual reader, the tail of the function > etnaviv_ioctl_gem_submit is always executed, as a lot of the structures > set up in this function need to be cleaned up regardless of whether the > submit succee

Re: [PATCH] Revert "fbdev: Make fb_release() return -ENODEV if fbdev was unregistered"

2022-05-04 Thread Daniel Vetter
On Wed, May 04, 2022 at 12:51:40PM +0200, Javier Martinez Canillas wrote: > This reverts commit aafa025c76dcc7d1a8c8f0bdefcbe4eb480b2f6a. That commit > attempted to fix a NULL pointer dereference, caused by the struct fb_info > associated with a framebuffer device to not longer be valid when the fi

Re: [PATCH v2] fbdev: Use helper to get fb_info in all file operations

2022-05-04 Thread Thomas Zimmermann
Hi Am 04.05.22 um 12:55 schrieb Daniel Vetter: On Wed, May 04, 2022 at 11:28:07AM +0200, Javier Martinez Canillas wrote: Hello Daniel, On 5/4/22 11:02, Daniel Vetter wrote: On Tue, May 03, 2022 at 10:19:34PM +0200, Javier Martinez Canillas wrote: A reference to the framebuffer device struct

Re: [PATCH v3 3/3] drm: Allow simpledrm to setup its emulated FB as firmware provided

2022-05-04 Thread Javier Martinez Canillas
On 5/4/22 12:58, Daniel Vetter wrote: > On Tue, May 03, 2022 at 09:15:40AM +0200, Javier Martinez Canillas wrote: >> Indicate to fbdev subsystem that the registered framebuffer is provided by >> the system firmware, so that it can handle accordingly. For example, would >> unregister the FB devices

Re: [PATCH RFC v6 16/21] dept: Distinguish each work from another

2022-05-04 Thread Sergey Shtylyov
Hello! On 5/4/22 11:17 AM, Byungchul Park wrote: > Workqueue already provides concurrency control. By that, any wait in a > work doesn't prevents events in other works with the control enabled. > Thus, each work would better be considered a different context. > > So let Dept assign a different c

Re: [PATCH v2] fbdev: Use helper to get fb_info in all file operations

2022-05-04 Thread Javier Martinez Canillas
Hello Thomas, On 5/4/22 13:08, Thomas Zimmermann wrote: [snip] >>> So something similar to fb_file_fb_info() is needed to check if >>> the vm_private_data is still valid. I guess that could be done >>> by using the vmf->vma->vm_file and attempting the same trick that >>> fb_file_fb_info() does ?

[PATCH v2 00/12] drm: bridge: Add Samsung MIPI DSIM bridge

2022-05-04 Thread Jagan Teki
This series supports common bridge support for Samsung MIPI DSIM which is used in Exynos and i.MX8MM SoC's. Previous v1 can be available here [1]. The final bridge supports both the Exynos and i.MX8MM DSI devices. On, summary this patch-set break the entire DSIM driver into - platform specific g

[PATCH v2 01/12] drm: bridge: Add Samsung DSIM bridge driver

2022-05-04 Thread Jagan Teki
Samsung MIPI DSIM controller is common DSI IP that can be used in various SoCs like Exynos, i.MX8M Mini/Nano. In order to access this DSI controller between various platform SoCs, the ideal way to incorporate this in the drm stack is via the drm bridge driver. This patch is trying to differentiat

[PATCH v2 02/12] drm: bridge: samsung-dsim: Lookup OF-graph or Child node devices

2022-05-04 Thread Jagan Teki
The child devices in MIPI DSI can be binding with OF-graph and also via child nodes. The OF-graph interface represents the child devices via remote and associated endpoint numbers like dsi { compatible = "fsl,imx8mm-mipi-dsim"; ports { port@0 { reg = <0>;

[PATCH v2 03/12] drm: bridge: samsung-dsim: Handle platform init via driver_data

2022-05-04 Thread Jagan Teki
In order to make a common Samsung DSIM bridge driver some platform specific glue code needs to maintain separately as it is hard to maintain platform specific glue and conventional component_ops on the drm bridge drivers side. This patch is trying to support that glue code initialization in the fo

[PATCH v2 04/12] drm: bridge: samsung-dsim: Mark PHY as optional

2022-05-04 Thread Jagan Teki
In i.MX8M Mini/Nano SoC the DSI Phy requires a MIPI DPHY bit to reset in order to activate the PHY and that can be done via upstream i.MX8M blk-ctrl driver. So, mark the phy get as optional. v2: * none v1: * new patch Signed-off-by: Jagan Teki --- drivers/gpu/drm/bridge/samsung-dsim.c | 2 +-

[PATCH v2 05/12] drm: bridge: samsung-dsim: Add DSI init in bridge pre_enable()

2022-05-04 Thread Jagan Teki
Host transfer() in DSI master will invoke only when the DSI commands are sent from DSI devices like DSI Panel or DSI bridges and this host transfer wouldn't invoke for I2C-based-DSI bridge drivers. Handling DSI host initialization in transfer calls misses the controller setup for I2C configured DS

[PATCH v2 06/12] drm: bridge: samsung-dsim: Fix PLL_P (PMS_P) offset

2022-05-04 Thread Jagan Teki
The i.MX 8M Mini Applications Processor Reference Manual, Rev. 3, 11/2020 with 13.7.10.1 Master PLL PMS Value setting Register mentioned PMS_P offset range from BIT[18-13] and the upstream driver is using the same offset. However, offset 13 is not working on i.MX8M Mini platforms but downstream NX

[PATCH v2 07/12] drm: bridge: samsung-dsim: Add module init, exit

2022-05-04 Thread Jagan Teki
Add module init and exit functions for the bridge to register and unregister dsi_driver. Exynos drm driver stack will register the platform_driver separately in the common of it's exynos_drm_drv.c including dsi_driver. Register again would return -EBUSY, so return 0 for such cases as dsi_driver i

[PATCH v2 08/12] drm: bridge: samsung-dsim: Add atomic_check

2022-05-04 Thread Jagan Teki
Fixing up the mode flags is required in order to correlate the correct sync flags of the surrounding components in the chain to make sure the whole pipeline can work properly. So, handle the mode flags via bridge, atomic_check. v2: * none v1: * fix mode flags in atomic_check instead of mode_fixu

[PATCH v2 09/12] drm: bridge: samsung-dsim: Add atomic_get_input_bus_fmts

2022-05-04 Thread Jagan Teki
Finding the right input bus format throughout the pipeline is hard so add atomic_get_input_bus_fmts callback and initialize with the default RGB888_1X24 bus format on DSI-end. This format can be used in pipeline for negotiating bus format between the DSI-end of this bridge and the other component

[PATCH v2 10/12] drm: bridge: samsung-dsim: Add input_bus_flags

2022-05-04 Thread Jagan Teki
eLCDIF is expecting to have input_bus_flags as DE_LOW in order to set active low during valid data transfer on each horizontal line. Add DE_LOW flag via drm bridge timings. v2: * none v1: * none Signed-off-by: Jagan Teki --- drivers/gpu/drm/bridge/samsung-dsim.c | 5 + 1 file changed, 5 i

[PATCH v2 11/12] dt-bindings: display: exynos: dsim: Add NXP i.MX8MM support

2022-05-04 Thread Jagan Teki
Samsung MIPI DSIM bridge can also be found in i.MX8MM SoC. Add dt-bingings for it. v2: * updated comments v1: * new patch Cc: devicet...@vger.kernel.org, Cc: Rob Herring Signed-off-by: Jagan Teki --- Note: I will send separate series for updating to yaml as the existing binding is old that it

[PATCH v2 12/12] drm: bridge: samsung-dsim: Add i.MX8MM support

2022-05-04 Thread Jagan Teki
Samsung MIPI DSIM master can also be found in i.MX8MM SoC. Add compatible and associated driver_data for it. v2: * collect Laurent r-b v1: * none Reviewed-by: Laurent Pinchart Signed-off-by: Jagan Teki --- drivers/gpu/drm/bridge/samsung-dsim.c | 34 +++ 1 file changed

Re: [PATCH v2] drm/tegra: Stop using iommu_present()

2022-05-04 Thread Robin Murphy
On 2022-05-04 01:52, Dmitry Osipenko wrote: On 4/11/22 16:46, Robin Murphy wrote: @@ -1092,6 +1092,19 @@ static bool host1x_drm_wants_iommu(struct host1x_device *dev) struct host1x *host1x = dev_get_drvdata(dev->dev.parent); struct iommu_domain *domain; + /* For starters, thi

Re: [PATCH 2/4] mgag200: Optimize damage clips

2022-05-04 Thread Jocelyn Falempe
On 04/05/2022 12:04, Thomas Zimmermann wrote: Hi Am 26.04.22 um 18:41 schrieb Jocelyn Falempe: when there are multiple damage clips, previous code merged them into one big rectangle. As the Matrox memory is very slow, it's faster to copy each damage clip. Signed-off-by: Jocelyn Falempe Re

Re: [PATCH 3/4] mgag200: remove unused flag

2022-05-04 Thread Jocelyn Falempe
On 04/05/2022 12:12, Thomas Zimmermann wrote: Hi Am 26.04.22 um 18:41 schrieb Jocelyn Falempe: The flag MGAG200_FLAG_HW_BUG_NO_STARTADD is no more used, because the framebuffer is now always at offset 0. Oh, well. I remember that thing. It took us a long time to find and fix this problem. Ba

[PATCH v2] Revert "fbdev: Make fb_release() return -ENODEV if fbdev was unregistered"

2022-05-04 Thread Javier Martinez Canillas
This reverts commit aafa025c76dcc7d1a8c8f0bdefcbe4eb480b2f6a. That commit attempted to fix a NULL pointer dereference, caused by the struct fb_info associated with a framebuffer device to not longer be valid when the file descriptor was closed. The issue was exposed by commit 27599aacbaef ("fbdev:

[PATCH 2/2] drm/i915: Don't use DRM_DEBUG_WARN_ON for ring unexpectedly not idle

2022-05-04 Thread Tvrtko Ursulin
From: Tvrtko Ursulin DRM_DEBUG_WARN_ON should only be used when we are certain CI is guaranteed to exercise a certain code path, so in case of values coming from MMIO reads we cannot be sure CI will have all the possible SKUs and parts, or that it will catch all possible error conditions. Use drm

[PATCH 1/2] drm/i915: Don't use DRM_DEBUG_WARN_ON for unexpected l3bank/mslice config

2022-05-04 Thread Tvrtko Ursulin
From: Tvrtko Ursulin DRM_DEBUG_WARN_ON should only be used when we are certain CI is guaranteed to exercise a certain code path, so in case of values coming from MMIO reads we cannot be sure CI will have all the possible SKUs and parts. Use drm_warn instead and move logging to init phase while a

Re: (subset) [PATCH v11 00/24] drm/rockchip: RK356x VOP2 support

2022-05-04 Thread Heiko Stuebner
On Fri, 22 Apr 2022 09:28:17 +0200, Sascha Hauer wrote: > It's v11 time. There's only one small change to v10. Discussion seems to > have settled now. Is there anything left that prevents the series from > being merged? I'd really like to have it in during the next merge > window. > > This series

Re: [PATCH 4/4] mgag200: remove mgag200_probe_vram()

2022-05-04 Thread Jocelyn Falempe
On 04/05/2022 12:16, Thomas Zimmermann wrote: Hi Am 26.04.22 um 18:41 schrieb Jocelyn Falempe: This function writes some pattern to video memory, to check for conflict. In case of conflicts, it returns a random memory capacity (offset of the conflict). Using devm_arch_io_reserve_memtype_wc() sh

Re: [PATCH] drm/i915: use IOMEM_ERR_PTR() directly

2022-05-04 Thread Tvrtko Ursulin
On 02/05/2022 09:30, Jani Nikula wrote: On Mon, 02 May 2022, Kefeng Wang wrote: Use IOMEM_ERR_PTR() instead of self defined IO_ERR_PTR(). Signed-off-by: Kefeng Wang Reviewed-by: Jani Nikula Pushed to drm-intel-gt-next, thanks for the patch and review! Regards, Tvrtko --- driver

Re: [PATCH] drm: Document that power requirements for DP AUX transfers

2022-05-04 Thread Ville Syrjälä
On Tue, May 03, 2022 at 04:21:08PM -0700, Douglas Anderson wrote: > When doing DP AUX transfers there are two actors that need to be > powered in order for the DP AUX transfer to work: the DP source and > the DP sync. Commit bacbab58f09d ("drm: Mention the power state > requirement on side-channel

[PATCH 1/5] dma-buf: cleanup dma_fence_unwrap selftest

2022-05-04 Thread Christian König
The selftests, fix the error handling, remove unused functions and stop leaking memory in failed tests. Signed-off-by: Christian König --- drivers/dma-buf/st-dma-fence-unwrap.c | 40 +++ 1 file changed, 16 insertions(+), 24 deletions(-) diff --git a/drivers/dma-buf/st-dm

[PATCH 2/5] dma-buf: cleanup dma_fence_unwrap implementation

2022-05-04 Thread Christian König
Move the code from the inline functions into exported functions. Signed-off-by: Christian König --- drivers/dma-buf/Makefile | 2 +- drivers/dma-buf/dma-fence-unwrap.c | 59 ++ include/linux/dma-fence-unwrap.h | 52 ++ 3 files chan

[PATCH 3/5] dma-buf: return only unsignaled fences in dma_fence_unwrap_for_each

2022-05-04 Thread Christian König
dma_fence_chain containers cleanup signaled fences automatically, so filter those out from arrays as well. Signed-off-by: Christian König --- drivers/dma-buf/dma-fence-unwrap.c | 23 --- include/linux/dma-fence-unwrap.h | 4 ++-- 2 files changed, 18 insertions(+), 9 deleti

[PATCH 4/5] dma-buf: generalize dma_fence unwrap & merging v2

2022-05-04 Thread Christian König
Introduce a dma_fence_unwrap_merge() macro which allows to unwrap fences which potentially can be containers as well and then merge them back together into a flat dma_fence_array. v2: rename the function, add some more comments about how the wrapper is used, move filtering of signaled fences i

[PATCH 5/5] drm: use dma_fence_unwrap_merge() in drm_syncobj

2022-05-04 Thread Christian König
The unwrap merge function is now intended for this use case. Signed-off-by: Christian König --- drivers/gpu/drm/drm_syncobj.c | 57 +-- 1 file changed, 7 insertions(+), 50 deletions(-) diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c ind

Re: [PATCH] drm/i915: Change semantics of context isolation reporting to UM

2022-05-04 Thread Daniel Vetter
On Fri, 29 Apr 2022 at 17:11, Adrian Larumbe wrote: > I915_PARAM_HAS_CONTEXT_ISOLATION was already being used as a boolean by > both Iris and Vulkan , and stood for the guarantee that, when creating a > new context, all state set by it will not leak to any other context. > > However the actual ret

Re: [PATCH 3/3] drm/mgag200: Protect concurrent access to I/O registers with lock

2022-05-04 Thread Jocelyn Falempe
On 02/05/2022 16:25, Thomas Zimmermann wrote: Add a mutex lock to protect concurrent access to I/O registers against each other. This happens between invokataion of commit- Typo in commit message, invokataion => invocation tail functions and get-mode operations. Both with use the CRTC index r

Re: [PATCH 0/3] drm: move dsc data pointer from drm_panel to mipi_dsi_device

2022-05-04 Thread Vinod Koul
On 01-05-22, 18:12, Dmitry Baryshkov wrote: > To properly support DSC the sink driver (panel) has to pass DSC pps data > to the source (DSI host). The commit 0f40ba48de3b ("drm/msm/dsi: Pass > DSC params to drm_panel") added a pointer to the DSC data to the struct > drm_panel. However this is not t

Re: [Freedreno] [PATCH v2] drm/msm/dsi: use RMW cycles in dsi_update_dsc_timing

2022-05-04 Thread Vinod Koul
On 30-04-22, 20:55, Dmitry Baryshkov wrote: > The downstream uses read-modify-write for updating command mode > compression registers. Let's follow this approach. This also fixes the > following warning: > > drivers/gpu/drm/msm/dsi/dsi_host.c:918:23: warning: variable 'reg_ctrl' set > but not use

Re: [PATCH v2] drm/msm/dsi: use RMW cycles in dsi_update_dsc_timing

2022-05-04 Thread Vinod Koul
On 30-04-22, 22:28, Dmitry Baryshkov wrote: > On 30/04/2022 21:58, Marijn Suijten wrote: > > On 2022-04-30 20:55:33, Dmitry Baryshkov wrote: > > > The downstream uses read-modify-write for updating command mode > > > compression registers. Let's follow this approach. This also fixes the > > > follo

[PATCH 2/2] Revert "fbdev: fbmem: add a helper to determine if an aperture is used by a fw fb"

2022-05-04 Thread Alex Deucher
This reverts commit 9a45ac2320d0a6ae01880a30d4b86025fce4061b. This was added a helper for amdgpu to workaround a runtime pm regression caused by a runtime pm fix in efifb. We now have a better workarouund in amdgpu in commit f95af4a9236695 ("drm/amdgpu: don't runtime suspend if there are displays

[PATCH 1/2] Revert "drm/amdgpu: disable runpm if we are the primary adapter"

2022-05-04 Thread Alex Deucher
This reverts commit b95dc06af3e683d6b7ddbbae178b2b2a21ee8b2b. This workaround is no longer necessary. We have a better workaround in commit f95af4a9236695 ("drm/amdgpu: don't runtime suspend if there are displays attached (v3)"). Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdg

Re: [PATCH v2] drm/msm/dsi: use RMW cycles in dsi_update_dsc_timing

2022-05-04 Thread Vinod Koul
On 01-05-22, 22:41, Marijn Suijten wrote: > On 2022-04-30 22:28:42, Dmitry Baryshkov wrote: > > On 30/04/2022 21:58, Marijn Suijten wrote: > > > On 2022-04-30 20:55:33, Dmitry Baryshkov wrote: > > >> The downstream uses read-modify-write for updating command mode > > >> compression registers. Let's

[PATCH v2 0/3] mgag200: Improve damage handling

2022-05-04 Thread Jocelyn Falempe
mgag200: Improve damage handling This series improves the damage handling on Matrox gpu, and allows Gnome/Wayland to run much better. Also include some driver cleanup. Tested on a Dell T310 with Matrox MGA G200eW WPCM450 (rev 0a) v2: Drop remove mgag200_probe_vram() Rewrote the patch to warn i

[PATCH v2 1/3] mgag200: Add FB_DAMAGE_CLIPS support

2022-05-04 Thread Jocelyn Falempe
The driver does support damage clips, but doesn't advertise it. So when running gnome/wayland on Matrox hardware, the full frame is copied to the slow Matrox memory, which leads to very poor performances. Add drm_plane_enable_fb_damage_clips() to advertise this capability to userspace. With this

[PATCH v2 2/3] mgag200: Optimize damage clips

2022-05-04 Thread Jocelyn Falempe
When there are multiple damage clips, previous code merged them into one big rectangle. As the Matrox memory is very slow, it's faster to copy each damage clip. Signed-off-by: Jocelyn Falempe Reviewed-by: Lyude Paul Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_mode.c | 15

[PATCH v2 3/3] mgag200: Warn once if trying to set start address on broken hardware.

2022-05-04 Thread Jocelyn Falempe
Some MGA200 hardware are broken, and can't use a start address > 0 v2: Warn if startaddr is not 0, and hw doesn't support it. (instead of removing MGAG200_FLAG_HW_BUG_NO_STARTADD) Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/mgag200/mgag200_mode.c | 3 +++ 1 file changed, 3 insertions(+

Re: [Freedreno] [PATCH v2] drm/msm/dsi: use RMW cycles in dsi_update_dsc_timing

2022-05-04 Thread Vinod Koul
On 02-05-22, 10:43, Marijn Suijten wrote: > On 2022-05-02 01:44:20, Dmitry Baryshkov wrote: > that require DSC for the screen to work. I've been told the series > didn't result in positive screen output way back in its infancy, but I would be intrested to hear about that. I have only pixel3 at my

[PATCH -next] video: fbdev: clean up some inconsistent indenting

2022-05-04 Thread Yang Li
Eliminate the follow smatch warnings: drivers/video/fbdev/nvidia/nv_hw.c:1512 NVLoadStateExt() warn: inconsistent indenting drivers/video/fbdev/sis/sis_main.c:4265 sisfb_post_300_rwtest() warn: inconsistent indenting Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/video/fbdev/nvidia

[PATCH 2/2] Revert "fbdev: fbmem: add a helper to determine if an aperture is used by a fw fb"

2022-05-04 Thread Alex Deucher
This reverts commit 9a45ac2320d0a6ae01880a30d4b86025fce4061b. This was added a helper for amdgpu to workaround a runtime pm regression caused by a runtime pm fix in efifb. We now have a better workarouund in amdgpu in commit f95af4a9236695 ("drm/amdgpu: don't runtime suspend if there are displays

[PATCH 1/2] Revert "drm/amdgpu: disable runpm if we are the primary adapter"

2022-05-04 Thread Alex Deucher
This reverts commit b95dc06af3e683d6b7ddbbae178b2b2a21ee8b2b. This workaround is no longer necessary. We have a better workaround in commit f95af4a9236695 ("drm/amdgpu: don't runtime suspend if there are displays attached (v3)"). Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdg

Re: [PATCH] drm: drm_gem.h: Add explicit includes for DEFINE_DRM_GEM_FOPS

2022-05-04 Thread Jeffrey Hugo
On 5/4/2022 3:38 AM, Daniel Vetter wrote: On Mon, May 02, 2022 at 06:41:39PM +0300, Jani Nikula wrote: On Fri, 29 Apr 2022, Jeffrey Hugo wrote: DEFINE_DRM_GEM_FOPS() references drm functions from other headers. For example drm_open() is defined in drm_file.h and drm_ioctl() is defined in drm_

Re: [PATCH] drm/todo: Add entry for using kunit in the subsystem

2022-05-04 Thread Maxime Ripard
On Wed, May 04, 2022 at 10:34:39AM +0200, Javier Martinez Canillas wrote: > Hello Maxime, > > Thanks for your feedback. > > On 5/4/22 10:10, Maxime Ripard wrote: > > Hi, > > > > On Wed, May 04, 2022 at 10:02:12AM +0200, Javier Martinez Canillas wrote: > >> The Kernel Unit Testing (KUnit) framewo

Re: [Intel-gfx] [PATCH 3/3] drm/i915/gt: Clear SET_PREDICATE_RESULT prior to executing the ring

2022-05-04 Thread Tvrtko Ursulin
On 25/04/2022 16:23, Ramalingam C wrote: From: Chris Wilson Userspace may leave predication enabled upon return from the batch buffer, which has the consequent of preventing all operation from the ring from being executed, including all the synchronisation, coherency control, arbitration and

Re: [PATCH] drm/bridge: tc358767: Fix DP bridge mode detection from DT endpoints

2022-05-04 Thread Lucas Stach
Am Freitag, dem 29.04.2022 um 22:46 +0200 schrieb Marek Vasut: > Per toshiba,tc358767.yaml DT binding document, port@2 the output (e)DP > port is optional. In case this port is not described in DT, the bridge > driver operates in DPI-to-DP mode. Make sure the driver treats this as > a valid mode of

[GIT PULL] drm/imx: various cleanups

2022-05-04 Thread Philipp Zabel
Hi Dave, Daniel, The following changes since commit 3123109284176b1532874591f7c81f3837bbdc17: Linux 5.18-rc1 (2022-04-03 14:08:21 -0700) are available in the Git repository at: git://git.pengutronix.de/pza/linux.git tags/imx-drm-next-2022-05-04 for you to fetch changes up to 927d8fd465adba

Re: [PATCH] drm/todo: Add entry for using kunit in the subsystem

2022-05-04 Thread Thomas Zimmermann
Hi Am 04.05.22 um 10:02 schrieb Javier Martinez Canillas: The Kernel Unit Testing (KUnit) framework provides a common framework for unit tests within the Linux kernel. Having a test suite would allow to identify regressions earlier. Signed-off-by: Javier Martinez Canillas --- Documentation/

Re: [PATCH v2 3/3] mgag200: Warn once if trying to set start address on broken hardware.

2022-05-04 Thread Thomas Zimmermann
Hi Am 04.05.22 um 15:40 schrieb Jocelyn Falempe: Some MGA200 hardware are broken, and can't use a start address > 0 I'm not a native speaker, but 'is broken' (without comma) would sound better to me. The period at the end of the sentence is missing. Best regards Thomas v2: Warn if starta

Re: [PATCH v2 1/2] drm/dp: Add callbacks to make using DP AUX bus properly easier

2022-05-04 Thread Doug Anderson
Hi, On Wed, May 4, 2022 at 3:41 AM Dmitry Baryshkov wrote: > > > - We had forgotten a EXPORT_SYMBOL_GPL on the non "devm" populate > >function. > > This can go to a separate patch, so that the fix can be backported to > earlier kernels. Please don't forget the Fixes: tag. Sure. Will do for v

Re: [PATCH] drm/i915: Change semantics of context isolation reporting to UM

2022-05-04 Thread Matt Roper
On Wed, May 04, 2022 at 02:24:07PM +0200, Daniel Vetter wrote: > On Fri, 29 Apr 2022 at 17:11, Adrian Larumbe > wrote: > > I915_PARAM_HAS_CONTEXT_ISOLATION was already being used as a boolean by > > both Iris and Vulkan , and stood for the guarantee that, when creating a > > new context, all state

Re: [PATCH v2 0/3] mgag200: Improve damage handling

2022-05-04 Thread Thomas Zimmermann
Hi Jocelyn, with my comment on 3/3 considered, you can add Reviewed-by: Thomas Zimemrmann to this patchset. You should get commit access for drm-misc, so that you can land the patchset on your own. Please see https://drm.pages.freedesktop.org/maintainer-tools/commit-access.html for how

Re: [PATCH] dt-bindings: display: bridge: ldb: Fill in reg property

2022-05-04 Thread Rob Herring
On Wed, 04 May 2022 03:26:01 +0200, Marek Vasut wrote: > Add missing reg and reg-names properties for both 'LDB_CTRL' > and 'LVDS_CTRL' registers. > > Fixes: 463db5c2ed4ae ("drm: bridge: ldb: Implement simple Freescale i.MX8MP > LDB bridge") > Signed-off-by: Marek Vasut > Cc: Laurent Pinchart >

Re: [PATCH 2/2] Revert "drm: of: Lookup if child node has panel or bridge"

2022-05-04 Thread Maxime Ripard
On Fri, Apr 29, 2022 at 07:05:59PM +0300, Laurent Pinchart wrote: > Hi Maxime, > > On Fri, Apr 29, 2022 at 05:46:45PM +0200, Maxime Ripard wrote: > > On Fri, Apr 29, 2022 at 01:17:26AM +0300, Laurent Pinchart wrote: > > > On Thu, Apr 28, 2022 at 02:09:42PM +0530, Jagan Teki wrote: > > > > On Wed,

Re: (subset) [PATCH] drm: exynos: dsi: Use child panel or bridge find helpers

2022-05-04 Thread Maxime Ripard
On Thu, 28 Apr 2022 15:18:08 +0530, Jagan Teki wrote: > commit <711c7adc4687> ("drm: exynos: dsi: Use drm panel_bridge API") > added devm_drm_of_get_bridge for looking up if child node has panel > or bridge. > > However commit ("Revert "drm: of: Lookup if child node > has panel or bridge") has re

Re: (subset) [RESEND 1/2] Revert "drm: bridge: mcde_dsi: Drop explicit bridge remove"

2022-05-04 Thread Maxime Ripard
On Fri, 29 Apr 2022 14:29:46 +0530, Jagan Teki wrote: > commit <3730bc6147b0> ("drm: bridge: mcde_dsi: Drop explicit bridge > remove") has removed downstream bridge as it's prior commit <3d7039e1e649> > ("drm: bridge: mcde_dsi: Switch to devm_drm_of_get_bridge") added > devm_drm_of_get_bridge for l

Re: (subset) [RESEND 2/2] Revert "drm: bridge: mcde_dsi: Switch to devm_drm_of_get_bridge"

2022-05-04 Thread Maxime Ripard
On Fri, 29 Apr 2022 14:29:47 +0530, Jagan Teki wrote: > commit <3d7039e1e649> ("drm: bridge: mcde_dsi: Switch to > devm_drm_of_get_bridge") > switched to devm_drm_of_get_bridge for looking up if child node has panel > or bridge. > > However commit ("Revert "drm: of: Lookup if child node > has pa

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix race in __i915_vma_remove_closed

2022-05-04 Thread Tvrtko Ursulin
On 20/04/2022 10:57, Karol Herbst wrote: i915_vma_reopen checked if the vma is closed before without taking the lock. So multiple threads could attempt removing the vma. Instead the lock needs to be taken before actually checking. v2: move struct declaration Cc: Chris Wilson Cc: intel-...@l

Re: [PATCH v4 10/15] drm/shmem-helper: Take reservation lock instead of drm_gem_shmem locks

2022-05-04 Thread Dmitry Osipenko
On 5/4/22 11:21, Daniel Vetter wrote: ... >>> - Maybe also do what you suggest and keep a separate lock for this, but >>> the fundamental issue is that this doesn't really work - if you share >>> buffers both ways with two drivers using shmem helpers, then the >>> ordering of this vmap_count_

Re: [PATCH] drm/msm/dsi: fix address for second DSI PHY on SDM660

2022-05-04 Thread Konrad Dybcio
On 03/05/2022 22:43, Dmitry Baryshkov wrote: Correct a typo in the address of the second DSI PHY in the SDM660 device config. Fixes: 694dd304cc29 ("drm/msm/dsi: Add phy configuration for SDM630/636/660") Cc: Konrad Dybcio Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- Gah

Re: [PATCH] drm: Document that power requirements for DP AUX transfers

2022-05-04 Thread Doug Anderson
Hi, On Wed, May 4, 2022 at 5:21 AM Ville Syrjälä wrote: > > On Tue, May 03, 2022 at 04:21:08PM -0700, Douglas Anderson wrote: > > When doing DP AUX transfers there are two actors that need to be > > powered in order for the DP AUX transfer to work: the DP source and > > the DP sync. Commit bacbab

Re: [PATCH v2 0/3] mgag200: Improve damage handling

2022-05-04 Thread Jocelyn Falempe
On 04/05/2022 16:59, Thomas Zimmermann wrote: Hi Jocelyn, with my comment on 3/3 considered, you can add Reviewed-by: Thomas Zimemrmann to this patchset. You should get commit access for drm-misc, so that you can land the patchset on your own. Please see   https://drm.pages.freedesktop.o

[PATCH] drm/nouveau/devinit: fix returnvar.cocci warnings

2022-05-04 Thread Guo Zhengkui
Fix the following coccicheck warnings: drivers/gpu/drm/nouveau/nvkm/subdev/devinit/gf100.c:71:5-12: Unneeded variable: "disable". Return "0ULL" on line 90. drivers/gpu/drm/nouveau/nvkm/subdev/devinit/gm107.c:35:5-12: Unneeded variable: "disable". Return "0ULL" on line 44. drivers/gpu/drm/nouveau/n

Re: [PATCH] drm/i915: Change semantics of context isolation reporting to UM

2022-05-04 Thread Daniel Vetter
On Wed, May 04, 2022 at 07:59:27AM -0700, Matt Roper wrote: > On Wed, May 04, 2022 at 02:24:07PM +0200, Daniel Vetter wrote: > > On Fri, 29 Apr 2022 at 17:11, Adrian Larumbe > > wrote: > > > I915_PARAM_HAS_CONTEXT_ISOLATION was already being used as a boolean by > > > both Iris and Vulkan , and st

RE: [PATCH] video: hyperv_fb: Allow resolutions with size > 64 MB for Gen1

2022-05-04 Thread Haiyang Zhang
> -Original Message- > From: Wei Liu > Sent: Thursday, April 28, 2022 10:38 AM > To: Saurabh Sengar > Cc: Saurabh Singh Sengar ; KY Srinivasan > ; Haiyang Zhang ; Stephen > Hemminger ; wei@kernel.org; Dexuan Cui > ; del...@gmx.de; linux-hyp...@vger.kernel.org; linux- > fb...@vger.k

Re: [PATCH 1/2] Revert "drm/amdgpu: disable runpm if we are the primary adapter"

2022-05-04 Thread Javier Martinez Canillas
Hello Alex, On 5/4/22 15:48, Alex Deucher wrote: > This reverts commit b95dc06af3e683d6b7ddbbae178b2b2a21ee8b2b. > > This workaround is no longer necessary. We have a better workaround > in commit f95af4a9236695 ("drm/amdgpu: don't runtime suspend if there are > displays attached (v3)"). > I w

Re: [PATCH 1/2] Revert "drm/amdgpu: disable runpm if we are the primary adapter"

2022-05-04 Thread Daniel Vetter
On Wed, May 04, 2022 at 09:48:32AM -0400, Alex Deucher wrote: > This reverts commit b95dc06af3e683d6b7ddbbae178b2b2a21ee8b2b. > > This workaround is no longer necessary. We have a better workaround > in commit f95af4a9236695 ("drm/amdgpu: don't runtime suspend if there are > displays attached (v

Re: [PATCH 1/2] drm/i915: Don't use DRM_DEBUG_WARN_ON for unexpected l3bank/mslice config

2022-05-04 Thread Matt Roper
On Wed, May 04, 2022 at 01:07:14PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > DRM_DEBUG_WARN_ON should only be used when we are certain CI is guaranteed > to exercise a certain code path, so in case of values coming from MMIO > reads we cannot be sure CI will have all the possible SK

Re: [PATCH 2/2] Revert "fbdev: fbmem: add a helper to determine if an aperture is used by a fw fb"

2022-05-04 Thread Javier Martinez Canillas
On 5/4/22 15:48, Alex Deucher wrote: > This reverts commit 9a45ac2320d0a6ae01880a30d4b86025fce4061b. > > This was added a helper for amdgpu to workaround a runtime pm regression > caused by a runtime pm fix in efifb. We now have a better workarouund s/workarouund/workaround > in amdgpu in > com

[PATCH 0/3] amdgpu: A few fixes for clang warnings

2022-05-04 Thread Mike Lothian
Just a few simple fixes to get rid of warnings seen with clang 14 Mike Lothian (3): drm/amdgpu/gfx10: Initalise index drm/amdgpu/gfx11: Initalise index drm/amdgpu/gfx11: Add missing break drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 3 ++- 2 files

[PATCH 1/3] drm/amdgpu/gfx10: Initalise index

2022-05-04 Thread Mike Lothian
This stops clang complaining: drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:3846:6: warning: variable 'index' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] if (ring->is_mes_queue) { ^~ drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:3903:30:

[PATCH 2/3] drm/amdgpu/gfx11: Initalise index

2022-05-04 Thread Mike Lothian
This stops clang complaining: drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c:376:6: warning: variable 'index' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] if (ring->is_mes_queue) { ^~ drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c:433:30: n

[PATCH 3/3] drm/amdgpu/gfx11: Add missing break

2022-05-04 Thread Mike Lothian
This stops clang complaining: drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c:5895:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough] default: ^ drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c:5895:2: note: insert 'break;' to avoid fall-through default:

Re: [PATCH 1/2] Revert "drm/amdgpu: disable runpm if we are the primary adapter"

2022-05-04 Thread Alex Deucher
On Wed, May 4, 2022 at 12:46 PM Javier Martinez Canillas wrote: > > Hello Alex, > > On 5/4/22 15:48, Alex Deucher wrote: > > This reverts commit b95dc06af3e683d6b7ddbbae178b2b2a21ee8b2b. > > > > This workaround is no longer necessary. We have a better workaround > > in commit f95af4a9236695 ("drm

Re: [PATCH 1/2] Revert "drm/amdgpu: disable runpm if we are the primary adapter"

2022-05-04 Thread Javier Martinez Canillas
On 5/4/22 18:50, Alex Deucher wrote: > On Wed, May 4, 2022 at 12:46 PM Javier Martinez Canillas > wrote: >> >> Hello Alex, >> >> On 5/4/22 15:48, Alex Deucher wrote: >>> This reverts commit b95dc06af3e683d6b7ddbbae178b2b2a21ee8b2b. >>> >>> This workaround is no longer necessary. We have a better

RE: [PATCH] video: hyperv_fb: Allow resolutions with size > 64 MB for Gen1

2022-05-04 Thread Dexuan Cui
> From: Haiyang Zhang > > > ... > > > - if (gen2vm) { > > > - pot_start = 0; > > > - pot_end = -1; > > > - } else { > > > - if (!(pci_resource_flags(pdev, 0) & IORESOURCE_MEM) || > > > - pci_resource_len(pdev, 0) < screen_fb_size) { > > > - pr_er

[PATCH] drm/nouveau: reorder nouveau_drm_device_fini

2022-05-04 Thread Mark Menzynski
Resources needed for output poll workers are destroyed in nouveau_fbcon_fini() before output poll workers are cleared in nouveau_display_fini(). This means there is a time between fbcon_fini and display_fini, where if output poll happens, it crashes. BUG: KASAN: use-after-free in __drm_fb_helper_i

Re: [PATCH] drm/nouveau/devinit: fix returnvar.cocci warnings

2022-05-04 Thread Lyude Paul
Reviewed-by: Lyude Paul Will push to the appropriate branch in a little bit On Thu, 2022-05-05 at 00:09 +0800, Guo Zhengkui wrote: > Fix the following coccicheck warnings: > > drivers/gpu/drm/nouveau/nvkm/subdev/devinit/gf100.c:71:5-12: > Unneeded variable: "disable". Return "0ULL" on line 90.

Re: [PATCH 0/4] Remove support for Hyper-V 2008 and 2008R2/Win7

2022-05-04 Thread Pavel Machek
Hi! > Linux code for running as a Hyper-V guest includes special cases for the > first released versions of Hyper-V: 2008 and 2008R2/Windows 7. These > versions were very thinly used for running Linux guests when first > released more than 12 years ago, and they are now out of support > (except fo

Re: [PATCH 1/2] drm/i915: Don't use DRM_DEBUG_WARN_ON for unexpected l3bank/mslice config

2022-05-04 Thread Tvrtko Ursulin
On 04/05/2022 17:48, Matt Roper wrote: On Wed, May 04, 2022 at 01:07:14PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin DRM_DEBUG_WARN_ON should only be used when we are certain CI is guaranteed to exercise a certain code path, so in case of values coming from MMIO reads we cannot be sur

Re: [PATCH] drm: Document that power requirements for DP AUX transfers

2022-05-04 Thread Lyude Paul
On Wed, 2022-05-04 at 09:04 -0700, Doug Anderson wrote: > Hi, > > On Wed, May 4, 2022 at 5:21 AM Ville Syrjälä > wrote: > > > > On Tue, May 03, 2022 at 04:21:08PM -0700, Douglas Anderson wrote: > > > When doing DP AUX transfers there are two actors that need to be > > > powered in order for the

Re: [PATCH] drm/i915: Change semantics of context isolation reporting to UM

2022-05-04 Thread Matt Roper
On Wed, May 04, 2022 at 06:42:37PM +0200, Daniel Vetter wrote: > On Wed, May 04, 2022 at 07:59:27AM -0700, Matt Roper wrote: > > On Wed, May 04, 2022 at 02:24:07PM +0200, Daniel Vetter wrote: > > > On Fri, 29 Apr 2022 at 17:11, Adrian Larumbe > > > wrote: > > > > I915_PARAM_HAS_CONTEXT_ISOLATION w

Re: [PATCH 1/2] drm/i915: Don't use DRM_DEBUG_WARN_ON for unexpected l3bank/mslice config

2022-05-04 Thread Matt Roper
On Wed, May 04, 2022 at 06:59:32PM +0100, Tvrtko Ursulin wrote: > > On 04/05/2022 17:48, Matt Roper wrote: > > On Wed, May 04, 2022 at 01:07:14PM +0100, Tvrtko Ursulin wrote: > > > From: Tvrtko Ursulin > > > > > > DRM_DEBUG_WARN_ON should only be used when we are certain CI is guaranteed > > > t

Re: [PATCH RFC v6 00/21] DEPT(Dependency Tracker)

2022-05-04 Thread Linus Torvalds
On Wed, May 4, 2022 at 1:19 AM Byungchul Park wrote: > > Hi Linus and folks, > > I've been developing a tool for detecting deadlock possibilities by > tracking wait/event rather than lock(?) acquisition order to try to > cover all synchonization machanisms. So what is the actual status of reports

<    1   2   3   >