Re: [PATCH v3 4/5] fbdev: Rename pagelist to pagereflist for deferred I/O

2022-04-29 Thread Javier Martinez Canillas
Hello Thomas, On 4/26/22 14:03, Thomas Zimmermann wrote: > Rename various instances of pagelist to pagereflist. The list now > stores pageref structures, so the new name is more appropriate. > > In their write-back helpers, several fbdev drivers refer to the > pageref list in struct fb_deferred_i

Re: [PATCH v3 4/5] fbdev: Rename pagelist to pagereflist for deferred I/O

2022-04-29 Thread Thomas Zimmermann
Hi Am 29.04.22 um 09:21 schrieb Javier Martinez Canillas: Hello Thomas, On 4/26/22 14:03, Thomas Zimmermann wrote: Rename various instances of pagelist to pagereflist. The list now stores pageref structures, so the new name is more appropriate. In their write-back helpers, several fbdev drive

Re: [PATCH v3 5/5] fbdev: Use pageref offset for deferred-I/O writeback

2022-04-29 Thread Javier Martinez Canillas
On 4/26/22 14:03, Thomas Zimmermann wrote: > Use pageref->offset instead of page->index for deferred-I/O writeback > where appropriate. Distinguishes between file-mapping offset and video- > memory offset. While at it, also remove unnecessary references to > struct page. > > Fbdev's deferred-I/O c

Re: [PATCH v3 4/5] fbdev: Rename pagelist to pagereflist for deferred I/O

2022-04-29 Thread Javier Martinez Canillas
On 4/29/22 09:27, Thomas Zimmermann wrote: > Hi > > Am 29.04.22 um 09:21 schrieb Javier Martinez Canillas: >> Hello Thomas, >> >> On 4/26/22 14:03, Thomas Zimmermann wrote: >>> Rename various instances of pagelist to pagereflist. The list now >>> stores pageref structures, so the new name is more

Re: [PATCH v3 0/5] Fix some race conditions that exists between fbmem and sysfb

2022-04-29 Thread Daniel Vetter
On Mon, Apr 25, 2022 at 11:49:13AM +0200, Javier Martinez Canillas wrote: > Hello Thomas, > > Thanks for the feedback. It was very useful. > > On 4/25/22 11:15, Thomas Zimmermann wrote: > > Hi > > > > Am 25.04.22 um 10:54 schrieb Thomas Zimmermann: > >> Hi > >> > >> Am 20.04.22 um 10:52 schrieb

Re: [PATCH 1/2] module: add a function to add module references

2022-04-29 Thread Daniel Vetter
On Fri, Apr 29, 2022 at 07:31:15AM +0100, Mauro Carvalho Chehab wrote: > Sometimes, device drivers are bound using indirect references, > which is not visible when looking at /proc/modules or lsmod. > > Add a function to allow setting up module references for such > cases. > > Reviewed-by: Dan Wi

Re: [PATCH v3 0/5] Fix some race conditions that exists between fbmem and sysfb

2022-04-29 Thread Javier Martinez Canillas
Hello Daniel, On 4/29/22 09:47, Daniel Vetter wrote: [snip] >> >> Exactly, should be done when the device is registered rather than when >> the driver is registered or a call is made to remove the conflicting FB. >> >> I'll rework this series with only the bits for sysfb_disable() and drop >> th

Re: [PATCH 1/2] module: add a function to add module references

2022-04-29 Thread Mauro Carvalho Chehab
Hi Daniel, Em Fri, 29 Apr 2022 09:54:10 +0200 Daniel Vetter escreveu: > On Fri, Apr 29, 2022 at 07:31:15AM +0100, Mauro Carvalho Chehab wrote: > > Sometimes, device drivers are bound using indirect references, > > which is not visible when looking at /proc/modules or lsmod. > > > > Add a functi

Re: [PATCH 2/2] Revert "drm: of: Lookup if child node has panel or bridge"

2022-04-29 Thread Jagan Teki
Hi Laurent, On Fri, Apr 29, 2022 at 3:47 AM Laurent Pinchart wrote: > > Hi Jagan, > > On Thu, Apr 28, 2022 at 02:09:42PM +0530, Jagan Teki wrote: > > On Wed, Apr 27, 2022 at 8:04 PM Maxime Ripard wrote: > > > On Tue, Apr 26, 2022 at 01:40:31PM +0530, Jagan Teki wrote: > > > > On Tue, Apr 26, 2022

Re: [PATCH] drm: exynos: dsi: Use child panel or bridge find helpers

2022-04-29 Thread Marek Szyprowski
Hi Maxime, On 28.04.2022 14:14, Maxime Ripard wrote: > On Thu, Apr 28, 2022 at 03:18:08PM +0530, Jagan Teki wrote: >> commit <711c7adc4687> ("drm: exynos: dsi: Use drm panel_bridge API") >> added devm_drm_of_get_bridge for looking up if child node has panel >> or bridge. >> >> However commit ("Re

Re: [PATCH 1/2] module: add a function to add module references

2022-04-29 Thread Greg KH
On Fri, Apr 29, 2022 at 09:07:57AM +0100, Mauro Carvalho Chehab wrote: > Hi Daniel, > > Em Fri, 29 Apr 2022 09:54:10 +0200 > Daniel Vetter escreveu: > > > On Fri, Apr 29, 2022 at 07:31:15AM +0100, Mauro Carvalho Chehab wrote: > > > Sometimes, device drivers are bound using indirect references, >

Re: [PATCH v9 18/22] drm/mediatek: Add mt8195 Embedded DisplayPort driver

2022-04-29 Thread Maxime Ripard
Hi Guillaume, On Mon, Mar 28, 2022 at 12:39:23AM +0200, Guillaume Ranquet wrote: > From: Markus Schneider-Pargmann > > This patch adds a DisplayPort driver for the Mediatek mt8195 SoC. > > It supports the mt8195, the embedded DisplayPort units. It offers > DisplayPort 1.4 with up to 4 lanes. >

[RFC PATCH v4 01/11] drm: Add a capability flag for simple framebuffer drivers

2022-04-29 Thread Javier Martinez Canillas
The DRIVER_FIRMWARE flag denotes that a DRM driver uses a framebuffer that was initialized and provided by the system firmware for scanout. Signed-off-by: Javier Martinez Canillas --- (no changes since v1) include/drm/drm_drv.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/

[RFC PATCH v4 03/11] drm/simpledrm: Set the DRM_FIRMWARE capability

2022-04-29 Thread Javier Martinez Canillas
The DRIVER_FIRMWARE flag denotes that a DRM driver uses a framebuffer that was initialized and provided by the system firmware for scanout, which is the case for simpledrm. Signed-off-by: Javier Martinez Canillas --- (no changes since v1) drivers/gpu/drm/tiny/simpledrm.c | 2 +- 1 file changed

[RFC PATCH v4 06/11] fbdev: Restart conflicting fb removal loop when unregistering devices

2022-04-29 Thread Javier Martinez Canillas
Drivers that want to remove registered conflicting framebuffers prior to register their own framebuffer, calls remove_conflicting_framebuffers(). This function takes the registration_lock mutex, to prevent a races when drivers register framebuffer devices. But if a conflicting framebuffer device i

[RFC PATCH v4 05/11] firmware: sysfb: Add helpers to unregister a pdev and disable registration

2022-04-29 Thread Javier Martinez Canillas
These can be used by subsystems to unregister a platform device registered by sysfb and also to disable future platform device registration in sysfb. Suggested-by: Daniel Vetter Signed-off-by: Javier Martinez Canillas Reviewed-by: Daniel Vetter --- (no changes since v2) Changes in v2: - Add k

[RFC PATCH v4 04/11] firmware: sysfb: Make sysfb_create_simplefb() return a pdev pointer

2022-04-29 Thread Javier Martinez Canillas
This function just returned 0 on success or an errno code on error, but it could be useful for sysfb_init() callers to have a pointer to the device. Signed-off-by: Javier Martinez Canillas Reviewed-by: Daniel Vetter Reviewed-by: Thomas Zimmermann --- Changes in v4: - Make sysfb_disable() to a

[RFC PATCH v4 02/11] drm/fb-helper: Set FBINFO_MISC_FIRMWARE flag for DRIVER_FIRMWARE fb

2022-04-29 Thread Javier Martinez Canillas
The DRIVER_FIRMWARE flag denotes that a DRM driver uses a framebuffer that was initialized and provided by the system firmware for scanout. Indicate to the fbdev subsystem that the registered framebuffer is a FBINFO_MISC_FIRMWARE, so that it can handle accordingly. For example, wold hot-unplug the

[RFC PATCH v4 08/11] fbdev: Fix race between sysfb and framebuffer devices registration

2022-04-29 Thread Javier Martinez Canillas
The platform devices registered by sysfb match with firmware-based DRM or fbdev drivers, that are used to have early graphics using a framebuffer provided by the system firmware. DRM or fbdev drivers later are probed and remove all conflicting framebuffers, leading to these platform devices for ge

[RFC PATCH v4 00/11] Fix some race between sysfb device registration and drivers probe

2022-04-29 Thread Javier Martinez Canillas
Hello, The patches in this series contain mostly changes suggested by Daniel Vetter Thomas Zimmermann. They aim to fix existing races between the Generic System Framebuffer (sysfb) infrastructure and the fbdev and DRM device registration. For example, it is currently possible for sysfb to registe

[RFC PATCH v4 09/11] drm: Fix race between sysfb and DRM devices registration

2022-04-29 Thread Javier Martinez Canillas
The platform devices registered by sysfb match with firmware-based DRM or fbdev drivers, that are used to have early graphics using a framebuffer provided by the system firmware. DRM or fbdev drivers later are probed and remove all conflicting framebuffers, leading to these platform devices for ge

[RFC PATCH v4 07/11] fbdev: Make sysfb to unregister its own registered devices

2022-04-29 Thread Javier Martinez Canillas
The platform devices registered in sysfb match with a firmware-based fbdev or DRM driver, that are used to have early graphics using framebuffers set up by the system firmware. Real DRM drivers later are probed and remove all conflicting framebuffers, leading to these platform devices for generic

[RFC PATCH v4 10/11] Revert "fbdev: Prevent probing generic drivers if a FB is already registered"

2022-04-29 Thread Javier Martinez Canillas
From: Daniel Vetter This reverts commit fb561bf9abde49f7e00fdbf9ed2ccf2d86cac8ee. With commit 27599aacbaefcbf2af7b06b0029459bbf682000d Author: Thomas Zimmermann Date: Tue Jan 25 10:12:18 2022 +0100 fbdev: Hot-unplug firmware fb devices on forced removal this should be fixed properly an

[RFC PATCH v4 11/11] fbdev: Make registered_fb[] private to fbmem.c

2022-04-29 Thread Javier Martinez Canillas
From: Daniel Vetter Well except when the olpc dcon fbdev driver is enabled, that thing digs around in there in rather unfixable ways. Cc oldc_dcon maintainers as fyi. v2: I typoed the config name (0day) Cc: kernel test robot Cc: Jens Frederich Cc: Jon Nettleton Cc: Greg Kroah-Hartman Cc: l

Re: [RFC] drm/kms: control display brightness through drm_connector properties

2022-04-29 Thread Hans de Goede
Hi, On 4/27/22 16:26, Daniel Vetter wrote: > On Wed, Apr 27, 2022 at 05:23:22PM +0300, Jani Nikula wrote: >> On Wed, 27 Apr 2022, Daniel Vetter wrote: >>> On Thu, Apr 14, 2022 at 01:24:30PM +0300, Jani Nikula wrote: On Mon, 11 Apr 2022, Alex Deucher wrote: > On Mon, Apr 11, 2022 at 6:18

[PATCH 2/2] Revert "drm: bridge: mcde_dsi: Switch to devm_drm_of_get_bridge"

2022-04-29 Thread Jagan Teki
From: Jagan Teki commit <3d7039e1e649> ("drm: bridge: mcde_dsi: Switch to devm_drm_of_get_bridge") switched to devm_drm_of_get_bridge for looking up if child node has panel or bridge. However commit ("Revert "drm: of: Lookup if child node has panel or bridge") has reverted panel or bridge chil

[PATCH 1/2] Revert "drm: bridge: mcde_dsi: Drop explicit bridge remove"

2022-04-29 Thread Jagan Teki
commit <3730bc6147b0> ("drm: bridge: mcde_dsi: Drop explicit bridge remove") has removed downstream bridge as it's prior commit <3d7039e1e649> ("drm: bridge: mcde_dsi: Switch to devm_drm_of_get_bridge") added devm_drm_of_get_bridge for looking up if child node has panel or bridge. However commit

Re: [RFC] drm/kms: control display brightness through drm_connector properties

2022-04-29 Thread Simon Ser
On Friday, April 29th, 2022 at 10:55, Hans de Goede wrote: > I believe that we can fix the new interface, the plan is for there > to be some helper code to proxy the new connector properties to what > is still a good old backlight-device internally in the kernel,. > > This proxy-ing code could ta

[RESEND 1/2] Revert "drm: bridge: mcde_dsi: Drop explicit bridge remove"

2022-04-29 Thread Jagan Teki
commit <3730bc6147b0> ("drm: bridge: mcde_dsi: Drop explicit bridge remove") has removed downstream bridge as it's prior commit <3d7039e1e649> ("drm: bridge: mcde_dsi: Switch to devm_drm_of_get_bridge") added devm_drm_of_get_bridge for looking up if child node has panel or bridge. However commit

[RESEND 2/2] Revert "drm: bridge: mcde_dsi: Switch to devm_drm_of_get_bridge"

2022-04-29 Thread Jagan Teki
commit <3d7039e1e649> ("drm: bridge: mcde_dsi: Switch to devm_drm_of_get_bridge") switched to devm_drm_of_get_bridge for looking up if child node has panel or bridge. However commit ("Revert "drm: of: Lookup if child node has panel or bridge") has reverted panel or bridge child node lookup from

[PATCH] omapdss: HDMI: simplify the return expression of hdmi_init_pll_data()

2022-04-29 Thread cgel . zte
From: Minghao Chi Simplify the return expression. Reported-by: Zeal Robot Signed-off-by: Minghao Chi --- drivers/gpu/drm/omapdrm/dss/hdmi_pll.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi_pll.c b/drivers/gpu/drm/omapdrm/dss/hdmi_

[PATCH] drm/vc4: simplify the return expression of vc4_grab_bin_bo()

2022-04-29 Thread cgel . zte
From: Minghao Chi Simplify the return expression. Reported-by: Zeal Robot Signed-off-by: Minghao Chi --- drivers/gpu/drm/vc4/vc4_bo.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_bo.c b/drivers/gpu/drm/vc4/vc4_bo.c index e451cc5bcfac..49c0

[PATCH] drm: omapdrm: simplify the return expression of dss_setup_default_clock()

2022-04-29 Thread cgel . zte
From: Minghao Chi Simplify the return expression. Reported-by: Zeal Robot Signed-off-by: Minghao Chi --- drivers/gpu/drm/omapdrm/dss/dss.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/dss.c b/drivers/gpu/drm/omapdrm/dss/dss.c index 039

[PATCH] drm/nouveau: simplify the return expression of nouveau_debugfs_init()

2022-04-29 Thread cgel . zte
From: Minghao Chi Simplify the return expression. Reported-by: Zeal Robot Signed-off-by: Minghao Chi --- drivers/gpu/drm/nouveau/nouveau_debugfs.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_debugfs.c b/drivers/gpu/drm/nouveau/no

Re: [RFC] drm/kms: control display brightness through drm_connector properties

2022-04-29 Thread Pekka Paalanen
On Fri, 29 Apr 2022 08:59:24 + Simon Ser wrote: > On Friday, April 29th, 2022 at 10:55, Hans de Goede > wrote: > > > I believe that we can fix the new interface, the plan is for there > > to be some helper code to proxy the new connector properties to what > > is still a good old backlight

Re: [RFC PATCH v4 02/11] drm/fb-helper: Set FBINFO_MISC_FIRMWARE flag for DRIVER_FIRMWARE fb

2022-04-29 Thread Thomas Zimmermann
Hi Am 29.04.22 um 10:42 schrieb Javier Martinez Canillas: The DRIVER_FIRMWARE flag denotes that a DRM driver uses a framebuffer that was initialized and provided by the system firmware for scanout. Indicate to the fbdev subsystem that the registered framebuffer is a FBINFO_MISC_FIRMWARE, so tha

Re: [PATCH 1/2] module: add a function to add module references

2022-04-29 Thread Mauro Carvalho Chehab
HI Greg, Em Fri, 29 Apr 2022 10:30:33 +0200 Greg KH escreveu: > On Fri, Apr 29, 2022 at 09:07:57AM +0100, Mauro Carvalho Chehab wrote: > > Hi Daniel, > > > > Em Fri, 29 Apr 2022 09:54:10 +0200 > > Daniel Vetter escreveu: > > > > > On Fri, Apr 29, 2022 at 07:31:15AM +0100, Mauro Carvalho Che

Re: [RFC PATCH v4 02/11] drm/fb-helper: Set FBINFO_MISC_FIRMWARE flag for DRIVER_FIRMWARE fb

2022-04-29 Thread Javier Martinez Canillas
Hello Thomas, On 4/29/22 11:14, Thomas Zimmermann wrote: > Hi > > Am 29.04.22 um 10:42 schrieb Javier Martinez Canillas: >> The DRIVER_FIRMWARE flag denotes that a DRM driver uses a framebuffer >> that was initialized and provided by the system firmware for scanout. >> >> Indicate to the fbdev su

Re: [PATCH v4] drm/bridge: tc358767: Fix (e)DP bridge endpoint parsing in dedicated function

2022-04-29 Thread Lucas Stach
Am Donnerstag, dem 28.04.2022 um 23:31 +0200 schrieb Marek Vasut: > Per toshiba,tc358767.yaml DT binding document, port@2 the output (e)DP > port is optional. In case this port is not described in DT, the bridge > driver operates in DPI-to-DP mode. The drm_of_find_panel_or_bridge() > call in tc_pro

Re: [PATCH 10/11] dt-bindings: display: exynos: dsim: Add NXP i.MX8MM support

2022-04-29 Thread Jagan Teki
Hi Laurent, On Sun, Apr 10, 2022 at 11:42 PM Laurent Pinchart wrote: > > Hi Jagan, > > Thank you for the patch. > > On Fri, Apr 08, 2022 at 09:51:07PM +0530, Jagan Teki wrote: > > Samsung MIPI DSIM bridge can also be found in i.MX8MM/i.MX8MN SoC. > > > > Add dt-bingings for it. > > > > v1: > > *

Re: [PATCH v5 3/5] drm/msm/dp: set stream_pixel rate directly

2022-04-29 Thread Dmitry Baryshkov
On Fri, 29 Apr 2022 at 04:20, Stephen Boyd wrote: > > Quoting Dmitry Baryshkov (2022-02-16 21:55:27) > > The only clock for which we set the rate is the "stream_pixel". Rather > > than storing the rate and then setting it by looping over all the > > clocks, set the clock rate directly. > > > > Sig

Re: [DKIM] [PATCH v10, 00/15] media: mtk-vcodec: support for M8192 decoder

2022-04-29 Thread Hans Verkuil
Hi Yunfei, On 26/04/2022 12:08, Yunfei Dong wrote: > This series adds support for mt8192 h264/vp8/vp9 decoder drivers. Firstly, > refactor > power/clock/interrupt interfaces for mt8192 is lat and core architecture. > > Secondly, add new functions to get frame buffer size and resolution according

Re: [PATCH] drm/panel: panel-simple: Fix proper bpc for AM-1280800N3TZQW-T00H

2022-04-29 Thread Jagan Teki
Hi Robert, Can you apply this? On Thu, Mar 31, 2022 at 8:22 PM Robert Foss wrote: > > On Thu, 31 Mar 2022 at 16:50, Jagan Teki wrote: > > > > + Robert > > > > On Tue, Feb 22, 2022 at 12:17 PM Jagan Teki > > wrote: > > > > > > On Mon, Feb 7, 2022 at 6:34 PM Jagan Teki > > > wrote: > > > > >

RE: [RFC] drm/kms: control display brightness through drm_connector properties

2022-04-29 Thread Lattannavar, Sameer
Yes we would need this. -Sameer -Original Message- From: wayland-devel On Behalf Of Pekka Paalanen Sent: Friday, April 29, 2022 2:37 PM To: Hans de Goede Cc: Jani Nikula ; Sebastian Wick ; Martin Roukala ; Christoph Grenz ; wayland ; dri-devel@lists.freedesktop.org; Daniel Vetter ;

[PATCH 1/2] drm/i915: Enable THP on Icelake and beyond

2022-04-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We have a statement from HW designers that the GPU read regression when using 2M pages was fixed from Icelake onwards, which was also confirmed by bencharking Eero did last year: """ When IOMMU is disabled, enabling THP causes following perf changes on TGL-H (GT1): 10-1

[PATCH 2/2] drm/i915: Only setup private tmpfs mount when needed and fix logging

2022-04-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin If i915 does not want to use huge pages there is a) no point in setting up the private mount and b) should former fail, it is misleading to log THP support is disabled in the caller, which does not even know if callee tried to enable it. Fix both by restructuring the flow in

[PATCH v4 1/5] fbdev: Put mmap for deferred I/O into drivers

2022-04-29 Thread Thomas Zimmermann
The fbdev mmap function fb_mmap() unconditionally overrides the driver's implementation if deferred I/O has been activated. This makes it hard to implement mmap with anything but a vmalloc()'ed software buffer. That is specifically a problem for DRM, where video memory is maintained by a memory man

[PATCH v4 0/5] fbdev: Decouple deferred I/O from struct page

2022-04-29 Thread Thomas Zimmermann
Rework the fbdev deferred-I/O to not interfere with fields of struct page. All references from deferred-I/O code to fields in struct page are gone. The rsp state is held in a separate pageref structure. v4: * fix locking in fb_mmap() (Dan) * fix commit-message style (Javier) v3:

[PATCH v4 5/5] fbdev: Use pageref offset for deferred-I/O writeback

2022-04-29 Thread Thomas Zimmermann
Use pageref->offset instead of page->index for deferred-I/O writeback where appropriate. Distinguishes between file-mapping offset and video- memory offset. While at it, also remove unnecessary references to struct page. Fbdev's deferred-I/O code uses the two related page->index and pageref->offse

[PATCH v4 2/5] fbdev: Track deferred-I/O pages in pageref struct

2022-04-29 Thread Thomas Zimmermann
Store the per-page state for fbdev's deferred I/O in struct fb_deferred_io_pageref. Maintain a list of pagerefs for the pages that have to be written back to video memory. Update all affected drivers. As with pages before, fbdev acquires a pageref when an mmaped page of the framebuffer is being wr

[PATCH v4 3/5] fbdev: Refactor implementation of page_mkwrite

2022-04-29 Thread Thomas Zimmermann
Refactor the page-write handler for deferred I/O. Drivers use the function to let fbdev track written pages of mmap'ed framebuffer memory. v3: * keep locking within track-pages function for readability (Sam) v2: * don't export the helper until we have an external caller Signed-off

[PATCH v4 4/5] fbdev: Rename pagelist to pagereflist for deferred I/O

2022-04-29 Thread Thomas Zimmermann
Rename various instances of pagelist to pagereflist. The list now stores pageref structures, so the new name is more appropriate. In their write-back helpers, several fbdev drivers refer to the pageref list in struct fb_deferred_io instead of using the one supplied as argument to the function. Con

Re: [PATCH 1/2] module: add a function to add module references

2022-04-29 Thread Greg KH
On Fri, Apr 29, 2022 at 10:15:03AM +0100, Mauro Carvalho Chehab wrote: > HI Greg, > > Em Fri, 29 Apr 2022 10:30:33 +0200 > Greg KH escreveu: > > > On Fri, Apr 29, 2022 at 09:07:57AM +0100, Mauro Carvalho Chehab wrote: > > > Hi Daniel, > > > > > > Em Fri, 29 Apr 2022 09:54:10 +0200 > > > Daniel

Re: [RFC PATCH v4 02/11] drm/fb-helper: Set FBINFO_MISC_FIRMWARE flag for DRIVER_FIRMWARE fb

2022-04-29 Thread Thomas Zimmermann
Hi Javier Am 29.04.22 um 11:23 schrieb Javier Martinez Canillas: Hello Thomas, On 4/29/22 11:14, Thomas Zimmermann wrote: Hi Am 29.04.22 um 10:42 schrieb Javier Martinez Canillas: The DRIVER_FIRMWARE flag denotes that a DRM driver uses a framebuffer that was initialized and provided by the s

Re: [PATCH 1/2] module: add a function to add module references

2022-04-29 Thread Mauro Carvalho Chehab
Em Fri, 29 Apr 2022 12:10:07 +0200 Greg KH escreveu: > On Fri, Apr 29, 2022 at 10:15:03AM +0100, Mauro Carvalho Chehab wrote: > > HI Greg, > > > > Em Fri, 29 Apr 2022 10:30:33 +0200 > > Greg KH escreveu: > > > > > On Fri, Apr 29, 2022 at 09:07:57AM +0100, Mauro Carvalho Chehab wrote: > > >

Re: [PATCH] omapdss: HDMI: simplify the return expression of hdmi_init_pll_data()

2022-04-29 Thread Tomi Valkeinen
On 29/04/2022 12:01, cgel@gmail.com wrote: From: Minghao Chi Simplify the return expression. Reported-by: Zeal Robot Signed-off-by: Minghao Chi --- drivers/gpu/drm/omapdrm/dss/hdmi_pll.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/

Re: [PATCH 1/2] module: add a function to add module references

2022-04-29 Thread Greg KH
On Fri, Apr 29, 2022 at 11:23:51AM +0100, Mauro Carvalho Chehab wrote: > Em Fri, 29 Apr 2022 12:10:07 +0200 > Greg KH escreveu: > > > On Fri, Apr 29, 2022 at 10:15:03AM +0100, Mauro Carvalho Chehab wrote: > > > HI Greg, > > > > > > Em Fri, 29 Apr 2022 10:30:33 +0200 > > > Greg KH escreveu: > >

Re: [PULL] gvt-next-2022-04-29

2022-04-29 Thread Jani Nikula
On Thu, 28 Apr 2022, "Wang, Zhi A" wrote: > Hi folks: > > Here is the pull of gvt-next which fixes the compilation error and warnings > for the the GVT-g refactor patches: > > - Fix a compiling warning of non-static function only having one caller. > - Fix a potential NULL pointer reference in th

Re: linux-next: manual merge of the amdgpu tree with the drm-misc tree

2022-04-29 Thread Christian König
Am 29.04.22 um 03:13 schrieb Stephen Rothwell: Hi all, On Wed, 13 Apr 2022 10:10:14 +1000 Stephen Rothwell wrote: On Wed, 6 Apr 2022 10:34:05 +1000 Stephen Rothwell wrote: Today's linux-next merge of the amdgpu tree got a conflict in: drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c between com

Re: [RFC PATCH v4 02/11] drm/fb-helper: Set FBINFO_MISC_FIRMWARE flag for DRIVER_FIRMWARE fb

2022-04-29 Thread Javier Martinez Canillas
On 4/29/22 12:20, Thomas Zimmermann wrote: > Hi Javier [snip] >> >>> We can do this with DRIVER_FIRMWARE. Alternatively, I'd suggest to we >>> could also used the existing final parameter of >>> drm_fbdev_generic_setup() to pass a flag that designates a firmware device. >>> >> >> By existing f

Re: [PATCH 1/2] drm/edid: fix kernel-doc parameter name mismatches

2022-04-29 Thread Jani Nikula
On Tue, 26 Apr 2022, Jani Nikula wrote: > Fix the below drm/edid kernel-doc warnings: > > drivers/gpu/drm/drm_edid.c:1589: warning: Function parameter or member > '_edid' not described in 'drm_edid_header_is_valid' > drivers/gpu/drm/drm_edid.c:1589: warning: Excess function parameter > 'raw_edid

Re: [Intel-gfx] [PATCH 1/3] drm/i915/xehpsdv/dg1/tgl: Fix issue with LRI relative addressing

2022-04-29 Thread Matthew Auld
On Mon, 25 Apr 2022 at 16:22, Ramalingam C wrote: > > From: Akeem G Abodunrin > > When bit 19 of MI_LOAD_REGISTER_IMM instruction opcode is set on tgl+ > devices, HW does not care about certain register address offsets, but > instead check the following for valid address ranges on specific engine

Re: [PATCH resend v8 1/5] drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_mode_set()

2022-04-29 Thread Liu Ying
Hi, On Fri, 2022-04-22 at 19:24 +0200, Guido Günther wrote: > Hi, > On Tue, Apr 19, 2022 at 09:08:48AM +0800, Liu Ying wrote: > > The Northwest Logic MIPI DSI host controller embedded in i.MX8qxp > > works with a Mixel MIPI DPHY + LVDS PHY combo to support either > > a MIPI DSI display or a LVDS d

Re: [PATCH v5 6/9] drm: vkms: Refactor the plane composer to accept new formats

2022-04-29 Thread Pekka Paalanen
On Wed, 27 Apr 2022 21:44:34 -0300 Igor Torrente wrote: > On 4/27/22 04:43, Pekka Paalanen wrote: > > On Tue, 26 Apr 2022 22:22:22 -0300 > > Igor Torrente wrote: > > > >> On April 26, 2022 10:03:09 PM GMT-03:00, Igor Torrente > >> wrote: > >>> > >>> > >>> On 4/25/22 22:54, Igor Torrente w

Re: [PATCH 2/3] drm/i915/selftests: Skip poisoning SET_PREDICATE_RESULT on dg2

2022-04-29 Thread Matthew Auld
On Mon, 25 Apr 2022 at 16:22, Ramalingam C wrote: > > From: Chris Wilson > > When predication is enabled all commands baring a few (such as MI_BB_END) > are nop'ed. If we accidentally enable predication while poisoning the > context, not only is the rest of the poisoning skipped (thus disabling >

[Bug 201991] amdgpu: clock management is disabled for the 4K resolution with polaris 10

2022-04-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201991 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC||alexdeuc...@gmail.c

[PATCH 1/4] drm: handle kernel fences in drm_gem_plane_helper_prepare_fb v2

2022-04-29 Thread Christian König
drm_gem_plane_helper_prepare_fb() was using drm_atomic_set_fence_for_plane() which ignores all implicit fences when an explicit fence is already set. That's rather unfortunate when the fb still has a kernel fence we need to wait for to avoid presenting garbage on the screen. So instead update the

[PATCH 2/4] drm/amdgpu: switch DM to atomic fence helpers

2022-04-29 Thread Christian König
This gives us the standard atomic implicit and explicit fencing rules. Signed-off-by: Christian König Cc: Harry Wentland Cc: Nicholas Kazlauskas Cc: Roman Li Cc: Qingqing Zhuo Cc: Jude Shih Cc: Wayne Lin Cc: Rodrigo Siqueira --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 23 -

[PATCH 3/4] drm/nouveau: use drm_gem_plane_helper_prepare_fb

2022-04-29 Thread Christian König
Instead of manually adjusting the plane state. Signed-off-by: Christian König Cc: Karol Herbst Cc: Lyude Paul Cc: Ben Skeggs Cc: Maxime Ripard --- drivers/gpu/drm/nouveau/dispnv50/wndw.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/nouveau/dispnv50

[PATCH 4/4] drm/qxl: add drm_gem_plane_helper_prepare_fb

2022-04-29 Thread Christian König
We could need to wait for the pin to complete here. Signed-off-by: Christian König Cc: Dave Airlie Cc: Gerd Hoffmann Cc: virtualizat...@lists.linux-foundation.org Cc: spice-de...@lists.freedesktop.org --- drivers/gpu/drm/qxl/qxl_display.c | 8 +++- 1 file changed, 7 insertions(+), 1 deleti

Re: [Intel-gfx] [PATCH 3/3] drm/i915/gt: Clear SET_PREDICATE_RESULT prior to executing the ring

2022-04-29 Thread Matthew Auld
On Mon, 25 Apr 2022 at 16:22, Ramalingam C wrote: > > From: Chris Wilson > > Userspace may leave predication enabled upon return from the batch > buffer, which has the consequent of preventing all operation from the > ring from being executed, including all the synchronisation, coherency > contro

Re: [PATCH v2] drm: mxsfb: Implement LCDIF scanout CRC32 support

2022-04-29 Thread Lucas Stach
Am Montag, dem 11.04.2022 um 22:35 +0200 schrieb Marek Vasut: > The LCDIF controller as present in i.MX28/i.MX6SX/i.MX8M Mini/Nano has > CRC_STAT register, which contains CRC32 of the frame as it was clocked > out of the DPI interface of the LCDIF. This is most likely meant as a > functional safety

[CI] drm/i915: Fix assert in i915_ggtt_pin

2022-04-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Use lockdep_assert_not_held to simplify and correct the code. Otherwise false positive are hit if lock state is uknown like after a previous taint. Signed-off-by: Tvrtko Ursulin Reported-by: Ville Syrjälä Reviewed-by: Ville Syrjälä --- It's not pretty but it fired again a

Re: [PATCH v2] drm: mxsfb: Implement LCDIF scanout CRC32 support

2022-04-29 Thread Stefan Agner
On 2022-04-11 22:35, Marek Vasut wrote: > The LCDIF controller as present in i.MX28/i.MX6SX/i.MX8M Mini/Nano has > CRC_STAT register, which contains CRC32 of the frame as it was clocked > out of the DPI interface of the LCDIF. This is most likely meant as a > functional safety feature. > > Unfortu

RE: [Intel-gfx] [V2 1/3] drm/debug: Expose connector's max supported bpc via debugfs

2022-04-29 Thread Murthy, Arun R
> +static int output_bpc_show(struct seq_file *m, void *data) { Can we have a meaningful name instead of 'm' ? Upon changing this parameter name, you can have my Reviewed-By: Arun R Murthy Thanks and Regards, Arun R Murthy

RE: [Intel-gfx] [V2 3/3] drm/amd/display: Move connector debugfs to drm

2022-04-29 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of > Bhanuprakash Modem > Sent: Monday, April 11, 2022 3:21 PM > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; amd- > g...@lists.freedesktop.org; jani.nik...@linux.intel.com; > ville.syrj...@linux.intel.com; harry.

Re: (subset) [PATCH] drm/vc4: simplify the return expression of vc4_grab_bin_bo()

2022-04-29 Thread Maxime Ripard
On Fri, 29 Apr 2022 09:02:08 +, cgel@gmail.com wrote: > From: Minghao Chi > > Simplify the return expression. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: (subset) [PATCH] drm/vc4: simplify the return expression of vc4_prepare_fb()

2022-04-29 Thread Maxime Ripard
On Fri, 29 Apr 2022 05:49:45 +, cgel@gmail.com wrote: > From: Minghao Chi > > Simplify the return expression. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: (subset) [PATCH] drm/sun4i: dsi: delete unnecessary IS_ERR() checks

2022-04-29 Thread Maxime Ripard
On Thu, 28 Apr 2022 15:26:23 +0300, Dan Carpenter wrote: > The "dsi->bus_clk" pointer cannot be an error pointer at this point. > The check is confusing and unnecessary. Delete it. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

[pull] amdgpu, amdkfd, radeon drm-next-5.19

2022-04-29 Thread Alex Deucher
Hi Dave, Daniel, More stuff for 5.19. The following changes since commit e15c9d06e9ad70df41285ca41d535de6215e0b21: drm/amd/amdgpu: Update PF2VF header (2022-04-21 16:00:14 -0400) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-next-5.19-

Re: [PATCH] drm/amdgpu: simplify the return expression of iceland_ih_hw_init

2022-04-29 Thread Alex Deucher
Applied. Thanks! On Fri, Apr 29, 2022 at 1:48 AM wrote: > > From: Minghao Chi > > Simplify the return expression. > > Reported-by: Zeal Robot > Signed-off-by: Minghao Chi > --- > drivers/gpu/drm/amd/amdgpu/iceland_ih.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --

Re: [PATCH] drm/amdgpu: simplify the return expression of navi10_ih_hw_init()

2022-04-29 Thread Alex Deucher
Applied. Thanks! On Fri, Apr 29, 2022 at 1:50 AM wrote: > > From: Minghao Chi > > Simplify the return expression. > > Reported-by: Zeal Robot > Signed-off-by: Minghao Chi > --- > drivers/gpu/drm/amd/amdgpu/navi10_ih.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --g

Re: [PATCH] gpu/drm/radeon: Fix spelling typo in comments

2022-04-29 Thread Alex Deucher
Applied. Thanks! On Fri, Apr 29, 2022 at 9:04 AM pengfuyuan wrote: > > Fix spelling typo in comments. > > Signed-off-by: pengfuyuan > --- > drivers/gpu/drm/radeon/atombios.h | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/atombios.h >

Re: [PATCH 2/2] Revert "drm: of: Lookup if child node has panel or bridge"

2022-04-29 Thread Maxime Ripard
On Fri, Apr 29, 2022 at 01:17:26AM +0300, Laurent Pinchart wrote: > Hi Jagan, > > On Thu, Apr 28, 2022 at 02:09:42PM +0530, Jagan Teki wrote: > > On Wed, Apr 27, 2022 at 8:04 PM Maxime Ripard wrote: > > > On Tue, Apr 26, 2022 at 01:40:31PM +0530, Jagan Teki wrote: > > > > On Tue, Apr 26, 2022 at 1

Re: [Intel-gfx] [PATCH 1/2] module: add a function to add module references

2022-04-29 Thread Lucas De Marchi
On Fri, Apr 29, 2022 at 11:23:51AM +0100, Mauro Carvalho Chehab wrote: Em Fri, 29 Apr 2022 12:10:07 +0200 Greg KH escreveu: On Fri, Apr 29, 2022 at 10:15:03AM +0100, Mauro Carvalho Chehab wrote: > HI Greg, > > Em Fri, 29 Apr 2022 10:30:33 +0200 > Greg KH escreveu: > > > On Fri, Apr 29, 2022 a

Re: [PATCH 2/2] Revert "drm: of: Lookup if child node has panel or bridge"

2022-04-29 Thread Laurent Pinchart
Hi Maxime, On Fri, Apr 29, 2022 at 05:46:45PM +0200, Maxime Ripard wrote: > On Fri, Apr 29, 2022 at 01:17:26AM +0300, Laurent Pinchart wrote: > > On Thu, Apr 28, 2022 at 02:09:42PM +0530, Jagan Teki wrote: > > > On Wed, Apr 27, 2022 at 8:04 PM Maxime Ripard wrote: > > > > On Tue, Apr 26, 2022 at 0

[PATCHv5] drm/amdgpu: vi: disable ASPM on Intel Alder Lake based systems

2022-04-29 Thread Richard Gong
Active State Power Management (ASPM) feature is enabled since kernel 5.14. There are some AMD Volcanic Islands (VI) GFX cards, such as the WX3200 and RX640, that do not work with ASPM-enabled Intel Alder Lake based systems. Using these GFX cards as video/display output, Intel Alder Lake based syste

Re: [PATCHv5] drm/amdgpu: vi: disable ASPM on Intel Alder Lake based systems

2022-04-29 Thread Alex Deucher
Reviewed-by: Alex Deucher On Fri, Apr 29, 2022 at 12:08 PM Richard Gong wrote: > > Active State Power Management (ASPM) feature is enabled since kernel 5.14. > There are some AMD Volcanic Islands (VI) GFX cards, such as the WX3200 and > RX640, that do not work with ASPM-enabled Intel Alder Lake

Re: [PATCH] drm/bridge: simplify the return expression of ps8640_bridge_host_attach

2022-04-29 Thread Doug Anderson
Hi, On Thu, Apr 28, 2022 at 10:51 PM wrote: > > From: Minghao Chi > > Simplify the return expression. > > Reported-by: Zeal Robot > Signed-off-by: Minghao Chi > --- > drivers/gpu/drm/bridge/parade-ps8640.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) Reviewed-by: Douglas And

Re: [PATCH] gpu: drm: remove redundant dma_fence_put() when drm_sched_job_add_dependency() fails

2022-04-29 Thread Andrey Grodzovsky
Now it's easy to see it's redundant, it's a problematic design where the fence 'get' part is happening outside the job->dependencies array logic but the fence 'put' part is happening inside, leads to confusions such as adding this 'put' in the first place. I will look into improving this if pos

[PATCH v3 2/2] drm/panel: simple: Add Startek KD070WVFPA043-C069A panel support

2022-04-29 Thread Fabio Estevam
From: Heiko Schocher Add Startek KD070WVFPA043-C069A 7" TFT LCD panel support. Signed-off-by: Heiko Schocher [fabio: passed .flags and .bus_flags] Signed-off-by: Fabio Estevam Acked-by: Sam Ravnborg --- Changes since v2: - Pass the full flags and bus_flags. drivers/gpu/drm/panel/panel-simpl

[PATCH v3 1/2] dt-bindings: display: simple: Add Startek KD070WVFPA043-C069A panel

2022-04-29 Thread Fabio Estevam
From: Fabio Estevam Add Startek KD070WVFPA043-C069A 7" TFT LCD panel compatible string. Signed-off-by: Fabio Estevam Acked-by: Sam Ravnborg --- Changes since v2: - None .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Docum

Re: [PATCH v3 2/2] drm/panel: simple: Add Startek KD070WVFPA043-C069A panel support

2022-04-29 Thread Marek Vasut
On 4/29/22 19:20, Fabio Estevam wrote: From: Heiko Schocher Add Startek KD070WVFPA043-C069A 7" TFT LCD panel support. Signed-off-by: Heiko Schocher [fabio: passed .flags and .bus_flags] Signed-off-by: Fabio Estevam Acked-by: Sam Ravnborg Reviewed-by: Marek Vasut

Re: [PATCH v3 1/2] dt-bindings: display: simple: Add Startek KD070WVFPA043-C069A panel

2022-04-29 Thread Marek Vasut
On 4/29/22 19:20, Fabio Estevam wrote: From: Fabio Estevam Add Startek KD070WVFPA043-C069A 7" TFT LCD panel compatible string. Signed-off-by: Fabio Estevam Acked-by: Sam Ravnborg --- Changes since v2: - None .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file c

Re: [PATCH v2 0/7] Make the rest of the VFIO driver interface use vfio_device

2022-04-29 Thread Jason Gunthorpe
On Thu, Apr 21, 2022 at 01:28:31PM -0300, Jason Gunthorpe wrote: > Prior series have transformed other parts of VFIO from working on struct > device or struct vfio_group into working directly on struct > vfio_device. Based on that work we now have vfio_device's readily > available in all the driver

[PATCH] MAINTAINERS: Add Dmitry as MSM DRM driver co-maintainer

2022-04-29 Thread Dmitry Baryshkov
For the past several releases I have been assisting Rob by writing, collecting, testing and integrating patches for non-GPU and non-core parts of MSM DRM driver, while Rob is more interested in improving the GPU-related part. Let's note this in the MAINTAINERS file. Signed-off-by: Dmitry Baryshkov

[PATCH v3 0/4] lrc selftest fixes

2022-04-29 Thread Ramalingam C
Few bug fixes for lrc selftest. v3: Extending the first patch for gen8 Chris Wilson (4): drm/i915/gt: Explicitly clear BB_OFFSET for new contexts drm/i915/selftests: Check for incomplete LRI from the context image drm/i915/selftest: Always cancel semaphore on error drm/i915/selftest: Cl

[PATCH v3 1/4] drm/i915/gt: Explicitly clear BB_OFFSET for new contexts

2022-04-29 Thread Ramalingam C
From: Chris Wilson Even though the initial protocontext we load onto HW has the register cleared, by the time we save it into the default image, BB_OFFSET has had the enable bit set. Reclear BB_OFFSET for each new context. Testcase: igt/i915_selftests/gt_lrc v2: Extend it for gen8. Signed-of

[PATCH v3 2/4] drm/i915/selftests: Check for incomplete LRI from the context image

2022-04-29 Thread Ramalingam C
From: Chris Wilson In order to keep the context image parser simple, we assume that all commands follow a similar format. A few, especially not MI commands on the render engines, have fixed lengths not encoded in a length field. This caused us to incorrectly skip over 3D state commands, and start

[PATCH v3 3/4] drm/i915/selftest: Always cancel semaphore on error

2022-04-29 Thread Ramalingam C
From: Chris Wilson Ensure that we always signal the semaphore when timing out, so that if it happens to be stuck waiting for the semaphore we will quickly recover without having to wait for a reset. Reported-by: CQ Tang Signed-off-by: Chris Wilson Cc: CQ Tang cc: Joonas Lahtinen Signed-off-b

  1   2   >