Re: [PATCH] drm/tilcdc: fix typos in comment

2022-04-25 Thread Jyri Sarha
On 2022-04-22 14:09, brookxu.cn wrote: From: Chunguang Xu Fix typos in comment. Signed-off-by: Chunguang Xu Pushed to drm-misc-next. Thanks, Jyri --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_cr

Re: [PATCH] drm/v3d: Fix null pointer dereference of pointer perfmon

2022-04-25 Thread Juan A.
On Sun, 2022-04-24 at 19:35 +0100, Colin Ian King wrote: > In the unlikely event that pointer perfmon is null the WARN_ON return > path > occurs after the pointer has already been deferenced. Fix this by > only > dereferencing perfmon after it has been null checked. > Good catch! Reviewed-by: Ju

Re: [PATCH v5 5/9] drm: vkms: Add fb information to `vkms_writeback_job`

2022-04-25 Thread Pekka Paalanen
On Sat, 23 Apr 2022 12:12:51 -0300 Igor Torrente wrote: > Hi Pekka, > > On 4/20/22 08:23, Pekka Paalanen wrote: > > On Mon, 4 Apr 2022 17:45:11 -0300 > > Igor Torrente wrote: > > > >> This commit is the groundwork to introduce new formats to the planes and > >> writeback buffer. As part of

[PATCH v2 1/3] drm/format-helper: Print warning on missing format conversion

2022-04-25 Thread Thomas Zimmermann
Not all possible format conversions are supported yet. Print a warning on unsupported combinations. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/drm_format_helper.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_format_he

[PATCH v2 0/3] drm/format-helper: Support conversion to XRGB8888

2022-04-25 Thread Thomas Zimmermann
Support conversion from RGB565 and RGB888 to XRGB. This enables simpledrm to work with framebuffers of such formats. UEFI and/or Grub will usually set 32-bit output in XRGB format. The issue can be reproduced by enabling simpledrm and requesting a console framebuffer of different format on

[PATCH v2 3/3] drm/format-helper: Add RGB565-to-XRGB8888 conversion

2022-04-25 Thread Thomas Zimmermann
Add a format helper that converts RGB565 to XRGB. Use this function in drm_fb_blit_toio(). Fixes simpledrm output for this combination of formats. UEFI and/or Grub will usually set 32-bit output in XRGB format. The issue can be reproduced by enabling simpledrm and requesting a console fram

[PATCH v2 2/3] drm/format-helper: Add RGB888-to-XRGB8888 conversion

2022-04-25 Thread Thomas Zimmermann
Add a format helper that converts RGB888 to XRGB. Use this function in drm_fb_blit_toio(). Fixes simpledrm output for this combination of formats. UEFI and/or Grub will usually set 32-bit output in XRGB format. The issue can be reproduced by enabling simpledrm and requesting a console fram

Re: [PATCH v3 1/5] firmware: sysfb: Make sysfb_create_simplefb() return a pdev pointer

2022-04-25 Thread Thomas Zimmermann
Am 20.04.22 um 10:52 schrieb Javier Martinez Canillas: This function just returned 0 on success or an errno code on error, but it could be useful for sysfb_init() callers to have a pointer to the device. Signed-off-by: Javier Martinez Canillas Reviewed-by: Daniel Vetter Reviewed-by: Thomas

Re: [PATCH v5 6/9] drm: vkms: Refactor the plane composer to accept new formats

2022-04-25 Thread Pekka Paalanen
On Sat, 23 Apr 2022 15:53:20 -0300 Igor Torrente wrote: > I forgot to respond some points from your review. > > On 4/23/22 13:04, Igor Torrente wrote: > > Hi Pekka, > > > > On 4/20/22 09:36, Pekka Paalanen wrote: > >> On Mon, 4 Apr 2022 17:45:12 -0300 > >> Igor Torrente wrote: > >> > >>>

Re: [PATCH v3 2/5] firmware: sysfb: Add helpers to unregister a pdev and disable registration

2022-04-25 Thread Thomas Zimmermann
Hi Am 20.04.22 um 10:53 schrieb Javier Martinez Canillas: These can be used by subsystems to unregister a platform device registered by sysfb and also to disable future platform device registration in sysfb. Suggested-by: Daniel Vetter Signed-off-by: Javier Martinez Canillas Reviewed-by: Dani

Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type

2022-04-25 Thread Chen-Yu Tsai
On Fri, Apr 22, 2022 at 10:13 PM Robert Foss wrote: > > On Fri, 22 Apr 2022 at 16:01, Robert Foss wrote: > > > > On Fri, 22 Apr 2022 at 10:49, Xin Ji wrote: > > > > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI > > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE

Re: [PATCH v3 3/5] fbdev: Restart conflicting fb removal loop when unregistering devices

2022-04-25 Thread Thomas Zimmermann
Hi Am 20.04.22 um 10:53 schrieb Javier Martinez Canillas: Drivers that want to remove registered conflicting framebuffers prior to register their own framebuffer, calls remove_conflicting_framebuffers(). This function takes the registration_lock mutex, to prevent a races when drivers register f

Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type

2022-04-25 Thread Chen-Yu Tsai
On Mon, Apr 25, 2022 at 4:24 PM Chen-Yu Tsai wrote: > > On Fri, Apr 22, 2022 at 10:13 PM Robert Foss wrote: > > > > On Fri, 22 Apr 2022 at 16:01, Robert Foss wrote: > > > > > > On Fri, 22 Apr 2022 at 10:49, Xin Ji wrote: > > > > > > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for

Re: [PATCH v3 4/5] fbdev: Fix some race conditions between fbmem and sysfb

2022-04-25 Thread Thomas Zimmermann
Hi Am 20.04.22 um 10:53 schrieb Javier Martinez Canillas: The platform devices registered in sysfb match with a firmware-based fbdev or DRM driver, that are used to have early graphics using framebuffers set up by the system firmware. Real DRM drivers later are probed and remove all conflicting

Re: [PATCH v3 3/5] fbdev: Restart conflicting fb removal loop when unregistering devices

2022-04-25 Thread Javier Martinez Canillas
Hello Thomas, Thanks for the feedback. On 4/25/22 10:27, Thomas Zimmermann wrote: > Hi > > Am 20.04.22 um 10:53 schrieb Javier Martinez Canillas: >> Drivers that want to remove registered conflicting framebuffers prior to >> register their own framebuffer, calls remove_conflicting_framebuffers()

Re: [PATCH v3 0/5] Fix some race conditions that exists between fbmem and sysfb

2022-04-25 Thread Thomas Zimmermann
Hi Am 20.04.22 um 10:52 schrieb Javier Martinez Canillas: Hello, The patches in this series are mostly changes suggested by Daniel Vetter to fix some race conditions that exists between the fbdev core (fbmem) and sysfb with regard to device registration and removal. For example, it is currentl

[PATCH] drm/msm/dpu: fix error check return value of irq_of_parse_and_map()

2022-04-25 Thread cgel . zte
From: Lv Ruyi The irq_of_parse_and_map() function returns 0 on failure, and does not return a negative value anyhow, so never enter this conditional branch. Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") Reported-by: Zeal Robot Signed-off-by: Lv Ruyi --- drivers/gpu/drm/msm/disp/dpu1

Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type

2022-04-25 Thread Xin Ji
On Mon, Apr 25, 2022 at 04:24:50PM +0800, Chen-Yu Tsai wrote: > On Fri, Apr 22, 2022 at 10:13 PM Robert Foss wrote: > > > > On Fri, 22 Apr 2022 at 16:01, Robert Foss wrote: > > > > > > On Fri, 22 Apr 2022 at 10:49, Xin Ji wrote: > > > > > > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descr

Re: [PATCH v3 0/5] Fix some race conditions that exists between fbmem and sysfb

2022-04-25 Thread Thomas Zimmermann
Hi Am 25.04.22 um 10:54 schrieb Thomas Zimmermann: Hi Am 20.04.22 um 10:52 schrieb Javier Martinez Canillas: Hello, The patches in this series are mostly changes suggested by Daniel Vetter to fix some race conditions that exists between the fbdev core (fbmem) and sysfb with regard to device r

[PATCH] drm/msm/hdmi: fix error check return value of irq_of_parse_and_map()

2022-04-25 Thread cgel . zte
From: Lv Ruyi The irq_of_parse_and_map() function returns 0 on failure, and does not return a negative value anyhow, so never enter this conditional branch. Fixes: f6a8eaca0ea1 ("drm/msm/mdp5: use irqdomains") Reported-by: Zeal Robot Signed-off-by: Lv Ruyi --- drivers/gpu/drm/msm/hdmi/hdmi.c

Re: [PATCH] drm: rcar-du: Drop file name from comment header blocks

2022-04-25 Thread Geert Uytterhoeven
On Sun, Apr 24, 2022 at 11:46 PM Laurent Pinchart wrote: > The comment blocks at the beginning of each file have a one-line > summary description of the file that includes the file name. While the > description is useful, the file name only creates opportunities for > mistakes (as seen in rcar_du_

RE: [PATCH v9 1/4] drm/msm/dp: Add eDP support via aux_bus

2022-04-25 Thread Sankeerth Billakanti (QUIC)
Hi Stephen, >Quoting Sankeerth Billakanti (2022-04-22 02:11:03) >> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c >> b/drivers/gpu/drm/msm/dp/dp_display.c >> index d7a19d6..055681a 100644 >> --- a/drivers/gpu/drm/msm/dp/dp_display.c >> +++ b/drivers/gpu/drm/msm/dp/dp_display.c > >Some nitpicks >

Re: [PATCH v3 0/5] Fix some race conditions that exists between fbmem and sysfb

2022-04-25 Thread Javier Martinez Canillas
Hello Thomas, Thanks for the feedback. It was very useful. On 4/25/22 11:15, Thomas Zimmermann wrote: > Hi > > Am 25.04.22 um 10:54 schrieb Thomas Zimmermann: >> Hi >> >> Am 20.04.22 um 10:52 schrieb Javier Martinez Canillas: >>> Hello, >>> >>> The patches in this series are mostly changes sugge

Re: [PATCH v17 03/21] dt-bindings: mediatek: add ethdr definition for mt8195

2022-04-25 Thread Philipp Zabel
Hi Nancy, On Sa, 2022-04-16 at 10:07 +0800, Nancy.Lin wrote: > Add vdosys1 ETHDR definition. > > Signed-off-by: Nancy.Lin > Reviewed-by: Chun-Kuang Hu > Reviewed-by: AngeloGioacchino Del Regno > > --- >  .../display/mediatek/mediatek,ethdr.yaml | 158 ++ >  1 file changed,

Re: [PATCH v17 13/21] drm/mediatek: add display merge async reset control

2022-04-25 Thread Philipp Zabel
On Sa, 2022-04-16 at 10:07 +0800, Nancy.Lin wrote: > Add merge async reset control in mtk_merge_stop. Async hw doesn't do self > reset on each sof signal(start of frame), so need to reset the async to > clear the hw status for the next merge start. > > Signed-off-by: Nancy.Lin > Reviewed-by: CK H

Re: [PATCH v17 14/21] drm/mediatek: add ETHDR support for MT8195

2022-04-25 Thread Philipp Zabel
On Sa, 2022-04-16 at 10:07 +0800, Nancy.Lin wrote: > ETHDR is a part of ovl_adaptor. > ETHDR is designed for HDR video and graphics conversion in the external > display path. It handles multiple HDR input types and performs tone > mapping, color space/color format conversion, and then combine > dif

Re: [PATCH 5.10.y] drm/cirrus: fix a NULL vs IS_ERR() checks

2022-04-25 Thread Greg Kroah-Hartman
On Sun, Apr 24, 2022 at 11:27:17AM +0800, Shile Zhang wrote: > Hi David and Daniel, > > Sorry but could you please help to check this issue? > Due to the function 'drm_gem_shmem_vmap' could return ERROR pointers which > will cause the kernel crash due to 'cirrus_fb_blit_rect' only check the > poin

Re: [PATCH 1/2] drm/i915/xehp: Add compute engine ABI

2022-04-25 Thread Tvrtko Ursulin
On 22/04/2022 20:50, Matt Roper wrote: We're now ready to start exposing compute engines to userspace. While we're at it, let's extend the kerneldoc description for the other engine types as well. Cc: Daniele Ceraolo Spurio Cc: Tvrtko Ursulin Cc: Vinay Belgaumkar Cc: Jordan Justen Cc: Szy

Re: [Freedreno] [PATCH v4 03/20] drm: allow real encoder to be passed for drm_writeback_connector

2022-04-25 Thread Dmitry Baryshkov
On Sun, 24 Apr 2022 at 22:59, Laurent Pinchart wrote: > > Hi Abhinav, > > On Sun, Apr 24, 2022 at 11:23:20AM -0700, Abhinav Kumar wrote: > > On 4/24/2022 11:12 AM, Abhinav Kumar wrote: > > > On 4/24/2022 7:50 AM, Laurent Pinchart wrote: > > >> On Fri, Apr 22, 2022 at 04:06:38PM -0700, Abhinav Kuma

[PATCH v2 0/3] fbdev: Decouple deferred I/O from struct page

2022-04-25 Thread Thomas Zimmermann
Rework the fbdev deferred-I/O to not interfere with fields of struct page. All references from deferred-I/O code to fields in struct page are gone. The rsp state is help in a separate pageref structure. Version 1 of this patchset was part of a larger attempt to improve GEM SHMEM support. [1] The p

[PATCH v2 1/3] fbdev: Put mmap for deferred I/O into drivers

2022-04-25 Thread Thomas Zimmermann
The fbdev mmap function fb_mmap() unconditionally overrides the driver's implementation if deferred I/O has been activated. This makes it hard to implement mmap with anything but a vmalloc()'ed software buffer. That is specifically a problem for DRM, where video memory is maintained by a memory man

[PATCH v2 2/3] fbdev: Track deferred-I/O pages in pageref struct

2022-04-25 Thread Thomas Zimmermann
Store the per-page state for fbdev's deferred I/O in struct fb_deferred_io_pageref. Maintain a list of pagerefs for the pages that have to be written back to video memory. Update all affected drivers. As with pages before, fbdev acquires a pageref when an mmaped page of the framebuffer is being wr

[PATCH v2 3/3] fbdev: Refactor implementation of page_mkwrite

2022-04-25 Thread Thomas Zimmermann
Refactor the page-write handler for deferred I/O. Drivers use the function to let fbdev track written pages of mmap'ed framebuffer memory. v2: * don't export the helper until we have an external caller Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/v

Re: [PULL v3] gvt-next

2022-04-25 Thread Jani Nikula
On Thu, 21 Apr 2022, "Wang, Zhi A" wrote: > Hi folks: > > Here is the PR of gvt-next. Thanks so much for the patience. Thanks, pulled to drm-intel-next, applied the below fix for the silent conflict on top, and pushed out. Should show up in linux-next shortly. BR, Jani. > > Mostly it includes t

[PATCH v10 0/4] Add support for the eDP panel over aux_bus

2022-04-25 Thread Sankeerth Billakanti
This series adds support for generic eDP panel over aux_bus. These changes are dependent on the following patches: https://patchwork.kernel.org/project/linux-arm-msm/patch/20220211224006.1797846-5-dmitry.barysh...@linaro.org/ https://patchwork.kernel.org/project/linux-arm-msm/patch/20220211224006.

[PATCH v10 1/4] drm/msm/dp: Add eDP support via aux_bus

2022-04-25 Thread Sankeerth Billakanti
This patch adds support for generic eDP sink through aux_bus. The eDP/DP controller driver should support aux transactions originating from the panel-edp driver and hence should be initialized and ready. The panel bridge supporting the panel should be ready before the bridge connector is initializ

[PATCH v10 2/4] drm/msm/dp: Support only IRQ_HPD and REPLUG interrupts for eDP

2022-04-25 Thread Sankeerth Billakanti
The panel-edp enables the eDP panel power during probe, get_modes and pre-enable. The eDP connect and disconnect interrupts for the eDP/DP controller are directly dependent on panel power. As eDP display can be assumed as always connected, the controller driver can skip the eDP connect and disconne

[PATCH v10 3/4] drm/msm/dp: wait for hpd high before aux transaction

2022-04-25 Thread Sankeerth Billakanti
The source device should ensure the sink is ready before proceeding to read the sink capability or perform any aux transactions. The sink will indicate its readiness by asserting the HPD line. The controller driver needs to wait for the hpd line to be asserted by the sink before it performs any aux

[PATCH v10 4/4] drm/msm/dp: Support the eDP modes given by panel

2022-04-25 Thread Sankeerth Billakanti
The eDP controller does not have a reliable way keep panel powered on to read the sink capabilities. So, the controller driver cannot validate if a mode can be supported by the source. We will rely on the panel driver to populate only the supported modes for now. Signed-off-by: Sankeerth Billakant

[PATCH] drm/nouveau: fix returnvar.cocci warning

2022-04-25 Thread Guo Zhengkui
Fix the following coccicheck warning: drivers/gpu/drm/nouveau/nvkm/subdev/devinit/gt215.c:71:5-12: Unneeded variable: "disable". Return "0ULL" on line 85. Signed-off-by: Guo Zhengkui --- drivers/gpu/drm/nouveau/nvkm/subdev/devinit/gt215.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

Re: [PATCH 1/1] drm/i915: Inherit submitter nice when scheduling requests

2022-04-25 Thread Tvrtko Ursulin
On 08/04/2022 16:10, Daniel Vetter wrote: On Fri, 8 Apr 2022 at 12:29, Tvrtko Ursulin wrote: On 08/04/2022 10:50, Dave Airlie wrote: On Fri, 8 Apr 2022 at 18:25, Tvrtko Ursulin wrote: On 08/04/2022 08:58, Daniel Vetter wrote: On Thu, Apr 07, 2022 at 04:16:27PM +0100, Tvrtko Ursulin wr

Re: [Intel-gfx] [PATCH 2/3] drm/i915/display: Replace crtc_state's has_drrs by drrs_downclock_mode

2022-04-25 Thread Jani Nikula
On Thu, 21 Apr 2022, José Roberto de Souza wrote: > Will be adding some additional control options to DRRS that will > require to have the DRRS downclock mode stored in the crtc_state. > > So to optimize memory usage a bit here using it to replace has_drrs > as we can check if the drrs_downclock_m

[PATCH v2 0/4] lrc selftest fixes

2022-04-25 Thread Ramalingam C
Few bug fixes for lrc selftest. Resending the reviewed patches for CI feedback. Chris Wilson (4): drm/i915/gt: Explicitly clear BB_OFFSET for new contexts drm/i915/selftests: Check for incomplete LRI from the context image drm/i915/selftest: Always cancel semaphore on error drm/i915/selft

[PATCH v2 1/4] drm/i915/gt: Explicitly clear BB_OFFSET for new contexts

2022-04-25 Thread Ramalingam C
From: Chris Wilson Even though the initial protocontext we load onto HW has the register cleared, by the time we save it into the default image, BB_OFFSET has had the enable bit set. Reclear BB_OFFSET for each new context. Testcase: igt/i915_selftests/gt_lrc Signed-off-by: Chris Wilson Cc: Mik

[PATCH v2 2/4] drm/i915/selftests: Check for incomplete LRI from the context image

2022-04-25 Thread Ramalingam C
From: Chris Wilson In order to keep the context image parser simple, we assume that all commands follow a similar format. A few, especially not MI commands on the render engines, have fixed lengths not encoded in a length field. This caused us to incorrectly skip over 3D state commands, and start

[PATCH v2 3/4] drm/i915/selftest: Always cancel semaphore on error

2022-04-25 Thread Ramalingam C
From: Chris Wilson Ensure that we always signal the semaphore when timing out, so that if it happens to be stuck waiting for the semaphore we will quickly recover without having to wait for a reset. Reported-by: CQ Tang Signed-off-by: Chris Wilson Cc: CQ Tang cc: Joonas Lahtinen Signed-off-b

[PATCH v2 4/4] drm/i915/selftest: Clear the output buffers before GPU writes

2022-04-25 Thread Ramalingam C
From: Chris Wilson When testing whether we can get the GPU to leak information about non-privileged state, we first need to ensure that the output buffer is set to a known value as the HW may opt to skip the write into memory for a non-privileged read of a sensitive register. We chose POISON_INUS

[PATCH] drm/msm: fix returnvar.cocci warning

2022-04-25 Thread Guo Zhengkui
Fix the following coccicheck warning: drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c:24:5-8: Unneeded variable: "ret". Return "0" on line 75. Signed-off-by: Guo Zhengkui --- drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/m

Re: [PULL v3] gvt-next

2022-04-25 Thread Jani Nikula
On Mon, 25 Apr 2022, Jani Nikula wrote: > On Thu, 21 Apr 2022, "Wang, Zhi A" wrote: >> Hi folks: >> >> Here is the PR of gvt-next. Thanks so much for the patience. > > Thanks, pulled to drm-intel-next, applied the below fix for the silent > conflict on top, and pushed out. Should show up in linux

Re: [PATCH v11 00/24] drm/rockchip: RK356x VOP2 support

2022-04-25 Thread Michael Riesch
Hello Sascha, On 4/22/22 09:28, Sascha Hauer wrote: > It's v11 time. There's only one small change to v10. Discussion seems to > have settled now. Is there anything left that prevents the series from > being merged? I'd really like to have it in during the next merge > window. Oh yes that'd be aw

Re: [PULL v3] gvt-next

2022-04-25 Thread Wang, Zhi A
On 4/25/22 12:33 PM, Jani Nikula wrote: > On Mon, 25 Apr 2022, Jani Nikula wrote: >> On Thu, 21 Apr 2022, "Wang, Zhi A" wrote: >>> Hi folks: >>> >>> Here is the PR of gvt-next. Thanks so much for the patience. >> >> Thanks, pulled to drm-intel-next, applied the below fix for the silent >> conflic

[PATCH] drm/nouveau/disp/gv100: make gv100_disp_wimm static

2022-04-25 Thread Tom Rix
Sparse reports this issue wimmgv100.c:39:1: warning: symbol 'gv100_disp_wimm' was not declared. Should it be static? This variable is only used in wimmgv100.c. Single file variables should be static. So use static as its storage-class specifier. Signed-off-by: Tom Rix --- drivers/gpu/drm/nou

[PATCH] drm/nouveau/disp/gv100: make gv100_disp_wndw and gv100_disp_wndw_mthd static

2022-04-25 Thread Tom Rix
Sparse reports these issues wndwgv100.c:120:1: warning: symbol 'gv100_disp_wndw_mthd' was not declared. Should it be static? wndwgv100.c:140:1: warning: symbol 'gv100_disp_wndw' was not declared. Should it be static? These variable are only used in wndwgv100.c. Single file variables should be

[PATCH] drm/i915: fix returnvar.cocci warning

2022-04-25 Thread Guo Zhengkui
Fix the following coccicheck warning: drivers/gpu/drm/i915/display/intel_pipe_crc.c:82:5-8: Unneeded variable: "ret". Return "0" on line 125. Signed-off-by: Guo Zhengkui --- drivers/gpu/drm/i915/display/intel_pipe_crc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/driver

Re: [PATCH v17 11/21] drm/mediatek: add display merge start/stop API for cmdq support

2022-04-25 Thread Chun-Kuang Hu
Hi, Matthias: Matthias Brugger 於 2022年4月22日 週五 下午7:48寫道: > > > > On 16/04/2022 04:07, Nancy.Lin wrote: > > Add merge start/stop API for cmdq support. The ovl_adaptor merges > > are configured with each drm plane update. Need to enable/disable > > merge with cmdq making sure all the settings taken

[PATCH] drm/bridge: it6505: Send DPCD SET_POWER to downstream

2022-04-25 Thread Pin-Yen Lin
Send DPCD SET_POWER command to downstream in .atomic_disable to make the downstream monitor enter the power down mode, so the device suspend won't be affected. Fixes: b5c84a9edcd418 ("drm/bridge: add it6505 driver") Signed-off-by: Pin-Yen Lin --- drivers/gpu/drm/bridge/ite-it6505.c | 29 +++

Re: [PATCH] drm: rcar-du: Drop file name from comment header blocks

2022-04-25 Thread Kieran Bingham
Quoting Laurent Pinchart (2022-04-24 22:45:50) > The comment blocks at the beginning of each file have a one-line > summary description of the file that includes the file name. While the > description is useful, the file name only creates opportunities for > mistakes (as seen in rcar_du_vsp.c) with

Re: [PATCH 2/2] drm/nvdla: Add driver support for NVDLA

2022-04-25 Thread Cai Huoqing
On 22 4月 22 01:01:14, Kari Argillander wrote: > This is just quick look up. I basically check some style issues and did > some basic static analyzing. > > I have run > - cppcheck (which found couple mistakes) > - flawfinder (did not found anything to my eyes) > - codespell (did find couple typo

Re: [Intel-gfx] [PATCH 1/2] drm/i915/xehp: Add compute engine ABI

2022-04-25 Thread Andi Shyti
Hi Matt, On Fri, Apr 22, 2022 at 12:50:06PM -0700, Matt Roper wrote: > We're now ready to start exposing compute engines to userspace. > > While we're at it, let's extend the kerneldoc description for the other > engine types as well. I would make two different patches. The kerneldoc description

Re: [PATCH v11 00/24] drm/rockchip: RK356x VOP2 support

2022-04-25 Thread Daniel Stone
On Fri, 22 Apr 2022 at 08:30, Sascha Hauer wrote: > It's v11 time. There's only one small change to v10. Discussion seems to > have settled now. Is there anything left that prevents the series from > being merged? I'd really like to have it in during the next merge > window. I don't believe there

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Xe_HP SDV and DG2 have up to 4 CCS engines

2022-04-25 Thread Andi Shyti
On Fri, Apr 22, 2022 at 12:50:07PM -0700, Matt Roper wrote: > From: Daniele Ceraolo Spurio > > Cc: Vinay Belgaumkar > Signed-off-by: Daniele Ceraolo Spurio > Signed-off-by: Matt Roper > Reviewed-by: Matt Roper Reviewed-by: Andi Shyti Andi

Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support

2022-04-25 Thread Daniel Stone
Hi Piotr, On Fri, 15 Apr 2022 at 12:11, Piotr Oniszczuk wrote: > Looking on Qt sources it looks to me this format should be supported: > > https://code.qt.io/cgit/qt/qtbase.git/tree/src/platformsupport/kmsconvenience/qkmsdevice.cpp?h=5.15.2#n380 > > Interesting that with custom Qt config1: "forma

[PATCH 0/3] Handle predicate programming

2022-04-25 Thread Ramalingam C
Userspace can leave SET_PREDICATE_RESULT active at the end of their batch, causing all the kernel operations from the ring to be noop'ed. This includes workarounds for memory corruption on dg2, as well as the usual synchronisation, arbitration, coherency and signaling. The latter can be used to cau

[PATCH 1/3] drm/i915/xehpsdv/dg1/tgl: Fix issue with LRI relative addressing

2022-04-25 Thread Ramalingam C
From: Akeem G Abodunrin When bit 19 of MI_LOAD_REGISTER_IMM instruction opcode is set on tgl+ devices, HW does not care about certain register address offsets, but instead check the following for valid address ranges on specific engines: RCS && CCS: BITS(0 - 10) BCS: BITS(0 - 11)

[PATCH 2/3] drm/i915/selftests: Skip poisoning SET_PREDICATE_RESULT on dg2

2022-04-25 Thread Ramalingam C
From: Chris Wilson When predication is enabled all commands baring a few (such as MI_BB_END) are nop'ed. If we accidentally enable predication while poisoning the context, not only is the rest of the poisoning skipped (thus disabling the test), but the closing instructions of the poison request a

[PATCH 3/3] drm/i915/gt: Clear SET_PREDICATE_RESULT prior to executing the ring

2022-04-25 Thread Ramalingam C
From: Chris Wilson Userspace may leave predication enabled upon return from the batch buffer, which has the consequent of preventing all operation from the ring from being executed, including all the synchronisation, coherency control, arbitration and user signaling. This is more than just a loca

Re: [PATCH v17 11/21] drm/mediatek: add display merge start/stop API for cmdq support

2022-04-25 Thread Matthias Brugger
On 25/04/2022 15:32, Chun-Kuang Hu wrote: Hi, Matthias: Matthias Brugger 於 2022年4月22日 週五 下午7:48寫道: On 16/04/2022 04:07, Nancy.Lin wrote: Add merge start/stop API for cmdq support. The ovl_adaptor merges are configured with each drm plane update. Need to enable/disable merge with cmdq ma

Re: [PATCH] gpu: drm: remove redundant dma_fence_put() when drm_sched_job_add_dependency() fails

2022-04-25 Thread Andrey Grodzovsky
On 2022-04-25 04:36, Hangyu Hua wrote: When drm_sched_job_add_dependency() fails, dma_fence_put() will be called internally. Calling it again after drm_sched_job_add_dependency() finishes may result in a dangling pointer. Fix this by removing redundant dma_fence_put(). Signed-off-by: Hangyu Hu

Re: [PATCH v2 1/3] fbdev: Put mmap for deferred I/O into drivers

2022-04-25 Thread kernel test robot
Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on 0e7deff6446a4ba2c75f499a0bfa80cd6a15c129] url: https://github.com/intel-lab-lkp/linux/commits/Thomas-Zimmermann/fbdev-Decouple-deferred-I-O-from-struct-page/20220425-192955 base

[PATCH v2 0/4] Flat-CCS eviction enhancements

2022-04-25 Thread Ramalingam C
Flat-CCS eviction enhancements v2: Correcting the memory residency requirement for flat-ccs capability [Thomas] Ramalingam C (4): drm/i915/gt: GEM_BUG_ON unexpected NULL at scatterlist walking drm/i915/gt: optimize the ccs_sz calculation per chunk drm/i915/gt: Document the eviction of t

[PATCH v2 1/4] drm/i915/gt: GEM_BUG_ON unexpected NULL at scatterlist walking

2022-04-25 Thread Ramalingam C
While locating the start of ccs scatterlist in smem scatterlist, that has to be the size of lmem obj size + corresponding ccs data size. Report bug if scatterlist terminate before that length. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c | 6 ++ 1 file changed, 6 i

[PATCH v2 2/4] drm/i915/gt: optimize the ccs_sz calculation per chunk

2022-04-25 Thread Ramalingam C
Calculate the ccs_sz that needs to be emitted based on the src and dst pages emitted per chunk. And handle the return value of emit_pte for the ccs pages. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c | 36 + 1 file changed, 12 insertions(+), 24

[PATCH v2 3/4] drm/i915/gt: Document the eviction of the Flat-CCS objects

2022-04-25 Thread Ramalingam C
Capture the eviction details for Flat-CCS capable, lmem objects. v2: Fix the Flat-ccs capbility of lmem obj with smem residency possibility [Thomas] Signed-off-by: Ramalingam C cc: Thomas Hellstrom cc: Matthew Auld --- drivers/gpu/drm/i915/gt/intel_migrate.c | 23 ++-

[PATCH v2 4/4] uapi/drm/i915: Document memory residency and Flat-CCS capability of obj

2022-04-25 Thread Ramalingam C
Capture the impact of memory region preference list of an object, on their memory residency and Flat-CCS capability of the objects. v2: Fix the Flat-CCS capability of an obj with {lmem, smem} preference list [Thomas] Signed-off-by: Ramalingam C cc: Matthew Auld cc: Thomas Hellstrom --- in

Re: [Freedreno] [PATCH v4 03/20] drm: allow real encoder to be passed for drm_writeback_connector

2022-04-25 Thread Abhinav Kumar
On 4/25/2022 3:50 AM, Dmitry Baryshkov wrote: On Sun, 24 Apr 2022 at 22:59, Laurent Pinchart wrote: Hi Abhinav, On Sun, Apr 24, 2022 at 11:23:20AM -0700, Abhinav Kumar wrote: On 4/24/2022 11:12 AM, Abhinav Kumar wrote: On 4/24/2022 7:50 AM, Laurent Pinchart wrote: On Fri, Apr 22, 2022 a

Re: [PATCH 5/5] dt-bindings: mediatek: add ethdr definition for mt8195

2022-04-25 Thread Rob Herring
On Tue, Apr 19, 2022 at 11:32:37AM +0800, Rex-BC Chen wrote: > From: "Nancy.Lin" > > Add vdosys1 ETHDR definition. > > Signed-off-by: Nancy.Lin > Reviewed-by: Chun-Kuang Hu > Reviewed-by: AngeloGioacchino Del Regno > > --- > .../display/mediatek/mediatek,ethdr.yaml | 158 ++

Re: [PATCH] drm/amd/display: fix non-kernel-doc comment warnings

2022-04-25 Thread Alex Deucher
On Fri, Apr 22, 2022 at 9:29 PM Randy Dunlap wrote: > > Fix kernel-doc warnings for a comment that should not use > kernel-doc notation: > > dmub_psr.c:235: warning: This comment starts with '/**', but isn't a > kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst > * Set PSR power o

Re: [PATCH] drm/radeon: change cik_default_state table from global to static

2022-04-25 Thread Alex Deucher
On Sat, Apr 23, 2022 at 9:44 AM Tom Rix wrote: > > Sparse reports these issues > cik_blit_shaders.c:31:11: warning: symbol 'cik_default_state' was not > declared. Should it be static? > cik_blit_shaders.c:246:11: warning: symbol 'cik_default_size' was not > declared. Should it be static? > > cik

Re: [PATCH] drm/radeon: change cac_weights_* to static

2022-04-25 Thread Alex Deucher
Applied. Thanks! Alex On Sat, Apr 23, 2022 at 4:02 PM Tom Rix wrote: > > Sparse reports these issues > si_dpm.c:332:26: warning: symbol 'cac_weights_pitcairn' was not declared. > Should it be static? > si_dpm.c:1088:26: warning: symbol 'cac_weights_oland' was not declared. > Should it be stat

Re: Screen corruption using radeon kernel driver

2022-04-25 Thread Alex Deucher
+ dri-devel On Mon, Apr 25, 2022 at 3:33 AM Krylov Michael wrote: > > Hello! > > After updating my Linux kernel from version 4.19 (Debian 10 version) to > 5.10 (packaged with Debian 11), I've noticed that the image > displayed on my older computer, 32-bit Pentium 4 using ATI Radeon X1950 > AGP vi

Re: [PATCH v2 1/3] fbdev: Put mmap for deferred I/O into drivers

2022-04-25 Thread Sam Ravnborg
Hi Thomas, > diff --git a/drivers/video/fbdev/core/fb_defio.c > b/drivers/video/fbdev/core/fb_defio.c > index 6aaf6d0abf39..6924d489a289 100644 > --- a/drivers/video/fbdev/core/fb_defio.c > +++ b/drivers/video/fbdev/core/fb_defio.c > @@ -181,6 +181,7 @@ int fb_deferred_io_mmap(struct fb_info *inf

Re: [Freedreno] [PATCH v4 03/20] drm: allow real encoder to be passed for drm_writeback_connector

2022-04-25 Thread Laurent Pinchart
On Mon, Apr 25, 2022 at 01:50:43PM +0300, Dmitry Baryshkov wrote: > On Sun, 24 Apr 2022 at 22:59, Laurent Pinchart wrote: > > On Sun, Apr 24, 2022 at 11:23:20AM -0700, Abhinav Kumar wrote: > > > On 4/24/2022 11:12 AM, Abhinav Kumar wrote: > > > > On 4/24/2022 7:50 AM, Laurent Pinchart wrote: > > >

Re: [PATCH 1/2] drm/i915/xehp: Add compute engine ABI

2022-04-25 Thread Matt Roper
On Mon, Apr 25, 2022 at 11:41:36AM +0100, Tvrtko Ursulin wrote: > > On 22/04/2022 20:50, Matt Roper wrote: > > We're now ready to start exposing compute engines to userspace. > > > > While we're at it, let's extend the kerneldoc description for the other > > engine types as well. > > > > Cc: Dan

Re: [PATCH v2 1/3] fbdev: Put mmap for deferred I/O into drivers

2022-04-25 Thread Sam Ravnborg
Hi Thomas, On Mon, Apr 25, 2022 at 07:26:32PM +0200, Sam Ravnborg wrote: > Hi Thomas, > > > diff --git a/drivers/video/fbdev/core/fb_defio.c > > b/drivers/video/fbdev/core/fb_defio.c > > index 6aaf6d0abf39..6924d489a289 100644 > > --- a/drivers/video/fbdev/core/fb_defio.c > > +++ b/drivers/video

Re: [Freedreno] [PATCH v4 03/20] drm: allow real encoder to be passed for drm_writeback_connector

2022-04-25 Thread Abhinav Kumar
Hi Laurent On 4/25/2022 10:32 AM, Laurent Pinchart wrote: On Mon, Apr 25, 2022 at 01:50:43PM +0300, Dmitry Baryshkov wrote: On Sun, 24 Apr 2022 at 22:59, Laurent Pinchart wrote: On Sun, Apr 24, 2022 at 11:23:20AM -0700, Abhinav Kumar wrote: On 4/24/2022 11:12 AM, Abhinav Kumar wrote: On 4/24

Re: [PATCH] video: clps711x-fb: Use syscon_regmap_lookup_by_phandle

2022-04-25 Thread Helge Deller
On 4/20/22 09:06, Alexander Shiyan wrote: > Since version 5.13, the standard syscon bindings have been added > to all clps711x DT nodes, so we can now use the more general > syscon_regmap_lookup_by_phandle function to get the syscon pointer. > > Signed-off-by: Alexander Shiyan applied. Thanks, He

Re: [PATCH v2 2/3] fbdev: Track deferred-I/O pages in pageref struct

2022-04-25 Thread Sam Ravnborg
Hi Thomas, a little ramblings below. Just my thoughts while trying to understand the code - especially since I looked at it before. Sam On Mon, Apr 25, 2022 at 01:27:50PM +0200, Thomas Zimmermann wrote: > Store the per-page state for fbdev's deferred I/O in struct > fb_deferred_io_pagere

Re: [Freedreno] [PATCH v4 03/20] drm: allow real encoder to be passed for drm_writeback_connector

2022-04-25 Thread Laurent Pinchart
On Mon, Apr 25, 2022 at 10:48:07AM -0700, Abhinav Kumar wrote: > On 4/25/2022 10:32 AM, Laurent Pinchart wrote: > > On Mon, Apr 25, 2022 at 01:50:43PM +0300, Dmitry Baryshkov wrote: > >> On Sun, 24 Apr 2022 at 22:59, Laurent Pinchart wrote: > >>> On Sun, Apr 24, 2022 at 11:23:20AM -0700, Abhinav Ku

Re: [PATCH v2 3/3] fbdev: Refactor implementation of page_mkwrite

2022-04-25 Thread Sam Ravnborg
Hi Thomas. On Mon, Apr 25, 2022 at 01:27:51PM +0200, Thomas Zimmermann wrote: > Refactor the page-write handler for deferred I/O. Drivers use the > function to let fbdev track written pages of mmap'ed framebuffer > memory. I like how the comments got a brush up and a little more info was added. B

RE: [PATCH 1/2] drm/i915/xehp: Add compute engine ABI

2022-04-25 Thread Yang, Fei
>> > --- a/drivers/gpu/drm/i915/gt/intel_gt.c >> > +++ b/drivers/gpu/drm/i915/gt/intel_gt.c >> > @@ -1175,6 +1175,7 @@ void intel_gt_invalidate_tlbs(struct intel_gt *gt) >> >[VIDEO_DECODE_CLASS]= GEN12_VD_TLB_INV_CR, >> >[VIDEO_ENHANCEMENT_CLASS] = GEN12_VE

Re: [PATCH 04/11] drm/r128: Fix undefined behavior due to shift overflowing the constant

2022-04-25 Thread Randy Dunlap
On 4/5/22 08:15, Borislav Petkov wrote: > From: Borislav Petkov > > Fix: > > drivers/gpu/drm/r128/r128_cce.c: In function ‘r128_do_init_cce’: > drivers/gpu/drm/r128/r128_cce.c:417:2: error: case label does not reduce to > an integer constant > case R128_PM4_64BM_64VCBM_64INDBM: >

[PATCH] drm/ssd130x: Make ssd130x_remove() return void

2022-04-25 Thread Uwe Kleine-König
This function returns zero unconditionally, so there isn't any benefit of returning a value. Make it return void to be able to see at a glance that the return value of ssd130x_i2c_remove() is always zero. This patch is a preparation for making i2c remove callbacks return void. Signed-off-by: Uwe

Re: [PATCH v2 1/3] drm/msm/dpu: index dpu_kms->hw_vbif using vbif_idx

2022-04-25 Thread Abhinav Kumar
+ Vinod Hi Dmitry Can we also absorb https://patchwork.freedesktop.org/patch/483255/ into this change? Looks like they are touching the same code and can be absorbed easily. Thanks Abhinav On 4/19/2022 9:20 AM, Dmitry Baryshkov wrote: Remove loops over hw_vbif. Instead always VBIF's idx

Re: [PATCH] drm/msm/dpu: fix error check return value of irq_of_parse_and_map()

2022-04-25 Thread Stephen Boyd
Quoting cgel@gmail.com (2022-04-25 02:09:47) > From: Lv Ruyi > > The irq_of_parse_and_map() function returns 0 on failure, and does not > return a negative value anyhow, so never enter this conditional branch. > > Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") > Reported-by: Zeal Robo

Re: [PATCH] drm/msm/hdmi: fix error check return value of irq_of_parse_and_map()

2022-04-25 Thread Stephen Boyd
Quoting cgel@gmail.com (2022-04-25 02:18:31) > From: Lv Ruyi > > The irq_of_parse_and_map() function returns 0 on failure, and does not > return a negative value anyhow, so never enter this conditional branch. > > Fixes: f6a8eaca0ea1 ("drm/msm/mdp5: use irqdomains") > Reported-by: Zeal Robot

Re: [PATCH] drm/msm: fix returnvar.cocci warning

2022-04-25 Thread Stephen Boyd
Quoting Guo Zhengkui (2022-04-25 05:22:21) > Fix the following coccicheck warning: > drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c:24:5-8: Unneeded variable: > "ret". Return "0" on line 75. > > Signed-off-by: Guo Zhengkui > --- Reviewed-by: Stephen Boyd

RE: [PATCH v9 1/4] drm/msm/dp: Add eDP support via aux_bus

2022-04-25 Thread Stephen Boyd
Quoting Sankeerth Billakanti (QUIC) (2022-04-25 02:39:43) > Hi Stephen, > > >Quoting Sankeerth Billakanti (2022-04-22 02:11:03) > >> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > >> b/drivers/gpu/drm/msm/dp/dp_display.c > >> index d7a19d6..055681a 100644 > >> --- a/drivers/gpu/drm/msm/dp/dp_di

RE: [PATCH v9 2/4] drm/msm/dp: Support only IRQ_HPD and REPLUG interrupts for eDP

2022-04-25 Thread Stephen Boyd
Quoting Sankeerth Billakanti (QUIC) (2022-04-24 19:55:29) > >Quoting Sankeerth Billakanti (2022-04-22 02:11:04) > > > >> int dp_catalog_ctrl_get_interrupt(struct dp_catalog *dp_catalog) diff > >> --git a/drivers/gpu/drm/msm/dp/dp_display.c > >> b/drivers/gpu/drm/msm/dp/dp_display.c > >> index 0556

[PATCH 1/2] drm/vmwgfx: Remove unused hugepage support

2022-04-25 Thread Zack Rusin
From: Zack Rusin There's no point in explicitly trying to align virtual memory to facilitate huge page table entries or huge page memory in buffer objects given that they're not being used. Transparent hugepages support for vram allocations has been gradually retired over the last two years maki

[PATCH 2/2] drm: Remove the drm_get_unmapped_area() helper

2022-04-25 Thread Zack Rusin
From: Zack Rusin This has been only used by the vmwgfx driver and vmwgfx over the last year removed support for transparent hugepages on vram leaving drm_get_unmapped_area completely unused. There's no point in keeping unused code in core drm. Signed-off-by: Zack Rusin Cc: Thomas Hellström Cc

  1   2   >