[PULL] drm-misc-next

2022-04-21 Thread Maxime Ripard
Hi, Here's this week drm-misc-next PR Maxime drm-misc-next-2022-04-21: drm-misc-next for $kernel-version: UAPI Changes: Cross-subsystem Changes: - of: Create a platform_device for offb Core Changes: - edid: block read refactoring - ttm: Add common debugfs code for resource managers Dri

Re: (subset) [PATCH v3 1/2] drm/vc4: hdmi: Replace drm_detect_hdmi_monitor() with is_hdmi

2022-04-21 Thread Maxime Ripard
On Wed, 20 Apr 2022 13:44:59 +0200, José Expósito wrote: > Once EDID is parsed, the monitor HDMI support information is cached in > drm_display_info.is_hdmi by drm_parse_hdmi_vsdb_video(). > > This driver calls drm_detect_hdmi_monitor() to receive the same > information and stores its own cached v

Re: (subset) [PATCH v3 2/2] drm/vc4: hdmi: Remove vc4_hdmi_encoder

2022-04-21 Thread Maxime Ripard
On Wed, 20 Apr 2022 13:45:00 +0200, José Expósito wrote: > The vc4_hdmi_encoder struct was used exclusively to cache the value > returned by drm_detect_hdmi_monitor() in order to avoid calling it > multiple times. > > Now that drm_detect_hdmi_monitor() has been replaced with > drm_display_info.is_

Re: [RFC PATCH 00/16] drm/rockchip: Rockchip EBC ("E-Book Controller") display driver

2022-04-21 Thread Nicolas Frattaroli
On Donnerstag, 21. April 2022 08:43:38 CEST Andreas Kemnade wrote: > On Wed, 13 Apr 2022 17:19:00 -0500 > Samuel Holland wrote: > > Blitting/Blending in Software > > = > > There are multiple layers to this topic (pun slightly intended): > > 1) Today's userspace does no

Re: (subset) [PATCH v3] drm/vc4: Use pm_runtime_resume_and_get to fix pm_runtime_get_sync() usage

2022-04-21 Thread Maxime Ripard
On Wed, 20 Apr 2022 21:50:07 +0800, Miaoqian Lin wrote: > If the device is already in a runtime PM enabled state > pm_runtime_get_sync() will return 1. > > Also, we need to call pm_runtime_put_noidle() when pm_runtime_get_sync() > fails, so use pm_runtime_resume_and_get() instead. this function >

Re: (subset) [PATCH 1/2] Revert "drm: of: Properly try all possible cases for bridge/panel detection"

2022-04-21 Thread Maxime Ripard
On Wed, 20 Apr 2022 16:12:29 -0700, Bjorn Andersson wrote: > Commit '80253168dbfd ("drm: of: Lookup if child node has panel or > bridge")' introduced the ability to describe a panel under a display > controller without having to use a graph to connect the controller to > its single child panel (or

Re: (subset) [PATCH 2/2] Revert "drm: of: Lookup if child node has panel or bridge"

2022-04-21 Thread Maxime Ripard
On Wed, 20 Apr 2022 16:12:30 -0700, Bjorn Andersson wrote: > Commit '80253168dbfd ("drm: of: Lookup if child node has panel or > bridge")' attempted to simplify the case of expressing a simple panel > under a DSI controller, by assuming that the first non-graph child node > was a panel or bridge. >

Re: [PATCH 1/2] Revert "drm: of: Properly try all possible cases for bridge/panel detection"

2022-04-21 Thread Maxime Ripard
On Thu, Apr 21, 2022 at 09:13:02AM +0200, Paul Kocialkowski wrote: > Hi, > > On Wed 20 Apr 22, 16:19, Bjorn Andersson wrote: > > On Wed 20 Apr 16:12 PDT 2022, Bjorn Andersson wrote: > > > > Sorry, I missed Jagan and Linus, author and reviewer of the reverted > > patch 2, among the recipients. >

Re: [PATCH v3 06/18] drm/msm/dpu: rename dpu_hw_pipe_cdp_cfg to dpu_hw_cdp_cfg

2022-04-21 Thread Dmitry Baryshkov
On Thu, 21 Apr 2022 at 02:50, Abhinav Kumar wrote: > > Rename dpu_hw_pipe_cdp_cfg to dpu_hw_cdp_cfg and move it > to dpu_hw_utils file so that other modules in addition to > SSPP such as writeback can use it as all the fields can > be used by writeback as well. > > Suggested-by: Dmitry Baryshkov

Re: [PATCH v3 08/18] drm/msm/dpu: add writeback blocks to DPU RM

2022-04-21 Thread Dmitry Baryshkov
On Thu, 21 Apr 2022 at 02:50, Abhinav Kumar wrote: > > Add writeback blocks to DPU resource manager so that > the encoders can directly request them through RM. > > changes in v3: > - use IS_ERR() instead of IS_ERR_OR_NULL() > > Signed-off-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov

[PATCH v3 1/8] drm: Put related statements next to each other in Makefile

2022-04-21 Thread Thomas Zimmermann
Give the Makefile a bit more structure by putting rules for core, helpers, drivers, etc next to each other. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/Makefile | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --

[PATCH v3 4/8] drm/display: Split DisplayPort header into core and helper

2022-04-21 Thread Thomas Zimmermann
Move DisplayPort protocol constants and structures into the new header drm_dp.h, which can be used by DRM core components. The existing header drm_dp_helper.h now only contains helper code for graphics drivers. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Lyude Paul Revie

[PATCH v3 2/8] drm: Rename dp/ to display/

2022-04-21 Thread Thomas Zimmermann
Rename dp/ to display/ to account for additional display-related helpers, such as HDMI. Update all related include statements. No functional changes. Various drivers, such as i915 and amdgpu, use similar naming scheme by putting code for video-output standards into a local display/ directory. The

[PATCH v3 8/8] drm/display: Move SCDC helpers into display-helper library

2022-04-21 Thread Thomas Zimmermann
SCDC is the Status and Control Data Channel for HDMI. Move the SCDC helpers into display/ and split the header into files for core and helpers. Update all affected drivers. No functional changes. To avoid the proliferation of Kconfig options, SCDC is part of DRM's support for HDMI. If necessary, a

[PATCH v3 5/8] drm/display: Move DSC header and helpers into display-helper module

2022-04-21 Thread Thomas Zimmermann
DSC is the Display Stream Compression standard for DisplayPort. Move the DSC code into display/ and split the header into files for protocol core and DRM helpers. Adapt all users of the code. No functional changes. To avoid the proliferation of Kconfig options, DSC is part of DRM's support for Dis

[PATCH v3 0/8] drm: Introduce display-helper library

2022-04-21 Thread Thomas Zimmermann
Move DisplayPort, HDMI and various other display helpers from KMS helpers into a new module. Adapt all drivers. This patch is part of an on-going effort to reduce the minimum size of DRM when linked into the kernel binary. The helpers for various display and video-output standards are not required

[PATCH v3 7/8] drm/display: Move HDMI helpers into display-helper module

2022-04-21 Thread Thomas Zimmermann
Move DRM's HMDI helpers into the display/ subdirectoy and add it to DRM's display helpers. Update all affected drivers. No functional changes. The HDMI helpers were implemented in the EDID and connector code, but are actually unrelated. With the move to the display-helper library, we can remove th

[PATCH v3 6/8] drm/display: Move HDCP helpers into display-helper module

2022-04-21 Thread Thomas Zimmermann
Move DRM's HDCP helper library into the display/ subdirectory and add it to DRM's display helpers. Split the header file into core and helpers. Update all affected drivers. No functional changes. v3: * fix Kconfig dependencies v2: * fix include statements (Jani, Javier) * u

[PATCH v3 3/8] drm/display: Introduce a DRM display-helper module

2022-04-21 Thread Thomas Zimmermann
Replace the DP-helper module with a display-helper module. The support for DisplayPort becomes an internal option that drivers have to select. Update all related Kconfig and Makefile rules. Besides the existing code for DisplayPort, the new module will contain helpers for other video-output standa

Re: [PATCH v3 09/18] drm/msm/dpu: add changes to support writeback in hw_ctl

2022-04-21 Thread Dmitry Baryshkov
On Thu, 21 Apr 2022 at 02:50, Abhinav Kumar wrote: > > Add changes to support writeback module in the dpu_hw_ctl > interface. > > changes in v3: > - read the intf_active and wb_active before writing > to preserve existing bits > - add the update_pending_flush_wb for non-v

Re: [PATCH 2/2] Revert "drm: of: Lookup if child node has panel or bridge"

2022-04-21 Thread Jagan Teki
+ Linus + Marek + Laurent + Robert On Thu, Apr 21, 2022 at 4:40 AM Bjorn Andersson wrote: > > Commit '80253168dbfd ("drm: of: Lookup if child node has panel or > bridge")' attempted to simplify the case of expressing a simple panel > under a DSI controller, by assuming that the first non-graph ch

Re: [PATCH 1/2] drm/i915/selftests: fixup min_alignment usage

2022-04-21 Thread Das, Nirmoy
Reviewed-by: Nirmoy Das On 4/6/2022 9:30 PM, Matthew Auld wrote: Trying to cast the region id into the region type doesn't work too well, since the i915_vm_min_alignment() won't give us the correct value for the stolen-lmem case. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Nirmoy Da

Re: [PATCH 2/2] drm/i915/selftests: tweak the misaligned_case

2022-04-21 Thread Das, Nirmoy
LGTM Reviewed-by: Nirmoy Das On 4/6/2022 9:30 PM, Matthew Auld wrote: The compact-pt layout restrictions should only apply to the ppGTT. Also make this play nice on platforms that only have the 64K GTT restriction, and not the compact-pt thing. Signed-off-by: Matthew Auld Cc: Thomas Hellström

Re: [PATCH 2/2] Revert "drm: of: Lookup if child node has panel or bridge"

2022-04-21 Thread Maxime Ripard
On Thu, Apr 21, 2022 at 01:15:54PM +0530, Jagan Teki wrote: > + Linus > + Marek > + Laurent > + Robert > > On Thu, Apr 21, 2022 at 4:40 AM Bjorn Andersson > wrote: > > > > Commit '80253168dbfd ("drm: of: Lookup if child node has panel or > > bridge")' attempted to simplify the case of expressing

Re: [PATCH 2/2] drm/nvdla: Add driver support for NVDLA

2022-04-21 Thread Thomas Zimmermann
(Resending, as some MLs didn't like the size of the origninal mail.) Hi, thanks for your submission. Some general comments: * some functions are prefixed with dla_, others use nvdla_. It seems arbitrary to me. Please use nvdla_ consistently throughout the source code. * For reporting err

Re: [CI 3/4] drm/i915/selftests: fixup min_alignment usage

2022-04-21 Thread Ramalingam C
On 2022-04-20 at 19:16:12 +0100, Matthew Auld wrote: > Trying to cast the region id into the region type doesn't work too well, > since the i915_vm_min_alignment() won't give us the correct value for > the stolen-lmem case. > > Signed-off-by: Matthew Auld Looks good to me. Reviewed-by: Ramalinga

Re: [PATCH 2/2] drm/nvdla: Add driver support for NVDLA

2022-04-21 Thread Christian König
Am 21.04.22 um 10:30 schrieb Thomas Zimmermann: (Resending, as some MLs didn't like the size of the origninal mail.) Hi, thanks for your submission. Some general comments:   * some functions are prefixed with dla_, others use nvdla_. It seems arbitrary to me. Please use nvdla_ consistently th

Re: [CI 4/4] drm/i915/selftests: tweak the misaligned_case

2022-04-21 Thread Ramalingam C
On 2022-04-20 at 19:16:13 +0100, Matthew Auld wrote: > The compact-pt layout restrictions should only apply to the ppGTT. Also > make this play nice on platforms that only have the 64K GTT restriction, > and not the compact-pt thing. > > Signed-off-by: Matthew Auld > Cc: Thomas Hellström > Cc: N

[PATCH] drm/tegra: Make use of the helper function devm_platform_ioremap_resource()

2022-04-21 Thread cgel . zte
From: Lv Ruyi Use the devm_platform_ioremap_resource() helper instead of calling platform_get_resource() and devm_ioremap_resource() separately.Make the code simpler without functional changes. Reported-by: Zeal Robot Signed-off-by: Lv Ruyi --- drivers/gpu/drm/tegra/vic.c | 9 + 1 fil

Re: [PATCH v6 1/2] dt-bindings: Add DT schema for Arm Mali Valhall GPU

2022-04-21 Thread Chen-Yu Tsai
On Thu, Apr 14, 2022 at 8:47 PM Steven Price wrote: > > On 14/04/2022 12:51, AngeloGioacchino Del Regno wrote: > > Il 14/04/22 04:50, Nick Fan ha scritto: > >> Add devicetree schema for Arm Mali Valhall GPU > >> > >> Define a compatible string for the Mali Valhall GPU > >> for MediaTek's SoC platf

Re: [PATCH 2/2] drm/nvdla: Add driver support for NVDLA

2022-04-21 Thread Thomas Zimmermann
Hi Am 21.04.22 um 10:34 schrieb Christian König: Am 21.04.22 um 10:30 schrieb Thomas Zimmermann: (Resending, as some MLs didn't like the size of the origninal mail.) Hi, thanks for your submission. Some general comments:   * some functions are prefixed with dla_, others use nvdla_. It seems

[PATCH] drm/amd/display: Fix memory leak in dcn21_clock_source_create

2022-04-21 Thread Miaoqian Lin
When dcn20_clk_src_construct() fails, we need to release clk_src. Fixes: 6f4e6361c3ff ("drm/amd/display: Add Renoir resource (v2)") Signed-off-by: Miaoqian Lin --- drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/displa

Re: [PATCH 2/2] drm/nvdla: Add driver support for NVDLA

2022-04-21 Thread Thomas Zimmermann
Am 21.04.22 um 10:34 schrieb Christian König: Am 21.04.22 um 10:30 schrieb Thomas Zimmermann: (Resending, as some MLs didn't like the size of the origninal mail.) Hi, thanks for your submission. Some general comments:   * some functions are prefixed with dla_, others use nvdla_. It seems a

Re: [PATCH 2/2] drm/nvdla: Add driver support for NVDLA

2022-04-21 Thread Thomas Zimmermann
Hi Am 21.04.22 um 10:34 schrieb Christian König: Am 21.04.22 um 10:30 schrieb Thomas Zimmermann: (Resending, as some MLs didn't like the size of the origninal mail.) Hi, thanks for your submission. Some general comments:   * some functions are prefixed with dla_, others use nvdla_. It seems

Re: [PATCH 2/2] drm/nvdla: Add driver support for NVDLA

2022-04-21 Thread Christian König
Am 21.04.22 um 11:13 schrieb Thomas Zimmermann: Hi Am 21.04.22 um 10:34 schrieb Christian König: Am 21.04.22 um 10:30 schrieb Thomas Zimmermann: (Resending, as some MLs didn't like the size of the origninal mail.) Hi, thanks for your submission. Some general comments:   * some functions are

Re: [PATCH 03/15] dma-buf & drm/amdgpu: remove dma_resv workaround

2022-04-21 Thread Christian König
Am 20.04.22 um 21:28 schrieb Zack Rusin: [SNIP] To figure out what it is could you try the following code fragment: diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_validation.c b/drivers/gpu/drm/vmwgfx/vmwgfx_validation.c index f46891012be3..a36f89d3f36d 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_va

[PATCH] drm/amd/display: Remove useless code

2022-04-21 Thread Haowen Bai
aux_rep only memset but no use at all, so we drop it. Signed-off-by: Haowen Bai --- drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c b/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c index 8e814000db62..2

Re: [PATCH v7 3/4] drm: allow real encoder to be passed for drm_writeback_connector

2022-04-21 Thread Liviu Dudau
Hi Abhinav, Sorry for the delay in reviewing this, Easter break happened in between. On Fri, Apr 08, 2022 at 05:53:54PM -0700, Abhinav Kumar wrote: > For some vendor driver implementations, display hardware can > be shared between the encoder used for writeback and the physical > display. > > In

Re: [PATCH] media: mediatek: vcodec: Fix v4l2 compliance decoder cmd test fail

2022-04-21 Thread Hans Verkuil
On 06/04/2022 03:20, Yunfei Dong wrote: > Will return -EINVAL using standard framework api when test stateless > decoder with cmd VIDIOC_(TRY)DECODER_CMD. > > Using another return value to adjust v4l2 compliance test for user > driver(GStreamer/Chrome) won't use decoder cmd. > > Fixes: 8cdc3794b2

Re: [PATCH v5 9/9] drm: vkms: Add support to the RGB565 format

2022-04-21 Thread Pekka Paalanen
On Mon, 4 Apr 2022 17:45:15 -0300 Igor Torrente wrote: > Adds this common format to vkms. > > This commit also adds new helper macros to deal with fixed-point > arithmetic. > > It was done to improve the precision of the conversion to ARGB16161616 > since the "conversion ratio" is not an integ

Re: [PATCH v3] drm/gma500: depend on framebuffer

2022-04-21 Thread Patrik Jakobsson
On Wed, Apr 20, 2022 at 1:42 AM James Hilliard wrote: > > On Tue, Apr 12, 2022 at 3:30 AM Patrik Jakobsson > wrote: > > > > On Tue, Apr 12, 2022 at 3:48 AM James Hilliard > > wrote: > > > > > > On Mon, Apr 11, 2022 at 3:27 AM Patrik Jakobsson > > > wrote: > > > > > > > > On Sun, Apr 10, 2022 at

Re: [PATCH 15/41] input: omap: void using mach/*.h headers

2022-04-21 Thread Dmitry Torokhov
On Tue, Apr 19, 2022 at 03:36:57PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > The omap-keypad driver currently relies on including mach/memory.h > implicitly, but that won't happen once omap1 is converted to > CONFIG_ARCH_MULTIPLATFORM. Include the required header > explicitly. > > Si

Re: [PATCH 0/1] add support for enum module parameters

2022-04-21 Thread Ben Greear
On 4/19/22 10:13 PM, Kalle Valo wrote: + linux-wireless, netdev Jani Nikula writes: On Thu, 14 Apr 2022, Greg Kroah-Hartman wrote: On Thu, Apr 14, 2022 at 03:30:32PM +0300, Jani Nikula wrote: Hey, I've sent this before, ages ago, but haven't really followed through with it. I still think i

Re: [PATCH 00/41] OMAP1 full multiplatform conversion

2022-04-21 Thread Aaro Koskinen
Hi, On Tue, Apr 19, 2022 at 03:36:42PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > This is the full series for converting OMAP1 to multiplatform, rebased > from my 2019 attempt to do the same thing. The soc tree contains simpler > patches to do the same for iop32x, ixp4xx, ep93xx and s

Re: [PATCH 26/41] ARM: omap1: relocate static I/O mapping

2022-04-21 Thread Aaro Koskinen
Hi, On Tue, Apr 19, 2022 at 03:37:08PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > The address range 0xfee0-0xfeff is used for PCI and > PCMCIA I/O port mappings, but OMAP1 has its static mappings > there as well. > > Move the OMAP1 addresses a little higher to avoid crashing

Re: [PATCH] Staging: fbtft: Fix style problem in header

2022-04-21 Thread Ian Cowan
On Wed, Apr 20, 2022 at 05:47:49PM +0200, Javier Martinez Canillas wrote: > On 4/20/22 16:36, Uwe Kleine-König wrote: > You are just changing a header file though, did you also enable one of the > fbtft drivers as a module to see if those build? But as said, by looking at > the code it seems that s

Re: [PATCH] Staging: fbtft: Fix style problem in header

2022-04-21 Thread Ian Cowan
On Wed, Apr 20, 2022 at 08:47:11AM +0200, Uwe Kleine-König wrote: > On Tue, Apr 19, 2022 at 03:21:28PM -0400, Ian Cowan wrote: > > Removed an unnecessary semicolon at the end of a macro call > > > > Signed-off-by: Ian Cowan > > --- > > drivers/staging/fbtft/fbtft.h | 2 +- > > 1 file changed, 1

[PATCH 0/4] Flat-CCS eviction enhancements

2022-04-21 Thread Ramalingam C
Flat-CCS eviction enhancements. Ramalingam C (4): drm/i915/gt: GEM_BUG_ON unexpected NULL at scatterlist walking drm/i915/gt: optimize the ccs_sz calculation per chunk drm/i915/gt: Extend doc on Flat-CCS obj eviction uapi/drm/i915: Update the placement list impact on obj residency driver

[PATCH 1/4] drm/i915/gt: GEM_BUG_ON unexpected NULL at scatterlist walking

2022-04-21 Thread Ramalingam C
While locating the start of ccs scatterlist in smem scatterlist, that has to be the size of lmem obj size + corresponding ccs data size. Report bug if scatterlist terminate before that length. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c | 6 ++ 1 file changed, 6 i

[PATCH 0/4] Flat-CCS eviction enhancements

2022-04-21 Thread Ramalingam C
Flat-CCS eviction enhancements. Ramalingam C (4): drm/i915/gt: GEM_BUG_ON unexpected NULL at scatterlist walking drm/i915/gt: optimize the ccs_sz calculation per chunk drm/i915/gt: Extend doc on Flat-CCS obj eviction uapi/drm/i915: Update the placement list impact on obj residency driver

[PATCH 4/4] uapi/drm/i915: Update the placement list impact on obj residency

2022-04-21 Thread Ramalingam C
Object created with list of memory classes as placement preferences, can be backed with any memory class of the list as per kernel's migration policy for the memory contrain situation. Userspace won't be notified of the memory residency change at this scenario. And also Flat-CCS compression is sup

[PATCH 3/4] drm/i915/gt: Extend doc on Flat-CCS obj eviction

2022-04-21 Thread Ramalingam C
Capture the eviction details for Flat-CCS capable lmem only objects and lmem objects with smem residency. This also captures the impact of eviction on object's memory residency and Flat-CCS compression state. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c | 36 +

[PATCH 2/4] drm/i915/gt: optimize the ccs_sz calculation per chunk

2022-04-21 Thread Ramalingam C
Calculate the ccs_sz that needs to be emitted based on the src and dst pages emitted per chunk. And handle the return value of emit_pte for the ccs pages. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c | 36 + 1 file changed, 12 insertions(+), 24

Re: [pull] amdgpu, amdkfd, radeon drm-next-5.19

2022-04-21 Thread Christian König
Hi Dave, just a gentle ping on that one here since it looks like it was missed because of the eastern holidays. I have general DRM/TTM changes I want to publish and need the amdgpu changes in drm-next so that we don't run into any merge conflicts. Thanks, Christian. Am 15.04.22 um 15:51 sc

Re: [PATCH v3] drm/gma500: depend on framebuffer

2022-04-21 Thread Thomas Zimmermann
Hi Am 09.04.22 um 06:23 schrieb James Hilliard: Select the efi framebuffer if efi is enabled. This appears to be needed for video output to function correctly. Signed-off-by: James Hilliard --- Changes v2 -> v3: - select EFI_FB instead of depending on it Changes v1 -> v2: - use depends

Re: [PATCH v2 04/17] drm/msm/dpu: add writeback blocks to the sm8250 DPU catalog

2022-04-21 Thread Liviu Dudau
On Tue, Apr 19, 2022 at 06:45:56PM -0700, Abhinav Kumar wrote: > Add writeback blocks to the sm8250 DPU hardware catalog. Other > chipsets support writeback too but add it to sm8250 to prototype > the feature so that it can be easily extended to other chipsets. > > changes in v2: > - none >

Re: [PATCH v2] drm/bridge: Fix error handling in analogix_dp_probe

2022-04-21 Thread Robert Foss
On Wed, 20 Apr 2022 at 03:16, Miaoqian Lin wrote: > > In the error handling path, the clk_prepare_enable() function > call should be balanced by a corresponding 'clk_disable_unprepare()' > call , as already done in the remove function. > > Fixes: 3424e3a4f844 ("drm: bridge: analogix/dp: split exyn

[PATCH] drm/ttm: use kvcalloc() instead of kvmalloc_array() in ttm_tt

2022-04-21 Thread Yang Wang
simplify programming with existing functions. Signed-off-by: Yang Wang --- drivers/gpu/drm/ttm/ttm_tt.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c index 79c870a3bef8..cbb3d1fb4caf 100644 -

Re: [PATCH v3] drm/gma500: depend on framebuffer

2022-04-21 Thread Patrik Jakobsson
On Thu, Apr 21, 2022 at 1:49 PM Thomas Zimmermann wrote: > > Hi > > Am 09.04.22 um 06:23 schrieb James Hilliard: > > Select the efi framebuffer if efi is enabled. > > > > This appears to be needed for video output to function correctly. > > > > Signed-off-by: James Hilliard > > --- > > Changes v2

Re: [PATCH v3] drm/gma500: depend on framebuffer

2022-04-21 Thread Javier Martinez Canillas
Hello Patrik, On 4/21/22 14:39, Patrik Jakobsson wrote: > On Thu, Apr 21, 2022 at 1:49 PM Thomas Zimmermann wrote: >> >> Hi >> >> Am 09.04.22 um 06:23 schrieb James Hilliard: >>> Select the efi framebuffer if efi is enabled. >>> >>> This appears to be needed for video output to function correctly

Re: [PATCH] drm/ttm: use kvcalloc() instead of kvmalloc_array() in ttm_tt

2022-04-21 Thread Christian König
Am 21.04.22 um 14:34 schrieb Yang Wang: simplify programming with existing functions. Signed-off-by: Yang Wang With a minimal style change reviewed and pushed to drm-misc-next. Thanks, Christian. --- drivers/gpu/drm/ttm/ttm_tt.c | 21 - 1 file changed, 12 insertions(

Re: [PATCH v3 7/8] drm/display: Move HDMI helpers into display-helper module

2022-04-21 Thread Javier Martinez Canillas
Hello Thomas, On 4/21/22 09:31, Thomas Zimmermann wrote: > Move DRM's HMDI helpers into the display/ subdirectoy and add it > to DRM's display helpers. Update all affected drivers. No functional > changes. > > The HDMI helpers were implemented in the EDID and connector code, but > are actually un

Re: [PATCH v3] drm/gma500: depend on framebuffer

2022-04-21 Thread Patrik Jakobsson
On Thu, Apr 21, 2022 at 2:47 PM Javier Martinez Canillas wrote: > > Hello Patrik, > > On 4/21/22 14:39, Patrik Jakobsson wrote: > > On Thu, Apr 21, 2022 at 1:49 PM Thomas Zimmermann > > wrote: > >> > >> Hi > >> > >> Am 09.04.22 um 06:23 schrieb James Hilliard: > >>> Select the efi framebuffer if

Re: [PATCH] drm/ttm: use kvcalloc() instead of kvmalloc_array() in ttm_tt

2022-04-21 Thread Wang, Yang(Kevin)
[AMD Official Use Only] From: Koenig, Christian Sent: Thursday, April 21, 2022 8:48 PM To: Wang, Yang(Kevin) ; amd-...@lists.freedesktop.org ; dri-devel@lists.freedesktop.org Cc: Kuehling, Felix ; Lazar, Lijo Subject: Re: [PATCH] drm/ttm: use kvcalloc() instea

Re: [PULL v2] gvt-next

2022-04-21 Thread Jason Gunthorpe
On Thu, Apr 21, 2022 at 09:41:30AM +0300, Joonas Lahtinen wrote: > + Tvrtko > > Quoting Christoph Hellwig (2022-04-21 08:47:38) > > On Thu, Apr 21, 2022 at 04:57:34AM +, Wang, Zhi A wrote: > > > Is it possible that I can send two different pull based on the same > > > branch? > > > I was thin

[PATCH v1] drm/bridge: Fix it6505 Kconfig DRM_DP_AUX_BUS dependency

2022-04-21 Thread Robert Foss
it6505 depends on DRM_DP_AUX_BUS, the kconfig for it6505 should reflect this dependency using 'select'. Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver") Reported-by: kernel test robot Suggested-by: Randy Dunlap Signed-off-by: Robert Foss --- drivers/gpu/drm/bridge/Kconfig | 1 + 1 file ch

[PATCH] drm/msm: change msm_sched_ops from global to static

2022-04-21 Thread Tom Rix
Smatch reports this issue msm_ringbuffer.c:43:36: warning: symbol 'msm_sched_ops' was not declared. Should it be static? msm_sched_ops is only used in msm_ringbuffer.c so change its storage-class specifier to static. Signed-off-by: Tom Rix --- drivers/gpu/drm/msm/msm_ringbuffer.c | 2 +- 1 fil

Re: [PATCH v3] drm/gma500: depend on framebuffer

2022-04-21 Thread Thomas Zimmermann
Hi Am 21.04.22 um 14:54 schrieb Patrik Jakobsson: On Thu, Apr 21, 2022 at 2:47 PM Javier Martinez Canillas wrote: Hello Patrik, On 4/21/22 14:39, Patrik Jakobsson wrote: On Thu, Apr 21, 2022 at 1:49 PM Thomas Zimmermann wrote: Hi Am 09.04.22 um 06:23 schrieb James Hilliard: Select the

Re: [PATCH v3] drm/gma500: depend on framebuffer

2022-04-21 Thread Javier Martinez Canillas
On 4/21/22 14:54, Patrik Jakobsson wrote: > On Thu, Apr 21, 2022 at 2:47 PM Javier Martinez Canillas > wrote: [snip] > diff --git a/drivers/gpu/drm/gma500/Kconfig > b/drivers/gpu/drm/gma500/Kconfig > index 0cff20265f97..a422fa84d53b 100644 > --- a/drivers/gpu/drm/gma500/Kconfig

Re: [PATCH 1/4] drm/i915/gt: GEM_BUG_ON unexpected NULL at scatterlist walking

2022-04-21 Thread Hellstrom, Thomas
On Thu, 2022-04-21 at 17:08 +0530, Ramalingam C wrote: > While locating the start of ccs scatterlist in smem scatterlist, that > has > to be the size of lmem obj size + corresponding ccs data size. Report > bug > if scatterlist terminate before that length. > > Signed-off-by: Ramalingam C > --- >

[PATCH] drm/nouveau/gsp: change gv100_gsp from global to static

2022-04-21 Thread Tom Rix
Smatch reports this issue gv100.c:46:1: warning: symbol 'gv100_gsp' was not declared. Should it be static? gv100_gsp is only used in gv100.c so change its storage-class specifier to static. Signed-off-by: Tom Rix --- drivers/gpu/drm/nouveau/nvkm/subdev/gsp/gv100.c | 2 +- 1 file changed, 1 inse

Re: [PATCH 00/41] OMAP1 full multiplatform conversion

2022-04-21 Thread Aaro Koskinen
Hi, On Wed, Apr 20, 2022 at 10:00:13PM +0200, Arnd Bergmann wrote: > On Wed, Apr 20, 2022 at 7:08 PM Aaro Koskinen wrote: > > On Tue, Apr 19, 2022 at 03:36:42PM +0200, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > This is the full series for converting OMAP1 to multiplatform, rebase

Re: [PATCH 3/4] drm/i915/gt: Extend doc on Flat-CCS obj eviction

2022-04-21 Thread Hellstrom, Thomas
On Thu, 2022-04-21 at 17:08 +0530, Ramalingam C wrote: > Capture the eviction details for Flat-CCS capable lmem only objects > and > lmem objects with smem residency. This also captures the impact of > eviction on  object's memory residency and Flat-CCS compression > state. > > Signed-off-by: Rama

Re: [PATCH 4/4] uapi/drm/i915: Update the placement list impact on obj residency

2022-04-21 Thread Hellstrom, Thomas
On Thu, 2022-04-21 at 17:08 +0530, Ramalingam C wrote: > Object created with list of memory classes as placement preferences, > can > be backed with any memory class of the list as per kernel's migration > policy for the memory contrain situation. Userspace won't be notified > of > the memory resid

Re: [PATCH 1/4] drm/i915/gt: GEM_BUG_ON unexpected NULL at scatterlist walking

2022-04-21 Thread Ramalingam C
On 2022-04-21 at 18:57:59 +0530, Hellstrom, Thomas wrote: > On Thu, 2022-04-21 at 17:08 +0530, Ramalingam C wrote: > > While locating the start of ccs scatterlist in smem scatterlist, that > > has > > to be the size of lmem obj size + corresponding ccs data size. Report > > bug > > if scatterlist t

Re: [PULL v2] gvt-next

2022-04-21 Thread Wang, Zhi A
On 4/21/22 1:14 PM, Jason Gunthorpe wrote: > On Thu, Apr 21, 2022 at 09:41:30AM +0300, Joonas Lahtinen wrote: >> + Tvrtko >> >> Quoting Christoph Hellwig (2022-04-21 08:47:38) >>> On Thu, Apr 21, 2022 at 04:57:34AM +, Wang, Zhi A wrote: Is it possible that I can send two different pull bas

Re: [PATCH] drm/amd/display: Remove useless code

2022-04-21 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Apr 21, 2022 at 6:29 AM Haowen Bai wrote: > > aux_rep only memset but no use at all, so we drop it. > > Signed-off-by: Haowen Bai > --- > drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/di

[PATCH] drm/qxl: remove qxl_log_level global

2022-04-21 Thread Tom Rix
Smatch reports this issue qxl_kms.c:36:5: warning: symbol 'qxl_log_level' was not declared. Should it be static? qxl_log_level is defined qxl_kms.c but unused, so remove. Signed-off-by: Tom Rix --- drivers/gpu/drm/qxl/qxl_kms.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/d

Re: [PATCH] drm/amd/display: Fix memory leak in dcn21_clock_source_create

2022-04-21 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Apr 21, 2022 at 5:03 AM Miaoqian Lin wrote: > > When dcn20_clk_src_construct() fails, we need to release clk_src. > > Fixes: 6f4e6361c3ff ("drm/amd/display: Add Renoir resource (v2)") > Signed-off-by: Miaoqian Lin > --- > drivers/gpu/drm/amd/display/dc/dcn21/dcn2

Re: (subset) [PATCH v2 1/3] drm/panel: nt36672a: add backlight support

2022-04-21 Thread Bjorn Andersson
On Fri, 1 Apr 2022 05:48:08 +0530, Joel Selvaraj wrote: > Add support for backlight. This panel supports backlight control > through the QCOM WLED driver in Xiaomi Poco F1 device. > > Applied, thanks! [3/3] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable qcom wled backlight and link to panel

[PATCH v8 0/4] Add support for the eDP panel over aux_bus

2022-04-21 Thread Sankeerth Billakanti
This series adds support for generic eDP panel over aux_bus. These changes are dependent on the following patches: https://patchwork.kernel.org/project/linux-arm-msm/patch/20220211224006.1797846-5-dmitry.barysh...@linaro.org/ https://patchwork.kernel.org/project/linux-arm-msm/patch/20220211224006.

[PATCH v8 1/4] drm/msm/dp: Add eDP support via aux_bus

2022-04-21 Thread Sankeerth Billakanti
This patch adds support for generic eDP sink through aux_bus. The eDP/DP controller driver should support aux transactions originating from the panel-edp driver and hence should be initialized and ready. The panel bridge supporting the panel should be ready before the bridge connector is initializ

[PATCH v8 2/4] drm/msm/dp: Support only IRQ_HPD and REPLUG interrupts for eDP

2022-04-21 Thread Sankeerth Billakanti
The panel-edp enables the eDP panel power during probe, get_modes and pre-enable. The eDP connect and disconnect interrupts for the eDP/DP controller are directly dependent on panel power. As eDP display can be assumed as always connected, the controller driver can skip the eDP connect and disconne

[PATCH v8 3/4] drm/msm/dp: wait for hpd high before aux transaction

2022-04-21 Thread Sankeerth Billakanti
The source device should ensure the sink is ready before proceeding to read the sink capability or perform any aux transactions. The sink will indicate its readiness by asserting the HPD line. The controller driver needs to wait for the hpd line to be asserted by the sink before it performs any aux

[PATCH v8 4/4] drm/msm/dp: Support the eDP modes given by panel

2022-04-21 Thread Sankeerth Billakanti
The eDP controller does not have a reliable way keep panel powered on to read the sink capabilities. So, the controller driver cannot validate if a mode can be supported by the source. We will rely on the panel driver to populate only the supported modes for now. Signed-off-by: Sankeerth Billakant

AMD display drivers handling DRM CRTC color mgmt props

2022-04-21 Thread Melissa Wen
Hi all, I'm examining how DRM color management properties (degamma, ctm, gamma) are applied to AMD display drivers. As far I could understand thanks Nicholas documentation on amdgpu_dm/amdgpu_dm_color, DC drivers have per-plane color correction features: * - Input gamma LUT (de-normalized) * - In

[PATCH] drm/rockchip: cdn-dp: change rk3399_cdn_dp from global to static

2022-04-21 Thread Tom Rix
Smatch reports this issue cdn-dp-core.c:51:20: warning: symbol 'rk3399_cdn_dp' was not declared. Should it be static? rk3399_cdn_dp is only used in cdn-dp-core.c so change its storge-class specifier to static. Signed-off-by: Tom Rix --- drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +- 1 file cha

Re: [PATCH 00/41] OMAP1 full multiplatform conversion

2022-04-21 Thread Arnd Bergmann
On Thu, Apr 21, 2022 at 3:34 PM Aaro Koskinen wrote: > > Hi, > > On Wed, Apr 20, 2022 at 10:00:13PM +0200, Arnd Bergmann wrote: > > On Wed, Apr 20, 2022 at 7:08 PM Aaro Koskinen wrote: > > > On Tue, Apr 19, 2022 at 03:36:42PM +0200, Arnd Bergmann wrote: > > > > From: Arnd Bergmann > > > > > > >

Re: [PATCH v8 1/4] drm/msm/dp: Add eDP support via aux_bus

2022-04-21 Thread Doug Anderson
Hi, On Thu, Apr 21, 2022 at 7:37 AM Sankeerth Billakanti wrote: > > @@ -1530,6 +1532,61 @@ void msm_dp_debugfs_init(struct msm_dp *dp_display, > struct drm_minor *minor) > } > } > > +static int dp_display_get_next_bridge(struct msm_dp *dp) > +{ > + int rc; > + struct dp_disp

Re: [PATCH v8 2/4] drm/msm/dp: Support only IRQ_HPD and REPLUG interrupts for eDP

2022-04-21 Thread Doug Anderson
Hi, On Thu, Apr 21, 2022 at 7:37 AM Sankeerth Billakanti wrote: > > The panel-edp enables the eDP panel power during probe, get_modes > and pre-enable. The eDP connect and disconnect interrupts for the eDP/DP > controller are directly dependent on panel power. As eDP display can be > assumed as a

Re: [PATCH v2 00/48] ARM: PXA multiplatform support

2022-04-21 Thread Arnd Bergmann
On Tue, Apr 19, 2022 at 6:37 PM Arnd Bergmann wrote: > > From: Arnd Bergmann > > This revisits a series I sent a few years ago: > > https://lore.kernel.org/lkml/20191018154052.1276506-1-a...@arndb.de/ > > All the other ARMv5 conversions are under way now, with > OMAP1 being the only one still not

RE: [PATCH v8 1/4] drm/msm/dp: Add eDP support via aux_bus

2022-04-21 Thread Sankeerth Billakanti (QUIC)
Hi Doug, >On Thu, Apr 21, 2022 at 7:37 AM Sankeerth Billakanti > wrote: >> >> @@ -1530,6 +1532,61 @@ void msm_dp_debugfs_init(struct msm_dp >*dp_display, struct drm_minor *minor) >> } >> } >> >> +static int dp_display_get_next_bridge(struct msm_dp *dp) { >> + int rc; >> + stru

Re: [PATCH v8 1/4] drm/msm/dp: Add eDP support via aux_bus

2022-04-21 Thread Doug Anderson
Hi, On Thu, Apr 21, 2022 at 9:00 AM Sankeerth Billakanti (QUIC) wrote: > > >> + } > >> + > >> + /* > >> +* External bridges are mandatory for eDP interfaces: one has to > >> +* provide at least an eDP panel (which gets wrapped into panel- > >bridge). > >> +* >

[PATCH v2 0/7] Make the rest of the VFIO driver interface use vfio_device

2022-04-21 Thread Jason Gunthorpe
Prior series have transformed other parts of VFIO from working on struct device or struct vfio_group into working directly on struct vfio_device. Based on that work we now have vfio_device's readily available in all the drivers. Update the rest of the driver facing API to use vfio_device as an inp

[PATCH v2 2/7] vfio/ccw: Remove mdev from struct channel_program

2022-04-21 Thread Jason Gunthorpe
The next patch wants the vfio_device instead. There is no reason to store a pointer here since we can container_of back to the vfio_device. Reviewed-by: Eric Farman Signed-off-by: Jason Gunthorpe --- drivers/s390/cio/vfio_ccw_cp.c | 47 - drivers/s390/cio/vfio_c

[PATCH v2 3/7] vfio/mdev: Pass in a struct vfio_device * to vfio_pin/unpin_pages()

2022-04-21 Thread Jason Gunthorpe
Every caller has a readily available vfio_device pointer, use that instead of passing in a generic struct device. The struct vfio_device already contains the group we need so this avoids complexity, extra refcountings, and a confusing lifecycle model. Reviewed-by: Christoph Hellwig Acked-by: Eric

[PATCH v2 6/7] vfio: Remove dead code

2022-04-21 Thread Jason Gunthorpe
Now that callers have been updated to use the vfio_device APIs the driver facing group interface is no longer used, delete it: - vfio_group_get_external_user_from_dev() - vfio_group_pin_pages() - vfio_group_unpin_pages() - vfio_group_iommu_domain() Reviewed-by: Christoph Hellwig Signed-off-by: J

[PATCH v2 1/7] vfio: Make vfio_(un)register_notifier accept a vfio_device

2022-04-21 Thread Jason Gunthorpe
All callers have a struct vfio_device trivially available, pass it in directly and avoid calling the expensive vfio_group_get_from_dev(). To support the unconverted kvmgt mdev driver add mdev_legacy_get_vfio_device() which will return the vfio_device pointer vfio_mdev.c puts in the drv_data. Acke

[PATCH v2 5/7] drm/i915/gvt: Change from vfio_group_(un)pin_pages to vfio_(un)pin_pages

2022-04-21 Thread Jason Gunthorpe
Use the existing vfio_device versions of vfio_(un)pin_pages(). There is no reason to use a group interface here, kvmgt has easy access to a vfio_device. Delete kvmgt_vdev::vfio_group since these calls were the last users. Signed-off-by: Jason Gunthorpe --- drivers/gpu/drm/i915/gvt/gvt.h | 1

[PATCH v2 7/7] vfio: Remove calls to vfio_group_add_container_user()

2022-04-21 Thread Jason Gunthorpe
When the open_device() op is called the container_users is incremented and held incremented until close_device(). Thus, so long as drivers call functions within their open_device()/close_device() region they do not need to worry about the container_users. These functions can all only be called bet

  1   2   >