[PATCH v8 0/5] phy: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support

2022-04-14 Thread Liu Ying
Hi, This is the v8 series to add i.MX8qxp LVDS PHY mode support for the Mixel PHY in the Freescale i.MX8qxp SoC. The Mixel PHY is MIPI DPHY + LVDS PHY combo, which can works in either MIPI DPHY mode or LVDS PHY mode. The PHY mode is controlled by i.MX8qxp SCU firmware. The PHY driver would call

[PATCH v8 1/5] drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_mode_set()

2022-04-14 Thread Liu Ying
The Northwest Logic MIPI DSI host controller embedded in i.MX8qxp works with a Mixel MIPI DPHY + LVDS PHY combo to support either a MIPI DSI display or a LVDS display. So, this patch calls phy_set_mode() from nwl_dsi_mode_set() to set PHY mode to MIPI DPHY explicitly. Cc: Guido Günther Cc: Rober

[PATCH v8 2/5] phy: Add LVDS configuration options

2022-04-14 Thread Liu Ying
This patch allows LVDS PHYs to be configured through the generic functions and through a custom structure added to the generic union. The parameters added here are based on common LVDS PHY implementation practices. The set of parameters should cover all potential users. Cc: Kishon Vijay Abraham

[PATCH v8 3/5] dt-bindings: phy: Convert mixel, mipi-dsi-phy to json-schema

2022-04-14 Thread Liu Ying
This patch converts the mixel,mipi-dsi-phy binding to DT schema format using json-schema. Comparing to the plain text version, the new binding adds the 'assigned-clocks', 'assigned-clock-parents' and 'assigned-clock-rates' properites, otherwise 'make dtbs_check' would complain that there are mis-m

[PATCH v8 4/5] dt-bindings: phy: mixel: mipi-dsi-phy: Add Mixel combo PHY support for i.MX8qxp

2022-04-14 Thread Liu Ying
Add support for Mixel MIPI DPHY + LVDS PHY combo IP as found on Freescale i.MX8qxp SoC. Cc: Guido Günther Cc: Kishon Vijay Abraham I Cc: Vinod Koul Cc: Rob Herring Cc: NXP Linux Team Reviewed-by: Rob Herring Reviewed-by: Guido Günther Signed-off-by: Liu Ying --- v7->v8: * No change. v6->v

[PATCH v8 5/5] phy: freescale: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support

2022-04-14 Thread Liu Ying
i.MX8qxp SoC embeds a Mixel MIPI DPHY + LVDS PHY combo which supports either a MIPI DSI display or a LVDS display. The PHY mode is controlled by SCU firmware and the driver would call a SCU firmware function to configure the PHY mode. The single LVDS PHY has 4 data lanes to support a LVDS display

RE: [PATCH v2 0/7] Add RZ/G2L Display support

2022-04-14 Thread Biju Das
Hi All, Gentle ping, Are we happy with this patch series? Cheers, Biju > Subject: [PATCH v2 0/7] Add RZ/G2L Display support > > RZ/G2L LCD controller composed of Frame compression Processor(FCPVD), > Video signal processor (VSPD) and Display unit(DU). The output of LCDC is > connected to Displa

RE: [PATCH v2 0/2] Add RZ/G2L DSI driver

2022-04-14 Thread Biju Das
Hi All, Gentle ping. Are we happy with this patch series? Please let me know. Cheers, Biju > Subject: [PATCH v2 0/2] Add RZ/G2L DSI driver > > This patch series aims to support the MIPI DSI encoder found in the RZ/G2L > SoC. It currently supports DSI mode only. > > This unit supports MIPI Alli

[PATCH] drm/i915: Remove intel_gvt_init_host declaration

2022-04-14 Thread Cong Liu
this function has been deleted since commit 9bdb073464d6 ("drm/i915/gvt: Change KVMGT as self load module"), remove the deprecated function declaration. Signed-off-by: Cong Liu --- drivers/gpu/drm/i915/intel_gvt.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_gvt.

[PULL] drm-misc-next

2022-04-14 Thread Maxime Ripard
Hi Daniel, Dave, Here's this week drm-misc-next PR Maxime drm-misc-next-2022-04-14: drm-misc-next for $kernel-version: UAPI Changes: Cross-subsystem Changes: - fbcon: various loading and locking cleanups Core Changes: - buddy: Check for page size alignment at allocation - dma-buf: Add d

Re: [PATCHv4] drm/amdgpu: disable ASPM on Intel Alder Lake based systems

2022-04-14 Thread Paul Menzel
[Cc: -kernel test robot ] Dear Alex, dear Richard, Am 13.04.22 um 15:00 schrieb Alex Deucher: On Wed, Apr 13, 2022 at 3:43 AM Paul Menzel wrote: Thank you for sending out v4. Am 12.04.22 um 23:50 schrieb Richard Gong: Active State Power Management (ASPM) feature is enabled since kernel 5.

Re: [PATCH v7 1/5] drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_mode_set()

2022-04-14 Thread Guido Günther
Hi, On Thu, Apr 14, 2022 at 02:48:54PM +0800, Liu Ying wrote: > The Northwest Logic MIPI DSI host controller embedded in i.MX8qxp > works with a Mixel MIPI DPHY + LVDS PHY combo to support either > a MIPI DSI display or a LVDS display. So, this patch calls > phy_set_mode() from nwl_dsi_mode_set()

Re: commit 15512021eb3975a8c2366e3883337e252bb0eee5 causes white spots in console screens

2022-04-14 Thread Lisovskiy, Stanislav
On Thu, Apr 14, 2022 at 08:33:35AM +0200, François Valenduc wrote: > Le 14/04/22 à 08:31, Lisovskiy, Stanislav a écrit : > > On Wed, Apr 13, 2022 at 08:12:20PM +0300, Jani Nikula wrote: > > > On Wed, 13 Apr 2022, François Valenduc wrote: > > > > Commit 15512021eb3975a8c2366e3883337e252bb0eee5 > >

Re: commit 15512021eb3975a8c2366e3883337e252bb0eee5 causes white spots in console screens

2022-04-14 Thread François Valenduc
Le 14/04/22 à 10:03, Lisovskiy, Stanislav a écrit : On Thu, Apr 14, 2022 at 08:33:35AM +0200, François Valenduc wrote: Le 14/04/22 à 08:31, Lisovskiy, Stanislav a écrit : On Wed, Apr 13, 2022 at 08:12:20PM +0300, Jani Nikula wrote: On Wed, 13 Apr 2022, François Valenduc wrote: Commit 15512

Re: [PATCH v10 12/24] drm/rockchip: dw_hdmi: drop mode_valid hook

2022-04-14 Thread Sascha Hauer
On Mon, Apr 11, 2022 at 07:00:51PM +0200, Alex Bee wrote: > Am 11.04.22 um 09:53 schrieb Sascha Hauer: > > On Sun, Apr 10, 2022 at 01:31:23PM +0200, Alex Bee wrote: > >> Am 08.04.22 um 13:22 schrieb Sascha Hauer: > >>> The driver checks if the pixel clock of the given mode matches an entry > >>> in

Re: [RFC PATCH 02/16] dt-bindings: display: rockchip: Add EBC binding

2022-04-14 Thread Andreas Kemnade
Hi Samuel, for comparison, here is my submission for the IMX EPDC bindings: https://lore.kernel.org/linux-devicetree/20220206080016.796556-2-andr...@kemnade.info/ On Wed, 13 Apr 2022 17:19:02 -0500 Samuel Holland wrote: [...] we have sy7636a driver in kernel which should be suitable for poweri

Re: commit 15512021eb3975a8c2366e3883337e252bb0eee5 causes white spots in console screens

2022-04-14 Thread Jani Nikula
On Thu, 14 Apr 2022, François Valenduc wrote: > Le 14/04/22 à 10:03, Lisovskiy, Stanislav a écrit : >> On Thu, Apr 14, 2022 at 08:33:35AM +0200, François Valenduc wrote: >>> Le 14/04/22 à 08:31, Lisovskiy, Stanislav a écrit : On Wed, Apr 13, 2022 at 08:12:20PM +0300, Jani Nikula wrote: >

Re: [RESEND][PATCH] omapdrm: fix missing check on list iterator

2022-04-14 Thread Tomi Valkeinen
Hi, On 14/04/2022 09:14, Xiaomeng Tong wrote: The bug is here: bus_flags = connector->display_info.bus_flags; The list iterator 'connector-' will point to a bogus position containing HEAD if the list is empty or no element is found. This case must be checked before any use of the iterat

Re: [PATCH] drm/radeon: Add build directory to include path

2022-04-14 Thread Christian König
Am 14.04.22 um 09:37 schrieb Michel Dänzer: On 2022-04-14 08:24, Christian König wrote: Am 13.04.22 um 18:14 schrieb Michel Dänzer: From: Michel Dänzer Fixes compile errors with out-of-tree builds, e.g. ../drivers/gpu/drm/radeon/r420.c:38:10: fatal error: r420_reg_safe.h: No such file or di

Re: [RFC PATCH 00/16] drm/rockchip: Rockchip EBC ("E-Book Controller") display driver

2022-04-14 Thread Maxime Ripard
On Wed, Apr 13, 2022 at 05:19:00PM -0500, Samuel Holland wrote: > This series adds a DRM driver for the electrophoretic display controller > found in a few different Rockchip SoCs, specifically the RK3566/RK3568 > variant[0] used by the PineNote tablet[1]. > > This is my first real involvement wit

[PATCH] drm/bridge: anx7625: Fill in empty ELD when no connector

2022-04-14 Thread Hsin-Yi Wang
Speaker may share I2S with DP and .get_eld callback will be called when speaker is playing. When HDMI wans't connected, the connector will be null. Instead of return an error, fill in empty ELD. Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/bridge/analogix/anx7625.c | 12 ++-- 1 file c

RE: [Intel-gfx] commit 15512021eb3975a8c2366e3883337e252bb0eee5 causes white spots in console screens

2022-04-14 Thread Saarinen, Jani
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: torstai 14. huhtikuuta 2022 11.32 > To: François Valenduc ; Lisovskiy, Stanislav > > Cc: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Subject: Re: [Intel-gfx] commit 15512021eb3975a8c2366e388

Re: [RFC] drm/kms: control display brightness through drm_connector properties

2022-04-14 Thread Jani Nikula
On Mon, 11 Apr 2022, Alex Deucher wrote: > On Mon, Apr 11, 2022 at 6:18 AM Hans de Goede wrote: >> >> Hi, >> >> On 4/8/22 17:11, Alex Deucher wrote: >> > On Fri, Apr 8, 2022 at 10:56 AM Hans de Goede wrote: >> >> >> >> Hi, >> >> >> >> On 4/8/22 16:08, Alex Deucher wrote: >> >>> On Fri, Apr 8, 20

Re: [PATCH v3 1/2] drm/dp: Factor out a function to probe a DPCD address

2022-04-14 Thread Jani Nikula
On Mon, 11 Apr 2022, Imre Deak wrote: > Factor out from drm_dp_dpcd_read() a function to probe a DPCD address > with a 1-byte read access. This will be needed by the next patch doing a > read from an LTTPR address, which must happen without the preceding > wake-up read in drm_dp_dpcd_read(). > > W

Re: [PATCH 5.10 1/1] drm/amdgpu: Ensure the AMDGPU file descriptor is legitimate

2022-04-14 Thread Greg KH
On Tue, Apr 12, 2022 at 04:20:57PM +0100, Lee Jones wrote: > [ Upstream commit b40a6ab2cf9213923bf8e821ce7fa7f6a0a26990 ] > > This is a partial cherry-pick of the above upstream commit. > > It ensures the file descriptor passed in by userspace is a valid one. > > Cc: Felix Kuehling > Cc: Alex D

Re: [PATCH 4.19 1/2] drm/amdgpu: Check if fd really is an amdgpu fd.

2022-04-14 Thread Greg KH
On Tue, Apr 12, 2022 at 04:35:28PM +0100, Lee Jones wrote: > From: Bas Nieuwenhuizen > > [ Upstream commit 021830d24ba55a578f602979274965344c8e6284 ] > > Otherwise we interpret the file private data as drm & amdgpu data > while it might not be, possibly allowing one to get memory corruption. >

Re: [PATCH v6 1/2] dt-bindings: Add DT schema for Arm Mali Valhall GPU

2022-04-14 Thread AngeloGioacchino Del Regno
Il 14/04/22 04:50, Nick Fan ha scritto: Add devicetree schema for Arm Mali Valhall GPU Define a compatible string for the Mali Valhall GPU for MediaTek's SoC platform. Signed-off-by: Nick Fan Hello Nick, Unfortunately, this binding is completely wrong. First of all, there's no arm,mali-valh

[PATCH v7 0/4] Add support for the eDP panel over aux_bus

2022-04-14 Thread Sankeerth Billakanti
This series adds support for generic eDP panel over aux_bus. These changes are dependent on the following series: https://patchwork.kernel.org/project/linux-arm-msm/list/?series=613654&state=* Sankeerth Billakanti (4): drm/msm/dp: Add eDP support via aux_bus drm/msm/dp: Support only IRQ_HPD a

[PATCH v7 1/4] drm/msm/dp: Add eDP support via aux_bus

2022-04-14 Thread Sankeerth Billakanti
This patch adds support for generic eDP sink through aux_bus. The eDP/DP controller driver should support aux transactions originating from the panel-edp driver and hence should be initialized and ready. The panel bridge supporting the panel should be ready before the bridge connector is initializ

[PATCH v7 2/4] drm/msm/dp: Support only IRQ_HPD and REPLUG interrupts for eDP

2022-04-14 Thread Sankeerth Billakanti
The panel-edp enables the eDP panel power during probe, get_modes and enable. The eDP connect and disconnect interrupts for the eDP/DP controller are directly dependent on panel power. As eDP display can be assumed as always connected, the controller driver can skip the eDP connect and disconnect i

[PATCH v7 3/4] drm/msm/dp: wait for hpd high before aux transaction

2022-04-14 Thread Sankeerth Billakanti
The source device should ensure the sink is ready before proceeding to read the sink capability or perform any aux transactions. The sink will indicate its readiness by asserting the HPD line. The controller driver needs to wait for the hpd line to be asserted by the sink before it performs any aux

[PATCH v7 4/4] Support the eDP modes given by panel

2022-04-14 Thread Sankeerth Billakanti
The eDP controller does not have a reliable way keep panel powered on to read the sink capabilities. So, the controller driver cannot validate if a mode can be supported by the source. We will rely on the panel driver to populate only the supported modes for now. Signed-off-by: Sankeerth Billakant

Re: refactor the i915 GVT support and move to the modern mdev API v3

2022-04-14 Thread Wang, Zhi A
On 4/13/22 11:20 PM, Jason Gunthorpe wrote: > On Wed, Apr 13, 2022 at 11:13:06PM +, Wang, Zhi A wrote: >> Hi folks: >> >> Thanks so much for the efforts. I prepared a branch which contains all our >> patches.The aim of the branch is for the VFIO maintainers to pull the whole >> bunch easily a

[PATCH 0/1] add support for enum module parameters

2022-04-14 Thread Jani Nikula
Hey, I've sent this before, ages ago, but haven't really followed through with it. I still think it would be useful for many scenarios where a plain number is a clumsy interface for a module param. Thoughts? BR, Jani. Cc: Andrew Morton Cc: Greg Kroah-Hartman Cc: Lucas De Marchi Jani Nikula

[PATCH 1/1] module: add enum module parameter type to map names to values

2022-04-14 Thread Jani Nikula
Add enum module parameter type that's internally an int and externally maps names to values. This makes the userspace interface more intuitive to use and somewhat easier to document, while also limiting the allowed values set by userspace to the defined set. For example, given this code to define

Re: [PATCH v6 1/2] dt-bindings: Add DT schema for Arm Mali Valhall GPU

2022-04-14 Thread Steven Price
On 14/04/2022 12:51, AngeloGioacchino Del Regno wrote: > Il 14/04/22 04:50, Nick Fan ha scritto: >> Add devicetree schema for Arm Mali Valhall GPU >> >> Define a compatible string for the Mali Valhall GPU >> for MediaTek's SoC platform. >> >> Signed-off-by: Nick Fan > > Hello Nick, > Unfortunatel

Re: [PATCH v4 1/5] dt-bindings: display: ssd1307fb: Deprecate "-i2c" compatible strings

2022-04-14 Thread Rob Herring
On Wed, 13 Apr 2022 18:23:54 +0200, Javier Martinez Canillas wrote: > The current compatible strings for SSD130x I2C controllers contain both an > "fb" and "-i2c" suffixes. It seems to indicate that are for a fbdev driver > and also that are for devices that can be accessed over an I2C bus. > > Bu

Re: [PATCH v4 2/5] dt-bindings: display: ssd1307fb: Extend schema for SPI controllers

2022-04-14 Thread Rob Herring
On Wed, 13 Apr 2022 18:23:55 +0200, Javier Martinez Canillas wrote: > The Solomon SSD130x OLED displays can either have an I2C or SPI interface, > add to the schema the properties and examples for OLED devices under SPI. > > Signed-off-by: Javier Martinez Canillas > Acked-by: Mark Brown > Review

Re: [RFC] drm/kms: control display brightness through drm_connector properties

2022-04-14 Thread Jani Nikula
On Thu, 07 Apr 2022, Hans de Goede wrote: > As discussed already several times in the past: > https://www.x.org/wiki/Events/XDC2014/XDC2014GoedeBacklight/ > > https://lore.kernel.org/all/4b17ba08-39f3-57dd-5aad-d37d844b0...@linux.intel.com/ > > The current userspace API for brightness control o

Re: [PATCHv4] drm/amdgpu: disable ASPM on Intel Alder Lake based systems

2022-04-14 Thread Alex Deucher
On Thu, Apr 14, 2022 at 3:52 AM Paul Menzel wrote: > > [Cc: -kernel test robot ] > > Dear Alex, dear Richard, > > > Am 13.04.22 um 15:00 schrieb Alex Deucher: > > On Wed, Apr 13, 2022 at 3:43 AM Paul Menzel wrote: > > >> Thank you for sending out v4. > >> > >> Am 12.04.22 um 23:50 schrieb Richard

Re: [PATCH v3 1/5] drm/i915: instantiate ttm ranger manager for stolen memory

2022-04-14 Thread Thomas Hellström
On 4/12/22 21:38, Robert Beckett wrote: prepare for ttm based stolen region by using ttm range manager as the resource manager for stolen region. Signed-off-by: Robert Beckett LGTM. Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 6 ++-- drivers/g

Re: [Intel-gfx] commit 15512021eb3975a8c2366e3883337e252bb0eee5 causes white spots in console screens

2022-04-14 Thread François Valenduc
Le 14/04/22 à 11:51, Saarinen, Jani a écrit : -Original Message- From: Intel-gfx On Behalf Of Jani Nikula Sent: torstai 14. huhtikuuta 2022 11.32 To: François Valenduc ; Lisovskiy, Stanislav Cc: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org Subject: Re: [Intel-gfx]

[PATCH 4.19 202/338] video: fbdev: nvidiafb: Use strscpy() to prevent buffer overflow

2022-04-14 Thread Greg Kroah-Hartman
From: Tim Gardner [ Upstream commit 37a1a2e6eeeb101285cd34e12e48a881524701aa ] Coverity complains of a possible buffer overflow. However, given the 'static' scope of nvidia_setup_i2c_bus() it looks like that can't happen after examiniing the call sites. CID 19036 (#1 of 1): Copy into fixed size

Re: [PATCH] drm/radeon: Add build directory to include path

2022-04-14 Thread Alex Deucher
On Thu, Apr 14, 2022 at 4:44 AM Christian König wrote: > > Am 14.04.22 um 09:37 schrieb Michel Dänzer: > > On 2022-04-14 08:24, Christian König wrote: > >> Am 13.04.22 um 18:14 schrieb Michel Dänzer: > >>> From: Michel Dänzer > >>> > >>> Fixes compile errors with out-of-tree builds, e.g. > >>> >

Re: refactor the i915 GVT support and move to the modern mdev API v3

2022-04-14 Thread Jason Gunthorpe
On Thu, Apr 14, 2022 at 12:20:42PM +, Wang, Zhi A wrote: > On 4/13/22 11:20 PM, Jason Gunthorpe wrote: > > On Wed, Apr 13, 2022 at 11:13:06PM +, Wang, Zhi A wrote: > >> Hi folks: > >> > >> Thanks so much for the efforts. I prepared a branch which contains all our > >> patches.The aim of th

Re: refactor the i915 GVT support and move to the modern mdev API v3

2022-04-14 Thread Wang, Zhi A
On 4/14/22 1:34 PM, Jason Gunthorpe wrote: > On Thu, Apr 14, 2022 at 12:20:42PM +, Wang, Zhi A wrote: >> On 4/13/22 11:20 PM, Jason Gunthorpe wrote: >>> On Wed, Apr 13, 2022 at 11:13:06PM +, Wang, Zhi A wrote: Hi folks: Thanks so much for the efforts. I prepared a branch whic

Re: refactor the i915 GVT support and move to the modern mdev API v3

2022-04-14 Thread Jani Nikula
On Thu, 14 Apr 2022, Jason Gunthorpe wrote: > On Thu, Apr 14, 2022 at 12:20:42PM +, Wang, Zhi A wrote: >> On 4/13/22 11:20 PM, Jason Gunthorpe wrote: >> > On Wed, Apr 13, 2022 at 11:13:06PM +, Wang, Zhi A wrote: >> >> Hi folks: >> >> >> >> Thanks so much for the efforts. I prepared a branc

Re: refactor the i915 GVT support and move to the modern mdev API v3

2022-04-14 Thread Jason Gunthorpe
On Thu, Apr 14, 2022 at 01:39:11PM +, Wang, Zhi A wrote: > On 4/14/22 1:34 PM, Jason Gunthorpe wrote: > > On Thu, Apr 14, 2022 at 12:20:42PM +, Wang, Zhi A wrote: > >> On 4/13/22 11:20 PM, Jason Gunthorpe wrote: > >>> On Wed, Apr 13, 2022 at 11:13:06PM +, Wang, Zhi A wrote: > Hi fo

Re: refactor the i915 GVT support and move to the modern mdev API v3

2022-04-14 Thread Jason Gunthorpe
On Thu, Apr 14, 2022 at 04:40:11PM +0300, Jani Nikula wrote: > >> >> git clone https://github.com/intel/gvt-linux -b for-christoph > >> > > >> > There are alot of extra commits on there - is it possible to base this > >> > straight on rc1 not on some kind of existing DRM tree? > >> > > >> > Why

[PATCH 5.4 291/475] video: fbdev: nvidiafb: Use strscpy() to prevent buffer overflow

2022-04-14 Thread Greg Kroah-Hartman
From: Tim Gardner [ Upstream commit 37a1a2e6eeeb101285cd34e12e48a881524701aa ] Coverity complains of a possible buffer overflow. However, given the 'static' scope of nvidia_setup_i2c_bus() it looks like that can't happen after examiniing the call sites. CID 19036 (#1 of 1): Copy into fixed size

Re: refactor the i915 GVT support and move to the modern mdev API v3

2022-04-14 Thread Jani Nikula
On Thu, 14 Apr 2022, Jason Gunthorpe wrote: > On Thu, Apr 14, 2022 at 01:39:11PM +, Wang, Zhi A wrote: >> This one belongs to i915, which has already been queued in drm-intel-next, >> but >> not yet reached to the top. When it is landed in -rc, I will rebase this >> branch >> on it, then we

Re: [PATCH 0/1] add support for enum module parameters

2022-04-14 Thread Greg Kroah-Hartman
On Thu, Apr 14, 2022 at 03:30:32PM +0300, Jani Nikula wrote: > Hey, I've sent this before, ages ago, but haven't really followed > through with it. I still think it would be useful for many scenarios > where a plain number is a clumsy interface for a module param. > > Thoughts? We should not be a

Re: [PATCH v2 2/5] drm/i915: sanitize mem_flags for stolen buffers

2022-04-14 Thread Thomas Hellström
On Tue, 2022-04-12 at 15:18 +, Robert Beckett wrote: > stolen regions are not page backed or considered iomem. thus... A little more elaborate commit message please. > > Signed-off-by: Robert Beckett Reviewed-by: Thomas Hellström > --- >  drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c |

Re: [PATCH v2 3/5] drm/i915: ttm move/clear logic fix

2022-04-14 Thread Thomas Hellström
On Tue, 2022-04-12 at 15:18 +, Robert Beckett wrote: > ttm managed buffers start off with system resource definitions and > ttm_tt > tracking structures allocated (though unpopulated). > currently this prevents clearing of buffers on first move to desired > placements. > > The desired behaviou

Re: [PATCH v2 4/5] drm/i915: ttm backend dont provide mmap_offset for kernel buffers

2022-04-14 Thread Thomas Hellström
On Tue, 2022-04-12 at 15:18 +, Robert Beckett wrote: > stolen/kernel buffers should not be mmapable by userland. > do not provide callbacks to facilitate this for these buffers. > > Signed-off-by: Robert Beckett > --- >  drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 32 +-- > -

Re: [CI v3 00/12] drm/edid: low level EDID block read refactoring etc.

2022-04-14 Thread Jani Nikula
On Mon, 11 Apr 2022, Jani Nikula wrote: > v3 of [1] fixing the (!x == 0) mistake. Resending the entire thing with > hopes the test robot picks up the baseline better; I haven't had much > luck with --in-reply-to for that. There were some issues with our CI, but I'm pretty sure they were not cause

Re: [PATCH 9/9] vfio: Remove calls to vfio_group_add_container_user()

2022-04-14 Thread Jason Gunthorpe
On Thu, Apr 14, 2022 at 09:51:49AM -0400, Matthew Rosato wrote: > On 4/12/22 11:53 AM, Jason Gunthorpe wrote: > > When the open_device() op is called the container_users is incremented and > > held incremented until close_device(). Thus, so long as drivers call > > functions within their open_devic

Re: [PATCH 0/1] add support for enum module parameters

2022-04-14 Thread Jani Nikula
On Thu, 14 Apr 2022, Greg Kroah-Hartman wrote: > On Thu, Apr 14, 2022 at 03:30:32PM +0300, Jani Nikula wrote: >> Hey, I've sent this before, ages ago, but haven't really followed >> through with it. I still think it would be useful for many scenarios >> where a plain number is a clumsy interface f

Re: refactor the i915 GVT support and move to the modern mdev API v3

2022-04-14 Thread Wang, Zhi A
On 4/14/22 1:43 PM, Jason Gunthorpe wrote: > On Thu, Apr 14, 2022 at 04:40:11PM +0300, Jani Nikula wrote: > >> git clone https://github.com/intel/gvt-linux -b for-christoph > > There are alot of extra commits on there - is it possible to base this > straight on rc1 not on some kind

Re: [PATCH 0/1] add support for enum module parameters

2022-04-14 Thread Greg Kroah-Hartman
On Thu, Apr 14, 2022 at 05:22:47PM +0300, Jani Nikula wrote: > On Thu, 14 Apr 2022, Greg Kroah-Hartman wrote: > > On Thu, Apr 14, 2022 at 03:30:32PM +0300, Jani Nikula wrote: > >> Hey, I've sent this before, ages ago, but haven't really followed > >> through with it. I still think it would be usef

Re: refactor the i915 GVT support and move to the modern mdev API v3

2022-04-14 Thread Jason Gunthorpe
On Thu, Apr 14, 2022 at 02:25:36PM +, Wang, Zhi A wrote: > > So drop the '[DONT PULL]' commit and send a PR to the next DRM tree - > > when that is confirmed send the same PR to vfio, > > I updated the branch again, but I am confused. What is the purpose of sending > the PR to next DRM tree?

Re: [PATCH v3 5/5] drm/i915: stolen memory use ttm backend

2022-04-14 Thread Thomas Hellström
Hi, On 4/12/22 21:38, Robert Beckett wrote: +struct ttm_resource * +i915_gem_stolen_reserve_range(struct drm_i915_private *i915, + resource_size_t size, + u64 start, u64 end) { - int ret; + struct intel_memory_region *mem = i

[PATCH 01/19] drm/edid: reset display info in drm_add_edid_modes() for NULL edid

2022-04-14 Thread Jani Nikula
If a NULL edid gets passed to drm_add_edid_modes(), we should probably also reset the display info. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 324ce

[PATCH 00/19] drm/edid: CEA data block iterators, and more

2022-04-14 Thread Jani Nikula
Get back to the CEA data block iterator stuff now that a bunch of prep work has landed. My git repo at [1], branch edid-hfeeodb-2022-04-14, contains where this is all headed after this. [1] https://cgit.freedesktop.org/~jani/drm/log/?h=edid-hfeeodb-2022-04-14 Jani Nikula (18): drm/edid: reset

[PATCH 02/19] drm/edid: check for HF-SCDB block

2022-04-14 Thread Jani Nikula
From: Lee Shawn C Find HF-SCDB information in CEA extensions block. And retrieve Max_TMDS_Character_Rate that support by sink device. v2: HF-SCDB and HF-VSDBS carry the same SCDS data. Reuse drm_parse_hdmi_forum_vsdb() to parse this packet. Cc: Jani Nikula Cc: Ville Syrjala Cc: Ankit Naut

[PATCH 03/19] drm/edid: clean up CTA data block tag definitions

2022-04-14 Thread Jani Nikula
Add prefixed names, group, sort, add references. v2: - Updated references to CTA-861-H - s/CEA/CTA/ in data block macros Cc: Ville Syrjälä Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 65 -- 1 file changed, 35 inser

[PATCH 05/19] drm/edid: add iterator for CTA data blocks

2022-04-14 Thread Jani Nikula
Add an iterator for CTA Data Blocks across EDID CTA Extensions and DisplayID CTA Data Blocks. v2: Update references, note why we can trust displayid ranges (Ville) Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 202 ++--- 1 file ch

[PATCH 06/19] drm/edid: clean up cea_db_is_*() functions

2022-04-14 Thread Jani Nikula
Abstract helpers for matching vendor data blocks and extended tags, and use them to simplify all the cea_db_is_*() functions. Take void pointer as parameter to allow transitional use for both u8 * and struct cea_db *. v2: Remove superfluous parens (Ville) Cc: Ville Syrjälä Signed-off-by: Jani N

[PATCH 04/19] drm/edid: add iterator for EDID base and extension blocks

2022-04-14 Thread Jani Nikula
Add an iterator abstraction for going through all the EDID blocks. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 48 ++ 1 file changed, 48 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c inde

[PATCH 08/19] drm/edid: convert drm_edid_to_speaker_allocation() to use cea db iter

2022-04-14 Thread Jani Nikula
Use the cea db iterator for speaker allocation. We'll still stop at the first speaker data block, but not at the first CTA extension if that doesn't have the info. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 47 -- 1 file cha

[PATCH 07/19] drm/edid: convert add_cea_modes() to use cea db iter

2022-04-14 Thread Jani Nikula
Iterate through all CTA EDID extension blocks and DisplayID CTA data blocks to add CEA modes. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 67 ++ 1 file changed, 31 insertions(+), 36 deletions(-) diff --git a/drivers/gpu/drm/

[PATCH 10/19] drm/edid: convert drm_detect_hdmi_monitor() to use cea db iter

2022-04-14 Thread Jani Nikula
Iterate through all CTA data blocks, not just the first CTA extension. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edi

[PATCH 11/19] drm/edid: convert drm_detect_monitor_audio() to use cea db iter

2022-04-14 Thread Jani Nikula
Iterate through all CEA data blocks. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index b1fac281fd85..e47bbcd103e6

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Use i915_probe_error instead of drm_err

2022-04-14 Thread Belgaumkar, Vinay
On 4/13/2022 11:41 PM, Anshuman Gupta wrote: On 2022-04-13 at 04:18:52 +0530, Vinay Belgaumkar wrote: This will ensure we don't have false positives when we run error injection tests. Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 42 ++---

[PATCH 13/19] drm/edid: convert drm_edid_to_eld() to use cea db iter

2022-04-14 Thread Jani Nikula
Iterate through all CTA data blocks across all CTA extensions and DisplayID data blocks. This may gather more data than before, and if there's duplicated data, some is overwritten by whichever comes last. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 64 +

[PATCH 09/19] drm/edid: convert drm_edid_to_sad() to use cea db iter

2022-04-14 Thread Jani Nikula
Use the cea db iterator for short audio descriptors. We'll still stop at the first audio data block, but not at the first CTA Extension if that doesn't have the info. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 34 +- 1 file chan

[PATCH 14/19] drm/edid: sunset the old unused cea data block iterators

2022-04-14 Thread Jani Nikula
All CTA data block iteration has now been converted to the new cea db iterators. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 45 -- 1 file changed, 45 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/dr

[PATCH 15/19] drm/edid: restore some type safety to cea_db_*() functions

2022-04-14 Thread Jani Nikula
During the transition, we accepted a void pointer for a poor C programmer's version of polymorphism. Switch the functions to use struct cea_db * to regain some more type safety. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 21 + 1 file change

[PATCH 12/19] drm/edid: convert drm_parse_cea_ext() to use cea db iter

2022-04-14 Thread Jani Nikula
Iterate through all CTA data blocks across all CTA Extensions and DisplayID data blocks. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drive

[PATCH 16/19] drm/edid: detect basic audio in all CEA extensions

2022-04-14 Thread Jani Nikula
Convert drm_find_cea_extension() to EDID block iterator in basic audio detection. Detect basic audio in all CEA extensions. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/g

[PATCH 17/19] drm/edid: detect color formats and CTA revision in all CTA extensions

2022-04-14 Thread Jani Nikula
Convert drm_find_cea_extension() to EDID block iterator in color format and CTA revision detection. Detect them in all CTA extensions. Also parse CTA Data Blocks in DisplayID even if there's no CTA EDID extension. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 24

[PATCH 18/19] drm/edid: skip CTA extension scan in drm_edid_to_eld() just for CTA rev

2022-04-14 Thread Jani Nikula
The DisplayID CTA data block version does not necessarily match the CTA revision. Simplify by postponing drm_edid_to_eld() slightly, and reusing the CTA revision extracted by drm_parse_cea_ext(). By not bailing out early in drm_edid_to_eld() we may end up filling meaningless data to the ELD. Howev

[PATCH 19/19] drm/edid: sunset drm_find_cea_extension()

2022-04-14 Thread Jani Nikula
Convert drm_find_cea_extension() to a predicate function to check if the EDID has a CTA extension or a DisplayID CTA data block. This is mainly to avoid adding new users that only find the first CTA extension. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 19

Re: [PATCH] drm/radeon: Add build directory to include path

2022-04-14 Thread Masahiro Yamada
Hi. On Thu, Apr 14, 2022 at 10:50 PM Michel Dänzer wrote: > > On 2022-04-14 15:34, Alex Deucher wrote: > > On Thu, Apr 14, 2022 at 4:44 AM Christian König > > wrote: > >> Am 14.04.22 um 09:37 schrieb Michel Dänzer: > >>> On 2022-04-14 08:24, Christian König wrote: > Am 13.04.22 um 18:14 sch

Re: [PATCH v18 07/10] drm/mediatek: add mediatek-drm of vdosys0 support for mt8195

2022-04-14 Thread kernel test robot
Hi "jason-jh.lin", Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on robh/for-next krzk/for-next linus/master v5.18-rc2 next-20220414] [If your patch is applied to the wrong git tree, kindly drop us a note

Re: [PATCH v5 03/10] drm/hdcp: Update property value on content type and user changes

2022-04-14 Thread Sean Paul
On Tue, Apr 12, 2022 at 09:25:59AM -0400, Rodrigo Vivi wrote: > On Mon, Apr 11, 2022 at 08:47:32PM +, Sean Paul wrote: > > From: Sean Paul > > > > This patch updates the connector's property value in 2 cases which were > > previously missed: > > > > 1- Content type changes. The value should

Re: [PATCH v5 00/10] drm/hdcp: Pull HDCP auth/exchange/check into helpers

2022-04-14 Thread Sean Paul
On Tue, Apr 12, 2022 at 09:41:35AM -0400, Rodrigo Vivi wrote: > On Mon, Apr 11, 2022 at 08:47:29PM +, Sean Paul wrote: > > From: Sean Paul > > > > Rebased set from November. Fixed a nit from Stephen in the msm patch and > > moved hdcp registers into the trogdor dtsi file to avoid differences

Re: [PATCH v2 4/5] drm/i915: ttm backend dont provide mmap_offset for kernel buffers

2022-04-14 Thread Robert Beckett
On 14/04/2022 15:05, Thomas Hellström wrote: On Tue, 2022-04-12 at 15:18 +, Robert Beckett wrote: stolen/kernel buffers should not be mmapable by userland. do not provide callbacks to facilitate this for these buffers. Signed-off-by: Robert Beckett ---  drivers/gpu/drm/i915/gem/i915_ge

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Use i915_probe_error instead of drm_err

2022-04-14 Thread Jani Nikula
On Thu, 14 Apr 2022, "Belgaumkar, Vinay" wrote: > On 4/13/2022 11:41 PM, Anshuman Gupta wrote: >> On 2022-04-13 at 04:18:52 +0530, Vinay Belgaumkar wrote: >>> This will ensure we don't have false positives when we run >>> error injection tests. >>> >>> Signed-off-by: Vinay Belgaumkar >>> --- >>>

RE: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Use i915_probe_error instead of drm_err

2022-04-14 Thread Gupta, Anshuman
> -Original Message- > From: Belgaumkar, Vinay > Sent: Thursday, April 14, 2022 8:38 PM > To: Gupta, Anshuman > Cc: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Use i915_probe_error > instead of drm_err > > > On

Re: [PATCH v2] drm/msm/dp: enhance both connect and disconnect pending_timeout handle

2022-04-14 Thread Kuogee Hsieh
On 4/13/2022 5:02 PM, Stephen Boyd wrote: The subject is still misleading. It is fixing something. It may be enhancing it as well but it is clearly fixing it first. Quoting Kuogee Hsieh (2022-04-06 14:28:13) dp_hpd_plug_handle() is responsible for setting up main link and send uevent to notif

Re: [PATCH v7 1/4] drm/msm/dp: Add eDP support via aux_bus

2022-04-14 Thread Doug Anderson
Hi, On Thu, Apr 14, 2022 at 5:20 AM Sankeerth Billakanti wrote: > > @@ -1530,6 +1532,60 @@ void msm_dp_debugfs_init(struct msm_dp *dp_display, > struct drm_minor *minor) > } > } > > +static int dp_display_get_next_bridge(struct msm_dp *dp) > +{ > + int rc; > + struct dp_disp

Re: [PATCH v7 2/4] drm/msm/dp: Support only IRQ_HPD and REPLUG interrupts for eDP

2022-04-14 Thread Doug Anderson
Hi, On Thu, Apr 14, 2022 at 5:20 AM Sankeerth Billakanti wrote: > > The panel-edp enables the eDP panel power during probe, get_modes > and enable. Technically the panel-edp powers on the panel in pre_enable() > The eDP connect and disconnect interrupts for the eDP/DP > controller are directly

Re: [PATCH v7 3/4] drm/msm/dp: wait for hpd high before aux transaction

2022-04-14 Thread Doug Anderson
Hi, On Thu, Apr 14, 2022 at 5:20 AM Sankeerth Billakanti wrote: > > The source device should ensure the sink is ready before proceeding to > read the sink capability or perform any aux transactions. The sink > will indicate its readiness by asserting the HPD line. The controller > driver needs to

Re: [PATCH v7 4/4] Support the eDP modes given by panel

2022-04-14 Thread Doug Anderson
Hi, On Thu, Apr 14, 2022 at 5:20 AM Sankeerth Billakanti wrote: > > The eDP controller does not have a reliable way keep panel > powered on to read the sink capabilities. So, the controller > driver cannot validate if a mode can be supported by the > source. We will rely on the panel driver to po

Re: [PATCH v7 0/4] Add support for the eDP panel over aux_bus

2022-04-14 Thread Doug Anderson
Hi, On Thu, Apr 14, 2022 at 5:19 AM Sankeerth Billakanti wrote: > > This series adds support for generic eDP panel over aux_bus. > > These changes are dependent on the following series: > https://patchwork.kernel.org/project/linux-arm-msm/list/?series=613654&state=* You're basically depending on

Re: [PATCH v2] drm/msm/dp: stop event kernel thread when DP unbind

2022-04-14 Thread Kuogee Hsieh
On 4/13/2022 4:19 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-04-13 14:04:25) Current DP driver implementation, event thread is kept running after DP display is unbind. This patch fix this problem by disabling DP irq and stop event thread to exit gracefully at dp_display_unbind(). Chan

Re: [PATCH v3 5/5] drm/i915: stolen memory use ttm backend

2022-04-14 Thread Robert Beckett
On 14/04/2022 15:41, Thomas Hellström wrote: Hi, On 4/12/22 21:38, Robert Beckett wrote: +struct ttm_resource * +i915_gem_stolen_reserve_range(struct drm_i915_private *i915, +  resource_size_t size, +  u64 start, u64 end)   { -    int ret; +    struct intel_m

[PATCH v3] drm/msm/dp: stop event kernel thread when DP unbind

2022-04-14 Thread Kuogee Hsieh
Current DP driver implementation, event thread is kept running after DP display is unbind. This patch fix this problem by disabling DP irq and stop event thread to exit gracefully at dp_display_unbind(). Changes in v2: -- start event thread at dp_display_bind() Changes in v3: -- disable all HDP i

[PATCH v2 1/1] i915/gem: drop wbinvd_on_all_cpus usage

2022-04-14 Thread Michael Cheng
Previous concern with using drm_clflush_sg was that we don't know what the sg_table is pointing to, thus the usage of wbinvd_on_all_cpus to flush everything at once to avoid paranoia. To make i915 more architecture-neutral and be less paranoid, lets attempt to use drm_clflush_sg to flush the pages

  1   2   >