Re: [PATCH] dma-buf-map: remove renamed header file

2022-04-12 Thread Thomas Zimmermann
Am 11.04.22 um 15:44 schrieb Karol Herbst: commit 7938f4218168 ("dma-buf-map: Rename to iosys-map") already renamed this file, but it got brought back by a merge. Delete it for real this time. Fixes: 30424ebae8df ("Merge tag 'drm-intel-gt-next-2022-02-17' of git://anongit.freedesktop.org/drm

Re: [PATCH v2 2/5] dt-bindings: display: ssd1307fb: Extend schema for SPI controllers

2022-04-12 Thread Rob Herring
On Tue, Apr 12, 2022 at 10:12:32AM +0200, Javier Martinez Canillas wrote: > On 4/12/22 10:07, Geert Uytterhoeven wrote: > > Hi Javier, > > [snip] > > >> > >> Do you have any hints here on how I should enforce this in the schema ? > >> > >> Or if you think that a comment is enough, then I will add

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-04-12 Thread Dmitry Osipenko
On 4/12/22 19:51, Andrey Grodzovsky wrote: > > On 2022-04-11 18:15, Dmitry Osipenko wrote: >> Interrupt context can't sleep. Drivers like Panfrost and MSM are taking >> mutex when job is released, and thus, that code can sleep. This results >> into "BUG: scheduling while atomic" if locks are conte

[linux-next:master] BUILD REGRESSION d0c745e7b2d6ce8bcc768b32361ab8ef520821ee

2022-04-12 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: d0c745e7b2d6ce8bcc768b32361ab8ef520821ee Add linux-next specific files for 20220412 Error/Warning reports: https://lore.kernel.org/linux-mm/202203160358.yulpl6b4-...@intel.com https

[PATCH v3 1/5] drm/i915: instantiate ttm ranger manager for stolen memory

2022-04-12 Thread Robert Beckett
prepare for ttm based stolen region by using ttm range manager as the resource manager for stolen region. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 6 ++-- drivers/gpu/drm/i915/intel_region_ttm.c | 31 +++- 2 files changed, 27 insertio

[PATCH v3 0/5] drm/i915: ttm for stolen region

2022-04-12 Thread Robert Beckett
This series refactors i915's stolen memory region to use ttm. v2: handle disabled stolen similar to legacy version. relying on ttm to fail allocs works fine, but is dmesg noisy and causes testing dmesg warning regressions. v3: rebase to latest drm-tip. fix v2 code

[PATCH v3 4/5] drm/i915: ttm backend dont provide mmap_offset for kernel buffers

2022-04-12 Thread Robert Beckett
stolen/kernel buffers should not be mmapable by userland. do not provide callbacks to facilitate this for these buffers. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 32 + 1 file changed, 27 insertions(+), 5 deletions(-) diff --git a/driver

[PATCH v3 3/5] drm/i915: ttm move/clear logic fix

2022-04-12 Thread Robert Beckett
ttm managed buffers start off with system resource definitions and ttm_tt tracking structures allocated (though unpopulated). currently this prevents clearing of buffers on first move to desired placements. The desired behaviour is to clear user allocated buffers and any kernel buffers that specif

[PATCH v3 2/5] drm/i915: sanitize mem_flags for stolen buffers

2022-04-12 Thread Robert Beckett
stolen regions are not page backed or considered iomem. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm_mo

[PATCH v3 5/5] drm/i915: stolen memory use ttm backend

2022-04-12 Thread Robert Beckett
refactor stolen memory region to use ttm. this necessitates using ttm resources to track reserved stolen regions instead of drm_mm_nodes. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/display/intel_fbc.c | 78 ++-- .../gpu/drm/i915/gem/i915_gem_object_types.h | 2 - drivers/gpu

Re: [PATCH] drm/msm: add trace_dma_fence_emit to msm_gpu_submit

2022-04-12 Thread Rob Clark
On Sat, Apr 9, 2022 at 7:33 AM Christian König wrote: > > Am 08.04.22 um 23:12 schrieb Chia-I Wu: > > In practice, trace_dma_fence_init is good enough and almost no driver > > calls trace_dma_fence_emit. But this is still more correct in theory. > > Well, the reason why basically no driver is cal

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-04-12 Thread Andrey Grodzovsky
On 2022-04-12 14:20, Dmitry Osipenko wrote: On 4/12/22 19:51, Andrey Grodzovsky wrote: On 2022-04-11 18:15, Dmitry Osipenko wrote: Interrupt context can't sleep. Drivers like Panfrost and MSM are taking mutex when job is released, and thus, that code can sleep. This results into "BUG: schedul

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-04-12 Thread Dmitry Osipenko
On 4/12/22 22:40, Andrey Grodzovsky wrote: > > On 2022-04-12 14:20, Dmitry Osipenko wrote: >> On 4/12/22 19:51, Andrey Grodzovsky wrote: >>> On 2022-04-11 18:15, Dmitry Osipenko wrote: Interrupt context can't sleep. Drivers like Panfrost and MSM are taking mutex when job is released, and

Re: [PATCH] video: fbdev-MMP: replace usage of found with dedicated list iterator variable

2022-04-12 Thread Helge Deller
On 4/1/22 00:35, Jakob Koschel wrote: > To move the list iterator variable into the list_for_each_entry_*() > macro in the future it should be avoided to use the list iterator > variable after the loop body. > > To *never* use the list iterator variable after the loop it was > concluded to use a se

[PATCH v2 1/2] drm/sched: use DECLARE_EVENT_CLASS

2022-04-12 Thread Chia-I Wu
drm_sched_job and drm_run_job have the same prototype. v2: rename the class from drm_sched_job_entity to drm_sched_job (Andrey) Signed-off-by: Chia-I Wu Cc: Rob Clark Reviewed-by: Andrey Grodzovsky --- .../gpu/drm/scheduler/gpu_scheduler_trace.h | 31 +-- 1 file changed, 7 i

[PATCH v2 2/2] drm/sched: use __string in tracepoints

2022-04-12 Thread Chia-I Wu
Otherwise, ring names are marked [UNSAFE-MEMORY]. Signed-off-by: Chia-I Wu Cc: Rob Clark Reviewed-by: Andrey Grodzovsky --- drivers/gpu/drm/scheduler/gpu_scheduler_trace.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler_t

Re: [PATCH 30/34] vfio/mdev: Remove vfio_mdev.c

2022-04-12 Thread Kirti Wankhede
On 4/11/2022 7:43 PM, Christoph Hellwig wrote: From: Jason Gunthorpe Now that all mdev drivers directly create their own mdev_device driver and directly register with the vfio core's vfio_device_ops this is all dead code. Delete vfio_mdev.c and the mdev_parent_ops members that are connected

Re: [PATCH 31/34] vfio/mdev: Remove mdev_parent_ops dev_attr_groups

2022-04-12 Thread Kirti Wankhede
On 4/11/2022 7:44 PM, Christoph Hellwig wrote: From: Jason Gunthorpe This is only used by one sample to print a fixed string that is pointless. In general, having a device driver attach sysfs attributes to the parent is horrific. This should never happen, and always leads to some kind of li

Re: [PATCH 32/34] vfio/mdev: Remove mdev_parent_ops

2022-04-12 Thread Kirti Wankhede
On 4/11/2022 7:44 PM, Christoph Hellwig wrote: From: Jason Gunthorpe The last useful member in this struct is the supported_type_groups, move it to the mdev_driver and delete mdev_parent_ops. Replace it with mdev_driver as an argument to mdev_register_device() Signed-off-by: Jason Gunthorp

Re: [PATCH 33/34] vfio/mdev: Use the driver core to create the 'remove' file

2022-04-12 Thread Kirti Wankhede
On 4/11/2022 7:44 PM, Christoph Hellwig wrote: From: Jason Gunthorpe The device creator is supposed to use the dev.groups value to add sysfs files before device_add is called, not call sysfs_create_files() after device_add() returns. This creates a race with uevent delivery where the extra a

Re: [PATCH 34/34] vfio/mdev: Remove mdev drvdata

2022-04-12 Thread Kirti Wankhede
On 4/11/2022 7:44 PM, Christoph Hellwig wrote: From: Jason Gunthorpe This is no longer used, remove it. All usages were moved over to either use container_of() from a vfio_device or to use dev_drvdata() directly on the mdev. Signed-off-by: Jason Gunthorpe Signed-off-by: Christoph Hellwig

Re: [Bug 215807] Bad page state in process systemd-udevd

2022-04-12 Thread Andrew Morton
(switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface). hm, that's my third `bad page' report in three emails. But I'm not seeing a pattern - this one might be a DRM thing. On Tue, 12 Apr 2022 20:52:18 + bugzilla-dae...@kernel.org wrote: > https://

Re: [PATCH v2 02/14] dt-bindings: display: Add D1 display engine compatibles

2022-04-12 Thread Rob Herring
On Mon, Apr 11, 2022 at 11:27:54PM -0500, Samuel Holland wrote: > Allwinner D1 contains a display engine 2.0. It features two mixers, a > TCON TOP (with DSI and HDMI), one TCON LCD, and one TCON TV. > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Samuel Holland > --- > > (no changes since

Re: [Bug 215807] Bad page state in process systemd-udevd

2022-04-12 Thread Matthew Wilcox
On Tue, Apr 12, 2022 at 02:08:04PM -0700, Andrew Morton wrote: > hm, that's my third `bad page' report in three emails. But I'm not > seeing a pattern - this one might be a DRM thing. I noticed it was an order-9 page and was set to take responsibility for it, but it's clearly not a filesystem pag

[PATCH v2] drm/msm: add trace_dma_fence_emit to msm_gpu_submit

2022-04-12 Thread Chia-I Wu
In practice, trace_dma_fence_init called from dma_fence_init is good enough and almost no driver calls trace_dma_fence_emit. But drm_sched and virtio both have cases where trace_dma_fence_init and trace_dma_fence_emit can be apart. It is easier for visualization tools to always use the more corre

[PATCHv4] drm/amdgpu: disable ASPM on Intel Alder Lake based systems

2022-04-12 Thread Richard Gong
Active State Power Management (ASPM) feature is enabled since kernel 5.14. There are some AMD GFX cards (such as WX3200 and RX640) that won't work with ASPM-enabled Intel Alder Lake based systems. Using these GFX cards as video/display output, Intel Alder Lake based systems will hang during suspend

[PATCH] drm/i915/guc/slpc: Use i915_probe_error instead of drm_err

2022-04-12 Thread Vinay Belgaumkar
This will ensure we don't have false positives when we run error injection tests. Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 42 ++--- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-04-12 Thread Erico Nunes
On Tue, Apr 12, 2022 at 9:41 PM Andrey Grodzovsky wrote: > > > On 2022-04-12 14:20, Dmitry Osipenko wrote: > > On 4/12/22 19:51, Andrey Grodzovsky wrote: > >> On 2022-04-11 18:15, Dmitry Osipenko wrote: > >>> Interrupt context can't sleep. Drivers like Panfrost and MSM are taking > >>> mutex when

[PATCH 0/1] Update to GuC v70

2022-04-12 Thread John . C . Harrison
From: John Harrison Update to the latest GuC firmware release. Note that this includes some significant backwards breaking API changes. One is about context registration - the descriptor pool is gone, all parameters are passed via the CTB instead. The second is about scheduling policy updates -

[PATCH 1/1] drm/i915/guc: Update to GuC version 70.1.1

2022-04-12 Thread John . C . Harrison
From: John Harrison The latest GuC firmware drops the context descriptor pool in favour of passing all creation data in the create H2G. It also greatly simplifies the work queue and removes the process descriptor used for multi-LRC submission. So, remove all mention of LRC and process descriptors

Re: [PATCH 3/6] drm/sun4i: sun8i-hdmi-phy: Used device-managed clocks/resets

2022-04-12 Thread Samuel Holland
On 4/12/22 8:23 AM, Maxime Ripard wrote: > Hi, > > On Mon, Apr 11, 2022 at 11:35:08PM -0500, Samuel Holland wrote: >> Now that the HDMI PHY is using a platform driver, it can use device- >> managed resources. Use these, as well as the dev_err_probe helper, to >> simplify the probe function and get

Re: [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks

2022-04-12 Thread Abhinav Kumar
Hi Daniel On 4/8/2022 9:04 PM, Abhinav Kumar wrote: On 4/7/2022 4:12 PM, Rob Clark wrote: On Thu, Apr 7, 2022 at 3:59 PM Abhinav Kumar wrote: Hi Rob and Daniel On 4/7/2022 3:51 PM, Rob Clark wrote: On Wed, Apr 6, 2022 at 6:27 PM Jessica Zhang wrote: On 3/31/2022 8:20 AM, Daniel Vett

Re: linux-next: build warning after merge of the drm-misc tree

2022-04-12 Thread Stephen Rothwell
Hi all, On Wed, 6 Apr 2022 15:50:30 +1000 Stephen Rothwell wrote: > > After merging the drm-misc tree, today's linux-next build (htmldocs) > produced this warning: > > include/drm/ttm/ttm_resource.h:226: warning: Function parameter or member > 'pos' not described in 'ttm_lru_bulk_move' > > In

Re: linux-next: build warnings after merge of the drm-misc tree

2022-04-12 Thread Stephen Rothwell
Hi all, On Wed, 6 Apr 2022 15:44:31 +1000 Stephen Rothwell wrote: > > After merging the drm-misc tree, today's linux-next build (KCONFIG_NAME) htmldocs > produced these warnings: > > drivers/gpu/drm/drm_edid.c:1589: warn

Re: linux-next: manual merge of the amdgpu tree with the drm-misc tree

2022-04-12 Thread Stephen Rothwell
Hi all, On Wed, 6 Apr 2022 10:34:05 +1000 Stephen Rothwell wrote: > > Today's linux-next merge of the amdgpu tree got a conflict in: > > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c > > between commit: > > fee2ede15542 ("drm/ttm: rework bulk move handling v5") > > from the drm-misc tree and co

Re: [PATCH] drm: bridge: icn6211: Convert to regmap

2022-04-12 Thread Marek Vasut
On 4/7/22 13:38, Mark Brown wrote: On Sun, Apr 03, 2022 at 07:10:04PM +0200, Marek Vasut wrote: To make debugging easier, convert driver to regmap. Implement read and write regmap tables for known registers, keep all known register readable and mark those which are obviously read-only as not wri

Re: [PATCH v2 1/2] drm/panel: lvds: Simplify mode parsing

2022-04-12 Thread Marek Vasut
On 4/7/22 13:16, Laurent Pinchart wrote: Hi Marek, Thank you for the patch. On Fri, Apr 01, 2022 at 06:21:53PM +0200, Marek Vasut wrote: The mode parsing is currently implemented in three steps: of_get_display_timing() - DT panel-timing to struct display_timing videomode_from_timing() - struct

Re: [PATCHv4] drm/amdgpu: disable ASPM on Intel Alder Lake based systems

2022-04-12 Thread Lazar, Lijo
On 4/13/2022 3:20 AM, Richard Gong wrote: Active State Power Management (ASPM) feature is enabled since kernel 5.14. There are some AMD GFX cards (such as WX3200 and RX640) that won't work with ASPM-enabled Intel Alder Lake based systems. Using these GFX cards as video/display output, Intel Al

[PATCH v3] drm/gma500: fix a potential repeat execution in psb_driver_load

2022-04-12 Thread Xiaomeng Tong
Instead of exiting the loop as expected when an entry is found, the list_for_each_entry() continues until the traversal is complete. To avoid potential executing 'ret = gma_backlight_init(dev);' repeatly, goto outside the loop when found entry by replacing switch/case with if statement. Signed-off

Re: [PATCH v2] drm/gma500: fix a potential repeat execution in psb_driver_load

2022-04-12 Thread Xiaomeng Tong
On Tue, 12 Apr 2022 16:58:24 +0200, Patrik Jakobsson wrote: > Hi, > This would work but using gotos like this easily turns the code into > spaghetti. See "7. Centralized exiting of functions" in > Documentation/process/coding-style.rst for when to use gotos. > > In this particular case I think we

Re: [PATCH] drm/tidss: Soft Reset DISPC on startup

2022-04-12 Thread Tony Lindgren
* Nishanth Menon [220412 21:18]: > On 17:24-20220412, Tomi Valkeinen wrote: > > Hi, > > > > On 14/03/2022 13:37, Devarsh Thakkar wrote: > > > Soft reset the display subsystem controller on startup and wait for > > > the reset to complete. This helps the s

[PULL] drm-intel-fixes

2022-04-12 Thread Joonas Lahtinen
Hi Dave & Daniel, Just one fix towards v5.18-rc3. Fix to align code with drm-tip to make sure full graphics IP version is used for legacy mmap disable check. Regards, Joonas *** drm-intel-fixes-2022-04-13: - Correct legacy mmap disabling to use GRAPHICS_VER_FULL The following changes since c

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-04-12 Thread Dmitry Osipenko
On 4/13/22 01:59, Erico Nunes wrote: > On Tue, Apr 12, 2022 at 9:41 PM Andrey Grodzovsky > wrote: >> >> >> On 2022-04-12 14:20, Dmitry Osipenko wrote: >>> On 4/12/22 19:51, Andrey Grodzovsky wrote: On 2022-04-11 18:15, Dmitry Osipenko wrote: > Interrupt context can't sleep. Drivers like P

Re: [PATCH v18 03/10] soc: mediatek: add mtk-mmsys support for mt8195 vdosys0

2022-04-12 Thread Dan Carpenter
Hi "jason-jh.lin", url: https://github.com/intel-lab-lkp/linux/commits/jason-jh-lin/Add-Mediatek-Soc-DRM-vdosys0-support-for-mt8195/20220412-183359 base: git://anongit.freedesktop.org/drm/drm drm-next config: arc-randconfig-m031-20220411 (https://download.01.org/0day-ci/archiv

Re: [PATCH v6 resend 2/5] phy: Add LVDS configuration options

2022-04-12 Thread Vinod Koul
On 02-04-22, 13:24, Liu Ying wrote: > This patch allows LVDS PHYs to be configured through > the generic functions and through a custom structure > added to the generic union. > > The parameters added here are based on common LVDS PHY > implementation practices. The set of parameters > should cov

Re: [PATCH v6 resend 5/5] phy: freescale: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support

2022-04-12 Thread Vinod Koul
On 02-04-22, 13:24, Liu Ying wrote: > i.MX8qxp SoC embeds a Mixel MIPI DPHY + LVDS PHY combo which supports > either a MIPI DSI display or a LVDS display. The PHY mode is controlled > by SCU firmware and the driver would call a SCU firmware function to > configure the PHY mode. The single LVDS PH

<    1   2