[PATCH] tests/drm_buddy: Add drm buddy test cases

2022-04-11 Thread Arunpravin Paneer Selvam
Add a set of drm buddy test cases to validate the drm/drm_buddy.c memory allocator. Signed-off-by: Arunpravin Paneer Selvam --- tests/drm_buddy.c | 14 ++ tests/meson.build | 1 + 2 files changed, 15 insertions(+) create mode 100644 tests/drm_buddy.c diff --git a/tests/drm_buddy.c

Re: vc4: Couldn't stop firmware display driver during boot

2022-04-11 Thread Maxime Ripard
Hi Stefan, On Sun, Apr 10, 2022 at 02:32:02AM +0200, Stefan Wahren wrote: > Am 09.04.22 um 21:25 schrieb Stefan Wahren: > > Hi, > > > > today i tested Linux 5.18-rc1 on my Raspberry Pi 400 connected to my > > HDMI display (multi_v7_defconfig + CONFIG_ARM_LPAE, firmware: > > 2021-01-08T14:31:16) a

Re: [PATCHv2] drm/amdgpu: disable ASPM on Intel AlderLake based systems

2022-04-11 Thread Paul Menzel
Dear Richard, Thank you for your response, but please reply to your own reply next time. Am 11.04.22 um 02:37 schrieb Gong, Richard: On 4/8/2022 7:19 PM, Paul Menzel wrote: Thank you for your patch. Am 08.04.22 um 21:05 schrieb Richard Gong: Active State Power Management (ASPM) feature is

[PATCH v3] drm: add a check to verify the size alignment

2022-04-11 Thread Arunpravin Paneer Selvam
Add a simple check to reject any size not aligned to the min_page_size. when size is not aligned to min_page_size, driver module should handle in their own way either to round_up() the size value to min_page_size or just to enable WARN_ON(). If we dont handle the alignment properly, we may hit th

Re: [PATCHv2] drm/amdgpu: disable ASPM on Intel AlderLake based systems

2022-04-11 Thread Paul Menzel
[Cc: +] Dear Richard, Am 11.04.22 um 02:27 schrieb Gong, Richard: On 4/8/2022 7:19 PM, Paul Menzel wrote: Am 08.04.22 um 21:05 schrieb Richard Gong: Active State Power Management (ASPM) feature is enabled since kernel 5.14. There are some AMD GFX cards (such as WX3200 and RX640) that cann

Re: [PATCH v2 1/5] drm: bridge: dw_hdmi: cec: Add cec suspend/resume function

2022-04-11 Thread Neil Armstrong
On 10/04/2022 12:13, Jernej Škrabec wrote: Dne petek, 08. april 2022 ob 15:41:36 CEST je Neil Armstrong napisal(a): On 08/04/2022 12:32, Sandor Yu wrote: CEC interrupt status/mask and logical address registers will be reset when device enter suspend. It will cause cec fail to work after device

Re: [Intel-gfx] [PATCH 4/4] drm/i915/selftest: Always cancel semaphore on error

2022-04-11 Thread Mae Chavez

Re: [PATCH v10 12/24] drm/rockchip: dw_hdmi: drop mode_valid hook

2022-04-11 Thread Sascha Hauer
On Sun, Apr 10, 2022 at 01:31:23PM +0200, Alex Bee wrote: > Am 08.04.22 um 13:22 schrieb Sascha Hauer: > > The driver checks if the pixel clock of the given mode matches an entry > > in the mpll config table. The frequencies in the mpll table are meant as > > a frequency range up to which the entry

Re: [PATCH v3] drm/hyperv: Added error message for fb size greater than allocated

2022-04-11 Thread Saurabh Singh Sengar
On Mon, Apr 11, 2022 at 06:40:38AM +, Dexuan Cui wrote: > > Subject: [PATCH v3] drm/hyperv: Added error message for fb size greater than > > allocated > > > > Added error message when the size of requested framebuffer is more than > > the allocated size by vmbus mmio region for framebuffer >

Patch "fbdev: Fix unregistering of framebuffers without device" has been added to the 5.15-stable tree

2022-04-11 Thread gregkh
This is a note to let you know that I've just added the patch titled fbdev: Fix unregistering of framebuffers without device to the 5.15-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "fbdev: Fix unregistering of framebuffers without device" has been added to the 5.16-stable tree

2022-04-11 Thread gregkh
This is a note to let you know that I've just added the patch titled fbdev: Fix unregistering of framebuffers without device to the 5.16-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "fbdev: Fix unregistering of framebuffers without device" has been added to the 5.17-stable tree

2022-04-11 Thread gregkh
This is a note to let you know that I've just added the patch titled fbdev: Fix unregistering of framebuffers without device to the 5.17-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Re: [RFC PATCH 1/6] drm/dp: Helpers to make it easier for drivers to use DP AUX bus properly

2022-04-11 Thread Jani Nikula
On Fri, 08 Apr 2022, Douglas Anderson wrote: > As talked about in the kerneldoc for "struct dp_aux_ep_client" in this > patch and also in the past in commit a1e3667a9835 ("drm/bridge: > ti-sn65dsi86: Promote the AUX channel to its own sub-dev"), to use the > DP AUX bus properly we really need two

Re: [PATCH] drm: mxsfb: Implement LCDIF scanout CRC32 support

2022-04-11 Thread Dan Carpenter
Hi Marek, url: https://github.com/intel-lab-lkp/linux/commits/Marek-Vasut/drm-mxsfb-Implement-LCDIF-scanout-CRC32-support/20220410-071222 base: git://anongit.freedesktop.org/drm/drm drm-next config: i386-randconfig-m021-20220411 (https://download.01.org/0day-ci/archive/20220411

5.18 vmwgfx seems to break booting VirtualBox VMs

2022-04-11 Thread Hans de Goede
Hi All, Fedora has received a bug report here: https://bugzilla.redhat.com/show_bug.cgi?id=2072556 That Fedora rawhide VMs no longer boot under the VirtualBox hypervisor after the VM has been updated to a 5.18-rc# kernel. Switching the emulated GPU from vmwaregfx to VirtualBoxSVGA fixes this, s

[PATCH] drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup

2022-04-11 Thread Matthew Auld
If we hit the sync case, like when skipping clearing for kernel internal objects, or when falling back to cpu clearing, like in i915, we end up trying to add a NULL fence, but with some recent changes in this area this now just results in NULL deref in dma_resv_add_fence: <1>[5.466383] BUG: ke

Re: [PATCH v4, 1/4] drm/mediatek: Adjust the timing of mipi signal from LP00 to LP11

2022-04-11 Thread AngeloGioacchino Del Regno
Il 11/04/22 04:31, xinlei@mediatek.com ha scritto: From: Jitao Shi Old sequence: 1. Pull the MIPI signal high 2. Delay & Dsi_reset 3. Set the dsi timing register 4. dsi clk & lanes leave ulp mode and enter hs mode The sequence after patching is: 1. Set the dsi timing register 2. Pull the M

Re: [PATCH v4, 2/4] drm/mediatek: Separate poweron/poweroff from enable/disable and define new funcs

2022-04-11 Thread AngeloGioacchino Del Regno
Il 11/04/22 04:31, xinlei@mediatek.com ha scritto: From: Jitao Shi In order to match the changes of "Use the drm_panel_bridge API", the poweron/poweroff of dsi is extracted from enable/disable and defined as new funcs (pre_enable/post_disable). Fixes: 2dd8075d2185 ("drm/mediatek: mtk_dsi:

Re: [PATCH v4, 3/4] drm/mediatek: keep dsi as LP00 before dcs cmds transfer

2022-04-11 Thread AngeloGioacchino Del Regno
Il 11/04/22 04:31, xinlei@mediatek.com ha scritto: From: Jitao Shi To comply with the panel sequence, hold the mipi signal to LP00 before the dcs cmds transmission, and pull the mipi signal high from LP00 to LP11 until the start of the dcs cmds transmission. The normal panel timing is : (

Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support

2022-04-11 Thread Sascha Hauer
On Fri, Apr 08, 2022 at 05:54:24PM +0200, Piotr Oniszczuk wrote: > > > > Wiadomość napisana przez Sascha Hauer w dniu > > 08.04.2022, o godz. 14:00: > > > >> That turned out to be simpler than I thought it would be. The zpos > >> values were never actually written to the hardware. Please try t

Patch "drm/amdkfd: Create file descriptor after client is added to smi_clients list" has been added to the 5.10-stable tree

2022-04-11 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/amdkfd: Create file descriptor after client is added to smi_clients list to the 5.10-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename

Patch "drm/nouveau/pmu: Add missing callbacks for Tegra devices" has been added to the 5.10-stable tree

2022-04-11 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/nouveau/pmu: Add missing callbacks for Tegra devices to the 5.10-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "drm/nouveau/pmu: Add missing callbacks for Tegra devices" has been added to the 5.15-stable tree

2022-04-11 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/nouveau/pmu: Add missing callbacks for Tegra devices to the 5.15-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "drm/amdkfd: Create file descriptor after client is added to smi_clients list" has been added to the 5.15-stable tree

2022-04-11 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/amdkfd: Create file descriptor after client is added to smi_clients list to the 5.15-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename

Patch "drm/amdkfd: Create file descriptor after client is added to smi_clients list" has been added to the 5.16-stable tree

2022-04-11 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/amdkfd: Create file descriptor after client is added to smi_clients list to the 5.16-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename

Patch "drm/nouveau/pmu: Add missing callbacks for Tegra devices" has been added to the 5.16-stable tree

2022-04-11 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/nouveau/pmu: Add missing callbacks for Tegra devices to the 5.16-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "drm/amdkfd: Create file descriptor after client is added to smi_clients list" has been added to the 5.17-stable tree

2022-04-11 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/amdkfd: Create file descriptor after client is added to smi_clients list to the 5.17-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename

Patch "drm/nouveau/pmu: Add missing callbacks for Tegra devices" has been added to the 5.17-stable tree

2022-04-11 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/nouveau/pmu: Add missing callbacks for Tegra devices to the 5.17-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Re: [PATCH v3] drm/gma500: depend on framebuffer

2022-04-11 Thread Patrik Jakobsson
On Sun, Apr 10, 2022 at 10:05 PM James Hilliard wrote: > > On Sun, Apr 10, 2022 at 1:52 PM Patrik Jakobsson > wrote: > > > > On Sun, Apr 10, 2022 at 9:40 PM James Hilliard > > wrote: > > > > > > On Sun, Apr 10, 2022 at 1:36 PM Patrik Jakobsson > > > wrote: > > > > > > > > On Sat, Apr 9, 2022 at

Re: [PATCH] tests/drm_buddy: Add drm buddy test cases

2022-04-11 Thread Matthew Auld
On 11/04/2022 08:28, Arunpravin Paneer Selvam wrote: Add a set of drm buddy test cases to validate the drm/drm_buddy.c memory allocator. Signed-off-by: Arunpravin Paneer Selvam --- tests/drm_buddy.c | 14 ++ tests/meson.build | 1 + 2 files changed, 15 insertions(+) create mo

Re: [PATCH v2 4/7] drm: mxsfb: Move mxsfb_get_fb_paddr() away from register IO functions

2022-04-11 Thread Lucas Stach
Am Montag, dem 11.04.2022 um 00:17 +0200 schrieb Marek Vasut: > On 4/7/22 11:47, Lucas Stach wrote: > > Am Donnerstag, dem 07.04.2022 um 00:05 +0200 schrieb Marek Vasut: > > > On 4/6/22 21:45, Lucas Stach wrote: > > > > Am Freitag, dem 11.03.2022 um 18:05 +0100 schrieb Marek Vasut: > > > > > Move m

[CI v2 00/12] drm/edid: low level EDID block read refactoring etc.

2022-04-11 Thread Jani Nikula
Submitting [1] again for CI. Just a slight change in patch 3 to address review. BR, Jani. [1] https://patchwork.freedesktop.org/series/102329/ Jani Nikula (12): drm/edid: convert edid_is_zero() to edid_block_is_zero() for blocks drm/edid: have edid_block_check() detect blocks that are all z

[CI v2 01/12] drm/edid: convert edid_is_zero() to edid_block_is_zero() for blocks

2022-04-11 Thread Jani Nikula
As edid_is_zero() is only ever used on EDID blocks, convert it to edid_block_is_zero() with implicit block size. Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/dr

[CI v2 02/12] drm/edid: have edid_block_check() detect blocks that are all zero

2022-04-11 Thread Jani Nikula
We have the check function, have it also detect blocks that are all zero instead of leaving that to callers. Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/

[CI v2 03/12] drm/edid: refactor EDID block status printing

2022-04-11 Thread Jani Nikula
Split out a function to log EDID block status. The printouts get changed slightly. Unfortunately, not all users will have struct drm_device available, so we convert to pr_* debug logging instead of drm device based logging. v2: Complain more loudly about unknown status codes (Ville) Signed-off-b

Re: [PATCH v3] drm: add a check to verify the size alignment

2022-04-11 Thread Matthew Auld
On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote: Add a simple check to reject any size not aligned to the min_page_size. when size is not aligned to min_page_size, driver module should handle in their own way either to round_up() the size value to min_page_size or just to enable WARN_ON().

[CI v2 04/12] drm/edid: add a helper to log dump an EDID block

2022-04-11 Thread Jani Nikula
Unify debug log dumping. There's duplication in the error paths for EDID block validity checks, but this should be neglible. Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 33 +++-- 1 file changed, 19 insertions(+), 14 deletion

[CI v2 05/12] drm/edid: pass struct edid to connector_bad_edid()

2022-04-11 Thread Jani Nikula
Avoid casting here and there, and make it const. Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 0b8098e34236..e

[CI v2 06/12] drm/edid: add typedef for block read function

2022-04-11 Thread Jani Nikula
Make the callback a bit easier on the eye. Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index e1afd6a55a8c..5b45

[CI v2 07/12] drm/edid: abstract an EDID block read helper

2022-04-11 Thread Jani Nikula
We have an abstraction for the EDID base block read, yet duplicating the retries and error handling for extension block reads. Introduce a more generic EDID block read helper. Switch to the helper piecemeal, starting with drm_edid_get_panel_id(), which doesn't need or have access to the connector

[CI v2 08/12] drm/edid: use EDID block read helper in drm_do_get_edid()

2022-04-11 Thread Jani Nikula
Convert drm_do_get_edit() from the base block read helper to the generic block read helper. There's quite a bit going on here, as the corrupt and null EDID information is moved back to the caller. As we see, they were not all that clear to begin with, and this change underlines that. Signed-off-by

[CI v2 09/12] drm/edid: convert extension block read to EDID block read helper

2022-04-11 Thread Jani Nikula
Use the EDID block read helper also for extension block reads, making edid_block_read() the only place with the read retry logic. Note: We observe that drm_do_get_edid() does not use invalid extension blocks to flag the EDID as corrupt. Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä ---

[CI v2 10/12] drm/edid: drop extra local var

2022-04-11 Thread Jani Nikula
We don't need override as a variable for anything. Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 8a050b65c06a..5a1906a

[CI v2 11/12] drm/edid: add single point of return to drm_do_get_edid()

2022-04-11 Thread Jani Nikula
This will be useful in the future. Use fail label for fail exit. Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index

[CI v2 12/12] drm/edid: add EDID block count and size helpers

2022-04-11 Thread Jani Nikula
Add some helpers to figure out the EDID extension block count, block count, size, pointers to blocks. Unfortunately, we'll need to cast away the const in a few places where we actually need to access the data. v2: fix s/j/i/ introduced in a rebase Signed-off-by: Jani Nikula Reviewed-by: Ville S

Re: [PATCH 06/12] drm/edid: add typedef for block read function

2022-04-11 Thread Jani Nikula
On Thu, 07 Apr 2022, Ville Syrjälä wrote: > On Thu, Apr 07, 2022 at 12:14:32PM +0300, Jani Nikula wrote: >> Make the callback a bit easier on the eye. >> >> Signed-off-by: Jani Nikula >> --- >> drivers/gpu/drm/drm_edid.c | 18 +- >> 1 file changed, 9 insertions(+), 9 deletions(-

Re: [PATCH 03/12] drm/edid: refactor EDID block status printing

2022-04-11 Thread Jani Nikula
On Thu, 07 Apr 2022, Ville Syrjälä wrote: > On Thu, Apr 07, 2022 at 12:14:29PM +0300, Jani Nikula wrote: >> Split out a function to log EDID block status. The printouts get changed >> slightly. >> >> Unfortunately, not all users will have struct drm_device available, so >> we convert to pr_* debu

[V2 0/3] Expose max and current bpc via debugfs

2022-04-11 Thread Bhanuprakash Modem
This series will expose the Connector's max supported bpc via connector debugfs and Crtc's current bpc via crtc debugfs. Also move the existing vendor specific "output_bpc" logic to drm. Test-with: 20220411094147.1650859-2-bhanuprakash.mo...@intel.com Bhanuprakash Modem (3): drm/debug: Expose c

[V2 0/3] Expose max and current bpc via debugfs

2022-04-11 Thread Bhanuprakash Modem
This series will expose the Connector's max supported bpc via connector debugfs and Crtc's current bpc via crtc debugfs. Also move the existing vendor specific "output_bpc" logic to drm. Test-with: 20220411094147.1650859-2-bhanuprakash.mo...@intel.com Bhanuprakash Modem (3): drm/debug: Expose c

Re: [PATCH 00/12] drm/edid: low level EDID block read refactoring etc.

2022-04-11 Thread Jani Nikula
On Thu, 07 Apr 2022, Ville Syrjälä wrote: > On Thu, Apr 07, 2022 at 12:14:26PM +0300, Jani Nikula wrote: >> Ever so slowly moving towards cleaner EDID reading. >> >> Jani Nikula (12): >> drm/edid: convert edid_is_zero() to edid_block_is_zero() for blocks >> drm/edid: have edid_block_check() d

[V2 0/3] Expose max and current bpc via debugfs

2022-04-11 Thread Bhanuprakash Modem
This series will expose the Connector's max supported bpc via connector debugfs and Crtc's current bpc via crtc debugfs. Also move the existing vendor specific "output_bpc" logic to drm. Test-with: 20220411094147.1650859-2-bhanuprakash.mo...@intel.com Bhanuprakash Modem (3): drm/debug: Expose c

[V2 1/3] drm/debug: Expose connector's max supported bpc via debugfs

2022-04-11 Thread Bhanuprakash Modem
It's useful to know the connector's max supported bpc for IGT testing. Expose it via a debugfs file on the connector "output_bpc". Example: cat /sys/kernel/debug/dri/0/DP-1/output_bpc V2: * Fix typo in comments (Harry) Cc: Jani Nikula Cc: Ville Syrjälä Cc: Harry Wentland Signed-off-by: Bhanup

[V2 2/3] drm/i915/display/debug: Expose crtc current bpc via debugfs

2022-04-11 Thread Bhanuprakash Modem
This new debugfs will expose the currently using bpc by crtc. It is very useful for verifying whether we enter the correct output color depth from IGT. This patch will also add the connector's max supported bpc to "i915_display_info" debugfs. Example: cat /sys/kernel/debug/dri/0/crtc-0/i915_curre

[V2 3/3] drm/amd/display: Move connector debugfs to drm

2022-04-11 Thread Bhanuprakash Modem
As drm_connector already have the display_info, instead of creating "output_bpc" debugfs in vendor specific driver, move the logic to the drm layer. This patch will also move "Current" bpc to the crtc debugfs from connector debugfs, since we are getting this info from crtc_state. Cc: Harry Wentla

Re: [PATCH] drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup

2022-04-11 Thread Thomas Hellström
Hi, Matthew On 4/11/22 10:56, Matthew Auld wrote: If we hit the sync case, like when skipping clearing for kernel internal objects, or when falling back to cpu clearing, like in i915, we end up trying to add a NULL fence, but with some recent changes in this area this now just results in NULL de

Re: [PATCH] drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup

2022-04-11 Thread Matthew Auld
On 11/04/2022 10:56, Thomas Hellström wrote: Hi, Matthew On 4/11/22 10:56, Matthew Auld wrote: If we hit the sync case, like when skipping clearing for kernel internal objects, or when falling back to cpu clearing, like in i915, we end up trying to add a NULL fence, but with some recent changes

Re: [RFC] drm/kms: control display brightness through drm_connector properties

2022-04-11 Thread Hans de Goede
Hi, On 4/8/22 17:11, Alex Deucher wrote: > On Fri, Apr 8, 2022 at 10:56 AM Hans de Goede wrote: >> >> Hi, >> >> On 4/8/22 16:08, Alex Deucher wrote: >>> On Fri, Apr 8, 2022 at 4:07 AM Daniel Vetter wrote: On Thu, Apr 07, 2022 at 05:05:52PM -0400, Alex Deucher wrote: > On Thu, Apr 7

Re: [RFC] drm/kms: control display brightness through drm_connector properties

2022-04-11 Thread Hans de Goede
Hi, On 4/7/22 20:58, Carsten Haitzler wrote: > On Thu, 7 Apr 2022 17:38:59 +0200 Hans de Goede said: > > Below you covered our usual /sys/class/backlight device friends... what about > DDC monitor controls? These function similarly but just remotely control a > screen via I2C and also suffer fro

Re: [RFC] drm/kms: control display brightness through drm_connector properties

2022-04-11 Thread Hans de Goede
Hi Simon, On 4/8/22 10:22, Simon Ser wrote: > Hi Hans, > > Thanks for your details replies! > > On Thursday, April 7th, 2022 at 19:43, Hans de Goede > wrote: > >>> On Thursday, April 7th, 2022 at 17:38, Hans de Goede >>> wrote: >>> The drm_connector brightness properties =

Re: [PATCH] drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup

2022-04-11 Thread Thomas Hellström
On 4/11/22 12:06, Matthew Auld wrote: On 11/04/2022 10:56, Thomas Hellström wrote: Hi, Matthew On 4/11/22 10:56, Matthew Auld wrote: If we hit the sync case, like when skipping clearing for kernel internal objects, or when falling back to cpu clearing, like in i915, we end up trying to add

Re: vc4: Couldn't stop firmware display driver during boot

2022-04-11 Thread Stefan Wahren
Hi Maxime, Am 11.04.22 um 09:35 schrieb Maxime Ripard: Hi Stefan, On Sun, Apr 10, 2022 at 02:32:02AM +0200, Stefan Wahren wrote: Am 09.04.22 um 21:25 schrieb Stefan Wahren: Hi, today i tested Linux 5.18-rc1 on my Raspberry Pi 400 connected to my HDMI display (multi_v7_defconfig + CONFIG_ARM_

Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support

2022-04-11 Thread Piotr Oniszczuk
> Wiadomość napisana przez Sascha Hauer w dniu > 11.04.2022, o godz. 11:08: > > Ok, so #37 for video, #43 for GUI. > > Where is the OSD rendered? Is it rendered on the GUI layer? Yes > >> ... >> >> >> playback: >> . >> 2022-04-08 17:48:55.457823 I DRMVideo: Using Plane #37 for v

Re: [PATCHv2] drm/amdgpu: disable ASPM on Intel AlderLake based systems

2022-04-11 Thread Gong, Richard
Hi Lijo, On 4/10/2022 11:15 PM, Lazar, Lijo wrote: On 4/9/2022 12:35 AM, Richard Gong wrote: Active State Power Management (ASPM) feature is enabled since kernel 5.14. There are some AMD GFX cards (such as WX3200 and RX640) that cannot be used with Intel AlderLake based systems to enable ASP

Re: [RFC] drm/kms: control display brightness through drm_connector properties

2022-04-11 Thread Carsten Haitzler
On Mon, 11 Apr 2022 12:27:37 +0200 Hans de Goede said: > Hi, > > On 4/7/22 20:58, Carsten Haitzler wrote: > > On Thu, 7 Apr 2022 17:38:59 +0200 Hans de Goede said: > > > > Below you covered our usual /sys/class/backlight device friends... what > > about DDC monitor controls? These function sim

Re: [RFC] drm/kms: control display brightness through drm_connector properties

2022-04-11 Thread Pekka Paalanen
On Mon, 11 Apr 2022 12:18:30 +0200 Hans de Goede wrote: > Hi, > > On 4/8/22 17:11, Alex Deucher wrote: > > On Fri, Apr 8, 2022 at 10:56 AM Hans de Goede wrote: > >> ... > > So set it to a level we can guarantee can call it 0. If we have the > > flag we are just punting on the problem in my

Re: [PATCHv2] drm/amdgpu: disable ASPM on Intel AlderLake based systems

2022-04-11 Thread Gong, Richard
Hi Paul, On 4/11/2022 2:41 AM, Paul Menzel wrote: [Cc: +] Dear Richard, Am 11.04.22 um 02:27 schrieb Gong, Richard: On 4/8/2022 7:19 PM, Paul Menzel wrote: Am 08.04.22 um 21:05 schrieb Richard Gong: Active State Power Management (ASPM) feature is enabled since kernel 5.14. There are so

Re: [PATCHv2] drm/amdgpu: disable ASPM on Intel AlderLake based systems

2022-04-11 Thread Paul Menzel
Dear Richard, Am 11.04.22 um 13:38 schrieb Gong, Richard: On 4/11/2022 2:41 AM, Paul Menzel wrote: [Cc: +] Am 11.04.22 um 02:27 schrieb Gong, Richard: On 4/8/2022 7:19 PM, Paul Menzel wrote: Am 08.04.22 um 21:05 schrieb Richard Gong: Active State Power Management (ASPM) feature is ena

Re: [RFC] drm/kms: control display brightness through drm_connector properties

2022-04-11 Thread Hans de Goede
Hi Pekka, On 4/11/22 13:34, Pekka Paalanen wrote: > On Mon, 11 Apr 2022 12:18:30 +0200 > Hans de Goede wrote: > >> Hi, >> >> On 4/8/22 17:11, Alex Deucher wrote: >>> On Fri, Apr 8, 2022 at 10:56 AM Hans de Goede wrote: > > ... > >>> So set it to a level we can guarantee can call it 0.

Re: [PATCH v0 07/10] phy: freescale: add Samsung HDMI PHY

2022-04-11 Thread Maxime Ripard
Hi Lucas, On Wed, Apr 06, 2022 at 06:01:20PM +0200, Lucas Stach wrote: > +static unsigned long phy_clk_recalc_rate(struct clk_hw *hw, > + unsigned long parent_rate) > +{ > + struct fsl_samsung_hdmi_phy *phy = to_fsl_samsung_hdmi_phy(hw); > + > + if (!ph

Re: [Intel-gfx] [CI v2 12/12] drm/edid: add EDID block count and size helpers

2022-04-11 Thread kernel test robot
Hi Jani, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on next-20220411] [cannot apply to drm/drm-next drm-intel/for-linux-next v5.18-rc2] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH v0 07/10] phy: freescale: add Samsung HDMI PHY

2022-04-11 Thread Lucas Stach
Hi Maxime, Am Montag, dem 11.04.2022 um 13:59 +0200 schrieb Maxime Ripard: > Hi Lucas, > > On Wed, Apr 06, 2022 at 06:01:20PM +0200, Lucas Stach wrote: > > +static unsigned long phy_clk_recalc_rate(struct clk_hw *hw, > > +unsigned long parent_rate) > > +{ > > +

Re: [PATCH 04/11] drm: bridge: samsung-dsim: Add DSI init in bridge pre_enable()

2022-04-11 Thread Adam Ford
On Fri, Apr 8, 2022 at 11:22 AM Jagan Teki wrote: > > Host transfer() in DSI master will invoke only when the DSI commands > are sent from DSI devices like DSI Panel or DSI bridges and this > host transfer wouldn't invoke for I2C-based-DSI bridge drivers. > > Handling DSI host initialization in tr

Re: [Intel-gfx] [CI v2 12/12] drm/edid: add EDID block count and size helpers

2022-04-11 Thread kernel test robot
Hi Jani, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on next-20220411] [cannot apply to drm/drm-next drm-intel/for-linux-next v5.18-rc2] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH] drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup

2022-04-11 Thread Christian König
Am 11.04.22 um 10:56 schrieb Matthew Auld: If we hit the sync case, like when skipping clearing for kernel internal objects, or when falling back to cpu clearing, like in i915, we end up trying to add a NULL fence, but with some recent changes in this area this now just results in NULL deref in d

Re: [PATCH v3] drm: add a check to verify the size alignment

2022-04-11 Thread Christian König
Am 11.04.22 um 11:47 schrieb Matthew Auld: On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote: Add a simple check to reject any size not aligned to the min_page_size. when size is not aligned to min_page_size, driver module should handle in their own way either to round_up() the size value t

Re: [PATCH] drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup

2022-04-11 Thread Christian König
Am 11.04.22 um 12:45 schrieb Thomas Hellström: On 4/11/22 12:06, Matthew Auld wrote: On 11/04/2022 10:56, Thomas Hellström wrote: Hi, Matthew On 4/11/22 10:56, Matthew Auld wrote: If we hit the sync case, like when skipping clearing for kernel internal objects, or when falling back to cpu c

[PATCH] video: fbdev: sh_mobile_lcdcfb: Remove sh_mobile_lcdc_check_var() declaration

2022-04-11 Thread Geert Uytterhoeven
As of commit 0fe66f327c464943 ("fbdev/sh_mobile: remove sh_mobile_lcdc_display_notify"), there is no longer a need for a foward declaration of sh_mobile_lcdc_check_var(). Signed-off-by: Geert Uytterhoeven --- drivers/video/fbdev/sh_mobile_lcdcfb.c | 3 --- 1 file changed, 3 deletions(-) diff --

Re: (EXT) [PATCH 00/11] drm: bridge: Add Samsung MIPI DSIM bridge

2022-04-11 Thread Alexander Stein
Hi Jagan, thanks for picking this up again and sending a new version. Am Freitag, 8. April 2022, 18:20:57 CEST schrieb Jagan Teki: > This series supports common bridge support for Samsung MIPI DSIM > which is used in Exynos and i.MX8MM SoC's. > > Previous RFC can be available here [1]. > > The

[PATCH v3 1/2] drm/dp: Factor out a function to probe a DPCD address

2022-04-11 Thread Imre Deak
Factor out from drm_dp_dpcd_read() a function to probe a DPCD address with a 1-byte read access. This will be needed by the next patch doing a read from an LTTPR address, which must happen without the preceding wake-up read in drm_dp_dpcd_read(). While at it add tracing for the 1 byte read even if

Re: [PATCH v3] drm: add a check to verify the size alignment

2022-04-11 Thread Matthew Auld
On 11/04/2022 13:42, Christian König wrote: Am 11.04.22 um 11:47 schrieb Matthew Auld: On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote: Add a simple check to reject any size not aligned to the min_page_size. when size is not aligned to min_page_size, driver module should handle in their o

Re: [PATCH v2 2/4] dt-bindings: display: ssd1307fb: Add entry for SINO WEALTH SH1106

2022-04-11 Thread Geert Uytterhoeven
Hi Chen-Yu, On Wed, Apr 6, 2022 at 10:13 PM Chen-Yu Tsai wrote: > From: Chen-Yu Tsai > > The SINO WEALTH SH1106 is an OLED display driver that is somewhat > compatible with the SSD1306. It supports a slightly wider display, > at 132 instead of 128 pixels. The basic commands are the same, but > t

Re: [RFC PATCH 1/6] drm/dp: Helpers to make it easier for drivers to use DP AUX bus properly

2022-04-11 Thread Doug Anderson
Hi, On Mon, Apr 11, 2022 at 1:34 AM Jani Nikula wrote: > > On Fri, 08 Apr 2022, Douglas Anderson wrote: > > As talked about in the kerneldoc for "struct dp_aux_ep_client" in this > > patch and also in the past in commit a1e3667a9835 ("drm/bridge: > > ti-sn65dsi86: Promote the AUX channel to its

Re: [PATCH v3] drm: add a check to verify the size alignment

2022-04-11 Thread Arunpravin Paneer Selvam
On 11/04/22 7:02 pm, Matthew Auld wrote: > On 11/04/2022 13:42, Christian König wrote: >> >> Am 11.04.22 um 11:47 schrieb Matthew Auld: >>> On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote: Add a simple check to reject any size not aligned to the min_page_size. when size i

[PATCH] dma-buf-map: remove renamed header file

2022-04-11 Thread Karol Herbst
commit 7938f4218168 ("dma-buf-map: Rename to iosys-map") already renamed this file, but it got brought back by a merge. Delete it for real this time. Fixes: 30424ebae8df ("Merge tag 'drm-intel-gt-next-2022-02-17' of git://anongit.freedesktop.org/drm/drm-intel into drm-intel-next") Cc: Rodrigo Vi

Re: [PATCH v3] drm: add a check to verify the size alignment

2022-04-11 Thread Christian König
Am 11.04.22 um 15:49 schrieb Arunpravin Paneer Selvam: On 11/04/22 7:02 pm, Matthew Auld wrote: On 11/04/2022 13:42, Christian König wrote: Am 11.04.22 um 11:47 schrieb Matthew Auld: On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote: Add a simple check to reject any size not aligned to

[PATCH] drm/ttm: fix logic inversion in ttm_eu_reserve_buffers

2022-04-11 Thread Christian König
That should have been max, not min. Signed-off-by: Christian König Fixes: 73511edf8b19 ("dma-buf: specify usage while adding fences to dma_resv obj v7") --- drivers/gpu/drm/ttm/ttm_execbuf_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_execbuf

[PATCH v2] drm/tegra: Stop using iommu_present()

2022-04-11 Thread Robin Murphy
Refactor the confusing logic to make it both clearer and more robust. If the host1x parent device does have an IOMMU domain then iommu_present() is redundantly true, while otherwise for the 32-bit DMA mask case it still doesn't say whether the IOMMU driver actually knows about the DRM device or not

Re: [PATCH 1/5] dt-bindings: display: ssd1307fb: Deprecate fbdev compatible strings

2022-04-11 Thread Geert Uytterhoeven
Hi Javier, On Thu, Apr 7, 2022 at 10:03 PM Javier Martinez Canillas wrote: > The current compatible strings for SSD130x I2C controllers contain an -fb > suffix, this seems to indicate that are for a fbdev driver. But the DT is > supposed to describe the hardware and not Linux implementation detai

Re: [PATCH -next] drm/solomon: Make DRM_SSD130X depends on MMU

2022-04-11 Thread Geert Uytterhoeven
Hi Javier, On Tue, Mar 15, 2022 at 12:28 PM Javier Martinez Canillas wrote: > On 3/12/22 07:34, YueHaibing wrote: > > WARNING: unmet direct dependencies detected for DRM_GEM_SHMEM_HELPER > > Depends on [n]: HAS_IOMEM [=y] && DRM [=m] && MMU [=n] > > Selected by [m]: > > - DRM_SSD130X [=m] &

Re: [Intel-gfx] [CI v2 12/12] drm/edid: add EDID block count and size helpers

2022-04-11 Thread Jani Nikula
On Mon, 11 Apr 2022, kernel test robot wrote: > Hi Jani, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on drm-tip/drm-tip] > [also build test WARNING on next-20220411] > [cannot apply to drm/drm-next drm-intel/for-linux-next v5.18-rc2

Re: [PATCH 00/11] drm: bridge: Add Samsung MIPI DSIM bridge

2022-04-11 Thread Marek Szyprowski
On 08.04.2022 18:20, Jagan Teki wrote: > This series supports common bridge support for Samsung MIPI DSIM > which is used in Exynos and i.MX8MM SoC's. > > Previous RFC can be available here [1]. > > The final bridge supports both the Exynos and i.MX8MM DSI devices. > > On, summary this patch-set br

Re: [PATCH] drm/ttm: fix logic inversion in ttm_eu_reserve_buffers

2022-04-11 Thread Matthew Auld
On 11/04/2022 14:45, Christian König wrote: That should have been max, not min. Signed-off-by: Christian König Fixes: 73511edf8b19 ("dma-buf: specify usage while adding fences to dma_resv obj v7") Should that rather be: Fixes: c8d4c18bfbc4 ("dma-buf/drivers: make reserving a shared slot ma

Re: [Intel-gfx] [CI v2 12/12] drm/edid: add EDID block count and size helpers

2022-04-11 Thread Jani Nikula
On Mon, 11 Apr 2022, kernel test robot wrote: > Hi Jani, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on drm-tip/drm-tip] > [also build test WARNING on next-20220411] > [cannot apply to drm/drm-next drm-intel/for-linux-next v5.18-rc2

Re: [PATCH] drm/ttm: fix logic inversion in ttm_eu_reserve_buffers

2022-04-11 Thread Christian König
Am 11.04.22 um 15:55 schrieb Matthew Auld: On 11/04/2022 14:45, Christian König wrote: That should have been max, not min. Signed-off-by: Christian König Fixes: 73511edf8b19 ("dma-buf: specify usage while adding fences to dma_resv obj v7") Should that rather be: Fixes: c8d4c18bfbc4 ("dma-b

[CI v3 00/12] drm/edid: low level EDID block read refactoring etc.

2022-04-11 Thread Jani Nikula
v3 of [1] fixing the (!x == 0) mistake. Resending the entire thing with hopes the test robot picks up the baseline better; I haven't had much luck with --in-reply-to for that. BR, Jani. [1] https://patchwork.freedesktop.org/series/102329/ Jani Nikula (12): drm/edid: convert edid_is_zero() to e

[CI v3 01/12] drm/edid: convert edid_is_zero() to edid_block_is_zero() for blocks

2022-04-11 Thread Jani Nikula
As edid_is_zero() is only ever used on EDID blocks, convert it to edid_block_is_zero() with implicit block size. Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/dr

[CI v3 02/12] drm/edid: have edid_block_check() detect blocks that are all zero

2022-04-11 Thread Jani Nikula
We have the check function, have it also detect blocks that are all zero instead of leaving that to callers. Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/

[CI v3 03/12] drm/edid: refactor EDID block status printing

2022-04-11 Thread Jani Nikula
Split out a function to log EDID block status. The printouts get changed slightly. Unfortunately, not all users will have struct drm_device available, so we convert to pr_* debug logging instead of drm device based logging. v2: Complain more loudly about unknown status codes (Ville) Signed-off-b

[CI v3 04/12] drm/edid: add a helper to log dump an EDID block

2022-04-11 Thread Jani Nikula
Unify debug log dumping. There's duplication in the error paths for EDID block validity checks, but this should be neglible. Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 33 +++-- 1 file changed, 19 insertions(+), 14 deletion

[CI v3 05/12] drm/edid: pass struct edid to connector_bad_edid()

2022-04-11 Thread Jani Nikula
Avoid casting here and there, and make it const. Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 0b8098e34236..e

  1   2   3   4   >