[PATCH v9 0/3] Refactor GVT-g MMIO tracking table and handlers

2022-04-07 Thread Zhi Wang
To support the new mdev interfaces and the re-factor patches from Christoph, which moves the GVT-g code into a dedicated module, the GVT-g initialization path has to be separated into two phases: a) Early initialization. The early initialization of GVT requires to be done when loading i915. Mostl

[PATCH v9 2/3] i915/gvt: Save the initial HW state snapshot in i915

2022-04-07 Thread Zhi Wang
Save the initial HW state snapshot in i915 so that the rest code of GVT-g can be moved into a dedicated module while it can still get a clean initial HW state saved at the correct time during the initialization of i915. The futhrer vGPU created by GVT-g will use this HW state as the initial HW stat

[PATCH v9 1/3] i915/gvt: Separate the MMIO tracking table from GVT-g

2022-04-07 Thread Zhi Wang
From: Zhi Wang To support the new mdev interfaces and the re-factor patches from Christoph, which moves the GVT-g code into a dedicated module, the GVT-g MMIO tracking table needs to be separated from GVT-g. v9: - Fix a problem might cause kernel panic. v8: - Use SPDX header in the intel_gvt_mm

[PATCH v9 3/3] i915/gvt: Use the initial HW state snapshot saved in i915

2022-04-07 Thread Zhi Wang
The code of saving initial HW state snapshot has been moved into i915. Let the GVT-g core logic use that snapshot. Cc: Christoph Hellwig Cc: Jason Gunthorpe Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Vivi Rodrigo Cc: Zhenyu Wang Cc: Zhi Wang Signed-off-by: Zhi Wang --- drivers/gpu/drm/i915/g

Re: [PATCH v17 6/6] drm/bridge: display-connector: add ddc-en gpio support

2022-04-07 Thread Laurent Pinchart
Hi Nikolaus, Thank you for the patch. On Wed, Apr 06, 2022 at 06:26:08PM +0200, H. Nikolaus Schaller wrote: > "hdmi-connector.yaml" bindings defines an optional property > "ddc-en-gpios" for a single gpio to enable DDC operation. > > Usually this controls +5V power on the HDMI connector. > This

Re: [PATCH 7/8] drm/display: Move HDMI helpers into display-helper module

2022-04-07 Thread Jani Nikula
On Wed, 06 Apr 2022, Thomas Zimmermann wrote: > Hi > > Am 30.03.22 um 12:35 schrieb Jani Nikula: >> On Tue, 22 Mar 2022, Thomas Zimmermann wrote: >>> diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h >>> index 144c495b99c4..e6e9e4557067 100644 >>> --- a/include/drm/drm_edid.h >>> +++ b

[PATCH v2] drm/hyperv: Added error message for fb size greater then allocated

2022-04-07 Thread Saurabh Sengar
Added error message when the size of requested framebuffer is more then the allocated size by vmbus mmio region for framebuffer Signed-off-by: Saurabh Sengar --- v1 -> v2 : Corrected Sign-off drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)

[PATCH] drm/amdgpu: Fix code with incorrect enum type

2022-04-07 Thread Grigory Vasilyev
Instead of the 'amdgpu_ring_priority_level' type, the 'amdgpu_gfx_pipe_priority' type was used, which is an error when setting ring priority. This is a minor error, but may cause problems in the future. Instead of AMDGPU_RING_PRIO_2 = 2, we can use AMDGPU_RING_PRIO_MAX = 3, but AMDGPU_RING_PRIO_2

[PATCH] drm/hyperv: Added error message for fb size greater then allocated

2022-04-07 Thread Saurabh Sengar
From: saurabh Added error message when the size of requested framebuffer is more then the allocated size by vmbus mmio region for framebuffer Signed-off-by: saurabh --- drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/g

Re: [PATCH] drm/amdkfd: Fix potential NULL pointer dereference

2022-04-07 Thread Григорий
Thanks. You are right. I found a potential bug, and as I understand it, the code only applies to the Aldebaran GPU and I can not check the correctness of the code. I only test code on my navi 10 and run GPU stress tests. My knowledge of amdgpu is limited, and fixing potential bugs allows me to lear

Re: [PATCH] drm/amdgpu: Unnecessary code in gfx_v7_0.c

2022-04-07 Thread Григорий
Alex Deucher, Thanks, that's what I thought too. But this code is uninformative, and without it is clear what this code is doing. If you need to provide additional information on how the code works, then for me it's better to leave a comment. This is actually more like a bug than an explanation of

Re: [PATCH 7/8] drm/display: Move HDMI helpers into display-helper module

2022-04-07 Thread Jani Nikula
On Thu, 07 Apr 2022, Jani Nikula wrote: > On Wed, 06 Apr 2022, Thomas Zimmermann wrote: >> Hi >> >> Am 30.03.22 um 12:35 schrieb Jani Nikula: >>> On Tue, 22 Mar 2022, Thomas Zimmermann wrote: diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h index 144c495b99c4..e6e9e4557067

Re: [PATCH 3/8] drm/display: Introduce a DRM display-helper module

2022-04-07 Thread Javier Martinez Canillas
On 4/6/22 21:08, Thomas Zimmermann wrote: > Hi Javier > > Am 30.03.22 um 11:23 schrieb Javier Martinez Canillas: >> On 3/22/22 20:27, Thomas Zimmermann wrote: >>> Replace the DP-helper module with a display-helper module. Update >>> all related Kconfig and Makefile rules. >>> >>> Besides the exist

Re: [PATCH 7/8] drm/display: Move HDMI helpers into display-helper module

2022-04-07 Thread Thomas Zimmermann
Hi Am 07.04.22 um 09:34 schrieb Jani Nikula: On Thu, 07 Apr 2022, Jani Nikula wrote: On Wed, 06 Apr 2022, Thomas Zimmermann wrote: Hi Am 30.03.22 um 12:35 schrieb Jani Nikula: On Tue, 22 Mar 2022, Thomas Zimmermann wrote: diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h index

Re: [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks

2022-04-07 Thread Thomas Zimmermann
Hi Daniel Am 31.03.22 um 17:20 schrieb Daniel Vetter: The stuff never really worked, and leads to lots of fun because it out-of-order frees atomic states. Which upsets KASAN, among other things. For async updates we now have a more solid solution with the ->atomic_async_check and ->atomic_async

Re: [PATCH v2 1/7] drm: mxsfb: Simplify LCDIF clock handling

2022-04-07 Thread Lucas Stach
Am Mittwoch, dem 06.04.2022 um 23:45 +0200 schrieb Marek Vasut: > On 4/6/22 21:32, Lucas Stach wrote: > > Hi Marek, > > Hi, > > > Am Freitag, dem 11.03.2022 um 18:05 +0100 schrieb Marek Vasut: > > > The current clock handling in the LCDIF driver is a convoluted mess. > > > > Here we agree... > >

Re: [PATCH v2 2/7] drm: mxsfb: Simplify LCDIF IRQ handling

2022-04-07 Thread Lucas Stach
Am Donnerstag, dem 07.04.2022 um 00:03 +0200 schrieb Marek Vasut: > On 4/6/22 21:41, Lucas Stach wrote: > > Am Freitag, dem 11.03.2022 um 18:05 +0100 schrieb Marek Vasut: > > > The call to drm_crtc_vblank_off(&lcdif->crtc); disables IRQ generation > > > from the LCDIF block already and this is call

Re: [PATCH 03/16] dma-buf: specify usage while adding fences to dma_resv obj v6

2022-04-07 Thread Christian König
Am 06.04.22 um 14:35 schrieb Daniel Vetter: On Wed, Apr 06, 2022 at 02:32:22PM +0200, Daniel Vetter wrote: On Wed, Apr 06, 2022 at 09:51:19AM +0200, Christian König wrote: [SNIP] diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c index 53f7

Re: [PATCH 3/8] drm/display: Introduce a DRM display-helper module

2022-04-07 Thread Thomas Zimmermann
Hi Javier Am 07.04.22 um 09:43 schrieb Javier Martinez Canillas: On 4/6/22 21:08, Thomas Zimmermann wrote: Hi Javier Am 30.03.22 um 11:23 schrieb Javier Martinez Canillas: On 3/22/22 20:27, Thomas Zimmermann wrote: Replace the DP-helper module with a display-helper module. Update all related

Re: [PATCH v7 04/12] clk: Always clamp the rounded rate

2022-04-07 Thread Maxime Ripard
Hi Yassine, On Thu, Apr 07, 2022 at 07:56:42AM +, Yassine Oudjana wrote: > On Fri, 25 Feb 2022 15:35:26 +0100, Maxime Ripard wrote: > > The current core while setting the min and max rate properly in the > > clk_request structure will not make sure that the requested rate is > > within these

Re: [PATCH v17 4/6] drm/bridge: dw-hdmi: handle unusable or non-configured CSC module

2022-04-07 Thread Neil Armstrong
Hi, On 06/04/2022 18:26, H. Nikolaus Schaller wrote: From: Neil Armstrong The dw-hdmi integrates an optional Color Space Conversion feature used to handle color-space conversions. On some platforms, the CSC isn't built-in or non-functional. This adds the necessary code to disable the CSC fun

Re: [PATCH v17 5/6] drm/bridge: dw-hdmi: add YCBCR formats only if CSC is available

2022-04-07 Thread Neil Armstrong
On 06/04/2022 18:26, H. Nikolaus Schaller wrote: otherwise they will produce a black HDMI screen. Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdm

Re: [PATCH v0 01/10] drm/bridge: dw-hdmi: add low-active PHY reset

2022-04-07 Thread Neil Armstrong
Hi Lucas, On 06/04/2022 18:01, Lucas Stach wrote: Allow vendor PHY implementations to reset PHYs with different polarity than the current Gen2 reset. Signed-off-by: Lucas Stach --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 7 +++ include/drm/bridge/dw_hdmi.h | 1 + 2 fil

Re: [PATCH 3/8] drm/display: Introduce a DRM display-helper module

2022-04-07 Thread Jani Nikula
On Thu, 07 Apr 2022, Thomas Zimmermann wrote: > Hi Javier > > Am 07.04.22 um 09:43 schrieb Javier Martinez Canillas: >> On 4/6/22 21:08, Thomas Zimmermann wrote: >>> Hi Javier >>> >>> Am 30.03.22 um 11:23 schrieb Javier Martinez Canillas: On 3/22/22 20:27, Thomas Zimmermann wrote: > Repla

Re: [PATCH 2/2] drm: lcdif: Add support for i.MX8MP LCDIF variant

2022-04-07 Thread Lucas Stach
Am Donnerstag, dem 07.04.2022 um 01:22 +0200 schrieb Marek Vasut: > On 4/4/22 14:23, Lucas Stach wrote: > > Hi Marek, > > Hi, > > > not a full review right now, just the first things that I noticed while > > playing around with this. > > > > Am Dienstag, dem 22.03.2022 um 15:28 +0100 schrieb Mar

Re: [PATCH v0 01/10] drm/bridge: dw-hdmi: add low-active PHY reset

2022-04-07 Thread Lucas Stach
Hi Neil, Am Donnerstag, dem 07.04.2022 um 10:30 +0200 schrieb Neil Armstrong: > Hi Lucas, > > On 06/04/2022 18:01, Lucas Stach wrote: > > Allow vendor PHY implementations to reset PHYs with different polarity > > than the current Gen2 reset. > > > > Signed-off-by: Lucas Stach > > --- > > driv

[PULL] drm-misc-next

2022-04-07 Thread Maxime Ripard
Hi Dave, Daniel, Here's the first drm-misc-next for 5.19 Maxime drm-misc-next-2022-04-07: drm-misc-next for 5.19: UAPI Changes: Cross-subsystem Changes: Core Changes: - atomic: Add atomic_print_state to private objects - edid: Constify the EDID parsing API, rework of the API - dma-buf:

DMA-resv usage

2022-04-07 Thread Christian König
Hi Daniel, only patch #2 had some significant changes. The rest ist pretty much the same except for the dropped exynos change and the added cleanup for the seqlock. Thanks, Christian.

[PATCH 01/15] dma-buf: add enum dma_resv_usage v4

2022-04-07 Thread Christian König
This change adds the dma_resv_usage enum and allows us to specify why a dma_resv object is queried for its containing fences. Additional to that a dma_resv_usage_rw() helper function is added to aid retrieving the fences for a read or write userspace submission. This is then deployed to the diffe

[PATCH 03/15] dma-buf & drm/amdgpu: remove dma_resv workaround

2022-04-07 Thread Christian König
Rework the internals of the dma_resv object to allow adding more than one write fence and remember for each fence what purpose it had. This allows removing the workaround from amdgpu which used a container for this instead. Signed-off-by: Christian König Reviewed-by: Daniel Vetter Cc: amd-...@l

[PATCH 02/15] dma-buf: specify usage while adding fences to dma_resv obj v7

2022-04-07 Thread Christian König
Instead of distingting between shared and exclusive fences specify the fence usage while adding fences. Rework all drivers to use this interface instead and deprecate the old one. v2: some kerneldoc comments suggested by Daniel v3: fix a missing case in radeon v4: rebase on nouveau changes, fix l

[PATCH 04/15] dma-buf: add DMA_RESV_USAGE_KERNEL v3

2022-04-07 Thread Christian König
Add an usage for kernel submissions. Waiting for those are mandatory for dynamic DMA-bufs. As a precaution this patch also changes all occurrences where fences are added as part of memory management in TTM, VMWGFX and i915 to use the new value because it now becomes possible for drivers to ignore

[PATCH 05/15] drm/amdgpu: use DMA_RESV_USAGE_KERNEL

2022-04-07 Thread Christian König
Wait only for kernel fences before kmap or UVD direct submission. This also makes sure that we always wait in amdgpu_bo_kmap() even when returning a cached pointer. Signed-off-by: Christian König Acked-by: Daniel Vetter --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 10 +- drivers/gp

[PATCH 07/15] drm/nouveau: only wait for kernel fences in nouveau_bo_vm_cleanup

2022-04-07 Thread Christian König
Don't wait for user space submissions. I'm not 100% sure if that is correct, but it seems to match what the code initially intended. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_bo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nou

[PATCH 08/15] RDMA: use DMA_RESV_USAGE_KERNEL

2022-04-07 Thread Christian König
We only need to wait for kernel submissions here. Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/infiniband/core/umem_dmabuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/core/umem_dmabuf.c b/drivers/infiniband/core/umem_dmabuf.

[PATCH 09/15] dma-buf: add DMA_RESV_USAGE_BOOKKEEP v3

2022-04-07 Thread Christian König
Add an usage for submissions independent of implicit sync but still interesting for memory management. v2: cleanup the kerneldoc a bit v3: separate amdgpu changes from this Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/dma-buf/dma-resv.c | 4 ++-- driv

[PATCH 06/15] drm/radeon: use DMA_RESV_USAGE_KERNEL

2022-04-07 Thread Christian König
Always wait for kernel fences before kmap and not only for UVD kmaps. Signed-off-by: Christian König Acked-by: Daniel Vetter --- drivers/gpu/drm/radeon/radeon_object.c | 7 ++- drivers/gpu/drm/radeon/radeon_uvd.c| 12 ++-- 2 files changed, 8 insertions(+), 11 deletions(-) diff

[PATCH 15/15] seqlock: drop seqcount_ww_mutex_t

2022-04-07 Thread Christian König
Daniel pointed out that this series removes the last user of seqcount_ww_mutex_t, so let's drop this. Signed-off-by: Christian König Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Will Deacon Cc: Waiman Long Cc: Boqun Feng Cc: linux-ker...@vger.kernel.org --- include/linux/seqlock.h | 8 ++-- 1

[PATCH 12/15] drm/i915: drop bo->moving dependency

2022-04-07 Thread Christian König
That should now be handled by the common dma_resv framework. Signed-off-by: Christian König Reviewed-by: Daniel Vetter Cc: intel-...@lists.freedesktop.org --- drivers/gpu/drm/i915/gem/i915_gem_object.c| 41 --- drivers/gpu/drm/i915/gem/i915_gem_object.h| 8 +--- drivers

[PATCH 11/15] dma-buf: wait for map to complete for static attachments

2022-04-07 Thread Christian König
We have previously done that in the individual drivers but it is more defensive to move that into the common code. Dynamic attachments should wait for map operations to complete by themselves. Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/dma-buf/dma-buf.c

[PATCH 14/15] dma-buf: drop seq count based update

2022-04-07 Thread Christian König
This should be possible now since we don't have the distinction between exclusive and shared fences any more. The only possible pitfall is that a dma_fence would be reused during the RCU grace period, but even that could be handled with a single extra check. Signed-off-by: Christian König Review

[PATCH 10/15] drm/amdgpu: use DMA_RESV_USAGE_BOOKKEEP

2022-04-07 Thread Christian König
Use DMA_RESV_USAGE_BOOKKEEP for VM page table updates and KFD preemption fence. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/dri

[PATCH 13/15] drm/ttm: remove bo->moving

2022-04-07 Thread Christian König
This is now handled by the DMA-buf framework in the dma_resv obj. Also remove the workaround inside VMWGFX to update the moving fence. Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 13 --- drivers/gpu/drm/amd/amdgpu/amdgpu_obj

Re: [PATCH] drm: sti: don't use kernel-doc markers

2022-04-07 Thread Philippe CORNU
On 3/31/22 18:58, Philippe CORNU wrote: On 3/28/22 16:26, Daniel Vetter wrote: On Mon, Mar 28, 2022 at 12:21:16PM +0200, Alain Volmat wrote: Hi Randy, thanks for the patch. Acked-by: Alain Volmat Will Philippe apply this one? Hi, yes I will (probably early next week). Many thanks Ph

Re: [PATCH] stm: ltdc: fix two incorrect NULL checks on list iterator

2022-04-07 Thread Philippe CORNU
On 3/28/22 14:37, Raphael Gallais-Pou wrote: Hello Xiaomeng On 3/27/22 07:53, Xiaomeng Tong wrote: The two bugs are here: if (encoder) { if (bridge && bridge->timings) The list iterator value 'encoder/bridge' will *always* be set and non-NULL by drm_for_each_encoder()/list_f

[PATCH] video: fbdev: Fix missing of_node_put in imxfb_probe

2022-04-07 Thread cgel . zte
From: Lv Ruyi of_parse_phandle returns node pointer with refcount incremented, use of_node_put() on it when done. Reported-by: Zeal Robot Signed-off-by: Lv Ruyi --- drivers/video/fbdev/imxfb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fb

Re: [RESEND RFC PATCH 1/5] firmware: sysfb: Make sysfb_create_simplefb() return a pdev pointer

2022-04-07 Thread Daniel Vetter
On Wed, Apr 06, 2022 at 11:39:15PM +0200, Javier Martinez Canillas wrote: > This function just returned 0 on success or an errno code on error, but it > could be useful to sysfb_init() to get a pointer to the device registered. > > Signed-off-by: Javier Martinez Canillas You need to rebase this

Re: [RESEND RFC PATCH 2/5] firmware: sysfb: Add helpers to unregister a pdev and disable registration

2022-04-07 Thread Daniel Vetter
On Wed, Apr 06, 2022 at 11:39:16PM +0200, Javier Martinez Canillas wrote: > These can be used by subsystems to unregister a platform device registered > by sysfb and also to disable future platform device registration in sysfb. > > Suggested-by: Daniel Vetter > Signed-off-by: Javier Martinez Cani

Re: [RESEND RFC PATCH 3/5] fbdev: Restart conflicting fb removal loop when unregistering devices

2022-04-07 Thread Daniel Vetter
On Wed, Apr 06, 2022 at 11:39:17PM +0200, Javier Martinez Canillas wrote: > Drivers that want to remove registered conflicting framebuffers prior to > register their own framebuffer, calls remove_conflicting_framebuffers(). > > This function takes the registration_lock mutex, to prevent a races wh

Re: [RESEND RFC PATCH 1/5] firmware: sysfb: Make sysfb_create_simplefb() return a pdev pointer

2022-04-07 Thread Javier Martinez Canillas
Hello Daniel, On 4/7/22 11:03, Daniel Vetter wrote: > On Wed, Apr 06, 2022 at 11:39:15PM +0200, Javier Martinez Canillas wrote: >> This function just returned 0 on success or an errno code on error, but it >> could be useful to sysfb_init() to get a pointer to the device registered. >> >> Signed-o

[PATCH v10 0/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2022-04-07 Thread Liu Ying
Hi, This is the v10 series to introduce i.MX8qm/qxp Display Processing Unit(DPU) DRM support. DPU is comprised of a blit engine for 2D graphics, a display controller and a command sequencer. Outside of DPU, optional prefetch engines can fetch data from memory prior to some DPU fetchunits of bli

[PATCH v10 1/6] dt-bindings: display: imx: Add i.MX8qxp/qm DPU binding

2022-04-07 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Processing Unit. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v9->v10: * No change. v8->v9: * No change. v7->v8: * No change. v6->v7: * Add Rob's R-b tag back. v5->v6: * Use graph schema. So, drop Rob's R-b tag as review is needed. v4

[PATCH v10 2/6] dt-bindings: display: imx: Add i.MX8qxp/qm PRG binding

2022-04-07 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Gasket. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v9->v10: * No change. v8->v9: * No change. v7->v8: * No change. v6->v7: * No change. v5->v6: * No change. v4->v5: * No change. v3->v4: * Improve compatible propert

[PATCH v10 3/6] dt-bindings: display: imx: Add i.MX8qxp/qm DPR channel binding

2022-04-07 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Channel. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v9->v10: * Add Rob's R-b tag. v8->v9: * Reference 'interrupts-extended' schema instead of 'interrupts' to require an additional interrupt(r_rtram_stall) because the

[PATCH v10 4/6] drm/atomic: Avoid unused-but-set-variable warning on for_each_old_plane_in_state

2022-04-07 Thread Liu Ying
Artificially use 'plane' and 'old_plane_state' to avoid 'not used' warning. The precedent has already been set by other macros in the same file. Acked-by: Daniel Vetter Signed-off-by: Liu Ying --- v9->v10: * No change. v8->v9: * No change. v7->v8: * No change. v6->v7: * No change. v5->v6: *

[PATCH v10 6/6] MAINTAINERS: add maintainer for i.MX8qxp DPU DRM driver

2022-04-07 Thread Liu Ying
Add myself as the maintainer of the i.MX8qxp DPU DRM driver. Acked-by: Laurentiu Palcu Signed-off-by: Liu Ying --- v9->v10: * Add Laurentiu's A-b tag. v8->v9: * No change. v7->v8: * No change. v6->v7: * No change. v5->v6: * No change. v4->v5: * No change. v3->v4: * No change. v2->v3: * No

Re: [RESEND RFC PATCH 2/5] firmware: sysfb: Add helpers to unregister a pdev and disable registration

2022-04-07 Thread Javier Martinez Canillas
On 4/7/22 11:06, Daniel Vetter wrote: > On Wed, Apr 06, 2022 at 11:39:16PM +0200, Javier Martinez Canillas wrote: [snip] >> +} >> +EXPORT_SYMBOL_GPL(sysfb_try_unregister); > > Kerneldoc for these plus adding that to > Documentation/firmware/other_interfaces.rst would be really neat. > > With th

Re: [RESEND RFC PATCH 4/5] fbdev: Fix some race conditions between fbmem and sysfb

2022-04-07 Thread Daniel Vetter
On Wed, Apr 06, 2022 at 11:39:18PM +0200, Javier Martinez Canillas wrote: > The platform devices registered in sysfb match with a firmware-based fbdev > or DRM driver, that are used to have early graphics using framebuffers set > up by the system firmware. > > Real DRM drivers later are probed and

Re: [PATCH 02/15] dma-buf: specify usage while adding fences to dma_resv obj v7

2022-04-07 Thread Daniel Vetter
On Thu, Apr 07, 2022 at 10:59:33AM +0200, Christian König wrote: > Instead of distingting between shared and exclusive fences specify > the fence usage while adding fences. > > Rework all drivers to use this interface instead and deprecate the old one. > > v2: some kerneldoc comments suggested by

[PATCH 00/12] drm/edid: low level EDID block read refactoring etc.

2022-04-07 Thread Jani Nikula
Ever so slowly moving towards cleaner EDID reading. Jani Nikula (12): drm/edid: convert edid_is_zero() to edid_block_is_zero() for blocks drm/edid: have edid_block_check() detect blocks that are all zero drm/edid: refactor EDID block status printing drm/edid: add a helper to log dump an ED

[PATCH 02/12] drm/edid: have edid_block_check() detect blocks that are all zero

2022-04-07 Thread Jani Nikula
We have the check function, have it also detect blocks that are all zero instead of leaving that to callers. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu

[PATCH 03/12] drm/edid: refactor EDID block status printing

2022-04-07 Thread Jani Nikula
Split out a function to log EDID block status. The printouts get changed slightly. Unfortunately, not all users will have struct drm_device available, so we convert to pr_* debug logging instead of drm device based logging. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 75

[PATCH 04/12] drm/edid: add a helper to log dump an EDID block

2022-04-07 Thread Jani Nikula
Unify debug log dumping. There's duplication in the error paths for EDID block validity checks, but this should be neglible. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/drivers/g

[PATCH 01/12] drm/edid: convert edid_is_zero() to edid_block_is_zero() for blocks

2022-04-07 Thread Jani Nikula
As edid_is_zero() is only ever used on EDID blocks, convert it to edid_block_is_zero() with implicit block size. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/d

[PATCH 05/12] drm/edid: pass struct edid to connector_bad_edid()

2022-04-07 Thread Jani Nikula
Avoid casting here and there, and make it const. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 8638e54e0879..ba54701f91f6 100644 --- a/dri

[PATCH 06/12] drm/edid: add typedef for block read function

2022-04-07 Thread Jani Nikula
Make the callback a bit easier on the eye. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index ba54701f91f6..926ffe5cd97e 100644 --- a/driver

[PATCH 07/12] drm/edid: abstract an EDID block read helper

2022-04-07 Thread Jani Nikula
We have an abstraction for the EDID base block read, yet duplicating the retries and error handling for extension block reads. Introduce a more generic EDID block read helper. Switch to the helper piecemeal, starting with drm_edid_get_panel_id(), which doesn't need or have access to the connector

[PATCH 08/12] drm/edid: use EDID block read helper in drm_do_get_edid()

2022-04-07 Thread Jani Nikula
Convert drm_do_get_edit() from the base block read helper to the generic block read helper. There's quite a bit going on here, as the corrupt and null EDID information is moved back to the caller. As we see, they were not all that clear to begin with, and this change underlines that. Signed-off-by

[PATCH 09/12] drm/edid: convert extension block read to EDID block read helper

2022-04-07 Thread Jani Nikula
Use the EDID block read helper also for extension block reads, making edid_block_read() the only place with the read retry logic. Note: We observe that drm_do_get_edid() does not use invalid extension blocks to flag the EDID as corrupt. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c

Re: [PATCH v0 02/10] dt-bindings: display: imx: add binding for i.MX8MP HDMI TX

2022-04-07 Thread Lucas Stach
Am Mittwoch, dem 06.04.2022 um 15:08 -0500 schrieb Rob Herring: > On Wed, 06 Apr 2022 18:01:15 +0200, Lucas Stach wrote: > > The HDMI TX controller on the i.MX8MP SoC is a Synopsys designware IP > > core with a little bit of SoC integration around it. > > > > Signed-off-by: Lucas Stach > > --- >

[PATCH 10/12] drm/edid: drop extra local var

2022-04-07 Thread Jani Nikula
We don't need override as a variable for anything. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 6fa17084af02..767639364bd9 100644 --- a/drivers/g

Re: DMA-resv usage

2022-04-07 Thread Daniel Vetter
On Thu, Apr 07, 2022 at 10:59:31AM +0200, Christian König wrote: > Hi Daniel, > > only patch #2 had some significant changes. The rest ist pretty much the > same except for the dropped exynos change and the added cleanup for the > seqlock. Reviewed that patch, I plan to do a full review of the do

[PATCH 11/12] drm/edid: add single point of return to drm_do_get_edid()

2022-04-07 Thread Jani Nikula
This will be useful in the future. Use fail label for fail exit. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 767639364bd9..90615e30eaf5

[PATCH 12/12] drm/edid: add EDID block count and size helpers

2022-04-07 Thread Jani Nikula
Add some helpers to figure out the EDID extension block count, block count, size, pointers to blocks. Unfortunately, we'll need to cast away the const in a few places where we actually need to access the data. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 78 ++

Re: [RESEND RFC PATCH 4/5] fbdev: Fix some race conditions between fbmem and sysfb

2022-04-07 Thread Javier Martinez Canillas
On 4/7/22 11:11, Daniel Vetter wrote: > On Wed, Apr 06, 2022 at 11:39:18PM +0200, Javier Martinez Canillas wrote: [snip] > > Yeah it's disappointing, but no worse than the piles of hacks we have now. > > With the bikesheds addressed above: > Agree with all your comments and will address in the

Re: [PATCH 15/15] seqlock: drop seqcount_ww_mutex_t

2022-04-07 Thread Daniel Vetter
On Thu, Apr 07, 2022 at 10:59:46AM +0200, Christian König wrote: > Daniel pointed out that this series removes the last user of > seqcount_ww_mutex_t, so let's drop this. > > Signed-off-by: Christian König > Cc: Peter Zijlstra > Cc: Ingo Molnar > Cc: Will Deacon > Cc: Waiman Long > Cc: Boqun

Re: [PATCH] drm: sti: fix spelling mistake: rejec -> rejection

2022-04-07 Thread Philippe CORNU
On 10/4/19 10:27, Colin King wrote: From: Colin Ian King In other places of the driver the string hdmi_rejection_pll is used instead of the truncated hdmi_rejec_pll, so use this string instead to be consistent. Signed-off-by: Colin Ian King --- drivers/gpu/drm/sti/sti_hdmi.c | 2 +- 1 f

Re: [PATCH 15/15] seqlock: drop seqcount_ww_mutex_t

2022-04-07 Thread Peter Zijlstra
On Thu, Apr 07, 2022 at 10:59:46AM +0200, Christian König wrote: > Daniel pointed out that this series removes the last user of > seqcount_ww_mutex_t, so let's drop this. > > Signed-off-by: Christian König Acked-by: Peter Zijlstra (Intel)

Re: [PATCH 03/16] dma-buf: specify usage while adding fences to dma_resv obj v6

2022-04-07 Thread Daniel Vetter
On Thu, Apr 07, 2022 at 10:01:52AM +0200, Christian König wrote: > Am 06.04.22 um 14:35 schrieb Daniel Vetter: > > On Wed, Apr 06, 2022 at 02:32:22PM +0200, Daniel Vetter wrote: > > > On Wed, Apr 06, 2022 at 09:51:19AM +0200, Christian König wrote: > > > > [SNIP] > > > > diff --git a/drivers/gpu/dr

Re: [PATCH v0 07/10] phy: freescale: add Samsung HDMI PHY

2022-04-07 Thread Philipp Zabel
Hi Lucas, On Mi, 2022-04-06 at 18:01 +0200, Lucas Stach wrote: > This adds the driver for the Samsung HDMI PHY found on the > i.MX8MP SoC. > > Heavily based on the PHY implementation in the downstream kernel > written by Sandor Yu , but also cleaned up > quite a bit and extended to support runtim

Re: [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks

2022-04-07 Thread Daniel Vetter
On Thu, Apr 07, 2022 at 09:49:49AM +0200, Thomas Zimmermann wrote: > Hi Daniel > > Am 31.03.22 um 17:20 schrieb Daniel Vetter: > > The stuff never really worked, and leads to lots of fun because it > > out-of-order frees atomic states. Which upsets KASAN, among other > > things. > > > > For async

Re: [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks

2022-04-07 Thread Daniel Vetter
On Wed, Apr 06, 2022 at 06:27:00PM -0700, Jessica Zhang wrote: > > > On 3/31/2022 8:20 AM, Daniel Vetter wrote: > > The stuff never really worked, and leads to lots of fun because it > > out-of-order frees atomic states. Which upsets KASAN, among other > > things. > > > > For async updates we no

Re: [PATCH v2 4/7] drm: mxsfb: Move mxsfb_get_fb_paddr() away from register IO functions

2022-04-07 Thread Lucas Stach
Am Donnerstag, dem 07.04.2022 um 00:05 +0200 schrieb Marek Vasut: > On 4/6/22 21:45, Lucas Stach wrote: > > Am Freitag, dem 11.03.2022 um 18:05 +0100 schrieb Marek Vasut: > > > Move mxsfb_get_fb_paddr() out of the way, away from register IO functions. > > > This is a clean up. No functional change.

Re: [PATCH v3 10/10] drm/msm: Add a way for userspace to allocate GPU iova

2022-04-07 Thread Dmitry Osipenko
On 4/7/22 00:46, Rob Clark wrote: > From: Rob Clark > > The motivation at this point is mainly native userspace mesa driver in a > VM guest. The one remaining synchronous "hotpath" is buffer allocation, > because guest needs to wait to know the bo's iova before it can start > emitting cmdstream/

Re: [PATCH v0 03/10] drm/imx: add bridge wrapper driver for i.MX8MP DWC HDMI

2022-04-07 Thread Philipp Zabel
On Mi, 2022-04-06 at 18:01 +0200, Lucas Stach wrote: > Add a simple wrapper driver for the DWC HDMI bridge driver that > implements the few bits that are necessary to abstract the i.MX8MP > SoC integration. > > Signed-off-by: Lucas Stach Reviewed-by: Philipp Zabel regards Philipp

Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support

2022-04-07 Thread Sascha Hauer
On Wed, Apr 06, 2022 at 06:00:00PM +0200, Piotr Oniszczuk wrote: > > > > Wiadomość napisana przez Sascha Hauer w dniu > > 06.04.2022, o godz. 16:58: > > > > On Wed, Apr 06, 2022 at 11:47:22AM +0200, Piotr Oniszczuk wrote: > >> > >> > >> Sascha, > >> > >> Having vop2 finally working with drm

Re: [PATCH v9 1/3] i915/gvt: Separate the MMIO tracking table from GVT-g

2022-04-07 Thread Wang, Zhi A
Thanks so much! Jani and Joonas, it would be better to have one rb from i915 maintainers as this patches also modify i915 code. Thanks, Zhi. On 4/7/22 8:06 AM, Christoph Hellwig wrote: > The whole series looks good and works fine on by Kaby Lake Thinkpad: > > Reviewed-by: Christoph Hellwig >

Re: [PATCH v0 05/10] drm/imx: add driver for HDMI TX Parallel Video Interface

2022-04-07 Thread Philipp Zabel
On Mi, 2022-04-06 at 18:01 +0200, Lucas Stach wrote: > This IP block is found in the HDMI subsystem of the i.MX8MP SoC. It has a > full timing generator and can switch between different video sources. On > the i.MX8MP however the only supported source is the LCDIF. The block > just needs to be powe

[PULL] drm-misc-fixes

2022-04-07 Thread Maarten Lankhorst
drm-misc-fixes-2022-04-07: drm-misc-fixes for v5.18-rc2: - Fix a crash when booting with nouveau on tegra. - Don't require input port for MIPI-DSI, and make width/height mandatory. - Fix unregistering of framebuffers without device. - The following changes since commit 3123109284176b1532874591f7c81

[PULL] drm-misc-next-fixes

2022-04-07 Thread Maarten Lankhorst
drm-misc-next-fixes-2022-04-07: drm-misc-next-fixes for v5.18-rc2: - fix warning about fence containers - fix logic error in new fence merge code - handle empty dma_fence_arrays gracefully - Try all possible cases for bridge/panel detection. The following changes since commit 7344bad7fb6daa4877a1c0

[PATCH 1/2] drm/i915: consider min_page_size when migrating

2022-04-07 Thread Matthew Auld
We can only force migrate an object if the existing object size is compatible with the new destinations min_page_size for the region. Currently we blow up with something like: [ 2857.497462] kernel BUG at drivers/gpu/drm/i915/gt/intel_migrate.c:431! [ 2857.497497] invalid opcode: [#1] PREEMPT

[PATCH 2/2] drm/i915/buddy: sanity check the size

2022-04-07 Thread Matthew Auld
Ensure we check that the size is compatible with the requested page_size. For tiny objects that are automatically annotated with TTM_PL_FLAG_CONTIGUOUS(since they fit within a single page), we currently end up silently overriding the min_page_size, which ends up hiding bugs elsewhere. Signed-off-b

Re: [PATCH v17 4/6] drm/bridge: dw-hdmi: handle unusable or non-configured CSC module

2022-04-07 Thread H. Nikolaus Schaller
Hi Neil, > Am 07.04.2022 um 10:28 schrieb Neil Armstrong : > > Hi, > > On 06/04/2022 18:26, H. Nikolaus Schaller wrote: >> From: Neil Armstrong >> The dw-hdmi integrates an optional Color Space Conversion feature used >> to handle color-space conversions. >> On some platforms, the CSC isn't bui

Re: [PATCH v17 5/6] drm/bridge: dw-hdmi: add YCBCR formats only if CSC is available

2022-04-07 Thread H. Nikolaus Schaller
> Am 07.04.2022 um 10:29 schrieb Neil Armstrong : > > On 06/04/2022 18:26, H. Nikolaus Schaller wrote: >> otherwise they will produce a black HDMI screen. >> Signed-off-by: H. Nikolaus Schaller >> --- >> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 6 -- >> 1 file changed, 4 insertions(+),

Re: [PATCH v17 6/6] drm/bridge: display-connector: add ddc-en gpio support

2022-04-07 Thread H. Nikolaus Schaller
Hi Laurent, > Am 07.04.2022 um 09:30 schrieb Laurent Pinchart > : > > Hi Nikolaus, > > Thank you for the patch. > > On Wed, Apr 06, 2022 at 06:26:08PM +0200, H. Nikolaus Schaller wrote: >> "hdmi-connector.yaml" bindings defines an optional property >> "ddc-en-gpios" for a single gpio to enable

[PATCH v18 0/3] MIPS: JZ4780 and CI20 HDMI

2022-04-07 Thread H. Nikolaus Schaller
PATCH V18 2022-04-07 13:16:10: * removed CSC filter patches (3-5/6) by Neil Armstrong as they no longer seem to be required * added "Reviewed-by: Laurent Pinchart " to ddc-en patch (6/6) PATCH V17 2022-04-06 18:26:08: * removed our local attempts to enable HPD because "drm/bridge_connector: e

[PATCH v18 1/3] drm/bridge: display-connector: add ddc-en gpio support

2022-04-07 Thread H. Nikolaus Schaller
"hdmi-connector.yaml" bindings defines an optional property "ddc-en-gpios" for a single gpio to enable DDC operation. Usually this controls +5V power on the HDMI connector. This +5V may also be needed for HPD. This was not reflected in code but is needed to make the CI20 board work. Now, the dri

[PATCH v18 3/3] drm/ingenic: Add dw-hdmi driver specialization for jz4780

2022-04-07 Thread H. Nikolaus Schaller
From: Paul Boddie A specialisation of the generic Synopsys HDMI driver is employed for JZ4780 HDMI support. This requires a new driver, plus device tree and configuration modifications. Here we add Kconfig DRM_INGENIC_DW_HDMI, Makefile and driver code. Note that there is no hpd-gpio installed o

[PATCH v18 2/3] drm/ingenic: Implement proper .atomic_get_input_bus_fmts

2022-04-07 Thread H. Nikolaus Schaller
From: Paul Cercueil The .atomic_get_input_bus_fmts() callback of our top bridge should return the possible input formats for a given output format. If the requested output format is not supported, then NULL should be returned, otherwise the bus format negociation will end with a bus format that t

Re: [PATCH v2 1/2] drm/panel: lvds: Simplify mode parsing

2022-04-07 Thread Laurent Pinchart
Hi Marek, Thank you for the patch. On Fri, Apr 01, 2022 at 06:21:53PM +0200, Marek Vasut wrote: > The mode parsing is currently implemented in three steps: > of_get_display_timing() - DT panel-timing to struct display_timing > videomode_from_timing() - struct display_timing to struct videomode >

  1   2   3   >