Public patches but non-public development branch (Re: [PATCH 1/1] drm/amdkfd: Add missing NULL check in svm_range_map_to_gpu)

2022-04-05 Thread Paul Menzel
Dear Christian, Am 05.04.22 um 08:54 schrieb Christian König: Am 05.04.22 um 08:45 schrieb Paul Menzel: Am 04.04.22 um 23:42 schrieb Philip Yang: bo_adev is NULL for system memory mapping to GPU. Fixes: 05fe8eeca92 (drm/amdgpu: fix TLB flushing during eviction) Sorry, where can I find th

Re: [PATCH 06/23] drm/nouveau: stop using dma_resv_excl_fence

2022-04-05 Thread Christian König
Am 04.04.22 um 13:47 schrieb Karol Herbst: On Sun, Apr 3, 2022 at 5:59 PM Christian König wrote: Just a gentle ping to the nouveau guys. Any more comments on this? Otherwise I'm pushing that with Daniels rb. It looks fine, but given that this area broke in the past I will try to do some test

[PATCH 5.17 0186/1126] drm/fb-helper: Mark screen buffers in system memory with FBINFO_VIRTFB

2022-04-05 Thread Greg Kroah-Hartman
From: Thomas Zimmermann commit cd9f7f7ac5932129fe81b4c7559cfcb226ec7c5c upstream. Mark screen buffers in system memory with FBINFO_VIRTFB. Otherwise, fbdev deferred I/O marks mmap'ed areas of system memory with VM_IO. (There's an inverse relationship between the two flags.) For shadow buffers,

Re: (subset) [PATCH] dt-bindings: display: bridge: Drop requirement on input port for DSI devices

2022-04-05 Thread Maxime Ripard
On Wed, 23 Mar 2022 16:48:23 +0100, Maxime Ripard wrote: > MIPI-DSI devices, if they are controlled through the bus itself, have to > be described as a child node of the controller they are attached to. > > Thus, there's no requirement on the controller having an OF-Graph output > port to model th

Re: [PATCH v13 00/13] Add GuC Error Capture Support

2022-04-05 Thread Tvrtko Ursulin
On 23/03/2022 13:19, Tvrtko Ursulin wrote: Hi, On 21/03/2022 16:45, Alan Previn wrote: This series:    1. Enables support of GuC to report error-state-capture   using a list of MMIO registers the driver registers   and GuC will dump, log and notify right before a GuC   triggered

Re: [PATCH 10/23] dma-buf: finally make dma_resv_excl_fence private v2

2022-04-05 Thread Christian König
Am 23.03.22 um 14:36 schrieb Daniel Vetter: On Mon, Mar 21, 2022 at 02:58:43PM +0100, Christian König wrote: Drivers should never touch this directly. v2: fix rebase clash Signed-off-by: Christian König Reviewed-by: Daniel Vetter I guess as soon as we have the rdma ack you can land up to t

Re: [PATCH] drm: bridge: icn6211: Fix DSI-to-DPI PLL configuration

2022-04-05 Thread Maxime Ripard
On Sat, Apr 02, 2022 at 02:41:18AM +0200, Marek Vasut wrote: > The datasheet for this bridge is not available, the PLL behavior has been > inferred from [1] and [2] and by analyzing the DPI pixel clock with scope. > After further testing with other displays and different DSI data lane count, > it t

[PATCH 5.17 0604/1126] drm/dp: Fix OOB read when handling Post Cursor2 register

2022-04-05 Thread Greg Kroah-Hartman
From: Kees Cook [ Upstream commit a2151490cc6c57b368d7974ffd447a8b36ade639 ] The link_status array was not large enough to read the Adjust Request Post Cursor2 register, so remove the common helper function to avoid an OOB read, found with a -Warray-bounds build: drivers/gpu/drm/drm_dp_helper.c

Re: [Intel-gfx] [CI 8/8] drm/i915: Expose client engine utilisation via fdinfo

2022-04-05 Thread Tvrtko Ursulin
On 04/04/2022 16:36, Daniel Vetter wrote: On Mon, Apr 04, 2022 at 10:23:53AM +0100, Tvrtko Ursulin wrote: + Dave and Daniel Guys, are you okay with merging this via drm-intel-gt-next? It is one new file at Documentation/gpu/drm-usage-stats.rst only which is outside i915. It has acks from Chr

[PATCH 5.17 0902/1126] video: fbdev: nvidiafb: Use strscpy() to prevent buffer overflow

2022-04-05 Thread Greg Kroah-Hartman
From: Tim Gardner [ Upstream commit 37a1a2e6eeeb101285cd34e12e48a881524701aa ] Coverity complains of a possible buffer overflow. However, given the 'static' scope of nvidia_setup_i2c_bus() it looks like that can't happen after examiniing the call sites. CID 19036 (#1 of 1): Copy into fixed size

[PATCH 5.17 0966/1126] drm/dp: Fix off-by-one in register cache size

2022-04-05 Thread Greg Kroah-Hartman
From: Kees Cook commit d4da1f27396fb1dde079447a3612f4f512caed07 upstream. The pcon_dsc_dpcd array holds 13 registers (0x92 through 0x9E). Fix the math to calculate the max size. Found from a -Warray-bounds build: drivers/gpu/drm/drm_dp_helper.c: In function 'drm_dp_pcon_dsc_bpp_incr': drivers/g

Re: [PATCH] dt-bindings: display: panel: mipi-dbi-spi: Make width-mm/height-mm mandatory

2022-04-05 Thread Noralf Trønnes
Den 04.04.2022 21.21, skrev Marek Vasut: > Make the width-mm/height-mm panel properties mandatory > to correctly report the panel dimensions to the OS. > > Fixes: 2f3468b82db97 ("dt-bindings: display: add bindings for MIPI DBI > compatible SPI panels") > Signed-off-by: Marek Vasut > Cc: Chris

Re: [PATCH v2 18/19] Revert "fbdev: Prevent probing generic drivers if a FB is already registered"

2022-04-05 Thread Daniel Vetter
On Wed, Feb 09, 2022 at 01:19:26AM +0100, Javier Martinez Canillas wrote: > On 2/8/22 22:08, Daniel Vetter wrote: > > This reverts commit fb561bf9abde49f7e00fdbf9ed2ccf2d86cac8ee. > > > > With > > > > commit 27599aacbaefcbf2af7b06b0029459bbf682000d > > Author: Thomas Zimmermann > > Date: Tue J

Re: [PATCH v2 18/19] Revert "fbdev: Prevent probing generic drivers if a FB is already registered"

2022-04-05 Thread Daniel Vetter
On Tue, Apr 05, 2022 at 10:36:35AM +0200, Daniel Vetter wrote: > On Wed, Feb 09, 2022 at 01:19:26AM +0100, Javier Martinez Canillas wrote: > > On 2/8/22 22:08, Daniel Vetter wrote: > > > This reverts commit fb561bf9abde49f7e00fdbf9ed2ccf2d86cac8ee. > > > > > > With > > > > > > commit 27599aacbaef

[PATCH 5.16 0189/1017] drm/fb-helper: Mark screen buffers in system memory with FBINFO_VIRTFB

2022-04-05 Thread Greg Kroah-Hartman
From: Thomas Zimmermann commit cd9f7f7ac5932129fe81b4c7559cfcb226ec7c5c upstream. Mark screen buffers in system memory with FBINFO_VIRTFB. Otherwise, fbdev deferred I/O marks mmap'ed areas of system memory with VM_IO. (There's an inverse relationship between the two flags.) For shadow buffers,

Re: [PATCH v2 09/19] fbcon: Extract fbcon_open/release helpers

2022-04-05 Thread Daniel Vetter
On Thu, Feb 10, 2022 at 12:46:32PM +0100, Thomas Zimmermann wrote: > Hi > > Am 08.02.22 um 22:08 schrieb Daniel Vetter: > > There's two minor behaviour changes in here: > > - in error paths we now consistently call fb_ops->fb_release > > - fb_release really can't fail (fbmem.c ignores it too) and

Re: [PATCH] fbdev: Fix unregistering of framebuffers without device

2022-04-05 Thread Daniel Vetter
On Mon, Apr 04, 2022 at 09:44:02PM +0200, Thomas Zimmermann wrote: > OF framebuffers do not have an underlying device in the Linux > device hierarchy. Do a regular unregister call instead of hot > unplugging such a non-existing device. Fixes a NULL dereference. > An example error message on ppc64le

Re: [PATCH v9 20/23] drm/rockchip: Make VOP driver optional

2022-04-05 Thread Sascha Hauer
On Sat, Apr 02, 2022 at 09:25:33AM +0800, Andy Yan wrote: > Hi Sascha: > > On 4/1/22 20:55, Sascha Hauer wrote: > > On Thu, Mar 31, 2022 at 07:00:34PM +0800, Andy Yan wrote: > > > Hi: > > > > > > On 3/31/22 16:18, Sascha Hauer wrote: > > > > On Thu, Mar 31, 2022 at 03:20:37PM +0800, Andy Yan wrot

[PATCH] drm/amdkfd: Fix potential NULL pointer dereference

2022-04-05 Thread Grigory Vasilyev
In the amdgpu_amdkfd_get_xgmi_bandwidth_mbytes function, the peer_adev pointer can be NULL and is passed to amdgpu_xgmi_get_num_links. In amdgpu_xgmi_get_num_links, peer_adev pointer is dereferenced without any checks: peer_adev->gmc.xgmi.node_id . Signed-off-by: Grigory Vasilyev --- drivers/gp

[PATCH] drm/amdgpu: Junk code

2022-04-05 Thread Grigory Vasilyev
Variable igp_lane_info always is 0. 0 & any value = 0 and false. In this way, all сonditional statements will false. Therefore, it is not clear what this code does. Signed-off-by: Grigory Vasilyev --- .../gpu/drm/amd/amdgpu/atombios_encoders.c| 21 --- 1 file changed, 21 dele

[PATCH 5.16 0816/1017] video: fbdev: nvidiafb: Use strscpy() to prevent buffer overflow

2022-04-05 Thread Greg Kroah-Hartman
From: Tim Gardner [ Upstream commit 37a1a2e6eeeb101285cd34e12e48a881524701aa ] Coverity complains of a possible buffer overflow. However, given the 'static' scope of nvidia_setup_i2c_bus() it looks like that can't happen after examiniing the call sites. CID 19036 (#1 of 1): Copy into fixed size

Re: [PATCH] dt-bindings: display: panel: mipi-dbi-spi: Make width-mm/height-mm mandatory

2022-04-05 Thread Laurent Pinchart
Hi Marek, Thank you for the patch. On Mon, Apr 04, 2022 at 09:21:05PM +0200, Marek Vasut wrote: > Make the width-mm/height-mm panel properties mandatory > to correctly report the panel dimensions to the OS. > > Fixes: 2f3468b82db97 ("dt-bindings: display: add bindings for MIPI DBI > compatible

[PATCH 5.16 0871/1017] drm/dp: Fix off-by-one in register cache size

2022-04-05 Thread Greg Kroah-Hartman
From: Kees Cook commit d4da1f27396fb1dde079447a3612f4f512caed07 upstream. The pcon_dsc_dpcd array holds 13 registers (0x92 through 0x9E). Fix the math to calculate the max size. Found from a -Warray-bounds build: drivers/gpu/drm/drm_dp_helper.c: In function 'drm_dp_pcon_dsc_bpp_incr': drivers/g

Re: [PATCH v2 18/19] Revert "fbdev: Prevent probing generic drivers if a FB is already registered"

2022-04-05 Thread Javier Martinez Canillas
Hello Daniel, On 4/5/22 10:40, Daniel Vetter wrote: > On Tue, Apr 05, 2022 at 10:36:35AM +0200, Daniel Vetter wrote: >> On Wed, Feb 09, 2022 at 01:19:26AM +0100, Javier Martinez Canillas wrote: >>> On 2/8/22 22:08, Daniel Vetter wrote: This reverts commit fb561bf9abde49f7e00fdbf9ed2ccf2d86cac

Re: [PATCH v2 18/19] Revert "fbdev: Prevent probing generic drivers if a FB is already registered"

2022-04-05 Thread Daniel Vetter
On Tue, 5 Apr 2022 at 11:19, Javier Martinez Canillas wrote: > > Hello Daniel, > > On 4/5/22 10:40, Daniel Vetter wrote: > > On Tue, Apr 05, 2022 at 10:36:35AM +0200, Daniel Vetter wrote: > >> On Wed, Feb 09, 2022 at 01:19:26AM +0100, Javier Martinez Canillas wrote: > >>> On 2/8/22 22:08, Daniel V

Re: [PATCH 23/23] drm/ttm: remove bo->moving

2022-04-05 Thread Christian König
Am 29.03.22 um 18:02 schrieb Daniel Vetter: On Mon, Mar 21, 2022 at 02:58:56PM +0100, Christian König wrote: [SNIP] static unsigned long ttm_bo_io_mem_pfn(struct ttm_buffer_object *bo, diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_resource.c b/drivers/gpu/drm/vmwgfx/vmwgfx_resource.c index f999f

[PATCH 5.15 178/913] drm/fb-helper: Mark screen buffers in system memory with FBINFO_VIRTFB

2022-04-05 Thread Greg Kroah-Hartman
From: Thomas Zimmermann commit cd9f7f7ac5932129fe81b4c7559cfcb226ec7c5c upstream. Mark screen buffers in system memory with FBINFO_VIRTFB. Otherwise, fbdev deferred I/O marks mmap'ed areas of system memory with VM_IO. (There's an inverse relationship between the two flags.) For shadow buffers,

Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support

2022-04-05 Thread Sascha Hauer
On Sat, Apr 02, 2022 at 09:37:17AM +0800, Andy Yan wrote: > Hi Sacha: > > On 4/1/22 20:52, Sascha Hauer wrote: > > -- > > >From cbc03073623a7180243331ac24c3afaf9dec7522 Mon Sep 17 00:00:00 2001 > > From: Sascha Hauer > > Date: Fri, 1 Apr 2022 14:48:49 +0200 > > Subject: [PATCH] fixup! drm: rockch

Re: [PATCH] i2c: at91: use dma safe buffers

2022-04-05 Thread Michael Walle
Am 2022-04-05 11:23, schrieb codrin.ciubota...@microchip.com: On 03.03.2022 18:17, Michael Walle wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe The supplied buffer might be on the stack and we get the following error message: [3.312058]

Re: [PATCH v7 3/9] drm/i915/gt: Optimize the migration and clear loop

2022-04-05 Thread Balasubramani Vivekanandan
On 01.04.2022 18:07, Ramalingam C wrote: > Move the static calculations out of the loops for copy and clear. > > Signed-off-by: Ramalingam C > Reviewed-by: Thomas Hellstrom > --- > drivers/gpu/drm/i915/gt/intel_migrate.c | 40 - > 1 file changed, 19 insertions(+), 21 del

[PATCH 5.15 737/913] video: fbdev: nvidiafb: Use strscpy() to prevent buffer overflow

2022-04-05 Thread Greg Kroah-Hartman
From: Tim Gardner [ Upstream commit 37a1a2e6eeeb101285cd34e12e48a881524701aa ] Coverity complains of a possible buffer overflow. However, given the 'static' scope of nvidia_setup_i2c_bus() it looks like that can't happen after examiniing the call sites. CID 19036 (#1 of 1): Copy into fixed size

Re: [PATCH v2 18/19] Revert "fbdev: Prevent probing generic drivers if a FB is already registered"

2022-04-05 Thread Javier Martinez Canillas
On 4/5/22 11:24, Daniel Vetter wrote: > On Tue, 5 Apr 2022 at 11:19, Javier Martinez Canillas [snip] >> >> This is how I think that work, please let me know if you see something >> wrong in my logic: >> >> 1) A PCI device of OF device is registered for the GPU, this attempt to >>match a regis

[PATCH 5.15 783/913] drm/dp: Fix off-by-one in register cache size

2022-04-05 Thread Greg Kroah-Hartman
From: Kees Cook commit d4da1f27396fb1dde079447a3612f4f512caed07 upstream. The pcon_dsc_dpcd array holds 13 registers (0x92 through 0x9E). Fix the math to calculate the max size. Found from a -Warray-bounds build: drivers/gpu/drm/drm_dp_helper.c: In function 'drm_dp_pcon_dsc_bpp_incr': drivers/g

Re: [PATCH v7 3/9] drm/i915/gt: Optimize the migration and clear loop

2022-04-05 Thread Ramalingam C
On 2022-03-29 at 18:53:42 +0530, Balasubramani Vivekanandan wrote: > On 29.03.2022 00:37, Ramalingam C wrote: > > Move the static calculations out of the loops for copy and clear. > > > > Signed-off-by: Ramalingam C > > Reviewed-by: Thomas Hellström > > --- > > drivers/gpu/drm/i915/gt/intel_mig

Re: [PATCH] drm/msm: use orig_nents to iterate over scatterlist with per-process tables

2022-04-05 Thread Robin Murphy
On 2022-03-28 13:55, Jonathan Marek wrote: This matches the implementation of iommu_map_sgtable() used for the non-per-process page tables path. This works around the dma_map_sgtable() call (used to invalidate cache) overwriting sgt->nents with 1 (which is probably a separate issue). FWIW that

[PATCH 5.10 483/599] video: fbdev: nvidiafb: Use strscpy() to prevent buffer overflow

2022-04-05 Thread Greg Kroah-Hartman
From: Tim Gardner [ Upstream commit 37a1a2e6eeeb101285cd34e12e48a881524701aa ] Coverity complains of a possible buffer overflow. However, given the 'static' scope of nvidia_setup_i2c_bus() it looks like that can't happen after examiniing the call sites. CID 19036 (#1 of 1): Copy into fixed size

Re: [PATCH v2 18/19] Revert "fbdev: Prevent probing generic drivers if a FB is already registered"

2022-04-05 Thread Daniel Vetter
On Tue, 5 Apr 2022 at 11:52, Javier Martinez Canillas wrote: > > On 4/5/22 11:24, Daniel Vetter wrote: > > On Tue, 5 Apr 2022 at 11:19, Javier Martinez Canillas > > [snip] > > >> > >> This is how I think that work, please let me know if you see something > >> wrong in my logic: > >> > >> 1) A PCI

[PATCH] drm/i915: Improve on suspend / resume time with VT-d enabled

2022-04-05 Thread Thomas Hellström
When DMAR / VT-d is enabled, the display engine uses overfetching, presumably to deal with the increased latency. To avoid display engine errors and DMAR faults, as a workaround the GGTT is populated with scatch PTEs when VT-d is enabled. However starting with gen10, Write-combined writing of scrat

Re: [PATCH] i2c: at91: use dma safe buffers

2022-04-05 Thread Michael Walle
Am 2022-04-05 12:02, schrieb codrin.ciubota...@microchip.com: On 05.04.2022 12:38, Michael Walle wrote: Am 2022-04-05 11:23, schrieb codrin.ciubota...@microchip.com: +   if (dev->use_dma) { +   dma_buf = i2c_get_dma_safe_msg_buf(m_start, 1); If you want, you could just dev->bu

Re: [PATCH][RESEND] drm/bridge: ti-sn65dsi83: Check link status register after enabling the bridge

2022-04-05 Thread Laurent Pinchart
Hi Marek, Thank you for the patch. On Sun, Feb 13, 2022 at 03:26:48AM +0100, Marek Vasut wrote: > In rare cases, the bridge may not start up correctly, which usually > leads to no display output. In case this happens, warn about it in > the kernel log. Do you know what this is caused by ? It's a

Re: [PATCH V2 0/3] DSI host and peripheral initialisation ordering

2022-04-05 Thread Dave Stevenson
On Fri, 18 Mar 2022 at 12:25, Dave Stevenson wrote: > > On Fri, 4 Mar 2022 at 15:18, Dave Stevenson > wrote: > > > > Hi All > > A gentle ping on this series. Any comments on the approach? > Thanks. I realise the merge window has just closed and therefore folks have been busy, but no responses on

Re: [PATCH][RESEND] drm/bridge: ti-sn65dsi83: Check link status register after enabling the bridge

2022-04-05 Thread Marek Vasut
On 4/5/22 13:42, Laurent Pinchart wrote: Hi Marek, Hi, Thank you for the patch. On Sun, Feb 13, 2022 at 03:26:48AM +0100, Marek Vasut wrote: In rare cases, the bridge may not start up correctly, which usually leads to no display output. In case this happens, warn about it in the kernel log.

Re: [PATCH][RESEND] drm/bridge: ti-sn65dsi83: Check link status register after enabling the bridge

2022-04-05 Thread Dave Stevenson
Hi Laurent On Tue, 5 Apr 2022 at 12:42, Laurent Pinchart wrote: > > Hi Marek, > > Thank you for the patch. > > On Sun, Feb 13, 2022 at 03:26:48AM +0100, Marek Vasut wrote: > > In rare cases, the bridge may not start up correctly, which usually > > leads to no display output. In case this happens,

Re: [Intel-gfx] [PATCH] drm/i915: Improve on suspend / resume time with VT-d enabled

2022-04-05 Thread Daniel Vetter
On Tue, 5 Apr 2022 at 13:00, Thomas Hellström wrote: > > When DMAR / VT-d is enabled, the display engine uses overfetching, > presumably to deal with the increased latency. To avoid display engine > errors and DMAR faults, as a workaround the GGTT is populated with scatch > PTEs when VT-d is enabl

Re: [PATCH 23/23] drm/ttm: remove bo->moving

2022-04-05 Thread Daniel Vetter
On Tue, 5 Apr 2022 at 11:25, Christian König wrote: > > Am 29.03.22 um 18:02 schrieb Daniel Vetter: > > On Mon, Mar 21, 2022 at 02:58:56PM +0100, Christian König wrote: > > [SNIP] > >> static unsigned long ttm_bo_io_mem_pfn(struct ttm_buffer_object *bo, > >> diff --git a/drivers/gpu/drm/vmwgfx/v

Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-04-05 Thread Dmitry Baryshkov
On Mon, 4 Apr 2022 at 23:53, Doug Anderson wrote: > > Hi, > > On Sat, Apr 2, 2022 at 1:26 PM Dmitry Baryshkov > wrote: > > > > On Sat, 2 Apr 2022 at 20:06, Doug Anderson wrote: > > > > > > Hi, > > > > > > On Sat, Apr 2, 2022 at 3:37 AM Dmitry Baryshkov > > > wrote: > > > > > > > > On 01/04/2022

Re: fbdev: Fix unregistering of framebuffers without device

2022-04-05 Thread Sudip Mukherjee
On Mon, Apr 04, 2022 at 09:44:02PM +0200, Thomas Zimmermann wrote: > OF framebuffers do not have an underlying device in the Linux > device hierarchy. Do a regular unregister call instead of hot > unplugging such a non-existing device. Fixes a NULL dereference. > An example error message on ppc64le

Re: [PATCH][RESEND] drm/bridge: ti-sn65dsi83: Check link status register after enabling the bridge

2022-04-05 Thread Laurent Pinchart
Hi Dave, On Tue, Apr 05, 2022 at 01:00:28PM +0100, Dave Stevenson wrote: > On Tue, 5 Apr 2022 at 12:42, Laurent Pinchart wrote: > > On Sun, Feb 13, 2022 at 03:26:48AM +0100, Marek Vasut wrote: > > > In rare cases, the bridge may not start up correctly, which usually > > > leads to no display outpu

Re: Public patches but non-public development branch (Re: [PATCH 1/1] drm/amdkfd: Add missing NULL check in svm_range_map_to_gpu)

2022-04-05 Thread Alex Deucher
On Tue, Apr 5, 2022 at 3:02 AM Paul Menzel wrote: > > Dear Christian, > > > Am 05.04.22 um 08:54 schrieb Christian König: > > Am 05.04.22 um 08:45 schrieb Paul Menzel: > > >> Am 04.04.22 um 23:42 schrieb Philip Yang: > >>> bo_adev is NULL for system memory mapping to GPU. > >>> > >>> Fixes: 05fe8e

Re: [PATCH] drm/radeon: simplify if-if to if-else

2022-04-05 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Mar 31, 2022 at 11:00 PM Guo Zhengkui wrote: > > Replace `if (!ret)` with `else` for simplification. > > Signed-off-by: Guo Zhengkui > --- > drivers/gpu/drm/radeon/radeon_pm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/dr

Re: [PATCH v2 18/19] Revert "fbdev: Prevent probing generic drivers if a FB is already registered"

2022-04-05 Thread Geert Uytterhoeven
Hi Daniel, On Tue, Apr 5, 2022 at 1:48 PM Daniel Vetter wrote: > On Tue, 5 Apr 2022 at 11:52, Javier Martinez Canillas > wrote: > > On 4/5/22 11:24, Daniel Vetter wrote: > > > On Tue, 5 Apr 2022 at 11:19, Javier Martinez Canillas > > >> This is how I think that work, please let me know if you se

Re: [PATCH][RESEND] drm/bridge: ti-sn65dsi83: Check link status register after enabling the bridge

2022-04-05 Thread Dave Stevenson
On Tue, 5 Apr 2022 at 14:08, Laurent Pinchart wrote: > > Hi Dave, > > On Tue, Apr 05, 2022 at 01:00:28PM +0100, Dave Stevenson wrote: > > On Tue, 5 Apr 2022 at 12:42, Laurent Pinchart wrote: > > > On Sun, Feb 13, 2022 at 03:26:48AM +0100, Marek Vasut wrote: > > > > In rare cases, the bridge may no

Re: [PATCH v2 18/19] Revert "fbdev: Prevent probing generic drivers if a FB is already registered"

2022-04-05 Thread Javier Martinez Canillas
On 4/5/22 12:34, Daniel Vetter wrote: > On Tue, 5 Apr 2022 at 11:52, Javier Martinez Canillas > wrote: [snip] >> >> I believe the correct fix would be for the fbdev core to keep a list of >> the apertures struct that are passed to remove_conflicting_framebuffers(), >> that way it will know what

Re: [PATCH v2] drm/radeon: change si_default_state table from global to static

2022-04-05 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Apr 5, 2022 at 2:04 AM Christian König wrote: > > Am 05.04.22 um 00:57 schrieb Tom Rix: > > Smatch reports these issues > > si_blit_shaders.c:31:11: warning: symbol 'si_default_state' > >was not declared. Should it be static? > > si_blit_shaders.c:253:11: warni

Re: [PATCH v2 18/19] Revert "fbdev: Prevent probing generic drivers if a FB is already registered"

2022-04-05 Thread Greg KH
On Tue, Apr 05, 2022 at 03:24:40PM +0200, Geert Uytterhoeven wrote: > Hi Daniel, > > On Tue, Apr 5, 2022 at 1:48 PM Daniel Vetter wrote: > > On Tue, 5 Apr 2022 at 11:52, Javier Martinez Canillas > > wrote: > > > On 4/5/22 11:24, Daniel Vetter wrote: > > > > On Tue, 5 Apr 2022 at 11:19, Javier Ma

Re: [PATCH v2] media: mediatek: vcodec: Fix v4l2 compliance decoder cmd test fail

2022-04-05 Thread AngeloGioacchino Del Regno
Il 01/04/22 10:13, Yunfei Dong ha scritto: Will return -EINVAL using standard framework api when test stateless decoder with cmd VIDIOC_(TRY)DECODER_CMD. Using another return value to adjust v4l2 compliance test for user driver(GStreamer/Chrome) won't use decoder cmd. Fixes: 8cdc3794b2e3 ("medi

[PATCH v7 0/2] Add inline rotation support for sc7280

2022-04-05 Thread Vinod Polimera
Changes in RFC: - Rebase changes to the latest code base. - Append rotation config variables with v2 and remove unused variables.(Dmitry) - Move pixel_ext setup separately from scaler3 config.(Dmitry) - Add 270 degree rotation to supported rotation list.(Dmitry) Changes in V2: - Remove unused macr

[PATCH v7 2/2] drm/msm/disp/dpu1: add inline rotation support for sc7280

2022-04-05 Thread Vinod Polimera
- Some DPU versions support inline rot90. It is supported only for limited amount of UBWC formats. - There are two versions of inline rotators, v1 (present on sm8250 and sm7250) and v2 (sc7280). These versions differ in the list of supported formats and in the scaler possibilities. Co-developed-by

[PATCH v7 1/2] drm/msm/disp/dpu1: add inline function to validate format support

2022-04-05 Thread Vinod Polimera
Check if the dpu format is supported or not using dpu_find_format. Co-developed-by: Kalyan Thota Signed-off-by: Kalyan Thota Signed-off-by: Vinod Polimera --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h | 22 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 10 +++--- 2

Re: [PATCH][RESEND] drm/bridge: ti-sn65dsi83: Check link status register after enabling the bridge

2022-04-05 Thread Marek Vasut
On 4/5/22 15:25, Dave Stevenson wrote: On Tue, 5 Apr 2022 at 14:08, Laurent Pinchart wrote: Hi Dave, On Tue, Apr 05, 2022 at 01:00:28PM +0100, Dave Stevenson wrote: On Tue, 5 Apr 2022 at 12:42, Laurent Pinchart wrote: On Sun, Feb 13, 2022 at 03:26:48AM +0100, Marek Vasut wrote: In rare cas

Re: [PATCH v7 1/2] drm/msm/disp/dpu1: add inline function to validate format support

2022-04-05 Thread Dmitry Baryshkov
On Tue, 5 Apr 2022 at 16:41, Vinod Polimera wrote: > > Check if the dpu format is supported or not using dpu_find_format. > > Co-developed-by: Kalyan Thota > Signed-off-by: Kalyan Thota > Signed-off-by: Vinod Polimera Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_f

Re: [PATCH v7 2/2] drm/msm/disp/dpu1: add inline rotation support for sc7280

2022-04-05 Thread Dmitry Baryshkov
On Tue, 5 Apr 2022 at 16:41, Vinod Polimera wrote: > > - Some DPU versions support inline rot90. It is supported only for > limited amount of UBWC formats. > - There are two versions of inline rotators, v1 (present on sm8250 and > sm7250) and v2 (sc7280). These versions differ in the list of suppo

Re: [PATCH] drm/amdgpu: Junk code

2022-04-05 Thread Alex Deucher
On Tue, Apr 5, 2022 at 5:07 AM Grigory Vasilyev wrote: > > Variable igp_lane_info always is 0. 0 & any value = 0 and false. > In this way, all сonditional statements will false. > Therefore, it is not clear what this code does. It was leftover from when the code was ported from radeon. The igp l

Re: [PATCH v6 13/14] drm/msm: Update generated headers

2022-04-05 Thread Dmitry Baryshkov
On Mon, 4 Apr 2022 at 19:35, Vinod Koul wrote: > > Update headers from mesa commit: > > commit 28ae397be111c37c6ced397e12d453a7695701bd > Author: Vinod Koul > Date: Fri Apr 1 16:53:04 2022 +0530 > > freedreno/registers: update dsi registers to support dsc > > Display Stream co

Re: [PATCH v6 14/14] drm/msm/dsi: Add support for DSC configuration

2022-04-05 Thread Dmitry Baryshkov
On Mon, 4 Apr 2022 at 19:35, Vinod Koul wrote: > > When DSC is enabled, we need to configure DSI registers accordingly and > configure the respective stream compression registers. > > Add support to calculate the register setting based on DSC params and > timing information and configure these reg

Re: [PATCH 1/3] drm/vmwgfx: Add debugfs entries for ttm placements

2022-04-05 Thread Zack Rusin
On Mon, 2022-04-04 at 17:38 +0200, Daniel Vetter wrote: > On Fri, Apr 01, 2022 at 04:56:00PM -0400, Zack Rusin wrote: > > From: Zack Rusin > > > > Add a few debugfs entries for every used TTM placement that vmwgfx > > is > > using. This allows basic tracking of memory usage inside vmwgfx, > > e.g

Re: Public patches but non-public development branch

2022-04-05 Thread Paul Menzel
Dear Alex, Am 05.04.22 um 15:14 schrieb Alex Deucher: On Tue, Apr 5, 2022 at 3:02 AM Paul Menzel wrote: Am 05.04.22 um 08:54 schrieb Christian König: Am 05.04.22 um 08:45 schrieb Paul Menzel: Am 04.04.22 um 23:42 schrieb Philip Yang: bo_adev is NULL for system memory mapping to GPU. Fi

Re: [PATCH] i2c: at91: use dma safe buffers

2022-04-05 Thread Michael Walle
Am 2022-04-05 15:58, schrieb codrin.ciubota...@microchip.com: On 05.04.2022 14:09, Michael Walle wrote: Am 2022-04-05 12:02, schrieb codrin.ciubota...@microchip.com: On 05.04.2022 12:38, Michael Walle wrote: Am 2022-04-05 11:23, schrieb codrin.ciubota...@microchip.com: +   if (dev->use_dm

Re: [PATCH] fbdev: Fix unregistering of framebuffers without device

2022-04-05 Thread Javier Martinez Canillas
Hello Thomas, On 4/4/22 21:44, Thomas Zimmermann wrote: > OF framebuffers do not have an underlying device in the Linux > device hierarchy. Do a regular unregister call instead of hot > unplugging such a non-existing device. Fixes a NULL dereference. > An example error message on ppc64le is shown

[PATCH] drm/arm/malidp: Stop using iommu_present()

2022-04-05 Thread Robin Murphy
iommu_get_domain_for_dev() is already perfectly happy to return NULL if the given device has no IOMMU. Drop the unnecessary check. Signed-off-by: Robin Murphy --- drivers/gpu/drm/arm/malidp_planes.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/dr

Re: Public patches but non-public development branch

2022-04-05 Thread Alex Deucher
On Tue, Apr 5, 2022 at 10:03 AM Paul Menzel wrote: > > Dear Alex, > > > Am 05.04.22 um 15:14 schrieb Alex Deucher: > > On Tue, Apr 5, 2022 at 3:02 AM Paul Menzel wrote: > > >> Am 05.04.22 um 08:54 schrieb Christian König: > >>> Am 05.04.22 um 08:45 schrieb Paul Menzel: > >> > Am 04.04.22 um 2

[PATCH] drm/mediatek: Stop using iommu_present()

2022-04-05 Thread Robin Murphy
Remove the pointless check. If an IOMMU is providing transparent DMA API ops for any device(s) we care about, the DT code will have enforced the appropriate probe ordering already. Signed-off-by: Robin Murphy --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 4 1 file changed, 4 deletions(-) di

Re: Public patches but non-public development branch

2022-04-05 Thread Paul Menzel
Dear Alex, Am 05.04.22 um 16:13 schrieb Alex Deucher: On Tue, Apr 5, 2022 at 10:03 AM Paul Menzel wrote: Am 05.04.22 um 15:14 schrieb Alex Deucher: On Tue, Apr 5, 2022 at 3:02 AM Paul Menzel wrote: Am 05.04.22 um 08:54 schrieb Christian König: Am 05.04.22 um 08:45 schrieb Paul Menzel:

[PATCH] drm/msm: Stop using iommu_present()

2022-04-05 Thread Robin Murphy
Even if some IOMMU has registered itself on the platform "bus", that doesn't necessarily mean it provides translation for the device we care about. Replace iommu_present() with a more appropriate check. Signed-off-by: Robin Murphy --- drivers/gpu/drm/msm/msm_drv.c | 2 +- 1 file changed, 1 inser

[PATCH] drm/tegra: Stop using iommu_present()

2022-04-05 Thread Robin Murphy
Remove the pointless check. host1x_drm_wants_iommu() cannot return true unless an IOMMU exists for the host1x platform device, which at the moment means the iommu_present() test could never fail. Signed-off-by: Robin Murphy --- drivers/gpu/drm/tegra/drm.c | 2 +- 1 file changed, 1 insertion(+),

Re: [PATCH][RESEND] drm/bridge: ti-sn65dsi83: Check link status register after enabling the bridge

2022-04-05 Thread Dave Stevenson
Hi Marek. On Tue, 5 Apr 2022 at 14:49, Marek Vasut wrote: > > On 4/5/22 15:25, Dave Stevenson wrote: > > On Tue, 5 Apr 2022 at 14:08, Laurent Pinchart > > wrote: > >> > >> Hi Dave, > >> > >> On Tue, Apr 05, 2022 at 01:00:28PM +0100, Dave Stevenson wrote: > >>> On Tue, 5 Apr 2022 at 12:42, Lauren

[PATCH] drm/nouveau/tegra: Stop using iommu_present()

2022-04-05 Thread Robin Murphy
Even if some IOMMU has registered itself on the platform "bus", that doesn't necessarily mean it provides translation for the device we care about. Replace iommu_present() with a more appropriate check. Signed-off-by: Robin Murphy --- drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c | 2 +- 1

Re: AMDGPU: regression on 5.17.1

2022-04-05 Thread Alex Deucher
On Mon, Apr 4, 2022 at 3:39 PM Michele Ballabio wrote: > > On Mon, 4 Apr 2022 13:03:41 -0400 > Alex Deucher wrote: > > > On Sun, Apr 3, 2022 at 10:19 AM Michele Ballabio > > wrote: > > > > > > Hi, > > > I've hit a regression on 5.17.1 (haven't tested 5.17.0, but > > > 5.16-stable didn't

[PATCH] drm/rockchip: Refactor IOMMU initialisation

2022-04-05 Thread Robin Murphy
Defer the IOMMU domain setup until after successfully binding components, so we can figure out IOMMU support directly from the VOP devices themselves, rather than manually inferring it from the DT (which also fails to account for whether the IOMMU driver is actually loaded). Although this is somewh

[PATCH v8 0/9] drm/i915/ttm: Evict and restore of compressed object

2022-04-05 Thread Ramalingam C
On Xe-HP and later devices, we use dedicated compression control state (CCS) stored in local memory for each surface, to support the 3D and media compression formats. The memory required for the CCS of the entire local memory is 1/256 of the local memory size. So before the kernel boot, the requir

[PATCH v8 2/9] drm/i915/gt: Use XY_FAST_COLOR_BLT to clear obj on graphics ver 12+

2022-04-05 Thread Ramalingam C
Use faster XY_FAST_COLOR_BLT cmd on graphics version of 12 and more, for clearing (Zero out) the pages of the newly allocated object. XY_FAST_COLOR_BLT is faster than the older XY_COLOR_BLT. v2: Typo fix at title [Thomas] v3: XY_FAST_COLOR_BLT is used only for FLAT_CCS capable gen12+ Signed-

[PATCH v8 1/9] drm/i915/gt: use engine instance directly for offset

2022-04-05 Thread Ramalingam C
To make it uniform across copy and clear, use the engine offset directly to calculate the offset in the cmd forming for emit_clear. Signed-off-by: Ramalingam C Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/intel_migrate.c | 11 --- 1 file changed, 4 insertions(+), 7 deletion

[PATCH v8 3/9] drm/i915/gt: Optimize the migration and clear loop

2022-04-05 Thread Ramalingam C
Move the static calculations out of the loops for copy and clear. v2: Fix the loss of proper error code on emit_pte Signed-off-by: Ramalingam C Reviewed-by: Thomas Hellstrom (v1) --- drivers/gpu/drm/i915/gt/intel_migrate.c | 34 - 1 file changed, 17 insertions(+), 17

[PATCH v8 5/9] drm/i915/gt: Clear compress metadata for Flat-ccs objects

2022-04-05 Thread Ramalingam C
Xe-HP and latest devices support Flat CCS which reserved a portion of the device memory to store compression metadata, during the clearing of device memory buffer object we also need to clear the associated CCS buffer. XY_CTRL_SURF_COPY_BLT is a BLT cmd used for reading and writing the ccs surface

[PATCH v8 4/9] drm/i915/gt: Pass the -EINVAL when emit_pte doesn't update any PTE

2022-04-05 Thread Ramalingam C
When emit_pte doesn't update any PTE with return value as 0, interpret it as -EINVAL. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/

[PATCH v8 7/9] drm/i915/selftest_migrate: Check CCS meta data clear

2022-04-05 Thread Ramalingam C
Extend the live migrate selftest, to verify the ccs surface clearing during the Flat-CCS capable lmem obj clear. v2: Look at right places for ccs data [Thomas] Signed-off-by: Ramalingam C Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/selftest_migrate.c | 250 ++---

[PATCH v8 8/9] drm/i915/gem: Add extra pages in ttm_tt for ccs data

2022-04-05 Thread Ramalingam C
On Xe-HP and later devices, dedicated compression control state (CCS) stored in local memory is used for each surface, to support the 3D and media compression formats. The memory required for the CCS of the entire local memory is 1/256 of the local memory size. So before the kernel boot, the requi

[PATCH v8 9/9] drm/i915/migrate: Evict and restore the flatccs capable lmem obj

2022-04-05 Thread Ramalingam C
When we are swapping out the local memory obj on flat-ccs capable platform, we need to capture the ccs data too along with main meory and we need to restore it when we are swapping in the content. When lmem object is swapped into a smem obj, smem obj will have the extra pages required to hold the

[PATCH v8 6/9] drm/i915/selftest_migrate: Consider the possible roundup of size

2022-04-05 Thread Ramalingam C
Consider the possible round up happened at obj size alignment to min_page_size during the obj allocation. Signed-off-by: Ramalingam C Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/selftest_migrate.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/selft

Re: [PATCH] drm/format_helper: fix a kernel-doc typo

2022-04-05 Thread Randy Dunlap
On 4/4/22 23:26, Javier Martinez Canillas wrote: > On 4/5/22 08:12, Simon Ser wrote: >> On Monday, April 4th, 2022 at 23:35, Randy Dunlap >> wrote: >> >>> On 4/4/22 09:04, Simon Ser wrote: >>> Both doc patches pushed, thanks. I had to manually edit them because they wouldn't apply cl

Re: [PATCH][RESEND] drm/bridge: ti-sn65dsi83: Check link status register after enabling the bridge

2022-04-05 Thread Marek Vasut
On 4/5/22 16:20, Dave Stevenson wrote: Hi, If we can initialise the DSI host before the bridge for the pre_enable, then all the configuration moves to the atomic_pre_enable and there should be no need to have the delay. I can't 100% guarantee that, but one of the folks on the Pi forums is usin

[PATCH 0/3] Inherit GPU scheduling priority from process nice

2022-04-05 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Current processing landscape seems to be more and more composed of pipelines where computations are done on multiple hardware devices. Furthermore some of the non-CPU devices, like in this case many GPUs supported by the i915 driver, actually support priority based scheduling

[PATCH 2/3] drm/i915: Inherit process nice for context scheduling priority

2022-04-05 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Introduce the concept of context nice value which matches the process nice. We do this by extending the struct i915_sched_attr and add a helper (i915_sched_attr_priority) to be used to convert to effective priority when used by backend code and for priority sorting. Context

[PATCH 1/3] drm/i915: Make some recently added vfuncs use full scheduling attribute

2022-04-05 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Code added in 71ed60112d5d ("drm/i915: Add kick_backend function to i915_sched_engine") and ee242ca704d3 ("drm/i915/guc: Implement GuC priority management") introduced some scheduling related vfuncs which take integer request priority as argument. Make them instead take stru

[PATCH 3/3] drm/i915: Inherit submitter nice when scheduling requests

2022-04-05 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Inherit submitter nice at point of request submission to account for long running processes getting either externally or self re-niced. Nice value will only apply to requests which originate from user contexts and have default context priority. Signed-off-by: Tvrtko Ursulin

Re: [PATCH] drm/format_helper: fix a kernel-doc typo

2022-04-05 Thread Simon Ser
On Tuesday, April 5th, 2022 at 16:39, Randy Dunlap wrote: > On 4/4/22 23:26, Javier Martinez Canillas wrote: > > > On 4/5/22 08:12, Simon Ser wrote: > > > > > On Monday, April 4th, 2022 at 23:35, Randy Dunlap rdun...@infradead.org > > > wrote: > > > > > > > On 4/4/22 09:04, Simon Ser wrote: > >

[PATCH v9 0/9] drm/i915/ttm: Evict and restore of compressed object

2022-04-05 Thread Ramalingam C
On Xe-HP and later devices, we use dedicated compression control state (CCS) stored in local memory for each surface, to support the 3D and media compression formats. The memory required for the CCS of the entire local memory is 1/256 of the local memory size. So before the kernel boot, the requir

[PATCH v9 1/9] drm/i915/gt: use engine instance directly for offset

2022-04-05 Thread Ramalingam C
To make it uniform across copy and clear, use the engine offset directly to calculate the offset in the cmd forming for emit_clear. Signed-off-by: Ramalingam C Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/intel_migrate.c | 11 --- 1 file changed, 4 insertions(+), 7 deletion

[PATCH v9 3/9] drm/i915/gt: Optimize the migration and clear loop

2022-04-05 Thread Ramalingam C
Move the static calculations out of the loops for copy and clear. v2: Fix the loss of proper error code on emit_pte Signed-off-by: Ramalingam C Reviewed-by: Thomas Hellstrom (v1) --- drivers/gpu/drm/i915/gt/intel_migrate.c | 34 - 1 file changed, 17 insertions(+), 17

[PATCH v9 2/9] drm/i915/gt: Use XY_FAST_COLOR_BLT to clear obj on graphics ver 12+

2022-04-05 Thread Ramalingam C
Use faster XY_FAST_COLOR_BLT cmd on graphics version of 12 and more, for clearing (Zero out) the pages of the newly allocated object. XY_FAST_COLOR_BLT is faster than the older XY_COLOR_BLT. v2: Typo fix at title [Thomas] v3: XY_FAST_COLOR_BLT is used only for FLAT_CCS capable gen12+ Signed-

  1   2   3   >