Re: [Linaro-mm-sig] [PATCH next] dma-buf/sync-file: do not allow zero size allocations

2022-03-30 Thread Christian König
That problem is already fixed with patch 21d139d73f77 dma-buf/sync-file: fix logic error in new fence merge code. Am 30.03.22 um 00:14 schrieb Pavel Skripkin: syzbot reported GPF in dma_fence_array_first(), which is caused by dereferencing ZERO_PTR in dma-buf internals. ZERO_PTR was generated

Re: [PATCH 6/8] drm/display: Move HDCP helpers into display-helper module

2022-03-30 Thread Jani Nikula
On Tue, 22 Mar 2022, Thomas Zimmermann wrote: > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c > b/drivers/gpu/drm/bridge/analogix/anx7625.c > index 21f16394012f..0ad78c73af7c 100644 > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > @@ -

Re: [PATCH 3/3] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable qcom wled backlight and link to panel

2022-03-30 Thread Marijn Suijten
On 2022-03-30 12:26:39, Joel Selvaraj wrote: > Xiaomi Poco F1 uses the QCOM WLED driver for backlight control. > Enable and link it to the panel to use it. > > Signed-off-by: Joel Selvaraj > --- > .../arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts | 13 + > 1 file changed, 13 insert

Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support

2022-03-30 Thread Sascha Hauer
Hi Piotr, On Tue, Mar 29, 2022 at 09:31:01AM +0200, Piotr Oniszczuk wrote: > > > > Wiadomość napisana przez Sascha Hauer w dniu > > 28.03.2022, o godz. 17:10: > > > > > > Changes since v8: > > - make hclk_vo a critical clock instead of enabling it in the hdmi driver > > - Fix vop2_setup_laye

[PATCH 3/3] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable qcom wled backlight and link to panel

2022-03-30 Thread Joel Selvaraj
Xiaomi Poco F1 uses the QCOM WLED driver for backlight control. Enable and link it to the panel to use it. Signed-off-by: Joel Selvaraj --- .../arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaom

[PATCH 1/3] drm/panel: nt36672a: add backlight support

2022-03-30 Thread Joel Selvaraj
Add support for backlight. This panel supports backlight control through the QCOM WLED driver in Xiaomi Poco F1 device. Signed-off-by: Joel Selvaraj --- drivers/gpu/drm/panel/panel-novatek-nt36672a.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36

[syzbot] general protection fault in dma_fence_array_first

2022-03-30 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:8515d05bf6bc Add linux-next specific files for 20220328 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=1694e21b70 kernel config: https://syzkaller.appspot.com/x/.config?x=530c68bef4e2b8a8 dashbo

[PATCH 2/3] dt-bindings: display: novatek, nt36672a: add backlight property

2022-03-30 Thread Joel Selvaraj
Add backlight property and update example to include it. Signed-off-by: Joel Selvaraj --- .../devicetree/bindings/display/panel/novatek,nt36672a.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml b/Documentation/

Re: [syzbot] general protection fault in dma_fence_array_first

2022-03-30 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger any issue: Reported-and-tested-by: syzbot+5c943fe38e86d615c...@syzkaller.appspotmail.com Tested on: commit: c2528a0c Add linux-next specific files for 20220329 git tree: linux-next kernel config: http

[PATCH 0/3] drm/panel: nt36672a: add backlight support

2022-03-30 Thread Joel Selvaraj
Joel Selvaraj (3): drm/panel: nt36672a: add backlight support dt-bindings: display: novatek,nt36672a: add backlight property arm64: dts: qcom: sdm845-xiaomi-beryllium: enable qcom wled backlight and link to panel .../bindings/display/panel/novatek,nt36672a.yaml| 2 ++ .../arm64/boo

Re: [PATCH v6 02/12] clk: Introduce Kunit Tests for the framework

2022-03-30 Thread Maxime Ripard
Hi Daniel, On Mon, Mar 28, 2022 at 02:36:25PM -0500, Daniel Latypov wrote: > On Mon, Mar 28, 2022 at 2:57 AM Maxime Ripard wrote: > > On Fri, Mar 25, 2022 at 05:36:25PM -0500, Daniel Latypov wrote: > > > On Mon, Feb 28, 2022 at 4:47 AM Maxime Ripard wrote: > > > > > > > > On Fri, Feb 25, 2022 at

[PATCH 1/1] drm/amdkfd: Create file descriptor after client is added to smi_clients list

2022-03-30 Thread Lee Jones
This ensures userspace cannot prematurely clean-up the client before it is fully initialised which has been proven to cause issues in the past. Cc: Felix Kuehling Cc: Alex Deucher Cc: "Christian König" Cc: "Pan, Xinhui" Cc: David Airlie Cc: Daniel Vetter Cc: amd-...@lists.freedesktop.org Cc:

Re: [PATCH 6/8] drm/display: Move HDCP helpers into display-helper module

2022-03-30 Thread Thomas Zimmermann
Hi Jani Am 30.03.22 um 09:12 schrieb Jani Nikula: On Tue, 22 Mar 2022, Thomas Zimmermann wrote: diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c index 21f16394012f..0ad78c73af7c 100644 --- a/drivers/gpu/drm/bridge/analogix/anx7625.c +++ b/driv

Re: [PATCH 1/8] drm: Put related statements next to each other in Makefile

2022-03-30 Thread Jani Nikula
On Tue, 22 Mar 2022, Thomas Zimmermann wrote: > Give the Makefile a bit more structure by putting rules for core, > helpers, drivers, etc next to each other. If you're up for it, I think it would be time to split these one per line, in alphabetical order, to make the diffs nicer: drm-y := \

Re: [PATCH 1/8] drm: Put related statements next to each other in Makefile

2022-03-30 Thread Javier Martinez Canillas
Hello Thomas, On 3/22/22 20:27, Thomas Zimmermann wrote: > Give the Makefile a bit more structure by putting rules for core, > helpers, drivers, etc next to each other. > > Signed-off-by: Thomas Zimmermann > --- This is a nice cleanup. Reviewed-by: Javier Martinez Canillas -- Best regards,

RE: [PATCH v2] drm/amdgpu: fix that issue that the number of the crtc of the 3250c is not correct

2022-03-30 Thread VURDIGERENATARAJ, CHANDAN
>Hi Chandan, > >This issue we found on the Zork project which uses the kernel 5.4 on. So I >just implemented it on kernel 5.4. >For finding out which is 3250c, I referenced the function which is implemented >from another function. >Below is the part where I found it. > >drivers/gpu/drm/amd/amdgpu

Re: (subset) [PATCH v3] drm: of: Properly try all possible cases for bridge/panel detection

2022-03-30 Thread Maxime Ripard
On Tue, 29 Mar 2022 15:27:32 +0200, Paul Kocialkowski wrote: > While bridge/panel detection was initially relying on the usual > port/ports-based of graph detection, it was recently changed to > perform the lookup on any child node that is not port/ports > instead when such a node is available, wit

Re: [PATCH 3/3] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable qcom wled backlight and link to panel

2022-03-30 Thread Joel Selvaraj
Hi Marijn, On 30/03/22 12:47, Marijn Suijten wrote: > On 2022-03-30 12:26:39, Joel Selvaraj wrote: >> Xiaomi Poco F1 uses the QCOM WLED driver for backlight control. >> Enable and link it to the panel to use it. >> >> Signed-off-by: Joel Selvaraj >> --- >> .../arm64/boot/dts/qcom/sdm845-xiaomi

Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support

2022-03-30 Thread piotro.oniszc...@google.com
> Wiadomość napisana przez Sascha Hauer w dniu > 30.03.2022, o godz. 09:28: > >> >> You can easily reproduce with modetest utility: >> >> modetest -P 43@67:1920x1080@NV12 > > This only sets the overlay, but how did you get something on the screen > initially? > I'm not sure that above co

Re: DSI Bridge switching

2022-03-30 Thread Maxime Ripard
On Tue, Mar 29, 2022 at 07:39:21PM +0530, Jagan Teki wrote: > On Thu, Mar 10, 2022 at 4:05 PM Maxime Ripard wrote: > > > > On Wed, Mar 09, 2022 at 06:45:10PM -0600, Adam Ford wrote: > > > On Wed, Mar 9, 2022 at 1:11 PM Jagan Teki > > > wrote: > > > > > > > > or a Hi All, > > > > > > > > On Thu,

Re: DRM Master ignoring hotplug event during display switching (QT)

2022-03-30 Thread Maxime Ripard
On Tue, Mar 29, 2022 at 11:38:32PM +0530, Jagan Teki wrote: > Hi all, > > I have implemented runtime display switching in the MIPI switch design > where LVDS and HDMI bridges are selected with the help of runtime > GPIO. > > Initial discussion on the same can be found here, > https://www.spinics.

Re: BUG: KASAN: use-after-free in drm_atomic_helper_wait_for_vblanks()

2022-03-30 Thread Maxime Ripard
On Tue, Mar 15, 2022 at 12:53:30AM +0300, Dmitry Osipenko wrote: > On 3/11/22 17:22, Maxime Ripard wrote: > > On Thu, Mar 10, 2022 at 03:33:07AM +0300, Dmitry Osipenko wrote: > >> I was playing/testing SuperTuxKart using VirtIO-GPU driver and spotted a > >> UAF bug in drm_atomic_helper_wait_for_vbl

Re: [PATCH v13 3/6] dt-bindings: display: Add Loongson display controller

2022-03-30 Thread Jiaxun Yang
在2022年3月30日三月 上午4:46,Sui Jingfeng写道: > On 2022/3/29 21:27, Rob Herring wrote: >> On Sun, Mar 27, 2022 at 9:29 PM Sui Jingfeng <15330273...@189.cn> wrote: >>> Add DT bindings and simple usages for Loongson display controller >>> found in LS7A1000 bridge chip and LS2k1000 SoC. >>> >>> Signed-off-b

Re: [PATCH 2/8] drm: Rename dp/ to display/

2022-03-30 Thread Javier Martinez Canillas
On 3/22/22 20:27, Thomas Zimmermann wrote: > Rename dp/ to display/ to account for additional display-related > helpers, such as HDMI. Update all related include statements. No > functional changes. > > Various drivers, such as i915 and amdgpu, use similar naming scheme > by putting code for video

[PATCH] drm: round_up the size to the alignment value

2022-03-30 Thread Arunpravin Paneer Selvam
Round up the size value to the min_page_size and trim the last block to the required size. This solves a bug detected when size is not aligned with the min_page_size. Unigine Heaven has allocation requests for example required pages are 257 and alignment request is 256. To allocate the left over 1

Re: [PATCH v2] drm: add a check to verify the size alignment

2022-03-30 Thread Arunpravin Paneer Selvam
On 29/03/22 4:54 pm, Matthew Auld wrote: > On Tue, 29 Mar 2022 at 12:17, Arunpravin Paneer Selvam > wrote: >> >> >> >> On 23/03/22 1:15 pm, Christian König wrote: >>> Am 23.03.22 um 08:34 schrieb Arunpravin Paneer Selvam: Add a simple check to reject any size not aligned to the min_pa

Re: [PATCH] drm: round_up the size to the alignment value

2022-03-30 Thread Christian König
Am 30.03.22 um 11:04 schrieb Arunpravin Paneer Selvam: Round up the size value to the min_page_size and trim the last block to the required size. This solves a bug detected when size is not aligned with the min_page_size. Unigine Heaven has allocation requests for example required pages are 257

Re: [PATCH] drm: round_up the size to the alignment value

2022-03-30 Thread Arunpravin Paneer Selvam
On 30/03/22 2:37 pm, Christian König wrote: > Am 30.03.22 um 11:04 schrieb Arunpravin Paneer Selvam: >> Round up the size value to the min_page_size and trim the last block to >> the required size. >> >> This solves a bug detected when size is not aligned with the min_page_size. >> Unigine Heave

Re: DRM Master ignoring hotplug event during display switching (QT)

2022-03-30 Thread Jagan Teki
On Wed, Mar 30, 2022 at 2:22 PM Maxime Ripard wrote: > > On Tue, Mar 29, 2022 at 11:38:32PM +0530, Jagan Teki wrote: > > Hi all, > > > > I have implemented runtime display switching in the MIPI switch design > > where LVDS and HDMI bridges are selected with the help of runtime > > GPIO. > > > > In

Re: [PATCH] drm: round_up the size to the alignment value

2022-03-30 Thread Christian König
Am 30.03.22 um 11:20 schrieb Arunpravin Paneer Selvam: On 30/03/22 2:37 pm, Christian König wrote: Am 30.03.22 um 11:04 schrieb Arunpravin Paneer Selvam: Round up the size value to the min_page_size and trim the last block to the required size. This solves a bug detected when size is not alig

Re: [PATCH v2 00/12] iio: buffer-dma: write() and new DMABUF based API

2022-03-30 Thread Daniel Vetter
On Tue, Mar 29, 2022 at 06:16:56PM +0100, Paul Cercueil wrote: > Hi Daniel, > > Le mar., mars 29 2022 at 16:10:44 +0200, Daniel Vetter a > écrit : > > On Tue, Mar 29, 2022 at 10:11:14AM +0100, Paul Cercueil wrote: > > > Hi Daniel, > > > > > > Le mar., mars 29 2022 at 10:33:32 +0200, Daniel Vet

Re: [PATCH v2 12/12] Documentation: iio: Document high-speed DMABUF based API

2022-03-30 Thread Daniel Vetter
On Tue, Mar 29, 2022 at 06:34:58PM +0100, Paul Cercueil wrote: > > > Le mar., mars 29 2022 at 16:07:21 +0200, Daniel Vetter a > écrit : > > On Tue, Mar 29, 2022 at 10:47:23AM +0100, Paul Cercueil wrote: > > > Hi Daniel, > > > > > > Le mar., mars 29 2022 at 10:54:43 +0200, Daniel Vetter > > >

Re: [PATCH 3/8] drm/display: Introduce a DRM display-helper module

2022-03-30 Thread Javier Martinez Canillas
On 3/22/22 20:27, Thomas Zimmermann wrote: > Replace the DP-helper module with a display-helper module. Update > all related Kconfig and Makefile rules. > > Besides the existing code for DisplayPort, the new module will > contain helpers for other video-output standards, such as HDMI. > Drivers wi

Re: [PATCH 2/8] drm: Rename dp/ to display/

2022-03-30 Thread Thomas Zimmermann
Hi Am 30.03.22 um 11:04 schrieb Javier Martinez Canillas: On 3/22/22 20:27, Thomas Zimmermann wrote: Rename dp/ to display/ to account for additional display-related helpers, such as HDMI. Update all related include statements. No functional changes. Various drivers, such as i915 and amdgpu, u

Re: DSI Bridge switching

2022-03-30 Thread Jagan Teki
On Wed, Mar 30, 2022 at 2:20 PM Maxime Ripard wrote: > > On Tue, Mar 29, 2022 at 07:39:21PM +0530, Jagan Teki wrote: > > On Thu, Mar 10, 2022 at 4:05 PM Maxime Ripard wrote: > > > > > > On Wed, Mar 09, 2022 at 06:45:10PM -0600, Adam Ford wrote: > > > > On Wed, Mar 9, 2022 at 1:11 PM Jagan Teki

Re: BUG: KASAN: use-after-free in drm_atomic_helper_wait_for_vblanks()

2022-03-30 Thread Daniel Vetter
On Tue, Mar 15, 2022 at 12:53:30AM +0300, Dmitry Osipenko wrote: > On 3/11/22 17:22, Maxime Ripard wrote: > > Hi Dmitry, > > > > On Thu, Mar 10, 2022 at 03:33:07AM +0300, Dmitry Osipenko wrote: > >> I was playing/testing SuperTuxKart using VirtIO-GPU driver and spotted a > >> UAF bug in drm_atomic

Re: [PATCH] dt-bindings: display: bridge: Drop requirement on input port for DSI devices

2022-03-30 Thread Maxime Ripard
On Thu, Mar 24, 2022 at 04:50:04PM +0200, Laurent Pinchart wrote: > Hi Maxime, > > On Thu, Mar 24, 2022 at 03:23:24PM +0100, Maxime Ripard wrote: > > On Thu, Mar 24, 2022 at 03:43:42PM +0200, Laurent Pinchart wrote: > > > On Thu, Mar 24, 2022 at 09:18:19AM +0100, Maxime Ripard wrote: > > > > On We

Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support

2022-03-30 Thread Sascha Hauer
On Wed, Mar 30, 2022 at 10:41:56AM +0200, piotro.oniszc...@google.com wrote: > > > > Wiadomość napisana przez Sascha Hauer w dniu > > 30.03.2022, o godz. 09:28: > > > >> > >> You can easily reproduce with modetest utility: > >> > >> modetest -P 43@67:1920x1080@NV12 > > > > This only sets th

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-30 Thread Daniel Vetter
On Tue, Mar 29, 2022 at 12:25:55PM -0400, Marek Olšák wrote: > I don't know what iris does, but I would guess that the same problems as > with AMD GPUs apply, making GPUs resets very fragile. iris_batch_check_for_reset -> replace_kernel_ctx -> iris_lost_context_state is I think the main call chai

Re: DRM Master ignoring hotplug event during display switching (QT)

2022-03-30 Thread Daniel Vetter
On Wed, Mar 30, 2022 at 10:52:54AM +0200, Maxime Ripard wrote: > On Tue, Mar 29, 2022 at 11:38:32PM +0530, Jagan Teki wrote: > > Hi all, > > > > I have implemented runtime display switching in the MIPI switch design > > where LVDS and HDMI bridges are selected with the help of runtime > > GPIO. >

Re: [PATCH] dt-bindings: display: bridge: Drop requirement on input port for DSI devices

2022-03-30 Thread Maxime Ripard
Hi Tomi, On Fri, Mar 25, 2022 at 12:42:15PM +0200, Tomi Valkeinen wrote: > On 24/03/2022 16:23, Maxime Ripard wrote: > > On Thu, Mar 24, 2022 at 03:43:42PM +0200, Laurent Pinchart wrote: > > > On Thu, Mar 24, 2022 at 09:18:19AM +0100, Maxime Ripard wrote: > > > > On Wed, Mar 23, 2022 at 10:38:19PM

Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support

2022-03-30 Thread piotro.oniszc...@google.com
> Wiadomość napisana przez Sascha Hauer w dniu > 30.03.2022, o godz. 11:45: > > On Wed, Mar 30, 2022 at 10:41:56AM +0200, piotro.oniszc...@google.com wrote: > > Let me rephrase this: The above sets a plane, but it doesn't set a mode > on the crtc. When my system boots up then the output of m

Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support

2022-03-30 Thread Sascha Hauer
On Wed, Mar 30, 2022 at 12:01:05PM +0200, piotro.oniszc...@google.com wrote: > > > > Wiadomość napisana przez Sascha Hauer w dniu > > 30.03.2022, o godz. 11:45: > > > > On Wed, Mar 30, 2022 at 10:41:56AM +0200, piotro.oniszc...@google.com wrote: > > > > Let me rephrase this: The above sets a

Re: [PATCH 3/8] drm/display: Introduce a DRM display-helper module

2022-03-30 Thread Thomas Zimmermann
Hi Am 30.03.22 um 11:23 schrieb Javier Martinez Canillas: On 3/22/22 20:27, Thomas Zimmermann wrote: Replace the DP-helper module with a display-helper module. Update all related Kconfig and Makefile rules. Besides the existing code for DisplayPort, the new module will contain helpers for othe

Re: [PATCH 7/8] drm/display: Move HDMI helpers into display-helper module

2022-03-30 Thread Jani Nikula
On Tue, 22 Mar 2022, Thomas Zimmermann wrote: > diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h > index 144c495b99c4..e6e9e4557067 100644 > --- a/include/drm/drm_edid.h > +++ b/include/drm/drm_edid.h > @@ -391,33 +391,6 @@ drm_load_edid_firmware(struct drm_connector *connector) > >

Re: [PATCH v2] drm/qxl: fix qxl can't use in arm64

2022-03-30 Thread David Airlie
I'd like to make sure this has no side effects on x86 guests, it probably is safe, but keep an eye for regression reports. Reviewed-by: Dave Airlie Dave. On Wed, Mar 30, 2022 at 8:20 PM Cong Liu wrote: > > any suggestions or extra test I can do now? > > Regards, > Cong > > On 2022/3/25 15:45, C

Re: Allow ttm_buffer_object without resource

2022-03-30 Thread Christian König
Am 29.03.22 um 16:02 schrieb Daniel Vetter: On Tue, Mar 29, 2022 at 01:02:32PM +0200, Christian König wrote: Hi guys, this patch set cleans up the handling of TTM buffer objects quite a bit by allowing to create them without allocating a ttm_resource as well. That's not only cleaner in general

Re: [PATCH 5/9] drm/msm: Drop msm_gem_iova()

2022-03-30 Thread Dmitry Baryshkov
On Wed, 30 Mar 2022 at 02:00, Rob Clark wrote: > > From: Rob Clark > > There was only a single user, which could just as easily stash the iova > when pinning. > > Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/msm_fb.c | 16 ++-- > drivers/gpu

Re: [PATCH 3/9] drm/msm/gem: Split out inuse helper

2022-03-30 Thread Dmitry Baryshkov
On Wed, 30 Mar 2022 at 02:00, Rob Clark wrote: > > From: Rob Clark > > Prep for a following patch. While we are at it, convert a few remaining > WARN_ON()s to GEM_WARN_ON(). Well... GEM_WARN_ON doesn't really look like a 'while we are at it'. It might be better to split it into a separate commi

RX 5500 XT: PCIe link speed stuck at Gen1 2.5GT/s by default

2022-03-30 Thread Bjorn Helgaas
See https://gitlab.freedesktop.org/drm/amd/-/issues/1447 This report was against DRM, but I'm mentioning it here because we've been talking about some link speed init issues lately, and AFAICT the gitlab reports don't show up anywhere in lore. Robert Hancock reported: > I'm using a RX 5500 XT ca

[PATCH AUTOSEL 5.17 14/66] video: fbdev: nvidiafb: Use strscpy() to prevent buffer overflow

2022-03-30 Thread Sasha Levin
From: Tim Gardner [ Upstream commit 37a1a2e6eeeb101285cd34e12e48a881524701aa ] Coverity complains of a possible buffer overflow. However, given the 'static' scope of nvidia_setup_i2c_bus() it looks like that can't happen after examiniing the call sites. CID 19036 (#1 of 1): Copy into fixed size

[PATCH AUTOSEL 5.16 14/59] video: fbdev: nvidiafb: Use strscpy() to prevent buffer overflow

2022-03-30 Thread Sasha Levin
From: Tim Gardner [ Upstream commit 37a1a2e6eeeb101285cd34e12e48a881524701aa ] Coverity complains of a possible buffer overflow. However, given the 'static' scope of nvidia_setup_i2c_bus() it looks like that can't happen after examiniing the call sites. CID 19036 (#1 of 1): Copy into fixed size

[PATCH AUTOSEL 5.15 13/50] video: fbdev: nvidiafb: Use strscpy() to prevent buffer overflow

2022-03-30 Thread Sasha Levin
From: Tim Gardner [ Upstream commit 37a1a2e6eeeb101285cd34e12e48a881524701aa ] Coverity complains of a possible buffer overflow. However, given the 'static' scope of nvidia_setup_i2c_bus() it looks like that can't happen after examiniing the call sites. CID 19036 (#1 of 1): Copy into fixed size

[PATCH AUTOSEL 5.10 06/37] video: fbdev: nvidiafb: Use strscpy() to prevent buffer overflow

2022-03-30 Thread Sasha Levin
From: Tim Gardner [ Upstream commit 37a1a2e6eeeb101285cd34e12e48a881524701aa ] Coverity complains of a possible buffer overflow. However, given the 'static' scope of nvidia_setup_i2c_bus() it looks like that can't happen after examiniing the call sites. CID 19036 (#1 of 1): Copy into fixed size

[PATCH AUTOSEL 5.4 02/25] video: fbdev: nvidiafb: Use strscpy() to prevent buffer overflow

2022-03-30 Thread Sasha Levin
From: Tim Gardner [ Upstream commit 37a1a2e6eeeb101285cd34e12e48a881524701aa ] Coverity complains of a possible buffer overflow. However, given the 'static' scope of nvidia_setup_i2c_bus() it looks like that can't happen after examiniing the call sites. CID 19036 (#1 of 1): Copy into fixed size

[PATCH AUTOSEL 4.19 01/22] video: fbdev: nvidiafb: Use strscpy() to prevent buffer overflow

2022-03-30 Thread Sasha Levin
From: Tim Gardner [ Upstream commit 37a1a2e6eeeb101285cd34e12e48a881524701aa ] Coverity complains of a possible buffer overflow. However, given the 'static' scope of nvidia_setup_i2c_bus() it looks like that can't happen after examiniing the call sites. CID 19036 (#1 of 1): Copy into fixed size

[PATCH AUTOSEL 4.14 01/20] video: fbdev: nvidiafb: Use strscpy() to prevent buffer overflow

2022-03-30 Thread Sasha Levin
From: Tim Gardner [ Upstream commit 37a1a2e6eeeb101285cd34e12e48a881524701aa ] Coverity complains of a possible buffer overflow. However, given the 'static' scope of nvidia_setup_i2c_bus() it looks like that can't happen after examiniing the call sites. CID 19036 (#1 of 1): Copy into fixed size

[PATCH AUTOSEL 4.9 01/17] video: fbdev: nvidiafb: Use strscpy() to prevent buffer overflow

2022-03-30 Thread Sasha Levin
From: Tim Gardner [ Upstream commit 37a1a2e6eeeb101285cd34e12e48a881524701aa ] Coverity complains of a possible buffer overflow. However, given the 'static' scope of nvidia_setup_i2c_bus() it looks like that can't happen after examiniing the call sites. CID 19036 (#1 of 1): Copy into fixed size

[PATCH 0/5] fix missing break in list_or_each_entry

2022-03-30 Thread Xiaomeng Tong
Instead of exiting the loop as expected when an entry is found, the list_for_each_entry() continues until the traversal is complete. It could lead to invalid reference or set 'is_*' flags mistakely. To fix this, when an entry is found, add a break to exit the loop. Xiaomeng Tong (5): gma500: fi

[PATCH 1/5] gma500: fix a missing break in oaktrail_crtc_mode_set

2022-03-30 Thread Xiaomeng Tong
Instead of exiting the loop as expected when an entry is found, the list_for_each_entry() continues until the traversal is complete. It will certainly lead to a invalid reference to list itereator variable 'connector' after the loop pointing an bogus address at an offset from the list head, and cou

[PATCH 2/5] gma500: fix a missing break in cdv_intel_crtc_mode_set

2022-03-30 Thread Xiaomeng Tong
Instead of exiting the loop as expected when an entry is found, the list_for_each_entry() continues until the traversal is complete. It could lead to a invalid reference to 'ddi_select' after the loop, and could lead to multiple 'is_*' flags being set with true mistakely, too. The invalid referenc

[PATCH 3/5] gma500: fix a missing break in psb_intel_crtc_mode_set

2022-03-30 Thread Xiaomeng Tong
Instead of exiting the loop as expected when an entry is found, the list_for_each_entry() continues until the traversal is complete. It could result in multiple 'is_*' flags being set with true mistakely. To fix this, when found the entry, add a break after the switch statement. Fixes: 89c78134cc

[PATCH 4/5] gma500: fix a missing break in cdv_intel_dp_set_m_n

2022-03-30 Thread Xiaomeng Tong
Instead of exiting the loop as expected when an entry is found, the list_for_each_entry() continues until the traversal is complete. It could lead to a invalid reference to 'lane_count/bpp' after the loop. The invalid reference to 'lane_count/bpp' is here: cdv_intel_dp_compute_m_n(bpp, lan

[PATCH 5/5] gma500: fix a missing break in psb_driver_load

2022-03-30 Thread Xiaomeng Tong
Instead of exiting the loop as expected when an entry is found, the list_for_each_entry() continues until the traversal is complete. To avoid potential executing 'ret = gma_backlight_init(dev);' repeatly, add a break after the switch statement. Fixes: 5c49fd3aa0ab0 ("gma500: Add the core DRM files

Re: [PATCH v2] drm/amd/display: don't ignore alpha property on pre-multiplied mode

2022-03-30 Thread Rodrigo Siqueira Jordao
On 2022-03-29 16:18, Melissa Wen wrote: "Pre-multiplied" is the default pixel blend mode for KMS/DRM, as documented in supported_modes of drm_plane_create_blend_mode_property(): https://cgit.freedesktop.org/drm/drm-misc/tree/drivers/gpu/drm/drm_blend.c In this mode, both 'pixel alpha' and 'pl

Re: regression: NULL pointer dereference due to 27599aacbaef ("fbdev: Hot-unplug firmware fb devices on forced removal")

2022-03-30 Thread Thorsten Leemhuis
[TLDR: I'm adding the regression report below to regzbot, the Linux kernel regression tracking bot; all text you find below is compiled from a few templates paragraphs you might have encountered already already from similar mails.] [adding fbdev and dri-devel lists, and the egression mailing list,

Re: [PATCH 0/2] remove DC_FP_* wrappers in dml files

2022-03-30 Thread Rodrigo Siqueira Jordao
On 2022-03-26 16:24, Melissa Wen wrote: From FPU documentation, developers must not use DC_FP_START/END in dml files, but invoke it when calling FPU-associated functions (isolated in dml folder). Therefore, the first patch renames dcn10_validate_bandwidth in dml/calcs to dcn_ for generalizati

Re: [PATCH v9 20/23] drm/rockchip: Make VOP driver optional

2022-03-30 Thread Andy Yan
Hi Sascha: On 3/30/22 14:39, Sascha Hauer wrote: Hi Andy, On Tue, Mar 29, 2022 at 07:56:27PM +0800, Andy Yan wrote: Hi Sascha: On 3/28/22 23:11, Sascha Hauer wrote: With upcoming VOP2 support VOP won't be the only choice anymore, so make the VOP driver optional. Signed-off-by: Sascha Hauer

Re: [Intel-gfx] [RFC v2 2/2] drm/doc/rfc: VM_BIND uapi definition

2022-03-30 Thread Daniel Vetter
On Mon, Mar 07, 2022 at 12:31:46PM -0800, Niranjana Vishwanathapura wrote: > VM_BIND und related uapi definitions > > Signed-off-by: Niranjana Vishwanathapura > --- > Documentation/gpu/rfc/i915_vm_bind.h | 176 +++ Maybe as the top level comment: The point of documenting

Re: [PATCH 01/12] drm/edid: use struct edid * in drm_do_get_edid()

2022-03-30 Thread Ville Syrjälä
On Tue, Mar 29, 2022 at 09:42:08PM +0300, Jani Nikula wrote: > Mixing u8 * and struct edid * is confusing, switch to the latter. > > Cc: Ville Syrjälä > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_edid.c | 31 +++ > 1 file changed, 15 insertions(+), 16 del

Re: [PATCH 2/8] drm: Rename dp/ to display/

2022-03-30 Thread Alex Deucher
On Tue, Mar 22, 2022 at 3:28 PM Thomas Zimmermann wrote: > > Rename dp/ to display/ to account for additional display-related > helpers, such as HDMI. Update all related include statements. No > functional changes. > > Various drivers, such as i915 and amdgpu, use similar naming scheme > by puttin

Re: [PATCH 0/2] remove DC_FP_* wrappers in dml files

2022-03-30 Thread Melissa Wen
On 03/30, Rodrigo Siqueira Jordao wrote: > > > On 2022-03-26 16:24, Melissa Wen wrote: > > From FPU documentation, developers must not use DC_FP_START/END in dml > > files, but invoke it when calling FPU-associated functions (isolated in > > dml folder). Therefore, the first patch renames dcn10_

Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support

2022-03-30 Thread Piotr Oniszczuk
> Wiadomość napisana przez Sascha Hauer w dniu > 30.03.2022, o godz. 12:20: > > Does it change anything if you do a "modetest -s 69@67:1920x1080" before > starting the app? Or if you run "modetest -P 43@67:1920x1080@NV12" > before starting the app? Or other combinations thereof? So i tried f

Re: [PATCH v2] drm/amd/display: don't ignore alpha property on pre-multiplied mode

2022-03-30 Thread Harry Wentland
On 2022-03-30 08:30, Rodrigo Siqueira Jordao wrote: > > > On 2022-03-29 16:18, Melissa Wen wrote: >> "Pre-multiplied" is the default pixel blend mode for KMS/DRM, as >> documented in supported_modes of drm_plane_create_blend_mode_property(): >> https://cgit.freedesktop.org/drm/drm-misc/tree/dr

Re: [PATCH 01/12] drm/edid: use struct edid * in drm_do_get_edid()

2022-03-30 Thread Jani Nikula
On Wed, 30 Mar 2022, Ville Syrjälä wrote: > On Tue, Mar 29, 2022 at 09:42:08PM +0300, Jani Nikula wrote: >> Mixing u8 * and struct edid * is confusing, switch to the latter. >> >> Cc: Ville Syrjälä >> Signed-off-by: Jani Nikula >> --- >> drivers/gpu/drm/drm_edid.c | 31 +++-

Re: [PATCH 01/12] drm/edid: use struct edid * in drm_do_get_edid()

2022-03-30 Thread Ville Syrjälä
On Wed, Mar 30, 2022 at 06:16:17PM +0300, Jani Nikula wrote: > On Wed, 30 Mar 2022, Ville Syrjälä wrote: > > On Tue, Mar 29, 2022 at 09:42:08PM +0300, Jani Nikula wrote: > >> Mixing u8 * and struct edid * is confusing, switch to the latter. > >> > >> Cc: Ville Syrjälä > >> Signed-off-by: Jani Ni

Re: [PATCH] drm/i915/guc: Use iosys_map interface to update lrc_desc

2022-03-30 Thread John Harrison
Sorry, only just seen this patch. Please do not do this! The entire lrc_desc_pool entity is being dropped as part of the update to GuC v70. That's why there was a recent patch set to significantly re-organise how/where it is used. That patch set explicitly said - this is all in preparation fo

[PATCH v6 0/8] Add support for the eDP panel over aux_bus

2022-03-30 Thread Sankeerth Billakanti
This series adds support for generic eDP panel over aux_bus. These changes are dependent on the following series in order: https://patchwork.kernel.org/project/linux-arm-msm/list/?series=620127&state=* https://patchwork.kernel.org/project/linux-arm-msm/list/?series=616587&state=* https://patchwork

[PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-03-30 Thread Sankeerth Billakanti
This patch adds support for generic eDP sink through aux_bus. The eDP/DP controller driver should support aux transactions originating from the panel-edp driver and hence should be initialized and ready. The panel bridge supporting the panel should be ready before the bridge connector is initializ

[PATCH v6 2/8] drm/msm/dp: wait for hpd high before aux transaction

2022-03-30 Thread Sankeerth Billakanti
The source device should ensure the sink is ready before proceeding to read the sink capability or performing any aux transactions. The sink will indicate its readiness by asserting the HPD line. The controller driver needs to wait for the hpd line to be asserted by the sink before performing any a

[PATCH v6 3/8] drm/msm/dp: Support only IRQ_HPD and REPLUG interrupts for eDP

2022-03-30 Thread Sankeerth Billakanti
The panel-edp enables the eDP panel power during probe, get_modes and enable. The eDP connect and disconnect interrupts for the eDP/DP controller are directly dependent on panel power. As eDP display can be assumed as always connected, the controller driver can skip the eDP connect and disconnect i

[PATCH v6 4/8] drm/msm/dp: avoid handling masked interrupts

2022-03-30 Thread Sankeerth Billakanti
The interrupt register will still reflect the connect and disconnect interrupt status without generating an actual HW interrupt. The controller driver should not handle those masked interrupts. Signed-off-by: Sankeerth Billakanti --- drivers/gpu/drm/msm/dp/dp_catalog.c | 5 +++-- 1 file changed,

[PATCH v6 5/8] drm/msm/dp: prevent multiple votes for dp resources

2022-03-30 Thread Sankeerth Billakanti
The aux_bus support with the dp_display driver will enable the dp resources during msm_dp_modeset_init. The host_init has to return early if the core is already initialized to prevent putting an additional vote for the dp controller resources. Signed-off-by: Sankeerth Billakanti --- drivers/gpu/

[PATCH v6 6/8] drm/msm/dp: remove unnecessary delay during boot

2022-03-30 Thread Sankeerth Billakanti
Remove the unnecessary delay in executing the EV_HPD_INIT_SETUP event. Signed-off-by: Sankeerth Billakanti --- drivers/gpu/drm/msm/dp/dp_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index

[PATCH v6 7/8] drm/msm/dp: Support edp/dp without hpd

2022-03-30 Thread Sankeerth Billakanti
Some eDP sinks or platform boards will not support hpd. This patch adds support for those cases. Signed-off-by: Sankeerth Billakanti --- drivers/gpu/drm/msm/dp/dp_catalog.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_catalog.c b

[PATCH v6 8/8] drm/msm/dp: Handle eDP mode_valid differently from dp

2022-03-30 Thread Sankeerth Billakanti
The panel-edp driver modes needs to be validated differently from DP because the link capabilities are not available for EDP by that time. Signed-off-by: Sankeerth Billakanti --- drivers/gpu/drm/msm/dp/dp_display.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/msm/dp/

[PATCH] drm/panel-edp: Fix AUO B133UAN01 panel id

2022-03-30 Thread Matthias Kaehlcke
Two digits are swapped in the AUO B133UAN01 panel id (0x8495 instead of 0x8594). This went initially unnoticed because the panel is still detected, though it is set up with a conservative default timing. Fix the digit swap. Fixes: ec57376fba5a ("drm/panel-edp: Add AUO B133UAN01") Signed-off-by: Ma

Re: [PATCH 01/12] drm/edid: use struct edid * in drm_do_get_edid()

2022-03-30 Thread Jani Nikula
On Wed, 30 Mar 2022, Ville Syrjälä wrote: > On Wed, Mar 30, 2022 at 06:16:17PM +0300, Jani Nikula wrote: >> On Wed, 30 Mar 2022, Ville Syrjälä wrote: >> > On Tue, Mar 29, 2022 at 09:42:08PM +0300, Jani Nikula wrote: >> >> Mixing u8 * and struct edid * is confusing, switch to the latter. >> >> >>

Re: [PATCH 1/1] drm/amdkfd: Create file descriptor after client is added to smi_clients list

2022-03-30 Thread Felix Kuehling
Am 2022-03-30 um 03:51 schrieb Lee Jones: This ensures userspace cannot prematurely clean-up the client before it is fully initialised which has been proven to cause issues in the past. Cc: Felix Kuehling Cc: Alex Deucher Cc: "Christian König" Cc: "Pan, Xinhui" Cc: David Airlie Cc: Daniel

Re: [PATCH] fbdev: defio: fix the pagelist corruption

2022-03-30 Thread Paul Menzel
[Cc: -jay...@intworks.biz as it bounces] Dear Chuansheng, Am 29.03.22 um 01:58 schrieb Liu, Chuansheng: -Original Message- From: Paul Menzel Sent: Monday, March 28, 2022 2:15 PM Am 28.03.22 um 02:58 schrieb Liu, Chuansheng: -Original Message- Sent: Saturday, March 26,

Re: [PATCH 01/12] drm/edid: use struct edid * in drm_do_get_edid()

2022-03-30 Thread Ville Syrjälä
On Wed, Mar 30, 2022 at 07:28:56PM +0300, Jani Nikula wrote: > On Wed, 30 Mar 2022, Ville Syrjälä wrote: > > On Wed, Mar 30, 2022 at 06:16:17PM +0300, Jani Nikula wrote: > >> On Wed, 30 Mar 2022, Ville Syrjälä wrote: > >> > On Tue, Mar 29, 2022 at 09:42:08PM +0300, Jani Nikula wrote: > >> >> Mixi

[PATCH] drm/edid: fix invalid EDID extension block filtering

2022-03-30 Thread Jani Nikula
The invalid EDID block filtering uses the number of valid EDID extensions instead of all EDID extensions for looping the extensions in the copy. This is fine, by coincidence, if all the invalid blocks are at the end of the EDID. However, it's completely broken if there are invalid extensions in the

Re: [Intel-gfx] [PATCH 01/12] drm/edid: use struct edid * in drm_do_get_edid()

2022-03-30 Thread Jani Nikula
On Wed, 30 Mar 2022, Ville Syrjälä wrote: > I'd fix this up front so we don't end having to backport the whole > thing if/when some security scan gizmo stumbles on this. Sent separately [1]. I'll rebase this series on top once that gets merged, but the conflict is trivial so I think the first rou

Re: [PATCH] drm/edid: fix invalid EDID extension block filtering

2022-03-30 Thread Ville Syrjälä
On Wed, Mar 30, 2022 at 08:04:26PM +0300, Jani Nikula wrote: > The invalid EDID block filtering uses the number of valid EDID > extensions instead of all EDID extensions for looping the extensions in > the copy. This is fine, by coincidence, if all the invalid blocks are at > the end of the EDID. H

Re: [PATCH 3/9] drm/msm/gem: Split out inuse helper

2022-03-30 Thread Rob Clark
On Wed, Mar 30, 2022 at 4:32 AM Dmitry Baryshkov wrote: > > On Wed, 30 Mar 2022 at 02:00, Rob Clark wrote: > > > > From: Rob Clark > > > > Prep for a following patch. While we are at it, convert a few remaining > > WARN_ON()s to GEM_WARN_ON(). > > Well... GEM_WARN_ON doesn't really look like a

Re: [PATCH 1/1] drm/amdkfd: Create file descriptor after client is added to smi_clients list

2022-03-30 Thread Lee Jones
On Wed, 30 Mar 2022, Felix Kuehling wrote: > > Am 2022-03-30 um 03:51 schrieb Lee Jones: > > This ensures userspace cannot prematurely clean-up the client before > > it is fully initialised which has been proven to cause issues in the > > past. > > > > Cc: Felix Kuehling > > Cc: Alex Deucher >

[PATCH] drm/msm/gpu: Avoid -Wunused-function with !CONFIG_PM_SLEEP

2022-03-30 Thread Nathan Chancellor
When building with CONFIG_PM=y and CONFIG_PM_SLEEP=n (such as ARCH=riscv allmodconfig), the following warnings/errors occur: drivers/gpu/drm/msm/adreno/adreno_device.c:679:12: error: 'adreno_system_resume' defined but not used [-Werror=unused-function] 679 | static int adreno_system_resume(

Re: [Linaro-mm-sig] [PATCH next] dma-buf/sync-file: do not allow zero size allocations

2022-03-30 Thread Pavel Skripkin
Hi Christian, On 3/30/22 10:09, Christian König wrote: That problem is already fixed with patch 21d139d73f77 dma-buf/sync-file: fix logic error in new fence merge code. Am 30.03.22 um 00:14 schrieb Pavel Skripkin: syzbot reported GPF in dma_fence_array_first(), which is caused by dereferencing

Re: DRM Master ignoring hotplug event during display switching (QT)

2022-03-30 Thread Jagan Teki
On Wed, Mar 30, 2022 at 3:27 PM Daniel Vetter wrote: > > On Wed, Mar 30, 2022 at 10:52:54AM +0200, Maxime Ripard wrote: > > On Tue, Mar 29, 2022 at 11:38:32PM +0530, Jagan Teki wrote: > > > Hi all, > > > > > > I have implemented runtime display switching in the MIPI switch design > > > where LVDS

[PATCH 3/4] drm: ssd130x: Support page addressing mode

2022-03-30 Thread Chen-Yu Tsai
From: Chen-Yu Tsai On the SINO WEALTH SH1106, which is mostly compatible with the SSD1306, only the basic page addressing mode is supported. This addressing mode is not as easy to use compared to the currently supported horizontal addressing mode, as the page address has to be set prior to writin

  1   2   >