[PATCH 1/2] dma-buf/sync-file: fix logic error in new fence merge code

2022-03-29 Thread Christian König
When the array is empty because everything is signaled we can't use add_fence() to add something because that would filter the signaled fence again. Signed-off-by: Christian König Fixes: 519f490db07e ("dma-buf/sync-file: fix warning about fence containers") --- drivers/dma-buf/sync_file.c | 2 +-

[PATCH 2/2] dma-buf: handle empty dma_fence_arrays gracefully

2022-03-29 Thread Christian König
A bug inside the new sync-file merge code created empty dma_fence_array instances. Warn about that and handle those without crashing. Signed-off-by: Christian König --- drivers/dma-buf/dma-fence-array.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/dma-buf/dma-fence-array.c

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf/sync-file: fix logic error in new fence merge code

2022-03-29 Thread Thomas Hellström
For the series, Reviewed-by: Thomas Hellström On 3/29/22 09:00, Christian König wrote: When the array is empty because everything is signaled we can't use add_fence() to add something because that would filter the signaled fence again. Signed-off-by: Christian König Fixes: 519f490db07e ("dm

Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support

2022-03-29 Thread Piotr Oniszczuk
> Wiadomość napisana przez Sascha Hauer w dniu > 28.03.2022, o godz. 17:10: > > > Changes since v8: > - make hclk_vo a critical clock instead of enabling it in the hdmi driver > - Fix vop2_setup_layer_mixer(), reported by Andy Yan > - Limit planes possible_crtcs to actually existing crtcs >

Re: [PATCH v2 02/12] iio: buffer-dma: Enable buffer write support

2022-03-29 Thread Nuno Sá
On Mon, 2022-03-28 at 19:39 +0100, Paul Cercueil wrote: > Hi Jonathan, > > Le lun., mars 28 2022 at 18:24:09 +0100, Jonathan Cameron > a écrit : > > On Mon,  7 Feb 2022 12:59:23 + > > Paul Cercueil wrote: > > > > >  Adding write support to the buffer-dma code is easy - the > > > write() >

Re: [PATCH v4 00/11] drm/bridge: tc358767: Add DSI-to-DPI mode support

2022-03-29 Thread Lucas Stach
Hi Marek, Am Montag, dem 28.03.2022 um 23:43 +0200 schrieb Marek Vasut: > The TC358767/TC358867/TC9595 are all capable of operating in multiple > modes, DPI-to-(e)DP, DSI-to-(e)DP, DSI-to-DPI. Clean up the driver, > switch to atomic ops, and add support for the DSI-to-DPI mode in > addition to alr

Re: [Intel-gfx] [PATCH] drm/i915: avoid concurrent writes to aux_inv

2022-03-29 Thread Tvrtko Ursulin
On 28/03/2022 18:16, fei.y...@intel.com wrote: From: Fei Yang GPU hangs have been observed when multiple engines write to the same aux_inv register at the same time. To avoid this each engine should only invalidate its own auxiliary table. The function gen12_emit_flush_xcs() currently invalid

Re: [PATCH v4 00/11] drm/bridge: tc358767: Add DSI-to-DPI mode support

2022-03-29 Thread Marek Vasut
On 3/29/22 09:47, Lucas Stach wrote: Hi Marek, Hi, Am Montag, dem 28.03.2022 um 23:43 +0200 schrieb Marek Vasut: The TC358767/TC358867/TC9595 are all capable of operating in multiple modes, DPI-to-(e)DP, DSI-to-(e)DP, DSI-to-DPI. Clean up the driver, switch to atomic ops, and add support for

[PATCH] drm/dp_mst: Lower down debug info level when receive NAK

2022-03-29 Thread Wayne Lin
[Why] It's reasonable that we receive NAK while doing DP_REMOTE_DPCD_READ. Downstream device might reply NAK with the reason and source should react accordingly. e.g. 1. When downstream device can't handle corresponding message in time, it then replies NAK as reason been set as DEFER. 2. When mult

Re: [Intel-gfx] [PATCH v7 9/9] drm/i915/migrate: Evict and restore the flatccs capable lmem obj

2022-03-29 Thread Thomas Hellström
On 3/28/22 21:07, Ramalingam C wrote: When we are swapping out the local memory obj on flat-ccs capable platform, we need to capture the ccs data too along with main meory and we need to restore it when we are swapping in the content. When lmem object is swapped into a smem obj, smem obj will

Re: [PATCH v2 00/12] iio: buffer-dma: write() and new DMABUF based API

2022-03-29 Thread Daniel Vetter
On Tue, Feb 15, 2022 at 05:43:35PM +, Paul Cercueil wrote: > Hi Jonathan, > > Le dim., févr. 13 2022 at 18:46:16 +, Jonathan Cameron > a écrit : > > On Mon, 7 Feb 2022 12:59:21 + > > Paul Cercueil wrote: > > > > > Hi Jonathan, > > > > > > This is the V2 of my patchset that intro

Re: [RFC v4 4/8] dmabuf: heaps: export system_heap buffers with GPU cgroup charging

2022-03-29 Thread Daniel Vetter
On Mon, Mar 28, 2022 at 11:28:24AM -0700, T.J. Mercier wrote: > On Mon, Mar 28, 2022 at 7:36 AM Daniel Vetter wrote: > > > > On Mon, Mar 28, 2022 at 03:59:43AM +, T.J. Mercier wrote: > > > From: Hridya Valsaraju > > > > > > All DMA heaps now register a new GPU cgroup device upon creation, and

Re: [PATCH next, v2] kernel: Add 1 ms delay to init handler to fix s3 resume hang

2022-03-29 Thread Daniel Vetter
On Tue, Mar 29, 2022 at 08:20:24AM +0200, Christian König wrote: > Am 29.03.22 um 05:05 schrieb Zhenneng Li: > > This is a workaround for s3 resume hang for r7 340(amdgpu). > > When we test s3 with r7 340 on arm64 platform, graphics card will hang up, > > the error message are as follows: > > Mar

Re: [PATCH 1/2] dma-buf/sync-file: fix logic error in new fence merge code

2022-03-29 Thread Daniel Vetter
On Tue, Mar 29, 2022 at 09:00:00AM +0200, Christian König wrote: > When the array is empty because everything is signaled we can't use > add_fence() to add something because that would filter the signaled > fence again. > > Signed-off-by: Christian König > Fixes: 519f490db07e ("dma-buf/sync-file:

Re: [PATCH 2/2] dma-buf: handle empty dma_fence_arrays gracefully

2022-03-29 Thread Daniel Vetter
On Tue, Mar 29, 2022 at 09:00:01AM +0200, Christian König wrote: > A bug inside the new sync-file merge code created empty dma_fence_array > instances. > > Warn about that and handle those without crashing. > > Signed-off-by: Christian König > --- > drivers/dma-buf/dma-fence-array.c | 5 +

Re: [PATCH 2/2] dma-buf: handle empty dma_fence_arrays gracefully

2022-03-29 Thread Daniel Vetter
On Tue, Mar 29, 2022 at 10:48:10AM +0200, Daniel Vetter wrote: > On Tue, Mar 29, 2022 at 09:00:01AM +0200, Christian König wrote: > > A bug inside the new sync-file merge code created empty dma_fence_array > > instances. > > > > Warn about that and handle those without crashing. > > > > Signed-o

Re: [PATCH 1/2] dma-buf/sync-file: fix logic error in new fence merge code

2022-03-29 Thread Christian König
Am 29.03.22 um 10:46 schrieb Daniel Vetter: On Tue, Mar 29, 2022 at 09:00:00AM +0200, Christian König wrote: When the array is empty because everything is signaled we can't use add_fence() to add something because that would filter the signaled fence again. Signed-off-by: Christian König Fixes

[PATCH v5 00/11] drm/bridge: tc358767: Add DSI-to-DPI mode support

2022-03-29 Thread Marek Vasut
The TC358767/TC358867/TC9595 are all capable of operating in multiple modes, DPI-to-(e)DP, DSI-to-(e)DP, DSI-to-DPI. Clean up the driver, switch to atomic ops, and add support for the DSI-to-DPI mode in addition to already supported DPI-to-(e)DP mode. Cc: Jonas Karlman Cc: Laurent Pinchart Cc: M

[PATCH v5 02/11] dt-bindings: display: bridge: tc358867: Document DSI data-lanes property

2022-03-29 Thread Marek Vasut
It is necessary to specify the number of connected/used DSI data lanes when using the DSI input port of this bridge. Document the 'data-lanes' property of the DSI input port. Reviewed-by: Rob Herring Acked-by: Lucas Stach Tested-by: Lucas Stach # In both DPI to eDP and DSI to DPI mode. Signed-

[PATCH v5 01/11] dt-bindings: display: bridge: tc358867: Document DPI output support

2022-03-29 Thread Marek Vasut
The TC358767/TC358867/TC9595 are all capable of operating in multiple modes, DPI-to-(e)DP, DSI-to-(e)DP, DSI-to-DPI. Document support for the DPI output port, which can now be connected both as input and output. Acked-by: Rob Herring Reviewed-by: Lucas Stach Tested-by: Lucas Stach # In both DPI

[PATCH v5 04/11] drm/bridge: tc358767: Convert to atomic ops

2022-03-29 Thread Marek Vasut
Use the atomic version of the enable/disable operations to continue the transition to the atomic API. This will be needed to access the mode from the atomic state. Reviewed-by: Lucas Stach Tested-by: Lucas Stach # In both DPI to eDP and DSI to DPI mode. Signed-off-by: Marek Vasut Cc: Jonas Kar

[PATCH v5 07/11] drm/bridge: tc358767: Wrap (e)DP aux I2C registration into tc_aux_link_setup()

2022-03-29 Thread Marek Vasut
This bit of code is (e)DP and aux I2C link specific, move it into tc_aux_link_setup() to permit cleaner addition of DSI-to-DPI mode. No functional change. Reviewed-by: Lucas Stach Tested-by: Lucas Stach # In both DPI to eDP and DSI to DPI mode. Signed-off-by: Marek Vasut Cc: Jonas Karlman Cc:

[PATCH v5 05/11] drm/bridge: tc358767: Implement atomic_check callback

2022-03-29 Thread Marek Vasut
Implement .atomic_check callback which prevents user space from setting unsupported mode. The tc_edp_common_atomic_check() variant is already prepared for DSI-to-DPI mode addition, which has different frequency limits. Reviewed-by: Lucas Stach Tested-by: Lucas Stach # In both DPI to eDP and DSI

[PATCH v5 08/11] drm/bridge: tc358767: Move bridge ops setup into tc_probe_edp_bridge_endpoint()

2022-03-29 Thread Marek Vasut
The bridge ops are specific to the bridge configuration, move them into tc_probe_edp_bridge_endpoint() to permit cleaner addition of DSI-to-DPI mode. No functional change. Reviewed-by: Lucas Stach Tested-by: Lucas Stach # In both DPI to eDP and DSI to DPI mode. Signed-off-by: Marek Vasut Cc: J

[PATCH v5 09/11] drm/bridge: tc358767: Detect bridge mode from connected endpoints in DT

2022-03-29 Thread Marek Vasut
The TC358767/TC358867/TC9595 are all capable of operating in multiple modes, DPI-to-(e)DP, DSI-to-(e)DP, DSI-to-DPI. Only the first mode is currently supported. It is possible to find out the mode in which the bridge should be operated by testing connected endpoints in DT. Port allocation: port@0

[PATCH v5 06/11] drm/bridge: tc358767: Move (e)DP bridge endpoint parsing into dedicated function

2022-03-29 Thread Marek Vasut
The TC358767/TC358867/TC9595 are all capable of operating in multiple modes, DPI-to-(e)DP, DSI-to-(e)DP, DSI-to-DPI. Only the first mode is currently supported. In order to support the rest of the modes without making the tc_probe() overly long, split the bridge endpoint parsing into dedicated func

[PATCH v5 11/11] drm/bridge: tc358767: Add DSI-to-DPI mode support

2022-03-29 Thread Marek Vasut
The TC358767/TC358867/TC9595 are all capable of operating in multiple modes, DPI-to-(e)DP, DSI-to-(e)DP, DSI-to-DPI. Add support for the DSI-to-DPI mode. This requires skipping most of the (e)DP initialization code, which is currently a large part of this driver, hence it is better to have far sim

[PATCH v5 10/11] drm/bridge: tc358767: Split tc_set_video_mode() into common and (e)DP part

2022-03-29 Thread Marek Vasut
The tc_set_video_mode() sets up both common and (e)DP video mode settings of the bridge chip. Split the function into tc_set_common_video_mode() to set the common settings and tc_set_edp_video_mode() to set the (e)DP specific settings. No functional change. Reviewed-by: Lucas Stach Tested-by: Luc

[PATCH v5 03/11] drm/bridge: tc358767: Change tc_ prefix to tc_edp_ for (e)DP specific functions

2022-03-29 Thread Marek Vasut
These functions are specific to (e)DP output initialization and operation, add specific tc_edp_ prefix to those functions to discern them from DPI output functions that will be added later in this series. No functional change. Reviewed-by: Lucas Stach Tested-by: Lucas Stach # In both DPI to eDP

Re: [PATCH v2 12/12] Documentation: iio: Document high-speed DMABUF based API

2022-03-29 Thread Daniel Vetter
On Mon, Feb 07, 2022 at 01:01:40PM +, Paul Cercueil wrote: > Document the new DMABUF based API. > > v2: - Explicitly state that the new interface is optional and is > not implemented by all drivers. > - The IOCTLs can now only be called on the buffer FD returned by > IIO_BUFFER

Re: [PATCH 1/2] dma-buf/sync-file: fix logic error in new fence merge code

2022-03-29 Thread Das, Nirmoy
I finally managed to find a machine and tested this series. If it is not too late The series is Tested-by: Nirmoy Das On 3/29/2022 9:00 AM, Christian König wrote: When the array is empty because everything is signaled we can't use add_fence() to add something because that would filter the sig

drm/amdgpu: Disable ABM when AC mode

2022-03-29 Thread Ryan Lin
Disable ABM feature when the system is running on AC mode to get the more perfect contrast of the display. v2: remove "UPSTREAM" from the subject. Signed-off-by: Ryan Lin --- drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 4 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 1 + drivers/gp

[CI v2] drm/i915: Move intel_vtd_active and run_as_guest to i915_utils

2022-03-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Continuation of the effort to declutter i915_drv.h. Also, component specific helpers which consult the iommu/virtualization helpers moved to respective component source/header files as appropriate. v2: * s/dev_priv/i915/ in intel_scanout_needs_vtd_wa. (Lucas) Signed-off-b

Re: [PATCH v2 00/12] iio: buffer-dma: write() and new DMABUF based API

2022-03-29 Thread Paul Cercueil
Hi Daniel, Le mar., mars 29 2022 at 10:33:32 +0200, Daniel Vetter a écrit : On Tue, Feb 15, 2022 at 05:43:35PM +, Paul Cercueil wrote: Hi Jonathan, Le dim., févr. 13 2022 at 18:46:16 +, Jonathan Cameron a écrit : > On Mon, 7 Feb 2022 12:59:21 + > Paul Cercueil wrote: >

[PATCH] video: fbdev: use if else instead

2022-03-29 Thread Qing Wang
From: Wang Qing use if and else instead of consequent if(A) and if (!A) Signed-off-by: Wang Qing --- drivers/video/fbdev/pxafb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) mode change 100644 => 100755 drivers/video/fbdev/pxafb.c diff --git a/drivers/video/fbdev/pxafb.c b/drive

Re: [PATCH] gma500: fix an incorrect NULL check on list iterator

2022-03-29 Thread Patrik Jakobsson
On Sun, Mar 27, 2022 at 7:20 AM Xiaomeng Tong wrote: > > The bug is here: > return crtc; > > The list iterator value 'crtc' will *always* be set and non-NULL by > list_for_each_entry(), so it is incorrect to assume that the iterator > value will be NULL if the list is empty or no element i

Re: [PATCH v2 12/12] Documentation: iio: Document high-speed DMABUF based API

2022-03-29 Thread Paul Cercueil
Hi Daniel, Le mar., mars 29 2022 at 10:54:43 +0200, Daniel Vetter a écrit : On Mon, Feb 07, 2022 at 01:01:40PM +, Paul Cercueil wrote: Document the new DMABUF based API. v2: - Explicitly state that the new interface is optional and is not implemented by all drivers. - The I

[PATCH] drm: msm: add null pointer check

2022-03-29 Thread cgel . zte
From: Lv Ruyi kzalloc is a memory allocation function which can return NULL when some internal memory errors happen. Add null pointer check to avoid dereferencing null pointer. Reported-by: Zeal Robot Signed-off-by: Lv Ruyi --- drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c | 2 ++ 1 file

[PATCH] drm: tegra: fix memory leak in error handling path

2022-03-29 Thread cgel . zte
From: Lv Ruyi Before leave the nvdec_load_firmware, we shuold free virt which is alloced by dma_alloc_coherent, so change "return err" to "goto cleanup". Reported-by: Zeal Robot Signed-off-by: Lv Ruyi --- drivers/gpu/drm/tegra/nvdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

Re: [PATCH v9 01/22] dt-bindings: mediatek,dpi: Add DP_INTF compatible

2022-03-29 Thread Matthias Brugger
On 28/03/2022 00:39, Guillaume Ranquet wrote: From: Markus Schneider-Pargmann DP_INTF is similar to DPI but does not have the exact same feature set or register layouts. DP_INTF is the sink of the display pipeline that is connected to the DisplayPort controller and encoder unit. It takes th

Re: [PATCH] drm: tegra: fix memory leak in error handling path

2022-03-29 Thread Jon Hunter
On 29/03/2022 11:37, cgel@gmail.com wrote: From: Lv Ruyi Before leave the nvdec_load_firmware, we shuold free virt which is alloced s/shuold/should s/alloced/allocated by dma_alloc_coherent, so change "return err" to "goto cleanup". Reported-by: Zeal Robot Signed-off-by: Lv Ruyi --

Re: [PATCH] dispnv50: atom: fix an incorrect NULL check on list iterator

2022-03-29 Thread Emil Velikov
On Mon, 28 Mar 2022 at 03:09, Xiaomeng Tong wrote: > > on Sun, 27 Mar 2022 16:59:28 +0100, Emil Velikov wrote: > > On Sun, 27 Mar 2022 at 08:39, Xiaomeng Tong wrote: > > > > > > The bug is here: > > > return encoder; > > > > > > The list iterator value 'encoder' will *always* be set and n

Allow ttm_buffer_object without resource

2022-03-29 Thread Christian König
Hi guys, this patch set cleans up the handling of TTM buffer objects quite a bit by allowing to create them without allocating a ttm_resource as well. That's not only cleaner in general, but also a necessary prerequisite for quite a number of related work. Please review and comment, Christian.

[PATCH 03/11] drm/vram-helper: switch over to ttm_bo_init_reserved

2022-03-29 Thread Christian König
Use the new interface instead. Signed-off-by: Christian König --- drivers/gpu/drm/drm_gem_vram_helper.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_helper.c index 3f00192215d1..0bd46a138ded 1

[PATCH 02/11] drm/nouveau: switch over to ttm_bo_init_reserved

2022-03-29 Thread Christian König
Use the new interface instead. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_bo.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c index fa73fe57f97b..ceac591a7c01 1006

[PATCH 05/11] drm/ttm: drop ttm_bo_init

2022-03-29 Thread Christian König
Not used any more. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 26 - include/drm/ttm/ttm_bo_api.h | 44 2 files changed, 70 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index

[PATCH 01/11] drm/radeon: switch over to ttm_bo_init_reserved

2022-03-29 Thread Christian König
Use the new interface instead. Signed-off-by: Christian König --- drivers/gpu/drm/radeon/radeon_object.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c index b827b87aefe2..7af

[PATCH 04/11] drm/ttm: move default BO destructor into VMWGFX

2022-03-29 Thread Christian König
It's the only driver using this. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 9 + drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 11 ++- 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c

[PATCH 06/11] drm/ttm: rename and cleanup ttm_bo_init_reserved

2022-03-29 Thread Christian König
Rename ttm_bo_init_reserved to ttm_bo_init_validate since that better matches what the function is actually doing. Remove the unused size parameter, move the function's kerneldoc to the implementation and cleanup the whole error handling. Signed-off-by: Christian König --- drivers/gpu/drm/amd/a

[PATCH 08/11] drm/nouveau: audit bo->resource usage

2022-03-29 Thread Christian König
Make sure we can at least move and release BOs without backing store. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_bo.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c index 4

[PATCH 10/11] drm/ttm: stop allocating dummy resources during BO creation

2022-03-29 Thread Christian König
That should not be necessary any more when drivers should at least be able to handle the move without a resource. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c

[PATCH 09/11] drm/ttm: audit bo->resource usage

2022-03-29 Thread Christian König
Allow BOs to exist without backing store. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index b7e259245f82..bd001fdde9fb 100644 --- a

[PATCH 07/11] drm/amdgpu: audit bo->resource usage

2022-03-29 Thread Christian König
Make sure we can at least move and release BOs without backing store. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgp

[PATCH 11/11] drm/ttm: stop allocating a dummy resource for pipelined gutting

2022-03-29 Thread Christian König
That should not be necessary any more when drivers should at least be able to handle a move without a resource. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo_util.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo_uti

Re: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu

2022-03-29 Thread Arunpravin Paneer Selvam
> -Original Message- > From: amd-gfx On Behalf Of Christian > König > Sent: Wednesday, March 23, 2022 1:07 PM > To: Paneer Selvam, Arunpravin ; > intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > amd-...@lists.freedesktop.org > Cc: Deucher, Alexander ; matthew.a...@i

Re: [PATCH v2] drm: add a check to verify the size alignment

2022-03-29 Thread Arunpravin Paneer Selvam
On 23/03/22 1:15 pm, Christian König wrote: > Am 23.03.22 um 08:34 schrieb Arunpravin Paneer Selvam: >> Add a simple check to reject any size not aligned to the >> min_page_size. >> >> handle instances when size is not aligned with the min_page_size. >> Unigine Heaven has allocation requests for

Re: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu

2022-03-29 Thread Christian König
Am 29.03.22 um 13:19 schrieb Arunpravin Paneer Selvam: [SNIP] + pages_left = node->base.num_pages; i = 0; - spin_lock(&mgr->lock); while (pages_left) { - uint32_t alignment = tbo->page_alignment; + if (tbo->page_alignment) +

Re: [PATCH v2] drm: add a check to verify the size alignment

2022-03-29 Thread Matthew Auld
On Tue, 29 Mar 2022 at 12:17, Arunpravin Paneer Selvam wrote: > > > > On 23/03/22 1:15 pm, Christian König wrote: > > Am 23.03.22 um 08:34 schrieb Arunpravin Paneer Selvam: > >> Add a simple check to reject any size not aligned to the > >> min_page_size. > >> > >> handle instances when size is not

Re: [PATCH v2] drm: add a check to verify the size alignment

2022-03-29 Thread Christian König
Am 29.03.22 um 13:28 schrieb Arunpravin Paneer Selvam: On 23/03/22 1:15 pm, Christian König wrote: Am 23.03.22 um 08:34 schrieb Arunpravin Paneer Selvam: Add a simple check to reject any size not aligned to the min_page_size. handle instances when size is not aligned with the min_page_size. Un

Re: [PATCH] drm/v3d: Use kvcalloc

2022-03-29 Thread Harshit Mogalapalli
On 28/03/22 5:55 pm, Melissa Wen wrote: On 03/12, Harshit Mogalapalli wrote: kvcalloc is same as kvmalloc_array + __GFP_ZERO. Signed-off-by: Harshit Mogalapalli --- drivers/gpu/drm/v3d/v3d_gem.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/v3d/v3d

Re: [PATCH v9 20/23] drm/rockchip: Make VOP driver optional

2022-03-29 Thread Andy Yan
Hi Sascha: On 3/28/22 23:11, Sascha Hauer wrote: With upcoming VOP2 support VOP won't be the only choice anymore, so make the VOP driver optional. Signed-off-by: Sascha Hauer --- drivers/gpu/drm/rockchip/Kconfig| 8 drivers/gpu/drm/rockchip/Makefile | 3 ++-

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-29 Thread Christian König
My main question is what does the iris driver better than radeonsi when the client doesn't support the robustness extension? From Daniels description it sounds like they have at least a partial recovery mechanism in place. Apart from that I completely agree to what you said below. Christian.

Re: [PATCH] drm/dp_mst: Lower down debug info level when receive NAK

2022-03-29 Thread Harry Wentland
On 2022-03-29 04:05, Wayne Lin wrote: > [Why] > It's reasonable that we receive NAK while doing DP_REMOTE_DPCD_READ. > Downstream device might reply NAK with the reason and source should > react accordingly. > > e.g. > 1. When downstream device can't handle corresponding message in time, > it t

Re: [PATCH v9 01/23] clk: rk3568: Mark hclk_vo as critical

2022-03-29 Thread Dmitry Osipenko
On 3/28/22 18:10, Sascha Hauer wrote: > Whenever pclk_vo is enabled hclk_vo must be enabled as well. This is > described in the Reference Manual as: > > | 2.8.6 NIU Clock gating reliance > | > | A part of niu clocks have a dependence on another niu clock in order to > | sharing the internal bus. W

Re: [PATCH v7 3/9] drm/i915/gt: Optimize the migration and clear loop

2022-03-29 Thread Balasubramani Vivekanandan
On 29.03.2022 00:37, Ramalingam C wrote: > Move the static calculations out of the loops for copy and clear. > > Signed-off-by: Ramalingam C > Reviewed-by: Thomas Hellström > --- > drivers/gpu/drm/i915/gt/intel_migrate.c | 44 - > 1 file changed, 21 insertions(+), 23 del

Re: [PATCH v11 5/7] dt-bindings: display: Add Loongson display controller

2022-03-29 Thread Rob Herring
On Tue, Mar 29, 2022 at 10:02:11AM +0800, Sui Jingfeng wrote: > > On 2022/3/28 22:04, Rob Herring wrote: > > On Sat, Mar 26, 2022 at 06:04:46PM +0800, Sui Jingfeng wrote: > > > On 2022/3/24 21:26, Rob Herring wrote: > > > > On Thu, Mar 24, 2022 at 09:48:19AM +0800, Sui Jingfeng wrote: > > > > > On

Re: [PATCH v13 3/6] dt-bindings: display: Add Loongson display controller

2022-03-29 Thread Rob Herring
On Sun, Mar 27, 2022 at 9:29 PM Sui Jingfeng <15330273...@189.cn> wrote: > > Add DT bindings and simple usages for Loongson display controller > found in LS7A1000 bridge chip and LS2k1000 SoC. > > Signed-off-by: Sui Jingfeng <15330273...@189.cn> > --- > .../loongson/loongson,display-controller.yam

Re: Allow ttm_buffer_object without resource

2022-03-29 Thread Daniel Vetter
On Tue, Mar 29, 2022 at 01:02:32PM +0200, Christian König wrote: > Hi guys, > > this patch set cleans up the handling of TTM buffer objects quite a bit > by allowing to create them without allocating a ttm_resource as well. > > That's not only cleaner in general, but also a necessary prerequisite

Re: drm/amdgpu: Disable ABM when AC mode

2022-03-29 Thread Alex Deucher
On Tue, Mar 29, 2022 at 4:56 AM Ryan Lin wrote: > > Disable ABM feature when the system is running on AC mode to get > the more perfect contrast of the display. > > v2: remove "UPSTREAM" from the subject. > > Signed-off-by: Ryan Lin > > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 4 ++

Re: [PATCH v2 12/12] Documentation: iio: Document high-speed DMABUF based API

2022-03-29 Thread Daniel Vetter
On Tue, Mar 29, 2022 at 10:47:23AM +0100, Paul Cercueil wrote: > Hi Daniel, > > Le mar., mars 29 2022 at 10:54:43 +0200, Daniel Vetter a > écrit : > > On Mon, Feb 07, 2022 at 01:01:40PM +, Paul Cercueil wrote: > > > Document the new DMABUF based API. > > > > > > v2: - Explicitly state that

Re: DSI Bridge switching

2022-03-29 Thread Jagan Teki
On Thu, Mar 10, 2022 at 4:05 PM Maxime Ripard wrote: > > On Wed, Mar 09, 2022 at 06:45:10PM -0600, Adam Ford wrote: > > On Wed, Mar 9, 2022 at 1:11 PM Jagan Teki > > wrote: > > > > > > or a Hi All, > > > > > > On Thu, Oct 14, 2021 at 6:45 PM Jagan Teki > > > wrote: > > > > > > > > Hi Laurent,

Re: [PATCH v2 00/12] iio: buffer-dma: write() and new DMABUF based API

2022-03-29 Thread Daniel Vetter
On Tue, Mar 29, 2022 at 10:11:14AM +0100, Paul Cercueil wrote: > Hi Daniel, > > Le mar., mars 29 2022 at 10:33:32 +0200, Daniel Vetter a > écrit : > > On Tue, Feb 15, 2022 at 05:43:35PM +, Paul Cercueil wrote: > > > Hi Jonathan, > > > > > > Le dim., févr. 13 2022 at 18:46:16 +, Jonatha

Re: [PATCH] UPSTREAM: drm/amdgpu: Disable ABM when AC mode

2022-03-29 Thread Harry Wentland
On 2022-03-24 19:10, Ryan Lin wrote: > Disable ABM feature when the system is running on AC mode to get > the more perfect contrast of the display. > > Signed-off-by: Ryan Lin > > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 4 ++ > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c|

Re: amdgpu link problem (was Re: [git pull] drm for 5.18-rc1)

2022-03-29 Thread Alex Deucher
On Mon, Mar 28, 2022 at 9:54 PM Linus Torvalds wrote: > > I didn't notice this until now, probably because everything still > _works_, but I get a new big warning splat at bootup on my main > workstation these days as of the merge window changes. > > The full warning is attached, but it's basicall

Re: [PATCH] UPSTREAM: drm/amdgpu: Disable ABM when AC mode

2022-03-29 Thread Harry Wentland
On 2022-03-29 10:33, Harry Wentland wrote: > > > On 2022-03-24 19:10, Ryan Lin wrote: >> Disable ABM feature when the system is running on AC mode to get >> the more perfect contrast of the display. >> >> Signed-off-by: Ryan Lin >> >> --- >> drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 4

Re: [PATCH 16/23] dma-buf: add enum dma_resv_usage v3

2022-03-29 Thread Daniel Vetter
On Mon, Mar 21, 2022 at 02:58:49PM +0100, Christian König wrote: > This change adds the dma_resv_usage enum and allows us to specify why a > dma_resv object is queried for its containing fences. > > Additional to that a dma_resv_usage_rw() helper function is added to aid > retrieving the fences fo

Re: [PATCH 17/23] dma-buf: specify usage while adding fences to dma_resv obj v5

2022-03-29 Thread Daniel Vetter
On Mon, Mar 21, 2022 at 02:58:50PM +0100, Christian König wrote: > Instead of distingting between shared and exclusive fences specify > the fence usage while adding fences. > > Rework all drivers to use this interface instead and deprecate the old one. > > v2: some kerneldoc comments suggested by

Re: [PATCH 18/23] drm/amdgpu: remove dma_resv workaround

2022-03-29 Thread Daniel Vetter
On Mon, Mar 21, 2022 at 02:58:51PM +0100, Christian König wrote: > We can now add multiple writers to the dma_resv object. > > Also enable the check for not adding containers in dma_resv.c again. > > Signed-off-by: Christian König > Cc: amd-...@lists.freedesktop.org It's a bit much magic, but t

Re: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu

2022-03-29 Thread Arunpravin Paneer Selvam
On 29/03/22 4:54 pm, Christian König wrote: > Am 29.03.22 um 13:19 schrieb Arunpravin Paneer Selvam: >> [SNIP] + pages_left = node->base.num_pages; i = 0; - spin_lock(&mgr->lock); while (pages_left) { - uint32_t alignment = tbo->

Re: [PATCH] dt-bindings: display: msm: dsi: remove address/size cells

2022-03-29 Thread Rob Herring
On Tue, Mar 29, 2022 at 12:01:52PM +0530, Vinod Koul wrote: > On 28-03-22, 13:21, Rob Herring wrote: > > On Mon, Mar 28, 2022 at 12:18 PM Krzysztof Kozlowski > > wrote: > > > > > > On 28/03/2022 19:16, Vinod Koul wrote: > > > > On 28-03-22, 19:43, Dmitry Baryshkov wrote: > > > >> On Mon, 28 Mar 20

Re: [PATCH 19/23] dma-buf: add DMA_RESV_USAGE_KERNEL v2

2022-03-29 Thread Daniel Vetter
On Mon, Mar 21, 2022 at 02:58:52PM +0100, Christian König wrote: > Add an usage for kernel submissions. Waiting for those > are mandatory for dynamic DMA-bufs. > > v2: use "must" in documentation, fix whitespaces > > Signed-off-by: Christian König I think it's not super great that you smash the

Re: [PATCH 21/23] dma-buf: wait for map to complete for static attachments

2022-03-29 Thread Daniel Vetter
On Mon, Mar 21, 2022 at 02:58:54PM +0100, Christian König wrote: > We have previously done that in the individual drivers but it is > more defensive to move that into the common code. > > Dynamic attachments should wait for map operations to complete by themselves. > > Signed-off-by: Christian Kö

Re: [PATCH 22/23] drm/i915: drop bo->moving dependency

2022-03-29 Thread Daniel Vetter
On Mon, Mar 21, 2022 at 02:58:55PM +0100, Christian König wrote: > That should now be handled by the common dma_resv framework. > > Signed-off-by: Christian König > Cc: intel-...@lists.freedesktop.org Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/i915/gem/i915_gem_object.c | 29 ++-

Re: [PATCH 23/23] drm/ttm: remove bo->moving

2022-03-29 Thread Daniel Vetter
On Mon, Mar 21, 2022 at 02:58:56PM +0100, Christian König wrote: > This is now handled by the DMA-buf framework in the dma_resv obj. > > Signed-off-by: Christian König > --- > .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 13 --- > drivers/gpu/drm/amd/amdgpu/amdgpu_object.c| 7 ++-- >

Re: [PATCH 20/23] dma-buf: add DMA_RESV_USAGE_BOOKKEEP v2

2022-03-29 Thread Daniel Vetter
On Mon, Mar 21, 2022 at 02:58:53PM +0100, Christian König wrote: > Add an usage for submissions independent of implicit sync but still > interesting for memory management. This fails to mention that you're hding the amdgpu vm optimization in here. I'd split that out, but it really needs to be in t

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-29 Thread Marek Olšák
I don't know what iris does, but I would guess that the same problems as with AMD GPUs apply, making GPUs resets very fragile. Marek On Tue., Mar. 29, 2022, 08:14 Christian König, wrote: > My main question is what does the iris driver better than radeonsi when > the client doesn't support the r

Re: [PATCH v2] panel-edp: drm/panel-edp: Add AUO B133UAN01

2022-03-29 Thread Doug Anderson
Hi, On Thu, Mar 24, 2022 at 1:51 PM Doug Anderson wrote: > > Hi, > > On Thu, Mar 24, 2022 at 1:48 PM Matthias Kaehlcke wrote: > > > > Add support for the AUO B133UAN01 13.3" WUXGA panel. > > > > Signed-off-by: Matthias Kaehlcke > > --- > > > > Changes in v2: > > - autodetect and configure the p

Re: [PATCH v2] drm/imx: Fix memory leak in imx_pd_connector_get_modes

2022-03-29 Thread Philipp Zabel
On Sa, 2022-01-08 at 17:52 +0100, José Expósito wrote: > Avoid leaking the display mode variable if of_get_drm_display_mode > fails. > > Fixes: 76ecd9c9fb24 ("drm/imx: parallel-display: check return code > from of_get_drm_display_mode()") > Addresses-Coverity-ID: 1443943 ("Resource leak") > Signed

Re: [PATCH] drm/imx: imx-ldb: Check for null pointer after calling kmemdup

2022-03-29 Thread Philipp Zabel
On Mi, 2022-01-05 at 15:47 +0800, Jiasheng Jiang wrote: > As the possible failure of the allocation, kmemdup() may return NULL > pointer. > Therefore, it should be better to check the return value of kmemdup() > and return error if fails. > > Fixes: dc80d7038883 ("drm/imx-ldb: Add support to drm-b

Re: [PATCH] drm/imx: dw_hdmi-imx: Fix bailout in error cases of probe

2022-03-29 Thread Philipp Zabel
On Fr, 2022-01-28 at 17:19 +0800, Liu Ying wrote: > In dw_hdmi_imx_probe(), if error happens after dw_hdmi_probe() > returns > successfully, dw_hdmi_remove() should be called where necessary as > bailout. > > Fixes: c805ec7eb210 ("drm/imx: dw_hdmi-imx: move initialization into > probe") > Cc: Phil

Re: [PATCH] gpu: ipu-v3: Fix dev_dbg frequency output

2022-03-29 Thread Philipp Zabel
On Mo, 2022-02-07 at 16:14 +0100, Mark Jonas wrote: > From: Leo Ruan > > This commit corrects the printing of the IPU clock error percentage > if > it is between -0.1% to -0.9%. For example, if the pixel clock > requested > is 27.2 MHz but only 27.0 MHz can be achieved the deviation is -0.8%. > B

Re: [RFC PATCH] drm/amd/display: dont ignore alpha property

2022-03-29 Thread Melissa Wen
On 03/28, Melissa Wen wrote: > On 03/28, Kazlauskas, Nicholas wrote: > > [AMD Official Use Only] > > > > > -Original Message- > > > From: Melissa Wen > > > Sent: Friday, March 25, 2022 4:45 PM > > > To: amd-...@lists.freedesktop.org; Wentland, Harry > > > ; Deucher, Alexander > > > ; Siqu

Re: [RFC v4 4/8] dmabuf: heaps: export system_heap buffers with GPU cgroup charging

2022-03-29 Thread Tejun Heo
On Tue, Mar 29, 2022 at 10:42:20AM +0200, Daniel Vetter wrote: > Hm I just realized ... are the names in the groups abi? If yes then I > think we need to fix this before we merge anything. Yes. Thanks. -- tejun

Re: [PATCH] drm/imx: make static read-only array channel_offsets const

2022-03-29 Thread Philipp Zabel
On So, 2022-01-23 at 22:34 +, Colin Ian King wrote: > The static array channel_offsets is read-only so it make sense to > make > it const. > > Signed-off-by: Colin Ian King > --- >  drivers/gpu/ipu-v3/ipu-dc.c | 5 +++-- >  1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/driv

Re: [RFC v4 2/8] cgroup: gpu: Add a cgroup controller for allocator attribution of GPU memory

2022-03-29 Thread Tejun Heo
Hello, On Mon, Mar 28, 2022 at 03:59:41AM +, T.J. Mercier wrote: > The API/UAPI can be extended to set per-device/total allocation limits > in the future. This total thing kinda bothers me. Can you please provide some concrete examples of how this and per-device limits would be used? Thanks.

Re: [PATCH v5 2/4] drm: introduce drm_writeback_connector_init_with_encoder() API

2022-03-29 Thread Abhinav Kumar
Hi Liviu Gentle reminder ... Can you please help to clarify the last set of questions so that I can work on the next version? Thanks Abhinav On 3/25/2022 9:31 AM, Abhinav Kumar wrote: Hi Liviu On 3/25/2022 3:19 AM, Liviu Dudau wrote: On Thu, Mar 24, 2022 at 09:36:50AM -0700, Abhinav Kumar

Re: [PATCH v2 00/12] iio: buffer-dma: write() and new DMABUF based API

2022-03-29 Thread Paul Cercueil
Hi Daniel, Le mar., mars 29 2022 at 16:10:44 +0200, Daniel Vetter a écrit : On Tue, Mar 29, 2022 at 10:11:14AM +0100, Paul Cercueil wrote: Hi Daniel, Le mar., mars 29 2022 at 10:33:32 +0200, Daniel Vetter a écrit : > On Tue, Feb 15, 2022 at 05:43:35PM +, Paul Cercueil wrote: > >

Re: [PATCH v2 12/12] Documentation: iio: Document high-speed DMABUF based API

2022-03-29 Thread Paul Cercueil
Le mar., mars 29 2022 at 16:07:21 +0200, Daniel Vetter a écrit : On Tue, Mar 29, 2022 at 10:47:23AM +0100, Paul Cercueil wrote: Hi Daniel, Le mar., mars 29 2022 at 10:54:43 +0200, Daniel Vetter a écrit : > On Mon, Feb 07, 2022 at 01:01:40PM +, Paul Cercueil wrote: > > Document

DRM Master ignoring hotplug event during display switching (QT)

2022-03-29 Thread Jagan Teki
Hi all, I have implemented runtime display switching in the MIPI switch design where LVDS and HDMI bridges are selected with the help of runtime GPIO. Initial discussion on the same can be found here, https://www.spinics.net/lists/dri-devel/msg318524.html The implementation has been done by crea

[PATCH 00/12] drm/edid: cleanup and refactoring around validity checks

2022-03-29 Thread Jani Nikula
Another day, another batch of EDID code refactoring. Mostly the goal was to simplify drm_do_get_edid(), but trying to extract a const function for checking a single block validity lead me down a rabbit hole... BR, Jani. Cc: Ville Syrjälä Cc: Emil Velikov Jani Nikula (12): drm/edid: use str

  1   2   >