Re: [PATCH] fbdev: defio: fix the pagelist corruption

2022-03-26 Thread Paul Menzel
Dear Chuansheng, Am 17.03.22 um 06:46 schrieb Chuansheng Liu: Easily hit the below list corruption: == list_add corruption. prev->next should be next (c0ceb090), but was ec604507edc8. (prev=ec604507edc8). WARNING: CPU: 65 PID: 3959 at lib/list_debug.c:26 __list_add_valid+0x53/0x

Re: [PATCH v11 5/7] dt-bindings: display: Add Loongson display controller

2022-03-26 Thread Sui Jingfeng
On 2022/3/24 21:26, Rob Herring wrote: On Thu, Mar 24, 2022 at 09:48:19AM +0800, Sui Jingfeng wrote: On 2022/3/23 21:03, Rob Herring wrote: On Wed, Mar 23, 2022 at 11:38:55AM +0800, Sui Jingfeng wrote: On 2022/3/23 04:55, Rob Herring wrote: On Tue, Mar 22, 2022 at 10:33:45AM +0800, Sui Jing

[ PATCH ] Documentation: fixed doc-build warnings

2022-03-26 Thread kushagra765
>From 9a9918b051d5709b5e14ca8afa29f3ef644b8688 Mon Sep 17 00:00:00 2001 From: Kushagra Verma Date: Sat, 26 Mar 2022 16:43:15 +0530 Subject: [PATCH] Documentation: fixed doc-build warnings This patch fixes the following (and 2 other) doc-build warnings: 1. ./include/linux/dcache.h:308: wa

[ PATCH ] Documentation: fixed some doc-build warnings

2022-03-26 Thread kushagra765

Re: [PATCH] drm/bridge: anx7625: add missing destroy_workqueue() in anx7625_i2c_probe()

2022-03-26 Thread Hsin-Yi Wang
On Sat, Mar 26, 2022 at 3:24 PM Yang Yingliang wrote: > > Add the missing destroy_workqueue() before return from > anx7625_i2c_probe() in the error handling case. > > Fixes: adca62ec370c ("drm/bridge: anx7625: Support reading edid through aux > channel") > Signed-off-by: Yang Yingliang > --- Rev

[PATCH 0/2] remove DC_FP_* wrappers in dml files

2022-03-26 Thread Melissa Wen
>From FPU documentation, developers must not use DC_FP_START/END in dml files, but invoke it when calling FPU-associated functions (isolated in dml folder). Therefore, the first patch renames dcn10_validate_bandwidth in dml/calcs to dcn_ for generalization, declares dcn10_validate_bandwidth in dcn1

[PATCH 1/2] drm/amd/display: detach fpu operations from dcn10_validate_bandwidth in calcs

2022-03-26 Thread Melissa Wen
dcn10_validate_bandwidth is only used on dcn10 files, but is declared in dcn_calcs files. Rename dcn10_* to dcn_* in calcs, remove DC_FP_* wrapper inside DML folder and create an specific dcn10_validate_bandwidth in dcn10_resources that calls dcn_validate_bandwidth and properly wraps that FPU funct

[PATCH 2/2] drm/amd/display: remove DC_FP_* wrapper from dml folder

2022-03-26 Thread Melissa Wen
FPU documentation states that developers must not use DC_FP_START/END inside dml files, but use this macro to wrap calls to FPU functions in dc folder (outside dml folder). Therefore, this patch removes DC_FP_* wrappers from dml folder and wraps calls for these FPU operations outside dml, as requir

[PATCH] drm/amd/display: DCN3.1: don't mark as kernel-doc

2022-03-26 Thread Randy Dunlap
There is no need for this one static function to be marked as kernel-doc notation. Avoid this doc build warning: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Enable CRTC Fixes: 110d3968fe95 ("drm/amd/display: Add DCN3.1

[PATCH] drm: sti: don't use kernel-doc markers

2022-03-26 Thread Randy Dunlap
Don't mark static functions as kernel-doc. Prevents multiple kernel-doc build warnings: drivers/gpu/drm/sti/sti_hdmi.c:187: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * HDMI interrupt handler threaded drivers/gpu/drm/sti

[PATCH] virtio-gpu: fix a missing check to avoid NULL dereference

2022-03-26 Thread Xiaomeng Tong
'cache_ent' could be set NULL inside virtio_gpu_cmd_get_capset() and it will lead to a NULL dereference by a lately use of it (i.e., ptr = cache_ent->caps_cache). Fix it with a NULL check. Fixes: 62fb7a5e10962 ("virtio-gpu: add 3d/virgl support") Signed-off-by: Xiaomeng Tong --- drivers/gpu/drm/

[PATCH] gma500: fix an incorrect NULL check on list iterator

2022-03-26 Thread Xiaomeng Tong
The bug is here: return crtc; The list iterator value 'crtc' will *always* be set and non-NULL by list_for_each_entry(), so it is incorrect to assume that the iterator value will be NULL if the list is empty or no element is found. To fix the bug, return 'crtc' when found, otherwise retur

[PATCH] device: fix missing check on list iterator

2022-03-26 Thread Xiaomeng Tong
The bug is here: lo = pstate->base.domain[domain->name]; The list iterator 'pstate' will point to a bogus position containing HEAD if the list is empty or no element is found. This case should be checked before any use of the iterator, otherwise it will lead to a invalid memory access. To

[PATCH] omapdrm: fix missing check on list iterator

2022-03-26 Thread Xiaomeng Tong
The bug is here: bus_flags = connector->display_info.bus_flags; The list iterator 'connector-' will point to a bogus position containing HEAD if the list is empty or no element is found. This case must be checked before any use of the iterator, otherwise it will lead to a invalid memory ac

Re: [PATCH] device: fix missing check on list iterator

2022-03-26 Thread Guenter Roeck
On 3/26/22 22:31, Xiaomeng Tong wrote: The bug is here: lo = pstate->base.domain[domain->name]; The list iterator 'pstate' will point to a bogus position containing HEAD if the list is empty or no element is found. This case should be checked before any use of the iterator, otherwise it

[PATCH] stm: ltdc: fix two incorrect NULL checks on list iterator

2022-03-26 Thread Xiaomeng Tong
The two bugs are here: if (encoder) { if (bridge && bridge->timings) The list iterator value 'encoder/bridge' will *always* be set and non-NULL by drm_for_each_encoder()/list_for_each_entry(), so it is incorrect to assume that the iterator value will be NULL if the list is empty or

[PATCH] tilcdc: tilcdc_external: fix an incorrect NULL check on list iterator

2022-03-26 Thread Xiaomeng Tong
The bug is here: if (!encoder) { The list iterator value 'encoder' will *always* be set and non-NULL by list_for_each_entry(), so it is incorrect to assume that the iterator value will be NULL if the list is empty or no element is found. To fix the bug, use a new variable 'iter' as the li